Github user yonglyhoo commented on the issue:
https://github.com/apache/spark/pull/16441
Great! Thanks Nick!Yong
Sent from Yahoo Mail for iPhone
On Friday, July 14, 2017, 10:59 PM, Nick Pentreath
wrote:
Should be in 2.2.0
On Sat, 15 Jul 2017 at
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/16441
Should be in 2.2.0
On Sat, 15 Jul 2017 at 07:54, yonglyhoo wrote:
> In which release this fix is going to be available? Thanks!
>
> â
> You are receiving this because you co
Github user yonglyhoo commented on the issue:
https://github.com/apache/spark/pull/16441
In which release this fix is going to be available? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18618
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18618
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79631/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18618
**[Test build #79631 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79631/testReport)**
for PR 18618 at commit
[`eaa910d`](https://github.com/apache/spark/commit/e
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18618#discussion_r127576287
--- Diff: python/pyspark/sql/types.py ---
@@ -562,6 +562,16 @@ def jsonValue(self):
def fromJson(cls, json):
return StructType([Str
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18618
**[Test build #79631 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79631/testReport)**
for PR 18618 at commit
[`eaa910d`](https://github.com/apache/spark/commit/ea
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18618
Either way is fine to me. Let me update this to return a list. I was just
thinking struct/row are a tuple-like and the output for this could be as so.
---
If your project is set up for it, you
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/17980
If new test cases works for existing orc component, how about updating test
cases at first?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18571
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18571
Thanks! Merging to master/2.2/2.1/2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18640
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79627/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18640
**[Test build #79627 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79627/testReport)**
for PR 18640 at commit
[`0f29656`](https://github.com/apache/spark/commit/0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18633
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18633
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79626/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18633
**[Test build #79626 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79626/testReport)**
for PR 18633 at commit
[`9a4f012`](https://github.com/apache/spark/commit/9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18639
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79624/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18639
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18639
**[Test build #79624 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79624/testReport)**
for PR 18639 at commit
[`85029e0`](https://github.com/apache/spark/commit/8
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18281
**[Test build #79630 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79630/testReport)**
for PR 18281 at commit
[`a95a8af`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18281
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79630/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18281
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18281
**[Test build #79630 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79630/testReport)**
for PR 18281 at commit
[`a95a8af`](https://github.com/apache/spark/commit/a9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79621/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18637
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18637
**[Test build #79621 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79621/testReport)**
for PR 18637 at commit
[`4b20f82`](https://github.com/apache/spark/commit/4
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/18487
`maxReqsInFlight` and `maxBytesInFlight` is hard to control the # of blocks
in a single request. When # of map is very high, this change can alleviate the
pressure of shuffle server.
@dhruve
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18571
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18633#discussion_r127565024
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
---
@@ -42,7 +42,7 @@ import org.apache.spark.internal.
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/16571
This PR is very similar to my early PR. Is that right? @jkbradley #14950
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r127562278
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
@@ -66,4 +75,50 @@ object DriverWrapper {
System.exit(-1
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r127561962
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -473,6 +474,12 @@ object SparkSubmit extends CommandLineUtils {
O
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r127563323
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
@@ -66,4 +75,50 @@ object DriverWrapper {
System.exit(-1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18616
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18616
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79629/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18616
**[Test build #79629 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79629/testReport)**
for PR 18616 at commit
[`545ae9a`](https://github.com/apache/spark/commit/5
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18633#discussion_r127561224
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HadoopFSDelegationTokenProvider.scala
---
@@ -45,11 +45,11 @@ private[deploy] class
HadoopFS
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18633#discussion_r127562035
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
---
@@ -42,7 +42,7 @@ import org.apache.spark.internal.Log
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18628
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79628/
Test PASSed.
---
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18630
Are you trying to support `--packages` in standalone cluster?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18628
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18628
**[Test build #79628 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79628/testReport)**
for PR 18628 at commit
[`787e72c`](https://github.com/apache/spark/commit/7
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18607
**[Test build #3842 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3842/testReport)**
for PR 18607 at commit
[`6d6e2d7`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18616
**[Test build #79629 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79629/testReport)**
for PR 18616 at commit
[`545ae9a`](https://github.com/apache/spark/commit/54
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18616
Thanks @vanzin for your review, I will update it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18428
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79623/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18428
**[Test build #79623 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79623/testReport)**
for PR 18428 at commit
[`6a7162d`](https://github.com/apache/spark/commit/6
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18628
**[Test build #79628 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79628/testReport)**
for PR 18628 at commit
[`787e72c`](https://github.com/apache/spark/commit/78
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18428
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18513#discussion_r127558429
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18513#discussion_r127554746
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18513#discussion_r127555147
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18513#discussion_r127498459
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18513#discussion_r127557871
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/FeatureHasherSuite.scala ---
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18513#discussion_r127491688
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/FeatureHasherSuite.scala ---
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the Apache Software Fou
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18428
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79622/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18428
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18428
**[Test build #79622 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79622/testReport)**
for PR 18428 at commit
[`a6bd197`](https://github.com/apache/spark/commit/a
Github user ajaysaini725 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127558107
--- Diff: python/pyspark/ml/tests.py ---
@@ -1229,11 +1229,30 @@ def test_output_columns(self):
(2.0, Vect
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18640
**[Test build #79627 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79627/testReport)**
for PR 18640 at commit
[`0f29656`](https://github.com/apache/spark/commit/0f
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18640
This aims to reduce the review scope for #17980 .
cc @kiszk .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user ajaysaini725 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127557890
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,50 @@ class OneVsRestSuite extends SparkFunSu
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/18640
[SPARK-21422][BUILD] Depend on Apache ORC 1.4.0
## What changes were proposed in this pull request?
Like Parquet, this PR aims to depend on the latest Apache ORC 1.4 for
Apache Spark
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18616#discussion_r127556964
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -438,6 +441,24 @@ private[spark] class Applicati
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18616#discussion_r127557008
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -438,6 +441,24 @@ private[spark] class Applicati
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17980
Hi, @kiszk . I will start with `Adding Apache ORC dependency (pom and
dependency changes)` in
[SPARK-21422](https://issues.apache.org/jira/browse/SPARK-21422) first.
---
If your project
Github user zasdfgbnm commented on a diff in the pull request:
https://github.com/apache/spark/pull/18444#discussion_r127555013
--- Diff: core/src/main/scala/org/apache/spark/api/python/SerDeUtil.scala
---
@@ -57,11 +57,11 @@ private[spark] object SerDeUtil extends Logging {
Github user zasdfgbnm commented on the issue:
https://github.com/apache/spark/pull/18444
I updated my code according to @HyukjinKwon's suggestion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18633
**[Test build #79626 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79626/testReport)**
for PR 18633 at commit
[`9a4f012`](https://github.com/apache/spark/commit/9a
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18633
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18616
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79625/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79619/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18616
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18637
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18616
**[Test build #79625 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79625/testReport)**
for PR 18616 at commit
[`a9e1a21`](https://github.com/apache/spark/commit/a
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18638
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/18513
Just to clarify:
* If I want to treat a column as categorical that is represented by
integers, I'd have to map those integers to strings, right? I believe that's
one of your bullets above.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18444
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79618/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18637
**[Test build #79619 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79619/testReport)**
for PR 18637 at commit
[`4b20f82`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18444
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18444
**[Test build #79618 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79618/testReport)**
for PR 18444 at commit
[`6c49a48`](https://github.com/apache/spark/commit/6
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/18638
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127552088
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,50 @@ class OneVsRestSuite extends SparkFunSuite
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18370
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127552778
--- Diff: python/pyspark/ml/classification.py ---
@@ -1511,27 +1512,47 @@ class OneVsRest(Estimator, OneVsRestParams,
MLReadable, MLWritable):
..
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127552478
--- Diff: python/pyspark/ml/classification.py ---
@@ -1511,27 +1512,47 @@ class OneVsRest(Estimator, OneVsRestParams,
MLReadable, MLWritable):
..
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127552072
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,50 @@ class OneVsRestSuite extends SparkFunSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127552824
--- Diff: python/pyspark/ml/classification.py ---
@@ -1511,27 +1512,47 @@ class OneVsRest(Estimator, OneVsRestParams,
MLReadable, MLWritable):
..
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127550679
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127553451
--- Diff: python/pyspark/ml/tests.py ---
@@ -1229,11 +1229,30 @@ def test_output_columns(self):
(2.0, Vectors
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127551356
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,8 +326,11 @@ final class OneVsRest @Since("1.4.0") (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127551019
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127550735
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/HasParallelism.scala ---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r127553419
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,50 @@ class OneVsRestSuite extends SparkFunSuite
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18555
Checking whether the values are set or not is not enough. We need to check
whether these parameters are effective or not. That means, we need to check the
behaviors of Spark
---
If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18547
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18547
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79617/
Test PASSed.
---
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18370
> it feels like we shouldn't ship the hadoop conf dir but that might break
some people
Yeah, we rely on that to ship other configs (like Hive and HBase) with the
application without the use
1 - 100 of 242 matches
Mail list logo