Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18875#discussion_r138228111
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -193,14 +223,35 @@ private[sql] class JacksonGen
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138225592
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138201871
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138207519
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138193555
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138225438
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138198506
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138207456
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138195259
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138194732
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138204793
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,292 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138189593
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
---
@@ -72,10 +72,15 @@ public UnsafeSorterSpillRead
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138189733
--- Diff:
core/src/test/java/org/apache/spark/io/GenericFileInputStreamSuite.java ---
@@ -50,17 +52,16 @@ public void tearDown() {
inputFile.delete
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138200321
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,317 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138194101
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138201264
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138188910
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
---
@@ -72,10 +72,15 @@ public UnsafeSorterSpillRead
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138195292
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138200201
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138194341
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138208239
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18317#discussion_r138198579
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -0,0 +1,315 @@
+/*
+ * Licensed under the Apache License, Version
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19136#discussion_r138224219
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19136#discussion_r138224082
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138220213
--- Diff: python/pyspark/ml/tests.py ---
@@ -1473,11 +1473,59 @@ def test_logistic_regression_summary(self):
self.assertTrue(isinstance(s.fMeasur
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138219915
--- Diff: python/pyspark/ml/tests.py ---
@@ -1473,11 +1473,59 @@ def test_logistic_regression_summary(self):
self.assertTrue(isinstance(s.fMeasur
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138220005
--- Diff: python/pyspark/ml/tests.py ---
@@ -1473,11 +1473,59 @@ def test_logistic_regression_summary(self):
self.assertTrue(isinstance(s.fMeasur
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138220297
--- Diff: python/pyspark/ml/classification.py ---
@@ -528,9 +528,11 @@ def summary(self):
trained on the training set. An exception is thrown if
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19188#discussion_r138221684
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -113,12 +114,39 @@ object TPCDSQueryBenchmark {
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/18592#discussion_r138220942
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -99,6 +95,20 @@ object TPCDSQueryBenchmark {
Github user devaraj-kavali commented on a diff in the pull request:
https://github.com/apache/spark/pull/19141#discussion_r138219530
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -565,7 +565,6 @@ private[spark] class Client(
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18945
Hey @logannc, have you had some time to work on this? I want to fix this
issue asap. Ortherwise, would anyone here be interested in submitimg another PR
for the another approach?
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19188#discussion_r138217212
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -113,12 +114,39 @@ object TPCDSQueryBenchmar
Github user sethah commented on the issue:
https://github.com/apache/spark/pull/19106
I'm confused how this issue was discovered in the first place. Did someone
actually train an RF/DT and receive all zero probabilities? If so, shouldn't
there be a unit test that recreates that scenar
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18592#discussion_r138217049
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -99,6 +95,20 @@ object TPCDSQueryBenchmark {
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19147#discussion_r138215300
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/VectorizedPythonRunner.scala
---
@@ -0,0 +1,329 @@
+/*
+ * Licensed to
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19107
@WeichenXu123 I just commented on
https://issues.apache.org/jira/browse/SPARK-18608 to clarify our efforts here.
Can you please either retarget this for SPARK-18608 and update it, or ask
@zhengr
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r138191841
--- Diff: core/src/main/scala/org/apache/spark/deploy/history/config.scala
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942598
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -229,10 +254,22 @@ private[history] class FsHistoryProvider(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942907
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -316,25 +353,21 @@ private[history] class FsHistoryProvider(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137940658
--- Diff: core/src/main/scala/org/apache/spark/deploy/history/config.scala
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942505
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -742,53 +698,146 @@ private[history] object FsHistoryProvide
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137941077
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -117,17 +122,37 @@ private[history] class FsHistoryProvider(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137940633
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -117,17 +122,37 @@ private[history] class FsHistoryProvider(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137941159
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -742,53 +698,146 @@ private[history] object FsHistoryProvide
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942178
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -742,53 +698,146 @@ private[history] object FsHistoryProvide
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942487
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -422,208 +455,101 @@ private[history] class FsHistoryProvide
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942186
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -742,53 +698,146 @@ private[history] object FsHistoryProvide
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942548
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -229,10 +254,22 @@ private[history] class FsHistoryProvider(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r137942697
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -301,9 +334,13 @@ private[history] class FsHistoryProvider(c
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19118
You don't have to use `saveAsHadoopFile`, just call `saveAsHadoopDataset`
directly?
---
-
To unsubscribe, e-mail: reviews-un
Github user erenavsarogullari commented on the issue:
https://github.com/apache/spark/pull/15326
Hi @kayousterhout,
Many thanks again for your review.
Patch is ready to re-review.
---
-
To unsubscribe, e-mail
Github user original-brownbear commented on the issue:
https://github.com/apache/spark/pull/19182
@srowen looks like we're all green :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additiona
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81647/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #81647 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81647/testReport)**
for PR 18982 at commit
[`088ee52`](https://github.com/apache/spark/commit/0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19110
Other than that 1 item, this looks ready
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comm
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19110#discussion_r138180599
--- Diff: python/pyspark/ml/param/shared.py ---
@@ -608,6 +608,30 @@ def getAggregationDepth(self):
return self.getOrDefault(self.aggregationD
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19194
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81645/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19194
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19194
**[Test build #81645 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81645/testReport)**
for PR 19194 at commit
[`4281151`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19193
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19193
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81644/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19193
**[Test build #81644 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81644/testReport)**
for PR 19193 at commit
[`c14aa2f`](https://github.com/apache/spark/commit/c
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/19130#discussion_r138154503
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -367,6 +368,52 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18875
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81643/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18875
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18875
**[Test build #81643 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81643/testReport)**
for PR 18875 at commit
[`0f2dd18`](https://github.com/apache/spark/commit/0
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/19130#discussion_r138151499
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -367,6 +368,52 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138151063
--- Diff: python/pyspark/ml/tuning.py ---
@@ -193,7 +194,8 @@ class CrossValidator(Estimator, ValidatorParams,
MLReadable, MLWritable):
>>> lr
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18875
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81641/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18875
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18875
**[Test build #81641 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81641/testReport)**
for PR 18875 at commit
[`069708c`](https://github.com/apache/spark/commit/0
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138144992
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -152,6 +152,8 @@ def get$Name(self):
("varianceCol", "column name for th
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138144361
--- Diff: python/pyspark/ml/tuning.py ---
@@ -255,18 +257,27 @@ def _fit(self, dataset):
randCol = self.uid + "_rand"
df = data
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/19122#discussion_r138142834
--- Diff: python/pyspark/ml/tuning.py ---
@@ -208,23 +210,23 @@ class CrossValidator(Estimator, ValidatorParams,
MLReadable, MLWritable):
Github user smurching commented on the issue:
https://github.com/apache/spark/pull/19186
Note: This PR follows up on the work/discussions in
[https://github.com/apache/spark/pull/17014](https://github.com/apache/spark/pull/17014)
---
-
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138139729
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -300,20 +300,23 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138136774
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -483,24 +488,17 @@ class LogisticRegression @Since("1.2
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138137893
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -163,9 +165,7 @@ final class OneVsRestModel private[ml] (
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138139091
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -82,7 +82,8 @@ private[shared] object SharedParamsCodeGe
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138140113
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/IsotonicRegression.scala ---
@@ -165,8 +170,7 @@ class IsotonicRegression @Since("1.5.0")
(
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138139539
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -444,13 +444,13 @@ class LogisticRegressionWithLBFGS
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19134
OK by me, if it's all on-purpose. So, am I right that all of the Pyspark
Kafka integration is effectively deprecated as of this change, because it
depends on now-deprecated 0.8 support? just want to
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/19134
There's already a jira about why 0.10 doesn't have python support,
https://issues-test.apache.org/jira/browse/SPARK-16534
---
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19106#discussion_r138130375
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -245,6 +245,10 @@ private[ml] object ProbabilisticCla
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19106#discussion_r138135778
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -245,6 +245,10 @@ private[ml] object ProbabilisticCla
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19195
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19195
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81646/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19195
**[Test build #81646 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81646/testReport)**
for PR 19195 at commit
[`99a4394`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #81647 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81647/testReport)**
for PR 18982 at commit
[`088ee52`](https://github.com/apache/spark/commit/08
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user hhbyyh commented on the issue:
https://github.com/apache/spark/pull/16158
Update:
To support pipeline estimator, change the tuning summary column name to
include full param reference:
**
for PR 19195 at commit
[`99a4394`](https://github.com/apache/spark/commit/99
Github user smurching commented on the issue:
https://github.com/apache/spark/pull/19107
@jkbradley would you be able to give this a look? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Fo
GitHub user sarutak opened a pull request:
https://github.com/apache/spark/pull/19195
[DOCS] Fix unreachable links in the document
## What changes were proposed in this pull request?
Recently, I found two unreachable links in the document and fixed them.
Because of small
Github user smurching commented on the issue:
https://github.com/apache/spark/pull/19106
This looks good to me! @srowen would you be able to give it another look?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spa
101 - 200 of 385 matches
Mail list logo
