Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22263#discussion_r226184242
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -288,6 +297,65 @@ class CachedTableSuite extends QueryTest with
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22171
Hm, actually I thought this makes sense tho.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additiona
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22295
Looks close to go.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22295#discussion_r226184011
--- Diff: python/pyspark/sql/functions.py ---
@@ -2713,6 +2713,25 @@ def from_csv(col, schema, options={}):
return Column(jc)
+@
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22677
@shivusondur . It seems that your PR almost finished. Please update JIRA
title and description together.
https://issues.apache.org/jira/browse/SPARK-25683
---
--
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22761
Of course!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@s
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22677#discussion_r226183134
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ---
@@ -169,7 +169,8 @@ private class AsyncEventQueue(
v
Github user sandeep-katta commented on the issue:
https://github.com/apache/spark/pull/22466
@cloud-fan @gatorsmile all the testcases are passed and review comments are
addressed,can you help me to merge this PR please
---
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22263#discussion_r226182333
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -288,6 +297,65 @@ class CachedTableSuite extends QueryTest with
SQLTes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22677
**[Test build #97516 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97516/testReport)**
for PR 22677 at commit
[`3e3ad24`](https://github.com/apache/spark/commit/3e
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22677
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: rev
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22756
@mgaido91 . If you don't mind, could you split this PR into two PRs? One is
adding `deprecation` annotation only. The other is adding new API and updating
all examples?
---
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22756#discussion_r226181011
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaBisectingKMeansExample.java
---
@@ -50,9 +51,14 @@ public static void main(String[]
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22761
I would merge https://github.com/apache/spark/pull/22746 to 2.4 release,
since the doc changes are not restricted by our RC. Maybe we can hold this PR?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22743
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4074/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22743
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22743
**[Test build #97515 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97515/testReport)**
for PR 22743 at commit
[`c32a2a9`](https://github.com/apache/spark/commit/c3
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22755
cc @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/22295#discussion_r226178191
--- Diff: python/pyspark/sql/tests.py ---
@@ -3863,6 +3863,145 @@ def test_jvm_default_session_already_set(self):
spark.stop()
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/22295#discussion_r226178127
--- Diff: python/pyspark/sql/tests.py ---
@@ -3863,6 +3863,145 @@ def test_jvm_default_session_already_set(self):
spark.stop()
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/22295#discussion_r226178054
--- Diff: python/pyspark/sql/functions.py ---
@@ -2713,6 +2713,25 @@ def from_csv(col, schema, options={}):
return Column(jc)
+@si
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22756#discussion_r226177653
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
@@ -125,8 +125,13 @@ class BisectingKMeansModel private[ml] (
Github user vinodkc closed the pull request at:
https://github.com/apache/spark/pull/20134
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vinodkc closed the pull request at:
https://github.com/apache/spark/pull/20947
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vinodkc closed the pull request at:
https://github.com/apache/spark/pull/22171
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/22755
cc @gatorsmile, @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97511/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97511 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97511/testReport)**
for PR 22309 at commit
[`c14b5f9`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22263
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22263
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97512/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22263
**[Test build #97512 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97512/testReport)**
for PR 22263 at commit
[`89502dc`](https://github.com/apache/spark/commit/8
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21990
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22295#discussion_r226166020
--- Diff: python/pyspark/sql/tests.py ---
@@ -3863,6 +3863,145 @@ def test_jvm_default_session_already_set(self):
spark.stop()
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22295#discussion_r226166057
--- Diff: python/pyspark/sql/tests.py ---
@@ -3863,6 +3863,145 @@ def test_jvm_default_session_already_set(self):
spark.stop()
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22295#discussion_r226165866
--- Diff: python/pyspark/sql/functions.py ---
@@ -2713,6 +2713,25 @@ def from_csv(col, schema, options={}):
return Column(jc)
+@
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21990
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21990
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22675
Looks cool otherwise!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: rev
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22675#discussion_r226165068
--- Diff: docs/ml-datasource.md ---
@@ -0,0 +1,90 @@
+---
+layout: global
+title: Data sources
+displayTitle: Data sources
+---
+
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22675#discussion_r226164867
--- Diff: docs/ml-datasource.md ---
@@ -0,0 +1,90 @@
+---
+layout: global
+title: Data sources
+displayTitle: Data sources
+---
+
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22675#discussion_r226164813
--- Diff: docs/ml-datasource.md ---
@@ -0,0 +1,90 @@
+---
+layout: global
+title: Data sources
+displayTitle: Data sources
--- End di
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22675#discussion_r226164476
--- Diff: docs/ml-datasource.md ---
@@ -0,0 +1,90 @@
+---
+layout: global
+title: Data sources
+displayTitle: Data sources
+---
+
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22675#discussion_r226164264
--- Diff: docs/ml-datasource.md ---
@@ -0,0 +1,90 @@
+---
+layout: global
+title: Data sources
+displayTitle: Data sources
+---
+
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22675#discussion_r226163959
--- Diff: docs/ml-datasource.md ---
@@ -0,0 +1,49 @@
+---
+layout: global
+title: Data sources
+displayTitle: Data sources
+---
+
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22675#discussion_r226163638
--- Diff: docs/ml-datasource.md ---
@@ -0,0 +1,49 @@
+---
+layout: global
+title: Data sources
+displayTitle: Data sources
+---
+
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22675
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22675
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97514/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22675
**[Test build #97514 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97514/testReport)**
for PR 22675 at commit
[`ba0d888`](https://github.com/apache/spark/commit/b
Github user shivusondur commented on the issue:
https://github.com/apache/spark/pull/22677
cc @vanzin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22675
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4073/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22675
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22675#discussion_r226161636
--- Diff: docs/ml-datasource.md ---
@@ -0,0 +1,49 @@
+---
+layout: global
+title: Data sources
+displayTitle: Data sources
+---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22675
**[Test build #97514 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97514/testReport)**
for PR 22675 at commit
[`ba0d888`](https://github.com/apache/spark/commit/ba
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22675#discussion_r226161623
--- Diff: docs/ml-datasource.md ---
@@ -0,0 +1,49 @@
+---
+layout: global
+title: Data sources
+displayTitle: Data sources
+---
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22675#discussion_r226161557
--- Diff: docs/ml-datasource.md ---
@@ -0,0 +1,49 @@
+---
+layout: global
+title: Data sources
+displayTitle: Data sources
+---
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226156109
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -73,19 +73,21 @@ case class UserDefinedFunction prot
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226156536
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -393,4 +393,30 @@ class UDFSuite extends QueryTest with SharedSQLContext
{
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226156400
--- Diff: docs/sql-programming-guide.md ---
@@ -1978,6 +1978,7 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
- Since
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226155205
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -393,4 +393,30 @@ class UDFSuite extends QueryTest with SharedSQLContext
{
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226155153
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -393,4 +393,30 @@ class UDFSuite extends QueryTest with SharedSQLContext
{
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21990
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21990
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97510/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21990
**[Test build #97510 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97510/testReport)**
for PR 21990 at commit
[`3629c78`](https://github.com/apache/spark/commit/3
Github user rezasafi commented on the issue:
https://github.com/apache/spark/pull/22612
I would appreciate if there is any other concerns with this patch @squito
@edwinalu @mccheah @dhruve
---
-
To unsubscribe, e-m
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22758#discussion_r226151421
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -193,6 +193,16 @@ private[hive] class HiveMetastoreCatalog(s
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22758#discussion_r226150341
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
@@ -1051,7 +1051,8 @@ class StatisticsSuite extends
StatisticsColle
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22761
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22761
**[Test build #97513 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97513/testReport)**
for PR 22761 at commit
[`e1d6a0a`](https://github.com/apache/spark/commit/e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22761
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97513/
Test PASSed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22745#discussion_r226149644
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -509,3 +509,24 @@ case class UnresolvedOrdinal(ordin
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22503#discussion_r226149299
--- Diff: sql/core/src/test/resources/test-data/cars-crlf.csv ---
@@ -0,0 +1,7 @@
+
+year,make,model,comment,blank
+"2012","Tesla","S","No co
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22309
what's still missing to support top level value class?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For a
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r226149168
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -632,13 +667,17 @@ object ScalaReflection extends ScalaR
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r226148985
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -376,6 +386,23 @@ object ScalaReflection extends ScalaRe
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r226148892
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -376,6 +386,23 @@ object ScalaReflection extends ScalaRe
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22761
**[Test build #97513 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97513/testReport)**
for PR 22761 at commit
[`e1d6a0a`](https://github.com/apache/spark/commit/e1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22761
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22761
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4072/
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/22761
[MINOR][DOC] Spacing items in migration guide for readability and
consistency
## What changes were proposed in this pull request?
Currently, migration guide has no space between each i
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21990
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apach
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22263
**[Test build #97512 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97512/testReport)**
for PR 22263 at commit
[`89502dc`](https://github.com/apache/spark/commit/89
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22263
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4071/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22263
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226145444
--- Diff: docs/sql-programming-guide.md ---
@@ -1978,6 +1978,7 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
- Sin
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226145051
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -393,4 +393,30 @@ class UDFSuite extends QueryTest with SharedSQLContext
{
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226145150
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -393,4 +393,30 @@ class UDFSuite extends QueryTest with SharedSQLContext
{
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226144670
--- Diff: docs/sql-programming-guide.md ---
@@ -1951,7 +1951,7 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
Github user mt40 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r226144119
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -125,6 +125,17 @@ object ScalaReflection extends ScalaReflect
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97511 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97511/testReport)**
for PR 22309 at commit
[`c14b5f9`](https://github.com/apache/spark/commit/c1
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226143221
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -393,4 +393,30 @@ class UDFSuite extends QueryTest with SharedSQLContext
{
Github user mt40 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r226142977
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -376,6 +387,23 @@ object ScalaReflection extends ScalaReflect
Github user mt40 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r226142827
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -376,6 +387,23 @@ object ScalaReflection extends ScalaReflect
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97508/
Test PASSed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226142651
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -73,19 +73,21 @@ case class UserDefinedFunction prote
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22732
**[Test build #97508 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97508/testReport)**
for PR 22732 at commit
[`968ed26`](https://github.com/apache/spark/commit/9
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226141983
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +42,29 @@ import org.apache.spark.sql.types.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22756#discussion_r226141315
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
@@ -125,8 +125,13 @@ class BisectingKMeansModel private[ml] (
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22612
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
1 - 100 of 364 matches
Mail list logo