[GitHub] [spark] AmplabJenkins commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523591650 Test PASSed. Refer to this link for bui

[GitHub] [spark] AmplabJenkins commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523591646 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins commented on issue #25523: [SPARK-28789][DOC] Document ALTER DATABASE command

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25523: [SPARK-28789][DOC] Document ALTER DATABASE command URL: https://github.com/apache/spark/pull/25523#issuecomment-523591748 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/je

[GitHub] [spark] dongjoon-hyun commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive

2019-08-21 Thread GitBox
dongjoon-hyun commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523590664 Retest this please. -

[GitHub] [spark] srowen commented on issue #25529: [SPARK-28804][DOC] Document DESCRIBE QUERY in SQL Reference

2019-08-21 Thread GitBox
srowen commented on issue #25529: [SPARK-28804][DOC] Document DESCRIBE QUERY in SQL Reference URL: https://github.com/apache/spark/pull/25529#issuecomment-523590525 PS you might look at the other similar PRs to add these docs to try to harmonize the style and format a little bit. They're p

[GitHub] [spark] srowen commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
srowen commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523590560 PS you might look at the other similar PRs to add these docs to try to harmonize the style and format a little b

[GitHub] [spark] srowen commented on a change in pull request #25533: [SPARK-28798][DOC][SQL]Document DROP TABLE/VIEW statement in SQL Reference.

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25533: [SPARK-28798][DOC][SQL]Document DROP TABLE/VIEW statement in SQL Reference. URL: https://github.com/apache/spark/pull/25533#discussion_r316334080 ## File path: docs/sql-ref-syntax-ddl-drop-table.md ## @@ -19,4 +19,20 @@

[GitHub] [spark] srowen commented on a change in pull request #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference URL: https://github.com/apache/spark/pull/25522#discussion_r31639 ## File path: docs/sql-ref-syntax-dml-load.md ## @@ -19,4 +19,37 @@ license: |

[GitHub] [spark] srowen commented on a change in pull request #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference URL: https://github.com/apache/spark/pull/25522#discussion_r316333007 ## File path: docs/sql-ref-syntax-dml-load.md ## @@ -19,4 +19,37 @@ license: |

[GitHub] [spark] SparkQA commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by H

2019-08-21 Thread GitBox
SparkQA commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523589419 **[Test build #109509 has start

[GitHub] [spark] AmplabJenkins removed a comment on issue #25542: [SPARK-28840][SQL][test-hadoop3.2] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which i

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25542: [SPARK-28840][SQL][test-hadoop3.2] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523588693 Test PASSed. Re

[GitHub] [spark] AmplabJenkins removed a comment on issue #25542: [SPARK-28840][SQL][test-hadoop3.2] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which i

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25542: [SPARK-28840][SQL][test-hadoop3.2] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523588687 Merged build finis

[GitHub] [spark] srowen commented on a change in pull request #25524: [SPARK-28788][DOC][SQL]Document ANALYZE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25524: [SPARK-28788][DOC][SQL]Document ANALYZE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25524#discussion_r316332115 ## File path: docs/sql-ref-syntax-aux-analyze-table.md ## @@ -19,4 +19,45 @@

[GitHub] [spark] AmplabJenkins commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is create

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523588687 Merged build finished. Tes

[GitHub] [spark] AmplabJenkins commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is create

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523588693 Test PASSed. Refer to t

[GitHub] [spark] srowen commented on a change in pull request #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#discussion_r316331815 ## File path: docs/sql-ref-syntax-aux-cache-cache-table.md ## @@ -19,4 +19,34 @

[GitHub] [spark] srowen commented on a change in pull request #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#discussion_r316330931 ## File path: docs/sql-ref-syntax-aux-cache-uncache-table.md ## @@ -19,4 +19,

[GitHub] [spark] huaxingao edited a comment on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-21 Thread GitBox
huaxingao edited a comment on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference URL: https://github.com/apache/spark/pull/25525#issuecomment-523557596 ![image](https://user-images.githubusercontent.com/13592258/63457150-46031b00-c405-11e9-8971-4b4d65aa9f1d

[GitHub] [spark] dongjoon-hyun commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive

2019-08-21 Thread GitBox
dongjoon-hyun commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523587514 ok to test --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hiv

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523496438 Can one of the admins verify this

[GitHub] [spark] srowen commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true

2019-08-21 Thread GitBox
srowen commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true URL: https://github.com/apache/spark/pull/25520#issuecomment-523587258 I don't have a strong opinion on this, and probably agree it's better to not fail these by default, is it really j

[GitHub] [spark] dilipbiswal commented on a change in pull request #25529: [SPARK-28804][DOC] Document DESCRIBE QUERY in SQL Reference

2019-08-21 Thread GitBox
dilipbiswal commented on a change in pull request #25529: [SPARK-28804][DOC] Document DESCRIBE QUERY in SQL Reference URL: https://github.com/apache/spark/pull/25529#discussion_r316329495 ## File path: docs/sql-ref-syntax-aux-describe-query.md ## @@ -19,4 +19,34 @@ license

[GitHub] [spark] srowen commented on a change in pull request #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#discussion_r316329054 ## File path: docs/sql-ref-syntax-aux-cache-clear-cache.md ## @@ -19,4 +19,16 @

[GitHub] [spark] srowen commented on a change in pull request #25528: [SPARK-28802][DOC][SQL]Document DESCRIBE DATABASE statement in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25528: [SPARK-28802][DOC][SQL]Document DESCRIBE DATABASE statement in SQL Reference URL: https://github.com/apache/spark/pull/25528#discussion_r316328393 ## File path: docs/sql-ref-syntax-aux-describe-database.md ## @@ -18,5 +1

[GitHub] [spark] srowen commented on a change in pull request #25528: [SPARK-28802][DOC][SQL]Document DESCRIBE DATABASE statement in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25528: [SPARK-28802][DOC][SQL]Document DESCRIBE DATABASE statement in SQL Reference URL: https://github.com/apache/spark/pull/25528#discussion_r316328605 ## File path: docs/sql-ref-syntax-aux-describe-database.md ## @@ -18,5 +1

[GitHub] [spark] srowen commented on a change in pull request #25528: [SPARK-28802][DOC][SQL]Document DESCRIBE DATABASE statement in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25528: [SPARK-28802][DOC][SQL]Document DESCRIBE DATABASE statement in SQL Reference URL: https://github.com/apache/spark/pull/25528#discussion_r316328308 ## File path: docs/sql-ref-syntax-aux-describe-database.md ## @@ -18,5 +1

[GitHub] [spark] srowen commented on a change in pull request #25527: [SPARK-28803][DOC] Document DESCRIBE TABLE in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25527: [SPARK-28803][DOC] Document DESCRIBE TABLE in SQL Reference URL: https://github.com/apache/spark/pull/25527#discussion_r316327622 ## File path: docs/sql-ref-syntax-aux-describe-table.md ## @@ -18,5 +18,53 @@ license: |

[GitHub] [spark] AmplabJenkins commented on issue #25531: [SPARK-28806][DOC] Document SHOW COLUMNS in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25531: [SPARK-28806][DOC] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-523585112 Merged build finished. Test PASSed. This is an automate

[GitHub] [spark] AmplabJenkins removed a comment on issue #25531: [SPARK-28806][DOC] Document SHOW COLUMNS in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25531: [SPARK-28806][DOC] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-523585119 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.b

[GitHub] [spark] srowen commented on a change in pull request #25527: [SPARK-28803][DOC] Document DESCRIBE TABLE in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25527: [SPARK-28803][DOC] Document DESCRIBE TABLE in SQL Reference URL: https://github.com/apache/spark/pull/25527#discussion_r316327917 ## File path: docs/sql-ref-syntax-aux-describe-table.md ## @@ -18,5 +18,53 @@ license: |

[GitHub] [spark] SparkQA removed a comment on issue #25531: [SPARK-28806][DOC] Document SHOW COLUMNS in SQL Reference

2019-08-21 Thread GitBox
SparkQA removed a comment on issue #25531: [SPARK-28806][DOC] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-523578840 **[Test build #109508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109508/testRepor

[GitHub] [spark] AmplabJenkins commented on issue #25531: [SPARK-28806][DOC] Document SHOW COLUMNS in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25531: [SPARK-28806][DOC] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-523585119 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25531: [SPARK-28806][DOC] Document SHOW COLUMNS in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25531: [SPARK-28806][DOC] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-523585112 Merged build finished. Test PASSed. This is an

[GitHub] [spark] srowen commented on a change in pull request #25527: [SPARK-28803][DOC] Document DESCRIBE TABLE in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25527: [SPARK-28803][DOC] Document DESCRIBE TABLE in SQL Reference URL: https://github.com/apache/spark/pull/25527#discussion_r316327736 ## File path: docs/sql-ref-syntax-aux-describe-table.md ## @@ -18,5 +18,53 @@ license: |

[GitHub] [spark] srowen commented on a change in pull request #25529: [SPARK-28804][DOC] Document DESCRIBE QUERY in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25529: [SPARK-28804][DOC] Document DESCRIBE QUERY in SQL Reference URL: https://github.com/apache/spark/pull/25529#discussion_r316327048 ## File path: docs/sql-ref-syntax-aux-describe-query.md ## @@ -19,4 +19,34 @@ license: |

[GitHub] [spark] srowen commented on a change in pull request #25529: [SPARK-28804][DOC] Document DESCRIBE QUERY in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25529: [SPARK-28804][DOC] Document DESCRIBE QUERY in SQL Reference URL: https://github.com/apache/spark/pull/25529#discussion_r316327470 ## File path: docs/sql-ref-syntax-aux-describe-query.md ## @@ -19,4 +19,34 @@ license: |

[GitHub] [spark] SparkQA commented on issue #25531: [SPARK-28806][DOC] Document SHOW COLUMNS in SQL Reference

2019-08-21 Thread GitBox
SparkQA commented on issue #25531: [SPARK-28806][DOC] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-523584966 **[Test build #109508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109508/testReport)** f

[GitHub] [spark] huaxingao edited a comment on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-21 Thread GitBox
huaxingao edited a comment on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference URL: https://github.com/apache/spark/pull/25525#issuecomment-523556338 ![image](https://user-images.githubusercontent.com/13592258/63456558-1273c100-c404-11e9-9c80-dc2fc9ca7967

[GitHub] [spark] srowen commented on a change in pull request #25530: [SPARK-28805][DOC] Document DESCRIBE FUNCTION in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25530: [SPARK-28805][DOC] Document DESCRIBE FUNCTION in SQL Reference URL: https://github.com/apache/spark/pull/25530#discussion_r316326559 ## File path: docs/sql-ref-syntax-aux-describe-function.md ## @@ -18,5 +18,40 @@ licens

[GitHub] [spark] srowen commented on a change in pull request #25526: [SPARK-28807][DOC] Document SHOW DATABASES in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25526: [SPARK-28807][DOC] Document SHOW DATABASES in SQL Reference URL: https://github.com/apache/spark/pull/25526#discussion_r316325880 ## File path: docs/sql-ref-syntax-aux-show-databases.md ## @@ -19,4 +19,31 @@ license: |

[GitHub] [spark] srowen commented on a change in pull request #25526: [SPARK-28807][DOC] Document SHOW DATABASES in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25526: [SPARK-28807][DOC] Document SHOW DATABASES in SQL Reference URL: https://github.com/apache/spark/pull/25526#discussion_r316325138 ## File path: docs/sql-ref-syntax-aux-show-databases.md ## @@ -19,4 +19,31 @@ license: |

[GitHub] [spark] srowen commented on a change in pull request #25526: [SPARK-28807][DOC] Document SHOW DATABASES in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25526: [SPARK-28807][DOC] Document SHOW DATABASES in SQL Reference URL: https://github.com/apache/spark/pull/25526#discussion_r316325647 ## File path: docs/sql-ref-syntax-aux-show-databases.md ## @@ -19,4 +19,31 @@ license: |

[GitHub] [spark] srowen commented on a change in pull request #25526: [SPARK-28807][DOC] Document SHOW DATABASES in SQL Reference

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25526: [SPARK-28807][DOC] Document SHOW DATABASES in SQL Reference URL: https://github.com/apache/spark/pull/25526#discussion_r316326023 ## File path: docs/sql-ref-syntax-aux-show-databases.md ## @@ -19,4 +19,31 @@ license: |

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
dongjoon-hyun edited a comment on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523541624 Hi, @xuanyuanking and @cloud-fan . This PR doesn't include the original test case. Is it okay?

[GitHub] [spark] huaxingao edited a comment on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-21 Thread GitBox
huaxingao edited a comment on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference URL: https://github.com/apache/spark/pull/25525#issuecomment-523555927 ![image](https://user-images.githubusercontent.com/13592258/63456433-c032a000-c403-11e9-9a85-f16327c4d92a

[GitHub] [spark] sarutak commented on a change in pull request #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots

2019-08-21 Thread GitBox
sarutak commented on a change in pull request #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots URL: https://github.com/apache/spark/pull/25487#discussion_r316308139 ## File path: core/src/main/scala/org/apache/spark/sch

[GitHub] [spark] sarutak commented on a change in pull request #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots

2019-08-21 Thread GitBox
sarutak commented on a change in pull request #25487: [SPARK-28769][CORE] Improve warning message of BarrierExecutionMode when required slots > maximum slots URL: https://github.com/apache/spark/pull/25487#discussion_r316308265 ## File path: core/src/main/scala/org/apache/spark/sc

[GitHub] [spark] rdblue commented on issue #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion

2019-08-21 Thread GitBox
rdblue commented on issue #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion URL: https://github.com/apache/spark/pull/25453#issuecomment-523563228 Any thoughts on whether we can get rid of legacy mode for v1 if we implement ANSI mode? Maybe we could use the 3

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316303481 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataFrameWriterV2Suite.scala ##

[GitHub] [spark] srowen commented on a change in pull request #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#discussion_r316302601 ## File path: resource-managers/mesos/src/main/scala/org/apache/spark/s

[GitHub] [spark] srowen commented on issue #25505: [SPARK-28776][ML] SparkML Writer gets hadoop conf from session state

2019-08-21 Thread GitBox
srowen commented on issue #25505: [SPARK-28776][ML] SparkML Writer gets hadoop conf from session state URL: https://github.com/apache/spark/pull/25505#issuecomment-523559011 (I usually leave it open at least a day to catch any more comments)

[GitHub] [spark] srowen commented on issue #25383: [SPARK-13677][ML] Implement Tree-Based Feature Transformation for ML

2019-08-21 Thread GitBox
srowen commented on issue #25383: [SPARK-13677][ML] Implement Tree-Based Feature Transformation for ML URL: https://github.com/apache/spark/pull/25383#issuecomment-523558542 Yeah, I think setters shouldn't be exposed on model objects. Some changes in the past have fixed some of that.

[GitHub] [spark] huaxingao commented on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-21 Thread GitBox
huaxingao commented on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference URL: https://github.com/apache/spark/pull/25525#issuecomment-523557596 ![image](https://user-images.githubusercontent.com/13592258/63452835-2287a280-c3fc-11e9-9688-d3c4fecc68f0.png)

[GitHub] [spark] gengliangwang commented on issue #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion

2019-08-21 Thread GitBox
gengliangwang commented on issue #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion URL: https://github.com/apache/spark/pull/25453#issuecomment-523557558 > If we want to have just one property, I think what we can do is use different defaults for v1 and v2, b

[GitHub] [spark] huaxingao commented on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-21 Thread GitBox
huaxingao commented on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference URL: https://github.com/apache/spark/pull/25525#issuecomment-523557375 ![image](https://user-images.githubusercontent.com/13592258/63452754-e5231500-c3fb-11e9-82d2-b888efa94554.png)

[GitHub] [spark] huaxingao commented on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-21 Thread GitBox
huaxingao commented on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference URL: https://github.com/apache/spark/pull/25525#issuecomment-523556338 ![image](https://user-images.githubusercontent.com/13592258/63452717-cd4b9100-c3fb-11e9-8cfe-a86475569533.png)

[GitHub] [spark] SparkQA commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
SparkQA commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-523556206 **[Test build #109506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109506/testReport)** for PR 25354 at

[GitHub] [spark] huaxingao commented on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-21 Thread GitBox
huaxingao commented on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference URL: https://github.com/apache/spark/pull/25525#issuecomment-523555927 ![image](https://user-images.githubusercontent.com/13592258/63452638-9ecdb600-c3fb-11e9-82ff-517bdb601a17.png)

[GitHub] [spark] AmplabJenkins removed a comment on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-523555148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/

[GitHub] [spark] huaxingao commented on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-21 Thread GitBox
huaxingao commented on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference URL: https://github.com/apache/spark/pull/25525#issuecomment-523555375 ![image](https://user-images.githubusercontent.com/13592258/63452562-71810800-c3fb-11e9-8dff-ebbe54efaa3b.png)

[GitHub] [spark] AmplabJenkins removed a comment on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-523555138 Merged build finished. Test PASSed. This is an automated mes

[GitHub] [spark] AmplabJenkins commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-523555138 Merged build finished. Test PASSed. This is an automated message fro

[GitHub] [spark] AmplabJenkins commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-523555148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/

[GitHub] [spark] huaxingao commented on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-21 Thread GitBox
huaxingao commented on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference URL: https://github.com/apache/spark/pull/25525#issuecomment-523554706 [](url) ![image](https://user-images.githubusercontent.com/13592258/63452476-3b438880-c3fb-11e9-9865-70d7ab515a7c

[GitHub] [spark] rdblue commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
rdblue commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316296769 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataFrameWriterV2Suite.scala ## @@

[GitHub] [spark] rdblue commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
rdblue commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316296208 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -3942,6 +3943,61 @@ obje

[GitHub] [spark] SparkQA commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
SparkQA commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-523552484 **[Test build #109505 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109505/testReport)** for PR 25354 at

[GitHub] [spark] AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523550426 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523549943 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523550433 Test PASSed. Refer to this link for build results (access rights to CI server needed): h

[GitHub] [spark] AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523549957 Test PASSed. Refer to this link for build results (access rights to CI server needed): h

[GitHub] [spark] SparkQA removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
SparkQA removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523439382 **[Test build #109495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilde

[GitHub] [spark] SparkQA removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
SparkQA removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523451346 **[Test build #109496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilde

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316294998 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.sca

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316294655 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/PartitionTransforms.scala #

[GitHub] [spark] AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523550433 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://a

[GitHub] [spark] AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523550426 Merged build finished. Test PASSed. T

[GitHub] [spark] AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523549943 Merged build finished. Test PASSed. T

[GitHub] [spark] AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523549957 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://a

[GitHub] [spark] SparkQA commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
SparkQA commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523549456 **[Test build #109495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/10949

[GitHub] [spark] SparkQA commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
SparkQA commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523549153 **[Test build #109496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/10949

[GitHub] [spark] AmplabJenkins removed a comment on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523546832 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523546840 Test PASSed. Refer to this link for build results (access rights to CI server needed): h

[GitHub] [spark] AmplabJenkins commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523546832 Merged build finished. Test PASSed. T

[GitHub] [spark] AmplabJenkins commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523546840 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://a

[GitHub] [spark] SparkQA removed a comment on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
SparkQA removed a comment on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523426163 **[Test build #109494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilde

[GitHub] [spark] SparkQA commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
SparkQA commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523546289 **[Test build #109494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/10949

[GitHub] [spark] brkyvz commented on issue #25521: [SPARK-28635][SQL][followup] CatalogManager should reflect the changes of default catalog

2019-08-21 Thread GitBox
brkyvz commented on issue #25521: [SPARK-28635][SQL][followup] CatalogManager should reflect the changes of default catalog URL: https://github.com/apache/spark/pull/25521#issuecomment-523545954 LGTM as well This is an automa

[GitHub] [spark] rdblue commented on issue #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion

2019-08-21 Thread GitBox
rdblue commented on issue #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion URL: https://github.com/apache/spark/pull/25453#issuecomment-523542819 > I have asked for your opinions one week ago in comment #25453 (comment) before I start the actual code changes

[GitHub] [spark] dongjoon-hyun commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
dongjoon-hyun commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523541624 @xuanyuanking and @cloud-fan . This PR doesn't include the original test case. Is it okay? It would be

[GitHub] [spark] rdblue commented on issue #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion

2019-08-21 Thread GitBox
rdblue commented on issue #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion URL: https://github.com/apache/spark/pull/25453#issuecomment-523541789 If we want to have just one property, I think what we can do is use different defaults for v1 and v2, but use th

[GitHub] [spark] rdblue commented on issue #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion

2019-08-21 Thread GitBox
rdblue commented on issue #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion URL: https://github.com/apache/spark/pull/25453#issuecomment-523540307 > For Spark users, I think it makes more sense to choose the table insertion policy with one flag. I don'

[GitHub] [spark] SparkQA commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
SparkQA commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523538354 **[Test build #109504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109504

[GitHub] [spark] AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523537124 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523537137 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523537137 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://

[GitHub] [spark] AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523537124 Merged build finished. Test PASSed. T

[GitHub] [spark] SparkQA commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
SparkQA commented on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523534335 **[Test build #109503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109503

[GitHub] [spark] AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523533292 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#issuecomment-523533302 Test PASSed. Refer to this link for build results (access rights to CI server needed):

<    4   5   6   7   8   9   10   11   12   13   >