[GitHub] spark issue #18725: [SPARK-21520][SQL]Hivetable scan for all the columns the...

2017-07-26 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18725 I think it's a `HiveTableScan`, rather than `FileSourceScanExec`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #18503: [SPARK-21271][SQL] Ensure Unsafe.sizeInBytes is a multip...

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18503 **[Test build #79956 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79956/testReport)** for PR 18503 at commit [`cc467de`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18655 **[Test build #79957 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79957/testReport)** for PR 18655 at commit [`19f3973`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18655 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79957/ Test FAILed. ---

[GitHub] spark issue #18709: [SPARK-21504] [SQL] Add spark version info into table me...

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18709 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18709: [SPARK-21504] [SQL] Add spark version info into table me...

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18709 **[Test build #79959 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79959/testReport)** for PR 18709 at commit [`4e71b66`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18655 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18503: [SPARK-21271][SQL] Ensure Unsafe.sizeInBytes is a multip...

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18503 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18503: [SPARK-21271][SQL] Ensure Unsafe.sizeInBytes is a multip...

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18503 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79956/ Test FAILed. ---

[GitHub] spark issue #18709: [SPARK-21504] [SQL] Add spark version info into table me...

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18709 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79959/ Test FAILed. ---

[GitHub] spark issue #18652: [SPARK-21497][SQL][WIP] Pull non-deterministic equi join...

2017-07-26 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18652 It is a good question. Based on previous discussion, I think Join operator has no unique result in the non-deterministic case. The migration issue from Hive is because this kind of queries can't run

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-26 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18655 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] spark issue #18513: [SPARK-13969][ML] Add FeatureHasher transformer

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18513 **[Test build #79961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79961/testReport)** for PR 18513 at commit [`d6a3117`](https://github.com/apache/spark/commit/d6

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18655 **[Test build #79960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79960/testReport)** for PR 18655 at commit [`19f3973`](https://github.com/apache/spark/commit/19

[GitHub] spark issue #18725: [SPARK-21520][SQL]Hivetable scan for all the columns the...

2017-07-26 Thread baibaichen
Github user baibaichen commented on the issue: https://github.com/apache/spark/pull/18725 The `HiveTableScans` strategy need `CatalogRelation`, but it's `LogicalRelation` in my case. Actually, the hive table is external table in my test, I guess that's the reason. I believe t

[GitHub] spark issue #18725: [SPARK-21520][SQL]Hivetable scan for all the columns the...

2017-07-26 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18725 @baibaichen I agree. Looks correct. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #18632: [SPARK-21412][SQL] Reset BufferHolder while initialize a...

2017-07-26 Thread gczsjdy
Github user gczsjdy commented on the issue: https://github.com/apache/spark/pull/18632 @cloud-fan You are right, thanks. I will close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #18632: [SPARK-21412][SQL] Reset BufferHolder while initi...

2017-07-26 Thread gczsjdy
Github user gczsjdy closed the pull request at: https://github.com/apache/spark/pull/18632 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] spark pull request #18737: [WIP][SPARK-21536][R] Remove the workaroud to all...

2017-07-26 Thread HyukjinKwon
Github user HyukjinKwon closed the pull request at: https://github.com/apache/spark/pull/18737 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] spark issue #18737: [WIP][SPARK-21536][R] Remove the workaroud to allow dots...

2017-07-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18737 Hm.. this is a bigger change than I thought .. I mean the change itself here should be correct as we support dots in columns in Scala side but it looks there are few bugs related with dots in co

[GitHub] spark issue #18731: [SPARK-20990][SQL] Read all JSON documents in files when...

2017-07-26 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/18731 I am debugging, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18737: [WIP][SPARK-21536][R] Remove the workaroud to allow dots...

2017-07-26 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18737 It's a breaking change, but IMO one we need since we have quite a bit of feedback on this. re: test failure ``` java.lang.IllegalArgumentException: Field "Sepal_Length" does not

[GitHub] spark issue #18737: [WIP][SPARK-21536][R] Remove the workaroud to allow dots...

2017-07-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18737 Yea. The test failure above itself is legitimate but while manually running and debugging few more tests with some more fixes, it printed: ``` Failed ---

[GitHub] spark issue #18737: [WIP][SPARK-21536][R] Remove the workaroud to allow dots...

2017-07-26 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18737 it's very likely we need to make sure a column name with `.` is specified with backtick, esp. when referenced in SQL expression... --- If your project is set up for it, you can reply to this em

[GitHub] spark issue #18725: [SPARK-21520][SQL]Hivetable scan for all the columns the...

2017-07-26 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/18725 @viirya @baibaichen thank your for review it. I made a comparison test: ``` select k,k,sum(id) from (select d004 as id, floor(c010 * 1) as k, ceil(c010) as cceila from XXX_tabl

[GitHub] spark issue #18731: [SPARK-20990][SQL] Read all JSON documents in files when...

2017-07-26 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/18731 The reason of the UT failure is that in these two UTs we are passing invalid JSONs (mind the extra closed curly brace): - https://github.com/apache/spark/blob/master/sql/core/src/test/scal

[GitHub] spark issue #18513: [SPARK-13969][ML] Add FeatureHasher transformer

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18513 **[Test build #79961 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79961/testReport)** for PR 18513 at commit [`d6a3117`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #18513: [SPARK-13969][ML] Add FeatureHasher transformer

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18513 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79961/ Test PASSed. ---

[GitHub] spark issue #18513: [SPARK-13969][ML] Add FeatureHasher transformer

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18513 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #18738: Typo in comment

2017-07-26 Thread nahoj
GitHub user nahoj opened a pull request: https://github.com/apache/spark/pull/18738 Typo in comment - You can merge this pull request into a Git repository by running: $ git pull https://github.com/nahoj/spark patch-1 Alternatively you can review and apply these changes as the

[GitHub] spark issue #18738: Typo in comment

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18738 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #18725: [SPARK-21520][SQL]Hivetable scan for all the columns the...

2017-07-26 Thread baibaichen
Github user baibaichen commented on the issue: https://github.com/apache/spark/pull/18725 @heary-cao, is the better performance with your fix? e.g. changing RDG's deterministic property from false to true? ``` override def deterministic: Boolean = true ``` --- If yo

[GitHub] spark pull request #18695: [SPARK-12717][PYTHON] Adding thread-safe broadcas...

2017-07-26 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18695#discussion_r129516461 --- Diff: python/pyspark/context.py --- @@ -195,7 +195,7 @@ def _do_init(self, master, appName, sparkHome, pyFiles, environment, batchSize, # Th

[GitHub] spark issue #18337: [SPARK-21131][GraphX] Fix batch gradient bug in SVDPlusP...

2017-07-26 Thread daniellaah
Github user daniellaah commented on the issue: https://github.com/apache/spark/pull/18337 I also tested the SVDPlusPlus on movielens-100k dataset. The algorithm just diverged. And the mse on the dataset gets 2.14748364347152E9. I tested @lxmly 's code as well, it works but I don'

[GitHub] spark issue #18725: [SPARK-21520][SQL]Hivetable scan for all the columns the...

2017-07-26 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/18725 @baibaichen yes, In my test environment `Time taken: 557.276 seconds, Fetched 1 row(s)` VS `Time taken: 5997.238 seconds, Fetched 1 row(s)` But I'm not sure about the ch

[GitHub] spark issue #18725: [SPARK-21520][SQL]Hivetable scan for all the columns the...

2017-07-26 Thread baibaichen
Github user baibaichen commented on the issue: https://github.com/apache/spark/pull/18725 @heary-cao your fix is wrong. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark issue #18555: [SPARK-21353][CORE]add checkValue in spark.internal.conf...

2017-07-26 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/18555 @gatorsmile @cloud-fan I added new test case again. except ``` DYN_ALLOCATION_MIN_EXECUTORS DYN_ALLOCATION_INITIAL_EXECUTORS DYN_ALLOCATION_MAX_EXECUTORS

[GitHub] spark issue #18725: [SPARK-21520][SQL]Hivetable scan for all the columns the...

2017-07-26 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/18725 @baibaichen Okay, I try to modify this particular scenario by split it to two Projects. thanks. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark issue #18738: Typo in comment

2017-07-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18738 Can you have a look for similar typos, or others in this file? we encourage people to submit more than just one minor typo fix in a PR if possible --- If your project is set up for it, you can reply

[GitHub] spark pull request #18659: [SPARK-21404][PYSPARK][WIP] Simple Python Vectori...

2017-07-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18659#discussion_r129522956 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala --- @@ -132,6 +135,61 @@ private[sql] object ArrowConverters {

[GitHub] spark issue #18738: Typo in comment

2017-07-26 Thread nahoj
Github user nahoj commented on the issue: https://github.com/apache/spark/pull/18738 Sorry, I don't have time to proof-read the docs, I just saw this one typo as it is in the summary of this much-used class. --- If your project is set up for it, you can reply to this email and have y

[GitHub] spark issue #18728: [SPARK-21524] [ML] unit test fix: ValidatorParamsSuiteHe...

2017-07-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18728 merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark pull request #18728: [SPARK-21524] [ML] unit test fix: ValidatorParams...

2017-07-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18728 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #18702: [SPARK-21485][SQL][DOCS] Spark SQL documentation generat...

2017-07-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18702 I guess it probably will take about a week more for my Apache account creation (according to the doc). --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark issue #18702: [SPARK-21485][SQL][DOCS] Spark SQL documentation generat...

2017-07-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18702 I am fine with leaving it to me too :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18305: [SPARK-20988][ML] Logistic regression uses aggregator hi...

2017-07-26 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/18305 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18655 **[Test build #79960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79960/testReport)** for PR 18655 at commit [`19f3973`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18655 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79960/ Test PASSed. ---

[GitHub] spark issue #18305: [SPARK-20988][ML] Logistic regression uses aggregator hi...

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18305 **[Test build #79962 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79962/testReport)** for PR 18305 at commit [`cb40b31`](https://github.com/apache/spark/commit/cb

[GitHub] spark issue #18655: [SPARK-21440][SQL][PYSPARK] Refactor ArrowConverters and...

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18655 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #18554: [SPARK-21306][ML] OneVsRest should support setWei...

2017-07-26 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/18554#discussion_r129532746 --- Diff: python/pyspark/ml/classification.py --- @@ -1517,20 +1517,22 @@ class OneVsRest(Estimator, OneVsRestParams, MLReadable, MLWritable):

[GitHub] spark pull request #18554: [SPARK-21306][ML] OneVsRest should support setWei...

2017-07-26 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/18554#discussion_r129533677 --- Diff: python/pyspark/ml/tests.py --- @@ -1255,6 +1255,24 @@ def test_output_columns(self): output = model.transform(df) self

[GitHub] spark issue #18664: [SPARK-21375][PYSPARK][SQL][WIP] Add Date and Timestamp ...

2017-07-26 Thread jreback
Github user jreback commented on the issue: https://github.com/apache/spark/pull/18664 I cannot repro this; can you show what ``item['timezone']`` is? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark issue #18305: [SPARK-20988][ML] Logistic regression uses aggregator hi...

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18305 **[Test build #79962 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79962/testReport)** for PR 18305 at commit [`cb40b31`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #18305: [SPARK-20988][ML] Logistic regression uses aggregator hi...

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18305 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18305: [SPARK-20988][ML] Logistic regression uses aggregator hi...

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18305 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79962/ Test PASSed. ---

[GitHub] spark issue #18305: [SPARK-20988][ML] Logistic regression uses aggregator hi...

2017-07-26 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/18305 Merged to master. Thanks @sethah, and thanks all for reviews. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #18305: [SPARK-20988][ML] Logistic regression uses aggreg...

2017-07-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #18731: [SPARK-20990][SQL] Read all JSON documents in files when...

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18731 **[Test build #79963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79963/testReport)** for PR 18731 at commit [`4da8493`](https://github.com/apache/spark/commit/4d

[GitHub] spark pull request #18554: [SPARK-21306][ML] OneVsRest should support setWei...

2017-07-26 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/18554#discussion_r129562189 --- Diff: python/pyspark/ml/classification.py --- @@ -1517,20 +1517,22 @@ class OneVsRest(Estimator, OneVsRestParams, MLReadable, MLWritable):

[GitHub] spark issue #18554: [SPARK-21306][ML] OneVsRest should support setWeightCol

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18554 **[Test build #79964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79964/testReport)** for PR 18554 at commit [`8c0beba`](https://github.com/apache/spark/commit/8c

[GitHub] spark pull request #18554: [SPARK-21306][ML] OneVsRest should support setWei...

2017-07-26 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/18554#discussion_r129562237 --- Diff: python/pyspark/ml/tests.py --- @@ -1255,6 +1255,24 @@ def test_output_columns(self): output = model.transform(df) self.ass

[GitHub] spark pull request #18739: [WIP][SPARK-21539][CORE] Job should not be aborte...

2017-07-26 Thread caneGuy
GitHub user caneGuy opened a pull request: https://github.com/apache/spark/pull/18739 [WIP][SPARK-21539][CORE] Job should not be aborted when dynamic allocation is en… …abled or spark.executor.instances larger then current allocated number by yarn ## What changes were

[GitHub] spark issue #18739: [WIP][SPARK-21539][CORE] Job should not be aborted when ...

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18739 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #17180: [SPARK-19839][Core]release longArray in BytesToBytesMap

2017-07-26 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/17180 Is it better to fix this test instead of remove it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request #18610: [SPARK-21386] ML LinearRegression supports warm s...

2017-07-26 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/18610#discussion_r129574777 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala --- @@ -309,6 +313,23 @@ private[ml] object DefaultParamsWriter { val met

[GitHub] spark issue #18554: [SPARK-21306][ML] OneVsRest should support setWeightCol

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18554 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79964/ Test PASSed. ---

[GitHub] spark issue #18554: [SPARK-21306][ML] OneVsRest should support setWeightCol

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18554 **[Test build #79964 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79964/testReport)** for PR 18554 at commit [`8c0beba`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #18554: [SPARK-21306][ML] OneVsRest should support setWeightCol

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18554 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #18735: [SPARK-21530] Update description of spark.shuffle...

2017-07-26 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/18735#discussion_r129589282 --- Diff: docs/configuration.md --- @@ -636,6 +636,8 @@ Apart from these, the following properties are also available, and may be useful Long.MAX_V

[GitHub] spark pull request #18735: [SPARK-21530] Update description of spark.shuffle...

2017-07-26 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/18735#discussion_r129589331 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -259,6 +259,8 @@ public Properties cryptoConf() {

[GitHub] spark issue #18731: [SPARK-20990][SQL] Read all JSON documents in files when...

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18731 **[Test build #79963 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79963/testReport)** for PR 18731 at commit [`4da8493`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #18731: [SPARK-20990][SQL] Read all JSON documents in files when...

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18731 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18731: [SPARK-20990][SQL] Read all JSON documents in files when...

2017-07-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18731 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79963/ Test PASSed. ---

[GitHub] spark issue #18305: [SPARK-20988][ML] Logistic regression uses aggregator hi...

2017-07-26 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/18305 Thanks @MLnick, @hhbyyh, and @facaiy for reviewing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18739: [WIP][SPARK-21539][CORE] Job should not be aborted when ...

2017-07-26 Thread caneMi
Github user caneMi commented on the issue: https://github.com/apache/spark/pull/18739 I have implemented logic to report blacklist node for yarn and will push later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark issue #18739: [WIP][SPARK-21539][CORE] Job should not be aborted when ...

2017-07-26 Thread canezk
Github user canezk commented on the issue: https://github.com/apache/spark/pull/18739 I have implemented logic to report blacklist node for yarn and will push later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request #18735: [SPARK-21530] Update description of spark.shuffle...

2017-07-26 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/18735#discussion_r129608114 --- Diff: docs/configuration.md --- @@ -636,6 +636,8 @@ Apart from these, the following properties are also available, and may be useful Long.MAX_V

[GitHub] spark issue #18735: [SPARK-21530] Update description of spark.shuffle.maxChu...

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18735 **[Test build #79965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79965/testReport)** for PR 18735 at commit [`2216b31`](https://github.com/apache/spark/commit/22

[GitHub] spark issue #18735: [SPARK-21530] Update description of spark.shuffle.maxChu...

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18735 **[Test build #79966 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79966/testReport)** for PR 18735 at commit [`14f857e`](https://github.com/apache/spark/commit/14

[GitHub] spark pull request #18735: [SPARK-21530] Update description of spark.shuffle...

2017-07-26 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/18735#discussion_r129613952 --- Diff: docs/configuration.md --- @@ -635,7 +635,10 @@ Apart from these, the following properties are also available, and may be useful spark.shu

[GitHub] spark issue #18735: [SPARK-21530] Update description of spark.shuffle.maxChu...

2017-07-26 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/18735 thanks for updating, minor formatting thing I forgot to mention before, otherwise looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] spark issue #18704: [SPARK-20783][SQL] Create CachedBatchColumnVector to abs...

2017-07-26 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18704 ping @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] spark issue #18468: [SPARK-20783][SQL] Create CachedBatchColumnVector to abs...

2017-07-26 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18468 ping @cloud-fan, @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #18315: [SPARK-21108] [ML] [WIP] convert LinearSVC to aggregator...

2017-07-26 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/18315 ping! https://github.com/apache/spark/pull/18305 was merged. This can proceed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18709: [SPARK-21504] [SQL] Add spark version info into table me...

2017-07-26 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18709 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #18709: [SPARK-21504] [SQL] Add spark version info into table me...

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18709 **[Test build #79967 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79967/testReport)** for PR 18709 at commit [`4e71b66`](https://github.com/apache/spark/commit/4e

[GitHub] spark issue #18702: [SPARK-21485][SQL][DOCS] Spark SQL documentation generat...

2017-07-26 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18702 LGTM too. Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #18702: [SPARK-21485][SQL][DOCS] Spark SQL documentation ...

2017-07-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18702 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #18645: [SPARK-14280][BUILD][WIP] Update change-version.sh and p...

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18645 **[Test build #79968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79968/testReport)** for PR 18645 at commit [`82b51dc`](https://github.com/apache/spark/commit/82

[GitHub] spark issue #18645: [SPARK-14280][BUILD][WIP] Update change-version.sh and p...

2017-07-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18645 I believe the last errors were essentially the same issue discussed in json4s here: https://github.com/json4s/json4s/issues/227 I suspect that it's down to a change in the effective setti

[GitHub] spark pull request #18711: [SPARK-21506][DOC]The description of "spark.execu...

2017-07-26 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18711#discussion_r129633550 --- Diff: docs/configuration.md --- @@ -1106,7 +1106,7 @@ Apart from these, the following properties are also available, and may be useful para

[GitHub] spark issue #17882: [WIP][SPARK-20079][yarn] Re registration of AM hangs spa...

2017-07-26 Thread witgo
Github user witgo commented on the issue: https://github.com/apache/spark/pull/17882 I'm very sorry, I haven't taken the time to update this code recently. @vanzin , thank you for your work. I'll close this PR. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request #17882: [WIP][SPARK-20079][yarn] Re registration of AM ha...

2017-07-26 Thread witgo
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/17882 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark issue #18694: [SPARK-21492][SQL] Memory leak in SortMergeJoin

2017-07-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18694 IMO the cleanup hook is a workaround for the limitation of iterator model: although the parent knows when to release resource of its child, but there is no way to notify the child via iterator.

[GitHub] spark issue #18503: [SPARK-21271][SQL] Ensure Unsafe.sizeInBytes is a multip...

2017-07-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18503 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #18503: [SPARK-21271][SQL] Ensure Unsafe.sizeInBytes is a multip...

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18503 **[Test build #79969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79969/testReport)** for PR 18503 at commit [`cc467de`](https://github.com/apache/spark/commit/cc

[GitHub] spark issue #16630: [SPARK-19270][ML] Add summary table to GLM summary

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16630 **[Test build #79970 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79970/testReport)** for PR 16630 at commit [`7281b77`](https://github.com/apache/spark/commit/72

[GitHub] spark issue #18708: [SPARK-21339] [CORE] spark-shell --packages option does ...

2017-07-26 Thread devaraj-kavali
Github user devaraj-kavali commented on the issue: https://github.com/apache/spark/pull/18708 @vanzin I have updated the changes, can you check and validate the change? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark issue #18679: [SPARK-21319][SQL] Fix memory leak in sorter

2017-07-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18679 **[Test build #79971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79971/testReport)** for PR 18679 at commit [`9b88297`](https://github.com/apache/spark/commit/9b

  1   2   3   >