[GitHub] spark pull request #16021: JDBCRDD returns incorrect results for filters on ...

2016-11-27 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/16021 JDBCRDD returns incorrect results for filters on CHAR of PostgreSQL ## What changes were proposed in this pull request? In Apache Spark 1.6.x, JDBCRDD returns incorrect results for

[GitHub] spark issue #16021: JDBCRDD returns incorrect results for filters on CHAR of...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16021 cc @maropu , @viirya , @HyukjinKwon , @rxin . This is a backport to resolve SPARK-18593 in `branch-1.6`. Although this is a correctness issue, there is a workaround for this

[GitHub] spark pull request #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect resu...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16021#discussion_r89688101 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala --- @@ -210,6 +220,16 @@ class JDBCSuite extends SparkFunSuite

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16021 Thank you, @maropu , @HyukjinKwon , @viirya . I'll update like that. @maropu . I think we don't need to remove that here at least for this issue. We don't expe

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16021 Oops. I didn't replace `spark` with `sqlContext`. I'll fix soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16021 Only your commits will be in `branch-1.6` with the original titles. Since this PR has nothing, this PR will disappear completely when the committer merge this. I think so. --- If your

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16021 Hmm. Ur, @HyukjinKwon , maybe, the Spark script might not work like that I mentioned. Anyway, in that case, the committer should backport these 6 commits separately instead of this

[GitHub] spark pull request #16012: [SPARK-17251][SQL] Support `OuterReference` in pr...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/16012 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #16012: [SPARK-17251][SQL] Support `OuterReference` in projectio...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16012 Hi, @hvanhovell and @nsyca . I created a JIRA issue for Option 2 with simple and complex example (@hvanhovell 's). * https://issues.apache.org/jira/browse/SPARK-

[GitHub] spark issue #16026: [SPARK-18597][SQL] Do push-down predicates to right side...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16026 Thank you for pinging me, @hvanhovell . I'll take a look, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request #16026: [SPARK-18597][SQL] Do push-down predicates to rig...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16026#discussion_r89715298 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala --- @@ -514,6 +514,39 @@ class

[GitHub] spark issue #16026: [SPARK-18597][SQL] Do push-down predicates to right side...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16026 LGTM, @hvanhovell . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16027: Make sure CollapseWindow returns the attributes in the s...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16027 Oh, I missed this. Yep. I'll take a look at this, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request #16027: Make sure CollapseWindow returns the attributes i...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16027#discussion_r89716308 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -545,7 +545,7 @@ object CollapseRepartition

[GitHub] spark issue #16027: Make sure CollapseWindow returns the attributes in the s...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16027 LGTM. Thank you for correct this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16027: Make sure CollapseWindow returns the attributes i...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16027#discussion_r89716395 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseWindowSuite.scala --- @@ -46,12 +46,15 @@ class

[GitHub] spark issue #16027: Make sure CollapseWindow returns the attributes in the s...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16027 Could you add `[SPARK-18604][SQL]` before merging? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #15976: [SPARK-18403][SQL] Fix unsafe data false sharing issue i...

2016-11-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15976 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16036: [SPARK-17732][SQL] Revert ALTER TABLE DROP PARTITION sho...

2016-11-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16036 I see. @cloud-fan and @hvanhovell . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16036: [SPARK-17732][SQL] Revert ALTER TABLE DROP PARTITION sho...

2016-11-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16036 @hvanhovell , could you give me some direction on #15987 before updating? The as-is direction of #15987 seems to be not proper. --- If your project is set up for it, you can reply to

[GitHub] spark issue #15924: [SPARK-18498] [SQL] Revise HDFSMetadataLog API for bette...

2016-11-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15924 Retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15722: [SPARK-18208] [Shuffle] Executor OOM due to a growing Lo...

2016-11-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15722 Retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #15722: [SPARK-18208] [Shuffle] Executor OOM due to a gro...

2016-11-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15722#discussion_r90029240 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -170,6 +170,8 @@ private long peakMemoryUsedBytes

[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...

2016-11-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15279 Hi, @ethanluoyc . Could you add Apache License, too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14638: [SPARK-11374][SQL] Support `skip.header.line.count` opti...

2016-11-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14638 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #16044: [Spark-18614][SQL] Incorrect predicate pushdown f...

2016-11-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16044#discussion_r90042593 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala --- @@ -575,6 +575,24 @@ class JoinSuite extends QueryTest with

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

2016-11-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r90095923 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -113,6 +113,10 @@ class HadoopTableReader( val

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

2016-11-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r90101517 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -122,10 +126,20 @@ class HadoopTableReader( val

[GitHub] spark pull request #16063: [SPARK-18622][SQL] Remove TypeCoercion rules for ...

2016-11-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16063#discussion_r90110048 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -482,21 +482,6 @@ object TypeCoercion

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

2016-11-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r90123854 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -113,6 +113,10 @@ class HadoopTableReader( val

[GitHub] spark pull request #16067: [SPARK-17897] [SQL] Fixed IsNotNull Constraint In...

2016-11-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16067#discussion_r90143591 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1697,6 +1697,12 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark issue #16072: [SPARK-18639] Build only a single pip package

2016-11-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16072 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a P...

2016-10-25 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/15640 [SPARK-18106][SQL] ANALYZE TABLE should raise a ParseException for invalid option ## What changes were proposed in this pull request? Currently, `ANALYZE TABLE` command accepts

[GitHub] spark pull request #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a P...

2016-10-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15640#discussion_r85164920 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -98,9 +98,10 @@ class SparkSqlAstBuilder(conf: SQLConf

[GitHub] spark pull request #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a P...

2016-10-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15640#discussion_r85166515 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala --- @@ -220,4 +220,12 @@ class SparkSqlParserSuite extends

[GitHub] spark pull request #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a P...

2016-10-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15640#discussion_r85167755 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala --- @@ -220,4 +220,12 @@ class SparkSqlParserSuite extends

[GitHub] spark pull request #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a P...

2016-10-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15640#discussion_r85168739 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -98,9 +98,10 @@ class SparkSqlAstBuilder(conf: SQLConf

[GitHub] spark issue #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a ParseExc...

2016-10-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15640 Hi, @srinathshankar . For the test suite, I'll update again if you give more opinion. So far, I didn't update that because I'm not sure. --- If your project is set up

[GitHub] spark pull request #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a P...

2016-10-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15640#discussion_r85168358 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala --- @@ -220,4 +220,12 @@ class SparkSqlParserSuite extends

[GitHub] spark issue #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a ParseExc...

2016-10-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15640 Hi, @hvanhovell . Could you review this PR when you have some time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a P...

2016-10-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15640#discussion_r85212670 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala --- @@ -220,4 +220,13 @@ class SparkSqlParserSuite extends

[GitHub] spark pull request #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a P...

2016-10-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15640#discussion_r85213183 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala --- @@ -220,4 +220,12 @@ class SparkSqlParserSuite extends

[GitHub] spark pull request #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a P...

2016-10-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15640#discussion_r85236855 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala --- @@ -220,4 +220,12 @@ class SparkSqlParserSuite extends

[GitHub] spark pull request #15664: [SPARK-18123][SQL] Use db column names instead of...

2016-10-27 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/15664 [SPARK-18123][SQL] Use db column names instead of RDD column ones during JDBC Writing ## What changes were proposed in this pull request? Apache Spark supports the following cases

[GitHub] spark pull request #15664: [SPARK-18123][SQL] Use db column names instead of...

2016-10-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15664#discussion_r85616485 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -112,7 +112,25 @@ object JdbcUtils extends

[GitHub] spark pull request #15682: [SPARK-18169][SQL] Suppress warnings when droppin...

2016-10-29 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/15682 [SPARK-18169][SQL] Suppress warnings when dropping views on a dropped table ## What changes were proposed in this pull request? Apache Spark 2.0.0 ~ 2.0.2-rc1 shows an

[GitHub] spark pull request #15686: [MINOR][DOC] Remove spaces following slashs

2016-10-30 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/15686 [MINOR][DOC] Remove spaces following slashs ## What changes were proposed in this pull request? This PR merges multiple lines enumerating items in order to remove the redundant

[GitHub] spark pull request #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a P...

2016-10-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15640#discussion_r85666227 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -98,9 +98,10 @@ class SparkSqlAstBuilder(conf: SQLConf

[GitHub] spark issue #15686: [MINOR][DOC] Remove spaces following slashs

2016-10-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15686 Thank you for review and approval, @srowen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a P...

2016-10-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15640#discussion_r85666706 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala --- @@ -220,4 +220,12 @@ class SparkSqlParserSuite extends

[GitHub] spark issue #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a ParseExc...

2016-10-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15640 The only test failure seems to be irrelevant. Let's see the final test result which is still running. ``` [info] - SPARK-10562: partition by column with mixed case name *** F

[GitHub] spark issue #15640: [SPARK-18106][SQL] ANALYZE TABLE should raise a ParseExc...

2016-10-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15640 Thank you, @hvanhovell ! Also, Thank you, @srinathshankar . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-10-31 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/15704 [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should support comparators ## What changes were proposed in this pull request? This PR aims to support `comparators`, e.g

[GitHub] spark issue #15302: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

2016-10-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15302 Hi, @hvanhovell . I made another attempt #15704 by using 'Expression' as you commented. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #15302: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

2016-10-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15302 Thank you, @hvanhovell ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15686: [MINOR][DOC] Remove spaces following slashs

2016-10-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15686 Never mind, @HyunjinKwon . I was also curious about AppVoyer failure. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #15686: [MINOR][DOC] Remove spaces following slashs

2016-11-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15686 Thank you for merging, @srowen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r85984522 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -631,6 +631,42 @@ private[spark] class

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86015221 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -418,27 +419,53 @@ case class

[GitHub] spark issue #15546: [SPARK-17982][SQL][WIP] SQLBuilder should wrap the gener...

2016-11-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15546 Sorry for delay, @rxin . I'm still working on, and will update in a few days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #15546: [SPARK-17982][SQL][WIP] SQLBuilder should wrap the gener...

2016-11-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15546 Oh, 2.1-rc1 today? I see. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15546: [SPARK-17982][SQL][WIP] SQLBuilder should wrap the gener...

2016-11-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15546 Ah, I see. It's feature freeze. Thank you for informing me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request #14435: [SPARK-16756][SQL][WIP] Add `sql` function to Log...

2016-11-01 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/14435 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14435: [SPARK-16756][SQL][WIP] Add `sql` function to LogicalPla...

2016-11-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14435 I close this PR since the issue is closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15704 Thank you for review, @viirya . I'll fix them tomorrow~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #15546: [SPARK-17982][SQL] SQLBuilder should wrap the gen...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15546#discussion_r86101999 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala --- @@ -138,9 +138,12 @@ class SQLBuilder private ( case g

[GitHub] spark pull request #15546: [SPARK-17982][SQL] SQLBuilder should wrap the gen...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15546#discussion_r86102201 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala --- @@ -138,9 +138,12 @@ class SQLBuilder private ( case g

[GitHub] spark pull request #15546: [SPARK-17982][SQL] SQLBuilder should wrap the gen...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15546#discussion_r86102655 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala --- @@ -162,6 +165,8 @@ class SQLBuilder private ( case p

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86238278 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -418,27 +419,53 @@ case class

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86237888 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -204,6 +207,38 @@ class AstBuilder extends

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86239543 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -418,27 +419,53 @@ case class

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86242187 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -193,6 +193,9 @@ class AstBuilder extends

[GitHub] spark pull request #15741: [SPARK-18200][GRAPHX] Support zero-size initial c...

2016-11-02 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/15741 [SPARK-18200][GRAPHX] Support zero-size initial capacity in OpenHashSet ## What changes were proposed in this pull request? [SPARK-18200](https://issues.apache.org/jira/browse/SPARK

[GitHub] spark pull request #15741: [SPARK-18200][GRAPHX] Support zero-size initial c...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15741#discussion_r86262058 --- Diff: core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala --- @@ -42,10 +42,12 @@ import org.apache.spark.annotation.Private

[GitHub] spark issue #15741: [SPARK-18200][GRAPHX] Support zero as an initial capacit...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15741 Retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15741: [SPARK-18200][GRAPHX] Support zero as an initial capacit...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15741 The only failure seems to be irrelevant. ``` [info] BasicSchedulerIntegrationSuite: [info] - job with fetch failure *** FAILED *** (1 second, 889 milliseconds) [info

[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15704 Thank you so much, @viirya . I added the testcase and fixed related bug again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15704 Thank you, @gatorsmile ! I'll fix soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86290826 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -204,6 +207,40 @@ class AstBuilder extends

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86290924 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -418,27 +419,56 @@ case class

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86291115 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -418,27 +419,56 @@ case class

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86291122 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -29,9 +29,10 @@ import org.apache.hadoop.mapred

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86292070 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -204,6 +207,40 @@ class AstBuilder extends

[GitHub] spark issue #15741: [SPARK-18200][GRAPHX] Support zero as an initial capacit...

2016-11-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15741 Thank you for review and merging, @rxin . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15704 I addressed all comments. For the upcoming comments, I'll handle them tomorrow. Thank you so much always, @gatorsmile . --- If your project is set up for it, you can reply to this emai

[GitHub] spark pull request #15741: [SPARK-18200][GRAPHX] Support zero as an initial ...

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15741#discussion_r86359753 --- Diff: core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala --- @@ -271,8 +271,12 @@ class OpenHashSet[@specialized(Long, Int) T

[GitHub] spark pull request #15741: [SPARK-18200][GRAPHX] Support zero as an initial ...

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15741#discussion_r86382197 --- Diff: core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala --- @@ -271,8 +271,12 @@ class OpenHashSet[@specialized(Long, Int) T

[GitHub] spark pull request #15741: [SPARK-18200][GRAPHX] Support zero as an initial ...

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15741#discussion_r86382636 --- Diff: core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala --- @@ -271,8 +271,12 @@ class OpenHashSet[@specialized(Long, Int) T

[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15704 Thank you, @hvanhovell . I'll revise the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86385537 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -243,7 +243,7 @@ partitionSpec

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86385850 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -204,6 +207,41 @@ class AstBuilder extends

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86386317 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -418,27 +419,56 @@ case class

[GitHub] spark pull request #15741: [SPARK-18200][GRAPHX] Support zero as an initial ...

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15741#discussion_r86388101 --- Diff: core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala --- @@ -271,8 +271,12 @@ class OpenHashSet[@specialized(Long, Int) T

[GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/15704#discussion_r86389182 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -418,27 +419,56 @@ case class

[GitHub] spark pull request #15754: [SPARK-18200][GRAPHX][FOLLOW-UP] Support zero as ...

2016-11-03 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/15754 [SPARK-18200][GRAPHX][FOLLOW-UP] Support zero as an initial capacity in OpenHashSet ## What changes were proposed in this pull request? This is a folloup PR of #15741 in order to

[GitHub] spark issue #15754: [SPARK-18200][GRAPHX][FOLLOW-UP] Support zero as an init...

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15754 The only failure seems to be irrelevant. ``` [info] StreamingContextSuite: [info] - stop slow receiver gracefully *** FAILED *** (1 second, 419 milliseconds) ``` --- If your

[GitHub] spark issue #15754: [SPARK-18200][GRAPHX][FOLLOW-UP] Support zero as an init...

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15754 Retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15754: [SPARK-18200][GRAPHX][FOLLOW-UP] Support zero as an init...

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15754 Thank you for review and approving, @srowen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #14426: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14426 Resolve the conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14426: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-11-03 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14426 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

<    2   3   4   5   6   7   8   9   10   11   >