Re: [RT] Script Resolution

2009-06-23 Thread Felix Meschberger
Hi, Carsten Ziegeler schrieb: > Another minor issue are the helper methods of the JcrResourceUtil class > (the getResourceSuperType, resourceTypeToPath methods). I think we can > make them completly JCR free and move them to the ResourceUtil class in > the API. +1 But leave the methods in the Jc

Code Coverage and Metrics

2009-06-23 Thread Carsten Ziegeler
Hi, Sling has been added to the public Sonar instance: http://nemo.sonarsource.org/project/index/org.apache.sling:sling-builder So we get some nice graphics about code coverage, some metrics etc. Atm we have 9% coverage :) Anyone interested in making us look better? Regards Carsten -- Carsten

Re: [RT] Script Resolution

2009-06-23 Thread Bertrand Delacretaz
Hi, On Mon, Jun 22, 2009 at 9:16 PM, Carsten Ziegeler wrote: > ...I suggest to change the script resolution to use the admin > session Sounds good for now, though we might later want to use specific credentials for that. When working with JCR, I miss the unixish execute permission bit, user

Re: Code Coverage and Metrics

2009-06-23 Thread Bertrand Delacretaz
On Tue, Jun 23, 2009 at 10:09 AM, Carsten Ziegeler wrote: > Sling has been added to the public Sonar instance: > http://nemo.sonarsource.org/project/index/org.apache.sling:sling-builder > So we get some nice graphics about code coverage, some metrics etc. Cool! > Atm we have 9% coverage :) Anyone

Re: [RT] Script Resolution

2009-06-23 Thread Felix Meschberger
Hi, Dominik Süß schrieb: > Wouldn't this take us the ability to restrict allowed actions by taking > reading rights of the scriptlocation by ACLs? > How would you solve restriction on scriptaccess? What exact problem do you want to solve with the restriction on script access ? Do you have some k

Re: [RT] Script Resolution

2009-06-23 Thread Ian Boston
On 23 Jun 2009, at 09:42, Felix Meschberger wrote: Hi, Dominik Süß schrieb: Wouldn't this take us the ability to restrict allowed actions by taking reading rights of the scriptlocation by ACLs? How would you solve restriction on scriptaccess? What exact problem do you want to solve with

Re: Code Coverage and Metrics

2009-06-23 Thread Dominik Süß
Cool stats :) Most metrics seam to be ok... but.. Cyclomatic Complexity[1] of Apache Sling Scripting JSP Support with a value of 165 ... wow... "11+ refactor now !" (quote from the Sonar Hovertext)... These metrics might really indicate where optimization could be required ;) Best regards, Domin

Re: Code Coverage and Metrics

2009-06-23 Thread Alexander Klimetschek
2009/6/23 Dominik Süß : > Cool stats :) > Most metrics seam to be ok... but.. > Cyclomatic Complexity[1] of Apache Sling Scripting JSP Support with a value > of 165 ... wow... That is the Jasper JSP compiler, which is included as-is in Sling. And compiler parsers are normally huge (because mostly

ACL permissions on nodes.

2009-06-23 Thread Ian Boston
Hi, If I set jcr:write granted on a node, I can upload content to that node with a multipart post but I cant overwrite the content. to make that work I appear to need at least curl http://admin:ad...@localhost:8080/_user/private/d9/31/78/03/ian5.acl.json {"ian5":{"granted": ["jcr:write ",

Re: [RT] Script Resolution

2009-06-23 Thread Bertrand Delacretaz
Hi, On Tue, Jun 23, 2009 at 12:03 PM, Ian Boston wrote: > On 23 Jun 2009, at 09:42, Felix Meschberger wrote: >>... What exact problem do you want to solve with the restriction on script >> access ? Do you have some kind of "x-bit" in mind ? The repository >> itself has no support for (and cannot s

Re: [RT] Script Resolution

2009-06-23 Thread Bertrand Delacretaz
(hit send too early - ignore previous message) Hi, On Tue, Jun 23, 2009 at 12:03 PM, Ian Boston wrote: > On 23 Jun 2009, at 09:42, Felix Meschberger wrote: >>... What exact problem do you want to solve with the restriction on script >> access ? Do you have some kind of "x-bit" in mind ? The repos

Re: [RT] Script Resolution

2009-06-23 Thread Bertrand Delacretaz
On Tue, Jun 23, 2009 at 1:23 PM, Bertrand Delacretaz wrote: > > (hit send too early - ignore previous message) Sorry about that - Gmail is *eating* parts of my messages today...back in a sec. -Bertrand

Re: [RT] Script Resolution

2009-06-23 Thread Bertrand Delacretaz
Hi, On Tue, Jun 23, 2009 at 12:03 PM, Ian Boston wrote: > On 23 Jun 2009, at 09:42, Felix Meschberger wrote: >>... What exact problem do you want to solve with the restriction on script >> access ? Do you have some kind of "x-bit" in mind ? The repository >> itself has no support for (and cannot s

Re: ACL permissions on nodes.

2009-06-23 Thread Tobias Bocanegra
hi, according to jsr283 (see 16.2.3), the jcr:write is an aggregate privilege: • jcr:write: An aggregate privilege that contains: o jcr:modifyProperties o jcr:addChildNodes o jcr:removeNode o jcr:removeChildNodes so, jcr:write should be sufficient. i can imagine, that the individual privilege are

Re: ACL permissions on nodes.

2009-06-23 Thread Ian Boston
On 23 Jun 2009, at 12:46, Tobias Bocanegra wrote: hi, according to jsr283 (see 16.2.3), the jcr:write is an aggregate privilege: • jcr:write: An aggregate privilege that contains: o jcr:modifyProperties o jcr:addChildNodes o jcr:removeNode o jcr:removeChildNodes so, jcr:write should be suf

Re: [RT] Script Resolution

2009-06-23 Thread Ian Boston
On 23 Jun 2009, at 12:28, Bertrand Delacretaz wrote: Hi, On Tue, Jun 23, 2009 at 12:03 PM, Ian Boston wrote: On 23 Jun 2009, at 09:42, Felix Meschberger wrote: ... What exact problem do you want to solve with the restriction on script access ? Do you have some kind of "x-bit" in mind ? The

Re: [RT] Script Resolution

2009-06-23 Thread Felix Meschberger
Hi, Ian Boston schrieb: > > On 23 Jun 2009, at 12:28, Bertrand Delacretaz wrote: >>> Although Sling might choose to ignore this, I/we (sakai) are going >>> to need to do something since all our users have write access to the >>> repo, and at least 10% of them are Computer Science first year >>>

Re: [RT] Script Resolution

2009-06-23 Thread Felix Meschberger
Hi, Bertrand Delacretaz schrieb: > Hi, > > On Tue, Jun 23, 2009 at 12:03 PM, Ian Boston wrote: >> On 23 Jun 2009, at 09:42, Felix Meschberger wrote: >>> ... What exact problem do you want to solve with the restriction on script >>> access ? Do you have some kind of "x-bit" in mind ? The repositor

Re: [RT] Script Resolution

2009-06-23 Thread Ian Boston
On 23 Jun 2009, at 14:06, Felix Meschberger wrote: Hi, Ian Boston schrieb: On 23 Jun 2009, at 12:28, Bertrand Delacretaz wrote: Although Sling might choose to ignore this, I/we (sakai) are going to need to do something since all our users have write access to the repo, and at least 10%

[jira] Created: (SLING-1018) Remove dependency to DS

2009-06-23 Thread Carsten Ziegeler (JIRA)
Remove dependency to DS --- Key: SLING-1018 URL: https://issues.apache.org/jira/browse/SLING-1018 Project: Sling Issue Type: Improvement Components: JCR Install Reporter: Carsten Ziegeler

Re: [RT] Script Resolution

2009-06-23 Thread Felix Meschberger
Hi Ian, Ian Boston schrieb: > > On 23 Jun 2009, at 14:06, Felix Meschberger wrote: > >> Hi, >> >> Ian Boston schrieb: >>> >>> On 23 Jun 2009, at 12:28, Bertrand Delacretaz wrote: > Although Sling might choose to ignore this, I/we (sakai) are going > to need to do something since all our

Re: [RT] Script Resolution

2009-06-23 Thread Ian Boston
On 23 Jun 2009, at 15:17, Felix Meschberger wrote: Correct, so I would then say: the actual user is to be configurable but default to admin. Would that be ok for you ? Yes, that would work for me, Thanks Ian

[jira] Closed: (SLING-1018) Remove dependency to DS

2009-06-23 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-1018. --- Resolution: Fixed Fix Version/s: JCR Install 2.0.4 Removed the dependency to declarati

[jira] Created: (SLING-1019) Correctly handle bind/unbind of repository

2009-06-23 Thread Carsten Ziegeler (JIRA)
Correctly handle bind/unbind of repository -- Key: SLING-1019 URL: https://issues.apache.org/jira/browse/SLING-1019 Project: Sling Issue Type: Bug Components: JCR Install Reporter

[jira] Created: (SLING-1020) Add some methods from JcrResourceUtil to ResourceUtil

2009-06-23 Thread Carsten Ziegeler (JIRA)
Add some methods from JcrResourceUtil to ResourceUtil - Key: SLING-1020 URL: https://issues.apache.org/jira/browse/SLING-1020 Project: Sling Issue Type: New Feature Components: AP