On Sat, 27 Feb 2016, Jilles Tjoelker wrote:
On Sat, Feb 27, 2016 at 09:48:05AM -0500, Pedro Giffuni wrote:
In the case of rlogind, note that the above limitation [FD_SETSIZE]
has disappeared by using poll(2).
I will add that FreeBSD has a native poll(2) implementation, it is
not a wrapper
On Sun, 21 Feb 2016, Edward Tomasz Napierala wrote:
Log:
Make the "invalid numeric value" error message actually displayable
(was a dead code before).
Submitted by: bde@ (earlier version)
Reviewed by: bde@
Thanks.
Modified:
head/bin/dd/args.c
Modified: head/bin/dd/args.c
On Sun, 21 Feb 2016, Ian Lepore wrote:
Log:
Allow a dynamic env to override a compiled-in static env by passing in the
override indication in the env data.
Submitted by: bde
Thanks.
Bruce
___
svn-src-all@freebsd.org mailing list
On Sat, 20 Feb 2016, Justin Hibbits wrote:
Log:
Fix the definition of RM_MAX_END.
Even though casting from signed to unsigned is well-defined in C, it's better
to
first cast to the larger unsigned type, then negate.
Casting ~0 is well-defined, but ~0 isn't.
The operation is
On Sat, 20 Feb 2016, Dimitry Andric wrote:
On 19 Feb 2016, at 16:49, Alan Somers wrote:
On Fri, Feb 19, 2016 at 5:24 AM, Sergey Kandaurov wrote:
...
-struct nlist namelist[] = {
+static struct nlist namelist[] = {
#define X_TTY_NIN 0
- {
On Fri, 19 Feb 2016, Benjamin Kaduk wrote:
On Fri, Feb 19, 2016 at 5:06 PM, Gleb Smirnoff wrote:
On Fri, Feb 19, 2016 at 08:49:43AM -0700, Alan Somers wrote:
A> On Fri, Feb 19, 2016 at 5:24 AM, Sergey Kandaurov
wrote:
A> Yeah, it was being implicitly
On Mon, 15 Feb 2016, Ian Lepore wrote:
On Tue, 2016-02-16 at 11:01 +1100, Bruce Evans wrote:
On Mon, 15 Feb 2016, Ian Lepore wrote:
On Tue, 2016-02-16 at 09:28 +1100, Bruce Evans wrote:
On Mon, 15 Feb 2016, Michal Meloun wrote:
[...]
Please note that ARM architecture does not have
On Mon, 15 Feb 2016, Ian Lepore wrote:
On Tue, 2016-02-16 at 09:28 +1100, Bruce Evans wrote:
On Mon, 15 Feb 2016, Michal Meloun wrote:
[...]
Please note that ARM architecture does not have vectored interrupts,
CPU must read actual interrupt source from external interrupt
controller (GIC
On Mon, 15 Feb 2016, Michal Meloun wrote:
Dne 13.02.2016 v 1:58 Marius Strobl napsal(a):
On Sat, Feb 13, 2016 at 06:53:25AM +1100, Bruce Evans wrote:
On Fri, 12 Feb 2016, Marius Strobl wrote:
On Fri, Feb 12, 2016 at 05:14:58AM +, Michal Meloun wrote:
Author: mmel
Date: Fri Feb 12 05:14
On Mon, 15 Feb 2016, Pedro F. Giffuni wrote:
Log:
fputs: Return the number of bytes written.
POSIX.1-2008 requires that successful completion simply return a
non-negative integer. We have regularly returned a constant value.
Another, equally valid, implementation convention implies
On Sat, 13 Feb 2016, Konstantin Belousov wrote:
On Sat, Feb 13, 2016 at 07:29:48AM +1100, Bruce Evans wrote:
It needs a version number to be correct. Plain __POSIX_VISIBLE means
all versions. __POSIX_VISBLE >= 200112 is probably good enough for
the POSIX part. I don't know the corr
On Sat, 13 Feb 2016, Konstantin Belousov wrote:
On Sun, Feb 14, 2016 at 04:02:05AM +1100, Bruce Evans wrote:
The old visibility bugs with mc_* should be fixed someday. I said that
uc_* could be used. _mc_* should have been used originally. Maybe we
can just change to either of these, since
On Fri, 12 Feb 2016, Konstantin Belousov wrote:
Log:
POSIX states that #include shall make both mcontext_t and
ucontext_t available. Our code even has XXX comment about this.
Only newer versions of POSIX have this bug. In the 2001 version, the
bug was limited to the XSI section. was
On Fri, 12 Feb 2016, Konstantin Belousov wrote:
On Fri, Feb 12, 2016 at 01:22:04PM +, Ruslan Bukin wrote:
On RISC-V it fails with __uint128_t:
struct fpregs {
__uint128_t fp_x[32];
how to fix?
You did not copied the error.
If my guess is correct, the issue is that
On Fri, 12 Feb 2016, Ruslan Bukin wrote:
On RISC-V it fails with __uint128_t:
struct fpregs {
__uint128_t fp_x[32];
how to fix?
This seems to be an old bug. __uint128_t shouldn't be used unless it
is supported by . In old versions of FreeBSD, I used
something like
On Fri, 12 Feb 2016, Konstantin Belousov wrote:
On Sat, Feb 13, 2016 at 01:08:55AM +1100, Bruce Evans wrote:
On Fri, 12 Feb 2016, Konstantin Belousov wrote:
...
Modified: head/include/signal.h
==
--- head/include
On Fri, 12 Feb 2016, Marius Strobl wrote:
On Fri, Feb 12, 2016 at 05:14:58AM +, Michal Meloun wrote:
Author: mmel
Date: Fri Feb 12 05:14:58 2016
New Revision: 295557
URL: https://svnweb.freebsd.org/changeset/base/295557
Log:
UART: Fix spurious interrupts generated by ns8250 and lpc
On Fri, 12 Feb 2016, Konstantin Belousov wrote:
On Sat, Feb 13, 2016 at 03:56:42AM +1100, Bruce Evans wrote:
Our Standard C namespace is a subset of the POSIX namespace. Most
Standard C headers are (were) careful about this. There aren't many
Standard C headers or versions of Standard C
On Thu, 11 Feb 2016, Pedro F. Giffuni wrote:
Log:
Ext4: Use boolean type instead of '0' and '1'
There are precedents of uses of bool in the kernel and
it is incorrect style to use integers as replacement for
a boolean type.
This is all backwards.
It is correct style to use integers to
On Sun, 7 Feb 2016, Pedro Giffuni wrote:
On 02/07/16 02:13, Bruce Evans wrote:
On Sun, 7 Feb 2016, Pedro F. Giffuni wrote:
Log:
cd9660: Drop an unnecessary check for NULL.
This was unnecessary and also confused Coverity.
Confirmed on:NetBSD
CID:978558
This leaves many
On Sun, 7 Feb 2016, Pedro F. Giffuni wrote:
Log:
msdosfs_rename: yet another unused value.
As with r295355, it seems to be left over from a cleanup
in r33548. The code is not in NetBSD either.
Thanks to bde for checking out the history.
r33548 was not a cleanup. It was a major change
On Sun, 7 Feb 2016, Pedro F. Giffuni wrote:
Log:
fdesc_setattr: unitialized pointer read
CID: 1018688
Bug in Coverity.
Modified: head/sys/fs/fdescfs/fdesc_vnops.c
==
--- head/sys/fs/fdescfs/fdesc_vnops.c Sun
On Sun, 7 Feb 2016, Pedro F. Giffuni wrote:
Log:
cd9660: Drop an unnecessary check for NULL.
This was unnecessary and also confused Coverity.
Confirmed on: NetBSD
CID: 978558
This leaves many similar bugs unfixed nearby. One is a null pointer
panic, not just an unnecessary
On Tue, 2 Feb 2016, John Baldwin wrote:
Log:
Return the timestamps from the corresponding namecache entry on a negative
namecache hit. This was ommitted due to a merging error in r238913. The
effect was to usually break caching of negative name lookups in the NFS
client.
Submitted by:
On Tue, 26 Jan 2016, Kubilay Kocak wrote:
Log:
Restore flushing of output for revoke(2) again. Document revoke()'s
intended behaviour in its man page. Simplify tty_drain() to match.
Don't call ttydevsw methods in tty_flush() if the device is gone
since we now sometimes call it then.
On Sun, 24 Jan 2016, Andriy Voskoboinyk wrote:
Log:
net80211: reduce stack usage for ieee80211_ioctl*() methods.
Use malloc(9) for
- struct ieee80211req_wpaie2 (518 bytes, used in
ieee80211_ioctl_getwpaie())
- struct ieee80211_scan_req (128 bytes, used in setmlme_assoc_adhoc()
and
On Fri, 22 Jan 2016, Marcelo Araujo wrote:
2016-01-22 15:57 GMT+08:00 Bruce Evans <b...@optusnet.com.au>:
...
Unfortunately, getdtablesize() is still needed for arrays as used in yp*,
and for anything using select(). If getdtablesize() is large then the
arrays should be sparse or larg
On Fri, 22 Jan 2016, Marcelo Araujo wrote:
Log:
Switch from FD_SETSIZE to getdtablesize(2) as it can make the FD to be
tunable. Also it gets more close with the original implementation from
OpenBSD.
Modified: head/usr.sbin/ypldap/yp.c
On Thu, 14 Jan 2016, John Baldwin wrote:
Log:
Fix building with GCC since PAGE_MASK is signed on i386.
...
Modified: head/lib/libkvm/kvm_i386.h
==
--- head/lib/libkvm/kvm_i386.h Thu Jan 14 15:50:13 2016
On Thu, 14 Jan 2016, Warner Losh wrote:
Log:
Document how to enter the debugger here. I'm sure there's some better
canonical place, and the nit-pickers are welcome to move this
information there with a cross reference.
...
Modified: head/share/man/man4/ddb.4
On Thu, 14 Jan 2016, Slawa Olhovchenkov wrote:
On Fri, Jan 15, 2016 at 06:27:05AM +1100, Bruce Evans wrote:
The BREAK_TO_DEBUGGER option used to mean: enter (not break into) the
debugger using a serial line break. This is a good method, except it
...
This option was broken to mean
On Tue, 12 Jan 2016, Conrad Meyer wrote:
On Tue, Jan 12, 2016 at 5:32 PM, Ian Lepore wrote:
Yep, but then I had to do this because ef->off is 64 bits even on 32
bit arches, so I got a pointer/int size mismatch warning...
Index: common/load_elf.c
On Wed, 13 Jan 2016, Konstantin Belousov wrote:
On Wed, Jan 13, 2016 at 03:03:07PM +1100, Bruce Evans wrote:
Oops. It is only declared in outside of the kernel.
Only __uintfptr_t is always declared by sys/types.h.
So what is the intended use of the uintfptr_t type ? Looking
On Wed, 13 Jan 2016, Ian Lepore wrote:
Log:
Go back to using uintptr_t, because code that actually compiles is
infinitely less buggy than code that is theoretically correct in some
alternate universe.
The uintfptr_t type is apparently a freebsd invention, and exists only when
compiling
On Tue, 12 Jan 2016, Ian Lepore wrote:
On Wed, 2016-01-13 at 01:17 +, Steven Hartland wrote:
On 13/01/2016 00:54, Ian Lepore wrote:
On Wed, 2016-01-13 at 00:43 +, Steven Hartland wrote:
...
Passes a full tinderbox so I assume your forcing gcc for some
reason?
For several reasons.
On Thu, 7 Jan 2016, Konstantin Belousov wrote:
Log:
Convert tty common code to use make_dev_s().
Tty.c was untypical in that it handled the si_drv1 issue consistently
and correctly, by always checking for si_drv1 being non-NULL and
sleeping if NULL. The removed code also illustrated
On Thu, 7 Jan 2016, Jim Harris wrote:
On Thu, Jan 7, 2016 at 9:27 AM, Ravi Pokala wrote:
...
+ * Used for calculating number of CPUs to assign to each core and number
of I/O
+ * queues to allocate per controller.
+ */
+#define NVME_CEILING(num, div)num) - 1) /
On Tue, 5 Jan 2016, Allan Jude wrote:
On 2016-01-05 22:16, Devin Teske wrote:
This e-mail is extremely hard to parse and I think you are mistaken.
The -f flag is more than just a counter to a possible -i
Try to rm a file that has schg
You will get a prompt without -i
Adding -f will abate
On Tue, 5 Jan 2016, Ian Lepore wrote:
Log:
Use the more proper -f. Leave /bin/rm in place since that's what
other rc scripts have, though it isn't strictly necessary.
"proper -f" is hard to parse. I think you mean:
Use 'rm -f' to turn off -i in case rm is broken and is an alias which
On Sat, 2 Jan 2016, Allan Jude wrote:
On 2015-12-31 13:50, Allan Jude wrote:
On 2015-12-31 13:32, Jonathan T. Looney wrote:
On 12/31/15, 2:15 AM, "Allan Jude" wrote:
It seems these problems also slow things down, a lot:
# time md5 /media/md5test/bigdata
MD5
On Sat, 2 Jan 2016, Ian Lepore wrote:
Log:
Cast pointer through uintptr_t on the way to uint64_t to squelch a warning.
Modified: head/sys/boot/uboot/lib/copy.c
==
--- head/sys/boot/uboot/lib/copy.c Sat Jan 2
On Sat, 2 Jan 2016, Ian Lepore wrote:
Log:
Use 64-bit math when finding a block of ram to hold the kernel. This fixes
a problem on 32-bit systems which have ram occupying the end of the physical
address space -- for example, a block of ram at 0x8000 with a size of
0x8000 was
On Wed, 30 Dec 2015, Jonathan T. Looney wrote:
Log:
Fix a file descriptor leak in mdXhl.c (which is used by numerous hashing
algorithms.
This code had amazingly low quality and is still especially broken near
the main leak fixed.
Modified: head/lib/libmd/mdXhl.c
On Thu, 31 Dec 2015, Bruce Evans wrote:
wc /proc/0/* works. md5 works like wc using a hack to avoid calling this
broken function. E.g.,
for i in $(ls /proc/0/*); do echo -n "$i: "; md5 <$i; done # gives
/proc/0/cmdline: 3c5896b1ac441f4998f052e2126e8d2
On Tue, 29 Dec 2015, John Baldwin wrote:
On Monday, December 28, 2015 01:01:26 PM Warner Losh wrote:
I'll look at that, but I don't think posix_memalign is the right way to go.
The alignment of FILE is more strict than posix_memalign will return. Ian's
idea of __alignof__ is the way to go. We
On Wed, 30 Dec 2015, David Chisnall wrote:
On 30 Dec 2015, at 00:48, Bruce Evans <b...@optusnet.com.au> wrote:
- C++ apparently spells this as both _Alignof() and alignof() after 2011/03
This is not correct. C++ spells it alignof. C spells it _Alignof, unless you
include , in whic
On Tue, 29 Dec 2015, Dmitry Chagin wrote:
So, my point was:
a) for a long time we have broken settimeofday() which does not allow us
to set the system time before the Epoch
We still have a broken settimeofday that doesn't allow us to set the system
time to the Epoch in the Western hemisphere
On Mon, 28 Dec 2015, Konstantin Belousov wrote:
On Mon, Dec 28, 2015 at 09:35:11AM +1100, Bruce Evans wrote:
If this causes a panic, then it is from a sanity check detecting the
invalid conversion later. A negative value in days breaks the loop
logic but seems to give premature exit from
On Mon, 28 Dec 2015, Garrett Cooper wrote:
On Dec 28, 2015, at 02:17, Bruce Evans <b...@optusnet.com.au> wrote:
...
It is not unreasonable to panic when such tests fail, just like for other
settings of unreasonable values. Only the superuser can make them, and
the superuser shoul
On Sun, 27 Dec 2015, Ian Lepore wrote:
On Sun, 2015-12-27 at 12:05 -0800, NGie Cooper wrote:
On Dec 27, 2015, at 11:30, Slawa Olhovchenkov
wrote:
?
I have no idea what you mean by that -- I didn't say anything at
all
about panic.
As I understund commit log -- this is
On Sun, 27 Dec 2015, Ian Lepore wrote:
On Sun, 2015-12-27 at 15:37 +, Dmitry Chagin wrote:
Author: dchagin
Date: Sun Dec 27 15:37:07 2015
New Revision: 292777
URL: https://svnweb.freebsd.org/changeset/base/292777
Log:
Verify that tv_sec value specified in settimeofday() and
On Mon, 28 Dec 2015, Marcelo Araujo wrote:
Log:
Add on systat -vm the ability to display the physical and kernel memory
percent usage.
PR:bin/203917
Submitted by: ota
Approved by: bapt (mentor)
Differential Revision: https://reviews.freebsd.org/D4281
On Thu, 24 Dec 2015, Konstantin Belousov wrote:
On Wed, Dec 23, 2015 at 08:02:10AM +1100, Bruce Evans wrote:
On Tue, 22 Dec 2015, Konstantin Belousov wrote:
Log:
If we annoy user with the terminal output due to failed load of
interpreter, also show the actual error code instead of some
On Tue, 22 Dec 2015, Konstantin Belousov wrote:
Log:
If we annoy user with the terminal output due to failed load of
interpreter, also show the actual error code instead of some
interpretation.
This and nearby messages are of annoyingly low quality. They don't
even print the program
On Tue, 22 Dec 2015, Konstantin Belousov wrote:
Log:
Keep devfs mount locked for the whole duration of the devfs_setattr(),
and ensure that our dirent is instantiated.
Reported and tested by:bde
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Thanks.
This is part of
On Fri, 18 Dec 2015, John Baldwin wrote:
Log:
Fix the precious change to check the pointer returned by malloc().
Submitted by: luke
Pointy hat to: jhb
Of course, malloc can't fail, especially for small utilities like boot0cfg,
especially in -current.
Modified:
On Sun, 13 Dec 2015, Garrett Cooper wrote:
Log:
Add -static to CFLAGS to unbreak the tests by using a libc.a with
the xlocale private symbols exposed which aren't exposed publicly
via the DSO
This is an interesting hack.
I think there are some bad bugs in static libraries from exposing
On Wed, 9 Dec 2015, Garrett Cooper wrote:
Log:
...
Use stdint.h instead of inttypes.h as the latter pollutes namespace more
...
Modified: head/lib/libc/stdio/open_memstream.c
==
--- head/lib/libc/stdio/open_memstream.c
On Thu, 10 Dec 2015, Hajimu UMEMOTO wrote:
On Wed, 9 Dec 2015 18:19:16 +1100 (EST)
Bruce Evans <b...@optusnet.com.au> said:
brde> resolv.h already had massinve namespace pollution and style bugs in
brde> its includes. One more include of a header that is relatively clean
On Wed, 9 Dec 2015, Hajimu UMEMOTO wrote:
Hi,
On Tue, 8 Dec 2015 16:09:48 + (UTC)
Eric van Gyzen said:
...
vangyzen> Log:
vangyzen> resolver: fix the build of some ports, broken by r289315
vangyzen>
vangyzen> r289315 required time_t and struct timespec to be
On Tue, 8 Dec 2015, Garrett Cooper wrote:
Author: ngie
...
Log:
Fix compilation when -DDEBUG is defined by adding inttypes.h #include
for intmax_t
Wrong include. intmax_t is declared in . declares
much more and is usually only needed for functions like strtoimax().
also declares PRI*
On Mon, 7 Dec 2015, Konstantin Belousov wrote:
Log:
Update ctime when atime or birthtime are updated.
Cleanup setting of ctime/mtime/birthtime: do not set IN_ACCESS or
IN_UPDATE, then clear them with ufs_itimes(), making transient
(possibly inconsistent) change to the times, and then copy
On Mon, 7 Dec 2015, Andrey Chernov wrote:
On 07.12.2015 17:42, Andrey Chernov wrote:
On 07.12.2015 15:09, Konstantin Belousov wrote:
Author: kib
Date: Mon Dec 7 12:09:04 2015
New Revision: 291936
URL: https://svnweb.freebsd.org/changeset/base/291936
Log:
Update ctime when atime or
On Thu, 3 Dec 2015, Bryan Drewery wrote:
On 12/3/2015 7:38 PM, Kenneth D. Merry wrote:
g_disk_limit(struct disk *dp, struct bio *bp)
{
bool limited = false;
- off_t d_maxsize;
-
- d_maxsize = (bp->bio_cmd == BIO_DELETE) ?
- dp->d_delmaxsize : dp->d_maxsize;
+
On Fri, 4 Dec 2015, Bryan Drewery wrote:
On 12/4/2015 10:03 AM, Bruce Evans wrote:
This is specified by not giving an example of using it. style(9) was
I really take issue with this stance. I don't think you really mean what
this implies. For example, can I even use 'x++' or mtx_lock(9
On Fri, 4 Dec 2015, NGie Cooper wrote:
On Nov 9, 2015, at 04:03, Bruce Evans <b...@optusnet.com.au> wrote:
On Mon, 9 Nov 2015, Garrett Cooper wrote:
Log:
Document powl(3)
powl was garbage that was intentionally undocumented. At least, I
intentionally ignored its non-documentation to
On Fri, 4 Dec 2015, Andrew Turner wrote:
On Fri, 4 Dec 2015 23:42:51 +1100 (EST)
Bruce Evans <b...@optusnet.com.au> wrote:
...
This looks like 5 style bugs and 0 issues:
3 old style bugs:
- use of bool
I don't seem to see where in style(9) we disallow the use of bool. Can
you point me
On Thu, 19 Nov 2015, Jonathan T. Looney wrote:
On 11/19/15, 12:58 PM, "John Baldwin" wrote:
Note that if you are going to document in each section 9 manpage which
APIs
are not safe to call in a critical section, you will need to update just
about every section 9 manpage. A
On Sun, 15 Nov 2015, Konstantin Belousov wrote:
On Sat, Nov 14, 2015 at 06:30:13PM +, David Chisnall wrote:
On 26 Oct 2015, at 16:21, Eric van Gyzen wrote:
One counter-argument to this change is that most applications already
use SIMD, and the number of
On Fri, 13 Nov 2015, David Chisnall wrote:
On 13 Nov 2015, at 08:35, Konstantin Belousov wrote:
On Fri, Nov 13, 2015 at 09:18:54AM +0100, Hans Petter Selasky wrote:
Hi,
On 11/12/15 18:17, Conrad Meyer wrote:
These should cast through (u)intptr_t rather than unsigned
On Tue, 10 Nov 2015, Hans Petter Selasky wrote:
On 11/09/15 22:17, Bruce Evans wrote:
...
This shouldn't compile either.
static int
-sysctl_root_handler_locked(struct sysctl_oid *oid, void *arg1, intptr_t
arg2,
+sysctl_root_handler_locked(struct sysctl_oid *oid, void *arg1, intmax_t
arg2
On Tue, 10 Nov 2015, Conrad Meyer wrote:
On Tue, Nov 10, 2015 at 7:08 AM, Ian Lepore wrote:
On Tue, 2015-11-10 at 08:44 +0100, Hans Petter Selasky wrote:
-sysctl_root_handler_locked(struct sysctl_oid *oid, void *arg1,
intptr_t arg2,
+sysctl_root_handler_locked(struct
On Tue, 10 Nov 2015, Justin Hibbits wrote:
On Tue, Nov 10, 2015 at 9:42 AM, Conrad Meyer wrote:
...
Given that intptr_t exists in our implementation and is a signed
integer type, I see no reason why intmax_t could possibly not
represent any such value. Same argument for the
On Mon, 9 Nov 2015, Conrad E. Meyer wrote:
Log:
linuxkpi/sysfs.h: Cast arg2 through intptr_t to avoid GCC warning
The code compiles fine under Clang, but GCC on PPC is less permissive about
integer and pointer sizes. (An intmax_t is clearly *large enough* to hold a
pointer value.)
On Mon, 9 Nov 2015, Garrett Cooper wrote:
Log:
Document powl(3)
powl was garbage that was intentionally undocumented. At least, I
intentionally ignored its non-documentation together with it.
Modified: head/lib/msun/man/exp.3
On Sat, 7 Nov 2015, Konstantin Belousov wrote:
On Sat, Nov 07, 2015 at 09:25:32PM +1100, Bruce Evans wrote:
...
I put intptr_t in long ago, since it was more needed and
less magic than intmax_t. This was obfuscated by moving it to
and including that in various places. intmax_t is
still
On Sat, 7 Nov 2015, Conrad E. Meyer wrote:
Log:
Round out SYSCTL macros to the full set of fixed-width types
Add S8, S16, S32, and U32 types; add SYSCTL*() macros for them, as well
as for the existing 64-bit types. (While SYSCTL*QUAD and UQUAD macros
already exist, they do not take the
On Sat, 7 Nov 2015, Svatopluk Kraus wrote:
You broke buildkernel. The following patch helps:
diff --git a/sys/sys/sysctl.h b/sys/sys/sysctl.h
index 950e712..a34c890 100644
--- a/sys/sys/sysctl.h
+++ b/sys/sys/sysctl.h
@@ -37,6 +37,7 @@
#define _SYS_SYSCTL_H_
#include
+#include
struct
On Sat, 7 Nov 2015, Conrad E. Meyer wrote:
Log:
Flesh out sysctl types further (follow-up of r290475)
Use the right intmax_t type instead of intptr_t in a few remaining
places.
Add support for CTLFLAG_TUN for the new fixed with types. Bruce will be
upset that the new handlers silently
On Fri, 30 Oct 2015, Justin Hibbits wrote:
On Oct 30, 2015, at 9:27 PM, Conrad Meyer wrote:
Comments inline.
On Fri, Oct 30, 2015 at 7:08 PM, Justin Hibbits
wrote:
Author: jhibbits
Date: Sat Oct 31 02:08:39 2015
New Revision: 290221
URL:
On Thu, 22 Oct 2015, Conrad E. Meyer wrote:
Log:
Add libkern ffsll() for parity with flsll()
Sponsored by: EMC / Isilon Storage Division
This fills a much needed gap, like the one filled by flsll().
It uses the long long abomination.
uintmax_t has been Standard since 1999, but is still
On Thu, 22 Oct 2015, Conrad E. Meyer wrote:
Log:
Sysctl: Add common support for U8, U16 types
Sponsored by: EMC / Isilon Storage Division
This uses similar low-quality code to other sysctls, and more.
Modified: head/sbin/sysctl/sysctl.c
On Sat, 17 Oct 2015, Konstantin Belousov wrote:
On Thu, Oct 15, 2015 at 10:12:03PM +1100, Bruce Evans wrote:
On Thu, 15 Oct 2015, Konstantin Belousov wrote:
On Wed, Oct 14, 2015 at 08:22:12PM +, Garrett Cooper wrote:
Author: ngie
Date: Wed Oct 14 20:22:12 2015
New Revision: 289332
URL
On Fri, 16 Oct 2015, Warner Losh wrote:
Log:
Do not relocate extents to make them contiguous if the underlying drive can do
deletions. Ability to do deletions is a strong indication that this
optimization will not help performance. It will only generate extra write
traffic. These devices
On Fri, 16 Oct 2015, Hans Petter Selasky wrote:
On 10/16/15 08:21, Bruce Evans wrote:
[Bruce Evans didn't write:]
In addition, making the file contiguous in LBA space doesn't
improve the access times from flash devices because they have no seek
time.
This is not exactly true, like Bruce
On Fri, 16 Oct 2015, Warner Losh wrote:
On Oct 16, 2015, at 2:12 AM, Hans Petter Selasky <h...@selasky.org> wrote:
On 10/16/15 08:21, Bruce Evans wrote:
In addition, making the file contiguous in LBA space doesn't
improve the access times from flash devices because they have no see
On Thu, 15 Oct 2015, Konstantin Belousov wrote:
On Wed, Oct 14, 2015 at 08:22:12PM +, Garrett Cooper wrote:
Author: ngie
Date: Wed Oct 14 20:22:12 2015
New Revision: 289332
URL: https://svnweb.freebsd.org/changeset/base/289332
Log:
Fix test-fenv:test_dfl_env when run on some amd64 CPUs
On Wed, 14 Oct 2015, Garrett Cooper wrote:
Log:
Fix test-fenv:test_dfl_env when run on some amd64 CPUs
Compare the fields that the AMD [1] and Intel [2] specs say will be
set once fnstenv returns.
Not all amd64 capable processors zero out the env.__x87.__other field
(example: AMD Opteron
On Sun, 30 Aug 2015, Jilles Tjoelker wrote:
On Sun, Aug 30, 2015 at 11:53:00AM +0200, Ed Schouten wrote:
2015-08-28 16:38 GMT+02:00 Joerg Sonnenberger jo...@britannica.bec.de:
But the compiler can't tell if it is the *intention* that the function
never returns. The warning behavior exists
On Fri, 28 Aug 2015, Joerg Sonnenberger wrote:
On Fri, Aug 28, 2015 at 10:17:56PM +1000, Bruce Evans wrote:
-static voiddie(int);
+static voiddie(int) __dead2;
Since the function is static, it is very easy for the compiler to see
that it doesn't return.
But the compiler can't tell
On Thu, 27 Aug 2015, Xin LI wrote:
Log:
die() would never return, mark it as so.
Why? (Except to add a style bug.)
Modified: head/usr.sbin/syslogd/syslogd.c
==
--- head/usr.sbin/syslogd/syslogd.c Thu Aug 27
On Thu, 13 Aug 2015, David Chisnall wrote:
On 13 Aug 2015, at 08:11, Marcelo Araujo araujobsdp...@gmail.com wrote:
The bcopy() was removed in IEEE Std 1003.1-2008 and it is marked as LEGACY in
IEEE Std 1003.1-2004. However, BSD has its implementation before IEEE Std
1003.1-2001.
In my
On Thu, 13 Aug 2015, Marcelo Araujo wrote:
Author: araujo
Date: Thu Aug 13 02:31:23 2015
New Revision: 286715
URL: https://svnweb.freebsd.org/changeset/base/286715
Log:
Remove the mention of memcpy(3) that is build on top of bcopy(3).
Fix some phrases to make it more clear.
Differential
On Mon, 10 Aug 2015, Xin Li wrote:
On 8/10/15 22:51, Ed Schouten wrote:
2015-08-11 1:20 GMT+02:00 Xin Li delp...@delphij.net:
Do you have a better solution for this? No, this is not ideal
but I didn't find a better alternative (or maybe I have missed
something obvious?)
I think with the
On Wed, 12 Aug 2015, Marcelo Araujo wrote:
Log:
Describe that bcopy(3) is deprecated and marked as LEGACY in
POSIX.1-2001 and removed from the specification in POSIX.1-2008.
Only new and old POSIX software and all Standard C software. Standard
C never had bcopy(). POSIX didn't have it
On Sun, 9 Aug 2015, Warner Losh wrote:
Since when is LEFT shifting a signed number undefined. It is RIGHT
shifting that???s undefined???
Always. It always shifts out the sign bit in the usual 2's complement
representation, so must be undefined in that case. It is undefined by
definition in
On Mon, 10 Aug 2015, Marcelo Araujo wrote:
2015-08-09 19:51 GMT+08:00 Ed Schouten e...@nuxi.nl:
Hi Marcelo,
2015-08-04 4:34 GMT+02:00 Marcelo Araujo ara...@freebsd.org:
Sync the code with the OpenBSD version.
That's a shame. It looks like improvements that we made to our version
have
On Tue, 4 Aug 2015, Jung-uk Kim wrote:
Log:
Fix style(9) bugs.
Thanks.
Modified:
head/sys/x86/include/_types.h
Modified: head/sys/x86/include/_types.h
==
--- head/sys/x86/include/_types.h Tue Aug 4
On Tue, 4 Aug 2015, Ed Schouten wrote:
2015-08-04 10:51 GMT+02:00 Edward Tomasz Napierala tr...@freebsd.org:
Mark vgonel() as static. It was already declared static earlier;
no idea why compilers don't warn about this.
That's because according to the standard, those keywords are meant
On Tue, 4 Aug 2015, Pedro F. Giffuni wrote:
Log:
Revert r286144 leaving the original fix to the buffer overflow.
Some developers consider the new code unnecessarily obfuscated.
There was also a benign off-by-one.
Discussed with:bde, vangyzen, jmallett
It is this version that is
901 - 1000 of 2128 matches
Mail list logo