Re: [U-Boot] [PATCH 15/28] net/memac_phy: reuse driver for little endian SoCs

2015-03-19 Thread Shaohui Xie
> > /* IFC */ > > #define CONFIG_SYS_FSL_IFC_LE > > +#define CONFIG_SYS_MEMAC_LITTLE_ENDIAN > > It seems tedious to have to define this. Can't you just use the functions > available? > > [S.H] To use a define is based on a concern that we cannot assume the I/O > access of an IP share same end

Re: [U-Boot] [PATCH 15/28] net/memac_phy: reuse driver for little endian SoCs

2015-03-19 Thread Joe Hershberger
On Thu, Mar 19, 2015 at 10:48 PM, Shaohui Xie wrote: > > > /* IFC */ > > > #define CONFIG_SYS_FSL_IFC_LE > > > +#define CONFIG_SYS_MEMAC_LITTLE_ENDIAN > > > > It seems tedious to have to define this. Can't you just use the functions available? > > > > [S.H] To use a define is based on a concern

Re: [U-Boot] [PATCH 15/28] net/memac_phy: reuse driver for little endian SoCs

2015-03-19 Thread Joe Hershberger
> Sent: Friday, March 20, 2015 2:04 AM > To: Sun York-R58495 > Cc: u-boot; Joe Hershberger; Xie Shaohui-B21989 > Subject: Re: [U-Boot] [PATCH 15/28] net/memac_phy: reuse driver for little endian SoCs > > > > Hi Shaohui Xie, > > On Thu, Mar 19, 2015 at 11:45 AM, York Sun wro

Re: [U-Boot] [PATCH 15/28] net/memac_phy: reuse driver for little endian SoCs

2015-03-19 Thread Shaohui Xie
/memac_phy: reuse driver for little endian SoCs Hi Shaohui Xie, On Thu, Mar 19, 2015 at 11:45 AM, York Sun mailto:york...@freescale.com>> wrote: > > From: Shaohui Xie > mailto:shaohui@freescale.com>> > > The memac for PHY management on little endian SoCs is similar

Re: [U-Boot] [PATCH 15/28] net/memac_phy: reuse driver for little endian SoCs

2015-03-19 Thread Joe Hershberger
Hi Shaohui Xie, On Thu, Mar 19, 2015 at 11:45 AM, York Sun wrote: > > From: Shaohui Xie > > The memac for PHY management on little endian SoCs is similar on big > endian SoCs, so we modify the driver by using I/O accessor function to > handle the endianness, so the driver can be reused on little

[U-Boot] [PATCH 15/28] net/memac_phy: reuse driver for little endian SoCs

2015-03-19 Thread York Sun
From: Shaohui Xie The memac for PHY management on little endian SoCs is similar on big endian SoCs, so we modify the driver by using I/O accessor function to handle the endianness, so the driver can be reused on little endian SoCs, we introduce CONFIG_SYS_MEMAC_LITTLE_ENDIAN for little endian SoC