Re: [uClinux-dev] [RFC/PATCH] m68knommu: add support for Coldfire m5441x

2012-05-31 Thread Steven King
On Thursday 24 May 2012 10:55:32 pm Greg Ungerer wrote: > > This looks pretty good overall. Only a couple of comments below. > Otherwise I'd like to commit it to the m68knommu git tree (after the > current merge window closes). Sure. Actually what I'd like to do is after the merge window closes

Re: [uClinux-dev] [PATCH] m68knommu: Add quirk and force fec to use RMII mode for m5441x.

2012-05-31 Thread Steven King
On Thursday 24 May 2012 11:05:31 pm Greg Ungerer wrote: > > +#ifdef CONFIG_M5441x > > +#define FEC_NAME "enet-fec" > > So I see that the iMX guys have used a device type prefix here for > the fec name. Does it make any sense to use something like that > for the 5441x as well? So "5441x-fec"? O

Re: [uClinux-dev] m528x qspi definition fix

2012-05-31 Thread Steven King
On Saturday 05 May 2012 1:40:44 pm Steven King wrote: > Hi Greg, > > The consolidation of the qspi code missed a definition for 528x. > > Signed-off-by: Steven King > --- > arch/m68k/include/asm/m528xsim.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/m68k/in

[uClinux-dev] [PATCH] m68knommu: Clean up printing of sections

2012-05-31 Thread Geert Uytterhoeven
- Remove casts and unneeded address-of ('&') operators, - Use %p to format pointers, %lx to format unsigned longs. Signed-off-by: Geert Uytterhoeven --- Not even compile tested arch/m68k/kernel/setup_no.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/arc

[uClinux-dev] [PATCH/RFC] mtd/uclinux: Use generic __bss_stop instead of _ebss

2012-05-31 Thread Geert Uytterhoeven
The standard (see BSS_SECTION() in and ) symbol for the end of BSS is __bss_stop. This allows to remove all local declarations that have been added to several architectures just to please CONFIG_MTD_UCLINUX. Not-Yet-Signed-off-by: Geert Uytterhoeven --- This is a prerequisite for some future m68

Re: [uClinux-dev] [PATCH/RFC] mtd/uclinux: Use generic __bss_stop instead of _ebss

2012-05-31 Thread Paul Mundt
On Thu, May 31, 2012 at 10:55:39PM +0200, Geert Uytterhoeven wrote: > The standard (see BSS_SECTION() in and > ) symbol for the end of BSS is __bss_stop. > This allows to remove all local declarations that have been added to > several architectures just to please CONFIG_MTD_UCLINUX. > > Not-Yet-S

Re: [uClinux-dev] [RFC/PATCH] m68knommu: add support for Coldfire m5441x

2012-05-31 Thread Greg Ungerer
Hi Steven, On 31/05/12 20:20, Steven King wrote: On Thursday 24 May 2012 10:55:32 pm Greg Ungerer wrote: This looks pretty good overall. Only a couple of comments below. Otherwise I'd like to commit it to the m68knommu git tree (after the current merge window closes). Sure. Actually what I'd

Re: [uClinux-dev] [PATCH] m68knommu: Add quirk and force fec to use RMII mode for m5441x.

2012-05-31 Thread Greg Ungerer
Hi Steven, On 31/05/12 20:23, Steven King wrote: On Thursday 24 May 2012 11:05:31 pm Greg Ungerer wrote: +#ifdef CONFIG_M5441x +#define FEC_NAME "enet-fec" So I see that the iMX guys have used a device type prefix here for the fec name. Does it make any sense to use something like that

Re: [uClinux-dev] m528x qspi definition fix

2012-05-31 Thread Greg Ungerer
Hi Steven, On 31/05/12 21:00, Steven King wrote: On Saturday 05 May 2012 1:40:44 pm Steven King wrote: Hi Greg, The consolidation of the qspi code missed a definition for 528x. Signed-off-by: Steven King --- arch/m68k/include/asm/m528xsim.h |2 +- 1 files changed, 1 insertions(+), 1 de

Re: [uClinux-dev] [PATCH] m68knommu: Clean up printing of sections

2012-05-31 Thread Greg Ungerer
Hi Geert, On 01/06/12 06:23, Geert Uytterhoeven wrote: - Remove casts and unneeded address-of ('&') operators, - Use %p to format pointers, %lx to format unsigned longs. Signed-off-by: Geert Uytterhoeven Looks good. Compile and run tested, all ok. Acked-by: Greg Ungerer Regards Greg

Re: [uClinux-dev] [PATCH/RFC] mtd/uclinux: Use generic __bss_stop instead of _ebss

2012-05-31 Thread Greg Ungerer
Hi Geert, On 01/06/12 06:55, Geert Uytterhoeven wrote: The standard (see BSS_SECTION() in and ) symbol for the end of BSS is __bss_stop. This allows to remove all local declarations that have been added to several architectures just to please CONFIG_MTD_UCLINUX. Looks good to me. Compile and