Re: [webkit-dev] Compiling WebKit up to 25% faster in Windows?

2013-03-26 Thread James Robinson
Also keep in mind that currently different build systems hack the include path up to have the same #include point to different headers depending on the build configuration, so the path expansion for a given #include will not be the same for all ports. It's basically a very non-obvious way to do #i

Re: [webkit-dev] window.internals abuse

2013-03-14 Thread James Robinson
On Thu, Mar 14, 2013 at 1:47 PM, Ryosuke Niwa wrote: > \On Thu, Mar 14, 2013 at 1:43 PM, James Robinson wrote: > >> The patch in question landed nearly a year ago and was added in order to >> test functionality that was (at the time) implemented in WebCore. >> window.te

Re: [webkit-dev] window.internals abuse

2013-03-14 Thread James Robinson
The patch in question landed nearly a year ago and was added in order to test functionality that was (at the time) implemented in WebCore. window.testRunner may have been a better choice, I don't remember what the state of it at the time was. Nowadays the functionality under test is no longer in

Re: [webkit-dev] Feature Announcement: IndieUI: Events

2013-03-05 Thread James Robinson
On Tue, Mar 5, 2013 at 9:11 AM, Chris Fleizach wrote: > Hello, > > I'm planning on implementing the IndieUI Events 1.0 W3C spec > https://dvcs.w3.org/hg/IndieUI/raw-file/default/src/indie-ui-events.html > > > This feature's primary goal is to allow assistive technologies (like a > Screen reader)

Re: [webkit-dev] New web-facing CSS feature: -webkit-cursor-visibility: auto-hide

2013-03-04 Thread James Robinson
On Mon, Mar 4, 2013 at 4:52 PM, Jer Noble wrote: > > On Mar 4, 2013, at 4:46 PM, Ryosuke Niwa wrote: > > Could you add either build or runtime flag? > > > I most definitely could. But are there any ports who would disable the > flag? (Honestly asking, here.) If not, adding a feature flag may

Re: [webkit-dev] Enable CANVAS_PATH by default

2013-02-14 Thread James Robinson
On Thu, Feb 14, 2013 at 9:55 AM, Dirk Schulze wrote: > Hi WebKit folks, > > I worked on the Path interface defined by the Canvas spec of W3C and > WHATWG [1][2] for the last couple of weeks. > > Summary: > Canvas supports a new DOM interface called Path. The Path interface takes > a series of ver

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

2013-02-09 Thread James Robinson
On Sat, Feb 9, 2013 at 11:52 AM, Maciej Stachowiak wrote: > > On Feb 9, 2013, at 10:11 AM, Adam Barth wrote: > > On Fri, Feb 8, 2013 at 8:19 PM, Maciej Stachowiak wrote: > >> >> On Feb 8, 2013, at 2:33 PM, Darin Fisher wrote: >> >> I would recommend minimizing the re-architecture of WebCore as

Re: [webkit-dev] Exporting symbols (was Re: Common build system (was Re: WebKit Wishes))

2013-02-02 Thread James Robinson
On Fri, Feb 1, 2013 at 5:12 PM, Balazs Kelemen wrote: > On 02/01/2013 02:28 AM, Darin Fisher wrote: > >> >> It would be nice if, in the shared library build of chromium, webcore and >> perhaps the modules and platform were separate DLLs. >> >> > The shared library build is kind of a developer bui

Re: [webkit-dev] Breaking other ports

2013-01-29 Thread James Robinson
On Tue, Jan 29, 2013 at 6:29 PM, Ryosuke Niwa wrote: > On Tue, Jan 29, 2013 at 5:46 PM, Adam Barth wrote: > >> I understand that the new "rules of the road" for WebKit2 are that >> contributors are allowed to break non-Apple ports. However, those new >> norms do not extend to WebCore. >> >> In

Re: [webkit-dev] Adding element to WebCore

2012-11-29 Thread James Robinson
On Thu, Nov 29, 2012 at 6:08 PM, James Craig wrote: > Snipping somewhat for brevity… > > This is an interesting standards debate but as many people have noted it does not belong on the webkit-dev list, which is for coordinating the development of WebKit. Please take this over to whatwg@ or some

Re: [webkit-dev] Status of multithreaded image decoding

2012-08-20 Thread James Robinson
On Fri, Aug 17, 2012 at 1:54 AM, Dong Seong Hwang wrote: > 2012/8/14 Dong Seong Hwang > > Trigger image decoding early in layout and scroll will certainly > > relieve flashing though it can’t completely remove the problem. We > > will apply this optimization to parallel image decoder. > > > > I c

Re: [webkit-dev] Status of multithreaded image decoding

2012-08-10 Thread James Robinson
On Thu, Aug 9, 2012 at 5:10 PM, Alpha Lam wrote: > Hi everyone! > > A few weeks ago some folks from company100.net have started a thread of > multithreaded (parallel) image decoding in WebKit. We have worked together > since then to get a better idea how to complete this feature. I would like > t

Re: [webkit-dev] Can we distinguish imported tests in LayoutTests/css3 ?

2012-06-11 Thread James Robinson
There are plenty of non-text tests in fast/, even entire directories of them (fast/repaint). My understanding of the meaning of fast/ is that it is where new tests that are not imported should go. This meaning is not universally applied. - James On Jun 11, 2012 7:33 PM, "Mike Lawther" wrote: > I

Re: [webkit-dev] Settings::devicePixelRatio and Settings::defaultDeviceScaleFactor

2012-05-31 Thread James Robinson
(top-posting to fit in) Doesn't the same argument apply to *deviceScaleFactor? That doesn't make sense as a Setting either. Pushing one or both out of settings doesn't answer the question of whether they are redundant. My gut feeling is that they are and we should fold them together. Alternate

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-25 Thread James Robinson
On Fri, May 25, 2012 at 1:42 PM, Žan Doberšek wrote: > > > On Fri, May 25, 2012 at 9:57 AM, Dominik Röttsches < > dominik.rottsc...@intel.com> wrote: > >> Andrei, >> >> >> On 05/25/2012 02:43 AM, Andrei Bucur wrote: >> >> Ojan, >> >> As Simon states, some repaint tests will likely not be possib

Re: [webkit-dev] Using namespace std

2012-05-16 Thread James Robinson
On Wed, May 16, 2012 at 12:04 PM, Anders Carlsson wrote: > > On May 16, 2012, at 9:31 AM, Darin Adler wrote: > > > On May 16, 2012, at 9:20 AM, Allan Sandfeld Jensen wrote: > > > >> there is another conflict which is entirely our own fault. It is > between WTF::bind and the new std::bind from C++

Re: [webkit-dev] github mirror

2012-04-24 Thread James Robinson
On Tue, Apr 24, 2012 at 7:15 AM, Tor Arne Vestbø wrote: > On 24.04.12 16:04, ext Shezan Baig wrote: > >> On Tue, Apr 24, 2012 at 9:55 AM, Adam Roben wrote: >> >>> In what situation does this cause issues? >>> >>> Probably the biggest issue is for people who've been using >>> git.webkit.org a

Re: [webkit-dev] handling failing tests (test_expectations, Skipped files, etc.)

2012-04-09 Thread James Robinson
> > 3) Don't use test_expectations.txt to suppress failures across a > single cycle of the bot, just so you can gather updated baselines > without the tree going red. While it might seem that you're doing tree > maintainers a favor, in my experience this just makes things confusing > and it's bette

Re: [webkit-dev] Git/SVN is slow

2012-03-14 Thread James Robinson
On Wed, Mar 14, 2012 at 2:08 PM, William Siegrist wrote: > On Mar 14, 2012, at 1:47 PM, Robert Hogan wrote: > > > On Wednesday 14 March 2012 08:44:46 Ashod Nakashian wrote: > >>> From: Nikolas Zimmermann > >>> To: WebKit Development > >>> Cc: > >>> Sent: Wednesday, March 14, 2012 1:31 AM > >>>

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-07 Thread James Robinson
On Wed, Mar 7, 2012 at 3:21 PM, Dan Bernstein wrote: > Please set the svn:mime-type property on binary files that you add to the > tree, such as *-expected.png, before committing. Otherwise the resulting > webkit-changes message will include those files as text, which is > inconvenient. > Step 3

Re: [webkit-dev] Initial painting time changed?

2012-01-30 Thread James Robinson
On Mon, Jan 30, 2012 at 12:19 PM, Nikolas Zimmermann < zimmerm...@physik.rwth-aachen.de> wrote: > > Am 30.01.2012 um 19:38 schrieb James Robinson: > > >> The document was laid out and painted once before the timeout fired. Most >> SVG repainting tests work this way:

Re: [webkit-dev] Initial painting time changed?

2012-01-30 Thread James Robinson
On Mon, Jan 30, 2012 at 3:56 AM, Nikolas Zimmermann < zimmerm...@physik.rwth-aachen.de> wrote: > Good evening WebKit folks, > > while working on some SVG Filter dynamic update issues I found out that > long-standing assumptions about the paint time don't hold anymore: > > > > > function doTest(

Re: [webkit-dev] Question regarding rebaseline for Layout Test Result for EFL port

2012-01-23 Thread James Robinson
On Mon, Jan 16, 2012 at 12:02 AM, Gyuyoung Kim wrote: > Hello WebKit folks. > > It looks that the result of layout test for EFL port needs rebaseline > because of 101343. The revision modified line spacing of font in > SimpleFontDataFreeType.cpp, and it seems that the existing layout test > resul

Re: [webkit-dev] New CSS property -webkit-control-text-overflow

2012-01-12 Thread James Robinson
What is the status of this feature in the CSS WG? I would expect this information to be available in the announcement and/or the feature bug but I cannot find it. - James On Jan 11, 2012 11:30 PM, "Jon Lee" wrote: > Hi WebKit! > > I wanted to let you know that we would like to add a new CSS prop

Re: [webkit-dev] layout tests: how are some compared against image, and others only text?

2012-01-04 Thread James Robinson
On Wed, Jan 4, 2012 at 3:39 PM, Elliot Poger wrote: > What is it that causes some tests to require baseline images (and not text > files) for comparison, while others require text and not image baselines? > > (I know that I can specifically SKIP comparison against IMAGE and/or TEXT > using test_e

Re: [webkit-dev] New feature flag proposal: Joystick API

2011-10-06 Thread James Robinson
On Thu, Oct 6, 2011 at 2:07 PM, Alexey Proskuryakov wrote: > > 06.10.2011, в 13:49, Scott Graham написал(а): > > The first revision of the spec (from the Scope section) is intended to > handle: > > ... support for devices common to current gaming systems including > gamepads, directional pads, jo

Re: [webkit-dev] New feature flag proposal: Joystick API

2011-10-06 Thread James Robinson
On Thu, Oct 6, 2011 at 11:07 AM, Alexey Proskuryakov wrote: > > I share Simon's concern that that providing low level access to every > possible controller creates fragmentation, with purportedly "HTML" content > that only works on a few devices. There is no clear cut border here - it's > been me

Re: [webkit-dev] Please use platform prefixes in bug titles

2011-10-05 Thread James Robinson
On Wed, Oct 5, 2011 at 5:43 PM, Simon Fraser wrote: > On Oct 5, 2011, at 5:37 PM, Darin Adler wrote: > > > Hi folks. > > > > It really helps frequent reviewers like me if you use platform prefixes > on bugs. A platform prefix indicates that the bug only affects code on a > particular platform. Fo

Re: [webkit-dev] Change to style guideline: should use type& instead of type* for out arguments

2011-10-04 Thread James Robinson
On Tue, Oct 4, 2011 at 2:06 PM, Ryosuke Niwa wrote: > Hi, > > It came to my attention that some people are using raw pointers to pass > out-arguments (e.g. bug 69366). In my understanding, we use pass by > reference for out arguments when they have to be modified in callees. > > If there's no obj

Re: [webkit-dev] Enable REQUEST_ANIMATION_FRAME on all ports? (was Re: ENABLE flag cleanup strawman proposal)

2011-09-27 Thread James Robinson
On Tue, Sep 27, 2011 at 10:34 AM, Chris Marrin wrote: > > On Sep 26, 2011, at 9:48 PM, James Robinson wrote: > > > > What happened at frame 9? Instead of advancing by 15 milliseconds worth, > the bird jumped forward by twice the normal amount. Why? We ran the rAF >

Re: [webkit-dev] Enable REQUEST_ANIMATION_FRAME on all ports? (was Re: ENABLE flag cleanup strawman proposal)

2011-09-26 Thread James Robinson
On Sun, Sep 25, 2011 at 6:52 PM, Darin Adler wrote: > On Sep 25, 2011, at 12:20 AM, James Robinson wrote: > > > The TIMER based support for RAF is very new (only a few weeks old) and > still has several major bugs. I'd suggest letting it bake for a bit before > considerin

Re: [webkit-dev] Enable REQUEST_ANIMATION_FRAME on all ports? (was Re: ENABLE flag cleanup strawman proposal)

2011-09-25 Thread James Robinson
On Sat, Sep 24, 2011 at 11:29 PM, Adam Barth wrote: > On Sat, Sep 24, 2011 at 11:21 PM, Adam Barth wrote: > > On Thu, Sep 15, 2011 at 11:06 AM, Adam Barth wrote: > >> On Wed, Sep 14, 2011 at 11:06 PM, Darin Fisher > wrote: > >>> What about ENABLE(REQUEST_ANIMATION_FRAME)? > >> > >> That might

Re: [webkit-dev] new APIs for strokes with dash in Canvas

2011-09-22 Thread James Robinson
On Thu, Sep 22, 2011 at 7:31 PM, Young Han Lee wrote: > Hi all, > > I have a patch to add webkitLineDash and webkitLineDashOffset APIs on > CanvasRenderingContext2D on https://bugs.webkit.org/show_bug.cgi?id=63933 > > The purpose of these APIs is to support for strokes with dash in Canvas. > > Al

Re: [webkit-dev] New feature announcement - Implement HTML5 Microdata in WebKit

2011-09-22 Thread James Robinson
On Thu, Sep 22, 2011 at 2:32 PM, Charles Pritchard wrote: > On 9/22/2011 2:13 PM, Ian Hickson wrote: > >> On Fri, 23 Sep 2011, Dean Jackson wrote: >> >>> However, isn't prefixing designed to avoid incompatibilities in spec >>> changes, not incompatibilities between implementations? Ensuring no >>

Re: [webkit-dev] Mouse Lock API

2011-09-21 Thread James Robinson
On Wed, Sep 21, 2011 at 11:11 AM, Alexey Proskuryakov wrote: > > 21.09.2011, в 10:56, Eric Uhrhane написал(а): > > >> one can always move the mouse pointer to top of screen to get back their > menu bar. > > Is that a Mac thing? > > Yes, this is how fullscreen applications regularly work on OS X.

Re: [webkit-dev] ENABLE flag cleanup strawman proposal

2011-09-14 Thread James Robinson
== Always Enable == > > ENABLE(DETAILS) ??? > ENABLE(DOM_STORAGE) > ENABLE(EVENTSOURCE) > ENABLE(INSPECTOR) ??? > ENABLE(METER_TAG) > ENABLE(OFFLINE_WEB_APPLICATIONS) > ENABLE(PROGRESS_TAG) > ENABLE(SVG_ANIMATION) => Gated on ENABLE(SVG) > ENABLE(SVG_AS_IMAGE) => Gated on ENABLE(SVG) > ENABLE(SVG_

Re: [webkit-dev] run-bindings-tests

2011-09-08 Thread James Robinson
On Thu, Sep 8, 2011 at 11:49 AM, Alexey Proskuryakov wrote: > > 08.09.2011, в 11:32, Eric Seidel написал(а): > > > FYI: As many of you already know, the build.webkit.org bots run > > "run-bindings-tests" on (almost) all platforms. > > > > They've been running (mostly w/o incident) on the bots si

Re: [webkit-dev] Chromium "GPU" LayoutTests

2011-08-22 Thread James Robinson
On Mon, Aug 22, 2011 at 3:24 PM, Adam Barth wrote: > On Mon, Aug 22, 2011 at 3:18 PM, James Robinson wrote: > > On Mon, Aug 22, 2011 at 3:07 PM, Adam Barth wrote: > >> On Mon, Aug 22, 2011 at 3:02 PM, James Robinson > wrote: > >> > On Mon, Aug 22, 201

Re: [webkit-dev] Chromium "GPU" LayoutTests

2011-08-22 Thread James Robinson
On Mon, Aug 22, 2011 at 3:07 PM, Adam Barth wrote: > On Mon, Aug 22, 2011 at 3:02 PM, James Robinson wrote: > > On Mon, Aug 22, 2011 at 2:55 PM, Adam Barth wrote: > >> I've been trying to wrap my mind around the "GPU" LayoutTests that > >> Chrom

Re: [webkit-dev] Chromium "GPU" LayoutTests

2011-08-22 Thread James Robinson
On Mon, Aug 22, 2011 at 2:55 PM, Adam Barth wrote: > I've been trying to wrap my mind around the "GPU" LayoutTests that > Chromium runs. In > , there are > the following directories: > > chromium-gpu > chromium-gpu-cg-mac > chromium-gpu-

Re: [webkit-dev] help with commit queue failure

2011-08-18 Thread James Robinson
On Thu, Aug 18, 2011 at 2:05 PM, Sailesh Agrawal wrote: > Hi all, I'm trying to commit a patch through commit queue and I'm getting a > strange error: > http://queues.webkit.org/results/9419886 > >From that output, I'd guess that there was a merge conflict trying to apply the patch. That output

Re: [webkit-dev] LayoutTests results fallback graph

2011-07-10 Thread James Robinson
On Jul 10, 2011 10:53 AM, "Adam Barth" wrote: > > Hi webkit-dev, > > In trying to understand how our LayoutTest results system works, I've > created a digram of the fallback graph among the various > platform-specific directories: > > https://docs.google.com/drawings/d/1z65SKkWrD4Slm6jobIphHwwRADy

Re: [webkit-dev] Accessibility Object Searching

2011-06-22 Thread James Robinson
On Wed, Jun 22, 2011 at 4:21 PM, Chris Fleizach wrote: > > On Jun 22, 2011, at 3:34 PM, Dominic Mazzoni wrote: > > > I just had another thought: how would this work in a multi-process > browser? > > > > As you may know, Chrome runs an instance of webkit in a separate > > renderer process for each

Re: [webkit-dev] Adding ENABLE_FLEXBOX to WebCore

2011-06-08 Thread James Robinson
ally confident in understanding how the ENABLE_'d code interacts with the rest of the codebase. - James > > -Darin > > > On Wed, Jun 8, 2011 at 4:29 PM, James Robinson wrote: > >> On Wed, Jun 8, 2011 at 4:20 PM, Darin Fisher wrote: >> >>> It seems lik

Re: [webkit-dev] Adding ENABLE_FLEXBOX to WebCore

2011-06-08 Thread James Robinson
On Wed, Jun 8, 2011 at 4:20 PM, Darin Fisher wrote: > It seems like it doesn't scale very well to have to stand-up new buildbots > for each > new feature. At least in the Chromium port, it is possible for the > Chromium repo > to override ENABLE_ flags so that only DRT gets built with a prototyp

Re: [webkit-dev] Do we have a style preference about const member functions?

2011-06-01 Thread James Robinson
On Tue, May 31, 2011 at 12:08 PM, Geoffrey Garen wrote: > I agree that const should be used for "logical constness". The rule should >> not be merely "doesn't alter any data members of this object" but rather >> "does not alter observable state of this object or vend any type of pointer >> or ref

Re: [webkit-dev] Cherry-Pick Bug Comments

2011-05-27 Thread James Robinson
I find these cherry-pick bug comments annoying and hope that you will stop generating them. There are many ports that make releases based off of WebKit trunk, and all of them have some notion of release branches that contain cherry-picked revisions, reverts, etc. As a developer it's nearly always

Re: [webkit-dev] Dropping support for WML?

2011-04-12 Thread James Robinson
I have a related question - what sort of test coverage is there for WML currently on the core bots? Do any of the core bots compile with WML enabled? I've made and reviewed a few changes to WML code made parallel to changes to the HTML forms code in the past and have made the WML edits essentiall

Re: [webkit-dev] XHTMLMP support

2011-03-08 Thread James Robinson
Which WebKit browser is using XHTMLMP? - James On Tue, Mar 8, 2011 at 4:43 PM, Ra Kyounga wrote: > Currently, XHTMLMP is used in webkit browser for mobile business. > > So, I think it's good to leave it for a while :) > > 2011. 3. 8., 오전 5:09, Eric Seidel 작성: > > > Are any ports still using tha

[webkit-dev] http://build.webkit.org/console fails to load in Chromium (appears to be server side bug)

2011-01-19 Thread James Robinson
http://build.webkit.org/console fails to load in Chromium (and Google Chrome) today. It seems that the bug is in the server's Accept-Encoding: handling. If the Accept-Encoding line includes 'sdch' then the server closes the socket without sending any response bytes. Requests for other pages like

Re: [webkit-dev] make-script-test-wrappers not being maintained

2011-01-18 Thread James Robinson
On Tue, Jan 18, 2011 at 4:30 PM, Darin Adler wrote: > It seems that a lot of people are making script tests with non-standard > wrappers. And not adding exceptions to the make-script-test-wrappers > script. I ran the script and it created 4 files, and modified 33 others. > > Any ideas on how to i

Re: [webkit-dev] Exposing CSS pixel metrics to the scripting environment

2010-11-26 Thread James Robinson
Are you posting here because there is something specific to WebKit in your query or because you dislike the outcome of the WHATWG thread? Most of us follow the WHATWG closely and generally prefer to discuss standardization issues such as this in that forum to get a broader feedback base. - James

[webkit-dev] Checking include paths in WebCore for bad dependencies

2010-11-08 Thread James Robinson
Within WebCore there are a number of directories that can be thought of as components with fairly well-defined dependencies. For example, WebCore/platform is intended to be a base component that the rest of WebCore can depend on but that should not have any outward dependencies. It's possible tha

Re: [webkit-dev] W3C Proposal: User Interface Independence for Accessible Rich Internet Applications

2010-11-05 Thread James Robinson
On Fri, Nov 5, 2010 at 6:52 PM, Adam Barth wrote: > On Fri, Nov 5, 2010 at 6:40 PM, James Robinson wrote: > > On Fri, Nov 5, 2010 at 6:32 PM, James Craig wrote: > >> Ojan Vafai wrote: > >> > >> How is [ DOMAttributeChangeRequestEvent ] any different than &

Re: [webkit-dev] W3C Proposal: User Interface Independence for Accessible Rich Internet Applications

2010-11-05 Thread James Robinson
On Fri, Nov 5, 2010 at 6:32 PM, James Craig wrote: > Ojan Vafai wrote: > > How is [ DOMAttributeChangeRequestEvent ] any different than > DOMAttrModified? The spec claims it doesn't have the problems that > DOMAttrModified has, but I don't see how that's the case. > > > > DOMAttrModified is a not

Re: [webkit-dev] Protecting against stale pointers in DrawingBuffer and GraphicsContext3D

2010-10-12 Thread James Robinson
On Tue, Oct 12, 2010 at 3:46 PM, Maciej Stachowiak wrote: > > On Oct 12, 2010, at 2:37 PM, Darin Fisher wrote: > > On Tue, Oct 12, 2010 at 1:20 PM, Maciej Stachowiak wrote: > > Hmm, I've found weak pointer abstractions to be very useful. The issue > with reference counting is that it is "easy"

Re: [webkit-dev] Pixel test experiment

2010-10-12 Thread James Robinson
To add a concrete data point, http://trac.webkit.org/changeset/69517 caused a number of SVG tests to fail. It required 14 text rebaselines for Mac and a further two more for Leopard (done by Adam Barth). In order to pass the pixel tests in Chromium, it required 1506 new pixel baselines (checked i

Re: [webkit-dev] Protecting against stale pointers in DrawingBuffer and GraphicsContext3D

2010-10-12 Thread James Robinson
On Tue, Oct 12, 2010 at 9:47 AM, Chris Marrin wrote: > > On Oct 11, 2010, at 5:15 PM, Maciej Stachowiak wrote: > > > > > On Oct 11, 2010, at 4:03 PM, Chris Marrin wrote: > > > >> > >> On Oct 11, 2010, at 3:35 PM, James Robinson wrote: > >&g

Re: [webkit-dev] Protecting against stale pointers in DrawingBuffer and GraphicsContext3D

2010-10-11 Thread James Robinson
On Mon, Oct 11, 2010 at 4:03 PM, Chris Marrin wrote: > > On Oct 11, 2010, at 3:35 PM, James Robinson wrote: > > > On Mon, Oct 11, 2010 at 3:15 PM, Chris Marrin wrote: > > > > For accelerated 2D rendering we created a class called DrawingBuffer. > This encaps

Re: [webkit-dev] Protecting against stale pointers in DrawingBuffer and GraphicsContext3D

2010-10-11 Thread James Robinson
On Mon, Oct 11, 2010 at 3:15 PM, Chris Marrin wrote: > > For accelerated 2D rendering we created a class called DrawingBuffer. This > encapsulates the accelerated drawing surface (usually in the GPU) and the > compositing layer used to display that surface on the page. The drawing > surface (whic

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-27 Thread James Robinson
On Mon, Sep 27, 2010 at 6:37 PM, Maciej Stachowiak wrote: > > On Sep 27, 2010, at 3:19 PM, Michael Nordman wrote: > > Webkit's XHR currently does not keep two copies of the data that I can see. > I think we should avoid that. > > > We could keep the raw data around, which hopefully is directly us

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-27 Thread James Robinson
On Mon, Sep 27, 2010 at 2:40 PM, Anne van Kesteren < annevankeste...@gmail.com> wrote: > (I'm subscribed to webkit-dev with a different address.) > > On Mon, Sep 27, 2010 at 8:31 PM, Michael Nordman > wrote: > > Yes, if we go with telling xhr up front for the array buffer case, I > guess > > an e

Re: [webkit-dev] Arena is crufty?

2010-09-01 Thread James Robinson
On Wed, Sep 1, 2010 at 4:20 PM, Chris Marrin wrote: > > Ken's PODRedBlackTree patch has made me go back and take a closer look at > WebKit's Arena "class". Turns out it's not a class at all, just some structs > and macros. That seems very un-WebKit-like to me. Ken's patch also has a > PODArena cl

Re: [webkit-dev] style question for empty for loops

2010-08-26 Thread James Robinson
The style guide currently covers this http://webkit.org/coding/coding-style.html: 4. Control clauses without a body should use empty braces:Right: for ( ; current; current = current->next) { } Wrong: for ( ; current; current = current->next); - James On Thu, Aug 26, 2010 at 12:22 PM, Chris F

Re: [webkit-dev] Checking allocation failures [was: Re: Naked new considered harmful]

2010-08-25 Thread James Robinson
On Wed, Aug 25, 2010 at 2:34 PM, Adam Barth wrote: > On Wed, Aug 25, 2010 at 2:31 PM, Stephan Assmus > wrote: > > Am 25.08.2010 18:35, schrieb Adam Barth: > >> On Wed, Aug 25, 2010 at 7:09 AM, Stephan Assmus > >> wrote: > >>> Am 24.08.2010 19:46, schrieb Adam Barth: > One thing Darin and I

Re: [webkit-dev] cr-win bot broken -- GYP Ninjas, please help.

2010-08-14 Thread James Robinson
Indeed! Dimitri or I will fix the python by Monday. - James On Aug 14, 2010 11:31 AM, "Adam Barth" wrote: The Chromium bots were supposed to have their Python upgraded ages ago. If we ever want to run the LayoutTests on them, they'll need their Python upgraded anyway. I think the correct solut

Re: [webkit-dev] DOM Mutation Events. WAS: Fwd: webkit editing rewrite?

2010-08-09 Thread James Robinson
On Mon, Aug 9, 2010 at 4:39 PM, Ojan Vafai wrote: > On Thu, Aug 5, 2010 at 2:22 AM, Adam Barth wrote: > >> On Thu, Aug 5, 2010 at 1:59 AM, Maciej Stachowiak wrote: >> > If mutation events tend to break editing, one simple solution is to turn >> then off within the scope of editing operations an

Re: [webkit-dev] review queue crazy idea

2010-07-21 Thread James Robinson
I've had patches sit in the review queue for >4 weeks then receive a positive review and land without much incident. Some patches are difficult to review or have a limited number of potential reviewers. I would have really appreciated a reminder email about that patch in particular (I honestly ha

Re: [webkit-dev] Frustrated at inconsiderate behavior

2010-07-07 Thread James Robinson
On Wed, Jul 7, 2010 at 7:19 PM, Oliver Hunt wrote: > > On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote: > > > > On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao wrote: > >> Maybe I should complain this in a different threads, but recently the >> commit bot waiting time is way too long. Several tim

Re: [webkit-dev] On adding 'console.memory' API (and about the whole 'console' object.)

2010-06-04 Thread James Robinson
How? Visited state information is not stored in the javascript heap (which is what this object contains information about). - James On Fri, Jun 4, 2010 at 12:06 PM, David Hyatt wrote: > I'm fairly certain I could construct an attack on :visited history privacy > using this object. > > dave > >

Re: [webkit-dev] Pixel test differences between Leopard and Snow Leopard

2010-05-19 Thread James Robinson
t;> On May 17, 2010, at 3:44 PM, James Robinson wrote: >> >> After this is done it should be possible to run the full layout test suite >> with --tolerance=0 on Snow Leopard and have no failures. Assuming this >> happens, I would like to switch the default value of

[webkit-dev] Pixel test differences between Leopard and Snow Leopard

2010-05-17 Thread James Robinson
Leopard and Snow Leopard have subtle differences in the way they render antialiased text. This does not affect the text metrics but does cause slight pixel differences. The majority of our existing pixel test baselines appear to have been generated on Leopard, but there is a growing minority of t

Re: [webkit-dev] Testing changes to CodeGenerator*.pm

2010-04-29 Thread James Robinson
As a concrete example, I found this test setup helpful for this patch: http://trac.webkit.org/changeset/58345. A nice side effect was that it revealed a bug in CodeGeneratorGObject.pm and let me fix it without having to set up build setup for whatever it is that uses the GObject bindings. I agree

Re: [webkit-dev] WTF::callOnMainThread() and re-entrancy

2010-03-08 Thread James Robinson
I saw a very similar bug recently regarding modal dialogs and focus/blur events: https://bugs.webkit.org/show_bug.cgi?id=33962. I think you will see the crash from that stacktrace with or without r55593 in place. For example, currently some mouse event handlers can fire underneath a window.alert

Re: [webkit-dev] Making browsers faster: Resource Packages

2009-11-17 Thread James Robinson
ting Apache than the guys making webpages, >> and I think if a technique is extremely useful, it's easier to get support >> into Apache than into, say, 50% of the webpages out there. > > There's no damage if you don't do this as a web author. If you care enough &g

Re: [webkit-dev] Making browsers faster: Resource Packages

2009-11-17 Thread James Robinson
On Tue, Nov 17, 2009 at 3:02 PM, Peter Kasting wrote: > On Tue, Nov 17, 2009 at 3:00 PM, James Robinson wrote: >> >> It seems like a browser will have to essentially stop rendering until >> it has finished downloading the entire .zip and examined it. > > I think mitig

Re: [webkit-dev] Making browsers faster: Resource Packages

2009-11-17 Thread James Robinson
On Tue, Nov 17, 2009 at 2:19 PM, Alexander Limi wrote: > > Good people of Webkit! > > We'd all like for the web to be faster, and therefore I'd love your feedback > on my proposal — it would be great to see support for this in additional > browsers, not just Firefox: > > http://limi.net/articles

Re: [webkit-dev] [chromium-dev] Learning Webkit: High Level Webkit overview?

2009-10-06 Thread James Robinson
On Sun, Oct 4, 2009 at 8:19 AM, Buakaw San wrote: > > There is a document called "How Chromium Displays Web Pages" (http:// > dev.chromium.org/developers/design-documents/displaying-a-web-page-in- > chrome), however I haven't found an equivalent page for Webkit. E.g. > "How Webkit Renders Web Pag

Re: [webkit-dev] Purging as much memory as possible

2009-10-02 Thread James Robinson
On Fri, Oct 2, 2009 at 12:10 PM, Peter Kasting wrote: > On Fri, Oct 2, 2009 at 11:13 AM, Geoffrey Garen wrote: >> >> Live items cannot be removed from the cache. > > > Yeah, I think that is what I'm seeing. > > Assume the page is not being painted (e.g. the window is minimized). Is > there a wa

[webkit-dev] Instrumentation framework for WebKit

2009-04-30 Thread James Robinson
It's difficult to understand the performance of a large web app nowadays - think GMail scale and beyond, in part because a lot of things happen in the UI thread outside of javascript. For example layout, selector matching and painting can all happen in a deferred way, take a lot of time and yet no