Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
On 21/02/2019 22:48, Sergey Bylokhov wrote: On 21/02/2019 04:23, Alexey Ivanov wrote: Thank you, Sergey, for looking into this. I guess this case requires more investigation. At first sight, it does not look right, does it? Right, I am not sure that "IndexColorModel" is selected intentionally. I have submitted: https://bugs.openjdk.java.net/browse/JDK-8219996 -- Regards, Alexey
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
On 21/02/2019 04:23, Alexey Ivanov wrote: Thank you, Sergey, for looking into this. I guess this case requires more investigation. At first sight, it does not look right, does it? Right, I am not sure that "IndexColorModel" is selected intentionally. -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
On 14/02/2019 22:39, Sergey Bylokhov wrote: On 14/02/2019 13:02, Alexey Ivanov wrote: BTW do we sure that the usage of IndexColorModel is not a bug? I don't think it's a bug. Likely Windows Server OS is installed in Server Code mode which has limited GUI support. I was able to get IndexColorModel on my desktop by something like this: User1: - sleep for 10 sec - > run java program -> print color model for the current GC -> pause - win+L User2: - Login to User2 -> wait 10 sec User1: - IndexColorModel will be printed, instead of DirectColorModel. Thank you, Sergey, for looking into this. I guess this case requires more investigation. At first sight, it does not look right, does it? -- Regards, Alexey
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
On 14/02/2019 13:02, Alexey Ivanov wrote: BTW do we sure that the usage of IndexColorModel is not a bug? I don't think it's a bug. Likely Windows Server OS is installed in Server Code mode which has limited GUI support. I was able to get IndexColorModel on my desktop by something like this: User1: - sleep for 10 sec - > run java program -> print color model for the current GC -> pause - win+L User2: - Login to User2 -> wait 10 sec User1: - IndexColorModel will be printed, instead of DirectColorModel. -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
On 14/02/2019 16:04, Sergey Bylokhov wrote: It looks fine. Thank you, Sergey! BTW do we sure that the usage of IndexColorModel is not a bug? I don't think it's a bug. Likely Windows Server OS is installed in Server Code mode which has limited GUI support. Regards, Alexey On 14/02/2019 06:07, Alexey Ivanov wrote: Hi Sergey, Do you have any comments for the latest webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.01/ Do I push the fix? Regards, Alexey On 12/02/2019 18:33, Phil Race wrote: +1 -phil. On 2/12/19 6:24 AM, Alexey Ivanov wrote: Hi Phil, On 11/02/2019 18:32, Phil Race wrote: On 2/11/19 1:44 AM, Alexey Ivanov wrote: Hi Phil, On 08/02/2019 21:02, Phil Race wrote: can you add @key headful to all these tests ? Yes, I can if you think it's required. Yes. I think it is required. Please see the updated webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.01/ These three test are not run in mach5. Regards, Alexey I was thinking whether I shall add a diagnostic message for skipping VolatileImage when IndexColorModel is in effect… sure. -phil. Regards, Alexey -phil. On 2/8/19 12:13 PM, Alexey Ivanov wrote: Hi, Please review the fix for jdk 13: bugs: https://bugs.openjdk.java.net/browse/JDK-8218682 https://bugs.openjdk.java.net/browse/JDK-8198411 webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.00/ Description: The updated DashOffset test proved to fail in mach5. It passed BufferedImage test and then failed VolatileImage test. VolatileImage had different colours instead of the expected white, blue and green. Root cause: The host uses IndexColorModel; the image uses the closest colour. Thus the colours do not match. It's also the reason why DashScaleMinWidth.java and DashZeroWidth.java fail in mach5. Fix: Skip testing VolatileImage where default graphics configuration uses IndexColorModel. I'm removing DashScaleMinWidth.java and DashZeroWidth.java from ProblemList.txt as the tests pass now. Regards, Alexey
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
It looks fine. BTW do we sure that the usage of IndexColorModel is not a bug? On 14/02/2019 06:07, Alexey Ivanov wrote: Hi Sergey, Do you have any comments for the latest webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.01/ Do I push the fix? Regards, Alexey On 12/02/2019 18:33, Phil Race wrote: +1 -phil. On 2/12/19 6:24 AM, Alexey Ivanov wrote: Hi Phil, On 11/02/2019 18:32, Phil Race wrote: On 2/11/19 1:44 AM, Alexey Ivanov wrote: Hi Phil, On 08/02/2019 21:02, Phil Race wrote: can you add @key headful to all these tests ? Yes, I can if you think it's required. Yes. I think it is required. Please see the updated webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.01/ These three test are not run in mach5. Regards, Alexey I was thinking whether I shall add a diagnostic message for skipping VolatileImage when IndexColorModel is in effect… sure. -phil. Regards, Alexey -phil. On 2/8/19 12:13 PM, Alexey Ivanov wrote: Hi, Please review the fix for jdk 13: bugs: https://bugs.openjdk.java.net/browse/JDK-8218682 https://bugs.openjdk.java.net/browse/JDK-8198411 webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.00/ Description: The updated DashOffset test proved to fail in mach5. It passed BufferedImage test and then failed VolatileImage test. VolatileImage had different colours instead of the expected white, blue and green. Root cause: The host uses IndexColorModel; the image uses the closest colour. Thus the colours do not match. It's also the reason why DashScaleMinWidth.java and DashZeroWidth.java fail in mach5. Fix: Skip testing VolatileImage where default graphics configuration uses IndexColorModel. I'm removing DashScaleMinWidth.java and DashZeroWidth.java from ProblemList.txt as the tests pass now. Regards, Alexey -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
Hi Sergey, Do you have any comments for the latest webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.01/ Do I push the fix? Regards, Alexey On 12/02/2019 18:33, Phil Race wrote: +1 -phil. On 2/12/19 6:24 AM, Alexey Ivanov wrote: Hi Phil, On 11/02/2019 18:32, Phil Race wrote: On 2/11/19 1:44 AM, Alexey Ivanov wrote: Hi Phil, On 08/02/2019 21:02, Phil Race wrote: can you add @key headful to all these tests ? Yes, I can if you think it's required. Yes. I think it is required. Please see the updated webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.01/ These three test are not run in mach5. Regards, Alexey I was thinking whether I shall add a diagnostic message for skipping VolatileImage when IndexColorModel is in effect… sure. -phil. Regards, Alexey -phil. On 2/8/19 12:13 PM, Alexey Ivanov wrote: Hi, Please review the fix for jdk 13: bugs: https://bugs.openjdk.java.net/browse/JDK-8218682 https://bugs.openjdk.java.net/browse/JDK-8198411 webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.00/ Description: The updated DashOffset test proved to fail in mach5. It passed BufferedImage test and then failed VolatileImage test. VolatileImage had different colours instead of the expected white, blue and green. Root cause: The host uses IndexColorModel; the image uses the closest colour. Thus the colours do not match. It's also the reason why DashScaleMinWidth.java and DashZeroWidth.java fail in mach5. Fix: Skip testing VolatileImage where default graphics configuration uses IndexColorModel. I'm removing DashScaleMinWidth.java and DashZeroWidth.java from ProblemList.txt as the tests pass now. Regards, Alexey
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
+1 -phil. On 2/12/19 6:24 AM, Alexey Ivanov wrote: Hi Phil, On 11/02/2019 18:32, Phil Race wrote: On 2/11/19 1:44 AM, Alexey Ivanov wrote: Hi Phil, On 08/02/2019 21:02, Phil Race wrote: can you add @key headful to all these tests ? Yes, I can if you think it's required. Yes. I think it is required. Please see the updated webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.01/ These three test are not run in mach5. Regards, Alexey I was thinking whether I shall add a diagnostic message for skipping VolatileImage when IndexColorModel is in effect… sure. -phil. Regards, Alexey -phil. On 2/8/19 12:13 PM, Alexey Ivanov wrote: Hi, Please review the fix for jdk 13: bugs: https://bugs.openjdk.java.net/browse/JDK-8218682 https://bugs.openjdk.java.net/browse/JDK-8198411 webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.00/ Description: The updated DashOffset test proved to fail in mach5. It passed BufferedImage test and then failed VolatileImage test. VolatileImage had different colours instead of the expected white, blue and green. Root cause: The host uses IndexColorModel; the image uses the closest colour. Thus the colours do not match. It's also the reason why DashScaleMinWidth.java and DashZeroWidth.java fail in mach5. Fix: Skip testing VolatileImage where default graphics configuration uses IndexColorModel. I'm removing DashScaleMinWidth.java and DashZeroWidth.java from ProblemList.txt as the tests pass now. Regards, Alexey
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
Hi Phil, On 11/02/2019 18:32, Phil Race wrote: On 2/11/19 1:44 AM, Alexey Ivanov wrote: Hi Phil, On 08/02/2019 21:02, Phil Race wrote: can you add @key headful to all these tests ? Yes, I can if you think it's required. Yes. I think it is required. Please see the updated webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.01/ These three test are not run in mach5. Regards, Alexey I was thinking whether I shall add a diagnostic message for skipping VolatileImage when IndexColorModel is in effect… sure. -phil. Regards, Alexey -phil. On 2/8/19 12:13 PM, Alexey Ivanov wrote: Hi, Please review the fix for jdk 13: bugs: https://bugs.openjdk.java.net/browse/JDK-8218682 https://bugs.openjdk.java.net/browse/JDK-8198411 webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.00/ Description: The updated DashOffset test proved to fail in mach5. It passed BufferedImage test and then failed VolatileImage test. VolatileImage had different colours instead of the expected white, blue and green. Root cause: The host uses IndexColorModel; the image uses the closest colour. Thus the colours do not match. It's also the reason why DashScaleMinWidth.java and DashZeroWidth.java fail in mach5. Fix: Skip testing VolatileImage where default graphics configuration uses IndexColorModel. I'm removing DashScaleMinWidth.java and DashZeroWidth.java from ProblemList.txt as the tests pass now. Regards, Alexey
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
On 12/02/2019 02:14, Sergey Bylokhov wrote: On 11/02/2019 10:41, Alexey Ivanov wrote: Let me experiment with this. Would it be acceptable if I submit a new CR to improve these tests? Ok, fine. Submitted https://bugs.openjdk.java.net/browse/JDK-8218827 -- Regards, Alexey
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
On 11/02/2019 10:41, Alexey Ivanov wrote: Let me experiment with this. Would it be acceptable if I submit a new CR to improve these tests? Ok, fine. -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
On 11/02/2019 18:27, Sergey Bylokhov wrote: On 11/02/2019 09:28, Alexey Ivanov wrote: No, it does not look like it's possible directly. In the case of DashOffset, VolatileImage contains #F8F8F8 instead of #FF, #CC instead of #FF, #00CC00 instead of #00FF00. In other configurations, the colours could be different. BufferedImage contains the expected colours. But I thought the colors should be the same if the BI was created using IndexColorModel(or any other used by VI) instead of default color model? Now I got your idea. It should work. Actually, it can be used to get the values of the “dynamic” colours to validate VolatileImage, thus avoiding comparing the colour of every single pixel. Let me experiment with this. Would it be acceptable if I submit a new CR to improve these tests? -- Regards, Alexey
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
On 2/11/19 1:44 AM, Alexey Ivanov wrote: Hi Phil, On 08/02/2019 21:02, Phil Race wrote: can you add @key headful to all these tests ? Yes, I can if you think it's required. Yes. I think it is required. However, I think we should keep them without @key headful so that they're run more regularly. BufferedImage can be used in headless environment. I think that the isHeadless() test was not catching the case when some VM is in use that really should not have run the test. The fix is still valid but I think we should have this too. This way jtreg won't bother even running the test if there's no head. Isn't isHeadless() used by jtreg itself? Not so far as I know. These tests seem to have failed only in Windows where there's no true headless environment. Recent versions of Windows Server allow installing the OS without support for desktop environment, it could be the reason why we see the limited IndexColorModel. I was thinking whether I shall add a diagnostic message for skipping VolatileImage when IndexColorModel is in effect… sure. -phil. Regards, Alexey -phil. On 2/8/19 12:13 PM, Alexey Ivanov wrote: Hi, Please review the fix for jdk 13: bugs: https://bugs.openjdk.java.net/browse/JDK-8218682 https://bugs.openjdk.java.net/browse/JDK-8198411 webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.00/ Description: The updated DashOffset test proved to fail in mach5. It passed BufferedImage test and then failed VolatileImage test. VolatileImage had different colours instead of the expected white, blue and green. Root cause: The host uses IndexColorModel; the image uses the closest colour. Thus the colours do not match. It's also the reason why DashScaleMinWidth.java and DashZeroWidth.java fail in mach5. Fix: Skip testing VolatileImage where default graphics configuration uses IndexColorModel. I'm removing DashScaleMinWidth.java and DashZeroWidth.java from ProblemList.txt as the tests pass now. Regards, Alexey
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
On 11/02/2019 09:28, Alexey Ivanov wrote: No, it does not look like it's possible directly. In the case of DashOffset, VolatileImage contains #F8F8F8 instead of #FF, #CC instead of #FF, #00CC00 instead of #00FF00. In other configurations, the colours could be different. BufferedImage contains the expected colours. But I thought the colors should be the same if the BI was created using IndexColorModel(or any other used by VI) instead of default color model? -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
Hi Sergey, On 11/02/2019 17:03, Sergey Bylokhov wrote: Hi, Alexey. On 11/02/2019 01:44, Alexey Ivanov wrote: Isn't isHeadless() used by jtreg itself? These tests seem to have failed only in Windows where there's no true headless environment. Recent versions of Windows Server allow installing the OS without support for desktop environment, it could be the reason why we see the limited IndexColorModel. I was thinking whether I shall add a diagnostic message for skipping VolatileImage when IndexColorModel is in effect… Is it possible in case of non-default color model to use BufferedImages as gold version to compare? No, it does not look like it's possible directly. In the case of DashOffset, VolatileImage contains #F8F8F8 instead of #FF, #CC instead of #FF, #00CC00 instead of #00FF00. In other configurations, the colours could be different. BufferedImage contains the expected colours. However, it could be possible to analyse the change in colour rather than absolute values. For example, a colour with equal R-G-B components could be considered as “white”; a colour with only blue component could be considered as “blue”, and similarly for green. The problem with this approach is that we assume that such colours exist in IndexColorModel. Since we don't control IndexColorModel, this assumption could be wrong, and we'd get a false failure. If we didn't assume specific colours but rather assigned dynamic values to “white”, “blue” and “green” based on the colours in the image, the tests could become more useful as the coverage would increase. But validation code should be somewhat different for VolatileImage from that for BufferedImage. -- Regards, Alexey
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
Hi, Alexey. On 11/02/2019 01:44, Alexey Ivanov wrote: Isn't isHeadless() used by jtreg itself? These tests seem to have failed only in Windows where there's no true headless environment. Recent versions of Windows Server allow installing the OS without support for desktop environment, it could be the reason why we see the limited IndexColorModel. I was thinking whether I shall add a diagnostic message for skipping VolatileImage when IndexColorModel is in effect… Is it possible in case of non-default color model to use BufferedImages as gold version to compare? -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
Hi Phil, On 08/02/2019 21:02, Phil Race wrote: can you add @key headful to all these tests ? Yes, I can if you think it's required. However, I think we should keep them without @key headful so that they're run more regularly. BufferedImage can be used in headless environment. I think that the isHeadless() test was not catching the case when some VM is in use that really should not have run the test. The fix is still valid but I think we should have this too. This way jtreg won't bother even running the test if there's no head. Isn't isHeadless() used by jtreg itself? These tests seem to have failed only in Windows where there's no true headless environment. Recent versions of Windows Server allow installing the OS without support for desktop environment, it could be the reason why we see the limited IndexColorModel. I was thinking whether I shall add a diagnostic message for skipping VolatileImage when IndexColorModel is in effect… Regards, Alexey -phil. On 2/8/19 12:13 PM, Alexey Ivanov wrote: Hi, Please review the fix for jdk 13: bugs: https://bugs.openjdk.java.net/browse/JDK-8218682 https://bugs.openjdk.java.net/browse/JDK-8198411 webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.00/ Description: The updated DashOffset test proved to fail in mach5. It passed BufferedImage test and then failed VolatileImage test. VolatileImage had different colours instead of the expected white, blue and green. Root cause: The host uses IndexColorModel; the image uses the closest colour. Thus the colours do not match. It's also the reason why DashScaleMinWidth.java and DashZeroWidth.java fail in mach5. Fix: Skip testing VolatileImage where default graphics configuration uses IndexColorModel. I'm removing DashScaleMinWidth.java and DashZeroWidth.java from ProblemList.txt as the tests pass now. Regards, Alexey
Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
can you add @key headful to all these tests ? I think that the isHeadless() test was not catching the case when some VM is in use that really should not have run the test. The fix is still valid but I think we should have this too. This way jtreg won't bother even running the test if there's no head. -phil. On 2/8/19 12:13 PM, Alexey Ivanov wrote: Hi, Please review the fix for jdk 13: bugs: https://bugs.openjdk.java.net/browse/JDK-8218682 https://bugs.openjdk.java.net/browse/JDK-8198411 webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.00/ Description: The updated DashOffset test proved to fail in mach5. It passed BufferedImage test and then failed VolatileImage test. VolatileImage had different colours instead of the expected white, blue and green. Root cause: The host uses IndexColorModel; the image uses the closest colour. Thus the colours do not match. It's also the reason why DashScaleMinWidth.java and DashZeroWidth.java fail in mach5. Fix: Skip testing VolatileImage where default graphics configuration uses IndexColorModel. I'm removing DashScaleMinWidth.java and DashZeroWidth.java from ProblemList.txt as the tests pass now. Regards, Alexey
[OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5
Hi, Please review the fix for jdk 13: bugs: https://bugs.openjdk.java.net/browse/JDK-8218682 https://bugs.openjdk.java.net/browse/JDK-8198411 webrev: http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.00/ Description: The updated DashOffset test proved to fail in mach5. It passed BufferedImage test and then failed VolatileImage test. VolatileImage had different colours instead of the expected white, blue and green. Root cause: The host uses IndexColorModel; the image uses the closest colour. Thus the colours do not match. It's also the reason why DashScaleMinWidth.java and DashZeroWidth.java fail in mach5. Fix: Skip testing VolatileImage where default graphics configuration uses IndexColorModel. I'm removing DashScaleMinWidth.java and DashZeroWidth.java from ProblemList.txt as the tests pass now. Regards, Alexey
