Translations tracking for Amarok 2.8
Hi! We are still tracking the translations of the last Qt4 Amarok branch (2.9). Can I safely assume that the next version, whenever it happens, will be Qt5-based (master), which means that we can stop tracking that branch for translations? (please cc me, I'm not subscribed) Ciao -- Luigi
Re: Review Request 129192: Add namespace to desktop and appdata files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/ --- (Updated Feb. 26, 2017, 8:42 p.m.) Status -- This change has been marked as submitted. Review request for Amarok and Matthias Klumpp. Changes --- Submitted with commit 22e0ac2baf0975a1dabbfa7892f8c52c38990235 by Luigi Toscano to branch master. Repository: amarok Description --- - add the organization namespace to the desktop and then appdata files, according the specification; - use the new directory for metadata (metainfo) files. Diffs - src/CMakeLists.txt 327ec10 src/amarok.appdata.xml c580fd5 src/amarok.desktop src/amarok_containers.desktop src/dbus/mpris2/MediaPlayer2.cpp a1d1bda Diff: https://git.reviewboard.kde.org/r/129192/diff/ Testing --- Compiles, the files are installed in the expected places. Thanks, Luigi Toscano
Re: Review Request 129192: Add namespace to desktop and appdata files
> On Feb. 23, 2017, 2:04 p.m., Matěj Laitl wrote: > > Ah, sorry for inactivity. Issue dropped. > > > > OTOH I'm still thinking about value/risk of this change. Pro: according to > > standards. Con: existing .desktop links may stop working. Has anyone tested > > this for example with Amarok shortcut in panel, desktop in various DEs? > > Others, what do you think? A link in the Plasma panel created with the old name will point to a non-existing desktop file. Same for a link created into to the desktop (but not if the desktop is copied). About the standards: the risk is having bugs coming from downstream distributions if the appstream checks are enforced. On the other side, if 2.9 is going to be released soon, the change could go to the kf5 branch only (as I guess that whatever will happen after 2.9, there won't be new kdelibs4 versions). I'd still prefer to fix it now (with 2.9 going out "soon") than wait for the future Frameworks version. - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/#review102578 ----------- On Ott. 16, 2016, 4:12 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > --- > > (Updated Ott. 16, 2016, 4:12 p.m.) > > > Review request for Amarok and Matthias Klumpp. > > > Repository: amarok > > > Description > --- > > - add the organization namespace to the desktop and then appdata files, > according the specification; > - use the new directory for metadata (metainfo) files. > > > Diffs > - > > src/CMakeLists.txt 327ec10 > src/amarok.appdata.xml c580fd5 > src/amarok.desktop > src/amarok_containers.desktop > src/dbus/mpris2/MediaPlayer2.cpp a1d1bda > > Diff: https://git.reviewboard.kde.org/r/129192/diff/ > > > Testing > --- > > Compiles, the files are installed in the expected places. > > > Thanks, > > Luigi Toscano > >
Re: Review Request 129192: Add namespace to desktop and appdata files
> On Oct. 16, 2016, 12:06 p.m., Matěj Laitl wrote: > > src/CMakeLists.txt, lines 955-958 > > <https://git.reviewboard.kde.org/r/129192/diff/1/?file=482253#file482253line955> > > > > What about these .desktop files? I seems that these should be moved, > > too, at least for consistency. > > Luigi Toscano wrote: > No, those are services. The specification talks about the reverse DNS > syntax only for applications: > " For applications, the part of the name of the desktop file (before the > .desktop) should follow the "reverse DNS" convention, e.g. > org.example.FooViewer.desktop. " > > > https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s02.html > > Luigi Toscano wrote: > I think that the other comments answer this point; do you have any other > concern? This is one of the last combination of desktop+appdata files on > kde.org without namespace. Gently ping... - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/#review100035 --- On Oct. 16, 2016, 4:12 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > --- > > (Updated Oct. 16, 2016, 4:12 p.m.) > > > Review request for Amarok and Matthias Klumpp. > > > Repository: amarok > > > Description > --- > > - add the organization namespace to the desktop and then appdata files, > according the specification; > - use the new directory for metadata (metainfo) files. > > > Diffs > - > > src/CMakeLists.txt 327ec10 > src/amarok.appdata.xml c580fd5 > src/amarok.desktop > src/amarok_containers.desktop > src/dbus/mpris2/MediaPlayer2.cpp a1d1bda > > Diff: https://git.reviewboard.kde.org/r/129192/diff/ > > > Testing > --- > > Compiles, the files are installed in the expected places. > > > Thanks, > > Luigi Toscano > >
Re: Review Request 129192: Add namespace to desktop and appdata files
> On Ott. 16, 2016, 12:06 p.m., Matěj Laitl wrote: > > src/CMakeLists.txt, lines 955-958 > > <https://git.reviewboard.kde.org/r/129192/diff/1/?file=482253#file482253line955> > > > > What about these .desktop files? I seems that these should be moved, > > too, at least for consistency. > > Luigi Toscano wrote: > No, those are services. The specification talks about the reverse DNS > syntax only for applications: > " For applications, the part of the name of the desktop file (before the > .desktop) should follow the "reverse DNS" convention, e.g. > org.example.FooViewer.desktop. " > > > https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s02.html I think that the other comments answer this point; do you have any other concern? This is one of the last combination of desktop+appdata files on kde.org without namespace. - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/#review100035 ------- On Ott. 16, 2016, 4:12 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > --- > > (Updated Ott. 16, 2016, 4:12 p.m.) > > > Review request for Amarok and Matthias Klumpp. > > > Repository: amarok > > > Description > --- > > - add the organization namespace to the desktop and then appdata files, > according the specification; > - use the new directory for metadata (metainfo) files. > > > Diffs > - > > src/CMakeLists.txt 327ec10 > src/amarok.appdata.xml c580fd5 > src/amarok.desktop > src/amarok_containers.desktop > src/dbus/mpris2/MediaPlayer2.cpp a1d1bda > > Diff: https://git.reviewboard.kde.org/r/129192/diff/ > > > Testing > --- > > Compiles, the files are installed in the expected places. > > > Thanks, > > Luigi Toscano > >
Re: Review Request 129192: Add namespace to desktop and appdata files
> On Ott. 16, 2016, 11:12 p.m., Matthias Klumpp wrote: > > Please rename the .desktop files too, the name of the .desktop file and the > > value of the `` tag must match for this to work. > > The DBus activation and Wayland window mapping will also only work with the > > renamed .desktop files. > > Matthias Klumpp wrote: > Ah, I see it's renamed in the cmake install section - a bit > unconventional, but it will work. The desktop files for Type=Application are renamed in the patch. The first question was about desktop files which represent Service. If I read the specification correctly, the requirement for the namespace is only for desktop files for applications, is it correct? The second question is: how much does the change break stuff like customer-set file applications and/or shortcuts in panels? - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/#review100051 ------- On Ott. 16, 2016, 4:12 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > --- > > (Updated Ott. 16, 2016, 4:12 p.m.) > > > Review request for Amarok and Matthias Klumpp. > > > Repository: amarok > > > Description > --- > > - add the organization namespace to the desktop and then appdata files, > according the specification; > - use the new directory for metadata (metainfo) files. > > > Diffs > - > > src/CMakeLists.txt 327ec10 > src/amarok.appdata.xml c580fd5 > src/amarok.desktop > src/amarok_containers.desktop > src/dbus/mpris2/MediaPlayer2.cpp a1d1bda > > Diff: https://git.reviewboard.kde.org/r/129192/diff/ > > > Testing > --- > > Compiles, the files are installed in the expected places. > > > Thanks, > > Luigi Toscano > >
Re: Review Request 129192: Add namespace to desktop and appdata files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/ --- (Updated Ott. 16, 2016, 4:12 p.m.) Review request for Amarok and Matthias Klumpp. Changes --- Really updated now, sorry for the spam. Repository: amarok Description --- - add the organization namespace to the desktop and then appdata files, according the specification; - use the new directory for metadata (metainfo) files. Diffs (updated) - src/CMakeLists.txt 327ec10 src/amarok.appdata.xml c580fd5 src/amarok.desktop src/amarok_containers.desktop src/dbus/mpris2/MediaPlayer2.cpp a1d1bda Diff: https://git.reviewboard.kde.org/r/129192/diff/ Testing --- Compiles, the files are installed in the expected places. Thanks, Luigi Toscano
Re: Review Request 129192: Add namespace to desktop and appdata files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/ --- (Updated Ott. 16, 2016, 4:10 p.m.) Review request for Amarok and Matthias Klumpp. Repository: amarok Description --- - add the organization namespace to the desktop and then appdata files, according the specification; - use the new directory for metadata (metainfo) files. Diffs (updated) - src/CMakeLists.txt 327ec10 src/amarok.appdata.xml c580fd5 src/amarok.desktop src/amarok_containers.desktop Diff: https://git.reviewboard.kde.org/r/129192/diff/ Testing --- Compiles, the files are installed in the expected places. Thanks, Luigi Toscano
Re: Review Request 129192: Add namespace to desktop and appdata files
> On Ott. 16, 2016, 12:06 p.m., Matěj Laitl wrote: > > Looks good, but see one question below. > > > > Also, I wonder what the consequences would be? People loosing custom-set > > file associations? What about shortcuts in panels etc.? > > Matěj Laitl wrote: > I also think MediaPlayer2::DesktopEntry() needs to be updated. Right for MediaPlayer2. It's possible that people would lose their favourite entry, if they linked to amarok desktop file. I'm not sure about associations, but I added the most knowledgable person about this to the review. > On Ott. 16, 2016, 12:06 p.m., Matěj Laitl wrote: > > src/CMakeLists.txt, lines 955-958 > > <https://git.reviewboard.kde.org/r/129192/diff/1/?file=482253#file482253line955> > > > > What about these .desktop files? I seems that these should be moved, > > too, at least for consistency. No, those are services. The specification talks about the reverse DNS syntax only for applications: " For applications, the part of the name of the desktop file (before the .desktop) should follow the "reverse DNS" convention, e.g. org.example.FooViewer.desktop. " https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s02.html - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/#review100035 --- On Ott. 15, 2016, 9:44 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > --- > > (Updated Ott. 15, 2016, 9:44 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > - add the organization namespace to the desktop and then appdata files, > according the specification; > - use the new directory for metadata (metainfo) files. > > > Diffs > - > > src/CMakeLists.txt 327ec10 > src/amarok.appdata.xml c580fd5 > src/amarok.desktop > src/amarok_containers.desktop > > Diff: https://git.reviewboard.kde.org/r/129192/diff/ > > > Testing > --- > > Compiles, the files are installed in the expected places. > > > Thanks, > > Luigi Toscano > >
Review Request 129192: Add namespace to desktop and appdata files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/ --- Review request for Amarok. Repository: amarok Description --- - add the organization namespace to the desktop and then appdata files, according the specification; - use the new directory for metadata (metainfo) files. Diffs - src/CMakeLists.txt 327ec10 src/amarok.appdata.xml c580fd5 src/amarok.desktop src/amarok_containers.desktop Diff: https://git.reviewboard.kde.org/r/129192/diff/ Testing --- Compiles, the files are installed in the expected places. Thanks, Luigi Toscano
