Re: [Anima] comments on anima-brski-prm
Hi Michael, Thank you again for the review and the proposed changes. I meanwhile included your proposed changes and also addressed most of the issues you raised. The results have been captured n the github discussion of open issues (https://github.com/anima-wg/anima-brski-prm/issues). The newest version is also available in this github. The remaining open issues are for discussion tomorrow in the Design Team. Most of them are already prepared. Best regards Steffen > -Original Message- > From: Anima On Behalf Of Fries, Steffen > Sent: Dienstag, 20. September 2022 15:08 > To: Michael Richardson ; anima@ietf.org > Subject: Re: [Anima] comments on anima-brski-prm > > Hi Michael, > > I put my comments inline. > > Best regards > Steffen > > > -Original Message- > > From: Anima On Behalf Of Michael Richardson > > Sent: Montag, 19. September 2022 17:50 > > Subject: [Anima] comments on anima-brski-prm > > > > I should remind people that git hates trailing whitespace, and please > > configure your editors to remove. I use emacs, and I have some code I > > use, but most editors now have an option. So some diffs you may see > > are just trailing space removal, which I guess I could have done on > main/master. > I'll keep this in mind ;-) > > > > > I made a whole bunch of small editorial fixes, which I collected at: > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > > > ub.co%2Fdata=05%7C01%7Csteffen.fries%40siemens.com%7C28dece81 > 9008 > > > 432aa88508da9b091efb%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0% > 7C6379 > > > 92760717697707%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ > QIjoiV2l > > > uMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=c > %2B%2FP > > pAIGKEXRss90QdiDk%2BoLYwnJ8ewkdtpF6IOXyLw%3Dreserved=0 > > m%2Fanima-wg%2Fanima-brski- > > > prm%2Fpull%2F76data=05%7C01%7Csteffen.fries%40siemens.com%7C1 > > > e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d55 > > > a%7C1%7C0%7C637991995576757266%7CUnknown%7CTWFpbGZsb3d8eyJWIj > > > oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C200 > > > 0%7C%7C%7Csdata=BInW0h%2BcDEGeYEKXrsPC9bH5lulIeO3NFsC7fiRSO > > Eo%3Dreserved=0 > > (I didn't make all those changes on the 18th, there was a rebase in > > the middle) You may find that the rich diff at: > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > > > ub.co%2Fdata=05%7C01%7Csteffen.fries%40siemens.com%7C28dece81 > 9008 > > > 432aa88508da9b091efb%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0% > 7C6379 > > > 92760717697707%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ > QIjoiV2l > > > uMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=c > %2B%2FP > > pAIGKEXRss90QdiDk%2BoLYwnJ8ewkdtpF6IOXyLw%3Dreserved=0 > > m%2Fanima-wg%2Fanima-brski- > > prm%2Fpull%2F76%2Ffiles%3Fshort_path%3D39089b2%23diff- > > > 39089b29400b74ce53b0f9b46cc0e8c08434b3518372da2bb356646768a1d56e& > > > amp;data=05%7C01%7Csteffen.fries%40siemens.com%7C1e3b4e1da3b64d7c39 > > > c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637 > > > 991995576757266%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC > > > JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C > > > sdata=D8HognvCph6bT2gaA9FyNfTV%2BBLO0Mgg5uBakmVGbgc%3Dres > > erved=0 > > provides for easier review. > > In many cases I just split up long paragraphs into more digestable parts. > > > Thanks, that definitely increases readability. > > > ** If it would help discussion for me to split these up into a bunch > > of separate > > ** pull requests, I can do that. > > > > I tweaked many of the diagrams so that aasvg would produce beautiful > > HTML/PDF. > Didn't know that, but it definitely looks better. > > > > > I also opened the following issues: > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > > > ub.co%2Fdata=05%7C01%7Csteffen.fries%40siemens.com%7C28dece81 > 9008 > > > 432aa88508da9b091efb%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0% > 7C6379 > > > 92760717697707%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ > QIjoiV2l > > > uMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=c > %2B%2FP > > pAIGKEXRss90QdiDk%2BoLYwnJ8ewkdtpF6IOXyLw%3Dreserved=0 > > m%2Fanima-wg%2Fanima-brski- > > > prm%2Fissues%2F75data=05%7C01%7Csteffen.fries%40siemens.com%7 > > > C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d > > 55a%7C1%7C0%7C637991995576913478%7CUnknown%7CTWFp
Re: [Anima] comments on anima-brski-prm
Hi Michael, I put my comments inline. Best regards Steffen > -Original Message- > From: Anima On Behalf Of Michael Richardson > Sent: Montag, 19. September 2022 17:50 > Subject: [Anima] comments on anima-brski-prm > > I should remind people that git hates trailing whitespace, and please > configure > your editors to remove. I use emacs, and I have some code I use, but most > editors now have an option. So some diffs you may see are just trailing space > removal, which I guess I could have done on main/master. I'll keep this in mind ;-) > > I made a whole bunch of small editorial fixes, which I collected at: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fpull%2F76data=05%7C01%7Csteffen.fries%40siemens.com%7C1 > e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d55 > a%7C1%7C0%7C637991995576757266%7CUnknown%7CTWFpbGZsb3d8eyJWIj > oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C200 > 0%7C%7C%7Csdata=BInW0h%2BcDEGeYEKXrsPC9bH5lulIeO3NFsC7fiRSO > Eo%3Dreserved=0 > (I didn't make all those changes on the 18th, there was a rebase in the > middle) > You may find that the rich diff at: > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fpull%2F76%2Ffiles%3Fshort_path%3D39089b2%23diff- > 39089b29400b74ce53b0f9b46cc0e8c08434b3518372da2bb356646768a1d56e& > amp;data=05%7C01%7Csteffen.fries%40siemens.com%7C1e3b4e1da3b64d7c39 > c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637 > 991995576757266%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC > JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C > sdata=D8HognvCph6bT2gaA9FyNfTV%2BBLO0Mgg5uBakmVGbgc%3Dres > erved=0 > provides for easier review. > In many cases I just split up long paragraphs into more digestable parts. > Thanks, that definitely increases readability. > ** If it would help discussion for me to split these up into a bunch of > separate > ** pull requests, I can do that. > > I tweaked many of the diagrams so that aasvg would produce beautiful > HTML/PDF. Didn't know that, but it definitely looks better. > > I also opened the following issues: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fissues%2F75data=05%7C01%7Csteffen.fries%40siemens.com%7 > C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d > 55a%7C1%7C0%7C637991995576913478%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 2000%7C%7C%7Csdata=kIownLfpv8NHsWec0QlDX6JGe%2BSYY7LPKwDx > XIV%2BPoE%3Dreserved=0: misuse of mDNS > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fissues%2F74data=05%7C01%7Csteffen.fries%40siemens.com%7 > C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d > 55a%7C1%7C0%7C637991995576913478%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 2000%7C%7C%7Csdata=b3kAxL1qQi9869RrZI9KGxQ7rD6cDBkBJXwT4ACo > o7k%3Dreserved=0: what is the threat for registrar-agent mis-use > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fissues%2F73data=05%7C01%7Csteffen.fries%40siemens.com%7 > C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d > 55a%7C1%7C0%7C637991995576913478%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 2000%7C%7C%7Csdata=PiIO9RNg6aYPgBScPHL%2BqNiyllVtTg9kgGfwL% > 2F8UTjI%3Dreserved=0: pledge-status responses are cumullative right? > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fissues%2F72data=05%7C01%7Csteffen.fries%40siemens.com%7 > C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d > 55a%7C1%7C0%7C637991995576913478%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 2000%7C%7C%7Csdata=lPJkOeKI%2FrMTIT3kdwoYH09opqZzcGWP19zPZ > EgzEzc%3Dreserved=0: section 5.5 is foreshadowed/repeated > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fissues%2F71data=05%7C01%7Csteffen.fries%40siemens.com%7 > C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d > 55a%7C1%7C0%7C637991995576913478%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 2000%7C%7C%7Csdata=o4ofsd6h0Ee8o7FTSTCjw0oqRMNChuttyUyot%2 > BkzdyU%3Dreserved=0: more tweaks need for ts diagram > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fissues%2F70%3Awhydata=05%7C01%7Csteffen.fries%40siemens. > com%7C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42 >
