Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY
Michael Buesch wrote: PLEASE TEST TEST TEST TEST TEST I tested your patch on my 4318, and it seems performance and stability are pretty much the same as unpatched wireless-testing. Here's what dmesg has to say: # dmesg | grep b43 b43-pci-bridge 0001:10:12.0: enabling device (0004 - 0006) b43-phy0: Broadcom 4318 WLAN found b43-phy0 debug: Found PHY: Analog 3, Type 2, Revision 7 b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 8 b43-phy0 debug: DebugFS (CONFIG_DEBUG_FS) not enabled in kernel config firmware: requesting b43/ucode5.fw firmware: requesting b43/pcm5.fw firmware: requesting b43/b0g0initvals5.fw firmware: requesting b43/b0g0bsinitvals5.fw b43-phy0: Loading firmware version 410.2160 (2007-05-26 15:32:10) b43-phy0 debug: Chip initialized b43-phy0 debug: 32-bit DMA initialized b43-phy0 debug: Wireless interface started b43-phy0 debug: Adding Interface type 2 b43-phy0: Radio turned on by software b43-phy0 debug: Using hardware based encryption for keyidx: 0, mac: 00:16:b6:a3:26:91 b43-phy0 debug: Using hardware based encryption for keyidx: 1, mac: ff:ff:ff:ff:ff:ff and the exact description of my card: # lspci -vn 0001:10:12.0 0280: 14e4:4318 (rev 02) Subsystem: 106b:4318 Flags: bus master, fast devsel, latency 16, IRQ 52 Memory at 80084000 (32-bit, non-prefetchable) [size=8K] Kernel driver in use: b43-pci-bridge Kernel modules: ssb I transfered some files around using both patched and unpatched wireless-testing, and I get very similar results in both cases: around 2.6 MB/s upload and 3.5 MB/s download. This is a couple rooms away from the AP, with a signal quality of 58/100. I will continue using this kernel for some time, and will report back here if I notice anything peculiar. I hope I didn't forget anything useful, but the bottom line is that I didn't see any difference between patched and unpatched wireless-testing, and if you need me to run some more tests, I'd be happy to; please let me know. -- Benoît ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY
2008/8/16 Michael Buesch [EMAIL PROTECTED]: This is the first part for the rewrite of the b43 PHY API. This is needed in order to make development of N and LP code possible. PLEASE TEST TEST TEST TEST TEST Lots of testing on lots of different devices is needed to ensure this doesn't introduce regressions due to typos. 95% of the patch just moves large parts of the PHY code from one file to another. More move-patches will follow. 5% of the patch introduces an ops based PHY API. Please test on all of your devices. http://bu3sch.de/patches/wireless-testing/20080816-0023/patches/002-b43-phy-ops.patch Apply against wireless-testing.git Applied to today wireless-testing git. Connected to my AP without problem, connection stable for 90min and 600MB of download. I didn't test speed performance as my antenna in broken. So everything seems to work fine for me. b43-pci-bridge :06:05.0: PCI INT A - GSI 21 (level, low) - IRQ 21 b43-phy0: Broadcom 4318 WLAN found b43-phy0 debug: Found PHY: Analog 3, Type 2, Revision 7 b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 8 input: b43-phy0 as /devices/virtual/input/input8 firmware: requesting b43/ucode5.fw firmware: requesting b43/pcm5.fw firmware: requesting b43/b0g0initvals5.fw firmware: requesting b43/b0g0bsinitvals5.fw b43-phy0: Loading firmware version 410.2160 (2007-05-26 15:32:10) b43-phy0 debug: Chip initialized b43-phy0 debug: 32-bit DMA initialized Registered led device: b43-phy0::tx Registered led device: b43-phy0::rx Registered led device: b43-phy0::radio b43-phy0 debug: Wireless interface started b43-phy0 debug: Adding Interface type 2 b43-phy0: Radio turned on by software -- Rafał Miłecki ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY
On Sat, 16 Aug 2008 00:29:56 +0200 Michael Buesch [EMAIL PROTECTED] wrote: This is the first part for the rewrite of the b43 PHY API. This is needed in order to make development of N and LP code possible. PLEASE TEST TEST TEST TEST TEST Lots of testing on lots of different devices is needed to ensure this doesn't introduce regressions due to typos. 95% of the patch just moves large parts of the PHY code from one file to another. More move-patches will follow. 5% of the patch introduces an ops based PHY API. Please test on all of your devices. http://bu3sch.de/patches/wireless-testing/20080816-0023/patches/002-b43-phy-ops.patch Apply against wireless-testing.git Tested on my 4318: $ dmesg | grep b43 b43-pci-bridge :06:02.0: enabling device ( - 0002) b43-pci-bridge :06:02.0: PCI INT A - GSI 22 (level, low) - IRQ 22 b43-pci-bridge :06:02.0: setting latency timer to 64 b43-phy0: Broadcom 4318 WLAN found b43-phy0 debug: Found PHY: Analog 3, Type 2, Revision 7 b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 8 input: b43-phy0 as /class/input/input8 firmware: requesting b43/ucode5.fw firmware: requesting b43/pcm5.fw firmware: requesting b43/b0g0initvals5.fw firmware: requesting b43/b0g0bsinitvals5.fw b43-phy0: Loading firmware version 410.2160 (2007-05-26 15:32:10) b43-phy0 debug: Chip initialized b43-phy0 debug: 32-bit DMA initialized Registered led device: b43-phy0::tx Registered led device: b43-phy0::rx Registered led device: b43-phy0::radio b43-phy0 debug: Wireless interface started b43-phy0 debug: Adding Interface type 2 b43-phy0: Radio turned on by software [Looks the same as Rafał Miłecki's] From lspci -vv: 06:02.0 Network controller: Broadcom Corporation BCM4318 [AirForce One 54g] 802.11g Wireless LAN Controller (rev 02) Subsystem: AMBIT Microsystem Corp. Device 0312 Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast TAbort- TAbort- MAbort- SERR- PERR- INTx- Latency: 64 Interrupt: pin A routed to IRQ 22 Region 0: Memory at d0002000 (32-bit, non-prefetchable) [size=8K] Kernel driver in use: b43-pci-bridge Kernel modules: ssb Performance seems fine; it's not perfect, but it's generally not. I don't know if it's the driver, environmental conditions, etc. Iperf, through a cheap home AP, to another system also connected wirelessly to the AP, both with little x and y axis displacement but two floors of z axis displacement, gives about 2.3 Mbps throughput (averaged over three iperf runs, but I know from experience that throughput seems to vary over time). I have built kernels and applied patches before, but I'm new to git; this is what I did: git-clone git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.git cd wireless-testing git-checkout -b michaels-patch patch -p1 the-patch-filename make menuconfig make make modules_install make install Is this right? [I generally build with debian's kernel-package scripts, but they didn't work on this tree, complaining about a mismatch involving UTS. I don't have the error in front of me, but it was something like a discrepancy between xxx-wl-dirty and xxx-wl-dirty-dirty-dirty.] Thanks for all your work on this, Celejar -- mailmin.sourceforge.net - remote access via secure (OpenPGP) email ssuds.sourceforge.net - A Simple Sudoku Solver and Generator ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY
On Thursday 21 August 2008 00:40:32 Larry Finger wrote: Michael Buesch wrote: This is the first part for the rewrite of the b43 PHY API. This is needed in order to make development of N and LP code possible. PLEASE TEST TEST TEST TEST TEST Lots of testing on lots of different devices is needed to ensure this doesn't introduce regressions due to typos. 95% of the patch just moves large parts of the PHY code from one file to another. More move-patches will follow. 5% of the patch introduces an ops based PHY API. Please test on all of your devices. I have now tested on a BCM4311/2 with positive results. The transmit throughput is roughly the same at 20.7 Mbs with a 54 Mbs bulk rate. Thanks :) I'll also do more testing and submit the patch soon. Anybody who didn't test his device, yet, please do so. If you discover a breakage after the merge, that will be _very_ unfortunate and we will have to live with the breakage until it is fixed (which can be very hard to do). -- Greetings Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY
On Thursday 21 August 2008 18:16:23 Sean Hodges wrote: On Sat, 2008-08-16 at 00:29 +0200, Michael Buesch wrote: This is the first part for the rewrite of the b43 PHY API. This is needed in order to make development of N and LP code possible. PLEASE TEST TEST TEST TEST TEST Lots of testing on lots of different devices is needed to ensure this doesn't introduce regressions due to typos. 95% of the patch just moves large parts of the PHY code from one file to another. More move-patches will follow. 5% of the patch introduces an ops based PHY API. Please test on all of your devices. http://bu3sch.de/patches/wireless-testing/20080816-0023/patches/002-b43-phy-ops.patch Apply against wireless-testing.git As a novice to driver development, is there some way I can help with testing this? I have no experience of driver development/testing, but have an N-PHY To say it once again: Despite the fact that the subject of this email mentiones N and LP PHYs, it implements _nothing_ N and LP related. It just _prepares_ the code for the future when we will add N and LP stuff (and other PHY stuff. Also A/B/G related). -- Greetings Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY
Thanks for the repeated explanation, the offer remains when it might be needed. Sean On Thu, 2008-08-21 at 18:58 +0200, Michael Buesch wrote: On Thursday 21 August 2008 18:16:23 Sean Hodges wrote: On Sat, 2008-08-16 at 00:29 +0200, Michael Buesch wrote: This is the first part for the rewrite of the b43 PHY API. This is needed in order to make development of N and LP code possible. PLEASE TEST TEST TEST TEST TEST Lots of testing on lots of different devices is needed to ensure this doesn't introduce regressions due to typos. 95% of the patch just moves large parts of the PHY code from one file to another. More move-patches will follow. 5% of the patch introduces an ops based PHY API. Please test on all of your devices. http://bu3sch.de/patches/wireless-testing/20080816-0023/patches/002-b43-phy-ops.patch Apply against wireless-testing.git As a novice to driver development, is there some way I can help with testing this? I have no experience of driver development/testing, but have an N-PHY To say it once again: Despite the fact that the subject of this email mentiones N and LP PHYs, it implements _nothing_ N and LP related. It just _prepares_ the code for the future when we will add N and LP stuff (and other PHY stuff. Also A/B/G related). ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY
Michael Buesch wrote: This is the first part for the rewrite of the b43 PHY API. This is needed in order to make development of N and LP code possible. PLEASE TEST TEST TEST TEST TEST Lots of testing on lots of different devices is needed to ensure this doesn't introduce regressions due to typos. 95% of the patch just moves large parts of the PHY code from one file to another. More move-patches will follow. 5% of the patch introduces an ops based PHY API. Please test on all of your devices. I have now tested on a BCM4311/2 with positive results. The transmit throughput is roughly the same at 20.7 Mbs with a 54 Mbs bulk rate. Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311
Am Montag, 18. August 2008 09:41:10 schrieb Holger Schurig: I know, which is one of the reasons I don't use a Debian-based distro. I want nothing to do with one whose stated goal is to make it so difficult to change the kernel that the users won't do it. Huh? I use make install modules_install from my kernel source dir (which I usually get via git) and that works fine, as in every distro on earth. And make-kpkg --revision 1 kernel-image isn't that much harder, either. You then get a .deb that you can install with dpkg like any other locally created package. It won't recompile everything if you don't change the revision. Simply don't complain about something you never tried... HS ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311
On Monday 18 August 2008 09:41:10 Holger Schurig wrote: I know, which is one of the reasons I don't use a Debian-based distro. I want nothing to do with one whose stated goal is to make it so difficult to change the kernel that the users won't do it. Huh? I use make install modules_install from my kernel source dir (which I usually get via git) and that works fine, as in every distro on earth. I can only second that. I simply ignore any distro specific kernel handling and override the grub/yaboot entries as I desire. I also ignore any rpm or deb for installing a kernel. I do it this way since the very beginning and it works fine on debian and non-debian distros. In general, I do always ignore the packet manager, but install custom compiled software in a specific directory so it does not interfere in any way with the distro packets. -- Greetings Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311
On Sunday 17 August 2008 21:26:21 Ehud Gavron wrote: Works fine here. iperf same results as prior to patch. b43-phy0: Broadcom 4311 WLAN found b43-phy0 debug: Found PHY: Analog 4, Type 2, Revision 8 b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2 Thanks a lot for testing. I want to encourage people again to test this patch. This really needs a lot of testing, because a regression caused by this would really really be a bad thing. Even if you think your card was already tested by somebody else, please test it anyway. There are so many different cards with matching revision numbers that really are slightly different. Get wireless-testing.git: git clone git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.git and apply the patch http://bu3sch.de/patches/wireless-testing/20080816-0023/patches/002-b43-phy-ops.patch Please test basic features, throughput and longterm stability of the connection. -- Greetings Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311
Holger Schurig wrote: Huh? I use make install modules_install from my kernel source dir (which I usually get via git) and that works fine, as in every distro on earth. Hehe, but I seldom use distro kernels, not even when I used Red Hat or Mandrake in old times :-) I tried that with Ubuntu 8.04 and the resulting kernel wouldn't boot. Only when I went through the process of making the .deb and installing that did the new kernel start properly. I didn't investigate it thoroughly as I was only testing one patch - I quickly fled back to openSUSE. Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311
On Monday 18 August 2008, Larry Finger wrote: Holger Schurig wrote: Huh? I use make install modules_install from my kernel source dir (which I usually get via git) and that works fine, as in every distro on earth. Hehe, but I seldom use distro kernels, not even when I used Red Hat or Mandrake in old times :-) I tried that with Ubuntu 8.04 and the resulting kernel wouldn't boot. Only when I went through the process of making the .deb and installing that did the new kernel start properly. I didn't investigate it thoroughly as I was only testing one patch - I quickly fled back to openSUSE. Larry I've been doing that for years, Larry. I use a couple of scripts that I edit the version patch names in, one to build the src tree, and one to actually do the compile install, leaving me to edit grub.conf/menu.lst. I can fwd them if you like. Currently running 2.6.27-rc3, much smoother than any fedora released kernel. Which I did try for about 12 hours recently, just long enough for the nvidia driver to scribble all over the system and when I had re-installed the radeon card, I had a goodly amount of my .kde to recover from amanda's carefully kept backups. !*%$^%@ nvidia crap drivers. -- Cheers, Gene There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order. -Ed Howdershelt (Author) Measure with a micrometer. Mark with chalk. Cut with an axe. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY
Larry Finger wrote: The patch works fine on the 802.11g portion of my BCM4312/1, which seems to be the same as a BCM4311/1. This card has a PCIe format. I also tested on my PCMCIA version of a BCM4318. That card works, but the maximum transmit rate is only about 1/2 of what I get without it. The card has a rev 09 802.11 core, a rev 7 PHY, and a rev 3 analog part. I still have to test on a PCI format BCM4306/3 card, but I suspect that you have already tested the 4306. Forget what I said about the loss of transmit rate. Once I did a proper test, it is the same with or without the patch. For the BCM4318, the b43 rate is slightly reduced from using bcm43xx. The difference is not really great, but a reproducible reduction from 16.6 to 14.2 Mbs with the iwconfig rate set at 54 Mbs. By comparison, the BCM4312 is over 20 Mbs. Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311
Works fine here. iperf same results as prior to patch. b43-phy0: Broadcom 4311 WLAN found b43-phy0 debug: Found PHY: Analog 4, Type 2, Revision 8 b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2 2.6.27-rc2-wl on Ubuntu 8.04 (don't even ask how long it takes to build a new kernel and create a debian package and install it...) Ehud Michael Buesch wrote: This is the first part for the rewrite of the b43 PHY API. This is needed in order to make development of N and LP code possible. PLEASE TEST TEST TEST TEST TEST Lots of testing on lots of different devices is needed to ensure this doesn't introduce regressions due to typos. 95% of the patch just moves large parts of the PHY code from one file to another. More move-patches will follow. 5% of the patch introduces an ops based PHY API. Please test on all of your devices. http://bu3sch.de/patches/wireless-testing/20080816-0023/patches/002-b43-phy-ops.patch Apply against wireless-testing.git (Not attached to the mail, as it is really big) ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311
Ehud Gavron wrote: Works fine here. iperf same results as prior to patch. b43-phy0: Broadcom 4311 WLAN found b43-phy0 debug: Found PHY: Analog 4, Type 2, Revision 8 b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2 2.6.27-rc2-wl on Ubuntu 8.04 (don't even ask how long it takes to build a new kernel and create a debian package and install it...) I know, which is one of the reasons I don't use a Debian-based distro. I want nothing to do with one whose stated goal is to make it so difficult to change the kernel that the users won't do it. Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
