Re: [blfs-dev] PulseAudio and Glibc-2.27
Ryan Marsaw wrote: On Sun, 4 Feb 2018, Bruce Dubbs wrote: Ryan Marsaw wrote: Hello. While building PulseAudio with the latest Glibc-2.27 I get the following error: [...] In file included from pulsecore/shm.c:48:0: ./pulsecore/memfd-wrappers.h:36:19: error: static declaration of 'memfd_create' follows non-static declaration static inline int memfd_create(const char *name, unsigned int flags) { ^~~~ In file included from /usr/include/bits/mman-linux.h:115:0, from /usr/include/bits/mman.h:45, from /usr/include/sys/mman.h:41, from pulsecore/shm.c:37: /usr/include/bits/mman-shared.h:46:5: note: previous declaration of 'memfd_create' was here int memfd_create (const char *__name, unsigned int __flags) __THROW; ^~~~ make[3]: *** [Makefile:8008: pulsecore/libpulsecommon_11.1_la-shm.lo] Error 1 [...] I've included a patch that fixes the issue. Reference: https://patchwork.openembedded.org/patch/147648/ The patch seems like a little overkill for us. I haven't tested it but I think sed -i '/int memfd_create/,+2 d' src/pulsecore/memfd-wrappers.h will work until a new version of pulseaudio is released. Can you check for us? -- Bruce Hi Bruce. Your sed statement worked just fine. I haven't gone through a thorough testing, but nothing appears to be any different between the patch and your workaround. Thanks for your help. -- Bruce -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] PulseAudio and Glibc-2.27
On Sun, 4 Feb 2018, Bruce Dubbs wrote: Ryan Marsaw wrote: Hello. While building PulseAudio with the latest Glibc-2.27 I get the following error: [...] In file included from pulsecore/shm.c:48:0: ./pulsecore/memfd-wrappers.h:36:19: error: static declaration of 'memfd_create' follows non-static declaration static inline int memfd_create(const char *name, unsigned int flags) { ^~~~ In file included from /usr/include/bits/mman-linux.h:115:0, from /usr/include/bits/mman.h:45, from /usr/include/sys/mman.h:41, from pulsecore/shm.c:37: /usr/include/bits/mman-shared.h:46:5: note: previous declaration of 'memfd_create' was here int memfd_create (const char *__name, unsigned int __flags) __THROW; ^~~~ make[3]: *** [Makefile:8008: pulsecore/libpulsecommon_11.1_la-shm.lo] Error 1 [...] I've included a patch that fixes the issue. Reference: https://patchwork.openembedded.org/patch/147648/ The patch seems like a little overkill for us. I haven't tested it but I think sed -i '/int memfd_create/,+2 d' src/pulsecore/memfd-wrappers.h will work until a new version of pulseaudio is released. Can you check for us? -- Bruce Hi Bruce. Your sed statement worked just fine. I haven't gone through a thorough testing, but nothing appears to be any different between the patch and your workaround. Thanks, and keep up the great work! Regards, Ryan -- Ryan Marsaw rmar...@personainternet.com -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] PulseAudio and Glibc-2.27
Ryan Marsaw wrote: Hello. While building PulseAudio with the latest Glibc-2.27 I get the following error: [...] In file included from pulsecore/shm.c:48:0: ./pulsecore/memfd-wrappers.h:36:19: error: static declaration of 'memfd_create' follows non-static declaration static inline int memfd_create(const char *name, unsigned int flags) { ^~~~ In file included from /usr/include/bits/mman-linux.h:115:0, from /usr/include/bits/mman.h:45, from /usr/include/sys/mman.h:41, from pulsecore/shm.c:37: /usr/include/bits/mman-shared.h:46:5: note: previous declaration of 'memfd_create' was here int memfd_create (const char *__name, unsigned int __flags) __THROW; ^~~~ make[3]: *** [Makefile:8008: pulsecore/libpulsecommon_11.1_la-shm.lo] Error 1 [...] I've included a patch that fixes the issue. Reference: https://patchwork.openembedded.org/patch/147648/ The patch seems like a little overkill for us. I haven't tested it but I think sed -i '/int memfd_create/,+2 d' src/pulsecore/memfd-wrappers.h will work until a new version of pulseaudio is released. Can you check for us? -- Bruce -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
[blfs-dev] PulseAudio and Glibc-2.27
Hello. While building PulseAudio with the latest Glibc-2.27 I get the following error: [...] In file included from pulsecore/shm.c:48:0: ./pulsecore/memfd-wrappers.h:36:19: error: static declaration of 'memfd_create' follows non-static declaration static inline int memfd_create(const char *name, unsigned int flags) { ^~~~ In file included from /usr/include/bits/mman-linux.h:115:0, from /usr/include/bits/mman.h:45, from /usr/include/sys/mman.h:41, from pulsecore/shm.c:37: /usr/include/bits/mman-shared.h:46:5: note: previous declaration of 'memfd_create' was here int memfd_create (const char *__name, unsigned int __flags) __THROW; ^~~~ make[3]: *** [Makefile:8008: pulsecore/libpulsecommon_11.1_la-shm.lo] Error 1 [...] I've included a patch that fixes the issue. Reference: https://patchwork.openembedded.org/patch/147648/ Regards, Ryan -- Ryan Marsaw rmar...@personainternet.com--- pulseaudio-11.1-orig/configure.ac 2017-09-05 06:46:23.0 -0400 +++ pulseaudio-11.1/configure.ac2018-02-04 14:46:52.647465714 -0500 @@ -603,6 +603,10 @@ AC_CHECK_DECL(SYS_memfd_create, [HAVE_MEMFD=1], [HAVE_MEMFD=0], [#include ]), [HAVE_MEMFD=0]) +AS_IF([test "x$enable_memfd" != "xno"], +AC_CHECK_FUNC(memfd_create, [HAVE_MEMFD_CREATE=1], [HAVE_MEMFD_CREATE=0], [#include ]), +[HAVE_MEMFD_CREATE=0]) + AS_IF([test "x$enable_memfd" = "xyes" && test "x$HAVE_MEMFD" = "x0"], [AC_MSG_ERROR([*** Your Linux kernel does not support memfd shared memory. *** Use linux v3.17 or higher for such a feature.])]) @@ -610,6 +614,9 @@ AC_SUBST(HAVE_MEMFD) AM_CONDITIONAL([HAVE_MEMFD], [test "x$HAVE_MEMFD" = x1]) AS_IF([test "x$HAVE_MEMFD" = "x1"], AC_DEFINE([HAVE_MEMFD], 1, [Have memfd shared memory.])) +AC_SUBST(HAVE_MEMFD_CREATE) +AM_CONDITIONAL([HAVE_MEMFD_CREATE], [test "x$HAVE_MEMFD_CREATE" = x1]) +AS_IF([test "x$HAVE_MEMFD_CREATE" = "x1"], AC_DEFINE([HAVE_MEMFD_CREATE], 1, [Define to 1 if you have the `memfd_create` function.])) X11 (optional) --- pulseaudio-11.1-orig/src/pulsecore/memfd-wrappers.h 2016-08-23 08:50:11.0 -0400 +++ pulseaudio-11.1/src/pulsecore/memfd-wrappers.h 2018-02-04 14:46:52.648465714 -0500 @@ -32,11 +32,11 @@ * defined in the kernel header file , that file as * a whole conflicts with the original glibc header . */ - +#ifndef HAVE_MEMFD_CREATE static inline int memfd_create(const char *name, unsigned int flags) { return syscall(SYS_memfd_create, name, flags); } - +#endif /* memfd_create(2) flags */ #ifndef MFD_CLOEXEC -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
[blfs-dev] Need help testing xf86-input-wacom-0.36.0
I do not know how to test xf86-input-wacom-0.36.0. https://downloads.sourceforge.net/linuxwacom/xf86-input-wacom-0.36.0.tar.bz2 It builds fine using the current instructions (0.1 SBU) and the 1 regression test passes. However I do not know how to actually test it. I do have a touchpad on my laptop, but don't know if wacom is used for that or not. If someone can test this driver for me, I will update the book. -- Bruce -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] Compile issue postgresql
Thomas Trepl wrote: Am Sonntag, den 04.02.2018, 13:58 +0100 schrieb Thomas Trepl: Am Sonntag, den 04.02.2018, 12:18 +0100 schrieb Armin K.: On Sun, 2018-02-04 at 11:42 +0100, Thomas Trepl wrote: Hi, got a abort message when compiling postgresql: D_GNU_SOURCE -c -o copy_fetch.o copy_fetch.c copy_fetch.c:159:1: Fehler: In Konflikt stehende Typen für »copy_file_range« copy_file_range(const char *path, off_t begin, off_t end, bool trunc) ^~~ In file included from copy_fetch.c:15:0: /usr/include/unistd.h:1110:9: Anmerkung: Vorherige Deklaration von »copy_file_range« war hier ssize_t copy_file_range (int __infd, __off64_t *__pinoff, ^~~ ... To me it looks like a clash to the standard library function copy_file_range. It's easy to fix as postgresql's copy_file_range is a static function. I did following sed sed -e "s/copy_file_range/_&/" \ -i src/bin/pg_rewind/copy_fetch.c with which compilation was successfull. Donno whether it is caused now by gcc-7.3 and/or glibc-2.27 (on i686). Have you seen that issue, too or is it something wired here locally? -- Thomas From what I've seen, glibc-2.27 introduced copy_file_range. You could try and swap any instance of copy_file_range in postgresql with, say, pg_copy_file_range to avoid conflicts (or try and delete copy_file_range in pgsql entirely, and let it use the one from glibc). Yes, now found the statement in glibc's changelog "* The copy_file_range function was added." I'll add a small sed to the postgresql instructions as it is quite easy to fix (and occurs only in one file). Should I open/fix/close a ticket for that? Upstream allready caught that issue and they said it will be fixed in "next week's round of minor releases" (10.2). So I think we can just wait a few days and problem will went away... For urgent fix, just do sed -e "s/copy_file_range/rewind_&/" -i src/bin/pg_rewind/copy_fetch.c This is what upstream did. Please go ahead and put that into the book for now. We always check sed and patch instructions when a new version of a package is released. -- Bruce -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] Compile issue postgresql
Thomas Trepl wrote: Am Sonntag, den 04.02.2018, 12:18 +0100 schrieb Armin K.: On Sun, 2018-02-04 at 11:42 +0100, Thomas Trepl wrote: Hi, got a abort message when compiling postgresql: D_GNU_SOURCE -c -o copy_fetch.o copy_fetch.c copy_fetch.c:159:1: Fehler: In Konflikt stehende Typen für »copy_file_range« copy_file_range(const char *path, off_t begin, off_t end, bool trunc) ^~~ In file included from copy_fetch.c:15:0: /usr/include/unistd.h:1110:9: Anmerkung: Vorherige Deklaration von »copy_file_range« war hier ssize_t copy_file_range (int __infd, __off64_t *__pinoff, ^~~ ... To me it looks like a clash to the standard library function copy_file_range. It's easy to fix as postgresql's copy_file_range is a static function. I did following sed sed -e "s/copy_file_range/_&/" \ -i src/bin/pg_rewind/copy_fetch.c with which compilation was successfull. Donno whether it is caused now by gcc-7.3 and/or glibc-2.27 (on i686). Have you seen that issue, too or is it something wired here locally? -- Thomas From what I've seen, glibc-2.27 introduced copy_file_range. You could try and swap any instance of copy_file_range in postgresql with, say, pg_copy_file_range to avoid conflicts (or try and delete copy_file_range in pgsql entirely, and let it use the one from glibc). Yes, now found the statement in glibc's changelog "* The copy_file_range function was added." I'll add a small sed to the postgresql instructions as it is quite easy to fix (and occurs only in one file). Should I open/fix/close a ticket for that? If you are going to go ahead and make the fix, then we do not need a ticket. We use the tickets to ensure we do not forget. -- Bruce -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] Compile issue postgresql
Am Sonntag, den 04.02.2018, 13:58 +0100 schrieb Thomas Trepl: > Am Sonntag, den 04.02.2018, 12:18 +0100 schrieb Armin K.: > > On Sun, 2018-02-04 at 11:42 +0100, Thomas Trepl wrote: > > > Hi, > > > > > > got a abort message when compiling postgresql: > > > > > > D_GNU_SOURCE -c -o copy_fetch.o copy_fetch.c > > > copy_fetch.c:159:1: Fehler: In Konflikt stehende Typen für > > > »copy_file_range« > > > copy_file_range(const char *path, off_t begin, off_t end, bool > > > trunc) > > > ^~~ > > > In file included from copy_fetch.c:15:0: > > > /usr/include/unistd.h:1110:9: Anmerkung: Vorherige Deklaration > > > von > > > »copy_file_range« war hier > > > ssize_t copy_file_range (int __infd, __off64_t *__pinoff, > > > ^~~ > > > > > > ... > > > To me it looks like a clash to the standard library function > > > copy_file_range. It's easy to fix as postgresql's copy_file_range > > > is > > > a > > > static function. I did following sed > > > > > > sed -e "s/copy_file_range/_&/" \ > > > -i src/bin/pg_rewind/copy_fetch.c > > > > > > with which compilation was successfull. Donno whether it is > > > caused > > > now > > > by gcc-7.3 and/or glibc-2.27 (on i686). > > > > > > Have you seen that issue, too or is it something wired here > > > locally? > > > > > > -- > > > Thomas > > > > From what I've seen, glibc-2.27 introduced copy_file_range. You > > could > > try and swap any instance of copy_file_range in postgresql with, > > say, > > pg_copy_file_range to avoid conflicts (or try and delete > > copy_file_range in pgsql entirely, and let it use the one from > > glibc). > > Yes, now found the statement in glibc's changelog > > "* The copy_file_range function was added." > > I'll add a small sed to the postgresql instructions as it is quite > easy > to fix (and occurs only in one file). > > Should I open/fix/close a ticket for that? Upstream allready caught that issue and they said it will be fixed in "next week's round of minor releases" (10.2). So I think we can just wait a few days and problem will went away... For urgent fix, just do sed -e "s/copy_file_range/rewind_&/" -i src/bin/pg_rewind/copy_fetch.c This is what upstream did. -- Thomas -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] Compile issue postgresql
Am Sonntag, den 04.02.2018, 12:18 +0100 schrieb Armin K.: > On Sun, 2018-02-04 at 11:42 +0100, Thomas Trepl wrote: > > Hi, > > > > got a abort message when compiling postgresql: > > > > D_GNU_SOURCE -c -o copy_fetch.o copy_fetch.c > > copy_fetch.c:159:1: Fehler: In Konflikt stehende Typen für > > »copy_file_range« > > copy_file_range(const char *path, off_t begin, off_t end, bool > > trunc) > > ^~~ > > In file included from copy_fetch.c:15:0: > > /usr/include/unistd.h:1110:9: Anmerkung: Vorherige Deklaration von > > »copy_file_range« war hier > > ssize_t copy_file_range (int __infd, __off64_t *__pinoff, > > ^~~ > > > > ... > > To me it looks like a clash to the standard library function > > copy_file_range. It's easy to fix as postgresql's copy_file_range > > is > > a > > static function. I did following sed > > > > sed -e "s/copy_file_range/_&/" \ > > -i src/bin/pg_rewind/copy_fetch.c > > > > with which compilation was successfull. Donno whether it is caused > > now > > by gcc-7.3 and/or glibc-2.27 (on i686). > > > > Have you seen that issue, too or is it something wired here > > locally? > > > > -- > > Thomas > > From what I've seen, glibc-2.27 introduced copy_file_range. You could > try and swap any instance of copy_file_range in postgresql with, say, > pg_copy_file_range to avoid conflicts (or try and delete > copy_file_range in pgsql entirely, and let it use the one from > glibc). Yes, now found the statement in glibc's changelog "* The copy_file_range function was added." I'll add a small sed to the postgresql instructions as it is quite easy to fix (and occurs only in one file). Should I open/fix/close a ticket for that? -- Thomas -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] Compile issue postgresql
On Sun, 2018-02-04 at 11:42 +0100, Thomas Trepl wrote: > Hi, > > got a abort message when compiling postgresql: > > gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after- > statement -Wendif-labels -Wmissing-format-attribute -Wformat-security > -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 > -I../../../src/interfaces/libpq -DFRONTEND -I../../../src/include - > D_GNU_SOURCE -c -o copy_fetch.o copy_fetch.c > copy_fetch.c:159:1: Fehler: In Konflikt stehende Typen für > »copy_file_range« > copy_file_range(const char *path, off_t begin, off_t end, bool > trunc) > ^~~ > In file included from copy_fetch.c:15:0: > /usr/include/unistd.h:1110:9: Anmerkung: Vorherige Deklaration von > »copy_file_range« war hier > ssize_t copy_file_range (int __infd, __off64_t *__pinoff, > ^~~ > make[3]: *** [: copy_fetch.o] Fehler 1 > make[3]: Verzeichnis „/tmp/postgresql/build/postgresql- > 10.1/src/bin/pg_rewind“ wird verlassen > make[2]: *** [Makefile:40: all-pg_rewind-recurse] Fehler 2 > make[2]: Verzeichnis „/tmp/postgresql/build/postgresql-10.1/src/bin“ > wird verlassen > make[1]: *** [Makefile:37: all-bin-recurse] Fehler 2 > make[1]: Verzeichnis „/tmp/postgresql/build/postgresql-10.1/src“ wird > verlassen > make: *** [GNUmakefile:11: all-src-recurse] Fehler 2 > > To me it looks like a clash to the standard library function > copy_file_range. It's easy to fix as postgresql's copy_file_range is > a > static function. I did following sed > > sed -e "s/copy_file_range/_&/" \ > -i src/bin/pg_rewind/copy_fetch.c > > with which compilation was successfull. Donno whether it is caused > now > by gcc-7.3 and/or glibc-2.27 (on i686). > > Have you seen that issue, too or is it something wired here locally? > > -- > Thomas From what I've seen, glibc-2.27 introduced copy_file_range. You could try and swap any instance of copy_file_range in postgresql with, say, pg_copy_file_range to avoid conflicts (or try and delete copy_file_range in pgsql entirely, and let it use the one from glibc). -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
[blfs-dev] Compile issue postgresql
Hi, got a abort message when compiling postgresql: gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after- statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -I../../../src/interfaces/libpq -DFRONTEND -I../../../src/include - D_GNU_SOURCE -c -o copy_fetch.o copy_fetch.c copy_fetch.c:159:1: Fehler: In Konflikt stehende Typen für »copy_file_range« copy_file_range(const char *path, off_t begin, off_t end, bool trunc) ^~~ In file included from copy_fetch.c:15:0: /usr/include/unistd.h:1110:9: Anmerkung: Vorherige Deklaration von »copy_file_range« war hier ssize_t copy_file_range (int __infd, __off64_t *__pinoff, ^~~ make[3]: *** [: copy_fetch.o] Fehler 1 make[3]: Verzeichnis „/tmp/postgresql/build/postgresql- 10.1/src/bin/pg_rewind“ wird verlassen make[2]: *** [Makefile:40: all-pg_rewind-recurse] Fehler 2 make[2]: Verzeichnis „/tmp/postgresql/build/postgresql-10.1/src/bin“ wird verlassen make[1]: *** [Makefile:37: all-bin-recurse] Fehler 2 make[1]: Verzeichnis „/tmp/postgresql/build/postgresql-10.1/src“ wird verlassen make: *** [GNUmakefile:11: all-src-recurse] Fehler 2 To me it looks like a clash to the standard library function copy_file_range. It's easy to fix as postgresql's copy_file_range is a static function. I did following sed sed -e "s/copy_file_range/_&/" \ -i src/bin/pg_rewind/copy_fetch.c with which compilation was successfull. Donno whether it is caused now by gcc-7.3 and/or glibc-2.27 (on i686). Have you seen that issue, too or is it something wired here locally? -- Thomas -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page