Re: [8u] RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
Looks good. /Erik On 2018-05-03 04:33, Severin Gehwolf wrote: Hi, Could I please get a review of this change for JDK 8u? We are seing build failures due to unresolved symbols when building libfontmanager.so. The build flag to trigger this is to configure with: --with-extra-ldflags="-Wl,-z,defs" Attempting a build of JDK 8 with this fails. This has been fixed in JDK 11 and hasn't shown any issues so far. Due to the change in the build system the JDK 11 patch does not apply cleanly after path unshuffeling (different context it seems). Hence, asking here for a review before asking for JDK 8 backport approval. Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.jdk8/ Review thread for JDK 11: http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021575.html Thanks, Severin
Re: [8u] RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
On 2018-05-03 13:33, Severin Gehwolf wrote: Hi, Could I please get a review of this change for JDK 8u? We are seing build failures due to unresolved symbols when building libfontmanager.so. The build flag to trigger this is to configure with: --with-extra-ldflags="-Wl,-z,defs" Attempting a build of JDK 8 with this fails. This has been fixed in JDK 11 and hasn't shown any issues so far. Due to the change in the build system the JDK 11 patch does not apply cleanly after path unshuffeling (different context it seems). Hence, asking here for a review before asking for JDK 8 backport approval. Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.jdk8/ Looks good to me. /Magnus Review thread for JDK 11: http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021575.html Thanks, Severin
[8u] RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
Hi, Could I please get a review of this change for JDK 8u? We are seing build failures due to unresolved symbols when building libfontmanager.so. The build flag to trigger this is to configure with: --with-extra-ldflags="-Wl,-z,defs" Attempting a build of JDK 8 with this fails. This has been fixed in JDK 11 and hasn't shown any issues so far. Due to the change in the build system the JDK 11 patch does not apply cleanly after path unshuffeling (different context it seems). Hence, asking here for a review before asking for JDK 8 backport approval. Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.jdk8/ Review thread for JDK 11: http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021575.html Thanks, Severin
Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
Hi Volker, On Fri, 2018-04-13 at 09:03 +0200, Volker Simonis wrote: > Hi Severin, > > I'm currently looking at the AIX-side of this bug. > > The problem I see with your solution is that it uses LDFLAGS (which is > generic) to filter out Linux specific linker flags. If we would extend > this to AIX, we would have to add yet another substitution for AIX > which filters out "-Wl,bernotok". This is not beautiful and gets > uglier with every new platform. Right. Note, though, that Magnus seems to be working on a more comprehensive solution to this: http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021625.html FWIW, the substitution for -Wl,-z,defs was there in LDFLAGS all along (it was missing the other syntax). Not sure if -Wl,-z,defs is generic enough to warrant it being on LDFLAGS directly, not LDFLAGS_linux or some other OS specific variant. Either way, that's the model I've followed. Thanks, Severin > But as this change has already been pushed and because (fortunately) > on AIX options which come later on the command line take precedence > over earlier ones I can easily fix this with a specific LDFLAGS_aix > setting. I've opened "8201524: [AIX] Don't link libfontmanager against > libawt_headless" [1] for it and I'll send out a new RFR for it soon. > > Regards, > Volker > > [1] https://bugs.openjdk.java.net/browse/JDK-8201524 > > > On Wed, Apr 11, 2018 at 10:17 AM, Severin Gehwolf wrote: > > On Tue, 2018-04-10 at 14:51 -0700, Sergey Bylokhov wrote: > > > LIBS_aix := -lawt_headless, > > > I guess that AIX team should have a similar fix. > > > > Possibly. I have no way of testing it, though. So will leave it to AIX > > folk to have a look. My experience was that it isn't easily > > reproducible. Some observations: > > > >1. Run swing app such as SwingSet2 on a headfull system. Since > > fontmanager will have a link dep on lawt_headless, and awt code > > loads libawt_xawt (headfull) on a headfull system, both libraries > > providing symbols needed by libfontmanager will be loaded. Then it > > depends whether this is a problem on that particular system or not. > > In my experience this worked on some systems and not on others. > >2. Solaris was build-time linking to libawt_headless causing bug > > 8194870. So build-time linking got removed with that bug. Not sure > > why that bug is private :( > > > > Thanks, > > Severin > > > > > On 10/04/2018 09:34, Erik Joelsson wrote: > > > > Looks good. Thanks! > > > > > > > > /Erik > > > > > > > > > > > > On 2018-04-10 04:25, Severin Gehwolf wrote: > > > > > Hi Erik, > > > > > > > > > > On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote: > > > > > > Hello Severin, > > > > > > > > > > > > I'm ok with this solution for now. > > > > > > > > > > Thanks for the review! > > > > > > > > > > > Could you please reduce the indentation on line 652. In the > > > > > > build system > > > > > > we like 4 spaces for continuation indent [1] > > > > > > > > > > Done. New webrev at: > > > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.0 > > > > > 2 > > > > > > > > > > Could someone from awt-dev have a look at this too? Thanks! > > > > > > > > > > Cheers, > > > > > Severin > > > > > > > > > > > /Erik > > > > > > > > > > > > [1] http://openjdk.java.net/groups/build/doc/code-conventions.h > > > > > > tml > > > > > > > > > > > > On 2018-04-09 06:39, Severin Gehwolf wrote: > > > > > > > Hi, > > > > > > > > > > > > > > Could somebody please review this build fix for > > > > > > > libfontmanager.so. The > > > > > > > issue for us is that with some LDFLAGS the build breaks as > > > > > > > described in > > > > > > > bug JDK-8196218. However, we cannot link to a providing > > > > > > > library at > > > > > > > build-time since we don't know which one it should be: > > > > > > > libawt_headless > > > > > > > or libawt_xawt. That has to happen at runtime. The proposed > > > > > > > fix filters > > > > > > > out relevant linker flags when libfontmanager is being built. > > > > > > > More > > > > > > > details are in the bug. > > > > > > > > > > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 > > > > > > > webrev: > > > > > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webr > > > > > > > ev.01/ > > > > > > > > > > > > > > Testing: I've run this through submit[1] and got the > > > > > > > following results. > > > > > > > SwingSet2 works fine for me on F27. I'm currently running > > > > > > > some more > > > > > > > tests on RHEL 7. > > > > > > > > > > > > > > - > > > > > > > Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: > > > > > > > Builds > > > > > > > PASSED. Testing FAILURE. > > > > > > > > > > > > > > 0 Failed Tests > > > > > > > > > > > > > > Mach5 Tasks Results Summary > > > > > > > > > > > > > > NA: 0 > > > > > > > UNABLE_TO_RUN: 0 > > > > > > > EXECUTED_WITH_FAILURE: 0 > > > > > > > KILLED: 0 > > > > > > > PASSED: 8
Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
Hi Severin, I'm currently looking at the AIX-side of this bug. The problem I see with your solution is that it uses LDFLAGS (which is generic) to filter out Linux specific linker flags. If we would extend this to AIX, we would have to add yet another substitution for AIX which filters out "-Wl,bernotok". This is not beautiful and gets uglier with every new platform. But as this change has already been pushed and because (fortunately) on AIX options which come later on the command line take precedence over earlier ones I can easily fix this with a specific LDFLAGS_aix setting. I've opened "8201524: [AIX] Don't link libfontmanager against libawt_headless" [1] for it and I'll send out a new RFR for it soon. Regards, Volker [1] https://bugs.openjdk.java.net/browse/JDK-8201524 On Wed, Apr 11, 2018 at 10:17 AM, Severin Gehwolf wrote: > On Tue, 2018-04-10 at 14:51 -0700, Sergey Bylokhov wrote: >> LIBS_aix := -lawt_headless, >> I guess that AIX team should have a similar fix. > > Possibly. I have no way of testing it, though. So will leave it to AIX > folk to have a look. My experience was that it isn't easily > reproducible. Some observations: > >1. Run swing app such as SwingSet2 on a headfull system. Since > fontmanager will have a link dep on lawt_headless, and awt code > loads libawt_xawt (headfull) on a headfull system, both libraries > providing symbols needed by libfontmanager will be loaded. Then it > depends whether this is a problem on that particular system or not. > In my experience this worked on some systems and not on others. >2. Solaris was build-time linking to libawt_headless causing bug > 8194870. So build-time linking got removed with that bug. Not sure > why that bug is private :( > > Thanks, > Severin > >> On 10/04/2018 09:34, Erik Joelsson wrote: >> > Looks good. Thanks! >> > >> > /Erik >> > >> > >> > On 2018-04-10 04:25, Severin Gehwolf wrote: >> > > Hi Erik, >> > > >> > > On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote: >> > > > Hello Severin, >> > > > >> > > > I'm ok with this solution for now. >> > > >> > > Thanks for the review! >> > > >> > > > Could you please reduce the indentation on line 652. In the >> > > > build system >> > > > we like 4 spaces for continuation indent [1] >> > > >> > > Done. New webrev at: >> > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.0 >> > > 2 >> > > >> > > Could someone from awt-dev have a look at this too? Thanks! >> > > >> > > Cheers, >> > > Severin >> > > >> > > > /Erik >> > > > >> > > > [1] http://openjdk.java.net/groups/build/doc/code-conventions.h >> > > > tml >> > > > >> > > > On 2018-04-09 06:39, Severin Gehwolf wrote: >> > > > > Hi, >> > > > > >> > > > > Could somebody please review this build fix for >> > > > > libfontmanager.so. The >> > > > > issue for us is that with some LDFLAGS the build breaks as >> > > > > described in >> > > > > bug JDK-8196218. However, we cannot link to a providing >> > > > > library at >> > > > > build-time since we don't know which one it should be: >> > > > > libawt_headless >> > > > > or libawt_xawt. That has to happen at runtime. The proposed >> > > > > fix filters >> > > > > out relevant linker flags when libfontmanager is being built. >> > > > > More >> > > > > details are in the bug. >> > > > > >> > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 >> > > > > webrev: >> > > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webr >> > > > > ev.01/ >> > > > > >> > > > > Testing: I've run this through submit[1] and got the >> > > > > following results. >> > > > > SwingSet2 works fine for me on F27. I'm currently running >> > > > > some more >> > > > > tests on RHEL 7. >> > > > > >> > > > > - >> > > > > Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: >> > > > > Builds >> > > > > PASSED. Testing FAILURE. >> > > > > >> > > > > 0 Failed Tests >> > > > > >> > > > > Mach5 Tasks Results Summary >> > > > > >> > > > > NA: 0 >> > > > > UNABLE_TO_RUN: 0 >> > > > > EXECUTED_WITH_FAILURE: 0 >> > > > > KILLED: 0 >> > > > > PASSED: 82 >> > > > > FAILED: 1 >> > > > > Test >> > > > > >> > > > > 1 Failed >> > > > > >> > > > > tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2- >> > > > > windows-x64- >> > > > > debug-31 SetupFailedException in setup...profile run-test- >> > > > > prebuilt' , >> > > > > return value: 10 >> > > > > >> > > > > >> > > > > Not sure what this test failure means. Could somebody at >> > > > > Oracle shed >> > > > > some light on this? >> > > > > >> > > > > Thanks, >> > > > > Severin >> >>
Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
Yes, I think this should be removed for AIX as we have done for Solaris + Linux, and I could have done that but I also had no way to test it .. without that capability I ran more risk of breaking AIX than fixing a problem that apparently hasn't been seen there. I am not sure if *headful* tests are regularly run on AIX, although email from earlier this week from IBM offering to contribute some input method support for AIX strongly suggests that it is of interest :-) -phil. On 04/11/2018 01:17 AM, Severin Gehwolf wrote: On Tue, 2018-04-10 at 14:51 -0700, Sergey Bylokhov wrote: LIBS_aix := -lawt_headless, I guess that AIX team should have a similar fix. Possibly. I have no way of testing it, though. So will leave it to AIX folk to have a look. My experience was that it isn't easily reproducible. Some observations: 1. Run swing app such as SwingSet2 on a headfull system. Since fontmanager will have a link dep on lawt_headless, and awt code loads libawt_xawt (headfull) on a headfull system, both libraries providing symbols needed by libfontmanager will be loaded. Then it depends whether this is a problem on that particular system or not. In my experience this worked on some systems and not on others. 2. Solaris was build-time linking to libawt_headless causing bug 8194870. So build-time linking got removed with that bug. Not sure why that bug is private :( Thanks, Severin On 10/04/2018 09:34, Erik Joelsson wrote: Looks good. Thanks! /Erik On 2018-04-10 04:25, Severin Gehwolf wrote: Hi Erik, On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote: Hello Severin, I'm ok with this solution for now. Thanks for the review! Could you please reduce the indentation on line 652. In the build system we like 4 spaces for continuation indent [1] Done. New webrev at: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.0 2 Could someone from awt-dev have a look at this too? Thanks! Cheers, Severin /Erik [1] http://openjdk.java.net/groups/build/doc/code-conventions.h tml On 2018-04-09 06:39, Severin Gehwolf wrote: Hi, Could somebody please review this build fix for libfontmanager.so. The issue for us is that with some LDFLAGS the build breaks as described in bug JDK-8196218. However, we cannot link to a providing library at build-time since we don't know which one it should be: libawt_headless or libawt_xawt. That has to happen at runtime. The proposed fix filters out relevant linker flags when libfontmanager is being built. More details are in the bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webr ev.01/ Testing: I've run this through submit[1] and got the following results. SwingSet2 works fine for me on F27. I'm currently running some more tests on RHEL 7. - Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds PASSED. Testing FAILURE. 0 Failed Tests Mach5 Tasks Results Summary NA: 0 UNABLE_TO_RUN: 0 EXECUTED_WITH_FAILURE: 0 KILLED: 0 PASSED: 82 FAILED: 1 Test 1 Failed tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2- windows-x64- debug-31 SetupFailedException in setup...profile run-test- prebuilt' , return value: 10 Not sure what this test failure means. Could somebody at Oracle shed some light on this? Thanks, Severin
Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
Hi Magnus, On Tue, 2018-04-10 at 22:57 +0200, Magnus Ihse Bursie wrote: > On 2018-04-10 13:25, Severin Gehwolf wrote: > > Hi Erik, > > > > On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote: > > > Hello Severin, > > > > > > I'm ok with this solution for now. > > > > Thanks for the review! > > > > > Could you please reduce the indentation on line 652. In the build > > > system > > > we like 4 spaces for continuation indent [1] > > > > Done. New webrev at: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.02 > > It's not nice, but there's no other way to do it right now. Approved. Thanks for the review! Cheers, Severin > (I'm working on getting to the point were I can address this in a > better > way.) > > /Magnus > > > > Could someone from awt-dev have a look at this too? Thanks! > > > > Cheers, > > Severin > > > > > /Erik > > > > > > [1] http://openjdk.java.net/groups/build/doc/code-conventions.htm > > > l > > > > > > On 2018-04-09 06:39, Severin Gehwolf wrote: > > > > Hi, > > > > > > > > Could somebody please review this build fix for > > > > libfontmanager.so. The > > > > issue for us is that with some LDFLAGS the build breaks as > > > > described in > > > > bug JDK-8196218. However, we cannot link to a providing library > > > > at > > > > build-time since we don't know which one it should be: > > > > libawt_headless > > > > or libawt_xawt. That has to happen at runtime. The proposed fix > > > > filters > > > > out relevant linker flags when libfontmanager is being built. > > > > More > > > > details are in the bug. > > > > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 > > > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-819651 > > > > 6/webrev.01/ > > > > > > > > Testing: I've run this through submit[1] and got the following > > > > results. > > > > SwingSet2 works fine for me on F27. I'm currently running some > > > > more > > > > tests on RHEL 7. > > > > > > > > - > > > > Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: > > > > Builds PASSED. Testing FAILURE. > > > > > > > > 0 Failed Tests > > > > > > > > Mach5 Tasks Results Summary > > > > > > > > NA: 0 > > > > UNABLE_TO_RUN: 0 > > > > EXECUTED_WITH_FAILURE: 0 > > > > KILLED: 0 > > > > PASSED: 82 > > > > FAILED: 1 > > > > Test > > > > > > > > 1 Failed > > > > > > > > tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2- > > > > windows-x64- > > > > debug-31 SetupFailedException in setup...profile run-test- > > > > prebuilt' , > > > > return value: 10 > > > > > > > > > > > > Not sure what this test failure means. Could somebody at Oracle > > > > shed > > > > some light on this? > > > > > > > > Thanks, > > > > Severin > >
Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
On Tue, 2018-04-10 at 09:34 -0700, Erik Joelsson wrote: > Looks good. Thanks! Thanks, Erik. Cheers, Severin > /Erik > > > On 2018-04-10 04:25, Severin Gehwolf wrote: > > Hi Erik, > > > > On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote: > > > Hello Severin, > > > > > > I'm ok with this solution for now. > > > > Thanks for the review! > > > > > Could you please reduce the indentation on line 652. In the build system > > > we like 4 spaces for continuation indent [1] > > > > Done. New webrev at: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.02 > > > > Could someone from awt-dev have a look at this too? Thanks! > > > > Cheers, > > Severin > > > > > /Erik > > > > > > [1] http://openjdk.java.net/groups/build/doc/code-conventions.html > > > > > > On 2018-04-09 06:39, Severin Gehwolf wrote: > > > > Hi, > > > > > > > > Could somebody please review this build fix for libfontmanager.so. The > > > > issue for us is that with some LDFLAGS the build breaks as described in > > > > bug JDK-8196218. However, we cannot link to a providing library at > > > > build-time since we don't know which one it should be: libawt_headless > > > > or libawt_xawt. That has to happen at runtime. The proposed fix filters > > > > out relevant linker flags when libfontmanager is being built. More > > > > details are in the bug. > > > > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 > > > > webrev: > > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.01/ > > > > > > > > Testing: I've run this through submit[1] and got the following results. > > > > SwingSet2 works fine for me on F27. I'm currently running some more > > > > tests on RHEL 7. > > > > > > > > - > > > > Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds > > > > PASSED. Testing FAILURE. > > > > > > > > 0 Failed Tests > > > > > > > > Mach5 Tasks Results Summary > > > > > > > > NA: 0 > > > > UNABLE_TO_RUN: 0 > > > > EXECUTED_WITH_FAILURE: 0 > > > > KILLED: 0 > > > > PASSED: 82 > > > > FAILED: 1 > > > > Test > > > > > > > > 1 Failed > > > > > > > > tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2-windows-x64- > > > > debug-31 SetupFailedException in setup...profile run-test-prebuilt' , > > > > return value: 10 > > > > > > > > > > > > Not sure what this test failure means. Could somebody at Oracle shed > > > > some light on this? > > > > > > > > Thanks, > > > > Severin > >
Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
On Tue, 2018-04-10 at 14:51 -0700, Sergey Bylokhov wrote: > LIBS_aix := -lawt_headless, > I guess that AIX team should have a similar fix. Possibly. I have no way of testing it, though. So will leave it to AIX folk to have a look. My experience was that it isn't easily reproducible. Some observations: 1. Run swing app such as SwingSet2 on a headfull system. Since fontmanager will have a link dep on lawt_headless, and awt code loads libawt_xawt (headfull) on a headfull system, both libraries providing symbols needed by libfontmanager will be loaded. Then it depends whether this is a problem on that particular system or not. In my experience this worked on some systems and not on others. 2. Solaris was build-time linking to libawt_headless causing bug 8194870. So build-time linking got removed with that bug. Not sure why that bug is private :( Thanks, Severin > On 10/04/2018 09:34, Erik Joelsson wrote: > > Looks good. Thanks! > > > > /Erik > > > > > > On 2018-04-10 04:25, Severin Gehwolf wrote: > > > Hi Erik, > > > > > > On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote: > > > > Hello Severin, > > > > > > > > I'm ok with this solution for now. > > > > > > Thanks for the review! > > > > > > > Could you please reduce the indentation on line 652. In the > > > > build system > > > > we like 4 spaces for continuation indent [1] > > > > > > Done. New webrev at: > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.0 > > > 2 > > > > > > Could someone from awt-dev have a look at this too? Thanks! > > > > > > Cheers, > > > Severin > > > > > > > /Erik > > > > > > > > [1] http://openjdk.java.net/groups/build/doc/code-conventions.h > > > > tml > > > > > > > > On 2018-04-09 06:39, Severin Gehwolf wrote: > > > > > Hi, > > > > > > > > > > Could somebody please review this build fix for > > > > > libfontmanager.so. The > > > > > issue for us is that with some LDFLAGS the build breaks as > > > > > described in > > > > > bug JDK-8196218. However, we cannot link to a providing > > > > > library at > > > > > build-time since we don't know which one it should be: > > > > > libawt_headless > > > > > or libawt_xawt. That has to happen at runtime. The proposed > > > > > fix filters > > > > > out relevant linker flags when libfontmanager is being built. > > > > > More > > > > > details are in the bug. > > > > > > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 > > > > > webrev: > > > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webr > > > > > ev.01/ > > > > > > > > > > Testing: I've run this through submit[1] and got the > > > > > following results. > > > > > SwingSet2 works fine for me on F27. I'm currently running > > > > > some more > > > > > tests on RHEL 7. > > > > > > > > > > - > > > > > Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: > > > > > Builds > > > > > PASSED. Testing FAILURE. > > > > > > > > > > 0 Failed Tests > > > > > > > > > > Mach5 Tasks Results Summary > > > > > > > > > > NA: 0 > > > > > UNABLE_TO_RUN: 0 > > > > > EXECUTED_WITH_FAILURE: 0 > > > > > KILLED: 0 > > > > > PASSED: 82 > > > > > FAILED: 1 > > > > > Test > > > > > > > > > > 1 Failed > > > > > > > > > > tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2- > > > > > windows-x64- > > > > > debug-31 SetupFailedException in setup...profile run-test- > > > > > prebuilt' , > > > > > return value: 10 > > > > > > > > > > > > > > > Not sure what this test failure means. Could somebody at > > > > > Oracle shed > > > > > some light on this? > > > > > > > > > > Thanks, > > > > > Severin > >
Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
+1 On 10/04/2018 13:57, Magnus Ihse Bursie wrote: On 2018-04-10 13:25, Severin Gehwolf wrote: Hi Erik, On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote: Hello Severin, I'm ok with this solution for now. Thanks for the review! Could you please reduce the indentation on line 652. In the build system we like 4 spaces for continuation indent [1] Done. New webrev at: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.02 It's not nice, but there's no other way to do it right now. Approved. (I'm working on getting to the point were I can address this in a better way.) /Magnus Could someone from awt-dev have a look at this too? Thanks! Cheers, Severin /Erik [1] http://openjdk.java.net/groups/build/doc/code-conventions.html On 2018-04-09 06:39, Severin Gehwolf wrote: Hi, Could somebody please review this build fix for libfontmanager.so. The issue for us is that with some LDFLAGS the build breaks as described in bug JDK-8196218. However, we cannot link to a providing library at build-time since we don't know which one it should be: libawt_headless or libawt_xawt. That has to happen at runtime. The proposed fix filters out relevant linker flags when libfontmanager is being built. More details are in the bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.01/ Testing: I've run this through submit[1] and got the following results. SwingSet2 works fine for me on F27. I'm currently running some more tests on RHEL 7. - Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds PASSED. Testing FAILURE. 0 Failed Tests Mach5 Tasks Results Summary NA: 0 UNABLE_TO_RUN: 0 EXECUTED_WITH_FAILURE: 0 KILLED: 0 PASSED: 82 FAILED: 1 Test 1 Failed tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2-windows-x64- debug-31 SetupFailedException in setup...profile run-test-prebuilt' , return value: 10 Not sure what this test failure means. Could somebody at Oracle shed some light on this? Thanks, Severin -- Best regards, Sergey.
Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
LIBS_aix := -lawt_headless, I guess that AIX team should have a similar fix. On 10/04/2018 09:34, Erik Joelsson wrote: Looks good. Thanks! /Erik On 2018-04-10 04:25, Severin Gehwolf wrote: Hi Erik, On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote: Hello Severin, I'm ok with this solution for now. Thanks for the review! Could you please reduce the indentation on line 652. In the build system we like 4 spaces for continuation indent [1] Done. New webrev at: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.02 Could someone from awt-dev have a look at this too? Thanks! Cheers, Severin /Erik [1] http://openjdk.java.net/groups/build/doc/code-conventions.html On 2018-04-09 06:39, Severin Gehwolf wrote: Hi, Could somebody please review this build fix for libfontmanager.so. The issue for us is that with some LDFLAGS the build breaks as described in bug JDK-8196218. However, we cannot link to a providing library at build-time since we don't know which one it should be: libawt_headless or libawt_xawt. That has to happen at runtime. The proposed fix filters out relevant linker flags when libfontmanager is being built. More details are in the bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.01/ Testing: I've run this through submit[1] and got the following results. SwingSet2 works fine for me on F27. I'm currently running some more tests on RHEL 7. - Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds PASSED. Testing FAILURE. 0 Failed Tests Mach5 Tasks Results Summary NA: 0 UNABLE_TO_RUN: 0 EXECUTED_WITH_FAILURE: 0 KILLED: 0 PASSED: 82 FAILED: 1 Test 1 Failed tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2-windows-x64- debug-31 SetupFailedException in setup...profile run-test-prebuilt' , return value: 10 Not sure what this test failure means. Could somebody at Oracle shed some light on this? Thanks, Severin -- Best regards, Sergey.
Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
On 2018-04-10 13:25, Severin Gehwolf wrote: Hi Erik, On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote: Hello Severin, I'm ok with this solution for now. Thanks for the review! Could you please reduce the indentation on line 652. In the build system we like 4 spaces for continuation indent [1] Done. New webrev at: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.02 It's not nice, but there's no other way to do it right now. Approved. (I'm working on getting to the point were I can address this in a better way.) /Magnus Could someone from awt-dev have a look at this too? Thanks! Cheers, Severin /Erik [1] http://openjdk.java.net/groups/build/doc/code-conventions.html On 2018-04-09 06:39, Severin Gehwolf wrote: Hi, Could somebody please review this build fix for libfontmanager.so. The issue for us is that with some LDFLAGS the build breaks as described in bug JDK-8196218. However, we cannot link to a providing library at build-time since we don't know which one it should be: libawt_headless or libawt_xawt. That has to happen at runtime. The proposed fix filters out relevant linker flags when libfontmanager is being built. More details are in the bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.01/ Testing: I've run this through submit[1] and got the following results. SwingSet2 works fine for me on F27. I'm currently running some more tests on RHEL 7. - Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds PASSED. Testing FAILURE. 0 Failed Tests Mach5 Tasks Results Summary NA: 0 UNABLE_TO_RUN: 0 EXECUTED_WITH_FAILURE: 0 KILLED: 0 PASSED: 82 FAILED: 1 Test 1 Failed tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2-windows-x64- debug-31 SetupFailedException in setup...profile run-test-prebuilt' , return value: 10 Not sure what this test failure means. Could somebody at Oracle shed some light on this? Thanks, Severin
Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
On 2018-04-10 04:30, Severin Gehwolf wrote: On Mon, 2018-04-09 at 15:39 +0200, Severin Gehwolf wrote: Hi, Could somebody please review this build fix for libfontmanager.so. The issue for us is that with some LDFLAGS the build breaks as described in bug JDK-8196218. However, we cannot link to a providing library at build-time since we don't know which one it should be: libawt_headless or libawt_xawt. That has to happen at runtime. The proposed fix filters out relevant linker flags when libfontmanager is being built. More details are in the bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 Latest webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.02/ Testing: I've run this through submit[1] and got the following results. SwingSet2 works fine for me on F27. I'm currently running some more tests on RHEL 7. I've finished testing on RHEL 7 by manually verifying that not both libawt_xawt and libawt_headless get loaded when running SwingSet. Could somebody tell me what this failure below is about? This was an internal infrastructure failure. I would say it's safe to ignore. /Erik Thanks, Severin - Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds PASSED. Testing FAILURE. 0 Failed Tests Mach5 Tasks Results Summary NA: 0 UNABLE_TO_RUN: 0 EXECUTED_WITH_FAILURE: 0 KILLED: 0 PASSED: 82 FAILED: 1 Test 1 Failed tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2-windows-x64- debug-31 SetupFailedException in setup...profile run-test-prebuilt' , return value: 10 Not sure what this test failure means. Could somebody at Oracle shed some light on this? Thanks, Severin
Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
Looks good. Thanks! /Erik On 2018-04-10 04:25, Severin Gehwolf wrote: Hi Erik, On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote: Hello Severin, I'm ok with this solution for now. Thanks for the review! Could you please reduce the indentation on line 652. In the build system we like 4 spaces for continuation indent [1] Done. New webrev at: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.02 Could someone from awt-dev have a look at this too? Thanks! Cheers, Severin /Erik [1] http://openjdk.java.net/groups/build/doc/code-conventions.html On 2018-04-09 06:39, Severin Gehwolf wrote: Hi, Could somebody please review this build fix for libfontmanager.so. The issue for us is that with some LDFLAGS the build breaks as described in bug JDK-8196218. However, we cannot link to a providing library at build-time since we don't know which one it should be: libawt_headless or libawt_xawt. That has to happen at runtime. The proposed fix filters out relevant linker flags when libfontmanager is being built. More details are in the bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.01/ Testing: I've run this through submit[1] and got the following results. SwingSet2 works fine for me on F27. I'm currently running some more tests on RHEL 7. - Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds PASSED. Testing FAILURE. 0 Failed Tests Mach5 Tasks Results Summary NA: 0 UNABLE_TO_RUN: 0 EXECUTED_WITH_FAILURE: 0 KILLED: 0 PASSED: 82 FAILED: 1 Test 1 Failed tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2-windows-x64- debug-31 SetupFailedException in setup...profile run-test-prebuilt' , return value: 10 Not sure what this test failure means. Could somebody at Oracle shed some light on this? Thanks, Severin
Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
On Mon, 2018-04-09 at 15:39 +0200, Severin Gehwolf wrote: > Hi, > > Could somebody please review this build fix for libfontmanager.so. The > issue for us is that with some LDFLAGS the build breaks as described in > bug JDK-8196218. However, we cannot link to a providing library at > build-time since we don't know which one it should be: libawt_headless > or libawt_xawt. That has to happen at runtime. The proposed fix filters > out relevant linker flags when libfontmanager is being built. More > details are in the bug. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 Latest webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.02/ > Testing: I've run this through submit[1] and got the following results. > SwingSet2 works fine for me on F27. I'm currently running some more > tests on RHEL 7. I've finished testing on RHEL 7 by manually verifying that not both libawt_xawt and libawt_headless get loaded when running SwingSet. Could somebody tell me what this failure below is about? Thanks, Severin > - > Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds PASSED. > Testing FAILURE. > > 0 Failed Tests > > Mach5 Tasks Results Summary > > NA: 0 > UNABLE_TO_RUN: 0 > EXECUTED_WITH_FAILURE: 0 > KILLED: 0 > PASSED: 82 > FAILED: 1 > Test > > 1 Failed > > tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2-windows-x64- > debug-31 SetupFailedException in setup...profile run-test-prebuilt' , > return value: 10 > > > Not sure what this test failure means. Could somebody at Oracle shed > some light on this? > > Thanks, > Severin
Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
Hi Erik, On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote: > Hello Severin, > > I'm ok with this solution for now. Thanks for the review! > Could you please reduce the indentation on line 652. In the build system > we like 4 spaces for continuation indent [1] Done. New webrev at: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.02 Could someone from awt-dev have a look at this too? Thanks! Cheers, Severin > /Erik > > [1] http://openjdk.java.net/groups/build/doc/code-conventions.html > > On 2018-04-09 06:39, Severin Gehwolf wrote: > > Hi, > > > > Could somebody please review this build fix for libfontmanager.so. The > > issue for us is that with some LDFLAGS the build breaks as described in > > bug JDK-8196218. However, we cannot link to a providing library at > > build-time since we don't know which one it should be: libawt_headless > > or libawt_xawt. That has to happen at runtime. The proposed fix filters > > out relevant linker flags when libfontmanager is being built. More > > details are in the bug. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.01/ > > > > Testing: I've run this through submit[1] and got the following results. > > SwingSet2 works fine for me on F27. I'm currently running some more > > tests on RHEL 7. > > > > - > > Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds PASSED. > > Testing FAILURE. > > > > 0 Failed Tests > > > > Mach5 Tasks Results Summary > > > > NA: 0 > > UNABLE_TO_RUN: 0 > > EXECUTED_WITH_FAILURE: 0 > > KILLED: 0 > > PASSED: 82 > > FAILED: 1 > > Test > > > > 1 Failed > > > > tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2-windows-x64- > > debug-31 SetupFailedException in setup...profile run-test-prebuilt' , > > return value: 10 > > > > > > Not sure what this test failure means. Could somebody at Oracle shed > > some light on this? > > > > Thanks, > > Severin > >
Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
Hello Severin, I'm ok with this solution for now. Could you please reduce the indentation on line 652. In the build system we like 4 spaces for continuation indent [1] /Erik [1] http://openjdk.java.net/groups/build/doc/code-conventions.html On 2018-04-09 06:39, Severin Gehwolf wrote: Hi, Could somebody please review this build fix for libfontmanager.so. The issue for us is that with some LDFLAGS the build breaks as described in bug JDK-8196218. However, we cannot link to a providing library at build-time since we don't know which one it should be: libawt_headless or libawt_xawt. That has to happen at runtime. The proposed fix filters out relevant linker flags when libfontmanager is being built. More details are in the bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.01/ Testing: I've run this through submit[1] and got the following results. SwingSet2 works fine for me on F27. I'm currently running some more tests on RHEL 7. - Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds PASSED. Testing FAILURE. 0 Failed Tests Mach5 Tasks Results Summary NA: 0 UNABLE_TO_RUN: 0 EXECUTED_WITH_FAILURE: 0 KILLED: 0 PASSED: 82 FAILED: 1 Test 1 Failed tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2-windows-x64- debug-31 SetupFailedException in setup...profile run-test-prebuilt' , return value: 10 Not sure what this test failure means. Could somebody at Oracle shed some light on this? Thanks, Severin
RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols
Hi, Could somebody please review this build fix for libfontmanager.so. The issue for us is that with some LDFLAGS the build breaks as described in bug JDK-8196218. However, we cannot link to a providing library at build-time since we don't know which one it should be: libawt_headless or libawt_xawt. That has to happen at runtime. The proposed fix filters out relevant linker flags when libfontmanager is being built. More details are in the bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.01/ Testing: I've run this through submit[1] and got the following results. SwingSet2 works fine for me on F27. I'm currently running some more tests on RHEL 7. - Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds PASSED. Testing FAILURE. 0 Failed Tests Mach5 Tasks Results Summary NA: 0 UNABLE_TO_RUN: 0 EXECUTED_WITH_FAILURE: 0 KILLED: 0 PASSED: 82 FAILED: 1 Test 1 Failed tier1-debug-jdk_open_test_hotspot_jtreg_tier1_compiler_2-windows-x64- debug-31 SetupFailedException in setup...profile run-test-prebuilt' , return value: 10 Not sure what this test failure means. Could somebody at Oracle shed some light on this? Thanks, Severin
