[chromium-dev] How to get a faster/smaller checkout?
Hi, It's noticed that a normal source code checkout by gclient config ... gclient sync with default settings will cost a couple of hours via an ADSL, which is very time-consuming, and the result working copy will occupy about 2GB disk space, which is very space-consuming. There are many unused things for certain developers, for example, directories for linux or mac are not necessary to developers who only want to build Chrome on win32. Is there any official configuration file (the .gclient file) for win32 only checkout or linux/mac only checkout, which only checkouts minimum files for the specified platform? -- Hua --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How to get a faster/smaller checkout?
On Wed, Jul 15, 2009 at 11:26 PM, Hua Suhuas...@gmail.com wrote: Hi, It's noticed that a normal source code checkout by gclient config ... gclient sync with default settings will cost a couple of hours via an ADSL, which is very time-consuming, and the result working copy will occupy about 2GB disk space, which is very space-consuming. Hi Hua: If you're talking about checking out all files manually, you can always download tar file at: http://build.chromium.org/buildbot/archives/chromium_tarball.html Ryosuke --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] How to attach to Renderer Process in XCode
Hi, chromium.org has this http://dev.chromium.org/developers/how-tos/debugging for debugging renderer process on Windows. My question is how can I do the same in XCode on MacOS X? I go to Run-Attach To Process, all the menu item entries are disabled. Thank you for any tip. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] How to exclude src/third_party/WebKit/LayoutTests when checkout chromium source code
How to exclude src/third_party/WebKit/LayoutTests when checkout chromium source code? I have added this to my .gclient src/third_party/WebKit/LayoutTests: None, src/webkit/data/layout_tests: None, the directory src/webkit/data/layout_tests was excluded, but diectory src/third_party/WebKit/LayoutTests is NOT excluded. Everytime, i remove src/third_party/WebKit/LayoutTests, and then do a gclient sync, it pulls does all the source again. Can you please tell me how to exclude both directories? Thank you. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How to get a faster/smaller checkout?
On Wed, Jul 15, 2009 at 11:26 PM, Hua Suhuas...@gmail.com wrote: Is there any official configuration file (the .gclient file) for win32 only checkout or linux/mac only checkout, which only checkouts minimum files for the specified platform? Platform-specific source is scattered around, and makes up a very small fraction of the total repository size (a substantial amount of which is tests, not source code), so that would take a lot of work to maintain for very little benefit. You'd be better off looking for the really large parts of of the repository and trimming the parts of those that you don't need for your development, rather than trying to get something that removes absolutely everything that you don't need. Besides, just because you are on Windows doesn't mean you won't need to make changes to other platform files during development. If all you are doing is *building* Chromium, not doing development, excluding the big test directories will be the biggest win by at least an order of magnitude or two. -Stuart --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: bug flag for flakiness-related bugs
Thanks. I applied the FlakyTest label to all bugs I know are about test flakiness, except layout tests. I just wasn't sure if it applies to them, and I just know much less about layout tests. On Thu, Jul 16, 2009 at 04:32, Darin Fisherda...@chromium.org wrote: Done. I named it FlakyTest since Flakiness seems like it could apply to other things besides just tests. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: bug flag for flakiness-related bugs
It seems OK to apply it to flaky layout tests too.-Darin On Thu, Jul 16, 2009 at 9:05 AM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: Thanks. I applied the FlakyTest label to all bugs I know are about test flakiness, except layout tests. I just wasn't sure if it applies to them, and I just know much less about layout tests. On Thu, Jul 16, 2009 at 04:32, Darin Fisherda...@chromium.org wrote: Done. I named it FlakyTest since Flakiness seems like it could apply to other things besides just tests. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How to exclude src/third_party/WebKit/LayoutTests when checkout chromium source code
I don't get third_party/WebKit/LayoutTests by excluding it in my .gclient,
not sure why it doesn't work for you. here is custom_deps section in my
.gclient:
custom_deps : {
# To use the trunk of a component instead of what's in DEPS:
#component: https://svnserver/component/trunk/;,
# To exclude a component from your working copy:
#data/really_large_component: None,
src/third_party/WebKit/LayoutTests: None,
src/webkit/data/layout_tests/LayoutTests: None,
},
On Wed, Jul 15, 2009 at 7:38 PM, James Howlett james.l.howl...@gmail.comwrote:
How to exclude src/third_party/WebKit/LayoutTests when checkout
chromium source code?
I have added this to my .gclient
src/third_party/WebKit/LayoutTests: None,
src/webkit/data/layout_tests: None,
the directory src/webkit/data/layout_tests was excluded, but diectory
src/third_party/WebKit/LayoutTests is NOT excluded. Everytime, i
remove src/third_party/WebKit/LayoutTests, and then do a gclient sync,
it pulls does all the source again.
Can you please tell me how to exclude both directories?
Thank you.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: How to exclude src/third_party/WebKit/LayoutTests when checkout chromium source code
By the way, in your client, you won't be able to exclude the
whole src/webkit/data/layout_tests directory, only the LayoutTests
subdirectory can be excluded, you will still pull other subdirectories like
chrome, platform, pending etc.
On Thu, Jul 16, 2009 at 9:17 AM, Victor Wang vict...@chromium.org wrote:
I don't get third_party/WebKit/LayoutTests by excluding it in my .gclient,
not sure why it doesn't work for you. here is custom_deps section in my
.gclient:
custom_deps : {
# To use the trunk of a component instead of what's in DEPS:
#component: https://svnserver/component/trunk/;,
# To exclude a component from your working copy:
#data/really_large_component: None,
src/third_party/WebKit/LayoutTests: None,
src/webkit/data/layout_tests/LayoutTests: None,
},
On Wed, Jul 15, 2009 at 7:38 PM, James Howlett
james.l.howl...@gmail.comwrote:
How to exclude src/third_party/WebKit/LayoutTests when checkout
chromium source code?
I have added this to my .gclient
src/third_party/WebKit/LayoutTests: None,
src/webkit/data/layout_tests: None,
the directory src/webkit/data/layout_tests was excluded, but diectory
src/third_party/WebKit/LayoutTests is NOT excluded. Everytime, i
remove src/third_party/WebKit/LayoutTests, and then do a gclient sync,
it pulls does all the source again.
Can you please tell me how to exclude both directories?
Thank you.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: How to exclude src/third_party/WebKit/LayoutTests when checkout chromium source code
Maybe those should be moved out of the source tree (into deps) so that they
can be excluded?
On Thu, Jul 16, 2009 at 9:23 AM, Victor Wang vict...@chromium.org wrote:
By the way, in your client, you won't be able to exclude the
whole src/webkit/data/layout_tests directory, only the LayoutTests
subdirectory can be excluded, you will still pull other subdirectories like
chrome, platform, pending etc.
On Thu, Jul 16, 2009 at 9:17 AM, Victor Wang vict...@chromium.org wrote:
I don't get third_party/WebKit/LayoutTests by excluding it in my .gclient,
not sure why it doesn't work for you. here is custom_deps section in my
.gclient:
custom_deps : {
# To use the trunk of a component instead of what's in DEPS:
#component: https://svnserver/component/trunk/;,
# To exclude a component from your working copy:
#data/really_large_component: None,
src/third_party/WebKit/LayoutTests: None,
src/webkit/data/layout_tests/LayoutTests: None,
},
On Wed, Jul 15, 2009 at 7:38 PM, James Howlett james.l.howl...@gmail.com
wrote:
How to exclude src/third_party/WebKit/LayoutTests when checkout
chromium source code?
I have added this to my .gclient
src/third_party/WebKit/LayoutTests: None,
src/webkit/data/layout_tests: None,
the directory src/webkit/data/layout_tests was excluded, but diectory
src/third_party/WebKit/LayoutTests is NOT excluded. Everytime, i
remove src/third_party/WebKit/LayoutTests, and then do a gclient sync,
it pulls does all the source again.
Can you please tell me how to exclude both directories?
Thank you.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: bug flag for flakiness-related bugs
On Thu, Jul 16, 2009 at 9:44 AM, Wan-Teh Chang w...@google.com wrote: Thanks for creating the FlakyTest label. One question: if a test *always* fails under a particular configuration, for example, on a particular platform or when running under Purify, it isn't a flaky test, right? I assume flaky means intermittent failure. Wan-Teh Agreed. I think that's a good definition. I wrote unreliable in the comment for the label. -Darin --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: bug flag for flakiness-related bugs
On Thu, Jul 16, 2009 at 9:48 AM, Darin Fisher da...@chromium.org wrote: On Thu, Jul 16, 2009 at 9:44 AM, Wan-Teh Chang w...@google.com wrote: Thanks for creating the FlakyTest label. One question: if a test *always* fails under a particular configuration, for example, on a particular platform or when running under Purify, it isn't a flaky test, right? I assume flaky means intermittent failure. Wan-Teh Agreed. I think that's a good definition. I wrote unreliable in the comment for the label. -Darin ... and if you think i should change the label description to something else, please let me know :) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How to exclude src/third_party/WebKit/LayoutTests when checkout chromium source code
They'll eventually be moved into upstream webkit's repository, at which
point they'll be in third_party/WebKit.
On Thu, Jul 16, 2009 at 9:43 AM, Jeremy Orlow jor...@chromium.org wrote:
Maybe those should be moved out of the source tree (into deps) so that they
can be excluded?
On Thu, Jul 16, 2009 at 9:23 AM, Victor Wang vict...@chromium.org wrote:
By the way, in your client, you won't be able to exclude the
whole src/webkit/data/layout_tests directory, only the LayoutTests
subdirectory can be excluded, you will still pull other subdirectories like
chrome, platform, pending etc.
On Thu, Jul 16, 2009 at 9:17 AM, Victor Wang vict...@chromium.orgwrote:
I don't get third_party/WebKit/LayoutTests by excluding it in my
.gclient, not sure why it doesn't work for you. here is custom_deps section
in my .gclient:
custom_deps : {
# To use the trunk of a component instead of what's in DEPS:
#component: https://svnserver/component/trunk/;,
# To exclude a component from your working copy:
#data/really_large_component: None,
src/third_party/WebKit/LayoutTests: None,
src/webkit/data/layout_tests/LayoutTests: None,
},
On Wed, Jul 15, 2009 at 7:38 PM, James Howlett
james.l.howl...@gmail.com wrote:
How to exclude src/third_party/WebKit/LayoutTests when checkout
chromium source code?
I have added this to my .gclient
src/third_party/WebKit/LayoutTests: None,
src/webkit/data/layout_tests: None,
the directory src/webkit/data/layout_tests was excluded, but diectory
src/third_party/WebKit/LayoutTests is NOT excluded. Everytime, i
remove src/third_party/WebKit/LayoutTests, and then do a gclient sync,
it pulls does all the source again.
Can you please tell me how to exclude both directories?
Thank you.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: How to exclude src/third_party/WebKit/LayoutTests when checkout chromium source code
Are you volunteering? ;)
http://spreadsheets.google.com/ccc?key=piGkUUMLW-PNUzuhTCzm4NQ
:DG
On Thu, Jul 16, 2009 at 9:43 AM, Jeremy Orlowjor...@chromium.org wrote:
Maybe those should be moved out of the source tree (into deps) so that they
can be excluded?
On Thu, Jul 16, 2009 at 9:23 AM, Victor Wang vict...@chromium.org wrote:
By the way, in your client, you won't be able to exclude the
whole src/webkit/data/layout_tests directory, only the LayoutTests
subdirectory can be excluded, you will still pull other subdirectories like
chrome, platform, pending etc.
On Thu, Jul 16, 2009 at 9:17 AM, Victor Wang vict...@chromium.org wrote:
I don't get third_party/WebKit/LayoutTests by excluding it in my
.gclient, not sure why it doesn't work for you. here is custom_deps section
in my .gclient:
custom_deps : {
# To use the trunk of a component instead of what's in DEPS:
#component: https://svnserver/component/trunk/;,
# To exclude a component from your working copy:
#data/really_large_component: None,
src/third_party/WebKit/LayoutTests: None,
src/webkit/data/layout_tests/LayoutTests: None,
},
On Wed, Jul 15, 2009 at 7:38 PM, James Howlett
james.l.howl...@gmail.com wrote:
How to exclude src/third_party/WebKit/LayoutTests when checkout
chromium source code?
I have added this to my .gclient
src/third_party/WebKit/LayoutTests: None,
src/webkit/data/layout_tests: None,
the directory src/webkit/data/layout_tests was excluded, but diectory
src/third_party/WebKit/LayoutTests is NOT excluded. Everytime, i
remove src/third_party/WebKit/LayoutTests, and then do a gclient sync,
it pulls does all the source again.
Can you please tell me how to exclude both directories?
Thank you.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: Proposal: chrome.tabs.executeContentScript()
On Wed, Jul 15, 2009 at 3:29 PM, Erik Kayerik...@chromium.org wrote: One naming thought for you. I wonder if the methods should be named loadScript and loadCSS? I know that this is effectively the same thing with JS, but execute sounds like it's just running something temporarily (maybe in the page's context) and forgetting about it, while load is loading it into the page and leaving it there for later reference. I don't have a strong opinion about this, it's just what popped into my head. When you say no attempt is made to dedupe these, again it sounds like the only downside is that the code has been run twice. Even for transient code, the newly created context would stick around until the next GC, If the code did anything more substantial, it would also keep this context and extra memory alive. Perhaps this is just solved by stronger wording in the doc. I see what you mean. Since we're creating a new context, it is a heavier operation than execute might imply. On the other hand, to me load sounds like it is something that doesn't have any side-effects. It might not seem like it could be used to actually do anything, other than load a library. In JavaScript, loading and executing are the same thing, so it's just a matter of what will confuse less often. I'm going to leave it executeScript() since it also accepts a simple string of JavaScript, which is definitely not implied by load. I added a bunch of comments about the weight though, and also changed the name executeCSS to insertCSS because you don't really execute CSS. On Thu, Jul 16, 2009 at 2:44 AM, disya2dis...@gmail.com wrote: Concerning the following: // tabId: Optional, defaults to selected tab of focused window if omitted. Maybe it would be better to use current window instead of focused? The caller is extension script and it may have some state variables or something which belongs to current window while extension script in focused window may have different state. On Thu, Jul 16, 2009 at 6:11 AM, Erik Kayerik...@chromium.org wrote: The problem with that is that background pages don't have a current window the way that toolstrips do. Great catch, disya. You are right that it would be more consistent, with, eg chrome.tabs.getSelected() to get the current window as opposed to the topmost one. I've changed this. Erik, the way that getCurrent() works is that it returns the window the code is executing in, but if there is no such window, then it falls back to the topmost window. - a --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] novel use of v8 - CSS Scripting Layout
I've produced a proposal for a CSS Scripting Layout specification. I've extended Chrome as a sample implementation. Of course, it relies heavily on v8 and I have gleaned a lot of useful knowledge from this group over the course of its development. I think it is a novel use of v8 and may be of interest to v8 developers. at the core is a constraint satisfaction system that requires a high degree of v8 reentrancy. I'd like to hear feedback from this community. TIA http://blogs.eforceglobal.com/dkarisch/archive/2009/07/16/536.aspx CSS Scripting Layout... a new set of CSS properties and object specifications that together compose a powerful declarative means to describe complex arbitrary layout criteria that are both reusable and extensible. The new properties are Javascript expressions that are woven together in a constraint resolving system to perform a specified layout. Additionally, a set of global objects defined in the constraint resolution Javascript execution environment enable powerful operations to be expressed succinctly resulting in more readable and compact layout specifications. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] How to Generate Visual Studio .SLN file from gyp
Hello You might think that this is a really a stupid question. I have downloaded chrome source code as well as the depot_tools and now I am trying to generate .SLN file for VS2005 However when running gclient runhooks --force I am getting the following error running 'D:\Programs\GoogleChrome\depot_tools\python_bin \python.exe src /tools/gyp/gyp_chromium' in 'D:\Programs\GoogleChrome\home\chrome-svn \tarball\ch romium' D:\Programs\GoogleChrome\depot_tools\python_bin\python.exe: can't open file 'src /tools/gyp/gyp_chromium': [Errno 2] No such file or directory failed to run command: D:\Programs\GoogleChrome\depot_tools\python_bin \python.ex e src/tools/gyp/gyp_chromium I would appreciate if you can guide me to an up-to-date docs on how to generate and build Chrome on VS Thx Ziad --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How to Generate Visual Studio .SLN file from gyp
sync again, it sounds like your src tree and gyp version are out of sync. TVL On Thu, Jul 16, 2009 at 6:39 AM, zys ziadsall...@gmail.com wrote: Hello You might think that this is a really a stupid question. I have downloaded chrome source code as well as the depot_tools and now I am trying to generate .SLN file for VS2005 However when running gclient runhooks --force I am getting the following error running 'D:\Programs\GoogleChrome\depot_tools\python_bin \python.exe src /tools/gyp/gyp_chromium' in 'D:\Programs\GoogleChrome\home\chrome-svn \tarball\ch romium' D:\Programs\GoogleChrome\depot_tools\python_bin\python.exe: can't open file 'src /tools/gyp/gyp_chromium': [Errno 2] No such file or directory failed to run command: D:\Programs\GoogleChrome\depot_tools\python_bin \python.ex e src/tools/gyp/gyp_chromium I would appreciate if you can guide me to an up-to-date docs on how to generate and build Chrome on VS Thx Ziad --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Confusing test coverage numbers
So I checked in a change that did some refactoring and added unit tests for two classes that were previously not tested: http://src.chromium.org/viewvc/chrome?view=revrevision=20836 According to the coverage graphs, that change actually brought both the source code and test code coverage *down*. What's interesting is the coverage analysis reports my new tests aren't being executed at all: http://build.chromium.org/buildbot/coverage/linux-debug/20836/CHROMIUM/media/filters/index.html Now I have no clue who/what process is generating these numbers, but maybe it needs to be clobbered. Andrew --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Purify - instrumentation fails on XP Unit (purify) bot
http://build.chromium.org/buildbot/waterfall/waterfall?builder=XP%20Unit%20(purify) Any insights would be appreciated... Sverrir (sheriff) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Enabled isolation for content scripts
Today I landed a patch that enables a security feature for extensions. Now when an extension runs a content script, that script runs in a parallel universe with the page. In its isolated world, the content script can see the page's DOM, but it can't see any of the page's JavaScript objects. This helps protect the extension from getting hacked by the page's JavaScript. If you're interested in how a page can hack a non-isolated content script, you might enjoy reading http://www.adambarth.com/papers/2009/adida-barth-jackson.pdf This is a breaking change in the sense that it changes the content script's API (by hiding the page's JavaScript). If you notice your favorite user script acting up after this change, please let me know and we'll try to get to the bottom of the issue. Adam --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Purify - instrumentation fails on XP Unit (purify) bot
On Thu, Jul 16, 2009 at 1:04 PM, Sverrir Á. Berg sver...@chromium.orgwrote: http://build.chromium.org/buildbot/waterfall/waterfall?builder=XP%20Unit%20(purify) I cleaned up the machine and restarted it. Sometimes it's enough to make it work. Nicolas http://build.chromium.org/buildbot/waterfall/waterfall?builder=XP%20Unit%20(purify) Any insights would be appreciated... Sverrir (sheriff) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Purify - instrumentation fails on XP Unit (purify) bot
What you're seeing is Purify crashing during instrumentation. The problem is usually transient, related to the state of the machine and the particular build revision. Unfortunately, we don't have great insights as to what's causing it. Here are things you can do to try to resolve the issue: * rdp into the machine and dismiss any alert dialogs that are there * do a clobber build * reboot the machine * wait for a couple of builds and see if it goes away on its own Also unfortunately, the debug cycle on this is fairly long, so it will be unclear what exactly caused the problem to get fixed. As sheriff, if you see it get into this state and stay in this state despite you doing the previous steps, the next step is to see if it reproduces on another machine (perhaps your own desktop). You don't necessarily need to do a full build, you could grab the build output from the build machine if that would be faster. If it does repro, then it's likely that we have a reproducible bug that we can send off to IBM to try to get a fix for. They've been fairly responsive when the crash is reproducible. Unfortunately, the more recent instances we have of these crashers have not been reproducible, so we've not been able to get them fixed. Erik On Thu, Jul 16, 2009 at 1:04 PM, Sverrir Á. Berg sver...@chromium.orgwrote: http://build.chromium.org/buildbot/waterfall/waterfall?builder=XP%20Unit%20(purify) Any insights would be appreciated... Sverrir (sheriff) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Enabled isolation for content scripts
awesome work! On Thu, Jul 16, 2009 at 1:05 PM, Adam Barth aba...@chromium.org wrote: Today I landed a patch that enables a security feature for extensions. Now when an extension runs a content script, that script runs in a parallel universe with the page. In its isolated world, the content script can see the page's DOM, but it can't see any of the page's JavaScript objects. This helps protect the extension from getting hacked by the page's JavaScript. If you're interested in how a page can hack a non-isolated content script, you might enjoy reading http://www.adambarth.com/papers/2009/adida-barth-jackson.pdf This is a breaking change in the sense that it changes the content script's API (by hiding the page's JavaScript). If you notice your favorite user script acting up after this change, please let me know and we'll try to get to the bottom of the issue. Adam --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: IPC from webkit glue?
I assume you mean renderer-browser IPC. The RenderView implements the WebViewDelegate interface, so calls to the RenderView take the form within WebViewImpl (e.g.): delegate()-RemoveStoredAutofillEntry(name, value); -- Evan Stade On Thu, Jul 16, 2009 at 9:09 PM, Paul Wickspwick...@gmail.com wrote: I'm working on setting up support for the spelling correction panel in chromium (there is a somewhat disorganized planning document on the wiki: http://code.google.com/p/chromium/wiki/SpellingPanelPlanningDoc) and I was wondering how to do IPC from the webkit glue code, specifically editor_client_impl.cc, as I am attempting to hook into some of the existing webkit code for this sort of thing. From what I can tell, the best way to send an IPC call would be to call a method in RenderView that would do the actual Send(), but I'm not sure of the best way to get to the right RenderView from editor_client_impl.cc. Does this sound about right and if it does, how do I get to the right RenderView from something in the webkit glue code? -Paul Wicks --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Confusing test coverage numbers
The bottom of the link says that coverage information was generated Wednesday. Your checkin was Thursday. Would that have something to do with it? - nick On Thu, Jul 16, 2009 at 12:43 PM, Andrew Scherkus scher...@chromium.orgwrote: So I checked in a change that did some refactoring and added unit tests for two classes that were previously not tested: http://src.chromium.org/viewvc/chrome?view=revrevision=20836 According to the coverage graphs, that change actually brought both the source code and test code coverage *down*. What's interesting is the coverage analysis reports my new tests aren't being executed at all: http://build.chromium.org/buildbot/coverage/linux-debug/20836/CHROMIUM/media/filters/index.html Now I have no clue who/what process is generating these numbers, but maybe it needs to be clobbered. Andrew --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Confusing test coverage numbers
I think we're getting confused by time zones here. I checked in at Wednesday at 18:26 PST (UTC-7), and assuming the coverage bot is also in my time zone that'd mean these results were generated ~20 minutes afterwards. On Thu, Jul 16, 2009 at 3:22 PM, Nick Carter n...@chromium.org wrote: The bottom of the link says that coverage information was generated Wednesday. Your checkin was Thursday. Would that have something to do with it? - nick On Thu, Jul 16, 2009 at 12:43 PM, Andrew Scherkus scher...@chromium.orgwrote: So I checked in a change that did some refactoring and added unit tests for two classes that were previously not tested: http://src.chromium.org/viewvc/chrome?view=revrevision=20836 According to the coverage graphs, that change actually brought both the source code and test code coverage *down*. What's interesting is the coverage analysis reports my new tests aren't being executed at all: http://build.chromium.org/buildbot/coverage/linux-debug/20836/CHROMIUM/media/filters/index.html Now I have no clue who/what process is generating these numbers, but maybe it needs to be clobbered. Andrew --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: bug flag for flakiness-related bugs
On Thu, Jul 16, 2009 at 16:44, Wan-Teh Chang w...@google.com wrote: One question: if a test *always* fails under a particular configuration, for example, on a particular platform or when running under Purify, it isn't a flaky test, right? I assume flaky means intermittent failure. I also think that flakiness = intermittent failure. One note about Purify and different environments: some tests become flaky when run under Purify or other kind of tool. They timeout or hang, but only sometimes. And one note about layout tests: I was looking at the list of layout test bugs, but I don't always know which are about real flakiness, and which are real failures after merges. I think it would be better to apply the FlakyTest label consistently, so I didn't label any of the webkit bugs. If you want to do that, feel free to do so. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Confusing test coverage numbers
For starters, thanks for caring about coverage It is possible your checkin was timed poorly (didn't land in time for the bot start), but looking at the coverage scripts I don't see how that could happen. I noticed you landed, then reverted, this CL the day before. My best guess is that such an action was enough info for croc to learn the filename and stick, but since you reverted it didn't compile or get run. Let's wait one more run and see if things fix themselves. Ping again if the problem continues. jrg On Thu, Jul 16, 2009 at 3:38 PM, Andrew Scherkus scher...@chromium.orgwrote: I think we're getting confused by time zones here. I checked in at Wednesday at 18:26 PST (UTC-7), and assuming the coverage bot is also in my time zone that'd mean these results were generated ~20 minutes afterwards. On Thu, Jul 16, 2009 at 3:22 PM, Nick Carter n...@chromium.org wrote: The bottom of the link says that coverage information was generated Wednesday. Your checkin was Thursday. Would that have something to do with it? - nick On Thu, Jul 16, 2009 at 12:43 PM, Andrew Scherkus scher...@chromium.orgwrote: So I checked in a change that did some refactoring and added unit tests for two classes that were previously not tested: http://src.chromium.org/viewvc/chrome?view=revrevision=20836 According to the coverage graphs, that change actually brought both the source code and test code coverage *down*. What's interesting is the coverage analysis reports my new tests aren't being executed at all: http://build.chromium.org/buildbot/coverage/linux-debug/20836/CHROMIUM/media/filters/index.html Now I have no clue who/what process is generating these numbers, but maybe it needs to be clobbered. Andrew --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Hacking on WebKit is easier than ever
On Wed, Jul 15, 2009 at 5:28 PM, Peter Kasting pkast...@chromium.orgwrote: I am now working on this upstream at https://bugs.webkit.org/show_bug.cgi?id=27323 . I have just checked in some changes that should help a bit. Builds should get farther than before (I haven't fixed all issues here) because all shell scripts have been changed to use LF line endings. prepare-ChangeLog, svn-create-patch, and commit-log-editor all work now, except that I still have an outstanding review for a change to make svn-create-patch not get confused about where the repository root for WebKit is. svn-unapply and svn-apply seemed to work for me as-is on my very simple patch. Making use of commit-log-editor is harder than I expected. Simply setting SVN_EDITOR = commit-log-editor doesn't work the way it does with the cygwin svn; the Windows svn tries to run commit-log-editor from inside a Windows cmd environment, so you get not a known command because it's a perl script. For now I've hacked around this by placing a commit-log-editor.bat inside my third_party/WebKit, which contains: @echo off setlocal e:\cygwin\bin\perl.exe -Ie:\pkasting\svn\trunk\src\third_party\WebKit\WebKitTools\Scripts -w -- e:\pkasting\svn\trunk\src\third_party\WebKit\WebKitTools\Scripts\commit-log-editor %* (That's three lines, the third being long. Obviously you'd replace the paths here as relevant.) I have updated the instructions accordingly. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Hacking on WebKit is easier than ever
On Thu, Jul 16, 2009 at 4:31 PM, Peter Kasting pkast...@chromium.orgwrote: prepare-ChangeLog, svn-create-patch, and commit-log-editor all work now, except that I still have an outstanding review for a change to make svn-create-patch not get confused about where the repository root for WebKit is. This is now checked in, so you should at least be able to create and commit patches. @echo off setlocal This line is unnecessary (I've removed it from the instructions too). My next change will be to get the build steps to only add Cygwin to the PATH if it's not there already, which should eliminate problems like the auto-version.sh script using the wrong copy of svn. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: novel use of v8 - CSS Scripting Layout
On Jul 16, 2009, at 9:48 AM, darrel karisch wrote: I've produced a proposal for a CSS Scripting Layout specification. I've extended Chrome as a sample implementation. Embedding arbitrary JavaScript expressions inside CSS turns out to be pretty dangerous from a security standpoint. MSIE has long had a simple facility for this (nothing as fancy as what you're proposing) and it's been a significant vector for XSS attacks. (It's made more dangerous by its subtlety — many web developers are totally unaware that CSS scripts could contain executable code.) In response, most sites that host user-created content have had to block the ability for users to link to external stylesheets, which restricts the ability to do things like custom themes. I'm not a security expert, but my feeling is that it would be a really bad idea to introduce another feature with the same properties, especially to browsers that haven't yet suffered from this particular type of vulnerability. —Jens --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] automation provider assistance
Hi, Will someone please inform me who I should talk to concerning the automation provider (chrome/browser/automation)? svn log in that directory is all over the place, so that wasn't much help. I'm looking at porting automation provider to linux and have a few questions. Thanks, James Hawkins --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How to Generate Visual Studio .SLN file from gyp
I'm puzzled why src/tools/gyp/gyp_chromium is getting used, as src/tools/gyp/gyp_dogfood is what I would expect.What shows up at the bottom of src/DEPS? (in the run hook) -BradN On Thu, Jul 16, 2009 at 10:53 AM, Thomas Van Lenten thoma...@chromium.orgwrote: sync again, it sounds like your src tree and gyp version are out of sync. TVL On Thu, Jul 16, 2009 at 6:39 AM, zys ziadsall...@gmail.com wrote: Hello You might think that this is a really a stupid question. I have downloaded chrome source code as well as the depot_tools and now I am trying to generate .SLN file for VS2005 However when running gclient runhooks --force I am getting the following error running 'D:\Programs\GoogleChrome\depot_tools\python_bin \python.exe src /tools/gyp/gyp_chromium' in 'D:\Programs\GoogleChrome\home\chrome-svn \tarball\ch romium' D:\Programs\GoogleChrome\depot_tools\python_bin\python.exe: can't open file 'src /tools/gyp/gyp_chromium': [Errno 2] No such file or directory failed to run command: D:\Programs\GoogleChrome\depot_tools\python_bin \python.ex e src/tools/gyp/gyp_chromium I would appreciate if you can guide me to an up-to-date docs on how to generate and build Chrome on VS Thx Ziad --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] [extensions] Backward compat
Although it is true that we are in a development phase now, we need to start being more careful about breaking changes. People are attempting to use our stuff now, and it is hard for them to keep up with our build rate. If we break things every week, we'll burn off our early testers, which would be bad. I've asked for changes to avoid breakage in some reviews, but I forget sometimes, so I want to make a general request now. What I would like to see us do for the typical case is: - If people use the old API and it is easy to do, continue supporting it. - Change the docs to only mention the new API - Add a comment to http://code.google.com/p/chromium/issues/detail?id=16356 reminding us to remove the deprecated API at 1.0 - When we send out the extension visible changes mail each week, mention the deprecated APIs in it To be clear, I'm not suggesting we should never break things at this point, just that in cases where it is easy to avoid breakage that we should do that. As an example, Matt recently renamed chrome.self to chrome.extension and just kept an alias at chrome.self. For Finnur's recent change to do extension-specific pageAction events, we could have continued dispatching all pageActions events through chrome.pageActions.onExecute if I would have thought to bring it up during review. As a counter-example, it would have been difficult to be backward compat when we implemented signing, so we specifically decided to bite the bullet and break everyone. At 1.0, we'll make a big sweep through and actually remove all these old APIs. - a --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How to Generate Visual Studio .SLN file from gyp
On Thu, Jul 16, 2009 at 8:44 PM, Bradley Nelson bradnel...@google.comwrote: I'm puzzled why src/tools/gyp/gyp_chromium is getting used, as src/tools/gyp/gyp_dogfood is what I would expect. What shows up at the bottom of src/DEPS? (in the run hook) The hook is src/tools/gyp/gyp_chromium, we sorta left the dogfood state a while ago :) and it's role has evolved to the point the work it does is specific to Chromium. So when tweaking something in it for the buildbots the other day, we went ahead and renamed it. TVL -BradN On Thu, Jul 16, 2009 at 10:53 AM, Thomas Van Lenten thoma...@chromium.org wrote: sync again, it sounds like your src tree and gyp version are out of sync. TVL On Thu, Jul 16, 2009 at 6:39 AM, zys ziadsall...@gmail.com wrote: Hello You might think that this is a really a stupid question. I have downloaded chrome source code as well as the depot_tools and now I am trying to generate .SLN file for VS2005 However when running gclient runhooks --force I am getting the following error running 'D:\Programs\GoogleChrome\depot_tools\python_bin \python.exe src /tools/gyp/gyp_chromium' in 'D:\Programs\GoogleChrome\home\chrome-svn \tarball\ch romium' D:\Programs\GoogleChrome\depot_tools\python_bin\python.exe: can't open file 'src /tools/gyp/gyp_chromium': [Errno 2] No such file or directory failed to run command: D:\Programs\GoogleChrome\depot_tools\python_bin \python.ex e src/tools/gyp/gyp_chromium I would appreciate if you can guide me to an up-to-date docs on how to generate and build Chrome on VS Thx Ziad --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: automation provider assistance
Hi James, I have recently started looking at it but I'll be happy to be of any help. Regards -Amit On Thu, Jul 16, 2009 at 5:30 PM, James Hawkinsjhawk...@chromium.org wrote: Hi, Will someone please inform me who I should talk to concerning the automation provider (chrome/browser/automation)? svn log in that directory is all over the place, so that wasn't much help. I'm looking at porting automation provider to linux and have a few questions. Thanks, James Hawkins --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
