[chromium-dev] Re: desktop notifications, preliminary code for review
On Wed, Aug 5, 2009 at 3:51 PM, John Greggjohn...@google.com wrote: As I mentioned to some of you offline, I would greatly appreciate a pre-review so I can start to work out the issues and be as ready as possible to check in once the WebKit process finishes. Looks promising, but I see Mac and Windows code and no Linux. ? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: desktop notifications, preliminary code for review
On Wed, Aug 5, 2009 at 4:00 PM, Evan Martine...@chromium.org wrote: On Wed, Aug 5, 2009 at 3:51 PM, John Greggjohn...@google.com wrote: As I mentioned to some of you offline, I would greatly appreciate a pre-review so I can start to work out the issues and be as ready as possible to check in once the WebKit process finishes. Looks promising, but I see Mac and Windows code and no Linux. ? To clarify, I'd at least like to see the design doc address how and whether this will work on Linux. For example, suppose the APIs available were more broad -- maybe then there is extra information that ought to be plumbed around. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: desktop notifications, preliminary code for review
On Linux you could probably get this effect by using the notify-send utility: http://manpages.ubuntu.com/manpages/gutsy/man1/notify-send.1.html http://www.galago-project.org/specs/notification/0.9/index.html --Mike On Wed, Aug 5, 2009 at 4:00 PM, Evan Martine...@chromium.org wrote: On Wed, Aug 5, 2009 at 3:51 PM, John Greggjohn...@google.com wrote: As I mentioned to some of you offline, I would greatly appreciate a pre-review so I can start to work out the issues and be as ready as possible to check in once the WebKit process finishes. Looks promising, but I see Mac and Windows code and no Linux. ? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: desktop notifications, preliminary code for review
Has a design doc for this feature in general been sent around? This is a fairly large change otherwise. -Ben On Wed, Aug 5, 2009 at 4:13 PM, Evan Martine...@chromium.org wrote: On Wed, Aug 5, 2009 at 4:00 PM, Evan Martine...@chromium.org wrote: On Wed, Aug 5, 2009 at 3:51 PM, John Greggjohn...@google.com wrote: As I mentioned to some of you offline, I would greatly appreciate a pre-review so I can start to work out the issues and be as ready as possible to check in once the WebKit process finishes. Looks promising, but I see Mac and Windows code and no Linux. ? To clarify, I'd at least like to see the design doc address how and whether this will work on Linux. For example, suppose the APIs available were more broad -- maybe then there is extra information that ought to be plumbed around. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: desktop notifications, preliminary code for review
The plan for linux is to use libnotify, which is Growl-like, for text notifications, and possibly something we build for HTML balloon notifications which could be turned on or off by the user. Can you elaborate on what you mean by more broad? We think that offering a text version and an html version which app writers can query for in the browser allow us to offer on each platform the most full-featured option that makes sense to those users. Other user agents could then implement one or the other or both as makes sense for their platforms (thinking mobile especially). I'll update the doc to discuss the linux plan. -John On Wed, Aug 5, 2009 at 4:13 PM, Evan Martin e...@chromium.org wrote: On Wed, Aug 5, 2009 at 4:00 PM, Evan Martine...@chromium.org wrote: On Wed, Aug 5, 2009 at 3:51 PM, John Greggjohn...@google.com wrote: As I mentioned to some of you offline, I would greatly appreciate a pre-review so I can start to work out the issues and be as ready as possible to check in once the WebKit process finishes. Looks promising, but I see Mac and Windows code and no Linux. ? To clarify, I'd at least like to see the design doc address how and whether this will work on Linux. For example, suppose the APIs available were more broad -- maybe then there is extra information that ought to be plumbed around. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: desktop notifications, preliminary code for review
Sorry, maybe not. It's a big world to keep up to date! Between WHATWG, webkit-dev, and offline it's been discussed at some length at many levels, but not much on this list as I check the archives. But in any case, while the code patch is large as I said I consider it preliminary, and this is why I ask for feedback on the document (and the design expressed in it) as well as the code. Thanks, -John On Wed, Aug 5, 2009 at 4:29 PM, Ben Goodger (Google) b...@chromium.orgwrote: Has a design doc for this feature in general been sent around? This is a fairly large change otherwise. -Ben On Wed, Aug 5, 2009 at 4:13 PM, Evan Martine...@chromium.org wrote: On Wed, Aug 5, 2009 at 4:00 PM, Evan Martine...@chromium.org wrote: On Wed, Aug 5, 2009 at 3:51 PM, John Greggjohn...@google.com wrote: As I mentioned to some of you offline, I would greatly appreciate a pre-review so I can start to work out the issues and be as ready as possible to check in once the WebKit process finishes. Looks promising, but I see Mac and Windows code and no Linux. ? To clarify, I'd at least like to see the design doc address how and whether this will work on Linux. For example, suppose the APIs available were more broad -- maybe then there is extra information that ought to be plumbed around. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: desktop notifications, preliminary code for review
Is there any reason you're doing this on appspot's code review, not chromium's? I reviewed half the patch at a high level. I think there's plenty of comments to address for now. Once those are addressed, I'm happy to take a deeper dive with the rest if there aren't any more qualified reviewers who'd like to take it on. Even though this has been discussed to death, it might be good to still write up a mini-design doc since that's easier than code to review and I'm sure there's plenty of people who'd like to sanity check the design. (That said, I didn't see any major design flaws while reviewing.) J On Wed, Aug 5, 2009 at 4:52 PM, John Gregg john...@google.com wrote: Sorry, maybe not. It's a big world to keep up to date! Between WHATWG, webkit-dev, and offline it's been discussed at some length at many levels, but not much on this list as I check the archives. But in any case, while the code patch is large as I said I consider it preliminary, and this is why I ask for feedback on the document (and the design expressed in it) as well as the code. Thanks, -John On Wed, Aug 5, 2009 at 4:29 PM, Ben Goodger (Google) b...@chromium.orgwrote: Has a design doc for this feature in general been sent around? This is a fairly large change otherwise. -Ben On Wed, Aug 5, 2009 at 4:13 PM, Evan Martine...@chromium.org wrote: On Wed, Aug 5, 2009 at 4:00 PM, Evan Martine...@chromium.org wrote: On Wed, Aug 5, 2009 at 3:51 PM, John Greggjohn...@google.com wrote: As I mentioned to some of you offline, I would greatly appreciate a pre-review so I can start to work out the issues and be as ready as possible to check in once the WebKit process finishes. Looks promising, but I see Mac and Windows code and no Linux. ? To clarify, I'd at least like to see the design doc address how and whether this will work on Linux. For example, suppose the APIs available were more broad -- maybe then there is extra information that ought to be plumbed around. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: desktop notifications, preliminary code for review
Yes. Major feature work should have a design doc sent to chromium-dev. Please write one up in the design docs section of dev.chromium.org. -Ben On Wed, Aug 5, 2009 at 5:03 PM, Jeremy Orlowjor...@chromium.org wrote: Is there any reason you're doing this on appspot's code review, not chromium's? I reviewed half the patch at a high level. I think there's plenty of comments to address for now. Once those are addressed, I'm happy to take a deeper dive with the rest if there aren't any more qualified reviewers who'd like to take it on. Even though this has been discussed to death, it might be good to still write up a mini-design doc since that's easier than code to review and I'm sure there's plenty of people who'd like to sanity check the design. (That said, I didn't see any major design flaws while reviewing.) J On Wed, Aug 5, 2009 at 4:52 PM, John Gregg john...@google.com wrote: Sorry, maybe not. It's a big world to keep up to date! Between WHATWG, webkit-dev, and offline it's been discussed at some length at many levels, but not much on this list as I check the archives. But in any case, while the code patch is large as I said I consider it preliminary, and this is why I ask for feedback on the document (and the design expressed in it) as well as the code. Thanks, -John On Wed, Aug 5, 2009 at 4:29 PM, Ben Goodger (Google) b...@chromium.org wrote: Has a design doc for this feature in general been sent around? This is a fairly large change otherwise. -Ben On Wed, Aug 5, 2009 at 4:13 PM, Evan Martine...@chromium.org wrote: On Wed, Aug 5, 2009 at 4:00 PM, Evan Martine...@chromium.org wrote: On Wed, Aug 5, 2009 at 3:51 PM, John Greggjohn...@google.com wrote: As I mentioned to some of you offline, I would greatly appreciate a pre-review so I can start to work out the issues and be as ready as possible to check in once the WebKit process finishes. Looks promising, but I see Mac and Windows code and no Linux. ? To clarify, I'd at least like to see the design doc address how and whether this will work on Linux. For example, suppose the APIs available were more broad -- maybe then there is extra information that ought to be plumbed around. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
