[jira] [Commented] (AIRFLOW-4938) next_execution_date is not a Pendulum object

[jack (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884571#comment-16884571
 ] 

jack commented on AIRFLOW-4938:
---

Related/duplicate to/of :

https://issues.apache.org/jira/browse/AIRFLOW-4788

> next_execution_date is not a Pendulum object
> 
>
> Key: AIRFLOW-4938
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4938
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: models
>Affects Versions: 1.10.2
> Environment: Airlfow 1.10.2 in Docker using puckel docker image.
> Configured for timezone Copenhagen
>Reporter: Adam Andersen Læssøe
>Priority: Major
>
> When templating, it seems `execution_date` refers to a Pendulum object while 
> `next_execution_date` refers to a native `datetime` object.
>  This is inconsistent, and contrary to what the docs say, so I'm thinking 
> it's a bug.
> *Observation*
>  Airflow is configured to run in timezone Copenhagen.
>  I have a where clause like
>  ```
> {code:java}
> WHERE inserted_at >= '{{execution_date}}' AND inserted_at < 
> '{{next_execution_date}}'{code}
> I execute the task using `airflow test ... 2019-07-01`.
>  The clause is rendered as
> {code:java}
> WHERE inserted_at >= '2019-07-01T00:00:00+02:00' AND inserted_at < 
> '2019-07-01 22:00:00+00:00'{code}
>  
> Note how `execution_date` is printed as UTC+2, while `next_execution_date` is 
> printed in UTC. I believe the timestamps actually decribe the correct 
> interval, but to be certain I tried explicitly converting to UTC:
> {code:java}
> WHERE inserted_at >= '{{execution_date.in_tz('UTC')}}' AND inserted_at < 
> '{{next_execution_date.in_tz('UTC')}}'{code}
> I then get an error that datetime.datetime does not have an in_tz method.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (AIRFLOW-4597) Add DagStateSensor

[jack (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884570#comment-16884570
 ] 

jack commented on AIRFLOW-4597:
---

[~ash] and isn't that exactly what 
[https://github.com/apache/airflow/pull/4291] is trying to do?

> Add DagStateSensor
> --
>
> Key: AIRFLOW-4597
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4597
> Project: Apache Airflow
>  Issue Type: Wish
>  Components: contrib
>Affects Versions: 1.10.3
>Reporter: HaloKu
>Priority: Major
>
> Airflow offers variety of sensor to poke DAGs.
> Most of them are time based or execution_date base.
> I have use case where all I care about is the DAG state.
> DAG has 3 states: Completed, Running, Failed (The sensor is on DAG level. not 
> on task level.)
> For example:
> DAG A, DAG B
> B can run only if A is not in "Running" state.
> I don't care which execution_date A has. Simply B start only if A doesn't 
> have active run.
>  
>  
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] potiuk commented on a change in pull request #5576: [AIRFLOW-4942] Drop six.next

[GitBox]

potiuk commented on a change in pull request #5576: [AIRFLOW-4942] Drop six.next
URL: https://github.com/apache/airflow/pull/5576#discussion_r303227884
 
 

 ##
 File path: tests/jobs/test_scheduler_job.py
 ##
 @@ -2087,7 +2087,7 @@ def run_with_error(task):
 except AirflowException:
 pass
 
-ti_tuple = six.next(six.itervalues(executor.queued_tasks))
+ti_tuple = list(executor.queued_tasks.values())[0]
 
 Review comment:
   I think this is not the best way of replacing six.next. The original code 
did not build the whole list - just an iterator and then took the first element 
of the iterator. In the proposed solution we are building the whole list of 
values and take the first element from that list. The list might be pretty long 
if you have a long queue of tasks so converting to list might change 
performance characteristics of this piece of code. Not sure if that matters but 
I think we should be careful with that. Python3 next is much more obvious 
choice:
   
   ```
   next(iter(executor.queued_tasks.values()))
   ``` 
   
   values() is a view object, iter builds an iterator to access it and next 
takes the first element from the iterator.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4943) Replace six assertion method with native

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884562#comment-16884562
 ] 

ASF GitHub Bot commented on AIRFLOW-4943:
-

potiuk commented on pull request #5577: [AIRFLOW-4943] Replace six assertion 
method with native
URL: https://github.com/apache/airflow/pull/5577
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Replace six assertion method with native
> 
>
> Key: AIRFLOW-4943
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4943
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Resolved] (AIRFLOW-4943) Replace six assertion method with native

[Jarek Potiuk (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk resolved AIRFLOW-4943.
---
   Resolution: Fixed
Fix Version/s: 2.0.0

> Replace six assertion method with native
> 
>
> Key: AIRFLOW-4943
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4943
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (AIRFLOW-4943) Replace six assertion method with native

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884563#comment-16884563
 ] 

ASF subversion and git services commented on AIRFLOW-4943:
--

Commit b5fb370446dab076713a7de3bc2cd0f8221d30df in airflow's branch 
refs/heads/master from Kamil Breguła
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=b5fb370 ]

[AIRFLOW-4943] Replace six assertion method with native (#5577)



> Replace six assertion method with native
> 
>
> Key: AIRFLOW-4943
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4943
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (AIRFLOW-4944) Use new types syntax

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884561#comment-16884561
 ] 

ASF subversion and git services commented on AIRFLOW-4944:
--

Commit 4f332382da3075c1a43a2194216a4eaa27d5d688 in airflow's branch 
refs/heads/master from Kamil Breguła
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=4f33238 ]

[AIRFLOW-4944] Use new types syntax (#5578)



> Use new types syntax
> 
>
> Key: AIRFLOW-4944
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4944
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Resolved] (AIRFLOW-4944) Use new types syntax

[Jarek Potiuk (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk resolved AIRFLOW-4944.
---
   Resolution: Fixed
Fix Version/s: 2.0.0

> Use new types syntax
> 
>
> Key: AIRFLOW-4944
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4944
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] potiuk merged pull request #5577: [AIRFLOW-4943] Replace six assertion method with native

[GitBox]

potiuk merged pull request #5577: [AIRFLOW-4943] Replace six assertion method 
with native
URL: https://github.com/apache/airflow/pull/5577
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4944) Use new types syntax

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884560#comment-16884560
 ] 

ASF GitHub Bot commented on AIRFLOW-4944:
-

potiuk commented on pull request #5578: [AIRFLOW-4944] Use new types syntax
URL: https://github.com/apache/airflow/pull/5578
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use new types syntax
> 
>
> Key: AIRFLOW-4944
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4944
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] potiuk merged pull request #5578: [AIRFLOW-4944] Use new types syntax

[GitBox]

potiuk merged pull request #5578: [AIRFLOW-4944] Use new types syntax
URL: https://github.com/apache/airflow/pull/5578
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4947) Remove six types

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884559#comment-16884559
 ] 

ASF subversion and git services commented on AIRFLOW-4947:
--

Commit c2f5698eda5737e796506eaa3e11cddbf5d96d25 in airflow's branch 
refs/heads/master from Kamil Breguła
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=c2f5698 ]

[AIRFLOW-4947] Remove six types (#5581)



> Remove six types
> 
>
> Key: AIRFLOW-4947
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4947
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Resolved] (AIRFLOW-4947) Remove six types

[Jarek Potiuk (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk resolved AIRFLOW-4947.
---
   Resolution: Fixed
Fix Version/s: 2.0.0

> Remove six types
> 
>
> Key: AIRFLOW-4947
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4947
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] potiuk commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

[GitBox]

potiuk commented on a change in pull request #5585: [AIRFLOW-4951] Use new 
style classes
URL: https://github.com/apache/airflow/pull/5585#discussion_r303227674
 
 

 ##
 File path: airflow/_vendor/nvd3/NVD3Chart.py
 ##
 @@ -36,7 +36,7 @@ def stab(tab=1):
 return ' ' * 4 * tab
 
 
-class NVD3Chart(object):
+class NVD3Chart:
 
 Review comment:
   Does it sound convincing @BasPH @ashb ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4949) Use OSError exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884557#comment-16884557
 ] 

ASF GitHub Bot commented on AIRFLOW-4949:
-

potiuk commented on pull request #5583: [AIRFLOW-4949] Use OSError exception
URL: https://github.com/apache/airflow/pull/5583
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use OSError exception
> -
>
> Key: AIRFLOW-4949
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4949
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Resolved] (AIRFLOW-4949) Use OSError exception

[Jarek Potiuk (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk resolved AIRFLOW-4949.
---
   Resolution: Fixed
Fix Version/s: 2.0.0

> Use OSError exception
> -
>
> Key: AIRFLOW-4949
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4949
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (AIRFLOW-4949) Use OSError exception

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884558#comment-16884558
 ] 

ASF subversion and git services commented on AIRFLOW-4949:
--

Commit 4a56abea3a404e1726d5ee94ace5ba73920846fe in airflow's branch 
refs/heads/master from Kamil Breguła
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=4a56abe ]

[AIRFLOW-4949] Use OSError exception (#5583)



> Use OSError exception
> -
>
> Key: AIRFLOW-4949
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4949
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] potiuk merged pull request #5583: [AIRFLOW-4949] Use OSError exception

[GitBox]

potiuk merged pull request #5583: [AIRFLOW-4949] Use OSError exception
URL: https://github.com/apache/airflow/pull/5583
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

[GitBox]

potiuk commented on a change in pull request #5585: [AIRFLOW-4951] Use new 
style classes
URL: https://github.com/apache/airflow/pull/5585#discussion_r303227624
 
 

 ##
 File path: airflow/_vendor/nvd3/NVD3Chart.py
 ##
 @@ -36,7 +36,7 @@ def stab(tab=1):
 return ' ' * 4 * tab
 
 
-class NVD3Chart(object):
+class NVD3Chart:
 
 Review comment:
   I think we discussed it before already re: vendor updates. And since we 
already modified those projects, I see no reason why we should not introduce 
those Py3 changes here. 
   
   I think the whole reason of _vendor is to keep sources of external libraries 
that we could not use directly as dependency but we had to modify the sources. 
So we already know it's legal to modify the sources and we've already done 
that. 
   
   Those consistency modifications are not technically needed but adding Py3 
consistency everywhere is a value on its own (for example it might make some 
tools work better - like black in the future maybe - if all our code is PY3 
only.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #5577: [AIRFLOW-4943] Replace six assertion method with native

[GitBox]

codecov-io commented on issue #5577: [AIRFLOW-4943] Replace six assertion 
method with native
URL: https://github.com/apache/airflow/pull/5577#issuecomment-511167476
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5577?src=pr=h1) 
Report
   > Merging 
[#5577](https://codecov.io/gh/apache/airflow/pull/5577?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/6aaa19b9e533c5df25fe723845720484c4a7b63c?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5577/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5577?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#5577   +/-   ##
   ===
 Coverage   79.06%   79.06%   
   ===
 Files 489  489   
 Lines   3070530705   
   ===
 Hits2427824278   
 Misses   6427 6427
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5577?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5577?src=pr=footer). 
Last update 
[6aaa19b...9efb6e8](https://codecov.io/gh/apache/airflow/pull/5577?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #5581: [AIRFLOW-4947] Remove six types

[GitBox]

codecov-io edited a comment on issue #5581: [AIRFLOW-4947] Remove six types
URL: https://github.com/apache/airflow/pull/5581#issuecomment-511158555
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=h1) 
Report
   > Merging 
[#5581](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20a9aa0117859b19ecfe476ae76729c55dec20?src=pr=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `93.93%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5581/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5581  +/-   ##
   ==
   - Coverage   79.06%   79.05%   -0.02% 
   ==
 Files 489  489  
 Lines   3071130684  -27 
   ==
   - Hits2428224257  -25 
   + Misses   6429 6427   -2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/sensors/gcp\_transfer\_sensor.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NwX3RyYW5zZmVyX3NlbnNvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/bigquery\_hook.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2JpZ3F1ZXJ5X2hvb2sucHk=)
 | `61.38% <ø> (-0.07%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/gcp\_transfer\_hook.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF90cmFuc2Zlcl9ob29rLnB5)
 | `90.41% <ø> (-0.07%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/qubole\_hook.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3F1Ym9sZV9ob29rLnB5)
 | `55% <0%> (-0.32%)` | :arrow_down: |
   | 
[airflow/stats.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9zdGF0cy5weQ==)
 | `69.23% <0%> (-0.47%)` | :arrow_down: |
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `94.7% <100%> (-0.02%)` | :arrow_down: |
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `66.42% <100%> (-0.04%)` | :arrow_down: |
   | 
[airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5)
 | `91.83% <100%> (-0.02%)` | :arrow_down: |
   | 
[...flow/contrib/operators/gcp\_cloud\_build\_operator.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY2xvdWRfYnVpbGRfb3BlcmF0b3IucHk=)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[.../contrib/operators/jenkins\_job\_trigger\_operator.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9qZW5raW5zX2pvYl90cmlnZ2VyX29wZXJhdG9yLnB5)
 | `67.67% <100%> (-0.33%)` | :arrow_down: |
   | ... and [18 
more](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=footer). 
Last update 
[fe20a9a...90f43c7](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #5581: [AIRFLOW-4947] Remove six types

[GitBox]

codecov-io commented on issue #5581: [AIRFLOW-4947] Remove six types
URL: https://github.com/apache/airflow/pull/5581#issuecomment-511158555
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=h1) 
Report
   > Merging 
[#5581](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20a9aa0117859b19ecfe476ae76729c55dec20?src=pr=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `93.93%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5581/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5581  +/-   ##
   ==
   - Coverage   79.06%   79.05%   -0.02% 
   ==
 Files 489  489  
 Lines   3071130684  -27 
   ==
   - Hits2428224257  -25 
   + Misses   6429 6427   -2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/sensors/gcp\_transfer\_sensor.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NwX3RyYW5zZmVyX3NlbnNvci5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/bigquery\_hook.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2JpZ3F1ZXJ5X2hvb2sucHk=)
 | `61.38% <ø> (-0.07%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/gcp\_transfer\_hook.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF90cmFuc2Zlcl9ob29rLnB5)
 | `90.41% <ø> (-0.07%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/qubole\_hook.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3F1Ym9sZV9ob29rLnB5)
 | `55% <0%> (-0.32%)` | :arrow_down: |
   | 
[airflow/stats.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9zdGF0cy5weQ==)
 | `69.23% <0%> (-0.47%)` | :arrow_down: |
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `94.7% <100%> (-0.02%)` | :arrow_down: |
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `66.42% <100%> (-0.04%)` | :arrow_down: |
   | 
[airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5)
 | `91.83% <100%> (-0.02%)` | :arrow_down: |
   | 
[...flow/contrib/operators/gcp\_cloud\_build\_operator.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY2xvdWRfYnVpbGRfb3BlcmF0b3IucHk=)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[.../contrib/operators/jenkins\_job\_trigger\_operator.py](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9qZW5raW5zX2pvYl90cmlnZ2VyX29wZXJhdG9yLnB5)
 | `67.67% <100%> (-0.33%)` | :arrow_down: |
   | ... and [18 
more](https://codecov.io/gh/apache/airflow/pull/5581/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=footer). 
Last update 
[fe20a9a...90f43c7](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4497) KubernetesExecutor fails to launch pods when using run_as_user or fs_group options

[Philippe Gagnon (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884503#comment-16884503
 ] 

Philippe Gagnon commented on AIRFLOW-4497:
--

[~ndigati] Is this solved by AIRFLOW-4516? I think you may be able to close 
this issue.

> KubernetesExecutor fails to launch pods when using run_as_user or fs_group 
> options
> --
>
> Key: AIRFLOW-4497
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4497
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: executors
>Affects Versions: 1.10.3
>Reporter: Nick Digati
>Assignee: Philippe Gagnon
>Priority: Minor
>  Labels: kubernetes
>
> If you set the run_as_user or the fs_group options in the airflow.cfg file 
> when using the KubernetesExecutor the pods will fail to launch with the 
> following error message:
>  
> {noformat}
> [2019-05-10 05:36:09,207] {pod_launcher.py:60} ERROR - Exception when 
> attempting to create Namespaced Pod.
> Traceback (most recent call last):
> File 
> "/usr/local/lib/python3.6/site-packages/airflow/contrib/kubernetes/pod_launcher.py",
>  line 57, in run_pod_async
> resp = self._client.create_namespaced_pod(body=req, namespace=pod.namespace)
> File 
> "/usr/local/lib/python3.6/site-packages/kubernetes/client/apis/core_v1_api.py",
>  line 6115, in create_namespaced_pod
> (data) = self.create_namespaced_pod_with_http_info(namespace, body, **kwargs)
> File 
> "/usr/local/lib/python3.6/site-packages/kubernetes/client/apis/core_v1_api.py",
>  line 6206, in create_namespaced_pod_with_http_info
> collection_formats=collection_formats)
> File 
> "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", 
> line 334, in call_api
> _return_http_data_only, collection_formats, _preload_content, 
> _request_timeout)
> File 
> "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", 
> line 168, in __call_api
> _request_timeout=_request_timeout)
> File 
> "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", 
> line 377, in request
> body=body)
> File "/usr/local/lib/python3.6/site-packages/kubernetes/client/rest.py", line 
> 266, in POST
> body=body)
> File "/usr/local/lib/python3.6/site-packages/kubernetes/client/rest.py", line 
> 222, in request
> raise ApiException(http_resp=r)
> kubernetes.client.rest.ApiException: (400)
> Reason: Bad Request
> HTTP response headers: HTTPHeaderDict({'Content-Type': 'application/json', 
> 'Date': 'Fri, 10 May 2019 05:36:09 GMT', 'Content-Length': '428'})
> HTTP response body: 
> {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"Pod
>  in version \"v1\" cannot be handled as a Pod: v1.Pod.Spec: 
> v1.PodSpec.SecurityContext: v1.PodSecurityContext.FSGroup: readUint64: 
> unexpected character: \ufffd, error found in #10 byte of ...|sGroup\": 
> \"65533\"}}}|..., bigger context ...|, \"affinity\": {}, \"securityContext\": 
> {\"fsGroup\": \"65533\"}}}|...","reason":"BadRequest","code":400}{noformat}
>  
> It seems like those two options are getting put into the pod manifest as 
> strings instead of integers?
>  
> My airflow.cfg options:
>  
> {noformat}
> [kubernetes]
> run_as_user = 1000
> fs_group = 65533{noformat}
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (AIRFLOW-4911) Silence the FORBIDDEN errors from the KubernetesExecutor

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884502#comment-16884502
 ] 

ASF subversion and git services commented on AIRFLOW-4911:
--

Commit a098c2d832830992bc74cae1bdaa2c0bf4474891 in airflow's branch 
refs/heads/v1-10-test from Andrii Soldatenko
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=a098c2d ]

[AIRFLOW-4911] Silence the FORBIDDEN errors from the KubernetesExecutor (#5547)

* [AIRFLOW-4911] Silence the FORBIDDEN errors from the KubernetesExecutor

* switch to WARN

* add to show message from ApiException

(cherry picked from commit a1f9d9a03faecbb4ab52def2735e374b2e88b2b9)


> Silence the FORBIDDEN errors from the KubernetesExecutor
> 
>
> Key: AIRFLOW-4911
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4911
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: executors
>Affects Versions: 1.10.3
>Reporter: Andrii Soldatenko
>Assignee: Andrii Soldatenko
>Priority: Trivial
> Fix For: 1.10.4
>
>
> Right now the {{KubernetesExecutor}} throws an error when it hits a quota 
> limit. It is gracefully handled, but we should also stop showing these errors 
> since they are show front-and-center in the log view now. This will probably 
> confuse folks and lead to an awkward user experience.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] codecov-io edited a comment on issue #5585: [AIRFLOW-4951] Use new style classes

[GitBox]

codecov-io edited a comment on issue #5585: [AIRFLOW-4951] Use new style classes
URL: https://github.com/apache/airflow/pull/5585#issuecomment-511149460
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=h1) 
Report
   > Merging 
[#5585](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20a9aa0117859b19ecfe476ae76729c55dec20?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5585/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5585  +/-   ##
   ==
   + Coverage   79.06%   79.07%   +<.01% 
   ==
 Files 489  489  
 Lines   3071130705   -6 
   ==
   - Hits2428224279   -3 
   + Misses   6429 6426   -3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==)
 | `66.24% <100%> (ø)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/base\_ti\_dep.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvYmFzZV90aV9kZXAucHk=)
 | `90.47% <0%> (-0.23%)` | :arrow_down: |
   | 
[airflow/ti\_deps/deps/trigger\_rule\_dep.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvdHJpZ2dlcl9ydWxlX2RlcC5weQ==)
 | `90.78% <0%> (-0.12%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `77.66% <0%> (-0.06%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/sagemaker\_hook.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NhZ2VtYWtlcl9ob29rLnB5)
 | `88.16% <0%> (-0.05%)` | :arrow_down: |
   | 
[airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5)
 | `93.18% <0%> (+0.16%)` | :arrow_up: |
   | 
[airflow/lineage/datasets.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy9saW5lYWdlL2RhdGFzZXRzLnB5)
 | `84.93% <0%> (+1.14%)` | :arrow_up: |
   | 
[airflow/contrib/hooks/grpc\_hook.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2dycGNfaG9vay5weQ==)
 | `93.33% <0%> (+1.53%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=footer). 
Last update 
[fe20a9a...fd2d8ef](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #5585: [AIRFLOW-4951] Use new style classes

[GitBox]

codecov-io edited a comment on issue #5585: [AIRFLOW-4951] Use new style classes
URL: https://github.com/apache/airflow/pull/5585#issuecomment-511149460
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=h1) 
Report
   > Merging 
[#5585](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20a9aa0117859b19ecfe476ae76729c55dec20?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5585/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5585  +/-   ##
   ==
   + Coverage   79.06%   79.07%   +<.01% 
   ==
 Files 489  489  
 Lines   3071130705   -6 
   ==
   - Hits2428224279   -3 
   + Misses   6429 6426   -3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==)
 | `66.24% <100%> (ø)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/base\_ti\_dep.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvYmFzZV90aV9kZXAucHk=)
 | `90.47% <0%> (-0.23%)` | :arrow_down: |
   | 
[airflow/ti\_deps/deps/trigger\_rule\_dep.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvdHJpZ2dlcl9ydWxlX2RlcC5weQ==)
 | `90.78% <0%> (-0.12%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `77.66% <0%> (-0.06%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/sagemaker\_hook.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NhZ2VtYWtlcl9ob29rLnB5)
 | `88.16% <0%> (-0.05%)` | :arrow_down: |
   | 
[airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5)
 | `93.18% <0%> (+0.16%)` | :arrow_up: |
   | 
[airflow/lineage/datasets.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy9saW5lYWdlL2RhdGFzZXRzLnB5)
 | `84.93% <0%> (+1.14%)` | :arrow_up: |
   | 
[airflow/contrib/hooks/grpc\_hook.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2dycGNfaG9vay5weQ==)
 | `93.33% <0%> (+1.53%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=footer). 
Last update 
[fe20a9a...fd2d8ef](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4911) Silence the FORBIDDEN errors from the KubernetesExecutor

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884501#comment-16884501
 ] 

ASF subversion and git services commented on AIRFLOW-4911:
--

Commit a098c2d832830992bc74cae1bdaa2c0bf4474891 in airflow's branch 
refs/heads/v1-10-test from Andrii Soldatenko
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=a098c2d ]

[AIRFLOW-4911] Silence the FORBIDDEN errors from the KubernetesExecutor (#5547)

* [AIRFLOW-4911] Silence the FORBIDDEN errors from the KubernetesExecutor

* switch to WARN

* add to show message from ApiException

(cherry picked from commit a1f9d9a03faecbb4ab52def2735e374b2e88b2b9)


> Silence the FORBIDDEN errors from the KubernetesExecutor
> 
>
> Key: AIRFLOW-4911
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4911
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: executors
>Affects Versions: 1.10.3
>Reporter: Andrii Soldatenko
>Assignee: Andrii Soldatenko
>Priority: Trivial
> Fix For: 1.10.4
>
>
> Right now the {{KubernetesExecutor}} throws an error when it hits a quota 
> limit. It is gracefully handled, but we should also stop showing these errors 
> since they are show front-and-center in the log view now. This will probably 
> confuse folks and lead to an awkward user experience.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] ashb commented on a change in pull request #5550: AIRFLOW-4912: Support to update nested keys in emr_defaults conn extras.

[GitBox]

ashb commented on a change in pull request #5550: AIRFLOW-4912: Support to 
update nested keys in emr_defaults conn extras.
URL: https://github.com/apache/airflow/pull/5550#discussion_r303220315
 
 

 ##
 File path: tests/utils/test_helpers.py
 ##
 @@ -52,6 +52,7 @@ def signal_handler(signum, frame):
 def _parent_of_ignores_sigterm(parent_pid, child_pid, setup_done):
 def signal_handler(signum, frame):
 pass
+
 
 Review comment:
   Could you revert the changes to this file please?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #5550: AIRFLOW-4912: Support to update nested keys in emr_defaults conn extras.

[GitBox]

ashb commented on a change in pull request #5550: AIRFLOW-4912: Support to 
update nested keys in emr_defaults conn extras.
URL: https://github.com/apache/airflow/pull/5550#discussion_r303220308
 
 

 ##
 File path: tests/contrib/hooks/test_emr_hook.py
 ##
 @@ -62,7 +62,7 @@ def test_create_job_flow_extra_args(self):
 # coverage of EMR isn't 100% it turns out.
 cluster = hook.create_job_flow({'Name': 'test_cluster',
 'ReleaseLabel': '',
-'AmiVersion': '3.2'})
+'AmiVersion': '3.2', 'Instances': 
{'TerminationProtected': True}})
 
 Review comment:
   Could you extend the tests here to make sure that we are actually getting a 
merge here


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4918) SparkShellHook

[Ash Berlin-Taylor (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884499#comment-16884499
 ] 

Ash Berlin-Taylor commented on AIRFLOW-4918:


Isn't spark-shell designed for interactive use? What would this hook do in 
Airflow?

> SparkShellHook 
> ---
>
> Key: AIRFLOW-4918
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4918
> Project: Apache Airflow
>  Issue Type: New Feature
>  Components: contrib, operators
>Affects Versions: 1.10.4
>Reporter: luto
>Priority: Major
>
> Airflow is missing SparkShellHook  (it does have SparkSubmitHook)
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] ashb commented on issue #5325: [AIRFLOW-XXX] Add missing extras package to installation.rst

[GitBox]

ashb commented on issue #5325: [AIRFLOW-XXX] Add missing extras package to 
installation.rst
URL: https://github.com/apache/airflow/pull/5325#issuecomment-511156757
 
 
   @icyfox-bupt We should probably change it, assuming the current ldap module 
we install isn't used for anything else (I don't _think_ it is)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #5576: [AIRFLOW-4942] Drop six.next

[GitBox]

codecov-io commented on issue #5576: [AIRFLOW-4942] Drop six.next
URL: https://github.com/apache/airflow/pull/5576#issuecomment-511155668
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=h1) 
Report
   > Merging 
[#5576](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20a9aa0117859b19ecfe476ae76729c55dec20?src=pr=desc)
 will **decrease** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5576/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5576  +/-   ##
   ==
   - Coverage   79.06%   79.03%   -0.04% 
   ==
 Files 489  489  
 Lines   3071130848 +137 
   ==
   + Hits2428224380  +98 
   - Misses   6429 6468  +39
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==)
 | `47.61% <0%> (-52.39%)` | :arrow_down: |
   | 
[airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5)
 | `74.41% <0%> (-4.66%)` | :arrow_down: |
   | 
[airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=)
 | `62.5% <0%> (-4.17%)` | :arrow_down: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `69.14% <0%> (-1.25%)` | :arrow_down: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `57.19% <0%> (-1.07%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/grpc\_hook.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2dycGNfaG9vay5weQ==)
 | `90.76% <0%> (-1.04%)` | :arrow_down: |
   | 
[airflow/ti\_deps/deps/base\_ti\_dep.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvYmFzZV90aV9kZXAucHk=)
 | `90% <0%> (-0.7%)` | :arrow_down: |
   | 
[airflow/lineage/datasets.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy9saW5lYWdlL2RhdGFzZXRzLnB5)
 | `83.69% <0%> (-0.09%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `78.39% <0%> (+0.67%)` | :arrow_up: |
   | 
[airflow/contrib/hooks/sagemaker\_hook.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NhZ2VtYWtlcl9ob29rLnB5)
 | `89.76% <0%> (+1.55%)` | :arrow_up: |
   | ... and [1 
more](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=footer). 
Last update 
[fe20a9a...cd031f3](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #5576: [AIRFLOW-4942] Drop six.next

[GitBox]

codecov-io edited a comment on issue #5576: [AIRFLOW-4942] Drop six.next
URL: https://github.com/apache/airflow/pull/5576#issuecomment-511155668
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=h1) 
Report
   > Merging 
[#5576](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20a9aa0117859b19ecfe476ae76729c55dec20?src=pr=desc)
 will **decrease** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5576/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5576  +/-   ##
   ==
   - Coverage   79.06%   79.03%   -0.04% 
   ==
 Files 489  489  
 Lines   3071130848 +137 
   ==
   + Hits2428224380  +98 
   - Misses   6429 6468  +39
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==)
 | `47.61% <0%> (-52.39%)` | :arrow_down: |
   | 
[airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5)
 | `74.41% <0%> (-4.66%)` | :arrow_down: |
   | 
[airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=)
 | `62.5% <0%> (-4.17%)` | :arrow_down: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `69.14% <0%> (-1.25%)` | :arrow_down: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `57.19% <0%> (-1.07%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/grpc\_hook.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2dycGNfaG9vay5weQ==)
 | `90.76% <0%> (-1.04%)` | :arrow_down: |
   | 
[airflow/ti\_deps/deps/base\_ti\_dep.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvYmFzZV90aV9kZXAucHk=)
 | `90% <0%> (-0.7%)` | :arrow_down: |
   | 
[airflow/lineage/datasets.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy9saW5lYWdlL2RhdGFzZXRzLnB5)
 | `83.69% <0%> (-0.09%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `78.39% <0%> (+0.67%)` | :arrow_up: |
   | 
[airflow/contrib/hooks/sagemaker\_hook.py](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NhZ2VtYWtlcl9ob29rLnB5)
 | `89.76% <0%> (+1.55%)` | :arrow_up: |
   | ... and [1 
more](https://codecov.io/gh/apache/airflow/pull/5576/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=footer). 
Last update 
[fe20a9a...cd031f3](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format

[GitBox]

ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format
URL: https://github.com/apache/airflow/pull/5584#issuecomment-511154921
 
 
   Thank you, and sorry to be a bit of a pain - I'm coming at this with my 
"I've just cherry-picked 100s of commits over the last few months" hat on.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4950) Simplify code formation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884490#comment-16884490
 ] 

ASF GitHub Bot commented on AIRFLOW-4950:
-

mik-laj commented on pull request #5584: [AIRFLOW-4950] Simplify string format
URL: https://github.com/apache/airflow/pull/5584
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Simplify code formation
> ---
>
> Key: AIRFLOW-4950
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4950
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] mik-laj closed pull request #5584: [AIRFLOW-4950] Simplify string format

[GitBox]

mik-laj closed pull request #5584: [AIRFLOW-4950] Simplify string format
URL: https://github.com/apache/airflow/pull/5584
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4921) scheduler stuck with schedule is 2.30am and timezone is daylight saving time

[Ash Berlin-Taylor (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884488#comment-16884488
 ] 

Ash Berlin-Taylor commented on AIRFLOW-4921:


Output I get on the RC:

{noformat}
 2019-07-13 22:19:40.689158
 2019-07-13 22:19:40.761653
 2019-07-13 22:19:40.782002
 2019-07-13 22:19:40.795771
 2019-07-13 22:19:40.812790
 2019-07-13 22:19:40.829807
 2019-07-13 22:19:40.850117
 2019-07-13 22:19:40.983008
 2019-07-13 22:19:41.040358
 2019-07-13 22:19:41.138533
 2019-07-13 22:19:41.225288
 2019-07-13 22:19:41.254749
 2019-07-13 22:19:41.301274
 2019-07-13 22:19:41.331035
 2019-07-13 22:19:41.356568
 2019-07-13 22:19:41.381656
{noformat}

> scheduler stuck with schedule is 2.30am and timezone is daylight saving time
> 
>
> Key: AIRFLOW-4921
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4921
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: scheduler
>Affects Versions: 1.10.3
>Reporter: dungnguyen
>Priority: Major
>
> Pls correct me if I'm wrong, but I'm still able to reproduce the issue using 
> below code
>  
> {code:java}
> import pendulum
> from airflow import DAG
> from airflow.jobs import SchedulerJob
> from datetime import timedelta, datetime
> tz = pendulum.timezone('America/New_York')
> # Set-up DAG
> test_dag = DAG(
>   dag_id='foo',
>   start_date=datetime(2017, 3, 6, tzinfo=tz),
>   schedule_interval='30 02 * * *',
>   catchup=True
> )
> # manually trigger create_dag_run
> s = SchedulerJob()
> for _ in range(465):
>   dag_run = s.create_dag_run(test_dag)
>   print(dag_run, datetime.now())
> {code}
>  
> The output will be stuck on the date of daylight saving change
>  
> {code:java}
> [2019-07-09 14:46:38,014] {__init__.py:51} INFO - Using executor 
> SequentialExecutor
>  scheduled__2017-03-06T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.268086
>  scheduled__2017-03-07T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.460748
>  scheduled__2017-03-08T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.649766
>  scheduled__2017-03-09T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.838063
>  scheduled__2017-03-10T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:39.030536
>  scheduled__2017-03-11T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:39.219713
>  scheduled__2017-03-12T06:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:39.408905
> {code}
>  
> The suspect I think is a loop in airflow/jobs/scheduler_job.py. This code is 
> stuck when dag.following_schedule(next_run_date) return value with no change
>  
> {code:java}
> # make sure backfills are also considered
> last_run = dag.get_last_dagrun(session=session)
> if last_run and next_run_date:
>   while next_run_date <= last_run.execution_date:
> next_run_date = dag.following_schedule(next_run_date)
> {code}
>  
> Pls let me know if I need to provide more information.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (AIRFLOW-4921) scheduler stuck with schedule is 2.30am and timezone is daylight saving time

[Ash Berlin-Taylor (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884484#comment-16884484
 ] 

Ash Berlin-Taylor commented on AIRFLOW-4921:


Likely already fixed in 1.10.4RC2 by AIRFLOW-4308

> scheduler stuck with schedule is 2.30am and timezone is daylight saving time
> 
>
> Key: AIRFLOW-4921
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4921
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: scheduler
>Affects Versions: 1.10.3
>Reporter: dungnguyen
>Priority: Major
>
> Pls correct me if I'm wrong, but I'm still able to reproduce the issue using 
> below code
>  
> {code:java}
> import pendulum
> from airflow import DAG
> from airflow.jobs import SchedulerJob
> from datetime import timedelta, datetime
> tz = pendulum.timezone('America/New_York')
> # Set-up DAG
> test_dag = DAG(
>   dag_id='foo',
>   start_date=datetime(2017, 3, 6, tzinfo=tz),
>   schedule_interval='30 02 * * *',
>   catchup=True
> )
> # manually trigger create_dag_run
> s = SchedulerJob()
> for _ in range(465):
>   dag_run = s.create_dag_run(test_dag)
>   print(dag_run, datetime.now())
> {code}
>  
> The output will be stuck on the date of daylight saving change
>  
> {code:java}
> [2019-07-09 14:46:38,014] {__init__.py:51} INFO - Using executor 
> SequentialExecutor
>  scheduled__2017-03-06T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.268086
>  scheduled__2017-03-07T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.460748
>  scheduled__2017-03-08T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.649766
>  scheduled__2017-03-09T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:38.838063
>  scheduled__2017-03-10T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:39.030536
>  scheduled__2017-03-11T07:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:39.219713
>  scheduled__2017-03-12T06:30:00+00:00, externally triggered: False> 2019-07-09 
> 14:46:39.408905
> {code}
>  
> The suspect I think is a loop in airflow/jobs/scheduler_job.py. This code is 
> stuck when dag.following_schedule(next_run_date) return value with no change
>  
> {code:java}
> # make sure backfills are also considered
> last_run = dag.get_last_dagrun(session=session)
> if last_run and next_run_date:
>   while next_run_date <= last_run.execution_date:
> next_run_date = dag.following_schedule(next_run_date)
> {code}
>  
> Pls let me know if I need to provide more information.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format

[GitBox]

ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format
URL: https://github.com/apache/airflow/pull/5584#issuecomment-511154360
 
 
   We still need to support Py 3.5 for a while yet, and I'm not in favour of 
Yet Another Style Checker, and I honestly couldn't care which style of string 
formatters people use in PRs, my concern here is 1) the current form works and 
isn't deprecated, it is valid Python 3.8 code. and 2) around git blame/history.
   
   To me the explicit numbers are clearer - I prefer the current version of 
these two:
   
   ```diff
   "Error occurred when calling the grpc service: {0}, 
method: {1} \
   status code: {2}, error details: {3}"
   "Error occurred when calling the grpc service: {}, 
method: {} \
   status code: {}, error details: {}"
   ```
   
   (that is admittedly the longest one in the diff)
   
   And just so you are aware: if we merge this change it makes a 1.10.5 almost 
impossible as now there are 62 more files that won't work on Py2. (`super()` 
was so far the only other major py2 issue and that one is easy enough to catch. 
This is much trickier.)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #5584: [AIRFLOW-4950] Simplify string format

[GitBox]

mik-laj commented on issue #5584: [AIRFLOW-4950] Simplify string format
URL: https://github.com/apache/airflow/pull/5584#issuecomment-511153798
 
 
   No, but it seems to me that when the whole code will be uniform, it will be 
a more readable code. This tool will allow us to automatically unify the whole 
code, and in addition we will be ensured that we always use the recommended 
syntax. I do not care very much about this change.  My main goal is to upgrade 
the syntax to Python 3.6.If we additionally get a code that will be unified in 
terms of code style, this is an additional plus.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4946) Use yield from syntax

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884481#comment-16884481
 ] 

ASF subversion and git services commented on AIRFLOW-4946:
--

Commit 6aaa19b9e533c5df25fe723845720484c4a7b63c in airflow's branch 
refs/heads/master from Kamil Breguła
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=6aaa19b ]

[AIRFLOW-4946] Use yield from syntax (#5580)



> Use yield from syntax
> -
>
> Key: AIRFLOW-4946
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4946
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (AIRFLOW-4946) Use yield from syntax

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884479#comment-16884479
 ] 

ASF GitHub Bot commented on AIRFLOW-4946:
-

BasPH commented on pull request #5580: [AIRFLOW-4946] Use yield from syntax
URL: https://github.com/apache/airflow/pull/5580
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use yield from syntax
> -
>
> Key: AIRFLOW-4946
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4946
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] BasPH merged pull request #5580: [AIRFLOW-4946] Use yield from syntax

[GitBox]

BasPH merged pull request #5580: [AIRFLOW-4946] Use yield from syntax
URL: https://github.com/apache/airflow/pull/5580
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format

[GitBox]

ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format
URL: https://github.com/apache/airflow/pull/5584#issuecomment-511153526
 
 
   Is the current syntax deprecated by Python?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4884) Roll up import_errors in UI

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884476#comment-16884476
 ] 

ASF subversion and git services commented on AIRFLOW-4884:
--

Commit 4e83a1e69b7ca5d61ca2e758fdde2be9363980a8 in airflow's branch 
refs/heads/v1-10-test from shuwen-zhang
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=4e83a1e ]

[AIRFLOW-4884] Roll up import_errors in RBAC UI (#5516)

(cherry picked from commit b9ba6d85b0c7c6ce866f346693c82d4c8997a0d2)


> Roll up import_errors in UI
> ---
>
> Key: AIRFLOW-4884
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4884
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: webserver
>Affects Versions: 1.10.3
>Reporter: Chris McLennon
>Assignee: Chris McLennon
>Priority: Minor
>
> When a DAG suffers from an import_error it populates each error at the top of 
> the Airflow UI in big red flash boxes. For Airflow instances that are shared 
> across multiple teams, this can be annoying when another team's import_errors 
> crowd the top of the screen and cannot be suppressed by users of other teams. 
> I would like to roll up the errors into a collective dropdown so that the 
> information is available and loud without being intrusive.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (AIRFLOW-4884) Roll up import_errors in UI

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884474#comment-16884474
 ] 

ASF subversion and git services commented on AIRFLOW-4884:
--

Commit b9ba6d85b0c7c6ce866f346693c82d4c8997a0d2 in airflow's branch 
refs/heads/master from shuwen-zhang
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=b9ba6d8 ]

[AIRFLOW-4884] Roll up import_errors in UI (#5516)



> Roll up import_errors in UI
> ---
>
> Key: AIRFLOW-4884
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4884
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: webserver
>Affects Versions: 1.10.3
>Reporter: Chris McLennon
>Assignee: Chris McLennon
>Priority: Minor
>
> When a DAG suffers from an import_error it populates each error at the top of 
> the Airflow UI in big red flash boxes. For Airflow instances that are shared 
> across multiple teams, this can be annoying when another team's import_errors 
> crowd the top of the screen and cannot be suppressed by users of other teams. 
> I would like to roll up the errors into a collective dropdown so that the 
> information is available and loud without being intrusive.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] ashb commented on issue #5516: [AIRFLOW-4884] Roll up import_errors in UI

[GitBox]

ashb commented on issue #5516: [AIRFLOW-4884] Roll up import_errors in UI
URL: https://github.com/apache/airflow/pull/5516#issuecomment-511153011
 
 
   /AIRFLOW-4748 was the PR for 
including stack traces in the dag-bag errors, but done the "naive" way they 
were _very_ long. If you can come to add stack traces please use that existing 
JIRA


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4884) Roll up import_errors in UI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884473#comment-16884473
 ] 

ASF GitHub Bot commented on AIRFLOW-4884:
-

ashb commented on pull request #5516: [AIRFLOW-4884] Roll up import_errors in UI
URL: https://github.com/apache/airflow/pull/5516
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Roll up import_errors in UI
> ---
>
> Key: AIRFLOW-4884
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4884
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: webserver
>Affects Versions: 1.10.3
>Reporter: Chris McLennon
>Assignee: Chris McLennon
>Priority: Minor
>
> When a DAG suffers from an import_error it populates each error at the top of 
> the Airflow UI in big red flash boxes. For Airflow instances that are shared 
> across multiple teams, this can be annoying when another team's import_errors 
> crowd the top of the screen and cannot be suppressed by users of other teams. 
> I would like to roll up the errors into a collective dropdown so that the 
> information is available and loud without being intrusive.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] ashb commented on issue #5516: [AIRFLOW-4884] Roll up import_errors in UI

[GitBox]

ashb commented on issue #5516: [AIRFLOW-4884] Roll up import_errors in UI
URL: https://github.com/apache/airflow/pull/5516#issuecomment-511152927
 
 
   Nice. I'll cherry-pick this back to 1.10.4 (but only for the RBAC ui)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #5580: [AIRFLOW-4946] Use yield from syntax

[GitBox]

codecov-io commented on issue #5580: [AIRFLOW-4946] Use yield from syntax
URL: https://github.com/apache/airflow/pull/5580#issuecomment-511152896
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5580?src=pr=h1) 
Report
   > Merging 
[#5580](https://codecov.io/gh/apache/airflow/pull/5580?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f06ae8fbe9a5c786f0299872abc85d9960b05886?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5580/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5580?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5580  +/-   ##
   ==
   + Coverage   79.06%   79.07%   +<.01% 
   ==
 Files 489  489  
 Lines   3071130705   -6 
   ==
   - Hits2428324279   -4 
   + Misses   6428 6426   -2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/5580?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/hooks/grpc\_hook.py](https://codecov.io/gh/apache/airflow/pull/5580/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2dycGNfaG9vay5weQ==)
 | `93.33% <0%> (+1.53%)` | :arrow_up: |
   | 
[airflow/lineage/datasets.py](https://codecov.io/gh/apache/airflow/pull/5580/diff?src=pr=tree#diff-YWlyZmxvdy9saW5lYWdlL2RhdGFzZXRzLnB5)
 | `84.93% <0%> (+1.14%)` | :arrow_up: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/5580/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `77.66% <100%> (-0.06%)` | :arrow_down: |
   | 
[airflow/ti\_deps/deps/trigger\_rule\_dep.py](https://codecov.io/gh/apache/airflow/pull/5580/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvdHJpZ2dlcl9ydWxlX2RlcC5weQ==)
 | `90.78% <100%> (-0.12%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/sagemaker\_hook.py](https://codecov.io/gh/apache/airflow/pull/5580/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NhZ2VtYWtlcl9ob29rLnB5)
 | `88.16% <100%> (-0.05%)` | :arrow_down: |
   | 
[airflow/ti\_deps/deps/base\_ti\_dep.py](https://codecov.io/gh/apache/airflow/pull/5580/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvYmFzZV90aV9kZXAucHk=)
 | `90.47% <100%> (-0.23%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5580?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5580?src=pr=footer). 
Last update 
[f06ae8f...e23e886](https://codecov.io/gh/apache/airflow/pull/5580?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb merged pull request #5516: [AIRFLOW-4884] Roll up import_errors in UI

[GitBox]

ashb merged pull request #5516: [AIRFLOW-4884] Roll up import_errors in UI
URL: https://github.com/apache/airflow/pull/5516
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #4291: [AIRFLOW-1488] Add the TriggeredDagRunSensor operator

[GitBox]

ashb commented on issue #4291: [AIRFLOW-1488] Add the TriggeredDagRunSensor 
operator
URL: https://github.com/apache/airflow/pull/4291#issuecomment-511152626
 
 
   > I can not start DAT_PUBLISH if there is DAG_UPDATE_PRICES in RUNNING
   
   https://airflow.apache.org/concepts.html#pools


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #5584: [AIRFLOW-4950] Simplify string format

[GitBox]

mik-laj commented on issue #5584: [AIRFLOW-4950] Simplify string format
URL: https://github.com/apache/airflow/pull/5584#issuecomment-511152368
 
 
   This will help maintain good health of the code. When this change is 
accepted, it will be possible to automatically verify the code.
   https://github.com/asottile/pyupgrade


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #5057: [AIRFLOW-4257] Remove the global session from the core test

[GitBox]

ashb commented on issue #5057: [AIRFLOW-4257] Remove the global session from 
the core test
URL: https://github.com/apache/airflow/pull/5057#issuecomment-511151048
 
 
   Yeah, I've done a bit of experimentation with Pytest, and started 
https://issues.apache.org/jira/browse/AIRFLOW-4863 as a result - those were all 
pre-reqs I found that stopped py.test working on the whole test suite.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #5578: [AIRFLOW-4944] Use new types syntax

[GitBox]

codecov-io commented on issue #5578: [AIRFLOW-4944] Use new types syntax
URL: https://github.com/apache/airflow/pull/5578#issuecomment-511150952
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5578?src=pr=h1) 
Report
   > Merging 
[#5578](https://codecov.io/gh/apache/airflow/pull/5578?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f06ae8fbe9a5c786f0299872abc85d9960b05886?src=pr=desc)
 will **decrease** coverage by `0.36%`.
   > The diff coverage is `88.88%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5578/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5578?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #5578  +/-   ##
   =
   - Coverage   79.06%   78.7%   -0.37% 
   =
 Files 489 489  
 Lines   30711   30711  
   =
   - Hits24283   24170 -113 
   - Misses   64286541 +113
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/5578?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/5578/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `66.45% <0%> (ø)` | :arrow_up: |
   | 
[airflow/www/utils.py](https://codecov.io/gh/apache/airflow/pull/5578/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvdXRpbHMucHk=)
 | `82.32% <100%> (ø)` | :arrow_up: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/5578/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `75.94% <100%> (-1.78%)` | :arrow_down: |
   | 
[airflow/www/security.py](https://codecov.io/gh/apache/airflow/pull/5578/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvc2VjdXJpdHkucHk=)
 | `92.3% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/operators/hipchat\_operator.py](https://codecov.io/gh/apache/airflow/pull/5578/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9oaXBjaGF0X29wZXJhdG9yLnB5)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/5578/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/5578/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/5578/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5578/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==)
 | `47.61% <0%> (-52.39%)` | :arrow_down: |
   | 
[airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5578/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5)
 | `68.6% <0%> (-10.47%)` | :arrow_down: |
   | ... and [7 
more](https://codecov.io/gh/apache/airflow/pull/5578/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5578?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5578?src=pr=footer). 
Last update 
[f06ae8f...cb57275](https://codecov.io/gh/apache/airflow/pull/5578?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #5543: Fix permission error when creating logs

[GitBox]

ashb commented on issue #5543: Fix permission error when creating logs
URL: https://github.com/apache/airflow/pull/5543#issuecomment-511150905
 
 
   This will change the path to point to something other than the RIGHT path.
   
   If I set my dag_dir to `/a/b/c/d/../../e` This would write logs to 
`a/b/c/d/e`, instaed of `a/b/e`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb closed pull request #5543: Fix permission error when creating logs

[GitBox]

ashb closed pull request #5543: Fix permission error when creating logs
URL: https://github.com/apache/airflow/pull/5543
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

[GitBox]

mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new 
style classes
URL: https://github.com/apache/airflow/pull/5585#discussion_r303217602
 
 

 ##
 File path: airflow/_vendor/nvd3/NVD3Chart.py
 ##
 @@ -36,7 +36,7 @@ def stab(tab=1):
 return ' ' * 4 * tab
 
 
-class NVD3Chart(object):
+class NVD3Chart:
 
 Review comment:
   Fix pushed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] BasPH commented on issue #5057: [AIRFLOW-4257] Remove the global session from the core test

[GitBox]

BasPH commented on issue #5057: [AIRFLOW-4257] Remove the global session from 
the core test
URL: https://github.com/apache/airflow/pull/5057#issuecomment-511150879
 
 
   Unrelated to this issue; but for the concern about boilerplate code I know 
there's some work being done on getting pytest in Airflow.
   
   A pytest fixture `test_session` (function scoped session) similar to 
`tmpdir` would prevent many duplicate `with create_session()...`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #5579: [AIRFLOW-4945] Use super() syntax

[GitBox]

ashb commented on issue #5579: [AIRFLOW-4945] Use super() syntax
URL: https://github.com/apache/airflow/pull/5579#issuecomment-511150796
 
 
   This should have been AIRFLOW-4204 - there was already a Jira for this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format

[GitBox]

ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format
URL: https://github.com/apache/airflow/pull/5584#issuecomment-511150712
 
 
   I think I'm -0.5 on this -- it is a lot of diff that makes `git 
blame`/history noisier and what is there is not deprecated or wrong.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

[GitBox]

mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new 
style classes
URL: https://github.com/apache/airflow/pull/5585#discussion_r303217518
 
 

 ##
 File path: airflow/_vendor/nvd3/NVD3Chart.py
 ##
 @@ -36,7 +36,7 @@ def stab(tab=1):
 return ' ' * 4 * tab
 
 
-class NVD3Chart(object):
+class NVD3Chart:
 
 Review comment:
   Changes should be made in the original repository, but we already have 
changes in this directory.
   https://github.com/apache/airflow/commits/master/airflow/_vendor
   Secondly. This change does not change anything in the behavior of the 
library, so it does not matter much. Changes to library behavior should not 
have a place for sure.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

[GitBox]

mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new 
style classes
URL: https://github.com/apache/airflow/pull/5585#discussion_r303217525
 
 

 ##
 File path: airflow/_vendor/nvd3/NVD3Chart.py
 ##
 @@ -36,7 +36,7 @@ def stab(tab=1):
 return ' ' * 4 * tab
 
 
-class NVD3Chart(object):
+class NVD3Chart:
 
 Review comment:
   I will update this PR. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

[GitBox]

ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not 
applied via setter
URL: https://github.com/apache/airflow/pull/5574#issuecomment-511150575
 
 
   I'd be very careful about deprecating something as "fundamental" as 
`task.dag = dag` -- even for 2.0.0 that would still potentially need a large 
number of dags in user installs to be re-written, which isn't a step we should 
take lightly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

[GitBox]

ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not 
applied via setter
URL: https://github.com/apache/airflow/pull/5574#issuecomment-511150505
 
 
   @milton0825 How does the context manager handle this case:
   
   ```
   dag = DAG('dag', default_args={'email_on_failure': False})
   
   with dag:
   op = BaseOperator(
   task_id='op',
   email_on_failure=True,  # happen to be the same as the default value 
in __init__ signature
   )
   ```
   
   Is the difference that @apply_defaults is applied at instantiation time? so 
this ends up with `email_on_failure=True`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

[GitBox]

ashb commented on a change in pull request #5585: [AIRFLOW-4951] Use new style 
classes
URL: https://github.com/apache/airflow/pull/5585#discussion_r303217437
 
 

 ##
 File path: airflow/_vendor/nvd3/NVD3Chart.py
 ##
 @@ -36,7 +36,7 @@ def stab(tab=1):
 return ' ' * 4 * tab
 
 
-class NVD3Chart(object):
+class NVD3Chart:
 
 Review comment:
   I prefer we didn't change code in `_vendor` unless we _have_ to.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] BasPH commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

[GitBox]

BasPH commented on a change in pull request #5585: [AIRFLOW-4951] Use new style 
classes
URL: https://github.com/apache/airflow/pull/5585#discussion_r303217355
 
 

 ##
 File path: airflow/_vendor/nvd3/NVD3Chart.py
 ##
 @@ -36,7 +36,7 @@ def stab(tab=1):
 return ' ' * 4 * tab
 
 
-class NVD3Chart(object):
+class NVD3Chart:
 
 Review comment:
   Should we maintain code in `_vendor`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Assigned] (AIRFLOW-4942) Drop six.next

[Kamil (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil reassigned AIRFLOW-4942:
--

Assignee: Kamil

> Drop six.next
> -
>
> Key: AIRFLOW-4942
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4942
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Assigned] (AIRFLOW-4947) Remove six types

[Kamil (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil reassigned AIRFLOW-4947:
--

Assignee: Kamil

> Remove six types
> 
>
> Key: AIRFLOW-4947
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4947
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Assigned] (AIRFLOW-4946) Use yield from syntax

[Kamil (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil reassigned AIRFLOW-4946:
--

Assignee: Kamil

> Use yield from syntax
> -
>
> Key: AIRFLOW-4946
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4946
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Assigned] (AIRFLOW-4943) Replace six assertion method with native

[Kamil (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil reassigned AIRFLOW-4943:
--

Assignee: Kamil

> Replace six assertion method with native
> 
>
> Key: AIRFLOW-4943
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4943
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Assigned] (AIRFLOW-4948) Use items, values method instead six package

[Kamil (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil reassigned AIRFLOW-4948:
--

Assignee: Kamil

> Use items, values method instead six package
> 
>
> Key: AIRFLOW-4948
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4948
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Assigned] (AIRFLOW-4945) Use super() syntax

[Kamil (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil reassigned AIRFLOW-4945:
--

Assignee: Kamil

> Use super() syntax
> --
>
> Key: AIRFLOW-4945
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4945
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Assigned] (AIRFLOW-4944) Use new types syntax

[Kamil (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil reassigned AIRFLOW-4944:
--

Assignee: Kamil

> Use new types syntax
> 
>
> Key: AIRFLOW-4944
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4944
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Assigned] (AIRFLOW-4949) Use OSError exception

[Kamil (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil reassigned AIRFLOW-4949:
--

Assignee: Kamil

> Use OSError exception
> -
>
> Key: AIRFLOW-4949
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4949
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Assigned] (AIRFLOW-4951) Use new style classes

[Kamil (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil reassigned AIRFLOW-4951:
--

Assignee: Kamil

> Use new style classes
> -
>
> Key: AIRFLOW-4951
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4951
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Assignee: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (AIRFLOW-4942) Drop six.next

[Kamil (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil updated AIRFLOW-4942:
---
Issue Type: Sub-task  (was: Improvement)
Parent: AIRFLOW-4196

> Drop six.next
> -
>
> Key: AIRFLOW-4942
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4942
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

[GitBox]

milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that 
default_args not applied via setter
URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149532
 
 
   @ashb I thought about applying `default_args` in the setter but I don't see 
how we can support the following case easily without complicating the code a 
lot:
   
   If user specified a arg with value equal to the default arg value in the 
`__init__` signature, we won't be able to tell from the setter whether the 
value is set by user or it is just default value. Please find the example below:
   ```
   dag = DAG('dag', default_args={'email_on_failure': False})
   
   op = BaseOperator(
   task_id='op',
   email_on_failure=True,  # happen to be the same as the default value in 
__init__ signature
   )
   
   op.dag = dag
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] milton0825 commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

[GitBox]

milton0825 commented on issue #5574: [AIRFLOW-4941] Warn that default_args not 
applied via setter
URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149609
 
 
   @feluelle I see that it is flooding the CI since there are actually quite 
some example dags using the setter. I feel like deprecating the setter would 
simplify things a lot.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

[GitBox]

milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that 
default_args not applied via setter
URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149532
 
 
   @ashb I thought about applying `default_args` in the setter but I don't see 
how we can support the following case easily without complicating the code a 
lot:
   
   If user specified a arg with value equal to the default arg value in the 
`__init__` signature, we won't be able to tell from the setter whether we 
should override the value with the `default_args`. Please find the example 
below:
   ```
   dag = DAG('dag', default_args={'email_on_failure': False})
   
   op = BaseOperator(
   task_id='op',
   email_on_failure=True,  # happen to be the same as the default value in 
__init__ signature
   )
   
   op.dag = dag
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

[GitBox]

milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that 
default_args not applied via setter
URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149532
 
 
   @ashb I thought about applying `default_args` in the setter but I don't see 
how we can support the following case easily without complicating the code a 
lot:
   
   If user specified a arg with value equal to the default arg value in the 
__init__ signature, we won't be able to tell from the setter whether we should 
override the value with the default_args. Please find the example below:
   ```
   dag = DAG('dag', default_args={'email_on_failure': False})
   
   op = BaseOperator(
   task_id='op',
   email_on_failure=True,  # happen to be the same as the default value in 
__init__ signature
   )
   
   op.dag = dag
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] milton0825 commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

[GitBox]

milton0825 commented on issue #5574: [AIRFLOW-4941] Warn that default_args not 
applied via setter
URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149532
 
 
   @ashb I thought about applying `default_args` in the setter but I don't see 
how we can support the following case easily:
   
   If user specified a arg with value equal to the default arg value in the 
__init__ signature, we won't be able to tell from the setter whether we should 
override the value with the default_args. Please find the example below:
   ```
   dag = DAG('dag', default_args={'email_on_failure': False})
   
   op = BaseOperator(
   task_id='op',
   email_on_failure=True,  # happen to be the same as the default value in 
__init__ signature
   )
   
   op.dag = dag
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #5585: [AIRFLOW-4951] Use new style classes

[GitBox]

codecov-io commented on issue #5585: [AIRFLOW-4951] Use new style classes
URL: https://github.com/apache/airflow/pull/5585#issuecomment-511149460
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=h1) 
Report
   > Merging 
[#5585](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f06ae8fbe9a5c786f0299872abc85d9960b05886?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5585/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5585  +/-   ##
   ==
   - Coverage   79.06%   79.06%   -0.01% 
   ==
 Files 489  489  
 Lines   3071130711  
   ==
   - Hits2428324282   -1 
   - Misses   6428 6429   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==)
 | `66.24% <100%> (ø)` | :arrow_up: |
   | 
[airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5585/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5)
 | `93.02% <0%> (-0.17%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=footer). 
Last update 
[f06ae8f...55481fd](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

[GitBox]

ashb commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI 
tests [Step 3/3]
URL: https://github.com/apache/airflow/pull/4938#issuecomment-511149357
 
 
   What was the problem with debian buster btw?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

[GitBox]

ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging 
Image - Travis CI tests [Step 3/3]
URL: https://github.com/apache/airflow/pull/4938#discussion_r303216882
 
 

 ##
 File path: scripts/ci/ci_docs.sh
 ##
 @@ -1,43 +1,52 @@
 #!/usr/bin/env bash
-
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements.  See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License.  You may obtain a copy of the License at
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
 #
-#http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
+#   http://www.apache.org/licenses/LICENSE-2.0
 #
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 set -euo pipefail
 
 MY_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+
 # shellcheck source=./_check_not_in_container.sh
 . "${MY_DIR}/_check_not_in_container.sh"
+# shellcheck source=./_force_python_3.6.sh
+. "${MY_DIR}"/_force_python_3.6.sh
+# shellcheck source=./_check_coreutils.sh
+. "${MY_DIR}"/_check_coreutils.sh
+# shellcheck source=./_cache_utils.sh
+. "${MY_DIR}"/_cache_utils.sh
+# shellcheck source=./_verbosity_utils.sh
+. "${MY_DIR}"/_verbosity_utils.sh
 
 Review comment:
   A lot of these scripts have the exact same prelude/checks don't they? Could 
we reduce duplication somewhere?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

[GitBox]

ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging 
Image - Travis CI tests [Step 3/3]
URL: https://github.com/apache/airflow/pull/4938#discussion_r303216801
 
 

 ##
 File path: scripts/ci/_force_python_3.6.sh
 ##
 @@ -0,0 +1,34 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Force Python version to 3.6 for some scripts
+export PYTHON_BINARY=python3.6
+
+# And fail in case it is not available
+if [[ ! -x "$(command -v "${PYTHON_BINARY}")" ]]; then
+echo >&2
+echo >&2 "${PYTHON_BINARY} is missing in your \$PATH"
+echo >&2
+echo >&2 "Please install Python 3.6 and make it available in your path"
+echo >&2
+exit 1
+fi
+
+# Set python version variable to force it in the scripts as well
+PYTHON_VERSION=3.6
+export PYTHON_VERSION
 
 Review comment:
   Code organisation point: There are a lot of these "helper" scripts that are 
sourced. What do you think to combining them in to a `scripts/ci/_utils.sh` as 
functions, so this would be used something like:
   
   ```bash
   . "${MY_DIR}"/_utils.sh
   airflow_force_python_3_6
   ```
   
   etc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

[GitBox]

ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging 
Image - Travis CI tests [Step 3/3]
URL: https://github.com/apache/airflow/pull/4938#discussion_r303216729
 
 

 ##
 File path: scripts/ci/_cache_utils.sh
 ##
 @@ -0,0 +1,99 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+AIRFLOW_SOURCES=$(pwd)
+export AIRFLOW_SOURCES
+
+BUILD_CACHE_DIR="${AIRFLOW_SOURCES}/.build"
+mkdir -p "${BUILD_CACHE_DIR}/cache/"
+
+USE_LOCALLY_BUILD_IMAGES_AS_CACHE="${BUILD_CACHE_DIR}/.use_locally_built_images_as_cache_${PYTHON_VERSION}"
+CACHE_TMP_FILE_DIR=$(mktemp -d "${BUILD_CACHE_DIR}/cache/XX")
+
+if [[ ${SKIP_CACHE_DELETION:=} != "true" ]]; then
+trap 'rm -rf -- "${CACHE_TMP_FILE_DIR}"' INT TERM HUP EXIT
+fi
+
+function check_file_md5sum {
+local FILE="${1}"
+local MD5SUM
+MD5SUM=$(md5sum "${FILE}")
+local MD5SUM_FILE
+MD5SUM_FILE=${BUILD_CACHE_DIR}/$(basename "${FILE}").md5sum
+local MD5SUM_FILE_NEW
+MD5SUM_FILE_NEW=${CACHE_TMP_FILE_DIR}/$(basename "${FILE}").md5sum.new
+echo "${MD5SUM}" > "${MD5SUM_FILE_NEW}"
+local RET_CODE=0
+if [[ ! -f "${MD5SUM_FILE}" ]]; then
+echo "Missing md5sum for ${FILE}"
+RET_CODE=1
+else
+diff "${MD5SUM_FILE_NEW}" "${MD5SUM_FILE}" >/dev/null
+RES=$?
+if [[ "${RES}" != "0" ]]; then
+echo "The md5sum changed for ${FILE}"
+RET_CODE=1
+fi
+fi
+return ${RET_CODE}
+}
+
+function move_file_md5sum {
+local FILE="${1}"
+local MD5SUM_FILE
+MD5SUM_FILE=${BUILD_CACHE_DIR}/$(basename "${FILE}").md5sum
+local MD5SUM_FILE_NEW
+MD5SUM_FILE_NEW=${CACHE_TMP_FILE_DIR}/$(basename "${FILE}").md5sum.new
+if [[ -f "${MD5SUM_FILE_NEW}" ]]; then
+mv "${MD5SUM_FILE_NEW}" "${MD5SUM_FILE}"
+echo "Updated md5sum file ${MD5SUM_FILE} for ${FILE}."
+fi
+}
+
+FILES_FOR_REBUILD_CHECK="\
+setup.py \
+setup.cfg \
+Dockerfile \
+airflow/version.py \
+airflow/www/package.json \
+airflow/www/package-lock.json
+"
+
+function update_all_md5_files() {
+# Record that we built the images locally so that next time we use 
"standard" cache
+touch "${USE_LOCALLY_BUILD_IMAGES_AS_CACHE}"
+echo
+echo "Updating md5sum files"
+echo
+for FILE in ${FILES_FOR_REBUILD_CHECK}
+do
+move_file_md5sum "${AIRFLOW_SOURCES}/${FILE}"
+done
+}
+
+function check_if_docker_build_is_needed() {
+set +e
+
+for FILE in ${FILES_FOR_REBUILD_CHECK}
+do
+if ! check_file_md5sum "${AIRFLOW_SOURCES}/${FILE}"; then
 
 Review comment:
   This seems like we are doing docker's job for it. Is this just because 
copying files over to the docker daemon takes a long time? If so can we add a 
comment saying _why_ we do this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

[GitBox]

ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging 
Image - Travis CI tests [Step 3/3]
URL: https://github.com/apache/airflow/pull/4938#discussion_r303216568
 
 

 ##
 File path: scripts/ci/docker-compose-local.yml
 ##
 @@ -0,0 +1,42 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: "2.2"
+services:
+  airflow-testing:
+volumes:
+  - ../../airflow:/opt/airflow/airflow
+  - ../../setup.cfg:/opt/airflow/setup.cfg
+  - ../../setup.py:/opt/airflow/setup.py
+  - ../../dags:/opt/airflow/dags
+  - ../../dev:/opt/airflow/dev
+  - ../../docs:/opt/airflow/docs
+  - ../../hooks:/opt/airflow/hooks
+  - ../../scripts:/opt/airflow/scripts
+  - ../../tests:/opt/airflow/tests
+  - ../../.coveragerc:/opt/airflow/.coveragerc
+  - ../../LICENSE:/opt/airflow/LICENSE
+  - ../../MANIFEST.in:/opt/airflow/MANIFEST.in
+  - ../../NOTICE:/opt/airflow/NOTICE
+  - ../../CHANGELOG.txt:/opt/airflow/CHANGELOG
+  - ../../.github:/opt/airflow/.github
+  - ../../.flake8:/opt/airflow/.flake8
+  - ../../pylintrc:/opt/airflow/pylintrc
+  - ../../.rat-excludes:/opt/airflow/.rat-excludes
+  - ../../run-tests:/opt/airflow/run-tests
+  - ../../logs:/root/airflow/logs
 
 Review comment:
   Oh good to know.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI

[GitBox]

ashb commented on issue #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI
URL: https://github.com/apache/airflow/pull/5573#issuecomment-511148508
 
 
   For running on master branch two things:
   
   1. Run `setup.py compile_assets`
   2. Use the `airflow users -c` option (you man need to do `pip install -e .` 
first)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #5580: [AIRFLOW-4946] Use yield from syntax

[GitBox]

ashb commented on a change in pull request #5580: [AIRFLOW-4946] Use yield from 
syntax
URL: https://github.com/apache/airflow/pull/5580#discussion_r303216456
 
 

 ##
 File path: airflow/contrib/hooks/grpc_hook.py
 ##
 @@ -100,8 +100,7 @@ def run(self, stub_class, call_func, streaming=False, 
data={}):
 if not streaming:
 yield response
 else:
-for single_response in response:
-yield single_response
+yield from response
 
 Review comment:
   Nice, learn something new every day!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (AIRFLOW-4942) Drop six.next

[Kamil (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil updated AIRFLOW-4942:
---
Summary: Drop six.next  (was: Replace six.next with next)

> Drop six.next
> -
>
> Key: AIRFLOW-4942
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4942
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] codecov-io edited a comment on issue #5583: [AIRFLOW-4949] Use OSError exception

[GitBox]

codecov-io edited a comment on issue #5583: [AIRFLOW-4949] Use OSError exception
URL: https://github.com/apache/airflow/pull/5583#issuecomment-511147742
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=h1) 
Report
   > Merging 
[#5583](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f06ae8fbe9a5c786f0299872abc85d9960b05886?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `40%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5583/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#5583   +/-   ##
   ===
 Coverage   79.06%   79.06%   
   ===
 Files 489  489   
 Lines   3071130711   
   ===
 Hits2428324283   
 Misses   6428 6428
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/5583/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=)
 | `75.15% <0%> (ø)` | :arrow_up: |
   | 
[airflow/security/utils.py](https://codecov.io/gh/apache/airflow/pull/5583/diff?src=pr=tree#diff-YWlyZmxvdy9zZWN1cml0eS91dGlscy5weQ==)
 | `50% <0%> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/get\_code.py](https://codecov.io/gh/apache/airflow/pull/5583/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC9nZXRfY29kZS5weQ==)
 | `76.92% <0%> (ø)` | :arrow_up: |
   | 
[airflow/api/client/json\_client.py](https://codecov.io/gh/apache/airflow/pull/5583/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY2xpZW50L2pzb25fY2xpZW50LnB5)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/operators/sftp\_operator.py](https://codecov.io/gh/apache/airflow/pull/5583/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zZnRwX29wZXJhdG9yLnB5)
 | `87.5% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/sensors/sftp\_sensor.py](https://codecov.io/gh/apache/airflow/pull/5583/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvc2Z0cF9zZW5zb3IucHk=)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/5583/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `66.45% <50%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=footer). 
Last update 
[f06ae8f...50e1087](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #5583: [AIRFLOW-4949] Use OSError exception

[GitBox]

codecov-io commented on issue #5583: [AIRFLOW-4949] Use OSError exception
URL: https://github.com/apache/airflow/pull/5583#issuecomment-511147742
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=h1) 
Report
   > Merging 
[#5583](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/f06ae8fbe9a5c786f0299872abc85d9960b05886?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `40%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5583/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#5583   +/-   ##
   ===
 Coverage   79.06%   79.06%   
   ===
 Files 489  489   
 Lines   3071130711   
   ===
 Hits2428324283   
 Misses   6428 6428
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/5583/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=)
 | `75.15% <0%> (ø)` | :arrow_up: |
   | 
[airflow/security/utils.py](https://codecov.io/gh/apache/airflow/pull/5583/diff?src=pr=tree#diff-YWlyZmxvdy9zZWN1cml0eS91dGlscy5weQ==)
 | `50% <0%> (ø)` | :arrow_up: |
   | 
[airflow/api/common/experimental/get\_code.py](https://codecov.io/gh/apache/airflow/pull/5583/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC9nZXRfY29kZS5weQ==)
 | `76.92% <0%> (ø)` | :arrow_up: |
   | 
[airflow/api/client/json\_client.py](https://codecov.io/gh/apache/airflow/pull/5583/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvY2xpZW50L2pzb25fY2xpZW50LnB5)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/operators/sftp\_operator.py](https://codecov.io/gh/apache/airflow/pull/5583/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zZnRwX29wZXJhdG9yLnB5)
 | `87.5% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/sensors/sftp\_sensor.py](https://codecov.io/gh/apache/airflow/pull/5583/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvc2Z0cF9zZW5zb3IucHk=)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/5583/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `66.45% <50%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=footer). 
Last update 
[f06ae8f...50e1087](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (AIRFLOW-4943) Replace six assertion method with native

[Jarek Potiuk (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk updated AIRFLOW-4943:
--
Issue Type: Sub-task  (was: Improvement)
Parent: AIRFLOW-4196

> Replace six assertion method with native
> 
>
> Key: AIRFLOW-4943
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4943
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (AIRFLOW-4944) Use new types syntax

[Jarek Potiuk (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk updated AIRFLOW-4944:
--
Issue Type: Sub-task  (was: Improvement)
Parent: AIRFLOW-4196

> Use new types syntax
> 
>
> Key: AIRFLOW-4944
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4944
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (AIRFLOW-4945) Use super() syntax

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884455#comment-16884455
 ] 

ASF GitHub Bot commented on AIRFLOW-4945:
-

potiuk commented on pull request #5579: [AIRFLOW-4945] Use super() syntax
URL: https://github.com/apache/airflow/pull/5579
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use super() syntax
> --
>
> Key: AIRFLOW-4945
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4945
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Resolved] (AIRFLOW-4945) Use super() syntax

[Jarek Potiuk (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk resolved AIRFLOW-4945.
---
   Resolution: Fixed
Fix Version/s: 2.0.0

> Use super() syntax
> --
>
> Key: AIRFLOW-4945
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4945
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (AIRFLOW-4945) Use super() syntax

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884456#comment-16884456
 ] 

ASF subversion and git services commented on AIRFLOW-4945:
--

Commit fe20a9aa0117859b19ecfe476ae76729c55dec20 in airflow's branch 
refs/heads/master from Kamil Breguła
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=fe20a9a ]

[AIRFLOW-4945] Use super() syntax (#5579)



> Use super() syntax
> --
>
> Key: AIRFLOW-4945
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4945
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [airflow] potiuk merged pull request #5579: [AIRFLOW-4945] Use super() syntax

[GitBox]

potiuk merged pull request #5579: [AIRFLOW-4945] Use super() syntax
URL: https://github.com/apache/airflow/pull/5579
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (AIRFLOW-4945) Use super() syntax

[Jarek Potiuk (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk updated AIRFLOW-4945:
--
Issue Type: Sub-task  (was: Improvement)
Parent: AIRFLOW-4196

> Use super() syntax
> --
>
> Key: AIRFLOW-4945
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4945
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: core
>Affects Versions: 1.10.3
>Reporter: Kamil
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)