[jira] [Commented] (AIRFLOW-6517) make merge_dicts recursive

2020-01-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011520#comment-17011520
 ] 

ASF GitHub Bot commented on AIRFLOW-6517:
-

dstandish commented on pull request #7111: [AIRFLOW-6517] make merge_dicts 
function recursive
URL: https://github.com/apache/airflow/pull/7111
 
 
   to support nested dictionaries
   
   it is a utility used in jsonformatter but useful for merging kwargs between 
conn extra and hook params
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> make merge_dicts recursive
> --
>
> Key: AIRFLOW-6517
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6517
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: utils
>Affects Versions: 1.10.7
>Reporter: Daniel Standish
>Assignee: Daniel Standish
>Priority: Trivial
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] dstandish opened a new pull request #7111: [AIRFLOW-6517] make merge_dicts function recursive

2020-01-08 Thread GitBox
dstandish opened a new pull request #7111: [AIRFLOW-6517] make merge_dicts 
function recursive
URL: https://github.com/apache/airflow/pull/7111
 
 
   to support nested dictionaries
   
   it is a utility used in jsonformatter but useful for merging kwargs between 
conn extra and hook params
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (AIRFLOW-5704) Docker scripts for kind kubernetes tests can be improved

2020-01-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011512#comment-17011512
 ] 

ASF GitHub Bot commented on AIRFLOW-5704:
-

potiuk commented on pull request #6516: [AIRFLOW-5704] Improve Kind Kubernetes 
scripts for local testing
URL: https://github.com/apache/airflow/pull/6516
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Docker scripts for kind kubernetes tests can be improved
> 
>
> Key: AIRFLOW-5704
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5704
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: breeze, ci, dependencies
>Affects Versions: 2.0.0
>Reporter: Jarek Potiuk
>Assignee: Jarek Potiuk
>Priority: Major
> Fix For: 2.0.0
>
>
> The docker CI image for kind tests can be improved
>  
>  * Kubernetes Version and all the installation of docker + kubectl + kind can 
> be added back
>  * Running kubernetes scripts should be possible from within breeze without 
> special "kubernetes" environment
>  * --env breeze switch should be removed
>  * "bare" environment should be replaced by --no-deps switch
>  * ENV variable should disappear
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-5704) Docker scripts for kind kubernetes tests can be improved

2020-01-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011513#comment-17011513
 ] 

ASF GitHub Bot commented on AIRFLOW-5704:
-

potiuk commented on pull request #6516: [AIRFLOW-5704] Improve Kind Kubernetes 
scripts for local testing
URL: https://github.com/apache/airflow/pull/6516
 
 
   * Fixed problem that Kubernetes tests were testing latest master
 rather than what came from the local sources.
   * Kind (Kubernetes in Dcocker) is run in the same Docker as Breeze env
   * Moved Kubernetes scripts to 'in_container' dir where they belong now
   * Kubernetes cluster is reused until it is stopped
   * Kubernetes image is build from image in docker already + mounted sources
   * Kubectl version name is corrected in the Dockerfile
   * KUBERNETES_VERSION can now be used to select Kubernetes version
   * Running kubernetes scripts is now easy in Breeze
   * We can start/recreate/stop cluster using  ---kind-cluster
   * Instructions on how to run Kubernetes tests are updated
   * The old "bare" environment is replaced by --no-deps switch
   
   ---
   Issue link: 
[AIRFLOW-5704](https://issues.apache.org/jira/browse/AIRFLOW-5704/)
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Docker scripts for kind kubernetes tests can be improved
> 
>
> Key: AIRFLOW-5704
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5704
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: breeze, ci, dependencies
>Affects Versions: 2.0.0
>Reporter: Jarek Potiuk
>Assignee: Jarek Potiuk
>Priority: Major
> Fix For: 2.0.0
>
>
> The docker CI image for kind tests can be improved
>  
>  * Kubernetes Version and all the installation of docker + kubectl + kind can 
> be added back
>  * Running kubernetes scripts should be possible from within breeze without 
> special "kubernetes" environment
>  * --env breeze switch should be removed
>  * "bare" environment should be replaced by --no-deps switch
>  * ENV variable should disappear
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] potiuk opened a new pull request #6516: [AIRFLOW-5704] Improve Kind Kubernetes scripts for local testing

2020-01-08 Thread GitBox
potiuk opened a new pull request #6516: [AIRFLOW-5704] Improve Kind Kubernetes 
scripts for local testing
URL: https://github.com/apache/airflow/pull/6516
 
 
   * Fixed problem that Kubernetes tests were testing latest master
 rather than what came from the local sources.
   * Kind (Kubernetes in Dcocker) is run in the same Docker as Breeze env
   * Moved Kubernetes scripts to 'in_container' dir where they belong now
   * Kubernetes cluster is reused until it is stopped
   * Kubernetes image is build from image in docker already + mounted sources
   * Kubectl version name is corrected in the Dockerfile
   * KUBERNETES_VERSION can now be used to select Kubernetes version
   * Running kubernetes scripts is now easy in Breeze
   * We can start/recreate/stop cluster using  ---kind-cluster
   * Instructions on how to run Kubernetes tests are updated
   * The old "bare" environment is replaced by --no-deps switch
   
   ---
   Issue link: 
[AIRFLOW-5704](https://issues.apache.org/jira/browse/AIRFLOW-5704/)
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] potiuk closed pull request #6516: [AIRFLOW-5704] Improve Kind Kubernetes scripts for local testing

2020-01-08 Thread GitBox
potiuk closed pull request #6516: [AIRFLOW-5704] Improve Kind Kubernetes 
scripts for local testing
URL: https://github.com/apache/airflow/pull/6516
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6090: [AIRFLOW-5470] Add Apache Livy REST operator

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6090: [AIRFLOW-5470] Add Apache Livy REST 
operator
URL: https://github.com/apache/airflow/pull/6090#issuecomment-572009682
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=h1) 
Report
   > Merging 
[#6090](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/d1c7f3c293122498057ecf3e5d80ddc0b6a549e7?src=pr=desc)
 will **decrease** coverage by `0.02%`.
   > The diff coverage is `94.68%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6090/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6090  +/-   ##
   ==
   - Coverage   84.98%   84.96%   -0.03% 
   ==
 Files 682  686   +4 
 Lines   3899639145 +149 
   ==
   + Hits3314233259 +117 
   - Misses   5854 5886  +32
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `67.78% <0%> (-0.02%)` | :arrow_down: |
   | 
[airflow/contrib/sensors/livy\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbGl2eV9zZW5zb3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[...flow/contrib/example\_dags/example\_livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX2xpdnlfb3BlcmF0b3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/livy\_hook.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2xpdnlfaG9vay5weQ==)
 | `94.77% <94.77%> (ø)` | |
   | 
[airflow/contrib/operators/livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9saXZ5X29wZXJhdG9yLnB5)
 | `97.5% <97.5%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | ... and [17 
more](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=footer). 
Last update 
[d1c7f3c...8ecb59d](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (AIRFLOW-6517) make merge_dicts recursive

2020-01-08 Thread Daniel Standish (Jira)
Daniel Standish created AIRFLOW-6517:


 Summary: make merge_dicts recursive
 Key: AIRFLOW-6517
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6517
 Project: Apache Airflow
  Issue Type: Bug
  Components: utils
Affects Versions: 1.10.7
Reporter: Daniel Standish
Assignee: Daniel Standish






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] potiuk commented on issue #6516: [AIRFLOW-5704] Improve Kind Kubernetes scripts for local testing [WIP]

2020-01-08 Thread GitBox
potiuk commented on issue #6516: [AIRFLOW-5704] Improve Kind Kubernetes scripts 
for local testing [WIP]
URL: https://github.com/apache/airflow/pull/6516#issuecomment-572429694
 
 
   Hey @gerardo @dimberman @kaxil @ashb @mik-laj @nuclearpinguin 
   
   I think you all might be interested with this change to 
see/review/understand how kind implementation evolves and how Breeze will let 
people to work with Kubernetes Executor in development mode. Kind seems to be 
really nice for both CI and local development.
   
   I have finally implemented the "best" approach with Kind I think. One that 
is much faster and seems to work really well for both - CI (much faster than 
previous approach with separate docker container) - it also helps with local 
development with kind cluster . Now I am testing all the ins/outs of it but it 
seems that it is really nice for local development as well (with regards to 
resources/time pulling images/using latest sources etc.). Together with the 
follow-up change of separating integration and slimming down Breeze: #7091 - it 
becomes really useful for local development.
   
   Some of the notable properties:
   
   - I switched to the latest kind 6.1 (it does not require separate exporting 
of the ".kube folder - it is done automatically) 
   
   - I pass the docker socket from host to the container for 
"ENABLE_KIND_CLUSTER" build - this way I can use the same docker image that 
airflow-testing is run on - all the Kind containers are run in that docker 
image (and visible from the host via docker ps). This means a) no separate 
docker container is needed b) no need to pull image from apache/airflow - it's 
already there! I am checking if container is already created and skip creating 
it if so. You can also force cluster recreation by passing --recreate-kind 
cluster flag or stop 
   
   - this also means that if I exit the Breeze/airflow-testing container - the 
cluster is still running there and I do not recreate the cluster when I 
re-enter the container. 
   
   - However I still run "rebuild_airflow_image.sh" when entering the 
container. This way I am 100% sure I use latest sources (both locally and in 
CI). Plus I can later change the sources and run "rebuild_airflow_image.sh" 
without leaving the airflow-testing container! What's nice about it - it's 
rather fast as it only rebuilds latest layers. It allows to iterate 
semi-quickly while working on Kubernetes :). Still loading image to kind takes 
quite some time (6 minutes for me) so it is not perfect. I will improve it when 
I have prod image - it should be much faster to load rather than the CI one
   
   - last but not least - the .kube folder is mounted from the HOST 
(${AIRFLOW_SOURCES}/.kube) so you should be able to interact with the cluster 
from the host as well (You just need to update hostname to localhost). I might 
want to document it or maybe even automatically copy the configuration to 
include the configuration that will support kubectl/connecting to cluster-run 
webserver from the localhost directly. All ports are exposed already so it 
should be rather easy.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] potiuk merged pull request #7110: [AIRFLOW-XXXX] improve clarity of confirm message

2020-01-08 Thread GitBox
potiuk merged pull request #7110: [AIRFLOW-] improve clarity of confirm 
message
URL: https://github.com/apache/airflow/pull/7110
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] potiuk commented on issue #7110: [AIRFLOW-XXXX] improve clarity of confirm message

2020-01-08 Thread GitBox
potiuk commented on issue #7110: [AIRFLOW-] improve clarity of confirm 
message
URL: https://github.com/apache/airflow/pull/7110#issuecomment-572406849
 
 
   > Adding quotes _and_ question mark makes it clear that we are forcing "no" 
to _the question_ "should we rebuild ci?".
   
   :D


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] dstandish edited a comment on issue #6850: [AIRFLOW-6296] add odbc hooks OdbcHook and MsSqlOdbcHook

2020-01-08 Thread GitBox
dstandish edited a comment on issue #6850: [AIRFLOW-6296] add odbc hooks 
OdbcHook and MsSqlOdbcHook
URL: https://github.com/apache/airflow/pull/6850#issuecomment-572400053
 
 
   Alright... after further thought... i think it makes more sense to just call 
it odbc hook.  there is no point in having a separate `MsSqlOdbcHook` that is 
identical apart from the name.  
   
   Having two identical hooks would be confusing for users and makes it 
difficult to create clear and consistent documentation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] dstandish commented on issue #6850: [AIRFLOW-6296] add odbc hooks OdbcHook and MsSqlOdbcHook

2020-01-08 Thread GitBox
dstandish commented on issue #6850: [AIRFLOW-6296] add odbc hooks OdbcHook and 
MsSqlOdbcHook
URL: https://github.com/apache/airflow/pull/6850#issuecomment-572400053
 
 
   Alright... after further thought... it makes more sense to just call it odbc 
hook.  there is no point in having a separate `MsSqlOdbcHook` that is identical 
apart from the name.  
   
   Having two identical hooks would be confusing for users and makes it 
difficult to create clear and consistent documentation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] dstandish removed a comment on issue #6850: [AIRFLOW-6296] add odbc hooks OdbcHook and MsSqlOdbcHook

2020-01-08 Thread GitBox
dstandish removed a comment on issue #6850: [AIRFLOW-6296] add odbc hooks 
OdbcHook and MsSqlOdbcHook
URL: https://github.com/apache/airflow/pull/6850#issuecomment-572297821
 
 
   ok @vamega refactored create odbc hook and make mssqlodbchook a subclass


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (AIRFLOW-6516) Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount

2020-01-08 Thread Kaxil Naik (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kaxil Naik resolved AIRFLOW-6516.
-
Resolution: Fixed

> Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount
> -
>
> Key: AIRFLOW-6516
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6516
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.10.8
>Reporter: Kaxil Naik
>Assignee: Kaxil Naik
>Priority: Major
> Fix For: 1.10.8
>
>
> https://github.com/apache/airflow/commit/4748a518ced4ebd30caec2ac290c782ef023b0d7
>  introduced a bug because we were re-assigning the "airflow-config" key in 
> volume_mounts/
> Because of this airflow.cfg was not mounted and only airflow_local_settings 
> was mounted if the `airflow_local_settings_configmap` is also set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] kaxil merged pull request #7109: [AIRFLOW-6516] BugFix: airflow.cfg does not exist in Volume Mounts

2020-01-08 Thread GitBox
kaxil merged pull request #7109: [AIRFLOW-6516] BugFix: airflow.cfg does not 
exist in Volume Mounts
URL: https://github.com/apache/airflow/pull/7109
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (AIRFLOW-6516) Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount

2020-01-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011363#comment-17011363
 ] 

ASF subversion and git services commented on AIRFLOW-6516:
--

Commit a0a02dfcd89a147c1b3a63af992bb6acba2b6b9f in airflow's branch 
refs/heads/master from Kaxil Naik
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=a0a02df ]

[AIRFLOW-6516] BugFix: airflow.cfg does not exist in Volume Mounts (#7109)



> Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount
> -
>
> Key: AIRFLOW-6516
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6516
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.10.8
>Reporter: Kaxil Naik
>Assignee: Kaxil Naik
>Priority: Major
> Fix For: 1.10.8
>
>
> https://github.com/apache/airflow/commit/4748a518ced4ebd30caec2ac290c782ef023b0d7
>  introduced a bug because we were re-assigning the "airflow-config" key in 
> volume_mounts/
> Because of this airflow.cfg was not mounted and only airflow_local_settings 
> was mounted if the `airflow_local_settings_configmap` is also set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-6516) Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount

2020-01-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011361#comment-17011361
 ] 

ASF GitHub Bot commented on AIRFLOW-6516:
-

kaxil commented on pull request #7109: [AIRFLOW-6516] BugFix: airflow.cfg does 
not exist in Volume Mounts
URL: https://github.com/apache/airflow/pull/7109
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount
> -
>
> Key: AIRFLOW-6516
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6516
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.10.8
>Reporter: Kaxil Naik
>Assignee: Kaxil Naik
>Priority: Major
> Fix For: 1.10.8
>
>
> https://github.com/apache/airflow/commit/4748a518ced4ebd30caec2ac290c782ef023b0d7
>  introduced a bug because we were re-assigning the "airflow-config" key in 
> volume_mounts/
> Because of this airflow.cfg was not mounted and only airflow_local_settings 
> was mounted if the `airflow_local_settings_configmap` is also set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] dstandish opened a new pull request #7110: AIRFLOW-XXXX improve clarity of confirm message

2020-01-08 Thread GitBox
dstandish opened a new pull request #7110: AIRFLOW- improve clarity of 
confirm message
URL: https://github.com/apache/airflow/pull/7110
 
 
   Clarifies confirm messaging
   
   Before:
   ```
   Forcing response 'no' to rebuild CI.
   ```
   
   After
   ```
   Forcing response 'no' to 'rebuild CI?'
   ```
   
   Why?
   
   The sentence `Forcing response 'no' to rebuild CI` can mean "forcing 
response "no" _in order to_ rebuild CI -- i.e. we must rebuild CI, and to do 
so, we must force the answer no.
   
   Adding quotes _and_ question mark makes it clear that we are forcing "no" to 
_the question_ "should we rebuild ci?".
   
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io commented on issue #7109: [AIRFLOW-6516] BugFix: airflow.cfg does not exist in Volume Mounts

2020-01-08 Thread GitBox
codecov-io commented on issue #7109: [AIRFLOW-6516] BugFix: airflow.cfg does 
not exist in Volume Mounts
URL: https://github.com/apache/airflow/pull/7109#issuecomment-572361352
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7109?src=pr=h1) 
Report
   > Merging 
[#7109](https://codecov.io/gh/apache/airflow/pull/7109?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a6676c4711aef1301bf3e7084371211f2f1af31b?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7109/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7109?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #7109   +/-   ##
   ==
 Coverage85.2%   85.2%   
   ==
 Files 682 682   
 Lines   38996   38996   
   ==
 Hits33228   33228   
 Misses   57685768
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7109?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/kubernetes/worker\_configuration.py](https://codecov.io/gh/apache/airflow/pull/7109/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3dvcmtlcl9jb25maWd1cmF0aW9uLnB5)
 | `99.29% <100%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7109?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7109?src=pr=footer). 
Last update 
[a6676c4...036685d](https://codecov.io/gh/apache/airflow/pull/7109?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #7109: [AIRFLOW-6516] BugFix: airflow.cfg does not exist in Volume Mounts

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #7109: [AIRFLOW-6516] BugFix: airflow.cfg 
does not exist in Volume Mounts
URL: https://github.com/apache/airflow/pull/7109#issuecomment-572361352
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7109?src=pr=h1) 
Report
   > Merging 
[#7109](https://codecov.io/gh/apache/airflow/pull/7109?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a6676c4711aef1301bf3e7084371211f2f1af31b?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7109/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7109?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #7109   +/-   ##
   ==
 Coverage85.2%   85.2%   
   ==
 Files 682 682   
 Lines   38996   38996   
   ==
 Hits33228   33228   
 Misses   57685768
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7109?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/kubernetes/worker\_configuration.py](https://codecov.io/gh/apache/airflow/pull/7109/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3dvcmtlcl9jb25maWd1cmF0aW9uLnB5)
 | `99.29% <100%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7109?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7109?src=pr=footer). 
Last update 
[a6676c4...036685d](https://codecov.io/gh/apache/airflow/pull/7109?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (AIRFLOW-6505) Let emoji encoded properly for json.dumps() -- BaseSQLToGoogleCloudStorageOperator

2020-01-08 Thread Damon Liao (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Damon Liao updated AIRFLOW-6505:

Description: 
Emoji can't be encoded properly when ` json.dumps()` and 'UTF-8', problem fixed 
by adding parameter `ensure_ascii=False`. 

 I've created a [PR|[https://github.com/damon09273/airflow/pull/1]] to fix this 
problem.

In [line|#L175]] BaseSQLToGoogleCloudStorageOperato.

 

For example

the emoji  encoded differentially when in use or not use  `ensure_ascii=False`.

In Use (correct UTF-8 encode): "\xf0\x9f\x8d\xbb"

Not Use (only 2 slash):"\\\ud83c\\\udf7b"

 

Ref: 
[https://stackoverflow.com/questions/51183947/python-json-dumps-doesnt-encode-emojis-properly]

  was:
Emoji can't be encoded properly when ` json.dumps()` and 'UTF-8', problem fixed 
by adding parameter `ensure_ascii=False`. 

 

In [line|#L175]] BaseSQLToGoogleCloudStorageOperato.

 

For example

the emoji  encoded differentially when in use or not use  `ensure_ascii=False`.

In Use (correct UTF-8 encode): "\xf0\x9f\x8d\xbb"

Not Use (only 2 slash):"\\\ud83c\\\udf7b"

 

Ref: 
[https://stackoverflow.com/questions/51183947/python-json-dumps-doesnt-encode-emojis-properly]


> Let emoji encoded properly for json.dumps() -- 
> BaseSQLToGoogleCloudStorageOperator
> --
>
> Key: AIRFLOW-6505
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6505
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: contrib
>Affects Versions: 1.10.8
> Environment: 1.10.7
>Reporter: Damon Liao
>Assignee: Damon Liao
>Priority: Blocker
> Fix For: 1.10.7
>
>
> Emoji can't be encoded properly when ` json.dumps()` and 'UTF-8', problem 
> fixed by adding parameter `ensure_ascii=False`. 
>  I've created a [PR|[https://github.com/damon09273/airflow/pull/1]] to fix 
> this problem.
> In [line|#L175]] BaseSQLToGoogleCloudStorageOperato.
>  
> For example
> the emoji  encoded differentially when in use or not use  
> `ensure_ascii=False`.
> In Use (correct UTF-8 encode): "\xf0\x9f\x8d\xbb"
> Not Use (only 2 slash):"\\\ud83c\\\udf7b"
>  
> Ref: 
> [https://stackoverflow.com/questions/51183947/python-json-dumps-doesnt-encode-emojis-properly]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] dimberman commented on issue #7109: [AIRFLOW-6516] BugFix: airflow.cfg does not exist in Volume Mounts

2020-01-08 Thread GitBox
dimberman commented on issue #7109: [AIRFLOW-6516] BugFix: airflow.cfg does not 
exist in Volume Mounts
URL: https://github.com/apache/airflow/pull/7109#issuecomment-572343368
 
 
   ohhh ok so you were overwriting `airflow-config` before. Got it. LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (AIRFLOW-6516) Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount

2020-01-08 Thread Kaxil Naik (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kaxil Naik updated AIRFLOW-6516:

Affects Version/s: (was: 2.0.0)
   1.10.8

> Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount
> -
>
> Key: AIRFLOW-6516
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6516
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.10.8
>Reporter: Kaxil Naik
>Assignee: Kaxil Naik
>Priority: Major
> Fix For: 1.10.8
>
>
> https://github.com/apache/airflow/commit/4748a518ced4ebd30caec2ac290c782ef023b0d7
>  introduced a bug because we were re-assigning the "airflow-config" key in 
> volume_mounts/
> Because of this airflow.cfg was not mounted and only airflow_local_settings 
> was mounted if the `airflow_local_settings_configmap` is also set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (AIRFLOW-6516) Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount

2020-01-08 Thread Kaxil Naik (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kaxil Naik updated AIRFLOW-6516:

Fix Version/s: 1.10.8

> Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount
> -
>
> Key: AIRFLOW-6516
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6516
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: core
>Affects Versions: 2.0.0
>Reporter: Kaxil Naik
>Assignee: Kaxil Naik
>Priority: Major
> Fix For: 1.10.8
>
>
> https://github.com/apache/airflow/commit/4748a518ced4ebd30caec2ac290c782ef023b0d7
>  introduced a bug because we were re-assigning the "airflow-config" key in 
> volume_mounts/
> Because of this airflow.cfg was not mounted and only airflow_local_settings 
> was mounted if the `airflow_local_settings_configmap` is also set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-6516) Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount

2020-01-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011292#comment-17011292
 ] 

ASF GitHub Bot commented on AIRFLOW-6516:
-

kaxil commented on pull request #7109: [AIRFLOW-6516] BugFix: airflow.cfg does 
not exist in Volume Mounts
URL: https://github.com/apache/airflow/pull/7109
 
 
   
https://github.com/apache/airflow/commit/4748a518ced4ebd30caec2ac290c782ef023b0d7
 introduced a bug because we were re-assigning the "airflow-config" key in 
volume_mounts/
   
   Because of this `airflow.cfg` was not mounted and only 
`airflow_local_settings.py` was mounted if the 
`airflow_local_settings_configmap` is also set.
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount
> -
>
> Key: AIRFLOW-6516
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6516
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: core
>Affects Versions: 2.0.0
>Reporter: Kaxil Naik
>Assignee: Kaxil Naik
>Priority: Major
>
> https://github.com/apache/airflow/commit/4748a518ced4ebd30caec2ac290c782ef023b0d7
>  introduced a bug because we were re-assigning the "airflow-config" key in 
> volume_mounts/
> Because of this airflow.cfg was not mounted and only airflow_local_settings 
> was mounted if the `airflow_local_settings_configmap` is also set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] kaxil opened a new pull request #7109: [AIRFLOW-6516] BugFix: airflow.cfg does not exist in Volume Mounts

2020-01-08 Thread GitBox
kaxil opened a new pull request #7109: [AIRFLOW-6516] BugFix: airflow.cfg does 
not exist in Volume Mounts
URL: https://github.com/apache/airflow/pull/7109
 
 
   
https://github.com/apache/airflow/commit/4748a518ced4ebd30caec2ac290c782ef023b0d7
 introduced a bug because we were re-assigning the "airflow-config" key in 
volume_mounts/
   
   Because of this `airflow.cfg` was not mounted and only 
`airflow_local_settings.py` was mounted if the 
`airflow_local_settings_configmap` is also set.
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (AIRFLOW-6516) Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount

2020-01-08 Thread Kaxil Naik (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kaxil Naik updated AIRFLOW-6516:

Description: 
https://github.com/apache/airflow/commit/4748a518ced4ebd30caec2ac290c782ef023b0d7
 introduced a bug because we were re-assigning the "airflow-config" key in 
volume_mounts/

Because of this airflow.cfg was not mounted and only airflow_local_settings was 
mounted if the `airflow_local_settings_configmap` is also set.

  was:
https://github.com/apache/airflow/commit/4748a518ced4ebd30caec2ac290c782ef023b0d7
 introduced a bug because we were re-assigning the "airflow-config" key in 
volume_mounts/

Because of this airflow.cfg was not mounted and only airflow_local_settings was 
mounted.


> Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount
> -
>
> Key: AIRFLOW-6516
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6516
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: core
>Affects Versions: 2.0.0
>Reporter: Kaxil Naik
>Assignee: Kaxil Naik
>Priority: Major
>
> https://github.com/apache/airflow/commit/4748a518ced4ebd30caec2ac290c782ef023b0d7
>  introduced a bug because we were re-assigning the "airflow-config" key in 
> volume_mounts/
> Because of this airflow.cfg was not mounted and only airflow_local_settings 
> was mounted if the `airflow_local_settings_configmap` is also set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add 
filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#issuecomment-552128422
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=h1) 
Report
   > Merging 
[#6489](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/2b374721f8b21eb3f0ba55a77a9f2b1895914f48?src=pr=desc)
 will **increase** coverage by `0.26%`.
   > The diff coverage is `96.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6489/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6489  +/-   ##
   =
   + Coverage   84.93%   85.2%   +0.26% 
   =
 Files 680 682   +2 
 Lines   38826   38984 +158 
   =
   + Hits32978   33217 +239 
   + Misses   58485767  -81
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_pig\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9waWdfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_python\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9weXRob25fb3BlcmF0b3IucHk=)
 | `63.33% <ø> (ø)` | :arrow_up: |
   | 
[...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5)
 | `75% <ø> (ø)` | :arrow_up: |
   | 
[...le\_dags/example\_passing\_params\_via\_test\_command.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9wYXNzaW5nX3BhcmFtc192aWFfdGVzdF9jb21tYW5kLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_gcs\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9nY3NfdG9fZ2NzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=)
 | `90% <ø> (ø)` | :arrow_up: |
   | 
[...low/example\_dags/example\_trigger\_controller\_dag.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX2NvbnRyb2xsZXJfZGFnLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_bash\_operator.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9iYXNoX29wZXJhdG9yLnB5)
 | `94.44% <ø> (ø)` | :arrow_up: |
   | 
[...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=)
 | `100% <ø> (ø)` | :arrow_up: |
   | ... and [25 
more](https://codecov.io/gh/apache/airflow/pull/6489/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=footer). 
Last update 
[2b37472...7898cbb](https://codecov.io/gh/apache/airflow/pull/6489?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (AIRFLOW-6516) Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount

2020-01-08 Thread Kaxil Naik (Jira)
Kaxil Naik created AIRFLOW-6516:
---

 Summary: Airflow Local Setting ConfigMap overrides airflow.cfg 
VolumeMount
 Key: AIRFLOW-6516
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6516
 Project: Apache Airflow
  Issue Type: Bug
  Components: core
Affects Versions: 2.0.0
Reporter: Kaxil Naik
Assignee: Kaxil Naik


https://github.com/apache/airflow/commit/4748a518ced4ebd30caec2ac290c782ef023b0d7
 introduced a bug because we were re-assigning the "airflow-config" key in 
volume_mounts/

Because of this airflow.cfg was not mounted and only airflow_local_settings was 
mounted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] tooptoop4 commented on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
tooptoop4 commented on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-572327119
 
 
   @mik-laj  pls merge


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > Merging 
[#6993](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.23%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6993  +/-   ##
   ==
   - Coverage   85.15%   84.92%   -0.24% 
   ==
 Files 680  682   +2 
 Lines   3882439007 +183 
   ==
   + Hits3306133127  +66 
   - Misses   5763 5880 +117
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `94.04% <ø> (ø)` | :arrow_up: |
   | 
[airflow/cli/commands/task\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvdGFza19jb21tYW5kLnB5)
 | `72.28% <50%> (+0.47%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/providers/amazon/aws/operators/batch.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvYmF0Y2gucHk=)
 | `93.75% <0%> (-2.09%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.59% <0%> (-0.29%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/gcp\_spanner\_hook.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9zcGFubmVyX2hvb2sucHk=)
 | `100% <0%> (ø)` | :arrow_up: |
   | ... and [8 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[fe20ef6...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > Merging 
[#6993](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.23%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6993  +/-   ##
   ==
   - Coverage   85.15%   84.92%   -0.24% 
   ==
 Files 680  682   +2 
 Lines   3882439007 +183 
   ==
   + Hits3306133127  +66 
   - Misses   5763 5880 +117
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `94.04% <ø> (ø)` | :arrow_up: |
   | 
[airflow/cli/commands/task\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvdGFza19jb21tYW5kLnB5)
 | `72.28% <50%> (+0.47%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/providers/amazon/aws/operators/batch.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvYmF0Y2gucHk=)
 | `93.75% <0%> (-2.09%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.59% <0%> (-0.29%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/gcp\_spanner\_hook.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9zcGFubmVyX2hvb2sucHk=)
 | `100% <0%> (ø)` | :arrow_up: |
   | ... and [8 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[fe20ef6...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > Merging 
[#6993](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.23%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6993  +/-   ##
   ==
   - Coverage   85.15%   84.92%   -0.24% 
   ==
 Files 680  682   +2 
 Lines   3882439007 +183 
   ==
   + Hits3306133127  +66 
   - Misses   5763 5880 +117
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `94.04% <ø> (ø)` | :arrow_up: |
   | 
[airflow/cli/commands/task\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvdGFza19jb21tYW5kLnB5)
 | `72.28% <50%> (+0.47%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/providers/amazon/aws/operators/batch.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvYmF0Y2gucHk=)
 | `93.75% <0%> (-2.09%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.59% <0%> (-0.29%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/gcp\_spanner\_hook.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9zcGFubmVyX2hvb2sucHk=)
 | `100% <0%> (ø)` | :arrow_up: |
   | ... and [8 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[fe20ef6...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > Merging 
[#6993](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.23%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6993  +/-   ##
   ==
   - Coverage   85.15%   84.92%   -0.24% 
   ==
 Files 680  682   +2 
 Lines   3882439007 +183 
   ==
   + Hits3306133127  +66 
   - Misses   5763 5880 +117
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `94.04% <ø> (ø)` | :arrow_up: |
   | 
[airflow/cli/commands/task\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvdGFza19jb21tYW5kLnB5)
 | `72.28% <50%> (+0.47%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/providers/amazon/aws/operators/batch.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvYmF0Y2gucHk=)
 | `93.75% <0%> (-2.09%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.59% <0%> (-0.29%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/gcp\_spanner\_hook.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9zcGFubmVyX2hvb2sucHk=)
 | `100% <0%> (ø)` | :arrow_up: |
   | ... and [8 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[fe20ef6...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > Merging 
[#6993](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.23%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6993  +/-   ##
   ==
   - Coverage   85.15%   84.92%   -0.24% 
   ==
 Files 680  682   +2 
 Lines   3882439007 +183 
   ==
   + Hits3306133127  +66 
   - Misses   5763 5880 +117
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5)
 | `94.04% <ø> (ø)` | :arrow_up: |
   | 
[airflow/cli/commands/task\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvdGFza19jb21tYW5kLnB5)
 | `72.28% <50%> (+0.47%)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | 
[...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==)
 | `78.75% <0%> (-20%)` | :arrow_down: |
   | 
[airflow/providers/amazon/aws/operators/batch.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvYmF0Y2gucHk=)
 | `93.75% <0%> (-2.09%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `91.59% <0%> (-0.29%)` | :arrow_down: |
   | 
[airflow/contrib/hooks/gcp\_spanner\_hook.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9zcGFubmVyX2hvb2sucHk=)
 | `100% <0%> (ø)` | :arrow_up: |
   | ... and [8 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[fe20ef6...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - task_states_for_dag_run

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6993: [AIRFLOW-4502] new cli command - 
task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#issuecomment-570075234
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@846af90`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `83.57%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6993/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#6993   +/-   ##
   =
 Coverage  ?   84.92%   
   =
 Files ?  682   
 Lines ?39007   
 Branches  ?0   
   =
 Hits  ?33127   
 Misses? 5880   
 Partials  ?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5)
 | `99.07% <ø> (ø)` | |
   | 
[airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=)
 | `89.28% <ø> (ø)` | |
   | 
[.../contrib/operators/gcs\_to\_gcs\_transfer\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfdG9fZ2NzX3RyYW5zZmVyX29wZXJhdG9yLnB5)
 | `0% <ø> (ø)` | |
   | 
[airflow/utils/weight\_rule.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy93ZWlnaHRfcnVsZS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | |
   | 
[airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5)
 | `85.96% <ø> (ø)` | |
   | 
[airflow/example\_dags/example\_docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kb2NrZXJfb3BlcmF0b3IucHk=)
 | `100% <ø> (ø)` | |
   | 
[airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==)
 | `97.43% <ø> (ø)` | |
   | 
[airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5)
 | `80.55% <ø> (ø)` | |
   | 
[airflow/sensors/base\_sensor\_operator.py](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2Jhc2Vfc2Vuc29yX29wZXJhdG9yLnB5)
 | `98.61% <ø> (ø)` | |
   | ... and [147 
more](https://codecov.io/gh/apache/airflow/pull/6993/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=footer). 
Last update 
[846af90...b20e3ce](https://codecov.io/gh/apache/airflow/pull/6993?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (AIRFLOW-6515) log level of INFO/WARN when ERROR happened

2020-01-08 Thread t oo (Jira)
t oo created AIRFLOW-6515:
-

 Summary: log level of INFO/WARN when ERROR happened
 Key: AIRFLOW-6515
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6515
 Project: Apache Airflow
  Issue Type: Bug
  Components: logging
Affects Versions: 1.10.7
Reporter: t oo


log level should be error on some (but there are false positives):

grep -iE 'log\.(info|warn).*(error|exceptio|fail|unab)' -R *
airflow/logging_config.py:log.warning('Unable to load the config, 
contains a configuration error.')
airflow/operators/check_operator.py:self.log.warning("The following 
%s tests out of %s failed:", j, n)
airflow/serialization/serialized_objects.py:LOG.warning('Failed to 
stringify.', exc_info=True)
airflow/providers/amazon/aws/operators/batch.py:self.log.info("AWS 
Batch Job has failed")
airflow/providers/amazon/aws/hooks/s3.py:
self.log.info(e.response["Error"]["Message"])
airflow/providers/amazon/aws/hooks/s3.py:
self.log.info(e.response["Error"]["Message"])
airflow/utils/dag_processing.py:self.log.info("Failing jobs without 
heartbeat after %s", limit_dttm)
airflow/models/dagrun.py:self.log.info('Marking run %s failed', 
self)
airflow/models/dagrun.py:self.log.info('Deadlock; marking run %s 
failed', self)
airflow/models/dagrun.py:self.log.warning("Failed to get 
task '{}' for dag '{}'. "
airflow/gcp/sensors/gcs.py:self.log.warning("FAILURE: Inactivity 
Period passed, not enough objects found in %s", path)
airflow/gcp/hooks/kubernetes_engine.py:self.log.info('Assuming 
Success: %s', error.message)
airflow/gcp/hooks/kubernetes_engine.py:self.log.info('Assuming 
Success: %s', error.message)
airflow/gcp/hooks/cloud_memorystore.py:self.log.info("Failovering 
Instance: %s", name)
airflow/gcp/hooks/cloud_memorystore.py:self.log.info("Instance 
failovered: %s", name)
airflow/gcp/hooks/bigquery.py:self.log.info(error_msg)
airflow/contrib/sensors/ftp_sensor.py:self.log.info('Ftp error 
encountered: %s', str(e))
airflow/contrib/operators/azure_container_instances_operator.py:
self.log.info("Azure provision failure")
airflow/contrib/auth/backends/ldap_auth.py:log.warning("Unable to find 
group for %s %s", search_base, search_filter)
airflow/contrib/auth/backends/ldap_auth.py:log.warning("Parsing error 
when retrieving the user's group(s)."
airflow/contrib/utils/sendgrid.py:log.warning('Failed to send out email 
with subject %s, status code: %s',
airflow/contrib/hooks/spark_submit_hook.py:
self.log.info("Exception when attempting to kill Spark on K8s:")
grep: airflow/www/static/docs: No such file or directory
airflow/www/api/experimental/endpoints.py:_log.info(error_message)
airflow/www/api/experimental/endpoints.py:_log.info(error_message)
airflow/www/api/experimental/endpoints.py:_log.info(error_message)
airflow/executors/kubernetes_executor.py:self.log.info('Event: %s 
Failed', pod_id)
airflow/executors/kubernetes_executor.py:
self.log.warning('ApiException when attempting to run task, re-queueing. '
airflow/executors/debug_executor.py:self.log.info("Setting %s 
to %s", ti.key, State.UPSTREAM_FAILED)
airflow/executors/debug_executor.py:self.log.info("Setting %s to 
%s", ti.key, State.UPSTREAM_FAILED)
airflow/task/task_runner/cgroup_task_runner.py:
self.log.warning("Task failed with return code of 137. This may indicate "
airflow/kubernetes/pod_launcher.py:self.log.info('Event with job id 
%s Failed', job_id)
grep: logs/scheduler/latest: No such file or directory
tests/gcp/operators/test_cloud_sql_system_helper.py:
self.log.info("Error while creating dir.")
tests/gcp/utils/gcp_authenticator.py:self.log.info('Airflow DB 
Session error:' + str(ex))
tests/gcp/utils/gcp_authenticator.py:self.log.info('Airflow DB 
Session error:' + str(ex))
tests/contrib/utils/logging_command_executor.py:
self.log.warning("Error when executing %s", " ".join(cmd))
tests/contrib/utils/logging_command_executor.py:
self.log.info("Error when executing '{}'".format(" ".join(cmd)))
Minjeongs-Air:MYAIRFLOWFORK root# grep -iE 
'log\.(info|warn).*(error|exceptio|fail|unab|couldn|lost|gone|missing|not 
fou|abort|exit|could not)' -R *
airflow/sensors/base_sensor_operator.py:self.log.info("Success criteria 
met. Exiting.")
airflow/logging_config.py:log.warning('Unable to load the config, 
contains a configuration error.')
airflow/operators/check_operator.py:self.log.warning("The following 
%s tests out of %s failed:", j, n)
airflow/operators/sql_to_gcs.py:

[jira] [Updated] (AIRFLOW-6515) log level of INFO/WARN when ERROR happened

2020-01-08 Thread t oo (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

t oo updated AIRFLOW-6515:
--
Description: 
log level should be error on some (but there are false positives):

grep -iE 
'log\.(info|warn).*(error|exceptio|fail|unab|couldn|lost|gone|missing|not 
fou|abort|exit|could not)' -R *
airflow/sensors/base_sensor_operator.py:self.log.info("Success criteria 
met. Exiting.")
airflow/logging_config.py:log.warning('Unable to load the config, 
contains a configuration error.')
airflow/operators/check_operator.py:self.log.warning("The following 
%s tests out of %s failed:", j, n)
airflow/operators/sql_to_gcs.py:self.log.warning('Using default 
schema due to missing name or type. Please '
airflow/operators/bash_operator.py:self.log.info('Command exited 
with return code %s', self.sub_process.returncode)
airflow/serialization/serialized_objects.py:LOG.warning('Failed to 
stringify.', exc_info=True)
airflow/providers/amazon/aws/operators/batch.py:self.log.info("AWS 
Batch Job has failed")
airflow/providers/amazon/aws/hooks/s3.py:
self.log.info(e.response["Error"]["Message"])
airflow/providers/amazon/aws/hooks/s3.py:
self.log.info(e.response["Error"]["Message"])
airflow/utils/dag_processing.py:self.log.info("Exiting gracefully upon 
receiving signal %s", signum)
airflow/utils/dag_processing.py:self.log.info("Exiting dag 
parsing loop as all files "
airflow/utils/dag_processing.py:self.log.info("Failing jobs without 
heartbeat after %s", limit_dttm)
airflow/utils/dag_processing.py:self.log.info("Waiting up to %s 
seconds for processes to exit...", timeout)
airflow/utils/helpers.py:log.info("Process %s (%s) terminated with exit 
code %s", p, p.pid, p.returncode)
airflow/models/dagrun.py:self.log.info('Marking run %s failed', 
self)
airflow/models/dagrun.py:self.log.info('Deadlock; marking run %s 
failed', self)
airflow/models/dagrun.py:self.log.warning("Failed to get 
task '{}' for dag '{}'. "
airflow/gcp/sensors/gcs.py:self.log.warning("FAILURE: Inactivity 
Period passed, not enough objects found in %s", path)
airflow/gcp/operators/spanner.py:self.log.info("The Cloud Spanner 
database was missing: "
airflow/gcp/hooks/kubernetes_engine.py:self.log.info('Assuming 
Success: %s', error.message)
airflow/gcp/hooks/kubernetes_engine.py:self.log.info('Assuming 
Success: %s', error.message)
airflow/gcp/hooks/cloud_memorystore.py:self.log.info("Failovering 
Instance: %s", name)
airflow/gcp/hooks/cloud_memorystore.py:self.log.info("Instance 
failovered: %s", name)
airflow/gcp/hooks/bigquery.py:self.log.info(error_msg)
airflow/gcp/hooks/bigtable.py:self.log.info("The instance '%s' does 
not exist in project '%s'. Exiting", instance_id,
airflow/contrib/sensors/bash_sensor.py:self.log.info("Command 
exited with return code %s", sp.returncode)
airflow/contrib/sensors/ftp_sensor.py:self.log.info('Ftp error 
encountered: %s', str(e))
airflow/contrib/operators/azure_container_instances_operator.py:
self.log.info("Container had exit code: %s", exit_code)
airflow/contrib/operators/azure_container_instances_operator.py:
self.log.info("Container exited with detail_status %s", detail_status)
airflow/contrib/operators/azure_container_instances_operator.py:
self.log.info("Azure provision failure")
airflow/contrib/operators/winrm_operator.py:self.log.info("Hook not 
found, creating...")
airflow/contrib/operators/docker_swarm_operator.py:
self.log.info('Service status before exiting: %s', status)
airflow/contrib/auth/backends/ldap_auth.py:log.warning("Unable to find 
group for %s %s", search_base, search_filter)
airflow/contrib/auth/backends/ldap_auth.py:log.warning("""Missing 
attribute "%s" when looked-up in Ldap database.
airflow/contrib/auth/backends/ldap_auth.py:log.warning("Parsing error 
when retrieving the user's group(s)."
airflow/contrib/utils/sendgrid.py:log.warning('Failed to send out email 
with subject %s, status code: %s',
airflow/contrib/example_dags/example_kubernetes_operator.py:
log.warning("Could not import KubernetesPodOperator: " + str(e))
airflow/contrib/hooks/gdrive_hook.py:self.log.info("Not found 
%s directory", current_folder)
airflow/contrib/hooks/sqoop_hook.py:self.log.info("Command exited with 
return code %s", self.sp.returncode)
airflow/contrib/hooks/salesforce_hook.py:log.warning("Could not 
convert field to timestamps: %s", column.name)
airflow/contrib/hooks/qubole_check_hook.py:log.info("Qubole command 
not found")

[GitHub] [airflow] sarutak commented on a change in pull request #7099: [AIRFLOW-6507] Replace the use of imp.load_source with another solution.

2020-01-08 Thread GitBox
sarutak commented on a change in pull request #7099: [AIRFLOW-6507] Replace the 
use of imp.load_source with another solution.
URL: https://github.com/apache/airflow/pull/7099#discussion_r364497578
 
 

 ##
 File path: airflow/models/dagbag.py
 ##
 @@ -248,7 +247,11 @@ def process_file(self, filepath, only_if_updated=True, 
safe_mode=True):
 
 with timeout(self.DAGBAG_IMPORT_TIMEOUT):
 try:
-m = imp.load_source(mod_name, filepath)
+loader = importlib.machinery.SourceFileLoader(mod_name, 
filepath)
+spec = importlib.util.spec_from_loader(mod_name, loader)
+m = importlib.util.module_from_spec(spec)
+sys.modules[spec.name] = m
 
 Review comment:
   It's the second approach.
   
https://github.com/apache/airflow/pull/7099/commits/68c539fdcd74b900bcc60f441ac5ceb3b4f1b63d
   That approach successfully finish some test-cases that the first one fails.
   But still fails a test-case.
   
`test_backfill_job.py::TestBackfillJob::test_backfill_examples_2_example_skip_dag`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil commented on a change in pull request #7099: [AIRFLOW-6507] Replace the use of imp.load_source with another solution.

2020-01-08 Thread GitBox
kaxil commented on a change in pull request #7099: [AIRFLOW-6507] Replace the 
use of imp.load_source with another solution.
URL: https://github.com/apache/airflow/pull/7099#discussion_r364488560
 
 

 ##
 File path: airflow/models/dagbag.py
 ##
 @@ -248,7 +247,11 @@ def process_file(self, filepath, only_if_updated=True, 
safe_mode=True):
 
 with timeout(self.DAGBAG_IMPORT_TIMEOUT):
 try:
-m = imp.load_source(mod_name, filepath)
+loader = importlib.machinery.SourceFileLoader(mod_name, 
filepath)
+spec = importlib.util.spec_from_loader(mod_name, loader)
+m = importlib.util.module_from_spec(spec)
+sys.modules[spec.name] = m
 
 Review comment:
   Ok but you should not need "sys.modules[spec.name] = m"


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] sarutak commented on a change in pull request #7099: [AIRFLOW-6507] Replace the use of imp.load_source with another solution.

2020-01-08 Thread GitBox
sarutak commented on a change in pull request #7099: [AIRFLOW-6507] Replace the 
use of imp.load_source with another solution.
URL: https://github.com/apache/airflow/pull/7099#discussion_r364487841
 
 

 ##
 File path: airflow/models/dagbag.py
 ##
 @@ -248,7 +247,11 @@ def process_file(self, filepath, only_if_updated=True, 
safe_mode=True):
 
 with timeout(self.DAGBAG_IMPORT_TIMEOUT):
 try:
-m = imp.load_source(mod_name, filepath)
+loader = importlib.machinery.SourceFileLoader(mod_name, 
filepath)
+spec = importlib.util.spec_from_loader(mod_name, loader)
+m = importlib.util.module_from_spec(spec)
+sys.modules[spec.name] = m
 
 Review comment:
   Thanks for you comment.
   What you suggested is actually my first approach.
   
https://github.com/apache/airflow/pull/7099/commits/7fd424457a10e161e819bf376b601716e481f194
   
   But it doesn't pass tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (AIRFLOW-3964) Consolidate and de-duplicate sensor tasks

2020-01-08 Thread Yingbo Wang (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yingbo Wang updated AIRFLOW-3964:
-
Summary: Consolidate and de-duplicate sensor tasks   (was: Consolidate and 
de-duplicate sensor tasks in newly created Operator)

> Consolidate and de-duplicate sensor tasks 
> --
>
> Key: AIRFLOW-3964
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3964
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: dependencies, operators, scheduler
>Affects Versions: 1.10.0
>Reporter: Yingbo Wang
>Assignee: Yingbo Wang
>Priority: Critical
>
> h2. Problem
> h3. Airflow Sensor:
> Sensors are a certain type of operator that will keep running until a certain 
> criterion is met. Examples include a specific file landing in HDFS or S3, a 
> partition appearing in Hive, or a specific time of the day. Sensors are 
> derived from BaseSensorOperator and run a poke method at a specified 
> poke_interval until it returns True.
> Airflow Sensor duplication is a normal problem for large scale airflow 
> project. There are duplicated partitions needing to be detected from 
> same/different DAG. In Airbnb there are 88 boxes running four different types 
> of sensors everyday. The number of running sensor tasks ranges from 8k to 
> 16k, which takes great amount of resources. Although Airflow team had 
> redirected all sensors to a specific queue to allocate relatively minor 
> resource, there is still large room to reduce the number of workers and 
> relief DB pressure by optimizing the sensor mechanism.
> Existing sensor implementation creates an identical task for any sensor task 
> with specific dag_id, task_id and execution_date. This task is responsible of 
> keeping querying DB until the specified partitions exists. Even if two tasks 
> are waiting for same partition in DB, they are creating two connections with 
> the DB and checking the status in two separate processes. In one hand, DB 
> need to run duplicate jobs in multiple processes which will take both cpu and 
> memory resources. At the same time, Airflow need to maintain a process for 
> each sensor to query and wait for the partition/table to be created.
> h1. ***Design*
> There are several issues need to be resolved for our smart sensor. 
> h2. Persist sensor infor in DB and avoid file parsing before running
> Current Airflow implementation need to parse the DAG python file before 
> running a task. Parsing multiple python file in a smart sensor make the case 
> low efficiency and overload. Since sensor tasks need relatively more “light 
> weight” executing information -- less number of properties with simple 
> structure (most are built in type instead of function or object). We propose 
> to skip the parsing for smart sensor. The easiest way is to persist all task 
> instance information in airflow metaDB. 
> h3. Solution:
> It will be hard to dump the whole task instance object dictionary. And we do 
> not really need that much information. 
> We add two sets to the base sensor class as “persist_fields” and 
> “execute_fields”. 
> h4. “persist_fields”  dump to airflow.task_instance column “attr_dict”
> saves the attribute names that should be used to accomplish a sensor poking 
> job. For example:
>  #  the “NamedHivePartitionSensor” define its persist_fields as  
> ('partition_names', 'metastore_conn_id', 'hook') since these properties are 
> enough for its poking function. 
>  # While the HivePartitionSensor can be slightly different use persist_fields 
> as ('schema', 'table', 'partition', 'metastore_conn_id')
> If we have two tasks that have same property value for all field in 
> persist_fields. That means these two tasks are poking the same item and they 
> are holding duplicate poking jobs in senser. 
> *The persist_fields can help us in deduplicate sensor tasks*. In a more 
> broader way. If we can list persist_fields for all operators, it can help to 
> dedup all airflow tasks.
> h4. “Execute_fields” dump to airflow.task_instance column “exec_dict”
> Saves the execution configuration such as “poke_interval”, “timeout”, 
> “execution_timeout”
> Fields in this set do not contain information affecting the poking job 
> detail. They are related to how frequent should we poke, when should the task 
> timeout, how many times timeout should be a fail etc. We only put those logic 
> that we can easily handle in a smart sensor for now. This is a smart sensor 
> “doable whitelist” and can be extended with more logic being “unlocked” by 
> smart sensor implementation. 
>  When we initialize a task instance object. We dump the attribute value of 
> these two sets and persist them in the Airflow metaDB. Smart sensor can visit 
> DB to get all required information of running sensor tasks and don’t need to 
> 

[GitHub] [airflow] dstandish commented on issue #6850: [AIRFLOW-6296] add odbc hooks OdbcHook and MsSqlOdbcHook

2020-01-08 Thread GitBox
dstandish commented on issue #6850: [AIRFLOW-6296] add odbc hooks OdbcHook and 
MsSqlOdbcHook
URL: https://github.com/apache/airflow/pull/6850#issuecomment-572297821
 
 
   ok @vamega refactored create odbc hook and make mssqlodbchook a subclass


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

2020-01-08 Thread GitBox
kaxil commented on a change in pull request #6489: [AIRFLOW-3959] 
[AIRFLOW-4026] Add filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#discussion_r364468582
 
 

 ##
 File path: airflow/www/app.py
 ##
 @@ -60,6 +61,11 @@ def create_app(config=None, session=None, testing=False, 
app_name="Airflow"):
 )
 app.secret_key = conf.get('webserver', 'SECRET_KEY')
 
+session_lifetime_days = 30
+if conf.has_option('webserver', 'SESSION_LIFETIME_DAYS'):
+session_lifetime_days = conf.getint('webserver', 
'SESSION_LIFETIME_DAYS')
 
 Review comment:
   We should also add this config to 
https://github.com/apache/airflow/blob/master/airflow/config_templates/config.yml
 and 
https://github.com/apache/airflow/blob/master/airflow/config_templates/default_airflow.cfg
 (If you are using pre-commit hooks `default_airflow.cfg` would be 
auto-generated for you from `config.yml` when you try to commit


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] tooptoop4 commented on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove excess sleep/log/duration calls

2020-01-08 Thread GitBox
tooptoop4 commented on issue #7089: [AIRFLOW-6452] scheduler_job.py - remove 
excess sleep/log/duration calls
URL: https://github.com/apache/airflow/pull/7089#issuecomment-572280616
 
 
   @nuclearpinguin pls merge


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

2020-01-08 Thread GitBox
kaxil commented on a change in pull request #6489: [AIRFLOW-3959] 
[AIRFLOW-4026] Add filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#discussion_r364467450
 
 

 ##
 File path: airflow/migrations/versions/7939bcff74ba_add_tags_to_dagmodel.py
 ##
 @@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Add tags to DagModel
 
 Review comment:
   "Add table for DagTags" I guess would be more correct :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6090: [AIRFLOW-5470] Add Apache Livy REST operator

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6090: [AIRFLOW-5470] Add Apache Livy REST 
operator
URL: https://github.com/apache/airflow/pull/6090#issuecomment-572009682
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=h1) 
Report
   > Merging 
[#6090](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.19%`.
   > The diff coverage is `94.68%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6090/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#6090 +/-   ##
   =
   - Coverage   85.15%   84.96%   -0.2% 
   =
 Files 680  686  +6 
 Lines   3882439145+321 
   =
   + Hits3306133259+198 
   - Misses   5763 5886+123
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `67.78% <0%> (-1%)` | :arrow_down: |
   | 
[airflow/contrib/sensors/livy\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbGl2eV9zZW5zb3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[...flow/contrib/example\_dags/example\_livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX2xpdnlfb3BlcmF0b3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/livy\_hook.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2xpdnlfaG9vay5weQ==)
 | `94.77% <94.77%> (ø)` | |
   | 
[airflow/contrib/operators/livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9saXZ5X29wZXJhdG9yLnB5)
 | `97.5% <97.5%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | ... and [9 
more](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=footer). 
Last update 
[fe20ef6...fb8d699](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

2020-01-08 Thread GitBox
kaxil commented on a change in pull request #6489: [AIRFLOW-3959] 
[AIRFLOW-4026] Add filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#discussion_r364465298
 
 

 ##
 File path: airflow/www/app.py
 ##
 @@ -60,6 +61,11 @@ def create_app(config=None, session=None, testing=False, 
app_name="Airflow"):
 )
 app.secret_key = conf.get('webserver', 'SECRET_KEY')
 
+session_lifetime_days = 30
+if conf.has_option('webserver', 'SESSION_LIFETIME_DAYS'):
+session_lifetime_days = conf.getint('webserver', 
'SESSION_LIFETIME_DAYS')
 
 Review comment:
   These 3 lines can be changed to a single line:
   
   ```python
   session_lifetime_days = conf.getint('webserver', 'SESSION_LIFETIME_DAYS', 
fallback=30)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

2020-01-08 Thread GitBox
kaxil commented on a change in pull request #6489: [AIRFLOW-3959] 
[AIRFLOW-4026] Add filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#discussion_r364465298
 
 

 ##
 File path: airflow/www/app.py
 ##
 @@ -60,6 +61,11 @@ def create_app(config=None, session=None, testing=False, 
app_name="Airflow"):
 )
 app.secret_key = conf.get('webserver', 'SECRET_KEY')
 
+session_lifetime_days = 30
+if conf.has_option('webserver', 'SESSION_LIFETIME_DAYS'):
+session_lifetime_days = conf.getint('webserver', 
'SESSION_LIFETIME_DAYS')
 
 Review comment:
   This can be changed to :
   
   ```python
   session_lifetime_days = conf.getint('webserver', 'SESSION_LIFETIME_DAYS', 
fallback=30)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil merged pull request #7108: [AIRFLOW-XXXX] Move airflow-config-yaml pre-commit before pylint

2020-01-08 Thread GitBox
kaxil merged pull request #7108: [AIRFLOW-] Move airflow-config-yaml 
pre-commit before pylint
URL: https://github.com/apache/airflow/pull/7108
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil opened a new pull request #7108: [AIRFLOW-XXXX] Move airflow-config-yaml pre-commit before pylint

2020-01-08 Thread GitBox
kaxil opened a new pull request #7108: [AIRFLOW-] Move airflow-config-yaml 
pre-commit before pylint
URL: https://github.com/apache/airflow/pull/7108
 
 
   Move airflow-config-yaml pre-commit before pylint so we fail fast before the 
expensive pylint and mypy checks
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil merged pull request #7107: [AIRFLOW-XXXX] Add descriptions to kubernetes section of config docs

2020-01-08 Thread GitBox
kaxil merged pull request #7107: [AIRFLOW-] Add descriptions to kubernetes 
section of config docs
URL: https://github.com/apache/airflow/pull/7107
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] dimberman commented on a change in pull request #7085: [AIRFLOW-6334] Use classes instead list of string in executors

2020-01-08 Thread GitBox
dimberman commented on a change in pull request #7085: [AIRFLOW-6334] Use 
classes instead list of string in executors
URL: https://github.com/apache/airflow/pull/7085#discussion_r364453845
 
 

 ##
 File path: airflow/executors/base_executor.py
 ##
 @@ -232,14 +255,14 @@ def get_event_buffer(self, dag_ids=None) -> 
Dict[TaskInstanceKeyType, Optional[s
 
 def execute_async(self,
   key: TaskInstanceKeyType,
-  command: CommandType,
+  deferred_run: LocalTaskJobDeferredRun,
   queue: Optional[str] = None,
 
 Review comment:
   I agree with @dazza-codes here. At first glance, the name 
LocalTaskJobDeferredRun has a LOT going on it and is kind of hard to understand 
for people not well acquainted with the code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] dimberman commented on issue #7085: [AIRFLOW-6334] Use classes instead list of string in executors

2020-01-08 Thread GitBox
dimberman commented on issue #7085: [AIRFLOW-6334] Use classes instead list of 
string in executors
URL: https://github.com/apache/airflow/pull/7085#issuecomment-572265141
 
 
   A massive +1 on this one. It also makes debugging/testing a nightmare.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil commented on a change in pull request #7099: [AIRFLOW-6507] Replace the use of imp.load_source with another solution.

2020-01-08 Thread GitBox
kaxil commented on a change in pull request #7099: [AIRFLOW-6507] Replace the 
use of imp.load_source with another solution.
URL: https://github.com/apache/airflow/pull/7099#discussion_r364446643
 
 

 ##
 File path: airflow/models/dagbag.py
 ##
 @@ -248,7 +247,11 @@ def process_file(self, filepath, only_if_updated=True, 
safe_mode=True):
 
 with timeout(self.DAGBAG_IMPORT_TIMEOUT):
 try:
-m = imp.load_source(mod_name, filepath)
+loader = importlib.machinery.SourceFileLoader(mod_name, 
filepath)
+spec = importlib.util.spec_from_loader(mod_name, loader)
+m = importlib.util.module_from_spec(spec)
+sys.modules[spec.name] = m
 
 Review comment:
   The following should also work:
   
   ```python
   spec = importlib.util.spec_from_file_location(module_name, module_path)
   module = importlib.util.module_from_spec(spec)
   spec.loader.exec_module(module
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil commented on a change in pull request #7099: [AIRFLOW-6507] Replace the use of imp.load_source with another solution.

2020-01-08 Thread GitBox
kaxil commented on a change in pull request #7099: [AIRFLOW-6507] Replace the 
use of imp.load_source with another solution.
URL: https://github.com/apache/airflow/pull/7099#discussion_r364443683
 
 

 ##
 File path: airflow/models/dagbag.py
 ##
 @@ -248,7 +247,11 @@ def process_file(self, filepath, only_if_updated=True, 
safe_mode=True):
 
 with timeout(self.DAGBAG_IMPORT_TIMEOUT):
 try:
-m = imp.load_source(mod_name, filepath)
+loader = importlib.machinery.SourceFileLoader(mod_name, 
filepath)
+spec = importlib.util.spec_from_loader(mod_name, loader)
+m = importlib.util.module_from_spec(spec)
+sys.modules[spec.name] = m
 
 Review comment:
   We don't need this, do we?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] tooptoop4 commented on issue #7075: [AIRFLOW-6212] SparkSubmitHook resolve connection

2020-01-08 Thread GitBox
tooptoop4 commented on issue #7075: [AIRFLOW-6212] SparkSubmitHook resolve 
connection
URL: https://github.com/apache/airflow/pull/7075#issuecomment-572250534
 
 
   > > > > > @tooptoop4 if we don't remove the spark check on line 177, how to 
use this hook to track driver status deployed on yarn, mesos, or k8s? Since I 
think `spark://` is only for standalone mode.
   > > > > > Or this hook is created only for standalone mode?
   > > > > 
   > > > > 
   > > > > yes.there is no concept of async driver status poll for other modes 
, read https://spark.apache.org/docs/latest/running-on-yarn.html ! in other 
modes the submit to launch is synchronous . i think u can cancel this 
@albertusk95
   > > > 
   > > > 
   > > > I couldn't find any info stating that there's no async driver polling 
for YARN anyway from the provided link.
   > > 
   > > 
   > > There isn't async driver polling in YARN, I know Spark on YARN.
   > 
   > How about using Livy to interact with the YARN cluster? I guess it 
supports sync & async results retrieval.
   
   there is another active pr on livy i saw


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6090: [AIRFLOW-5470] Add Apache Livy REST operator

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6090: [AIRFLOW-5470] Add Apache Livy REST 
operator
URL: https://github.com/apache/airflow/pull/6090#issuecomment-572009682
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=h1) 
Report
   > Merging 
[#6090](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.19%`.
   > The diff coverage is `94.68%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6090/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#6090 +/-   ##
   =
   - Coverage   85.15%   84.96%   -0.2% 
   =
 Files 680  686  +6 
 Lines   3882439145+321 
   =
   + Hits3306133259+198 
   - Misses   5763 5886+123
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `67.78% <0%> (-1%)` | :arrow_down: |
   | 
[airflow/contrib/sensors/livy\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbGl2eV9zZW5zb3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[...flow/contrib/example\_dags/example\_livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX2xpdnlfb3BlcmF0b3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/livy\_hook.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2xpdnlfaG9vay5weQ==)
 | `94.77% <94.77%> (ø)` | |
   | 
[airflow/contrib/operators/livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9saXZ5X29wZXJhdG9yLnB5)
 | `97.5% <97.5%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | ... and [9 
more](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=footer). 
Last update 
[fe20ef6...dd948fc](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6090: [AIRFLOW-5470] Add Apache Livy REST operator

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6090: [AIRFLOW-5470] Add Apache Livy REST 
operator
URL: https://github.com/apache/airflow/pull/6090#issuecomment-572009682
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=h1) 
Report
   > Merging 
[#6090](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.19%`.
   > The diff coverage is `94.68%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6090/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#6090 +/-   ##
   =
   - Coverage   85.15%   84.96%   -0.2% 
   =
 Files 680  686  +6 
 Lines   3882439145+321 
   =
   + Hits3306133259+198 
   - Misses   5763 5886+123
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `67.78% <0%> (-1%)` | :arrow_down: |
   | 
[airflow/contrib/sensors/livy\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbGl2eV9zZW5zb3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[...flow/contrib/example\_dags/example\_livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX2xpdnlfb3BlcmF0b3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/livy\_hook.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2xpdnlfaG9vay5weQ==)
 | `94.77% <94.77%> (ø)` | |
   | 
[airflow/contrib/operators/livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9saXZ5X29wZXJhdG9yLnB5)
 | `97.5% <97.5%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | ... and [9 
more](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=footer). 
Last update 
[fe20ef6...dd948fc](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6090: [AIRFLOW-5470] Add Apache Livy REST operator

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6090: [AIRFLOW-5470] Add Apache Livy REST 
operator
URL: https://github.com/apache/airflow/pull/6090#issuecomment-572009682
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=h1) 
Report
   > Merging 
[#6090](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.19%`.
   > The diff coverage is `94.68%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6090/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#6090 +/-   ##
   =
   - Coverage   85.15%   84.96%   -0.2% 
   =
 Files 680  686  +6 
 Lines   3882439145+321 
   =
   + Hits3306133259+198 
   - Misses   5763 5886+123
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `67.78% <0%> (-1%)` | :arrow_down: |
   | 
[airflow/contrib/sensors/livy\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbGl2eV9zZW5zb3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[...flow/contrib/example\_dags/example\_livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX2xpdnlfb3BlcmF0b3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/livy\_hook.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2xpdnlfaG9vay5weQ==)
 | `94.77% <94.77%> (ø)` | |
   | 
[airflow/contrib/operators/livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9saXZ5X29wZXJhdG9yLnB5)
 | `97.5% <97.5%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | ... and [9 
more](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=footer). 
Last update 
[fe20ef6...dd948fc](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] codecov-io edited a comment on issue #6090: [AIRFLOW-5470] Add Apache Livy REST operator

2020-01-08 Thread GitBox
codecov-io edited a comment on issue #6090: [AIRFLOW-5470] Add Apache Livy REST 
operator
URL: https://github.com/apache/airflow/pull/6090#issuecomment-572009682
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=h1) 
Report
   > Merging 
[#6090](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/fe20ef6147f157b7c963ad46e13aff7c16458632?src=pr=desc)
 will **decrease** coverage by `0.19%`.
   > The diff coverage is `94.68%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6090/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#6090 +/-   ##
   =
   - Coverage   85.15%   84.96%   -0.2% 
   =
 Files 680  686  +6 
 Lines   3882439145+321 
   =
   + Hits3306133259+198 
   - Misses   5763 5886+123
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==)
 | `67.78% <0%> (-1%)` | :arrow_down: |
   | 
[airflow/contrib/sensors/livy\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbGl2eV9zZW5zb3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[...flow/contrib/example\_dags/example\_livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX2xpdnlfb3BlcmF0b3IucHk=)
 | `100% <100%> (ø)` | |
   | 
[airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/livy\_hook.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2xpdnlfaG9vay5weQ==)
 | `94.77% <94.77%> (ø)` | |
   | 
[airflow/contrib/operators/livy\_operator.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9saXZ5X29wZXJhdG9yLnB5)
 | `97.5% <97.5%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | ... and [9 
more](https://codecov.io/gh/apache/airflow/pull/6090/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=footer). 
Last update 
[fe20ef6...dd948fc](https://codecov.io/gh/apache/airflow/pull/6090?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil commented on a change in pull request #7107: [AIRFLOW-XXXX] Add descriptions to kubernetes section of config docs

2020-01-08 Thread GitBox
kaxil commented on a change in pull request #7107: [AIRFLOW-] Add 
descriptions to kubernetes section of config docs
URL: https://github.com/apache/airflow/pull/7107#discussion_r364425945
 
 

 ##
 File path: airflow/config_templates/config.yml
 ##
 @@ -1546,7 +1553,30 @@
   default: "default"
 - name: airflow_configmap
   description: |
-The name of the Kubernetes ConfigMap containing the Airflow 
Configuration (this file)
+The name of the Kubernetes ConfigMap containing ``airflow.cfg`` file.
+
+For example:
+
+``airflow_local_settings_configmap = "airflow-configmap"`` if you have 
the following ConfigMap.
 
 Review comment:
   ```suggestion
   ``airflow_configmap = "airflow-configmap"`` if you have the 
following ConfigMap.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil commented on a change in pull request #7107: [AIRFLOW-XXXX] Add descriptions to kubernetes section of config docs

2020-01-08 Thread GitBox
kaxil commented on a change in pull request #7107: [AIRFLOW-] Add 
descriptions to kubernetes section of config docs
URL: https://github.com/apache/airflow/pull/7107#discussion_r364425885
 
 

 ##
 File path: airflow/config_templates/config.yml
 ##
 @@ -1546,7 +1553,30 @@
   default: "default"
 - name: airflow_configmap
   description: |
-The name of the Kubernetes ConfigMap containing the Airflow 
Configuration (this file)
+The name of the Kubernetes ConfigMap containing ``airflow.cfg`` file.
+
+For example:
+
+``airflow_local_settings_configmap = "airflow-configmap"`` if you have 
the following ConfigMap.
+
+``airflow-configmap.yaml``:
+
+.. code-block:: yaml
+
+  ---
+  apiVersion: v1
+  kind: ConfigMap
+  metadata:
+name: airflow-configmap
+  data:
+airflow_local_settings.py: |
+def pod_mutation_hook(pod):
+...
 
 Review comment:
   Maybe we should remove `airflow_local_settings.py` key from here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil commented on a change in pull request #7107: [AIRFLOW-XXXX] Add descriptions to kubernetes section of config docs

2020-01-08 Thread GitBox
kaxil commented on a change in pull request #7107: [AIRFLOW-] Add 
descriptions to kubernetes section of config docs
URL: https://github.com/apache/airflow/pull/7107#discussion_r364425067
 
 

 ##
 File path: airflow/config_templates/config.yml
 ##
 @@ -1506,19 +1506,22 @@
   options:
 - name: worker_container_repository
   description: |
-The repository, tag and imagePullPolicy of the Kubernetes Image for 
the Worker to Run
+The repository of the Kubernetes Image for the Worker to Run
   version_added: ~
   type: string
   example: ~
   default: ""
 - name: worker_container_tag
-  description: ~
+  description: |
+
 
 Review comment:
   ```suggestion
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] frankcash commented on issue #7095: AIRFLOW-XXXX Update docs on example files for k8s

2020-01-08 Thread GitBox
frankcash commented on issue #7095: AIRFLOW- Update docs on example files 
for k8s
URL: https://github.com/apache/airflow/pull/7095#issuecomment-572238737
 
 
   Will do!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil merged pull request #7106: [AIRFLOW-XXXX] update logging section of config docs

2020-01-08 Thread GitBox
kaxil merged pull request #7106: [AIRFLOW-] update logging section of 
config docs
URL: https://github.com/apache/airflow/pull/7106
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] potiuk commented on issue #7095: AIRFLOW-XXXX Update docs on example files for k8s

2020-01-08 Thread GitBox
potiuk commented on issue #7095: AIRFLOW- Update docs on example files for 
k8s
URL: https://github.com/apache/airflow/pull/7095#issuecomment-572235037
 
 
   Merged! Just next time pls. add [AIRFLOW-] in commit (there was no []). 
I added them while merging so no problem this time. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] potiuk merged pull request #7095: AIRFLOW-XXXX Update docs on example files for k8s

2020-01-08 Thread GitBox
potiuk merged pull request #7095: AIRFLOW- Update docs on example files for 
k8s
URL: https://github.com/apache/airflow/pull/7095
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] potiuk commented on issue #7095: AIRFLOW-XXXX Update docs on example files for k8s

2020-01-08 Thread GitBox
potiuk commented on issue #7095: AIRFLOW- Update docs on example files for 
k8s
URL: https://github.com/apache/airflow/pull/7095#issuecomment-572234476
 
 
   Thanks @frankcash !


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] potiuk commented on issue #7105: [AIRFLOW-6513] Add web_pdb/pudb support in post_mortem option

2020-01-08 Thread GitBox
potiuk commented on issue #7105: [AIRFLOW-6513] Add web_pdb/pudb support in 
post_mortem option
URL: https://github.com/apache/airflow/pull/7105#issuecomment-572234088
 
 
   @mik-laj -> will you add an info of --post-mortem parameter to "debugging".


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (AIRFLOW-6513) Add web_pdb/pudb support in post_mortem option

2020-01-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010982#comment-17010982
 ] 

ASF subversion and git services commented on AIRFLOW-6513:
--

Commit 177dbd289c439146cdd0ead85fa2561a38531e2d in airflow's branch 
refs/heads/master from Kamil Breguła
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=177dbd2 ]

[AIRFLOW-6513] Add web_pdb/pudb support in post_mortem option (#7105)



> Add web_pdb/pudb support in post_mortem option
> --
>
> Key: AIRFLOW-6513
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6513
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: cli
>Affects Versions: 1.10.7
>Reporter: Kamil Bregula
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (AIRFLOW-6513) Add web_pdb/pudb support in post_mortem option

2020-01-08 Thread Jarek Potiuk (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk resolved AIRFLOW-6513.
---
Fix Version/s: 2.0.0
   Resolution: Fixed

> Add web_pdb/pudb support in post_mortem option
> --
>
> Key: AIRFLOW-6513
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6513
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: cli
>Affects Versions: 1.10.7
>Reporter: Kamil Bregula
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-6513) Add web_pdb/pudb support in post_mortem option

2020-01-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010981#comment-17010981
 ] 

ASF GitHub Bot commented on AIRFLOW-6513:
-

potiuk commented on pull request #7105: [AIRFLOW-6513] Add web_pdb/pudb support 
in post_mortem option
URL: https://github.com/apache/airflow/pull/7105
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add web_pdb/pudb support in post_mortem option
> --
>
> Key: AIRFLOW-6513
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6513
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: cli
>Affects Versions: 1.10.7
>Reporter: Kamil Bregula
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [airflow] potiuk merged pull request #7105: [AIRFLOW-6513] Add web_pdb/pudb support in post_mortem option

2020-01-08 Thread GitBox
potiuk merged pull request #7105: [AIRFLOW-6513] Add web_pdb/pudb support in 
post_mortem option
URL: https://github.com/apache/airflow/pull/7105
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] kaxil commented on issue #7106: [AIRFLOW-XXXX] update logging section of config docs

2020-01-08 Thread GitBox
kaxil commented on issue #7106: [AIRFLOW-] update logging section of config 
docs
URL: https://github.com/apache/airflow/pull/7106#issuecomment-572229129
 
 
   Aah CI failed. Can you install `pre-commit` hooks
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] dimberman opened a new pull request #7107: [AIRFLOW-XXXX] Add descriptions to kubernetes section of config docs

2020-01-08 Thread GitBox
dimberman opened a new pull request #7107: [AIRFLOW-] Add descriptions to 
kubernetes section of config docs
URL: https://github.com/apache/airflow/pull/7107
 
 
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


  1   2   3   4   >