[jira] [Updated] (AIRFLOW-6700) Error on airflow db init related to local import on example_dags module

[Sayed Mohammad Hossein Torabi (Jira)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sayed Mohammad Hossein Torabi updated AIRFLOW-6700:
---
Description: 
Error on `airflow db init` related to local import on **example_dags** module.
{code:java}
 ~ airflow db init
 DB: sqlite:home/blcksrx/airflow/airflow.db
 [2020-02-01 11:16:02,569] {db.py:471} INFO - Creating tables
 INFO [alembic.runtime.migration] Context impl SQLiteImpl.
 INFO [alembic.runtime.migration] Will assume non-transactional DDL.
 ERROR [airflow.models.dagbag.DagBag] Failed to import:   
/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py
 Traceback (most recent call last):
 File "/home/blcksrx/Projects/airflow/airflow/models/dagbag.py", line 255, in 
process_file
 loader.exec_module(m)
 File "", line 728, in exec_module
 File "", line 219, in _call_with_frames_removed
 File 
"/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py",
 line 24, in 
 from libs import print_stuff
 ModuleNotFoundError: No module named 'libs'
 Done.
{code}

  was:
Error on `airflow db init` related to local import on **example_dags** module.
{code:java}
// ~ airflow db init
 DB: sqlite:home/blcksrx/airflow/airflow.db
 [2020-02-01 11:16:02,569] {db.py:471} INFO - Creating tables
 INFO [alembic.runtime.migration] Context impl SQLiteImpl.
 INFO [alembic.runtime.migration] Will assume non-transactional DDL.
 ERROR [airflow.models.dagbag.DagBag] Failed to import: 
/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py
 Traceback (most recent call last):
 File "/home/blcksrx/Projects/airflow/airflow/models/dagbag.py", line 255, in 
process_file
 loader.exec_module(m)
 File "", line 728, in exec_module
 File "", line 219, in _call_with_frames_removed
 File 
"/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py",
 line 24, in 
 from libs import print_stuff
 ModuleNotFoundError: No module named 'libs'
 Done.
{code}


> Error on airflow db init related to local import on example_dags module
> ---
>
> Key: AIRFLOW-6700
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6700
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: examples
>Affects Versions: 1.10.7
>Reporter: Sayed Mohammad Hossein Torabi
>Assignee: Sayed Mohammad Hossein Torabi
>Priority: Major
>
> Error on `airflow db init` related to local import on **example_dags** module.
> {code:java}
>  ~ airflow db init
>  DB: sqlite:home/blcksrx/airflow/airflow.db
>  [2020-02-01 11:16:02,569] {db.py:471} INFO - Creating tables
>  INFO [alembic.runtime.migration] Context impl SQLiteImpl.
>  INFO [alembic.runtime.migration] Will assume non-transactional DDL.
>  ERROR [airflow.models.dagbag.DagBag] Failed to import:   
> /home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py
>  Traceback (most recent call last):
>  File "/home/blcksrx/Projects/airflow/airflow/models/dagbag.py", line 255, in 
> process_file
>  loader.exec_module(m)
>  File "", line 728, in exec_module
>  File "", line 219, in _call_with_frames_removed
>  File 
> "/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py",
>  line 24, in 
>  from libs import print_stuff
>  ModuleNotFoundError: No module named 'libs'
>  Done.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (AIRFLOW-6700) Error on airflow db init related to local import on example_dags module

[Sayed Mohammad Hossein Torabi (Jira)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sayed Mohammad Hossein Torabi updated AIRFLOW-6700:
---
Description: 
Error on `airflow db init` related to local import on **example_dags** module.

```


 ~ airflow db init
 DB: sqlite:home/blcksrx/airflow/airflow.db
 [2020-02-01 11:16:02,569] \{db.py:471} INFO - Creating tables
 INFO [alembic.runtime.migration] Context impl SQLiteImpl.
 INFO [alembic.runtime.migration] Will assume non-transactional DDL.
 ERROR [airflow.models.dagbag.DagBag] Failed to import: 
/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py
 Traceback (most recent call last):
 File "/home/blcksrx/Projects/airflow/airflow/models/dagbag.py", line 255, in 
process_file
 loader.exec_module(m)
 File "", line 728, in exec_module
 File "", line 219, in _call_with_frames_removed
 File 
"/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py",
 line 24, in 
 from libs import print_stuff
 ModuleNotFoundError: No module named 'libs'
 Done.


 ```

  was:
Error on `airflow db init` related to local import on **example_dags** module.

```
~ airflow db init
DB: sqlite:home/blcksrx/airflow/airflow.db
[2020-02-01 11:16:02,569] \{db.py:471} INFO - Creating tables
INFO [alembic.runtime.migration] Context impl SQLiteImpl.
INFO [alembic.runtime.migration] Will assume non-transactional DDL.
ERROR [airflow.models.dagbag.DagBag] Failed to import: 
/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py
Traceback (most recent call last):
 File "/home/blcksrx/Projects/airflow/airflow/models/dagbag.py", line 255, in 
process_file
 loader.exec_module(m)
 File "", line 728, in exec_module
 File "", line 219, in _call_with_frames_removed
 File 
"/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py",
 line 24, in 
 from libs import print_stuff
ModuleNotFoundError: No module named 'libs'
Done.
```


> Error on airflow db init related to local import on example_dags module
> ---
>
> Key: AIRFLOW-6700
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6700
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: examples
>Affects Versions: 1.10.7
>Reporter: Sayed Mohammad Hossein Torabi
>Assignee: Sayed Mohammad Hossein Torabi
>Priority: Major
>
> Error on `airflow db init` related to local import on **example_dags** module.
> ```
>  ~ airflow db init
>  DB: sqlite:home/blcksrx/airflow/airflow.db
>  [2020-02-01 11:16:02,569] \{db.py:471} INFO - Creating tables
>  INFO [alembic.runtime.migration] Context impl SQLiteImpl.
>  INFO [alembic.runtime.migration] Will assume non-transactional DDL.
>  ERROR [airflow.models.dagbag.DagBag] Failed to import: 
> /home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py
>  Traceback (most recent call last):
>  File "/home/blcksrx/Projects/airflow/airflow/models/dagbag.py", line 255, in 
> process_file
>  loader.exec_module(m)
>  File "", line 728, in exec_module
>  File "", line 219, in _call_with_frames_removed
>  File 
> "/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py",
>  line 24, in 
>  from libs import print_stuff
>  ModuleNotFoundError: No module named 'libs'
>  Done.
>  ```



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (AIRFLOW-6700) Error on airflow db init related to local import on example_dags module

[Sayed Mohammad Hossein Torabi (Jira)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sayed Mohammad Hossein Torabi updated AIRFLOW-6700:
---
Description: 
Error on `airflow db init` related to local import on **example_dags** module.
{code:java}
// ~ airflow db init
 DB: sqlite:home/blcksrx/airflow/airflow.db
 [2020-02-01 11:16:02,569] {db.py:471} INFO - Creating tables
 INFO [alembic.runtime.migration] Context impl SQLiteImpl.
 INFO [alembic.runtime.migration] Will assume non-transactional DDL.
 ERROR [airflow.models.dagbag.DagBag] Failed to import: 
/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py
 Traceback (most recent call last):
 File "/home/blcksrx/Projects/airflow/airflow/models/dagbag.py", line 255, in 
process_file
 loader.exec_module(m)
 File "", line 728, in exec_module
 File "", line 219, in _call_with_frames_removed
 File 
"/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py",
 line 24, in 
 from libs import print_stuff
 ModuleNotFoundError: No module named 'libs'
 Done.
{code}

  was:
Error on `airflow db init` related to local import on **example_dags** module.

```


 ~ airflow db init
 DB: sqlite:home/blcksrx/airflow/airflow.db
 [2020-02-01 11:16:02,569] \{db.py:471} INFO - Creating tables
 INFO [alembic.runtime.migration] Context impl SQLiteImpl.
 INFO [alembic.runtime.migration] Will assume non-transactional DDL.
 ERROR [airflow.models.dagbag.DagBag] Failed to import: 
/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py
 Traceback (most recent call last):
 File "/home/blcksrx/Projects/airflow/airflow/models/dagbag.py", line 255, in 
process_file
 loader.exec_module(m)
 File "", line 728, in exec_module
 File "", line 219, in _call_with_frames_removed
 File 
"/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py",
 line 24, in 
 from libs import print_stuff
 ModuleNotFoundError: No module named 'libs'
 Done.


 ```


> Error on airflow db init related to local import on example_dags module
> ---
>
> Key: AIRFLOW-6700
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6700
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: examples
>Affects Versions: 1.10.7
>Reporter: Sayed Mohammad Hossein Torabi
>Assignee: Sayed Mohammad Hossein Torabi
>Priority: Major
>
> Error on `airflow db init` related to local import on **example_dags** module.
> {code:java}
> // ~ airflow db init
>  DB: sqlite:home/blcksrx/airflow/airflow.db
>  [2020-02-01 11:16:02,569] {db.py:471} INFO - Creating tables
>  INFO [alembic.runtime.migration] Context impl SQLiteImpl.
>  INFO [alembic.runtime.migration] Will assume non-transactional DDL.
>  ERROR [airflow.models.dagbag.DagBag] Failed to import: 
> /home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py
>  Traceback (most recent call last):
>  File "/home/blcksrx/Projects/airflow/airflow/models/dagbag.py", line 255, in 
> process_file
>  loader.exec_module(m)
>  File "", line 728, in exec_module
>  File "", line 219, in _call_with_frames_removed
>  File 
> "/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py",
>  line 24, in 
>  from libs import print_stuff
>  ModuleNotFoundError: No module named 'libs'
>  Done.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (AIRFLOW-6700) Error on airflow db init related to local import on example_dags module

[Sayed Mohammad Hossein Torabi (Jira)]

Sayed Mohammad Hossein Torabi created AIRFLOW-6700:
--

 Summary: Error on airflow db init related to local import on 
example_dags module
 Key: AIRFLOW-6700
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6700
 Project: Apache Airflow
  Issue Type: Bug
  Components: examples
Affects Versions: 1.10.7
Reporter: Sayed Mohammad Hossein Torabi
Assignee: Sayed Mohammad Hossein Torabi


Error on `airflow db init` related to local import on **example_dags** module.

```
~ airflow db init
DB: sqlite:home/blcksrx/airflow/airflow.db
[2020-02-01 11:16:02,569] \{db.py:471} INFO - Creating tables
INFO [alembic.runtime.migration] Context impl SQLiteImpl.
INFO [alembic.runtime.migration] Will assume non-transactional DDL.
ERROR [airflow.models.dagbag.DagBag] Failed to import: 
/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py
Traceback (most recent call last):
 File "/home/blcksrx/Projects/airflow/airflow/models/dagbag.py", line 255, in 
process_file
 loader.exec_module(m)
 File "", line 728, in exec_module
 File "", line 219, in _call_with_frames_removed
 File 
"/home/blcksrx/Projects/airflow/airflow/example_dags/example_kubernetes_executor.py",
 line 24, in 
 from libs import print_stuff
ModuleNotFoundError: No module named 'libs'
Done.
```



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] stale[bot] commented on issue #6175: [AIRFLOW-5545] Fixes recursion in DAG cycle testing

[GitBox]

stale[bot] commented on issue #6175: [AIRFLOW-5545] Fixes recursion in DAG 
cycle testing
URL: https://github.com/apache/airflow/pull/6175#issuecomment-580976560
 
 
   This issue has been automatically marked as stale because it has not had 
recent activity. It will be closed if no further activity occurs. Thank you for 
your contributions.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] stale[bot] closed pull request #6623: Donating Google's Airflow K8s Operator to Apache Foundation

[GitBox]

stale[bot] closed pull request #6623: Donating Google's Airflow K8s Operator to 
Apache Foundation
URL: https://github.com/apache/airflow/pull/6623
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

[GitBox]

coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday 
sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-580951357
 
 
   Sure, I would love to give that a shot. Thanks!
   
   On Fri, Jan 31, 2020 at 16:53 Kamil Breguła 
   wrote:
   
   > @coopergillan  I see that you like order
   > in tests. Wouldn't you like to organize one file?
   >
   > 
https://github.com/apache/airflow/blob/master/tests/providers/apache/hive/operators/test_hive.py#L29-L40
   > This file contains tests for many unrelated components. I think it would
   > be useful to transfer some tests to other files.
   > Here is an example: PolideaInternal@a91b612
   > 

   > To avoid conflicts you can do it in one PR, but it would be useful for
   > each move to be in a separate commit. This will facilitate the review.
   >
   > —
   > You are receiving this because you were mentioned.
   >
   >
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   >
   -- 
   
   Cooper
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6440) AWS Fargate Executor (AIP-29) (WIP)

[Andrea Falco (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027879#comment-17027879
 ] 

Andrea Falco commented on AIRFLOW-6440:
---

I've a question: why is this executor called "AWS Fargate" and not "AWS ECS"?
In practice it allow you to start a task with ECS placed into EC2 or FARGATE 
(or FARGATE-SPOT).

I propose to rename this executor with the name "AWS ECS Executor" and correct 
the code because in some parte you use the term ECS referring to EC2 and the 
term FARGATE referring to ECS.

Tell me if I can help.

> AWS Fargate Executor (AIP-29) (WIP)
> ---
>
> Key: AIRFLOW-6440
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6440
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: aws, executors
>Affects Versions: 1.10.8
> Environment: AWS Cloud
>Reporter: Ahmed Elzeiny
>Assignee: Ahmed Elzeiny
>Priority: Minor
>  Labels: AWS, Executor, autoscaling
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> h1. Links
> AIP - 
> [https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-29%3A+AWS+Fargate+Executor]
> PR - [https://github.com/apache/airflow/pull/7030]
> h1. Airflow on AWS Fargate
> {color:#707070}We propose the creation of a new Airflow Executor, called the 
> FargateExecutor, that runs tasks asynchronously on AWS Fargate. The Airflow 
> Scheduler comes up with a command that needs to be executed in some shell. A 
> Docker container parameterized with the command is passed in as an ARG, and 
> AWS Fargate provisions a new instance with . The container then completes or 
> fails the job, causing the container to die along with the Fargate instance. 
> The executor is responsible for keeping track what happened to the task with 
> an airflow task id and AWS ARN number, and based off of the instance exit 
> code we either say that the task succeeded or failed.{color}
> h1. Proposed Implementation
> As you could probably deduce, the underlying mechanism to launch, track, and 
> stop Fargate instances is AWS' Boto3 Library.
> To accomplish this we create a FargateExecutor under the "airflow.executors" 
> module. This class will extend from BaseExecutor and override 5 methods: 
> {{start()}}, {{{color:#3366ff}sync(){color}}},{{{color:#3366ff} 
> execute_async(){color}}}, {{{color:#3366ff}end(){color}}}, and 
> {{{color:#3366ff}terminate(){color}}}. Internally, the FargateExecutor uses 
> boto3 for monitoring and deployment purposes.
> {color:#707070}The three major Boto3 API calls are:{color}
>  * {color:#707070}The {color:#0747a6}{{execute_async()}}{color} function 
> calls boto3's {{{color:#0747a6}run_task(){color}}} function.{color}
>  * {color:#707070}The {{{color:#0747a6}sync(){color}}} function calls boto3's 
> {{{color:#0747a6}describe_tasks(){color}}} function.{color}
>  * {color:#707070}The {{{color:#0747a6}terminate(){color}}} function calls 
> boto3's {{{color:#0747a6}stop_task(){color}}} function.{color}
> h1. Maintenance
> The executor itself is nothing special since it mostly relies on overriding 
> the proper methods from .
> In general, AWS is fairly committed to keeping their APIs in service. Fargate 
> is rather new and I've personally perceived a lot more features added as 
> optional parameters over the course of the past year. However, the required 
> parameters for the three Boto3 calls that are used have remained the same. 
> I've also written test-cases that ensures that the Boto3 calls made are 
> complaint to the most current version of their APIs.
> We've also introduced a callback hook (very similar to the Celery Executor) 
> that allows users to launch tasks with their own parameters. Therefore if a 
> user doesn't like the default parameter options used in Boto3's 
> \{{run_task(),}}then they can call it themselves with whatever parameters 
> they want. This means that Airflow doesn't have to add a new configuration 
> everytime AWS makes an addition to AWS Fargate. It's just one configuration 
> to cover them all.
> h1. {color:#707070}Proposed Configuration{color}
>  
> {code:java}
> [fargate]
> # For more information on any of these execution parameters, see the link 
> below:
> # 
> https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ecs.html#ECS.Client.run_task
> # For boto3 credential management, see
> # 
> https://boto3.amazonaws.com/v1/documentation/api/latest/guide/configuration.html
> ### MANDATORY CONFIGS:
> # Name of region
> region = us-west-2
> # Name of cluster
> cluster = test-airflow
> ### EITHER POPULATE THESE:
> # Name of task definition with a bootable-container. Note that this container 
> will receive an airflow CLI
> # command as an additional parameter to its entrypoint. It's job is to 
> boot-up and run this command
> task_definition = 

[GitHub] [airflow] mik-laj commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

[GitBox]

mik-laj commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor 
tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-580946162
 
 
   @coopergillan  I see that you like order in tests. Wouldn't you like to 
organize one file?  
   
https://github.com/apache/airflow/blob/master/tests/providers/apache/hive/operators/test_hive.py#L29-L40
   This file contains tests for many unrelated components. I think it would be 
useful to transfer some tests to other files.
   Here is an example: 
https://github.com/PolideaInternal/airflow/commit/a91b61222a7790c6daeb59f3bb2d90f1a2cc1c40
   To avoid conflicts you can do it in one PR, but it would be useful for each 
move to be in a separate commit. This will facilitate the review. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

[GitBox]

codecov-io edited a comment on issue #7316: [AIRFLOW-6699] Parameterize weekday 
sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-580933199
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr=h1) 
Report
   > Merging 
[#7316](https://codecov.io/gh/apache/airflow/pull/7316?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/65b524a6a571b6b3510d10672b3c7cd075323d07?src=pr=desc)
 will **decrease** coverage by `0.24%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7316/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7316?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7316  +/-   ##
   ==
   - Coverage   85.59%   85.34%   -0.25% 
   ==
 Files 863  863  
 Lines   4048440484  
   ==
   - Hits3465134552  -99 
   - Misses   5833 5932  +99
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7316?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=)
 | `52.94% <0%> (-32.36%)` | :arrow_down: |
   | 
[airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=)
 | `77.46% <0%> (-16.91%)` | :arrow_down: |
   | 
[airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5)
 | `93.33% <0%> (-3.34%)` | :arrow_down: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `85.63% <0%> (-2.5%)` | :arrow_down: |
   | 
[airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5)
 | `88.42% <0%> (-2.48%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `90.43% <0%> (-1.45%)` | :arrow_down: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `88.75% <0%> (-0.44%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr=footer). 
Last update 
[65b524a...2fecab1](https://codecov.io/gh/apache/airflow/pull/7316?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible

[GitBox]

coopergillan commented on issue #7309: [AIRFLOW-4681] Make sensors module 
pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-580937766
 
 
   Build failures look unrelated and transient.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Work started] (AIRFLOW-6685) Add operators to improve data quality testing on data workflows/pipelines

[alex l (Jira)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on AIRFLOW-6685 started by alex l.
---
> Add operators to improve data quality testing on data workflows/pipelines
> -
>
> Key: AIRFLOW-6685
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6685
> Project: Apache Airflow
>  Issue Type: New Feature
>  Components: operators
>Affects Versions: 2.0.0
>Reporter: alex l
>Assignee: alex l
>Priority: Major
>
> Adding plugins to allow better data quality testing within a dag. This 
> includes 3 operators:
>  * BaseDataQualityOperator
>  ** contains shared attributes and methods that data quality check operators 
> utilize
>  ** a base class that can be used to create other dq operators
>  * DataQualityThresholdCheckOperator
>  ** will check a single value, sql result against a threshold range, and will 
> fail a task if it is outside this range.
>  * DataQulaityThresholdSQLCheckOperator
>  ** Similar to DataQualityThresholdCheckOperator, but thresholds are 
> sql-evaluated values, for dynamic threshold ranging.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] codecov-io commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

[GitBox]

codecov-io commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor 
tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-580933199
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr=h1) 
Report
   > Merging 
[#7316](https://codecov.io/gh/apache/airflow/pull/7316?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/65b524a6a571b6b3510d10672b3c7cd075323d07?src=pr=desc)
 will **decrease** coverage by `0.69%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7316/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7316?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#7316 +/-   ##
   =
   - Coverage   85.59%   84.89%   -0.7% 
   =
 Files 863  863 
 Lines   4048440484 
   =
   - Hits3465134369-282 
   - Misses   5833 6115+282
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7316?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.51% <0%> (-72.16%)` | :arrow_down: |
   | 
[airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=)
 | `28.16% <0%> (-54.93%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50% <0%> (-50%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0%> (-46.67%)` | :arrow_down: |
   | 
[airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5)
 | `49.65% <0%> (-38.78%)` | :arrow_down: |
   | 
[airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=)
 | `61.53% <0%> (-38.47%)` | :arrow_down: |
   | 
[...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=)
 | `52.94% <0%> (-32.36%)` | :arrow_down: |
   | 
[airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=)
 | `77.46% <0%> (-16.91%)` | :arrow_down: |
   | ... and [7 
more](https://codecov.io/gh/apache/airflow/pull/7316/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7316?src=pr=footer). 
Last update 
[65b524a...2fecab1](https://codecov.io/gh/apache/airflow/pull/7316?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

[GitBox]

coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday 
sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-580932930
 
 
   Pushed up two fixup commits and then squashed them into one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Reopened] (AIRFLOW-4681) Make airflow/sensors Pylint compatible

[Kamil Bregula (Jira)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil Bregula reopened AIRFLOW-4681:


> Make airflow/sensors Pylint compatible
> --
>
> Key: AIRFLOW-4681
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4681
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: pylint
>Affects Versions: 2.0.0
>Reporter: Bas Harenslak
>Assignee: Kamil Bregula
>Priority: Major
>
> Fix all Pylint messages in airflow/sensors. To start; running 
> scripts/ci/ci_pylint.sh on master should produce no messages. (1) Remove the 
> files mentioned in your issue from the blacklist. (2) Run 
> scripts/ci/ci_pylint.sh to see all messages on the no longer blacklisted 
> files. (3) Fix all messages and create PR.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] mik-laj commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible

[GitBox]

mik-laj commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint 
compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-580930406
 
 
   No. Don't worry. This can be fixed later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible

[GitBox]

coopergillan commented on issue #7309: [AIRFLOW-4681] Make sensors module 
pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-580926362
 
 
   Seeing [AIRFLOW-4681](https://issues.apache.org/jira/browse/AIRFLOW-4681) 
was marked as "Won't Do". Should we close this one?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Work started] (AIRFLOW-6699) Parameterize weekday sensor tests

[Cooper Gillan (Jira)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on AIRFLOW-6699 started by Cooper Gillan.
--
> Parameterize weekday sensor tests
> -
>
> Key: AIRFLOW-6699
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6699
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: tests
>Affects Versions: 1.10.7
>Reporter: Cooper Gillan
>Assignee: Cooper Gillan
>Priority: Minor
>
> Many of the arguments for the true tests in 
> tests/sensors/test_weekday_sensor.py are repeated. The tests are also running 
> with unittest.TestCase rather than pytest.
> Make use of pytest's parametrize functionality to use the same base tests for 
> true tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] robinedwards commented on a change in pull request #7251: [AIRFLOW-6628] Fix search auto complete behaviour

[GitBox]

robinedwards commented on a change in pull request #7251: [AIRFLOW-6628] Fix 
search auto complete behaviour
URL: https://github.com/apache/airflow/pull/7251#discussion_r373697615
 
 

 ##
 File path: airflow/www/views.py
 ##
 @@ -325,10 +319,36 @@ def get_int_arg(value, default=0):
 paging=wwwutils.generate_pages(current_page, num_of_pages,
search=escape(arg_search_query) if 
arg_search_query else None,
showPaused=not hide_paused),
-auto_complete_data=auto_complete_data,
 num_runs=num_runs,
 tags=tags)
 
+@expose('/dag_autocomplete')
+@has_access
 
 Review comment:
   Yea i guess `dag_stats` too, could potentially break people consuming the 
end point directly on its existing path mind.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on a change in pull request #7309: [AIRFLOW-4681] Make sensors module pylint compatible

[GitBox]

coopergillan commented on a change in pull request #7309: [AIRFLOW-4681] Make 
sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#discussion_r373697332
 
 

 ##
 File path: airflow/providers/jira/sensors/jira.py
 ##
 @@ -68,7 +68,7 @@ class JiraTicketSensor(JiraSensor):
 
 :param jira_conn_id: reference to a pre-defined Jira Connection
 :type jira_conn_id: str
-:param ticket_id: id of the ticket to be monitored
+state:param ticket_id: id of the ticket to be monitored
 
 Review comment:
   Nice catch, thank you! This snuck in somehow. Just pushed up a change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

[GitBox]

coopergillan commented on issue #7316: [AIRFLOW-6699] Parameterize weekday 
sensor tests
URL: https://github.com/apache/airflow/pull/7316#issuecomment-580919009
 
 
   Note: I noticed [usage of `parameterized` in 
`tests/providers/sftp/hooks/test_sftp.py`](https://github.com/coopergillan/airflow/blob/d97fe949c8dfd888abf27a4254ef0d27388f63bb/tests/providers/sftp/hooks/test_sftp.py#L210)
 among other spots.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on a change in pull request #7315: [AIRFLOW-6699] Parameterize weekday_sensor tests

[GitBox]

coopergillan commented on a change in pull request #7315: [AIRFLOW-6699] 
Parameterize weekday_sensor tests
URL: https://github.com/apache/airflow/pull/7315#discussion_r373692143
 
 

 ##
 File path: tests/sensors/test_weekday_sensor.py
 ##
 @@ -33,130 +33,91 @@
 WEEKEND_DATE = datetime(2018, 12, 22)
 TEST_DAG_ID = 'weekday_sensor_dag'
 DEV_NULL = '/dev/null'
-
-
-class TestDayOfWeekSensor(unittest.TestCase):
-
-def setUp(self):
-self.dagbag = DagBag(
-dag_folder=DEV_NULL,
-include_examples=True
-)
-self.args = {
-'owner': 'airflow',
-'start_date': DEFAULT_DATE
-}
-dag = DAG(TEST_DAG_ID, default_args=self.args)
-self.dag = dag
-
-def tearDown(self):
-session = Session()
-session.query(models.TaskInstance).filter_by(
-dag_id=TEST_DAG_ID).delete()
-session.query(TaskFail).filter_by(
-dag_id=TEST_DAG_ID).delete()
-session.commit()
-session.close()
-
-def test_weekday_sensor_true(self):
-op = DayOfWeekSensor(
-task_id='weekday_sensor_check_true',
-week_day='Thursday',
-use_task_execution_day=True,
-dag=self.dag)
+TRUE_TESTS_CONFIG = {
+"string": "Thursday",
+"enum": WeekDay.THURSDAY,
+"enum-set": {WeekDay.THURSDAY},
+"enum-set-2-items": {WeekDay.THURSDAY, WeekDay.FRIDAY},
+"string-set": {'Thursday'},
+"string-set-2-items": {'Thursday', 'Friday'},
+}
+
+
+@pytest.fixture
+def dag():
+args = {"owner": "airflow", "start_date": DEFAULT_DATE}
+return DAG(TEST_DAG_ID, default_args=args)
+
+
+@pytest.fixture
+def tear_down():
+yield
+
+session = Session()
+session.query(models.TaskInstance).filter_by(
+dag_id=TEST_DAG_ID).delete()
+session.query(TaskFail).filter_by(
+dag_id=TEST_DAG_ID).delete()
+session.commit()
+session.close()
+
+
+@pytest.mark.parametrize("weekday", TRUE_TESTS_CONFIG.values(), 
ids=list(TRUE_TESTS_CONFIG.keys()))
+def test_weekday_sensor_true(dag, weekday, tear_down):
+op = DayOfWeekSensor(
+task_id="weekday_sensor_check_true",
 
 Review comment:
   This helped me learn about how tests **are** parameterized here in 
`airflow`. Went with a different approach over in #7316.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6699) Parameterize weekday sensor tests

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027842#comment-17027842
 ] 

ASF GitHub Bot commented on AIRFLOW-6699:
-

coopergillan commented on pull request #7315: [AIRFLOW-6699] Parameterize 
weekday_sensor tests
URL: https://github.com/apache/airflow/pull/7315
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Parameterize weekday sensor tests
> -
>
> Key: AIRFLOW-6699
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6699
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: tests
>Affects Versions: 1.10.7
>Reporter: Cooper Gillan
>Assignee: Cooper Gillan
>Priority: Minor
>
> Many of the arguments for the true tests in 
> tests/sensors/test_weekday_sensor.py are repeated. The tests are also running 
> with unittest.TestCase rather than pytest.
> Make use of pytest's parametrize functionality to use the same base tests for 
> true tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] coopergillan commented on issue #7315: [AIRFLOW-6699] Parameterize weekday_sensor tests

[GitBox]

coopergillan commented on issue #7315: [AIRFLOW-6699] Parameterize 
weekday_sensor tests
URL: https://github.com/apache/airflow/pull/7315#issuecomment-580917441
 
 
   Closed in favor of https://github.com/apache/airflow/pull/7316.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan closed pull request #7315: [AIRFLOW-6699] Parameterize weekday_sensor tests

[GitBox]

coopergillan closed pull request #7315: [AIRFLOW-6699] Parameterize 
weekday_sensor tests
URL: https://github.com/apache/airflow/pull/7315
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6699) Parameterize weekday sensor tests

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027840#comment-17027840
 ] 

ASF GitHub Bot commented on AIRFLOW-6699:
-

coopergillan commented on pull request #7316: [AIRFLOW-6699] Parameterize 
weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316
 
 
   Using the `parameterized` library, consolidate the "true" or so-called 
"happy path" tests, reducing overall code to maintain and showing each test 
case in one list of tuples.
   
   This makes it faster to add any other true test cases if need be.
   
   For now, the "false" tests are different enough to remain as-is.
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Parameterize weekday sensor tests
> -
>
> Key: AIRFLOW-6699
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6699
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: tests
>Affects Versions: 1.10.7
>Reporter: Cooper Gillan
>Assignee: Cooper Gillan
>Priority: Minor
>
> Many of the arguments for the true tests in 
> tests/sensors/test_weekday_sensor.py are repeated. The tests are also running 
> with unittest.TestCase rather than pytest.
> Make use of pytest's parametrize functionality to use the same base tests for 
> true tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] coopergillan opened a new pull request #7316: [AIRFLOW-6699] Parameterize weekday sensor tests

[GitBox]

coopergillan opened a new pull request #7316: [AIRFLOW-6699] Parameterize 
weekday sensor tests
URL: https://github.com/apache/airflow/pull/7316
 
 
   Using the `parameterized` library, consolidate the "true" or so-called 
"happy path" tests, reducing overall code to maintain and showing each test 
case in one list of tuples.
   
   This makes it faster to add any other true test cases if need be.
   
   For now, the "false" tests are different enough to remain as-is.
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] TomatoEgg commented on issue #7230: [AIRFLOW-6602]: render executor_config before triggering tasks to su…

[GitBox]

TomatoEgg commented on issue #7230: [AIRFLOW-6602]: render executor_config 
before triggering tasks to su…
URL: https://github.com/apache/airflow/pull/7230#issuecomment-580916713
 
 
   @nuclearpinguin : sure, but I would need to discuss what I observed in my 
manual testing of this feature. Who is the best person to talk to? and how do 
you normally carry out such discussions? (This is my first PR so please bear 
with me those basic questions)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] robinedwards commented on a change in pull request #7251: [AIRFLOW-6628] Fix search auto complete behaviour

[GitBox]

robinedwards commented on a change in pull request #7251: [AIRFLOW-6628] Fix 
search auto complete behaviour
URL: https://github.com/apache/airflow/pull/7251#discussion_r373690273
 
 

 ##
 File path: UPDATING.md
 ##
 @@ -59,6 +59,10 @@ https://developers.google.com/style/inclusive-documentation
 
 -->
 
+### New permission can_dag_autocomplete
+The new dag autocomplete end point requires permissions to be synchronised and 
updated for roles other than Admin. Please run `airflow sync_perm`,
 
 Review comment:
   Happy to take that bit out. I have that setting turned off so thought it 
could possibly trip people up


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7251: [AIRFLOW-6628] Fix search auto complete behaviour

[GitBox]

ashb commented on a change in pull request #7251: [AIRFLOW-6628] Fix search 
auto complete behaviour
URL: https://github.com/apache/airflow/pull/7251#discussion_r373690224
 
 

 ##
 File path: airflow/www/views.py
 ##
 @@ -325,10 +319,36 @@ def get_int_arg(value, default=0):
 paging=wwwutils.generate_pages(current_page, num_of_pages,
search=escape(arg_search_query) if 
arg_search_query else None,
showPaused=not hide_paused),
-auto_complete_data=auto_complete_data,
 num_runs=num_runs,
 tags=tags)
 
+@expose('/dag_autocomplete')
+@has_access
 
 Review comment:
   And more for future work than anything else: should methods like this live 
on the DagModelView instead?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7307: [AIRFLOW-6676] added GCSDeleteBucketOperator

[GitBox]

codecov-io edited a comment on issue #7307: [AIRFLOW-6676] added 
GCSDeleteBucketOperator
URL: https://github.com/apache/airflow/pull/7307#issuecomment-580914401
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7307?src=pr=h1) 
Report
   > Merging 
[#7307](https://codecov.io/gh/apache/airflow/pull/7307?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a2d6a2f85e07c38be479e91e4a27981f308f4711?src=pr=desc)
 will **decrease** coverage by `0.44%`.
   > The diff coverage is `94.87%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7307/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7307?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #7307  +/-   ##
   =
   - Coverage   85.34%   84.9%   -0.45% 
   =
 Files 863 863  
 Lines   40484   40523  +39 
   =
   - Hits34552   34406 -146 
   - Misses   59326117 +185
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7307?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/google/cloud/hooks/gcs.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2djcy5weQ==)
 | `85.51% <100%> (+0.53%)` | :arrow_up: |
   | 
[airflow/providers/google/cloud/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9nY3MucHk=)
 | `86.44% <100%> (+0.81%)` | :arrow_up: |
   | 
[...providers/google/cloud/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2djcy5weQ==)
 | `96.29% <89.47%> (-3.71%)` | :arrow_down: |
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.51% <0%> (-72.16%)` | :arrow_down: |
   | 
[airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=)
 | `28.16% <0%> (-54.93%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50% <0%> (-50%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0%> (-46.67%)` | :arrow_down: |
   | 
[airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5)
 | `49.65% <0%> (-38.78%)` | :arrow_down: |
   | 
[airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=)
 | `61.53% <0%> (-38.47%)` | :arrow_down: |
   | 
[airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5)
 | `85% <0%> (-8.34%)` | :arrow_down: |
   | ... and [2 
more](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7307?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7307?src=pr=footer). 
Last update 
[a2d6a2f...06a05ef](https://codecov.io/gh/apache/airflow/pull/7307?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7251: [AIRFLOW-6628] Fix search auto complete behaviour

[GitBox]

ashb commented on a change in pull request #7251: [AIRFLOW-6628] Fix search 
auto complete behaviour
URL: https://github.com/apache/airflow/pull/7251#discussion_r373688808
 
 

 ##
 File path: UPDATING.md
 ##
 @@ -59,6 +59,10 @@ https://developers.google.com/style/inclusive-documentation
 
 -->
 
+### New permission can_dag_autocomplete
+The new dag autocomplete end point requires permissions to be synchronised and 
updated for roles other than Admin. Please run `airflow sync_perm`,
 
 Review comment:
   sync_perm is run automatically at webserver start up, so this part isn't 
needed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7307: [AIRFLOW-6676] added GCSDeleteBucketOperator

[GitBox]

codecov-io commented on issue #7307: [AIRFLOW-6676] added 
GCSDeleteBucketOperator
URL: https://github.com/apache/airflow/pull/7307#issuecomment-580914401
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7307?src=pr=h1) 
Report
   > Merging 
[#7307](https://codecov.io/gh/apache/airflow/pull/7307?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a2d6a2f85e07c38be479e91e4a27981f308f4711?src=pr=desc)
 will **decrease** coverage by `0.44%`.
   > The diff coverage is `94.87%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7307/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/7307?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #7307  +/-   ##
   =
   - Coverage   85.34%   84.9%   -0.45% 
   =
 Files 863 863  
 Lines   40484   40523  +39 
   =
   - Hits34552   34406 -146 
   - Misses   59326117 +185
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7307?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/google/cloud/hooks/gcs.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2djcy5weQ==)
 | `85.51% <100%> (+0.53%)` | :arrow_up: |
   | 
[airflow/providers/google/cloud/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9nY3MucHk=)
 | `86.44% <100%> (+0.81%)` | :arrow_up: |
   | 
[...providers/google/cloud/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2djcy5weQ==)
 | `96.29% <89.47%> (-3.71%)` | :arrow_down: |
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.51% <0%> (-72.16%)` | :arrow_down: |
   | 
[airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=)
 | `28.16% <0%> (-54.93%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50% <0%> (-50%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0%> (-46.67%)` | :arrow_down: |
   | 
[airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5)
 | `49.65% <0%> (-38.78%)` | :arrow_down: |
   | 
[airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=)
 | `61.53% <0%> (-38.47%)` | :arrow_down: |
   | 
[airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5)
 | `85% <0%> (-8.34%)` | :arrow_down: |
   | ... and [2 
more](https://codecov.io/gh/apache/airflow/pull/7307/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7307?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7307?src=pr=footer). 
Last update 
[a2d6a2f...06a05ef](https://codecov.io/gh/apache/airflow/pull/7307?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7251: [AIRFLOW-6628] Fix search auto complete behaviour

[GitBox]

ashb commented on a change in pull request #7251: [AIRFLOW-6628] Fix search 
auto complete behaviour
URL: https://github.com/apache/airflow/pull/7251#discussion_r373688156
 
 

 ##
 File path: airflow/www/views.py
 ##
 @@ -325,10 +319,36 @@ def get_int_arg(value, default=0):
 paging=wwwutils.generate_pages(current_page, num_of_pages,
search=escape(arg_search_query) if 
arg_search_query else None,
showPaused=not hide_paused),
-auto_complete_data=auto_complete_data,
 num_runs=num_runs,
 tags=tags)
 
+@expose('/dag_autocomplete')
+@has_access
 
 Review comment:
   For the record: I am not a fan of each view being a new permission; instead 
I am of the view that permissions should be about operations/concepts - so can 
list, can get details etc -> I can see no reason why you might want to view 
details/list a dag but not have it show up in the auto complete list for 
instance
   
   (Not saying change this now, but if we re-think the permissions for the API 
work)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on a change in pull request #7315: [AIRFLOW-6699] Parameterize weekday_sensor tests

[GitBox]

coopergillan commented on a change in pull request #7315: [AIRFLOW-6699] 
Parameterize weekday_sensor tests
URL: https://github.com/apache/airflow/pull/7315#discussion_r373684134
 
 

 ##
 File path: tests/sensors/test_weekday_sensor.py
 ##
 @@ -33,130 +33,91 @@
 WEEKEND_DATE = datetime(2018, 12, 22)
 TEST_DAG_ID = 'weekday_sensor_dag'
 DEV_NULL = '/dev/null'
-
-
-class TestDayOfWeekSensor(unittest.TestCase):
-
-def setUp(self):
-self.dagbag = DagBag(
-dag_folder=DEV_NULL,
-include_examples=True
-)
-self.args = {
-'owner': 'airflow',
-'start_date': DEFAULT_DATE
-}
-dag = DAG(TEST_DAG_ID, default_args=self.args)
-self.dag = dag
-
-def tearDown(self):
-session = Session()
-session.query(models.TaskInstance).filter_by(
-dag_id=TEST_DAG_ID).delete()
-session.query(TaskFail).filter_by(
-dag_id=TEST_DAG_ID).delete()
-session.commit()
-session.close()
-
-def test_weekday_sensor_true(self):
-op = DayOfWeekSensor(
-task_id='weekday_sensor_check_true',
-week_day='Thursday',
-use_task_execution_day=True,
-dag=self.dag)
+TRUE_TESTS_CONFIG = {
+"string": "Thursday",
+"enum": WeekDay.THURSDAY,
+"enum-set": {WeekDay.THURSDAY},
+"enum-set-2-items": {WeekDay.THURSDAY, WeekDay.FRIDAY},
+"string-set": {'Thursday'},
+"string-set-2-items": {'Thursday', 'Friday'},
+}
+
+
+@pytest.fixture
+def dag():
+args = {"owner": "airflow", "start_date": DEFAULT_DATE}
+return DAG(TEST_DAG_ID, default_args=args)
+
+
+@pytest.fixture
+def tear_down():
+yield
+
+session = Session()
+session.query(models.TaskInstance).filter_by(
+dag_id=TEST_DAG_ID).delete()
+session.query(TaskFail).filter_by(
+dag_id=TEST_DAG_ID).delete()
+session.commit()
+session.close()
+
+
+@pytest.mark.parametrize("weekday", TRUE_TESTS_CONFIG.values(), 
ids=list(TRUE_TESTS_CONFIG.keys()))
+def test_weekday_sensor_true(dag, weekday, tear_down):
+op = DayOfWeekSensor(
+task_id="weekday_sensor_check_true",
 
 Review comment:
   Ah, that makes sense. Thank you for the heads up 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7315: [AIRFLOW-6699] Parameterize weekday_sensor tests

[GitBox]

mik-laj commented on a change in pull request #7315: [AIRFLOW-6699] 
Parameterize weekday_sensor tests
URL: https://github.com/apache/airflow/pull/7315#discussion_r373683785
 
 

 ##
 File path: tests/sensors/test_weekday_sensor.py
 ##
 @@ -33,130 +33,91 @@
 WEEKEND_DATE = datetime(2018, 12, 22)
 TEST_DAG_ID = 'weekday_sensor_dag'
 DEV_NULL = '/dev/null'
-
-
-class TestDayOfWeekSensor(unittest.TestCase):
-
-def setUp(self):
-self.dagbag = DagBag(
-dag_folder=DEV_NULL,
-include_examples=True
-)
-self.args = {
-'owner': 'airflow',
-'start_date': DEFAULT_DATE
-}
-dag = DAG(TEST_DAG_ID, default_args=self.args)
-self.dag = dag
-
-def tearDown(self):
-session = Session()
-session.query(models.TaskInstance).filter_by(
-dag_id=TEST_DAG_ID).delete()
-session.query(TaskFail).filter_by(
-dag_id=TEST_DAG_ID).delete()
-session.commit()
-session.close()
-
-def test_weekday_sensor_true(self):
-op = DayOfWeekSensor(
-task_id='weekday_sensor_check_true',
-week_day='Thursday',
-use_task_execution_day=True,
-dag=self.dag)
+TRUE_TESTS_CONFIG = {
+"string": "Thursday",
+"enum": WeekDay.THURSDAY,
+"enum-set": {WeekDay.THURSDAY},
+"enum-set-2-items": {WeekDay.THURSDAY, WeekDay.FRIDAY},
+"string-set": {'Thursday'},
+"string-set-2-items": {'Thursday', 'Friday'},
+}
+
+
+@pytest.fixture
+def dag():
+args = {"owner": "airflow", "start_date": DEFAULT_DATE}
+return DAG(TEST_DAG_ID, default_args=args)
+
+
+@pytest.fixture
+def tear_down():
+yield
+
+session = Session()
+session.query(models.TaskInstance).filter_by(
+dag_id=TEST_DAG_ID).delete()
+session.query(TaskFail).filter_by(
+dag_id=TEST_DAG_ID).delete()
+session.commit()
+session.close()
+
+
+@pytest.mark.parametrize("weekday", TRUE_TESTS_CONFIG.values(), 
ids=list(TRUE_TESTS_CONFIG.keys()))
+def test_weekday_sensor_true(dag, weekday, tear_down):
+op = DayOfWeekSensor(
+task_id="weekday_sensor_check_true",
 
 Review comment:
   It is necessary to use classes in tests. More information: 
https://lists.apache.org/thread.html/1e4df7d4b0cd9b2d2bb76a3336471aa85e852545dd41ada6d4e461b8%40%3Cdev.airflow.apache.org%3E
 (question 5)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7315: [AIRFLOW-6699] Parameterize weekday_sensor tests

[GitBox]

mik-laj commented on a change in pull request #7315: [AIRFLOW-6699] 
Parameterize weekday_sensor tests
URL: https://github.com/apache/airflow/pull/7315#discussion_r373683785
 
 

 ##
 File path: tests/sensors/test_weekday_sensor.py
 ##
 @@ -33,130 +33,91 @@
 WEEKEND_DATE = datetime(2018, 12, 22)
 TEST_DAG_ID = 'weekday_sensor_dag'
 DEV_NULL = '/dev/null'
-
-
-class TestDayOfWeekSensor(unittest.TestCase):
-
-def setUp(self):
-self.dagbag = DagBag(
-dag_folder=DEV_NULL,
-include_examples=True
-)
-self.args = {
-'owner': 'airflow',
-'start_date': DEFAULT_DATE
-}
-dag = DAG(TEST_DAG_ID, default_args=self.args)
-self.dag = dag
-
-def tearDown(self):
-session = Session()
-session.query(models.TaskInstance).filter_by(
-dag_id=TEST_DAG_ID).delete()
-session.query(TaskFail).filter_by(
-dag_id=TEST_DAG_ID).delete()
-session.commit()
-session.close()
-
-def test_weekday_sensor_true(self):
-op = DayOfWeekSensor(
-task_id='weekday_sensor_check_true',
-week_day='Thursday',
-use_task_execution_day=True,
-dag=self.dag)
+TRUE_TESTS_CONFIG = {
+"string": "Thursday",
+"enum": WeekDay.THURSDAY,
+"enum-set": {WeekDay.THURSDAY},
+"enum-set-2-items": {WeekDay.THURSDAY, WeekDay.FRIDAY},
+"string-set": {'Thursday'},
+"string-set-2-items": {'Thursday', 'Friday'},
+}
+
+
+@pytest.fixture
+def dag():
+args = {"owner": "airflow", "start_date": DEFAULT_DATE}
+return DAG(TEST_DAG_ID, default_args=args)
+
+
+@pytest.fixture
+def tear_down():
+yield
+
+session = Session()
+session.query(models.TaskInstance).filter_by(
+dag_id=TEST_DAG_ID).delete()
+session.query(TaskFail).filter_by(
+dag_id=TEST_DAG_ID).delete()
+session.commit()
+session.close()
+
+
+@pytest.mark.parametrize("weekday", TRUE_TESTS_CONFIG.values(), 
ids=list(TRUE_TESTS_CONFIG.keys()))
+def test_weekday_sensor_true(dag, weekday, tear_down):
+op = DayOfWeekSensor(
+task_id="weekday_sensor_check_true",
 
 Review comment:
   It is necessary to use classes in tests. More information: 
https://lists.apache.org/thread.html/1e4df7d4b0cd9b2d2bb76a3336471aa85e852545dd41ada6d4e461b8%40%3Cdev.airflow.apache.org%3E


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7307: [AIRFLOW-6676] added GCSDeleteBucketOperator

[GitBox]

mik-laj commented on a change in pull request #7307: [AIRFLOW-6676] added 
GCSDeleteBucketOperator
URL: https://github.com/apache/airflow/pull/7307#discussion_r373682965
 
 

 ##
 File path: airflow/providers/google/cloud/example_dags/example_gcs.py
 ##
 @@ -127,7 +128,32 @@
 task_id="delete_files", bucket_name=BUCKET_1, 
objects=[BUCKET_FILE_LOCATION]
 )
 
+# [START howto_operator_gcs_delete_bucket]
+delete_bucket_1 = GCSDeleteBucketOperator(task_id="delete_bucket", 
bucket_name=BUCKET_1)
+delete_bucket_2 = GCSDeleteBucketOperator(task_id="delete_bucket", 
bucket_name=BUCKET_2)
+# [END howto_operator_gcs_delete_bucket]
+
 [create_bucket1, create_bucket2] >> list_buckets >> list_buckets_result
 [create_bucket1, create_bucket2] >> upload_file
 upload_file >> [download_file, copy_file]
 upload_file >> gcs_bucket_create_acl_entry_task >> 
gcs_object_create_acl_entry_task >> delete_files
+
+create_bucket1 >> delete_bucket_1
+create_bucket2 >> delete_bucket_2
+create_bucket2 >> copy_file
+create_bucket1 >> copy_file
+list_buckets >> delete_bucket_1
+upload_file >> delete_bucket_1
+create_bucket1 >> upload_file >> delete_bucket_1
+transform_file >> delete_bucket_1
+gcs_bucket_create_acl_entry_task >> delete_bucket_1
+gcs_object_create_acl_entry_task >> delete_bucket_1
+download_file >> delete_bucket_1
+copy_file >> delete_bucket_1
+copy_file >> delete_bucket_2
+delete_files >> delete_bucket_1
 
 Review comment:
   The previous version was incorrect in a few cases. This can be simplified if 
you look at the fact that some of the requirements are included in others, but 
the current version makes it easier to understand the relationship between 
tasks. I note that in Airflow we define requirements and Airflow can 
automatically detect redundancy and optimize it. If there is something the 
computer can do, the computer should do it.
   
   I'm worried about task `transform_file`, which has no upstream dependencies, 
so so this task can be executed before the bucket is created.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6699) Parameterize weekday sensor tests

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027825#comment-17027825
 ] 

ASF GitHub Bot commented on AIRFLOW-6699:
-

coopergillan commented on pull request #7315: [AIRFLOW-6699] Parameterize 
weekday_sensor tests
URL: https://github.com/apache/airflow/pull/7315
 
 
   Using `pytest`, consolidate the "True" or "happy path" tests into one 
parameterized test that uses a new TRUE_TESTS_CONFIG to drive test names and 
the `week_day` parameter.
   
   Update all tests to use `pytest`, including regex matching on the failing 
tests as needed.
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Parameterize weekday sensor tests
> -
>
> Key: AIRFLOW-6699
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6699
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: tests
>Affects Versions: 1.10.7
>Reporter: Cooper Gillan
>Assignee: Cooper Gillan
>Priority: Minor
>
> Many of the arguments for the true tests in 
> tests/sensors/test_weekday_sensor.py are repeated. The tests are also running 
> with unittest.TestCase rather than pytest.
> Make use of pytest's parametrize functionality to use the same base tests for 
> true tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] coopergillan opened a new pull request #7315: [AIRFLOW-6699] Parameterize weekday_sensor tests

[GitBox]

coopergillan opened a new pull request #7315: [AIRFLOW-6699] Parameterize 
weekday_sensor tests
URL: https://github.com/apache/airflow/pull/7315
 
 
   Using `pytest`, consolidate the "True" or "happy path" tests into one 
parameterized test that uses a new TRUE_TESTS_CONFIG to drive test names and 
the `week_day` parameter.
   
   Update all tests to use `pytest`, including regex matching on the failing 
tests as needed.
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7307: [AIRFLOW-6676] added GCSDeleteBucketOperator

[GitBox]

nuclearpinguin commented on a change in pull request #7307: [AIRFLOW-6676] 
added GCSDeleteBucketOperator
URL: https://github.com/apache/airflow/pull/7307#discussion_r373679194
 
 

 ##
 File path: airflow/providers/google/cloud/operators/gcs.py
 ##
 @@ -625,3 +625,32 @@ def execute(self, context: Dict):
 object_name=self.destination_object,
 filename=destination_file.name
 )
+
+
+class GCSDeleteBucketOperator(BaseOperator):
+"""
+Deletes bucket from a Google Cloud Storage.
+
+.. seealso::
+For more information on how to use this operator, take a look at the 
guide:
+:ref:`howto/operator:GCSDeleteBucketOperator`
+
+:param bucket_name: name of the bucket which will be deleted
+:type bucket_name: str
+"""
+
+template_fields = ('bucket_name', "gcp_conn_id")
+
+@apply_defaults
+def __init__(self,
+ bucket_name: str,
 
 Review comment:
   ```suggestion
bucket_name: str,
force: bool = True,
   ```
   It's good idea to add this option to operator. In my opinion it should 
default to `True`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7307: [AIRFLOW-6676] added GCSDeleteBucketOperator

[GitBox]

nuclearpinguin commented on a change in pull request #7307: [AIRFLOW-6676] 
added GCSDeleteBucketOperator
URL: https://github.com/apache/airflow/pull/7307#discussion_r373679320
 
 

 ##
 File path: airflow/providers/google/cloud/operators/gcs.py
 ##
 @@ -625,3 +625,32 @@ def execute(self, context: Dict):
 object_name=self.destination_object,
 filename=destination_file.name
 )
+
+
+class GCSDeleteBucketOperator(BaseOperator):
+"""
+Deletes bucket from a Google Cloud Storage.
+
+.. seealso::
+For more information on how to use this operator, take a look at the 
guide:
+:ref:`howto/operator:GCSDeleteBucketOperator`
+
+:param bucket_name: name of the bucket which will be deleted
+:type bucket_name: str
+"""
+
+template_fields = ('bucket_name', "gcp_conn_id")
+
+@apply_defaults
+def __init__(self,
+ bucket_name: str,
+ gcp_conn_id: str = 'google_cloud_default',
+ *args, **kwargs) -> None:
+super().__init__(*args, **kwargs)
+
+self.bucket_name = bucket_name
+self.gcp_conn_id = gcp_conn_id
+
+def execute(self, context):
+hook = GCSHook(gcp_conn_id=self.gcp_conn_id, )
+hook.delete_bucket(self.bucket_name)
 
 Review comment:
   ```suggestion
   hook.delete_bucket(bucket_name=self.bucket_name, force=self.force)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7307: [AIRFLOW-6676] added GCSDeleteBucketOperator

[GitBox]

nuclearpinguin commented on a change in pull request #7307: [AIRFLOW-6676] 
added GCSDeleteBucketOperator
URL: https://github.com/apache/airflow/pull/7307#discussion_r373678646
 
 

 ##
 File path: airflow/providers/google/cloud/hooks/gcs.py
 ##
 @@ -323,6 +324,27 @@ def delete(self, bucket_name, object_name):
 
 self.log.info('Blob %s deleted.', object_name)
 
+def delete_bucket(self, bucket_name: str, force: bool = False):
+"""
+Delete a bucket object from the Google Cloud Storage
 
 Review comment:
   ```suggestion
   Delete a bucket object from the Google Cloud Storage.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7307: [AIRFLOW-6676] added GCSDeleteBucketOperator

[GitBox]

nuclearpinguin commented on a change in pull request #7307: [AIRFLOW-6676] 
added GCSDeleteBucketOperator
URL: https://github.com/apache/airflow/pull/7307#discussion_r373678546
 
 

 ##
 File path: airflow/providers/google/cloud/example_dags/example_gcs.py
 ##
 @@ -127,7 +128,32 @@
 task_id="delete_files", bucket_name=BUCKET_1, 
objects=[BUCKET_FILE_LOCATION]
 )
 
+# [START howto_operator_gcs_delete_bucket]
+delete_bucket_1 = GCSDeleteBucketOperator(task_id="delete_bucket", 
bucket_name=BUCKET_1)
+delete_bucket_2 = GCSDeleteBucketOperator(task_id="delete_bucket", 
bucket_name=BUCKET_2)
+# [END howto_operator_gcs_delete_bucket]
+
 [create_bucket1, create_bucket2] >> list_buckets >> list_buckets_result
 [create_bucket1, create_bucket2] >> upload_file
 upload_file >> [download_file, copy_file]
 upload_file >> gcs_bucket_create_acl_entry_task >> 
gcs_object_create_acl_entry_task >> delete_files
+
+create_bucket1 >> delete_bucket_1
+create_bucket2 >> delete_bucket_2
+create_bucket2 >> copy_file
+create_bucket1 >> copy_file
+list_buckets >> delete_bucket_1
+upload_file >> delete_bucket_1
+create_bucket1 >> upload_file >> delete_bucket_1
+transform_file >> delete_bucket_1
+gcs_bucket_create_acl_entry_task >> delete_bucket_1
+gcs_object_create_acl_entry_task >> delete_bucket_1
+download_file >> delete_bucket_1
+copy_file >> delete_bucket_1
+copy_file >> delete_bucket_2
+delete_files >> delete_bucket_1
 
 Review comment:
   Can it be simplified? I think the previous version was much more clearer.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7311: [AIRFLOW-XXXX] Fix email configuration link in CONTRIBUTING.rst

[GitBox]

mik-laj commented on issue #7311: [AIRFLOW-] Fix email configuration link 
in CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7311#issuecomment-580904231
 
 
   Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #7311: [AIRFLOW-XXXX] Fix email configuration link in CONTRIBUTING.rst

[GitBox]

mik-laj merged pull request #7311: [AIRFLOW-] Fix email configuration link 
in CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7311
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7310: [AIRFLOW-XXXX] Fix email configuration link in CONTRIBUTING.rst

[GitBox]

mik-laj commented on issue #7310: [AIRFLOW-] Fix email configuration link 
in CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7310#issuecomment-580903871
 
 
   Hi. This change seems valuable to me. Why did you close this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (AIRFLOW-6699) Parameterize weekday sensor tests

[Cooper Gillan (Jira)]

Cooper Gillan created AIRFLOW-6699:
--

 Summary: Parameterize weekday sensor tests
 Key: AIRFLOW-6699
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6699
 Project: Apache Airflow
  Issue Type: Improvement
  Components: tests
Affects Versions: 1.10.7
Reporter: Cooper Gillan
Assignee: Cooper Gillan


Many of the arguments for the true tests in 
tests/sensors/test_weekday_sensor.py are repeated. The tests are also running 
with unittest.TestCase rather than pytest.

Make use of pytest's parametrize functionality to use the same base tests for 
true tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] mik-laj commented on a change in pull request #7309: [AIRFLOW-4681] Make sensors module pylint compatible

[GitBox]

mik-laj commented on a change in pull request #7309: [AIRFLOW-4681] Make 
sensors module pylint compatible
URL: https://github.com/apache/airflow/pull/7309#discussion_r373676561
 
 

 ##
 File path: airflow/providers/jira/sensors/jira.py
 ##
 @@ -68,7 +68,7 @@ class JiraTicketSensor(JiraSensor):
 
 :param jira_conn_id: reference to a pre-defined Jira Connection
 :type jira_conn_id: str
-:param ticket_id: id of the ticket to be monitored
+state:param ticket_id: id of the ticket to be monitored
 
 Review comment:
   ```suggestion
   :param ticket_id: id of the ticket to be monitored
   ```
   Travis is sad without this change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6157) Separate out executor protocol

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027812#comment-17027812
 ] 

ASF GitHub Bot commented on AIRFLOW-6157:
-

potiuk commented on pull request #6760: [AIRFLOW-6157] Separate out common 
protocol for executors.
URL: https://github.com/apache/airflow/pull/6760
 
 
   Some of the fields of executors are accessed directly in the main core. The
   protocol for executor can be extracted and used in all places where executors
   are used. 
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
 - https://issues.apache.org/jira/browse/AIRFLOW-XXX
 - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
 - In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
 - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
 1. Subject is separated from body by a blank line
 1. Subject is limited to 50 characters (not including Jira issue reference)
 1. Subject does not end with a period
 1. Subject uses the imperative mood ("add", not "adding")
 1. Body wraps at 72 characters
 1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
 - All the public functions and the classes in the PR contain docstrings 
that explain what it does
 - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Separate out executor protocol
> --
>
> Key: AIRFLOW-6157
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6157
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 2.0.0
>Reporter: Jarek Potiuk
>Assignee: Jarek Potiuk
>Priority: Major
>
> Some of the fields of executors are accessed directly in the main core. The 
> protocol for executor can be extracted and used in all places where executors 
> are used. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] potiuk opened a new pull request #6760: [AIRFLOW-6157] Separate out common protocol for executors.

[GitBox]

potiuk opened a new pull request #6760: [AIRFLOW-6157] Separate out common 
protocol for executors.
URL: https://github.com/apache/airflow/pull/6760
 
 
   Some of the fields of executors are accessed directly in the main core. The
   protocol for executor can be extracted and used in all places where executors
   are used. 
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
 - https://issues.apache.org/jira/browse/AIRFLOW-XXX
 - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
 - In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
 - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
 1. Subject is separated from body by a blank line
 1. Subject is limited to 50 characters (not including Jira issue reference)
 1. Subject does not end with a period
 1. Subject uses the imperative mood ("add", not "adding")
 1. Body wraps at 72 characters
 1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
 - All the public functions and the classes in the PR contain docstrings 
that explain what it does
 - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6157) Separate out executor protocol

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027811#comment-17027811
 ] 

ASF GitHub Bot commented on AIRFLOW-6157:
-

stale[bot] commented on pull request #6760: [AIRFLOW-6157] Separate out common 
protocol for executors.
URL: https://github.com/apache/airflow/pull/6760
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Separate out executor protocol
> --
>
> Key: AIRFLOW-6157
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6157
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 2.0.0
>Reporter: Jarek Potiuk
>Assignee: Jarek Potiuk
>Priority: Major
>
> Some of the fields of executors are accessed directly in the main core. The 
> protocol for executor can be extracted and used in all places where executors 
> are used. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] stale[bot] closed pull request #6760: [AIRFLOW-6157] Separate out common protocol for executors.

[GitBox]

stale[bot] closed pull request #6760: [AIRFLOW-6157] Separate out common 
protocol for executors.
URL: https://github.com/apache/airflow/pull/6760
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] houqp commented on issue #7238: [AIRFLOW-6613] center dag on graph view load

[GitBox]

houqp commented on issue #7238: [AIRFLOW-6613] center dag on graph view load
URL: https://github.com/apache/airflow/pull/7238#issuecomment-580902356
 
 
   @ashb rebased on latest master, let me know what else i can help to get this 
merged into master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #7308: [AIRFLOW-XXXX] Update GitLab team members

[GitBox]

mik-laj merged pull request #7308: [AIRFLOW-] Update GitLab team members
URL: https://github.com/apache/airflow/pull/7308
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7308: Update GitLab team members

[GitBox]

mik-laj commented on issue #7308: Update GitLab team members
URL: https://github.com/apache/airflow/pull/7308#issuecomment-580900389
 
 
   Title Validator and Mergeable are sad. Can you fix it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj removed a comment on issue #7308: Update GitLab team members

[GitBox]

mik-laj removed a comment on issue #7308: Update GitLab team members
URL: https://github.com/apache/airflow/pull/7308#issuecomment-580900389
 
 
   Title Validator and Mergeable are sad. Can you fix it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (AIRFLOW-4681) Make airflow/sensors Pylint compatible

[Kamil Bregula (Jira)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamil Bregula resolved AIRFLOW-4681.

Resolution: Won't Do

> Make airflow/sensors Pylint compatible
> --
>
> Key: AIRFLOW-4681
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4681
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: pylint
>Affects Versions: 2.0.0
>Reporter: Bas Harenslak
>Assignee: Kamil Bregula
>Priority: Major
>
> Fix all Pylint messages in airflow/sensors. To start; running 
> scripts/ci/ci_pylint.sh on master should produce no messages. (1) Remove the 
> files mentioned in your issue from the blacklist. (2) Run 
> scripts/ci/ci_pylint.sh to see all messages on the no longer blacklisted 
> files. (3) Fix all messages and create PR.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] mik-laj commented on issue #5406: [AIRFLOW-4681] Fix pylint problems for sensors module

[GitBox]

mik-laj commented on issue #5406: [AIRFLOW-4681] Fix pylint problems for 
sensors module
URL: https://github.com/apache/airflow/pull/5406#issuecomment-580898809
 
 
   Too many conflicts. I will start from scratch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj closed pull request #5406: [AIRFLOW-4681] Fix pylint problems for sensors module

[GitBox]

mik-laj closed pull request #5406: [AIRFLOW-4681] Fix pylint problems for 
sensors module
URL: https://github.com/apache/airflow/pull/5406
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4681) Make airflow/sensors Pylint compatible

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027805#comment-17027805
 ] 

ASF GitHub Bot commented on AIRFLOW-4681:
-

mik-laj commented on pull request #5406: [AIRFLOW-4681] Fix pylint problems for 
sensors module
URL: https://github.com/apache/airflow/pull/5406
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Make airflow/sensors Pylint compatible
> --
>
> Key: AIRFLOW-4681
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4681
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: pylint
>Affects Versions: 2.0.0
>Reporter: Bas Harenslak
>Assignee: Kamil Bregula
>Priority: Major
>
> Fix all Pylint messages in airflow/sensors. To start; running 
> scripts/ci/ci_pylint.sh on master should produce no messages. (1) Remove the 
> files mentioned in your issue from the blacklist. (2) Run 
> scripts/ci/ci_pylint.sh to see all messages on the no longer blacklisted 
> files. (3) Fix all messages and create PR.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6697) Base date and Search in Graph view don't dim when modal activate

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027803#comment-17027803
 ] 

ASF subversion and git services commented on AIRFLOW-6697:
--

Commit 83adfbe086624718ea7e51e11d8d3702e31cb53a in airflow's branch 
refs/heads/master from JCoder01
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=83adfbe ]

[AIRFLOW-6697] fix modal_backdrop z-index (#7313)



> Base date and Search in Graph view don't dim when modal activate
> 
>
> Key: AIRFLOW-6697
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6697
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: ui
>Affects Versions: 1.10.7
>Reporter: James Coder
>Assignee: James Coder
>Priority: Minor
> Attachments: image-2020-01-31-13-46-57-069.png
>
>
> !image-2020-01-31-13-46-57-069.png|width=972,height=431!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6697) Base date and Search in Graph view don't dim when modal activate

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027802#comment-17027802
 ] 

ASF GitHub Bot commented on AIRFLOW-6697:
-

bolkedebruin commented on pull request #7313: [AIRFLOW-6697] fix modal_backdrop 
z-index
URL: https://github.com/apache/airflow/pull/7313
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Base date and Search in Graph view don't dim when modal activate
> 
>
> Key: AIRFLOW-6697
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6697
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: ui
>Affects Versions: 1.10.7
>Reporter: James Coder
>Assignee: James Coder
>Priority: Minor
> Attachments: image-2020-01-31-13-46-57-069.png
>
>
> !image-2020-01-31-13-46-57-069.png|width=972,height=431!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] bolkedebruin merged pull request #7313: [AIRFLOW-6697] fix modal_backdrop z-index

[GitBox]

bolkedebruin merged pull request #7313: [AIRFLOW-6697] fix modal_backdrop 
z-index
URL: https://github.com/apache/airflow/pull/7313
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6698) Allow shorthand notation

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027796#comment-17027796
 ] 

ASF GitHub Bot commented on AIRFLOW-6698:
-

bolkedebruin commented on pull request #7314: [AIRFLOW-6698] Add shorthand 
notation for lineage
URL: https://github.com/apache/airflow/pull/7314
 
 
   This adds shorthand notation to define dags that have lineage
   support. | for piping between operators and > and < for setting
   (static) lineage defintions.
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   @potiuk 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow shorthand notation
> 
>
> Key: AIRFLOW-6698
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6698
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: lineage
>Affects Versions: 1.10.7
>Reporter: Bolke de Bruin
>Priority: Major
> Fix For: 1.10.8
>
>
> Shorthand notation makes it a lot easier to define dags with lineage support



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] bolkedebruin opened a new pull request #7314: [AIRFLOW-6698] Add shorthand notation for lineage

[GitBox]

bolkedebruin opened a new pull request #7314: [AIRFLOW-6698] Add shorthand 
notation for lineage
URL: https://github.com/apache/airflow/pull/7314
 
 
   This adds shorthand notation to define dags that have lineage
   support. | for piping between operators and > and < for setting
   (static) lineage defintions.
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   @potiuk 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6697) Base date and Search in Graph view don't dim when modal activate

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027793#comment-17027793
 ] 

ASF GitHub Bot commented on AIRFLOW-6697:
-

JCoder01 commented on pull request #7313: [AIRFLOW-6697] fix modal_backdrop 
z-index
URL: https://github.com/apache/airflow/pull/7313
 
 
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   change modal-backdrop z index to cover Base dag and Search input boxes in 
graph view.
   
   Before:
   
![image](https://user-images.githubusercontent.com/651639/73570931-68c93f00-443b-11ea-8e10-92f6052c9a17.png)
   
   After:
   
   
![image](https://user-images.githubusercontent.com/651639/73570954-754d9780-443b-11ea-9c09-5bbbedc807a0.png)
   
   
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Base date and Search in Graph view don't dim when modal activate
> 
>
> Key: AIRFLOW-6697
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6697
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: ui
>Affects Versions: 1.10.7
>Reporter: James Coder
>Assignee: James Coder
>Priority: Minor
> Attachments: image-2020-01-31-13-46-57-069.png
>
>
> !image-2020-01-31-13-46-57-069.png|width=972,height=431!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] JCoder01 commented on issue #7313: [AIRFLOW-6697] fix modal_backdrop z-index

[GitBox]

JCoder01 commented on issue #7313: [AIRFLOW-6697] fix modal_backdrop z-index
URL: https://github.com/apache/airflow/pull/7313#issuecomment-580891847
 
 
   I don't think tests are needed as this is just a change to a css file.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] JCoder01 opened a new pull request #7313: [AIRFLOW-6697] fix modal_backdrop z-index

[GitBox]

JCoder01 opened a new pull request #7313: [AIRFLOW-6697] fix modal_backdrop 
z-index
URL: https://github.com/apache/airflow/pull/7313
 
 
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   change modal-backdrop z index to cover Base dag and Search input boxes in 
graph view.
   
   Before:
   
![image](https://user-images.githubusercontent.com/651639/73570931-68c93f00-443b-11ea-8e10-92f6052c9a17.png)
   
   After:
   
   
![image](https://user-images.githubusercontent.com/651639/73570954-754d9780-443b-11ea-9c09-5bbbedc807a0.png)
   
   
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (AIRFLOW-6697) Base date and Search in Graph view don't dim when modal activate

[James Coder (Jira)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Coder updated AIRFLOW-6697:
-
Description: !image-2020-01-31-13-46-57-069.png|width=972,height=431!  
(was: !image-2020-01-31-13-46-57-069.png!)

> Base date and Search in Graph view don't dim when modal activate
> 
>
> Key: AIRFLOW-6697
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6697
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: ui
>Affects Versions: 1.10.7
>Reporter: James Coder
>Assignee: James Coder
>Priority: Minor
> Attachments: image-2020-01-31-13-46-57-069.png
>
>
> !image-2020-01-31-13-46-57-069.png|width=972,height=431!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] larryzhu2018 commented on issue #7141: [AIRFLOW-6544] add log_id to end_of_log mark log record

[GitBox]

larryzhu2018 commented on issue #7141: [AIRFLOW-6544] add log_id to end_of_log 
mark log record
URL: https://github.com/apache/airflow/pull/7141#issuecomment-580890427
 
 
   Correct
   
   Get Outlook for iOS
   
   From: Jacob Ward 
   Sent: Friday, January 31, 2020 4:48:04 AM
   To: apache/airflow 
   Cc: larryzhu2018 ; Mention 
   Subject: Re: [apache/airflow] [AIRFLOW-6544] add log_id to end_of_log mark 
log record (#7141)
   
   
   @jward-bw commented on this pull request.
   
   
   
   In 
airflow/utils/log/es_task_handler.py:
   
   >  def __init__(self, base_log_folder, filename_template,
 log_id_template, end_of_log_mark,
 write_stdout, json_format, json_fields,
   + index='*',
   
   
   Just to check * will match all indexes? I am working with an ES cluster 
where we have a new index every day
   
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on 
GitHub,
 or 
unsubscribe.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (AIRFLOW-6697) Base date and Search in Graph view don't dim when modal activate

[James Coder (Jira)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Coder updated AIRFLOW-6697:
-
Priority: Minor  (was: Major)

> Base date and Search in Graph view don't dim when modal activate
> 
>
> Key: AIRFLOW-6697
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6697
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: ui
>Affects Versions: 1.10.7
>Reporter: James Coder
>Assignee: James Coder
>Priority: Minor
> Attachments: image-2020-01-31-13-46-57-069.png
>
>
> !image-2020-01-31-13-46-57-069.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (AIRFLOW-6698) Allow shorthand notation

[Bolke de Bruin (Jira)]

Bolke de Bruin created AIRFLOW-6698:
---

 Summary: Allow shorthand notation
 Key: AIRFLOW-6698
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6698
 Project: Apache Airflow
  Issue Type: Sub-task
  Components: lineage
Affects Versions: 1.10.7
Reporter: Bolke de Bruin
 Fix For: 1.10.8


Shorthand notation makes it a lot easier to define dags with lineage support



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] coopergillan commented on issue #7309: [AIRFLOW-4681] Make sensors module pylint compatible

[GitBox]

coopergillan commented on issue #7309: [AIRFLOW-4681] Make sensors module 
pylint compatible
URL: https://github.com/apache/airflow/pull/7309#issuecomment-580881834
 
 
   I did see https://github.com/apache/airflow/pull/5406, but noticed that it 
had been dormant for some time. I wanted to give it a shot from a fresh pull of 
`master`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6695) Support passing DAG configuration in UI

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027741#comment-17027741
 ] 

ASF GitHub Bot commented on AIRFLOW-6695:
-

dacohen commented on pull request #7312: [AIRFLOW-6695] Add DAG run 
configuration to UI
URL: https://github.com/apache/airflow/pull/7312
 
 
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support passing DAG configuration in UI
> ---
>
> Key: AIRFLOW-6695
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6695
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: ui
>Affects Versions: master
>Reporter: Daniel Cohen
>Priority: Minor
>
> When triggering a DAG from the CLI or the REST API, it's possible to pass 
> configuration for the DAG run as a JSON blob.
> The PR accompanying this ticket adds a new screen confirming the trigger 
> request, and allowing the user to pass a JSON configuration blob to the new 
> DAG run.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] dacohen opened a new pull request #7312: [AIRFLOW-6695] Add DAG run configuration to UI

[GitBox]

dacohen opened a new pull request #7312: [AIRFLOW-6695] Add DAG run 
configuration to UI
URL: https://github.com/apache/airflow/pull/7312
 
 
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-3007) Scheduler docs use deprecated use of `schedule_interval`

[Kaxil Naik (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027734#comment-17027734
 ] 

Kaxil Naik commented on AIRFLOW-3007:
-

[~matjazmav] You might be passing *schedule_interval* in *default_args* or 
passing in *task*. You should only set it on DAG level

> Scheduler docs use deprecated use of `schedule_interval` 
> -
>
> Key: AIRFLOW-3007
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3007
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Kaxil Naik
>Assignee: Kaxil Naik
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: screenshot-1.png
>
>
> The scheduler docs at 
> https://airflow.apache.org/scheduler.html#backfill-and-catchup use deprecated 
> way of passing {{schedule_interval}} . {{schedule_interval}}  should be pass 
> to DAG as a separate parameter and not as a default arg.
>  !screenshot-1.png! 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (AIRFLOW-6697) Base date and Search in Graph view don't dim when modal activate

[James Coder (Jira)]

James Coder created AIRFLOW-6697:


 Summary: Base date and Search in Graph view don't dim when modal 
activate
 Key: AIRFLOW-6697
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6697
 Project: Apache Airflow
  Issue Type: Bug
  Components: ui
Affects Versions: 1.10.7
Reporter: James Coder
Assignee: James Coder
 Attachments: image-2020-01-31-13-46-57-069.png

!image-2020-01-31-13-46-57-069.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] coopergillan opened a new pull request #7311: [AIRFLOW-XXXX] Fix email configuration link in CONTRIBUTING.rst

[GitBox]

coopergillan opened a new pull request #7311: [AIRFLOW-] Fix email 
configuration link in CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7311
 
 
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan closed pull request #7310: [AIRFLOW-XXXX] Fix email configuration link in CONTRIBUTING.rst

[GitBox]

coopergillan closed pull request #7310: [AIRFLOW-] Fix email configuration 
link in CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7310
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan closed pull request #7310: [AIRFLOW-XXXX] Fix email configuration link in CONTRIBUTING.rst

[GitBox]

coopergillan closed pull request #7310: [AIRFLOW-] Fix email configuration 
link in CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7310
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan opened a new pull request #7310: [AIRFLOW-XXXX] Fix email configuration link in CONTRIBUTING.rst

[GitBox]

coopergillan opened a new pull request #7310: [AIRFLOW-] Fix email 
configuration link in CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7310
 
 
   Update the link to the email configuration in CONTRIBUTING.rst.
   
   ---
   Issue link: `Document only change, no JIRA issue`
   
   Make sure to mark the boxes below before creating PR:
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan opened a new pull request #7310: [AIRFLOW-XXXX] Fix email configuration link in CONTRIBUTING.rst

[GitBox]

coopergillan opened a new pull request #7310: [AIRFLOW-] Fix email 
configuration link in CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7310
 
 
   Update the link to the email configuration in CONTRIBUTING.rst.
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4681) Make airflow/sensors Pylint compatible

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027712#comment-17027712
 ] 

ASF GitHub Bot commented on AIRFLOW-4681:
-

coopergillan commented on pull request #7309: [AIRFLOW-4681] Make sensors 
module pylint compatible
URL: https://github.com/apache/airflow/pull/7309
 
 
   Make sensor modules pylint compatible. Rename and use some local rather than 
class variables and add comments to ignore some pylint checks around higher 
impact code.
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Make airflow/sensors Pylint compatible
> --
>
> Key: AIRFLOW-4681
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4681
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: pylint
>Affects Versions: 2.0.0
>Reporter: Bas Harenslak
>Assignee: Kamil Bregula
>Priority: Major
>
> Fix all Pylint messages in airflow/sensors. To start; running 
> scripts/ci/ci_pylint.sh on master should produce no messages. (1) Remove the 
> files mentioned in your issue from the blacklist. (2) Run 
> scripts/ci/ci_pylint.sh to see all messages on the no longer blacklisted 
> files. (3) Fix all messages and create PR.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] coopergillan opened a new pull request #7309: [AIRFLOW-4681] Make sensors module pylint compatible

[GitBox]

coopergillan opened a new pull request #7309: [AIRFLOW-4681] Make sensors 
module pylint compatible
URL: https://github.com/apache/airflow/pull/7309
 
 
   Make sensor modules pylint compatible. Rename and use some local rather than 
class variables and add comments to ignore some pylint checks around higher 
impact code.
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #6788: WIP: [AIRFLOW-5944] Rendering templated_fields without accessing DAG files

[GitBox]

kaxil commented on a change in pull request #6788: WIP: [AIRFLOW-5944] 
Rendering templated_fields without accessing DAG files
URL: https://github.com/apache/airflow/pull/6788#discussion_r373608085
 
 

 ##
 File path: 
airflow/migrations/versions/852ae6c715af_add_templated_fields_rendered_table.py
 ##
 @@ -0,0 +1,103 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Add TemplatedFieldsRendered table
+
+Revision ID: 852ae6c715af
+Revises: 1d3a23a719bf
+Create Date: 2019-12-10 22:19:18.034961
+
+"""
+
+import sqlalchemy as sa
+from alembic import op
+from sqlalchemy.dialects import mysql
+
+# revision identifiers, used by Alembic.
+revision = '852ae6c715af'
+down_revision = '1d3a23a719bf'
+branch_labels = None
+depends_on = None
+
+TABLE_NAME = 'templated_fields_rendered'
+INDEX_NAME = 'idx_tfr_dag_task_date'
+
+
+def upgrade():
+"""Apply Add TemplatedFieldsRendered table"""
+json_type = sa.JSON
+conn = op.get_bind()  # pylint: disable=no-member
+
+if conn.dialect.name != "postgresql":
+# Mysql 5.7+/MariaDB 10.2.3 has JSON support. Rather than checking for
+# versions, check for the function existing.
+try:
+conn.execute("SELECT JSON_VALID(1)").fetchone()
+except sa.exc.OperationalError:
+json_type = sa.Text
+
+op.create_table(
+TABLE_NAME,  # pylint: disable=no-member
+sa.Column('dag_id', sa.String(length=250), nullable=False),
+sa.Column('task_id', sa.String(length=250), nullable=False),
+sa.Column('execution_date', sa.DateTime(), nullable=False),
+sa.Column('rendered_fields', json_type(), nullable=True),
+sa.PrimaryKeyConstraint('dag_id', 'task_id', 'execution_date')
+)
+op.create_index(  # pylint: disable=no-member
+INDEX_NAME,
+TABLE_NAME,
+['dag_id', 'task_id', 'execution_date'],
+)
+
+if conn.dialect.name == "mysql":
+conn.execute("SET time_zone = '+00:00'")
 
 Review comment:
   From the same 
[article](https://www.eversql.com/mysql-datetime-vs-timestamp-column-types-which-one-i-should-use/)
 :
   
   >To summarize, if you want to serve your date and time data the same way 
regardless of timezones, you can use the DATETIME type (which will also allow 
you to use all the date & type functions built in MySQL). Otherwise, you can 
use TIMESTAMP and serve the data on a per-timezone basis.
   
   Also, from 
https://docs.sqlalchemy.org/en/13/core/type_basics.html#sqlalchemy.types.DateTime
   >For timezone support, use at least the TIMESTAMP datatype, if not the 
dialect-specific datatype object.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] stale[bot] commented on issue #6802: [AIRFLOW-6234] Allow override of k8s secret volume default mode

[GitBox]

stale[bot] commented on issue #6802: [AIRFLOW-6234] Allow override of k8s 
secret volume default mode
URL: https://github.com/apache/airflow/pull/6802#issuecomment-580833995
 
 
   This issue has been automatically marked as stale because it has not had 
recent activity. It will be closed if no further activity occurs. Thank you for 
your contributions.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (AIRFLOW-6696) Package manager installable not a full distribution for rbac use

[Chris Schmautz (Jira)]

Chris Schmautz created AIRFLOW-6696:
---

 Summary: Package manager installable not a full distribution for 
rbac use
 Key: AIRFLOW-6696
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6696
 Project: Apache Airflow
  Issue Type: Bug
  Components: ui
Affects Versions: 1.10.7
Reporter: Chris Schmautz


+Problem+

The 'pip' or 'conda' distribution of airflow is not a full distribution for 
anyone wanting a turn-key package. The 'dist' folder is not included in 
'.../www_rbac/static'.

 

+Proposed solution+

The expectation of the package manager is to have a useable asset once the 
package is installed. Packages relying on additional dependencies tend to stick 
with +sdist+ packaging route, so that they can expose those dependencies during 
build time (think C-backed packages, for instance).

 

'conda install airflow' did not expose this need for an additional step, and 
based on numerous other issues open in the Airflow backlog, chances are 'pip 
install' suffers the same fate.

 

Preferably for the proposed solution, just prescribe defaults for the 'dist' 
folder, and include ways to override it through some mechanism. Airflow already 
has this pattern for 'webserver_config.py', so the pattern is already there, if 
you'd want to extend the pattern to these assets. Whatever the solution, 'pip 
install' or 'conda install' should provide a usable, turn-key package without 
the need for an additional build system downstream.

 

+Why+

Many of our deployment targets don't have npm, and won't ever have it. We are 
then forced into a position of composing an environment at a tag revision, then 
using 'conda-pack' to send that revision to another place where the static 
resources can be built, back to a second 'conda-pack' with the built bundle. 
From our perspective, this build pattern has minimal lift over the previous 
static deployment path and is mainly a hassle.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (AIRFLOW-6695) Support passing DAG configuration in UI

[Daniel Cohen (Jira)]

Daniel Cohen created AIRFLOW-6695:
-

 Summary: Support passing DAG configuration in UI
 Key: AIRFLOW-6695
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6695
 Project: Apache Airflow
  Issue Type: Improvement
  Components: ui
Affects Versions: master
Reporter: Daniel Cohen


When triggering a DAG from the CLI or the REST API, it's possible to pass 
configuration for the DAG run as a JSON blob.

The PR accompanying this ticket adds a new screen confirming the trigger 
request, and allowing the user to pass a JSON configuration blob to the new DAG 
run.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] tayloramurphy opened a new pull request #7308: Update GitLab team members

[GitBox]

tayloramurphy opened a new pull request #7308: Update GitLab team members
URL: https://github.com/apache/airflow/pull/7308
 
 
   @tlapiana is no longer with the company and @m_walker is new on the team!
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

[GitBox]

anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST 
API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373565889
 
 

 ##
 File path: airflow/api/common/experimental/trigger_dag.py
 ##
 @@ -122,7 +122,12 @@ def trigger_dag(
 dag_model = DagModel.get_current(dag_id)
 if dag_model is None:
 raise DagNotFound("Dag id {} not found in DagModel".format(dag_id))
-dagbag = DagBag(dag_folder=dag_model.fileloc)
+from airflow.configuration import conf as global_conf
 
 Review comment:
   I understand. But I needed a different name because conf parameters is 
already passed to this method and it denotes conf for dag run (additional 
parameters)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] coopergillan commented on issue #5406: [AIRFLOW-4681] Fix pylint problems for sensors module

[GitBox]

coopergillan commented on issue #5406: [AIRFLOW-4681] Fix pylint problems for 
sensors module
URL: https://github.com/apache/airflow/pull/5406#issuecomment-580788188
 
 
   Looks like this one just needs a rebase?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4707) Make tests/plugins Pylint compatible

[Cooper Gillan (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027609#comment-17027609
 ] 

Cooper Gillan commented on AIRFLOW-4707:


Was this resolved with AIRFLOW-6343?

> Make tests/plugins Pylint compatible
> 
>
> Key: AIRFLOW-4707
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4707
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: pylint
>Affects Versions: 2.0.0
>Reporter: Bas Harenslak
>Assignee: kik
>Priority: Major
>
> Fix all Pylint messages in tests/plugins. To start; running 
> scripts/ci/ci_pylint.sh on master should produce no messages. (1) Remove the 
> files mentioned in your issue from the blacklist. (2) Run 
> scripts/ci/ci_pylint.sh to see all messages on the no longer blacklisted 
> files. (3) Fix all messages and create PR.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] mik-laj commented on a change in pull request #7305: [AIRFLOW-6693] Make page titles distinguishable from another

[GitBox]

mik-laj commented on a change in pull request #7305: [AIRFLOW-6693] Make page 
titles distinguishable from another
URL: https://github.com/apache/airflow/pull/7305#discussion_r373544606
 
 

 ##
 File path: airflow/www/views.py
 ##
 @@ -1709,7 +1709,8 @@ def tries(self, session=None):
 demo_mode=conf.getboolean('webserver', 'demo_mode'),
 root=root,
 form=form,
-chart=chart.htmlcontent
+chart=chart.htmlcontent,
+tab_title='tries',
 
 Review comment:
   ```suggestion
   tab_title='Tries',
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7305: [AIRFLOW-6693] Make page titles distinguishable from another

[GitBox]

mik-laj commented on a change in pull request #7305: [AIRFLOW-6693] Make page 
titles distinguishable from another
URL: https://github.com/apache/airflow/pull/7305#discussion_r373544677
 
 

 ##
 File path: airflow/www/views.py
 ##
 @@ -1788,6 +1789,7 @@ def landing_times(self, session=None):
 demo_mode=conf.getboolean('webserver', 'demo_mode'),
 root=root,
 form=form,
+tab_title='landing times',
 
 Review comment:
   ```suggestion
   tab_title='Landing times',
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7305: [AIRFLOW-6693] Make page titles distinguishable from another

[GitBox]

mik-laj commented on a change in pull request #7305: [AIRFLOW-6693] Make page 
titles distinguishable from another
URL: https://github.com/apache/airflow/pull/7305#discussion_r373544494
 
 

 ##
 File path: airflow/www/templates/airflow/tree.html
 ##
 @@ -18,7 +18,7 @@
 #}
 
 {% extends "airflow/dag.html" %}
-{% block title %}Airflow - DAGs{% endblock %}
+{% block page_title %}{{ dag.dag_id }} - tree - Airflow{% endblock %}
 
 Review comment:
   ```suggestion
   {% block page_title %}{{ dag.dag_id }} - Tree - Airflow{% endblock %}
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7305: [AIRFLOW-6693] Make page titles distinguishable from another

[GitBox]

mik-laj commented on a change in pull request #7305: [AIRFLOW-6693] Make page 
titles distinguishable from another
URL: https://github.com/apache/airflow/pull/7305#discussion_r373544362
 
 

 ##
 File path: airflow/www/templates/airflow/duration_chart.html
 ##
 @@ -18,7 +18,7 @@
 #}
 
 {% extends "airflow/dag.html" %}
-{% block title %}Airflow - DAGs{% endblock %}
+{% block page_title %}{{ dag.dag_id }} - duration - Airflow{% endblock %}
 
 Review comment:
   ```suggestion
   {% block page_title %}{{ dag.dag_id }} - Duration chart - Airflow{% endblock 
%}
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7305: [AIRFLOW-6693] Make page titles distinguishable from another

[GitBox]

mik-laj commented on a change in pull request #7305: [AIRFLOW-6693] Make page 
titles distinguishable from another
URL: https://github.com/apache/airflow/pull/7305#discussion_r373544182
 
 

 ##
 File path: airflow/www/templates/airflow/dag_code.html
 ##
 @@ -18,7 +18,8 @@
 #}
 
 {% extends "airflow/dag.html" %}
-{% block title %}Airflow - DAGs{% endblock %}
+
+{% block page_title %}{{ dag.dag_id }} - code - Airflow{% endblock %}
 
 Review comment:
   ```suggestion
   {% block page_title %}{{ dag.dag_id }} - Code - Airflow{% endblock %}
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7305: [AIRFLOW-6693] Make page titles distinguishable from another

[GitBox]

mik-laj commented on a change in pull request #7305: [AIRFLOW-6693] Make page 
titles distinguishable from another
URL: https://github.com/apache/airflow/pull/7305#discussion_r373544124
 
 

 ##
 File path: airflow/www/templates/airflow/code.html
 ##
 @@ -19,9 +19,7 @@
 
 {% extends "airflow/master.html" %}
 
-{% block title %}
-{{ title }}
-{% endblock %}
+{% block page_title %}{{ dag.dag_id }} - code - Airflow{% endblock %}
 
 Review comment:
   ```suggestion
   {% block page_title %}{{ dag.dag_id }} - Code - Airflow{% endblock %}
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7305: [AIRFLOW-6693] Make page titles distinguishable from another

[GitBox]

mik-laj commented on a change in pull request #7305: [AIRFLOW-6693] Make page 
titles distinguishable from another
URL: https://github.com/apache/airflow/pull/7305#discussion_r373544245
 
 

 ##
 File path: airflow/www/templates/airflow/dag_details.html
 ##
 @@ -19,9 +19,7 @@
 
 {% extends "airflow/dag.html" %}
 
-{% block title %}
-{{ title }}
-{% endblock %}
+{% block page_title %}{{ dag.dag_id }} - details - Airflow{% endblock %}
 
 Review comment:
   ```suggestion
   {% block page_title %}{{ dag.dag_id }} - DAG Details - Airflow{% endblock %}
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services