Re: [Apache Bloodhound] #415: Edit pages should put focus on text input element

[Apache Bloodhound]

#415: Edit pages should put focus on text input element
--+
  Reporter:  rjollos  |  Owner:  rjollos
  Type:  enhancement  | Status:  new
  Priority:  minor|  Milestone:  Release 9
 Component:  ui design|Version:
Resolution:   |   Keywords:  trac-1.0.2
--+
Changes (by rjollos):

 * keywords:   => trac-1.0.2


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #415: Edit pages should put focus on text input element

[Apache Bloodhound]

#415: Edit pages should put focus on text input element
--+---
  Reporter:  rjollos  |  Owner:  rjollos
  Type:  enhancement  | Status:  new
  Priority:  minor|  Milestone:  Release 9
 Component:  ui design|Version:
Resolution:   |   Keywords:
--+---

Comment (by rjollos):

 Complementary changes committed to Trac in [t 11994:11995].

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #639: KeyError: 'product'

[Apache Bloodhound]

#639: KeyError: 'product'
---+--
  Reporter:  jav   |  Owner:
  Type:  defect| Status:  review
  Priority:  critical  |  Milestone:  Release 8
 Component:  multiproduct  |Version:  0.6.0
Resolution:|   Keywords:  ticket field
---+--

Comment (by rjollos):

 (In [1517740])

 0.8dev: Log warning or add warning message to page when the `product`
 field is missing from the ticket template's `data` dictionary. Refs #639.

 Patch by Olemis.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

svn commit: r1517740 - /bloodhound/trunk/bloodhound_theme/bhtheme/theme.py

[rjollos]

Author: rjollos
Date: Tue Aug 27 02:22:40 2013
New Revision: 1517740

URL: http://svn.apache.org/r1517740
Log:
0.8dev: Log warning or add warning message to page when the `product` field is 
missing from the ticket template's `data` dictionary. Refs #639.

Patch by Olemis.

Modified:
bloodhound/trunk/bloodhound_theme/bhtheme/theme.py

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py?rev=1517740&r1=1517739&r2=1517740&view=diff
==
--- bloodhound/trunk/bloodhound_theme/bhtheme/theme.py (original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/theme.py Tue Aug 27 02:22:40 2013
@@ -35,7 +35,7 @@ from trac.util.presentation import to_js
 from trac.util.translation import _
 from trac.versioncontrol.web_ui.browser import BrowserModule
 from trac.web.api import IRequestFilter, IRequestHandler, ITemplateStreamFilter
-from trac.web.chrome import (add_stylesheet, INavigationContributor,
+from trac.web.chrome import (add_stylesheet, add_warning, 
INavigationContributor,
  ITemplateProvider, prevnext_nav, Chrome)
 from trac.wiki.admin import WikiAdmin
 
@@ -481,7 +481,7 @@ class QuickCreateTicketDialog(Component)
   for f in tm._prepare_fields(req, ticket)
   if f['type'] == 'select')
 
-product_field = all_fields['product']
+product_field = all_fields.get('product')
 if product_field:
 if self.env.product:
 product_field['value'] = self.env.product.prefix
@@ -499,6 +499,15 @@ class QuickCreateTicketDialog(Component)
 ProductEnvironment.lookup_env(self.env, p).product.name
 for p in product_field['options']
 ]
+else:
+msg = _("Missing ticket field '%s'.", 'product')
+if ProductTicketModule is not None and \
+self.env[ProductTicketModule] is not None:
+# Display warning alert to users
+add_warning(req, msg)
+else:
+# Include message in logs since this might be a failure
+self.log.warning(msg)
 data['qct'] = {
 'fields': [all_fields[k] for k in self.qct_fields
if k in all_fields],

Re: [Apache Bloodhound] #552: Inaccurate URLs in global dashboard

[Apache Bloodhound]

#552: Inaccurate URLs in global dashboard
-+-
  Reporter:  olemis  |  Owner:  olemis
  Type:  defect  | Status:  closed
  Priority:  major   |  Milestone:  Release 8
 Component:  dashboard   |Version:
Resolution:  fixed   |   Keywords:  custom bootstrap handlers, product
 |  widget
-+-
Changes (by rjollos):

 * status:  review => closed
 * resolution:   => fixed


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #552: Inaccurate URLs in global dashboard

[Apache Bloodhound]

#552: Inaccurate URLs in global dashboard
-+-
  Reporter:  olemis  |  Owner:  olemis
  Type:  defect  | Status:  review
  Priority:  major   |  Milestone:  Release 8
 Component:  dashboard   |Version:
Resolution:  |   Keywords:  custom bootstrap handlers, product
 |  widget
-+-
Changes (by rjollos):

 * owner:  rjollos => olemis


Comment:

 (In [1517739])

 0.8dev: URLs in product widget were incorrect in product URL with
 subdomains. Refs #552.

 The query links from the product widget now exclude closed tickets and
 provide a more useful set of default columns. Patch by Olemis.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

svn commit: r1517739 - in /bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets: product.py templates/widget_product.html

[rjollos]

Author: rjollos
Date: Tue Aug 27 02:03:36 2013
New Revision: 1517739

URL: http://svn.apache.org/r1517739
Log:
0.8dev: URLs in product widget were incorrect in product URL with subdomains. 
Refs #552.

The query links from the product widget now exclude closed tickets and provide 
a more useful set of default columns. Patch by Olemis.

Modified:
bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py

bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/templates/widget_product.html

Modified: bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py?rev=1517739&r1=1517738&r2=1517739&view=diff
==
--- bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py 
(original)
+++ bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py Tue 
Aug 27 02:03:36 2013
@@ -36,7 +36,6 @@ from trac.ticket.query import Query
 from bhdashboard.util import WidgetBase, check_widget_name, pretty_wrapper
 
 from multiproduct.env import Product, ProductEnvironment
-from multiproduct.hooks import ProductizedHref
 
 
 __metaclass__ = type
@@ -59,9 +58,11 @@ class ProductWidget(WidgetBase):
 
 get_widget_params = pretty_wrapper(get_widget_params, check_widget_name)
 
-def _get_product_info(self, product, resource, max_):
+COMMON_QUERY = 'order=priority&status=!closed&col=id&col=summary' \
+   '&col=owner&col=type&col=status&col=priority&col=product'
+
+def _get_product_info(self, product, href, resource, max_):
 penv = ProductEnvironment(self.env, product.prefix)
-href = ProductizedHref(self.env, penv.href.base)
 results = []
 
 # some queries return a list/tuple, some a generator,
@@ -76,9 +77,10 @@ class ProductWidget(WidgetBase):
 for q in itertools.islice(query, max_):
 q.url = href(resource['name'], q.name) \
 if resource.get('hrefurl') \
-else Query.from_string(
-penv, 'order=priority&%s=%s' %
-  (resource['name'], q.name)).get_href(href)
+else Query.from_string(penv,
+'%s=%s&%s&col=%s' % (resource['name'], q.name,
+ self.COMMON_QUERY, resource['name'])
+).get_href(href)
 q.ticket_count = penv.db_query("""
 SELECT COUNT(*) FROM ticket WHERE ticket.%s='%s'
 AND ticket.status <> 'closed'
@@ -125,21 +127,24 @@ class ProductWidget(WidgetBase):
 params = ('max', 'cols')
 max_, cols = self.bind_params(name, options, *params)
 
-if not isinstance(req.perm.env, ProductEnvironment):
+if not isinstance(self.env, ProductEnvironment):
 for p in Product.select(self.env):
 if 'PRODUCT_VIEW' in req.perm(Neighborhood('product', 
p.prefix)):
+penv = ProductEnvironment(self.env, p.prefix)
+phref = ProductEnvironment.resolve_href(penv, self.env)
 for resource in (
 {'type': Milestone, 'name': 'milestone', 'hrefurl': 
True},
 {'type': Component, 'name': 'component'},
 {'type': Version, 'name': 'version'},
 ):
 setattr(p, resource['name'] + 's',
-self._get_product_info(p, resource, max_))
+self._get_product_info(p, phref, resource, 
max_))
 p.owner_link = Query.from_string(self.env,
 'status!=closed&col=id&col=summary&col=owner'
 '&col=status&col=priority&order=priority'
 '&group=product&owner=%s' % (p._data['owner'] or '', )
-).get_href(req.href)
+).get_href(phref)
+p.href = phref()
 data.setdefault('product_list', []).append(p)
 title = _('Products')
 

Modified: 
bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/templates/widget_product.html
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/templates/widget_product.html?rev=1517739&r1=1517738&r2=1517739&view=diff
==
--- 
bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/templates/widget_product.html
 (original)
+++ 
bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/templates/widget_product.html
 Tue Aug 27 02:03:36 2013
@@ -26,7 +26,7 @@
   
 
   
-☆ $p.name 
($p.prefix)
+☆ $p.name ($p.prefix)
 
   
   owned by

Re: [Apache Bloodhound] #649: Clicking on "... more" hyperlink within dashboard results in error

[Apache Bloodhound]

#649: Clicking on "... more" hyperlink within dashboard results in error
--+---
  Reporter:  ChrisHarris  |  Owner:  rjollos
  Type:  defect   | Status:  closed
  Priority:  major|  Milestone:  Release 8
 Component:  dashboard|Version:  0.6.0
Resolution:  fixed|   Keywords:
--+---
Changes (by rjollos):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 (In [1517736])

 0.8dev: The "... more" link in the product widget did not point to the
 dashboard. Fixes #649.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

svn commit: r1517736 - /bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py

[rjollos]

Author: rjollos
Date: Tue Aug 27 01:07:34 2013
New Revision: 1517736

URL: http://svn.apache.org/r1517736
Log:
0.8dev: The "... more" link in the product widget did not point to the 
dashboard. Fixes #649.

Modified:
bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py

Modified: bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py?rev=1517736&r1=1517735&r2=1517736&view=diff
==
--- bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py 
(original)
+++ bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py Tue 
Aug 27 01:07:34 2013
@@ -111,7 +111,7 @@ class ProductWidget(WidgetBase):
 q.name = _('... more')
 q.ticket_count = None
 q.url = href(resource['name']) if resource.get('hrefurl') \
-else href.product(product.prefix)
+else href.dashboard()
 results.append(q)
 
 return results

svn commit: r1517735 - /bloodhound/trunk/bloodhound_theme/bhtheme/theme.py

[rjollos]

Author: rjollos
Date: Tue Aug 27 01:04:07 2013
New Revision: 1517735

URL: http://svn.apache.org/r1517735
Log:
0.8dev: Reporter and timestamp in comment feed were not correct. Fixes #643.

Modified:
bloodhound/trunk/bloodhound_theme/bhtheme/theme.py

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py?rev=1517735&r1=1517734&r2=1517735&view=diff
==
--- bloodhound/trunk/bloodhound_theme/bhtheme/theme.py (original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/theme.py Tue Aug 27 01:04:07 2013
@@ -363,14 +363,15 @@ class BloodhoundTheme(ThemeBase):
  is_active)
 
 #add a creation event to the changelog if the ticket exists
-if data['ticket'].exists:
+ticket = data['ticket']
+if ticket.exists:
 data['changes'] = [{'comment': '',
-'author': data['author_id'],
+'author': ticket['reporter'],
 'fields': {u'reported': {'label': u'Reported'},
},
 'permanent': 1,
 'cnum': 0,
-'date': data['start_time'],
+'date': ticket['time'],
 },
] + data['changes']
 #and set default order

Re: [Apache Bloodhound] #643: Inaccurate timestamps and ticket reporter

[Apache Bloodhound]

#643: Inaccurate timestamps and ticket reporter
+---
  Reporter:  olemis |  Owner:  rjollos
  Type:  defect | Status:  closed
  Priority:  minor  |  Milestone:  Release 8
 Component:  ui design  |Version:  0.6.0
Resolution:  fixed  |   Keywords:  ticket
+---
Changes (by rjollos):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 (In [1517735])

 0.8dev: Reporter and timestamp in comment feed were not correct. Fixes
 #643.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #645: "Enter ticket summary" field collapses

[Apache Bloodhound]

#645: "Enter ticket summary" field collapses
--+---
  Reporter:  ChrisHarris  |  Owner:  rjollos
  Type:  defect   | Status:  closed
  Priority:  major|  Milestone:  Release 8
 Component:  dashboard|Version:  0.6.0
Resolution:  fixed|   Keywords:
--+---
Changes (by rjollos):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 (In [1517734])

 0.8dev: Prevent ticket summary field from collapsing when empty. Fixes
 #645.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

svn commit: r1517734 - /bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css

[rjollos]

Author: rjollos
Date: Tue Aug 27 00:58:52 2013
New Revision: 1517734

URL: http://svn.apache.org/r1517734
Log:
0.8dev: Prevent ticket summary field from collapsing when empty. Fixes #645.

Modified:
bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css?rev=1517734&r1=1517733&r2=1517734&view=diff
==
--- bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css (original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css Tue Aug 27 
00:58:52 2013
@@ -374,6 +374,10 @@ h1, h2, h3, h4 {
  page-break-after: avoid;
 }
 
+h1, h2, h3 {
+ min-height: 40px;
+}
+
 .clip, .affix .clip-affix {
  overflow: hidden;
  text-overflow: ellipsis;

Re: [Apache Bloodhound] #539: Product-scope TracAdmin commands don't take effect until tracd is restarted

[Apache Bloodhound]

#539: Product-scope TracAdmin commands don't take effect until tracd is 
restarted
+---
  Reporter:  rjollos|  Owner:  olemis
  Type:  defect | Status:  accepted
  Priority:  major  |  Milestone:  Release 8
 Component:  dashboard  |Version:
Resolution: |   Keywords:  tracadmin command
+---

Comment (by olemis):

 I have attached two patches introducing each a global for basic
 synchronization of product configuration instances and related test cases
 . Details :

 {{{#!sh

 $ hg qapplied
 t539/t539_r1516428_test_product_config_sync.diff
 t539/t539_r1516428_product_config_sync.diff

 $ hg log -r qparent
 changeset:   398:17cd489fc827
 tag: qparent
 tag: svn-1516428
 user:matevz@13f79535-47bb-0310-9956-ffa450edef68
 date:Thu Aug 22 12:17:32 2013 +
 summary: #444 - Show number of attachments next to attachment heading

 }}}

 After applying both patches the unit tests for configuration objects all
 succeed. I'm running the whole unit and functional test suites and report
 here the results I got shortly after .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #639: KeyError: 'product'

[Apache Bloodhound]

#639: KeyError: 'product'
---+--
  Reporter:  jav   |  Owner:
  Type:  defect| Status:  review
  Priority:  critical  |  Milestone:  Release 8
 Component:  multiproduct  |Version:  0.6.0
Resolution:|   Keywords:  ticket field
---+--
Changes (by olemis):

 * status:  accepted => review
 * owner:  olemis =>
 * milestone:   => Release 8


Old description:

>  How to Reproduce 
>
> While doing a GET operation on
> `/attachment/wiki/Topic1/Page1/Image1.png`, Trac issued an internal
> error.
>
> Clicking on an attachment link in a Wiki page results in an error
> message.
>
> Request parameters:
> {{{
> {'path': u'Topic1/Page1/Image1.png',
>  'realm': u'wiki'}
> }}}
>
> User agent: `Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101
> Firefox/23.0`
>
>  System Information 
> || '''`Trac`''' || `1.0.1` [[br]] `` ||
> || '''`Babel`''' || `1.3` ||
> || '''`Bloodhound Trac`''' || `1.0.1` ||
> || '''`Genshi`''' || `0.7 (without speedups)` ||
> || '''`GIT`''' || `1.8.1.4` ||
> || '''`mod_wsgi`''' || `3.3 (WSGIProcessGroup bh_tracker
> WSGIApplicationGroup %{GLOBAL})` ||
> || '''`psycopg2`''' || `2.4.5` ||
> || '''`Pygments`''' || `1.6` ||
> || '''`Python`''' || `2.7.3 (default, Apr 14 2012, 08:58:41) [GCC]` ||
> || '''`pytz`''' || `2013b` ||
> || '''`setuptools`''' || `0.9.8` ||
> || '''`jQuery`''' || `1.7.2` ||
>
>  Enabled Plugins 
> || '''`BloodhoundDashboardPlugin`''' || `0.6.0` ||
> || '''`BloodhoundMultiProduct`''' || `0.6.0` ||
> || '''`BloodhoundRelationsPlugin`''' || `0.6.0` ||
> || '''`BloodhoundSearchPlugin`''' || `0.6.0` ||
> || '''`BloodhoundTheme`''' || `0.6.0` ||
> || '''`TracAccountManager`''' || `0.4.3` ||
> || '''`TracPermRedirect`''' || `3.0` ||
> || '''`TracThemeEngine`''' || `2.2.0` ||
>
>  Python Traceback 
> {{{
> Traceback (most recent call last):
>   File "/opt/apache-bloodhound-0.6/installer/bloodhound/lib/python2.7
> /site-packages/trac/web/main.py", line 477, in _dispatch_request
> dispatcher.dispatch(req)
>   File "/opt/apache-bloodhound-0.6/installer/bloodhound/lib/python2.7
> /site-packages/trac/web/main.py", line 224, in dispatch
> self._post_process_request(req, *resp)
>   File "/opt/apache-bloodhound-0.6/installer/bloodhound/lib/python2.7
> /site-packages/trac/web/main.py", line 338, in _post_process_request
> resp = f.post_process_request(req, *resp)
>   File "/opt/apache-bloodhound-0.6/installer/bloodhound/lib/python2.7
> /site-packages/bhtheme/theme.py", line 476, in post_process_request
> product_field = all_fields['product']
> KeyError: 'product'
> }}}

New description:

  How to Reproduce 

 While doing a GET operation on `/attachment/wiki/Topic1/Page1/Image1.png`,
 Trac issued an internal error.

 Clicking on an attachment link in a Wiki page results in an error message.

 Request parameters:
 {{{
 {'path': u'Topic1/Page1/Image1.png',
  'realm': u'wiki'}
 }}}

 User agent: `Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101
 Firefox/23.0`

  System Information 
 || '''`Trac`''' || `1.0.1` [[br]] `` ||
 || '''`Babel`''' || `1.3` ||
 || '''`Bloodhound Trac`''' || `1.0.1` ||
 || '''`Genshi`''' || `0.7 (without speedups)` ||
 || '''`GIT`''' || `1.8.1.4` ||
 || '''`mod_wsgi`''' || `3.3 (WSGIProcessGroup bh_tracker
 WSGIApplicationGroup %{GLOBAL})` ||
 || '''`psycopg2`''' || `2.4.5` ||
 || '''`Pygments`''' || `1.6` ||
 || '''`Python`''' || `2.7.3 (default, Apr 14 2012, 08:58:41) [GCC]` ||
 || '''`pytz`''' || `2013b` ||
 || '''`setuptools`''' || `0.9.8` ||
 || '''`jQuery`''' || `1.7.2` ||

  Enabled Plugins 
 || '''`BloodhoundDashboardPlugin`''' || `0.6.0` ||
 || '''`BloodhoundMultiProduct`''' || `0.6.0` ||
 || '''`BloodhoundRelationsPlugin`''' || `0.6.0` ||
 || '''`BloodhoundSearchPlugin`''' || `0.6.0` ||
 || '''`BloodhoundTheme`''' || `0.6.0` ||
 || '''`TracAccountManager`''' || `0.4.3` ||
 || '''`TracPermRedirect`''' || `3.0` ||
 || '''`TracThemeEngine`''' || `2.2.0` ||

  Python Traceback 
 {{{#!py
 Traceback (most recent call last):
   File "/opt/apache-bloodhound-0.6/installer/bloodhound/lib/python2.7
 /site-packages/trac/web/main.py", line 477, in _dispatch_request
 dispatcher.dispatch(req)
   File "/opt/apache-bloodhound-0.6/installer/bloodhound/lib/python2.7
 /site-packages/trac/web/main.py", line 224, in dispatch
 self._post_process_request(req, *resp)
   File "/opt/apache-bloodhound-0.6/installer/bloodhound/lib/python2.7
 /site-packages/trac/web/main.py", line 338, in _post_process_request
 resp = f.post_process_request(req, *resp)
   File "/opt/apache-bloodhound-0.6/installer/bloodhound/lib/python2.7
 /site-packages/bhtheme/theme.py", line 476, in post_process_request
 product_field = all_fields['product']
 KeyError: 'product'
 }}}

--

Comment:

 The root cause of this error seems to be related to a lower level failure
 of 

Re: [Apache Bloodhound] #552: Inaccurate URLs in global dashboard

[Apache Bloodhound]

#552: Inaccurate URLs in global dashboard
-+-
  Reporter:  olemis  |  Owner:  rjollos
  Type:  defect  | Status:  review
  Priority:  major   |  Milestone:  Release 8
 Component:  dashboard   |Version:
Resolution:  |   Keywords:  custom bootstrap handlers, product
 |  widget
-+-

Comment (by olemis):

 Refreshed the patch and it works against r1516428 .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #567: Write functional test cases to track regressions on known issues

[Apache Bloodhound]

#567: Write functional test cases to track regressions on known issues
---+-
  Reporter:  olemis|  Owner:  olemis
  Type:  task  | Status:  accepted
  Priority:  minor |  Milestone:  Release 8
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  qa, functional test
---+-
Changes (by olemis):

 * owner:  nobody => olemis
 * status:  new => accepted


Old description:

> Initial targets :
>
>   - Request handling in product web module : #541 and #561
>   - Product features : #575 , #562,
>   - Apply [attachment:t638_r1514232_dashb_ticket_url.diff:ticket:638
> patch] including test cases for #638
>
> ... more will be added later

New description:

 Initial targets :

   - Request handling in product web module : #541 and #561
   - Product features : #575 , #562
   - Apply [attachment:t638_r1514232_dashb_ticket_url.diff:ticket:638
 patch] including test cases for #638
   - Products widget : #552

 ... more will be added later

--

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #649: Clicking on "... more" hyperlink within dashboard results in error

[Apache Bloodhound]

#649: Clicking on "... more" hyperlink within dashboard results in error
--+---
  Reporter:  ChrisHarris  |  Owner:  rjollos
  Type:  defect   | Status:  accepted
  Priority:  major|  Milestone:  Release 8
 Component:  dashboard|Version:  0.6.0
Resolution:   |   Keywords:
--+---

Comment (by olemis):

 Replying to [comment:4 olemis]:
 > Replying to [comment:3 rjollos]:
 > > Since `href` is an instance `ProductizedHref`, it seems like we just
 want to create a URL that points to the dashboard for the product.
 > >
 >
 > I'm not so sure about this one ... I'll take a look .
 >

 @rjollos : it's ok . Now I noticed that `href` is correctly scoped to the
 right product base URL , even after applying the patches for #552 . BTW ,
 this is not a duplicate of #552 since the same problem is still there
 after applying
 [attachment:t552_r1500567_product_widget_href.diff:ticket:552 this patch].

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #649: Clicking on "... more" hyperlink within dashboard results in error

[Apache Bloodhound]

#649: Clicking on "... more" hyperlink within dashboard results in error
--+---
  Reporter:  ChrisHarris  |  Owner:  rjollos
  Type:  defect   | Status:  accepted
  Priority:  major|  Milestone:  Release 8
 Component:  dashboard|Version:  0.6.0
Resolution:   |   Keywords:
--+---

Comment (by olemis):

 Replying to [comment:3 rjollos]:
 > Since `href` is an instance `ProductizedHref`, it seems like we just
 want to create a URL that points to the dashboard for the product.
 >

 I'm not so sure about this one ... I'll take a look .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #649: Clicking on "... more" hyperlink within dashboard results in error

[Apache Bloodhound]

#649: Clicking on "... more" hyperlink within dashboard results in error
--+---
  Reporter:  ChrisHarris  |  Owner:  rjollos
  Type:  defect   | Status:  accepted
  Priority:  major|  Milestone:  Release 8
 Component:  dashboard|Version:  0.6.0
Resolution:   |   Keywords:
--+---

Comment (by olemis):

 This ticket look like a duplicate of #552 .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #647: Can't reassign ticket to another product once assigned to Default (@) product

[Apache Bloodhound]

#647: Can't reassign ticket to another product once assigned to Default (@)
product
---+
  Reporter:  ChrisHarris   |  Owner:  nobody
  Type:  defect| Status:  new
  Priority:  major |  Milestone:
 Component:  multiproduct  |Version:  0.6.0
Resolution:|   Keywords:  ticket product
---+
Changes (by olemis):

 * keywords:   => ticket product


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #647: Can't reassign ticket to another product once assigned to Default (@) product

[Apache Bloodhound]

#647: Can't reassign ticket to another product once assigned to Default (@)
product
---+
  Reporter:  ChrisHarris   |  Owner:  nobody
  Type:  defect| Status:  new
  Priority:  major |  Milestone:
 Component:  multiproduct  |Version:  0.6.0
Resolution:|   Keywords:
---+

Comment (by olemis):

 Replying to [ticket:647 ChrisHarris]:
 [...]
 >
 > 4.) Locate the newly created ticket and click on "Modify Ticket".  You
 can't reassign the ticket to another product.  The ticket is stuck as
 being associated with "@".
 >
 > This is a very annoying problem.  I've tried manually changing the
 ticket's product association in PostgreSQL, but that causes an even bigger
 problem (The ticket will appear via Search and Tickets, but clicking on
 the ticket will result in an error page).

 Changing ticket product in ticket UI is not supported . Nevertheless you
 can

   - click ''Tickets'' menu item to go to the dashboard
   - click ''Custom Query'' to go to query form
   - select target tickets
   - expand batch modify box
   - in ''Add field'' combo box select ''Product''
   - select an existing product prefix .
   - input comment (optional)
   - click ''Change ticket'' button to commit your changes

 That has worked for me before ... I use this to move spam to an special
 [http://blood-hound.net/products/trash trash] product .

 Please let us know if that will work for you . Should you find any issues
 we'd like to know about the details .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #643: Inaccurate timestamps and ticket reporter

[Apache Bloodhound]

#643: Inaccurate timestamps and ticket reporter
+---
  Reporter:  olemis |  Owner:  rjollos
  Type:  defect | Status:  accepted
  Priority:  minor  |  Milestone:  Release 8
 Component:  ui design  |Version:  0.6.0
Resolution: |   Keywords:  ticket
+---

Comment (by olemis):

 Replying to [comment:3 rjollos]:
 > This patch seems to fix the issue:
 [...]

 very nice , indeed !

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #646: New Ticket Page needs a Cancel button

[Apache Bloodhound]

#646: New Ticket Page needs a Cancel button
--+
  Reporter:  ChrisHarris  |  Owner:  nobody
  Type:  enhancement  | Status:  new
  Priority:  major|  Milestone:
 Component:  ui design|Version:  0.6.0
Resolution:   |   Keywords:  new ticket
--+
Changes (by olemis):

 * keywords:   => new ticket
 * component:  dashboard => ui design


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #646: New Ticket Page needs a Cancel button

[Apache Bloodhound]

#646: New Ticket Page needs a Cancel button
--+
  Reporter:  ChrisHarris  |  Owner:  nobody
  Type:  enhancement  | Status:  new
  Priority:  major|  Milestone:
 Component:  dashboard|Version:  0.6.0
Resolution:   |   Keywords:
--+

Comment (by olemis):

 Replying to [comment:1 rjollos]:
 [...]
 >
 > On a related note, the QCT form has a //Cancel// button, but we could
 just as well name this button //Close//. It does clear the fields of the
 form though, so perhaps //Cancel// is more appropriate.

 fwiw +

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #646: New Ticket Page needs a Cancel button

[Apache Bloodhound]

#646: New Ticket Page needs a Cancel button
--+
  Reporter:  ChrisHarris  |  Owner:  nobody
  Type:  enhancement  | Status:  new
  Priority:  major|  Milestone:
 Component:  dashboard|Version:  0.6.0
Resolution:   |   Keywords:
--+

Comment (by rjollos):

 Clicking the //Cancel// button on other "add" pages takes you back to the
 page where you clicked //Add //. For example, from the Report
 List (`/report`) page you click //Create new report//. If you click
 //Cancel//, you are taken back to the Report List page. You'll find the
 behavior is similar for Milestones.

 If we were to add a //Cancel// button on the New ticket form, it could
 take you back to the Home page as you suggest, which could either be
 WikiStart or Default handler. However, you can get back to WIkiStart by
 just clicking on the Wiki entry on the mainnav, and clicking on the
 Bloodhound logo in the upper right takes you to the default handler.

 I guess a //Cancel// button is fine, but it's not strictly necessary for
 consistency in navigation links.

 On a related note, the QCT form has a //Cancel// button, but we could just
 as well name this button //Close//. It does clear the fields of the form
 though, so perhaps //Cancel// is more appropriate.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #645: "Enter ticket summary" field collapses

[Apache Bloodhound]

#645: "Enter ticket summary" field collapses
--+---
  Reporter:  ChrisHarris  |  Owner:  rjollos
  Type:  defect   | Status:  accepted
  Priority:  major|  Milestone:  Release 8
 Component:  dashboard|Version:  0.6.0
Resolution:   |   Keywords:
--+---

Comment (by rjollos):

 I noticed another issue present in Firefox, but not Chrome. Clicking in
 the //Enter new comment// `textarea` should cause the textarea to expand.
 However for Firefox, the `textarea` only expands after the following
 steps:
  1. Click in the `textarea` but don't enter any text
  1. Click elsewhere on the page
  1. Click in the `textarea` again

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #645: "Enter ticket summary" field collapses

[Apache Bloodhound]

#645: "Enter ticket summary" field collapses
--+---
  Reporter:  ChrisHarris  |  Owner:  rjollos
  Type:  defect   | Status:  accepted
  Priority:  major|  Milestone:  Release 8
 Component:  dashboard|Version:  0.6.0
Resolution:   |   Keywords:
--+---

Comment (by rjollos):

 Bootstrap has the following CSS rule:
 {{{#!css
 h1, h2, h3 {
 line-height: 40px;
 }
 }}}

 The issue seems to be resolved if we add the following to Bloodhound.css:
 {{{#!css
 h1, h2, h3 {
  min-height: 40px;
 }
 }}}

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #645: "Enter ticket summary" field collapses

[Apache Bloodhound]

#645: "Enter ticket summary" field collapses
--+---
  Reporter:  ChrisHarris  |  Owner:  rjollos
  Type:  defect   | Status:  accepted
  Priority:  major|  Milestone:  Release 8
 Component:  dashboard|Version:  0.6.0
Resolution:   |   Keywords:
--+---
Changes (by rjollos):

 * owner:  nobody => rjollos
 * status:  new => accepted
 * milestone:   => Release 8


Comment:

 It works okay in Chrome 28, but I've reproduced in Firefox 23.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #643: Inaccurate timestamps and ticket reporter

[Apache Bloodhound]

#643: Inaccurate timestamps and ticket reporter
+---
  Reporter:  olemis |  Owner:  rjollos
  Type:  defect | Status:  accepted
  Priority:  minor  |  Milestone:  Release 8
 Component:  ui design  |Version:  0.6.0
Resolution: |   Keywords:  ticket
+---
Changes (by rjollos):

 * owner:  nobody => rjollos
 * status:  new => accepted
 * milestone:   => Release 8


Comment:

 This patch seems to fix the issue:
 {{{#!diff
 ===
 --- bloodhound_theme/bhtheme/theme.py   (revision 1517446)
 +++ bloodhound_theme/bhtheme/theme.py   (working copy)
 @@ -363,14 +363,15 @@
   is_active)

  #add a creation event to the changelog if the ticket exists
 -if data['ticket'].exists:
 +ticket = data['ticket']
 +if ticket.exists:
  data['changes'] = [{'comment': '',
 -'author': data['author_id'],
 +'author': ticket['reporter'],
  'fields': {u'reported': {'label':
 u'Reported'},
 },
  'permanent': 1,
  'cnum': 0,
 -'date': data['start_time'],
 +'date': ticket['time'],
  },
 ] + data['changes']
  #and set default order
 }}}

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #650: QCT allows ticket to be created without a summary

[Apache Bloodhound]

#650: QCT allows ticket to be created without a summary
+---
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  accepted
  Priority:  major  |  Milestone:  Release 8
 Component:  dashboard  |Version:  0.6.0
Resolution: |   Keywords:  qct
+---
Changes (by rjollos):

 * status:  new => accepted
 * keywords:   => qct
 * component:   => dashboard
 * owner:   => rjollos
 * milestone:   => Release 8


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #648: div tag rendered at bottom of page

[Apache Bloodhound]

#648: div tag rendered at bottom of page
--+---
  Reporter:  ChrisHarris  |  Owner:  rjollos
  Type:  defect   | Status:  closed
  Priority:  minor|  Milestone:  Release 8
 Component:  dashboard|Version:  0.6.0
Resolution:  fixed|   Keywords:  jQuery-UI
--+---
Changes (by rjollos):

 * keywords:   => jQuery-UI
 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 This has been reported in jQuery UI, see jQuery-UI:4111. The workaround in
 jQuery-UI:4111#comment:11 seems to work well, and the issue should be
 fixed in jQuery UI 1.9 (we are using jQuery UI 1.8.21 via Trac). Trac has
 scheduled an upgrade to jQuery UI to 1.10 or later (t:#11019).

 

 (In [1517466])

 0.8dev: Applied workaround to hide the datepicker `div` at the bottom of
 the page. Refs #648.

 The workaround can be removed after upgrading to jQuery UI 1.9.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

svn commit: r1517466 - /bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css

[rjollos]

Author: rjollos
Date: Mon Aug 26 08:54:13 2013
New Revision: 1517466

URL: http://svn.apache.org/r1517466
Log:
0.8dev: Applied workaround to hide the datepicker `div` at the bottom of the 
page. Refs #648.

The workaround can be removed after upgrading to jQuery UI 1.9.

Modified:
bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css?rev=1517466&r1=1517465&r2=1517466&view=diff
==
--- bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css (original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css Mon Aug 26 
08:54:13 2013
@@ -847,6 +847,7 @@ tt {
  border: 1px solid #DD;
  border-radius: 3px 3px 3px 3px;
  box-shadow: 0 1px 0 #FF inset;
+ display: none; /* can be removed after upgrading to jQuery UI 1.9 
(http://bugs.jqueryui.com/ticket/4111 */
  list-style: none outside none;
  margin: 0 0 18px;
  padding: 7px 14px;

Re: [Apache Bloodhound] #644: Crash on SMTP failure notifying ticket relations update

[Apache Bloodhound]

#644: Crash on SMTP failure notifying ticket relations update
+
  Reporter:  olemis |  Owner:  astaric
  Type:  defect | Status:  closed
  Priority:  blocker|  Milestone:
 Component:  relations  |Version:  0.6.0
Resolution:  fixed  |   Keywords:  smtp notifications
+
Changes (by astaric):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 I have moved the code that creates notification form api to web_ui, where
 exceptions are handled and appropriate warning is displayed.

 Related commits:
 r1517457, r1517459

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

[Apache Bloodhound] InterMapTxt modified

[Apache Bloodhound]

Page "InterMapTxt" was changed by rjollos
Diff URL: 

Revision 11
Changes:
---8<--8<--8<--8<--8<--8<--8<--8<
Index: InterMapTxt
=
--- InterMapTxt (version: 10)
+++ InterMapTxt (version: 11)
@@ -45,6 +45,8 @@
 BEP /bloodhound/wiki/Proposals/BEP-# Bloodhound Enhancement Proposal $1
 
 src  http://svn.apache.org/viewvc/bloodhound/$1 # Bloodhound source file $1
+
+jQuery-UI http://bugs.jqueryui.com/ticket/$1 # jQuery UI issue $1
 
 PEP http://www.python.org/peps/pep-$1.html# Python Enhancement Proposal
 PythonBughttp://bugs.python.org/issue$1   # Python Issue #$1
---8<--8<--8<--8<--8<--8<--8<--8<

--
Page URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

This is an automated message. Someone added your email address to be
notified of changes on 'InterMapTxt' page.
If it was not you, please report to .

svn commit: r1517459 - /bloodhound/trunk/bloodhound_relations/bhrelations/tests/notification.py

[astaric]

Author: astaric
Date: Mon Aug 26 08:33:55 2013
New Revision: 1517459

URL: http://svn.apache.org/r1517459
Log:
Fixed notification tests.

Notifications are no longer created in api, so
they have to be constructed manually in tests.
Refs: #644

Modified:
bloodhound/trunk/bloodhound_relations/bhrelations/tests/notification.py

Modified: 
bloodhound/trunk/bloodhound_relations/bhrelations/tests/notification.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_relations/bhrelations/tests/notification.py?rev=1517459&r1=1517458&r2=1517459&view=diff
==
--- bloodhound/trunk/bloodhound_relations/bhrelations/tests/notification.py 
(original)
+++ bloodhound/trunk/bloodhound_relations/bhrelations/tests/notification.py Mon 
Aug 26 08:33:55 2013
@@ -69,8 +69,7 @@ class NotificationTestCase(BaseRelations
 relation = self.relations_system.add(
 ticket, ticket2, "dependent")
 
-rn = RelationNotifyEmail(self.env)
-rn.notify(relation)
+self.notifier.notify(relation)
 
 recipients = self.smtpd.get_recipients()
 # checks there is no duplicate in the recipient list
@@ -95,7 +94,8 @@ class NotificationTestCase(BaseRelations
 ticket = self._insert_and_load_ticket('Foo', reporter='anonymous')
 ticket2 = self._insert_and_load_ticket('Bar', reporter='anonymous')
 
-self.relations_system.add(ticket, ticket2, "dependent")
+relation = self.relations_system.add(ticket, ticket2, "dependent")
+self.notifier.notify(relation)
 
 sender = self.smtpd.get_sender()
 recipients = self.smtpd.get_recipients()
@@ -110,6 +110,7 @@ class NotificationTestCase(BaseRelations
 ticket2 = self._insert_and_load_ticket('Bar', reporter='anonymous')
 
 relation = self.relations_system.add(ticket, ticket2, "dependent")
+self.notifier.notify(relation)
 
 relations = self.env.db_direct_query(
 "SELECT * FROM bloodhound_relations")

svn commit: r1517457 - in /bloodhound/trunk/bloodhound_relations/bhrelations: api.py tests/base.py tests/web_ui.py web_ui.py

[astaric]

Author: astaric
Date: Mon Aug 26 08:27:40 2013
New Revision: 1517457

URL: http://svn.apache.org/r1517457
Log:
Catch error when relation notification fails.

Display a warning instead.
Refs: #644

Modified:
bloodhound/trunk/bloodhound_relations/bhrelations/api.py
bloodhound/trunk/bloodhound_relations/bhrelations/tests/base.py
bloodhound/trunk/bloodhound_relations/bhrelations/tests/web_ui.py
bloodhound/trunk/bloodhound_relations/bhrelations/web_ui.py

Modified: bloodhound/trunk/bloodhound_relations/bhrelations/api.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_relations/bhrelations/api.py?rev=1517457&r1=1517456&r2=1517457&view=diff
==
--- bloodhound/trunk/bloodhound_relations/bhrelations/api.py (original)
+++ bloodhound/trunk/bloodhound_relations/bhrelations/api.py Mon Aug 26 
08:27:40 2013
@@ -269,9 +269,6 @@ class RelationsSystem(Component):
 for listener in self.changing_listeners:
 listener.adding_relation(relation)
 
-from bhrelations.notification import RelationNotifyEmail
-RelationNotifyEmail(self.env).notify(relation)
-
 def delete(self, relation_id, when=None):
 if when is None:
 when = datetime.now(utc)

Modified: bloodhound/trunk/bloodhound_relations/bhrelations/tests/base.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_relations/bhrelations/tests/base.py?rev=1517457&r1=1517456&r2=1517457&view=diff
==
--- bloodhound/trunk/bloodhound_relations/bhrelations/tests/base.py (original)
+++ bloodhound/trunk/bloodhound_relations/bhrelations/tests/base.py Mon Aug 26 
08:27:40 2013
@@ -18,7 +18,8 @@
 from _sqlite3 import OperationalError
 from tests.env import MultiproductTestCase
 from multiproduct.env import ProductEnvironment
-from bhrelations.api import RelationsSystem, EnvironmentSetup
+from bhrelations.api import RelationsSystem, EnvironmentSetup, \
+RELATIONS_CONFIG_NAME
 from trac.test import EnvironmentStub, Mock, MockPerm
 from trac.ticket import Ticket
 from trac.util.datefmt import utc
@@ -43,7 +44,7 @@ class BaseRelationsTestCase(Multiproduct
'BlockerValidator')
 env.config.set('bhrelations', 'duplicate_relation',
'duplicateof')
-config_name = RelationsSystem.RELATIONS_CONFIG_NAME
+config_name = RELATIONS_CONFIG_NAME
 env.config.set(config_name, 'dependency', 'dependson,dependent')
 env.config.set(config_name, 'dependency.validators',
'NoCycles,SingleProduct')
@@ -72,7 +73,8 @@ class BaseRelationsTestCase(Multiproduct
 
 self.req = Mock(href=self.env.href, authname='anonymous', tz=utc,
 args=dict(action='dummy'),
-locale=locale_en, lc_time=locale_en)
+locale=locale_en, lc_time=locale_en,
+chrome={'warnings': []})
 self.req.perm = MockPerm()
 self.relations_system = RelationsSystem(self.env)
 self._upgrade_env()

Modified: bloodhound/trunk/bloodhound_relations/bhrelations/tests/web_ui.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_relations/bhrelations/tests/web_ui.py?rev=1517457&r1=1517456&r2=1517457&view=diff
==
--- bloodhound/trunk/bloodhound_relations/bhrelations/tests/web_ui.py (original)
+++ bloodhound/trunk/bloodhound_relations/bhrelations/tests/web_ui.py Mon Aug 
26 08:27:40 2013
@@ -86,6 +86,20 @@ class RelationManagementModuleTestCase(B
 
 self.assertEqual(len(data["relations"]), 1)
 
+def test_failure_to_notify_does_not_result_in_error(self):
+t2 = self._insert_ticket(self.env, "Bar")
+self.req.args['add'] = True
+self.req.args['dest_tid'] = str(t2)
+self.req.args['reltype'] = 'dependson'
+rlm = RelationManagementModule(self.env)
+rlm.notify_relation_changed = self._failing_notification
+
+url, data, x = rlm.process_request(self.req)
+self.assertEqual(len(self.req.chrome['warnings']), 1)
+
+def _failing_notification(self, relation):
+raise Exception()
+
 def process_request(self):
 url, data, x = RelationManagementModule(self.env).process_request(
 self.req)

Modified: bloodhound/trunk/bloodhound_relations/bhrelations/web_ui.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_relations/bhrelations/web_ui.py?rev=1517457&r1=1517456&r2=1517457&view=diff
==
--- bloodhound/trunk/bloodhound_relations/bhrelations/web_ui.py (original)
+++ bloodhound/trunk/bloodhound_relations/bhrelations/web_ui.py Mon Aug 26 
08:27:40 2013
@@ -29,6 +29,7 @@ import re
 from trac.core import Component, im

Re: [Apache Bloodhound] #649: Clicking on "... more" hyperlink within dashboard results in error

[Apache Bloodhound]

#649: Clicking on "... more" hyperlink within dashboard results in error
--+---
  Reporter:  ChrisHarris  |  Owner:  rjollos
  Type:  defect   | Status:  accepted
  Priority:  major|  Milestone:  Release 8
 Component:  dashboard|Version:  0.6.0
Resolution:   |   Keywords:
--+---

Comment (by rjollos):

 Since `href` is an instance `ProductizedHref`, it seems like we just want
 to create a URL that points to the dashboard for the product.

 {{{#!diff
 diff --git a/bloodhound_dashboard/bhdashboard/widgets/product.py
 b/bloodhound_da
 index 2179676..1809ba3 100644
 --- a/bloodhound_dashboard/bhdashboard/widgets/product.py
 +++ b/bloodhound_dashboard/bhdashboard/widgets/product.py
 @@ -111,7 +111,7 @@ class ProductWidget(WidgetBase):
  q.name = _('... more')
  q.ticket_count = None
  q.url = href(resource['name']) if resource.get('hrefurl') \
 -else href.product(product.prefix)
 +else href.dashboard()
  results.append(q)

  return results
 }}}

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

svn commit: r1517450 - /bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py

[rjollos]

Author: rjollos
Date: Mon Aug 26 07:57:13 2013
New Revision: 1517450

URL: http://svn.apache.org/r1517450
Log:
0.8dev: PEP-0008 whitespace changes.

Modified:
bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py

Modified: bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py?rev=1517450&r1=1517449&r2=1517450&view=diff
==
--- bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py 
(original)
+++ bloodhound/trunk/bloodhound_dashboard/bhdashboard/widgets/product.py Mon 
Aug 26 07:57:13 2013
@@ -41,18 +41,21 @@ from multiproduct.hooks import Productiz
 
 __metaclass__ = type
 
+
 class ProductWidget(WidgetBase):
 """Display products available to the user.
 """
+
 def get_widget_params(self, name):
 """Return a dictionary containing arguments specification for
 the widget with specified name.
 """
-return {'max' : {'desc' : """Limit the number of products displayed""",
- 'type' : int},
-'cols' : {'desc' : """Number of columns""",
-  'type' : int}
-}
+return {
+'max': {'desc': """Limit the number of products displayed""",
+'type': int},
+'cols': {'desc': """Number of columns""",
+ 'type': int}
+}
 
 get_widget_params = pretty_wrapper(get_widget_params, check_widget_name)
 
@@ -71,12 +74,15 @@ class ProductWidget(WidgetBase):
 
 query = resource['type'].select(penv)
 for q in itertools.islice(query, max_):
-q.url = href(resource['name'], q.name) if resource.get('hrefurl') \
-else Query.from_string(penv, 'order=priority&%s=%s' %
-(resource['name'], q.name)).get_href(href)
-q.ticket_count = penv.db_query(
-"""SELECT COUNT(*) FROM ticket WHERE ticket.%s='%s'
-   AND ticket.status <> 'closed'""" % (resource['name'], 
q.name))[0][0]
+q.url = href(resource['name'], q.name) \
+if resource.get('hrefurl') \
+else Query.from_string(
+penv, 'order=priority&%s=%s' %
+  (resource['name'], q.name)).get_href(href)
+q.ticket_count = penv.db_query("""
+SELECT COUNT(*) FROM ticket WHERE ticket.%s='%s'
+AND ticket.status <> 'closed'
+""" % (resource['name'], q.name))[0][0]
 
 results.append(q)
 
@@ -89,9 +95,10 @@ class ProductWidget(WidgetBase):
 q = resource['type'](penv)
 q.name = '(No %s)' % (resource['name'],)
 q.url = Query.from_string(penv,
-'status=!closed&col=id&col=summary&col=owner'
-'&col=status&col=priority&order=priority&%s=' %
-(resource['name'],)).get_href(href)
+   'status=!closed&col=id&col=summary&col=owner'
+   '&col=status&col=priority&order=priority&%s='
+   % (resource['name'],)
+).get_href(href)
 q.ticket_count = ticket_count
 results.append(q)
 
@@ -122,31 +129,27 @@ class ProductWidget(WidgetBase):
 for p in Product.select(self.env):
 if 'PRODUCT_VIEW' in req.perm(Neighborhood('product', 
p.prefix)):
 for resource in (
-{ 'type': Milestone, 'name': 'milestone', 'hrefurl': 
True },
-{ 'type': Component, 'name': 'component' },
-{ 'type': Version, 'name': 'version' },
+{'type': Milestone, 'name': 'milestone', 'hrefurl': 
True},
+{'type': Component, 'name': 'component'},
+{'type': Version, 'name': 'version'},
 ):
 setattr(p, resource['name'] + 's',
-self._get_product_info(p, resource, max_))
-p.owner_link = Query.from_string(self.env, 
'status!=closed&'
-'col=id&col=summary&col=owner&col=status&col=priority&'
-'order=priority&group=product&owner=%s'
-% (p._data['owner'] or '', )).get_href(req.href)
+self._get_product_info(p, resource, max_))
+p.owner_link = Query.from_string(self.env,
+'status!=closed&col=id&col=summary&col=owner'
+'&col=status&col=priority&order=priority'
+'&group=product&owner=%s' % (p._data['owner'] or '', )
+).get_href(req.href)
 data.setdefault('product_list', []).append(p)
 title = _('Products')
 

Re: [Apache Bloodhound] #644: Crash on SMTP failure notifying ticket relations update

[Apache Bloodhound]

#644: Crash on SMTP failure notifying ticket relations update
+
  Reporter:  olemis |  Owner:  astaric
  Type:  defect | Status:  accepted
  Priority:  blocker|  Milestone:
 Component:  relations  |Version:  0.6.0
Resolution: |   Keywords:  smtp notifications
+
Changes (by astaric):

 * owner:  nobody => astaric
 * status:  new => accepted


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

[Apache Bloodhound] #650: QCT allows ticket to be created without a summary

[Apache Bloodhound]

#650: QCT allows ticket to be created without a summary
--+-
  Reporter:  rjollos  |Owner:
  Type:  defect   |   Status:  new
  Priority:  major|  Version:  0.6.0
Resolution:   |
--+-
 When creating a ticket through the full ticket form a summary is required,
 but the summary is not required when using the QCT form. We should at
 least be consistent, and requiring a summary seems like a good choice.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #647: Can't reassign ticket to another product once assigned to Default (@) product

[Apache Bloodhound]

#647: Can't reassign ticket to another product once assigned to Default (@)
product
---+
  Reporter:  ChrisHarris   |  Owner:  nobody
  Type:  defect| Status:  new
  Priority:  major |  Milestone:
 Component:  multiproduct  |Version:  0.6.0
Resolution:|   Keywords:
---+
Changes (by astaric):

 * owner:   => nobody
 * component:   => multiproduct


Comment:

 We are aware that there is currently no automatic way to transfer tickets
 between products. There is currently an open proposal concerning ticket
 id-s (Proposals/BEP-0010) that needs to be implemented before we can start
 working on transferring tickets between products.

 Meanwhile, manually changing the product field in the database should
 work, but you need to be careful, to also modify related tables
 (ticket_change, ticket_custom, attachment, bloodhound_relations).

 Search index update will not be triggered, if you modify data directly, so
 you should do it manually by running
 {{{
 trac admin path/to/your/env bhsearch rebuild
 }}}

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker