Re: [PR] [CALCITE-6302] Release Calcite 1.37.0 [calcite]
sonarcloud[bot] commented on PR #3768: URL: https://github.com/apache/calcite/pull/3768#issuecomment-2071131640 ## [](https://sonarcloud.io/dashboard?id=apache_calcite=3768) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite=3768=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_calcite=3768=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3768=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite=3768) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6322] Casts to DECIMAL types are ignored [calcite]
sonarcloud[bot] commented on PR #3733: URL: https://github.com/apache/calcite/pull/3733#issuecomment-2071120406 ## [](https://sonarcloud.io/dashboard?id=apache_calcite=3733) **Quality Gate passed** Issues  [8 New issues](https://sonarcloud.io/project/issues?id=apache_calcite=3733=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_calcite=3733=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3733=false=true)  [93.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite=3733=new_coverage=list)  [15.4% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite=3733=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite=3733) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6322] Casts to DECIMAL types are ignored [calcite]
mihaibudiu commented on PR #3733: URL: https://github.com/apache/calcite/pull/3733#issuecomment-207854 @zabetak I have tried to address your comments. In the process I found at least one more bug in my PR, the rounding mode is really DOWN and not FLOOR. This was found through the new tests you requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [CALCITE-6302] Release Calcite 1.37.0 [calcite]
snuyanzin opened a new pull request, #3768: URL: https://github.com/apache/calcite/pull/3768 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(calcite) annotated tag calcite-1.37.0-rc0 updated (53fd905eb4 -> b5e787e386)
This is an automated email from the ASF dual-hosted git repository. snuyanzin pushed a change to annotated tag calcite-1.37.0-rc0 in repository https://gitbox.apache.org/repos/asf/calcite.git *** WARNING: tag calcite-1.37.0-rc0 was modified! *** from 53fd905eb4 (commit) to b5e787e386 (tag) tagging 53fd905eb4c730b4bedd49fa6569d5b0de47f021 (commit) replaces calcite-1.36.0 by Sergey Nuyanzin on Tue Apr 23 00:21:39 2024 +0200 - Log - --- No new revisions were added by this update. Summary of changes:
svn commit: r68720 - in /dev/calcite/apache-calcite-1.37.0-rc0: apache-calcite-1.37.0-src.tar.gz apache-calcite-1.37.0-src.tar.gz.asc apache-calcite-1.37.0-src.tar.gz.sha512
Author: snuyanzin Date: Mon Apr 22 22:45:57 2024 New Revision: 68720 Log: Uploading release candidate Apache Calcite calcite-1.37.0-rc0 to dev area Modified: dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz.asc dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz.sha512 Modified: dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz == (empty) Modified: dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz.asc == (empty) Modified: dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz.sha512 == (empty)
Re: [PR] [CALCITE-6322] Casts to DECIMAL types are ignored [calcite]
mihaibudiu commented on code in PR #3733:
URL: https://github.com/apache/calcite/pull/3733#discussion_r1575417379
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -598,6 +598,13 @@ void testCastBooleanToNumeric(CastType castType,
SqlOperatorFixture f) {
"Cast function cannot convert value of type BOOLEAN to type
DECIMAL\\(19, 0\\)", false);
}
+ /** Test case for https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-6322;>
+ * [CALCITE-6322] Casts to DECIMAL types are ignored. */
Review Comment:
I will re-enable many of these tests, but this doesn't completely solve the
cases covered by SqlOperatorTest.DECIMAL. I have filed a new issue
https://issues.apache.org/jira/browse/CALCITE-6379 that covers arithmetic.
Moreover, the current PR also does not cover casts from STRING and INTERVAL. I
have filed https://issues.apache.org/jira/browse/CALCITE-6380 to cover these
two cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
svn commit: r68718 - in /dev/calcite/apache-calcite-1.37.0-rc0: ./ apache-calcite-1.37.0-src.tar.gz apache-calcite-1.37.0-src.tar.gz.asc apache-calcite-1.37.0-src.tar.gz.sha512
Author: snuyanzin Date: Mon Apr 22 22:21:27 2024 New Revision: 68718 Log: Uploading release candidate Apache Calcite calcite-1.37.0-rc0 to dev area Added: dev/calcite/apache-calcite-1.37.0-rc0/ dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz.asc dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz.sha512 Added: dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz == Binary files dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz (added) and dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz Mon Apr 22 22:21:27 2024 differ Added: dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz.asc == --- dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz.asc (added) +++ dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz.asc Mon Apr 22 22:21:27 2024 @@ -0,0 +1,17 @@ +-BEGIN PGP SIGNATURE- +Version: BCPG v1.68 + +iQIzBAABCgAdFiEE91KfriSBGlwN88p0FZa78HJoNdgFAmYm4tMACgkQFZa78HJo +NdhS3Q/8CTg7Tb6zcIX1z/ZKYCpfxl6aKxy0+97MPimdUfr/qyqljSw+iAjfNbHx +KPotDx6cE7vxM5hb/o3k93MxwRrEC+uq+ZFvnmtU7uesL8xlVLTrK6i8OuCOduVj +yGO8bkReQfWSQPW9PnpqwqcaoSRHIapHjpet1TCyKOMtSN1IG82Xe7YzSaaQOiR5 +aGVKqFuYBVYcVZfLLMCDFZYy1QyNInfUb5/QaW6DfFlx8F0gs1MW7N9UkIjFTzwJ +Av+soWE4ECvaobyDF5x27CAXgWtyetg3U1M9OQpGj7MvW8GYfJ4F8Cmc1SqLTkAx +Qbw4a/v6qZehy2wMFcWFmRkg0TE+jPJ0+378LFnYlZmgU70fS/3kjhwaIYmeHtVb +39SO8w8Fi8+azbVhdjN7ZwYaYeTfC+hHn1SHfKj/sdeGENEVmJjl6744ixlPftfv +f2Gf3mBRyGdztB/q1emJZTEvlKuBY51PEXBzhn4pY7JQuwT5xfEHCLFkjQJ4QuPM +K9HaPLFun2A1p3BNF9iSZycbwPqsHqb3auizXGxaUMgrkzH0blNXkDo10ZNxAWod +/QKf1u632YxPvyKu3vXmq+r4wIb4Lo6ffzzkHU/fy4Jp1N45M0J8NHQ3u3mEq3Rn +EzMH5fa+6HkUPvvLFbh/rB0u3K7NJrpdD/Kaxr3Yl2v95YrQs5c= +=kxqr +-END PGP SIGNATURE- Added: dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz.sha512 == --- dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz.sha512 (added) +++ dev/calcite/apache-calcite-1.37.0-rc0/apache-calcite-1.37.0-src.tar.gz.sha512 Mon Apr 22 22:21:27 2024 @@ -0,0 +1 @@ +b044fb94fd60710142edfe348ff20bbdc7e43f3d70a68b6520b65dc8fb2fe53f0ecf6b5d03b199b3212e9064a7dd04fb3995a9cd09cb8864a7bfdb5617feefbb *apache-calcite-1.37.0-src.tar.gz
Re: [PR] [CALCITE-6313] Add POWER function for PostgreSQL [calcite]
mihaibudiu commented on code in PR #3762:
URL: https://github.com/apache/calcite/pull/3762#discussion_r1575303020
##
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##
@@ -2006,7 +2006,7 @@ void checkPeriodPredicate(Checker checker) {
expr("1-2+3*4/5/6-7")
.ok("(((1 - 2) + (((3 * 4) / 5) / 6)) - 7)");
expr("power(2,3)")
-.ok("POWER(2, 3)");
+.ok("`POWER`(2, 3)");
Review Comment:
I don't know the answer to this question. But I know that Calcite can load
multiple libraries, and I believe a function will be resolved by trying the
libraries in order. I also am assuming that there is nothing special about the
standard operator table. So if you load the postgres operator table first,
perhaps the right POWER will be used?
A quick experiment should be able answer this question.
If this works, we should probably document that the right way to implement a
dialect is to load the dialect specific operator table first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CALCITE-6313] Add POWER function for PostgreSQL [calcite]
normanj-bitquill commented on code in PR #3762:
URL: https://github.com/apache/calcite/pull/3762#discussion_r1575298296
##
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##
@@ -2006,7 +2006,7 @@ void checkPeriodPredicate(Checker checker) {
expr("1-2+3*4/5/6-7")
.ok("(((1 - 2) + (((3 * 4) / 5) / 6)) - 7)");
expr("power(2,3)")
-.ok("POWER(2, 3)");
+.ok("`POWER`(2, 3)");
Review Comment:
Is it possible to have a power function in the standard operator table and
still have an override for PostgreSQL that is able to return a decimal in some
cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
svn commit: r68717 - /release/calcite/KEYS
Author: snuyanzin Date: Mon Apr 22 20:01:07 2024 New Revision: 68717 Log: [CALCITE] Add Sergey Nuyanzin's public key Modified: release/calcite/KEYS Modified: release/calcite/KEYS == --- release/calcite/KEYS (original) +++ release/calcite/KEYS Mon Apr 22 20:01:07 2024 @@ -2930,3 +2930,220 @@ B5wcMEduSwwuLvMb1c1L3ukZICx5JXrN+ZZaRd/m Yh8QRpb8wG8kRiO7VGn4WGJE2U6uqkc= =MnS6 -END PGP PUBLIC KEY BLOCK- +pub rsa4096 2020-12-11 [SC] + F7529FAE24811A5C0DF3CA741596BBF0726835D8 +uid [ unknown] Sergey Nuyanzin (CODE SIGNING KEY) +sig 31596BBF0726835D8 2023-11-23 Sergey Nuyanzin (CODE SIGNING KEY) +uid [ unknown] Sergey Nuyanzin (CODE SIGNING KEY) +sig 31596BBF0726835D8 2023-05-05 Sergey Nuyanzin (CODE SIGNING KEY) +sig D77C3383F1927570 2023-06-29 Stamatis Zampetakis +sig DF925FEBA08B032B 2023-06-29 Ruben Quesada Lopez +sig 55CA1C8070BE0BEE 2023-06-29 Benchao Li +sig D8D72C13CF2D8DDB 2023-06-29 Michael Mior +sig B989C696D102A552 2023-06-29 Xiong Duan (CODE SIGNING KEY) +uid [ unknown] Sergey Nuyanzin +sig 31596BBF0726835D8 2020-12-11 Sergey Nuyanzin (CODE SIGNING KEY) +sig D77C3383F1927570 2023-06-29 Stamatis Zampetakis +sig DF925FEBA08B032B 2023-06-29 Ruben Quesada Lopez +sig 55CA1C8070BE0BEE 2023-06-29 Benchao Li +sig D8D72C13CF2D8DDB 2023-06-29 Michael Mior +sig B989C696D102A552 2023-06-29 Xiong Duan (CODE SIGNING KEY) +sub rsa4096 2020-12-11 [E] +sig 1596BBF0726835D8 2023-06-28 Sergey Nuyanzin (CODE SIGNING KEY) + +-BEGIN PGP PUBLIC KEY BLOCK- + +mQINBF/Tdr8BEAC+L0xWxqIAzYdiJHvDhDta9QsEx7vk2dfwAU2oklJVEnTcsLtB +Rnd3HIK15TUGzHHWgrc1imboHTyLpGPZXKk6oZvyhGNlw5sjkvKVPtI77DrJ+Cs3 +S4BRCBu8sSyo3ciuczG7ZYKWWnhLsbgnol2I1tGh8HIPxBu75Jza8gZXkckQpTLM +rutHXjZlkAPefucqOC2u/h1LLlE+FXUfhw6FyBasQO6sXDde58D7ciqZXSkxuwmN +06X5tfqKPdtFnYLJFD2C4qW9Y9f5Y2dn8XdLibeMZkpmZTmvbXFyP2z4gR1cjZ8a +x+9dw0tkn8ZjBq9cHaN61hNpCZCsveVKBSF/YBYibhmFM86cMh3vnvcC8pdl7hX4 +mMMjW5v7HO6wrjzZY+lO5vm1VWGmE3uwvsrkOO834lobRQVC4QIdXj3bcoCwX1NE +BcaRkxUIWi9bW0g1uLtLASrSCf/x0ZrpMUKwLAV5AOYEeFGMtxa5VsbPjezfVz0c +yYNnJSU0g5duWPGhkptFM2lTMmxtuRmod2mAOfEniti+U3+bv6eT8gBYAV0wqkGM +/KVn13lLFUbRzGqk/moxq7uTsSaGQaD9ZVnHucDNjSboMpPQie4D37UTOmV1ygZ0 +ZFSrxPFajd04I5spjNtklCwRot/oGgk8LQJ2yV4xfIhUrt80b/5MGM5frwARAQAB +tDhTZXJnZXkgTnV5YW56aW4gKENPREUgU0lHTklORyBLRVkpIDxzbnV5YW56aW5A +Z21haWwuY29tPokCRgQTAQoAMBYhBPdSn64kgRpcDfPKdBWWu/ByaDXYBQJkVMkh +AhsDAgsJAxUKCAIWAAIeBQIXgAAKCRAVlrvwcmg12EgjEACbUCNgxiOB4e2LeRFg +4Uzk4JujtJIxkiRSyXtBUkYDLmJlv1dlWH/H7Ox9e88y/NWKMI9sQGGsMpLGLMI0 +26Q9Ew/Rid6LWX2mJY1AngbZEN0oPzvHo5PJQ14L5WCCcXIUUrpiwkcr/R+QyINU ++DDNvuFOORy0z3e09vI7//BIsatAc2fvHqmQAB4ZLEAK5OM1NoKvg1pkhYAyYLuz +53U5pbDXIJ4lN5mn99jcEoQGvoNgO9MLs8AgU04e99UhEzNlKa4eJWJCKozllsJc +lLPeQM36ijzU+0O/CQipVtTcbXuZaW1PmCYVT0CL7WM1sofjYM+Bx4JiEyJMKj+n +ZWKMVAMElOBPwlXSt5lQTGIIhVgRxM0AvVP7u0Nsty/XfKr+sUdRROwvU19nNQEY +je5h07qgXtbYR1mLbWgcrezmoazGD2k4eFuBzCeRh9hYA5D+8shaSaRe/FznxmKa +GakWuRtTxtlWeAx33Gp8jqDOgEuJWGCEe8iPKI3GuSJwCASSNSC02KaWnBND9re7 +od92cIXpNgdS/hOoa5CA1M3mlFEdTAxUnbgNB+EoCIzxMtl5RFlhmCyvCXseabd+ +PNE8tTAK/EqkYWAEC6uSSPu9SOXBljzY2qwfyoZBqGME4RyTm7Rl3fNHBShZdsOZ +8etSd82Wl4cifv3U7spTbWLy8YkCMwQQAQoAHRYhBAR0lXf9k0Z0uc1Fxdd8M4Px +knVwBQJknX3+AAoJENd8M4PxknVwvVkP/3+24mTL71ovlN/Z8t9NR8SA7WbAZRGe +5rv7c0ZwXY8lOdrB6bkzjHof7h//bQKYoIe1iOOj7XWny9ybTKFwtWBABmq2zgTC +votNFnEE4gLd6ysmUUAdkoq+7v703UogWy6EvlZQMlXZ3YmxRigN86ygSTMr+59j +tZmY/6u4tbJYK2HKpxSwzwH23jeWZM2Zc/+7M71Ew9P2zb5QsDBT9qK7ms88p25P +DhRKsu3zZqlTb5xHpB3rP2ABmkVCkraK89FIADRRd1jOTAqyD/c6CZ4z+KeznWOi +eeMgFPlF2q4aH9upAFCt+YaZ23kZyxVdb5K5cBEq7uooxy5yL7fhnc2W4K6xHCq+ +iyprw7zOtpju7WBe2wNP+ohiQOqdX6gcUOYesHWOKNENNZu3hfuqsCGhqCsmF4/W +plP6aln+AGBsSrgafvsX0HPlKtgssBoRsCJjfxKsP8hCrYA/SpI5kEcruUGGw1Ix +Hfp6tO3WQbBIHrIz86nPtDcvStgDqAF2paqnOQygatIM5x2hWVTnrQQWBwg6cAK3 +4t5/CToNCamMdF6wiypetr8rrv5SusrHMbIXxiHy9lYAl29mTcxYe51QGQvcw8UR +41maj25CmWUT/utrQL1eDWDui2T5XZH7rRZkKS4Oih56ZZfl0dW9r56Wr5kkEZXf +f0ac9MFhtHC2iQIzBBABCAAdFiEERk+ko9fkIRLky2jy35Jf66CLAysFAmSdfgcA +CgkQ35Jf66CLAysezg//WvpmFcCkr6Bp5UezjEId2ipjoGVE/uu0GFJMd6b1pcp9 +mSE92t6hrWi4NsNcEWpCdT4eadJnCy8fE7jRAVQ6P2IbA8hGOJ/X5sDhlirNjtxb +kr5Wl8wVo716kiaY8TCkrjp8MIbzqt7Jgz3ZtWJy/8kLDjLM5n/vDxON+LK/VPaa +782bXeKfg4oDSQieO1oL69Ur4+M6rfCrVoOAUu/WO+xSWPDNluXzzlbLthbVBkSN +S47jIK47AQsJ1y0hl2gMTOnBEU2X4sOX2TeJMLpTu252No/sICAjblMwUiOiKXR8 +BE7D5ko1E7n7BOkP+2P4W1hgAmsVfreMEUlPb6+/4xE+Yvd9wnhOu3IC2UTZQeLj +blDPR6Z3g1QvKTfNps0xOxGbz6pZMqP2SaldKtn8eThZuC0cP3dQhHkguqbAcjPd +EKQZ0z4CrPUMoItS8XPXgwZq/zcc+5TDMyLFk5vvSFkKhX3pMjM+bn6NOPEa/ctC +a+dyvYGkIXAyON2ifO4Oi35sivKIUlXTfxSG34HsZ0lM6hp+pgs3VDaLh033PXVr +NWqrGjoFyayMH+BiBRYe5QGjGL2F3CSivR+LWqcnkSAVgioTs6JtrVEklzeNqABd +Oya5cJJWp2FAAhZ69jJ0phCYnObmd+cdc9tiqkJdoRFGtZOnaENQVMdIcLj5GUmJ
(calcite) branch main updated: [CALCITE-6316] Update Javadoc for CALCITE-5607
This is an automated email from the ASF dual-hosted git repository.
snuyanzin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 153494 [CALCITE-6316] Update Javadoc for CALCITE-5607
153494 is described below
commit 153494207c24318d4c1d2c908df4a15c4aa4
Author: Oliver Lee
AuthorDate: Fri Mar 8 00:34:14 2024 +
[CALCITE-6316] Update Javadoc for CALCITE-5607
---
core/src/test/java/org/apache/calcite/plan/RelWriterTest.java | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
b/core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
index ccb375503d..fd9499510e 100644
--- a/core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
+++ b/core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
@@ -1055,12 +1055,8 @@ class RelWriterTest {
}
/** Test case for
- * https://issues.apache.org/jira/browse/CALCITE-5607;>[CALCITE-5607]
- *
- * Before the fix, RelJson.toRex would throw an ArrayIndexOutOfBounds
error
- * when deserializing MINUS_DATE due to type inference requiring 3 operands.
- *
- * The solution is to add in 'type' when serializing to JSON.
+ * https://issues.apache.org/jira/browse/CALCITE-5607;>[CALCITE-5607]
+ * Datetime MINUS throws ArrayIndexOutOfBounds error when serializing
toRex.
*/
@Test void testDeserializeMinusDateOperator() {
final FrameworkConfig config = RelBuilderTest.config().build();
Re: [PR] [CALCITE-6316] Update Javadoc for CALCITE-5607 [calcite]
snuyanzin merged PR #3719: URL: https://github.com/apache/calcite/pull/3719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6322] Casts to DECIMAL types are ignored [calcite]
mihaibudiu commented on code in PR #3733: URL: https://github.com/apache/calcite/pull/3733#discussion_r1575214858 ## core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java: ## @@ -1836,7 +1836,7 @@ public static boolean isValidDecimalValue(@Nullable BigDecimal value, RelDataTyp case DECIMAL: final int intDigits = value.precision() - value.scale(); final int maxIntDigits = toType.getPrecision() - toType.getScale(); - return intDigits <= maxIntDigits; + return (intDigits <= maxIntDigits) && (value.scale() <= toType.getScale()); Review Comment: The question is really about what this function is supposed to implement. My assumption is that this function decides whether a BigDecimal value can be represented exactly in the specified type. In this case I believe that both conditions need to be satisfied. If the scale is not large enough, the number may need rounding to be represented, so the representation won't be exact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6322] Casts to DECIMAL types are ignored [calcite]
mihaibudiu commented on code in PR #3733:
URL: https://github.com/apache/calcite/pull/3733#discussion_r1575207451
##
druid/src/test/java/org/apache/calcite/test/DruidAdapter2IT.java:
##
@@ -1909,10 +1909,14 @@ private void checkGroupBySingleSortLimit(boolean
approx) {
+ "end as b from \"foodmart\" group by \"store_state\" order by a
desc";
final String postAggString =
"'postAggregations':[{'type':'expression','name':'A',"
+ "'expression':'(\\'$f1\\' /
\\'$f2\\')'},{'type':'expression','name':'B',"
-+ "'expression':'case_searched((\\'$f3\\' == 0),1.0,CAST(\\'$f3\\'";
++ "'expression':'case_searched((\\'$f3\\' == 0),1,CAST(\\'$f3\\'";
final String plan = "PLAN="
+ "EnumerableInterpreter\n"
-+ " DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[$63, $90, $91, $89]], groups=[{0}], aggs=[[SUM($1), SUM($2),
SUM($3)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n";
++ " DruidQuery(table=[[foodmart, foodmart]],"
++ " intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],"
++ " projects=[[$63, $90, $91, $89]], groups=[{0}], aggs=[[SUM($1),
SUM($2), SUM($3)]],"
++ " post_projects=[[$0, /($1, $2), CASE(=($3, 0), CAST(1:DECIMAL(19,
0)):DECIMAL(19, 0),"
Review Comment:
I suspect this is some lack of optimization in the Druid code generator,
which doesn't remove redundant casts. If we think this is a bug, I suggest we
file a new issue to deal with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CALCITE-6322] Casts to DECIMAL types are ignored [calcite]
mihaibudiu commented on code in PR #3733: URL: https://github.com/apache/calcite/pull/3733#discussion_r1575204316 ## babel/src/test/resources/sql/redshift.iq: ## @@ -523,78 +523,78 @@ select deptno, ratio_to_report(sal) over (partition by deptno) from emp; !} # STDDEV_POP -select empno, stddev_pop(comm) over (order by empno rows unbounded preceding) from emp where deptno = 30 order by 1; +select empno, stddev_pop(CAST(comm AS DECIMAL(12, 4))) over (order by empno rows unbounded preceding) from emp where deptno = 30 order by 1; Review Comment: Initially I had filed issue https://issues.apache.org/jira/browse/CALCITE-6324 about this problem. See the comments there as well. Indeed, in Calcite, as in Oracle, the result type of an aggregate is the same as the type of the value aggregated. Moreover, the Calcite implementation of aggregates also uses *internally* the same type for all calculations. Since STDDEV needs to square values, it requires double the precision not to overflow. So without changing the type here, this program would fail because of overflows for decimal values (prior to this PR such overflows were simply ignored, which is wrong). The problem of internal overflows could be solved in two ways: (1) change the internal implementation of all aggregation functions that could overflow to use a different precision for intermediate results. (2) require the user to use a type wide enough to accommodate possible overflows Now, unfortunately the compiler cannot choose safely a type to guarantee that the results won't overflow, even for a simple aggregate such as AVG. The reason is that, although the compiler has a bound on the precision of the values aggregated, in general it has no bound on the number of rows in the table at runtime (especially for cases like incremental view maintenance, where the plans generated need to work even for future contents of the tables). So no matter what precision the compiler may choose for internal computations, this precision may be exceeded at runtime for some input data. This leaves the other alternative: the user should choose a precision high enough to carry all computations. Although the user may also not know the size of the tables, at least the user has some domain-specific knowledge. So this PR adopts the approach in (2), which is also compatible with the existing Calcite implementation of aggregates. If we want to implement (1), it will require much more work, we have to modify the implementation of all Calcite aggregates, choosing an arbitrary type for intermediate results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6316] Update Javadoc for CALCITE-5607 [calcite]
sonarcloud[bot] commented on PR #3719: URL: https://github.com/apache/calcite/pull/3719#issuecomment-2070524059 ## [](https://sonarcloud.io/dashboard?id=apache_calcite=3719) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite=3719=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_calcite=3719=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3719=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite=3719) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(calcite) branch main updated: Rectify missing/broken BQ date-time format elements
This is an automated email from the ASF dual-hosted git repository.
tanner pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 4a977fe2a2 Rectify missing/broken BQ date-time format elements
4a977fe2a2 is described below
commit 4a977fe2a204107efdf850fb276722f9d79496a0
Author: Jerin John
AuthorDate: Mon Apr 15 12:38:01 2024 -0400
Rectify missing/broken BQ date-time format elements
---
.../src/main/java/org/apache/calcite/util/Bug.java | 15 +-
.../calcite/util/format/FormatElementEnum.java | 232 ---
.../apache/calcite/util/format/FormatModels.java | 69 -
.../org/apache/calcite/util/FormatModelTest.java | 4 +-
.../calcite/util/format/FormatElementEnumTest.java | 43 ++-
core/src/test/resources/sql/cast-with-format.iq| 326 -
.../org/apache/calcite/test/SqlOperatorTest.java | 126 +---
7 files changed, 511 insertions(+), 304 deletions(-)
diff --git a/core/src/main/java/org/apache/calcite/util/Bug.java
b/core/src/main/java/org/apache/calcite/util/Bug.java
index 7fdbb4c082..e0eaa97a3e 100644
--- a/core/src/main/java/org/apache/calcite/util/Bug.java
+++ b/core/src/main/java/org/apache/calcite/util/Bug.java
@@ -200,16 +200,21 @@ public abstract class Bug {
* Fix to be available with Avatica 1.24.0 [CALCITE-6053] */
public static final boolean CALCITE_6092_FIXED = false;
- /** Whether
- * https://issues.apache.org/jira/browse/CALCITE-6269;>[CALCITE-6269]
- * Fix missing/broken BigQuery date-time format elements is fixed. */
- public static final boolean CALCITE_6269_FIXED = false;
-
/** Whether
* https://issues.apache.org/jira/browse/CALCITE-6270;>[CALCITE-6270]
* Support FORMAT in CAST from Numeric and BYTES to String (Enabled in
BigQuery) is fixed. */
public static final boolean CALCITE_6270_FIXED = false;
+ /** Whether
+ * https://issues.apache.org/jira/browse/CALCITE-6367;>[CALCITE-6367]
+ * Add timezone support for FORMAT clause in CAST (enabled in BigQuery)
is fixed. */
+ public static final boolean CALCITE_6367_FIXED = false;
+
+ /** Whether
+ * https://issues.apache.org/jira/browse/CALCITE-6375;>[CALCITE-6375]
+ * Fix failing quidem tests for FORMAT in CAST is fixed. */
+ public static final boolean CALCITE_6375_FIXED = false;
+
/**
* Use this to flag temporary code.
*/
diff --git
a/core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java
b/core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java
index de4b5df03b..f4f290903f 100644
--- a/core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java
+++ b/core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java
@@ -18,6 +18,8 @@ package org.apache.calcite.util.format;
import org.apache.calcite.avatica.util.DateTimeUtils;
+import org.apache.commons.lang3.StringUtils;
+
import org.checkerframework.checker.nullness.qual.Nullable;
import java.text.DateFormat;
@@ -57,19 +59,22 @@ public enum FormatElementEnum implements FormatElement {
sb.append(String.format(Locale.ROOT, "%d",
calendar.get(Calendar.DAY_OF_WEEK)));
}
},
- DAY("", "The full weekday name") {
+ DAY("", "The full weekday name, in uppercase") {
@Override public void format(StringBuilder sb, Date date) {
- final Calendar calendar = Work.get().calendar;
- calendar.setTime(date);
- // The Calendar and SimpleDateFormatter do not seem to give correct
results
- // for the day of the week prior to the Julian to Gregorian date change.
- // So we resort to using a LocalDate representation.
- LocalDate ld =
- LocalDate.of(calendar.get(Calendar.YEAR),
- // Calendar months are numbered from 0
- calendar.get(Calendar.MONTH) + 1,
- calendar.get(Calendar.DAY_OF_MONTH));
- sb.append(ld.getDayOfWeek().getDisplayName(TextStyle.FULL,
Locale.ENGLISH));
+ final Work work = Work.get();
+ sb.append(work.getDayFromDate(date,
TextStyle.FULL).toUpperCase(Locale.ROOT));
+}
+ },
+ Day("", "The full weekday name, capitalized") {
+@Override public void format(StringBuilder sb, Date date) {
+ final Work work = Work.get();
+ sb.append(work.getDayFromDate(date, TextStyle.FULL));
+}
+ },
+ day("", "The full weekday name, in lowercase") {
+@Override public void format(StringBuilder sb, Date date) {
+ final Work work = Work.get();
+ sb.append(work.getDayFromDate(date,
TextStyle.FULL).toLowerCase(Locale.ROOT));
}
},
DD("dd", "The day of the month as a decimal number (01-31)") {
@@ -86,19 +91,22 @@ public enum FormatElementEnum implements FormatElement {
sb.append(String.format(Locale.ROOT, "%03d",
calendar.get(Calendar.DAY_OF_YEAR)));
}
},
- DY("EEE", "The abbreviated weekday name") {
+ DY("EEE", "The abbreviated weekday
Re: [PR] [CALCITE-6269] Fix missing/broken BigQuery date-time format elements [calcite]
tanclary merged PR #3761: URL: https://github.com/apache/calcite/pull/3761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6322] Casts to DECIMAL types are ignored [calcite]
zabetak commented on code in PR #3733:
URL: https://github.com/apache/calcite/pull/3733#discussion_r1574555950
##
babel/src/test/resources/sql/redshift.iq:
##
@@ -523,78 +523,78 @@ select deptno, ratio_to_report(sal) over (partition by
deptno) from emp;
!}
# STDDEV_POP
-select empno, stddev_pop(comm) over (order by empno rows unbounded preceding)
from emp where deptno = 30 order by 1;
+select empno, stddev_pop(CAST(comm AS DECIMAL(12, 4))) over (order by empno
rows unbounded preceding) from emp where deptno = 30 order by 1;
Review Comment:
According to the description, I assume that the `CAST` was added to avoid a
runtime error but it is not evident why the error is raised. Does the plan have
another CAST somewhere? For what reason?
As far as I see the column `comm` is declared as `DECIMAL(7,2)` and the
result of the `stddev_pop` function should also be a `DECIMAL(7,2)` according
to `RelDataTypeSystemImpl#deriveAvgAggType`. Based on the existing data the
result of stddev_pop is always between 0 and 523 so I am not sure why it cannot
be represented as `DECIMAL(7,2)`.
From a SQL user perspective it is strange to require an explicit CAST for
functions that are supposed to handle exact numerics such as `stddev_pop`,
`sum`, `variance` etc.
Can you please elaborate a bit why it is necessary to introduce this
explicit cast?
##
druid/src/test/java/org/apache/calcite/test/DruidAdapter2IT.java:
##
@@ -1909,10 +1909,14 @@ private void checkGroupBySingleSortLimit(boolean
approx) {
+ "end as b from \"foodmart\" group by \"store_state\" order by a
desc";
final String postAggString =
"'postAggregations':[{'type':'expression','name':'A',"
+ "'expression':'(\\'$f1\\' /
\\'$f2\\')'},{'type':'expression','name':'B',"
-+ "'expression':'case_searched((\\'$f3\\' == 0),1.0,CAST(\\'$f3\\'";
++ "'expression':'case_searched((\\'$f3\\' == 0),1,CAST(\\'$f3\\'";
final String plan = "PLAN="
+ "EnumerableInterpreter\n"
-+ " DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[$63, $90, $91, $89]], groups=[{0}], aggs=[[SUM($1), SUM($2),
SUM($3)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n";
++ " DruidQuery(table=[[foodmart, foodmart]],"
++ " intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],"
++ " projects=[[$63, $90, $91, $89]], groups=[{0}], aggs=[[SUM($1),
SUM($2), SUM($3)]],"
++ " post_projects=[[$0, /($1, $2), CASE(=($3, 0), CAST(1:DECIMAL(19,
0)):DECIMAL(19, 0),"
Review Comment:
The `CAST(1:DECIMAL(19, 0)):DECIMAL(19, 0)` seems like a redundant cast and
it was not there before. Why do we need it now?
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -598,6 +598,13 @@ void testCastBooleanToNumeric(CastType castType,
SqlOperatorFixture f) {
"Cast function cannot convert value of type BOOLEAN to type
DECIMAL\\(19, 0\\)", false);
}
+ /** Test case for https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-6322;>
+ * [CALCITE-6322] Casts to DECIMAL types are ignored. */
+ @Test void testDecimalDecimalCast() {
+final SqlOperatorFixture f = fixture();
+f.checkScalar("CAST(1.123 AS DECIMAL(4, 0))", "1", "DECIMAL(4, 0) NOT
NULL");
+ }
+
Review Comment:
Instead of adding a new method should we rather enrich
`testCastToExactNumeric`?
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -598,6 +598,13 @@ void testCastBooleanToNumeric(CastType castType,
SqlOperatorFixture f) {
"Cast function cannot convert value of type BOOLEAN to type
DECIMAL\\(19, 0\\)", false);
}
+ /** Test case for https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-6322;>
+ * [CALCITE-6322] Casts to DECIMAL types are ignored. */
Review Comment:
The PR claims to add support for three kinds of CASTS:
* decimal to decimal
* int to decimal
* double/float to decimal
I've seen a few tests for the first category, do we have something for the
other two? If not then I think we should add.
Moreover, I've noticed some tests that are currently disabled by the
`DECIMAL` flag. A few of them should be fixed by this PR so please enable those
that are relevant.
##
druid/src/test/java/org/apache/calcite/test/DruidAdapterIT.java:
##
@@ -2215,12 +2215,13 @@ private void checkGroupBySingleSortLimit(boolean
approx) {
+ "from \"foodmart\" group by \"store_state\" order by a desc";
final String postAggString =
"'postAggregations':[{'type':'expression','name':'A',"
+ "'expression':'(\\'$f1\\' /
\\'$f2\\')'},{'type':'expression','name':'B',"
-+ "'expression':'case_searched((\\'$f3\\' == 0),1.0,CAST(\\'$f3\\'";
+
Re: [PR] [CALCITE-6378] Bump Redis Docker image from 2.8.19 to 7.2.4 [calcite]
F21 merged PR #3767: URL: https://github.com/apache/calcite/pull/3767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(calcite) branch main updated: [CALCITE-6378] Bump Redis Docker image from 2.8.19 to 7.2.4
This is an automated email from the ASF dual-hosted git repository.
francischuang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 6d4f80e90b [CALCITE-6378] Bump Redis Docker image from 2.8.19 to 7.2.4
6d4f80e90b is described below
commit 6d4f80e90bd99392e5bec152f964e639f0cfe7fc
Author: Sergey Nuyanzin
AuthorDate: Mon Apr 22 11:40:19 2024 +0200
[CALCITE-6378] Bump Redis Docker image from 2.8.19 to 7.2.4
---
redis/src/test/java/org/apache/calcite/adapter/redis/RedisCaseBase.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/redis/src/test/java/org/apache/calcite/adapter/redis/RedisCaseBase.java
b/redis/src/test/java/org/apache/calcite/adapter/redis/RedisCaseBase.java
index 7577fe5177..44d82385aa 100644
--- a/redis/src/test/java/org/apache/calcite/adapter/redis/RedisCaseBase.java
+++ b/redis/src/test/java/org/apache/calcite/adapter/redis/RedisCaseBase.java
@@ -49,7 +49,7 @@ public abstract class RedisCaseBase {
* Uses the Redis 2.8.19 version to be aligned with the embedded server.
*/
private static final GenericContainer REDIS_CONTAINER =
- new GenericContainer<>("redis:2.8.19").withExposedPorts(6379);
+ new GenericContainer<>("redis:7.2.4").withExposedPorts(6379);
/**
* The embedded Redis server.
Re: [PR] [CALCITE-6378] Bump Redis Docker image from 2.8.19 to 7.2.4 [calcite]
sonarcloud[bot] commented on PR #3767: URL: https://github.com/apache/calcite/pull/3767#issuecomment-2069107896 ## [](https://sonarcloud.io/dashboard?id=apache_calcite=3767) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite=3767=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_calcite=3767=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3767=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite=3767) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [CALCITE-6378] Bump Redis Docker image from 2.8.19 to 7.2.4 [calcite]
snuyanzin opened a new pull request, #3767: URL: https://github.com/apache/calcite/pull/3767 Docker since 19.x deprecated image manifest v2 schema 1 and disabled since 26.x it is also going to remove it since 27.x as mentioned at https://docs.docker.com/engine/deprecated/#pushing-and-pulling-with-image-manifest-v2-schema-1 for that reason need to bump redis docker image which uses deprecated version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
