[jira] [Updated] (CASSANDRA-19278) AND queries involving both static and regular columns can hide matches from Memtable-attached indexes
[
https://issues.apache.org/jira/browse/CASSANDRA-19278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-19278:
Attachment: ci_summary.html
result_details.tar.gz
> AND queries involving both static and regular columns can hide matches from
> Memtable-attached indexes
> -
>
> Key: CASSANDRA-19278
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19278
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/SAI
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
> Attachments: ci_summary.html, result_details.tar.gz
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> As part of our ongoing work on CASSANDRA-18275, Harry started surfacing
> errors shortly after we added static columns to the schema of
> {{SingleNodeSAITest}}. After a bit of debugging, I was able to come up with
> the following concrete repro:
> {noformat}
> import org.junit.Test;
> import org.apache.cassandra.cql3.UntypedResultSet;
> import org.apache.cassandra.index.sai.utils.SAIRandomizedTester;
> public class InMemoryIntersectionsTest extends SAIRandomizedTester
> {
> @Test
> public void staticAndRegularIntersection()
> {
> createTable("CREATE TABLE %s (pk int, ck int, v1 int, s1 int static,
> PRIMARY KEY(pk, ck))");
> createIndex("CREATE INDEX ON %s(v1) USING 'sai'");
> createIndex("CREATE INDEX ON %s(s1) USING 'sai'");
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 1, 0);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 2, 1);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 3, 2);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 4, 3);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 5, 4);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 6, 5);
> execute("INSERT INTO %s (pk, s1) VALUES (?, ?)", 0, 100);
> // Flushing here passes test
> UntypedResultSet result1 = execute("SELECT * FROM %s WHERE pk = ? AND
> v1 > ?", 0, 2);
> assertRowCount(result1, 3);
> UntypedResultSet result2 = execute("SELECT * FROM %s WHERE pk = ? AND
> v1 > ? AND s1 = ?", 0, 2, 100);
> assertRowCount(result2, 3); // Only returns one result!
> }
> }
> {noformat}
> Flushing memtables immediately before the queries passes the test, but it
> seems we have an issue with how the {{PrimaryKey}} iterators produced by
> static and regular column indexes are intersected when the iterators come
> from Memtable-attached indexes. Once the root cause of this is determined, it
> might make some sense to enhance {{RandomIntersectionTest}} to cover this
> interaction as well, just in case it turns up further problems.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19278) AND queries involving both static and regular columns can hide matches from Memtable-attached indexes
[
https://issues.apache.org/jira/browse/CASSANDRA-19278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808592#comment-17808592
]
Caleb Rackliffe edited comment on CASSANDRA-19278 at 1/20/24 7:01 AM:
--
5.0 [patch|https://github.com/apache/cassandra/pull/3054] [^ci_summary.html]
was (Author: maedhroz):
5.0 [patch|https://github.com/apache/cassandra/pull/3054] [CI|TODO]
> AND queries involving both static and regular columns can hide matches from
> Memtable-attached indexes
> -
>
> Key: CASSANDRA-19278
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19278
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/SAI
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
> Attachments: ci_summary.html, result_details.tar.gz
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> As part of our ongoing work on CASSANDRA-18275, Harry started surfacing
> errors shortly after we added static columns to the schema of
> {{SingleNodeSAITest}}. After a bit of debugging, I was able to come up with
> the following concrete repro:
> {noformat}
> import org.junit.Test;
> import org.apache.cassandra.cql3.UntypedResultSet;
> import org.apache.cassandra.index.sai.utils.SAIRandomizedTester;
> public class InMemoryIntersectionsTest extends SAIRandomizedTester
> {
> @Test
> public void staticAndRegularIntersection()
> {
> createTable("CREATE TABLE %s (pk int, ck int, v1 int, s1 int static,
> PRIMARY KEY(pk, ck))");
> createIndex("CREATE INDEX ON %s(v1) USING 'sai'");
> createIndex("CREATE INDEX ON %s(s1) USING 'sai'");
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 1, 0);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 2, 1);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 3, 2);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 4, 3);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 5, 4);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 6, 5);
> execute("INSERT INTO %s (pk, s1) VALUES (?, ?)", 0, 100);
> // Flushing here passes test
> UntypedResultSet result1 = execute("SELECT * FROM %s WHERE pk = ? AND
> v1 > ?", 0, 2);
> assertRowCount(result1, 3);
> UntypedResultSet result2 = execute("SELECT * FROM %s WHERE pk = ? AND
> v1 > ? AND s1 = ?", 0, 2, 100);
> assertRowCount(result2, 3); // Only returns one result!
> }
> }
> {noformat}
> Flushing memtables immediately before the queries passes the test, but it
> seems we have an issue with how the {{PrimaryKey}} iterators produced by
> static and regular column indexes are intersected when the iterators come
> from Memtable-attached indexes. Once the root cause of this is determined, it
> might make some sense to enhance {{RandomIntersectionTest}} to cover this
> interaction as well, just in case it turns up further problems.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-96) Typo in foundation package under common org.apache.cassandra.sidecar
[
https://issues.apache.org/jira/browse/CASSANDRASC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRASC-96:
--
Fix Version/s: 1.0
Source Control Link:
https://github.com/apache/cassandra-sidecar/commit/cf09cded72dd04e272f56fba0b7d9cceb0c4f894
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Typo in foundation package under common org.apache.cassandra.sidecar
>
>
> Key: CASSANDRASC-96
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-96
> Project: Sidecar for Apache Cassandra
> Issue Type: Bug
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
> Fix For: 1.0
>
>
> There's a typo in the foundation package spelled {{foundataion}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-96) Typo in foundation package under common org.apache.cassandra.sidecar
[
https://issues.apache.org/jira/browse/CASSANDRASC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808876#comment-17808876
]
ASF subversion and git services commented on CASSANDRASC-96:
Commit cf09cded72dd04e272f56fba0b7d9cceb0c4f894 in cassandra-sidecar's branch
refs/heads/trunk from Francisco Guerrero
[ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=cf09cde ]
CASSANDRASC-96 Fix typo in foundation package under common
org.apache.cassandra.sidecar
Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSANDRASC-96
> Typo in foundation package under common org.apache.cassandra.sidecar
>
>
> Key: CASSANDRASC-96
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-96
> Project: Sidecar for Apache Cassandra
> Issue Type: Bug
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> There's a typo in the foundation package spelled {{foundataion}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-96) Typo in foundation package under common org.apache.cassandra.sidecar
[
https://issues.apache.org/jira/browse/CASSANDRASC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRASC-96:
--
Status: Ready to Commit (was: Review In Progress)
> Typo in foundation package under common org.apache.cassandra.sidecar
>
>
> Key: CASSANDRASC-96
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-96
> Project: Sidecar for Apache Cassandra
> Issue Type: Bug
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> There's a typo in the foundation package spelled {{foundataion}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-96) Typo in foundation package under common org.apache.cassandra.sidecar
[
https://issues.apache.org/jira/browse/CASSANDRASC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRASC-96:
--
Reviewers: Yifan Cai, Francisco Guerrero
Yifan Cai, Francisco Guerrero (was: Francisco Guerrero, Yifan
Cai)
Status: Review In Progress (was: Patch Available)
> Typo in foundation package under common org.apache.cassandra.sidecar
>
>
> Key: CASSANDRASC-96
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-96
> Project: Sidecar for Apache Cassandra
> Issue Type: Bug
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> There's a typo in the foundation package spelled {{foundataion}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-sidecar) branch trunk updated: CASSANDRASC-96 Fix typo in foundation package under common org.apache.cassandra.sidecar
This is an automated email from the ASF dual-hosted git repository.
frankgh pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-sidecar.git
The following commit(s) were added to refs/heads/trunk by this push:
new cf09cde CASSANDRASC-96 Fix typo in foundation package under common
org.apache.cassandra.sidecar
cf09cde is described below
commit cf09cded72dd04e272f56fba0b7d9cceb0c4f894
Author: Francisco Guerrero
AuthorDate: Fri Jan 19 17:38:55 2024 -0800
CASSANDRASC-96 Fix typo in foundation package under common
org.apache.cassandra.sidecar
Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSANDRASC-96
---
.../java/org/apache/cassandra/sidecar/client/SidecarClientTest.java| 2 +-
.../sidecar/common/data/CreateRestoreJobRequestPayloadTest.java| 2 +-
.../sidecar/common/data/UpdateRestoreJobRequestPayloadTest.java| 3 +--
.../sidecar/{foundataion => foundation}/RestoreJobSecretsGen.java | 2 +-
.../cassandra/sidecar/db/RestoreJobsDatabaseAccessorIntTest.java | 2 +-
.../apache/cassandra/sidecar/routes/restore/BaseRestoreJobTests.java | 2 +-
6 files changed, 6 insertions(+), 7 deletions(-)
diff --git
a/client/src/testFixtures/java/org/apache/cassandra/sidecar/client/SidecarClientTest.java
b/client/src/testFixtures/java/org/apache/cassandra/sidecar/client/SidecarClientTest.java
index 4f5a458..fb1102c 100644
---
a/client/src/testFixtures/java/org/apache/cassandra/sidecar/client/SidecarClientTest.java
+++
b/client/src/testFixtures/java/org/apache/cassandra/sidecar/client/SidecarClientTest.java
@@ -71,7 +71,7 @@ import
org.apache.cassandra.sidecar.common.data.SchemaResponse;
import org.apache.cassandra.sidecar.common.data.TimeSkewResponse;
import org.apache.cassandra.sidecar.common.data.TokenRangeReplicasResponse;
import org.apache.cassandra.sidecar.common.utils.HttpRange;
-import org.apache.cassandra.sidecar.foundataion.RestoreJobSecretsGen;
+import org.apache.cassandra.sidecar.foundation.RestoreJobSecretsGen;
import static io.netty.handler.codec.http.HttpResponseStatus.ACCEPTED;
import static io.netty.handler.codec.http.HttpResponseStatus.BAD_REQUEST;
diff --git
a/common/src/test/java/org/apache/cassandra/sidecar/common/data/CreateRestoreJobRequestPayloadTest.java
b/common/src/test/java/org/apache/cassandra/sidecar/common/data/CreateRestoreJobRequestPayloadTest.java
index cf4d6b0..e7f47b9 100644
---
a/common/src/test/java/org/apache/cassandra/sidecar/common/data/CreateRestoreJobRequestPayloadTest.java
+++
b/common/src/test/java/org/apache/cassandra/sidecar/common/data/CreateRestoreJobRequestPayloadTest.java
@@ -28,7 +28,7 @@ import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException;
import com.fasterxml.jackson.databind.exc.ValueInstantiationException;
-import org.apache.cassandra.sidecar.foundataion.RestoreJobSecretsGen;
+import org.apache.cassandra.sidecar.foundation.RestoreJobSecretsGen;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
diff --git
a/common/src/test/java/org/apache/cassandra/sidecar/common/data/UpdateRestoreJobRequestPayloadTest.java
b/common/src/test/java/org/apache/cassandra/sidecar/common/data/UpdateRestoreJobRequestPayloadTest.java
index 580c49a..b1e26c8 100644
---
a/common/src/test/java/org/apache/cassandra/sidecar/common/data/UpdateRestoreJobRequestPayloadTest.java
+++
b/common/src/test/java/org/apache/cassandra/sidecar/common/data/UpdateRestoreJobRequestPayloadTest.java
@@ -23,10 +23,9 @@ import java.util.Date;
import org.junit.jupiter.api.Test;
-
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
-import org.apache.cassandra.sidecar.foundataion.RestoreJobSecretsGen;
+import org.apache.cassandra.sidecar.foundation.RestoreJobSecretsGen;
import static org.assertj.core.api.Assertions.assertThat;
diff --git
a/common/src/testFixtures/java/org/apache/cassandra/sidecar/foundataion/RestoreJobSecretsGen.java
b/common/src/testFixtures/java/org/apache/cassandra/sidecar/foundation/RestoreJobSecretsGen.java
similarity index 97%
rename from
common/src/testFixtures/java/org/apache/cassandra/sidecar/foundataion/RestoreJobSecretsGen.java
rename to
common/src/testFixtures/java/org/apache/cassandra/sidecar/foundation/RestoreJobSecretsGen.java
index 461b7df..35893b5 100644
---
a/common/src/testFixtures/java/org/apache/cassandra/sidecar/foundataion/RestoreJobSecretsGen.java
+++
b/common/src/testFixtures/java/org/apache/cassandra/sidecar/foundation/RestoreJobSecretsGen.java
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-package org.apache.cassandra.sidecar.foundataion;
+package org.apache.cassandra.sidecar.foundation;
import java.util.concurrent.ThreadLocalRandom;
diff --git
[jira] [Commented] (CASSANDRASC-96) Typo in foundation package under common org.apache.cassandra.sidecar
[
https://issues.apache.org/jira/browse/CASSANDRASC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808875#comment-17808875
]
Francisco Guerrero commented on CASSANDRASC-96:
---
CI is green
> Typo in foundation package under common org.apache.cassandra.sidecar
>
>
> Key: CASSANDRASC-96
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-96
> Project: Sidecar for Apache Cassandra
> Issue Type: Bug
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> There's a typo in the foundation package spelled {{foundataion}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-96) Typo in foundation package under common org.apache.cassandra.sidecar
[
https://issues.apache.org/jira/browse/CASSANDRASC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRASC-96:
--
Authors: Francisco Guerrero
Test and Documentation Plan: No tests added since it is only fixing a typo
Status: Patch Available (was: In Progress)
PR: https://github.com/apache/cassandra-sidecar/pull/93
CI:
https://app.circleci.com/pipelines/github/frankgh/cassandra-sidecar?branch=CASSANDRASC-96
> Typo in foundation package under common org.apache.cassandra.sidecar
>
>
> Key: CASSANDRASC-96
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-96
> Project: Sidecar for Apache Cassandra
> Issue Type: Bug
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> There's a typo in the foundation package spelled {{foundataion}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-96) Typo in foundation package under common org.apache.cassandra.sidecar
[
https://issues.apache.org/jira/browse/CASSANDRASC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRASC-96:
--
Bug Category: Parent values: Code(13163)Level 1 values: Bug - Unclear
Impact(13164)
Complexity: Low Hanging Fruit
Component/s: Configuration
Discovered By: Code Inspection
Severity: Low
Status: Open (was: Triage Needed)
> Typo in foundation package under common org.apache.cassandra.sidecar
>
>
> Key: CASSANDRASC-96
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-96
> Project: Sidecar for Apache Cassandra
> Issue Type: Bug
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> There's a typo in the foundation package spelled {{foundataion}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-96) Typo in foundation package under common org.apache.cassandra.sidecar
[
https://issues.apache.org/jira/browse/CASSANDRASC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CASSANDRASC-96:
--
Labels: pull-request-available (was: )
> Typo in foundation package under common org.apache.cassandra.sidecar
>
>
> Key: CASSANDRASC-96
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-96
> Project: Sidecar for Apache Cassandra
> Issue Type: Bug
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> There's a typo in the foundation package spelled {{foundataion}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRASC-96) Typo in foundation package under common org.apache.cassandra.sidecar
Francisco Guerrero created CASSANDRASC-96:
-
Summary: Typo in foundation package under common
org.apache.cassandra.sidecar
Key: CASSANDRASC-96
URL: https://issues.apache.org/jira/browse/CASSANDRASC-96
Project: Sidecar for Apache Cassandra
Issue Type: Bug
Reporter: Francisco Guerrero
Assignee: Francisco Guerrero
There's a typo in the foundation package spelled {{foundataion}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19046) Paxos V2 does not update individual fields of readMetrics
[
https://issues.apache.org/jira/browse/CASSANDRA-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808849#comment-17808849
]
Brandon Williams commented on CASSANDRA-19046:
--
Fixing ClientMetricsTest.testPaxosStatement requires deciding on if we should
add the metrics, or exempt them in the test for v2.
QueriesTablesTest passes for v1 when it sends a Commit and that is then
converted to a
[string|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/paxos/Commit.java#L340]
in the queries table that matches. v2 doesn't use Commit and I'm not sure
where to add an equivalent that will appear there, but it seems to have value
if it's going to be visible in the table.
Do you have any guidance on those points, [~benedict]?
[Here|https://app.circleci.com/pipelines/github/driftx/cassandra/1460/workflows/5bae89db-18db-4311-b314-4a7641ce5a9f/jobs/71554]
is 500 repetitions of client_request_metrics_test.TestClientRequestMetrics
from [this
branch|https://github.com/driftx/cassandra-dtest/tree/CASSANDRA-19046].
> Paxos V2 does not update individual fields of readMetrics
> -
>
> Key: CASSANDRA-19046
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19046
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Lightweight Transactions, Observability/Metrics
>Reporter: Branimir Lambov
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1.x, 5.0-rc, 5.x
>
>
> As a result, {{ClientRequestMetricsTest.testPaxosStatement}} is failing with
> {{{}paxos_variant: v2{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19276) Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
[
https://issues.apache.org/jira/browse/CASSANDRA-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808844#comment-17808844
]
Andy Tolbert commented on CASSANDRA-19276:
--
I think what we really need is for {{LeftCurly}} to have an option like
{{RightCurly}}'s {{alone_or_singleline}} which specifies:
{quote}
The brace must be alone on the line, yet single-line format of block is allowed.
{quote}
will see if anyone has ever requested that; or if something maybe feasible to
add there
> Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
> ---
>
> Key: CASSANDRA-19276
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19276
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
> Attachments: checkstyle_lcurly_output.zip
>
>
> It came up in a review that I had missed some style changes in
> [CASSANDRA-18857]
> (https://github.com/apache/cassandra/pull/2969#pullrequestreview-1810999533).
> Chatting with [~smiklosovic] we agreed that it would be nice if we could
> enforce this in checkstyle, so we wouldn't need to be dependent on this being
> caught in review.
> The change for this is effectively:
> {code}
> index 8b81f21281..9bd22dc1ac 100644
> --- a/.build/checkstyle.xml
> +++ b/.build/checkstyle.xml
> @@ -179,6 +179,10 @@
> value="'Deprecated annotation must provide 'since' value."/>
>
> +
> +
> + value="ANNOTATION_DEF,CLASS_DEF,CTOR_DEF,ENUM_CONSTANT_DEF,INTERFACE_DEF,LITERAL_CASE,LITERAL_CATCH,LITERAL_DEFAULT,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_SWITCH,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,METHOD_DEF,OBJBLOCK,STATIC_INIT,RECORD_DEF,COMPACT_CTOR_DEF"/>
> +
>
>
> {code}
> Notably, we would allow braces on the same lines for lambdas as per the
> [project
> guidelines|https://cassandra.apache.org/_/development/code_style.html] on
> code formatting:
> {quote}
> {{{}} and {{}}} are placed on a new line except when empty or opening a
> multi-line lambda expression. Braces may be elided to a depth of one if the
> condition or loop guards a single expression.
> {quote}
> There are 594 violations and 211 source files that would need to be adjusted.
> I may play with the rules a little bit more to get this right.
> I would like to propose that we change all files that are not imported from
> other projects (there are a few, such as
> src/java/org/apache/cassandra/utils/obs/BitUtil.java, which we can suppress
> changes for), but we would change others.
> I'll make a patch with the changes send a small proposal to the mailing list
> as it could be disruptive to make a bunch of tiny changes, and depending on
> timing there may be a better time to make a change like this.
> We should make this change only on trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19001) Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue
[
https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808843#comment-17808843
]
Ekaterina Dimitrova commented on CASSANDRA-19001:
-
I received an approval from [~paulo] in Slack to commit the current patch.
Done here:
To https://github.com/apache/cassandra.git
[8fd44ca8fc..9f5e45e5a2 |
https://github.com/apache/cassandra/commit/9f5e45e5a21af2049b8874cd1663668059848f03]
cassandra-5.0 -> cassandra-5.0
[03f0d37cb0..aa644c9dfa |
https://github.com/apache/cassandra/commit/aa644c9dfa6680c73a9400f295f450b623dee784]
trunk -> trunk
> Check whether the startup warnings for unknown modules represent a legit
> problem or cosmetic issue
> --
>
> Key: CASSANDRA-19001
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19001
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.0-rc, 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During the 5.0 alpha 2 release
> [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr],
> [~paulo] raised the following concerns:
> {code:java}
> Launched a tarball-based 5.0-alpha2 container on top of
> "eclipse-temurin:17-jre-focal" and the server starts up fine, can run
> nodetool and cqlsh.
> I got these seemingly harmless JDK17 warnings during startup and when
> running nodetool (no warnings on JDK11):
> WARNING: Unknown module: jdk.attach specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-opens
> WARNING: A terminally deprecated method in java.lang.System has been called
> WARNING: System::setSecurityManager has been called by
> org.apache.cassandra.security.ThreadAwareSecurityManager
> (file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar)
> WARNING: Please consider reporting this to the maintainers of
> org.apache.cassandra.security.ThreadAwareSecurityManager
> WARNING: System::setSecurityManager will be removed in a future release
> Anybody knows if these warnings are legit/expected ? We can create
> follow-up tickets if needed.
> $ java --version
> openjdk 17.0.9 2023-10-17
> OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9)
> OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode,
> sharing)
> {code}
> {code:java}
> Clarification: - When running nodetool only the "Unknown module" warnings
> show up. All warnings show up during startup.{code}
> We need to verify whether this presents a real problem in the features where
> those modules are expected to be used, or if it is a false alarm.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch cassandra-5.0 updated (8fd44ca8fc -> 9f5e45e5a2)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 8fd44ca8fc Upgrade Python driver to 3.29.0 add 9f5e45e5a2 Append additional JVM options when using JDK17+ No new revisions were added by this update. Summary of changes: CHANGES.txt| 1 + bin/cassandra.in.sh| 8 conf/jvm17-clients.options | 4 conf/jvm17-server.options | 3 --- tools/bin/cassandra.in.sh | 8 5 files changed, 17 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch trunk updated (03f0d37cb0 -> aa644c9dfa)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 03f0d37cb0 Merge branch 'cassandra-5.0' into trunk add 9f5e45e5a2 Append additional JVM options when using JDK17+ new aa644c9dfa Merge branch 'cassandra-5.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + bin/cassandra.in.sh| 8 conf/jvm17-clients.options | 4 conf/jvm17-server.options | 3 --- tools/bin/cassandra.in.sh | 8 5 files changed, 17 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit aa644c9dfa6680c73a9400f295f450b623dee784 Merge: 03f0d37cb0 9f5e45e5a2 Author: Ekaterina Dimitrova AuthorDate: Fri Jan 19 18:59:00 2024 -0500 Merge branch 'cassandra-5.0' into trunk CHANGES.txt| 1 + bin/cassandra.in.sh| 8 conf/jvm17-clients.options | 4 conf/jvm17-server.options | 3 --- tools/bin/cassandra.in.sh | 8 5 files changed, 17 insertions(+), 7 deletions(-) diff --cc CHANGES.txt index 565b1d80b6,268bfa42b3..ebf48c2315 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,13 -1,5 +1,14 @@@ -5.0-beta2 +5.1 + * Limit cassandra startup to supported JDKs, allow higher JDKs by setting CASSANDRA_JDK_UNSUPPORTED (CASSANDRA-18688) + * Standardize nodetool tablestats formatting of data units (CASSANDRA-19104) + * Make nodetool tablestats use number of significant digits for time and average values consistently (CASSANDRA-19015) + * Upgrade jackson to 2.15.3 and snakeyaml to 2.1 (CASSANDRA-18875) + * Transactional Cluster Metadata [CEP-21] (CASSANDRA-18330) + * Add ELAPSED command to cqlsh (CASSANDRA-18861) + * Add the ability to disable bulk loading of SSTables (CASSANDRA-18781) + * Clean up obsolete functions and simplify cql_version handling in cqlsh (CASSANDRA-18787) +Merged from 5.0: + * Append additional JVM options when using JDK17+ (CASSANDRA-19001) * Upgrade Python driver to 3.29.0 (CASSANDRA-19245) * Creating a SASI index after creating an SAI index does not break secondary index queries (CASSANDRA-18939) * Optionally fail when a non-partition-restricted query is issued against an index (CASSANDRA-18796) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-95) Adding sidecar client changes for restore from S3
[ https://issues.apache.org/jira/browse/CASSANDRASC-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-95: - Fix Version/s: 1.0 Source Control Link: https://github.com/apache/cassandra-sidecar/commit/1b6052a8c3b04fca48f82e887c12bcfb2bae0bdb Resolution: Fixed Status: Resolved (was: Ready to Commit) > Adding sidecar client changes for restore from S3 > - > > Key: CASSANDRASC-95 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-95 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > Fix For: 1.0 > > > Adding sidecar client changes so that clients can interact with the sidecar > server to restore from S3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-95) Adding sidecar client changes for restore from S3
[ https://issues.apache.org/jira/browse/CASSANDRASC-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808841#comment-17808841 ] ASF subversion and git services commented on CASSANDRASC-95: Commit 1b6052a8c3b04fca48f82e887c12bcfb2bae0bdb in cassandra-sidecar's branch refs/heads/trunk from Yifan Cai [ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=1b6052a ] CASSANDRASC-95 Add sidecar client changes for restore from S3 Patch by Saranya Krishnakumar, Yifan Cai; Reviewed by Francisco Guerrero for CASSANDRASC-95 Co-authored-by: Yifan Cai Co-authored-by: Saranya Krishnakumar > Adding sidecar client changes for restore from S3 > - > > Key: CASSANDRASC-95 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-95 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > > Adding sidecar client changes so that clients can interact with the sidecar > server to restore from S3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-sidecar) branch trunk updated: CASSANDRASC-95 Add sidecar client changes for restore from S3
This is an automated email from the ASF dual-hosted git repository.
ycai pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-sidecar.git
The following commit(s) were added to refs/heads/trunk by this push:
new 1b6052a CASSANDRASC-95 Add sidecar client changes for restore from S3
1b6052a is described below
commit 1b6052a8c3b04fca48f82e887c12bcfb2bae0bdb
Author: Yifan Cai
AuthorDate: Fri Jan 19 10:52:50 2024 -0800
CASSANDRASC-95 Add sidecar client changes for restore from S3
Patch by Saranya Krishnakumar, Yifan Cai; Reviewed by Francisco Guerrero
for CASSANDRASC-95
Co-authored-by: Yifan Cai
Co-authored-by: Saranya Krishnakumar
---
CHANGES.txt| 1 +
client/build.gradle| 1 +
.../cassandra/sidecar/client/SidecarClient.java| 84 +-
.../client/SidecarClientBlobRestoreExtension.java | 96 +++
.../client/request/AbortRestoreJobRequest.java | 56 +++
.../client/request/CreateRestoreJobRequest.java| 65
.../request/CreateRestoreJobSliceRequest.java | 77 +
.../sidecar/client/request/JsonPayloadRequest.java | 30
.../client/request/RestoreJobSummaryRequest.java | 57 +++
.../client/request/UpdateRestoreJobRequest.java| 68
.../client/retry/CreateRestoreJobRetryPolicy.java | 62 +++
.../sidecar/client/SidecarClientTest.java | 53 ++
common/build.gradle| 3 +-
.../cassandra/sidecar/common/ApiEndpointsV1.java | 2 +
.../data/CreateRestoreJobRequestPayloadTest.java | 182 +
.../common/data/CreateSliceRequestPayloadTest.java | 109
.../data/UpdateRestoreJobRequestPayloadTest.java | 76 +
17 files changed, 1020 insertions(+), 2 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 2cca9d6..6b5a9b9 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,5 +1,6 @@
1.0.0
-
+ * Add sidecar client changes for restore from S3 (CASSANDRASC-95)
* Add restore SSTables from S3 into Cassandra feature to Cassandra Sidecar
(CASSANDRASC-92)
* Define routing order for http routes (CASSANDRASC-93)
* AbstractHandler is handling the request even when it fails to extract
params (CASSANDRASC-91)
diff --git a/client/build.gradle b/client/build.gradle
index d7564cd..202a3a1 100644
--- a/client/build.gradle
+++ b/client/build.gradle
@@ -80,6 +80,7 @@ dependencies {
testImplementation('com.squareup.okhttp3:mockwebserver:4.10.0')
testImplementation(group: 'io.netty', name: 'netty-codec-http', version:
'4.1.69.Final')
+testFixturesApi(testFixtures(project(":common")))
testFixturesImplementation(platform('org.junit:junit-bom:5.9.2'))
testFixturesImplementation('org.junit.jupiter:junit-jupiter')
testFixturesImplementation("org.assertj:assertj-core:3.24.2")
diff --git
a/client/src/main/java/org/apache/cassandra/sidecar/client/SidecarClient.java
b/client/src/main/java/org/apache/cassandra/sidecar/client/SidecarClient.java
index 7e5dbbe..3048808 100644
---
a/client/src/main/java/org/apache/cassandra/sidecar/client/SidecarClient.java
+++
b/client/src/main/java/org/apache/cassandra/sidecar/client/SidecarClient.java
@@ -20,13 +20,21 @@
package org.apache.cassandra.sidecar.client;
import java.util.List;
+import java.util.Objects;
+import java.util.UUID;
import java.util.concurrent.CompletableFuture;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import io.netty.handler.codec.http.HttpResponseStatus;
+import org.apache.cassandra.sidecar.client.request.AbortRestoreJobRequest;
+import org.apache.cassandra.sidecar.client.request.CreateRestoreJobRequest;
+import
org.apache.cassandra.sidecar.client.request.CreateRestoreJobSliceRequest;
import org.apache.cassandra.sidecar.client.request.ImportSSTableRequest;
+import org.apache.cassandra.sidecar.client.request.RestoreJobSummaryRequest;
+import org.apache.cassandra.sidecar.client.request.UpdateRestoreJobRequest;
+import org.apache.cassandra.sidecar.client.retry.CreateRestoreJobRetryPolicy;
import org.apache.cassandra.sidecar.client.retry.IgnoreConflictRetryPolicy;
import org.apache.cassandra.sidecar.client.retry.OncePerInstanceRetryPolicy;
import org.apache.cassandra.sidecar.client.retry.RetryPolicy;
@@ -34,21 +42,26 @@ import
org.apache.cassandra.sidecar.client.retry.RunnableOnStatusCodeRetryPolicy
import org.apache.cassandra.sidecar.client.selection.InstanceSelectionPolicy;
import
org.apache.cassandra.sidecar.client.selection.RandomInstanceSelectionPolicy;
import org.apache.cassandra.sidecar.common.NodeSettings;
+import org.apache.cassandra.sidecar.common.data.CreateRestoreJobRequestPayload;
+import
org.apache.cassandra.sidecar.common.data.CreateRestoreJobResponsePayload;
+import org.apache.cassandra.sidecar.common.data.CreateSliceRequestPayload;
import
[jira] [Updated] (CASSANDRASC-95) Adding sidecar client changes for restore from S3
[ https://issues.apache.org/jira/browse/CASSANDRASC-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-95: - Status: Ready to Commit (was: Review In Progress) > Adding sidecar client changes for restore from S3 > - > > Key: CASSANDRASC-95 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-95 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > > Adding sidecar client changes so that clients can interact with the sidecar > server to restore from S3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19001) Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue
[
https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808832#comment-17808832
]
Brandon Williams commented on CASSANDRA-19001:
--
I don't think packaging should need this, since it controls the jre/jdk
versions used already. Given that, it's probably not material for the redhat
in.sh to be updated here and the debian version is always updated and patched
each time (though perhaps with fuzz now.)
That said, we don't regularly update them unless it's necessary, so we could
take this opportunity to do so.
> Check whether the startup warnings for unknown modules represent a legit
> problem or cosmetic issue
> --
>
> Key: CASSANDRA-19001
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19001
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.0-rc, 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During the 5.0 alpha 2 release
> [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr],
> [~paulo] raised the following concerns:
> {code:java}
> Launched a tarball-based 5.0-alpha2 container on top of
> "eclipse-temurin:17-jre-focal" and the server starts up fine, can run
> nodetool and cqlsh.
> I got these seemingly harmless JDK17 warnings during startup and when
> running nodetool (no warnings on JDK11):
> WARNING: Unknown module: jdk.attach specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-opens
> WARNING: A terminally deprecated method in java.lang.System has been called
> WARNING: System::setSecurityManager has been called by
> org.apache.cassandra.security.ThreadAwareSecurityManager
> (file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar)
> WARNING: Please consider reporting this to the maintainers of
> org.apache.cassandra.security.ThreadAwareSecurityManager
> WARNING: System::setSecurityManager will be removed in a future release
> Anybody knows if these warnings are legit/expected ? We can create
> follow-up tickets if needed.
> $ java --version
> openjdk 17.0.9 2023-10-17
> OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9)
> OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode,
> sharing)
> {code}
> {code:java}
> Clarification: - When running nodetool only the "Unknown module" warnings
> show up. All warnings show up during startup.{code}
> We need to verify whether this presents a real problem in the features where
> those modules are expected to be used, or if it is a false alarm.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19001) Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue
[
https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808828#comment-17808828
]
Ekaterina Dimitrova edited comment on CASSANDRA-19001 at 1/19/24 11:47 PM:
---
I will commit this patch but keep the ticket open as I believe there is part 2.
Packaging?
I see some differences between bin/cassandra.in.sh and redhat/cassandra.in.sh
and it seems the debian diff on 5.0 was updated once in 2020 since it was
created in 2019.
I am questioning my understanding around those files and how/ when we update
them. [~mck], [~brandon.williams], can you help me understand whether I should
update those and, in general, when they are updated? Or were they just missed
being updated in time?
was (Author: e.dimitrova):
I will commit this patch but keep the ticket open as I believe there is part 2.
Packaging?
I see some differences between bin/cassandra.in.sh and redhat/cassandra.in.sh
and it seems the debian diff on 5.0 was updated once in 2020 since it was
created for 5.0.
I am questioning my understanding around those files and how/ when we update
them. [~mck], [~brandon.williams], can you help me understand whether I should
update those and, in general, when they are updated? Or were they just missed
being updated in time?
> Check whether the startup warnings for unknown modules represent a legit
> problem or cosmetic issue
> --
>
> Key: CASSANDRA-19001
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19001
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.0-rc, 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During the 5.0 alpha 2 release
> [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr],
> [~paulo] raised the following concerns:
> {code:java}
> Launched a tarball-based 5.0-alpha2 container on top of
> "eclipse-temurin:17-jre-focal" and the server starts up fine, can run
> nodetool and cqlsh.
> I got these seemingly harmless JDK17 warnings during startup and when
> running nodetool (no warnings on JDK11):
> WARNING: Unknown module: jdk.attach specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-opens
> WARNING: A terminally deprecated method in java.lang.System has been called
> WARNING: System::setSecurityManager has been called by
> org.apache.cassandra.security.ThreadAwareSecurityManager
> (file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar)
> WARNING: Please consider reporting this to the maintainers of
> org.apache.cassandra.security.ThreadAwareSecurityManager
> WARNING: System::setSecurityManager will be removed in a future release
> Anybody knows if these warnings are legit/expected ? We can create
> follow-up tickets if needed.
> $ java --version
> openjdk 17.0.9 2023-10-17
> OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9)
> OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode,
> sharing)
> {code}
> {code:java}
> Clarification: - When running nodetool only the "Unknown module" warnings
> show up. All warnings show up during startup.{code}
> We need to verify whether this presents a real problem in the features where
> those modules are expected to be used, or if it is a false alarm.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-94) Reduce filesystem calls while streaming SSTables
[ https://issues.apache.org/jira/browse/CASSANDRASC-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRASC-94: -- Authors: Francisco Guerrero Test and Documentation Plan: Added unit tests that tests the newly introduced caches Status: Patch Available (was: In Progress) PR: https://github.com/apache/cassandra-sidecar/pull/91 CI: https://app.circleci.com/pipelines/github/frankgh/cassandra-sidecar/430 > Reduce filesystem calls while streaming SSTables > > > Key: CASSANDRASC-94 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-94 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > When streaming snapshotted SSTables from Cassandra Sidecar, Sidecar will > perform multiple filesystem calls: > - Traverse the data directories to determine the keyspace / table path > - Once found determine if the SSTable file exists under the snapshots > directory > - Read the filesystem to obtain the file type and file size > - Read the requested range of the file and stream it > The amount of filesystem calls is manageable for streaming a single SSTable, > but when a client(s) read multiple SSTables, for example in the case of > Cassandra Analytics bulk reads, hundred to thousand of requests are performed > requiring every request to perform the above system calls. > In this improvement, it is proposed introducing several caches to reduce the > amount of system calls while streaming SSTables. > - *snapshot list cache*: to maintain a cache of recently listed snapshot > files under a snapshot directory. This cache avoids having to access the > filesystem every time a bulk read client list the snapshot directory. > - *table dir cache*: to maintain a cache of recently streamed table directory > paths. This cache helps avoiding having to traverse the filesystem searching > for the table directory while running bulk reads for example. Since bulk > reads can stream tens to hundreds of SSTable components from a snapshot > directory, this cache helps avoid having to resolve the table directory each > time. > - *snapshot path cache*: to maintain a cache of recently streamed snapshot > SSTable components. This cache avoids having to resolve the snapshot SSTable > component path during bulk reads. Since bulk reads streams sub-ranges of an > SSTable component, the resolution can happen multiple times during bulk reads > for a single SSTable component. > - *file props cache*: to maintain a cache of FileProps of recently streamed > files. This cache avoids having to validate file properties during bulk reads > for example where sub-ranges of an SSTable component are streamed, therefore > reading the file properties can occur multiple times during bulk reads of the > same file. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19001) Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue
[
https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808828#comment-17808828
]
Ekaterina Dimitrova commented on CASSANDRA-19001:
-
I will commit this patch but keep the ticket open as I believe there is part 2.
Packaging?
I see some differences between bin/cassandra.in.sh and redhat/cassandra.in.sh
and it seems the debian diff on 5.0 was updated once in 2020 since it was
created for 5.0.
I am questioning my understanding around those files and how/ when we update
them. [~mck], [~brandon.williams], can you help me understand whether I should
update those and, in general, when they are updated? Or were they just missed
being updated in time?
> Check whether the startup warnings for unknown modules represent a legit
> problem or cosmetic issue
> --
>
> Key: CASSANDRA-19001
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19001
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.0-rc, 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During the 5.0 alpha 2 release
> [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr],
> [~paulo] raised the following concerns:
> {code:java}
> Launched a tarball-based 5.0-alpha2 container on top of
> "eclipse-temurin:17-jre-focal" and the server starts up fine, can run
> nodetool and cqlsh.
> I got these seemingly harmless JDK17 warnings during startup and when
> running nodetool (no warnings on JDK11):
> WARNING: Unknown module: jdk.attach specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-opens
> WARNING: A terminally deprecated method in java.lang.System has been called
> WARNING: System::setSecurityManager has been called by
> org.apache.cassandra.security.ThreadAwareSecurityManager
> (file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar)
> WARNING: Please consider reporting this to the maintainers of
> org.apache.cassandra.security.ThreadAwareSecurityManager
> WARNING: System::setSecurityManager will be removed in a future release
> Anybody knows if these warnings are legit/expected ? We can create
> follow-up tickets if needed.
> $ java --version
> openjdk 17.0.9 2023-10-17
> OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9)
> OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode,
> sharing)
> {code}
> {code:java}
> Clarification: - When running nodetool only the "Unknown module" warnings
> show up. All warnings show up during startup.{code}
> We need to verify whether this presents a real problem in the features where
> those modules are expected to be used, or if it is a false alarm.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-95) Adding sidecar client changes for restore from S3
[ https://issues.apache.org/jira/browse/CASSANDRASC-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRASC-95: -- Reviewers: Francisco Guerrero Status: Review In Progress (was: Patch Available) > Adding sidecar client changes for restore from S3 > - > > Key: CASSANDRASC-95 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-95 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > > Adding sidecar client changes so that clients can interact with the sidecar > server to restore from S3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-95) Adding sidecar client changes for restore from S3
[ https://issues.apache.org/jira/browse/CASSANDRASC-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808827#comment-17808827 ] Francisco Guerrero commented on CASSANDRASC-95: --- +1 Thanks for the patch > Adding sidecar client changes for restore from S3 > - > > Key: CASSANDRASC-95 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-95 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > > Adding sidecar client changes so that clients can interact with the sidecar > server to restore from S3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18813) Simplify the bind marker and Term logic
[
https://issues.apache.org/jira/browse/CASSANDRA-18813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808823#comment-17808823
]
Ekaterina Dimitrova commented on CASSANDRA-18813:
-
I just made a final pass, focused on whether any changes affected the patch
after the big rebases. I did not find any conflicts which would have changed
the code and required attention. If I haven't missed anything that you may
point out to me to check - +1
I also looked into the CI results:
I haven't found anything about this failure -
org.apache.cassandra.distributed.test.SnapshotsTest, but I do not think it can
relate to the patch. I suggest we do a repeated run against trunk and open a
ticket for the community to check this one.
- test-cassandra.testtag_IS_UNDEFINED - CASSANDRA-19279
- jvm tests failing with OOM - CASSANDRA-19279
- testDropListAndAddListWithSameName-oa_jdk17 - CASSANDRA-18360
> Simplify the bind marker and Term logic
> ---
>
> Key: CASSANDRA-18813
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18813
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> The current logic around {{Term}} and {{Terms}} classes is confusing
> specially with {{MultiItemTerminal}} and {{MultiColumnRaw}} that are used to
> handle different use cases that could be handled simply with the {{Term}}
> interface.
> On top of that IN marker add to the confusion because the are represented as
> single Term where in practice they are a set of terms. Representing them as a
> {{Terms}} could simplify the way we handle IN restrictions.
> The goal of this ticket is:
> * to refactor the {{Term}} and {{Terms}} interfaces to simplify the logic
> * Represents IN bind marker as {{Terms}} instead of having 2 different
> representations (a list of terms and a single {{MultiItemTerminal}}.
> * Simplify the {{AbstractMarker}} hierachy
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18360) Test Failure: o.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName
[
https://issues.apache.org/jira/browse/CASSANDRA-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808822#comment-17808822
]
Ekaterina Dimitrova commented on CASSANDRA-18360:
-
Another failure here -
https://app.circleci.com/pipelines/github/blerer/cassandra/372/workflows/8ef2ff8a-4a01-439a-93dd-03b01254dcde/jobs/7940/tests
> Test Failure:
> o.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName
> ---
>
> Key: CASSANDRA-18360
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18360
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 5.x
>
>
> The unit test
> {{org.apache.cassandra.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName}}
> is flaky at least on trunk. Flakiness seems lesser than 1%.
> While I haven't seen it on Jenkins yet, it can easily be reproduced on
> CircleCI with the multiplexer:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/58edc2f6-9a21-4d09-b783-b7fb15e1b320/jobs/32235
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/58edc2f6-9a21-4d09-b783-b7fb15e1b320/jobs/32234
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/739a95d3-8e42-4447-93dd-122fc16fdd7d/jobs/32233/tests
> Those runs show two types of errors:
> {code}
> junit.framework.AssertionFailedError: Invalid value for row 0 column 1
> (content of type text), expected but got
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1506)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:102)
> {code}
> and:
> {code}
> org.apache.cassandra.serializers.MarshalException: Invalid UTF-8 bytes
> 00e0279515437f00
> at
> org.apache.cassandra.serializers.AbstractTextSerializer.deserialize(AbstractTextSerializer.java:46)
> at
> org.apache.cassandra.serializers.AbstractTextSerializer.deserialize(AbstractTextSerializer.java:29)
> at
> org.apache.cassandra.serializers.TypeSerializer.deserialize(TypeSerializer.java:37)
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1494)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:102)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> The CircleCI config I used to reproduce the test failure can be generated
> with:
> {code}
> .circleci/generate.sh -p \
> -e REPEATED_UTESTS_COUNT=500 \
> -e REPEATED_UTESTS=org.apache.cassandra.cql3.validation.operations.AlterTest
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-86) Startup Validation Failures when Checking Sidecar Connectivity
[ https://issues.apache.org/jira/browse/CASSANDRASC-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-86: - Reviewers: Yifan Cai Status: Review In Progress (was: Patch Available) > Startup Validation Failures when Checking Sidecar Connectivity > -- > > Key: CASSANDRASC-86 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-86 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > We have experienced repeated startup validation failures caused by Sidecar > health checks for some jobs with a large number of Spark executors. > These failures are likely caused by the thundering herd problem, and have > been so far worked around by disabling startup validations altogether. > In order to prevent them going forward, a random delay needs to be added > between retries of health checks in Sidecar client. > It is also worth increasing the overall timeout for Sidecar health checks > from current 30 seconds to 60 seconds. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19276) Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
[
https://issues.apache.org/jira/browse/CASSANDRA-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808819#comment-17808819
]
Andy Tolbert edited comment on CASSANDRA-19276 at 1/19/24 10:56 PM:
ah, interesting, let me see if I can use in conjunction. I think the rule will
allow {{}}} on the same line, but i'm not certain if it will by proxy allow {
to exist in the same way, i'll test that out as if we can make that work it'd
cut the number of violations significantly.
was (Author: andrew.tolbert):
ah, interesting, let me see if I can use in conjunction. I think the rule will
allow {{}}} on the same line, but i'm not certain if it will by proxy allow
{{{}} to exist in the same way, i'll test that out as if we can make that work
it'd cut the number of violations significantly.
> Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
> ---
>
> Key: CASSANDRA-19276
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19276
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
> Attachments: checkstyle_lcurly_output.zip
>
>
> It came up in a review that I had missed some style changes in
> [CASSANDRA-18857]
> (https://github.com/apache/cassandra/pull/2969#pullrequestreview-1810999533).
> Chatting with [~smiklosovic] we agreed that it would be nice if we could
> enforce this in checkstyle, so we wouldn't need to be dependent on this being
> caught in review.
> The change for this is effectively:
> {code}
> index 8b81f21281..9bd22dc1ac 100644
> --- a/.build/checkstyle.xml
> +++ b/.build/checkstyle.xml
> @@ -179,6 +179,10 @@
> value="'Deprecated annotation must provide 'since' value."/>
>
> +
> +
> + value="ANNOTATION_DEF,CLASS_DEF,CTOR_DEF,ENUM_CONSTANT_DEF,INTERFACE_DEF,LITERAL_CASE,LITERAL_CATCH,LITERAL_DEFAULT,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_SWITCH,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,METHOD_DEF,OBJBLOCK,STATIC_INIT,RECORD_DEF,COMPACT_CTOR_DEF"/>
> +
>
>
> {code}
> Notably, we would allow braces on the same lines for lambdas as per the
> [project
> guidelines|https://cassandra.apache.org/_/development/code_style.html] on
> code formatting:
> {quote}
> {{{}} and {{}}} are placed on a new line except when empty or opening a
> multi-line lambda expression. Braces may be elided to a depth of one if the
> condition or loop guards a single expression.
> {quote}
> There are 594 violations and 211 source files that would need to be adjusted.
> I may play with the rules a little bit more to get this right.
> I would like to propose that we change all files that are not imported from
> other projects (there are a few, such as
> src/java/org/apache/cassandra/utils/obs/BitUtil.java, which we can suppress
> changes for), but we would change others.
> I'll make a patch with the changes send a small proposal to the mailing list
> as it could be disruptive to make a bunch of tiny changes, and depending on
> timing there may be a better time to make a change like this.
> We should make this change only on trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19276) Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
[
https://issues.apache.org/jira/browse/CASSANDRA-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808819#comment-17808819
]
Andy Tolbert edited comment on CASSANDRA-19276 at 1/19/24 10:56 PM:
ah, interesting, let me see if I can use in conjunction. I think the rule will
allow {{}}} on the same line, but i'm not certain if it will by proxy allow
{{{}} to exist in the same way, i'll test that out as if we can make that work
it'd cut the number of violations significantly.
was (Author: andrew.tolbert):
ah, interesting, let me see if I can use in conjunction. I think the rule will
allow {{}}} on the same line, but i'm not certain if it will by proxy allow
{{{}} to exist in the same way, i'll test that out as if we can make that work
it'd cut the number of violations significantly.
> Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
> ---
>
> Key: CASSANDRA-19276
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19276
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
> Attachments: checkstyle_lcurly_output.zip
>
>
> It came up in a review that I had missed some style changes in
> [CASSANDRA-18857]
> (https://github.com/apache/cassandra/pull/2969#pullrequestreview-1810999533).
> Chatting with [~smiklosovic] we agreed that it would be nice if we could
> enforce this in checkstyle, so we wouldn't need to be dependent on this being
> caught in review.
> The change for this is effectively:
> {code}
> index 8b81f21281..9bd22dc1ac 100644
> --- a/.build/checkstyle.xml
> +++ b/.build/checkstyle.xml
> @@ -179,6 +179,10 @@
> value="'Deprecated annotation must provide 'since' value."/>
>
> +
> +
> + value="ANNOTATION_DEF,CLASS_DEF,CTOR_DEF,ENUM_CONSTANT_DEF,INTERFACE_DEF,LITERAL_CASE,LITERAL_CATCH,LITERAL_DEFAULT,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_SWITCH,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,METHOD_DEF,OBJBLOCK,STATIC_INIT,RECORD_DEF,COMPACT_CTOR_DEF"/>
> +
>
>
> {code}
> Notably, we would allow braces on the same lines for lambdas as per the
> [project
> guidelines|https://cassandra.apache.org/_/development/code_style.html] on
> code formatting:
> {quote}
> {{{}} and {{}}} are placed on a new line except when empty or opening a
> multi-line lambda expression. Braces may be elided to a depth of one if the
> condition or loop guards a single expression.
> {quote}
> There are 594 violations and 211 source files that would need to be adjusted.
> I may play with the rules a little bit more to get this right.
> I would like to propose that we change all files that are not imported from
> other projects (there are a few, such as
> src/java/org/apache/cassandra/utils/obs/BitUtil.java, which we can suppress
> changes for), but we would change others.
> I'll make a patch with the changes send a small proposal to the mailing list
> as it could be disruptive to make a bunch of tiny changes, and depending on
> timing there may be a better time to make a change like this.
> We should make this change only on trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19276) Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
[
https://issues.apache.org/jira/browse/CASSANDRA-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808819#comment-17808819
]
Andy Tolbert edited comment on CASSANDRA-19276 at 1/19/24 10:55 PM:
ah, interesting, let me see if I can use in conjunction. I think the rule will
allow {{}}} on the same line, but i'm not certain if it will by proxy allow
{{{}} to exist in the same way, i'll test that out as if we can make that work
it'd cut the number of violations significantly.
was (Author: andrew.tolbert):
ah, interesting, let me see if I can use in conjunction. I think the rule will
allow {{}}} on the same line, but i'm not certain if it will by proxy allow
{{}}} to exist in the same way, i'll test that out as if we can make that work
it'd cut the number of violations significantly.
> Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
> ---
>
> Key: CASSANDRA-19276
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19276
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
> Attachments: checkstyle_lcurly_output.zip
>
>
> It came up in a review that I had missed some style changes in
> [CASSANDRA-18857]
> (https://github.com/apache/cassandra/pull/2969#pullrequestreview-1810999533).
> Chatting with [~smiklosovic] we agreed that it would be nice if we could
> enforce this in checkstyle, so we wouldn't need to be dependent on this being
> caught in review.
> The change for this is effectively:
> {code}
> index 8b81f21281..9bd22dc1ac 100644
> --- a/.build/checkstyle.xml
> +++ b/.build/checkstyle.xml
> @@ -179,6 +179,10 @@
> value="'Deprecated annotation must provide 'since' value."/>
>
> +
> +
> + value="ANNOTATION_DEF,CLASS_DEF,CTOR_DEF,ENUM_CONSTANT_DEF,INTERFACE_DEF,LITERAL_CASE,LITERAL_CATCH,LITERAL_DEFAULT,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_SWITCH,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,METHOD_DEF,OBJBLOCK,STATIC_INIT,RECORD_DEF,COMPACT_CTOR_DEF"/>
> +
>
>
> {code}
> Notably, we would allow braces on the same lines for lambdas as per the
> [project
> guidelines|https://cassandra.apache.org/_/development/code_style.html] on
> code formatting:
> {quote}
> {{{}} and {{}}} are placed on a new line except when empty or opening a
> multi-line lambda expression. Braces may be elided to a depth of one if the
> condition or loop guards a single expression.
> {quote}
> There are 594 violations and 211 source files that would need to be adjusted.
> I may play with the rules a little bit more to get this right.
> I would like to propose that we change all files that are not imported from
> other projects (there are a few, such as
> src/java/org/apache/cassandra/utils/obs/BitUtil.java, which we can suppress
> changes for), but we would change others.
> I'll make a patch with the changes send a small proposal to the mailing list
> as it could be disruptive to make a bunch of tiny changes, and depending on
> timing there may be a better time to make a change like this.
> We should make this change only on trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19276) Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
[
https://issues.apache.org/jira/browse/CASSANDRA-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808819#comment-17808819
]
Andy Tolbert commented on CASSANDRA-19276:
--
ah, interesting, let me see if I can use in conjunction. I think the rule will
allow {{}}} on the same line, but i'm not certain if it will by proxy allow
{{}}} to exist in the same way, i'll test that out as if we can make that work
it'd cut the number of violations significantly.
> Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
> ---
>
> Key: CASSANDRA-19276
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19276
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
> Attachments: checkstyle_lcurly_output.zip
>
>
> It came up in a review that I had missed some style changes in
> [CASSANDRA-18857]
> (https://github.com/apache/cassandra/pull/2969#pullrequestreview-1810999533).
> Chatting with [~smiklosovic] we agreed that it would be nice if we could
> enforce this in checkstyle, so we wouldn't need to be dependent on this being
> caught in review.
> The change for this is effectively:
> {code}
> index 8b81f21281..9bd22dc1ac 100644
> --- a/.build/checkstyle.xml
> +++ b/.build/checkstyle.xml
> @@ -179,6 +179,10 @@
> value="'Deprecated annotation must provide 'since' value."/>
>
> +
> +
> + value="ANNOTATION_DEF,CLASS_DEF,CTOR_DEF,ENUM_CONSTANT_DEF,INTERFACE_DEF,LITERAL_CASE,LITERAL_CATCH,LITERAL_DEFAULT,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_SWITCH,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,METHOD_DEF,OBJBLOCK,STATIC_INIT,RECORD_DEF,COMPACT_CTOR_DEF"/>
> +
>
>
> {code}
> Notably, we would allow braces on the same lines for lambdas as per the
> [project
> guidelines|https://cassandra.apache.org/_/development/code_style.html] on
> code formatting:
> {quote}
> {{{}} and {{}}} are placed on a new line except when empty or opening a
> multi-line lambda expression. Braces may be elided to a depth of one if the
> condition or loop guards a single expression.
> {quote}
> There are 594 violations and 211 source files that would need to be adjusted.
> I may play with the rules a little bit more to get this right.
> I would like to propose that we change all files that are not imported from
> other projects (there are a few, such as
> src/java/org/apache/cassandra/utils/obs/BitUtil.java, which we can suppress
> changes for), but we would change others.
> I'll make a patch with the changes send a small proposal to the mailing list
> as it could be disruptive to make a bunch of tiny changes, and depending on
> timing there may be a better time to make a change like this.
> We should make this change only on trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18714) Expand CQLSSTableWriter to write SSTable-attached secondary indexes
[
https://issues.apache.org/jira/browse/CASSANDRA-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808816#comment-17808816
]
Caleb Rackliffe commented on CASSANDRA-18714:
-
+1 to the trunk patch, pending the addition of a basic client mode test
> Expand CQLSSTableWriter to write SSTable-attached secondary indexes
> ---
>
> Key: CASSANDRA-18714
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18714
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SAI, Tool/bulk load
>Reporter: Caleb Rackliffe
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
> Attachments: client-mode-cqlsstablewriter-tests.patch
>
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
> {{CQLSSTableWriter}} currently has no way of writing any secondary indexes
> inline as it writes the core SSTable components. With SAI, this has become
> tractable problem, and we should be able to enhance both it and
> {{SSTableImporter}} to handle cases where we might want to write SSTables
> somewhere in bulk (and in parallel) and then import them without waiting for
> index building on import. It would require the following changes:
> 1.) {{CQLSSTableWriter}} must accept 2i definitions on top of its current
> table schema definition. Once added to the schema, any {{ColumnFamilyStore}}
> instances opened will have those 2i defined in their index managers.
> 2.) All {{AbstractSSTableSimpleWriter}} instances must register index groups,
> allowing the proper {{SSTableFlushObservers}} to be attached to
> {{SSTableWriter}}. Once this is done, SAI (and any other SSTable-attached
> indexes) components will be built incrementally along w/ the SSTable data
> file, and will be finalized when the newly written SSTable is finalized.
> 3.) Provide an example (in a unit test?) of how a third-party tool might,
> assuming access to the right C* JAR, validate/checksum SAI components outside
> C* proper.
> 4.) {{SSTableImporter}} should have two new options:
> a.) an option that fails import if any SSTable-attached 2i must be built
> (i.e. has not already been built and brought along w/ the other new SSTable
> components)
> b.) an option that allows us to bypass full checksum validation on
> imported/already-built SSTable-attached indexes (assuming they have just been
> written by {{CQLSSTableWriter}})
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14572) Expose all table metrics in virtual table
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808808#comment-17808808
]
Michael Semb Wever commented on CASSANDRA-14572:
bq. if someone wrote a script to constantly poll this virtual table. Maybe add
some documentation that discourages polling of this virtual table?
could we add a guardrail and/or rate-limiter on it?
> Expose all table metrics in virtual table
> -
>
> Key: CASSANDRA-14572
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14572
> Project: Cassandra
> Issue Type: New Feature
> Components: Legacy/Observability, Observability/Metrics
>Reporter: Chris Lohfink
>Assignee: Maxim Muzafarov
>Priority: Low
> Labels: virtual-tables
> Fix For: 5.x
>
> Attachments: keyspayces_group responses times.png, keyspayces_group
> summary.png, select keyspaces_group by string prefix.png, select
> keyspaces_group compare with wo.png, select keyspaces_group without
> value.png, systemv_views.metrics_dropped_message.png, thread_pools
> benchmark.png
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> While we want a number of virtual tables to display data in a way thats great
> and intuitive like in nodetool. There is also much for being able to expose
> the metrics we have for tooling via CQL instead of JMX. This is more for the
> tooling and adhoc advanced users who know exactly what they are looking for.
> *Schema:*
> Initial idea is to expose data via {{((keyspace, table), metric)}} with a
> column for each metric value. Could also use a Map or UDT instead of the
> column based that can be a bit more specific to each metric type. To that end
> there can be a {{metric_type}} column and then a UDT for each metric type
> filled in, or a single value with more of a Map style. I am
> purposing the column type though as with {{ALLOW FILTERING}} it does allow
> more extensive query capabilities.
> *Implementations:*
> * Use reflection to grab all the metrics from TableMetrics (see:
> CASSANDRA-7622 impl). This is easiest and least abrasive towards new metric
> implementors... but its reflection and a kinda a bad idea.
> * Add a hook in TableMetrics to register with this virtual table when
> registering
> * Pull from the CassandraMetrics registery (either reporter or iterate
> through metrics query on read of virtual table)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18857) Allow CQL client certificate authentication to work without sending an AUTHENTICATE request
[
https://issues.apache.org/jira/browse/CASSANDRA-18857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808807#comment-17808807
]
Andy Tolbert commented on CASSANDRA-18857:
--
Thanks everyone! Test results attached, things came back mostly clean:
[^ci_summary.html]
[^result_details.tar.gz]
The failing tests appear to be unrelated/flakes:
* largecolumn_test.TestLargeColumn#test_cleanup - looks like a common flake
that has come up a number of times; I'll look into seeing if something i can
help with if not already handled, but high confidence it's not related to my
change.
*
upgrade_tests.upgrade_through_versions_test.TestUpgrade_indev_4_1_x_To_indev_trunk
test_bootstrap_multidc ([CASSANDRA-17893])
*
upgrade_tests.upgrade_through_versions_test.TestUpgrade_indev_4_1_x_To_indev_trunk
test_parallel_upgrade_with_internode_ssl ([CASSANDRA-17893])
> Allow CQL client certificate authentication to work without sending an
> AUTHENTICATE request
> ---
>
> Key: CASSANDRA-18857
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18857
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Encryption
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Normal
> Attachments: ci_summary.html, result_details.tar.gz
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Currently when using {{MutualTlsAuthenticator}} or
> {{MutualTlsWithPasswordFallbackAuthenticator}} a client is prompted with an
> {{AUTHENTICATE}} message to which they must respond with an {{AUTH_RESPONSE}}
> (e.g. a user name and password). This shouldn't be needed as the role can be
> identified using only the certificate.
> To address this, we could add the capability to authenticate early in
> processing of a {{STARTUP}} message if we can determine that both the
> configured authenticator supports certificate authentication and a client
> certificate was provided. If the certificate can be authenticated, a
> {{READY}} response is returned, otherwise an {{ERROR}} is returned.
> This change can be done done in a fully backwards compatible way and requires
> no protocol or driver changes; I will supply a patch shortly!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18857) Allow CQL client certificate authentication to work without sending an AUTHENTICATE request
[
https://issues.apache.org/jira/browse/CASSANDRA-18857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Tolbert updated CASSANDRA-18857:
-
Attachment: ci_summary.html
> Allow CQL client certificate authentication to work without sending an
> AUTHENTICATE request
> ---
>
> Key: CASSANDRA-18857
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18857
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Encryption
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Normal
> Attachments: ci_summary.html, result_details.tar.gz
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Currently when using {{MutualTlsAuthenticator}} or
> {{MutualTlsWithPasswordFallbackAuthenticator}} a client is prompted with an
> {{AUTHENTICATE}} message to which they must respond with an {{AUTH_RESPONSE}}
> (e.g. a user name and password). This shouldn't be needed as the role can be
> identified using only the certificate.
> To address this, we could add the capability to authenticate early in
> processing of a {{STARTUP}} message if we can determine that both the
> configured authenticator supports certificate authentication and a client
> certificate was provided. If the certificate can be authenticated, a
> {{READY}} response is returned, otherwise an {{ERROR}} is returned.
> This change can be done done in a fully backwards compatible way and requires
> no protocol or driver changes; I will supply a patch shortly!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18857) Allow CQL client certificate authentication to work without sending an AUTHENTICATE request
[
https://issues.apache.org/jira/browse/CASSANDRA-18857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Tolbert updated CASSANDRA-18857:
-
Attachment: result_details.tar.gz
> Allow CQL client certificate authentication to work without sending an
> AUTHENTICATE request
> ---
>
> Key: CASSANDRA-18857
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18857
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Encryption
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Normal
> Attachments: ci_summary.html, result_details.tar.gz
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Currently when using {{MutualTlsAuthenticator}} or
> {{MutualTlsWithPasswordFallbackAuthenticator}} a client is prompted with an
> {{AUTHENTICATE}} message to which they must respond with an {{AUTH_RESPONSE}}
> (e.g. a user name and password). This shouldn't be needed as the role can be
> identified using only the certificate.
> To address this, we could add the capability to authenticate early in
> processing of a {{STARTUP}} message if we can determine that both the
> configured authenticator supports certificate authentication and a client
> certificate was provided. If the certificate can be authenticated, a
> {{READY}} response is returned, otherwise an {{ERROR}} is returned.
> This change can be done done in a fully backwards compatible way and requires
> no protocol or driver changes; I will supply a patch shortly!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-95) Adding sidecar client changes for restore from S3
[ https://issues.apache.org/jira/browse/CASSANDRASC-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808806#comment-17808806 ] Yifan Cai commented on CASSANDRASC-95: -- CI is green > Adding sidecar client changes for restore from S3 > - > > Key: CASSANDRASC-95 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-95 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > > Adding sidecar client changes so that clients can interact with the sidecar > server to restore from S3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19118) Add support of vector type to COPY command
[
https://issues.apache.org/jira/browse/CASSANDRA-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808805#comment-17808805
]
Andres de la Peña commented on CASSANDRA-19118:
---
Here we go:
||PR||CI||
|[5.0
|https://github.com/apache/cassandra/pull/2957]|[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3396/workflows/e4ad19c1-bb39-4d9b-b953-f2faa6727549]
[j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3396/workflows/fb84db84-5497-4a6c-bfd1-4e1969e4a77c]|
|[trunk|https://github.com/apache/cassandra/pull/3056]|[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3397/workflows/1eecda78-4da8-4804-ada8-283521ef9866]
[j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3397/workflows/2d0b5c05-f9fe-422b-8927-0edfb94b9703]|
> Add support of vector type to COPY command
> --
>
> Key: CASSANDRA-19118
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19118
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Szymon Miezal
>Assignee: Szymon Miezal
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> Currently it's not possible to import rows with vector literals via {{COPY}}
> command.
> STR:
> * Create a table
> {code:sql}
> CREATE TABLE testcopyfrom (id text PRIMARY KEY, embedding_vector
> VECTOR
> {code}
> * Prepare csv file with sample data, for instance:
> {code:sql}
> 1,"[0.1, 0.2, 0.3, 0.4, 0.5, 0.6]"
> 2,"[-0.1, -0.2, -0.3, -0.4, -0.5, -0.6]" {code}
> * in cqlsh run
> {code:sql}
> COPY ks.testcopyfrom FROM data.csv
> {code}
> It will result in getting:
> {code:sql}
> TypeError: Received an argument of invalid type for column
> "embedding_vector". Expected: ,
> Got: ; (required argument is not a float){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-95) Adding sidecar client changes for restore from S3
[ https://issues.apache.org/jira/browse/CASSANDRASC-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-95: - Test and Documentation Plan: ci; unit Status: Patch Available (was: Open) PR: [https://github.com/apache/cassandra-sidecar/pull/92] CI: [https://app.circleci.com/pipelines/github/yifan-c/cassandra-sidecar?branch=CASSANDRASC-95%2Ftrunk] > Adding sidecar client changes for restore from S3 > - > > Key: CASSANDRASC-95 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-95 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > > Adding sidecar client changes so that clients can interact with the sidecar > server to restore from S3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-95) Adding sidecar client changes for restore from S3
[ https://issues.apache.org/jira/browse/CASSANDRASC-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRASC-95: -- Labels: pull-request-available (was: ) > Adding sidecar client changes for restore from S3 > - > > Key: CASSANDRASC-95 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-95 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > > Adding sidecar client changes so that clients can interact with the sidecar > server to restore from S3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRASC-95) Adding sidecar client changes for restore from S3
Yifan Cai created CASSANDRASC-95: Summary: Adding sidecar client changes for restore from S3 Key: CASSANDRASC-95 URL: https://issues.apache.org/jira/browse/CASSANDRASC-95 Project: Sidecar for Apache Cassandra Issue Type: Improvement Reporter: Yifan Cai Assignee: Yifan Cai Adding sidecar client changes so that clients can interact with the sidecar server to restore from S3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-95) Adding sidecar client changes for restore from S3
[ https://issues.apache.org/jira/browse/CASSANDRASC-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-95: - Change Category: Operability Complexity: Normal Component/s: Rest API Status: Open (was: Triage Needed) > Adding sidecar client changes for restore from S3 > - > > Key: CASSANDRASC-95 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-95 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > > Adding sidecar client changes so that clients can interact with the sidecar > server to restore from S3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19001) Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue
[
https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-19001:
Bug Category: Parent values: Packaging(13660) (was: Parent values:
Degradation(12984)Level 1 values: Other Exception(12998))
> Check whether the startup warnings for unknown modules represent a legit
> problem or cosmetic issue
> --
>
> Key: CASSANDRA-19001
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19001
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.0-rc, 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During the 5.0 alpha 2 release
> [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr],
> [~paulo] raised the following concerns:
> {code:java}
> Launched a tarball-based 5.0-alpha2 container on top of
> "eclipse-temurin:17-jre-focal" and the server starts up fine, can run
> nodetool and cqlsh.
> I got these seemingly harmless JDK17 warnings during startup and when
> running nodetool (no warnings on JDK11):
> WARNING: Unknown module: jdk.attach specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-opens
> WARNING: A terminally deprecated method in java.lang.System has been called
> WARNING: System::setSecurityManager has been called by
> org.apache.cassandra.security.ThreadAwareSecurityManager
> (file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar)
> WARNING: Please consider reporting this to the maintainers of
> org.apache.cassandra.security.ThreadAwareSecurityManager
> WARNING: System::setSecurityManager will be removed in a future release
> Anybody knows if these warnings are legit/expected ? We can create
> follow-up tickets if needed.
> $ java --version
> openjdk 17.0.9 2023-10-17
> OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9)
> OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode,
> sharing)
> {code}
> {code:java}
> Clarification: - When running nodetool only the "Unknown module" warnings
> show up. All warnings show up during startup.{code}
> We need to verify whether this presents a real problem in the features where
> those modules are expected to be used, or if it is a false alarm.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19118) Add support of vector type to COPY command
[
https://issues.apache.org/jira/browse/CASSANDRA-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808755#comment-17808755
]
Andres de la Peña commented on CASSANDRA-19118:
---
[~szymon.miezal] I have just committed CASSANDRA-19245.
I'll run CI once the 5.0/trunk patches are rebased.
> Add support of vector type to COPY command
> --
>
> Key: CASSANDRA-19118
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19118
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Szymon Miezal
>Assignee: Szymon Miezal
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
> Currently it's not possible to import rows with vector literals via {{COPY}}
> command.
> STR:
> * Create a table
> {code:sql}
> CREATE TABLE testcopyfrom (id text PRIMARY KEY, embedding_vector
> VECTOR
> {code}
> * Prepare csv file with sample data, for instance:
> {code:sql}
> 1,"[0.1, 0.2, 0.3, 0.4, 0.5, 0.6]"
> 2,"[-0.1, -0.2, -0.3, -0.4, -0.5, -0.6]" {code}
> * in cqlsh run
> {code:sql}
> COPY ks.testcopyfrom FROM data.csv
> {code}
> It will result in getting:
> {code:sql}
> TypeError: Received an argument of invalid type for column
> "embedding_vector". Expected: ,
> Got: ; (required argument is not a float){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19245) Upgrade Python driver to 3.29.0
[
https://issues.apache.org/jira/browse/CASSANDRA-19245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-19245:
--
Fix Version/s: 5.0-beta2
(was: 5.0-rc)
Source Control Link:
https://github.com/apache/cassandra/commit/8fd44ca8fc9e0b0e94932bcd855e2833bf6ca3cb
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Upgrade Python driver to 3.29.0
> ---
>
> Key: CASSANDRA-19245
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19245
> Project: Cassandra
> Issue Type: Task
> Components: Feature/Vector Search, Tool/cqlsh
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0-beta2, 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The version of the Python driver that is used by cqlsh (3.28.0) doesn't
> correctly support vectors of variable-width types. Wrong deserialization can
> either fail with an exception or silently provide wrong results. For example:
> {code:java}
> cqlsh:k> CREATE TABLE t (k int PRIMARY KEY, v vector);
> cqlsh:k> INSERT INTO t(k, v) VALUES (1,
> [23452352356235654634567437463767365783768, 3]);
> cqlsh:k> SELECT * FROM t;
> k | v
> ---+--
> 1 | [289729430, -1001073214]}}
> {code}
> The most recent driver at the moment (3.29.0) still doesn't support this kind
> of vector, but it always fails with a proper message instead of dangerously
> providing wrong results, thanks to
> [PYTHON-1371|https://datastax-oss.atlassian.net/browse/PYTHON-1371].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 03f0d37cb0120625db25d0aec52bbc6b49c3982c Merge: 89e33a16ea 8fd44ca8fc Author: Andrés de la Peña AuthorDate: Fri Jan 19 17:33:55 2024 + Merge branch 'cassandra-5.0' into trunk .build/build-resolver.xml | 2 - .build/docker/run-tests.sh | 4 +- .build/docker/ubuntu2004_test.docker | 24 +- .build/run-python-dtests.sh| 2 +- .circleci/config.yml | 877 ++-- .circleci/config.yml.FREE | 877 ++-- .circleci/config.yml.PAID | 879 ++--- .circleci/config_template.yml | 170 +--- .circleci/config_template.yml.PAID.patch | 104 +-- CHANGES.txt| 1 + NEWS.txt | 4 +- bin/cqlsh | 6 +- bin/cqlsh.py | 6 +- .../cassandra/pages/installing/installing.adoc | 2 +- lib/cassandra-driver-internal-only-3.28.0.zip | Bin 356837 -> 0 bytes lib/cassandra-driver-internal-only-3.29.0.zip | Bin 0 -> 396496 bytes pylib/Dockerfile.ubuntu.py3| 2 +- ...kerfile.ubuntu.py37 => Dockerfile.ubuntu.py311} | 2 +- pylib/README.asc | 2 +- pylib/cassandra-cqlsh-tests.sh | 2 +- pylib/cqlshlib/test/run_cqlsh.py | 2 +- pylib/requirements.txt | 2 +- 22 files changed, 298 insertions(+), 2672 deletions(-) diff --cc .circleci/config_template.yml.PAID.patch index 422dddc650,a07902b350..8b4da040d0 --- a/.circleci/config_template.yml.PAID.patch +++ b/.circleci/config_template.yml.PAID.patch @@@ -1,5 -1,5 +1,5 @@@ - --- config_template.yml 2023-11-10 16:50:30.517080584 + - +++ config_template.yml.PAID 2023-11-10 16:51:58.40394 + config_template.yml 2024-01-05 00:32:24.148600479 + -+++ config_template.yml.PAID 2024-01-05 00:32:40.861079981 + ++--- config_template.yml 2024-01-05 12:06:28.009687781 + + config_template.yml.PAID 2024-01-05 12:09:25.083221646 + @@ -157,20 +157,20 @@ j11_par_executor: _par_executor executor: diff --cc CHANGES.txt index d1ed33baee,336edfb09f..565b1d80b6 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,13 -1,5 +1,14 @@@ -5.0-beta2 +5.1 + * Limit cassandra startup to supported JDKs, allow higher JDKs by setting CASSANDRA_JDK_UNSUPPORTED (CASSANDRA-18688) + * Standardize nodetool tablestats formatting of data units (CASSANDRA-19104) + * Make nodetool tablestats use number of significant digits for time and average values consistently (CASSANDRA-19015) + * Upgrade jackson to 2.15.3 and snakeyaml to 2.1 (CASSANDRA-18875) + * Transactional Cluster Metadata [CEP-21] (CASSANDRA-18330) + * Add ELAPSED command to cqlsh (CASSANDRA-18861) + * Add the ability to disable bulk loading of SSTables (CASSANDRA-18781) + * Clean up obsolete functions and simplify cql_version handling in cqlsh (CASSANDRA-18787) +Merged from 5.0: + * Upgrade Python driver to 3.29.0 (CASSANDRA-19245) * Creating a SASI index after creating an SAI index does not break secondary index queries (CASSANDRA-18939) * Optionally fail when a non-partition-restricted query is issued against an index (CASSANDRA-18796) * Add a startup check to fail startup when using invalid configuration with certain Kernel and FS type (CASSANDRA-19196) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch trunk updated (89e33a16ea -> 03f0d37cb0)
This is an automated email from the ASF dual-hosted git repository.
adelapena pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
from 89e33a16ea Limit cassandra startup to supported JDKs
new 8fd44ca8fc Upgrade Python driver to 3.29.0
new 03f0d37cb0 Merge branch 'cassandra-5.0' into trunk
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.build/build-resolver.xml | 2 -
.build/docker/run-tests.sh | 4 +-
.build/docker/ubuntu2004_test.docker | 24 +-
.build/run-python-dtests.sh| 2 +-
.circleci/config.yml | 877 ++--
.circleci/config.yml.FREE | 877 ++--
.circleci/config.yml.PAID | 879 ++---
.circleci/config_template.yml | 170 +---
.circleci/config_template.yml.PAID.patch | 104 +--
CHANGES.txt| 1 +
NEWS.txt | 4 +-
bin/cqlsh | 6 +-
bin/cqlsh.py | 6 +-
.../cassandra/pages/installing/installing.adoc | 2 +-
lib/cassandra-driver-internal-only-3.28.0.zip | Bin 356837 -> 0 bytes
lib/cassandra-driver-internal-only-3.29.0.zip | Bin 0 -> 396496 bytes
pylib/Dockerfile.ubuntu.py3| 2 +-
...kerfile.ubuntu.py37 => Dockerfile.ubuntu.py311} | 2 +-
pylib/README.asc | 2 +-
pylib/cassandra-cqlsh-tests.sh | 2 +-
pylib/cqlshlib/test/run_cqlsh.py | 2 +-
pylib/requirements.txt | 2 +-
22 files changed, 298 insertions(+), 2672 deletions(-)
delete mode 100644 lib/cassandra-driver-internal-only-3.28.0.zip
create mode 100644 lib/cassandra-driver-internal-only-3.29.0.zip
rename pylib/{Dockerfile.ubuntu.py37 => Dockerfile.ubuntu.py311} (80%)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] CASSANDRA-19180: Support reloading keystore in cassandra-java-driver [cassandra-java-driver]
aratno opened a new pull request, #1907: URL: https://github.com/apache/cassandra-java-driver/pull/1907 Jira: https://issues.apache.org/jira/browse/CASSANDRA-19180 This PR includes keystore reloading for `DefautlSslEngineFactory`, implemented by checking the contents of the keystore file at a periodic interval. This is intended to be useful in environments where mTLS is enabled, application instances restart infrequently, and certificates are short-lived. The existing default behavior (no reloading at all) would cause application re-connections to fail after the client certificate in the original keystore has expired, requiring an application restart to establish a new session to pick up the updated contents of the keystore file. This PR does not include a mechanism for updating the contents of a keystore file in different environments. In some environments where client certificates are automatically renewed, an application may have to load those certificates into their keystore with a tool like fsnotify or a cronjob to keep identity certificates and the client-referenced keystore file in sync. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-10821) OOM Killer terminates Cassandra when Compactions use too much memory then won't restart
[ https://issues.apache.org/jira/browse/CASSANDRA-10821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-10821: Description: We were writing to the DB from EC2 instances in us-east-1 at a rate of about 3000 per second, replication us-east:2 us-west:2, LeveledCompaction and DeflateCompressor. After about 48 hours some nodes had over 800 pending compactions and a few of them started getting killed for Linux OOM. Priam attempts to restart the nodes, but they fail because of corrupted saved_cahce files. Loading has finished, and the cluster is mostly idle, but 6 of the nodes were killed again last night by OOM. This is the log message where the node won't restart: ERROR [main] 2015-12-05 13:59:13,754 CassandraDaemon.java:635 - Detected unreadable sstables /media/ephemeral0/cassandra/saved_caches/KeyCache-ca.db, please check NEWS.txt and ensure that you have upgraded through all required intermediate versions, running upgradesstables This is the dmesg where the node is terminated: [360803.234422] Out of memory: Kill process 10809 (java) score 949 or sacrifice child [360803.237544] Killed process 10809 (java) total-vm:438484092kB, anon-rss:29228012kB, file-rss:107576kB This is what Compaction Stats look like currently: pending tasks: 1096 id compaction type keyspace table completed total unit progress 93eb3200-9b58-11e5-b9f1-ffef1041ec45 Compaction overlordpreprod document 8670748796 839129219651 bytes 1.03% Compaction system hints 30 1921326518 bytes 0.00% Active compaction remaining time : 27h33m47s Only 6 of the 32 nodes have compactions pending, and all on the order of 1000. was: We were writing to the DB from EC2 instances in us-east-1 at a rate of about 3000 per second, replication us-east:2 us-west:2, LeveledCompaction and DeflateCompressor. After about 48 hours some nodes had over 800 pending compactions and a few of them started getting killed for Linux OOM. Priam attempts to restart the nodes, but they fail because of corrupted saved_cahce files. Loading has finished, and the cluster is mostly idle, but 6 of the nodes were killed again last night by OOM. This is the log message where the node won't restart: ERROR [main] 2015-12-05 13:59:13,754 CassandraDaemon.java:635 - Detected unreadable sstables /media/ephemeral0/cassandra/saved_caches/KeyCache-ca.db, please check NEWS.txt and ensure that you have upgraded through all required intermediate versions, running upgradesstables This is the dmesg where the node is terminated: [360803.234422] Out of memory: Kill process 10809 (java) score 949 or sacrifice child [360803.237544] Killed process 10809 (java) total-vm:438484092kB, anon-rss:29228012kB, file-rss:107576kB This is what Compaction Stats look like currently: pending tasks: 1096 id compaction type keyspace tablecompleted totalunit progress 93eb3200-9b58-11e5-b9f1-ffef1041ec45Compaction overlordpreprod document 8670748796 839129219651 bytes 1.03% Compactionsystem hints 30 1921326518 bytes 0.00% Active compaction remaining time : 27h33m47s Only 6 of the 32 nodes have compactions pending, and all on the order of 1000. > OOM Killer terminates Cassandra when Compactions use too much memory then > won't restart > --- > > Key: CASSANDRA-10821 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10821 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction > Environment: EC2 32 x i2.xlarge split between us-east-1a,c and > us-west 2a,b > Linux 4.1.10-17.31.amzn1.x86_64 #1 SMP Sat Oct 24 01:31:37 UTC 2015 x86_64 > x86_64 x86_64 GNU/Linux > Java(TM) SE Runtime Environment (build 1.8.0_65-b17) > Java HotSpot(TM) 64-Bit Server VM (build 25.65-b01, mixed mode) > Cassandra version: 2.2.3 >Reporter: tbartold >Priority: Normal > > > We were writing to the DB from EC2 instances in us-east-1 at a rate of about > 3000 per second, replication us-east:2 us-west:2, LeveledCompaction and > DeflateCompressor. > After about 48 hours some nodes had over 800 pending compactions and a few of > them started getting killed for Linux OOM. Priam attempts to restart the > nodes, but they fail because of corrupted saved_cahce files. > Loading has finished, and the cluster is mostly idle, but 6 of the nodes were > killed again last night by OOM. > This is the log message where the node won't restart: > ERROR [main] 2015-12-05 13:59:13,754 CassandraDaemon.java:635 - Detected > unreadable sstables /media/ephemeral0/cassandra/saved_caches/KeyCache-ca.db, > please check NEWS.txt and ensure that you have
[jira] [Updated] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-19097:
-
Fix Version/s: 5.0-rc
5.x
(was: 5.0)
(was: 4.0.12)
(was: 4.1.4)
(was: 5.1)
(was: 5.0-beta2)
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18714) Expand CQLSSTableWriter to write SSTable-attached secondary indexes
[
https://issues.apache.org/jira/browse/CASSANDRA-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808675#comment-17808675
]
Stefan Miklosovic commented on CASSANDRA-18714:
---
[~maedhroz] notes for the review - we put the tests how they were because what
we did in 5.0 is just not applicable to trunk ... Doug knows about this. We
will try to rewrite it later in trunk, not at this stage.
> Expand CQLSSTableWriter to write SSTable-attached secondary indexes
> ---
>
> Key: CASSANDRA-18714
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18714
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SAI, Tool/bulk load
>Reporter: Caleb Rackliffe
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
> Attachments: client-mode-cqlsstablewriter-tests.patch
>
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
> {{CQLSSTableWriter}} currently has no way of writing any secondary indexes
> inline as it writes the core SSTable components. With SAI, this has become
> tractable problem, and we should be able to enhance both it and
> {{SSTableImporter}} to handle cases where we might want to write SSTables
> somewhere in bulk (and in parallel) and then import them without waiting for
> index building on import. It would require the following changes:
> 1.) {{CQLSSTableWriter}} must accept 2i definitions on top of its current
> table schema definition. Once added to the schema, any {{ColumnFamilyStore}}
> instances opened will have those 2i defined in their index managers.
> 2.) All {{AbstractSSTableSimpleWriter}} instances must register index groups,
> allowing the proper {{SSTableFlushObservers}} to be attached to
> {{SSTableWriter}}. Once this is done, SAI (and any other SSTable-attached
> indexes) components will be built incrementally along w/ the SSTable data
> file, and will be finalized when the newly written SSTable is finalized.
> 3.) Provide an example (in a unit test?) of how a third-party tool might,
> assuming access to the right C* JAR, validate/checksum SAI components outside
> C* proper.
> 4.) {{SSTableImporter}} should have two new options:
> a.) an option that fails import if any SSTable-attached 2i must be built
> (i.e. has not already been built and brought along w/ the other new SSTable
> components)
> b.) an option that allows us to bypass full checksum validation on
> imported/already-built SSTable-attached indexes (assuming they have just been
> written by {{CQLSSTableWriter}})
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18714) Expand CQLSSTableWriter to write SSTable-attached secondary indexes
[
https://issues.apache.org/jira/browse/CASSANDRA-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808675#comment-17808675
]
Stefan Miklosovic edited comment on CASSANDRA-18714 at 1/19/24 2:13 PM:
[~maedhroz] notes for the review - we changed the tests how they were because
what we did in 5.0 is just not applicable to trunk ... Doug knows about this.
We will try to rewrite it later in trunk, not at this stage.
was (Author: smiklosovic):
[~maedhroz] notes for the review - we put the tests how they were because what
we did in 5.0 is just not applicable to trunk ... Doug knows about this. We
will try to rewrite it later in trunk, not at this stage.
> Expand CQLSSTableWriter to write SSTable-attached secondary indexes
> ---
>
> Key: CASSANDRA-18714
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18714
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SAI, Tool/bulk load
>Reporter: Caleb Rackliffe
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
> Attachments: client-mode-cqlsstablewriter-tests.patch
>
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
> {{CQLSSTableWriter}} currently has no way of writing any secondary indexes
> inline as it writes the core SSTable components. With SAI, this has become
> tractable problem, and we should be able to enhance both it and
> {{SSTableImporter}} to handle cases where we might want to write SSTables
> somewhere in bulk (and in parallel) and then import them without waiting for
> index building on import. It would require the following changes:
> 1.) {{CQLSSTableWriter}} must accept 2i definitions on top of its current
> table schema definition. Once added to the schema, any {{ColumnFamilyStore}}
> instances opened will have those 2i defined in their index managers.
> 2.) All {{AbstractSSTableSimpleWriter}} instances must register index groups,
> allowing the proper {{SSTableFlushObservers}} to be attached to
> {{SSTableWriter}}. Once this is done, SAI (and any other SSTable-attached
> indexes) components will be built incrementally along w/ the SSTable data
> file, and will be finalized when the newly written SSTable is finalized.
> 3.) Provide an example (in a unit test?) of how a third-party tool might,
> assuming access to the right C* JAR, validate/checksum SAI components outside
> C* proper.
> 4.) {{SSTableImporter}} should have two new options:
> a.) an option that fails import if any SSTable-attached 2i must be built
> (i.e. has not already been built and brought along w/ the other new SSTable
> components)
> b.) an option that allows us to bypass full checksum validation on
> imported/already-built SSTable-attached indexes (assuming they have just been
> written by {{CQLSSTableWriter}})
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18688) Limit Java runtime in 5.1 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18688: Description: Currently, we limit our users from building with non-default Java versions in build.xml. They can easily hack build.xml for test purposes with different versions. Cassandra–5.1 will be run on JDK11 and JDK17, but on startup, we do not limit people to those two, but only to everything >= 11. We should also put an upper limit of 17 in our Cassandra startup scripts. We can also add a flag to opt-out if someone wants to test with newer versions. was: Currently, we limit our users from building with non-default Java versions in build.xml. They can easily hack build.xml for test purposes with different versions. Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit people to those two, but only to everything >= 11. We should also put an upper limit of 17 in our Cassandra startup scripts. We can also add a flag to opt-out if someone wants to test with newer versions. > Limit Java runtime in 5.1 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.1 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.1 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18688) Limit Java runtime in 5.1 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18688: Test and Documentation Plan: Cassandra startup was tested with JDK 8,11, 12, 17 & 19 with and without the new environment variable being set (was: Cassandra startup was tested with JDK 8,11, 12, 17 & 19 with and without the -J option) > Limit Java runtime in 5.1 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.1 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18688) Limit Java runtime in 5.1 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18688: Test and Documentation Plan: Cassandra startup was tested with JDK 11, 17 & 21 with and without the new environment variable being set (was: Cassandra startup was tested with JDK 8,11, 12, 17 & 19 with and without the new environment variable being set) > Limit Java runtime in 5.1 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.1 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18688) Limit Java runtime in 5.1 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18688: Summary: Limit Java runtime in 5.1 to JDK 11 and 17 in scripts; add a flag to opt out of that (was: Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that) > Limit Java runtime in 5.1 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.1 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18688: Source Control Link: [43eb2a4bde..89e33a16ea | https://github.com/apache/cassandra/commit/89e33a16eae20f6956127c78466b6626f41449c2] Resolution: Fixed Status: Resolved (was: Ready to Commit) > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.1 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808673#comment-17808673 ] Ekaterina Dimitrova commented on CASSANDRA-18688: - Great! Thanks! Committed to trunk - [43eb2a4bde..89e33a16ea | https://github.com/apache/cassandra/commit/89e33a16eae20f6956127c78466b6626f41449c2] The nit was also addressed - https://github.com/apache/cassandra/commit/89e33a16eae20f6956127c78466b6626f41449c2#diff-75eb2b40d9ea80eebc076f57757ecb7aebddb89308db1cf714d9d5156084a9adR51 > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.1 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch trunk updated: Limit cassandra startup to supported JDKs
This is an automated email from the ASF dual-hosted git repository.
edimitrova pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 89e33a16ea Limit cassandra startup to supported JDKs
89e33a16ea is described below
commit 89e33a16eae20f6956127c78466b6626f41449c2
Author: shyla226
AuthorDate: Wed Aug 9 14:45:01 2023 -0700
Limit cassandra startup to supported JDKs
Set CASSANDRA_JDK_UNSUPPORTED to use a newer JDK
patch by Shylaja Kokoori; reviewed by Berenguer Blasi, Ekaterina Dimitrova,
Michael Semb Wever and Stefan Miklosovic for CASSANDRA-18688
---
CHANGES.txt | 1 +
bin/cassandra.in.sh | 27
debian/patches/cassandra_in.sh_dirs.diff | 54 +++-
redhat/cassandra.in.sh | 25 ---
tools/bin/cassandra.in.sh| 29 +
5 files changed, 118 insertions(+), 18 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 152f63056f..d1ed33baee 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
5.1
+ * Limit cassandra startup to supported JDKs, allow higher JDKs by setting
CASSANDRA_JDK_UNSUPPORTED (CASSANDRA-18688)
* Standardize nodetool tablestats formatting of data units (CASSANDRA-19104)
* Make nodetool tablestats use number of significant digits for time and
average values consistently (CASSANDRA-19015)
* Upgrade jackson to 2.15.3 and snakeyaml to 2.1 (CASSANDRA-18875)
diff --git a/bin/cassandra.in.sh b/bin/cassandra.in.sh
index dfa17643fd..6b347da7a8 100644
--- a/bin/cassandra.in.sh
+++ b/bin/cassandra.in.sh
@@ -48,7 +48,7 @@ fi
cassandra_storagedir="$CASSANDRA_HOME/data"
# JAVA_HOME can optionally be set here
-#JAVA_HOME=/usr/local/jdk6
+# JAVA_HOME=/usr/local/jdk11
for jar in "$CASSANDRA_HOME"/lib/*.jar; do
CLASSPATH="$CLASSPATH:$jar"
@@ -116,19 +116,34 @@ if [ -z $JAVA ] ; then
exit 1;
fi
+# Matches variable 'java.supported' in build.xml
+java_versions_supported=11,17
+
# Determine the sort of JVM we'll be running on.
java_ver_output=`"${JAVA:-java}" -version 2>&1`
jvmver=`echo "$java_ver_output" | grep '[openjdk|java] version' | awk -F'"'
'NR==1 {print $2}' | cut -d\- -f1`
JVM_VERSION=${jvmver%_*}
short=$(echo "${jvmver}" | cut -c1-2)
-JAVA_VERSION=17
-if [ "$short" = "11" ] ; then
- JAVA_VERSION=11
-elif [ "$JVM_VERSION" \< "17" ] ; then
-echo "Cassandra 5.0 requires Java 11 or Java 17."
+# Unsupported JDKs below the upper supported version are not allowed
+if [ "$short" != "$(echo "$java_versions_supported" | cut -d, -f1)" ] && [
"$JVM_VERSION" \< "$(echo "$java_versions_supported" | cut -d, -f2)" ] ; then
+echo "Unsupported Java $JVM_VERSION. Supported are
$java_versions_supported"
exit 1;
fi
+# Allow execution of supported Java versions, and newer if
CASSANDRA_JDK_UNSUPPORTED is set
+is_supported_version=$(echo "$java_versions_supported" | tr "," '\n' | grep -F
-x "$short")
+if [ -z "$is_supported_version" ] ; then
+if [ -z "$CASSANDRA_JDK_UNSUPPORTED" ] ; then
+echo "Unsupported Java $JVM_VERSION. Supported are
$java_versions_supported"
+echo "If you would like to test with newer Java versions set
CASSANDRA_JDK_UNSUPPORTED to any value (for example,
CASSANDRA_JDK_UNSUPPORTED=true). Unset the parameter for default behavior"
+exit 1;
+else
+echo
"##"
+echo "Warning! You are using JDK$short. This Cassandra version only
supports $java_versions_supported."
+echo
"##"
+fi
+fi
+JAVA_VERSION=$short
jvm=`echo "$java_ver_output" | grep -A 1 '[openjdk|java] version' | awk 'NR==2
{print $1}'`
case "$jvm" in
diff --git a/debian/patches/cassandra_in.sh_dirs.diff
b/debian/patches/cassandra_in.sh_dirs.diff
index 6642165beb..2926966c42 100644
--- a/debian/patches/cassandra_in.sh_dirs.diff
+++ b/debian/patches/cassandra_in.sh_dirs.diff
@@ -33,7 +33,7 @@
+cassandra_storagedir=/var/lib/cassandra
# JAVA_HOME can optionally be set here
- #JAVA_HOME=/usr/local/jdk6
+ #JAVA_HOME=/usr/local/jdk11
@@ -47,6 +47,10 @@ for jar in "$CASSANDRA_HOME"/lib/*.jar; do
CLASSPATH="$CLASSPATH:$jar"
done
@@ -45,3 +45,55 @@
CLASSPATH="$CLASSPATH:$EXTRA_CLASSPATH"
# JSR223 - collect all JSR223 engines' jars
+ #
+ # Java executable and per-Java version JVM settings
+ #
+
+ # Use JAVA_HOME if set, otherwise look for java in PATH
+ if [ -n "$JAVA_HOME" ]; then
+ # Why we can't have nice things: Solaris combines x86 and x86_64
+ # installations in the same tree, using an unconventional path for the
+ # 64bit JVM. Since we prefer 64bit, search the alternate path first,
+ # (see https://issues.apache.org/jira/browse/CASSANDRA-4638).
+ for
[jira] [Updated] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18688: Status: Ready to Commit (was: Review In Progress) > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.x > > Time Spent: 3.5h > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18688: Fix Version/s: 5.1 (was: 5.x) > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.1 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808657#comment-17808657
]
Brandon Williams commented on CASSANDRA-19097:
--
Reopened to make sure we don't forget.
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.12, 4.1.4, 5.0-beta2, 5.0, 5.1
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-19097:
-
Resolution: (was: Fixed)
Status: Open (was: Resolved)
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.12, 4.1.4, 5.0-beta2, 5.0, 5.1
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19276) Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
[
https://issues.apache.org/jira/browse/CASSANDRA-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808650#comment-17808650
]
Stefan Miklosovic commented on CASSANDRA-19276:
---
[~andrew.tolbert] I think you need RightCurly for this, just search for string
like
{noformat}
public void testSingleLine() { bar(); } // OK, because singleline is allowed
{noformat}
https://checkstyle.org/checks/blocks/rightcurly.html
> Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
> ---
>
> Key: CASSANDRA-19276
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19276
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
> Attachments: checkstyle_lcurly_output.zip
>
>
> It came up in a review that I had missed some style changes in
> [CASSANDRA-18857]
> (https://github.com/apache/cassandra/pull/2969#pullrequestreview-1810999533).
> Chatting with [~smiklosovic] we agreed that it would be nice if we could
> enforce this in checkstyle, so we wouldn't need to be dependent on this being
> caught in review.
> The change for this is effectively:
> {code}
> index 8b81f21281..9bd22dc1ac 100644
> --- a/.build/checkstyle.xml
> +++ b/.build/checkstyle.xml
> @@ -179,6 +179,10 @@
> value="'Deprecated annotation must provide 'since' value."/>
>
> +
> +
> + value="ANNOTATION_DEF,CLASS_DEF,CTOR_DEF,ENUM_CONSTANT_DEF,INTERFACE_DEF,LITERAL_CASE,LITERAL_CATCH,LITERAL_DEFAULT,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_SWITCH,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,METHOD_DEF,OBJBLOCK,STATIC_INIT,RECORD_DEF,COMPACT_CTOR_DEF"/>
> +
>
>
> {code}
> Notably, we would allow braces on the same lines for lambdas as per the
> [project
> guidelines|https://cassandra.apache.org/_/development/code_style.html] on
> code formatting:
> {quote}
> {{{}} and {{}}} are placed on a new line except when empty or opening a
> multi-line lambda expression. Braces may be elided to a depth of one if the
> condition or loop guards a single expression.
> {quote}
> There are 594 violations and 211 source files that would need to be adjusted.
> I may play with the rules a little bit more to get this right.
> I would like to propose that we change all files that are not imported from
> other projects (there are a few, such as
> src/java/org/apache/cassandra/utils/obs/BitUtil.java, which we can suppress
> changes for), but we would change others.
> I'll make a patch with the changes send a small proposal to the mailing list
> as it could be disruptive to make a bunch of tiny changes, and depending on
> timing there may be a better time to make a change like this.
> We should make this change only on trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19276) Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
[
https://issues.apache.org/jira/browse/CASSANDRA-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808649#comment-17808649
]
Stefan Miklosovic commented on CASSANDRA-19276:
---
_ Unfortunately I can't seem to find a way to allow this particular use while
also forbidding multi-line methods that have left braces in the declaration
line, but i'll keep looking._
Yeah, that is unfortunate, that pattern seems to be used quite frequently.
> Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
> ---
>
> Key: CASSANDRA-19276
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19276
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
> Attachments: checkstyle_lcurly_output.zip
>
>
> It came up in a review that I had missed some style changes in
> [CASSANDRA-18857]
> (https://github.com/apache/cassandra/pull/2969#pullrequestreview-1810999533).
> Chatting with [~smiklosovic] we agreed that it would be nice if we could
> enforce this in checkstyle, so we wouldn't need to be dependent on this being
> caught in review.
> The change for this is effectively:
> {code}
> index 8b81f21281..9bd22dc1ac 100644
> --- a/.build/checkstyle.xml
> +++ b/.build/checkstyle.xml
> @@ -179,6 +179,10 @@
> value="'Deprecated annotation must provide 'since' value."/>
>
> +
> +
> + value="ANNOTATION_DEF,CLASS_DEF,CTOR_DEF,ENUM_CONSTANT_DEF,INTERFACE_DEF,LITERAL_CASE,LITERAL_CATCH,LITERAL_DEFAULT,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_SWITCH,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,METHOD_DEF,OBJBLOCK,STATIC_INIT,RECORD_DEF,COMPACT_CTOR_DEF"/>
> +
>
>
> {code}
> Notably, we would allow braces on the same lines for lambdas as per the
> [project
> guidelines|https://cassandra.apache.org/_/development/code_style.html] on
> code formatting:
> {quote}
> {{{}} and {{}}} are placed on a new line except when empty or opening a
> multi-line lambda expression. Braces may be elided to a depth of one if the
> condition or loop guards a single expression.
> {quote}
> There are 594 violations and 211 source files that would need to be adjusted.
> I may play with the rules a little bit more to get this right.
> I would like to propose that we change all files that are not imported from
> other projects (there are a few, such as
> src/java/org/apache/cassandra/utils/obs/BitUtil.java, which we can suppress
> changes for), but we would change others.
> I'll make a patch with the changes send a small proposal to the mailing list
> as it could be disruptive to make a bunch of tiny changes, and depending on
> timing there may be a better time to make a change like this.
> We should make this change only on trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19276) Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
[
https://issues.apache.org/jira/browse/CASSANDRA-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808649#comment-17808649
]
Stefan Miklosovic edited comment on CASSANDRA-19276 at 1/19/24 1:06 PM:
_Unfortunately I can't seem to find a way to allow this particular use while
also forbidding multi-line methods that have left braces in the declaration
line, but i'll keep looking._
Yeah, that is unfortunate, that pattern seems to be used quite frequently.
was (Author: smiklosovic):
_ Unfortunately I can't seem to find a way to allow this particular use while
also forbidding multi-line methods that have left braces in the declaration
line, but i'll keep looking._
Yeah, that is unfortunate, that pattern seems to be used quite frequently.
> Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
> ---
>
> Key: CASSANDRA-19276
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19276
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
> Attachments: checkstyle_lcurly_output.zip
>
>
> It came up in a review that I had missed some style changes in
> [CASSANDRA-18857]
> (https://github.com/apache/cassandra/pull/2969#pullrequestreview-1810999533).
> Chatting with [~smiklosovic] we agreed that it would be nice if we could
> enforce this in checkstyle, so we wouldn't need to be dependent on this being
> caught in review.
> The change for this is effectively:
> {code}
> index 8b81f21281..9bd22dc1ac 100644
> --- a/.build/checkstyle.xml
> +++ b/.build/checkstyle.xml
> @@ -179,6 +179,10 @@
> value="'Deprecated annotation must provide 'since' value."/>
>
> +
> +
> + value="ANNOTATION_DEF,CLASS_DEF,CTOR_DEF,ENUM_CONSTANT_DEF,INTERFACE_DEF,LITERAL_CASE,LITERAL_CATCH,LITERAL_DEFAULT,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_SWITCH,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,METHOD_DEF,OBJBLOCK,STATIC_INIT,RECORD_DEF,COMPACT_CTOR_DEF"/>
> +
>
>
> {code}
> Notably, we would allow braces on the same lines for lambdas as per the
> [project
> guidelines|https://cassandra.apache.org/_/development/code_style.html] on
> code formatting:
> {quote}
> {{{}} and {{}}} are placed on a new line except when empty or opening a
> multi-line lambda expression. Braces may be elided to a depth of one if the
> condition or loop guards a single expression.
> {quote}
> There are 594 violations and 211 source files that would need to be adjusted.
> I may play with the rules a little bit more to get this right.
> I would like to propose that we change all files that are not imported from
> other projects (there are a few, such as
> src/java/org/apache/cassandra/utils/obs/BitUtil.java, which we can suppress
> changes for), but we would change others.
> I'll make a patch with the changes send a small proposal to the mailing list
> as it could be disruptive to make a bunch of tiny changes, and depending on
> timing there may be a better time to make a change like this.
> We should make this change only on trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18714) Expand CQLSSTableWriter to write SSTable-attached secondary indexes
[
https://issues.apache.org/jira/browse/CASSANDRA-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808646#comment-17808646
]
Stefan Miklosovic commented on CASSANDRA-18714:
---
PR for trunk [~maedhroz] https://github.com/apache/cassandra/pull/3049
> Expand CQLSSTableWriter to write SSTable-attached secondary indexes
> ---
>
> Key: CASSANDRA-18714
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18714
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SAI, Tool/bulk load
>Reporter: Caleb Rackliffe
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
> Attachments: client-mode-cqlsstablewriter-tests.patch
>
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
> {{CQLSSTableWriter}} currently has no way of writing any secondary indexes
> inline as it writes the core SSTable components. With SAI, this has become
> tractable problem, and we should be able to enhance both it and
> {{SSTableImporter}} to handle cases where we might want to write SSTables
> somewhere in bulk (and in parallel) and then import them without waiting for
> index building on import. It would require the following changes:
> 1.) {{CQLSSTableWriter}} must accept 2i definitions on top of its current
> table schema definition. Once added to the schema, any {{ColumnFamilyStore}}
> instances opened will have those 2i defined in their index managers.
> 2.) All {{AbstractSSTableSimpleWriter}} instances must register index groups,
> allowing the proper {{SSTableFlushObservers}} to be attached to
> {{SSTableWriter}}. Once this is done, SAI (and any other SSTable-attached
> indexes) components will be built incrementally along w/ the SSTable data
> file, and will be finalized when the newly written SSTable is finalized.
> 3.) Provide an example (in a unit test?) of how a third-party tool might,
> assuming access to the right C* JAR, validate/checksum SAI components outside
> C* proper.
> 4.) {{SSTableImporter}} should have two new options:
> a.) an option that fails import if any SSTable-attached 2i must be built
> (i.e. has not already been built and brought along w/ the other new SSTable
> components)
> b.) an option that allows us to bypass full checksum validation on
> imported/already-built SSTable-attached indexes (assuming they have just been
> written by {{CQLSSTableWriter}})
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808633#comment-17808633
]
Berenguer Blasi commented on CASSANDRA-19097:
-
^Yeah as I am reviewing things and as jenkins runs some more SHAs, this coming
up often as it does, it should give us some idea of the impact of reading at
ALL...
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.12, 4.1.4, 5.0-beta2, 5.0, 5.1
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19265) Mutation.PartitionUpdateCollector#add asserts Partitioner pointers are equal but this may fail during CommitLogReplay for LocalPartitioner
[
https://issues.apache.org/jira/browse/CASSANDRA-19265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-19265:
--
Fix Version/s: 5.1
(was: 5.x)
Since Version: 5.1-alpha1
Source Control Link:
https://github.com/apache/cassandra/commit/91e8a22d63683e46d26c7d9a25df3b3d80eba500
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Mutation.PartitionUpdateCollector#add asserts Partitioner pointers are equal
> but this may fail during CommitLogReplay for LocalPartitioner
> --
>
> Key: CASSANDRA-19265
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19265
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: David Capwell
>Assignee: Aleksey Yeschenko
>Priority: Normal
> Fix For: 5.1
>
>
> This was found on the cep-15-accord branch. We have a system table
> all_commands_for_key and it seems that the LocalPartitioner pointer gets
> changed, causing CommitLogReplyer to fail
> {code}
> java.lang.AssertionError: Update to key
> DecoratedKey(11:01c93b4893674349ae:2b74bbca-eae8-3217-a675-115cf5642ef3\:3030312e302e393134,
>
> 0004000b0901c93b4893674349ae2100102b74bbcaeae83217a675115cf5642ef300093030312e302e39313400)
> with partitioner org.apache.cassandra.dht.LocalPartitioner@1fc4de9e (class
> org.apache.cassandra.dht.LocalPartitioner) had an update
> ([system_accord.all_commands_for_key]...) with a different partitioner!
> org.apache.cassandra.dht.LocalPartitioner@c7d8be7 (class
> org.apache.cassandra.dht.LocalPartitioner)
> at org.apache.cassandra.utils.Throwables.unchecked(Throwables.java:308)
> at org.apache.cassandra.utils.Throwables.cleaned(Throwables.java:327)
> at
> org.apache.cassandra.utils.FBUtilities.waitOnFuture(FBUtilities.java:544)
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleMutation(CommitLogReplayer.java:521)
> at
> org.apache.cassandra.db.commitlog.CommitLogReader.readMutation(CommitLogReader.java:478)
> at
> org.apache.cassandra.db.commitlog.CommitLogReader.readSection(CommitLogReader.java:397)
> at
> org.apache.cassandra.db.commitlog.CommitLogReader.readCommitLogSegment(CommitLogReader.java:244)
> at
> org.apache.cassandra.db.commitlog.CommitLogReader.readCommitLogSegment(CommitLogReader.java:147)
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayFiles(CommitLogReplayer.java:195)
> at
> org.apache.cassandra.db.commitlog.CommitLog.recoverFiles(CommitLog.java:225)
> at
> org.apache.cassandra.db.commitlog.CommitLog.recoverSegmentsOnDisk(CommitLog.java:206)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:332)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:726)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:876)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19265) Mutation.PartitionUpdateCollector#add asserts Partitioner pointers are equal but this may fail during CommitLogReplay for LocalPartitioner
[
https://issues.apache.org/jira/browse/CASSANDRA-19265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-19265:
--
Reviewers: Marcus Eriksson (was: Aleksey Yeschenko, Marcus Eriksson)
> Mutation.PartitionUpdateCollector#add asserts Partitioner pointers are equal
> but this may fail during CommitLogReplay for LocalPartitioner
> --
>
> Key: CASSANDRA-19265
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19265
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: David Capwell
>Assignee: Aleksey Yeschenko
>Priority: Normal
> Fix For: 5.1
>
>
> This was found on the cep-15-accord branch. We have a system table
> all_commands_for_key and it seems that the LocalPartitioner pointer gets
> changed, causing CommitLogReplyer to fail
> {code}
> java.lang.AssertionError: Update to key
> DecoratedKey(11:01c93b4893674349ae:2b74bbca-eae8-3217-a675-115cf5642ef3\:3030312e302e393134,
>
> 0004000b0901c93b4893674349ae2100102b74bbcaeae83217a675115cf5642ef300093030312e302e39313400)
> with partitioner org.apache.cassandra.dht.LocalPartitioner@1fc4de9e (class
> org.apache.cassandra.dht.LocalPartitioner) had an update
> ([system_accord.all_commands_for_key]...) with a different partitioner!
> org.apache.cassandra.dht.LocalPartitioner@c7d8be7 (class
> org.apache.cassandra.dht.LocalPartitioner)
> at org.apache.cassandra.utils.Throwables.unchecked(Throwables.java:308)
> at org.apache.cassandra.utils.Throwables.cleaned(Throwables.java:327)
> at
> org.apache.cassandra.utils.FBUtilities.waitOnFuture(FBUtilities.java:544)
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleMutation(CommitLogReplayer.java:521)
> at
> org.apache.cassandra.db.commitlog.CommitLogReader.readMutation(CommitLogReader.java:478)
> at
> org.apache.cassandra.db.commitlog.CommitLogReader.readSection(CommitLogReader.java:397)
> at
> org.apache.cassandra.db.commitlog.CommitLogReader.readCommitLogSegment(CommitLogReader.java:244)
> at
> org.apache.cassandra.db.commitlog.CommitLogReader.readCommitLogSegment(CommitLogReader.java:147)
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayFiles(CommitLogReplayer.java:195)
> at
> org.apache.cassandra.db.commitlog.CommitLog.recoverFiles(CommitLog.java:225)
> at
> org.apache.cassandra.db.commitlog.CommitLog.recoverSegmentsOnDisk(CommitLog.java:206)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:332)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:726)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:876)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19265) Mutation.PartitionUpdateCollector#add asserts Partitioner pointers are equal but this may fail during CommitLogReplay for LocalPartitioner
[
https://issues.apache.org/jira/browse/CASSANDRA-19265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-19265:
--
Reviewers: Marcus Eriksson, Aleksey Yeschenko (was: Marcus Eriksson)
Marcus Eriksson, Aleksey Yeschenko (was: Aleksey Yeschenko,
Marcus Eriksson)
Status: Review In Progress (was: Patch Available)
> Mutation.PartitionUpdateCollector#add asserts Partitioner pointers are equal
> but this may fail during CommitLogReplay for LocalPartitioner
> --
>
> Key: CASSANDRA-19265
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19265
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: David Capwell
>Assignee: Aleksey Yeschenko
>Priority: Normal
> Fix For: 5.x
>
>
> This was found on the cep-15-accord branch. We have a system table
> all_commands_for_key and it seems that the LocalPartitioner pointer gets
> changed, causing CommitLogReplyer to fail
> {code}
> java.lang.AssertionError: Update to key
> DecoratedKey(11:01c93b4893674349ae:2b74bbca-eae8-3217-a675-115cf5642ef3\:3030312e302e393134,
>
> 0004000b0901c93b4893674349ae2100102b74bbcaeae83217a675115cf5642ef300093030312e302e39313400)
> with partitioner org.apache.cassandra.dht.LocalPartitioner@1fc4de9e (class
> org.apache.cassandra.dht.LocalPartitioner) had an update
> ([system_accord.all_commands_for_key]...) with a different partitioner!
> org.apache.cassandra.dht.LocalPartitioner@c7d8be7 (class
> org.apache.cassandra.dht.LocalPartitioner)
> at org.apache.cassandra.utils.Throwables.unchecked(Throwables.java:308)
> at org.apache.cassandra.utils.Throwables.cleaned(Throwables.java:327)
> at
> org.apache.cassandra.utils.FBUtilities.waitOnFuture(FBUtilities.java:544)
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleMutation(CommitLogReplayer.java:521)
> at
> org.apache.cassandra.db.commitlog.CommitLogReader.readMutation(CommitLogReader.java:478)
> at
> org.apache.cassandra.db.commitlog.CommitLogReader.readSection(CommitLogReader.java:397)
> at
> org.apache.cassandra.db.commitlog.CommitLogReader.readCommitLogSegment(CommitLogReader.java:244)
> at
> org.apache.cassandra.db.commitlog.CommitLogReader.readCommitLogSegment(CommitLogReader.java:147)
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayFiles(CommitLogReplayer.java:195)
> at
> org.apache.cassandra.db.commitlog.CommitLog.recoverFiles(CommitLog.java:225)
> at
> org.apache.cassandra.db.commitlog.CommitLog.recoverSegmentsOnDisk(CommitLog.java:206)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:332)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:726)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:876)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch cep-15-accord updated (a609154245 -> 91e8a22d63)
This is an automated email from the ASF dual-hosted git repository. aleksey pushed a change to branch cep-15-accord in repository https://gitbox.apache.org/repos/asf/cassandra.git from a609154245 fix fast path test epoch wait add 91e8a22d63 Fix LocalPartitioner duplication in *_for_key Accord system tables No new revisions were added by this update. Summary of changes: src/java/org/apache/cassandra/service/accord/AccordKeyspace.java | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808619#comment-17808619
]
Brandon Williams commented on CASSANDRA-19097:
--
bq. But if circle times are correct this shows a failure even after reading at
ALL.
If that is true the corruption runs deeper than just bootstrap, it affects the
whole cluster if ALL doesn't help. Let's stick with your plan of waiting until
Tuesday and see if this persists or anything else shakes out.
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.12, 4.1.4, 5.0-beta2, 5.0, 5.1
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19245) Upgrade Python driver to 3.29.0
[
https://issues.apache.org/jira/browse/CASSANDRA-19245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-19245:
--
Status: Ready to Commit (was: Review In Progress)
> Upgrade Python driver to 3.29.0
> ---
>
> Key: CASSANDRA-19245
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19245
> Project: Cassandra
> Issue Type: Task
> Components: Feature/Vector Search, Tool/cqlsh
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The version of the Python driver that is used by cqlsh (3.28.0) doesn't
> correctly support vectors of variable-width types. Wrong deserialization can
> either fail with an exception or silently provide wrong results. For example:
> {code:java}
> cqlsh:k> CREATE TABLE t (k int PRIMARY KEY, v vector);
> cqlsh:k> INSERT INTO t(k, v) VALUES (1,
> [23452352356235654634567437463767365783768, 3]);
> cqlsh:k> SELECT * FROM t;
> k | v
> ---+--
> 1 | [289729430, -1001073214]}}
> {code}
> The most recent driver at the moment (3.29.0) still doesn't support this kind
> of vector, but it always fails with a proper message instead of dangerously
> providing wrong results, thanks to
> [PYTHON-1371|https://datastax-oss.atlassian.net/browse/PYTHON-1371].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19245) Upgrade Python driver to 3.29.0
[
https://issues.apache.org/jira/browse/CASSANDRA-19245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-19245:
--
Reviewers: Berenguer Blasi
> Upgrade Python driver to 3.29.0
> ---
>
> Key: CASSANDRA-19245
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19245
> Project: Cassandra
> Issue Type: Task
> Components: Feature/Vector Search, Tool/cqlsh
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The version of the Python driver that is used by cqlsh (3.28.0) doesn't
> correctly support vectors of variable-width types. Wrong deserialization can
> either fail with an exception or silently provide wrong results. For example:
> {code:java}
> cqlsh:k> CREATE TABLE t (k int PRIMARY KEY, v vector);
> cqlsh:k> INSERT INTO t(k, v) VALUES (1,
> [23452352356235654634567437463767365783768, 3]);
> cqlsh:k> SELECT * FROM t;
> k | v
> ---+--
> 1 | [289729430, -1001073214]}}
> {code}
> The most recent driver at the moment (3.29.0) still doesn't support this kind
> of vector, but it always fails with a proper message instead of dangerously
> providing wrong results, thanks to
> [PYTHON-1371|https://datastax-oss.atlassian.net/browse/PYTHON-1371].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19245) Upgrade Python driver to 3.29.0
[
https://issues.apache.org/jira/browse/CASSANDRA-19245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-19245:
--
Status: Review In Progress (was: Patch Available)
> Upgrade Python driver to 3.29.0
> ---
>
> Key: CASSANDRA-19245
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19245
> Project: Cassandra
> Issue Type: Task
> Components: Feature/Vector Search, Tool/cqlsh
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The version of the Python driver that is used by cqlsh (3.28.0) doesn't
> correctly support vectors of variable-width types. Wrong deserialization can
> either fail with an exception or silently provide wrong results. For example:
> {code:java}
> cqlsh:k> CREATE TABLE t (k int PRIMARY KEY, v vector);
> cqlsh:k> INSERT INTO t(k, v) VALUES (1,
> [23452352356235654634567437463767365783768, 3]);
> cqlsh:k> SELECT * FROM t;
> k | v
> ---+--
> 1 | [289729430, -1001073214]}}
> {code}
> The most recent driver at the moment (3.29.0) still doesn't support this kind
> of vector, but it always fails with a proper message instead of dangerously
> providing wrong results, thanks to
> [PYTHON-1371|https://datastax-oss.atlassian.net/browse/PYTHON-1371].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19278) AND queries involving both static and regular columns can hide matches from Memtable-attached indexes
[
https://issues.apache.org/jira/browse/CASSANDRA-19278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-19278:
Test and Documentation Plan: new randomized tests (or rather enhancements
to an existing one)
Status: Patch Available (was: In Progress)
5.0 [patch|https://github.com/apache/cassandra/pull/3054] [CI|TODO]
> AND queries involving both static and regular columns can hide matches from
> Memtable-attached indexes
> -
>
> Key: CASSANDRA-19278
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19278
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/SAI
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As part of our ongoing work on CASSANDRA-18275, Harry started surfacing
> errors shortly after we added static columns to the schema of
> {{SingleNodeSAITest}}. After a bit of debugging, I was able to come up with
> the following concrete repro:
> {noformat}
> import org.junit.Test;
> import org.apache.cassandra.cql3.UntypedResultSet;
> import org.apache.cassandra.index.sai.utils.SAIRandomizedTester;
> public class InMemoryIntersectionsTest extends SAIRandomizedTester
> {
> @Test
> public void staticAndRegularIntersection()
> {
> createTable("CREATE TABLE %s (pk int, ck int, v1 int, s1 int static,
> PRIMARY KEY(pk, ck))");
> createIndex("CREATE INDEX ON %s(v1) USING 'sai'");
> createIndex("CREATE INDEX ON %s(s1) USING 'sai'");
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 1, 0);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 2, 1);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 3, 2);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 4, 3);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 5, 4);
> execute("INSERT INTO %s (pk, ck, v1) VALUES (?, ?, ?)", 0, 6, 5);
> execute("INSERT INTO %s (pk, s1) VALUES (?, ?)", 0, 100);
> // Flushing here passes test
> UntypedResultSet result1 = execute("SELECT * FROM %s WHERE pk = ? AND
> v1 > ?", 0, 2);
> assertRowCount(result1, 3);
> UntypedResultSet result2 = execute("SELECT * FROM %s WHERE pk = ? AND
> v1 > ? AND s1 = ?", 0, 2, 100);
> assertRowCount(result2, 3); // Only returns one result!
> }
> }
> {noformat}
> Flushing memtables immediately before the queries passes the test, but it
> seems we have an issue with how the {{PrimaryKey}} iterators produced by
> static and regular column indexes are intersected when the iterators come
> from Memtable-attached indexes. Once the root cause of this is determined, it
> might make some sense to enhance {{RandomIntersectionTest}} to cover this
> interaction as well, just in case it turns up further problems.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18851) Test failure: junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASMultiDCTest.testLocalSerialLocalCommit
[
https://issues.apache.org/jira/browse/CASSANDRA-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808577#comment-17808577
]
Berenguer Blasi commented on CASSANDRA-18851:
-
Seen here
https://app.circleci.com/pipelines/github/adelapena/cassandra/3391/workflows/454ab0c8-5dd5-4fe8-8d7f-72a695ecd309/jobs/99383/tests
> Test failure:
> junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASMultiDCTest.testLocalSerialLocalCommit
> ---
>
> Key: CASSANDRA-18851
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18851
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> See CASSANDRA-18707 Where this test is
> [proven|https://issues.apache.org/jira/browse/CASSANDRA-18707?focusedCommentId=17761803=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17761803]
> flaky
> failure in testLocalSerialLocalCommit:
> {noformat}
> junit.framework.AssertionFailedError: numWritten: 2 < 3
> at
> org.apache.cassandra.distributed.test.CASMultiDCTest.testLocalSerialCommit(CASMultiDCTest.java:111)
> at
> org.apache.cassandra.distributed.test.CASMultiDCTest.testLocalSerialLocalCommit(CASMultiDCTest.java:121)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808574#comment-17808574
]
Berenguer Blasi edited comment on CASSANDRA-19097 at 1/19/24 9:35 AM:
--
I couldn't find the exact dtest SHA [this
run|https://app.circleci.com/pipelines/github/adelapena/cassandra/3390/workflows/650688a9-0522-4794-be19-5365fefe3e68/jobs/99409/tests]
used. But if circle times are correct this shows a failure even after reading
at ALL. So it seems we need to revert this and that we have some bootstrap
legit problem.
was (Author: bereng):
I couldn't find the exact dtest SHA [this
run|https://app.circleci.com/pipelines/github/adelapena/cassandra/3390/workflows/650688a9-0522-4794-be19-5365fefe3e68/jobs/99409/tests]
used. But if circle times are correct this show a failure even after reading
at ALL. So it seems we need to revert this and that we have some bootstrap
legit problem.
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.12, 4.1.4, 5.0-beta2, 5.0, 5.1
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808574#comment-17808574
]
Berenguer Blasi commented on CASSANDRA-19097:
-
I couldn't find the exact dtest SHA [this
run|https://app.circleci.com/pipelines/github/adelapena/cassandra/3390/workflows/650688a9-0522-4794-be19-5365fefe3e68/jobs/99409/tests]
used. But if circle times are correct this show a failure even after reading
at ALL. So it seems we need to revert this and that we have some bootstrap
legit problem.
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.12, 4.1.4, 5.0-beta2, 5.0, 5.1
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
