[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[
https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830095#comment-15830095
]
Aleksey Yeschenko commented on CASSANDRA-10825:
---
One other issue is that the {{LongAdder}}, used by {{Counter}}, is not a good
fit for the task. Under normal operation it's rarely being incremented, but
being read multiple times on each request. {{AtomicLong}} here is actually
strictly better.
{{LongAdder}} is also not atomic, so the change isn't functionally equivalent
either.
That said, I'm fine with {{LoadingCache}} here. Not with {{LongAdder}}. Perhaps
putting {{AtomicLong}} s back, but opting for {{Gauge}} s on the metrics side
would be a better option?
> OverloadedException is untested
> ---
>
> Key: CASSANDRA-10825
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10825
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths
>Reporter: Ariel Weisberg
>Assignee: Edward Capriolo
> Attachments: jmx-hint.png
>
>
> If you grep test/src and cassandra-dtest you will find that the string
> OverloadedException doesn't appear anywhere.
> In CASSANDRA-10477 it was found that there were cases where Paxos should
> back-pressure and throw OverloadedException but didn't.
> If OverloadedException is used for functional purposes then we should test
> that it is thrown under expected conditions. If there are behaviors driven by
> catching or tracking OverloadedException we should test those as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[
https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815045#comment-15815045
]
Aleksey Yeschenko commented on CASSANDRA-10825:
---
Don't need you to rebase, but I have one last doubt. Should we keep these
counters in a {{LoadingCache}} in the first place? I feel like making them
permanent explicitly might be better.
> OverloadedException is untested
> ---
>
> Key: CASSANDRA-10825
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10825
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths
>Reporter: Ariel Weisberg
>Assignee: Edward Capriolo
> Attachments: jmx-hint.png
>
>
> If you grep test/src and cassandra-dtest you will find that the string
> OverloadedException doesn't appear anywhere.
> In CASSANDRA-10477 it was found that there were cases where Paxos should
> back-pressure and throw OverloadedException but didn't.
> If OverloadedException is used for functional purposes then we should test
> that it is thrown under expected conditions. If there are behaviors driven by
> catching or tracking OverloadedException we should test those as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804765#comment-15804765 ] Edward Capriolo commented on CASSANDRA-10825: - I agree.Let me know if you need me to rebase. > OverloadedException is untested > --- > > Key: CASSANDRA-10825 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10825 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Ariel Weisberg >Assignee: Edward Capriolo > Attachments: jmx-hint.png > > > If you grep test/src and cassandra-dtest you will find that the string > OverloadedException doesn't appear anywhere. > In CASSANDRA-10477 it was found that there were cases where Paxos should > back-pressure and throw OverloadedException but didn't. > If OverloadedException is used for functional purposes then we should test > that it is thrown under expected conditions. If there are behaviors driven by > catching or tracking OverloadedException we should test those as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15801294#comment-15801294 ] Aleksey Yeschenko commented on CASSANDRA-10825: --- bq. This feature never worked as intended. With this patch applied it will start doing something. My concern is a user a user could suddenly start seeing OverloadedException and without the metrics they will not have visibility into it. That's a valid concern. Maybe we should just target trunk only here, to avoid surprising anyone with new (old) behaviour? Would be indeed rude to drop it into 2.1/2.2/3.0 minor release, with or without metrics. For trunk this is fine. Maybe even 3.X. wdyt? > OverloadedException is untested > --- > > Key: CASSANDRA-10825 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10825 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Ariel Weisberg >Assignee: Edward Capriolo > Attachments: jmx-hint.png > > > If you grep test/src and cassandra-dtest you will find that the string > OverloadedException doesn't appear anywhere. > In CASSANDRA-10477 it was found that there were cases where Paxos should > back-pressure and throw OverloadedException but didn't. > If OverloadedException is used for functional purposes then we should test > that it is thrown under expected conditions. If there are behaviors driven by > catching or tracking OverloadedException we should test those as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799526#comment-15799526 ] Edward Capriolo commented on CASSANDRA-10825: - I realize that replacing AtomicLong with Counter and introducing metrics is beyond the scope of the bug fix, but there is one thing I want to point out: This feature never worked as intended. With this patch applied it will start doing something. My concealer is a user A user could suddenly start seeing OverloadedException, and without the metrics they will be unable to understand why. I do not mind breaking it out, but does that above rational change your opinion on breaking it out? > OverloadedException is untested > --- > > Key: CASSANDRA-10825 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10825 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Ariel Weisberg >Assignee: Edward Capriolo > Attachments: jmx-hint.png > > > If you grep test/src and cassandra-dtest you will find that the string > OverloadedException doesn't appear anywhere. > In CASSANDRA-10477 it was found that there were cases where Paxos should > back-pressure and throw OverloadedException but didn't. > If OverloadedException is used for functional purposes then we should test > that it is thrown under expected conditions. If there are behaviors driven by > catching or tracking OverloadedException we should test those as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[
https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796007#comment-15796007
]
Aleksey Yeschenko commented on CASSANDRA-10825:
---
Ok, this is deeply stupid and also embarrassing.
The reason it never gets updated is that {{hintsInProgress}} isn't a cache,
it's an instance of {{CacheLoader}}. Meaning calls to {{load()}} always return
the initial value. Very, very stupid. Worse, it got committed by me 3 years
ago, back when I didn't know any better. In CASSANDRA-6007.
[~appodictic] Your patch goes way beyond what needs to be fixed, nor do I think
it addresses the original concern from Ariel (the problem lies deeper). You did
however fix CASSANDRA-6007 breakage just by introducing the {{LoadingCache}}.
I'd ask you to go with the minimal change here, given that this should be in
2.1+, and get a v2 that *only* changes {{StorageProxy.hintsInProgress}} from
{{CacheLoader}} to the intended {{LoadingCache}}. Or I can extract it for you
instead.
Replacing {{AtomicLong}} with {{Counter}} and introducing new metrics is beyond
the scope of the bug fix - feel free to open a 3.X or trunk ticket for that,
separately.
> OverloadedException is untested
> ---
>
> Key: CASSANDRA-10825
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10825
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths
>Reporter: Ariel Weisberg
>Assignee: Edward Capriolo
> Attachments: jmx-hint.png
>
>
> If you grep test/src and cassandra-dtest you will find that the string
> OverloadedException doesn't appear anywhere.
> In CASSANDRA-10477 it was found that there were cases where Paxos should
> back-pressure and throw OverloadedException but didn't.
> If OverloadedException is used for functional purposes then we should test
> that it is thrown under expected conditions. If there are behaviors driven by
> catching or tracking OverloadedException we should test those as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[
https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795683#comment-15795683
]
Aleksey Yeschenko commented on CASSANDRA-10825:
---
You are calling {{load}} with a new instance of autoboxed {{Integer}} every
time, which is why the increments seem 'lost'. In reality after two increment
calls and one load call you now have 3 instanced of {{AtomicInteger}} in the
cache, two of 1 and one of 0.
> OverloadedException is untested
> ---
>
> Key: CASSANDRA-10825
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10825
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths
>Reporter: Ariel Weisberg
>Assignee: Edward Capriolo
> Attachments: jmx-hint.png
>
>
> If you grep test/src and cassandra-dtest you will find that the string
> OverloadedException doesn't appear anywhere.
> In CASSANDRA-10477 it was found that there were cases where Paxos should
> back-pressure and throw OverloadedException but didn't.
> If OverloadedException is used for functional purposes then we should test
> that it is thrown under expected conditions. If there are behaviors driven by
> catching or tracking OverloadedException we should test those as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575459#comment-15575459 ] Edward Capriolo commented on CASSANDRA-10825: - [~iamaleksey] Looping around on all my patch_available patches and being a pest. Do you need anything else from me? > OverloadedException is untested > --- > > Key: CASSANDRA-10825 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10825 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Ariel Weisberg >Assignee: Edward Capriolo > Attachments: jmx-hint.png > > > If you grep test/src and cassandra-dtest you will find that the string > OverloadedException doesn't appear anywhere. > In CASSANDRA-10477 it was found that there were cases where Paxos should > back-pressure and throw OverloadedException but didn't. > If OverloadedException is used for functional purposes then we should test > that it is thrown under expected conditions. If there are behaviors driven by > catching or tracking OverloadedException we should test those as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526848#comment-15526848 ] Edward Capriolo commented on CASSANDRA-10825: - https://github.com/apache/cassandra/compare/trunk...edwardcapriolo:CASSANDRA-10825-3.0.9?expand=1 and https://github.com/apache/cassandra/compare/trunk...edwardcapriolo:CASSANDRA-10825-2.2.6?expand=1 https://github.com/edwardcapriolo/cassandra/tree/CASSANDRA-10825 <--trunk > OverloadedException is untested > --- > > Key: CASSANDRA-10825 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10825 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Ariel Weisberg >Assignee: Edward Capriolo > Attachments: jmx-hint.png > > > If you grep test/src and cassandra-dtest you will find that the string > OverloadedException doesn't appear anywhere. > In CASSANDRA-10477 it was found that there were cases where Paxos should > back-pressure and throw OverloadedException but didn't. > If OverloadedException is used for functional purposes then we should test > that it is thrown under expected conditions. If there are behaviors driven by > catching or tracking OverloadedException we should test those as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513613#comment-15513613 ] Edward Capriolo commented on CASSANDRA-10825: - [~tjake] [~iamaleksey] Thanks for looking. Before I rebase for two branches I made some minor changes. * Switched from AtomicLong to counter * Move the structure into the StorageMetrics class * During the exception captured the stats to method variables, the way it was written there is moments of time between data collection and message printing Let me know if you like these changes. > OverloadedException is untested > --- > > Key: CASSANDRA-10825 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10825 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Ariel Weisberg >Assignee: Edward Capriolo > > If you grep test/src and cassandra-dtest you will find that the string > OverloadedException doesn't appear anywhere. > In CASSANDRA-10477 it was found that there were cases where Paxos should > back-pressure and throw OverloadedException but didn't. > If OverloadedException is used for functional purposes then we should test > that it is thrown under expected conditions. If there are behaviors driven by > catching or tracking OverloadedException we should test those as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513445#comment-15513445 ] Edward Capriolo commented on CASSANDRA-10825: - Thanks. I am going to spend a little time here. In particular I want to be sure that inc() and dec() always happen. In particular now that this code path is active if we inc() and not dec() the system could keep throwing OverloadedException. Maybe the right answer is that the counter should decay over time or the count should be the OneMinuteRate or something along those lines. > OverloadedException is untested > --- > > Key: CASSANDRA-10825 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10825 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Ariel Weisberg >Assignee: Edward Capriolo > > If you grep test/src and cassandra-dtest you will find that the string > OverloadedException doesn't appear anywhere. > In CASSANDRA-10477 it was found that there were cases where Paxos should > back-pressure and throw OverloadedException but didn't. > If OverloadedException is used for functional purposes then we should test > that it is thrown under expected conditions. If there are behaviors driven by > catching or tracking OverloadedException we should test those as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512051#comment-15512051 ] Aleksey Yeschenko commented on CASSANDRA-10825: --- Probably since forever. Hilarious. [~appodictic] check 2.2 and 3.0 please, provide patches for both, and run CI on them. Not sure if this is critical enough to go into 2.1 if affected. > OverloadedException is untested > --- > > Key: CASSANDRA-10825 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10825 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Ariel Weisberg >Assignee: Edward Capriolo > > If you grep test/src and cassandra-dtest you will find that the string > OverloadedException doesn't appear anywhere. > In CASSANDRA-10477 it was found that there were cases where Paxos should > back-pressure and throw OverloadedException but didn't. > If OverloadedException is used for functional purposes then we should test > that it is thrown under expected conditions. If there are behaviors driven by > catching or tracking OverloadedException we should test those as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511994#comment-15511994 ] T Jake Luciani commented on CASSANDRA-10825: Do you agree [~iamaleksey]? Looking at this history this has been in the code for a long time > OverloadedException is untested > --- > > Key: CASSANDRA-10825 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10825 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Ariel Weisberg >Assignee: Edward Capriolo > > If you grep test/src and cassandra-dtest you will find that the string > OverloadedException doesn't appear anywhere. > In CASSANDRA-10477 it was found that there were cases where Paxos should > back-pressure and throw OverloadedException but didn't. > If OverloadedException is used for functional purposes then we should test > that it is thrown under expected conditions. If there are behaviors driven by > catching or tracking OverloadedException we should test those as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511988#comment-15511988 ] T Jake Luciani commented on CASSANDRA-10825: Good find! Yeah looks like it's using only the cache loader and not the cache builder. So every call to get getHintsInProgressFor will always return AtomicInteger(0); > OverloadedException is untested > --- > > Key: CASSANDRA-10825 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10825 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Ariel Weisberg >Assignee: Edward Capriolo > > If you grep test/src and cassandra-dtest you will find that the string > OverloadedException doesn't appear anywhere. > In CASSANDRA-10477 it was found that there were cases where Paxos should > back-pressure and throw OverloadedException but didn't. > If OverloadedException is used for functional purposes then we should test > that it is thrown under expected conditions. If there are behaviors driven by > catching or tracking OverloadedException we should test those as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511967#comment-15511967 ] Edward Capriolo commented on CASSANDRA-10825: - https://github.com/edwardcapriolo/cassandra/tree/CASSANDRA-10825 > OverloadedException is untested > --- > > Key: CASSANDRA-10825 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10825 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Ariel Weisberg >Assignee: Edward Capriolo > > If you grep test/src and cassandra-dtest you will find that the string > OverloadedException doesn't appear anywhere. > In CASSANDRA-10477 it was found that there were cases where Paxos should > back-pressure and throw OverloadedException but didn't. > If OverloadedException is used for functional purposes then we should test > that it is thrown under expected conditions. If there are behaviors driven by > catching or tracking OverloadedException we should test those as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[
https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511827#comment-15511827
]
Edward Capriolo commented on CASSANDRA-10825:
-
Looking at this I thinkthere is a serious problem here:
In StorageProxy i see hintsInProgress to be a system that always returns 0,
unless I really do not understand the idiom. I am Working on a fix that uses a
codahale meter.
java.lang.AssertionError: expected:<2> but was:<0>
{noformat}
package org.apache.cassandra.service;
import java.net.InetAddress;
import java.net.UnknownHostException;
import java.util.concurrent.atomic.AtomicInteger;
import org.apache.cassandra.OrderedJUnit4ClassRunner;
import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.db.Keyspace;
import org.apache.cassandra.exceptions.ConfigurationException;
import org.apache.cassandra.locator.IEndpointSnitch;
import org.apache.cassandra.locator.PropertyFileSnitch;
import org.junit.Assert;
import org.junit.BeforeClass;
import org.junit.Test;
import org.junit.runner.RunWith;
import com.google.common.cache.CacheLoader;
@RunWith(OrderedJUnit4ClassRunner.class)
public class StorageProxyOverloadTests
{
@BeforeClass
public static void setUp() throws ConfigurationException
{
DatabaseDescriptor.daemonInitialization();
IEndpointSnitch snitch = new PropertyFileSnitch();
DatabaseDescriptor.setEndpointSnitch(snitch);
Keyspace.setInitialized();
}
@Test
public void abc() throws UnknownHostException{
InetAddress me = InetAddress.getLocalHost();
StorageProxy.instance.setMaxHintsInProgress(-1);
Assert.assertEquals(0, StorageProxy.getHintsInProgressFor(me).get());
StorageProxy.getHintsInProgressFor(me).incrementAndGet();
StorageProxy.getHintsInProgressFor(me).incrementAndGet();
StorageProxy.getHintsInProgressFor(me).decrementAndGet();
StorageProxy.getHintsInProgressFor(me).incrementAndGet();
Assert.assertEquals(0, StorageProxy.getHintsInProgressFor(me).get());
Assert.assertTrue(StorageProxy.shouldHint(me));
StorageProxy.checkHintOverload(me);
}
@Test
public void def() throws Exception{
CacheLoader hintsInProgress = new
CacheLoader()
{
public AtomicInteger load(Integer i)
{
return new AtomicInteger(0);
}
};
hintsInProgress.load(1).incrementAndGet();
hintsInProgress.load(1).incrementAndGet();
Assert.assertEquals(2, hintsInProgress.load(1));
}
}
{noformat}
{noformat}
public void def() throws Exception{
CacheLoader hintsInProgress = new
CacheLoader()
{
public AtomicInteger load(Integer i)
{
return new AtomicInteger(0);
}
};
hintsInProgress.load(1).incrementAndGet();
hintsInProgress.load(1).incrementAndGet();
Assert.assertEquals(2, hintsInProgress.load(1));
}
{noformat}
If someone smart is looking make sure I am not on crazy pills.
> OverloadedException is untested
> ---
>
> Key: CASSANDRA-10825
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10825
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths
>Reporter: Ariel Weisberg
>Assignee: Edward Capriolo
>
> If you grep test/src and cassandra-dtest you will find that the string
> OverloadedException doesn't appear anywhere.
> In CASSANDRA-10477 it was found that there were cases where Paxos should
> back-pressure and throw OverloadedException but didn't.
> If OverloadedException is used for functional purposes then we should test
> that it is thrown under expected conditions. If there are behaviors driven by
> catching or tracking OverloadedException we should test those as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
[ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510978#comment-15510978 ] Edward Capriolo commented on CASSANDRA-10825: - We can do something like mocking out the overload detector and assert on counter values. > OverloadedException is untested > --- > > Key: CASSANDRA-10825 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10825 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Ariel Weisberg >Assignee: Edward Capriolo > > If you grep test/src and cassandra-dtest you will find that the string > OverloadedException doesn't appear anywhere. > In CASSANDRA-10477 it was found that there were cases where Paxos should > back-pressure and throw OverloadedException but didn't. > If OverloadedException is used for functional purposes then we should test > that it is thrown under expected conditions. If there are behaviors driven by > catching or tracking OverloadedException we should test those as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
