[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[ https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419197#comment-15419197 ] Nachiket Patil commented on CASSANDRA-9507: --- Thanks [~blerer] and [~ifesdjeen] for the reviews. > range metrics are not updated for timeout and unavailable in StorageProxy > - > > Key: CASSANDRA-9507 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9507 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: sankalp kohli >Assignee: Nachiket Patil >Priority: Minor > Fix For: 2.2.8, 3.0.9, 3.9 > > Attachments: CASSANDRA-9507-2.2.diff, CASSANDRA-9507-3.0.diff, > CASSANDRA-9507-trunk.diff > > > Looking at the code, it looks like range metrics are not updated for timeouts > and unavailable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[ https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418899#comment-15418899 ] Alex Petrov commented on CASSANDRA-9507: Thanks! Once again, sorry it took longer. I've tried several different things, including bubbling exceptions from originating methods, but ended up leaving it out since they're unchecked anyways, would be impossible to force that. > range metrics are not updated for timeout and unavailable in StorageProxy > - > > Key: CASSANDRA-9507 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9507 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: sankalp kohli >Assignee: Nachiket Patil >Priority: Minor > Fix For: 2.2.8, 3.0.9, 3.9 > > Attachments: CASSANDRA-9507-2.2.diff, CASSANDRA-9507-3.0.diff, > CASSANDRA-9507-trunk.diff > > > Looking at the code, it looks like range metrics are not updated for timeouts > and unavailable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[ https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418857#comment-15418857 ] Benjamin Lerer commented on CASSANDRA-9507: --- [~nachiket_patil] Thanks for the patch. [~ifesdjeen] Thanks for taking over the review > range metrics are not updated for timeout and unavailable in StorageProxy > - > > Key: CASSANDRA-9507 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9507 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: sankalp kohli >Assignee: Nachiket Patil >Priority: Minor > Attachments: CASSANDRA-9507-2.2.diff, CASSANDRA-9507-3.0.diff, > CASSANDRA-9507-trunk.diff > > > Looking at the code, it looks like range metrics are not updated for timeouts > and unavailable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[ https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417342#comment-15417342 ] Alex Petrov commented on CASSANDRA-9507: I'm sorry it took me so long. +1 CI for reference: |[2.2|https://github.com/ifesdjeen/cassandra/tree/9507-2.2] |[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-9507-2.2-testall/] |[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-9507-2.2-dtest/] | |[3.0|https://github.com/ifesdjeen/cassandra/tree/9507-3.0] |[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-9507-3.0-testall/] |[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-9507-3.0-dtest/] | |[trunk|https://github.com/ifesdjeen/cassandra/tree/9507-trunk] |[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-9507-trunk-testall/] |[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-9507-trunk-dtest/] | > range metrics are not updated for timeout and unavailable in StorageProxy > - > > Key: CASSANDRA-9507 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9507 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: sankalp kohli >Assignee: Nachiket Patil >Priority: Minor > Attachments: CASSANDRA-9507-2.2.diff, CASSANDRA-9507-3.0.diff, > CASSANDRA-9507-trunk.diff > > > Looking at the code, it looks like range metrics are not updated for timeouts > and unavailable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[ https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408765#comment-15408765 ] Nachiket Patil commented on CASSANDRA-9507: --- I have removed 2.1 patch and attached new patches for other branches. > range metrics are not updated for timeout and unavailable in StorageProxy > - > > Key: CASSANDRA-9507 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9507 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: sankalp kohli >Assignee: Nachiket Patil >Priority: Minor > Attachments: CASSANDRA-9507-2.2.diff, CASSANDRA-9507-3.0.diff, > CASSANDRA-9507-trunk.diff > > > Looking at the code, it looks like range metrics are not updated for timeouts > and unavailable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[
https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403562#comment-15403562
]
Alex Petrov commented on CASSANDRA-9507:
Yes, I meant we should leave it out for {{2.1}}. Sorry I forgot to mention the
version number, added now.
As regards the patch, I still can see Benjamin's comments there:
* {{final}} keywords in {{catch}} blocks in [3.0
patch|https://github.com/ifesdjeen/cassandra/commit/4e6a45a0ffc11a8e0589fd4b48d9d3850ed535ab#diff-71f06c193f5b5e270cf8ac695164f43aR2066]
(btw, it merges clean to trunk) (if it was the only thing we could just fix it
on commit)
* exceptions thrown in {{StorageProxy::getRangeSlice}} are [still
there|https://github.com/ifesdjeen/cassandra/blob/4e6a45a0ffc11a8e0589fd4b48d9d3850ed535ab/src/java/org/apache/cassandra/service/StorageProxy.java#L2165].
[~blerer] has suggested to remove them since they're not thrown there. As he
mentioned, for example, the {{UnavailableException}} is thrown in
{{RangeCommandIterator#query}} (since it calls {{assureSufficientLiveNodes}}
originally and bubbled up. As far as I can say, they're thrown in a different
way/different place in {{2.2}}.
> range metrics are not updated for timeout and unavailable in StorageProxy
> -
>
> Key: CASSANDRA-9507
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9507
> Project: Cassandra
> Issue Type: Bug
> Components: Observability
>Reporter: sankalp kohli
>Assignee: Nachiket Patil
>Priority: Minor
> Attachments: CASANDRA-9507 trunk.diff, CASSANDRA-9507 v2.1.diff,
> CASSANDRA-9507 v2.2.diff, CASSANDRA-9507 v3.0.diff
>
>
> Looking at the code, it looks like range metrics are not updated for timeouts
> and unavailable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[ https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403091#comment-15403091 ] sankalp kohli commented on CASSANDRA-9507: -- This is not a critical fix so its fine to leave it out for 2.1 and 2.2...we are fine doing this in 3.0 > range metrics are not updated for timeout and unavailable in StorageProxy > - > > Key: CASSANDRA-9507 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9507 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: sankalp kohli >Assignee: Nachiket Patil >Priority: Minor > Attachments: CASANDRA-9507 trunk.diff, CASSANDRA-9507 v2.1.diff, > CASSANDRA-9507 v2.2.diff, CASSANDRA-9507 v3.0.diff > > > Looking at the code, it looks like range metrics are not updated for timeouts > and unavailable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[ https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402754#comment-15402754 ] Nachiket Patil commented on CASSANDRA-9507: --- Hi [~ifesdjeen], I had uploaded patches but didn't check if the status of the JIRA changed to Patch Available. The patches you are looking at are correct. The Latency is added in the RangeCommandIterator::close() method which is for reading complete range. Not sure we should be measuring individual read. I agree this is not a critical patch. We are not patching only 2.1 branch with non-critical fixes right? We can still get this patch in 2.2, 3.0 - trunk. > range metrics are not updated for timeout and unavailable in StorageProxy > - > > Key: CASSANDRA-9507 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9507 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: sankalp kohli >Assignee: Nachiket Patil >Priority: Minor > Attachments: CASANDRA-9507 trunk.diff, CASSANDRA-9507 v2.1.diff, > CASSANDRA-9507 v2.2.diff, CASSANDRA-9507 v3.0.diff > > > Looking at the code, it looks like range metrics are not updated for timeouts > and unavailable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[
https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401901#comment-15401901
]
Alex Petrov commented on CASSANDRA-9507:
Hi [~nachiket_patil], you mentioned that new patches attached, although
unfortunately I can still only see patches from 5 of July. I might be missing
something.
Since I could only look at those patches, I have one more comment in addition
to what Benjamin has mentioned: do we want to report time as we do with other
metircs with {{addNano}} and time diff?
As a sidenote, as far as I can say this issue does not qualify for "critical",
and according to the
[discussion|https://mail-archives.apache.org/mod_mbox/cassandra-dev/201607.mbox/%3CCALdd-zjg%2Ba73VncPkU2rw_UpFPVsw0yNwO-yBqUQfK8H8FpiKw%40mail.gmail.com%3E]
we probably should leave it out.
> range metrics are not updated for timeout and unavailable in StorageProxy
> -
>
> Key: CASSANDRA-9507
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9507
> Project: Cassandra
> Issue Type: Bug
> Components: Observability
>Reporter: sankalp kohli
>Assignee: Nachiket Patil
>Priority: Minor
> Attachments: CASANDRA-9507 trunk.diff, CASSANDRA-9507 v2.1.diff,
> CASSANDRA-9507 v2.2.diff, CASSANDRA-9507 v3.0.diff
>
>
> Looking at the code, it looks like range metrics are not updated for timeouts
> and unavailable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[ https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385004#comment-15385004 ] Nachiket Patil commented on CASSANDRA-9507: --- New patches attached with changes accommodating feedback. > range metrics are not updated for timeout and unavailable in StorageProxy > - > > Key: CASSANDRA-9507 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9507 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: sankalp kohli >Assignee: Nachiket Patil >Priority: Minor > Attachments: CASANDRA-9507 trunk.diff, CASSANDRA-9507 v2.1.diff, > CASSANDRA-9507 v2.2.diff, CASSANDRA-9507 v3.0.diff > > > Looking at the code, it looks like range metrics are not updated for timeouts > and unavailable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[
https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343937#comment-15343937
]
Benjamin Lerer commented on CASSANDRA-9507:
---
Thanks for the quick update.
It seems to me that patch for 3.x will not work.
{{RequestExecutionException}} extends {{RuntimeException}} which means that you
cannot rely anymore on the method declaration to know which
{{RequestExecutionExceptions}} are thrown.
{{StorageProxy::getRangeSlice}} do not throw those exceptions and they should
be removed from the method signature. I believe that they are thrown by the
returned {{RangeCommandIterator}} but I just looked at {{UnavailableException}}.
Otherwise, your patch for 2.2 does not handle {{ReadFailureException}} and the
{{final}} keywords in the {{catch}} blocks can be removed.
> range metrics are not updated for timeout and unavailable in StorageProxy
> -
>
> Key: CASSANDRA-9507
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9507
> Project: Cassandra
> Issue Type: Bug
> Components: Observability
>Reporter: sankalp kohli
>Assignee: Nachiket Patil
>Priority: Minor
> Attachments: CASSANDRA-9507 v2.X.diff, CASSANDRA-9507 v3.0-trunk.diff
>
>
> Looking at the code, it looks like range metrics are not updated for timeouts
> and unavailable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[ https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342618#comment-15342618 ] Nachiket Patil commented on CASSANDRA-9507: --- Thanks Benjamin for the feedback. I have attached new diffs one for v2.x and another for v 3.0 and trunk. > range metrics are not updated for timeout and unavailable in StorageProxy > - > > Key: CASSANDRA-9507 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9507 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: sankalp kohli >Assignee: Nachiket Patil >Priority: Minor > Attachments: CASSANDRA-9507 v2.X.diff, CASSANDRA-9507 v3.0-trunk.diff > > > Looking at the code, it looks like range metrics are not updated for timeouts > and unavailable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9507) range metrics are not updated for timeout and unavailable in StorageProxy
[
https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342085#comment-15342085
]
Benjamin Lerer commented on CASSANDRA-9507:
---
Thanks for the patch.
It seems that range metrics are also not updated for {{failure}}. Could you
update your patch and provide one for 3.0 and trunk (the current one does not
apply).
I guessed that the patch was for 2.2 but it would be nice if you could specify
the version next time.It simplify the review process.
> range metrics are not updated for timeout and unavailable in StorageProxy
> -
>
> Key: CASSANDRA-9507
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9507
> Project: Cassandra
> Issue Type: Bug
> Components: Observability
>Reporter: sankalp kohli
>Assignee: Nachiket Patil
>Priority: Minor
> Attachments: Cassandra-9507.diff
>
>
> Looking at the code, it looks like range metrics are not updated for timeouts
> and unavailable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
