[GitHub] blueorangutan commented on issue #2466: Rare race condition in KVM migration

[GitBox]

blueorangutan commented on issue #2466: Rare race condition in KVM migration
URL: https://github.com/apache/cloudstack/pull/2466#issuecomment-368189979
 
 
   Trillian test result (tid-2278)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 29885 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2466-t2278-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 187.97 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 176.70 | 
test_privategw_acl.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[GitBox]

rafaelweingartner commented on a change in pull request #2231: 
[CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170353521
 
 

 ##
 File path: 
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##
 @@ -2566,6 +2567,61 @@ protected DiskOfferingVO createDiskOffering(final Long 
userId, final Long domain
 isCustomized = true;
 }
 
+if (minIopsPerGb != null || maxIopsPerGb != null) {
+
+if (!isCustomized) {
+   throw new InvalidParameterValueException("Cannot set Min/Max 
IOPS/GB for a fixed size disk offering");
 
 Review comment:
   So, for fixed size disks we cannot control the IOPS?  Why cannot we 
control/limit the IOPS of fixed size disks?
   
   BTW, what do you understand as IOPS? input and output per second, meaning 
read and write speed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[GitBox]

rafaelweingartner commented on a change in pull request #2231: 
[CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170353027
 
 

 ##
 File path: engine/schema/src/main/resources/META-INF/db/schema-41100to41200.sql
 ##
 @@ -0,0 +1,70 @@
+-- IOPS per GB disk offering
+DROP PROCEDURE IF EXISTS `cloud`.`ADD_COLUMN_TO_TABLE_IDEMPOTENT`;
+
+DELIMITER //
+CREATE PROCEDURE `cloud`.`ADD_COLUMN_TO_TABLE_IDEMPOTENT`(
 
 Review comment:
   Hmm.. Then, I think it is better to coordinate with PR #2449.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] syed commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[GitBox]

syed commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding 
IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170351240
 
 

 ##
 File path: 
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##
 @@ -2566,6 +2567,61 @@ protected DiskOfferingVO createDiskOffering(final Long 
userId, final Long domain
 isCustomized = true;
 }
 
+if (minIopsPerGb != null || maxIopsPerGb != null) {
+
+if (!isCustomized) {
+   throw new InvalidParameterValueException("Cannot set Min/Max 
IOPS/GB for a fixed size disk offering");
 
 Review comment:
   You cannot have an IOPS/GB offering for a fixed sized disk. The whole Idea 
of an IOPS/GB type of offering makes sense when you have a custom offering so 
when you change the size of a disk, the IOPS also change


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] syed commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[GitBox]

syed commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding 
IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170350998
 
 

 ##
 File path: engine/schema/src/main/resources/META-INF/db/schema-41100to41200.sql
 ##
 @@ -0,0 +1,70 @@
+-- IOPS per GB disk offering
+DROP PROCEDURE IF EXISTS `cloud`.`ADD_COLUMN_TO_TABLE_IDEMPOTENT`;
+
+DELIMITER //
+CREATE PROCEDURE `cloud`.`ADD_COLUMN_TO_TABLE_IDEMPOTENT`(
 
 Review comment:
   No. This is only for this PR


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2466: Rare race condition in KVM migration

[GitBox]

blueorangutan commented on issue #2466: Rare race condition in KVM migration
URL: https://github.com/apache/cloudstack/pull/2466#issuecomment-368080820
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2466: Rare race condition in KVM migration

[GitBox]

borisstoyanov commented on issue #2466: Rare race condition in KVM migration
URL: https://github.com/apache/cloudstack/pull/2466#issuecomment-368080687
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[GitBox]

rafaelweingartner commented on a change in pull request #2231: 
[CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170311638
 
 

 ##
 File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
 ##
 @@ -916,29 +951,34 @@ public VolumeVO resizeVolume(ResizeVolumeCmd cmd) throws 
ResourceAllocationExcep
 // no parameter provided; just use the original size of the 
volume
 newSize = volume.getSize();
 }
-
+newSizeInGb = newSize >> 30;
 
 Review comment:
   Let's not use bit shift here. It makes things harder to read and understand.
   
   The code is already convoluted enough


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[GitBox]

rafaelweingartner commented on a change in pull request #2231: 
[CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170309607
 
 

 ##
 File path: engine/schema/src/main/resources/META-INF/db/schema-41100to41200.sql
 ##
 @@ -0,0 +1,70 @@
+-- IOPS per GB disk offering
+DROP PROCEDURE IF EXISTS `cloud`.`ADD_COLUMN_TO_TABLE_IDEMPOTENT`;
+
+DELIMITER //
+CREATE PROCEDURE `cloud`.`ADD_COLUMN_TO_TABLE_IDEMPOTENT`(
 
 Review comment:
   Isn't this being introduced by some other PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[GitBox]

rafaelweingartner commented on a change in pull request #2231: 
[CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170310373
 
 

 ##
 File path: 
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##
 @@ -2566,6 +2567,61 @@ protected DiskOfferingVO createDiskOffering(final Long 
userId, final Long domain
 isCustomized = true;
 }
 
+if (minIopsPerGb != null || maxIopsPerGb != null) {
+
+if (!isCustomized) {
+   throw new InvalidParameterValueException("Cannot set Min/Max 
IOPS/GB for a fixed size disk offering");
+}
+
+if ((isCustomizedIops != null && isCustomizedIops) || minIops != 
null || maxIops != null) {
+throw new InvalidParameterValueException("Cannot set Min/Max 
IOPS/GB with either " +
+"custom IOPS or fixed IOPS");
+}
+
+if (minIopsPerGb != null && maxIopsPerGb != null) {
 
 Review comment:
   Could you extract this block to a specific method? Document it, and write 
unit tests for it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[GitBox]

rafaelweingartner commented on a change in pull request #2231: 
[CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170310467
 
 

 ##
 File path: 
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##
 @@ -2566,6 +2567,61 @@ protected DiskOfferingVO createDiskOffering(final Long 
userId, final Long domain
 isCustomized = true;
 }
 
+if (minIopsPerGb != null || maxIopsPerGb != null) {
+
+if (!isCustomized) {
+   throw new InvalidParameterValueException("Cannot set Min/Max 
IOPS/GB for a fixed size disk offering");
+}
+
+if ((isCustomizedIops != null && isCustomizedIops) || minIops != 
null || maxIops != null) {
+throw new InvalidParameterValueException("Cannot set Min/Max 
IOPS/GB with either " +
+"custom IOPS or fixed IOPS");
+}
+
+if (minIopsPerGb != null && maxIopsPerGb != null) {
+if (minIopsPerGb <= 0 || maxIopsPerGb <= 0) {
+throw new InvalidParameterValueException("Min/Max IOPS/GB 
value must be greater than 0");
+}
+
+if (minIopsPerGb > maxIopsPerGb){
+throw new InvalidParameterValueException("Min IOPS/GB must 
be greater than max IOPS/GB");
+}
+}
+
+//if either one of them is set but the other is not
+if ((minIopsPerGb != null && maxIopsPerGb == null) || 
(minIopsPerGb == null && maxIopsPerGb != null)) {
+throw new InvalidParameterValueException("Both min IOPS/GB and 
max IOPS/GB must be specified");
+}
+}
+
+if (highestMinIops != null && highestMaxIops != null) {
 
 Review comment:
   This whole validation block can also be extracted to a method, documented 
and unit tested.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[GitBox]

rafaelweingartner commented on a change in pull request #2231: 
[CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170311751
 
 

 ##
 File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
 ##
 @@ -981,6 +1021,7 @@ public VolumeVO resizeVolume(ResizeVolumeCmd cmd) throws 
ResourceAllocationExcep
 newSize = newDiskOffering.getDiskSize();
 }
 
+newSizeInGb = newSize >> 30;
 
 Review comment:
   bit shift...
   
   Have you checked if there is a library to convert between these bases? If 
there is none, what about we create an utils method to execute this job?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[GitBox]

rafaelweingartner commented on a change in pull request #2231: 
[CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170312130
 
 

 ##
 File path: setup/db/db/schema-41000to41100.sql
 ##
 @@ -0,0 +1,324 @@
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements.  See the NOTICE file
 
 Review comment:
   these scripts should not be here, right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[GitBox]

rafaelweingartner commented on a change in pull request #2231: 
[CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170310191
 
 

 ##
 File path: 
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##
 @@ -2566,6 +2567,61 @@ protected DiskOfferingVO createDiskOffering(final Long 
userId, final Long domain
 isCustomized = true;
 }
 
+if (minIopsPerGb != null || maxIopsPerGb != null) {
+
+if (!isCustomized) {
+   throw new InvalidParameterValueException("Cannot set Min/Max 
IOPS/GB for a fixed size disk offering");
+}
+
+if ((isCustomizedIops != null && isCustomizedIops) || minIops != 
null || maxIops != null) {
 
 Review comment:
   Can you use BooleanUtils here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[GitBox]

rafaelweingartner commented on a change in pull request #2231: 
[CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170310089
 
 

 ##
 File path: 
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##
 @@ -2566,6 +2567,61 @@ protected DiskOfferingVO createDiskOffering(final Long 
userId, final Long domain
 isCustomized = true;
 }
 
+if (minIopsPerGb != null || maxIopsPerGb != null) {
+
+if (!isCustomized) {
+   throw new InvalidParameterValueException("Cannot set Min/Max 
IOPS/GB for a fixed size disk offering");
 
 Review comment:
   I did not understand this error here. Can you explain it a little further?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] syed commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[GitBox]

syed commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#issuecomment-368067578
 
 
   @rafaelweingartner I've resolved the conflicts. I'd really like to get this 
in because I think this is the 3rd time rebasing it. If you could do a code 
review, that would be sublime :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as 
HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-368054650
 
 
   @syed are you sure? I don't think with only systemvm.iso, 
`cloud-early-config` will be updated with new code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR 
to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-368052724
 
 
   That is what I would expect. If you take a look at the millstone for the 
next release of 4.11, you can see that it is 4.11.1.
   
   @syed, so the scripts all come from systemvm.iso. That is great, then we do 
not need to built a new one and deal with all of the bureaucracy that it would 
require.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] syed commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

syed commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM 
on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-368051868
 
 
   @khos2ow @rafaelweingartner Given the changes here, I don't think we need to 
rebuild an new systemvm template. The changes will get deployed using the 
`systemvm.iso`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as 
HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-368051026
 
 
   It got changed in 6ffbce6. May be it was supposed to be `4.11.1.0-SNAPSHOT`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR 
to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-368047161
 
 
   Hmm..Then, I think there is something wrong. As far as I know, the version 
format is x.y.z.s, where x.y are used to identify the major version; .z is the 
minor, and .s is the security version bit (in case we have a security version 
for the x.y.z).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as 
HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-368046104
 
 
   Correct. The new template will be mandatory only if they are working against 
XenServer though, but we need to generate one anyway.
   BTW, the POM version is `4.11.0.1-SNAPSHOT` and not `4.11.1.0-SNAPSHOT`, if 
that needs to be fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR 
to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-368039705
 
 
   4.11 already requires a new template, right? So, people that upgraded to it 
already had to install a new one given the changes that are in 4.11. Now, we 
would need to create a new one for 4.11.1.0 , given the changes in this PR, 
right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as 
HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-368038241
 
 
   I don't think we need a template for 4.11.0.0 (because there's no java code 
and cloud-early-config to handle it) rather than only new template for 4.11.0.1.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as 
HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-368038241
 
 
   I don't think we need a template for 4.11.0.0 (because there's no java and 
cloud-early-config to handle it) rather than only new template for 4.11.0.1.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR 
to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-368036297
 
 
   I see you targeted the PR against 4.11 branch. So, a system VM for 4.11, and 
another one for 4.11.1. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as 
HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-368035606
 
 
   Yes it will require new SystemVM template.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation

[GitBox]

rafaelweingartner commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add 
package name declaration validation
URL: https://github.com/apache/cloudstack/pull/2422#issuecomment-368025458
 
 
   @marcaurele we still need one more review.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcaurele commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation

[GitBox]

marcaurele commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package 
name declaration validation
URL: https://github.com/apache/cloudstack/pull/2422#issuecomment-368022960
 
 
   @rafaelweingartner CI is green, so it should be all good to merge now since 
there is no code change in term of functionality.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2466: Rare race condition in KVM migration

[GitBox]

blueorangutan commented on issue #2466: Rare race condition in KVM migration
URL: https://github.com/apache/cloudstack/pull/2466#issuecomment-368021351
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1732


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR 
to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-368018880
 
 
   Will this one require new system VMs to be built?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: Merge pull request #2443 from rafaelweingartner/CLOUDSTACK-9338

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 06ef61b96da328baf863c2da2612f3d6089c04da
Merge: f8d98fd 601d095
Author: Rafael Weingärtner 
AuthorDate: Fri Feb 23 11:07:38 2018 -0300

Merge pull request #2443 from rafaelweingartner/CLOUDSTACK-9338

 [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom 
service offering properly

 .../cloud/configuration/dao/ResourceCountDao.java  |  14 +
 .../configuration/dao/ResourceCountDaoImpl.java|  51 +++-
 .../resourcelimit/ResourceLimitManagerImpl.java| 297 -
 .../component/test_updateResourceCount.py  | 235 
 4 files changed, 413 insertions(+), 184 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[GitHub] rafaelweingartner closed pull request #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

[GitBox]

rafaelweingartner closed pull request #2443:  [CLOUDSTACK-9338] ACS is not 
accounting resources of VMs with custom service offering properly
URL: https://github.com/apache/cloudstack/pull/2443
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDao.java 
b/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDao.java
index d4695c3ff75..b5a75d196fa 100644
--- 
a/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDao.java
+++ 
b/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDao.java
@@ -57,4 +57,18 @@
 Set listRowsToUpdateForDomain(long domainId, ResourceType type);
 
 long removeEntriesByOwner(long ownerId, ResourceOwnerType ownerType);
+
+/**
+ * Counts the number of CPU cores allocated for the given account.
+ *
+ * Side note: This method is not using the "resource_count" table. It is 
executing the actual count instead.
+ */
+long countCpuNumberAllocatedToAccount(long accountId);
+
+/**
+ * Counts the amount of memory allocated for the given account.
+ *
+ * Side note: This method is not using the "resource_count" table. It is 
executing the actual count instead.
+ */
+long countMemoryAllocatedToAccount(long accountId);
 }
diff --git 
a/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java
 
b/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java
index f7cd3cbf86f..56261337faf 100644
--- 
a/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java
+++ 
b/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java
@@ -16,6 +16,9 @@
 // under the License.
 package com.cloud.configuration.dao;
 
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.SQLException;
 import java.util.ArrayList;
 import java.util.HashSet;
 import java.util.List;
@@ -24,9 +27,6 @@
 import javax.annotation.PostConstruct;
 import javax.inject.Inject;
 
-import com.cloud.domain.DomainVO;
-import com.cloud.user.AccountVO;
-import com.cloud.utils.db.JoinBuilder;
 import org.springframework.stereotype.Component;
 
 import com.cloud.configuration.Resource;
@@ -34,14 +34,18 @@
 import com.cloud.configuration.Resource.ResourceType;
 import com.cloud.configuration.ResourceCountVO;
 import com.cloud.configuration.ResourceLimit;
+import com.cloud.domain.DomainVO;
 import com.cloud.domain.dao.DomainDao;
 import com.cloud.exception.UnsupportedServiceException;
+import com.cloud.user.AccountVO;
 import com.cloud.user.dao.AccountDao;
 import com.cloud.utils.db.DB;
 import com.cloud.utils.db.GenericDaoBase;
+import com.cloud.utils.db.JoinBuilder;
 import com.cloud.utils.db.SearchBuilder;
 import com.cloud.utils.db.SearchCriteria;
 import com.cloud.utils.db.TransactionLegacy;
+import com.cloud.utils.exception.CloudRuntimeException;
 
 @Component
 public class ResourceCountDaoImpl extends GenericDaoBase implements ResourceCountDao {
@@ -51,9 +55,9 @@
 private final SearchBuilder DomainSearch;
 
 @Inject
-protected DomainDao _domainDao;
+private DomainDao _domainDao;
 @Inject
-protected AccountDao _accountDao;
+private AccountDao _accountDao;
 
 public ResourceCountDaoImpl() {
 TypeSearch = createSearchBuilder();
@@ -248,4 +252,41 @@ public long removeEntriesByOwner(long ownerId, 
ResourceOwnerType ownerType) {
 return 0;
 }
 
+private String baseSqlCountComputingResourceAllocatedToAccount = "Select "
++ " SUM((CASE "
++ "WHEN so.%s is not null THEN so.%s "
++ "ELSE CONVERT(vmd.value, UNSIGNED INTEGER) "
++ "END)) as total "
++ " from vm_instance vm "
++ " join service_offering_view so on so.id = 
vm.service_offering_id "
++ " left join user_vm_details vmd on vmd.vm_id = vm.id and 
vmd.name = '%s' "
++ " where vm.type = 'User' and state not in ('Destroyed', 'Error', 
'Expunging') and display_vm = true and account_id = ? ";
+@Override
+public long countCpuNumberAllocatedToAccount(long accountId) {
+String sqlCountCpuNumberAllocatedToAccount = 
String.format(baseSqlCountComputingResourceAllocatedToAccount, 
ResourceType.cpu, ResourceType.cpu, "cpuNumber");
+return executeSqlCountComputingResourcesForAccount(accountId, 
sqlCountCpuNumberAllocatedToAccount);
+}
+
+@Override
+public long countMemoryAllocatedToAccount(long accountId) {
+String serviceOfferingRamSizeField = "ram_size";
+String sqlCountCpuNumberAllocatedToAccount = 

[cloudstack] branch master updated (f8d98fd -> 06ef61b)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from f8d98fd  Merge pull request #2451 from Accelerite/CLOUDSTACK-10284
 add 5d54502  [CLOUDSTACK-9338] ACS not accounting resources of VMs with 
custom service offering
 add 7f934c0  Formatting to make checkstyle happy
 add 601d095  Python automated test case for updateResourceCount API method
 new 06ef61b  Merge pull request #2443 from 
rafaelweingartner/CLOUDSTACK-9338

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../cloud/configuration/dao/ResourceCountDao.java  |  14 +
 .../configuration/dao/ResourceCountDaoImpl.java|  51 +++-
 .../resourcelimit/ResourceLimitManagerImpl.java| 297 -
 .../component/test_updateResourceCount.py  | 235 
 4 files changed, 413 insertions(+), 184 deletions(-)
 create mode 100644 test/integration/component/test_updateResourceCount.py

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[GitHub] rafaelweingartner commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

[GitBox]

rafaelweingartner commented on issue #1940: CLOUDSTACK-9781:ACS records ID in 
events tables instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-368015846
 
 
   Can you provide some feedback here @syed.
   I notice you have a -1 here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2112: Add Datera CloudStack Storage Plugin 4.10.0.0

[GitBox]

rafaelweingartner commented on a change in pull request #2112: Add Datera 
CloudStack Storage Plugin 4.10.0.0
URL: https://github.com/apache/cloudstack/pull/2112#discussion_r170256535
 
 

 ##
 File path: 
plugins/storage/volume/datera/test/org/apache/cloudstack/storage/datastore/driver/DateraPrimaryDataStoreDriverTest.java
 ##
 @@ -0,0 +1,133 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.storage.datastore.driver;
+
+import com.cloud.dc.ClusterDetailsDao;
+import com.cloud.dc.dao.ClusterDao;
+import com.cloud.host.Host;
+import com.cloud.host.dao.HostDao;
+import com.cloud.storage.dao.SnapshotDao;
+import com.cloud.storage.dao.SnapshotDetailsDao;
+import com.cloud.storage.dao.VMTemplatePoolDao;
+import com.cloud.storage.dao.VolumeDao;
+import com.cloud.storage.dao.VolumeDetailsDao;
+import org.apache.cloudstack.engine.subsystem.api.storage.VolumeDataFactory;
+import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
+import org.apache.cloudstack.storage.datastore.db.StoragePoolDetailsDao;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mock;
+
+import javax.inject.Inject;
+
+import static org.mockito.Mockito.when;
+
+public class DateraPrimaryDataStoreDriverTest {
+
+@Inject
+DateraPrimaryDataStoreDriver dateraDriver = new 
DateraPrimaryDataStoreDriver();
+
+@Mock private ClusterDao _clusterDao;
+@Mock private ClusterDetailsDao _clusterDetailsDao;
+@Mock private HostDao _hostDao;
+@Mock private SnapshotDao _snapshotDao;
+@Mock private SnapshotDetailsDao _snapshotDetailsDao;
+@Mock private PrimaryDataStoreDao _storagePoolDao;
+@Mock private StoragePoolDetailsDao _storagePoolDetailsDao;
+@Mock private VolumeDao _volumeDao;
+@Mock private VMTemplatePoolDao tmpltPoolDao;
+@Mock private PrimaryDataStoreDao storagePoolDao;
+@Mock private VolumeDetailsDao volumeDetailsDao;
+@Mock private SnapshotDetailsDao snapshotDetailsDao;
+@Mock private VolumeDataFactory volumeDataFactory;
+
+// Mock variables
+@Mock private Host mockHost;
+
+
+//Constants
+private static final String STORAGE_URL = "TODO";
+
+@Before
+public void setUp() throws Exception {
+
+//setup Mock objects
+when(mockHost.getStorageUrl()).thenReturn(STORAGE_URL);
+
+}
+
+@Test
+public void testGrantAccess() throws Exception {
 
 Review comment:
   Are you planning to really implement the test cases?!?
   If not, please remote these classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2112: Add Datera CloudStack Storage Plugin 4.10.0.0

[GitBox]

rafaelweingartner commented on issue #2112: Add Datera CloudStack Storage 
Plugin 4.10.0.0
URL: https://github.com/apache/cloudstack/pull/2112#issuecomment-368015141
 
 
   Ping @jcshen007 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2466: Rare race condition in KVM migration

[GitBox]

blueorangutan commented on issue #2466: Rare race condition in KVM migration
URL: https://github.com/apache/cloudstack/pull/2466#issuecomment-368011848
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2466: Rare race condition in KVM migration

[GitBox]

borisstoyanov commented on issue #2466: Rare race condition in KVM migration
URL: https://github.com/apache/cloudstack/pull/2466#issuecomment-368011721
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2392: dateutil: constistency of tzdate input and output

[GitBox]

rafaelweingartner commented on issue #2392: dateutil: constistency of tzdate 
input and output
URL: https://github.com/apache/cloudstack/pull/2392#issuecomment-367999877
 
 
   Ok. So let's keep it to master, and not cause you much more trouble. One 
more thing though; can you squash those commits? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greut commented on issue #2392: dateutil: constistency of tzdate input and output

[GitBox]

greut commented on issue #2392: dateutil: constistency of tzdate input and 
output
URL: https://github.com/apache/cloudstack/pull/2392#issuecomment-367999313
 
 
   @rafaelweingartner I really don't mind about the target. At the end the day, 
@marcaurele will be the backport ninja.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2466: Rare race condition in KVM migration

[GitBox]

nvazquez commented on issue #2466: Rare race condition in KVM migration
URL: https://github.com/apache/cloudstack/pull/2466#issuecomment-367995401
 
 
   Thanks @rafaelweingartner your reviewing!
   That's great @remibergsma, thanks, much appreaciated!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] remibergsma commented on issue #2466: Rare race condition in KVM migration

[GitBox]

remibergsma commented on issue #2466: Rare race condition in KVM migration
URL: https://github.com/apache/cloudstack/pull/2466#issuecomment-367994088
 
 
   Thanks @nvazquez, was just investigating this issue when I saw your PR. 
Looks pretty much what we saw as well. Will test it :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2392: dateutil: constistency of tzdate input and output

[GitBox]

rafaelweingartner commented on issue #2392: dateutil: constistency of tzdate 
input and output
URL: https://github.com/apache/cloudstack/pull/2392#issuecomment-367993667
 
 
   ok, now you pointed the PR to master. Is that your target?
   If so, I believe everything is ok to start the integration tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greut commented on issue #2392: dateutil: constistency of tzdate input and output

[GitBox]

greut commented on issue #2392: dateutil: constistency of tzdate input and 
output
URL: https://github.com/apache/cloudstack/pull/2392#issuecomment-367993109
 
 
   @rafaelweingartner I don't mind rebasing it against 4.11 if necessary.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2466: Rare race condition in KVM migration

[GitBox]

nvazquez commented on issue #2466: Rare race condition in KVM migration
URL: https://github.com/apache/cloudstack/pull/2466#issuecomment-367991052
 
 
   Hi @rafaelweingartner, let me answer your questions by explaining the issue 
in a better way:
   
   This is issue is reported under these conditions:
   - VM migration has physically finished
   - Migration thread executor is still not marked as terminated
   
   From the migration monitoring process, as VM has been migrated, that domain 
cannot be found (we should get the destination domain from the migration thread 
later) and the LibvirtException is thrown: `LibvirtException ?Domain not found: 
no domain with matching uuid?`.
   So basically the idea is just logging the issue but not suspending the VM as 
the migration has already been performed, but the migration thread is not 
marked as finished. Once the migrarion thread is marked as finished, the 
migration monitoring process (while loop) ends and the migration command 
wrapper would continue its execution.
   Regarding your last question, we won't need to suspend the VM in this case 
as the migration has already been performed. VM suspension will take place 
whenever the migration is in progress and those conditions are met


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2392: dateutil: constistency of tzdate input and output

[GitBox]

rafaelweingartner commented on issue #2392: dateutil: constistency of tzdate 
input and output
URL: https://github.com/apache/cloudstack/pull/2392#issuecomment-367978492
 
 
   @greut there is somethign wrong with your rebase. It seems that you rebased 
against master, but now you are opening a PR against 4.11 branch. Which one do 
you want?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2392: dateutil: constistency of tzdate input and output

[GitBox]

rafaelweingartner commented on issue #2392: dateutil: constistency of tzdate 
input and output
URL: https://github.com/apache/cloudstack/pull/2392#issuecomment-367978492
 
 
   @greut there is something wrong with your rebase. It seems that you rebased 
against master, but now you are opening a PR against 4.11 branch. Which one do 
you want?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ustcweizhou commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM.

[GitBox]

ustcweizhou commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from 
VM Snapshot generates error if hypervisor is not KVM.
URL: https://github.com/apache/cloudstack/pull/2451#issuecomment-367978464
 
 
   @rafaelweingartner I deleted my LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ustcweizhou commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM.

[GitBox]

ustcweizhou commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from 
VM Snapshot generates error if hypervisor is not KVM.
URL: https://github.com/apache/cloudstack/pull/2451#issuecomment-364846473
 
 
   LGTM
   my mistake actually.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM.

[GitBox]

rafaelweingartner commented on issue #2451: CLOUDSTACK-10284:Creating a 
snapshot from VM Snapshot generates error if hypervisor is not KVM.
URL: https://github.com/apache/cloudstack/pull/2451#issuecomment-367977323
 
 
   If that is the case. I can merge it now.
   It has already 2 successful reviews and it only changes code in the UI.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: Merge pull request #2451 from Accelerite/CLOUDSTACK-10284

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit f8d98fd1d014ca9ef8b9f69a6310f868dca2c6d8
Merge: d0ec261 37e5d36
Author: Rafael Weingärtner 
AuthorDate: Fri Feb 23 07:55:19 2018 -0300

Merge pull request #2451 from Accelerite/CLOUDSTACK-10284

CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if 
hypervisor is not KVM.

 ui/scripts/storage.js | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[GitHub] rafaelweingartner closed pull request #2451: CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM.

[GitBox]

rafaelweingartner closed pull request #2451: CLOUDSTACK-10284:Creating a 
snapshot from VM Snapshot generates error if hypervisor is not KVM.
URL: https://github.com/apache/cloudstack/pull/2451
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ui/scripts/storage.js b/ui/scripts/storage.js
index 1cba7505491..e9b6138d0b6 100644
--- a/ui/scripts/storage.js
+++ b/ui/scripts/storage.js
@@ -2859,7 +2859,10 @@
 if (jsonObj.state == "Ready") {
 allowedActions.push("remove");
 allowedActions.push("revertToVMSnapshot");
-allowedActions.push("takeSnapshot");
+
+if (args && args.context && args.context.instances && 
args.context.instances[0].hypervisor && args.context.instances[0].hypervisor 
=== "KVM") {
+allowedActions.push("takeSnapshot");
+}
 }
 
 return allowedActions;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (d0ec261 -> f8d98fd)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from d0ec261  Forward merge #2454 merged on '4.11' branch
 add 37e5d36  CLOUDSTACK-10284:Creating a snapshot from VM Snapshot 
generates error if hypervisor is not KVM.
 new f8d98fd  Merge pull request #2451 from Accelerite/CLOUDSTACK-10284

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 ui/scripts/storage.js | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.