[GitHub] [cloudstack] shwstppr closed pull request #4639: cks: use HttpsURLConnection for checking api server
shwstppr closed pull request #4639: URL: https://github.com/apache/cloudstack/pull/4639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4543: marvin and tests python 2to3
blueorangutan removed a comment on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-782441062 Trillian test result (tid-3583) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28440 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4543-t3583-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py Intermittent failure detected: /marvin/tests/smoke/test_over_provisioning.py Intermittent failure detected: /marvin/tests/smoke/test_pvlan.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_usage_events.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 78 look OK, 8 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_deploy_vm_root_resize | `Failure` | 33.15 | test_deploy_vm_root_resize.py test_UpdateStorageOverProvisioningFactor | `Error` | 0.05 | test_over_provisioning.py test_oobm_issue_power_cycle | `Failure` | 3.21 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_off | `Failure` | 3.55 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_on | `Failure` | 3.58 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_reset | `Failure` | 3.94 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_soft | `Failure` | 4.58 | test_outofbandmanagement_nestedplugin.py test_oobm_issue_power_status | `Failure` | 2.98 | test_outofbandmanagement_nestedplugin.py test_create_pvlan_network | `Error` | 1.13 | test_pvlan.py test_01_snapshot_root_disk | `Error` | 4.24 | test_snapshots.py ContextSuite context=TestUsageEvents>:teardown | `Error` | 7.64 | test_usage_events.py runTest | `Error` | 0.00 | test_vm_life_cycle.py runTest | `Error` | 0.00 | test_vm_life_cycle.py runTest | `Error` | 0.00 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4543: marvin and tests python 2to3
DaanHoogland commented on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-783974313 wow, let's see if this is in an automated run as well: ``` # cat smoketests-summary.txt Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 85 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_migrate_VM_and_root_volume | `Error` | 68.61 | test_vm_life_cycle.py test_02_migrate_VM_with_two_data_disks | `Error` | 48.46 | test_vm_life_cycle.py ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4551: Cleanup volume information from db when deleted
blueorangutan commented on pull request #4551: URL: https://github.com/apache/cloudstack/pull/4551#issuecomment-783956282 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2801 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
blueorangutan commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-783956283 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2802 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
blueorangutan commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783956279 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2800 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4713: API: Increase leniency to list templates on secondary stores that have been marked deleted by updating the db
blueorangutan commented on pull request #4713: URL: https://github.com/apache/cloudstack/pull/4713#issuecomment-783938331 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2799 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
blueorangutan commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-783935123 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2798 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
blueorangutan commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-783909885 @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4422: Count resources of virtual routers cpu/memory
blueorangutan commented on pull request #4422: URL: https://github.com/apache/cloudstack/pull/4422#issuecomment-783908122 @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4047: Look for active templates for VR deployment
shwstppr commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-783907382 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4422: Count resources of virtual routers cpu/memory
shwstppr commented on pull request #4422: URL: https://github.com/apache/cloudstack/pull/4422#issuecomment-783905873 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4713: API: Increase leniency to list templates on secondary stores that have been marked deleted by updating the db
blueorangutan commented on pull request #4713: URL: https://github.com/apache/cloudstack/pull/4713#issuecomment-783904742 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4713: API: Increase leniency to list templates on secondary stores that have been marked deleted by updating the db
shwstppr commented on pull request #4713: URL: https://github.com/apache/cloudstack/pull/4713#issuecomment-783902471 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr closed issue #4603: uuids instead of display names are shown in detail view of VM snapshot
shwstppr closed issue #4603: URL: https://github.com/apache/cloudstack/issues/4603 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on issue #4603: uuids instead of display names are shown in detail view of VM snapshot
shwstppr commented on issue #4603: URL: https://github.com/apache/cloudstack/issues/4603#issuecomment-783879829 Closed with #4604 @mib1185 please re-open if the issue still persists This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4378: server: Optional destination host when migrate a vm
blueorangutan commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-783840465 Trillian test result (tid-3593) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37820 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4378-t3593-vmware-65u2.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Smoke tests completed. 85 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 782.62 | test_kubernetes_clusters.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4378: server: Optional destination host when migrate a vm
blueorangutan commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-783805651 Trillian test result (tid-3592) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33516 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4378-t3592-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_iso.py Smoke tests completed. 85 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_extract_Iso | `Failure` | 128.42 | test_iso.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4378: server: Optional destination host when migrate a vm
blueorangutan commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-783790767 Trillian test result (tid-3591) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31169 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4378-t3591-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Smoke tests completed. 85 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_scale_vm | `Failure` | 10.26 | test_scale_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
blueorangutan commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-783787706 Trillian test result (tid-3594) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30418 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4032-t3594-kvm-centos7.zip Smoke tests completed. 86 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4717: Added recursive fetch of child domains for listUsageRecords API call
blueorangutan commented on pull request #4717: URL: https://github.com/apache/cloudstack/pull/4717#issuecomment-783766482 Trillian test result (tid-3590) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32143 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4717-t3590-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Smoke tests completed. 84 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_privategw_static_routes | `Failure` | 234.79 | test_privategw_acl.py test_04_extract_Iso | `Failure` | 128.29 | test_iso.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ThyLAW edited a comment on issue #4700: Uefi.properties doesn't Exist / connection w/ libvirtd broken
ThyLAW edited a comment on issue #4700: URL: https://github.com/apache/cloudstack/issues/4700#issuecomment-783695389 > CS means java, not per se the other way around I think 220183 is the pid. So I just verified that it is Cloudstack running on those ports. To test to see if Libvirtd even worked, I created a virtual machine and ran it and it seemed fine, meaning that libvirtd is working and I am able to use nested virtualization. This has now been narrowed down to some properties of libvirtd, properties of cloudstack agent, or the connection between them. Here is the most recent error logs (journalctl -xe): > Feb 22 16:42:48 cloud.upbcist.priv polkitd[805]: Unregistered Authentication Agent for unix-process:40535:2843629 (system bus name :1.4803, object path /org/freedesktop/PolicyKit1/AuthenticationAgent, locale en_US.UTF-8) (disconnected fr > Feb 22 16:42:48 cloud.upbcist.priv java[40541]: log4j:WARN No appenders could be found for logger (com.cloud.agent.AgentShell). > Feb 22 16:42:48 cloud.upbcist.priv java[40541]: log4j:WARN Please initialize the log4j system properly. > Feb 22 16:42:48 cloud.upbcist.priv java[40541]: log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. > Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.agent.AgentShell] (main:) (logid:) Agent started > Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.agent.AgentShell] (main:) (logid:) Implementation Version is 4.15.0.0 > Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.agent.AgentShell] (main:) (logid:) agent.properties found at /etc/cloudstack/agent/agent.properties > Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.agent.AgentShell] (main:) (logid:) Defaulting to using properties file for storage > Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.agent.AgentShell] (main:) (logid:) Defaulting to the constant time backoff algorithm > Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.utils.LogUtils] (main:) (logid:) log4j configuration found at /etc/cloudstack/agent/log4j-cloud.xml > Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.agent.AgentShell] (main:) (logid:) Using default Java settings for IPv6 preference for agent connection > Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.agent.Agent] (main:) (logid:) id is 0 > Feb 22 16:42:48 cloud.upbcist.priv java[40541]: ERROR [kvm.resource.LibvirtComputingResource] (main:) (logid:) uefi properties file not found due to: Unable to find file uefi.properties. > Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [kvm.resource.LibvirtConnection] (main:) (logid:) No existing libvirtd connection found. Opening a new one > Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [kvm.resource.LibvirtComputingResource] (main:) (logid:) No libvirt.vif.driver specified. Defaults to BridgeVifDriver. > Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [kvm.resource.LibvirtComputingResource] (main:) (logid:) iscsi session clean up is disabled > Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [cloud.agent.Agent] (main:) (logid:) Agent [id = 0 : type = LibvirtComputingResource : zone = default : pod = default : workers = 5 : host = localhost : port = 8250 > Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [utils.nio.NioClient] (main:) (logid:) Connecting to localhost:8250 > Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [utils.nio.Link] (main:) (logid:) Conf file found: /etc/cloudstack/agent/agent.properties > Feb 22 16:42:49 cloud.upbcist.priv java[40541]: WARN [utils.nio.Link] (main:) (logid:) Failed to load keystore, using trust all manager > Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [utils.nio.NioClient] (main:) (logid:) SSL: Handshake done > Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [utils.nio.NioClient] (main:) (logid:) Connected to localhost:8250 > Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [utils.linux.KVMHostInfo] (Agent-Handler-1:) (logid:) Could not read cpuinfo_max_freq, falling back on libvirt > Feb 22 16:42:49 cloud.upbcist.priv sudo[40641]: root : TTY=unknown ; PWD=/ ; USER=root ; COMMAND=/bin/grep InitiatorName= /etc/iscsi/initiatorname.iscsi > Feb 22 16:42:49 cloud.upbcist.priv systemd[1]: Created slice User Slice of root. > `Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [kvm.storage.LibvirtStorageAdaptor] (Agent-Handler-1:) (logid:) Attempting to create storage pool 4462e20b-ace8-417b-9125-8be5cf4cff4b (Filesystem) in libvirt > Feb 22 16:42:49 cloud.upbcist.priv java[40541]: libvirt: Domain Config error : invalid connection pointer in virConnectGetVersion > Feb 22 16:42:49 cloud.upbcist.priv java[40541]: ERROR [kvm.resource.LibvirtConnection] (Agent-Handler-1:) (logid:) Connection with libvirtd is broken: invalid connection pointer in
[GitHub] [cloudstack] ThyLAW commented on issue #4700: Uefi.properties doesn't Exist / connection w/ libvirtd broken
ThyLAW commented on issue #4700: URL: https://github.com/apache/cloudstack/issues/4700#issuecomment-783695389 > CS means java, not per se the other way around I think 220183 is the pid. So I just verified that it is Cloudstack running on those ports. To test to see if Libvirtd even worked, I created a virtual machine and ran it and it seemed fine, meaning that libvirtd is working and I am able to use nested virtualization. This has now been narrowed down to some properties of libvirtd, properties of cloudstack agent, or the connection between them. Here is the most recent error logs (journalctl -xe): `Feb 22 16:42:48 cloud.upbcist.priv polkitd[805]: Unregistered Authentication Agent for unix-process:40535:2843629 (system bus name :1.4803, object path /org/freedesktop/PolicyKit1/AuthenticationAgent, locale en_US.UTF-8) (disconnected fr Feb 22 16:42:48 cloud.upbcist.priv java[40541]: log4j:WARN No appenders could be found for logger (com.cloud.agent.AgentShell). Feb 22 16:42:48 cloud.upbcist.priv java[40541]: log4j:WARN Please initialize the log4j system properly. Feb 22 16:42:48 cloud.upbcist.priv java[40541]: log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.agent.AgentShell] (main:) (logid:) Agent started Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.agent.AgentShell] (main:) (logid:) Implementation Version is 4.15.0.0 Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.agent.AgentShell] (main:) (logid:) agent.properties found at /etc/cloudstack/agent/agent.properties Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.agent.AgentShell] (main:) (logid:) Defaulting to using properties file for storage Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.agent.AgentShell] (main:) (logid:) Defaulting to the constant time backoff algorithm Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.utils.LogUtils] (main:) (logid:) log4j configuration found at /etc/cloudstack/agent/log4j-cloud.xml Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.agent.AgentShell] (main:) (logid:) Using default Java settings for IPv6 preference for agent connection Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [cloud.agent.Agent] (main:) (logid:) id is 0 Feb 22 16:42:48 cloud.upbcist.priv java[40541]: ERROR [kvm.resource.LibvirtComputingResource] (main:) (logid:) uefi properties file not found due to: Unable to find file uefi.properties. Feb 22 16:42:48 cloud.upbcist.priv java[40541]: INFO [kvm.resource.LibvirtConnection] (main:) (logid:) No existing libvirtd connection found. Opening a new one Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [kvm.resource.LibvirtComputingResource] (main:) (logid:) No libvirt.vif.driver specified. Defaults to BridgeVifDriver. Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [kvm.resource.LibvirtComputingResource] (main:) (logid:) iscsi session clean up is disabled Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [cloud.agent.Agent] (main:) (logid:) Agent [id = 0 : type = LibvirtComputingResource : zone = default : pod = default : workers = 5 : host = localhost : port = 8250 Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [utils.nio.NioClient] (main:) (logid:) Connecting to localhost:8250 Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [utils.nio.Link] (main:) (logid:) Conf file found: /etc/cloudstack/agent/agent.properties Feb 22 16:42:49 cloud.upbcist.priv java[40541]: WARN [utils.nio.Link] (main:) (logid:) Failed to load keystore, using trust all manager Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [utils.nio.NioClient] (main:) (logid:) SSL: Handshake done Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [utils.nio.NioClient] (main:) (logid:) Connected to localhost:8250 Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [utils.linux.KVMHostInfo] (Agent-Handler-1:) (logid:) Could not read cpuinfo_max_freq, falling back on libvirt Feb 22 16:42:49 cloud.upbcist.priv sudo[40641]: root : TTY=unknown ; PWD=/ ; USER=root ; COMMAND=/bin/grep InitiatorName= /etc/iscsi/initiatorname.iscsi Feb 22 16:42:49 cloud.upbcist.priv systemd[1]: Created slice User Slice of root. ` `Feb 22 16:42:49 cloud.upbcist.priv java[40541]: INFO [kvm.storage.LibvirtStorageAdaptor] (Agent-Handler-1:) (logid:) Attempting to create storage pool 4462e20b-ace8-417b-9125-8be5cf4cff4b (Filesystem) in libvirt Feb 22 16:42:49 cloud.upbcist.priv java[40541]: libvirt: Domain Config error : invalid connection pointer in virConnectGetVersion Feb 22 16:42:49 cloud.upbcist.priv java[40541]: ERROR [kvm.resource.LibvirtConnection] (Agent-Handler-1:) (logid:) Connection with libvirtd is broken: invalid connection pointer in virConnectGetVersion Feb 22 16:42:49
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
blueorangutan commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783665965 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2797 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
blueorangutan commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-783665400 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2796 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
blueorangutan commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-783664584 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2795 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] dhansenippathways commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.
dhansenippathways commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-783659064 It looks like the build is failing on a timeout error. Should we get the build re-kicked off or are there other errors that I'm missing? @DaanHoogland @ggoodrich-ipp This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4543: marvin and tests python 2to3
blueorangutan removed a comment on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-783488083 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4543: marvin and tests python 2to3
blueorangutan commented on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-783580698 Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this
blueorangutan commented on pull request #4577: URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-783578061 Trillian test result (tid-3589) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32292 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4577-t3589-kvm-centos7.zip Smoke tests completed. 86 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4703: Improve logs on ProcessRunner
GutoVeronezi commented on a change in pull request #4703: URL: https://github.com/apache/cloudstack/pull/4703#discussion_r580485951 ## File path: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ## @@ -34,6 +34,7 @@ import java.util.concurrent.Future; import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeoutException; +import org.apache.commons.lang3.StringUtils; Review comment: @DaanHoogland as discussed in the review https://github.com/apache/cloudstack/pull/4702#pullrequestreview-593280595, it will not be done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi opened a new pull request #4722: Externalize config to set min memory/cpu with division by overprovisi…
GutoVeronezi opened a new pull request #4722:
URL: https://github.com/apache/cloudstack/pull/4722
### Description
When ACS is deploying a VM, it defines a minimum memory|CPU to the VM based
on a calculation through the overprovisioning (defined mem|cpu speed /
overprovisioning factor); Therefore, it will define a range of memory|CPU, even
if it does not use scalable (dynamic) service offerings.
This PR intends to externalize 2 cluster's configurations to allow operators
to decide if they want the minimum memory|CPU to be different from the
allocated value when the overprovisioning's configurations are different than
`1`.
When we set the overprovisioning factor, it means that we (as operators) are
willing to allocate more virtual resources than the physical ones. This is
interesting when the hypervisor has optimization techniques such as the KVM
ones for optimizing the allocation of common blocks among running virtual
machines (Kernel Samepage Merging - KSM). Therefore, we do not need to reduce
the minimum amount of memory that the VM must receive when the overprovisioning
is higher than one. This is important for public cloud environments, where such
definition can be perceived by final users.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
It has been tested locally in a test lab.
1. I had created VM and observed the `dumpxml`.
2. When I was using the configuration as `true`, it kept the same behavior
(allocated memory <> currentMemory).
3. When I was using the configuration as `false`, it took the current memory
equals the allocated memory.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4543: marvin and tests python 2to3
blueorangutan commented on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-783520763 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2793 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
blueorangutan commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-783519732 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
blueorangutan commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-783518762 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2791 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] abdelouahabb commented on issue #4715: Cloudstack management asks for rpm command on debian distribution
abdelouahabb commented on issue #4715: URL: https://github.com/apache/cloudstack/issues/4715#issuecomment-783502498 ``` abdelouahab@alien:~ $ sudo lshw -class system alien.akham.local description: Computer product: VirtualBox vendor: innotek GmbH version: 1.2 serial: 0 width: 64 bits capabilities: smbios-2.5 dmi-2.5 smp vsyscall32 configuration: family=Virtual Machine uuid=E7584F9E-5753-2E49-9099-BA34C6073FA3 abdelouahab@alien:~ $ hostnamectl status Static hostname: alien.akham.local Icon name: computer-vm Chassis: vm Machine ID: ec31ec7e3e384682b6a396c151c030ac Boot ID: 4f3d9a5b14734ad7afcd55b2b456d2cc Virtualization: oracle Operating System: Ubuntu 18.04.5 LTS Kernel: Linux 4.15.0-135-generic Architecture: x86-64 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4543: marvin and tests python 2to3
blueorangutan commented on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-783488083 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2789 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4551: Cleanup volume information from db when deleted
blueorangutan commented on pull request #4551: URL: https://github.com/apache/cloudstack/pull/4551#issuecomment-783488084 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2790 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] abdelouahabb commented on issue #4715: Cloudstack management asks for rpm command on debian distribution
abdelouahabb commented on issue #4715: URL: https://github.com/apache/cloudstack/issues/4715#issuecomment-783492136 > @abdelouahabb is your KVM host centos7 based? @rhtyd no, this is Ubuntu 18.04.5 ontop of VirtualBox under Windows 7 (as the paravirtualization enabled) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4700: Uefi.properties doesn't Exist / connection w/ libvirtd broken
DaanHoogland commented on issue #4700: URL: https://github.com/apache/cloudstack/issues/4700#issuecomment-783486814 CS means java, not per se the other way around I think 220183 is the pid. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ThyLAW commented on issue #4700: Uefi.properties doesn't Exist / connection w/ libvirtd broken
ThyLAW commented on issue #4700: URL: https://github.com/apache/cloudstack/issues/4700#issuecomment-783476540 I get the following: netstat -tulnp | grep (8250, 9090, 8080) tcp6 0 0 ::8250 :::* LISTEN 220183/java netstat -tulnp | grep (8787, 8096, 3922) *nothing* netstat -tulnp | grep 22 tcp6 0 0 ::22 :::* LISTEN1148/sshd Java should mean CS right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
blueorangutan commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-783474536 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
blueorangutan commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-783474364 @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
shwstppr commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-783473914 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
blueorangutan commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-783473705 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #3944: vpc/server: Fix network statistics for vpc
shwstppr commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-783473497 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4378: server: Optional destination host when migrate a vm
blueorangutan commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-783473246 @shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
shwstppr commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-783473028 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4551: Cleanup volume information from db when deleted
blueorangutan commented on pull request #4551: URL: https://github.com/apache/cloudstack/pull/4551#issuecomment-783473072 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4551: Cleanup volume information from db when deleted
shwstppr commented on pull request #4551: URL: https://github.com/apache/cloudstack/pull/4551#issuecomment-783472462 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4378: server: Optional destination host when migrate a vm
shwstppr commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-783471922 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4700: Uefi.properties doesn't Exist / connection w/ libvirtd broken
DaanHoogland commented on issue #4700: URL: https://github.com/apache/cloudstack/issues/4700#issuecomment-783458723 yes, there are some other tickets related to this but afaicsn it is not a duplicate (i might be wrong). check yout host to see if anything is listening on that port @ThyLAW . I undestand you try to get a hyperconverged env up. check if there is nothing listeniong on the ports you need. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4422: Count resources of virtual routers cpu/memory
blueorangutan commented on pull request #4422: URL: https://github.com/apache/cloudstack/pull/4422#issuecomment-783455802 Packaging result: ✔centos7 ✔centos8 ✖debian. JID-2788 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
blueorangutan commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783451056 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland opened a new pull request #4721: preserve root cause in exception
DaanHoogland opened a new pull request #4721:
URL: https://github.com/apache/cloudstack/pull/4721
### Description
This PR... preserve a root cause exception
### Types of changes
- [x] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4717: Added recursive fetch of child domains for listUsageRecords API call
blueorangutan commented on pull request #4717: URL: https://github.com/apache/cloudstack/pull/4717#issuecomment-783417348 @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4717: Added recursive fetch of child domains for listUsageRecords API call
Spaceman1984 commented on pull request #4717: URL: https://github.com/apache/cloudstack/pull/4717#issuecomment-783416729 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4422: Count resources of virtual routers cpu/memory
blueorangutan commented on pull request #4422: URL: https://github.com/apache/cloudstack/pull/4422#issuecomment-783414192 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ThyLAW commented on issue #4700: Uefi.properties doesn't Exist / connection w/ libvirtd broken
ThyLAW commented on issue #4700: URL: https://github.com/apache/cloudstack/issues/4700#issuecomment-783413857 The UEFI apparently doesn't matter, I don't care about the secureboot. The connection between the agent and libvirtd is what is causing this to crash. Error similar to #4659 , #4050, #3509 . Nothing seems to be able to fix it. Restarting agent, management, and libvirtd gives me: `/ elper] (main:null) (logid:) Default Builder inited. .Agent] (Agent-Handler-2:) (logid:) Reconnecting to host:localhost NioClient] (Agent-Handler-2:) (logid:) Connecting to localhost:8250 NioConnection] (Agent-Handler-2:) (logid:) Unable to connect to remote: is there a server running on port 8250` Unsure what it could be. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4422: Count resources of virtual routers cpu/memory
shwstppr commented on pull request #4422: URL: https://github.com/apache/cloudstack/pull/4422#issuecomment-783413842 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr removed a comment on pull request #4422: Count resources of virtual routers cpu/memory
shwstppr removed a comment on pull request #4422: URL: https://github.com/apache/cloudstack/pull/4422#issuecomment-783252501 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4422: Count resources of virtual routers cpu/memory
blueorangutan removed a comment on pull request #4422: URL: https://github.com/apache/cloudstack/pull/4422#issuecomment-783302935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
blueorangutan commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783413612 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #3804: Display capability info in listNetwork response
shwstppr commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783413052 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #3804: Display capability info in listNetwork response
shwstppr closed pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4378: server: Optional destination host when migrate a vm
blueorangutan commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-783411156 Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4534: Migrate vm across clusters
blueorangutan commented on pull request #4534: URL: https://github.com/apache/cloudstack/pull/4534#issuecomment-783411158 Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2786 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4717: Added recursive fetch of child domains for listUsageRecords API call
Spaceman1984 commented on a change in pull request #4717:
URL: https://github.com/apache/cloudstack/pull/4717#discussion_r580265549
##
File path: server/src/main/java/com/cloud/usage/UsageServiceImpl.java
##
@@ -248,7 +248,17 @@ public boolean
generateUsageRecords(GenerateUsageRecordsCmd cmd) {
sc.addAnd("domainId", SearchCriteria.Op.IN, domainIds.toArray());
}
-if (domainId != null) {
+if (cmd.isRecursive() && domainId != null){
Review comment:
While testing I found that users cannot call this API, but domain admins
can. I have added a check, if an account id is specified, if it belongs to any
of the domains of the calling domain admin.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4717: Added recursive fetch of child domains for listUsageRecords API call
Spaceman1984 commented on a change in pull request #4717:
URL: https://github.com/apache/cloudstack/pull/4717#discussion_r580265549
##
File path: server/src/main/java/com/cloud/usage/UsageServiceImpl.java
##
@@ -248,7 +248,17 @@ public boolean
generateUsageRecords(GenerateUsageRecordsCmd cmd) {
sc.addAnd("domainId", SearchCriteria.Op.IN, domainIds.toArray());
}
-if (domainId != null) {
+if (cmd.isRecursive() && domainId != null){
Review comment:
While testing I found that users cannot call this API, but domain admins
can. I have added a check, if an account id is specified, if it belongs to any
of the domains for the calling domain admin.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4708: kvm: Handle storage issue on NFS/KVM in multiple ways
weizhouapache closed pull request #4708: URL: https://github.com/apache/cloudstack/pull/4708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache edited a comment on pull request #4534: Migrate vm across clusters
weizhouapache edited a comment on pull request #4534: URL: https://github.com/apache/cloudstack/pull/4534#issuecomment-783381700 > sorry but this needs fixing conflicts again. > Also, is the use-case here is allow cross-cluster migration when putting the last host in maintenance. As we added some improvements for cross-cluster cross-pod VM migration with #4385 but they were largely for VMware. > Since VMware would allow cross-cluster migration even with cluster scoped pools with vmotion do we need to mention the new global setting is not for VMware @shwstppr I had a quick view on #4385, it looks that it migrates vms with a storageid. this pr should not break the feature as this changes the behavior if storageid is not passed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4534: Migrate vm across clusters
weizhouapache commented on pull request #4534: URL: https://github.com/apache/cloudstack/pull/4534#issuecomment-783381700 > sorry but this needs fixing conflicts again. > Also, is the use-case here is allow cross-cluster migration when putting the last host in maintenance. As we added some improvements for cross-cluster cross-pod VM migration with #4385 but they were largely for VMware. > Since VMware would allow cross-cluster migration even with cluster scoped pools with vmotion do we need to mention the new global setting is not for VMware @shwstppr I had a quick view on #4385, it looks that it migrates vms with a storageid. this pr should not break the feature as this changes the behavior when hostid is passed or storageid is not passed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4534: Migrate vm across clusters
blueorangutan commented on pull request #4534: URL: https://github.com/apache/cloudstack/pull/4534#issuecomment-783371380 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4534: Migrate vm across clusters
shwstppr commented on pull request #4534: URL: https://github.com/apache/cloudstack/pull/4534#issuecomment-783370910 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4378: server: Optional destination host when migrate a vm
blueorangutan commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-783370783 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4378: server: Optional destination host when migrate a vm
shwstppr commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-783370267 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4640: Added disk provisioning type support for VMWare
Spaceman1984 commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r580242683
##
File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java
##
@@ -2331,6 +2338,80 @@ public ImageStore updateImageStoreStatus(Long id,
Boolean readonly) {
return imageStoreVO;
}
+@Override
+public void updateStorageCapabilities(Long poolId, boolean failOnChecks) {
+List pools = new ArrayList<>();
+if (poolId == null) {
+pools = _storagePoolDao.listByStatus(StoragePoolStatus.Up);
+} else {
+StoragePoolVO pool = _storagePoolDao.findById(poolId);
+
+if (pool == null) {
+throw new CloudRuntimeException("Primary storage not found for
id: " + poolId);
+}
+
+pools.add(pool);
+}
+
+if (pools.size() == 0) {
+throw new CloudRuntimeException("No storage pools found to
update.");
+}
+
+for (StoragePoolVO pool: pools) {
+
+// Only checking NFS for now - required for disk provisioning type
support for vmware.
+if (pool.getPoolType() != StoragePoolType.NetworkFilesystem) {
+if (failOnChecks) {
Review comment:
failOnChecks is not only dependent on the pool id being null or not, it
is also dependent on where the method is being called from.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4531: novnc: Reject new novnc client if novnc viewer object is still alive
weizhouapache commented on pull request #4531: URL: https://github.com/apache/cloudstack/pull/4531#issuecomment-783366517 @rhtyd @DaanHoogland @davidjumani as discussed, updated this pr to accept new vm console session and disconnect old session. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4378: server: Optional destination host when migrate a vm
weizhouapache closed pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4534: Migrate vm across clusters
ustcweizhou opened a new pull request #4534:
URL: https://github.com/apache/cloudstack/pull/4534
### Description
This PR adds a global setting migrate.vm.across.clusters to indicate whether
vm can be live migrated to other clusters (with same hypervisor type), if all
volumes are in zone-wide storage pool.
If vm is running on the last host in a cluster and vm cannot be migrated to
other clusters, put host to maintenance will fail.
This is based on pr #4378
This fixes #3707 #3720
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [X] Major
- [ ] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4534: Migrate vm across clusters
weizhouapache closed pull request #4534: URL: https://github.com/apache/cloudstack/pull/4534 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
blueorangutan commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-783360325 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2784 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
blueorangutan commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-783360172 Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2783 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4707: Improve logs on HAManagerImpl
GutoVeronezi commented on a change in pull request #4707:
URL: https://github.com/apache/cloudstack/pull/4707#discussion_r580226027
##
File path: server/src/main/java/org/apache/cloudstack/ha/HAManagerImpl.java
##
@@ -156,19 +156,16 @@ public boolean transitionHAState(final HAConfig.Event
event, final HAConfig haCo
if (result) {
final String message = String.format("Transitioned host HA
state from:%s to:%s due to event:%s for the host id:%d",
currentHAState, nextState, event,
haConfig.getResourceId());
-if (LOG.isTraceEnabled()) {
-LOG.trace(message);
-}
+LOG.debug(message);
Review comment:
@DaanHoogland About removing the `isEnabled`, if you take a look at the
methods (`debug`, `trace`, or others) on
[Logger](https://github.com/apache/log4j/blob/trunk/src/main/java/org/apache/log4j/Logger.java)
and
[Category](https://github.com/apache/log4j/blob/trunk/src/main/java/org/apache/log4j/Category.java),
you will notice that they already do the same validation as the `isEnabled`
do, the only thing that the `if` would avoid is that in some cases the string
to be logged would not be created; In an async web app, like `ACS`, it is not
relevant to safe this "cost" by adding more lines to the codebase.
About changing the log level to `debug`, in this context, these messages
work better as `debug`; as well, it is quite unusual to call `trace` on `ACS`,
so, it is interesting to keep a pattern and use `debug`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability
sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580219285
##
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##
@@ -417,6 +425,40 @@ private String composeThumbnailUrl(String rootUrl,
VirtualMachine vm, HostVO hos
return sb.toString();
}
+/**
+ * Sets the URL to establish a VNC over websocket connection
+ */
+private void setWebsocketUrl(VirtualMachine vm, ConsoleProxyClientParam
param) {
+String ticket = acquireVncTicketForVmwareVm(vm);
+String wsUrl = composeWebsocketUrlForVmwareVm(ticket, param);
+param.setWebsocketUrl(wsUrl);
+}
+
+/**
+ * Format expected: wss://:443/ticket/
+ */
+private String composeWebsocketUrlForVmwareVm(String ticket,
ConsoleProxyClientParam param) {
+param.setClientHostPort(443);
+return String.format("wss://%s:%s/ticket/%s",
param.getClientHostAddress(), param.getClientHostPort(), ticket);
+}
+
+/**
+ * Acquires a ticket to be used for console proxy as described in 'Removal
of VNC Server from ESXi' on:
+ *
https://docs.vmware.com/en/VMware-vSphere/7.0/rn/vsphere-esxi-vcenter-server-70-release-notes.html
+ */
+private String acquireVncTicketForVmwareVm(VirtualMachine vm) {
+try {
+s_logger.info("Acquiring VNC ticket for VM = " + vm.getHostName());
+GetVmVncTicketCommand cmd = new
GetVmVncTicketCommand(vm.getInstanceName());
+Answer answer = agentManager.send(vm.getHostId(), cmd);
+GetVmVncTicketAnswer ans = (GetVmVncTicketAnswer) answer;
+return ans.getTicket();
+} catch (AgentUnavailableException | OperationTimedoutException e) {
+s_logger.error("Error acquiring ticket", e);
+return null;
Review comment:
in case of failure, better send the error msg with result as fail in the
answer, and process accordingly on the receiving side.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability
sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580217264
##
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##
@@ -417,6 +425,40 @@ private String composeThumbnailUrl(String rootUrl,
VirtualMachine vm, HostVO hos
return sb.toString();
}
+/**
+ * Sets the URL to establish a VNC over websocket connection
+ */
+private void setWebsocketUrl(VirtualMachine vm, ConsoleProxyClientParam
param) {
+String ticket = acquireVncTicketForVmwareVm(vm);
+String wsUrl = composeWebsocketUrlForVmwareVm(ticket, param);
+param.setWebsocketUrl(wsUrl);
+}
+
+/**
+ * Format expected: wss://:443/ticket/
+ */
+private String composeWebsocketUrlForVmwareVm(String ticket,
ConsoleProxyClientParam param) {
+param.setClientHostPort(443);
+return String.format("wss://%s:%s/ticket/%s",
param.getClientHostAddress(), param.getClientHostPort(), ticket);
+}
+
+/**
+ * Acquires a ticket to be used for console proxy as described in 'Removal
of VNC Server from ESXi' on:
+ *
https://docs.vmware.com/en/VMware-vSphere/7.0/rn/vsphere-esxi-vcenter-server-70-release-notes.html
+ */
+private String acquireVncTicketForVmwareVm(VirtualMachine vm) {
+try {
+s_logger.info("Acquiring VNC ticket for VM = " + vm.getHostName());
+GetVmVncTicketCommand cmd = new
GetVmVncTicketCommand(vm.getInstanceName());
+Answer answer = agentManager.send(vm.getHostId(), cmd);
+GetVmVncTicketAnswer ans = (GetVmVncTicketAnswer) answer;
Review comment:
better check for the answer result before continuing with the ticket, as
the ticket can be null in case of error scenarios
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability
sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580215605
##
File path: core/src/main/java/com/cloud/agent/api/GetVmVncTicketAnswer.java
##
@@ -0,0 +1,32 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.agent.api;
+
+public class GetVmVncTicketAnswer extends Answer {
+
Review comment:
cmd result (success / failed - with the reason) in the answer?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability
sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580213756
##
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##
@@ -417,6 +425,40 @@ private String composeThumbnailUrl(String rootUrl,
VirtualMachine vm, HostVO hos
return sb.toString();
}
+/**
+ * Sets the URL to establish a VNC over websocket connection
+ */
+private void setWebsocketUrl(VirtualMachine vm, ConsoleProxyClientParam
param) {
+String ticket = acquireVncTicketForVmwareVm(vm);
Review comment:
_acquireVncTicketForVmwareVm()_ returns null, in case of any
errors/exceptions, check for the same ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability
sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580213756
##
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##
@@ -417,6 +425,40 @@ private String composeThumbnailUrl(String rootUrl,
VirtualMachine vm, HostVO hos
return sb.toString();
}
+/**
+ * Sets the URL to establish a VNC over websocket connection
+ */
+private void setWebsocketUrl(VirtualMachine vm, ConsoleProxyClientParam
param) {
+String ticket = acquireVncTicketForVmwareVm(vm);
Review comment:
_ acquireVncTicketForVmwareVm()_ returns null, in case of any
errors/exceptions, check for the same ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability
sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580213756
##
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##
@@ -417,6 +425,40 @@ private String composeThumbnailUrl(String rootUrl,
VirtualMachine vm, HostVO hos
return sb.toString();
}
+/**
+ * Sets the URL to establish a VNC over websocket connection
+ */
+private void setWebsocketUrl(VirtualMachine vm, ConsoleProxyClientParam
param) {
+String ticket = acquireVncTicketForVmwareVm(vm);
Review comment:
_ acquireVncTicketForVmwareVm()_ returns null, in case of any
errors/expections, check for the same ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability
sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580209328
##
File path:
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/vnc/NoVncClient.java
##
@@ -62,6 +69,27 @@ public void connectTo(String host, int port) throws
UnknownHostException, IOExce
setStreams();
}
+public void connectToWebSocket(String websocketUrl, Session session)
throws URISyntaxException {
+webSocketReverseProxy = new WebSocketReverseProxy(new
URI(websocketUrl), session);
+webSocketReverseProxy.connect();
+}
+
+public boolean isVncOverWebSocketConnection() {
+return webSocketReverseProxy != null;
+}
+
Review comment:
Non websocket connections, will cause NPE for the below methods. Either
add a comment here to use these methods for _isVncOverWebSocketConnection()_
true, or explicitly add a check.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4300: [WIP] engine: add support for VMware 7.0 dependency and hypervisor capability
sureshanaparti commented on a change in pull request #4300: URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580202141 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql ## @@ -18,4 +18,10 @@ --; -- Schema upgrade from 4.15.0.0 to 4.15.1.0 --; +-- Add support for VMware 7.0 Review comment: @nvazquez any new OS supported with 7.0 / 7.0.1.0 to be added to guest os mappings This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala opened a new issue #4720: [UI] Need separate configurations for setting URL for general help and context sensitive help
harikrishna-patnala opened a new issue #4720: URL: https://github.com/apache/cloudstack/issues/4720 Currently CloudStack has "docBase" in config.json file where one can change the base URL for all sections. Changing the "docBase" to a new URL will effect all sections which may not be a convenient setting. For example, changing the "docBase" URL from "http://docs.cloudstack.apache.org/en/latest/; to "http://dochelp.custom.url/; this change effect the general help section here (below image) which is good  But it also changes the base URL for other sections like context sensitive help (below image) to "http://dochelp.custom.url//adminguide/virtualmachine.html;  It is good to have two different settings for URLs, one for general help and another for all context sensitive help sections. Also if feasible, a single place like a json file where one can update the bookmarks/URLS to the general help and individual context sensitive help sections (eg: VM, template, snapshot, volume, etc.) # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ ~~~ # CLOUDSTACK VERSION ~~~ ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY # STEPS TO REPRODUCE ~~~ ~~~ # EXPECTED RESULTS ~~~ ~~~ # ACTUAL RESULTS ~~~ ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4422: Count resources of virtual routers cpu/memory
blueorangutan commented on pull request #4422: URL: https://github.com/apache/cloudstack/pull/4422#issuecomment-783302935 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
blueorangutan commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-783302934 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2780 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
blueorangutan commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-783302932 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
blueorangutan commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-783302933 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2781 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4639: cks: use HttpsURLConnection for checking api server
shwstppr closed pull request #4639: URL: https://github.com/apache/cloudstack/pull/4639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4422: Count resources of virtual routers cpu/memory
blueorangutan commented on pull request #4422: URL: https://github.com/apache/cloudstack/pull/4422#issuecomment-783278447 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2778 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
blueorangutan commented on pull request #4582: URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-783277797 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
