[GitHub] [cloudstack] blueorangutan commented on pull request #6979: Guest os mappings improvements
blueorangutan commented on PR #6979: URL: https://github.com/apache/cloudstack/pull/6979#issuecomment-1373285894 @harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6979: Guest os mappings improvements
harikrishna-patnala commented on PR #6979: URL: https://github.com/apache/cloudstack/pull/6979#issuecomment-1373283630 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6979: Guest os mappings improvements
harikrishna-patnala commented on code in PR #6979:
URL: https://github.com/apache/cloudstack/pull/6979#discussion_r1063186073
##
api/src/main/java/org/apache/cloudstack/api/response/HypervisorGuestOsNamesResponse.java:
##
@@ -0,0 +1,76 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.response;
+
+import java.util.List;
+
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseResponse;
+
+import com.cloud.serializer.Param;
+import com.google.gson.annotations.SerializedName;
+
+public class HypervisorGuestOsNamesResponse extends BaseResponse {
+@SerializedName(ApiConstants.HYPERVISOR)
+@Param(description = "the hypervisor")
+private String hypervisor;
+
+@SerializedName(ApiConstants.HYPERVISOR_VERSION)
+@Param(description = "version of the hypervisor for guest os names")
+private String hypervisorVersion;
+
+@SerializedName(ApiConstants.GUEST_OSES)
+@Param(description = "the guest OSes of the hypervisor", responseObject =
HypervisorGuestOsResponse.class)
+private List guestOSes;
+
+@SerializedName(ApiConstants.GUEST_OSES_COUNT)
+@Param(description = "the count of guest OSes of the hypervisor")
+private Integer guestOSesCount;
Review Comment:
This is not used anywhere but to keep a count of the list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6979: Guest os mappings improvements
harikrishna-patnala commented on code in PR #6979:
URL: https://github.com/apache/cloudstack/pull/6979#discussion_r1063185174
##
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCheckGuestOsMappingCommandWrapper.java:
##
@@ -0,0 +1,67 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.hypervisor.xenserver.resource.wrapper.xenbase;
+
+import java.util.Set;
+
+import org.apache.log4j.Logger;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CheckGuestOsMappingAnswer;
+import com.cloud.agent.api.CheckGuestOsMappingCommand;
+import com.cloud.hypervisor.xenserver.resource.CitrixResourceBase;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.xensource.xenapi.Connection;
+import com.xensource.xenapi.VM;
+
+@ResourceWrapper(handles = CheckGuestOsMappingCommand.class)
+public final class CitrixCheckGuestOsMappingCommandWrapper extends
CommandWrapper {
+
+private static final Logger s_logger =
Logger.getLogger(CitrixCheckGuestOsMappingCommandWrapper.class);
+
+@Override
+public Answer execute(final CheckGuestOsMappingCommand command, final
CitrixResourceBase citrixResourceBase) {
+final Connection conn = citrixResourceBase.getConnection();
+String guestOsName = command.getGuestOsName();
+String guestOsMappingName = command.getGuestOsHypervisorMappingName();
+try {
+s_logger.info("Checking guest os mapping name: " +
guestOsMappingName + " for the guest os: " + guestOsName + " in the
hypervisor");
+final Set vms = VM.getAll(conn);
+if (vms == null || vms.isEmpty()) {
+return new CheckGuestOsMappingAnswer(command, "Unable to match
guest os mapping name: " + guestOsMappingName + " in the hypervisor");
+}
+for (VM vm : vms) {
+if (vm != null && vm.getIsATemplate(conn) &&
guestOsMappingName.equalsIgnoreCase(vm.getNameLabel(conn))) {
+if (guestOsName.equalsIgnoreCase(vm.getNameLabel(conn))) {
+// Exact matching may fail, try with regex?
Review Comment:
I think this is Suresh's hypothesis that it may fail. In my testing this is
getting passed normally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6979: Guest os mappings improvements
harikrishna-patnala commented on code in PR #6979:
URL: https://github.com/apache/cloudstack/pull/6979#discussion_r1063180024
##
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixGetHypervisorGuestOsNamesCommandWrapper.java:
##
@@ -0,0 +1,75 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.hypervisor.xenserver.resource.wrapper.xenbase;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.log4j.Logger;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.GetHypervisorGuestOsNamesAnswer;
+import com.cloud.agent.api.GetHypervisorGuestOsNamesCommand;
+import com.cloud.hypervisor.xenserver.resource.CitrixResourceBase;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.Pair;
+import com.xensource.xenapi.Connection;
+import com.xensource.xenapi.VM;
+
+@ResourceWrapper(handles = GetHypervisorGuestOsNamesCommand.class)
+public final class CitrixGetHypervisorGuestOsNamesCommandWrapper extends
CommandWrapper {
+
+private static final Logger s_logger =
Logger.getLogger(CitrixGetHypervisorGuestOsNamesCommandWrapper.class);
+
+@Override
+public Answer execute(final GetHypervisorGuestOsNamesCommand command,
final CitrixResourceBase citrixResourceBase) {
+final Connection conn = citrixResourceBase.getConnection();
+String keyword = command.getKeyword();
+try {
+s_logger.info("Getting guest os names in the hypervisor");
+final Set vms = VM.getAll(conn);
Review Comment:
This is an equivalent command to "xe template-list"
[root@pr6979-t5741-xenserver-70-xs1 ~]# xe template-list | grep name-label
name-label ( RW): Oracle Enterprise Linux 6 (32-bit)
name-label ( RW): SUSE Linux Enterprise Server 11 (32-bit)
name-label ( RW): Windows Server 2016 (64-bit)
name-label ( RW): Ubuntu Lucid Lynx 10.04 (32-bit)
name-label ( RW): Oracle Enterprise Linux 5 (64-bit)
name-label ( RW): Oracle Enterprise Linux 5 (32-bit)
name-label ( RW): Red Hat Enterprise Linux 4.8 (32-bit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7059: guestos: add el9 distros
rohityadavcloud commented on code in PR #7059:
URL: https://github.com/apache/cloudstack/pull/7059#discussion_r1063175635
##
engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql:
##
@@ -997,3 +997,9 @@ BEGIN
DECLARE CONTINUE HANDLER FOR 1061 BEGIN END; SET @ddl = CONCAT('ALTER
TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', ' ADD KEY ') ; SET @ddl =
CONCAT(@ddl, ' ', in_index_name); SET @ddl = CONCAT(@ddl, ' ',
in_key_definition); PREPARE stmt FROM @ddl; EXECUTE stmt; DEALLOCATE PREPARE
stmt; END;
CALL `cloud`.`IDEMPOTENT_ADD_KEY`('i_user_ip_address_state','user_ip_address',
'(state)');
+
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'AlmaLinux 9.0', 'KVM',
'default', 'AlmaLinux 9.0');
Review Comment:
Leave it just 9, so in future we need not add for all 9.0, 9.1, 9.2…. Also
should we find and add guest os mappings for other hypervisors? (Could be a
separate issue or PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud closed pull request #7060: build(deps): bump json5, @vue/cli-plugin-unit-jest and @vue/cli-service in /ui
rohityadavcloud closed pull request #7060: build(deps): bump json5, @vue/cli-plugin-unit-jest and @vue/cli-service in /ui URL: https://github.com/apache/cloudstack/pull/7060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] dependabot[bot] commented on pull request #7060: build(deps): bump json5, @vue/cli-plugin-unit-jest and @vue/cli-service in /ui
dependabot[bot] commented on PR #7060: URL: https://github.com/apache/cloudstack/pull/7060#issuecomment-1373206441 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nate-ac commented on issue #6987: Project User kubeadmin is not working with project k8s clusters
nate-ac commented on issue #6987:
URL: https://github.com/apache/cloudstack/issues/6987#issuecomment-1372894386
A little more RCA here:
When a project is created a "PrjAcct-" account is also created and given
ownership to the project. This account is created with the "RO Admin" role.
https://github.com/apache/cloudstack/blob/20306d612928712e5354bad57691b5fe4e1f59a9/server/src/main/java/com/cloud/projects/ProjectManagerImpl.java#L266
```
//Create an account associated with the project
StringBuilder acctNm = new StringBuilder("PrjAcct-");
acctNm.append(name).append("-").append(ownerFinal.getDomainId());
Account projectAccount =
_accountMgr.createAccount(acctNm.toString(), Account.Type.PROJECT, null,
domainId, null, null, UUID.randomUUID().toString());
Project project = _projectDao.persist(new ProjectVO(name,
displayText, ownerFinal.getDomainId(), projectAccount.getId()));
//assign owner to the project
assignAccountToProject(project, ownerFinal.getId(),
ProjectAccount.Role.Admin,
Optional.ofNullable(finalUser).map(User::getId).orElse(null), null);
if (project != null) {
CallContext.current().setEventDetails("Project id=" +
project.getId());
CallContext.current().putContextParameter(Project.class,
project.getUuid());
}
```
Then, a subsequent account is created then added to the project and set as
"Domain Admin". Within the account is the kubeadmin user. This user makes API
calls to setup the nginx ingress controller like shown above. The API call
results in an empty response.
Changing the "PrjAcct-" role from "RO Admin" to "Domain Admin" somehow
allows the kubeadmin user the access it needs to "see" the resources and
interact with them.
So there seems to be something wrong with project accounts accessing the
resources that are owned by the "PriAcct-" RO Admin account or the account is
being created with insufficient access.
Things we noted while troubleshooting:
- All resources created in the project are owned by the "PrjAcct-" account
- The "PriAcct-" account has type = 5 (RO Admin) and role_id = NULL in
cloud.account
- API calls the kubeadm user made during nginx ingress install & delete:
```
assignToLoadBalancerRule
associateIpAddress
deleteFirewallRule
deleteLoadBalancerRule
disassociateIpAddress
listFirewallRules
listLoadBalancerRules
listNetworks
listVirtualMachines
queryAsyncJobResult
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7032: Allow users to inform timezones on APIs that have the date parameter
blueorangutan commented on PR #7032: URL: https://github.com/apache/cloudstack/pull/7032#issuecomment-1372878217 Trillian test result (tid-5756) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48886 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7032-t5756-kvm-centos7.zip Smoke tests completed. 105 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 813.36 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] boring-cyborg[bot] commented on issue #7062: Secondary Storage System VM keeps crashing
boring-cyborg[bot] commented on issue #7062: URL: https://github.com/apache/cloudstack/issues/7062#issuecomment-1372841103 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Atiqul-Islam opened a new issue, #7062: Secondary Storage System VM keeps crashing
Atiqul-Islam opened a new issue, #7062:
URL: https://github.com/apache/cloudstack/issues/7062
Issue Type
```
Bug Report
```
Component
```
Secondary Storage
```
Zone Type
```
Basic
```
Operating System
```
Ubuntu 22.04
System VM Template
```
http://download.cloudstack.org/systemvm/4.16/systemvmtemplate-4.16.0-kvm.qcow2.bz2
```
Behavior:
I am trying to setup cloudstack. For secondary storage the system VM keeps
crashing.
Error
```
2023-01-05 13:25:49,632 INFO [c.c.v.VirtualMachineManagerImpl]
(Work-Job-Executor-86:ctx-1e6adfd7 job-4/job-110 ctx-2a159388) (logid:d99cbd34)
Unable to start VM on Host {"id": "1", "name": "cstack-manager", "uuid":
"0950fd0c-d5b3-4c63-9778-cca3fe80458c", "type"="Routing"} due to unsupported
configuration: VNC password is 22 characters long, only 8 permitted
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7024: server: correctly list suitable hosts for migration with uefi capability
blueorangutan commented on PR #7024: URL: https://github.com/apache/cloudstack/pull/7024#issuecomment-1372839324 Trillian test result (tid-5754) Environment: xcpng82 (x2), Advanced Networking with Mgmt server r8 Total time taken: 47398 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7024-t5754-xcpng82.zip Smoke tests completed. 101 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch main updated: Allow creating atmost 1 physical network with null tag (#6781)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 20306d6129 Allow creating atmost 1 physical network with null tag
(#6781)
20306d6129 is described below
commit 20306d612928712e5354bad57691b5fe4e1f59a9
Author: Sina Kashipazha
AuthorDate: Thu Jan 5 20:36:31 2023 +
Allow creating atmost 1 physical network with null tag (#6781)
---
.../java/com/cloud/network/dao/NetworkDaoImpl.java | 2 +-
.../configuration/ConfigurationManagerImpl.java| 43 ++-
.../java/com/cloud/network/NetworkModelImpl.java | 37 +-
.../java/com/cloud/network/NetworkServiceImpl.java | 73 ++--
.../test_multiple_physical_network_creation.py | 405 +
tools/marvin/marvin/lib/base.py| 10 +-
6 files changed, 509 insertions(+), 61 deletions(-)
diff --git
a/engine/schema/src/main/java/com/cloud/network/dao/NetworkDaoImpl.java
b/engine/schema/src/main/java/com/cloud/network/dao/NetworkDaoImpl.java
index 5b759c5092..502ddfa7a7 100644
--- a/engine/schema/src/main/java/com/cloud/network/dao/NetworkDaoImpl.java
+++ b/engine/schema/src/main/java/com/cloud/network/dao/NetworkDaoImpl.java
@@ -129,7 +129,7 @@ public class NetworkDaoImpl extends
GenericDaoBaseimplements Ne
AllFieldsSearch.and("account",
AllFieldsSearch.entity().getAccountId(), Op.EQ);
AllFieldsSearch.and("related", AllFieldsSearch.entity().getRelated(),
Op.EQ);
AllFieldsSearch.and("guestType",
AllFieldsSearch.entity().getGuestType(), Op.EQ);
-AllFieldsSearch.and("physicalNetwork",
AllFieldsSearch.entity().getPhysicalNetworkId(), Op.EQ);
+AllFieldsSearch.and("physicalNetworkId",
AllFieldsSearch.entity().getPhysicalNetworkId(), Op.EQ);
AllFieldsSearch.and("broadcastUri",
AllFieldsSearch.entity().getBroadcastUri(), Op.EQ);
AllFieldsSearch.and("vpcId", AllFieldsSearch.entity().getVpcId(),
Op.EQ);
AllFieldsSearch.and("aclId",
AllFieldsSearch.entity().getNetworkACLId(), Op.EQ);
diff --git
a/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
b/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
index 7fa764d2f2..0edc96acf4 100644
--- a/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
+++ b/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
@@ -6720,19 +6720,10 @@ public class ConfigurationManagerImpl extends
ManagerBase implements Configurati
final Boolean sourceNatSupported = cmd.getSourceNatSupported();
final List pNtwkTags = new ArrayList();
boolean checkForTags = false;
+boolean allowNullTag = false;
if (zone != null) {
-final List pNtwks =
_physicalNetworkDao.listByZoneAndTrafficType(zoneId, TrafficType.Guest);
-if (pNtwks.size() > 1) {
-checkForTags = true;
-// go through tags
-for (final PhysicalNetworkVO pNtwk : pNtwks) {
-final List pNtwkTag = pNtwk.getTags();
-if (pNtwkTag == null || pNtwkTag.isEmpty()) {
-throw new CloudRuntimeException("Tags are not defined
for physical network in the zone id=" + zoneId);
-}
-pNtwkTags.addAll(pNtwkTag);
-}
-}
+allowNullTag = allowNetworkOfferingWithNullTag(zoneId, pNtwkTags);
+checkForTags = !pNtwkTags.isEmpty() || allowNullTag;
}
// filter by supported services
@@ -6762,10 +6753,8 @@ public class ConfigurationManagerImpl extends
ManagerBase implements Configurati
boolean addOffering = true;
List checkForProviders = new ArrayList();
-if (checkForTags) {
-if (!pNtwkTags.contains(offering.getTags())) {
-continue;
-}
+if (checkForTags && ! checkNetworkOfferingTags(pNtwkTags,
allowNullTag, offering.getTags())) {
+continue;
}
if (listBySupportedServices) {
@@ -6815,6 +6804,28 @@ public class ConfigurationManagerImpl extends
ManagerBase implements Configurati
}
}
+private boolean allowNetworkOfferingWithNullTag(Long zoneId, List
allPhysicalNetworkTags) {
+boolean allowNullTag = false;
+final List physicalNetworks =
_physicalNetworkDao.listByZoneAndTrafficType(zoneId, TrafficType.Guest);
+for (final PhysicalNetworkVO physicalNetwork : physicalNetworks) {
+final List physicalNetworkTags = physicalNetwork.getTags();
+if (CollectionUtils.isEmpty(physicalNetworkTags)) {
+if (!allowNullTag) {
+allowNullTag = true;
+} else {
[GitHub] [cloudstack] DaanHoogland merged pull request #6781: Allow creating atmost 1 physical network with null tag
DaanHoogland merged PR #6781: URL: https://github.com/apache/cloudstack/pull/6781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #5797: Improve global settings UI to be more intuitive/logical
DaanHoogland commented on code in PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#discussion_r1062344189
##
api/src/main/java/com/cloud/server/ManagementService.java:
##
@@ -102,6 +104,13 @@ public interface ManagementService {
*/
Pair, Integer>
searchForConfigurations(ListCfgsByCmd c);
+/**
+ * returns the the configuration groups
+ *
+ * @return list of configuration groups
+ */
+Pair, Integer>
listConfigurationGroups(ListCfgGroupsByCmd cmd);
Review Comment:
Any reason this would not suffice?
```suggestion
Pair, Integer>
listConfigurationGroups(ListCfgGroupsByCmd cmd);
```
##
api/src/main/java/org/apache/cloudstack/api/command/admin/config/ListCfgGroupsByCmd.java:
##
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.config;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.BaseListCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.ConfigurationGroupResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.config.ConfigurationGroup;
+import org.apache.log4j.Logger;
+
+import com.cloud.utils.Pair;
+
+@APICommand(name = ListCfgGroupsByCmd.APINAME, description = "Lists all
configuration groups (primarily used for UI).", responseObject =
ConfigurationGroupResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
since = "4.18.0")
+public class ListCfgGroupsByCmd extends BaseListCmd {
+public static final Logger s_logger =
Logger.getLogger(ListCfgGroupsByCmd.class.getName());
+
+public static final String APINAME = "listConfigurationGroups";
+
+// ///
+// // API parameters /
+// ///
+
+@Parameter(name = ApiConstants.GROUP, type = CommandType.STRING,
description = "lists configuration group by group name")
+private String groupName;
+
+// ///
+// / Accessors ///
+// ///
+
+public String getGroupName() {
+return groupName;
+}
+
+// ///
+// / API Implementation///
+// ///
+
+@Override
+public String getCommandName() {
+return APINAME.toLowerCase() + BaseCmd.RESPONSE_SUFFIX;
+}
+
+@Override
+public void execute() {
+Pair, Integer> result =
_mgr.listConfigurationGroups(this);
Review Comment:
```suggestion
Pair, Integer> result =
_mgr.listConfigurationGroups(this);
```
?
##
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/ExtensionRegistry.java:
##
@@ -136,14 +136,17 @@ public ConfigKey[] getConfigKeys() {
List> result = new ArrayList>();
if (orderConfigKey != null && orderConfigKeyObj == null) {
-orderConfigKeyObj = new ConfigKey("Advanced",
String.class, orderConfigKey, orderConfigDefault, "The order of precedence for
the extensions", false);
+orderConfigKeyObj = new ConfigKey(String.class,
orderConfigKey, "Advanced", orderConfigDefault, "The order of precedence for
the extensions", false, ConfigKey.Scope.Global, null, null, null, null, null,
ConfigKey.Kind.Order, orderConfigDefault);
Review Comment:
```suggestion
orderConfigKeyObj = new ConfigKey<>(String.class,
orderConfigKey, "Advanced", orderConfigDefault, "The order of precedence for
the extensions", false, ConfigKey.Scope.Global, null, null, null, null, null,
ConfigKey.Kind.Order, orderConfigDefault);
```
##
[GitHub] [cloudstack] blueorangutan commented on pull request #6938: Create API to reassign volume
blueorangutan commented on PR #6938: URL: https://github.com/apache/cloudstack/pull/6938#issuecomment-1372674982 Trillian test result (tid-5755) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39953 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6938-t5755-kvm-centos7.zip Smoke tests completed. 106 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6840: infra: edge zones
sonarcloud[bot] commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1372673284 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6840) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6840=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6840=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6840=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6840=new_coverage=list) [24.3% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6840=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6840=new_duplicated_lines_density=list) [3.3% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6840=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6840: infra: edge zones
blueorangutan commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1372665667 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
blueorangutan commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1372664025 Trillian test result (tid-5753) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41234 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t5753-kvm-centos7.zip Smoke tests completed. 101 look OK, 5 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_primary_storage_disabled_host | `Error` | 0.78 | test_primary_storage.py test_01_primary_storage_nfs | `Error` | 0.15 | test_primary_storage.py ContextSuite context=TestStorageTags>:setup | `Error` | 0.26 | test_primary_storage.py test_01_non_strict_host_anti_affinity | `Failure` | 114.00 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 81.23 | test_nonstrict_affinity_group.py test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 35.13 | test_kubernetes_clusters.py test_07_deploy_kubernetes_ha_cluster | `Failure` | 58.64 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 41.16 | test_kubernetes_clusters.py test_09_delete_kubernetes_ha_cluster | `Failure` | 36.06 | test_kubernetes_clusters.py ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 120.03 | test_kubernetes_clusters.py test_01_secure_vm_migration | `Error` | 158.76 | test_vm_life_cycle.py test_02_unsecure_vm_migration | `Error` | 268.32 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 136.88 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 43.94 | test_vm_life_cycle.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 304.86 | test_hostha_kvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6979: Guest os mappings improvements
weizhouapache commented on code in PR #6979:
URL: https://github.com/apache/cloudstack/pull/6979#discussion_r1062822604
##
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/ClusterMO.java:
##
@@ -69,7 +69,7 @@
//
public class ClusterMO extends BaseMO implements VmwareHypervisorHost {
private static final Logger s_logger = Logger.getLogger(ClusterMO.class);
-private ManagedObjectReference _environmentBrowser = null;
+public ManagedObjectReference _environmentBrowser = null;
Review Comment:
maybe protected is enough.
##
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCheckGuestOsMappingCommandWrapper.java:
##
@@ -0,0 +1,67 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.hypervisor.xenserver.resource.wrapper.xenbase;
+
+import java.util.Set;
+
+import org.apache.log4j.Logger;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CheckGuestOsMappingAnswer;
+import com.cloud.agent.api.CheckGuestOsMappingCommand;
+import com.cloud.hypervisor.xenserver.resource.CitrixResourceBase;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.xensource.xenapi.Connection;
+import com.xensource.xenapi.VM;
+
+@ResourceWrapper(handles = CheckGuestOsMappingCommand.class)
+public final class CitrixCheckGuestOsMappingCommandWrapper extends
CommandWrapper {
+
+private static final Logger s_logger =
Logger.getLogger(CitrixCheckGuestOsMappingCommandWrapper.class);
+
+@Override
+public Answer execute(final CheckGuestOsMappingCommand command, final
CitrixResourceBase citrixResourceBase) {
+final Connection conn = citrixResourceBase.getConnection();
+String guestOsName = command.getGuestOsName();
+String guestOsMappingName = command.getGuestOsHypervisorMappingName();
+try {
+s_logger.info("Checking guest os mapping name: " +
guestOsMappingName + " for the guest os: " + guestOsName + " in the
hypervisor");
+final Set vms = VM.getAll(conn);
+if (vms == null || vms.isEmpty()) {
+return new CheckGuestOsMappingAnswer(command, "Unable to match
guest os mapping name: " + guestOsMappingName + " in the hypervisor");
+}
+for (VM vm : vms) {
+if (vm != null && vm.getIsATemplate(conn) &&
guestOsMappingName.equalsIgnoreCase(vm.getNameLabel(conn))) {
+if (guestOsName.equalsIgnoreCase(vm.getNameLabel(conn))) {
+// Exact matching may fail, try with regex?
Review Comment:
is this a TODO ?
##
api/src/main/java/org/apache/cloudstack/api/response/HypervisorGuestOsNamesResponse.java:
##
@@ -0,0 +1,76 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.response;
+
+import java.util.List;
+
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseResponse;
+
+import com.cloud.serializer.Param;
+import com.google.gson.annotations.SerializedName;
+
+public class HypervisorGuestOsNamesResponse extends BaseResponse {
+@SerializedName(ApiConstants.HYPERVISOR)
+@Param(description = "the hypervisor")
+private String hypervisor;
+
+@SerializedName(ApiConstants.HYPERVISOR_VERSION)
+@Param(description = "version of the hypervisor for guest os names")
+
[cloudstack-documentation] branch main updated: Configurable MTU for VR (#279)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/main by this push: new da274aa Configurable MTU for VR (#279) da274aa is described below commit da274aa1b6aaa4e93601cb6fa8dbeb08511e1b16 Author: Pearl Dsilva AuthorDate: Thu Jan 5 14:10:25 2023 -0500 Configurable MTU for VR (#279) Co-authored-by: Abhishek Kumar --- .../adminguide/networking/advanced_zone_config.rst | 29 -- .../networking/virtual_private_cloud_config.rst| 10 +--- source/installguide/configuration.rst | 3 +++ 3 files changed, 32 insertions(+), 10 deletions(-) diff --git a/source/adminguide/networking/advanced_zone_config.rst b/source/adminguide/networking/advanced_zone_config.rst index db4be0d..e7937b3 100644 --- a/source/adminguide/networking/advanced_zone_config.rst +++ b/source/adminguide/networking/advanced_zone_config.rst @@ -49,6 +49,14 @@ configure the base guest network: - **Network offering**: If the administrator has configured multiple network offerings, select the one you want to use for this network + - **Public MTU**: The MTU that will be configured on the public interfaces + of the network's VR. + **NOTE:** This will not be considered for VPC network tiers, as the + public MTU defined at the VPC network creation level will be considered + + - **Private MTU**: The MTU that will configured on the private interface(s) + of the network's VR + - **External Id**: ID of the network in an external system. - **Gateway**: The gateway that the guests instances will use. @@ -68,8 +76,8 @@ configure the base guest network: #. Click OK. .. note:: - In security groups-enabled Advanced zones and Basic zones, creation of - VPC and isolated networks are not supported. + * In security groups-enabled Advanced zones and Basic zones, creation of VPC and isolated networks are not supported. + * MTU options will be shown in the UI and considered only when zone configuration - `allow.end.users.to.specify.vr.mtu` is set to true. Maximum allowed values for public and private MTU can be controlled by zone-level configurations, `vr.public.interface.max.mtu` and `vr.private.interface.max.mtu` respectively. Configure Public Traffic in an Advanced Zone @@ -141,6 +149,12 @@ Configuring a Shared Guest Network - **Network Offering**: If the administrator has configured multiple network offerings, select the one you want to use for this network. + + - **Public MTU**: The MTU that will be configured on the public interfaces + of the network's VR. This MTU will considered for redundant VRs + + - **Private MTU**: The MTU that will configured on the private interface(s) + of the network's VR - **Associated Network**: The L2 or Isolated network this network is associated to. This network will use same VLAN as associated network. @@ -172,11 +186,12 @@ Configuring a Shared Guest Network #. Click OK to confirm. .. note:: - End users (not administrator) can only use the network - offerings with specifyvlan is false. Please create a network offering - with specifyvlan is false to enable this for end users. See - `“Creating a New Network Offering” - `_. + * End users (not administrator) can only use the network +offerings with specifyvlan is false. Please create a network offering +with specifyvlan is false to enable this for end users. See +`“Creating a New Network Offering” +`_. + * MTU options will be shown in the UI and considered only when zone configuration - `allow.end.users.to.specify.vr.mtu` is set to true. Maximum allowed values for public and private MTU can be controlled by zone-level configurations, `vr.public.interface.max.mtu` and `vr.private.interface.max.mtu` respectively. .. |addguestnetwork.png| image:: /_static/images/add-guest-network.png diff --git a/source/adminguide/networking/virtual_private_cloud_config.rst b/source/adminguide/networking/virtual_private_cloud_config.rst index d927746..d274717 100644 --- a/source/adminguide/networking/virtual_private_cloud_config.rst +++ b/source/adminguide/networking/virtual_private_cloud_config.rst @@ -215,11 +215,15 @@ addresses in the form of a Classless Inter-Domain Routing (CIDR) block. - **IPv6 DNS**: A set of custom IPv6 DNS that will be used by this VPC. If not provided then IPv6 DNS specified for the zone will be used. Available only when the selected VPC offering is IPv6 enabled and supports DNS service. + - **Public MTU**: The MTU to be configured on the public interfaces of the + VPC network's VR + #. Click OK. -.. note:: - In security groups-enabled Advanced zones and Basic
[GitHub] [cloudstack] blueorangutan commented on pull request #6840: infra: edge zones
blueorangutan commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1372618722 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6840: infra: edge zones
shwstppr commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1372617805 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6840: infra: edge zones
blueorangutan commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1372609874 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6840: infra: edge zones
shwstppr commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1372609442 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7052: Allow domain admins to inform tags when creating offerings
sonarcloud[bot] commented on PR #7052: URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372480452 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7052) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7052=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7052=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7052=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7052=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7052=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7052=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7052=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7052=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7052=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7052=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7052=false=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7052=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7052=new_coverage=list) [1.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7052=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7052=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7052=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!
github-actions[bot] commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1372469079 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7004: The 'LSI Logic Parallel' controller is not supported on Windows 10
weizhouapache commented on issue #7004: URL: https://github.com/apache/cloudstack/issues/7004#issuecomment-1372431962 user needs to upgrade to 4.16.1.0 and above which includes #5910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7052: Allow domain admins to inform tags when creating offerings
weizhouapache commented on PR #7052: URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372410568 > > > > @JoaoJandre please have a look at the errors with Simulator CI (ignore the errors with test_tags ) > > > > > > > > > The only error without test_tags was an insufficient capacity exception in a VM deploy and it doesn't look correlated with this PR. > > > > > > @JoaoJandre there is another error test_affinity_groups_projects, which may or not be related to your change. > > That is the one I was talking about, the test_affinity_groups_projects test's error doesn't look correlated with this PR. OK. closed/reopened this PR to rekick the simulator CI. let's see -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #7052: Allow domain admins to inform tags when creating offerings
weizhouapache closed pull request #7052: Allow domain admins to inform tags when creating offerings URL: https://github.com/apache/cloudstack/pull/7052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7059: guestos: add el9 distros
codecov[bot] commented on PR #7059: URL: https://github.com/apache/cloudstack/pull/7059#issuecomment-1372398700 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7059?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#7059](https://codecov.io/gh/apache/cloudstack/pull/7059?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b4c7fb1) into [main](https://codecov.io/gh/apache/cloudstack/commit/16ec8105e4ac556d233b2073e2acc4a9a396b4a7?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (16ec810) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## main#7059 +/- ## = Coverage 11.58% 11.58% Complexity 7550 7550 = Files 2494 2494 Lines247073 247073 Branches 3861438614 = Hits 2863328633 Misses 214695 214695 Partials 3745 3745 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7058: UI: fix cannot list lb rules if cidr_list is NULL
codecov[bot] commented on PR #7058: URL: https://github.com/apache/cloudstack/pull/7058#issuecomment-1372393894 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7058?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#7058](https://codecov.io/gh/apache/cloudstack/pull/7058?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (bee009f) into [main](https://codecov.io/gh/apache/cloudstack/commit/16ec8105e4ac556d233b2073e2acc4a9a396b4a7?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (16ec810) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## main#7058 +/- ## = Coverage 11.58% 11.58% Complexity 7550 7550 = Files 2494 2494 Lines247073 247073 Branches 3861438614 = Hits 2863328633 Misses 214695 214695 Partials 3745 3745 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7061: Rollback of changes with errors during the VM assign
weizhouapache commented on PR #7061:
URL: https://github.com/apache/cloudstack/pull/7061#issuecomment-1372376990
> > lots of refactoring. I am not sure if the code is good or not. Maybe
others can check.
> > @stephankruggg can you point out the key point of your change ?
>
> @weizhouapache, when assigning a VM to another account
(`assignVirtualMachine API`), if a network error happens during the process, no
rollback is executed; thus, leaving the DB in an inconsistent state. This PR
fixes this by processing all steps to change the ownership of a VM inside the
transaction.
>
> The refactoring is intended to make the code more testable, readable, and
easier to maintain.
@stephankruggg
thanks.
it seems the key block is
```
Transaction.execute(new TransactionCallbackNoReturn() {
@Override
public void doInTransactionWithoutResult(TransactionStatus
status) {
executeStepsToChangeOwnershipOfVm(cmd, caller, oldAccount,
newAccount, vm, offering, volumes, template, domainId);
}
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7052: Allow domain admins to inform tags when creating offerings
JoaoJandre commented on PR #7052: URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372374425 > > > @JoaoJandre what's the goal of this enhancement ? > > > > > > ACS only allows root admins to enter tags during the creation of service, disk, and network offerings; however, in private cloud environments, domain admin accounts may have autonomy and knowledge of the infrastructure, being able to direct resources according to their needs. > > To enable this behavior, a new account-level setting (`allow.domain.admins.to.create.offerings.with.tags`) has been created. When disabled (default), the previous behavior is maintained; when enabled, the domain admin account can enter tags when creating disk and service offerings. > > @JoaoJandre for domain admins, how do they get the list of available tags ? @weizhouapache the default domain admin role has permission to list storage and host tags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7052: Allow domain admins to inform tags when creating offerings
JoaoJandre commented on PR #7052: URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372363589 > > > @JoaoJandre please have a look at the errors with Simulator CI (ignore the errors with test_tags ) > > > > > > The only error without test_tags was an insufficient capacity exception in a VM deploy and it doesn't look correlated with this PR. > > @JoaoJandre there is another error test_affinity_groups_projects, which may or not be related to your change. That is the one I was talking about, the test_affinity_groups_projects test's error doesn't look correlated with this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] stephankruggg commented on pull request #7061: Rollback of changes with errors during the VM assign
stephankruggg commented on PR #7061: URL: https://github.com/apache/cloudstack/pull/7061#issuecomment-1372338282 > lots of refactoring. I am not sure if the code is good or not. Maybe others can check. > > @stephankruggg can you point out the key point of your change ? @weizhouapache, when assigning a VM to another account (`assignVirtualMachine API`), if a network error happens during the process, no rollback is executed; thus, leaving the DB in an inconsistent state. This PR fixes this by processing all steps to change the ownership of a VM inside the transaction. The refactoring is intended to make the code more testable, readable, and easier to maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #6698: Dedication of public IP ranges broken after upgrade to 4.17.0.1
weizhouapache commented on issue #6698: URL: https://github.com/apache/cloudstack/issues/6698#issuecomment-1372321916 @Hudratronium it is normal you cannot find related records in domain_vlan_map or account_vlan_map. can you share the result of the following mysql query ? select public_ip_address,state,forsystemvms from user_ip_address join vlan on user_ip_address.vlan_db_id = vlan.id and vlan.uuid='adc15744-9b35-4bea-81f0-1fdbd5b544f3'; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7061: Rollback of changes with errors during the VM assign
sonarcloud[bot] commented on PR #7061: URL: https://github.com/apache/cloudstack/pull/7061#issuecomment-1372303536 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7061) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7061=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7061=false=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7061=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7061=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7061=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7061=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7061=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7061=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7061=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7061=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7061=false=CODE_SMELL) [19 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7061=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7061=new_coverage=list) [75.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7061=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7061=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7061=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7061: Rollback of changes with errors during the VM assign
weizhouapache commented on code in PR #7061:
URL: https://github.com/apache/cloudstack/pull/7061#discussion_r1062529433
##
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##
@@ -7052,525 +7051,779 @@ public VirtualMachine
migrateVirtualMachineWithVolume(Long vmId, Host destinatio
@DB
@Override
@ActionEvent(eventType = EventTypes.EVENT_VM_MOVE, eventDescription =
"move VM to another user", async = false)
-public UserVm moveVMToUser(final AssignVMCmd cmd) throws
ResourceAllocationException, ConcurrentOperationException,
ResourceUnavailableException, InsufficientCapacityException {
-// VERIFICATIONS and VALIDATIONS
-
-// VV 1: verify the two users
+public UserVm moveVmToUser(final AssignVMCmd cmd) throws
ResourceAllocationException, InsufficientCapacityException {
Account caller = CallContext.current().getCallingAccount();
-if (!_accountMgr.isRootAdmin(caller.getId())
-&& !_accountMgr.isDomainAdmin(caller.getId())) { // only
-// root
-// admin
-// can
-// assign
-// VMs
-throw new InvalidParameterValueException("Only domain admins are
allowed to assign VMs and not " + caller.getType());
-}
-
-// get and check the valid VM
-final UserVmVO vm = _vmDao.findById(cmd.getVmId());
-if (vm == null) {
-throw new InvalidParameterValueException("There is no vm by that
id " + cmd.getVmId());
-} else if (vm.getState() == State.Running) { // VV 3: check if vm is
-// running
-if (s_logger.isDebugEnabled()) {
-s_logger.debug("VM is Running, unable to move the vm " + vm);
-}
-InvalidParameterValueException ex = new
InvalidParameterValueException("VM is Running, unable to move the vm with
specified vmId");
-ex.addProxyObject(vm.getUuid(), "vmId");
-throw ex;
-}
-
-final Account oldAccount =
_accountService.getActiveAccountById(vm.getAccountId());
-if (oldAccount == null) {
-throw new InvalidParameterValueException("Invalid account for VM "
+ vm.getAccountId() + " in domain.");
-}
-final Account newAccount = _accountMgr.finalizeOwner(caller,
cmd.getAccountName(), cmd.getDomainId(), cmd.getProjectId());
-if (newAccount == null) {
-throw new InvalidParameterValueException("Invalid accountid=" +
cmd.getAccountName() + " in domain " + cmd.getDomainId());
+Long callerId = caller.getId();
+s_logger.trace(String.format("Verifying if caller [%s] is root or
domain admin.", caller));
+if (!_accountMgr.isRootAdmin(callerId) &&
!_accountMgr.isDomainAdmin(callerId)) {
+throw new InvalidParameterValueException(String.format("Only root
or domain admins are allowed to assign VMs. Caller [%s] is of type [%s].",
caller, caller.getType()));
}
-if (newAccount.getState() == Account.State.DISABLED) {
-throw new InvalidParameterValueException("The new account owner "
+ cmd.getAccountName() + " is disabled.");
-}
+Long vmId = cmd.getVmId();
+final UserVmVO vm = _vmDao.findById(vmId);
+validateIfVmExistsAndIsNotRunning(vm, vmId);
-if (cmd.getProjectId() != null && cmd.getDomainId() == null) {
+Long domainId = cmd.getDomainId();
+Long projectId = cmd.getProjectId();
+Long oldAccountId = vm.getAccountId();
+String newAccountName = cmd.getAccountName();
+final Account oldAccount =
_accountService.getActiveAccountById(oldAccountId);
+final Account newAccount = _accountMgr.finalizeOwner(caller,
newAccountName, domainId, projectId);
+validateAccountsAndCallerAccessToThem(caller, oldAccount, newAccount,
oldAccountId, newAccountName, domainId);
+
+s_logger.trace(String.format("Verifying if the provided domain ID [%s]
is valid.", domainId));
+if (projectId != null && domainId == null) {
throw new InvalidParameterValueException("Please provide a valid
domain ID; cannot assign VM to a project if domain ID is NULL.");
}
-//check caller has access to both the old and new account
-_accountMgr.checkAccess(caller, null, true, oldAccount);
-_accountMgr.checkAccess(caller, null, true, newAccount);
+validateIfVmHasNoRules(vm, vmId);
-// make sure the accounts are not same
-if (oldAccount.getAccountId() == newAccount.getAccountId()) {
-throw new InvalidParameterValueException("The new account is the
same as the old account. Account id =" + oldAccount.getAccountId());
+final List volumes = _volsDao.findByInstance(vmId);
+validateIfVolumesHaveNoSnapshots(volumes);
+
+final ServiceOfferingVO offering =
serviceOfferingDao.findByIdIncludingRemoved(vm.getId(),
vm.getServiceOfferingId());
[GitHub] [cloudstack] codecov[bot] commented on pull request #7061: Rollback of changes with errors during the VM assign
codecov[bot] commented on PR #7061: URL: https://github.com/apache/cloudstack/pull/7061#issuecomment-1372292184 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7061?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#7061](https://codecov.io/gh/apache/cloudstack/pull/7061?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (e9d1a84) into [main](https://codecov.io/gh/apache/cloudstack/commit/d0b34b75765d3f36b595f7f5659cdb282e67e3ce?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d0b34b7) will **increase** coverage by `0.12%`. > The diff coverage is `94.44%`. ```diff @@ Coverage Diff @@ ## main#7061 +/- ## + Coverage 11.58% 11.71% +0.12% - Complexity 7548 7634 +86 Files 2494 2494 Lines247065 247088 +23 Branches 3861338586 -27 + Hits 2862928948 +319 + Misses 214692 214403 -289 + Partials 3744 3737 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7061?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7061?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | `13.79% <94.44%> (+7.04%)` | :arrow_up: | | [...main/java/com/cloud/api/query/vo/UserVmJoinVO.java](https://codecov.io/gh/apache/cloudstack/pull/7061?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9xdWVyeS92by9Vc2VyVm1Kb2luVk8uamF2YQ==) | `8.57% <0.00%> (-0.13%)` | :arrow_down: | | [...ava/com/cloud/api/query/dao/UserVmJoinDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7061?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9xdWVyeS9kYW8vVXNlclZtSm9pbkRhb0ltcGwuamF2YQ==) | `3.18% <0.00%> (-0.02%)` | :arrow_down: | | [...m/cloud/api/query/dao/DomainRouterJoinDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7061?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9xdWVyeS9kYW8vRG9tYWluUm91dGVySm9pbkRhb0ltcGwuamF2YQ==) | `0.47% <0.00%> (-0.01%)` | :arrow_down: | | [...src/main/java/com/cloud/api/ApiResponseHelper.java](https://codecov.io/gh/apache/cloudstack/pull/7061?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9BcGlSZXNwb25zZUhlbHBlci5qYXZh) | `3.87% <0.00%> (-0.01%)` | :arrow_down: | | [...ava/com/cloud/api/query/vo/DomainRouterJoinVO.java](https://codecov.io/gh/apache/cloudstack/pull/7061?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9xdWVyeS92by9Eb21haW5Sb3V0ZXJKb2luVk8uamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...n/java/com/cloud/vm/VirtualMachineProfileImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7061?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2NvbXBvbmVudHMtYXBpL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1ZpcnR1YWxNYWNoaW5lUHJvZmlsZUltcGwuamF2YQ==) | `37.38% <0.00%> (+0.93%)` | :arrow_up: | | [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/7061?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `28.84% <0.00%> (+7.69%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7058: UI: fix cannot list lb rules if cidr_list is NULL
sonarcloud[bot] commented on PR #7058: URL: https://github.com/apache/cloudstack/pull/7058#issuecomment-1372239885 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7058) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7058=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7058=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7058=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7058=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7058=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7058=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7058=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7058=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7058=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7058=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7058=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7058=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7058=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7058=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7060: build(deps): bump json5, @vue/cli-plugin-unit-jest and @vue/cli-service in /ui
sonarcloud[bot] commented on PR #7060: URL: https://github.com/apache/cloudstack/pull/7060#issuecomment-1372234963 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7060) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7060=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7060=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7060=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7060=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7060=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7060=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7060=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7060=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7060=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7060=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7060=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7060=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7060=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7060=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7059: guestos: add el9 distros
sonarcloud[bot] commented on PR #7059: URL: https://github.com/apache/cloudstack/pull/7059#issuecomment-1372233349 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7059) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7059=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7059=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7059=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7059=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7059=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #6747: listNetworkOfferings api does not handle phyiscal network tags correctly
weizhouapache commented on issue #6747:
URL: https://github.com/apache/cloudstack/issues/6747#issuecomment-1372232214
> if (isTagged) {
> sc.addAnd("tags", SearchCriteria.Op.NNULL);
> } else {
> sc.addAnd("tags", SearchCriteria.Op.NULL);
> }
> }
@samapraku
this is fine. You may not notice the difference between `NNULL` and `NULL`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #6747: listNetworkOfferings api does not handle phyiscal network tags correctly
weizhouapache commented on issue #6747:
URL: https://github.com/apache/cloudstack/issues/6747#issuecomment-1372231206
@samapraku
I tried to reproduce the issue with latest main branch but failed.
both api/ui work for me.
```
(localcloud) > list networkofferings tags=test
zoneid=7c9769a1-ba70-4f3a-a976-5a6ae7d946bb state=Enabled filter=id,name,tags
{
"count": 1,
"networkoffering": [
{
"id": "3db2b279-db80-40c5-a013-c1b236194641",
"name": "test-tag",
"tags": "test"
}
]
}
```
can you share the results of your cmk commands ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] stephankruggg opened a new pull request, #7061: Rollback of changes with errors during the VM assign
stephankruggg opened a new pull request, #7061:
URL: https://github.com/apache/cloudstack/pull/7061
### Description
When assigning a VM to another account (`assignVirtualMachine API`), if a
network error happens during the process, no rollback is executed; thus,
leaving the DB in an inconsistent state.
This PR fixes this by processing all steps to change the ownership of a VM
inside the transaction. It also refactors code related to this procedure.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### How Has This Been Tested?
In a local lab, I created a VM and an account of user type. I then attempted
to assign the admin's VM to the user by using a network not accessible to the
user.
Before applying the changes, an error was raised, but the VM was listed as
belonging to the user.
After applying the changes, an error was raised, and the VM was listed as
belonging to the admin - no changes occurred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7060: build(deps): bump json5, @vue/cli-plugin-unit-jest and @vue/cli-service in /ui
codecov[bot] commented on PR #7060: URL: https://github.com/apache/cloudstack/pull/7060#issuecomment-1372214538 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7060?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#7060](https://codecov.io/gh/apache/cloudstack/pull/7060?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (dadb767) into [main](https://codecov.io/gh/apache/cloudstack/commit/c2b75f4c81cf0b2846da10de52b9dd66292bff36?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c2b75f4) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## main#7060 +/- ## = Coverage 11.58% 11.58% Complexity 7550 7550 = Files 2494 2494 Lines247073 247073 Branches 3861438614 = Hits 2863328633 - Misses 214695 214696+1 + Partials 3745 3744-1 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7060?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/7060?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `21.15% <0.00%> (-7.70%)` | :arrow_down: | | [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/7060?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `58.75% <0.00%> (+2.25%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6840: infra: edge zones
blueorangutan commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1372211642 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7057: server/UI: fix some issues with network offering details
codecov[bot] commented on PR #7057: URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1372206323 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7057?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#7057](https://codecov.io/gh/apache/cloudstack/pull/7057?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (bce6829) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/89d4c7537fde8092f99c0fc61f8a5e5921ea5733?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (89d4c75) will **decrease** coverage by `0.00%`. > The diff coverage is `0.00%`. ```diff @@ Coverage Diff @@ ## 4.17#7057 +/- ## - Coverage 10.36% 10.36% -0.01% + Complexity 6633 6629 -4 Files 2453 2453 Lines242386 242389 +3 Branches 3792837929 +1 - Hits 2513325125 -8 - Misses 214144 214156 +12 + Partials 3109 3108 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7057?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../cloud/configuration/ConfigurationManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7057?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbmZpZ3VyYXRpb24vQ29uZmlndXJhdGlvbk1hbmFnZXJJbXBsLmphdmE=) | `10.84% <0.00%> (-0.01%)` | :arrow_down: | | [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/7057?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `21.15% <0.00%> (-7.70%)` | :arrow_down: | | [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/7057?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `56.49% <0.00%> (-2.26%)` | :arrow_down: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7054: UI: support serviceofferingid when create vpc offering
codecov[bot] commented on PR #7054: URL: https://github.com/apache/cloudstack/pull/7054#issuecomment-1372190894 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7054?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#7054](https://codecov.io/gh/apache/cloudstack/pull/7054?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (7f84bf0) into [main](https://codecov.io/gh/apache/cloudstack/commit/16ec8105e4ac556d233b2073e2acc4a9a396b4a7?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (16ec810) will **decrease** coverage by `0.00%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## main#7054 +/- ## - Coverage 11.58% 11.58% -0.01% + Complexity 7550 7548 -2 Files 2494 2494 Lines247073 247073 Branches 3861438614 - Hits 2863328629 -4 - Misses 214695 214700 +5 + Partials 3745 3744 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7054?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/7054?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `21.15% <0.00%> (-7.70%)` | :arrow_down: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] soreana commented on issue #6999: Security group fields in the listVirtualmachines API call's response doesn't change
soreana commented on issue #6999: URL: https://github.com/apache/cloudstack/issues/6999#issuecomment-1372189062 @weizhouapache I'm busy with the HA Proxy customisation PR. Couldn't find a time to look into this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7052: Allow domain admins to inform tags when creating offerings
weizhouapache commented on PR #7052: URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372162064 > > @JoaoJandre what's the goal of this enhancement ? > > ACS only allows root admins to enter tags during the creation of service, disk, and network offerings; however, in private cloud environments, domain admin accounts may have autonomy and knowledge of the infrastructure, being able to direct resources according to their needs. > > To enable this behavior, a new account-level setting (`allow.domain.admins.to.create.offerings.with.tags`) has been created. When disabled (default), the previous behavior is maintained; when enabled, the domain admin account can enter tags when creating disk and service offerings. @JoaoJandre for domain admins, how do they get the list of available tags ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6840: infra: edge zones
blueorangutan commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1372161001 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6840: infra: edge zones
shwstppr commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1372160325 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch dependabot/npm_and_yarn/ui/json5-and-json5-and-vue/cli-plugin-unit-jest-and-vue/cli-service-2.2.3 created (now dadb76782d)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/ui/json5-and-json5-and-vue/cli-plugin-unit-jest-and-vue/cli-service-2.2.3 in repository https://gitbox.apache.org/repos/asf/cloudstack.git at dadb76782d build(deps): bump json5, @vue/cli-plugin-unit-jest and @vue/cli-service No new revisions were added by this update.
[GitHub] [cloudstack] dependabot[bot] opened a new pull request, #7060: build(deps): bump json5, @vue/cli-plugin-unit-jest and @vue/cli-service in /ui
dependabot[bot] opened a new pull request, #7060: URL: https://github.com/apache/cloudstack/pull/7060 Bumps [json5](https://github.com/json5/json5) to 2.2.3 and updates ancestor dependencies [json5](https://github.com/json5/json5), [json5](https://github.com/json5/json5), [@vue/cli-plugin-unit-jest](https://github.com/vuejs/vue-cli/tree/HEAD/packages/@vue/cli-plugin-unit-jest) and [@vue/cli-service](https://github.com/vuejs/vue-cli/tree/HEAD/packages/@vue/cli-service). These dependencies need to be updated together. Updates `json5` from 2.2.1 to 2.2.3 Release notes Sourced from https://github.com/json5/json5/releases;>json5's releases. v2.2.3 Fix: json5@2.2.3 is now the 'latest' release according to npm instead of v1.0.2. (https://github-redirect.dependabot.com/json5/json5/issues/299;>#299) v2.2.2 Fix: Properties with the name __proto__ are added to objects and arrays. (https://github-redirect.dependabot.com/json5/json5/issues/199;>#199) This also fixes a prototype pollution vulnerability reported by Jonathan Gregson! (https://github-redirect.dependabot.com/json5/json5/issues/295;>#295). Changelog Sourced from https://github.com/json5/json5/blob/main/CHANGELOG.md;>json5's changelog. v2.2.3 [https://github.com/json5/json5/tree/v2.2.3;>code, https://github.com/json5/json5/compare/v2.2.2...v2.2.3;>diff] Fix: json5@2.2.3 is now the 'latest' release according to npm instead of v1.0.2. (https://github-redirect.dependabot.com/json5/json5/issues/299;>#299) v2.2.2 [https://github.com/json5/json5/tree/v2.2.2;>code, https://github.com/json5/json5/compare/v2.2.1...v2.2.2;>diff] Fix: Properties with the name __proto__ are added to objects and arrays. (https://github-redirect.dependabot.com/json5/json5/issues/199;>#199) This also fixes a prototype pollution vulnerability reported by Jonathan Gregson! (https://github-redirect.dependabot.com/json5/json5/issues/295;>#295). Commits https://github.com/json5/json5/commit/c3a75242772a5026a49c4017a16d9b3543b62776;>c3a7524 2.2.3 https://github.com/json5/json5/commit/94fd06d82eeed225fa172f6fb2ca27375cbd2e39;>94fd06d docs: update CHANGELOG for v2.2.3 https://github.com/json5/json5/commit/3b8cebf0c474a8b20c78bd75c89cca0c4dce84ce;>3b8cebf docs(security): use GitHub security advisories https://github.com/json5/json5/commit/f0fd9e194dde282caff114a110f4fac635f3a62c;>f0fd9e1 docs: publish a security policy https://github.com/json5/json5/commit/6a91a05fffeda16ff6b3b5008b6b340d42d31ec0;>6a91a05 docs(template): bug - bug report https://github.com/json5/json5/commit/14f8cb186e8abdfaccf6527171da7b1224374650;>14f8cb1 2.2.2 https://github.com/json5/json5/commit/10cc7ca9169b59c5e0f5afc03dbd870cd06bcc46;>10cc7ca docs: update CHANGELOG for v2.2.2 https://github.com/json5/json5/commit/7774c1097993bc3ce9f0ac4b722a32bf7d6871c8;>7774c10 fix: add proto to objects and arrays https://github.com/json5/json5/commit/edde30abd8b22facf2c06c72586b9f6edf12700d;>edde30a Readme: slight tweak to intro https://github.com/json5/json5/commit/97286f8bd542c89dcee096bc05dd28ed2dfc1e16;>97286f8 Improve example in readme Additional commits viewable in https://github.com/json5/json5/compare/v2.2.1...v2.2.3;>compare view Updates `json5` from 1.0.1 to 2.2.3 Release notes Sourced from https://github.com/json5/json5/releases;>json5's releases. v2.2.3 Fix: json5@2.2.3 is now the 'latest' release according to npm instead of v1.0.2. (https://github-redirect.dependabot.com/json5/json5/issues/299;>#299) v2.2.2 Fix: Properties with the name __proto__ are added to objects and arrays. (https://github-redirect.dependabot.com/json5/json5/issues/199;>#199) This also fixes a prototype pollution vulnerability reported by Jonathan Gregson! (https://github-redirect.dependabot.com/json5/json5/issues/295;>#295). Changelog Sourced from https://github.com/json5/json5/blob/main/CHANGELOG.md;>json5's changelog. v2.2.3 [https://github.com/json5/json5/tree/v2.2.3;>code, https://github.com/json5/json5/compare/v2.2.2...v2.2.3;>diff] Fix: json5@2.2.3 is now the 'latest' release according to npm instead of v1.0.2. (https://github-redirect.dependabot.com/json5/json5/issues/299;>#299) v2.2.2 [https://github.com/json5/json5/tree/v2.2.2;>code, https://github.com/json5/json5/compare/v2.2.1...v2.2.2;>diff] Fix: Properties with the name __proto__ are added to objects and arrays. (https://github-redirect.dependabot.com/json5/json5/issues/199;>#199) This also fixes a prototype pollution vulnerability reported by Jonathan Gregson! (https://github-redirect.dependabot.com/json5/json5/issues/295;>#295). Commits https://github.com/json5/json5/commit/c3a75242772a5026a49c4017a16d9b3543b62776;>c3a7524 2.2.3
[GitHub] [cloudstack] weizhouapache commented on pull request #7052: Allow domain admins to inform tags when creating offerings
weizhouapache commented on PR #7052: URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372159292 > > @JoaoJandre please have a look at the errors with Simulator CI (ignore the errors with test_tags ) > > The only error without test_tags was an insufficient capacity exception in a VM deploy and it doesn't look correlated with this PR. @JoaoJandre there is another error test_affinity_groups_projects, which may or not be related to your change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr opened a new pull request, #7059: guestos: add el9 distros
shwstppr opened a new pull request, #7059:
URL: https://github.com/apache/cloudstack/pull/7059
### Description
TBA
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6869: Support for parameter `cidrlist` added to the UI
weizhouapache commented on PR #6869: URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1372157954 @GutoVeronezi @JoaoJandre @stephankruggg Do you have QA engineer or mutually review/testing process ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch main updated: README: revert project logo and update README
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new c2b75f4c81 README: revert project logo and update README c2b75f4c81 is described below commit c2b75f4c81cf0b2846da10de52b9dd66292bff36 Author: Rohit Yadav AuthorDate: Thu Jan 5 17:59:08 2023 +0530 README: revert project logo and update README Happy New Year - this reverts project logo and updates README and the names of Github Actions badges used on README. Signed-off-by: Rohit Yadav --- .github/workflows/build.yml | 2 +- .github/workflows/rat.yml | 2 +- README.md | 9 + 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index af0b965fae..a1c3190a3e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -15,7 +15,7 @@ # specific language governing permissions and limitations # under the License. -name: Maven Build (noredist) +name: Build on: [push, pull_request] diff --git a/.github/workflows/rat.yml b/.github/workflows/rat.yml index 4206480eac..438d75bfcf 100644 --- a/.github/workflows/rat.yml +++ b/.github/workflows/rat.yml @@ -15,7 +15,7 @@ # specific language governing permissions and limitations # under the License. -name: RAT License Check +name: License Check on: [push, pull_request] diff --git a/README.md b/README.md index eec8ae98f1..e56857ed0c 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ -# Apache CloudStack [](https://github.com/apache/cloudstack/actions/workflows/build.yml) [](https://github.com/apache/cloudstack/actions/workflows/ui.yml) [](https://github.com/apache/cloudstac [...] +# Apache CloudStack [](https://github.com/apache/cloudstack/actions/workflows/build.yml) [](https://github.com/apache/cloudstack/actions/workflows/ui.yml) [](https://github.com/apache/cloudstack/actions/ [...] - + Apache CloudStack is open source software designed to deploy and manage large networks of virtual machines, as a highly available, highly scalable @@ -101,8 +101,9 @@ developer [page](https://cloudstack.apache.org/developers.html) for contributing ## Reporting Security Vulnerabilities If you've found an issue that you believe is a security vulnerability in a -released version of CloudStack, please report it to `secur...@cloudstack.apache.org` with details about the vulnerability, how it -might be exploited, and any additional information that might be useful. +released version of CloudStack, please report it to `secur...@apache.org` with +details about the vulnerability, how it might be exploited, and any additional +information that might be useful. For more details, please visit our security [page](http://cloudstack.apache.org/security.html).
[GitHub] [cloudstack] weizhouapache commented on issue #6133: CKS instance Info page display all Public IP's PNAT,FW and LB in same account.
weizhouapache commented on issue #6133: URL: https://github.com/apache/cloudstack/issues/6133#issuecomment-1372155466 @levindecaro I cannot reproduce the issue on latest main branch. fixed an issue with listing LB rules: #7058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7047: fix merge diff display
codecov[bot] commented on PR #7047: URL: https://github.com/apache/cloudstack/pull/7047#issuecomment-1372155263 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7047?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#7047](https://codecov.io/gh/apache/cloudstack/pull/7047?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f7fd631) into [main](https://codecov.io/gh/apache/cloudstack/commit/af59e76df6c9ad2b265cafb1b15195a89eafce9b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (af59e76) will **increase** coverage by `0.04%`. > The diff coverage is `27.41%`. ```diff @@ Coverage Diff @@ ## main#7047 +/- ## + Coverage 11.54% 11.58% +0.04% - Complexity 7509 7548 +39 Files 2494 2494 Lines246678 247073 +395 Branches 3853338614 +81 + Hits 2847628629 +153 - Misses 214521 214699 +178 - Partials 3681 3745 +64 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7047?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...estration/service/NetworkOrchestrationService.java](https://codecov.io/gh/apache/cloudstack/pull/7047?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9lbmdpbmUvb3JjaGVzdHJhdGlvbi9zZXJ2aWNlL05ldHdvcmtPcmNoZXN0cmF0aW9uU2VydmljZS5qYXZh) | `100.00% <ø> (ø)` | | | [...n/java/com/cloud/vm/VirtualMachineManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7047?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvdm0vVmlydHVhbE1hY2hpbmVNYW5hZ2VySW1wbC5qYXZh) | `5.89% <ø> (ø)` | | | [...n/java/com/cloud/network/dao/IPAddressDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7047?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9uZXR3b3JrL2Rhby9JUEFkZHJlc3NEYW9JbXBsLmphdmE=) | `30.83% <0.00%> (-0.50%)` | :arrow_down: | | [...ngine/schema/src/main/java/com/cloud/vm/NicVO.java](https://codecov.io/gh/apache/cloudstack/pull/7047?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9OaWNWTy5qYXZh) | `50.47% <0.00%> (-1.49%)` | :arrow_down: | | [...ema/src/main/java/com/cloud/vm/dao/NicDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7047?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9kYW8vTmljRGFvSW1wbC5qYXZh) | `23.38% <0.00%> (-0.97%)` | :arrow_down: | | [...bernetes/cluster/KubernetesClusterManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7047?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9pbnRlZ3JhdGlvbnMva3ViZXJuZXRlcy1zZXJ2aWNlL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2t1YmVybmV0ZXMvY2x1c3Rlci9LdWJlcm5ldGVzQ2x1c3Rlck1hbmFnZXJJbXBsLmphdmE=) | `0.00% <ø> (ø)` | | | [...src/main/java/com/cloud/api/ApiResponseHelper.java](https://codecov.io/gh/apache/cloudstack/pull/7047?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9BcGlSZXNwb25zZUhlbHBlci5qYXZh) | `3.87% <0.00%> (-0.01%)` | :arrow_down: | | [...com/cloud/api/query/dao/DataCenterJoinDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7047?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9xdWVyeS9kYW8vRGF0YUNlbnRlckpvaW5EYW9JbXBsLmphdmE=) | `1.85% <0.00%> (-0.11%)` | :arrow_down: | |
[GitHub] [cloudstack] weizhouapache commented on pull request #7058: UI: fix cannot list lb rules if cidr_list is NULL
weizhouapache commented on PR #7058: URL: https://github.com/apache/cloudstack/pull/7058#issuecomment-1372154682 @JoaoJandre this is a regression of #6869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7058: UI: fix cannot list lb rules if cidr_list is NULL
weizhouapache opened a new pull request, #7058:
URL: https://github.com/apache/cloudstack/pull/7058
### Description
This PR fixes an UI issue that LB rules cannot be listed for kubernetes
cluster.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7057: server/UI: fix some issues with network offering details
weizhouapache commented on code in PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#discussion_r1062406906
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -6408,7 +6408,9 @@ public NetworkOfferingVO doInTransaction(final
TransactionStatus status) {
detailsVO.add(new
NetworkOfferingDetailsVO(offering.getId(), Detail.internetProtocol,
String.valueOf(internetProtocol), true));
}
if (!detailsVO.isEmpty()) {
-networkOfferingDetailsDao.saveDetails(detailsVO);
Review Comment:
> @weizhouapache this is used while creating a new offering so will it
matter even if the code tries to delete existing details for the resourceId
(service offering is here)?
@shwstppr yes, there are some network offering details passed via API.
https://cloudstack.apache.org/api/apidocs-4.17/apis/createNetworkOffering.html
for example, the following details are not saved
Promiscuous mode
MAC address changes
Forged transmits
MAC learning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7052: Allow domain admins to inform tags when creating offerings
JoaoJandre commented on PR #7052: URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372138209 > @JoaoJandre what's the goal of this enhancement ? ACS only allows root admins to enter tags during the creation of service, disk, and network offerings; however, in private cloud environments, domain admin accounts may have autonomy and knowledge of the infrastructure, being able to direct resources according to their needs. To enable this behavior, a new account-level setting (`allow.domain.admins.to.create.offerings.with.tags`) has been created. When disabled (default), the previous behavior is maintained; when enabled, the domain admin account can enter tags when creating disk and service offerings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #6794: Cannot start cloudstack-agent after upgrade from 4.16.1 to 4.17.1
weizhouapache commented on issue #6794: URL: https://github.com/apache/cloudstack/issues/6794#issuecomment-1372132586 I have created a 4.15.0 testing env, and upgrade the 4.17.2.0. The old cloud-plugin-hypervisor-kvm-4.15.0.0.jar has been removed during upgrade. ``` [root@ref-trl-4110-k-M7-wei-zhou-kvm2 lib]# ls -l cloud-*jar -rw-r--r--. 1 root root 97055 Dec 16 17:10 cloud-agent-4.17.2.0.jar -rw-r--r--. 1 root root 2290269 Dec 16 17:10 cloud-api-4.17.2.0.jar -rw-r--r--. 1 root root 576521 Dec 16 17:10 cloud-core-4.17.2.0.jar -rw-r--r--. 1 root root 103668 Dec 16 17:10 cloud-engine-api-4.17.2.0.jar -rw-r--r--. 1 root root 76537 Dec 16 17:10 cloud-engine-components-api-4.17.2.0.jar -rw-r--r--. 1 root root 1873790 Dec 16 17:10 cloud-engine-schema-4.17.2.0.jar -rw-r--r--. 1 root root 167883 Dec 16 17:10 cloud-engine-storage-4.17.2.0.jar -rw-r--r--. 1 root root 17189 Dec 16 17:10 cloud-engine-storage-configdrive-4.17.2.0.jar -rw-r--r--. 1 root root 64512 Dec 16 17:10 cloud-engine-storage-image-4.17.2.0.jar -rw-r--r--. 1 root root 89243 Dec 16 17:10 cloud-engine-storage-volume-4.17.2.0.jar -rw-r--r--. 1 root root6665 Dec 16 17:10 cloud-framework-agent-lb-4.17.2.0.jar -rw-r--r--. 1 root root7622 Dec 16 17:10 cloud-framework-ca-4.17.2.0.jar -rw-r--r--. 1 root root 78031 Dec 16 17:10 cloud-framework-cluster-4.17.2.0.jar -rw-r--r--. 1 root root 29919 Dec 16 17:10 cloud-framework-config-4.17.2.0.jar -rw-r--r--. 1 root root 169293 Dec 16 17:10 cloud-framework-db-4.17.2.0.jar -rw-r--r--. 1 root root 10418 Dec 16 17:10 cloud-framework-direct-download-4.17.2.0.jar -rw-r--r--. 1 root root 12441 Dec 16 17:10 cloud-framework-events-4.17.2.0.jar -rw-r--r--. 1 root root 91967 Dec 16 17:10 cloud-framework-ipc-4.17.2.0.jar -rw-r--r--. 1 root root 120836 Dec 16 17:10 cloud-framework-jobs-4.17.2.0.jar -rw-r--r--. 1 root root 18092 Dec 16 17:10 cloud-framework-managed-context-4.17.2.0.jar -rw-r--r--. 1 root root 12346 Dec 16 17:10 cloud-framework-rest-4.17.2.0.jar -rw-r--r--. 1 root root 24812 Dec 16 17:10 cloud-framework-security-4.17.2.0.jar -rw-r--r--. 1 root root 593523 Dec 16 17:10 cloud-plugin-hypervisor-kvm-4.17.2.0.jar -rw-r--r--. 1 root root 84494 Dec 16 17:10 cloud-plugin-network-ovs-4.17.2.0.jar -rw-r--r--. 1 root root 82833 Dec 16 17:10 cloud-plugin-storage-volume-scaleio-4.17.2.0.jar -rw-r--r--. 1 root root 151621 Dec 16 17:10 cloud-plugin-storage-volume-storpool-4.17.2.0.jar -rw-r--r--. 1 root root 123023 Dec 16 17:10 cloud-secondary-storage-4.17.2.0.jar -rw-r--r--. 1 root root 3435303 Dec 16 17:10 cloud-server-4.17.2.0.jar -rw-r--r--. 1 root root 403787 Dec 16 17:10 cloud-utils-4.17.2.0.jar ``` when I copied the old jar file and restart cloudstack-agent, I got same error ``` [root@ref-trl-4110-k-M7-wei-zhou-kvm2 lib]# cp /usr/share/cloudstack-agent-41500/lib/cloud-plugin-hypervisor-kvm-4.15.0.0.jar /usr/share/cloudstack-agent/lib/ [root@ref-trl-4110-k-M7-wei-zhou-kvm2 lib]# systemctl restart cloudstack-agent [root@ref-trl-4110-k-M7-wei-zhou-kvm2 lib]# tail -f /var/log/cloudstack/agent/agent.log 2023-01-05 12:02:06,621 ERROR [cloud.agent.AgentShell] (main:null) (logid:) Unable to start agent: com.cloud.utils.exception.CloudRuntimeException: java.lang.InstantiationException: com.cloud.hypervisor.kvm.storage.ScaleIOStorageAdaptor at com.cloud.hypervisor.kvm.storage.KVMStoragePoolManager.(KVMStoragePoolManager.java:116) at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.configure(LibvirtComputingResource.java:1056) at com.cloud.agent.Agent.(Agent.java:189) at com.cloud.agent.AgentShell.launchNewAgent(AgentShell.java:451) at com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:420) at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:404) at com.cloud.agent.AgentShell.start(AgentShell.java:510) at com.cloud.agent.AgentShell.main(AgentShell.java:545) ``` the host became normal after removing the old jar file ``` [root@ref-trl-4110-k-M7-wei-zhou-kvm2 lib]# rm -f /usr/share/cloudstack-agent/lib/cloud-plugin-hypervisor-kvm-4.15.0.0.jar [root@ref-trl-4110-k-M7-wei-zhou-kvm2 lib]# systemctl restart cloudstack-agent ``` this is not a bug. @DaanHoogland @levindecaro -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed issue #6794: Cannot start cloudstack-agent after upgrade from 4.16.1 to 4.17.1
weizhouapache closed issue #6794: Cannot start cloudstack-agent after upgrade from 4.16.1 to 4.17.1 URL: https://github.com/apache/cloudstack/issues/6794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7052: Allow domain admins to inform tags when creating offerings
JoaoJandre commented on PR #7052: URL: https://github.com/apache/cloudstack/pull/7052#issuecomment-1372131360 > @JoaoJandre please have a look at the errors with Simulator CI (ignore the errors with test_tags ) The only error without test_tags was an insufficient capacity exception in a VM deploy and it doesn't look correlated with this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7057: server/UI: fix some issues with network offering details
blueorangutan commented on PR #7057: URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1372130447 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6840: infra: edge zones
sonarcloud[bot] commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1372125187 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6840) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6840=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6840=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6840=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6840=new_coverage=list) [24.3% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6840=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6840=new_duplicated_lines_density=list) [3.3% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6840=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6979: Guest os mappings improvements
sonarcloud[bot] commented on PR #6979: URL: https://github.com/apache/cloudstack/pull/6979#issuecomment-1372116346 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6979) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6979=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6979=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6979=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6979=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6979=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6979=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6979=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6979=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6979=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6979=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6979=false=CODE_SMELL) [17 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6979=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6979=new_coverage=list) [17.6% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6979=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6979=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6979=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7057: server/UI: fix some issues with network offering details
shwstppr commented on code in PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#discussion_r1062388174
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -6408,7 +6408,9 @@ public NetworkOfferingVO doInTransaction(final
TransactionStatus status) {
detailsVO.add(new
NetworkOfferingDetailsVO(offering.getId(), Detail.internetProtocol,
String.valueOf(internetProtocol), true));
}
if (!detailsVO.isEmpty()) {
-networkOfferingDetailsDao.saveDetails(detailsVO);
Review Comment:
@weizhouapache this is used while creating a new offering so will it matter
even if the code tries to delete existing details for the resourceId (service
offering is here)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7045: kvm: get vm disk stats for ceph disks
sonarcloud[bot] commented on PR #7045: URL: https://github.com/apache/cloudstack/pull/7045#issuecomment-1372106156 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7045) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7045=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7045=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7045=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7045=new_coverage=list) [53.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7045=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7045=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7045=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7057: server/UI: fix some issues with network offering details
blueorangutan commented on PR #7057: URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1372089692 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7057: server/UI: fix some issues with network offering details
weizhouapache commented on PR #7057: URL: https://github.com/apache/cloudstack/pull/7057#issuecomment-1372088608 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7057: server/UI: fix some issues with network offering details
weizhouapache commented on code in PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#discussion_r1062365397
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -6408,7 +6408,9 @@ public NetworkOfferingVO doInTransaction(final
TransactionStatus status) {
detailsVO.add(new
NetworkOfferingDetailsVO(offering.getId(), Detail.internetProtocol,
String.valueOf(internetProtocol), true));
}
if (!detailsVO.isEmpty()) {
-networkOfferingDetailsDao.saveDetails(detailsVO);
Review Comment:
`saveDetails` will firstly remove all existing details. this causes issue
(2) in the PR decription.
in my opinion. the issue is critical . @DaanHoogland @rohityadavcloud
@shwstppr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7057: server/UI: fix some issues with network offering details
weizhouapache opened a new pull request, #7057:
URL: https://github.com/apache/cloudstack/pull/7057
### Description
This PR fixes some issues with network offering details
(1) on UI: the serviceofferingid and maclearning is not passed to API when
create network offering
(2) when create network offering, the details are not saved except
internetprotocol, including
Promiscuous mode
MAC address changes
Forged transmits
MAC learning
(3) network offering details are not removed when delete a network offering.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [x] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7054: UI: support serviceofferingid when create vpc offering
sonarcloud[bot] commented on PR #7054: URL: https://github.com/apache/cloudstack/pull/7054#issuecomment-1372073384 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7054) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7054=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7054=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7054=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7054=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7054=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7054=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7054=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7054=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7054=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7054=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7054=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7054=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7054=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7054=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5797: Improve global settings UI to be more intuitive/logical
DaanHoogland commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1372053766 > SonarCloud Quality Gate failed.[](https://sonarcloud.io/dashboard?id=apache_cloudstack=5797) > > [](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=5797=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=5797=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=5797=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=CODE_SMELL) [77 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=CODE_SMELL) > > [](https://sonarcloud.io/component_measures?id=apache_cloudstack=5797=new_coverage=list) [18.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=5797=new_coverage=list)
[GitHub] [cloudstack] fangyi1008 commented on issue #7053: cant not instance
fangyi1008 commented on issue #7053:
URL: https://github.com/apache/cloudstack/issues/7053#issuecomment-1372040099
> > > 你能分享更多日志吗？
> > > 管理日志：
> >
> >
> > ## 2023-01-05 17:52:11,528 DEBUG [ccvVmWorkJobDispatcher]
(Work-Job-Executor-98:ctx-00ddfb01 job-446/job-447) (logid:564609bc) 完成运行 VM
工作作业：com.cloud VM 101 的 .vm.VmWorkStart，作业来源：446
> > 2023-01-05 17:52:11,528 错误 [ccvVmWorkJobDispatcher]
(Work-Job-Executor-98:ctx-00ddfb01 job-446/job-447) (logid:564609bc) 无法完成
AsyncJobVO: {id:447, userId : 2, accountId: 2, instanceType: null, instanceId:
null, cmd: com.cloud.vm.VmWorkStart, cmdInfo:
> >
BRG5OaGRtVmtYM0JoYzNOM2IzSmt4cA，cmdVersion：0，状态：IN_PROGRESS，processStatus：0，resultCode：0，结果：null，initMsid：261833773422727，completeMsid：null，lastUpdated：null，lastPolled：null，创建时间：Thu
Jan 05 17:51:5263 CST 5263
，已删除：null}，作业来源：446com.cloud.exception.InsufficientServerCapacityException：无法为
VM 实例创建部署 {id：“101”，名称：“i-2-101-VM”，uuid：“60093c58-bba6
-470e-a958-0d30e5507628", type="User"}Scope=interface com.cloud.dc.DataCenter;
id=1 InsufficientServerCapacityException: 无法为 VM 实例创建部署 {id: "101", name:
"i-2-101-VM", uuid: "60093c58-bba6-470e-a958-0d30e5507628", type="User"}Scope
=接口com.cloud.dc.DataCenter；id=1 InsufficientServerCapacityException: 无法为 VM
实例创建部署 {id: "101", name: "i-2-101-VM", uuid:
"60093c58-bba6-470e-a958-0d30e5507628", type="User"}Scope
=接口com.cloud.dc.DataCenter；id=1
> > 在
com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:1140)
> > 在
com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:5315)
> > 在 jdk.internal.reflect.GeneratedMethodAccessor554.invoke(Unknown Source)
> > 在 java
.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > 在 java.base/java.lang.reflect.Method.invoke(Method.java:566)
> > 在 com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob
(VmWorkJobHandlerProxy.java:107)
> > 在
com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:5439)
> > 在 com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:102)
> > 在
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:620)
> > 在
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48)
> > 在 org.apache
.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
> > 在
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
> > 在 org.apache.cloudstack。
managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
> > 在
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:45)
> > 在 org.apache.cloudstack.framework.jobs.impl。
AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:568)
> > 在
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> > 在 java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> > 在 java.base/java
.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> > 在
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> > 在 java.base/java.lang.Thread.run (Thread.java:829)
> > 2023-01-05 17:52:11,541 INFO [oacfjiAsyncJobMonitor]
(Work-Job-Executor-98:ctx-00ddfb01 job-446/job-447) (logid:564609bc) 删除作业
447从作业监控
> > 2023-01-05 17:52:11,554 DEBUG [ccvUserVmManagerImpl]
(API-Job-Executor-117:ctx-f896976b job-446 ctx-c292f039) (logid:564609bc) 销毁 vm
VM 实例 {id: "101", name : "i-2-101-VM", uuid:
"60093c58-bba6-470e-a958-0d30e5507628", type="User"} 因为它无法
> > 在 ID 为：12023-01-05 17:52 的主机上创建： 11,571 调试 [cccCapacityManagerImpl]
(API-Job-Executor-117:ctx-f896976b job-446 ctx-c292f039) (logid:564609bc) VM 实例
{id: "101", name: "i-2-101-VM", uuid: "60093c58-bba6-470e-a958-0d30e5507628",
type="User"} 状态从 [Stopped] 转变为 [
> > 错误] 与事件
[OperationFailedToError]。VM的原始主机：null，新主机：null，状态转换前的主机：null2023-01-05
17:52:11,586 DEBUG [ccrResourceLimitManagerImpl]
(API-Job-Executor-117:ctx-f896976b job-446 ctx-c292f039) ( logid:564609bc)
更新资源类型 = 帐户的数量 = 2 操作 = 减少数量 = 1
> > 2023-01-05 17:52:11,595 DEBUG [ccrResourceLimitManagerImpl]
(API-Job-Executor-117:ctx-f896976b job-446 ctx -c292f039) (logid:564609bc)
更新资源类型 = 帐户的主要存储计数 = 2 操作 = 减少数量 = (20.00 GB) 21474836480
> > 2023-01-05 17:52:11,614 警告 [ccaAlertManagerImpl]
(API-Job-Executor-117:ctx-f896976b job-446 ctx-c292f039) (logid:564609bc)
alertType=[8] dataCenterId=[1] podId= [1] clusterId=[null] message=[无法在 ID 为 1
的主机上部署 ID 为 101 的虚拟机]。
> > 2023-01-05 17:52:11,621 WARN [ccaAlertManagerImpl]
(API-Job-Executor-117:ctx-f896976b job-446 ctx-c292f039) (logid:564609bc)
全局设置中未设置收件人 'alert.email.addresses '，跳过发送主题为 [无法在主机 w 上部署 ID 为 101 的 Vm 的警报
> > ith Id: 1] 和内容 [无法在 ID 为 1 的主机上部署
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7045: kvm: get vm disk stats for ceph disks
sonarcloud[bot] commented on PR #7045: URL: https://github.com/apache/cloudstack/pull/7045#issuecomment-1372034705 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7045) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7045=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7045=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7045=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7045=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7045=new_coverage=list) [42.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7045=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7045=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7045=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7047: fix merge diff display
sonarcloud[bot] commented on PR #7047: URL: https://github.com/apache/cloudstack/pull/7047#issuecomment-1372031696 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7047) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7047=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7047=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7047=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7047=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7047=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7047=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7047=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7047=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7047=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7047=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7047=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7047=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7047=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7047=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sbrueseke opened a new issue, #7056: UI user icon not using primary-color setting
sbrueseke opened a new issue, #7056: URL: https://github.com/apache/cloudstack/issues/7056 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.17.2.0 ~~~ # SUMMARY After login into UI the top right user icon does not use @primary-color from theme section of config.json -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7053: cant not instance
weizhouapache commented on issue #7053:
URL: https://github.com/apache/cloudstack/issues/7053#issuecomment-1372030371
> > can you share more logs, please ?
> > management log:
>
> ## 2023-01-05 17:52:11,528 DEBUG [c.c.v.VmWorkJobDispatcher]
(Work-Job-Executor-98:ctx-00ddfb01 job-446/job-447) (logid:564609bc) Done with
run of VM work job: com.cloud.vm.VmWorkStart for VM 101, job origin: 446
> 2023-01-05 17:52:11,528 ERROR [c.c.v.VmWorkJobDispatcher]
(Work-Job-Executor-98:ctx-00ddfb01 job-446/job-447) (logid:564609bc) Unable to
complete AsyncJobVO: {id:447, userId: 2, accountId: 2, instanceType: null,
instanceId: null, cmd: com.cloud.vm.VmWorkStart, cmdInfo:
>
rO0ABXNyABhjb20uY2xvdWQudm0uVm1Xb3JrU3RhcnR9cMGsvxz73gIAC0oABGRjSWRMAAZhdm9pZHN0ADBMY29tL2Nsb3VkL2RlcGxveS9EZXBsb3ltZW50UGxhbm5lciRFeGNsdWRlTGlzdDtMAAljbHVzdGVySWR0ABBMamF2YS9sYW5nL0xvbmc7TAAGaG9zdElkcQB-AAJMAAtqb3VybmFsTmFtZXQAEkxqYXZhL2xhbmcvU3RyaW5nO0wAEXBoeXNpY2FsTmV0d29ya0lkcQB-AAJMAAdwbGFubmVycQB-AANMAAVwb2RJZHEAfgACTAAGcG9vbElkcQB-AAJMAAlyYXdQYXJhbXN0AA9MamF2YS91dGlsL01hcDtMAA1yZXNlcnZhdGlvbklkcQB-AAN4cgATY29tLmNsb3VkLnZtLlZtV29ya5-ZtlbwJWdrAgAESgAJYWNjb3VudElkSgAGdXNlcklkSgAEdm1JZEwAC2hhbmRsZXJOYW1lcQB-AAN4cAACAAIAZXQAGVZpcnR1YWxNYWNoaW5lTWFuYWdlckltcGwAAXBzcgAOamF2YS5sYW5nLkxvbmc7i-SQzI8j3wIAAUoABXZhbHVleHIAEGphdmEubGFuZy5OdW1iZXKGrJUdC5TgiwIAAHhwAAFxAH4ACnBwcHEAfgAKcHNyABFqYXZhLnV0aWwuSGFzaE1hcAUH2sHDFmDRAwACRgAKbG9hZEZhY3RvckkACXRocmVzaG9sZHhwP0x3CBABdAAKVm1QYXNzd29yZHQAHHJPMEFCWFFBRG5OaGRtVmtYM0JoYzNOM2IzSmt4cA,
cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result:
null, initMsid: 26183377
3422727, completeMsid: null, lastUpdated: null, lastPolled: null, created: Thu
Jan 05 17:51:56 CST 2023, removed: null}, job
origin:446com.cloud.exception.InsufficientServerCapacityException: Unable to
create a deployment for VM instance {id: "101", name: "i-2-101-VM", uuid:
"60093c58-bba6-470e-a958-0d30e5507628", type="User"}Scope=interface
com.cloud.dc.DataCenter; id=1
> at
com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:1140)
> at
com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:5315)
> at jdk.internal.reflect.GeneratedMethodAccessor554.invoke(Unknown Source)
> at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107)
> at
com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:5439)
> at com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:102)
> at
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:620)
> at
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48)
> at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
> at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
> at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
> at
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:45)
> at
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:568)
> at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> 2023-01-05 17:52:11,541 INFO [o.a.c.f.j.i.AsyncJobMonitor]
(Work-Job-Executor-98:ctx-00ddfb01 job-446/job-447) (logid:564609bc) Remove
job-447 from job monitoring
> 2023-01-05 17:52:11,554 DEBUG [c.c.v.UserVmManagerImpl]
(API-Job-Executor-117:ctx-f896976b job-446 ctx-c292f039) (logid:564609bc)
Destroying vm VM instance {id: "101", name: "i-2-101-VM", uuid:
"60093c58-bba6-470e-a958-0d30e5507628", type="User"} as it failed to create
> on Host with Id:12023-01-05 17:52:11,571 DEBUG [c.c.c.CapacityManagerImpl]
(API-Job-Executor-117:ctx-f896976b job-446 ctx-c292f039) (logid:564609bc) VM
instance {id: "101", name: "i-2-101-VM", uuid:
"60093c58-bba6-470e-a958-0d30e5507628", type="User"} state transited from
[Stopped] to [
> Error] with event [OperationFailedToError]. VM's original host: null, new
host: null, host before state transition: null2023-01-05 17:52:11,586 DEBUG
[c.c.r.ResourceLimitManagerImpl] (API-Job-Executor-117:ctx-f896976b job-446
[GitHub] [cloudstack] sbrueseke opened a new issue, #7055: UI favicon and title of login page editable via config.json
sbrueseke opened a new issue, #7055: URL: https://github.com/apache/cloudstack/issues/7055 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.17.2.0 ~~~ # SUMMARY I would be nice to be able to change favicon of the UI and the title of the login page via config.json. You are unable to change the favicon via config.json. It looks hard coded and points to cloud.ico. You can edit the titles of the UI after login via appTitle, but this will not change the title of the login page. It looks like it is hard coded in index.html. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] fangyi1008 commented on issue #7053: cant not instance
fangyi1008 commented on issue #7053:
URL: https://github.com/apache/cloudstack/issues/7053#issuecomment-1372006451
> can you share more logs, please ?
management log:
2023-01-05 17:52:11,528 DEBUG [c.c.v.VmWorkJobDispatcher]
(Work-Job-Executor-98:ctx-00ddfb01 job-446/job-447) (logid:564609bc) Done with
run of VM work job: com.cloud.vm.VmWorkStart for VM 101, job origin: 446
2023-01-05 17:52:11,528 ERROR [c.c.v.VmWorkJobDispatcher]
(Work-Job-Executor-98:ctx-00ddfb01 job-446/job-447) (logid:564609bc) Unable to
complete AsyncJobVO: {id:447, userId: 2, accountId: 2, instanceType: null,
instanceId: null, cmd: com.cloud.vm.VmWorkStart, cmdInfo:
rO0ABXNyABhjb20uY2xvdWQudm0uVm1Xb3JrU3RhcnR9cMGsvxz73gIAC0oABGRjSWRMAAZhdm9pZHN0ADBMY29tL2Nsb3VkL2RlcGxveS9EZXBsb3ltZW50UGxhbm5lciRFeGNsdWRlTGlzdDtMAAljbHVzdGVySWR0ABBMamF2YS9sYW5nL0xvbmc7TAAGaG9zdElkcQB-AAJMAAtqb3VybmFsTmFtZXQAEkxqYXZhL2xhbmcvU3RyaW5nO0wAEXBoeXNpY2FsTmV0d29ya0lkcQB-AAJMAAdwbGFubmVycQB-AANMAAVwb2RJZHEAfgACTAAGcG9vbElkcQB-AAJMAAlyYXdQYXJhbXN0AA9MamF2YS91dGlsL01hcDtMAA1yZXNlcnZhdGlvbklkcQB-AAN4cgATY29tLmNsb3VkLnZtLlZtV29ya5-ZtlbwJWdrAgAESgAJYWNjb3VudElkSgAGdXNlcklkSgAEdm1JZEwAC2hhbmRsZXJOYW1lcQB-AAN4cAACAAIAZXQAGVZpcnR1YWxNYWNoaW5lTWFuYWdlckltcGwAAXBzcgAOamF2YS5sYW5nLkxvbmc7i-SQzI8j3wIAAUoABXZhbHVleHIAEGphdmEubGFuZy5OdW1iZXKGrJUdC5TgiwIAAHhwAAFxAH4ACnBwcHEAfgAKcHNyABFqYXZhLnV0aWwuSGFzaE1hcAUH2sHDFmDRAwACRgAKbG9hZEZhY3RvckkACXRocmVzaG9sZHhwP0x3CBABdAAKVm1QYXNzd29yZHQAHHJPMEFCWFFBRG5OaGRtVmtYM0JoYzNOM2IzSmt4cA,
cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result:
null, initMsid: 2618337734
22727, completeMsid: null, lastUpdated: null, lastPolled: null, created: Thu
Jan 05 17:51:56 CST 2023, removed: null}, job
origin:446com.cloud.exception.InsufficientServerCapacityException: Unable to
create a deployment for VM instance {id: "101", name: "i-2-101-VM", uuid:
"60093c58-bba6-470e-a958-0d30e5507628", type="User"}Scope=interface
com.cloud.dc.DataCenter; id=1
at
com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:1140)
at
com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:5315)
at jdk.internal.reflect.GeneratedMethodAccessor554.invoke(Unknown
Source)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107)
at
com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:5439)
at com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:102)
at
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:620)
at
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
at
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:45)
at
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:568)
at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
2023-01-05 17:52:11,541 INFO [o.a.c.f.j.i.AsyncJobMonitor]
(Work-Job-Executor-98:ctx-00ddfb01 job-446/job-447) (logid:564609bc) Remove
job-447 from job monitoring
2023-01-05 17:52:11,554 DEBUG [c.c.v.UserVmManagerImpl]
(API-Job-Executor-117:ctx-f896976b job-446 ctx-c292f039) (logid:564609bc)
Destroying vm VM instance {id: "101", name: "i-2-101-VM", uuid:
"60093c58-bba6-470e-a958-0d30e5507628", type="User"} as it failed to create
on Host with Id:12023-01-05 17:52:11,571 DEBUG [c.c.c.CapacityManagerImpl]
(API-Job-Executor-117:ctx-f896976b job-446 ctx-c292f039) (logid:564609bc) VM
instance {id: "101", name: "i-2-101-VM", uuid:
"60093c58-bba6-470e-a958-0d30e5507628", type="User"} state transited from
[Stopped] to [
Error] with event [OperationFailedToError]. VM's original host: null, new
host: null, host before state transition: null2023-01-05 17:52:11,586 DEBUG
[c.c.r.ResourceLimitManagerImpl]
[GitHub] [cloudstack] weizhouapache commented on pull request #6957: Allow VPC offering creation only with active VR service offerings
weizhouapache commented on PR #6957: URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1372002749 @stephankruggg can you please fix the conflicts ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7053: cant not instance
weizhouapache commented on issue #7053:
URL: https://github.com/apache/cloudstack/issues/7053#issuecomment-1372002028
> > > > @fangyi1008 您使用本地存储还是共享存储？
> > > > 日志显示没有适合该卷的存储池。
> > > > ```
> > > > 2023-01-05 10:36:33,020 Looking for suitable pools for this host
under zone: 1, pod: 1, cluster: 1
> > > > 2023-01-05 10:36:33,022 Checking suitable pools for volume (Id,
Type): (70,ROOT)
> > > > 2023-01-05 10:36:33,022 We need to allocate new storagepool for this
volume
> > > > 2023-01-05 10:36:33,023 Calling StoragePoolAllocators to find
suitable pools
> > > > 2023-01-05 10:36:33,027 No suitable pools found for volume:
Vol[70|vm=90|ROOT] under cluster: 1
> > > > 2023-01-05 10:36:33,027 No suitable pools found
> > > > 2023-01-05 10:36:33,027 Cannot deploy to specified host, returning.
> > > > ```
> > >
> > >
> > > The primary storage is local storage, and the secondary storage uses
nfs。 In the global configuration, system.vm.use.local.storage is set to true
> >
> >
> > @fangyi1008 what's the storage type of service offering (used by the vm
instance) ? it should be "local" as well.
> > Another problem arises。
> > Unable to start a VM [fdb11a9c-b45a-4a32-b6f9-c322a2358444] due to
[Unable to create a deployment for VM instance {id: "98", name: "i-2-98-VM",
uuid: "fdb11a9c-b45a-4a32-b6f9-c322a2358444", type="User"}].
can you share more logs, please ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6781: Allow creating atmost 1 physical network with null tag
sonarcloud[bot] commented on PR #6781: URL: https://github.com/apache/cloudstack/pull/6781#issuecomment-1372000249 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6781) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6781=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6781=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6781=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6781=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6781=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6781=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6781=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6781=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6781=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6781=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6781=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6781=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6781=new_coverage=list) [4.7% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6781=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6781=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6781=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7054: UI: support serviceofferingid when create vpc offering
weizhouapache opened a new pull request, #7054:
URL: https://github.com/apache/cloudstack/pull/7054
### Description
This PR fixes #7042
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
no supported services
"SourceNat" is checked
###
How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] fangyi1008 commented on issue #7053: cant not instance
fangyi1008 commented on issue #7053:
URL: https://github.com/apache/cloudstack/issues/7053#issuecomment-1371994078
> > > @fangyi1008 您使用本地存储还是共享存储？
> > > 日志显示没有适合该卷的存储池。
> > > ```
> > > 2023-01-05 10:36:33,020 Looking for suitable pools for this host under
zone: 1, pod: 1, cluster: 1
> > > 2023-01-05 10:36:33,022 Checking suitable pools for volume (Id, Type):
(70,ROOT)
> > > 2023-01-05 10:36:33,022 We need to allocate new storagepool for this
volume
> > > 2023-01-05 10:36:33,023 Calling StoragePoolAllocators to find suitable
pools
> > > 2023-01-05 10:36:33,027 No suitable pools found for volume:
Vol[70|vm=90|ROOT] under cluster: 1
> > > 2023-01-05 10:36:33,027 No suitable pools found
> > > 2023-01-05 10:36:33,027 Cannot deploy to specified host, returning.
> > > ```
> >
> >
> > The primary storage is local storage, and the secondary storage uses
nfs。 In the global configuration, system.vm.use.local.storage is set to true
>
> @fangyi1008 what's the storage type of service offering (used by the vm
instance) ? it should be "local" as well.
Another problem arises。
Unable to start a VM [fdb11a9c-b45a-4a32-b6f9-c322a2358444] due to [Unable
to create a deployment for VM instance {id: "98", name: "i-2-98-VM", uuid:
"fdb11a9c-b45a-4a32-b6f9-c322a2358444", type="User"}].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] fangyi1008 commented on issue #7053: cant not instance
fangyi1008 commented on issue #7053: URL: https://github.com/apache/cloudstack/issues/7053#issuecomment-1371992416 > > > @fangyi1008 您使用本地存储还是共享存储？ > > > 日志显示没有适合该卷的存储池。 > > > ``` > > > 2023-01-05 10:36:33,020 Looking for suitable pools for this host under zone: 1, pod: 1, cluster: 1 > > > 2023-01-05 10:36:33,022 Checking suitable pools for volume (Id, Type): (70,ROOT) > > > 2023-01-05 10:36:33,022 We need to allocate new storagepool for this volume > > > 2023-01-05 10:36:33,023 Calling StoragePoolAllocators to find suitable pools > > > 2023-01-05 10:36:33,027 No suitable pools found for volume: Vol[70|vm=90|ROOT] under cluster: 1 > > > 2023-01-05 10:36:33,027 No suitable pools found > > > 2023-01-05 10:36:33,027 Cannot deploy to specified host, returning. > > > ``` > > > > > > The primary storage is local storage, and the secondary storage uses nfs。 In the global configuration, system.vm.use.local.storage is set to true > > @fangyi1008 what's the storage type of service offering (used by the vm instance) ? it should be "local" as well. Select local when you need to customize the calculation scheme to select the disk size。 thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] fangyi1008 commented on issue #7053: cant not instance
fangyi1008 commented on issue #7053: URL: https://github.com/apache/cloudstack/issues/7053#issuecomment-1371990878 > Does your service offering use local storage? I know how to solve it。thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] fangyi1008 commented on issue #7053: cant not instance
fangyi1008 commented on issue #7053: URL: https://github.com/apache/cloudstack/issues/7053#issuecomment-1371987731 > > > > @fangyi1008 您使用本地存储还是共享存储？ > > > 日志显示没有适合该卷的存储池。 > > > ``` > > > 2023-01-05 10:36:33,020 Looking for suitable pools for this host under zone: 1, pod: 1, cluster: 1 > > > 2023-01-05 10:36:33,022 Checking suitable pools for volume (Id, Type): (70,ROOT) > > > 2023-01-05 10:36:33,022 We need to allocate new storagepool for this volume > > > 2023-01-05 10:36:33,023 Calling StoragePoolAllocators to find suitable pools > > > 2023-01-05 10:36:33,027 No suitable pools found for volume: Vol[70|vm=90|ROOT] under cluster: 1 > > > 2023-01-05 10:36:33,027 No suitable pools found > > > 2023-01-05 10:36:33,027 Cannot deploy to specified host, returning. > > > ``` > > > > > > The primary storage is local storage, and the secondary storage uses nfs。 In the global configuration, system.vm.use.local.storage is set to true > > @fangyi1008 what's the storage type of service offering (used by the vm instance) ? it should be "local" as well. https://user-images.githubusercontent.com/89246132/210748722-bc80f1ac-7253-4d3c-ac89-9b3d88e2f42c.png;> The zone is created as follows  Uploaded iso used for instance creation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7045: kvm: get vm disk stats for ceph disks
weizhouapache commented on PR #7045: URL: https://github.com/apache/cloudstack/pull/7045#issuecomment-1371982823 > @weizhouapache coverage is "down" by 0%. should we consider to add tests for this? (not implying we should!) unit tests added. @DaanHoogland let's wait for the codecov report. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7053: cant not instance
weizhouapache commented on issue #7053: URL: https://github.com/apache/cloudstack/issues/7053#issuecomment-1371980503 > > @fangyi1008 您使用本地存储还是共享存储？ > > 日志显示没有适合该卷的存储池。 > > ``` > > 2023-01-05 10:36:33,020 Looking for suitable pools for this host under zone: 1, pod: 1, cluster: 1 > > 2023-01-05 10:36:33,022 Checking suitable pools for volume (Id, Type): (70,ROOT) > > 2023-01-05 10:36:33,022 We need to allocate new storagepool for this volume > > 2023-01-05 10:36:33,023 Calling StoragePoolAllocators to find suitable pools > > 2023-01-05 10:36:33,027 No suitable pools found for volume: Vol[70|vm=90|ROOT] under cluster: 1 > > 2023-01-05 10:36:33,027 No suitable pools found > > 2023-01-05 10:36:33,027 Cannot deploy to specified host, returning. > > ``` > > The primary storage is local storage, and the secondary storage uses nfs。 In the global configuration, system.vm.use.local.storage is set to true @fangyi1008 what's the storage type of service offering (used by the vm instance) ? it should be "local" as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sbrueseke commented on issue #7053: cant not instance
sbrueseke commented on issue #7053: URL: https://github.com/apache/cloudstack/issues/7053#issuecomment-1371978619 Does your service offering use local storage? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6840: infra: edge zones
github-actions[bot] commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1371978176 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
