Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]
blueorangutan commented on PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#issuecomment-2080375440 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]
rohityadavcloud commented on PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#issuecomment-2080375134 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2080370216 [SF] Trillian Build Failed (tid-10063) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2080370166 [SF] Trillian Build Failed (tid-10061) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]
blueorangutan commented on PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#issuecomment-2080369490 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2080365687 @rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
rohityadavcloud commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2080364673 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: improve listVM API handling and response speed [cloudstack]
blueorangutan commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080362392 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: improve listVM API handling and response speed [cloudstack]
rohityadavcloud commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080362124 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: improve listVM API handling and response speed [cloudstack]
rohityadavcloud commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080360286 Thanks @weizhouapache @JoaoJandre I've addressed the feedback and comments. Joao's remarks are valid, however, my comments at the time were largely around metrics vs non-metrics APIs - how they should be used treated. At the time I couldn't co-relate what made the API slow only to later find out through community and customer issues who are facing degraded performance. Generally speaking, we shouldn't break API compatibility which can break potential integrations (as also on this PR Wei has objected). I feel in this case whatever we do we break what was introduced by #5984 in 4.17. The root cause that I could determine is, we accumulate VM stats for each VM in list API calls which isn't a good idea. That said, I think we need a stop-gap until a better solution emerges on how we should process and return stats are returned by the list API (I think we shouldn't reduce/accumulate stats during a list API call). The list VM API response method is used not only for listVMs API but also for several other VM related lifecycle APIs (such as migrate, stop/start etc) which all return the same vm response class/object. So, I've tried to have a different approach with the PR, and introduce a new global setting that can allow users who want backward compatibility but largely benefit users who don't want it (as default). I've updated the description to reflect this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]
blueorangutan commented on PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#issuecomment-2080352750 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]
rohityadavcloud commented on PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#issuecomment-2080352554 Thanks @weizhouapache @sureshanaparti I've addressed the review comments. @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]
rohityadavcloud commented on code in PR #8988:
URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1581727099
##
utils/src/main/java/com/cloud/utils/net/MacAddress.java:
##
@@ -79,209 +72,45 @@ public String toString() {
static {
String macAddress = null;
-Process p = null;
-BufferedReader in = null;
-
try {
-String osname = System.getProperty("os.name");
-
-if (osname.startsWith("Windows")) {
-p = Runtime.getRuntime().exec(new String[] {"ipconfig",
"/all"}, null);
-} else if (osname.startsWith("Solaris") ||
osname.startsWith("SunOS")) {
-// Solaris code must appear before the generic code
-String hostName = MacAddress.getFirstLineOfCommand(new
String[] {"uname", "-n"});
-if (hostName != null) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/arp", hostName}, null);
-}
-} else if (new File("/usr/sbin/lanscan").exists()) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/lanscan"}, null);
-} else if (new File("/sbin/ifconfig").exists()) {
-p = Runtime.getRuntime().exec(new String[] {"/sbin/ifconfig",
"-a"}, null);
-}
-
-if (p != null) {
-in = new BufferedReader(new
InputStreamReader(p.getInputStream()), 128);
-String l = null;
-while ((l = in.readLine()) != null) {
-macAddress = MacAddress.parse(l);
-if (macAddress != null) {
-short parsedShortMacAddress =
MacAddress.parseShort(macAddress);
-if (parsedShortMacAddress != 0xff &&
parsedShortMacAddress != 0x00)
-break;
-}
-macAddress = null;
-}
-}
-
-} catch (SecurityException ex) {
-s_logger.info("[ignored] security exception in static initializer
of MacAddress", ex);
-} catch (IOException ex) {
-s_logger.info("[ignored] io exception in static initializer of
MacAddress");
-} finally {
-if (p != null) {
-closeAutoCloseable(in, "closing init process input stream");
-closeAutoCloseable(p.getErrorStream(), "closing init process
error output stream");
-closeAutoCloseable(p.getOutputStream(), "closing init process
std output stream");
-p.destroy();
-}
+Enumeration networkInterfaces =
NetworkInterface.getNetworkInterfaces();
+while (networkInterfaces.hasMoreElements()) {
+ NetworkInterface network = networkInterfaces.nextElement();
+ final byte [] mac = network.getHardwareAddress();
+ if (mac != null && !network.isVirtual() &&
+ !network.getName().startsWith("br-") &&
+ !network.getName().startsWith("veth") &&
+ !network.getName().startsWith("vnet")) {
Review Comment:
Found this to be a non-issue. Interfaces inside containers were found to
have non-virtual Nic names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]
rohityadavcloud commented on code in PR #8988:
URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1581725346
##
utils/src/main/java/com/cloud/utils/net/MacAddress.java:
##
@@ -79,209 +72,45 @@ public String toString() {
static {
String macAddress = null;
-Process p = null;
-BufferedReader in = null;
-
try {
-String osname = System.getProperty("os.name");
-
-if (osname.startsWith("Windows")) {
-p = Runtime.getRuntime().exec(new String[] {"ipconfig",
"/all"}, null);
-} else if (osname.startsWith("Solaris") ||
osname.startsWith("SunOS")) {
-// Solaris code must appear before the generic code
-String hostName = MacAddress.getFirstLineOfCommand(new
String[] {"uname", "-n"});
-if (hostName != null) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/arp", hostName}, null);
-}
-} else if (new File("/usr/sbin/lanscan").exists()) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/lanscan"}, null);
-} else if (new File("/sbin/ifconfig").exists()) {
-p = Runtime.getRuntime().exec(new String[] {"/sbin/ifconfig",
"-a"}, null);
-}
-
-if (p != null) {
-in = new BufferedReader(new
InputStreamReader(p.getInputStream()), 128);
-String l = null;
-while ((l = in.readLine()) != null) {
-macAddress = MacAddress.parse(l);
-if (macAddress != null) {
-short parsedShortMacAddress =
MacAddress.parseShort(macAddress);
-if (parsedShortMacAddress != 0xff &&
parsedShortMacAddress != 0x00)
-break;
-}
-macAddress = null;
-}
-}
-
-} catch (SecurityException ex) {
-s_logger.info("[ignored] security exception in static initializer
of MacAddress", ex);
-} catch (IOException ex) {
-s_logger.info("[ignored] io exception in static initializer of
MacAddress");
-} finally {
-if (p != null) {
-closeAutoCloseable(in, "closing init process input stream");
-closeAutoCloseable(p.getErrorStream(), "closing init process
error output stream");
-closeAutoCloseable(p.getOutputStream(), "closing init process
std output stream");
-p.destroy();
-}
+Enumeration networkInterfaces =
NetworkInterface.getNetworkInterfaces();
+while (networkInterfaces.hasMoreElements()) {
+ NetworkInterface network = networkInterfaces.nextElement();
+ final byte [] mac = network.getHardwareAddress();
+ if (mac != null && !network.isVirtual() &&
+ !network.getName().startsWith("br-") &&
+ !network.getName().startsWith("veth") &&
+ !network.getName().startsWith("vnet")) {
+ StringBuilder macAddressBuilder = new StringBuilder();
+ for (byte b : mac) {
+ macAddressBuilder.append(String.format("%02X", b));
+ }
+ macAddress = macAddressBuilder.toString();
+ }
+ }
+} catch (SocketException ignore) {
Review Comment:
Logging wouldn't be necessary here, we ignore it anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]
blueorangutan commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2080341492 [SF] Trillian test result (tid-10052) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 51115 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8243-t10052-kvm-centos7.zip Smoke tests completed. 128 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 436.58 | test_events_resource.py test_02_trigger_shutdown | `Failure` | 357.31 | test_safe_shutdown.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2080335049 [SF] Trillian test result (tid-10054) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48698 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8977-t10054-kvm-rocky8.zip Smoke tests completed. 128 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 420.15 | test_events_resource.py test_01_restore_vm | `Error` | 0.28 | test_restore_vm.py test_02_restore_vm_allocated_root | `Error` | 0.20 | test_restore_vm.py ContextSuite context=TestRestoreVM>:teardown | `Error` | 1.32 | test_restore_vm.py test_02_trigger_shutdown | `Failure` | 346.99 | test_safe_shutdown.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
blueorangutan commented on PR #8974: URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2080322814 [SF] Trillian test result (tid-10046) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a8 Total time taken: 56860 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8974-t10046-vmware-70u3.zip Smoke tests completed. 125 look OK, 5 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 362.00 | test_events_resource.py test_deploy_more_vms_than_limit_allows | `Error` | 159.03 | test_deploy_vms_in_parallel.py test_04_list_domains_level_filter | `Failure` | 0.08 | test_list_domains.py test_05_list_domains_no_filter | `Failure` | 0.04 | test_list_domains.py test_05_list_volumes_isrecursive | `Failure` | 0.08 | test_list_volumes.py test_07_list_volumes_listall | `Failure` | 0.11 | test_list_volumes.py test_list_system_vms_metrics_history | `Failure` | 0.30 | test_metrics_api.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Accept a role ID on linking an account to LDAP [cloudstack]
blueorangutan commented on PR #8236: URL: https://github.com/apache/cloudstack/pull/8236#issuecomment-2080304770 [SF] Trillian test result (tid-10053) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44428 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8236-t10053-kvm-centos7.zip Smoke tests completed. 129 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 408.71 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] sanatise log in case multiple passwords have been passed [cloudstack]
blueorangutan commented on PR #8891: URL: https://github.com/apache/cloudstack/pull/8891#issuecomment-2080247652 [SF] Trillian test result (tid-10047) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47863 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8891-t10047-kvm-centos7.zip Smoke tests completed. 129 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 424.40 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2080246212 [SF] Trillian test result (tid-10050) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45290 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8977-t10050-kvm-centos7.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 415.40 | test_events_resource.py test_01_restore_vm | `Error` | 0.25 | test_restore_vm.py test_02_restore_vm_allocated_root | `Error` | 0.18 | test_restore_vm.py ContextSuite context=TestRestoreVM>:teardown | `Error` | 1.28 | test_restore_vm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
rg9975 commented on code in PR #8889:
URL: https://github.com/apache/cloudstack/pull/8889#discussion_r1581627317
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/MultipathSCSIAdapterBase.java:
##
@@ -223,15 +228,19 @@ public boolean disconnectPhysicalDisk(Map
volumeToDisconnect) {
@Override
public boolean disconnectPhysicalDiskByPath(String localPath) {
LOGGER.debug(String.format("disconnectPhysicalDiskByPath(localPath)
called with args (%s) STARTED", localPath));
+if (localPath == null || (localPath != null &&
!localPath.startsWith("/dev/mapper/"))) {
Review Comment:
Unfortunately, there is no other distinguishing factor I can think of in
this scenario to determine if the MultipathSCSIAdapter code should take action
or not. This flow is called when the LibvirtComputingResource cleans up disks
left over after a live migration (from what I can tell) and it only knows the
path that was referenced in the Domain configuration (the multipathed file).
/dev/mapper is the standard location for multipath mapped devices. Even if
another storage provider uses this path, this cleanup routine should not cause
an issue since it could logically only perform the same function (delete the
multipath and clean up any residual path devices left).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix: Update rootdisksize detail on restore VM [cloudstack]
blueorangutan commented on PR #8981: URL: https://github.com/apache/cloudstack/pull/8981#issuecomment-2080231020 [SF] Trillian test result (tid-10049) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44709 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8981-t10049-kvm-centos7.zip Smoke tests completed. 129 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 411.42 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2080207600 [SF] Trillian test result (tid-10045) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48172 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8624-t10045-kvm-rocky8.zip Smoke tests completed. 129 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 423.65 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
rg9975 commented on code in PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#discussion_r1581566150 ## engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java: ## @@ -2975,19 +3076,21 @@ private CopyCmdAnswer performCopyOfVdi(VolumeInfo volumeInfo, SnapshotInfo snaps srcData = cacheData; } -CopyCommand copyCommand = new CopyCommand(srcData.getTO(), volumeInfo.getTO(), primaryStorageDownloadWait, VirtualMachineManager.ExecuteInSequence.value()); +CopyCommand copyCommand = null; Review Comment: Fixed in updated commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
rg9975 commented on code in PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#discussion_r1581565857 ## engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java: ## @@ -2496,15 +2599,17 @@ private void handleCreateTemplateFromManagedVolume(VolumeInfo volumeInfo, Templa int primaryStorageDownloadWait = StorageManager.PRIMARY_STORAGE_DOWNLOAD_WAIT.value(); -CopyCommand copyCommand = new CopyCommand(volumeInfo.getTO(), templateInfo.getTO(), primaryStorageDownloadWait, VirtualMachineManager.ExecuteInSequence.value()); +CopyCommand copyCommand = null; Review Comment: Fixed in updated commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
rg9975 commented on code in PR #8889:
URL: https://github.com/apache/cloudstack/pull/8889#discussion_r1581565512
##
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java:
##
@@ -1696,14 +1850,15 @@ private void
handleCreateVolumeFromVolumeOnSecondaryStorage(VolumeInfo srcVolume
private CopyCmdAnswer copyImageToVolume(DataObject srcDataObject,
VolumeInfo destVolumeInfo, HostVO hostVO) {
int primaryStorageDownloadWait =
StorageManager.PRIMARY_STORAGE_DOWNLOAD_WAIT.value();
-CopyCommand copyCommand = new CopyCommand(srcDataObject.getTO(),
destVolumeInfo.getTO(), primaryStorageDownloadWait,
-VirtualMachineManager.ExecuteInSequence.value());
+CopyCommand copyCommand = null;
Review Comment:
Fixed in updated commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2080128999 [SF] Trillian test result (tid-10042) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 49762 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8898-t10042-vmware-67u3.zip Smoke tests completed. 71 look OK, 39 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 156.75 | test_accounts.py test_DeleteDomain | `Error` | 101.52 | test_accounts.py test_forceDeleteDomain | `Failure` | 91.91 | test_accounts.py test_01_user_remove_VM_running | `Error` | 80.21 | test_accounts.py test_DeployVmAntiAffinityGroup_in_project | `Error` | 82.76 | test_affinity_groups_projects.py ContextSuite context=TestAnnotations>:setup | `Error` | 0.00 | test_annotations.py test_query_async_job_result | `Error` | 100.79 | test_async_job.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 80.36 | test_internal_lb.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 80.36 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 151.54 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 151.55 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 95.92 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 95.93 | test_internal_lb.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 160.62 | test_internal_lb.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 160.63 | test_internal_lb.py test_deploy_more_vms_than_limit_allows | `Error` | 72.47 | test_deploy_vms_in_parallel.py ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py test_deployvm_firstfit | `Error` | 81.66 | test_deploy_vms_with_varied_deploymentplanners.py test_deployvm_userconcentrated | `Error` | 17.09 | test_deploy_vms_with_varied_deploymentplanners.py test_deployvm_userdispersing | `Error` | 16.08 | test_deploy_vms_with_varied_deploymentplanners.py test_deployvm_userdata | `Error` | 73.84 | test_deploy_vm_with_userdata.py test_deployvm_userdata_post | `Error` | 14.16 | test_deploy_vm_with_userdata.py test_delete_account | `Error` | 81.70 | test_network.py test_delete_network_while_vm_on_it | `Error` | 9.18 | test_network.py test_delete_network_while_vm_on_it | `Error` | 9.18 | test_network.py test_deploy_vm_l2network | `Error` | 7.88 | test_network.py test_deploy_vm_l2network | `Error` | 7.89 | test_network.py test_l2network_restart | `Error` | 10.40 | test_network.py test_l2network_restart | `Error` | 10.40 | test_network.py ContextSuite context=TestL2Networks>:teardown | `Error` | 11.55 | test_network.py ContextSuite context=TestPortForwarding>:setup | `Error` | 79.52 | test_network.py ContextSuite context=TestPublicIP>:setup | `Error` | 68.14 | test_network.py test_reboot_router | `Error` | 68.19 | test_network.py test_releaseIP | `Error` | 68.72 | test_network.py ContextSuite context=TestRouterRules>:setup | `Error` | 135.59 | test_network.py ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py test_list_vms_metrics_admin | `Error` | 24.92 | test_metrics_api.py test_list_vms_metrics_history | `Error` | 17.77 | test_metrics_api.py test_list_vms_metrics_user | `Error` | 67.97 | test_metrics_api.py test_list_volumes_metrics_history | `Error` | 17.45 | test_metrics_api.py test_03_deploy_vm_domain_service_offering | `Error` | 93.53 | test_domain_service_offerings.py ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py test_nic_secondaryip_add_remove | `Error` | 78.25 | test_multipleips_per_nic.py test_nested_virtualization_vmware | `Error` | 90.37 | test_nested_virtualization.py test_network_acl | `Error` | 100.06 | test_network_acl.py test_01_verify_ipv6_network | `Error` | 71.74 | test_network_ipv6.py test_01_verify_ipv6_network | `Error` | 71.75 | test_network_ipv6.py ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py test_01_create_delete_portforwarding_fornonvpc | `Error` | 74.57 | test_portforwardingrules.py test_02_vpc_privategw_static_routes | `Failure` | 137.12 | test_privategw_acl.py test_02_vpc_privategw_static_routes | `Error` | 137.13 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 129.33 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 129.34 | test_privategw_acl.py
Re: [PR] api: improve listVM API handling and response speed [cloudstack]
blueorangutan commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080113463 [SF] Trillian test result (tid-10044) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43454 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8985-t10044-kvm-centos7.zip Smoke tests completed. 109 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_nonsecured_to_secured_vm_migration | `Error` | 166.37 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 46.21 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2079994634 [SF] Trillian Build Failed (tid-10060) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2079966364 [SF] Trillian Build Failed (tid-10058) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2079939039 @rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
rohityadavcloud commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2079935495 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] (VirtualRouter) Provider is not ready, cannot Enable the provider, please configure the provider first [cloudstack]
boring-cyborg[bot] commented on issue #8997: URL: https://github.com/apache/cloudstack/issues/8997#issuecomment-2079930659 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] (VirtualRouter) Provider is not ready, cannot Enable the provider, please configure the provider first [cloudstack]
Luskan777 opened a new issue, #8997: URL: https://github.com/apache/cloudstack/issues/8997 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VirtualRouter ~~~ # CLOUDSTACK VERSION ~~~ 4.19.0.1 ~~~ # CONFIGURATION # OS / ENVIRONMENT : Ubuntu 22.04.4 LTS (Management Server) and CentOS 7 (Agent) Network: advanced networking Physical Network: - cloudbr0: management and storage traffic - cloudbr1: Public and Guest Traffic # SUMMARY # STEPS TO REPRODUCE ~~~ When you try to activate the VirtualRouter provider in Zone -> Physical Network -> Network Service Provider ~~~ # EXPECTED RESULTS ~~~ Successfully activate the VirtualRouter provider ~~~ # ACTUAL RESULTS ~~~ (VirtualRouter) Provider is not ready, cannot Enable the provider, please configure the provider first ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]
weizhouapache commented on code in PR #8988:
URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1581384065
##
utils/src/main/java/com/cloud/utils/net/MacAddress.java:
##
@@ -79,209 +72,45 @@ public String toString() {
static {
String macAddress = null;
-Process p = null;
-BufferedReader in = null;
-
try {
-String osname = System.getProperty("os.name");
-
-if (osname.startsWith("Windows")) {
-p = Runtime.getRuntime().exec(new String[] {"ipconfig",
"/all"}, null);
-} else if (osname.startsWith("Solaris") ||
osname.startsWith("SunOS")) {
-// Solaris code must appear before the generic code
-String hostName = MacAddress.getFirstLineOfCommand(new
String[] {"uname", "-n"});
-if (hostName != null) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/arp", hostName}, null);
-}
-} else if (new File("/usr/sbin/lanscan").exists()) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/lanscan"}, null);
-} else if (new File("/sbin/ifconfig").exists()) {
-p = Runtime.getRuntime().exec(new String[] {"/sbin/ifconfig",
"-a"}, null);
-}
-
-if (p != null) {
-in = new BufferedReader(new
InputStreamReader(p.getInputStream()), 128);
-String l = null;
-while ((l = in.readLine()) != null) {
-macAddress = MacAddress.parse(l);
-if (macAddress != null) {
-short parsedShortMacAddress =
MacAddress.parseShort(macAddress);
-if (parsedShortMacAddress != 0xff &&
parsedShortMacAddress != 0x00)
-break;
-}
-macAddress = null;
-}
-}
-
-} catch (SecurityException ex) {
-s_logger.info("[ignored] security exception in static initializer
of MacAddress", ex);
-} catch (IOException ex) {
-s_logger.info("[ignored] io exception in static initializer of
MacAddress");
-} finally {
-if (p != null) {
-closeAutoCloseable(in, "closing init process input stream");
-closeAutoCloseable(p.getErrorStream(), "closing init process
error output stream");
-closeAutoCloseable(p.getOutputStream(), "closing init process
std output stream");
-p.destroy();
-}
+Enumeration networkInterfaces =
NetworkInterface.getNetworkInterfaces();
+while (networkInterfaces.hasMoreElements()) {
+ NetworkInterface network = networkInterfaces.nextElement();
+ final byte [] mac = network.getHardwareAddress();
+ if (mac != null && !network.isVirtual() &&
+ !network.getName().startsWith("br-") &&
+ !network.getName().startsWith("veth") &&
+ !network.getName().startsWith("vnet")) {
+ StringBuilder macAddressBuilder = new StringBuilder();
+ for (byte b : mac) {
+ macAddressBuilder.append(String.format("%02X", b));
+ }
+ macAddress = macAddressBuilder.toString();
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] System VM / Agent on KVM host does not support NFSv3 on Secondary Storage [cloudstack]
weizhouapache commented on issue #8996: URL: https://github.com/apache/cloudstack/issues/8996#issuecomment-2079911841 > This bug is probably related to the first bug I submitted, ie, the zone set up let me configure secondary storage that it could not actually make use of and no errors were shown. Since then I fixed secondary storage, manually deleted the old storage and am still debugging other issues. > good, thanks for the update @Jayd603 do you consider re-create the zone ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] System VM / Agent on KVM host does not support NFSv3 on Secondary Storage [cloudstack]
Jayd603 commented on issue #8996: URL: https://github.com/apache/cloudstack/issues/8996#issuecomment-2079897685 This bug is probably related to the first bug I submitted, ie, the zone set up let me configure secondary storage that it could not actually make use of and no errors were shown. Since then I fixed secondary storage, manaully deleted the old storage and am still debugging other issues. > > > Update /etc/nfsmount.conf to set the NFS version to 4.0 and retry > > > > > > Thanks but the storage server I am using actually only supports nfsv3 due to legacy clients making use of it. I can use iscsi or another nfs server BUT i'd like to use nfsv3 on this one server preferably. > > Also do you mean on the host system? because that file doesn't exist in ubuntu and the KVM host system can mount fine when I mount from command line using the same mount command in the logs. > > @Jayd603 I noticed you have some update, what's the current status ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] System VM / Agent on KVM host does not support NFSv3 on Secondary Storage [cloudstack]
weizhouapache commented on issue #8996: URL: https://github.com/apache/cloudstack/issues/8996#issuecomment-2079890833 > > Update /etc/nfsmount.conf to set the NFS version to 4.0 and retry > > Thanks but the storage server I am using actually only supports nfsv3 due to legacy clients making use of it. I can use iscsi or another nfs server BUT i'd like to use nfsv3 on this one server preferably. > > Also do you mean on the host system? because that file doesn't exist in ubuntu and the KVM host system can mount fine when I mount from command line using the same mount command in the logs. @Jayd603 I noticed you have some update, what's the current status ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2079890508 [SF] Trillian test result (tid-10041) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47282 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8980-t10041-kvm-centos7.zip Smoke tests completed. 129 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 420.84 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Use parameter dcId as wrapper to prevent NPE [cloudstack]
blueorangutan commented on PR #8986: URL: https://github.com/apache/cloudstack/pull/8986#issuecomment-2079869662 @weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Use parameter dcId as wrapper to prevent NPE [cloudstack]
weizhouapache commented on PR #8986: URL: https://github.com/apache/cloudstack/pull/8986#issuecomment-2079867296 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] IP address conflicts held by public IPs of virtual routers [cloudstack]
vdombrovski commented on issue #8967: URL: https://github.com/apache/cloudstack/issues/8967#issuecomment-2079829634 @DaanHoogland yes correct, released after I wrote my comment, which means we will surely plan our tests now. As for proof inside the DB, I've ran more tests, and I can most definitely introduce inconsistencies. For example, my last test got an IP with allocated=NULL but state=Allocated, which in practice means this ip is now unusable until I manually reset it in the database (it cannot be assigned, it cannot be released). ``` select * from user_ip_address where public_ip_address="XX.YY.17.30" \G; *** 1. row *** id: 107 uuid: f1988f51-c9e5-46e4-9393-2a873b2610e0 account_id: NULL domain_id: NULL public_ip_address: XX.YY.17.30 data_center_id: 1 source_nat: 0 allocated: NULL vlan_db_id: 2 one_to_one_nat: 0 vm_id: NULL state: Allocated mac_address: 139 source_network_id: 200 network_id: 225 physical_network_id: 200 is_system: 0 vpc_id: NULL dnat_vmip: NULL is_portable: 0 display: 1 removed: NULL created: NULL rule_state: NULL forsystemvms: 0 ``` Note that all these cases are introduced without any modifications to my original test; I'm simply changing the timings of when I start test1.sh and test2.sh I'll run some more tests, and report any additional anomalies I find. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Use parameter dcId as wrapper to prevent NPE [cloudstack]
KlausDornsbach commented on PR #8986: URL: https://github.com/apache/cloudstack/pull/8986#issuecomment-2079819706 CLGTM. Also done some testing: 1. Remove NFS secondary storage. 2. Create AWS Bucket, generate access and secret keys. 3. Add the S3 secondary storage bucket to ACS with success and no errors on logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] System VM / Agent on KVM host does not support NFSv3 on Secondary Storage [cloudstack]
Jayd603 commented on issue #8996: URL: https://github.com/apache/cloudstack/issues/8996#issuecomment-2079756749 > Update /etc/nfsmount.conf to set the NFS version to 4.0 and retry Thanks but the server I am using actually only supports nfsv3 due to legacy clients making use of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] System VM / Agent on KVM host does not support NFSv3 on Secondary Storage [cloudstack]
weizhouapache commented on issue #8996: URL: https://github.com/apache/cloudstack/issues/8996#issuecomment-2079755098 Update /etc/nfsmount.conf to set the NFS version to 4.0 and retry -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up Python code; Python `2` to `3` [cloudstack]
blueorangutan commented on PR #8993: URL: https://github.com/apache/cloudstack/pull/8993#issuecomment-2079739683 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add password enabled during ISO register and update [cloudstack]
codecov-commenter commented on PR #8992: URL: https://github.com/apache/cloudstack/pull/8992#issuecomment-2079732337 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8992?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.26%. Comparing base [(`a5508ac`)](https://app.codecov.io/gh/apache/cloudstack/commit/a5508acc54d1638ba469f4d7ce9898b81b5209d0?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`f18483b`)](https://app.codecov.io/gh/apache/cloudstack/pull/8992?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 631 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8992 +/- ## - Coverage 13.17% 4.26%-8.91% Files 2725 363 -2362 Lines258235 29556 -228679 Branches 402495188-35061 - Hits 340131262-32751 + Misses 219913 28152 -191761 + Partials 4309 142 -4167 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8992/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8992/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.26% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8992?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] VNF: add API listVnfAppliances [cloudstack]
blueorangutan commented on PR #8994: URL: https://github.com/apache/cloudstack/pull/8994#issuecomment-2079665237 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up Python code; Python `2` to `3` [cloudstack]
blueorangutan commented on PR #8993: URL: https://github.com/apache/cloudstack/pull/8993#issuecomment-2079603515 @jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up Python code; Python `2` to `3` [cloudstack]
jbampton commented on PR #8993: URL: https://github.com/apache/cloudstack/pull/8993#issuecomment-2079600356 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Unstable 4.19 and main branch smoketests [cloudstack]
weizhouapache commented on issue #8931:
URL: https://github.com/apache/cloudstack/issues/8931#issuecomment-2079559208
I updated the integration test
```
diff --git a/test/integration/smoke/test_events_resource.py
b/test/integration/smoke/test_events_resource.py
index 660cbd37bce..4bbab66532f 100644
--- a/test/integration/smoke/test_events_resource.py
+++ b/test/integration/smoke/test_events_resource.py
@@ -16,7 +16,6 @@
# under the License.
""" BVT tests for Events Resource
"""
-import json
import os
import tempfile
import time
@@ -185,7 +184,7 @@ class TestEventsResource(cloudstackTestCase):
for event in events:
if event.type.startswith("VM.") or
(event.type.startswith("NETWORK.") and not
event.type.startswith("NETWORK.ELEMENT")) or event.type.startswith("VOLUME.")
or event.type.startswith("ACCOUNT.") or event.type.startswith("DOMAIN.") or
event.type.startswith("TEMPLATE."):
if event.resourceid is None or event.resourcetype is None:
-self.debug("Failed event:: %s" % json.dumps(event,
indent=2))
+self.debug("Failed event:: %s" % event)
self.fail("resourceid or resourcetype for the event not
found!")
else:
self.debug("Event %s at %s:: Resource Type: %s,
Resource ID: %s" % (event.type, event.created, event.resourcetype,
event.resourceid))
```
and got the following error (`resourceid` is not found)
`
test_01_events_resource
(tests.smoke.test_events_resource.TestEventsResource): DEBUG: Failed event::
{id : '4a7bbf38-35ee-42d3-ada6-09ffc20b702c', username : 'admin', type :
'VOLUME.DESTROY', level : 'INFO', description : 'Successfully completed
destroying a volume', account : 'admin', domainid :
'37ff2485-cc1e-11ee-a4eb-1e00db000197', domain : 'ROOT', resourcetype :
'Volume', created : '2024-04-26T13:24:11+', state : 'Completed'}
`
it looks the error `test_01_events_resource` is caused by #8800 (merged on
2024-04-12)
cc @vishesh92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Initial zone set-up does not verify usable secondary storage - leads to issues [cloudstack]
boring-cyborg[bot] commented on issue #8995: URL: https://github.com/apache/cloudstack/issues/8995#issuecomment-2079548780 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Initial zone set-up does not verify usable secondary storage - leads to issues [cloudstack]
Jayd603 opened a new issue, #8995: URL: https://github.com/apache/cloudstack/issues/8995 Latest cloudstack, I just did a new cloudstack install, set up first zone, I accidentally used the wrong secondary NFS storage path, the set-up process gave no errors. Now, after creating new and correct secondary storage, I cannot migrate and cannot delete the old one. Zone set-up script should test connection and write ability of the secondary storage I'm thinking. Now i'm just looking for best way to fix, might just be easier to destroy the zone and re-create. Oh, and, there are now templates and ISOs in "Not Ready" state with no option to remove them in the UI. I'm trying to fix in the db now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] VNF: add API listVnfAppliances [cloudstack]
codecov-commenter commented on PR #8994: URL: https://github.com/apache/cloudstack/pull/8994#issuecomment-2079548300 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8994?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.31%. Comparing base [(`e409c6d`)](https://app.codecov.io/gh/apache/cloudstack/commit/e409c6d870a49762fb4e730ad118a3a836715cc5?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`15d740f`)](https://app.codecov.io/gh/apache/cloudstack/pull/8994?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #8994 +/- ## - Coverage 14.96% 4.31% -10.65% Files 5373 363 -5010 Lines468989 29171 -439818 Branches 610095089-55920 - Hits 701911260-68931 + Misses 391019 27770 -363249 + Partials 7779 141 -7638 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8994/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8994/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.31% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/8994/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8994?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] VNF: add API listVnfAppliances [cloudstack]
blueorangutan commented on PR #8994: URL: https://github.com/apache/cloudstack/pull/8994#issuecomment-2079536410 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] VNF: add API listVnfAppliances [cloudstack]
weizhouapache commented on PR #8994: URL: https://github.com/apache/cloudstack/pull/8994#issuecomment-2079532671 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] VNF: add API listVnfAppliances [cloudstack]
weizhouapache opened a new pull request, #8994:
URL: https://github.com/apache/cloudstack/pull/8994
### Description
This PR fixes #8979
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Clean up Python code; Python `2` to `3` [cloudstack]
codecov-commenter commented on PR #8993: URL: https://github.com/apache/cloudstack/pull/8993#issuecomment-2079514027 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8993?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.26%. Comparing base [(`6e823b2`)](https://app.codecov.io/gh/apache/cloudstack/commit/6e823b2cd34cea489a400a5b344c7b7d8c3c76ae?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`b3a1509`)](https://app.codecov.io/gh/apache/cloudstack/pull/8993?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ##main #8993 +/- ## = Coverage 4.26% 4.26% = Files363 363 Lines 29556 29556 Branches51885188 = Hits12621262 Misses 28152 28152 Partials 142 142 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8993/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8993/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.26% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8993?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Cannot remove Secondary storage after using new feature "migration of secondary storage" [cloudstack]
Jayd603 commented on issue #4613: URL: https://github.com/apache/cloudstack/issues/4613#issuecomment-2079503884 I just did a new cloudstack install, set up first zone, I accidentally used the wrong secondary storage path, the set-up process gave no errors. Now, after creating new and correct secondary storage, I cannot migrate and cannot delete the old one. Zone set-up script should test connection and write ability of the secondary storage I'm thinking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Clean up Python code; Python `2` to `3` [cloudstack]
jbampton opened a new pull request, #8993:
URL: https://github.com/apache/cloudstack/pull/8993
### Description
This PR cleans up some Python code. Mainly `print` statements.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] add password enabled during ISO register and update [cloudstack]
GaOrtiga opened a new pull request, #8992:
URL: https://github.com/apache/cloudstack/pull/8992
### Description
The parameter `passwordenabled` is available on the APIs that register and
update ISOs, however, it had not been added to the UI yet.
This parameter was added to the UI, making it possible to specify it when
registering/updating ISOs.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### Screenshots (if appropriate):
Before
After
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Ubuntu 24.04 support [cloudstack]
weizhouapache commented on issue #8991: URL: https://github.com/apache/cloudstack/issues/8991#issuecomment-2079384769 +1 Do we consider it in 4.19.1? @sureshanaparti @rohityadavcloud @DaanHoogland -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2079363901 [SF] Trillian test result (tid-10040) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9 Total time taken: 51459 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8922-t10040-vmware-70u3.zip Smoke tests completed. 129 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 335.27 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Ubuntu 24.04 support [cloudstack]
fmcwebs opened a new issue, #8991: URL: https://github.com/apache/cloudstack/issues/8991 # ISSUE TYPE * Enhancement Request # COMPONENT NAME ~~~ OS Support ~~~ # CLOUDSTACK VERSION ~~~ 4.18 / 4.19 ~~~ # CONFIGURATION # OS / ENVIRONMENT Ubuntu 24.04 # SUMMARY It will be great to add support for Ubuntu 24.04 to the hosts. # STEPS TO REPRODUCE ~~~ ~~~ # EXPECTED RESULTS ~~~ ~~~ # ACTUAL RESULTS ~~~ ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling, word case, duplicate words in code comments only [cloudstack]
DaanHoogland closed pull request #8987: Fix spelling, word case, duplicate words in code comments only URL: https://github.com/apache/cloudstack/pull/8987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]
sureshanaparti commented on code in PR #8988:
URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1580998790
##
utils/src/main/java/com/cloud/utils/net/MacAddress.java:
##
@@ -79,209 +72,45 @@ public String toString() {
static {
String macAddress = null;
-Process p = null;
-BufferedReader in = null;
-
try {
-String osname = System.getProperty("os.name");
-
-if (osname.startsWith("Windows")) {
-p = Runtime.getRuntime().exec(new String[] {"ipconfig",
"/all"}, null);
-} else if (osname.startsWith("Solaris") ||
osname.startsWith("SunOS")) {
-// Solaris code must appear before the generic code
-String hostName = MacAddress.getFirstLineOfCommand(new
String[] {"uname", "-n"});
-if (hostName != null) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/arp", hostName}, null);
-}
-} else if (new File("/usr/sbin/lanscan").exists()) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/lanscan"}, null);
-} else if (new File("/sbin/ifconfig").exists()) {
-p = Runtime.getRuntime().exec(new String[] {"/sbin/ifconfig",
"-a"}, null);
-}
-
-if (p != null) {
-in = new BufferedReader(new
InputStreamReader(p.getInputStream()), 128);
-String l = null;
-while ((l = in.readLine()) != null) {
-macAddress = MacAddress.parse(l);
-if (macAddress != null) {
-short parsedShortMacAddress =
MacAddress.parseShort(macAddress);
-if (parsedShortMacAddress != 0xff &&
parsedShortMacAddress != 0x00)
-break;
-}
-macAddress = null;
-}
-}
-
-} catch (SecurityException ex) {
-s_logger.info("[ignored] security exception in static initializer
of MacAddress", ex);
-} catch (IOException ex) {
-s_logger.info("[ignored] io exception in static initializer of
MacAddress");
-} finally {
-if (p != null) {
-closeAutoCloseable(in, "closing init process input stream");
-closeAutoCloseable(p.getErrorStream(), "closing init process
error output stream");
-closeAutoCloseable(p.getOutputStream(), "closing init process
std output stream");
-p.destroy();
-}
+Enumeration networkInterfaces =
NetworkInterface.getNetworkInterfaces();
+while (networkInterfaces.hasMoreElements()) {
+ NetworkInterface network = networkInterfaces.nextElement();
+ final byte [] mac = network.getHardwareAddress();
+ if (mac != null && !network.isVirtual() &&
+ !network.getName().startsWith("br-") &&
+ !network.getName().startsWith("veth") &&
+ !network.getName().startsWith("vnet")) {
+ StringBuilder macAddressBuilder = new StringBuilder();
+ for (byte b : mac) {
+ macAddressBuilder.append(String.format("%02X", b));
+ }
+ macAddress = macAddressBuilder.toString();
+ }
+ }
+} catch (SocketException ignore) {
Review Comment:
want to log exception here, in case any issues while fetching network
information?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]
sureshanaparti commented on code in PR #8988:
URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1580995715
##
utils/src/main/java/com/cloud/utils/net/MacAddress.java:
##
@@ -79,209 +72,45 @@ public String toString() {
static {
String macAddress = null;
-Process p = null;
-BufferedReader in = null;
-
try {
-String osname = System.getProperty("os.name");
-
-if (osname.startsWith("Windows")) {
-p = Runtime.getRuntime().exec(new String[] {"ipconfig",
"/all"}, null);
-} else if (osname.startsWith("Solaris") ||
osname.startsWith("SunOS")) {
-// Solaris code must appear before the generic code
-String hostName = MacAddress.getFirstLineOfCommand(new
String[] {"uname", "-n"});
-if (hostName != null) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/arp", hostName}, null);
-}
-} else if (new File("/usr/sbin/lanscan").exists()) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/lanscan"}, null);
-} else if (new File("/sbin/ifconfig").exists()) {
-p = Runtime.getRuntime().exec(new String[] {"/sbin/ifconfig",
"-a"}, null);
-}
-
-if (p != null) {
-in = new BufferedReader(new
InputStreamReader(p.getInputStream()), 128);
-String l = null;
-while ((l = in.readLine()) != null) {
-macAddress = MacAddress.parse(l);
-if (macAddress != null) {
-short parsedShortMacAddress =
MacAddress.parseShort(macAddress);
-if (parsedShortMacAddress != 0xff &&
parsedShortMacAddress != 0x00)
-break;
-}
-macAddress = null;
-}
-}
-
-} catch (SecurityException ex) {
-s_logger.info("[ignored] security exception in static initializer
of MacAddress", ex);
-} catch (IOException ex) {
-s_logger.info("[ignored] io exception in static initializer of
MacAddress");
-} finally {
-if (p != null) {
-closeAutoCloseable(in, "closing init process input stream");
-closeAutoCloseable(p.getErrorStream(), "closing init process
error output stream");
-closeAutoCloseable(p.getOutputStream(), "closing init process
std output stream");
-p.destroy();
-}
+Enumeration networkInterfaces =
NetworkInterface.getNetworkInterfaces();
+while (networkInterfaces.hasMoreElements()) {
+ NetworkInterface network = networkInterfaces.nextElement();
+ final byte [] mac = network.getHardwareAddress();
+ if (mac != null && !network.isVirtual() &&
+ !network.getName().startsWith("br-") &&
+ !network.getName().startsWith("veth") &&
+ !network.getName().startsWith("vnet")) {
+ StringBuilder macAddressBuilder = new StringBuilder();
+ for (byte b : mac) {
+ macAddressBuilder.append(String.format("%02X", b));
+ }
+ macAddress = macAddressBuilder.toString();
Review Comment:
break loop here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] list VMs by displayname instead of name [cloudstack]
blueorangutan commented on PR #8503: URL: https://github.com/apache/cloudstack/pull/8503#issuecomment-2079332819 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8503 (QA-JID-325) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079323373 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]
BryanMLima commented on code in PR #8978:
URL: https://github.com/apache/cloudstack/pull/8978#discussion_r1580981216
##
ui/src/store/modules/permission.js:
##
@@ -17,24 +17,39 @@
import { asyncRouterMap, constantRouterMap } from '@/config/router'
-function hasApi (apis, route) {
- if (route.meta && route.meta.permission) {
-for (const permission of route.meta.permission) {
- if (!apis.includes(permission)) {
-return false
- }
-}
+function hasAccessToRoute (apis, route) {
+ if (!route.meta || !route.meta.permission) {
Review Comment:
Could use optional chaining here, no?
```suggestion
if (!route.meta?.permission) {
```
##
ui/src/store/modules/permission.js:
##
@@ -17,24 +17,39 @@
import { asyncRouterMap, constantRouterMap } from '@/config/router'
-function hasApi (apis, route) {
- if (route.meta && route.meta.permission) {
-for (const permission of route.meta.permission) {
- if (!apis.includes(permission)) {
-return false
- }
-}
+function hasAccessToRoute (apis, route) {
+ if (!route.meta || !route.meta.permission) {
return true
}
+ for (const permission of route.meta.permission) {
+if (!apis.includes(permission)) {
+ return false
+}
+ }
+ return true
+}
+
+function hasAccessToSection (route) {
+ const visibleChildren = route.children.filter(child => !child.hidden)
+ if (visibleChildren.length === 0) {
+return false
+ }
+ const redirect = '/' + visibleChildren[0].meta.name
+ if (redirect !== route.path) {
+route.redirect = redirect
+ }
return true
}
function filterAsyncRouter (routerMap, apis) {
const accessedRouters = routerMap.filter(route => {
-if (hasApi(apis, route)) {
+if (hasAccessToRoute(apis, route)) {
if (route.children && route.children.length > 0) {
route.children = filterAsyncRouter(route.children, apis)
}
+ if (route.meta && route.meta.section) {
Review Comment:
Could use optional chaining here, no?
```suggestion
if (route.meta?.section) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]
BryanMLima commented on code in PR #8978:
URL: https://github.com/apache/cloudstack/pull/8978#discussion_r1580985185
##
ui/src/store/modules/permission.js:
##
@@ -17,24 +17,39 @@
import { asyncRouterMap, constantRouterMap } from '@/config/router'
-function hasApi (apis, route) {
- if (route.meta && route.meta.permission) {
-for (const permission of route.meta.permission) {
- if (!apis.includes(permission)) {
-return false
- }
-}
+function hasAccessToRoute (apis, route) {
+ if (!route.meta || !route.meta.permission) {
Review Comment:
Never mind, did not see it was already merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]
sureshanaparti commented on code in PR #8988:
URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1580982750
##
utils/src/main/java/com/cloud/utils/net/MacAddress.java:
##
@@ -79,209 +72,45 @@ public String toString() {
static {
String macAddress = null;
-Process p = null;
-BufferedReader in = null;
-
try {
-String osname = System.getProperty("os.name");
-
-if (osname.startsWith("Windows")) {
-p = Runtime.getRuntime().exec(new String[] {"ipconfig",
"/all"}, null);
-} else if (osname.startsWith("Solaris") ||
osname.startsWith("SunOS")) {
-// Solaris code must appear before the generic code
-String hostName = MacAddress.getFirstLineOfCommand(new
String[] {"uname", "-n"});
-if (hostName != null) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/arp", hostName}, null);
-}
-} else if (new File("/usr/sbin/lanscan").exists()) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/lanscan"}, null);
-} else if (new File("/sbin/ifconfig").exists()) {
-p = Runtime.getRuntime().exec(new String[] {"/sbin/ifconfig",
"-a"}, null);
-}
-
-if (p != null) {
-in = new BufferedReader(new
InputStreamReader(p.getInputStream()), 128);
-String l = null;
-while ((l = in.readLine()) != null) {
-macAddress = MacAddress.parse(l);
-if (macAddress != null) {
-short parsedShortMacAddress =
MacAddress.parseShort(macAddress);
-if (parsedShortMacAddress != 0xff &&
parsedShortMacAddress != 0x00)
-break;
-}
-macAddress = null;
-}
-}
-
-} catch (SecurityException ex) {
-s_logger.info("[ignored] security exception in static initializer
of MacAddress", ex);
-} catch (IOException ex) {
-s_logger.info("[ignored] io exception in static initializer of
MacAddress");
-} finally {
-if (p != null) {
-closeAutoCloseable(in, "closing init process input stream");
-closeAutoCloseable(p.getErrorStream(), "closing init process
error output stream");
-closeAutoCloseable(p.getOutputStream(), "closing init process
std output stream");
-p.destroy();
-}
+Enumeration networkInterfaces =
NetworkInterface.getNetworkInterfaces();
+while (networkInterfaces.hasMoreElements()) {
+ NetworkInterface network = networkInterfaces.nextElement();
+ final byte [] mac = network.getHardwareAddress();
Review Comment:
```suggestion
final byte[] mac = network.getHardwareAddress();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
weizhouapache commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079320521 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Order the `.gitignore` file [cloudstack]
DaanHoogland merged PR #8989: URL: https://github.com/apache/cloudstack/pull/8989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated (00ee5fd4298 -> 6e823b2cd34)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 00ee5fd4298 Show menu section if user has access to at least one of its pages (#8978) add 6e823b2cd34 Order the `.gitignore` file (#8989) No new revisions were added by this update. Summary of changes: .gitignore | 134 ++--- 1 file changed, 67 insertions(+), 67 deletions(-)
Re: [PR] Accept a role ID on linking an account to LDAP [cloudstack]
blueorangutan commented on PR #8236: URL: https://github.com/apache/cloudstack/pull/8236#issuecomment-2079309379 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]
blueorangutan commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2079309332 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] list VMs by displayname instead of name [cloudstack]
blueorangutan commented on PR #8503: URL: https://github.com/apache/cloudstack/pull/8503#issuecomment-2079310865 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] list VMs by displayname instead of name [cloudstack]
DaanHoogland commented on PR #8503: URL: https://github.com/apache/cloudstack/pull/8503#issuecomment-2079309205 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]
DaanHoogland commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2079306991 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Accept a role ID on linking an account to LDAP [cloudstack]
DaanHoogland commented on PR #8236: URL: https://github.com/apache/cloudstack/pull/8236#issuecomment-2079306095 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [UI] Storage menu not showing even with API permissions [cloudstack]
DaanHoogland closed issue #8730: [UI] Storage menu not showing even with API permissions URL: https://github.com/apache/cloudstack/issues/8730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]
DaanHoogland commented on PR #8978: URL: https://github.com/apache/cloudstack/pull/8978#issuecomment-2079299649 > I suppose that the user you created was `cripple`. I verified that it did not have access to `listZones`, which is an API users are unable to login without. This behavior has nothing to do with the changes here, and you can verify that this account is unable to login in the QA of other PRs as well. you are right, I added `listZones` and cripple can login with all menus available. :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated: Show menu section if user has access to at least one of its pages (#8978)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 00ee5fd4298 Show menu section if user has access to at least one of
its pages (#8978)
00ee5fd4298 is described below
commit 00ee5fd429829ba467d72d8b02b87a804dac2d6c
Author: Fabricio Duarte
AuthorDate: Fri Apr 26 09:34:06 2024 -0300
Show menu section if user has access to at least one of its pages (#8978)
---
ui/src/config/router.js| 5 ++---
ui/src/store/modules/permission.js | 31 +++
2 files changed, 25 insertions(+), 11 deletions(-)
diff --git a/ui/src/config/router.js b/ui/src/config/router.js
index c3b69bde23a..b4570dbcee8 100644
--- a/ui/src/config/router.js
+++ b/ui/src/config/router.js
@@ -51,14 +51,13 @@ function generateRouterMap (section) {
icon: section.icon,
docHelp: vueProps.$applyDocHelpMappings(section.docHelp),
searchFilters: section.searchFilters,
- related: section.related
+ related: section.related,
+ section: true
},
component: shallowRef(RouteView)
}
if (section.children && section.children.length > 0) {
-map.redirect = '/' + section.children[0].name
-map.meta.permission = section.children[0].permission
map.children = []
for (const child of section.children) {
if ('show' in child && !child.show()) {
diff --git a/ui/src/store/modules/permission.js
b/ui/src/store/modules/permission.js
index 3b080be5f63..ad11fe5a8d0 100644
--- a/ui/src/store/modules/permission.js
+++ b/ui/src/store/modules/permission.js
@@ -17,24 +17,39 @@
import { asyncRouterMap, constantRouterMap } from '@/config/router'
-function hasApi (apis, route) {
- if (route.meta && route.meta.permission) {
-for (const permission of route.meta.permission) {
- if (!apis.includes(permission)) {
-return false
- }
-}
+function hasAccessToRoute (apis, route) {
+ if (!route.meta || !route.meta.permission) {
return true
}
+ for (const permission of route.meta.permission) {
+if (!apis.includes(permission)) {
+ return false
+}
+ }
+ return true
+}
+
+function hasAccessToSection (route) {
+ const visibleChildren = route.children.filter(child => !child.hidden)
+ if (visibleChildren.length === 0) {
+return false
+ }
+ const redirect = '/' + visibleChildren[0].meta.name
+ if (redirect !== route.path) {
+route.redirect = redirect
+ }
return true
}
function filterAsyncRouter (routerMap, apis) {
const accessedRouters = routerMap.filter(route => {
-if (hasApi(apis, route)) {
+if (hasAccessToRoute(apis, route)) {
if (route.children && route.children.length > 0) {
route.children = filterAsyncRouter(route.children, apis)
}
+ if (route.meta && route.meta.section) {
+return hasAccessToSection(route)
+ }
return true
}
return false
Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]
DaanHoogland merged PR #8978: URL: https://github.com/apache/cloudstack/pull/8978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2079294747 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] list VMs by displayname instead of name [cloudstack]
codecov-commenter commented on PR #8503: URL: https://github.com/apache/cloudstack/pull/8503#issuecomment-2079290539 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8503?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `50.14767%` with `844 lines` in your changes are missing coverage. Please review. > Project coverage is 30.73%. Comparing base [(`76aff0f`)](https://app.codecov.io/gh/apache/cloudstack/commit/76aff0f422a476f1de720999d309f8f07756cd50?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`8cb9dcf`)](https://app.codecov.io/gh/apache/cloudstack/pull/8503?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 56 commits behind head on 4.18. > :exclamation: Current head 8cb9dcf differs from pull request most recent head 36be215. Consider uploading reports for the commit 36be215 to get more accurate results | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8503?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [api/src/main/java/com/cloud/gpu/GPU.java](https://app.codecov.io/gh/apache/cloudstack/pull/8503?src=pr=tree=api%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fgpu%2FGPU.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2dwdS9HUFUuamF2YQ==) | 0.00% | [98 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8503?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...apache/cloudstack/api/response/BucketResponse.java](https://app.codecov.io/gh/apache/cloudstack/pull/8503?src=pr=tree=api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fapi%2Fresponse%2FBucketResponse.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9yZXNwb25zZS9CdWNrZXRSZXNwb25zZS5qYXZh) | 0.00% | [69 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8503?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...stack/api/command/user/bucket/CreateBucketCmd.java](https://app.codecov.io/gh/apache/cloudstack/pull/8503?src=pr=tree=api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fapi%2Fcommand%2Fuser%2Fbucket%2FCreateBucketCmd.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9jb21tYW5kL3VzZXIvYnVja2V0L0NyZWF0ZUJ1Y2tldENtZC5qYXZh) | 2.56% | [38 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8503?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...i/response/SecondaryStorageHeuristicsResponse.java](https://app.codecov.io/gh/apache/cloudstack/pull/8503?src=pr=tree=api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fapi%2Fresponse%2FSecondaryStorageHeuristicsResponse.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9yZXNwb25zZS9TZWNvbmRhcnlTdG9yYWdlSGV1cmlzdGljc1Jlc3BvbnNlLmphdmE=) | 0.00% | [34 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8503?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...nt/resource/consoleproxy/ConsoleProxyResource.java](https://app.codecov.io/gh/apache/cloudstack/pull/8503?src=pr=tree=agent%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fagent%2Fresource%2Fconsoleproxy%2FConsoleProxyResource.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YWdlbnQvc3JjL21haW4vamF2YS9jb20vY2xvdWQvYWdlbnQvcmVzb3VyY2UvY29uc29sZXByb3h5L0NvbnNvbGVQcm94eVJlc291cmNlLmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8503?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...e/cloudstack/api/command/admin/vm/ImportVmCmd.java](https://app.codecov.io/gh/apache/cloudstack/pull/8503?src=pr=tree=api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fapi%2Fcommand%2Fadmin%2Fvm%2FImportVmCmd.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9jb21tYW5kL2FkbWluL3ZtL0ltcG9ydFZtQ21kLmphdmE=) | 3.12% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8503?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | |
(cloudstack) branch 4.18 updated: linstor: cleanup diskless nodes on disconnect (#8790)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.18 by this push:
new 9d5d4e55648 linstor: cleanup diskless nodes on disconnect (#8790)
9d5d4e55648 is described below
commit 9d5d4e55648c279c7d462d26469d07174bcd0701
Author: Rene Peinthor
AuthorDate: Fri Apr 26 14:25:07 2024 +0200
linstor: cleanup diskless nodes on disconnect (#8790)
---
.../kvm/storage/LinstorStorageAdaptor.java | 114 +
1 file changed, 74 insertions(+), 40 deletions(-)
diff --git
a/plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java
b/plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java
index 66278f827f7..b38ab382a42 100644
---
a/plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java
+++
b/plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java
@@ -38,6 +38,7 @@ import org.libvirt.LibvirtException;
import com.cloud.storage.Storage;
import com.cloud.utils.exception.CloudRuntimeException;
import com.linbit.linstor.api.ApiClient;
+import com.linbit.linstor.api.ApiConsts;
import com.linbit.linstor.api.ApiException;
import com.linbit.linstor.api.Configuration;
import com.linbit.linstor.api.DevelopersApi;
@@ -103,6 +104,10 @@ public class LinstorStorageAdaptor implements
StorageAdaptor {
}
}
+private void logLinstorAnswers(@Nonnull ApiCallRcList answers) {
+answers.forEach(this::logLinstorAnswer);
+}
+
private void checkLinstorAnswersThrow(@Nonnull ApiCallRcList answers) {
answers.forEach(this::logLinstorAnswer);
if (answers.hasError())
@@ -316,23 +321,90 @@ public class LinstorStorageAdaptor implements
StorageAdaptor {
return true;
}
+private boolean tryDisconnectLinstor(String volumePath, KVMStoragePool
pool)
+{
+if (volumePath == null) {
+return false;
+}
+
+s_logger.debug("Linstor: Using storage pool: " + pool.getUuid());
+final DevelopersApi api = getLinstorAPI(pool);
+
+Optional optRsc;
+try
+{
+List resources = api.viewResources(
+Collections.singletonList(localNodeName),
+null,
+null,
+null,
+null,
+null);
+
+optRsc = getResourceByPath(resources, volumePath);
+} catch (ApiException apiEx) {
+// couldn't query linstor controller
+s_logger.error(apiEx.getBestMessage());
+return false;
+}
+
+
+if (optRsc.isPresent()) {
+try {
+Resource rsc = optRsc.get();
+
+// if diskless resource remove it, in the worst case it will
be transformed to a tiebreaker
+if (rsc.getFlags() != null &&
+rsc.getFlags().contains(ApiConsts.FLAG_DRBD_DISKLESS)
&&
+!rsc.getFlags().contains(ApiConsts.FLAG_TIE_BREAKER)) {
+ApiCallRcList delAnswers =
api.resourceDelete(rsc.getName(), localNodeName);
+logLinstorAnswers(delAnswers);
+}
+
+// remove allow-two-primaries
+ResourceDefinitionModify rdm = new ResourceDefinitionModify();
+
rdm.deleteProps(Collections.singletonList("DrbdOptions/Net/allow-two-primaries"));
+ApiCallRcList answers =
api.resourceDefinitionModify(rsc.getName(), rdm);
+if (answers.hasError()) {
+s_logger.error(
+String.format("Failed to remove
'allow-two-primaries' on %s: %s",
+rsc.getName(),
LinstorUtil.getBestErrorMessage(answers)));
+// do not fail here as removing allow-two-primaries
property isn't fatal
+}
+} catch (ApiException apiEx) {
+s_logger.error(apiEx.getBestMessage());
+// do not fail here as removing allow-two-primaries property
or deleting diskless isn't fatal
+}
+
+return true;
+}
+
+s_logger.warn("Linstor: Couldn't find resource for this path: " +
volumePath);
+return false;
+}
+
@Override
public boolean disconnectPhysicalDisk(String volumePath, KVMStoragePool
pool)
{
s_logger.debug("Linstor: disconnectPhysicalDisk " + pool.getUuid() +
":" + volumePath);
+if (MapStorageUuidToStoragePool.containsValue(pool)) {
+return tryDisconnectLinstor(volumePath, pool);
+}
return false;
}
@Override
public boolean disconnectPhysicalDisk(Map
Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]
winterhazel commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2079286992 @DaanHoogland GHI tests are passing now ;) Can you run the CI one last time so we can proceed with this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]
DaanHoogland merged PR #8790: URL: https://github.com/apache/cloudstack/pull/8790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Accept a role ID on linking an account to LDAP [cloudstack]
blueorangutan commented on PR #8236: URL: https://github.com/apache/cloudstack/pull/8236#issuecomment-2079274145 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: improve listVM API handling and response speed [cloudstack]
JoaoJandre commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2079269843 Hello @rohityadavcloud , @weizhouapache Looking briefly at this PR I noticed that it has a big intersection with #8782, especially the changes on the listVirtualMachines and listVirtualMachineMetrics APIs. When #8782 proposed to change the default behavior of them to not list the stats, both @weizhouapache and @rohityadavcloud were firmly against changing the default behavior (see https://github.com/apache/cloudstack/pull/8782#issuecomment-1995297443 and https://github.com/apache/cloudstack/pull/8782#issuecomment-1997341885). So now, only a month later, we get this PR: what is the big difference on these two PRs? And if there is, why not just propose an adjustment to #8782? In any case, this PR not only breaks compatibility on the APIs, but also changes the default value of another configuration; and all this is going into 4.18! Are we going to introduce breaking changes on a maintenance version? I would really like to understand what made you change your opinion on compatibility so fast. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]
blueorangutan commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2079270686 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]
winterhazel commented on PR #8978: URL: https://github.com/apache/cloudstack/pull/8978#issuecomment-2079268907 > @winterhazel @bernardodemarco I tried this in qa: > > ``` > I created a role based on the Read-Only User role. > I denied the role's access to listVirtualMachines, listNetworks, listVolumes and listTemplates APIs. > I created an account using the custom role. > I tried to log in but could not. > ``` > > to double check I created a "regular" Read-Only user and could log in. Hey @DaanHoogland, I reproduced your steps in QA and was able to log in. I created the account `t` (password is also `t`). I suppose that the user you created was `cripple`. I verified that it did not have access to `listZones`, which is an API users are unable to login without. This behavior has nothing to do with the changes here, and you can verify that this account is unable to login in the QA of other PRs as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]
weizhouapache commented on PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#issuecomment-2079265875 @rohityadavcloud I copied the code and run it locally - on mgmt server (with only 1 interface), the `macAddressInLong` value is same as previous legacy code. that is good ``` macAddressInLong = 32989023043991 mysql> select msid from mshost where state='Up'; ++ | msid | ++ | 32989023043991 | ++ 1 row in set (0.00 sec) ``` - run it on kvm host ``` network.getName() = vnet125 network.getName() = vnet150 network.getName() = vnet110 network.getName() = vnet127 network.getName() = vnet111 network.getName() = vnet124 network.getName() = vnet148 network.getName() = vnet78 network.getName() = vnet145 network.getName() = vnet118 network.getName() = vnet122 network.getName() = vnet116 network.getName() = vnet147 network.getName() = vnet117 network.getName() = vnet123 network.getName() = vnet80 network.getName() = vnet79 network.getName() = vnet146 network.getName() = vnet149 network.getName() = vnet112 network.getName() = vnet126 network.getName() = vnet131 network.getName() = cloud0 network.getName() = cloudbr1 network.getName() = cloudbr0 network.getName() = lo ``` my suggestion is - reverse the elements in the return of `NetworkInterface.getNetworkInterfaces` - ignore `lo` interface, so the code will get the mac address of the first non-loopback nic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]
sureshanaparti commented on code in PR #8947:
URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1580920735
##
server/src/main/java/com/cloud/storage/StoragePoolAutomationImpl.java:
##
@@ -318,9 +323,12 @@ public boolean cancelMaintain(DataStore store) {
if (hosts == null || hosts.size() == 0) {
return true;
}
+
+Map details = new HashMap<>();
Review Comment:
can create this map in the method itself and return (noticed map is created
before _addStoragePoolNFSMountOptsToDetailsMap()_ is called )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(cloudstack) branch main updated: plugin: fix nsx build failure with mvn 3.9 (#8974)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 380385d0451 plugin: fix nsx build failure with mvn 3.9 (#8974) 380385d0451 is described below commit 380385d045164a91e00511c4a920da225201c8b9 Author: Rohit Yadav AuthorDate: Fri Apr 26 17:24:24 2024 +0530 plugin: fix nsx build failure with mvn 3.9 (#8974) This excludes indirect dependencies of vapi-authentication to allow build to work. Signed-off-by: Rohit Yadav --- plugins/network-elements/nsx/pom.xml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/plugins/network-elements/nsx/pom.xml b/plugins/network-elements/nsx/pom.xml index bed5731feee..9e8d6ee7bce 100644 --- a/plugins/network-elements/nsx/pom.xml +++ b/plugins/network-elements/nsx/pom.xml @@ -49,6 +49,12 @@ com.vmware.vapi vapi-authentication 2.40.0 + + +* +* + + com.vmware.vapi
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
rohityadavcloud merged PR #8974: URL: https://github.com/apache/cloudstack/pull/8974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]
rohityadavcloud commented on code in PR #8988:
URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1580918983
##
utils/src/main/java/com/cloud/utils/net/MacAddress.java:
##
@@ -79,209 +72,45 @@ public String toString() {
static {
String macAddress = null;
-Process p = null;
-BufferedReader in = null;
-
try {
-String osname = System.getProperty("os.name");
-
-if (osname.startsWith("Windows")) {
-p = Runtime.getRuntime().exec(new String[] {"ipconfig",
"/all"}, null);
-} else if (osname.startsWith("Solaris") ||
osname.startsWith("SunOS")) {
-// Solaris code must appear before the generic code
-String hostName = MacAddress.getFirstLineOfCommand(new
String[] {"uname", "-n"});
-if (hostName != null) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/arp", hostName}, null);
-}
-} else if (new File("/usr/sbin/lanscan").exists()) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/lanscan"}, null);
-} else if (new File("/sbin/ifconfig").exists()) {
-p = Runtime.getRuntime().exec(new String[] {"/sbin/ifconfig",
"-a"}, null);
-}
-
-if (p != null) {
-in = new BufferedReader(new
InputStreamReader(p.getInputStream()), 128);
-String l = null;
-while ((l = in.readLine()) != null) {
-macAddress = MacAddress.parse(l);
-if (macAddress != null) {
-short parsedShortMacAddress =
MacAddress.parseShort(macAddress);
-if (parsedShortMacAddress != 0xff &&
parsedShortMacAddress != 0x00)
-break;
-}
-macAddress = null;
-}
-}
-
-} catch (SecurityException ex) {
-s_logger.info("[ignored] security exception in static initializer
of MacAddress", ex);
-} catch (IOException ex) {
-s_logger.info("[ignored] io exception in static initializer of
MacAddress");
-} finally {
-if (p != null) {
-closeAutoCloseable(in, "closing init process input stream");
-closeAutoCloseable(p.getErrorStream(), "closing init process
error output stream");
-closeAutoCloseable(p.getOutputStream(), "closing init process
std output stream");
-p.destroy();
-}
+Enumeration networkInterfaces =
NetworkInterface.getNetworkInterfaces();
+while (networkInterfaces.hasMoreElements()) {
+ NetworkInterface network = networkInterfaces.nextElement();
+ final byte [] mac = network.getHardwareAddress();
+ if (mac != null && !network.isVirtual() &&
+ !network.getName().startsWith("br-") &&
+ !network.getName().startsWith("veth") &&
+ !network.getName().startsWith("vnet")) {
Review Comment:
One concern though, cc @weizhouapache if you know - do people run CloudStack
in containers, then what nice are seen within; for such users could this cause
issues (if we ignore virtual nics?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]
rohityadavcloud commented on code in PR #8988:
URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1580918983
##
utils/src/main/java/com/cloud/utils/net/MacAddress.java:
##
@@ -79,209 +72,45 @@ public String toString() {
static {
String macAddress = null;
-Process p = null;
-BufferedReader in = null;
-
try {
-String osname = System.getProperty("os.name");
-
-if (osname.startsWith("Windows")) {
-p = Runtime.getRuntime().exec(new String[] {"ipconfig",
"/all"}, null);
-} else if (osname.startsWith("Solaris") ||
osname.startsWith("SunOS")) {
-// Solaris code must appear before the generic code
-String hostName = MacAddress.getFirstLineOfCommand(new
String[] {"uname", "-n"});
-if (hostName != null) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/arp", hostName}, null);
-}
-} else if (new File("/usr/sbin/lanscan").exists()) {
-p = Runtime.getRuntime().exec(new String[]
{"/usr/sbin/lanscan"}, null);
-} else if (new File("/sbin/ifconfig").exists()) {
-p = Runtime.getRuntime().exec(new String[] {"/sbin/ifconfig",
"-a"}, null);
-}
-
-if (p != null) {
-in = new BufferedReader(new
InputStreamReader(p.getInputStream()), 128);
-String l = null;
-while ((l = in.readLine()) != null) {
-macAddress = MacAddress.parse(l);
-if (macAddress != null) {
-short parsedShortMacAddress =
MacAddress.parseShort(macAddress);
-if (parsedShortMacAddress != 0xff &&
parsedShortMacAddress != 0x00)
-break;
-}
-macAddress = null;
-}
-}
-
-} catch (SecurityException ex) {
-s_logger.info("[ignored] security exception in static initializer
of MacAddress", ex);
-} catch (IOException ex) {
-s_logger.info("[ignored] io exception in static initializer of
MacAddress");
-} finally {
-if (p != null) {
-closeAutoCloseable(in, "closing init process input stream");
-closeAutoCloseable(p.getErrorStream(), "closing init process
error output stream");
-closeAutoCloseable(p.getOutputStream(), "closing init process
std output stream");
-p.destroy();
-}
+Enumeration networkInterfaces =
NetworkInterface.getNetworkInterfaces();
+while (networkInterfaces.hasMoreElements()) {
+ NetworkInterface network = networkInterfaces.nextElement();
+ final byte [] mac = network.getHardwareAddress();
+ if (mac != null && !network.isVirtual() &&
+ !network.getName().startsWith("br-") &&
+ !network.getName().startsWith("veth") &&
+ !network.getName().startsWith("vnet")) {
Review Comment:
One concern though, cc @weizhouapache if you know - do people run CloudStack
in containers - if so, could this cause issues (if we ignore virtual nics?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
