Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]
blueorangutan commented on PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#issuecomment-2126281136 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]
blueorangutan commented on PR #8875: URL: https://github.com/apache/cloudstack/pull/8875#issuecomment-2126279705 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feature: webhooks [cloudstack]
blueorangutan commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2126236345 @kiranchavala a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feature: webhooks [cloudstack]
kiranchavala commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2126233228 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]
blueorangutan commented on PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#issuecomment-2126216911 @abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]
abh1sar commented on PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#issuecomment-2126215265 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]
blueorangutan commented on PR #8875: URL: https://github.com/apache/cloudstack/pull/8875#issuecomment-2126213483 @abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]
abh1sar commented on PR #8875: URL: https://github.com/apache/cloudstack/pull/8875#issuecomment-2126212617 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Download Volume Snapshots [cloudstack]
blueorangutan commented on PR #8878: URL: https://github.com/apache/cloudstack/pull/8878#issuecomment-2126024007 [SF] Trillian test result (tid-10253) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45717 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8878-t10253-kvm-centos7.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 417.67 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added support for storpool_qos service [cloudstack]
blueorangutan commented on PR #8755: URL: https://github.com/apache/cloudstack/pull/8755#issuecomment-2125992767 [SF] Trillian test result (tid-10243) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 56225 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8755-t10243-kvm-centos7.zip Smoke tests completed. 126 look OK, 5 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 425.39 | test_events_resource.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 112.26 | test_routers_network_ops.py test_03_secured_to_nonsecured_vm_migration | `Error` | 298.20 | test_vm_life_cycle.py test_01_verify_ipv6_vpc | `Failure` | 771.23 | test_vpc_ipv6.py test_02_redundant_VPC_default_routes | `Failure` | 385.82 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 610.00 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Failure` | 530.74 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 530.76 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
blueorangutan commented on PR #9064: URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2125982474 [SF] Trillian test result (tid-10250) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52554 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9064-t10250-kvm-centos7.zip Smoke tests completed. 127 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 405.91 | test_events_resource.py test_08_arping_in_ssvm | `Failure` | 5.22 | test_diagnostics.py test_09_arping_in_cpvm | `Failure` | 5.27 | test_diagnostics.py test_02_trigger_shutdown | `Failure` | 346.84 | test_safe_shutdown.py test_01_redundant_vpc_site2site_vpn | `Failure` | 410.44 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server: allow project role-based api access [cloudstack]
blueorangutan commented on PR #9090: URL: https://github.com/apache/cloudstack/pull/9090#issuecomment-2125977557 [SF] Trillian test result (tid-10252) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 50449 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9090-t10252-kvm-alma9.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 428.95 | test_events_resource.py test_02_trigger_shutdown | `Failure` | 341.41 | test_safe_shutdown.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2125957952 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: add `codespell` to check spelling [cloudstack]
blueorangutan commented on PR #8197: URL: https://github.com/apache/cloudstack/pull/8197#issuecomment-2125941284 [SF] Trillian test result (tid-10244) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52031 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8197-t10244-kvm-centos7.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 431.60 | test_events_resource.py test_02_trigger_shutdown | `Failure` | 351.72 | test_safe_shutdown.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2125938902 [SF] Trillian test result (tid-10251) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48420 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8898-t10251-vmware-67u3.zip Smoke tests completed. 110 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]
blueorangutan commented on PR #8908: URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2125931703 [SF] Trillian test result (tid-10248) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50810 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8908-t10248-kvm-centos7.zip Smoke tests completed. 128 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 421.49 | test_events_resource.py test_02_trigger_shutdown | `Failure` | 351.78 | test_safe_shutdown.py test_01_redundant_vpc_site2site_vpn | `Failure` | 446.44 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: add hook to trim trailing whitespace [cloudstack]
blueorangutan commented on PR #8205: URL: https://github.com/apache/cloudstack/pull/8205#issuecomment-2125910907 [SF] Trillian test result (tid-10245) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49836 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8205-t10245-kvm-centos7.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 414.61 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2125896959 [SF] Trillian test result (tid-10247) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48880 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8911-t10247-kvm-centos7.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 413.78 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2125886004 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2125884839 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Change exception when orchestrating VM start [cloudstack]
blueorangutan commented on PR #9062: URL: https://github.com/apache/cloudstack/pull/9062#issuecomment-2125873532 [SF] Trillian test result (tid-10242) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48430 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9062-t10242-kvm-centos7.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 426.01 | test_events_resource.py test_05_vmschedule_test_e2e | `Failure` | 361.87 | test_vm_schedule.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: enable Python Flake8 rule `E713` [cloudstack]
blueorangutan commented on PR #9016: URL: https://github.com/apache/cloudstack/pull/9016#issuecomment-2125862215 [SF] Trillian test result (tid-10241) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48008 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9016-t10241-kvm-centos7.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 418.10 | test_events_resource.py test_08_arping_in_ssvm | `Failure` | 5.21 | test_diagnostics.py test_09_arping_in_cpvm | `Failure` | 5.20 | test_diagnostics.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in docs, logs, exception messages etc [cloudstack]
blueorangutan commented on PR #9076: URL: https://github.com/apache/cloudstack/pull/9076#issuecomment-2125860639 [SF] Trillian test result (tid-10246) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47080 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9076-t10246-kvm-centos7.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 417.49 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,ui: vm template format, fix vm info link [cloudstack]
blueorangutan commented on PR #9094: URL: https://github.com/apache/cloudstack/pull/9094#issuecomment-2125835320 [SF] Trillian test result (tid-10236) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 49562 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9094-t10236-kvm-rocky8.zip Smoke tests completed. 128 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 425.66 | test_events_resource.py test_02_trigger_shutdown | `Failure` | 346.71 | test_safe_shutdown.py test_02_list_cpvm_vm | `Failure` | 0.05 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.06 | test_ssvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Extra parameter for UpdateImageStore [cloudstack]
blueorangutan commented on PR #8941: URL: https://github.com/apache/cloudstack/pull/8941#issuecomment-2125826616 [SF] Trillian Build Failed (tid-10255) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Veeam] disable jobs but keep backups [cloudstack]
blueorangutan commented on PR #6589: URL: https://github.com/apache/cloudstack/pull/6589#issuecomment-2125825046 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix migration from local storage to NFS in KVM [cloudstack]
blueorangutan commented on PR #8909: URL: https://github.com/apache/cloudstack/pull/8909#issuecomment-2125799576 [SF] Trillian test result (tid-10240) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46429 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8909-t10240-kvm-centos7.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 416.26 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2125798952 [SF] Trillian test result (tid-10238) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48502 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8929-t10238-kvm-rocky8.zip Smoke tests completed. 131 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 440.82 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2125783783 [SF] Trillian test result (tid-10239) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46013 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8624-t10239-kvm-centos7.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 414.13 | test_events_resource.py test_01_redundant_vpc_site2site_vpn | `Failure` | 420.75 | test_vpc_vpn.py test_01_vpc_site2site_vpn_multiple_options | `Failure` | 343.12 | test_vpc_vpn.py test_01_vpc_site2site_vpn | `Failure` | 294.82 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server: list autoscalevmgroups with keyword [cloudstack]
blueorangutan commented on PR #9046: URL: https://github.com/apache/cloudstack/pull/9046#issuecomment-2125753932 [SF] Trillian test result (tid-10237) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 46979 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9046-t10237-kvm-rocky8.zip Smoke tests completed. 127 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 420.44 | test_events_resource.py test_create_pvlan_network | `Error` | 0.11 | test_pvlan.py test_02_trigger_shutdown | `Failure` | 341.87 | test_safe_shutdown.py test_05_vmschedule_test_e2e | `Failure` | 362.75 | test_vm_schedule.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Veeam] disable jobs but keep backups [cloudstack]
blueorangutan commented on PR #6589: URL: https://github.com/apache/cloudstack/pull/6589#issuecomment-2125693225 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Veeam] disable jobs but keep backups [cloudstack]
BryanMLima commented on PR #6589: URL: https://github.com/apache/cloudstack/pull/6589#issuecomment-2125691246 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]
blueorangutan commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-212842 Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]
weizhouapache commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2125533659 > Maybe a good time for 4.20 to drop support for EL7, Ubuntu 18.04 and 20.04 ? cc @sureshanaparti @shwstppr @DaanHoogland @JoaoJandre and others? Many distros will only have JRE17 as the new default, so either with 4.20 or 4.21 should deprecate support for older distros (both as mgmt/usage server host and KVM host) and move on to using newer LTS JRE. yep EL7 support should be dropped 18.04 is EOL but 20.04 is not. but if openjdk 17 is installed, they should work as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
blueorangutan commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2125496485 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VM allocation on Primary Storage [cloudstack]
JoaoJandre commented on issue #8959: URL: https://github.com/apache/cloudstack/issues/8959#issuecomment-2125476198 Hello @cdfgallo @shwstppr, You could use flexible tags to finely choose which hosts receive which VMs and the same with storages and volumes. You can make rules to specifically allow only certain groups of tags into each host/storage. You can read a little more about tags and flexible tags in the [documentation](http://docs.cloudstack.apache.org/en/latest/adminguide/host_and_storage_tags.html#). Let me know if you do not understand the docs, and have further questions about flexible tags; I can try to answer them. However, if you only want preferred and not exclusive hosts/storages, regular tags would do just fine as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]
BryanMLima commented on PR #8581:
URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-2125451174
> > @DaanHoogland, as you have more experience with the test matrix, did it
ever happen in a scenario when the API had an incorrect signature, such as
`errorText:unable to verify user credentials and/or request signature`? I can
run the Quota plugin test in my local lab, however, the matrix test points out
this signature error
https://github.com/apache/cloudstack/actions/runs/9036087020/job/24832224476?pr=8581.
I'm willing to remove this test from the matrix as I do not have a clue to why
this happens.
>
> guess this time around it didn't fail?
Nope, it still had the same error, even though the test is marked as
“passed”. I removed the Quota plugin smoke test from the test matrix as I could
not find the reason for the error message. The results from running the
integration tests in my local lab is presented below for verification:
runinfo
```2024-05-22 18:01:14,332 - DEBUG - Parsing Test data successful
2024-05-22 18:01:14,332 - DEBUG - Payload: {'account': 'admin', 'command':
'listUsers', 'response': 'json'}
2024-05-22 18:01:14,332 - DEBUG - Sending GET Cmd : listUsers===
2024-05-22 18:01:14,346 - DEBUG - Response : [{id :
'0f29064e-8a09-11ee-b655-525400627401', username : 'admin', firstname :
'admin', lastname : 'cloud', created : '2023-11-23T14:03:20+', state :
'enabled', account : 'admin', accounttype : 1, usersource : 'native', roleid :
'09360ed0-8a09-11ee-b655-525400627401', roletype : 'Admin', rolename : 'Root
Admin', domainid : '0091d3ad-8a09-11ee-b655-525400627401', domain : 'ROOT',
apikey :
'TEYzt4GLXLz4859ncH84qCN84Lq6gQ0KIGWCz_xmchYBmESpqLobKaYV4lR1h2hMNyDWItpCJbYMcTPIZLQuow',
accountid : '0f27e443-8a09-11ee-b655-525400627401', iscallerchilddomain :
False, isdefault : True, is2faenabled : False, is2famandated : False}, {id :
'18b84e66-8338-4b41-b0d0-facc5b82ba0f', username : 'teste', firstname :
'teste', lastname : 'teste', email : 'teste', created :
'2024-03-28T18:16:22+', state : 'enabled', account : 'admin', accounttype :
1, usersource : 'native', roleid : '09360ed0-8a09-11ee-b655-525400627401',
roletype : 'Admin', rolename :
'Root Admin', domainid : '0091d3ad-8a09-11ee-b655-525400627401', domain :
'ROOT', timezone : 'Etc/GMT-3', accountid :
'0f27e443-8a09-11ee-b655-525400627401', iscallerchilddomain : False, isdefault
: False, is2faenabled : False, is2famandated : False}]
2024-05-22 18:01:14,346 - DEBUG - Payload: {'id':
'0f29064e-8a09-11ee-b655-525400627401', 'command': 'getUserKeys', 'response':
'json'}
2024-05-22 18:01:14,346 - DEBUG - Sending GET Cmd :
getUserKeys===
2024-05-22 18:01:14,354 - DEBUG - Response : {apikey :
'TEYzt4GLXLz4859ncH84qCN84Lq6gQ0KIGWCz_xmchYBmESpqLobKaYV4lR1h2hMNyDWItpCJbYMcTPIZLQuow',
secretkey :
'i6K3V2Qggc7tb2KILyEQq-6jVECahwP6MODmDR1-RZC45VSj8vCAr9qIjXTFHIggyjvJDhuIJAmmJ--UwgamtA'}
2024-05-22 18:01:14,354 - DEBUG - Test Client Creation Successful
2024-05-22 18:01:14,399 - DEBUG - Payload: {'command': 'listDomains',
'response': 'json', 'apiKey':
'TEYzt4GLXLz4859ncH84qCN84Lq6gQ0KIGWCz_xmchYBmESpqLobKaYV4lR1h2hMNyDWItpCJbYMcTPIZLQuow',
'signature': b'Y0pChHXtWOHAjUO1E+i1+peq90g='}
2024-05-22 18:01:14,399 - DEBUG - Sending GET Cmd :
listDomains===
2024-05-22 18:01:14,414 - DEBUG - Response : [{id :
'0091d3ad-8a09-11ee-b655-525400627401', name : 'ROOT', level : 0, haschild :
True, path : 'ROOT', state : 'Active', vmlimit : 'Unlimited', vmtotal : 5,
vmavailable : 'Unlimited', iplimit : 'Unlimited', iptotal : 4, ipavailable :
'Unlimited', volumelimit : 'Unlimited', volumetotal : 9, volumeavailable :
'Unlimited', snapshotlimit : 'Unlimited', snapshottotal : 1, snapshotavailable
: 'Unlimited', templatelimit : 'Unlimited', templatetotal : 18,
templateavailable : 'Unlimited', projectlimit : 'Unlimited', projecttotal : 4,
projectavailable : 'Unlimited', networklimit : 'Unlimited', networktotal : 6,
networkavailable : 'Unlimited', vpclimit : 'Unlimited', vpctotal : 2,
vpcavailable : 'Unlimited', cpulimit : 'Unlimited', cputotal : 10, cpuavailable
: 'Unlimited', memorylimit : 'Unlimited', memorytotal : 2560, memoryavailable :
'Unlimited', primarystoragelimit : 'Unlimited', primarystoragetotal : 59,
primarystorageavailable : 'Unlimite
d', secondarystoragelimit : 'Unlimited', secondarystoragetotal : 38.638916,
secondarystorageavailable : 'Unlimited', hasannotations : False}, {id :
'5b0d718b-4e67-45a6-91b7-ba78532e70c7', name : 'dom-01', level : 1,
parentdomainid : '0091d3ad-8a09-11ee-b655-525400627401', parentdomainname :
'ROOT', haschild : False, path : 'ROOT/dom-01', state : 'Active', created :
'2024-03-07T12:56:08+', vmlimit : 'Unlimited', vmtotal : 0, vmavailable :
'Unlimited', iplimit : 'Unlimited', iptotal : 0, ipavailable : 'Unlimited',
volumelimit : 'Unlimited', volumetotal : 0,
Re: [PR] ui: fix dashboard on saml user login [cloudstack]
blueorangutan commented on PR #9097: URL: https://github.com/apache/cloudstack/pull/9097#issuecomment-2125450066 UI build failed: :heavy_multiplication_x: (SL-JID-346) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]
blueorangutan commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2125425644 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix dashboard on saml user login [cloudstack]
DaanHoogland commented on PR #9097: URL: https://github.com/apache/cloudstack/pull/9097#issuecomment-2125424999 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix dashboard on saml user login [cloudstack]
blueorangutan commented on PR #9097: URL: https://github.com/apache/cloudstack/pull/9097#issuecomment-2125425654 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]
DaanHoogland commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2125423692 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server: encryptformat in volume response [cloudstack]
blueorangutan commented on PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#issuecomment-2125422556 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server: encryptformat in volume response [cloudstack]
DaanHoogland commented on PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#issuecomment-2125419306 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix dashboard on saml user login [cloudstack]
blueorangutan commented on PR #9097: URL: https://github.com/apache/cloudstack/pull/9097#issuecomment-2125373407 UI build failed: :heavy_multiplication_x: (SL-JID-345) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
blueorangutan commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2125366503 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
rohityadavcloud commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2125364730 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]
rohityadavcloud commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2125351799 Maybe a good time for 4.20 to drop support for EL7, Ubuntu 18.04 and 20.04 ? cc @sureshanaparti @shwstppr @DaanHoogland @JoaoJandre and others? Many distros will only have JRE17 as the new default, so either with 4.20 or 4.21 should deprecate support for older distros (both as mgmt/usage server host and KVM host) and move on to using newer LTS JRE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix dashboard on saml user login [cloudstack]
blueorangutan commented on PR #9097: URL: https://github.com/apache/cloudstack/pull/9097#issuecomment-2125347054 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix dashboard on saml user login [cloudstack]
rohityadavcloud commented on PR #9097: URL: https://github.com/apache/cloudstack/pull/9097#issuecomment-2125344535 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] listNetworks optimization [cloudstack]
rohityadavcloud commented on code in PR #9096: URL: https://github.com/apache/cloudstack/pull/9096#discussion_r1610360509 ## server/src/main/java/com/cloud/network/NetworkServiceImpl.java: ## @@ -2267,7 +2267,7 @@ public Pair, Integer> searchForNetworks(ListNetworksCmd isRecursive = true; } -Filter searchFilter = new Filter(NetworkVO.class, "id", false, null, null); +Filter searchFilter = new Filter(NetworkVO.class, "id", false, cmd.getStartIndex(), cmd.getPageSizeVal()); Review Comment: Are there not any other API similar to this where pagination is applied where the pattern can be repeated, maybe templates, volumes, offerings? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] listNetworks optimization [cloudstack]
rohityadavcloud commented on code in PR #9096:
URL: https://github.com/apache/cloudstack/pull/9096#discussion_r1610359422
##
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##
@@ -2322,41 +2322,52 @@ public Pair, Integer>
searchForNetworks(ListNetworksCmd
sb.join("associatedNetworkSearch", associatedNetworkSearch,
sb.entity().getId(), associatedNetworkSearch.entity().getResourceId(),
JoinBuilder.JoinType.INNER);
}
-List networksToReturn = new ArrayList();
+Pair, Integer> networks;
+Pair, Integer> networksToReturn = new Pair<>(new
ArrayList(), 0);
if (isSystem == null || !isSystem) {
if (!permittedAccounts.isEmpty()) {
if (Arrays.asList(Network.NetworkFilter.Account,
Network.NetworkFilter.AccountDomain,
Network.NetworkFilter.All).contains(networkFilter)) {
//get account level networks
-
networksToReturn.addAll(listAccountSpecificNetworks(buildNetworkSearchCriteria(sb,
keyword, id, isSystem, zoneId, guestIpType, trafficType, physicalNetworkId,
networkOfferingId,
-aclType, skipProjectNetworks, restartRequired,
specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId),
searchFilter, permittedAccounts));
+networks =
listAccountSpecificNetworks(buildNetworkSearchCriteria(sb, keyword, id,
isSystem, zoneId, guestIpType, trafficType, physicalNetworkId,
networkOfferingId,
+aclType, skipProjectNetworks, restartRequired,
specifyIpRanges, vpcId, tags, display, vlanId, associatedNetworkId),
searchFilter, permittedAccounts);
+networksToReturn.first().addAll(networks.first());
+networksToReturn.second(networksToReturn.second() +
networks.second());
}
if (domainId != null &&
Arrays.asList(Network.NetworkFilter.Domain,
Network.NetworkFilter.AccountDomain,
Network.NetworkFilter.All).contains(networkFilter)) {
//get domain level networks
-
networksToReturn.addAll(listDomainLevelNetworks(buildNetworkSearchCriteria(sb,
keyword, id, isSystem, zoneId, guestIpType, trafficType, physicalNetworkId,
networkOfferingId,
-aclType, true, restartRequired, specifyIpRanges,
vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, domainId,
false));
+networks =
listDomainLevelNetworks(buildNetworkSearchCriteria(sb, keyword, id, isSystem,
zoneId, guestIpType, trafficType, physicalNetworkId, networkOfferingId,
+aclType, true, restartRequired, specifyIpRanges,
vpcId, tags, display, vlanId, associatedNetworkId), searchFilter, domainId,
false);
+networksToReturn.first().addAll(networks.first());
+networksToReturn.second(networksToReturn.second() +
networks.second());
}
if (Arrays.asList(Network.NetworkFilter.Shared,
Network.NetworkFilter.All).contains(networkFilter)) {
// get shared networks
-List sharedNetworks =
listSharedNetworks(buildNetworkSearchCriteria(sb, keyword, id, isSystem,
zoneId, guestIpType, trafficType, physicalNetworkId, networkOfferingId,
+Pair, Integer> sharedNetworks =
listSharedNetworks(buildNetworkSearchCriteria(sb, keyword, id, isSystem,
zoneId, guestIpType, trafficType, physicalNetworkId, networkOfferingId,
aclType, true, restartRequired, specifyIpRanges,
vpcId, tags, display, vlanId, associatedNetworkId), searchFilter,
permittedAccounts);
-addNetworksToReturnIfNotExist(networksToReturn,
sharedNetworks);
+addNetworksToReturnIfNotExist(networksToReturn,
sharedNetworks.first());
Review Comment:
This needs to be accurate too. Perhaps once the query returns the page, we
can call a dao::getCount() passing only the list of IDs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2125268138 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 9678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]
blueorangutan commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2125223967 Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]
sonarcloud[bot] commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2125173327 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack=8609) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack=8609=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack=8609=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=8609=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack=8609=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_cloudstack=8609) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2125099680 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2125095317 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix allocation of VMs with multiple clusters [cloudstack]
blueorangutan commented on PR #8611: URL: https://github.com/apache/cloudstack/pull/8611#issuecomment-2125094113 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]
blueorangutan commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2125046039 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]
weizhouapache commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2125041534 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.20-sonar-jre17 updated (50eeeeb097b -> fd78488b962)
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch 4.20-sonar-jre17 in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard 50b097b fix simulator CI and Update exec-maven-plugin to 3.2.0 discard d73a8052aed Revert "pom.xml: update cs.jdk.version to 17" discard fa752ce5d4c Fix failure test with ConfigKeyScheduledExecutionWrapperTest add b786b8c1096 Revert "pom.xml: update cs.jdk.version to 17" add 4af230047d2 fix simulator CI and Update exec-maven-plugin to 3.2.0 add fd396656ad1 fix simulator CI add 0d1bc7dfd0c Limit `listRoles` API visibility (#8639) add f80d2052845 linstor: Fix volume format and make resource available on copy target (#8811) add 87e7c57d08c Fixup e2e test_restore_vm (#9025) add e9ff2707bbd Merge branch '4.19' add 21af134087a Fix exceeding of resource limits with powerflex (#9008) add 5f73172bcbe Fix failure test with ConfigKeyScheduledExecutionWrapperTest (#9103) add 2a63483b4c5 framework/config: make logic in ::value() defensive (#9108) add fd78488b962 Merge remote-tracking branch 'apache/main' into 4.20-sonar-jre17 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (50b097b) \ N -- N -- N refs/heads/4.20-sonar-jre17 (fd78488b962) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../java/com/cloud/user/ResourceLimitService.java | 2 + developer/pom.xml | 21 ++- .../service/VolumeOrchestrationService.java| 3 +- .../api/storage/PrimaryDataStoreDriver.java| 16 ++ .../com/cloud/vm/VirtualMachineManagerImpl.java| 3 +- .../engine/orchestration/VolumeOrchestrator.java | 50 ++- .../cloudstack/framework/config/ConfigKey.java | 2 +- .../ConfigKeyScheduledExecutionWrapperTest.java| 5 +- .../contrail/management/MockAccountManager.java| 5 + .../driver/LinstorPrimaryDataStoreDriverImpl.java | 54 +++ .../driver/ScaleIOPrimaryDataStoreDriver.java | 10 ++ .../driver/ScaleIOPrimaryDataStoreDriverTest.java | 33 + .../resourcelimit/ResourceLimitManagerImpl.java| 13 ++ .../com/cloud/storage/VolumeApiServiceImpl.java| 18 +++ .../main/java/com/cloud/user/AccountManager.java | 2 + .../java/com/cloud/user/AccountManagerImpl.java| 5 + .../main/java/com/cloud/vm/UserVmManagerImpl.java | 107 -- .../org/apache/cloudstack/acl/RoleManagerImpl.java | 103 ++--- .../com/cloud/user/MockAccountManagerImpl.java | 4 + .../java/com/cloud/vm/UserVmManagerImplTest.java | 34 + .../cloud/vpc/MockResourceLimitManagerImpl.java| 6 + .../apache/cloudstack/acl/RoleManagerImplTest.java | 162 - .../component/test_resource_limit_tags.py | 44 ++ test/integration/smoke/test_restore_vm.py | 105 +++-- tools/marvin/marvin/lib/base.py| 20 ++- 25 files changed, 700 insertions(+), 127 deletions(-)
(cloudstack) branch main updated: framework/config: make logic in ::value() defensive (#9108)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 2a63483b4c5 framework/config: make logic in ::value() defensive (#9108)
2a63483b4c5 is described below
commit 2a63483b4c5f234fa441cb5a5477aa59c9e196ee
Author: Rohit Yadav
AuthorDate: Wed May 22 20:20:15 2024 +0530
framework/config: make logic in ::value() defensive (#9108)
This adds a NPE check on the s_depot.global() which can cause NPE in
case of unit tests, where s_depot is not null but the underlying config
dao is null (not mocked or initialised) via `s_depot.global()` becomes
null.
This reverts commit 5f73172bcbe975e4ef416e525dc95bad63fa6d3a.
Signed-off-by: Rohit Yadav
---
.../main/java/org/apache/cloudstack/framework/config/ConfigKey.java | 2 +-
.../framework/config/ConfigKeyScheduledExecutionWrapperTest.java | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git
a/framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java
b/framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java
index df93f78fa83..46923de3c7c 100644
---
a/framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java
+++
b/framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java
@@ -211,7 +211,7 @@ public class ConfigKey {
public T value() {
if (_value == null || isDynamic()) {
-ConfigurationVO vo = s_depot != null ?
s_depot.global().findById(key()) : null;
+ConfigurationVO vo = (s_depot != null && s_depot.global() != null)
? s_depot.global().findById(key()) : null;
final String value = (vo != null && vo.getValue() != null) ?
vo.getValue() : defaultValue();
_value = ((value == null) ? (T)defaultValue() : valueOf(value));
}
diff --git
a/framework/config/src/test/java/org/apache/cloudstack/framework/config/ConfigKeyScheduledExecutionWrapperTest.java
b/framework/config/src/test/java/org/apache/cloudstack/framework/config/ConfigKeyScheduledExecutionWrapperTest.java
index 0eb2f6286ca..fbb4dc24fca 100644
---
a/framework/config/src/test/java/org/apache/cloudstack/framework/config/ConfigKeyScheduledExecutionWrapperTest.java
+++
b/framework/config/src/test/java/org/apache/cloudstack/framework/config/ConfigKeyScheduledExecutionWrapperTest.java
@@ -20,7 +20,6 @@ import com.cloud.utils.concurrency.NamedThreadFactory;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mock;
-import org.mockito.Mockito;
import org.mockito.junit.MockitoJUnitRunner;
import java.util.concurrent.Executors;
@@ -59,8 +58,8 @@ public class ConfigKeyScheduledExecutionWrapperTest {
@Test(expected = IllegalArgumentException.class)
public void invalidConfigKeyTest() {
TestRunnable runnable = new TestRunnable();
-ConfigKey configKey = Mockito.mock(ConfigKey.class);
-when(configKey.value()).thenReturn("test");
+ConfigKey configKey = new ConfigKey<>(String.class, "test",
"test", "test", "test", true,
+ConfigKey.Scope.Global, null, null, null, null, null,
ConfigKey.Kind.CSV, null);
ConfigKeyScheduledExecutionWrapper runner = new
ConfigKeyScheduledExecutionWrapper(executorService, runnable, configKey,
TimeUnit.SECONDS);
}
Re: [PR] framework/config: make logic in ::value() defensive [cloudstack]
rohityadavcloud merged PR #9108: URL: https://github.com/apache/cloudstack/pull/9108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] framework/db: introduce a new MySQL table based distributed lock [cloudstack]
rohityadavcloud commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2124997299 Update and note - on further R and investigation, MySQL server turned out to not really be the bottleneck, thanks to the creators of jprofiler, yourkit, MAT and visual vm, I've more insights on what's lacking in CloudStack. While such a PR like this may still be useful for users who want an active-active MySQL setup, the real challenge is fixing the schema and application in the first place, for which I'll submit a separate PR (or PRs). For now this is on-hold, to be treated as an experiment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/config: make logic in ::value() defensive [cloudstack]
rohityadavcloud commented on code in PR #9108:
URL: https://github.com/apache/cloudstack/pull/9108#discussion_r1610130733
##
framework/config/src/test/java/org/apache/cloudstack/framework/config/ConfigKeyScheduledExecutionWrapperTest.java:
##
@@ -59,8 +58,8 @@ public void nullConfigKeyTest() {
@Test(expected = IllegalArgumentException.class)
public void invalidConfigKeyTest() {
TestRunnable runnable = new TestRunnable();
-ConfigKey configKey = Mockito.mock(ConfigKey.class);
-when(configKey.value()).thenReturn("test");
+ConfigKey configKey = new ConfigKey<>(String.class, "test",
"test", "test", "test", true,
+ConfigKey.Scope.Global, null, null, null, null, null,
ConfigKey.Kind.CSV, null);
Review Comment:
I think the original test (before Wei's change) was just testing for an
invalid configKey; I reverted the change to keep author's original intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] api,server: encryptformat in volume response [cloudstack]
blueorangutan commented on PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#issuecomment-2124947148 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/config: make logic in ::value() defensive [cloudstack]
blueorangutan commented on PR #9108: URL: https://github.com/apache/cloudstack/pull/9108#issuecomment-2124940721 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix allocation of VMs with multiple clusters [cloudstack]
blueorangutan commented on PR #8611: URL: https://github.com/apache/cloudstack/pull/8611#issuecomment-2124925692 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix allocation of VMs with multiple clusters [cloudstack]
BryanMLima commented on PR #8611: URL: https://github.com/apache/cloudstack/pull/8611#issuecomment-2124920112 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]
BryanMLima commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2124915608 @weizhouapache @KlausDornsbach, can you guys have a look at this PR with the latest change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cks,ui: fix npe and check for disable zone [cloudstack]
blueorangutan commented on PR #9105: URL: https://github.com/apache/cloudstack/pull/9105#issuecomment-2124846643 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cks,ui: fix npe and check for disable zone [cloudstack]
DaanHoogland commented on PR #9105: URL: https://github.com/apache/cloudstack/pull/9105#issuecomment-2124841706 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] list by isEncrypted [cloudstack]
blueorangutan commented on PR #8643: URL: https://github.com/apache/cloudstack/pull/8643#issuecomment-2124842206 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
blueorangutan commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2124842136 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
DaanHoogland commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2124840050 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] list by isEncrypted [cloudstack]
DaanHoogland commented on PR #8643: URL: https://github.com/apache/cloudstack/pull/8643#issuecomment-2124838307 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] FiberChannel Multipath for KVM + Pure Flash Array and HPE-Primera Support [cloudstack]
meletisf commented on PR #7889: URL: https://github.com/apache/cloudstack/pull/7889#issuecomment-2124825738 > > Hello, are there any plans to support Alletra 5/6K and MP? This is probably compatible with 9K since it is based on Primera but with the general direction being the MP platform (officially GreenLake for Block) it would be interesting to see support for the new generations. > > At this time we do not have plans to test against these newer devices, but the Alletra line appears to support HPE Web Services API 1.10 which the driver is coded to. I suspect it may work as-is or with minor tweaks. Good point about the Web Services API. I will raise it to the Alletra engineering team to verify it. Most likely i will testing it on A6K and MP arrays and let you know! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] list by isEncrypted [cloudstack]
blueorangutan commented on PR #8643: URL: https://github.com/apache/cloudstack/pull/8643#issuecomment-2124820519 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cks,ui: fix npe and check for disable zone [cloudstack]
blueorangutan commented on PR #9105: URL: https://github.com/apache/cloudstack/pull/9105#issuecomment-2124803126 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
blueorangutan commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2124802994 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Refactor type and range validation in configuration update process [cloudstack]
blueorangutan commented on PR #9107: URL: https://github.com/apache/cloudstack/pull/9107#issuecomment-2124803001 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server: encryptformat in volume response [cloudstack]
blueorangutan commented on PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#issuecomment-2124791776 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server: encryptformat in volume response [cloudstack]
DaanHoogland commented on PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#issuecomment-2124789561 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server: encryptformat in volume response [cloudstack]
DaanHoogland commented on PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#issuecomment-2124788188 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/config: make logic in ::value() defensive [cloudstack]
DaanHoogland commented on code in PR #9108:
URL: https://github.com/apache/cloudstack/pull/9108#discussion_r1609932888
##
framework/config/src/test/java/org/apache/cloudstack/framework/config/ConfigKeyScheduledExecutionWrapperTest.java:
##
@@ -59,8 +58,8 @@ public void nullConfigKeyTest() {
@Test(expected = IllegalArgumentException.class)
public void invalidConfigKeyTest() {
TestRunnable runnable = new TestRunnable();
-ConfigKey configKey = Mockito.mock(ConfigKey.class);
-when(configKey.value()).thenReturn("test");
+ConfigKey configKey = new ConfigKey<>(String.class, "test",
"test", "test", "test", true,
+ConfigKey.Scope.Global, null, null, null, null, null,
ConfigKey.Kind.CSV, null);
Review Comment:
isn't using a mock fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] api: improve listVM API handling and response speed [cloudstack]
rohityadavcloud commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2124763220 As I don't care much for the PR anymore and #8782 has addressed most if not all my concerns, I'm closing this PR. I may raise a new PR for changes that aren't in #8782 and we probably may need a doc PR in release notes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: improve listVM API handling and response speed [cloudstack]
rohityadavcloud closed pull request #8985: api: improve listVM API handling and response speed URL: https://github.com/apache/cloudstack/pull/8985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VMs with same host-affinity group are deployed to different hosts [cloudstack]
weizhouapache commented on issue #9110: URL: https://github.com/apache/cloudstack/issues/9110#issuecomment-2124757925 cc @vishesh92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Do not retrieve VM's stats on normal VM listing [cloudstack]
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1609919869
##
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey SharePublicTemplatesWithOtherDomains = new
ConfigKey<>("Advanced", Boolean.class,
"share.public.templates.with.other.domains", "true",
"If false, templates of this domain will not show up in the list
templates of other domains.", true, ConfigKey.Scope.Domain);
+ConfigKey ReturnVmStatsOnVmList = new ConfigKey<>("Advanced",
Boolean.class, "return.vm.stats.on.vm.list", "true",
Review Comment:
```suggestion
ConfigKey ReturnVmStatsOnVmList = new ConfigKey<>("Advanced",
Boolean.class, "return.vm.stats.on.vm.list", "false",
```
After due considerations, I think this can be set to false what originally
Joao wants to accomplish. As the listVirtualMachines API is used by at least
three integrations I know of (CAPC, k8s-provider and terraform etc.) and
several portals are built on top such APIs, it makes sense to trade off speed.
BUT, if we do this we must document this change in the release notes and what
users can do to get previous/old behaviour if they want it. This along with
setting the `vm.stats.increment.metrics` setting to false as well.
What do you think - @JoaoJandre @weizhouapache @DaanHoogland @sureshanaparti
@shwstppr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] VMs with same host-affinity group are deployed to different hosts [cloudstack]
weizhouapache opened a new issue, #9110:
URL: https://github.com/apache/cloudstack/issues/9110
This issue is found in the e2e test of CAPC
for example
https://github.com/kubernetes-sigs/cluster-api-provider-cloudstack/pull/350#issuecomment-2123992442
https://github.com/kubernetes-sigs/cluster-api-provider-cloudstack/pull/356#issuecomment-2122647979
https://github.com/kubernetes-sigs/cluster-api-provider-cloudstack/pull/356#issuecomment-2124387388
similar issue for anti-host-affinity groups, the VMs are deployed to same
host.
https://github.com/kubernetes-sigs/cluster-api-provider-cloudstack/pull/350#issuecomment-2121015061
The issue is caused by parallel deployment of VMs
```
2024-05-21 22:18:55,696 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl]
(qtp1866850137-18:ctx-8183c8b3 ctx-5a9b76e5 ctx-f8cf5bbe) (logid:86195b45)
submit async job-3362, details: AsyncJobVO: {id:3362, userId: 2, accountId: 2,
instanceType: VirtualMachine, instanceId: 276, cmd:
org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin, cmdInfo:
{"apiKey":"LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q","signature":"2DkJqWqpEDkVimY04J0DjIB4K1Q\u003d","keypair":"CAPCKeyPair6","httpmethod":"POST","templateid":"725a9858-dd25-44b2-99d8-d3e0d657ac44","ctxAccountId":"2","uuid":"b1268b89-2363-4109-80c5-bff366b2e519","cmdEventType":"VM.CREATE","userdata":"H4sI/6RUTW/jNhC9+1cMEmDTHiTbsS3LPBQoFgu0RbEIuov2GIzIkTURxVHJURx3u/+9kKomTnMp0Is+Ht+8+cA8Xl+DUtd7VDLwwOEBF9fWy+AyK6Hm42Jxiqx0X7OnZBYZAPSojYFlHMKyHSpC1/3zzh6EwxyYn7HzCwAAOQWKBqKImvExgT3FjlNiCcnAzarYrm4m3EpQCmrgz+kXIMuy+Qt7/pXiGGJgTpi3ZcpZlo/rihQ3M9FxsvJI8WxmAKAS0aQR+8/SUnjBJ9VPFB8pfgiuFx5Tr1f5Kt8V+
Xq1N8V2u7lgW3xPUX/A1IzTeMEzSA3e7gpz2B32riora/fbvV3vixK3xWZHxebWbXG9LssDlfWhsHio3a6mw5bcerOmoqxW+6paX2jqVCqUcqSiysv2tgm6+51td4tF1c3EloMz8JNweD+NfYioLGE+DeLoFzry2PoIv5TMHR7pbvD+Tjzbs4Ef64+id5ESBX1mjWP2pB+eNOL38fiq5T7KIzuKGTsD08okRdua5XJ58+ULuJR3pHjvUDHnkBSDpXt28PXrzbNKwI4MjHQvFv19I0lH7BVJkYNepM6A6pqsGvgon2xDbvB0UVdLZzM1nls/JKWYP2XzmgyBAyuj5z/IzSH/Xuk5KMOel71HS414R/F/bPLV54YTXGjBaCbgBEMiBypgI6ESaENvaoA0VOA4klWJZ+AACCc8gzaoo4SVrkflyhOcWBuoRBv4mcPwBBgc/MbBySnBN13rOELWv03ghBIEUThJbP8WmaO+vVrEIdjOjbPP4CqdsJe6hgyvJmA2IYyuh2z2/X+7GADevQOyjUAarKWU4Lu34382bTaT8rFbT0qLvwIAAP//C58UcbcEAAA\u003d","networkids":"a0b2c9d0-31b0-49f2-bcb0-57b46410c236","serviceofferingid":"a2ffec97-63e2-4fe2-83ee-052387b44752","response":"json","ctxUserId":"2","displayname":"affinity-group-0b80f6-md-0-j6frs-q55x8","name":"affinity-group-0b80f6-md-0-sjlb2","zoneid":"bc8ec269-b43b-44e1-bb52-eb9bb7a29f51","ctxStartEventId":"8372","id":"276","ctxDetails":"{\"interface
com.cloud.offering.ServiceOffering\":\"a2ffec97-63e2-4
fe2-83ee-052387b44752\",\"interface
org.apache.cloudstack.affinity.AffinityGroup\":\"8548f41f-a4b5-4a3d-9a67-4d6032e0675f\",\"interface
com.cloud.network.Network\":\"a0b2c9d0-31b0-49f2-bcb0-57b46410c236\",\"interface
com.cloud.template.VirtualMachineTemplate\":\"725a9858-dd25-44b2-99d8-d3e0d657ac44\",\"interface
com.cloud.dc.DataCenter\":\"bc8ec269-b43b-44e1-bb52-eb9bb7a29f51\",\"interface
com.cloud.vm.VirtualMachine\":\"b1268b89-2363-4109-80c5-bff366b2e519\"}","affinitygroupids":"8548f41f-a4b5-4a3d-9a67-4d6032e0675f"},
cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result:
null, initMsid: 32988737831359, completeMsid: null, lastUpdated: null,
lastPolled: null, created: null, removed: null}
2024-05-21 22:18:55,705 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl]
(qtp1866850137-1054:ctx-88df36ab ctx-6b3456d4 ctx-1485cdb2) (logid:4d8744c9)
submit async job-3361, details: AsyncJobVO: {id:3361, userId: 2, accountId: 2,
instanceType: VirtualMachine, instanceId: 277, cmd:
org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin, cmdInfo:
{"apiKey":"LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q","signature":"TaBnd9xegAFix7qi4zALyonoZuI\u003d","keypair":"CAPCKeyPair6","httpmethod":"POST","templateid":"725a9858-dd25-44b2-99d8-d3e0d657ac44","ctxAccountId":"2","uuid":"3f706c6b-9448-423b-92e2-2a02f0f2ad68","cmdEventType":"VM.CREATE","userdata":"H4sI/6RUTY/jRBC951eUZqQdONiJN4mT9AEJrVYChFYjdgXHUbm7PK643WW6y8mEZf87sjEzWeaCxMUfr1+9+lC9vr0Fpa73qGTgyOGIi1vrZXCZlVDz42Jxjqz0ULOnZBYZAPSojYFlHMKyHSpC1/3zzo7CYQ7ML9j5BQCAnANFA1FEzfiYwJ5ixymxhGTgblVuVncTbiUoBTXw5/QLkGXZ/IU9/0pxDDEwJ8zbfcpZlqeiIsX1THScrJwoXswMAFQimjRi/0laCi/4pPqR4oni++B64TF1scpX+bb
Re: [PR] Do not retrieve VM's stats on normal VM listing [cloudstack]
rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1609919869
##
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey SharePublicTemplatesWithOtherDomains = new
ConfigKey<>("Advanced", Boolean.class,
"share.public.templates.with.other.domains", "true",
"If false, templates of this domain will not show up in the list
templates of other domains.", true, ConfigKey.Scope.Domain);
+ConfigKey ReturnVmStatsOnVmList = new ConfigKey<>("Advanced",
Boolean.class, "return.vm.stats.on.vm.list", "true",
Review Comment:
```suggestion
ConfigKey ReturnVmStatsOnVmList = new ConfigKey<>("Advanced",
Boolean.class, "return.vm.stats.on.vm.list", "false",
```
After due considerations, I think this can be set to false what originally
Joao wants to accomplish. As the listVirtualMachines API is used by at least
three integrations I know of (CAPC, k8s-provider and terraform etc.) and
several portals are built on top such APIs, it makes sense to trade off speed.
BUT, if we do this we must document this change in the release notes and what
users can do to get previous/old behaviour if they want it.
What do you think - @JoaoJandre @weizhouapache @DaanHoogland @sureshanaparti
@shwstppr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Decrypt account and domain configurations when needed [cloudstack]
blueorangutan commented on PR #9088: URL: https://github.com/apache/cloudstack/pull/9088#issuecomment-2124749425 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Decrypt account and domain configurations when needed [cloudstack]
weizhouapache commented on PR #9088: URL: https://github.com/apache/cloudstack/pull/9088#issuecomment-2124748129 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Storage Overprovisioning [cloudstack]
Sislik opened a new issue, #9109: URL: https://github.com/apache/cloudstack/issues/9109 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ ~~~ # CLOUDSTACK VERSION ~~~ ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY # STEPS TO REPRODUCE   ~~~ ~~~ # EXPECTED RESULTS ~~~ ~~~ # ACTUAL RESULTS ~~~ ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Decrypt account and domain configurations when needed [cloudstack]
BryanMLima commented on PR #9088: URL: https://github.com/apache/cloudstack/pull/9088#issuecomment-2124715494 > clgtm, would these constructs have to be added to other scopes as well? i.e. move the code to the `GenercDaoBase` !? Currently, there is no need, as the changes are only in respect to the removal of the `@Encrypt` annotation from Account and Domain details tables in PR #6812. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Storage Overprovisioning [cloudstack]
boring-cyborg[bot] commented on issue #9109: URL: https://github.com/apache/cloudstack/issues/9109#issuecomment-2124715599 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] listNetworks optimization [cloudstack]
blueorangutan commented on PR #9096: URL: https://github.com/apache/cloudstack/pull/9096#issuecomment-2124712657 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/config: make logic in ::value() defensive [cloudstack]
codecov[bot] commented on PR #9108: URL: https://github.com/apache/cloudstack/pull/9108#issuecomment-2124712669 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9108?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.26%. Comparing base [(`5f73172`)](https://app.codecov.io/gh/apache/cloudstack/commit/5f73172bcbe975e4ef416e525dc95bad63fa6d3a?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`54d597e`)](https://app.codecov.io/gh/apache/cloudstack/pull/9108?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ##main #9108 +/- ## = Coverage 4.26% 4.26% = Files363 363 Lines 29565 29565 Branches51905190 = Hits12621262 Misses 28160 28160 Partials 143 143 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9108/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9108/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.26% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9108?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/config: make logic in ::value() defensive [cloudstack]
blueorangutan commented on PR #9108: URL: https://github.com/apache/cloudstack/pull/9108#issuecomment-2124697241 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] framework/config: make logic in ::value() defensive [cloudstack]
rohityadavcloud commented on PR #9108: URL: https://github.com/apache/cloudstack/pull/9108#issuecomment-2124694945 Build and Github Actions/CI checks are enough to validate this change (I hope) @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
