Re: [PR] New feature: Implicit host tags [cloudstack]
rohityadavcloud merged PR #8929: URL: https://github.com/apache/cloudstack/pull/8929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2125798952 [SF] Trillian test result (tid-10238) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48502 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8929-t10238-kvm-rocky8.zip Smoke tests completed. 131 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 440.82 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2124071225 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2124067076 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2124046156 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2123930375 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2123929053 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2123505649 [SF] Trillian test result (tid-10231) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 47649 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8929-t10231-kvm-rocky8.zip Smoke tests completed. 130 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 438.31 | test_events_resource.py test_01_restore_vm | `Error` | 0.24 | test_restore_vm.py test_02_restore_vm_allocated_root | `Error` | 0.17 | test_restore_vm.py ContextSuite context=TestRestoreVM>:teardown | `Error` | 1.26 | test_restore_vm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2122020747 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2122019672 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2121995736 [SF] Trillian Build Failed (tid-10226) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
vladimirpetrov commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2121933541 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2121934333 @vladimirpetrov a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2089920549 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2089794810 This is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2089791360 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2089788538 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2089314443 [SF] Trillian test result (tid-10112) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 47836 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8929-t10112-kvm-rocky8.zip Smoke tests completed. 130 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 442.18 | test_events_resource.py test_01_restore_vm | `Error` | 0.23 | test_restore_vm.py test_02_restore_vm_allocated_root | `Error` | 0.16 | test_restore_vm.py ContextSuite context=TestRestoreVM>:teardown | `Error` | 1.25 | test_restore_vm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2088246932 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2088244663 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2088218178 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2088143060 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2088142393 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2082483387 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2078231719 [SF] Trillian test result (tid-10014) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 51258 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8929-t10014-kvm-rocky8.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 444.16 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2076487218 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2076484629 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2074910544 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2074774914 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2074772736 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2074755037 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2074752726 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2071470178 [SF] Trillian test result (tid-9957) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48206 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8929-t9957-xenserver-71.zip Smoke tests completed. 128 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 237.14 | test_events_resource.py test_01_events_resource | `Error` | 237.14 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 107.84 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.52 | test_network_permissions.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2071441794 [SF] Trillian test result (tid-9958) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 46346 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8929-t9958-vmware-67u3.zip Smoke tests completed. 119 look OK, 11 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 209.14 | test_events_resource.py test_01_events_resource | `Error` | 209.15 | test_events_resource.py test_DeployVmAntiAffinityGroup_in_project | `Error` | 122.00 | test_affinity_groups_projects.py test_DeployVmAntiAffinityGroup | `Error` | 47.16 | test_affinity_groups.py test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 53.65 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.09 | test_kubernetes_clusters.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 104.01 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.49 | test_network_permissions.py test_01_non_strict_host_anti_affinity | `Failure` | 150.67 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 100.17 | test_nonstrict_affinity_group.py test_01_verify_ipv6_vpc | `Error` | 3.45 | test_vpc_ipv6.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 5.79 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Error` | 5.86 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 6.19 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 5.84 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 5.59 | test_vpc_redundant.py test_01_VPC_nics_after_destroy | `Error` | 6.41 | test_vpc_router_nics.py test_02_VPC_default_routes | `Error` | 5.75 | test_vpc_router_nics.py test_01_redundant_vpc_site2site_vpn | `Failure` | 3.79 | test_vpc_vpn.py test_01_vpc_site2site_vpn_multiple_options | `Failure` | 3.49 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | `Failure` | 1.24 | test_vpc_vpn.py test_01_vpc_site2site_vpn | `Failure` | 3.51 | test_vpc_vpn.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 0.08 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 0.07 | test_host_maintenance.py test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.07 | test_host_maintenance.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2071434077 [SF] Trillian test result (tid-9959) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46026 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8929-t9959-kvm-centos7.zip Smoke tests completed. 128 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 304.08 | test_events_resource.py test_01_events_resource | `Error` | 304.09 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 88.48 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.42 | test_network_permissions.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2070062584 @weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2070058028 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2069396819 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2069218374 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
codecov-commenter commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2069249026 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8929?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `25.53191%` with `70 lines` in your changes are missing coverage. Please review. > Project coverage is 15.05%. Comparing base [(`a5508ac`)](https://app.codecov.io/gh/apache/cloudstack/commit/a5508acc54d1638ba469f4d7ce9898b81b5209d0?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`232a982`)](https://app.codecov.io/gh/apache/cloudstack/pull/8929?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 585 commits behind head on main. | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8929?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/com/cloud/host/dao/HostTagsDaoImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree=engine%2Fschema%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fhost%2Fdao%2FHostTagsDaoImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9ob3N0L2Rhby9Ib3N0VGFnc0Rhb0ltcGwuamF2YQ==) | 27.69% | [44 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...ervisor/kvm/resource/LibvirtComputingResource.java](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree=plugins%2Fhypervisors%2Fkvm%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fhypervisor%2Fkvm%2Fresource%2FLibvirtComputingResource.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbXB1dGluZ1Jlc291cmNlLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...pache/cloudstack/api/response/HostTagResponse.java](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree=api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fapi%2Fresponse%2FHostTagResponse.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9yZXNwb25zZS9Ib3N0VGFnUmVzcG9uc2UuamF2YQ==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...schema/src/main/java/com/cloud/host/HostTagVO.java](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree=engine%2Fschema%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fhost%2FHostTagVO.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9ob3N0L0hvc3RUYWdWTy5qYXZh) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...ain/java/com/cloud/api/query/QueryManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fapi%2Fquery%2FQueryManagerImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9xdWVyeS9RdWVyeU1hbmFnZXJJbXBsLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...udstack/api/response/HostForMigrationResponse.java](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree=api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fapi%2Fresponse%2FHostForMigrationResponse.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9yZXNwb25zZS9Ib3N0Rm9yTWlncmF0aW9uUmVzcG9uc2UuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | |
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2069216220 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2066959313 > > > @JoaoJandre thanks for your review > > > the methods are moved from [HostTagDaoImpl.java](https://github.com/apache/cloudstack/blob/4.19/server/src/main/java/com/cloud/api/query/dao/HostTagDaoImpl.java) without any code changes. Since it has the very similar class name as [HostTagsDaoImpl](https://github.com/apache/cloudstack/blob/4.19/engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java), I merged them into 1 file. > > > > suggestion committed @JoaoJandre > > > > actually the test could be simple, as the all host tags are considered during vm deployment and vm migration, etc, including the implicit and current (explicit) host tags. > > @weizhouapache What happens if you define an implicit tag on a host and a flexible tag on it as well? > Currently you either have normal or flexible tags, not both. here is a question: why not both? the normal tag could be regarded as a special type of flexible tag. This PR will not break the flexible tags anyway, as the implicit tags are empty by default. It can be regarded as a limitation. I will update the doc PR. Anyone who is interested in supporting both implicit tags and flexible tags can work on the improvement to support both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
JoaoJandre commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2066932539 > > @JoaoJandre thanks for your review > > the methods are moved from [HostTagDaoImpl.java](https://github.com/apache/cloudstack/blob/4.19/server/src/main/java/com/cloud/api/query/dao/HostTagDaoImpl.java) without any code changes. Since it has the very similar class name as [HostTagsDaoImpl](https://github.com/apache/cloudstack/blob/4.19/engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java), I merged them into 1 file. > > suggestion committed @JoaoJandre > > actually the test could be simple, as the all host tags are considered during vm deployment and vm migration, etc, including the implicit and current (explicit) host tags. @weizhouapache What happens if you define an implicit tag on a host and a flexible tag on it as well? Currently you either have normal or flexible tags, not both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2066918607 > @JoaoJandre thanks for your review > > the methods are moved from [HostTagDaoImpl.java](https://github.com/apache/cloudstack/blob/4.19/server/src/main/java/com/cloud/api/query/dao/HostTagDaoImpl.java) without any code changes. Since it has the very similar class name as [HostTagsDaoImpl](https://github.com/apache/cloudstack/blob/4.19/engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java), I merged them into 1 file. suggestion committed @JoaoJandre actually the test could be simple, as the all host tags are considered during vm deployment and vm migration, etc, including the implicit and current (explicit) host tags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2066749768 @JoaoJandre thanks for your review the methods are moved from [HostTagDaoImpl.java](https://github.com/apache/cloudstack/blob/4.19/server/src/main/java/com/cloud/api/query/dao/HostTagDaoImpl.java) without any code changes. Since it has the very similar class name as [HostTagsDaoImpl](https://github.com/apache/cloudstack/blob/4.19/engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java), I merged them into 1 file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
JoaoJandre commented on code in PR #8929:
URL: https://github.com/apache/cloudstack/pull/8929#discussion_r1572398700
##
engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java:
##
@@ -110,4 +167,72 @@ public ConfigKey[] getConfigKeys() {
public String getConfigComponentName() {
return HostTagsDaoImpl.class.getSimpleName();
}
+
+@Override
+public HostTagResponse newHostTagResponse(HostTagVO tag) {
+HostTagResponse tagResponse = new HostTagResponse();
+
+tagResponse.setName(tag.getTag());
+tagResponse.setHostId(tag.getHostId());
+tagResponse.setImplicit(tag.getIsImplicit());
+
+tagResponse.setObjectName("hosttag");
+
+return tagResponse;
+}
+
+@Override
+public List searchByIds(Long... stIds) {
+String batchCfg = _configDao.getValue("detail.batch.query.size");
+
+final int detailsBatchSize = batchCfg != null ?
Integer.parseInt(batchCfg) : 2000;
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
+while ((curr_index + detailsBatchSize) <= stIds.length) {
+Long[] ids = new Long[detailsBatchSize];
+
+for (int k = 0, j = curr_index; j < curr_index +
detailsBatchSize; j++, k++) {
+ids[k] = stIds[j];
+}
+
+SearchCriteria sc = stSearch.create();
+
+sc.setParameters("idIN", (Object[])ids);
+
+List vms = searchIncludingRemoved(sc, null, null,
false);
Review Comment:
```suggestion
List hostTags = searchIncludingRemoved(sc, null,
null, false);
```
##
engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java:
##
@@ -110,4 +167,72 @@ public ConfigKey[] getConfigKeys() {
public String getConfigComponentName() {
return HostTagsDaoImpl.class.getSimpleName();
}
+
+@Override
+public HostTagResponse newHostTagResponse(HostTagVO tag) {
+HostTagResponse tagResponse = new HostTagResponse();
+
+tagResponse.setName(tag.getTag());
+tagResponse.setHostId(tag.getHostId());
+tagResponse.setImplicit(tag.getIsImplicit());
+
+tagResponse.setObjectName("hosttag");
+
+return tagResponse;
+}
+
+@Override
+public List searchByIds(Long... stIds) {
Review Comment:
what does the "st" in "stIds" mean?
##
engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java:
##
@@ -110,4 +167,72 @@ public ConfigKey[] getConfigKeys() {
public String getConfigComponentName() {
return HostTagsDaoImpl.class.getSimpleName();
}
+
+@Override
+public HostTagResponse newHostTagResponse(HostTagVO tag) {
+HostTagResponse tagResponse = new HostTagResponse();
+
+tagResponse.setName(tag.getTag());
+tagResponse.setHostId(tag.getHostId());
+tagResponse.setImplicit(tag.getIsImplicit());
+
+tagResponse.setObjectName("hosttag");
+
+return tagResponse;
+}
+
+@Override
+public List searchByIds(Long... stIds) {
+String batchCfg = _configDao.getValue("detail.batch.query.size");
+
+final int detailsBatchSize = batchCfg != null ?
Integer.parseInt(batchCfg) : 2000;
+
+// query details by batches
+List uvList = new ArrayList();
Review Comment:
hostTagList?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2065452580 [SF] Trillian test result (tid-9898) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48000 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8929-t9898-kvm-rocky8.zip Smoke tests completed. 128 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 310.14 | test_events_resource.py test_01_events_resource | `Error` | 310.15 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 96.39 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.56 | test_network_permissions.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2063369437 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2063364926 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2063330342 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2063265733 > Code looks good. Need to wait for the test results This should be useful for operators adding/re-adding specialized hosts as it makes adding host tags easier in such cases by only adding once. thanks @shwstppr yeah it will be much easier for operators to set host tags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
shwstppr commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2063245858 Never mind about documentation. I couldn't read the linked doc PR above :man_facepalming: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2063191386 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2063190376 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2061100330 > @weizhouapache, could you describe the objectives of this feature and how you expect it to work? @GutoVeronezi I just added a paragraph in the description. Hope it answers your question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
GutoVeronezi commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2061054455 @weizhouapache, could you describe the objectives of this feature and how you expect it to work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on code in PR #8929:
URL: https://github.com/apache/cloudstack/pull/8929#discussion_r1568698055
##
api/src/main/java/org/apache/cloudstack/api/response/HostForMigrationResponse.java:
##
@@ -205,9 +205,13 @@ public class HostForMigrationResponse extends BaseResponse
{
private String events;
@SerializedName("hosttags")
-@Param(description = "comma-separated list of tags for the host")
+@Param(description = "comma-separated list of explicit host tags for the
host")
private String hostTags;
+@SerializedName("implicithosttags")
+@Param(description = "comma-separated list of implicit host tags for the
host", since = "4.18.1")
Review Comment:
updated this and another file , thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
DaanHoogland commented on code in PR #8929:
URL: https://github.com/apache/cloudstack/pull/8929#discussion_r1568623029
##
api/src/main/java/org/apache/cloudstack/api/response/HostForMigrationResponse.java:
##
@@ -205,9 +205,13 @@ public class HostForMigrationResponse extends BaseResponse
{
private String events;
@SerializedName("hosttags")
-@Param(description = "comma-separated list of tags for the host")
+@Param(description = "comma-separated list of explicit host tags for the
host")
private String hostTags;
+@SerializedName("implicithosttags")
+@Param(description = "comma-separated list of implicit host tags for the
host", since = "4.18.1")
Review Comment:
```suggestion
@Param(description = "comma-separated list of implicit host tags for the
host", since = "4.20.0")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] New feature: Implicit host tags [cloudstack]
weizhouapache opened a new pull request, #8929:
URL: https://github.com/apache/cloudstack/pull/8929
### Description
This PR adds a new feature to add implicit host tags via agent.properties
- Explicit host tags: the tags of host managed by cloudstack (CRUD APIs)
- Implicit host tags: the tags managed by agent.properties on kvm host
This PR also
- Merge two HostTagVO and HostTagDaoImpl
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
