[GitHub] [cordova-android] dpogue commented on issue #896: feat: add kotlin support
dpogue commented on issue #896: feat: add kotlin support URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574997513 > @timbru31 I just added the Kotlin source set as well, per your change request's overview comment. The only thing I was not sure is if it was necessary to wrap that behind a flag too. IMO no need for a flag for adding the src/main/kotlin folder. Note that currently all plugin source files will end up in src/main/java because there's no special handling to detect kotlin files. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat: add kotlin support
codecov-io edited a comment on issue #896: feat: add kotlin support URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=h1) Report > Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/a95179343142318ee64a043f5b5a03063d7b016d?src=pr=desc) will **decrease** coverage by `0.14%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=tree) ```diff @@Coverage Diff @@ ## master #896 +/- ## == - Coverage 66.17% 66.03% -0.15% == Files 19 19 Lines1839 1843 +4 == Hits 1217 1217 - Misses622 626 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `35.11% <0%> (-0.48%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=footer). Last update [a951793...742643d](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat: add kotlin support
codecov-io edited a comment on issue #896: feat: add kotlin support URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=h1) Report > Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/a95179343142318ee64a043f5b5a03063d7b016d?src=pr=desc) will **decrease** coverage by `0.14%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=tree) ```diff @@Coverage Diff @@ ## master #896 +/- ## == - Coverage 66.17% 66.03% -0.15% == Files 19 19 Lines1839 1843 +4 == Hits 1217 1217 - Misses622 626 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `35.11% <0%> (-0.48%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=footer). Last update [a951793...742643d](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] erisu commented on issue #896: feat: add kotlin support
erisu commented on issue #896: feat: add kotlin support URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574996574 @timbru31 I just added the Kotlin source set as well, per your change request's overview comment. The only thing I was not sure is if it was necessary to wrap that behind a flag too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] erisu commented on issue #896: feat: add kotlin support
erisu commented on issue #896: feat: add kotlin support URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574994317 @timbru31 I went ahead and created a new Kotlin support PR so we can quickly apply all the changes and improvements to get Kotlin prepared and released hopefully in the next day or 2. Per your change request in the previous PR, I have: * Updated Kotlin to the latest version * Replaced `mavenCentral` with `jcenter` in the `test/app/build.gradle` **NOTICE**: This change is not applied to the actual `build.gradle` that is used when building a Cordova project. The actual file, `bin/templates/project/app/build.gradle`, still uses in the following order: mavenCentral -> google -> jcenter If these are to be updated, it should be taken care of in a separate PR * Per your comment about `kotlin:kotlin-stdlib-jdk7` I believe it is best to keep it as `kotlin:kotlin-stdlib-jdk7`. A newly created Android project with the official Android Studio uses `kotlin:kotlin-stdlib-jdk7`. Probably best to not do something different. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on issue #896: feat: add kotlin support
codecov-io commented on issue #896: feat: add kotlin support URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=h1) Report > Merging [#896](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/a95179343142318ee64a043f5b5a03063d7b016d?src=pr=desc) will **decrease** coverage by `0.14%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=tree) ```diff @@Coverage Diff @@ ## master #896 +/- ## == - Coverage 66.17% 66.03% -0.15% == Files 19 19 Lines1839 1843 +4 == Hits 1217 1217 - Misses622 626 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/896/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `35.11% <0%> (-0.48%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=footer). Last update [a951793...babf7a5](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] erisu commented on issue #441: CB-14089: (android) Add Kotlin support
erisu commented on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-574989908 Hi @joshchandler, I noticed that there was no activity after the "request change" that was posted a week ago. I went ahead and created a second PR to quickly prepare and get ready to release Kotlin support. The new PR uses this PR as its base. (New PR: https://github.com/apache/cordova-android/pull/896) The PR changes consist of: * Rebased with the latest master branch * Fixes the merge conflicts * Applies suggested changes * Additionally improves I expect to merge my PR with in the next day or two which will automatically close this PR. Since your commits were cherry-picked into my new PR, it will still retain your contributions. Thank you for your contribution and sorry that it took this long to merge in your commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] erisu opened a new pull request #896: dFeat/kotlin support
erisu opened a new pull request #896: dFeat/kotlin support URL: https://github.com/apache/cordova-android/pull/896 ### Motivation and Context To finish off the change requests and close out PR #441 closes: #441 ### Description What this PR does: * Cherry-picks commit changes from #441 * Rename preference option `EnableKotlin` to `KotlinEnabled` (Default: `false`) * Since the preference has not been released or used in any other repos, the name change is safe. This change is only an update from the original PR's proposal. * Added preference options `KotlinCodeStyle` (Default: `official`) * Added preference option `KotlinVersion` (Default: `1.3.41`) * Apply `kotlin-android-extensions` plugin as well when `EnableKotlin` is `true` * Changed `compile` to `implementation` ### Testing - `npm t` ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary (*Pending Work for Cordova Docs Repo*) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] erisu edited a comment on issue #438: Add support for EnableGoogleServicesPlugin
erisu edited a comment on issue #438: Add support for EnableGoogleServicesPlugin URL: https://github.com/apache/cordova-android/pull/438#issuecomment-574946339 @chemerisuk I do not have an issue ticket regarding the issues I described with the `phonegap-plugin-push` plugin. But, I pushed a PR that briefly explains changes to the plugin that will be needed to use these new preference options without having a build issue. It removed the enable google services plugin dependency. The issue the plugin had was a conflict with the new preferences enabling the Google Services in the buildscript while the enable google services plugin dependency did the same thing. Here is the PR: https://github.com/phonegap/phonegap-plugin-push/pull/2873 It is currently labeled as `DRAFT` because we will need to first release the major. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] erisu commented on issue #438: Add support for EnableGoogleServicesPlugin
erisu commented on issue #438: Add support for EnableGoogleServicesPlugin URL: https://github.com/apache/cordova-android/pull/438#issuecomment-574946339 @chemerisuk I do not have an issue ticket on the `phonegap-plugin-push` issues I mentioned. But I pushed a PR that briefly explains some changes to the plugin that will use these new preference option over the previously added dependencies. The issue was around added the enable google services plugin as a dependency with these new changes. It created conflicts. Here is the PR: https://github.com/phonegap/phonegap-plugin-push/pull/2873 It is currently labeled as `DRAFT` because we will need to first release the major. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-windows] breautek commented on issue #374: Cordova Build Android shows error
breautek commented on issue #374: Cordova Build Android shows error URL: https://github.com/apache/cordova-windows/issues/374#issuecomment-574923731 What command line shell are you using? I see windows-style paths, but linux/mac executables are attempted to be executed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-windows] buchion opened a new issue #374: Cordova Build Android shows error
buchion opened a new issue #374: Cordova Build Android shows error URL: https://github.com/apache/cordova-windows/issues/374 cordova run android Discovered saved plugin "cordova-plugin-splashscreen". Adding it to the project Failed to restore plugin "cordova-plugin-splashscreen" from config.xml. You might need to try adding it again. Error: Cannot find plugin.xml for plugin "cordova-plugin-splashscreen". Please try adding it again. Checking Java JDK and Android SDK versions ANDROID_SDK_ROOT=undefined (recommended setting) ANDROID_HOME=C:\Users\buchi\AppData\Local\Android\sdk (DEPRECATED) Subproject Path: CordovaLib Subproject Path: app chmod: File not found: C:\Users\buchi\Desktop\Coou\platforms\android\gradle\wrapper\gradle-wrapper.properties sed: no such file or directory: C:\Users\buchi\Desktop\Coou\platforms\android\gradle\wrapper\gradle-wrapper.properties 'sh' is not recognized as an internal or external command, operable program or batch file. C:\Users\buchi\Desktop\Coou\platforms\android\gradlew: Command failed with exit code 1 Error output: 'sh' is not recognized as an internal or external command, operable program or batch file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] cedw032 commented on issue #555: IAB.close() called but it was already closed
cedw032 commented on issue #555: IAB.close() called but it was already closed URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/555#issuecomment-574910008 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] erisu commented on issue #895: feat: move ci to gh-actions
erisu commented on issue #895: feat: move ci to gh-actions URL: https://github.com/apache/cordova-android/pull/895#issuecomment-574909489 Please ignore that the AppVeyor CI service is failing. AppVeyor would be turned off as this would replace it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-android] branch master updated: feat: add google services support (#893)
This is an automated email from the ASF dual-hosted git repository.
erisu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git
The following commit(s) were added to refs/heads/master by this push:
new a951793 feat: add google services support (#893)
a951793 is described below
commit a95179343142318ee64a043f5b5a03063d7b016d
Author: エリス
AuthorDate: Thu Jan 16 08:40:54 2020 +0900
feat: add google services support (#893)
* feat: Add support for GoogleServicesEnabled preference option
* fix: wrap google-services classpath with GoogleServicesEnabled flag
* chore: bump google-services version to 4.2.0
* feat: Add support for GoogleServicesVersion preference option
Co-authored-by: Maksim Chemerisuk
---
bin/templates/project/app/build.gradle | 25 +
framework/cordova.gradle | 4
2 files changed, 29 insertions(+)
diff --git a/bin/templates/project/app/build.gradle
b/bin/templates/project/app/build.gradle
index ea26195..47cef0d 100644
--- a/bin/templates/project/app/build.gradle
+++ b/bin/templates/project/app/build.gradle
@@ -27,7 +27,28 @@ buildscript {
}
dependencies {
+apply from: '../CordovaLib/cordova.gradle'
+
classpath 'com.android.tools.build:gradle:3.3.0'
+
+if(cdvHelpers.getConfigPreference('GoogleServicesEnabled',
'false').toBoolean()) {
+String defaultGoogleServiceVersion = '4.2.0'
+
+/**
+ * Fetches the user's defined Google Services Plugin Version from
config.xml.
+ * If the version is not set or invalid, it will default to the
${defaultGoogleServiceVersion}
+ */
+String googleServicesVersion =
cdvHelpers.getConfigPreference('GoogleServicesVersion',
defaultGoogleServiceVersion)
+if(!cdvHelpers.isVersionValid(googleServicesVersion)) {
+println("The defined Google Services plugin version
(${googleServicesVersion}) does not appear to be a valid version. Falling back
to version: ${defaultGoogleServiceVersion}.")
+googleServicesVersion = defaultGoogleServiceVersion
+}
+
+// Create the Google Services classpath and set it.
+String googleServicesClassPath =
"com.google.gms:google-services:${googleServicesVersion}"
+println "Adding classpath: ${googleServicesClassPath}"
+classpath googleServicesClassPath
+}
}
}
@@ -356,3 +377,7 @@ for (def func : cdvPluginPostBuildExtras) {
if (hasProperty('postBuildExtras')) {
postBuildExtras()
}
+
+if (cdvHelpers.getConfigPreference('GoogleServicesEnabled',
'false').toBoolean()) {
+apply plugin: 'com.google.gms.google-services'
+}
diff --git a/framework/cordova.gradle b/framework/cordova.gradle
index 5a06ea7..0fb476c 100644
--- a/framework/cordova.gradle
+++ b/framework/cordova.gradle
@@ -48,6 +48,10 @@ Version[] getAvailableBuildTools() {
.sort { a, b -> a.isHigherThan(b) ? -1 : 1 }
}
+Boolean isVersionValid(version) {
+return !(new Version(version)).isEqual('0.0.0')
+}
+
String doFindLatestInstalledBuildTools(String minBuildToolsVersionString) {
def availableBuildToolsVersions
try {
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #893: feat: add google services support
erisu merged pull request #893: feat: add google services support URL: https://github.com/apache/cordova-android/pull/893 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] erisu closed pull request #438: Add support for EnableGoogleServicesPlugin
erisu closed pull request #438: Add support for EnableGoogleServicesPlugin URL: https://github.com/apache/cordova-android/pull/438 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-file] fragatak edited a comment on issue #239: Not seeing files that are stored on the Android device
fragatak edited a comment on issue #239: Not seeing files that are stored on the Android device URL: https://github.com/apache/cordova-plugin-file/issues/239#issuecomment-574849382 I think I have got this working in initial testing. I added `` to the AndroidManifest.xml. I also added the cordova-plugin-android-permissions aswell. So I am not completely sure which one might have made it work. I can now see the Downloads off of cordova.file.externalRootDirectory and when doing 'file:///sdcard' (device root internal directory for shared files) I can now see everything. I am using API level 26 currently. I added a view from Chrome remote console.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-file] fragatak commented on issue #239: Not seeing files that are stored on the Android device
fragatak commented on issue #239: Not seeing files that are stored on the Android device URL: https://github.com/apache/cordova-plugin-file/issues/239#issuecomment-574849382 I think I have got this working in initial testing. I added to the AndroidManifest.xml. I also added the cordova-plugin-android-permissions aswell. So I am not completely sure which one might have made it work. I can now see the Downloads off of cordova.file.externalRootDirectory and when doing 'file:///sdcard' (device root internal directory for shared files) I can now see everything. I am using API level 26 currently. I added a view from Chrome remote console.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-docs] brodybits opened a new issue #1051: feature tag seems to be missing in plugin reference
brodybits opened a new issue #1051: feature tag seems to be missing in plugin reference URL: https://github.com/apache/cordova-docs/issues/1051 The feature and param tags are part of the config-file in plugin.xml but seems to be not documented in https://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/index.html While I do see examples in plugin documentation for Android and iOS, I would expect these tags to be documented in the reference. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] dwasyluk commented on issue #197: Android: White screen before splash screen
dwasyluk commented on issue #197: Android: White screen before splash screen URL: https://github.com/apache/cordova-plugin-splashscreen/issues/197#issuecomment-574803429 Thanks @hungtranpg I can confirm that fix works. I was able to just add `true` to the default `AppTheme` and that did the trick. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-camera] PabbleDabble edited a comment on issue #448: Incorrect Orientation on Windows 10
PabbleDabble edited a comment on issue #448: Incorrect Orientation on Windows 10
URL:
https://github.com/apache/cordova-plugin-camera/issues/448#issuecomment-574780339
I'll be picking this ticket up in our upcoming sprint. If anyone is alerted
by this message and has any new information, I would be greatly appreciative.
I'll report back findings as they arise.
This is the options I'm passing to getPicture()
// this.camera is ionic-native/camera import
const options: CameraOptions = {
quality: 25
, destinationType: this.camera.DestinationType.NATIVE_URI
, encodingType: this.camera.EncodingType.JPEG
, mediaType: this.camera.MediaType.PICTURE
, sourceType: source
, correctOrientation: true
};
Note: "allowEdit: true" here gave an interesting UI to zoom / pan the image,
and did end up keeping the correct orientation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] bhandaribhumin commented on issue #887: android build error
bhandaribhumin commented on issue #887: android build error URL: https://github.com/apache/cordova-android/issues/887#issuecomment-574792060 i resolve this issue using some tweaks, @tryhardest thanks for your advice and help. cheers bro This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova] tryhardest edited a comment on issue #185: Deprecated plugins
tryhardest edited a comment on issue #185: Deprecated plugins URL: https://github.com/apache/cordova/issues/185#issuecomment-574777183 To be clear I presume you are only suggesting sunsetting when newer versions of plugins are available aka close-to drop in replacement plugins? Often new webAPIs that have core plugin functionality fully supported but cannot alone do the extended things some of those listed plugins can. At least not without months of work all told, or a huge amount of additional build out and refactor (maybe enough to kill businesses) which could honestly accompany this decision on next Cordova upgrade cycle, when these would all possibly become unusable. If for some reason (there often are) projects forced into an upgrade cycle and they find half their app no longer functions. The whole model of Cordova was and is plugin extendability. Certainly hasn't been easy doing so with the complexity of version control, maintainers falling off, conflicts, etc. However, these are all critical plugins for many people who spent massive amounts of time and resources integrating them fully, and as mentioned the extended functionality and use cases in many of the listed plugins is critical to apps functioning correctly. Wouldn't it make more sense seeing as Capacitor functions also on Cordova plugins, to promote upgrading and ongoing development of them by respective maintainers? Or suggesting the plugins reach out for some help and make the appropriate changes to be current? Users always have the option to opt for webAPIs anyway, so why not take that approach without actively promoting the depreciation of so many complex plugins. the depreciation suggestion of these; apache/cordova-plugin-contacts apache/cordova-plugin-device-motion apache/cordova-plugin-device-orientation apache/cordova-plugin-file-transfer apache/cordova-plugin-media apache/cordova-plugin-media-capture apache/cordova-plugin-camera apache/cordova-plugin-file All of which we use, seems like untold headaches. For a small team that could potentially kill us. Took long enough to get all the plugins working correctly. We also additionally use Splashscreen Whitelist but personally we have no issue for those to be integrated, I've always felt that they should be. Further we also use; WKwebview (Ionic version) Whitelist SQLite storage But you have not suggested those to be depreciated, only to superseed core plugins. So I guess I am trying to get a better understanding of how this depreciation is being approached without potentially devistating consequences for thousands of projects moving fwd. Maybe my understanding of stopping active support, development and matenaince on them is elevated due to knowing there is an enevitable dead end with this approach whereby the continuing advancement of the platform will eventually collide with their use at all, rending all the code surrounding each to be unusable. I know (and am grateful) that you maintain many plugins and for your work on Cordova proper. I personally feel if we all took one or two of them under our wings (with webAPI optionality) it's a better approach. Aren't plugin maintainers the ones to decide if they want to continue updating and maintenance on a plugin anyway? In summary; sorry I'm not fully understanding your posts. I am understanding this as either devastating ultimately to our project moving fwd or enough new work that it will destroy our small team because we depend on so much of what you have mentioned. Thanks you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-camera] PabbleDabble commented on issue #448: Incorrect Orientation on Windows 10
PabbleDabble commented on issue #448: Incorrect Orientation on Windows 10 URL: https://github.com/apache/cordova-plugin-camera/issues/448#issuecomment-574780339 I'll be picking this ticket up in our upcoming sprint. If anyone is alerted by this message and has any new information, I would be greatly appreciative. I'll report back findings as they arise. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova] tryhardest commented on issue #185: Deprecated plugins
tryhardest commented on issue #185: Deprecated plugins URL: https://github.com/apache/cordova/issues/185#issuecomment-574777183 To be clear I presume you are only suggesting sunsetting when newer versions of plugins are available aka close-to drop in replacement plugins? Often new webAPIs that have core plugin functionality fully supported but cannot alone do the extended things some of those listed plugins can. At least not without months of work all told, or a huge amount of additional build out and refactor (maybe enough to kill businesses) which could honestly accompany this decision on next Cordova upgrade cycle, when these would all possibly become unusable. If for some reason (there often are) projects forced into an upgrade cycle and they find half their app no longer functions. The whole model of Cordova was and is plugin extendability. Certainly hasn't been easy doing so with the complexity of version control, maintainers falling off, conflicts, etc. However, these are all critical plugins for many people who spent massive amounts of time and resources integrating them fully, and as mentioned the extended functionality and use cases in many of the listed plugins is critical to apps functioning correctly. Wouldn't it make more sense seeing as Capacitor functions also on Cordova plugins, to promote upgrading and ongoing development of them by respective maintainers? Or suggesting the plugins reach out for some help and make the appropriate changes to be current? Users always have the option to opt for webAPIs anyway, so why not take that approach without actively promoting the depreciation of so many complex plugins. the depreciation suggestion of these; apache/cordova-plugin-contacts apache/cordova-plugin-device-motion apache/cordova-plugin-device-orientation apache/cordova-plugin-file-transfer apache/cordova-plugin-media apache/cordova-plugin-file-transfer apache/cordova-plugin-media apache/cordova-plugin-media-capture apache/cordova-plugin-camera apache/cordova-plugin-file All of which we use, seems like untold headaches. For a small team that could potentially kill us. Took long enough to get all the plugins working correctly. We also additionally use Splashscreen Whitelist but personally we have no issue for those to be integrated, I've always felt that they should be. So I guess I am trying to get a better understanding of how this depreciation is being approached without potentially devistating consequences for thousands of projects moving fwd. Maybe my understanding of stopping active support, development and matenaince on them is elevated due to knowing there is an enevitable dead end with this approach whereby the continuing advancement of the platform will eventually collide with their use at all, rending all the code surrounding each to be unusable. I know (and am grateful) that you maintain many plugins and for your work on Cordova proper. I personally feel if we all took one or two of them under our wings (with webAPI optionality) it's a better approach. Aren't plugin maintainers the ones to decide if they want to continue updating and maintenance on a plugin anyway? In summary; sorry I'm not fully understanding your posts. I am understanding this as either devastating ultimately to our project moving fwd or enough new work that it will destroy our small team because we depend on so much of what you have mentioned. Thanks you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] brandPittCode closed issue #611: [ Ionic iOS] create window opens a white screen
brandPittCode closed issue #611: [ Ionic iOS] create window opens a white screen URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] brandPittCode commented on issue #611: [ Ionic iOS] create window opens a white screen
brandPittCode commented on issue #611: [ Ionic iOS] create window opens a white screen URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/611#issuecomment-574742212 I was a problem of url encoding This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] ZumelzuR commented on issue #678: authenticator.xml resource mipmap/icon not found
ZumelzuR commented on issue #678: authenticator.xml resource mipmap/icon not found URL: https://github.com/apache/cordova-android/issues/678#issuecomment-574714031 Is not a good practice to touch the files inside platforms> (edit or create stuff there), so I recommend to change the ICON variable and keep it like ` ... ... ` This route "mipmap/ic_launcher" will work. BTW now package is @mauron85/cordova-plugin-background-geolocation, the other one is deprecated This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] Hadatko commented on issue #580: Download is not working in a link opened in inappbrowser in ionic 4
Hadatko commented on issue #580: Download is not working in a link opened in inappbrowser in ionic 4 URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/580#issuecomment-574712863 Hi, check this: https://getsatisfaction.com/apperyio/topics/in_app_browser_download_links This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] erisu opened a new pull request #895: feat: move ci to gh-actions
erisu opened a new pull request #895: feat: move ci to gh-actions URL: https://github.com/apache/cordova-android/pull/895 ### Motivation and Context Use GitHub Actions instead of third-party CI services. ### Description * Created GitHub Actions Task * Move all Travis CI & AppVeyor jobs to GitHub Actions * Run only one Travis CI job for `codecov` reports. (Job Environment: Linux + Node 12) Codecov has a better UI but requires setting secrets in GH which we do not have the direct ability to set. If we want to continue supporting and using Codecov, we would need to community with INFRA to set the secret token. ### Testing - https://github.com/erisu/cordova-android/commit/0e3bda75114f84788ff6b5319b65dd62e0deda02/checks?check_suite_id=401547626 ### Checklist - [x] I've run the tests to see all new and existing tests pass This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] DimitrisMpanis commented on issue #55: Could not signal service com.apple.WebKit.WebContent in ios 11.4.1
DimitrisMpanis commented on issue #55: Could not signal service com.apple.WebKit.WebContent in ios 11.4.1 URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/55#issuecomment-574681778 Should this be included in the official cordova wkwebview plug in? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] brandPittCode opened a new issue #611: [ Ionic iOS] create window opens a white screen
brandPittCode opened a new issue #611: [ Ionic iOS] create window opens a white screen URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/611 ### Issue Type - [x ] Bug Report - [ ] Feature Request - [ ] Support Question ## Description When I open an url with an in-app-browser instance in iOS the system opens a white window with the word loading at the bottom. ## Information iOS console ouput : "[Assert] Unsupported use of UIKit API off the main thread: UIAccessibilityIsAssistiveTouchRunning() [Assert] Unsupported use of UIKit API off the main thread: UIAccessibilityIsGuidedAccessEnabled()" It works fine in Android. ### Command or Code iab.create(url, 'blank_', 'location=no') ### Environment, Platform, Device ionic iOS ### Version information "@ionic-native/in-app-browser": "^5.12.0", "cordova-plugin-inappbrowser": "^3.2.0", "cordova-plugin-ionic-webview": "^4.0.0", ## Checklist - [x] I searched for already existing GitHub issues about this - [x] I updated all Cordova tooling to their most recent version - [x] I included all the necessary information above This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] huahuichin commented on issue #374: Webview offset and height issue on ios when `toolbarposition=top`
huahuichin commented on issue #374: Webview offset and height issue on ios when `toolbarposition=top` URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/374#issuecomment-574637160 hi, i still have a problem, how to remove the top gray area This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] GlausLivio closed issue #129: webrtc issue
GlausLivio closed issue #129: webrtc issue URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/129 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] GlausLivio opened a new issue #129: webrtc issue
GlausLivio opened a new issue #129: webrtc issue URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/129 I tried to implement video call using webrtc, it is working well on Android, iOS browsers. (ios Safari, too). but It is not working on iOS wkwebview. Do you have any plan to support webrtc? I am now using iosrtc plugin, but it is too old. I dont want to use it in the future. Hope to get your opinion. thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-camera] ankitjainOfficial commented on issue #419: No camera permission in Android app.
ankitjainOfficial commented on issue #419: No camera permission in Android app. URL: https://github.com/apache/cordova-plugin-camera/issues/419#issuecomment-574580292 @AmrAlmagic It's been a while, I think the solution was: Adding this to your config.xml ``` ``` And install this [package](https://github.com/dpa99c/cordova-custom-config#readme) I didn't need to make any changes to AndroidManifest directly. If everything works, you should see the following in `platforms/android/app/src/main/AndroidManifest.xml`: ``` ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-plugin-camera] ankitjainOfficial edited a comment on issue #419: No camera permission in Android app.
ankitjainOfficial edited a comment on issue #419: No camera permission in Android app. URL: https://github.com/apache/cordova-plugin-camera/issues/419#issuecomment-574580292 @AmrAlmagic It's been a while, I think the solution was: Adding this to your `config.xml` ``` ``` And install this [package](https://github.com/dpa99c/cordova-custom-config#readme) I didn't need to make any changes to AndroidManifest directly. If everything works, you should see the following in `platforms/android/app/src/main/AndroidManifest.xml`: ``` ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] [cordova-android] chemerisuk commented on issue #438: Add support for EnableGoogleServicesPlugin
chemerisuk commented on issue #438: Add support for EnableGoogleServicesPlugin URL: https://github.com/apache/cordova-android/pull/438#issuecomment-574561084 @erisu thanks for the update. Unfortunately my current environment is a bit different now, so it will be hard to test those changes properly. So please go ahead with the PR, it's a long waited one. If you have time could you post a link to a compilation problem at `phonegap-plugin-push` you've mentioned. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
