[echarts-doc] 01/01: Merge branch 'dev'
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/echarts-doc.git commit 5183c66e212da333166123a53d349803647346e4 Merge: 9b37769f d625492b Author: Ovilia AuthorDate: Thu Sep 22 15:07:11 2022 +0800 Merge branch 'dev' en/api/echarts.md | 7 +++ en/option-gl/component/globe.md| 5 + en/option-gl/partial/atmosphere.md | 28 en/option/partial/zr-graphic.md| 6 +- zh/api/echarts.md | 13 +++-- zh/option-gl/component/globe.md| 5 + zh/option-gl/partial/atmosphere.md | 28 zh/option/partial/zr-graphic.md| 6 +- 8 files changed, 86 insertions(+), 12 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts-doc] branch master updated (9b37769f -> 5183c66e)
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/echarts-doc.git from 9b37769f Merge pull request #288 from apache/treemap-emphasis add 5aa5e5c8 Merge pull request #269 from apache/master add 687b006a doc: update instruction for custom group being null apache/echarts#17349 add c2739452 fix(custom): update null hints add 847e47cc Merge pull request #270 from apache/fix-custom-merge add b0de16d3 feat:add 'atmosphere' add ab7dc772 fix: delete 'highlight' and 'downplay' from 'events' and 'action' add c899e497 Revert "fix: delete 'highlight' and 'downplay' from 'events' and 'action'" add 5c3e94d7 feat:supplement 'atmosphere' configuration add c6ccf94d Merge pull request #271 from yyp0716/dev add a299ea80 Merge branch 'master' into dev add 30012190 doc: add doc for coarse pointer apache/echarts#17102 add d625492b doc: add doc for coarse pointer apache/echarts#17102 new 5183c66e Merge branch 'dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: en/api/echarts.md | 7 +++ en/option-gl/component/globe.md| 5 + en/option-gl/partial/atmosphere.md | 28 en/option/partial/zr-graphic.md| 6 +- zh/api/echarts.md | 13 +++-- zh/option-gl/component/globe.md| 5 + zh/option-gl/partial/atmosphere.md | 28 zh/option/partial/zr-graphic.md| 6 +- 8 files changed, 86 insertions(+), 12 deletions(-) create mode 100644 en/option-gl/partial/atmosphere.md create mode 100644 zh/option-gl/partial/atmosphere.md - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts-doc] 01/01: doc(gauge): axisLabel support rotate apache/echarts#16985
This is an automated email from the ASF dual-hosted git repository.
ovilia pushed a commit to branch gauge
in repository https://gitbox.apache.org/repos/asf/echarts-doc.git
commit c1748bb4ee3cbc6f67055d081e2a12a75d0ef929
Author: Ovilia
AuthorDate: Thu Sep 22 15:38:56 2022 +0800
doc(gauge): axisLabel support rotate apache/echarts#16985
---
en/option/partial/label-rotate-tangential.md | 9 +
en/option/series/gauge.md| 4
en/option/series/sunburst.md | 19 +++
zh/option/partial/label-rotate-tangential.md | 9 +
zh/option/series/gauge.md| 4
zh/option/series/sunburst.md | 17 +++--
6 files changed, 32 insertions(+), 30 deletions(-)
diff --git a/en/option/partial/label-rotate-tangential.md
b/en/option/partial/label-rotate-tangential.md
new file mode 100644
index ..b0a29d3a
--- /dev/null
+++ b/en/option/partial/label-rotate-tangential.md
@@ -0,0 +1,9 @@
+{{ target: partial-label-rotate-tangential }}
+
+#${prefix} rotate(string|number) = 'radial'
+
+If it is `number` type, then is stands for rotation, from -90 degrees to 90
degrees, and positive values stand for counterclockwise.
+
+Besides, it can be string `'radial'`, standing for radial rotation; or
`'tangential'`, standing for tangential rotation.
+
+By default, it is `'radial'`. If no rotation is wanted, it can be set to `0`.
diff --git a/en/option/series/gauge.md b/en/option/series/gauge.md
index 0a0c1889..faa9fbdb 100644
--- a/en/option/series/gauge.md
+++ b/en/option/series/gauge.md
@@ -279,6 +279,10 @@ Whether to show the label.
The distance between the label and tick line.
+{{ use: partial-label-rotate-tangential(
+prefix = '##'
+) }}
+
### formatter(string|Function)
The content formatter of scale label, which supports both string template and
callback function.
diff --git a/en/option/series/sunburst.md b/en/option/series/sunburst.md
index e4d73ecf..822404d5 100644
--- a/en/option/series/sunburst.md
+++ b/en/option/series/sunburst.md
@@ -1,26 +1,14 @@
{{ target: partial-sunburst-label-helper }}
-#${prefix} rotate(string|number) = 'radial'
-
-
-
-{{ if: ${prefix} === '##' }}
-If it is `number` type, then is stands for rotation, from -90 degrees to 90
degrees, and positive values stand for counterclockwise.
-
-Besides, it can be string `'radial'`, standing for radial rotation; or
`'tangential'`, standing for tangential rotation.
-
-By default, it is `'radial'`. If no rotation is wanted, it can be set to `0`.
+{{ use: partial-label-rotate-tangential(
+prefix = ${prefix}
+) }}
The following example shows different `rotate` settings:
~[700x400](${galleryViewPath}sunburst-label-rotate=1=1)
-Same to [label.rotate](~sunburst.label.rotate)
-{{ else }}
-Same to [label.rotate](~sunburst.label.rotate)
-{{ /if }}
-
#${prefix} align(string) = 'center'
@@ -413,4 +401,3 @@ Select state.
defaultAnimationDuration = 1000,
defaultAnimationDurationUpdate = 500
) }}
-
diff --git a/zh/option/partial/label-rotate-tangential.md
b/zh/option/partial/label-rotate-tangential.md
new file mode 100644
index ..3d245c24
--- /dev/null
+++ b/zh/option/partial/label-rotate-tangential.md
@@ -0,0 +1,9 @@
+{{ target: partial-label-rotate-tangential }}
+
+#${prefix} rotate(string|number) = 'radial'
+
+如果是 `number` 类型，则表示标签的旋转角，从 -90 度到 90 度，正值是逆时针。
+
+除此之外，还可以是字符串 `'radial'` 表示径向旋转、`'tangential'` 表示切向旋转。
+
+默认径向旋转，如果不需要文字旋转，可以将其设为 `0`。
diff --git a/zh/option/series/gauge.md b/zh/option/series/gauge.md
index 6897d634..29622795 100644
--- a/zh/option/series/gauge.md
+++ b/zh/option/series/gauge.md
@@ -292,6 +292,10 @@ color: [
标签与刻度线的距离。
+{{ use: partial-label-rotate-tangential(
+prefix = '##'
+) }}
+
### formatter(string|Function)
刻度标签的内容格式器，支持字符串模板和回调函数两种形式。
diff --git a/zh/option/series/sunburst.md b/zh/option/series/sunburst.md
index 3909a8b8..ab5d461e 100644
--- a/zh/option/series/sunburst.md
+++ b/zh/option/series/sunburst.md
@@ -1,23 +1,13 @@
{{ target: partial-sunburst-label-helper }}
-#${prefix} rotate(string|number) = 'radial'
-
-
-
-{{ if: ${prefix} === '##' }}
-如果是 `number` 类型，则表示标签的旋转角，从 -90 度到 90 度，正值是逆时针。
-
-除此之外，还可以是字符串 `'radial'` 表示径向旋转、`'tangential'` 表示切向旋转。
-
-默认径向旋转，如果不需要文字旋转，可以将其设为 `0`。
+{{ use: partial-label-rotate-tangential(
+prefix = ${prefix}
+) }}
下面的例子展示了不同的 `rotate` 设置方法：
~[700x400](${galleryViewPath}sunburst-label-rotate=1=1)
-{{ else }}
-同 [label.rotate](~sunburst.label.rotate)
-{{ /if }}
#${prefix} align(string) = 'center'
@@ -560,4 +550,3 @@ series: {
defaultAnimationDuration = 1000,
defaultAnimationDurationUpdate = 500
) }}
-
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts-doc] Ovilia opened a new pull request, #294: doc(gauge): axisLabel support rotate apache/echarts#16985
Ovilia opened a new pull request, #294: URL: https://github.com/apache/echarts-doc/pull/294 Doc for apache/echarts#16985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] dependabot[bot] opened a new pull request, #17683: chore(deps): bump shelljs and jshint
dependabot[bot] opened a new pull request, #17683: URL: https://github.com/apache/echarts/pull/17683 Removes [shelljs](https://github.com/shelljs/shelljs). It's no longer used after updating ancestor dependency [jshint](https://github.com/jshint/jshint). These dependencies need to be updated together. Removes `shelljs` Updates `jshint` from 2.10.2 to 2.13.5 Release notes Sourced from https://github.com/jshint/jshint/releases;>jshint's releases. JSHint 2.13.5 https://github.com/jshint/jshint/compare/2.13.4...v2.13.5;>2.13.5 (2022-07-08) Bug Fixes Tolerate late definition of async function (https://github-redirect.dependabot.com/jshint/jshint/issues/3618;>#3618) (https://github.com/jshint/jshint/commit/5c256a2;>5c256a2) JSHint 2.13.4 https://github.com/jshint/jshint/compare/2.13.3...v2.13.4;>2.13.4 (2022-01-24) Bug Fixes Remove shelljs (https://github.com/jshint/jshint/commit/eb4609a;>eb4609a) JSHint 2.13.3 https://github.com/jshint/jshint/compare/2.13.2...v2.13.3;>2.13.3 (2022-01-05) Bug Fixes Recognize ES2020 globals (https://github.com/jshint/jshint/commit/b1426f1;>b1426f1) JSHint 2.13.2 https://github.com/jshint/jshint/compare/2.13.1...v2.13.2;>2.13.2 (2021-12-27) Bug Fixes Add missing well-known globals (https://github-redirect.dependabot.com/jshint/jshint/issues/3582;>#3582) (https://github.com/jshint/jshint/commit/cc1adf6;>cc1adf6) add URL for node in src/vars.js (https://github-redirect.dependabot.com/jshint/jshint/issues/3570;>#3570) (https://github.com/jshint/jshint/commit/ca06e6a;>ca06e6a) change escape-sequence handler for double quotes () (https://github-redirect.dependabot.com/jshint/jshint/issues/3566;>#3566) (https://github.com/jshint/jshint/commit/75e48b7;>75e48b7) Limit Too many Errors (E043) to errors only (https://github-redirect.dependabot.com/jshint/jshint/issues/3562;>#3562) (https://github.com/jshint/jshint/commit/4a681b9;>4a681b9) Tolerate keyword in object shorthand (https://github.com/jshint/jshint/commit/057b1c6;>057b1c6) Tolerate unterminated nullish coalescing (https://github.com/jshint/jshint/commit/ecae54a;>ecae54a) JSHint 2.13.1 https://github.com/jshint/jshint/compare/2.13.0...v2.13.1;>2.13.1 (2021-08-10) Bug Fixes Allow invoking result of optional chaining (https://github.com/jshint/jshint/commit/71ec395;>71ec395) Allow optional chaining call as satement (https://github.com/jshint/jshint/commit/11dc0a6;>11dc0a6) Tolerate dangling NewExpression (https://github.com/jshint/jshint/commit/7c890aa;>7c890aa) JSHint 2.13.0 https://github.com/jshint/jshint/compare/2.12.0...v2.13.0;>2.13.0 (2021-05-30) Bug Fixes Allow comma expression in MemberExpression (https://github.com/jshint/jshint/commit/f05c8d1;>f05c8d1) Consider all exported bindings used (https://github.com/jshint/jshint/commit/90228b7;>90228b7) ... (truncated) Changelog Sourced from https://github.com/jshint/jshint/blob/main/CHANGELOG.md;>jshint's changelog. https://github.com/jshint/jshint/compare/2.13.4...v2.13.5;>2.13.5 (2022-07-08) Bug Fixes Tolerate late definition of async function (https://github-redirect.dependabot.com/jshint/jshint/issues/3618;>#3618) (https://github.com/jshint/jshint/commit/5c256a2;>5c256a2) https://github.com/jshint/jshint/compare/2.13.3...v2.13.4;>2.13.4 (2022-01-24) Bug Fixes Remove shelljs (https://github.com/jshint/jshint/commit/eb4609a;>eb4609a) https://github.com/jshint/jshint/compare/2.13.2...v2.13.3;>2.13.3 (2022-01-05) Bug Fixes Recognize ES2020 globals (https://github.com/jshint/jshint/commit/b1426f1;>b1426f1) https://github.com/jshint/jshint/compare/2.13.1...v2.13.2;>2.13.2 (2021-12-27) Bug Fixes Add missing well-known globals (https://github-redirect.dependabot.com/jshint/jshint/issues/3582;>#3582) (https://github.com/jshint/jshint/commit/cc1adf6;>cc1adf6) add URL for node in src/vars.js (https://github-redirect.dependabot.com/jshint/jshint/issues/3570;>#3570) (https://github.com/jshint/jshint/commit/ca06e6a;>ca06e6a) change escape-sequence handler for double quotes () (https://github-redirect.dependabot.com/jshint/jshint/issues/3566;>#3566) (https://github.com/jshint/jshint/commit/75e48b7;>75e48b7) Limit Too many Errors (E043) to errors only (https://github-redirect.dependabot.com/jshint/jshint/issues/3562;>#3562) (https://github.com/jshint/jshint/commit/4a681b9;>4a681b9) Tolerate keyword in object shorthand (https://github.com/jshint/jshint/commit/057b1c6;>057b1c6) Tolerate unterminated nullish coalescing (https://github.com/jshint/jshint/commit/ecae54a;>ecae54a) https://github.com/jshint/jshint/compare/2.13.0...v2.13.1;>2.13.1 (2021-08-10) Bug Fixes Allow invoking result of optional chaining
[GitHub] [echarts] Ovilia commented on pull request #17652: Fix #17136
Ovilia commented on PR #17652: URL: https://github.com/apache/echarts/pull/17652#issuecomment-1254787063 Please change the PR's title to be more informative -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17683: chore(deps): bump shelljs and jshint
echarts-bot[bot] commented on PR #17683: URL: https://github.com/apache/echarts/pull/17683#issuecomment-1254787099 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request). To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: `PR: doc ready`, `PR: awaiting doc`, `PR: doc unchanged` This message is shown because the PR description doesn't contain the document related template. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch dependabot/npm_and_yarn/shelljs-and-jshint--removed created (now dc8f361f6)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/shelljs-and-jshint--removed in repository https://gitbox.apache.org/repos/asf/echarts.git at dc8f361f6 chore(deps): bump shelljs and jshint No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch master updated (c9e9a022d -> f51f1feb3)
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/echarts.git from c9e9a022d Merge pull request #17647 from apache/fix-timeline add fe0555b0b chore(deps): bump jsdom from 16.4.0 to 16.7.0 new f51f1feb3 Merge pull request #17282 from apache/dependabot/npm_and_yarn/jsdom-16.7.0 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: package-lock.json | 620 -- 1 file changed, 322 insertions(+), 298 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts-doc] branch master updated: fix(api): add missing new options `useCoarsePointer` & `pointerSize` to `echarts#init` function for en doc.
This is an automated email from the ASF dual-hosted git repository.
wangzx pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts-doc.git
The following commit(s) were added to refs/heads/master by this push:
new 58f14fe8 fix(api): add missing new options `useCoarsePointer` &
`pointerSize` to `echarts#init` function for en doc.
58f14fe8 is described below
commit 58f14fe8858f2ac037a999655d6bcb1d13d392b4
Author: plainheart
AuthorDate: Thu Sep 22 15:12:42 2022 +0800
fix(api): add missing new options `useCoarsePointer` & `pointerSize` to
`echarts#init` function for en doc.
---
en/api/echarts.md | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/en/api/echarts.md b/en/api/echarts.md
index b8cfe0ee..144f769f 100644
--- a/en/api/echarts.md
+++ b/en/api/echarts.md
@@ -8,11 +8,13 @@ Global echarts object, which can be accessed after including
`echarts.js` in scr
(dom: HTMLDivElement|HTMLCanvasElement, theme?: Object|string, opts?: {
devicePixelRatio?: number,
renderer?: string,
-useDirtyRect?: boolean, // Since `5.0.0`
-ssr?: boolean, // Since `5.3.0`
+useDirtyRect?: boolean, // Since `5.0.0`
+useCoarsePointer?: boolean, // Since `5.4.0`
+pointerSize?: number, // Since `5.4.0`
+ssr?: boolean, // Since `5.3.0`
width?: number|string,
height?: number|string,
-locale?: string // Since `5.0.0`
+locale?: string // Since `5.0.0`
}) => ECharts
```
Creates an ECharts instance, and returns an
[echartsInstance](~echartsInstance). You shall not initialize multiple ECharts
instances on a single container.
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts-doc] Ovilia merged pull request #294: doc(gauge): axisLabel support rotate apache/echarts#16985
Ovilia merged PR #294: URL: https://github.com/apache/echarts-doc/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #17680: [Bug] visualMap pieces legend running out of view
plainheart commented on issue #17680: URL: https://github.com/apache/echarts/issues/17680#issuecomment-1254663327 Duplicate of #17659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] closed issue #17680: [Bug] visualMap pieces legend running out of view
echarts-bot[bot] closed issue #17680: [Bug] visualMap pieces legend running out of view URL: https://github.com/apache/echarts/issues/17680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] srinathmerugu opened a new issue, #17686: [Feature] Show Bubble chart below the axis line
srinathmerugu opened a new issue, #17686: URL: https://github.com/apache/echarts/issues/17686 ### What problem does this feature solve? I'm trying to plot a bubble chart using echarts v5.3.3, after the bubble chart has rendered, observed bubble is exceeding the axis line as shown below  ### What does the proposed API look like? Expected behavior is to cut off the bubble when it exceeds the axis line as shown below. Is there any way/option to know bubble x coordinates before the chart has rendered and to cut off the bubble when it crosses axis line.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] dependabot[bot] opened a new pull request, #17684: chore(deps): bump validator and @microsoft/api-extractor
dependabot[bot] opened a new pull request, #17684: URL: https://github.com/apache/echarts/pull/17684 Bumps [validator](https://github.com/validatorjs/validator.js) to 13.7.0 and updates ancestor dependency [@microsoft/api-extractor](https://github.com/microsoft/rushstack/tree/HEAD/apps/api-extractor). These dependencies need to be updated together. Updates `validator` from 8.2.0 to 13.7.0 Release notes Sourced from https://github.com/validatorjs/validator.js/releases;>validator's releases. 13.7.0 13.7.0 New Features https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1706;>#1706 isISO4217, currency code validator https://github.com/jpaya17;>@jpaya17 Fixes and Enhancements https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1647;>#1647 isFQDN: add allow_wildcard option https://github.com/fasenderos;>@fasenderos https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1654;>#1654 isRFC3339: Disallow prepended and appended strings to RFC 3339 date-time https://github.com/jmacmahon;>@jmacmahon https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1658;>#1658 maintenance: increase code coverage https://github.com/tux-tn;>@tux-tn https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1669;>#1669 IBAN export list of country codes that implement IBAN https://github.com/dror-heller;>@dror-heller https://github.com/fedeci;>@fedeci https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1676;>#1676 isBoolean: add loose option https://github.com/brybrophy;>@brybrophy https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1697;>#1697 maintenance: fix npm installation error https://github.com/rubiin;>@rubiin https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1708;>#1708 isISO31661Alpha3: perf https://github.com/jpaya17;>@jpaya17 https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1711;>#1711 isDate: allow users to strictly validate dates with . as delimiter https://github.com/flymans;>@flymans https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1715;>#1715 isCreditCard: fix for Union Pay cards https://github.com/shreyassai123;>@shreyassai123 https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1718;>#1718 isEmail: replace all dots in GMail length validation https://github.com/DasDingGehtNicht;>@DasDingGehtNicht https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1721;>#1721 isURL: add allow_fragments and allow_query_components https://github.com/cowboy-bebug;>@cowboy-bebug https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1724;>#1724 isISO31661Alpha2: perf https://github.com/jpaya17;>@jpaya17 https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1730;>#1730 isMagnetURI https://github.com/tux-tn;>@tux-tn https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1738;>#1738 trim: remove regex to prevent ReDOS attack https://github.com/tux-tn;>@tux-tn https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1747;>#1747 maintenance: run scripts in parallel for build and clean https://github.com/sachinraja;>@sachinraja https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1748;>#1748 isURL: higher priority to whitelist https://github.com/deepanshu2506;>@deepanshu2506 https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1751;>#1751 isURL: allow url with colon and no port https://github.com/MatteoPierro;>@MatteoPierro https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1777;>#1777 isUUID: fix for null version argument https://github.com/theteladras;>@theteladras https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1799;>#1799 isFQDN: check more special chars https://github.com/MatteoPierro;>@MatteoPierro https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1833;>#1833 isURL: allow URL with an empty user https://github.com/MiguelSavignano;>@MiguelSavignano https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1835;>#1835 unescape: fixed bug where intermediate string contains escaped https://github.com/Marcholio;>@Marcholio https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1836;>#1836 contains: can check that string contains seed multiple times https://github.com/Marcholio;>@Marcholio https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1844;>#1844 docs: add CDN instructions https://github.com/luiscobits;>@luiscobits https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1848;>#1848 isUUID: add support for validation of v1 and v2 https://github.com/theteladras;>@theteladras https://github-redirect.dependabot.com/validatorjs/validator.js/pull/1641;>#1941 isEmail:
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17684: chore(deps): bump validator and @microsoft/api-extractor
echarts-bot[bot] commented on PR #17684: URL: https://github.com/apache/echarts/pull/17684#issuecomment-1254787448 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request). To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: `PR: doc ready`, `PR: awaiting doc`, `PR: doc unchanged` This message is shown because the PR description doesn't contain the document related template. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch dependabot/npm_and_yarn/validator-and-microsoft/api-extractor-13.7.0 created (now 10a8cd111)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/validator-and-microsoft/api-extractor-13.7.0 in repository https://gitbox.apache.org/repos/asf/echarts.git at 10a8cd111 chore(deps): bump validator and @microsoft/api-extractor No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia merged pull request #17684: chore(deps): bump validator and @microsoft/api-extractor
Ovilia merged PR #17684: URL: https://github.com/apache/echarts/pull/17684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17684: chore(deps): bump validator and @microsoft/api-extractor
echarts-bot[bot] commented on PR #17684: URL: https://github.com/apache/echarts/pull/17684#issuecomment-1254810126 Congratulations! Your PR has been merged. Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts-doc] branch gauge created (now c1748bb4)
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch gauge in repository https://gitbox.apache.org/repos/asf/echarts-doc.git at c1748bb4 doc(gauge): axisLabel support rotate apache/echarts#16985 This branch includes the following new commits: new c1748bb4 doc(gauge): axisLabel support rotate apache/echarts#16985 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] MeMeMax commented on issue #17659: [Bug] Legend do not break in VisualMap piecewise option
MeMeMax commented on issue #17659: URL: https://github.com/apache/echarts/issues/17659#issuecomment-1254692536 Here is a reproduction if anyone needs it: https://jsfiddle.net/90y1oc4x/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia merged pull request #17683: chore(deps): bump shelljs and jshint
Ovilia merged PR #17683: URL: https://github.com/apache/echarts/pull/17683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] praful-hunde commented on issue #17655: [Bug] MarkLine Lable visibility not applied
praful-hunde commented on issue #17655: URL: https://github.com/apache/echarts/issues/17655#issuecomment-1254811615 > Found a way via setting lable.formatter to an empty string. [demo link](https://codesandbox.io/s/function-plot-forked-13rr3y?file=/index.js) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch master updated (9a1a486eb -> 878e29455)
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/echarts.git from 9a1a486eb Merge pull request #17684 from apache/dependabot/npm_and_yarn/validator-and-microsoft/api-extractor-13.7.0 add dc8f361f6 chore(deps): bump shelljs and jshint new 878e29455 Merge pull request #17683 from apache/dependabot/npm_and_yarn/shelljs-and-jshint--removed The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: package-lock.json | 38 +- package.json | 2 +- 2 files changed, 10 insertions(+), 30 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17683: chore(deps): bump shelljs and jshint
echarts-bot[bot] commented on PR #17683: URL: https://github.com/apache/echarts/pull/17683#issuecomment-1254810685 Congratulations! Your PR has been merged. Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch master updated (56a989b03 -> 9a1a486eb)
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/echarts.git from 56a989b03 Merge pull request #17510 from caiwukun/fix_legend_name_duplicate_removal add 10a8cd111 chore(deps): bump validator and @microsoft/api-extractor add 9a1a486eb Merge pull request #17684 from apache/dependabot/npm_and_yarn/validator-and-microsoft/api-extractor-13.7.0 No new revisions were added by this update. Summary of changes: package-lock.json | 582 +- package.json | 2 +- 2 files changed, 355 insertions(+), 229 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] 01/01: Merge pull request #17683 from apache/dependabot/npm_and_yarn/shelljs-and-jshint--removed
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/echarts.git commit 878e294558d3d78311c26784b19d0519abe9d560 Merge: 9a1a486eb dc8f361f6 Author: Wenli Zhang AuthorDate: Thu Sep 22 18:08:42 2022 +0800 Merge pull request #17683 from apache/dependabot/npm_and_yarn/shelljs-and-jshint--removed chore(deps): bump shelljs and jshint package-lock.json | 38 +- package.json | 2 +- 2 files changed, 10 insertions(+), 30 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on a diff in pull request #17669: bugfix #15694: support connectNulls series in data zoom
Ovilia commented on code in PR #17669:
URL: https://github.com/apache/echarts/pull/17669#discussion_r977419123
##
src/component/dataZoom/SliderZoomView.ts:
##
@@ -409,7 +409,18 @@ class SliderZoomView extends DataZoomView {
const otherCoord = isEmpty
? 0 : linearMap(value as number, otherDataExtent,
otherShadowExtent, true);
-// Attempt to draw data shadow precisely when there are empty
value.
+const connectNulls = (seriesModel as any).get('connectNulls');
+
+if (connectNulls) {
+const otherC = isEmpty
Review Comment:
`otherC` should have a more meaningful name
##
src/component/dataZoom/SliderZoomView.ts:
##
@@ -421,9 +432,10 @@ class SliderZoomView extends DataZoomView {
areaPoints.push([thisCoord, otherCoord]);
linePoints.push([thisCoord, otherCoord]);
+}
thisCoord += step;
-lastIsEmpty = isEmpty;
+lastIsEmpty = connectNulls ? false : isEmpty;
Review Comment:
Even if `connectNulls`, if all previous data is `null`, this should be empty
##
src/component/dataZoom/SliderZoomView.ts:
##
@@ -409,7 +409,18 @@ class SliderZoomView extends DataZoomView {
const otherCoord = isEmpty
? 0 : linearMap(value as number, otherDataExtent,
otherShadowExtent, true);
-// Attempt to draw data shadow precisely when there are empty
value.
+const connectNulls = (seriesModel as any).get('connectNulls');
Review Comment:
Don't use `as any`
##
test/data-zoom-connect-nulls.html:
##
@@ -0,0 +1,536 @@
+
+
+
+
+
+
+
+
+
+
+
+
+#main {
+ position: relative;
+ text-align: center;
+}
+
+.title {
+ display: block;
+ cursor: pointer;
+ text-decoration: none;
+ clear: both;
+ text-align: center;
+ margin: 0;
+ background: #eef;
+ line-height: 22px;
+}
+
+.block {
+ display: inline-block;
+ *display: inline;
+ *zoom: 1;
+ vertical-align: top;
+ margin: 30px 0 30px 50px;
+}
+
+.block .ec {
+ width: 800px;
+ height: 240px;
+}
+
+.block .info {
+ display: block;
+ text-align: left;
+ background: #eee;
+ border-radius: 3px;
+ font-size: 12px;
+ line-height: 18px;
+ padding: 0 5px;
+}
+
+.block .info td {
+ font-size: 12px;
+ border: 1px solid #bbb;
+ padding: 1px 3px;
+}
+
+strong {
+ color: red;
+ font-weight: bold;
+ font-size: 18px;
+ padding: 0 3px;
+}
+
+ Data Zoom supports series with {"connectNulls": true}
+ resolve: https://github.com/apache/echarts/issues/15694;>https://github.com/apache/echarts/issues/15694
+
+
+
+var xAxisData = [
+ "2022-01-01",
+ "2022-01-02",
+ "2022-01-03",
+ "2022-01-04",
+ "2022-01-05",
+ "2022-01-06",
+ "2022-01-07",
+ "2022-01-08",
+ "2022-01-09",
+ "2022-01-10",
+ "2022-01-11",
+ "2022-01-12",
+ "2022-01-13",
+ "2022-01-14",
+ "2022-01-15",
+ "2022-01-16",
+ "2022-01-17",
+ "2022-01-18",
+ "2022-01-19",
+ "2022-01-20",
+ "2022-01-21",
+ "2022-01-22",
+ "2022-01-23",
+ "2022-01-24",
+ "2022-01-25",
+ "2022-01-26",
+ "2022-01-27",
+ "2022-01-28",
+ "2022-01-29",
+ "2022-01-30",
+ "2022-01-31",
+ "2022-02-01",
+ "2022-02-02",
+ "2022-02-03",
+ "2022-02-04",
+ "2022-02-05",
+ "2022-02-06",
+ "2022-02-07",
+ "2022-02-08",
+ "2022-02-09",
+ "2022-02-10",
+ "2022-02-11",
+ "2022-02-12",
+ "2022-02-13",
+ "2022-02-14",
+ "2022-02-15",
+ "2022-02-16",
+ "2022-02-17",
+ "2022-02-18",
+ "2022-02-19",
+ "2022-02-20",
+ "2022-02-21",
+ "2022-02-22",
+ "2022-02-23",
+ "2022-02-24",
+ "2022-02-25",
+ "2022-02-26",
+ "2022-02-27",
+ "2022-02-28",
+ "2022-03-01",
+ "2022-03-02",
+ "2022-03-03",
+ "2022-03-04",
+ "2022-03-05",
+ "2022-03-06",
+ "2022-03-07",
+ "2022-03-08",
+ "2022-03-09",
+ "2022-03-10",
+ "2022-03-11",
+ "2022-03-12",
+ "2022-03-13",
+ "2022-03-14",
+ "2022-03-15",
+ "2022-03-16",
+ "2022-03-17",
+ "2022-03-18",
+ "2022-03-19",
+ "2022-03-20",
+ "2022-03-21",
+ "2022-03-22",
+ "2022-03-23",
+ "2022-03-24",
+ "2022-03-25",
+ "2022-03-26",
+ "2022-03-27",
+ "2022-03-28",
+ "2022-03-29",
+ "2022-03-30",
+ "2022-03-31",
+ "2022-04-01",
+ "2022-04-02",
+ "2022-04-03",
+ "2022-04-04",
+ "2022-04-05",
+ "2022-04-06",
+ "2022-04-07",
+
[echarts-doc] 01/01: Merge pull request #294 from apache/gauge
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/echarts-doc.git commit 5f644c8a7b64f9822bf348c1b9a3bfe48d9505df Merge: 58f14fe8 c1748bb4 Author: Wenli Zhang AuthorDate: Thu Sep 22 15:42:03 2022 +0800 Merge pull request #294 from apache/gauge doc(gauge): axisLabel support rotate apache/echarts#16985 en/option/partial/label-rotate-tangential.md | 9 + en/option/series/gauge.md| 4 en/option/series/sunburst.md | 19 +++ zh/option/partial/label-rotate-tangential.md | 9 + zh/option/series/gauge.md| 4 zh/option/series/sunburst.md | 17 +++-- 6 files changed, 32 insertions(+), 30 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts-doc] branch master updated (58f14fe8 -> 5f644c8a)
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/echarts-doc.git from 58f14fe8 fix(api): add missing new options `useCoarsePointer` & `pointerSize` to `echarts#init` function for en doc. add c1748bb4 doc(gauge): axisLabel support rotate apache/echarts#16985 new 5f644c8a Merge pull request #294 from apache/gauge The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: en/option/partial/label-rotate-tangential.md | 9 + en/option/series/gauge.md| 4 en/option/series/sunburst.md | 19 +++ zh/option/partial/label-rotate-tangential.md | 9 + zh/option/series/gauge.md| 4 zh/option/series/sunburst.md | 17 +++-- 6 files changed, 32 insertions(+), 30 deletions(-) create mode 100644 en/option/partial/label-rotate-tangential.md create mode 100644 zh/option/partial/label-rotate-tangential.md - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] 01/01: Merge pull request #17282 from apache/dependabot/npm_and_yarn/jsdom-16.7.0
This is an automated email from the ASF dual-hosted git repository.
ovilia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts.git
commit f51f1feb351bb72ff5020ee0d0721716d71c0542
Merge: c9e9a022d fe0555b0b
Author: Wenli Zhang
AuthorDate: Thu Sep 22 17:45:58 2022 +0800
Merge pull request #17282 from apache/dependabot/npm_and_yarn/jsdom-16.7.0
chore(deps): bump jsdom from 16.4.0 to 16.7.0
package-lock.json | 620 --
1 file changed, 322 insertions(+), 298 deletions(-)
diff --cc package-lock.json
index 7db23f2be,224733d22..c287932ad
--- a/package-lock.json
+++ b/package-lock.json
@@@ -2447,9 -2398,21 +2456,21 @@@
"node_modules/after": {
"version": "0.8.2",
"resolved": "https://registry.npmjs.org/after/-/after-0.8.2.tgz;,
- "integrity": "sha1-/ts5T58OAqqXaOcCvaI7UF+ufh8=",
+ "integrity":
"sha512-QbJ0NTQ/I9DI3uSJA4cbexiwQeRAfjPScqIbSjUDd9TOrcg6pTkdgziesOqxBMBzit8vFCTwrP27t13vFOORRA==",
"dev": true
},
+ "node_modules/agent-base": {
+ "version": "6.0.2",
+ "resolved":
"https://registry.npmjs.org/agent-base/-/agent-base-6.0.2.tgz;,
+ "integrity":
"sha512-RZNwNclF7+MS/8bDg70amg32dyeZGZxiDuQmZxKLAlQjr3jGyLx+4Kkk58UO7D2QdgFIQCovuSuZESne6RG6XQ==",
+ "dev": true,
+ "dependencies": {
+ "debug": "4"
+ },
+ "engines": {
+ "node": ">= 6.0.0"
+ }
+ },
"node_modules/ajv": {
"version": "6.12.6",
"resolved": "https://registry.npmjs.org/ajv/-/ajv-6.12.6.tgz;,
@@@ -15418,9 -15340,18 +15438,18 @@@
"after": {
"version": "0.8.2",
"resolved": "https://registry.npmjs.org/after/-/after-0.8.2.tgz;,
- "integrity": "sha1-/ts5T58OAqqXaOcCvaI7UF+ufh8=",
+ "integrity":
"sha512-QbJ0NTQ/I9DI3uSJA4cbexiwQeRAfjPScqIbSjUDd9TOrcg6pTkdgziesOqxBMBzit8vFCTwrP27t13vFOORRA==",
"dev": true
},
+ "agent-base": {
+ "version": "6.0.2",
+ "resolved":
"https://registry.npmjs.org/agent-base/-/agent-base-6.0.2.tgz;,
+ "integrity":
"sha512-RZNwNclF7+MS/8bDg70amg32dyeZGZxiDuQmZxKLAlQjr3jGyLx+4Kkk58UO7D2QdgFIQCovuSuZESne6RG6XQ==",
+ "dev": true,
+ "requires": {
+ "debug": "4"
+ }
+ },
"ajv": {
"version": "6.12.6",
"resolved": "https://registry.npmjs.org/ajv/-/ajv-6.12.6.tgz;,
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia merged pull request #17282: chore(deps): bump jsdom from 16.4.0 to 16.7.0
Ovilia merged PR #17282: URL: https://github.com/apache/echarts/pull/17282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17282: chore(deps): bump jsdom from 16.4.0 to 16.7.0
echarts-bot[bot] commented on PR #17282: URL: https://github.com/apache/echarts/pull/17282#issuecomment-1254785722 Congratulations! Your PR has been merged. Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch master updated (f51f1feb3 -> 56a989b03)
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/echarts.git from f51f1feb3 Merge pull request #17282 from apache/dependabot/npm_and_yarn/jsdom-16.7.0 new 4fe4561ea fix: remove legend name duplicate to prevent double inverse bug new 46cdb2bf1 fix: revert package-lock.json new 56a989b03 Merge pull request #17510 from caiwukun/fix_legend_name_duplicate_removal The 8842 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/component/legend/LegendModel.ts | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia merged pull request #17510: fix: legend inverse doesn't work if series/data have the same name
Ovilia merged PR #17510: URL: https://github.com/apache/echarts/pull/17510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17510: fix: legend inverse doesn't work if series/data have the same name
echarts-bot[bot] commented on PR #17510: URL: https://github.com/apache/echarts/pull/17510#issuecomment-1254806438 Congratulations! Your PR has been merged. Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] wangchao18654941093 opened a new issue, #17685: [Bug] registerMap不能加载svg外联样式
wangchao18654941093 opened a new issue, #17685: URL: https://github.com/apache/echarts/issues/17685 ### Version 5.2.2 ### Link to Minimal Reproduction _No response_ ### Steps to Reproduce [在线查看](https://www.isqqw.com/viewer?id=35341) ### Current Behavior svg的样式没有加载上：  ### Expected Behavior 这个是svg应该的样式：  ### Environment ```markdown - OS: - Browser: - Framework: ``` ### Any additional comments? echarts.registerMap 加载svg时感觉没有解析 svg标签上的class所以导致外联样式（style标签）没有加载成功。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #17685: [Bug] registerMap不能加载svg外联样式
echarts-bot[bot] commented on issue #17685: URL: https://github.com/apache/echarts/issues/17685#issuecomment-1254835666 @wangchao18654941093 It seems you are not using English, I've helped translate the content automatically. To make your issue understood by more people and get helped, we'd like to suggest using English next time. 珞 TRANSLATED **TITLE** [Bug] registerMap cannot load svg outline styles **BODY** ### Version 5.2.2 ### Link to Minimal Reproduction _No response_ ### Steps to Reproduce [View online](https://www.isqqw.com/viewer?id=35341) ### Current Behavior The styles of the svg are not loaded:  ### Expected Behavior This is how the svg should look:  ### Environment markdown - OS: - Browser: - Framework: ### Any additional comments? When echarts.registerMap loads svg, it feels that the class on the svg tag is not parsed, so the external style (style tag) is not loaded successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] patel22111 opened a new issue, #17687: [Bug] label on x axis is getting trimmed.
patel22111 opened a new issue, #17687: URL: https://github.com/apache/echarts/issues/17687 ### Version 5.3.3 ### Link to Minimal Reproduction _No response_ ### Steps to Reproduce  ### Current Behavior time on x axis is getting trimmed from right side ### Expected Behavior label should not trimmed ### Environment ```markdown - OS: - Browser: - Framework: ``` ### Any additional comments? . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #17687: [Bug] label on x axis is getting trimmed.
echarts-bot[bot] commented on issue #17687: URL: https://github.com/apache/echarts/issues/17687#issuecomment-1255194865 @patel22111 Please provide a demo for the issue either with [Official Editor](https://echarts.apache.org/examples/editor.html), [CodePen](https://codepen.io/Ovilia/pen/dyYWXWM), [CodeSandbox](https://codesandbox.io/s/echarts-basic-example-template-mpfz1s) or [JSFiddle](https://jsfiddle.net/plainheart/e46ozpqj/7/). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts-doc] tyn1998 opened a new pull request, #295: WIP: docs: update documents for multiple level drilldown - `childGroupId`
tyn1998 opened a new pull request, #295: URL: https://github.com/apache/echarts-doc/pull/295 - [x] Chinese - [ ] English (I'm working on it...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] jornetsimon commented on issue #17135: [Bug] stack for null value with connectNulls: true, the color from the upper values overflows to the bottom.
jornetsimon commented on issue #17135: URL: https://github.com/apache/echarts/issues/17135#issuecomment-1255137833 Same thing on 5.2.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] JinJianQi commented on pull request #17288: feat: add the insideDataZoom 'gestureOnTouchPad' option that can Optimize the Experience on the MAC touchpad.
JinJianQi commented on PR #17288: URL: https://github.com/apache/echarts/pull/17288#issuecomment-1255205237 @100pah Thanks for your reply :) From my side, I think both A and B are good, C just changes the original behavior, which means we may need another way to represent the original behavior. In addition, for the style, I'll update this PR later ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #16825: Changed calculated label gap to be passed from top
Ovilia commented on PR #16825: URL: https://github.com/apache/echarts/pull/16825#issuecomment-1255760293 Please click "Resolve conversion" in the above reviews if you have corrected them in the new commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] oberhamsi opened a new issue, #17688: [Bug]
oberhamsi opened a new issue, #17688: URL: https://github.com/apache/echarts/issues/17688 ### Version 5.3.3 ### Link to Minimal Reproduction https://jsfiddle.net/vbekcu68/2/ ### Steps to Reproduce 1. create a bar chart with xaxis.type = value 2. add multiple series 3. the bars are not correctly positioned on the x-axis this can more easily be observed by enabling/disabling "B" via the legend - the bars of "A" move around although their x-values of course have not changed. ### Current Behavior bars are not at the correct position according to their x-value. ### Expected Behavior all bars should be correctly positioned. ### Environment ```markdown - OS: ubuntu, windows - Browser:firefox, chrome - Framework: none ``` ### Any additional comments? with more than two series in the diagram the behaviour is even more clearly wrong: when disabling a series, all bars of series defined after the disabled one are moved to the right, the bars of series defined before are moved to the left. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] closed issue #17688: [Bug]
echarts-bot[bot] closed issue #17688: [Bug] URL: https://github.com/apache/echarts/issues/17688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] NathanIceSea commented on issue #16924: [Bug] dataZoom data shadow line does not match with serie line
NathanIceSea commented on issue #16924: URL: https://github.com/apache/echarts/issues/16924#issuecomment-1255823223 same problem here, especially when time type xAxis has custom min and max boundary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia merged pull request #17606: chore(lint): enforce consistent spacing after comment starts
Ovilia merged PR #17606: URL: https://github.com/apache/echarts/pull/17606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17606: chore(lint): enforce consistent spacing after comment starts
echarts-bot[bot] commented on PR #17606: URL: https://github.com/apache/echarts/pull/17606#issuecomment-1255721463 Congratulations! Your PR has been merged. Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia closed issue #17681: [Feature] Apache ECharts Node.js Export Server ( Server Side Rendering , HTTP Server)
Ovilia closed issue #17681: [Feature] Apache ECharts Node.js Export Server ( Server Side Rendering , HTTP Server) URL: https://github.com/apache/echarts/issues/17681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #17681: [Feature] Apache ECharts Node.js Export Server ( Server Side Rendering , HTTP Server)
Ovilia commented on issue #17681: URL: https://github.com/apache/echarts/issues/17681#issuecomment-1255726239 Thanks for your contribution! If this issue is try to let more people know about the repo, please close this one and add a line to [ecomfe/awesome-echarts](https://github.com/ecomfe/awesome-echarts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] WangWuzhen626 commented on issue #17299: [Bug] 使用extendShape自定义组件时获取不到坐标
WangWuzhen626 commented on issue #17299: URL: https://github.com/apache/echarts/issues/17299#issuecomment-1255742910 I also has the same question! when I set the data as interface `Hex[]`,it does work useing `api.value(0)`. As I console it ,it shows `NaN`. By the way,hex is a class I defined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on a diff in pull request #16825: Changed calculated label gap to be passed from top
Ovilia commented on code in PR #16825:
URL: https://github.com/apache/echarts/pull/16825#discussion_r978236387
##
src/component/axis/AxisBuilder.ts:
##
@@ -365,29 +366,47 @@ const builders: Record<'axisLine' | 'axisTickLabel' |
'axisName', AxisElementsBu
},
axisName(opt, axisModel, group, transformGroup) {
+function calcDistanceToAxis() {
+const defaultMargin = 10;
+const axis = axisModel.axis;
+const isHorizontal = axis.isHorizontal();
+const labelUnionRect = estimateLabelUnionRect(axis);
+if (!labelUnionRect) {
+return 0;
+}
+const dim = isHorizontal ? 'height' : 'width';
+const margin = axisModel.getModel('axisLabel').get('margin');
+return labelUnionRect[dim] + margin + defaultMargin;
+}
const name = retrieve(opt.axisName, axisModel.get('name'));
if (!name) {
return;
}
-
+const isOutside = name === 'outsideStart' || name === 'outsideMiddle'
|| name === 'outsideEnd';
+const labelGap = isOutside ? calcDistanceToAxis() : 0;
const nameLocation = axisModel.get('nameLocation');
const nameDirection = opt.nameDirection;
const textStyleModel = axisModel.getModel('nameTextStyle');
-const gap = axisModel.get('nameGap') || 0;
-
+const gap = (axisModel.get('nameGap') || 0);
const extent = axisModel.axis.getExtent();
const gapSignal = extent[0] > extent[1] ? -1 : 1;
+
const pos = [
nameLocation === 'start'
? extent[0] - gapSignal * gap
+: nameLocation === 'outsideStart'
+? extent[0] + gapSignal * (gap) + (nameDirection * labelGap)
Review Comment:
`'start'` and `'outsideStart'` can use the same logic because `labelGap` is
0 for `'start'`.
##
src/component/axis/AxisBuilder.ts:
##
@@ -365,29 +366,47 @@ const builders: Record<'axisLine' | 'axisTickLabel' |
'axisName', AxisElementsBu
},
axisName(opt, axisModel, group, transformGroup) {
+function calcDistanceToAxis() {
+const defaultMargin = 10;
Review Comment:
We should probably use
[xAxis.nameGap](https://echarts.apache.org/en/option.html#xAxis.nameGap)
instead. The document can be updated so that when the `nameLocation` is
`outsideXXX`, it means the distance between the axis name and the axis labels.
##
src/coord/axisCommonTypes.ts:
##
@@ -35,7 +35,7 @@ export interface AxisBaseOptionCommon extends ComponentOption,
inverse?: boolean;
// Axis name displayed.
name?: string;
-nameLocation?: 'start' | 'middle' | 'end';
+nameLocation?: 'start' | 'middle' | 'end' | 'outsideStart' |
'outsideMiddle' | 'outsideEnd';
Review Comment:
Make this a new type and export it so that it can be used in `endTextLayout`.
##
src/component/axis/AxisBuilder.ts:
##
@@ -365,29 +366,47 @@ const builders: Record<'axisLine' | 'axisTickLabel' |
'axisName', AxisElementsBu
},
axisName(opt, axisModel, group, transformGroup) {
+function calcDistanceToAxis() {
+const defaultMargin = 10;
+const axis = axisModel.axis;
+const isHorizontal = axis.isHorizontal();
+const labelUnionRect = estimateLabelUnionRect(axis);
+if (!labelUnionRect) {
+return 0;
+}
+const dim = isHorizontal ? 'height' : 'width';
+const margin = axisModel.getModel('axisLabel').get('margin');
+return labelUnionRect[dim] + margin + defaultMargin;
+}
const name = retrieve(opt.axisName, axisModel.get('name'));
if (!name) {
return;
}
-
+const isOutside = name === 'outsideStart' || name === 'outsideMiddle'
|| name === 'outsideEnd';
+const labelGap = isOutside ? calcDistanceToAxis() : 0;
const nameLocation = axisModel.get('nameLocation');
const nameDirection = opt.nameDirection;
const textStyleModel = axisModel.getModel('nameTextStyle');
-const gap = axisModel.get('nameGap') || 0;
-
+const gap = (axisModel.get('nameGap') || 0);
Review Comment:
```ts
const nameGap = axisModel.get('nameGap') || 0;
const gap = isOutside ? calcDistanceToAxis(nameGap) : nameGap;
```
And `labelGap` is not necessary any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail:
[GitHub] [echarts-doc] cnazev opened a new issue, #296: 这个部分（/zh/tutorial.html）在官网上没有找到入口，只有handbook的入口
cnazev opened a new issue, #296: URL: https://github.com/apache/echarts-doc/issues/296 是怎么回事？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on a diff in pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …
Ovilia commented on code in PR #16947:
URL: https://github.com/apache/echarts/pull/16947#discussion_r978241152
##
src/component/axis/CartesianAxisView.ts:
##
@@ -135,6 +139,37 @@ const axisElementBuilders: Record 2 && (axis.scale as any).getInterval
instanceof Function) {
+const interval = (axis.scale as IntervalScale).getInterval() ||
null;
+const precision = (axis.scale as
IntervalScale).getIntervalPrecision instanceof Function
+? (axis.scale as IntervalScale).getIntervalPrecision()
+: null;
+
+const showMinLine = splitLineModel.get('showMinLine');
+if (showMinLine === false
+|| (showMinLine === 'auto'
+&& roundNumber(
Review Comment:
Using `roundNumber` to check if it is added as the *nice* extent is not
accurate.
##
src/component/axis/CartesianAxisView.ts:
##
@@ -135,6 +139,37 @@ const axisElementBuilders: Record 2 && (axis.scale as any).getInterval
instanceof Function) {
Review Comment:
Create a new variable for `axis.scale as IntervalScale`
##
src/coord/axisCommonTypes.ts:
##
@@ -244,6 +244,10 @@ interface MinorTickOption {
interface SplitLineOption {
show?: boolean,
+// null/undefined (true) | true | false | 'auto' (true when nick tick only)
+showMinLine?: boolean | 'auto',
+// null/undefined (true) | true | false | 'auto' (true when nick tick only)
Review Comment:
`null/undefined` is not necessary and they should not have a default value
defined here. Instead, the default value should be defined in `axisDefault.ts`.
##
src/component/axis/CartesianAxisView.ts:
##
@@ -135,6 +139,37 @@ const axisElementBuilders: Record 2 && (axis.scale as any).getInterval
instanceof Function) {
Review Comment:
`instanceof Function` can be omitted. If `getInterval` is not null, we can
expect it to be a function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on a diff in pull request #17217: fix: fix the error caused by setting markArea x/y
Ovilia commented on code in PR #17217:
URL: https://github.com/apache/echarts/pull/17217#discussion_r978246509
##
src/component/marker/markerHelper.ts:
##
@@ -147,6 +147,9 @@ export function dataTransform(
item.coord = coord;
}
}
+if (item.coord == null) {
+item.coord = [];
Review Comment:
I'm not sure but returning an array with 0 element doesn't seem to be
*valid* by logic for the `coord`. What do you think if it returns `[null,
null]`? Can you help test if it works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Ovilia commented on PR #17098: URL: https://github.com/apache/echarts/pull/17098#issuecomment-1255793182 > Hi, Is there any plan to merge the problem to the latest version in the near future? @Ovilia 樂️ This PR is scheduled in 5.4.1, which should be published in November. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia merged pull request #17098: fix: markArea of bar series now covers whole categories specified
Ovilia merged PR #17098: URL: https://github.com/apache/echarts/pull/17098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia closed issue #12341: markArea xAxis does not work as expected for category axis and bar series
Ovilia closed issue #12341: markArea xAxis does not work as expected for category axis and bar series URL: https://github.com/apache/echarts/issues/12341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia closed issue #17021: [Feature] Get calculated max/min value of yaxis
Ovilia closed issue #17021: [Feature] Get calculated max/min value of yaxis URL: https://github.com/apache/echarts/issues/17021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
echarts-bot[bot] commented on PR #17098: URL: https://github.com/apache/echarts/pull/17098#issuecomment-1255817920 Congratulations! Your PR has been merged. Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch master updated (9c007664e -> 583711e95)
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/echarts.git from 9c007664e Merge pull request #17606 from apache/fix-lint new a051e30b6 fix: markArea of bar series now covers whole category new 27c69b01e fix lint error new 8b8e1662b Merge branch 'master' of https://github.com/apache/echarts into issue#17021 new 6dbd5df64 New testcase added new b47d05673 fix: markPoint now can show normally new 5186308c1 fix lint error new 70db7c6fc chore: resolve conflict new 583711e95 Merge pull request #17098 from jiawulin001/issue#17021 The 8856 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/chart/bar/BaseBarSeries.ts | 33 +-- src/component/marker/MarkAreaView.ts | 25 - src/coord/CoordinateSystem.ts| 2 + src/model/Series.ts | 6 +- test/bar-markArea.html | 184 +++ 5 files changed, 240 insertions(+), 10 deletions(-) create mode 100644 test/bar-markArea.html - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
echarts-bot[bot] commented on PR #17098: URL: https://github.com/apache/echarts/pull/17098#issuecomment-1255817828 To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: `PR: doc ready`, `PR: awaiting doc`, `PR: doc unchanged` This message is shown because the PR description doesn't contain the document related template. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] commented on issue #13298: 坐标轴在同时有两个X轴和两个Y轴时,顶部X轴会掉到底部
github-actions[bot] commented on issue #13298: URL: https://github.com/apache/echarts/issues/13298#issuecomment-1255546868 This issue has been automatically marked as stale because it did not have recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] commented on issue #13313: Tooltip does not work in parallel plot and can't select an individual line
github-actions[bot] commented on issue #13313: URL: https://github.com/apache/echarts/issues/13313#issuecomment-1255546917 This issue has been automatically marked as stale because it did not have recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #17685: [Bug] registerMap不能加载svg外联样式
Ovilia commented on issue #17685: URL: https://github.com/apache/echarts/issues/17685#issuecomment-1255725364 Try [this](https://github.com/doom-goober/svg_style_attribute). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch master updated (878e29455 -> 9c007664e)
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/echarts.git from 878e29455 Merge pull request #17683 from apache/dependabot/npm_and_yarn/shelljs-and-jshint--removed add 59c206c53 chore(lint): enforce consistent spacing after comment starts new 9c007664e Merge pull request #17606 from apache/fix-lint The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .eslintrc-common.yaml | 2 +- src/coord/axisHelper.ts | 2 +- src/core/task.ts| 2 +- src/export/api.ts | 6 +++--- src/layout/barPolar.ts | 2 +- src/util/states.ts | 3 ++- src/util/types.ts | 3 ++- 7 files changed, 11 insertions(+), 9 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] 01/01: Merge pull request #17606 from apache/fix-lint
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/echarts.git commit 9c007664e74c947267f6ba8bba3987d6a2aed362 Merge: 878e29455 59c206c53 Author: Wenli Zhang AuthorDate: Fri Sep 23 09:52:49 2022 +0800 Merge pull request #17606 from apache/fix-lint chore(lint): enforce consistent spacing after comment starts .eslintrc-common.yaml | 2 +- src/coord/axisHelper.ts | 2 +- src/core/task.ts| 2 +- src/export/api.ts | 6 +++--- src/layout/barPolar.ts | 2 +- src/util/states.ts | 3 ++- src/util/types.ts | 3 ++- 7 files changed, 11 insertions(+), 9 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
