[incubator-nuttx] branch master updated: arch: imx6: Apply the latest imxrt/imxrt_enet.c to imx6/imx_enet.c
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 977367c arch: imx6: Apply the latest imxrt/imxrt_enet.c to
imx6/imx_enet.c
977367c is described below
commit 977367ce043e900e5e7fb19e2ff82a469fa7c579
Author: Masayuki Ishikawa
AuthorDate: Thu Jan 28 15:54:44 2021 +0900
arch: imx6: Apply the latest imxrt/imxrt_enet.c to imx6/imx_enet.c
Summary:
- Since imx_enet.c is based on imxrt_enet.c and still under debugging,
the differences should be minimum to keep tracking the changes
Impact:
- None
Testing:
- Tested with sabre-6quad:netnsh with QEMU
Signed-off-by: Masayuki Ishikawa
---
arch/arm/src/imx6/imx_enet.c | 134 ++-
1 file changed, 120 insertions(+), 14 deletions(-)
diff --git a/arch/arm/src/imx6/imx_enet.c b/arch/arm/src/imx6/imx_enet.c
index e460e6e..3a7739f 100644
--- a/arch/arm/src/imx6/imx_enet.c
+++ b/arch/arm/src/imx6/imx_enet.c
@@ -24,6 +24,7 @@
#include
+#include
#include
#include
#include
@@ -108,6 +109,27 @@
#define NENET_NBUFFERS \
(CONFIG_IMX_ENET_NTXBUFFERS + CONFIG_IMX_ENET_NRXBUFFERS)
+/* Normally you would clean the cache after writing new values to the DMA
+ * memory so assure that the dirty cache lines are flushed to memory
+ * before the DMA occurs. And you would invalid the cache after a data is
+ * received via DMA so that you fetch the actual content of the data from
+ * the cache.
+ *
+ * These conditions are not fully supported here. If the write-throuch
+ * D-Cache is enabled, however, then many of these issues go away: The
+ * cache clean operation does nothing (because there are not dirty cache
+ * lines) and the cache invalid operation is innocuous (because there are
+ * never dirty cache lines to be lost; valid data will always be reloaded).
+ *
+ * At present, we simply insist that write through cache be enabled.
+ */
+
+#if 0
+#if defined(CONFIG_ARMV7M_DCACHE) &&
!defined(CONFIG_ARMV7M_DCACHE_WRITETHROUGH)
+# error Write back D-Cache not yet supported
+#endif
+#endif
+
/* TX poll delay = 1 seconds. CLK_TCK is the number of clock ticks per
* second.
*/
@@ -155,6 +177,11 @@
* 7. BOARD_PHY_ISDUPLEX: A macro that can convert the status register
*value into a boolean: true=duplex mode, false=half-duplex mode
*
+ * The imxrt1050-evk board uses a KSZ8081 PHY
+ * The Versiboard2 uses a LAN8720 PHY
+ * The Teensy-4.1 board uses a DP83825I PHY
+ *
+ * ...and further PHY descriptions here.
*/
/* TODO:
@@ -180,6 +207,15 @@
# define BOARD_PHY_10BASET(s) (((s)_LAN8720_SPSCR_10MBPS) != 0)
# define BOARD_PHY_100BASET(s) (((s)_LAN8720_SPSCR_100MBPS) != 0)
# define BOARD_PHY_ISDUPLEX(s) (((s)_LAN8720_SPSCR_DUPLEX) != 0)
+#elif defined(CONFIG_ETH0_PHY_DP83825I)
+# define BOARD_PHY_NAME"DP83825I"
+# define BOARD_PHYID1 MII_PHYID1_DP83825I
+# define BOARD_PHYID2 MII_PHYID2_DP83825I
+# define BOARD_PHY_STATUS MII_DP83825I_PHYSTS
+# define BOARD_PHY_ADDR(0)
+# define BOARD_PHY_10BASET(s) (((s) & MII_DP83825I_PHYSTS_SPEED) != 0)
+# define BOARD_PHY_100BASET(s) (((s) & MII_DP83825I_PHYSTS_SPEED) == 0)
+# define BOARD_PHY_ISDUPLEX(s) (((s) & MII_DP83825I_PHYSTS_DUPLEX) != 0)
#else
# error "Unrecognized or missing PHY selection"
#endif
@@ -362,6 +398,52 @@ static void imx_reset(struct imx_driver_s *priv);
/
/
+ * Function: imx_swap16/32
+ *
+ * Description:
+ * The descriptors are represented by structures Unfortunately, when the
+ * structures are overlaid on the data, the bytes are reversed because
+ * the underlying hardware writes the data in big-endian byte order.
+ *
+ * Input Parameters:
+ * value - The value to be byte swapped
+ *
+ * Returned Value:
+ * The byte swapped value
+ *
+ /
+
+#if 0 /* Use builtins if the compiler supports them */
+#ifndef CONFIG_ENDIAN_BIG
+static inline uint32_t imx_swap32(uint32_t value)
+{
+ uint32_t result = 0;
+
+ __asm__ __volatile__
+ (
+"rev %0, %1"
+:"=r" (result)
+: "r"(value)
+ );
+ return result;
+}
+
+static inline uint16_t imx_swap16(uint16_t value)
+{
+ uint16_t result = 0;
+
+ __asm__ __volatile__
+ (
+"revsh %0, %1"
+:"=r" (result)
+: "r"(value)
+ );
+ return result;
+}
+#endif
+#endif
+
+/
* Function: imx_txringfull
*
* Description:
@@ -615,7 +697,7 @@ static inline void imx_dispatch(FAR struct imx_driver_s
*priv)
NETDEV_RXPACKETS(>dev);
#ifdef CONFIG_NET_PKT
- /* When
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2763: arch: imx6: Apply the latest imxrt/imxrt_enet.c to imx6/imx_enet.c
xiaoxiang781216 merged pull request #2763: URL: https://github.com/apache/incubator-nuttx/pull/2763 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2763: arch: imx6: Apply the latest imxrt/imxrt_enet.c to imx6/imx_enet.c
masayuki2009 commented on pull request #2763: URL: https://github.com/apache/incubator-nuttx/pull/2763#issuecomment-768843806 > Hmm, the CI did not start... I've just pushed with the latest timestamp, the CI started but finished immediately... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2763: arch: imx6: Apply the latest imxrt/imxrt_enet.c to imx6/imx_enet.c
masayuki2009 commented on pull request #2763: URL: https://github.com/apache/incubator-nuttx/pull/2763#issuecomment-768841586 Hmm, the CI did not start... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2763: arch: imx6: Apply the latest imxrt/imxrt_enet.c to imx6/imx_enet.c
masayuki2009 opened a new pull request #2763: URL: https://github.com/apache/incubator-nuttx/pull/2763 ## Summary - Since imx_enet.c is based on imxrt_enet.c and still under debugging, the differences should be minimum to keep tracking the changes ## Impact - None ## Testing - Tested with sabre-6quad:netnsh with QEMU This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2735: nRF52: add support for building SoftDevice BLE controller
btashton commented on a change in pull request #2735: URL: https://github.com/apache/incubator-nuttx/pull/2735#discussion_r565853935 ## File path: arch/arm/src/nrf52/Make.defs ## @@ -163,3 +163,89 @@ endif ifeq ($(CONFIG_PM),y) CHIP_CSRCS += nrf52_pminitialize.c endif + +ifeq ($(CONFIG_NRF52_SOFTDEVICE_CONTROLLER),y) + +NRFXLIB_UNPACK := sdk-nrfxlib +NRFXLIB_VER := 1.4.2 +NRFXLIB_REF := v$(NRFXLIB_VER) +NRFXLIB_TGZ := $(NRFXLIB_REF).tar.gz +NRFXLIB_URL := https://github.com/nrfconnect/sdk-nrfxlib/archive + +NRFX_UNPACK := nrfx +NRFX_VER:= 2.4.0 +NRFX_REF:= v$(NRFX_VER) +NRFX_TGZ:= $(NRFX_REF).tar.gz +NRFX_URL:= https://github.com/NordicSemiconductor/nrfx/archive + +CMSIS_UNPACK:= CMSIS_5 +CMSIS_VER := 5.7.0 +CMSIS_REF := $(CMSIS_VER) +CMSIS_TGZ := $(CMSIS_REF).tar.gz +CMSIS_URL := https://github.com/ARM-software/CMSIS_5/archive + +$(NRFXLIB_TGZ): + $(Q) echo "Downloading: NRFXLIB" + $(Q) curl -L $(NRFXLIB_URL)/$(NRFXLIB_TGZ) -o chip/$(NRFXLIB_TGZ) + +$(NRFX_TGZ): + $(Q) echo "Downloading: NRFX" + $(Q) curl -L $(NRFX_URL)/$(NRFX_TGZ) -o chip/$(NRFX_TGZ) + +$(CMSIS_TGZ): + $(Q) echo "Downloading: CMSIS" + $(Q) curl -L $(CMSIS_URL)/$(CMSIS_TGZ) -o chip/$(CMSIS_TGZ) + +chip/$(NRFXLIB_UNPACK): $(NRFXLIB_TGZ) + $(Q) echo "Unpacking: NRXFLIB" + $(Q) cd chip && tar zxf $(NRFXLIB_TGZ) + $(Q) mv chip/$(NRFXLIB_UNPACK)-$(NRFXLIB_VER)* chip/$(NRFXLIB_UNPACK) + $(Q) touch chip/$(NRFXLIB_UNPACK) + +chip/$(NRFX_UNPACK): $(NRFX_TGZ) + $(Q) echo "Unpacking: NRXF" + $(Q) cd chip && tar zxf $(NRFX_TGZ) + $(Q) mv chip/$(NRFX_UNPACK)-$(NRFX_VER)* chip/$(NRFX_UNPACK) + $(Q) touch chip/$(NRFX_UNPACK) + +chip/$(CMSIS_UNPACK): $(CMSIS_TGZ) Review comment: I messed with it and I think you are right, otherwise this will get hard to maintain. See my comment on the nrf one I think we can just turn that into a single typedef This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2735: nRF52: add support for building SoftDevice BLE controller
btashton commented on a change in pull request #2735:
URL: https://github.com/apache/incubator-nuttx/pull/2735#discussion_r565844647
##
File path: arch/arm/src/nrf52/nrf52_sdc.c
##
@@ -0,0 +1,609 @@
+/
+ * arch/arm/src/chip/nrf52_sdc.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "arm_internal.h"
+#include "ram_vectors.h"
+#include "arm_arch.h"
+
+#include
+#include
+#include
+
+/
+ * Pre-processor Definitions
+ /
+
+#if defined(CONFIG_SDC_SLAVE_COUNT) && \
+CONFIG_SDC_SLAVE_COUNT > CONFIG_BLUETOOTH_MAX_CONN
+# error "Cannot support more BLE slave roles than connections"
+#endif
+
+#define SDC_MASTER_COUNT (CONFIG_BLUETOOTH_MAX_CONN - \
+ CONFIG_NRF52_SDC_SLAVE_COUNT)
+
+/* Todo: check central/peripheral against master/slave count */
+
+#define MASTER_MEM_SIZE (SDC_MEM_PER_MASTER_LINK( \
+ SDC_DEFAULT_TX_PACKET_SIZE, \
+ SDC_DEFAULT_RX_PACKET_SIZE, \
+ SDC_DEFAULT_TX_PACKET_COUNT, \
+ SDC_DEFAULT_RX_PACKET_COUNT) \
+ + SDC_MEM_MASTER_LINKS_SHARED)
+
+#define SLAVE_MEM_SIZE (SDC_MEM_PER_SLAVE_LINK( \
+SDC_DEFAULT_TX_PACKET_SIZE, \
+SDC_DEFAULT_RX_PACKET_SIZE, \
+SDC_DEFAULT_TX_PACKET_COUNT, \
+SDC_DEFAULT_RX_PACKET_COUNT) \
++ SDC_MEM_SLAVE_LINKS_SHARED)
+
+#define MEMPOOL_SIZE ((CONFIG_NRF52_SDC_SLAVE_COUNT * SLAVE_MEM_SIZE) + \
+ (SDC_MASTER_COUNT * MASTER_MEM_SIZE))
+
+/
+ * Private Types
+ /
+
+struct nrf52_sdc_dev_s
+{
+ uint8_t mempool[MEMPOOL_SIZE];
+ uint8_t msg_buffer[HCI_MSG_BUFFER_MAX_SIZE];
+
+ sem_t exclsem;
+ struct work_s work;
+};
+
+/
+ * Private Function Prototypes
+ /
+
+static void mpsl_assert_handler(const char *const file, const uint32_t line);
+static void sdc_fault_handler(const char *file, const uint32_t line);
+
+static int bt_open(FAR const struct bt_driver_s *btdev);
+static int bt_hci_send(FAR const struct bt_driver_s *btdev,
+ FAR struct bt_buf_s *buf);
+
+static void on_hci(void);
+static void on_hci_worker(void *arg);
+
+static void low_prio_worker(void *arg);
+
+static int swi_isr(int irq, FAR void *context, FAR void *arg);
+static int power_clock_isr(int irq, FAR void *context, FAR void *arg);
+
+static void rng_handler(void);
+static void rtc0_handler(void);
+static void timer0_handler(void);
+static void radio_handler(void);
+
+/
+ * Private Data
+ /
+
+static const struct bt_driver_s g_bt_driver =
+{
+ .head_reserve = 0,
+ .open = bt_open,
+ .send = bt_hci_send
+};
+
+static const mpsl_clock_lfclk_cfg_t g_clock_config =
+{
+ .source = MPSL_CLOCK_LF_SRC_XTAL,
+ .rc_ctiv = 0,
+ .rc_temp_ctiv = 0,
+ .accuracy_ppm = CONFIG_NRF52_SDC_CLOCK_ACCURACY,
+ .skip_wait_lfclk_started = false
+};
+
+static struct nrf52_sdc_dev_s g_sdc_dev;
+
+/
+ * Private Functions
+
[GitHub] [incubator-nuttx-apps] yamt commented on pull request #576: netcat fixes and improvements
yamt commented on pull request #576: URL: https://github.com/apache/incubator-nuttx-apps/pull/576#issuecomment-768833532 the ci failure looks unrelated. let me restart. ``` fatal: repository 'https://github.com/spiriou/microADB.git/' not found ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2735: nRF52: add support for building SoftDevice BLE controller
btashton commented on a change in pull request #2735:
URL: https://github.com/apache/incubator-nuttx/pull/2735#discussion_r565842825
##
File path: arch/arm/src/nrf52/nrf52_sdc.c
##
@@ -0,0 +1,609 @@
+/
+ * arch/arm/src/chip/nrf52_sdc.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "arm_internal.h"
+#include "ram_vectors.h"
+#include "arm_arch.h"
+
+#include
+#include
+#include
+
+/
+ * Pre-processor Definitions
+ /
+
+#if defined(CONFIG_SDC_SLAVE_COUNT) && \
+CONFIG_SDC_SLAVE_COUNT > CONFIG_BLUETOOTH_MAX_CONN
+# error "Cannot support more BLE slave roles than connections"
+#endif
+
+#define SDC_MASTER_COUNT (CONFIG_BLUETOOTH_MAX_CONN - \
+ CONFIG_NRF52_SDC_SLAVE_COUNT)
+
+/* Todo: check central/peripheral against master/slave count */
+
+#define MASTER_MEM_SIZE (SDC_MEM_PER_MASTER_LINK( \
+ SDC_DEFAULT_TX_PACKET_SIZE, \
+ SDC_DEFAULT_RX_PACKET_SIZE, \
+ SDC_DEFAULT_TX_PACKET_COUNT, \
+ SDC_DEFAULT_RX_PACKET_COUNT) \
+ + SDC_MEM_MASTER_LINKS_SHARED)
+
+#define SLAVE_MEM_SIZE (SDC_MEM_PER_SLAVE_LINK( \
+SDC_DEFAULT_TX_PACKET_SIZE, \
+SDC_DEFAULT_RX_PACKET_SIZE, \
+SDC_DEFAULT_TX_PACKET_COUNT, \
+SDC_DEFAULT_RX_PACKET_COUNT) \
++ SDC_MEM_SLAVE_LINKS_SHARED)
+
+#define MEMPOOL_SIZE ((CONFIG_NRF52_SDC_SLAVE_COUNT * SLAVE_MEM_SIZE) + \
+ (SDC_MASTER_COUNT * MASTER_MEM_SIZE))
+
+/
+ * Private Types
+ /
+
+struct nrf52_sdc_dev_s
+{
+ uint8_t mempool[MEMPOOL_SIZE];
+ uint8_t msg_buffer[HCI_MSG_BUFFER_MAX_SIZE];
+
+ sem_t exclsem;
+ struct work_s work;
+};
+
+/
+ * Private Function Prototypes
+ /
+
+static void mpsl_assert_handler(const char *const file, const uint32_t line);
+static void sdc_fault_handler(const char *file, const uint32_t line);
+
+static int bt_open(FAR const struct bt_driver_s *btdev);
+static int bt_hci_send(FAR const struct bt_driver_s *btdev,
+ FAR struct bt_buf_s *buf);
+
+static void on_hci(void);
+static void on_hci_worker(void *arg);
+
+static void low_prio_worker(void *arg);
+
+static int swi_isr(int irq, FAR void *context, FAR void *arg);
+static int power_clock_isr(int irq, FAR void *context, FAR void *arg);
+
+static void rng_handler(void);
+static void rtc0_handler(void);
+static void timer0_handler(void);
+static void radio_handler(void);
+
+/
+ * Private Data
+ /
+
+static const struct bt_driver_s g_bt_driver =
+{
+ .head_reserve = 0,
+ .open = bt_open,
+ .send = bt_hci_send
+};
+
+static const mpsl_clock_lfclk_cfg_t g_clock_config =
+{
+ .source = MPSL_CLOCK_LF_SRC_XTAL,
+ .rc_ctiv = 0,
+ .rc_temp_ctiv = 0,
+ .accuracy_ppm = CONFIG_NRF52_SDC_CLOCK_ACCURACY,
+ .skip_wait_lfclk_started = false
+};
+
+static struct nrf52_sdc_dev_s g_sdc_dev;
+
+/
+ * Private Functions
+
[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #576: netcat fixes and improvements
yamt opened a new pull request #576: URL: https://github.com/apache/incubator-nuttx-apps/pull/576 ## Summary * Make "netcat -l" stop after processing a connection * Stop echoing back the input. It isn't the responsibility of this app, IMO. * Allow non-text data * Error checks and cleanups ## Impact ## Testing tested on esp32-devkitc. the peer was netbsd nc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #572: Add support in printf command to send 8-32 bits value
xiaoxiang781216 commented on a change in pull request #572:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/572#discussion_r565789424
##
File path: nshlib/nsh_printf.c
##
@@ -84,7 +87,34 @@ int cmd_printf(FAR struct nsh_vtbl_s *vtbl, int argc, char
**argv)
{
case 'x':
fmt++;
-nsh_output(vtbl, "%c", strtol(fmt, NULL, 16));
+value = strtol(fmt, NULL, 16);
+len = strnlen(fmt, 10);
+
+/* Is it a Big Endian MCU ? */
+
+if (BYTE_ORDER == BIG_ENDIAN)
+ {
+value = __swap_uint32(value);
Review comment:
Don't manually swap the value.
(0x12345678 & 0xff00) >> 8 always get 0x56.
##
File path: nshlib/nsh_printf.c
##
@@ -84,7 +87,34 @@ int cmd_printf(FAR struct nsh_vtbl_s *vtbl, int argc, char
**argv)
{
case 'x':
fmt++;
-nsh_output(vtbl, "%c", strtol(fmt, NULL, 16));
+value = strtol(fmt, NULL, 16);
+len = strnlen(fmt, 10);
+
+/* Is it a Big Endian MCU ? */
+
+if (BYTE_ORDER == BIG_ENDIAN)
+ {
+value = __swap_uint32(value);
+ }
+
+if (len == 8)
Review comment:
change to len >= 7(len >= 3, len >= 1)
##
File path: nshlib/nsh_printf.c
##
@@ -84,7 +87,34 @@ int cmd_printf(FAR struct nsh_vtbl_s *vtbl, int argc, char
**argv)
{
case 'x':
fmt++;
-nsh_output(vtbl, "%c", strtol(fmt, NULL, 16));
+value = strtol(fmt, NULL, 16);
Review comment:
change strtol to strtoul
##
File path: nshlib/nsh_printf.c
##
@@ -84,7 +87,34 @@ int cmd_printf(FAR struct nsh_vtbl_s *vtbl, int argc, char
**argv)
{
case 'x':
fmt++;
-nsh_output(vtbl, "%c", strtol(fmt, NULL, 16));
+value = strtol(fmt, NULL, 16);
+len = strnlen(fmt, 10);
+
+/* Is it a Big Endian MCU ? */
+
+if (BYTE_ORDER == BIG_ENDIAN)
+ {
+value = __swap_uint32(value);
+ }
+
+if (len == 8)
+ {
+nsh_output(vtbl, "%c%c%c%c", value & 0xff,
+ (value & 0xff00) >> 8,
+ (value & 0xff) >> 16,
+ (value & 0xff00) >> 24);
+ }
+else
+ if (len == 4)
+{
+ nsh_output(vtbl, "%c%c", value & 0xff,
+ (value & 0xff00) >> 8);
+}
+ else
+if (len == 2)
Review comment:
same question
##
File path: nshlib/nsh_printf.c
##
@@ -84,7 +87,34 @@ int cmd_printf(FAR struct nsh_vtbl_s *vtbl, int argc, char
**argv)
{
case 'x':
fmt++;
-nsh_output(vtbl, "%c", strtol(fmt, NULL, 16));
+value = strtol(fmt, NULL, 16);
+len = strnlen(fmt, 10);
+
+/* Is it a Big Endian MCU ? */
+
+if (BYTE_ORDER == BIG_ENDIAN)
+ {
+value = __swap_uint32(value);
+ }
+
+if (len == 8)
+ {
+nsh_output(vtbl, "%c%c%c%c", value & 0xff,
+ (value & 0xff00) >> 8,
+ (value & 0xff) >> 16,
+ (value & 0xff00) >> 24);
+ }
+else
+ if (len == 4)
Review comment:
Why split "else if" into two lines?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2761: arch/risc-v: Remove unused and undefined file section "Public Variables"
xiaoxiang781216 merged pull request #2761: URL: https://github.com/apache/incubator-nuttx/pull/2761 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: arch/risc-v: Remove unused and undefined file section "Public Variables"
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 0f2b774 arch/risc-v: Remove unused and undefined file section "Public Variables" 0f2b774 is described below commit 0f2b774dec289f07bd0d29ce8078a08b745c49c3 Author: Abdelatif Guettouche AuthorDate: Wed Jan 27 22:58:20 2021 +0100 arch/risc-v: Remove unused and undefined file section "Public Variables" Signed-off-by: Abdelatif Guettouche --- arch/risc-v/include/arch.h| 4 arch/risc-v/include/csr.h | 4 arch/risc-v/include/gap8/chip.h | 4 arch/risc-v/include/nr5m100/chip.h| 4 arch/risc-v/include/nr5m100/nr5m1xx_irq.h | 4 arch/risc-v/include/rv32im/arch.h | 4 arch/risc-v/include/rv32im/irq.h | 4 arch/risc-v/include/rv64gc/arch.h | 4 arch/risc-v/include/rv64gc/irq.h | 4 arch/risc-v/src/common/riscv_internal.h | 4 10 files changed, 40 deletions(-) diff --git a/arch/risc-v/include/arch.h b/arch/risc-v/include/arch.h index 555d5b9..03969c5 100644 --- a/arch/risc-v/include/arch.h +++ b/arch/risc-v/include/arch.h @@ -91,10 +91,6 @@ uint32_t up_gethartid(void); / / - * Public Variables - / - -/ * Public Function Prototypes / diff --git a/arch/risc-v/include/csr.h b/arch/risc-v/include/csr.h index d4701ac..8b63f95 100644 --- a/arch/risc-v/include/csr.h +++ b/arch/risc-v/include/csr.h @@ -355,10 +355,6 @@ / / - * Public Variables - / - -/ * Public Function Prototypes / diff --git a/arch/risc-v/include/gap8/chip.h b/arch/risc-v/include/gap8/chip.h index 65ed998..eff9f00 100644 --- a/arch/risc-v/include/gap8/chip.h +++ b/arch/risc-v/include/gap8/chip.h @@ -51,10 +51,6 @@ / / - * Public Variables - / - -/ * Public Function Prototypes / diff --git a/arch/risc-v/include/nr5m100/chip.h b/arch/risc-v/include/nr5m100/chip.h index 43bde07..e6b8aa3 100644 --- a/arch/risc-v/include/nr5m100/chip.h +++ b/arch/risc-v/include/nr5m100/chip.h @@ -50,10 +50,6 @@ / / - * Public Variables - / - -/ * Public Function Prototypes / diff --git a/arch/risc-v/include/nr5m100/nr5m1xx_irq.h b/arch/risc-v/include/nr5m100/nr5m1xx_irq.h index 3abd5a5..1ebc665 100644 --- a/arch/risc-v/include/nr5m100/nr5m1xx_irq.h +++ b/arch/risc-v/include/nr5m100/nr5m1xx_irq.h @@ -60,10 +60,6 @@ / / - * Public Variables - / - -/ * Public Function Prototypes / diff --git a/arch/risc-v/include/rv32im/arch.h b/arch/risc-v/include/rv32im/arch.h index ff9418f..6466ea9 100644 --- a/arch/risc-v/include/rv32im/arch.h +++ b/arch/risc-v/include/rv32im/arch.h @@ -59,10 +59,6 @@ static inline uint32_t riscv_getsp(void) } / - * Public Variables - / -
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2760: drivers: mtd: nxstyle error fixes
xiaoxiang781216 merged pull request #2760: URL: https://github.com/apache/incubator-nuttx/pull/2760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (6f5793e -> 6d786be)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 6f5793e sched: mqueue: Remove an unnecessary comment in mq_send.c add 822fbe5 drivers: mtd: mtd_nandscheme: mix case identifier fix add 95adb15 drivers: mtd: nxstyle errors fix add 2d8b193 drivers: mtd: fix nxstyle errors add 6d786be drivers: mtd: mx35.c: mix case identifier fix No new revisions were added by this update. Summary of changes: drivers/mtd/at24xx.c| 196 +- drivers/mtd/at25.c | 188 ++ drivers/mtd/at45db.c| 329 + drivers/mtd/gd5f.c | 299 +--- drivers/mtd/hamming.c | 8 +- drivers/mtd/is25xp.c| 323 ++--- drivers/mtd/m25px.c | 273 -- drivers/mtd/mtd_modeltab.c | 215 ++- drivers/mtd/mtd_nandecc.c | 12 +- drivers/mtd/mtd_nandmodel.c | 3 +- drivers/mtd/mtd_nandscheme.c| 122 ++- drivers/mtd/mtd_rwbuffer.c | 182 ++ drivers/mtd/mx25lx.c| 464 +--- drivers/mtd/mx25rxx.c | 164 + drivers/mtd/mx35.c | 350 ++ drivers/mtd/n25qxxx.c | 667 ++ drivers/mtd/rammtd.c| 49 ++- drivers/mtd/ramtron.c | 366 +++ drivers/mtd/s25fl1.c| 772 ++-- drivers/mtd/sector512.c | 202 ++- drivers/mtd/skeleton.c | 14 +- drivers/mtd/sst25.c | 459 ++-- drivers/mtd/sst26.c | 351 +- drivers/mtd/w25.c | 400 - drivers/mtd/w25qxxxjv.c | 602 +-- include/nuttx/mtd/nand_scheme.h | 4 +- 26 files changed, 3896 insertions(+), 3118 deletions(-)
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2759: esp32/psram: Fix missing configs
xiaoxiang781216 commented on a change in pull request #2759: URL: https://github.com/apache/incubator-nuttx/pull/2759#discussion_r565778356 ## File path: arch/xtensa/src/esp32/esp32_psram.c ## @@ -153,7 +153,11 @@ #define PICO_PSRAM_CLK_IO 6 #ifndef CONFIG_PICO_PSRAM_CS_IO/* Default is 10 */ -# define PICO_PSRAM_CS_IO 10 +# define CONFIG_PICO_PSRAM_CS_IO 10 Review comment: should we keep the alignment? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: sched: mqueue: Remove an unnecessary comment in mq_send.c
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 6f5793e sched: mqueue: Remove an unnecessary comment in mq_send.c
6f5793e is described below
commit 6f5793eefc5866feb3b7813821365668eb2a258b
Author: Masayuki Ishikawa
AuthorDate: Thu Jan 28 08:52:22 2021 +0900
sched: mqueue: Remove an unnecessary comment in mq_send.c
Signed-off-by: Masayuki Ishikawa
---
sched/mqueue/mq_send.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sched/mqueue/mq_send.c b/sched/mqueue/mq_send.c
index d65c09a..a4e7307 100644
--- a/sched/mqueue/mq_send.c
+++ b/sched/mqueue/mq_send.c
@@ -113,7 +113,7 @@ int file_mq_send(FAR struct file *mq, FAR const char *msg,
size_t msglen,
{
/* No.. Not in an interrupt handler. Is the message queue FULL? */
- if (msgq->nmsgs >= msgq->maxmsgs) /* Message queue not-FULL? */
+ if (msgq->nmsgs >= msgq->maxmsgs)
{
/* Yes.. the message queue is full. Wait for space to become
* available in the message queue.
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2762: sched: mqueue: Remove an unnecessary comment in mq_send.c
xiaoxiang781216 merged pull request #2762: URL: https://github.com/apache/incubator-nuttx/pull/2762 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #566: WIP: crypto: Initial support for Mbed TLS
btashton commented on pull request #566: URL: https://github.com/apache/incubator-nuttx-apps/pull/566#issuecomment-768684410 > Hi, > > Just a note on adding this Mbed is dual licensed under Apache 2.0 and GPL so license wise this is OK. But you may need to inform the US government that NuttX contains encryption software. See here for the process [1] > > Thanks,. > Justin > > 1. https://infra.apache.org/crypto.html Thanks Justin, we have a note to handle that as well for a some other cypto code that came up in the last release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-website] branch asf-site updated: Publishing web: 59c4fb7620bc9aabf46df895f9e5cdb361f50177 docs: 82aae4deb69aeeda0cd1cad25cee0d5ecd5c9c3d
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 12dac6d Publishing web: 59c4fb7620bc9aabf46df895f9e5cdb361f50177 docs: 82aae4deb69aeeda0cd1cad25cee0d5ecd5c9c3d 12dac6d is described below commit 12dac6d824b860c979ff891ea1cab04e51f0081b Author: Ouss4 AuthorDate: Thu Jan 28 00:55:01 2021 + Publishing web: 59c4fb7620bc9aabf46df895f9e5cdb361f50177 docs: 82aae4deb69aeeda0cd1cad25cee0d5ecd5c9c3d --- content/docs/10.0.0/index.html | 2 +- content/docs/10.0.1/index.html | 2 +- content/docs/latest/index.html | 2 +- content/feed.xml | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html index d36dd38..8bfced4 100644 --- a/content/docs/10.0.0/index.html +++ b/content/docs/10.0.0/index.html @@ -207,7 +207,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 27 January 21 at 00:50 +Last Updated: 28 January 21 at 00:52 Table of Contents diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html index e058c33..33f090f 100644 --- a/content/docs/10.0.1/index.html +++ b/content/docs/10.0.1/index.html @@ -211,7 +211,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 27 January 21 at 00:51 +Last Updated: 28 January 21 at 00:53 Table of Contents diff --git a/content/docs/latest/index.html b/content/docs/latest/index.html index 7a65ef6..e2b4073 100644 --- a/content/docs/latest/index.html +++ b/content/docs/latest/index.html @@ -210,7 +210,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 27 January 21 at 00:51 +Last Updated: 28 January 21 at 00:53 Table of Contents diff --git a/content/feed.xml b/content/feed.xml index b9981cb..bf4218d 100644 --- a/content/feed.xml +++ b/content/feed.xml @@ -5,8 +5,8 @@ / -Wed, 27 Jan 2021 00:53:09 + -Wed, 27 Jan 2021 00:53:09 + +Thu, 28 Jan 2021 00:54:59 + +Thu, 28 Jan 2021 00:54:59 + Jekyll v3.8.5
[GitHub] [incubator-nuttx-apps] justinmclean commented on pull request #566: WIP: crypto: Initial support for Mbed TLS
justinmclean commented on pull request #566: URL: https://github.com/apache/incubator-nuttx-apps/pull/566#issuecomment-768671705 Hi, Just a note on adding this Mbed is dual licensed under Apache 2.0 and GPL so license wise this is OK. But you may need to inform the US government that NuttX contains encryption software. See here for the process [1] Thanks,. Justin 1. https://infra.apache.org/crypto.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2762: sched: mqueue: Remove an unnecessary comment in mq_send.c
masayuki2009 opened a new pull request #2762: URL: https://github.com/apache/incubator-nuttx/pull/2762 ## Summary - Remove an unnecessary comment in mq_send.c ## Impact - None ## Testing - None This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 merged pull request #2757: esp32/esp32_wifi_adapter.c: Print debug output only when DEBUG_WIRLESS* are enabled.
masayuki2009 merged pull request #2757: URL: https://github.com/apache/incubator-nuttx/pull/2757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: esp32/esp32_wifi_adapter.c: Print debug output only when DEBUG_WIRLESS* are enabled.
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 82aae4d esp32/esp32_wifi_adapter.c: Print debug output only when
DEBUG_WIRLESS* are enabled.
82aae4d is described below
commit 82aae4deb69aeeda0cd1cad25cee0d5ecd5c9c3d
Author: Abdelatif Guettouche
AuthorDate: Wed Jan 27 14:27:49 2021 +0100
esp32/esp32_wifi_adapter.c: Print debug output only when DEBUG_WIRLESS*
are enabled.
Signed-off-by: Abdelatif Guettouche
---
arch/xtensa/src/esp32/esp32_wifi_adapter.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/arch/xtensa/src/esp32/esp32_wifi_adapter.c
b/arch/xtensa/src/esp32/esp32_wifi_adapter.c
index b7abaa1..16285e6 100644
--- a/arch/xtensa/src/esp32/esp32_wifi_adapter.c
+++ b/arch/xtensa/src/esp32/esp32_wifi_adapter.c
@@ -3343,25 +3343,27 @@ static uint32_t esp_rand(void)
static void esp_log_writev(uint32_t level, const char *tag,
const char *format, va_list args)
{
- int pri;
-
switch (level)
{
+#ifdef CONFIG_DEBUG_WIRELESS_ERROR
case ESP_LOG_ERROR:
-pri = LOG_ERR;
+vsyslog(LOG_ERR, format, args);
break;
+#endif
+#ifdef CONFIG_DEBUG_WIRELESS_WARN
case ESP_LOG_WARN:
-pri = LOG_WARNING;
+vsyslog(LOG_WARNING, format, args);
break;
+#endif
+#ifdef CONFIG_DEBUG_WIRELESS_INFO
case ESP_LOG_INFO:
-pri = LOG_INFO;
+vsyslog(LOG_INFO, format, args);
break;
default:
-pri = LOG_DEBUG;
+vsyslog(LOG_DEBUG, format, args);
break;
+#endif
}
-
- vsyslog(pri, format, args);
}
/
@@ -3993,11 +3995,13 @@ int phy_printf(const char *format, ...)
int net80211_printf(const char *format, ...)
{
+#ifdef CONFIG_DEBUG_WIRELESS_INFO
va_list arg;
va_start(arg, format);
vsyslog(LOG_INFO, format, arg);
va_end(arg);
+#endif
return 0;
}
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2757: esp32/esp32_wifi_adapter.c: Print debug output only when DEBUG_WIRLESS* are enabled.
masayuki2009 commented on pull request #2757: URL: https://github.com/apache/incubator-nuttx/pull/2757#issuecomment-768630981 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2757: esp32/esp32_wifi_adapter.c: Print debug output only when DEBUG_WIRLESS* are enabled.
masayuki2009 commented on pull request #2757: URL: https://github.com/apache/incubator-nuttx/pull/2757#issuecomment-768630895 >BTW, if you want to also remove some of the output from the 2nd stage bootloader, you need to build one from IDF with >BOOTLOADER_LOG_LEVEL_NONE selected. This is only for some debug output at startup. @Ouss4 Thanks, I understand. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #2761: arch/risc-v: Remove unused and undefined file section "Public Variables"
Ouss4 opened a new pull request #2761: URL: https://github.com/apache/incubator-nuttx/pull/2761 ## Summary Remove unused and undefined file section "Public Variables" ## Impact N/A ## Testing N/A This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2735: nRF52: add support for building SoftDevice BLE controller
v01d commented on a change in pull request #2735: URL: https://github.com/apache/incubator-nuttx/pull/2735#discussion_r565621571 ## File path: arch/arm/src/nrf52/Make.defs ## @@ -163,3 +163,89 @@ endif ifeq ($(CONFIG_PM),y) CHIP_CSRCS += nrf52_pminitialize.c endif + +ifeq ($(CONFIG_NRF52_SOFTDEVICE_CONTROLLER),y) + +NRFXLIB_UNPACK := sdk-nrfxlib +NRFXLIB_VER := 1.4.2 +NRFXLIB_REF := v$(NRFXLIB_VER) +NRFXLIB_TGZ := $(NRFXLIB_REF).tar.gz +NRFXLIB_URL := https://github.com/nrfconnect/sdk-nrfxlib/archive + +NRFX_UNPACK := nrfx +NRFX_VER:= 2.4.0 +NRFX_REF:= v$(NRFX_VER) +NRFX_TGZ:= $(NRFX_REF).tar.gz +NRFX_URL:= https://github.com/NordicSemiconductor/nrfx/archive + +CMSIS_UNPACK:= CMSIS_5 +CMSIS_VER := 5.7.0 +CMSIS_REF := $(CMSIS_VER) +CMSIS_TGZ := $(CMSIS_REF).tar.gz +CMSIS_URL := https://github.com/ARM-software/CMSIS_5/archive + +$(NRFXLIB_TGZ): + $(Q) echo "Downloading: NRFXLIB" + $(Q) curl -L $(NRFXLIB_URL)/$(NRFXLIB_TGZ) -o chip/$(NRFXLIB_TGZ) + +$(NRFX_TGZ): + $(Q) echo "Downloading: NRFX" + $(Q) curl -L $(NRFX_URL)/$(NRFX_TGZ) -o chip/$(NRFX_TGZ) + +$(CMSIS_TGZ): + $(Q) echo "Downloading: CMSIS" + $(Q) curl -L $(CMSIS_URL)/$(CMSIS_TGZ) -o chip/$(CMSIS_TGZ) + +chip/$(NRFXLIB_UNPACK): $(NRFXLIB_TGZ) + $(Q) echo "Unpacking: NRXFLIB" + $(Q) cd chip && tar zxf $(NRFXLIB_TGZ) + $(Q) mv chip/$(NRFXLIB_UNPACK)-$(NRFXLIB_VER)* chip/$(NRFXLIB_UNPACK) + $(Q) touch chip/$(NRFXLIB_UNPACK) + +chip/$(NRFX_UNPACK): $(NRFX_TGZ) + $(Q) echo "Unpacking: NRXF" + $(Q) cd chip && tar zxf $(NRFX_TGZ) + $(Q) mv chip/$(NRFX_UNPACK)-$(NRFX_VER)* chip/$(NRFX_UNPACK) + $(Q) touch chip/$(NRFX_UNPACK) + +chip/$(CMSIS_UNPACK): $(CMSIS_TGZ) Review comment: Ok, I ended up creating stub files in a subdirectory (I think it is cleaner than carrying patches) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #2760: drivers: mtd: nxstyle error fixes
jerpelea opened a new pull request #2760: URL: https://github.com/apache/incubator-nuttx/pull/2760 ## Summary drivers: mtd: nxstyle error fixes ## Impact none ## Testing local run of nxstyle This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] acassis opened a new pull request #2759: esp32/psram: Fix missing configs
acassis opened a new pull request #2759: URL: https://github.com/apache/incubator-nuttx/pull/2759 ## Summary esp32/psram: Fix missing configs ## Impact Default configuration will work even without board pin definition ## Testing ESP32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2758: arch/xtensa/Kconfig: Reduce the default value of the internal memory.
xiaoxiang781216 merged pull request #2758: URL: https://github.com/apache/incubator-nuttx/pull/2758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: arch/xtensa/Kconfig: Reduce the default value of the internal memory.
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 6bc0700 arch/xtensa/Kconfig: Reduce the default value of the internal memory. 6bc0700 is described below commit 6bc070024de0269114e939f680dcdb53def80b8c Author: Abdelatif Guettouche AuthorDate: Wed Jan 27 14:34:46 2021 +0100 arch/xtensa/Kconfig: Reduce the default value of the internal memory. The static memory is now divided at almost the middle to not override the ROM data. The old 0x28000 will take all of what's left for heap region1. Signed-off-by: Abdelatif Guettouche --- arch/xtensa/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/xtensa/Kconfig b/arch/xtensa/Kconfig index 1a368a4..e562274 100644 --- a/arch/xtensa/Kconfig +++ b/arch/xtensa/Kconfig @@ -131,8 +131,7 @@ config XTENSA_USE_SEPARATE_IMEM config XTENSA_IMEM_REGION_SIZE hex "DRAM region size for internal use" depends on XTENSA_USE_SEPARATE_IMEM - range 0x2000 0x28000 - default 0x28000 + default 0x18000 config XTENSA_IMEM_PROCFS bool "Internal memory PROCFS support"
[incubator-nuttx] branch master updated (c33040f -> e5200d4)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from c33040f License/authorship handling scripts add e5200d4 nrf52: add stackcheck support No new revisions were added by this update. Summary of changes: arch/arm/Kconfig | 1 + arch/arm/src/nrf52/Make.defs | 4 arch/arm/src/nrf52/nrf52_start.c | 13 + 3 files changed, 18 insertions(+)
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2756: nrf52: add stackcheck support
xiaoxiang781216 merged pull request #2756: URL: https://github.com/apache/incubator-nuttx/pull/2756 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2735: nRF52: add support for building SoftDevice BLE controller
v01d commented on pull request #2735: URL: https://github.com/apache/incubator-nuttx/pull/2735#issuecomment-768426849 > > @btashton regarding your comments, is your concern download size or having include flags for these external HALs? While the flags would also apply for arch-level source code, this is the only file where these headers would be included. Maybe it is possible to have these include flags be set for this source file only? w.r.t. download size, I'm not sure it is possible to download only parts of a repo from GitHub. > > Let me take a look this evening when I do a review/test. Sure, thanks. Have a look at my other comment also, I identified the minimal required code from two dependencies. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2735: nRF52: add support for building SoftDevice BLE controller
btashton commented on pull request #2735: URL: https://github.com/apache/incubator-nuttx/pull/2735#issuecomment-768425954 > @btashton regarding your comments, is your concern download size or having include flags for these external HALs? While the flags would also apply for arch-level source code, this is the only file where these headers would be included. Maybe it is possible to have these include flags be set for this source file only? w.r.t. download size, I'm not sure it is possible to download only parts of a repo from GitHub. Let me take a look this evening when I do a review/test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #2751: the real wait time of sigtimedwait() more than specified time one CONFIG_USEC_PER_TICK
patacongo edited a comment on issue #2751: URL: https://github.com/apache/incubator-nuttx/issues/2751#issuecomment-768321262 What the op is seeing here is not normally timer behavior. It is a consequence of running the setup up the timer consistent in phase the system time and, hence, experience the maximum error every time. If the timer is set up a random phase with respect to the system timer, then removing the +1 would introduce serious, subtle errors. The +1 was added to fix those errors. For example, suppose the system timer has a 10MS period and you request the a 10MS delay like usleep(10*1000) near the system timer period. That would result in no delay and a complete failure of the timing if +1 were not added to delay ticks. That could result in very bad consequences. Waiting a little too long, on the other hander, is never an error. That will happen normally in real time system due to interruptions, prioritization, etc. However, waiting no as long as requested is just an error, always. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #2751: the real wait time of sigtimedwait() more than specified time one CONFIG_USEC_PER_TICK
patacongo edited a comment on issue #2751: URL: https://github.com/apache/incubator-nuttx/issues/2751#issuecomment-768321262 What the op is seeing here is not normally timer behavior. It is a consequence of running the setup up the timer consistent in phase the system time and, hence, experience the maximum error every time. If the timer is set up a random phase with respect to the system timer, then removing the +1 would introduce serious, subtle errors. The +1 was added to fix those errors. For example, suppose the system timer has a 10MS period and you request the a 10MS delay like usleep(10*1000) near the system timer period. That would result in no delay and a complete failure of the timing if +1 were not added to delay ticks. That could result in very bad consequences. Waiting a little too long, on the other hander, is never an error. That will happen normally in real time system due to interruptions, prioritization, etc. However, waiting no as long as requested is just an error. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2735: nRF52: add support for building SoftDevice BLE controller
v01d commented on a change in pull request #2735: URL: https://github.com/apache/incubator-nuttx/pull/2735#discussion_r565409512 ## File path: arch/arm/src/nrf52/Make.defs ## @@ -163,3 +163,89 @@ endif ifeq ($(CONFIG_PM),y) CHIP_CSRCS += nrf52_pminitialize.c endif + +ifeq ($(CONFIG_NRF52_SOFTDEVICE_CONTROLLER),y) + +NRFXLIB_UNPACK := sdk-nrfxlib +NRFXLIB_VER := 1.4.2 +NRFXLIB_REF := v$(NRFXLIB_VER) +NRFXLIB_TGZ := $(NRFXLIB_REF).tar.gz +NRFXLIB_URL := https://github.com/nrfconnect/sdk-nrfxlib/archive + +NRFX_UNPACK := nrfx +NRFX_VER:= 2.4.0 +NRFX_REF:= v$(NRFX_VER) +NRFX_TGZ:= $(NRFX_REF).tar.gz +NRFX_URL:= https://github.com/NordicSemiconductor/nrfx/archive + +CMSIS_UNPACK:= CMSIS_5 +CMSIS_VER := 5.7.0 +CMSIS_REF := $(CMSIS_VER) +CMSIS_TGZ := $(CMSIS_REF).tar.gz +CMSIS_URL := https://github.com/ARM-software/CMSIS_5/archive + +$(NRFXLIB_TGZ): + $(Q) echo "Downloading: NRFXLIB" + $(Q) curl -L $(NRFXLIB_URL)/$(NRFXLIB_TGZ) -o chip/$(NRFXLIB_TGZ) + +$(NRFX_TGZ): + $(Q) echo "Downloading: NRFX" + $(Q) curl -L $(NRFX_URL)/$(NRFX_TGZ) -o chip/$(NRFX_TGZ) + +$(CMSIS_TGZ): + $(Q) echo "Downloading: CMSIS" + $(Q) curl -L $(CMSIS_URL)/$(CMSIS_TGZ) -o chip/$(CMSIS_TGZ) + +chip/$(NRFXLIB_UNPACK): $(NRFXLIB_TGZ) + $(Q) echo "Unpacking: NRXFLIB" + $(Q) cd chip && tar zxf $(NRFXLIB_TGZ) + $(Q) mv chip/$(NRFXLIB_UNPACK)-$(NRFXLIB_VER)* chip/$(NRFXLIB_UNPACK) + $(Q) touch chip/$(NRFXLIB_UNPACK) + +chip/$(NRFX_UNPACK): $(NRFX_TGZ) + $(Q) echo "Unpacking: NRXF" + $(Q) cd chip && tar zxf $(NRFX_TGZ) + $(Q) mv chip/$(NRFX_UNPACK)-$(NRFX_VER)* chip/$(NRFX_UNPACK) + $(Q) touch chip/$(NRFX_UNPACK) + +chip/$(CMSIS_UNPACK): $(CMSIS_TGZ) Review comment: I justed looked at what is used from CMSIS and it seems it is only these definitions: ``` #ifdef __cplusplus #define __I volatile /*!< Defines 'read only' permissions */ #else #define __I volatile const /*!< Defines 'read only' permissions */ #endif #define __O volatile /*!< Defines 'write only' permissions */ #define __IOvolatile /*!< Defines 'read / write' permissions */ /* following defines should be used for structure members */ #define __IM volatile const /*! Defines 'read only' structure member permissions */ #define __OM volatile/*! Defines 'write only' structure member permissions */ #define __IOMvolatile/*! Defines 'read / write' structure member permissions */ ``` As per nrfx, it seems that I only need the definition of type `IRQn_Type` which is an enum. I could make a typedef but I'm not sure what is the appropriate size (I've read that it could be 8 bits if there are less than 256 values but it could also be 32 bits). We could avoid downloading nrfx and CMSIS this way, but I would need to probably patch nrfxlib to not include core_cm4.h and nrf.h (and provide these defininitions in separate header included before sdc/mpsl headers). With these changes would it look better for you? We would only download nrfxlib, which is still a bit large but we need various files from there anyway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (b9d4bd0 -> c33040f)
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from b9d4bd0 arch: esp32: Fix compile errors with CONFIG_SMP=y add c33040f License/authorship handling scripts No new revisions were added by this update. Summary of changes: tools/licensing/README.md | 57 .../cxd56_uid.h => tools/licensing/apachize.py | 40 +-- tools/licensing/author_mappings.json | 11 + tools/licensing/check.py | 287 + tools/licensing/log2json.sh| 77 ++ 5 files changed, 456 insertions(+), 16 deletions(-) create mode 100644 tools/licensing/README.md copy arch/arm/src/cxd56xx/cxd56_uid.h => tools/licensing/apachize.py (54%) mode change 100644 => 100755 create mode 100644 tools/licensing/author_mappings.json create mode 100755 tools/licensing/check.py create mode 100755 tools/licensing/log2json.sh
[GitHub] [incubator-nuttx] hartmannathan merged pull request #1834: License/authorship handling scripts
hartmannathan merged pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #1834: License/authorship handling scripts
hartmannathan commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-768348267 > Why not merge the patch? then we can refine the script in IP clean process. Agreed. I will merge the patch now and we will go from there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #2751: the real wait time of sigtimedwait() more than specified time one CONFIG_USEC_PER_TICK
patacongo commented on issue #2751: URL: https://github.com/apache/incubator-nuttx/issues/2751#issuecomment-768321262 What the op is seeing here is not normally timer behavior. It is a consequence of running the setup up the timer consistent in phase the system time and, hence, experience the maximum error every time. If the timer is set up a random phase with respect to the system timer, then removing the +1 would introduce serious, subtle errors. The +1 was added to fix those errors. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #2758: arch/xtensa/Kconfig: Reduce the default value of the internal memory.
Ouss4 opened a new pull request #2758: URL: https://github.com/apache/incubator-nuttx/pull/2758 ## Summary The static memory for ESP32 is now divided at almost the middle to not override the ROM data. The old 0x28000 will take all of what's left for heap region1. ## Impact The whole internal heap is disabled by default. So no impact. ## Testing esp32 boards. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #2757: esp32/esp32_wifi_adapter.c: Print debug output only when DEBUG_WIRLESS* are enabled.
Ouss4 edited a comment on pull request #2757: URL: https://github.com/apache/incubator-nuttx/pull/2757#issuecomment-768287657 @masayuki2009 BTW, if you want to also remove some of the output from the 2nd stage bootloader, you need to build one from IDF with BOOTLOADER_LOG_LEVEL_NONE selected. This is only for some debug output at startup. @donghengqaz PTAL. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2757: esp32/esp32_wifi_adapter.c: Print debug output only when DEBUG_WIRLESS* are enabled.
Ouss4 commented on pull request #2757: URL: https://github.com/apache/incubator-nuttx/pull/2757#issuecomment-768287657 @masayuki2009 BTW, if you want to also remove some of the output from the 2nd stage bootloader, you need to build one from IDF with BOOTLOADER_LOG_LEVEL_NONE selected. @donghengqaz PTAL. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #2757: esp32/esp32_wifi_adapter.c: Print debug output only when DEBUG_WIRLESS* are enabled.
Ouss4 opened a new pull request #2757: URL: https://github.com/apache/incubator-nuttx/pull/2757 ## Summary Condition the output printed by the Wifi driver with DEBUG_WIRELESS* ## Impact Remove some debug messages when DEBUG_WIRELESS are disabled. ## Testing esp32-wroverè-kit:wapi This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #2751: the real wait time of sigtimedwait() more than specified time one CONFIG_USEC_PER_TICK
patacongo commented on issue #2751: URL: https://github.com/apache/incubator-nuttx/issues/2751#issuecomment-768285491 > > > @shiliqinghuan it should be fine to remove the extra tick, could you provide a patch to fix it? No, that we be logic error. You should not remove the extra tick. If you remove it, then you will have occasional waits that are shorter that the requested wait. That is unacceptable behavior for the API. Again, please read https://cwiki.apache.org/confluence/display/NUTTX/Short+Time+Delays This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2735: nRF52: add support for building SoftDevice BLE controller
v01d commented on a change in pull request #2735: URL: https://github.com/apache/incubator-nuttx/pull/2735#discussion_r565283680 ## File path: arch/arm/src/nrf52/nrf52_sdc.c ## @@ -0,0 +1,608 @@ +/ + * /home/v01d/coding/nuttx_sdc/nuttx/arch/arm/src/chip/nrf52_sdc.c Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2735: nRF52: add support for building SoftDevice BLE controller
v01d commented on a change in pull request #2735: URL: https://github.com/apache/incubator-nuttx/pull/2735#discussion_r565283599 ## File path: arch/arm/src/nrf52/nrf52_sdc.h ## @@ -0,0 +1,65 @@ +/ + * /home/v01d/coding/nuttx_sdc/nuttx/arch/arm/src/chip/nrf52_sdc.h Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2735: nRF52: add support for building SoftDevice BLE controller
v01d commented on a change in pull request #2735: URL: https://github.com/apache/incubator-nuttx/pull/2735#discussion_r565283070 ## File path: arch/arm/src/nrf52/nrf52_sdc.h ## @@ -0,0 +1,65 @@ +/ + * /home/v01d/coding/nuttx_sdc/nuttx/arch/arm/src/chip/nrf52_sdc.h Review comment: Right, thanks. I need to fix my code template. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2735: nRF52: add support for building SoftDevice BLE controller
acassis commented on a change in pull request #2735: URL: https://github.com/apache/incubator-nuttx/pull/2735#discussion_r565281775 ## File path: arch/arm/src/nrf52/nrf52_sdc.c ## @@ -0,0 +1,608 @@ +/ + * /home/v01d/coding/nuttx_sdc/nuttx/arch/arm/src/chip/nrf52_sdc.c Review comment: Please use relative path: arch/arm/src/chip/nrf52_sdc.c ## File path: arch/arm/src/nrf52/nrf52_sdc.h ## @@ -0,0 +1,65 @@ +/ + * /home/v01d/coding/nuttx_sdc/nuttx/arch/arm/src/chip/nrf52_sdc.h Review comment: Please use relative path instead absolute path: arch/arm/src/chip/nrf52_sdc.h This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2756: nrf52: add stackcheck support
v01d commented on pull request #2756: URL: https://github.com/apache/incubator-nuttx/pull/2756#issuecomment-768262924 Ok, we can do that later then. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2735: nRF52: add support for building SoftDevice BLE controller
v01d commented on pull request #2735: URL: https://github.com/apache/incubator-nuttx/pull/2735#issuecomment-768262291 Also, I'm supposed to avoid any concurrent calls to SDC/MPL functions. I added semaphores for mutual exclusion. But it seems that I should also not interrupt these calls so I added critical sections around them. I'm not entirely sure that is correct (I get confused with sched_lock, irqsave and critical section). For reference, this is what the SDC docs require: > Low priority is used for background tasks that are not directly tied to the radio or scheduling. These tasks are designed in such a way that they can be interrupted by high priority code. The tasks are however not designed to be interrupted by other low priority tasks. Therefore, make sure that only one MPSL API function is called from the application at any time. > > All protocol stacks using MPSL must be synchronized (i.e. not called concurrently) to avoid concurrent calls to MPSL functions. > > Application must only call MPSL APIs from non-preemptible threads, or with interrupts disabled (e.g. during initialization). > > The mpsl_low_priority_process() function should only be called from thread context, i.e. not directly from the software interrupt handler. > > Alternatively, you can use synchronization primitives to ensure that no MPSL functions are called at the same time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: arch: esp32: Fix compile errors with CONFIG_SMP=y
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new b9d4bd0 arch: esp32: Fix compile errors with CONFIG_SMP=y
b9d4bd0 is described below
commit b9d4bd0854c2619af8c0dc025d749c0c19490bdf
Author: Masayuki Ishikawa
AuthorDate: Wed Jan 27 19:37:03 2021 +0900
arch: esp32: Fix compile errors with CONFIG_SMP=y
Summary:
- This commit fixes compile errors in esp32_spiflash.c and
esp32_wifi_adapter.c with CONFIG_SMP=y
Impact:
- SMP only
Testing:
- Tested with esp32-devkitc:wapi
- NOTE: the following configs need to be added.
+CONFIG_SMP=y
+CONFIG_SMP_IDLETHREAD_STACKSIZE=3072
+CONFIG_SMP_NCPUS=2
+CONFIG_SPINLOCK_IRQ=y
Signed-off-by: Masayuki Ishikawa
---
arch/xtensa/src/esp32/esp32_spiflash.c | 2 +-
arch/xtensa/src/esp32/esp32_wifi_adapter.c | 6 +-
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/xtensa/src/esp32/esp32_spiflash.c
b/arch/xtensa/src/esp32/esp32_spiflash.c
index 96c21ca..f019f01 100644
--- a/arch/xtensa/src/esp32/esp32_spiflash.c
+++ b/arch/xtensa/src/esp32/esp32_spiflash.c
@@ -616,8 +616,8 @@ static void IRAM_ATTR spiflash_flushmapped(size_t start,
size_t size)
Cache_Flush(0);
#ifndef CONFIG_SMP
Cache_Flush(1);
-}
#endif
+}
}
}
diff --git a/arch/xtensa/src/esp32/esp32_wifi_adapter.c
b/arch/xtensa/src/esp32/esp32_wifi_adapter.c
index cda5d93..b7abaa1 100644
--- a/arch/xtensa/src/esp32/esp32_wifi_adapter.c
+++ b/arch/xtensa/src/esp32/esp32_wifi_adapter.c
@@ -755,7 +755,7 @@ static void *esp_spin_lock_create(void)
spinlock_t *lock;
int tmp;
- tmp = sizeof(struct spinlock_t);
+ tmp = sizeof(*lock);
lock = kmm_malloc(tmp);
if (!lock)
{
@@ -3901,11 +3901,7 @@ static unsigned long esp_random_ulong(void)
uint32_t IRAM_ATTR esp_dport_access_reg_read(uint32_t reg)
{
-#ifdef CONFIG_SMP
- DEBUGASSERT(0);
-#else
return getreg32(reg);
-#endif
}
/
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2755: arch: esp32: Fix compile errors with CONFIG_SMP=y
xiaoxiang781216 merged pull request #2755: URL: https://github.com/apache/incubator-nuttx/pull/2755 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2735: nRF52: add support for building SoftDevice BLE controller
v01d commented on pull request #2735: URL: https://github.com/apache/incubator-nuttx/pull/2735#issuecomment-768260196 Ok, I managed to make this work. We can have full BLE controller now on nRF52 =) I tested this with nimBLE and it works perfectly. @btashton regarding your comments, is your concern download size or having include flags for these external HALs? While the flags would also apply for arch-level source code, this is the only file where these headers would be included. Maybe it is possible to have these include flags be set for this source file only? w.r.t. download size, I'm not sure it is possible to download only parts of a repo from GitHub. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2756: nrf52: add stackcheck support
xiaoxiang781216 commented on pull request #2756: URL: https://github.com/apache/incubator-nuttx/pull/2756#issuecomment-768259611 > This requires the appropriate build flag (-finstrument-functions). @xiaoxiang781216 since you've been migrating repeating flags for boards, is there a general place where this could be added? It's better to move the common toolchain flag to arch(e.g. https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-m/Toolchain.defs), so all boards can get the same feature support at the same time. Since the duplication setting is huge we can do the movement step by step. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2756: nrf52: add stackcheck support
v01d commented on pull request #2756: URL: https://github.com/apache/incubator-nuttx/pull/2756#issuecomment-768255113 This requires the appropriate build flag (-finstrument-functions). @xiaoxiang781216 since you've been migrating repeating flags for boards, is there a general place where this could be added? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d opened a new pull request #2756: nrf52: add stackcheck support
v01d opened a new pull request #2756: URL: https://github.com/apache/incubator-nuttx/pull/2756 ## Summary Add required code to support stack checking functionality. ## Impact Add feature ## Testing Built OK, can't verify if it is working though. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] acassis commented on a change in pull request #572: Add support in printf command to send 8-32 bits value
acassis commented on a change in pull request #572:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/572#discussion_r565269179
##
File path: nshlib/nsh_printf.c
##
@@ -84,7 +87,34 @@ int cmd_printf(FAR struct nsh_vtbl_s *vtbl, int argc, char
**argv)
{
case 'x':
Review comment:
Hi @xiaoxiang781216, using "printf \x01 \x00 \x00 \x00 > /dev/userleds"
works, but the user will need to take care about endianess. Using \x0001 is
more intuitive, because we know the LSB is 1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 edited a comment on pull request #2755: arch: esp32: Fix compile errors with CONFIG_SMP=y
masayuki2009 edited a comment on pull request #2755: URL: https://github.com/apache/incubator-nuttx/pull/2755#issuecomment-768248369 >@masayuki2009 the following could solve that: @Ouss4 Thanks. Can you create a new PR for it? I think we need to support CONFIG_DEBUG_WIRELESS_ERROR and CONFIG_DEBUG_WIRELESS_WARN as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2755: arch: esp32: Fix compile errors with CONFIG_SMP=y
masayuki2009 commented on pull request #2755: URL: https://github.com/apache/incubator-nuttx/pull/2755#issuecomment-768248369 >@masayuki2009 the following could solve that: @Ouss4 Thanks. Can you create a new PR for it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #2755: arch: esp32: Fix compile errors with CONFIG_SMP=y
Ouss4 edited a comment on pull request #2755:
URL: https://github.com/apache/incubator-nuttx/pull/2755#issuecomment-768235520
> By the way, do you know how to suppress the following messages?
I'd like to see such messages only with CONFIG_DEBUG_WIRELESS_INFO=y
@masayuki2009 the following could solve that:
```diff
diff --git a/arch/xtensa/src/esp32/esp32_wifi_adapter.c
b/arch/xtensa/src/esp32/esp32_wifi_adapter.c
index cda5d937be..bdebc7263a 100644
--- a/arch/xtensa/src/esp32/esp32_wifi_adapter.c
+++ b/arch/xtensa/src/esp32/esp32_wifi_adapter.c
@@ -3343,6 +3343,7 @@ static uint32_t esp_rand(void)
static void esp_log_writev(uint32_t level, const char *tag,
const char *format, va_list args)
{
+#ifdef CONFIG_DEBUG_WIRELESS_INFO
int pri;
switch (level)
@@ -3362,6 +3363,7 @@ static void esp_log_writev(uint32_t level, const char
*tag,
}
vsyslog(pri, format, args);
+#endif
}
/
@@ -3384,10 +3386,12 @@ void esp_log_write(uint32_t level,
const char *tag,
const char *format, ...)
{
+#ifdef CONFIG_DEBUG_WIRELESS_INFO
va_list list;
va_start(list, format);
esp_log_writev(level, tag, format, list);
va_end(list);
+#endif
}
/
@@ -3997,11 +4001,13 @@ int phy_printf(const char *format, ...)
int net80211_printf(const char *format, ...)
{
+#ifdef CONFIG_DEBUG_WIRELESS_INFO
va_list arg;
va_start(arg, format);
vsyslog(LOG_INFO, format, arg);
va_end(arg);
+#endif
return 0;
}
```
@donghengqaz what do you think, is there any reason to keep the logs?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2755: arch: esp32: Fix compile errors with CONFIG_SMP=y
Ouss4 commented on pull request #2755:
URL: https://github.com/apache/incubator-nuttx/pull/2755#issuecomment-768235520
> By the way, do you know how to suppress the following messages?
I'd like to see such messages only with CONFIG_DEBUG_WIRELESS_INFO=y
@masayuki2009 the following could solve that:
```diff
diff --git a/arch/xtensa/src/esp32/esp32_wifi_adapter.c
b/arch/xtensa/src/esp32/esp32_wifi_adapter.c
index cda5d937be..bdebc7263a 100644
--- a/arch/xtensa/src/esp32/esp32_wifi_adapter.c
+++ b/arch/xtensa/src/esp32/esp32_wifi_adapter.c
@@ -3343,6 +3343,7 @@ static uint32_t esp_rand(void)
static void esp_log_writev(uint32_t level, const char *tag,
const char *format, va_list args)
{
+#ifdef CONFIG_DEBUG_WIRELESS_INFO
int pri;
switch (level)
@@ -3362,6 +3363,7 @@ static void esp_log_writev(uint32_t level, const char
*tag,
}
vsyslog(pri, format, args);
+#endif
}
/
@@ -3384,10 +3386,12 @@ void esp_log_write(uint32_t level,
const char *tag,
const char *format, ...)
{
+#ifdef CONFIG_DEBUG_WIRELESS_INFO
va_list list;
va_start(list, format);
esp_log_writev(level, tag, format, list);
va_end(list);
+#endif
}
/
@@ -3997,11 +4001,13 @@ int phy_printf(const char *format, ...)
int net80211_printf(const char *format, ...)
{
+#ifdef CONFIG_DEBUG_WIRELESS_INFO
va_list arg;
va_start(arg, format);
vsyslog(LOG_INFO, format, arg);
va_end(arg);
+#endif
return 0;
}
```
@donghengqaz what do you think?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2755: arch: esp32: Fix compile errors with CONFIG_SMP=y
masayuki2009 commented on pull request #2755: URL: https://github.com/apache/incubator-nuttx/pull/2755#issuecomment-768227168 @Ouss4 By the way, do you know how to suppress the following messages? I'd like to see such messages only with CONFIG_DEBUG_WIRELESS_INFO=y ``` I (99533) wifi:mode : sta (3c:71:bf:8a:dd:10) I (99534) wifi:enable tsf I (99536) wifi:Set ps type: 0 ... ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2755: arch: esp32: Fix compile errors with CONFIG_SMP=y
masayuki2009 commented on pull request #2755: URL: https://github.com/apache/incubator-nuttx/pull/2755#issuecomment-768220887 ESP32 Wi-Fi works in SMP mode now. ``` NuttShell (NSH) NuttX-10.0.1 nsh> wapi psk wlan0 wifi-test-24g 1 nsh> wapi essid wlan0 raspi3-g 1 I (99533) wifi:mode : sta (3c:71:bf:8a:dd:10) I (99534) wifi:enable tsf I (99536) wifi:Set ps type: 0 I (100145) wifi:new:<5,0>, old:<1,0>, ap:<255,255>, sta:<5,0>, prof:1 I (100824) wifi:state: init -> auth (b0) I (100832) wifi:state: auth -> assoc (0) I (100838) wifi:state: assoc -> run (10) I (100858) wifi:connected with raspi3-g, aid = 2, channel 5, BW20, bssid = b8:27:eb:62:e8:30 I (100859) wifi:security: WPA2-PSK, phy: bgn, rssi: -51 I (100984) wifi:pm start, type: 0 nsh> I (100986) wifi:AP's beacon interval = 102400 us, DTIM period = 2 nsh> renew wlan0 nsh> ifconfig wlan0Link encap:Ethernet HWaddr 3c:71:bf:8a:dd:10 at UP inet addr:192.168.10.12 DRaddr:192.168.10.1 Mask:255.255.255.0 nsh> ps PID CPU PRI POLICY TYPENPX STATEEVENT SIGMASK STACK COMMAND 0 0 0 FIFO Kthread N-- Assigned 003072 CPU0 IDLE 1 1 0 FIFO Kthread N-- Running 003072 CPU1 IDLE 3 --- 100 RR Kthread --- Waiting Signal 002128 lpwork 4 1 100 RR Task--- Running 002128 init 5 --- 223 RR Kthread --- Waiting Semaphore 002112 rt_timer 6 --- 253 RR Kthread --- Waiting MQ empty 003664 wifi nsh> free total used freelargest Umem: 252432 50960 201472 152576 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (99a9e2b -> 6b48f8b)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 99a9e2b esp32: Enable renew for "wapi" configs add 6b48f8b netdb: A few build fixes No new revisions were added by this update. Summary of changes: libs/libc/netdb/lib_dnsaddserver.c | 3 +-- libs/libc/netdb/lib_dnsforeach.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)
[GitHub] [incubator-nuttx] Ouss4 merged pull request #2754: netdb: A few build fixes
Ouss4 merged pull request #2754: URL: https://github.com/apache/incubator-nuttx/pull/2754 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2755: arch: esp32: Fix compile errors with CONFIG_SMP=y
masayuki2009 commented on pull request #2755: URL: https://github.com/apache/incubator-nuttx/pull/2755#issuecomment-768199753 Please ignore style errors in esp32_spiflash.c The symbols exist in the ROM code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2755: arch: esp32: Fix compile errors with CONFIG_SMP=y
masayuki2009 opened a new pull request #2755: URL: https://github.com/apache/incubator-nuttx/pull/2755 ## Summary - This commit fixes compile errors in esp32_spiflash.c and esp32_wifi_adapter.c with CONFIG_SMP=y ## Impact - SMP only ## Testing - Tested with esp32-devkitc:wapi - NOTE: the following configs need to be added. +CONFIG_SMP=y +CONFIG_SMP_IDLETHREAD_STACKSIZE=3072 +CONFIG_SMP_NCPUS=2 +CONFIG_SPINLOCK_IRQ=y This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea merged pull request #575: netdb: Fix usage and comment
jerpelea merged pull request #575: URL: https://github.com/apache/incubator-nuttx-apps/pull/575 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated: netdb: Fix usage and comment
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new bb620bb netdb: Fix usage and comment
bb620bb is described below
commit bb620bb95c52415d048bd41aceeb6c22788de821
Author: YAMAMOTO Takashi
AuthorDate: Wed Jan 27 17:14:59 2021 +0900
netdb: Fix usage and comment
---
system/netdb/netdb_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/system/netdb/netdb_main.c b/system/netdb/netdb_main.c
index 4a83dd6..9285a73 100644
--- a/system/netdb/netdb_main.c
+++ b/system/netdb/netdb_main.c
@@ -82,11 +82,11 @@ static void show_usage(FAR const char *progname,
int exitcode) noreturn_function;
static void show_usage(FAR const char *progname, int exitcode)
{
- fprintf(stderr, "USAGE: %s --ipv4 \n", progname);
#ifdef HAVE_GETHOSTBYADDR
+ fprintf(stderr, "USAGE: %s --ipv4 \n", progname);
fprintf(stderr, " %s --ipv6 \n", progname);
- fprintf(stderr, " %s --host \n", progname);
#endif
+ fprintf(stderr, " %s --host \n", progname);
fprintf(stderr, " %s --help\n", progname);
exit(exitcode);
}
@@ -152,7 +152,7 @@ int main(int argc, FAR char *argv[])
}
}
- /* Handle: netdb --ipv46 */
+ /* Handle: netdb --ipv6 */
else if (strcmp(argv[1], "--ipv6") == 0)
{
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #572: Add support in printf command to send 8-32 bits value
xiaoxiang781216 commented on a change in pull request #572:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/572#discussion_r565195330
##
File path: nshlib/nsh_printf.c
##
@@ -84,7 +87,34 @@ int cmd_printf(FAR struct nsh_vtbl_s *vtbl, int argc, char
**argv)
{
case 'x':
Review comment:
should we use something like this for multiple char:
printf \x12 \x34 \x56 \x78
from https://wiki.bash-hackers.org/commands/builtin/printf:
one /x should generate one byte output.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea merged pull request #574: netcat: Fix a buffer overflow
jerpelea merged pull request #574: URL: https://github.com/apache/incubator-nuttx-apps/pull/574 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated (3b21cd9 -> 87c876c)
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from 3b21cd9 netutils/ntpclient: add more features add 87c876c netcat: Fix a buffer overflow No new revisions were added by this update. Summary of changes: netutils/netcat/netcat_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #2751: the real wait time of sigtimedwait() more than specified time one CONFIG_USEC_PER_TICK
xiaoxiang781216 commented on issue #2751: URL: https://github.com/apache/incubator-nuttx/issues/2751#issuecomment-768178375 @shiliqinghuan it should be fine to remove the extra tick, could you provide a patch to fix it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] SChina-CSC-SDD-Dev removed a comment on pull request #2625: Add time ticket related APIs to support hot sleep function
SChina-CSC-SDD-Dev removed a comment on pull request #2625: URL: https://github.com/apache/incubator-nuttx/pull/2625#issuecomment-768100795 We will propose the three below solutions as above suggestion. - Solution One We will create a new API like nxsched_process_timer_ext(ticks) called by HW platform. When resuming, HW platform will update ticks about shed, systime and sporadic etc separately through this API. And this API will update ticks through these corresponding module API. If the called module API not found, we will create the new module API to update ticks. If this solution can be acceptable and merged into mainline without other issues, we will follow this solution. - Solution Two Similar with solution One, we will create a new API like nxched_process_timer_ext(ticks) but called by nxched_process_timer(). But it seems overlying. - Solution Three We will create the mechanism. When the related module will update ticks by itself when the event has been triggered. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] yamt opened a new pull request #2754: netdb: A few build fixes
yamt opened a new pull request #2754: URL: https://github.com/apache/incubator-nuttx/pull/2754 ## Summary netdb: A few build fixes ## Impact ## Testing locally build-tested This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: esp32: Enable renew for "wapi" configs
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 99a9e2b esp32: Enable renew for "wapi" configs 99a9e2b is described below commit 99a9e2bf3d3937148d6bf98cfa44dd0dbd5089c4 Author: YAMAMOTO Takashi AuthorDate: Wed Jan 27 14:09:13 2021 +0900 esp32: Enable renew for "wapi" configs It's handy to have it when testing wifi stuff. --- boards/xtensa/esp32/esp32-devkitc/configs/wapi/defconfig | 2 +- boards/xtensa/esp32/esp32-ethernet-kit/configs/wapi/defconfig | 2 +- boards/xtensa/esp32/esp32-wrover-kit/configs/wapi/defconfig | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/boards/xtensa/esp32/esp32-devkitc/configs/wapi/defconfig b/boards/xtensa/esp32/esp32-devkitc/configs/wapi/defconfig index 9ada848..287ac2f 100644 --- a/boards/xtensa/esp32/esp32-devkitc/configs/wapi/defconfig +++ b/boards/xtensa/esp32/esp32-devkitc/configs/wapi/defconfig @@ -38,7 +38,6 @@ CONFIG_NETDB_DNSCLIENT=y CONFIG_NETDEV_LATEINIT=y CONFIG_NETDEV_PHY_IOCTL=y CONFIG_NETDEV_WIRELESS_IOCTL=y -CONFIG_NETUTILS_DHCPC=y CONFIG_NET_BROADCAST=y CONFIG_NET_ICMP=y CONFIG_NET_ICMP_SOCKET=y @@ -66,6 +65,7 @@ CONFIG_SPIFFS_NAME_MAX=48 CONFIG_START_DAY=6 CONFIG_START_MONTH=12 CONFIG_START_YEAR=2011 +CONFIG_SYSTEM_DHCPC_RENEW=y CONFIG_SYSTEM_NSH=y CONFIG_SYSTEM_PING=y CONFIG_UART0_SERIAL_CONSOLE=y diff --git a/boards/xtensa/esp32/esp32-ethernet-kit/configs/wapi/defconfig b/boards/xtensa/esp32/esp32-ethernet-kit/configs/wapi/defconfig index 7f671d7..1f725c8 100644 --- a/boards/xtensa/esp32/esp32-ethernet-kit/configs/wapi/defconfig +++ b/boards/xtensa/esp32/esp32-ethernet-kit/configs/wapi/defconfig @@ -37,7 +37,6 @@ CONFIG_NETDB_DNSCLIENT=y CONFIG_NETDEV_LATEINIT=y CONFIG_NETDEV_PHY_IOCTL=y CONFIG_NETDEV_WIRELESS_IOCTL=y -CONFIG_NETUTILS_DHCPC=y CONFIG_NET_BROADCAST=y CONFIG_NET_ICMP=y CONFIG_NET_ICMP_SOCKET=y @@ -65,6 +64,7 @@ CONFIG_SPIFFS_NAME_MAX=48 CONFIG_START_DAY=6 CONFIG_START_MONTH=12 CONFIG_START_YEAR=2011 +CONFIG_SYSTEM_DHCPC_RENEW=y CONFIG_SYSTEM_NSH=y CONFIG_SYSTEM_PING=y CONFIG_UART0_SERIAL_CONSOLE=y diff --git a/boards/xtensa/esp32/esp32-wrover-kit/configs/wapi/defconfig b/boards/xtensa/esp32/esp32-wrover-kit/configs/wapi/defconfig index 987c821..fc3dc3f 100644 --- a/boards/xtensa/esp32/esp32-wrover-kit/configs/wapi/defconfig +++ b/boards/xtensa/esp32/esp32-wrover-kit/configs/wapi/defconfig @@ -38,7 +38,6 @@ CONFIG_NETDB_DNSCLIENT=y CONFIG_NETDEV_LATEINIT=y CONFIG_NETDEV_PHY_IOCTL=y CONFIG_NETDEV_WIRELESS_IOCTL=y -CONFIG_NETUTILS_DHCPC=y CONFIG_NET_BROADCAST=y CONFIG_NET_ICMP=y CONFIG_NET_ICMP_SOCKET=y @@ -66,6 +65,7 @@ CONFIG_SPIFFS_NAME_MAX=48 CONFIG_START_DAY=6 CONFIG_START_MONTH=12 CONFIG_START_YEAR=2011 +CONFIG_SYSTEM_DHCPC_RENEW=y CONFIG_SYSTEM_NSH=y CONFIG_SYSTEM_PING=y CONFIG_UART0_SERIAL_CONSOLE=y
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2753: esp32: Enable renew for "wapi" configs
xiaoxiang781216 merged pull request #2753: URL: https://github.com/apache/incubator-nuttx/pull/2753 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #575: netdb: Fix usage and comment
yamt opened a new pull request #575: URL: https://github.com/apache/incubator-nuttx-apps/pull/575 ## Summary netdb: Fix usage and comment ## Impact ## Testing tested on esp32-devkitc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #574: netcat: Fix a buffer overflow
yamt opened a new pull request #574: URL: https://github.com/apache/incubator-nuttx-apps/pull/574 ## Summary The buffer doesn't have the space for the terminating NUL. Fix it by replacing it with fwrite, as there seems to be little reason to use fprintf and NUL-terminated string in the first place. ## Impact ## Testing tested on esp32-devkitc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
