[GitHub] [incubator-nuttx] NicholasChin commented on issue #244: Adds clock config logic and Kconfig menus for FLEXIO on IMXRT
NicholasChin commented on issue #244: Adds clock config logic and Kconfig menus for FLEXIO on IMXRT URL: https://github.com/apache/incubator-nuttx/pull/244#issuecomment-584321096 Hi David, Thanks for the steps. Still getting used to working with with github. My PR is cleaned up and all Kconfig option combos build on 1020, 1050, and 1060-evk. I rebased onto the current master this morning before making my PR. Nick This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-apps] adamfeuer commented on issue #64: apps/examples/tcpblaster: Fix compile errors in loopback mode.
adamfeuer commented on issue #64: apps/examples/tcpblaster: Fix compile errors in loopback mode. URL: https://github.com/apache/incubator-nuttx-apps/pull/64#issuecomment-584348184 @patacongo This works for me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on issue #247: boards/sim: Add a TCP loopback test.
adamfeuer commented on issue #247: boards/sim: Add a TCP loopback test. URL: https://github.com/apache/incubator-nuttx/pull/247#issuecomment-584348319 @patacongo This works for me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #247: boards/sim: Add a TCP loopback test.
patacongo opened a new pull request #247: boards/sim: Add a TCP loopback test. URL: https://github.com/apache/incubator-nuttx/pull/247 tcploop. This configuration performs a TCP "performance" test using apps/examples/tcpblaster and the IPv6 local loopback device. Performance is in quotes because, while that is the intent of the tcpblaster example, this is not an appropriate configuration for TCP performance testing. Rather, this configurat is useful only for verifying TCP transfers over the loopback device. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-apps] patacongo opened a new pull request #64: apps/examples/tcpblaster: Fix compile errors in loopback mode.
patacongo opened a new pull request #64: apps/examples/tcpblaster: Fix compile errors in loopback mode. URL: https://github.com/apache/incubator-nuttx-apps/pull/64 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #64: apps/examples/tcpblaster: Fix compile errors in loopback mode.
Ouss4 merged pull request #64: apps/examples/tcpblaster: Fix compile errors in loopback mode. URL: https://github.com/apache/incubator-nuttx-apps/pull/64 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #247: boards/sim: Add a TCP loopback test.
Ouss4 merged pull request #247: boards/sim: Add a TCP loopback test. URL: https://github.com/apache/incubator-nuttx/pull/247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #265: mm: Fix memory corruption issues in realloc
patacongo commented on a change in pull request #265: mm: Fix memory corruption
issues in realloc
URL: https://github.com/apache/incubator-nuttx/pull/265#discussion_r378859739
##
File path: mm/mm_heap/mm_realloc.c
##
@@ -213,6 +215,28 @@ FAR void *mm_realloc(FAR struct mm_heap_s *heap, FAR void
*oldmem,
}
}
+ /* Note that a free node can't be smaller than SIZEOF_MM_FREENODE.
+ * We have to either take the whole node, or leave at least
+ * SIZEOF_MM_FREENODE bytes.
+ * When we can't leave SIZEOF_MM_FREENODE bytes, just take the whole
+ * node. It might end up with returning a larger chunk than the
+ * caller requested. It should be ok.
+ */
+ DEBUGASSERT(prevsize >= takeprev);
+ DEBUGASSERT(nextsize >= takenext);
+ if (prevsize - takeprev < SIZEOF_MM_FREENODE)
+{
+ takeprev = prevsize;
+}
+ if (nextsize - takenext < SIZEOF_MM_FREENODE)
Review comment:
Coding standard requires that all terminating right braces be followed by a
blank line.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #266: Fix mm for clang
yamt commented on a change in pull request #266: Fix mm for clang
URL: https://github.com/apache/incubator-nuttx/pull/266#discussion_r378871429
##
File path: mm/mm_heap/mm_mallinfo.c
##
@@ -97,17 +98,29 @@ int mm_mallinfo(FAR struct mm_heap_s *heap, FAR struct
mallinfo *info)
if ((node->preceding & MM_ALLOC_BIT) != 0)
{
+ DEBUGASSERT(node->size >= SIZEOF_MM_ALLOCNODE);
uordblks += node->size;
}
else
{
+ FAR struct mm_freenode_s *fnode;
+ DEBUGASSERT(node->size >= SIZEOF_MM_FREENODE);
+ fnode = (FAR void *)node;
+ DEBUGASSERT(fnode->blink->flink == fnode);
+ DEBUGASSERT(fnode->blink->size <= fnode->size);
+ DEBUGASSERT(fnode->flink == NULL ||
+ fnode->flink->blink == fnode);
+ DEBUGASSERT(fnode->flink == NULL ||
+ fnode->flink->size == 0 ||
+ fnode->flink->size >= fnode->size);
ordblks++;
fordblks += node->size;
if (node->size > mxordblk)
{
mxordblk = node->size;
}
}
+ DEBUGASSERT(prev == NULL || prev->size == (node->preceding &
~MM_ALLOC_BIT));
Review comment:
thank you. fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #269: mm/: Coding style clean-up
patacongo opened a new pull request #269: mm/: Coding style clean-up URL: https://github.com/apache/incubator-nuttx/pull/269 Run tools/nxstyle against all C files under mm/ and correct coding standard violations. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #268: to introduce a new function timerfd_settime() and timerfd_gettime()
patacongo commented on issue #268: to introduce a new function timerfd_settime() and timerfd_gettime() URL: https://github.com/apache/incubator-nuttx/issues/268#issuecomment-585757926 I would prefer not. These are non-standard GLIBC functions. NuttX follows the standards defined at OpenGroup.org which does not include these interfaces. There are exceptions to this in the code base now, but I don't think we should proliferate non-standard interfaces. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] edbek opened a new issue #268: to introduce a new function timerfd_settime() and timerfd_gettime()
edbek opened a new issue #268: to introduce a new function timerfd_settime() and timerfd_gettime() URL: https://github.com/apache/incubator-nuttx/issues/268 Is it possible to introduce a new function **timerfd_settime** () and **timerfd_gettime** ()? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #265: mm: Fix memory corruption issues in realloc
patacongo commented on a change in pull request #265: mm: Fix memory corruption issues in realloc URL: https://github.com/apache/incubator-nuttx/pull/265#discussion_r378859408 ## File path: mm/mm_heap/mm_realloc.c ## @@ -213,6 +215,28 @@ FAR void *mm_realloc(FAR struct mm_heap_s *heap, FAR void *oldmem, } } + /* Note that a free node can't be smaller than SIZEOF_MM_FREENODE. + * We have to either take the whole node, or leave at least + * SIZEOF_MM_FREENODE bytes. + * When we can't leave SIZEOF_MM_FREENODE bytes, just take the whole + * node. It might end up with returning a larger chunk than the + * caller requested. It should be ok. + */ + DEBUGASSERT(prevsize >= takeprev); Review comment: Coding standard requires that all comments be followed by a blank line. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #266: Fix mm for clang
patacongo merged pull request #266: Fix mm for clang URL: https://github.com/apache/incubator-nuttx/pull/266 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #249: Simplify sim net
xiaoxiang781216 commented on issue #249: Simplify sim net URL: https://github.com/apache/incubator-nuttx/pull/249#issuecomment-584966378 @papatience the PR is rebased to the mainline now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #251: Fix a typo in Kconfig description
yamt opened a new pull request #251: Fix a typo in Kconfig description URL: https://github.com/apache/incubator-nuttx/pull/251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #251: Fix a typo in Kconfig description
xiaoxiang781216 merged pull request #251: Fix a typo in Kconfig description URL: https://github.com/apache/incubator-nuttx/pull/251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #233: boards: sabre-6quad: Add QEMU instructions to README.txt
masayuki2009 opened a new pull request #233: boards: sabre-6quad: Add QEMU instructions to README.txt URL: https://github.com/apache/incubator-nuttx/pull/233 As requested in https://github.com/apache/incubator-nuttx/issues/207, I added QEMU instructions to README.txt. I hope this would help to solve SMP related issues for Cortex-A MPCore. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 closed pull request #234: tools/checkpatch.sh: make sure fail get the real return error value
liuguo09 closed pull request #234: tools/checkpatch.sh: make sure fail get the real return error value URL: https://github.com/apache/incubator-nuttx/pull/234 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #232: Kconfig: Fix unmet dependencies on ARCH_PHY_INTERRUPT
Ouss4 merged pull request #232: Kconfig: Fix unmet dependencies on ARCH_PHY_INTERRUPT URL: https://github.com/apache/incubator-nuttx/pull/232 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #60: Ensure all source code end with one and only one newline
xiaoxiang781216 opened a new pull request #60: Ensure all source code end with one and only one newline URL: https://github.com/apache/incubator-nuttx-apps/pull/60 by this command: git ls-files -z | while IFS= read -rd '' f; do tail -c1 < "$f" | read -r _ || echo >> "$f"; done Signed-off-by: Xiang Xiao This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #59: testing/smp: Replace up_cpu_index with sched_getcpu
xiaoxiang781216 opened a new pull request #59: testing/smp: Replace up_cpu_index with sched_getcpu URL: https://github.com/apache/incubator-nuttx-apps/pull/59 Change-Id: Ieb52948ad1266f7168a85e3d17b4c79e7957894c Signed-off-by: Xiang Xiao This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] masayuki2009 commented on issue #207: SMP for Cortex-A MPcore is unstable
masayuki2009 commented on issue #207: SMP for Cortex-A MPcore is unstable URL: https://github.com/apache/incubator-nuttx/issues/207#issuecomment-583792173 @xiaoxiang781216 @patacongo I've just sent a PR https://github.com/apache/incubator-nuttx/pull/233 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #235: Fix syscall sched
xiaoxiang781216 opened a new pull request #235: Fix syscall sched URL: https://github.com/apache/incubator-nuttx/pull/235 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #249: Simplify sim net
yamt commented on a change in pull request #249: Simplify sim net URL: https://github.com/apache/incubator-nuttx/pull/249#discussion_r378186607 ## File path: boards/sim/sim/sim/README.txt ## @@ -199,6 +199,16 @@ REVISIT: This may not long be an issue even with NSH because of the recent redesign of how the stdio devices are handled in the simulation (they should no longer freeze the simulation). +Update: Please issue these commands to setup the reliable network on Ubuntu: + + sudo apt-get -y install net-tools + sudo nuttx/tools/simbridge.sh eth0 on + +Here is some tips you may need: + 1.Must launch the exectuable with the root permission + 2.Have to use virtual machine if host is in corporation network Review comment: why? just because it's better to isolate dev network? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #252: Fix typos in comments
yamt opened a new pull request #252: Fix typos in comments URL: https://github.com/apache/incubator-nuttx/pull/252 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] jerpelea merged pull request #252: Fix typos in comments
jerpelea merged pull request #252: Fix typos in comments URL: https://github.com/apache/incubator-nuttx/pull/252 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #270: Small I2C fixups
patacongo commented on a change in pull request #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#discussion_r378983337 ## File path: drivers/i2c/Kconfig ## @@ -54,3 +50,7 @@ config I2CMULTIPLEXER_PCA9540BDP endmenu # I2C Multiplexer Support endif + +config ARCH_HAVE_I2CRESET Review comment: The reason is that ARCH_HAVE_I2CRESET is selected unconditionally in all architecture configurations that support I2C reset. That is correct, advertising that an architecture supports a feature is conditional. CONFIG_I2C is completely unnecessary to enable architecture I2C support. If conditions are added to ARCH_HAVE_I2CRESET, the errors referring to unmet dependencies will be generated on all configurations that enabled architecture-specific I2C support but don't need CONFIG_I2C. This same change was added a few weeks ago and this resulted in several new errors in build testing and had to be fixed by moving ARCH_HAVE_I2CRESET outside of I2C. It must be that way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #270: Small I2C fixups
patacongo commented on issue #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#issuecomment-585854407 I will close this PR now. If you remove the offending commit, it may be reopened. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] NicholasChin commented on issue #270: Small I2C fixups
NicholasChin commented on issue #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#issuecomment-585857955 @patacongo ARCH_HAVE_I2CRESET is outside the conditional. However, ARCH_HAVE_I2CRESET MUST come after the conditional. If it does not, I2C config options are nested under the "Device Drivers" menu and not under "I2C Driver Support." This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #273: net/netlink/netlink_route.c: Fix a typo.
patacongo opened a new pull request #273: net/netlink/netlink_route.c: Fix a typo. URL: https://github.com/apache/incubator-nuttx/pull/273 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #271: Socket can
patacongo opened a new pull request #271: Socket can URL: https://github.com/apache/incubator-nuttx/pull/271 Initial WIP implementation for the socket layer interface (only) for SocketCAN sockets. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #272: Sim: loadable module definitions
yamt opened a new pull request #272: Sim: loadable module definitions URL: https://github.com/apache/incubator-nuttx/pull/272 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] edbek commented on issue #268: to introduce a new function timerfd_settime() and timerfd_gettime()
edbek commented on issue #268: to introduce a new function timerfd_settime() and timerfd_gettime() URL: https://github.com/apache/incubator-nuttx/issues/268#issuecomment-585833546 I agree ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #270: Small I2C fixups
patacongo commented on a change in pull request #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#discussion_r378973957 ## File path: drivers/i2c/Kconfig ## @@ -54,3 +50,7 @@ config I2CMULTIPLEXER_PCA9540BDP endmenu # I2C Multiplexer Support endif + +config ARCH_HAVE_I2CRESET Review comment: We have been through this one before. ARCH_HAVE_I2CRESET must be outside of if I2C, otherwise Kconfig generates errors. This cannot be accepted into the repository. That same mistake was made in a previous PR and that had to be reverted because of all of the configuration errors it causes. This cannot be accepted into the repository. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #270: Small I2C fixups
patacongo commented on issue #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#issuecomment-585866363 Yes, there is a problem. But your solution is not correct. It is worse. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #272: Sim: loadable module definitions
xiaoxiang781216 commented on a change in pull request #272: Sim: loadable module definitions URL: https://github.com/apache/incubator-nuttx/pull/272#discussion_r379018268 ## File path: boards/sim/sim/sim/configs/cxxtest/Make.defs ## @@ -128,6 +142,7 @@ ifeq ($(CONFIG_SIM_M32),y) LDLINKFLAGS += -melf_i386 CCLINKFLAGS += -m32 LDFLAGS += -m32 + LDMODULEFLAGS += -melf_i386 Review comment: LDELFFLAGS need -melf_i386 too This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #272: Sim: loadable module definitions
xiaoxiang781216 commented on a change in pull request #272: Sim: loadable module definitions URL: https://github.com/apache/incubator-nuttx/pull/272#discussion_r379018520 ## File path: boards/sim/sim/sim/configs/nsh2/Make.defs ## @@ -120,6 +134,7 @@ ifeq ($(CONFIG_SIM_M32),y) LDLINKFLAGS += -melf_i386 CCLINKFLAGS += -m32 LDFLAGS += -m32 + LDMODULEFLAGS += -melf_i386 Review comment: align with other line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] NicholasChin commented on a change in pull request #270: Small I2C fixups
NicholasChin commented on a change in pull request #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#discussion_r378962319 ## File path: drivers/i2c/Kconfig ## @@ -53,4 +49,8 @@ config I2CMULTIPLEXER_PCA9540BDP endmenu # I2C Multiplexer Support +config ARCH_HAVE_I2CRESET Review comment: Hi Xiang, I've pulled ARCH_HAVE_I2CRESET out of the if I2C conditional. The conditional must be first in this file as menuconfigs will only nest configs if the conditional is the next block after declaring the menuconfig. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #270: Small I2C fixups
patacongo commented on a change in pull request #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#discussion_r378996148 ## File path: drivers/i2c/Kconfig ## @@ -54,3 +50,7 @@ config I2CMULTIPLEXER_PCA9540BDP endmenu # I2C Multiplexer Support endif + +config ARCH_HAVE_I2CRESET Review comment: You could move the ARCH_HAVE_I2CRESET item into the drivers/Kconfig file before CONFIG_I2C is selected. That would resolve the problem. I personally believe that all of the ARCH_HAVE_ definitions belong in the arch/Kconfig menu. That is were they were originally and there is where they best belong. The ARCH naming conventions is only correct if they reside in the arch/Kconfig file. But there were moved all over in a recent PR and now the naming is wrong and a lot of dependencies relationships have been broken and kludged around like this one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] acassis merged pull request #271: Socket can
acassis merged pull request #271: Socket can URL: https://github.com/apache/incubator-nuttx/pull/271 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #270: Small I2C fixups
patacongo commented on issue #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#issuecomment-585859504 That does not matter because that option is not visual in the menus. It is a hidden option that can only be selected by architecture code. Certainly that is not an excuse to introduce errors into the configuration. Configuration options that have no prompt string do not appear in the menus. This is internal implementation of configuration system and not part of the UI menus. Everything is correct as it is. Please do not change anything. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] NicholasChin commented on a change in pull request #270: Small I2C fixups
NicholasChin commented on a change in pull request #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#discussion_r379000645 ## File path: drivers/i2c/Kconfig ## @@ -54,3 +50,7 @@ config I2CMULTIPLEXER_PCA9540BDP endmenu # I2C Multiplexer Support endif Review comment: @patacongo This is the `endif` for the corresponding `if I2c` `config ARCH_HAVE_I2CRESET` comes after it. Therefore, `ARCH_HAVE_I2CRESET` does NOT DEPEND on I2C and is unconditionally declared. This is correct. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] NicholasChin commented on a change in pull request #270: Small I2C fixups
NicholasChin commented on a change in pull request #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#discussion_r379001861 ## File path: drivers/i2c/Kconfig ## @@ -54,3 +50,7 @@ config I2CMULTIPLEXER_PCA9540BDP endmenu # I2C Multiplexer Support endif + +config ARCH_HAVE_I2CRESET Review comment: This Kconfig file isn't conditionally brought in when I2C is defined. So technically ARCH_HAVE_I2CRESET is declared at the same level as it was before. If it would be preferred for these to be declared in the larger Kconfig as before, I can change that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] NicholasChin opened a new pull request #270: Small I2C fixups
NicholasChin opened a new pull request #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270 Commit a44fb6e simply switches the place of a symbol so I2C options are nested under "I2C Driver Support" properly. Commit 0ec84b8 is for an issue I was seeing with my IMXRT platform where it seemed to poll the AT24 so fast that it burned through the 100 retries before the AT24 was ready to accept commands. 500 retries is the absolute max that you should need as 500 NACK'd transaction at 1MHz takes the same time as the AT24's max write time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #249: Simplify sim net
xiaoxiang781216 opened a new pull request #249: Simplify sim net URL: https://github.com/apache/incubator-nuttx/pull/249 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] acassis merged pull request #248: Network Loopbacka Driver: Configuration to control packet size
acassis merged pull request #248: Network Loopbacka Driver: Configuration to control packet size URL: https://github.com/apache/incubator-nuttx/pull/248 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #244: Adds clock config logic and Kconfig menus for FLEXIO on IMXRT
patacongo merged pull request #244: Adds clock config logic and Kconfig menus for FLEXIO on IMXRT URL: https://github.com/apache/incubator-nuttx/pull/244 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] sgysh opened a new pull request #250: boards: stm32f4discovery: Modify a default path to a romfs image
sgysh opened a new pull request #250: boards: stm32f4discovery: Modify a default path to a romfs image URL: https://github.com/apache/incubator-nuttx/pull/250 Modify a default path to a romfs image because the stm32f4discovery directory has been moved from configs/ to boards/arm/stm32/. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #248: Network Loopbacka Driver: A configuration option to control packet s…
patacongo opened a new pull request #248: Network Loopbacka Driver: A configuration option to control packet s… URL: https://github.com/apache/incubator-nuttx/pull/248 …ize. Historically, the loopback driver used the largest packet size of all enabled link layer protocols. This permitted packets to be forward via the loopbak device with no major loss of performance. However, in experimenting with configurations where no other link layer protocols were enabled, this means the loopback packet size was set to the smallest possible size, to the SLIP minimum of 296 bytes. This resulted in terrible loopback performance. This commit adds an option to increase the loopback packet size with the option CONFIG_NET_LOOPBACK_PACKETSIZE. The loopback driver packet buffer should be quite large. The larger the loopback packet buffer, the better will be TCP performance of the loopback transfers. The Linux loopback device historically used packet buffers of size 16Kb, but that was increased in recent Linux versions to 64Kb. Those sizes may be excessive for resource constrained MCUs, however. The network still enforces the lower limit that is the maximum packet size of all enabled link layer protocols. But this new option permits the loopback packet size to be increased from that. * net/Kconfig: Adds CONFIG_NET_LOOPBACK_PKTSIZE option * include/nuttx/net/netconfig.h: Assures that the packet size that is used is at least as large as the largest packet size of other link layer protocols. * drivers/net/loopback.c: Use that larger packet size. * boards/sim/sim/sim/configs/tcploop/defconfig: Set the loopback packet size to 1500 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #253: Fix typos in comments
yamt opened a new pull request #253: Fix typos in comments URL: https://github.com/apache/incubator-nuttx/pull/253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #207: SMP for Cortex-A MPcore is unstable
patacongo commented on issue #207: SMP for Cortex-A MPcore is unstable URL: https://github.com/apache/incubator-nuttx/issues/207#issuecomment-585253784 I don't see any simple way to implement the first issue you mention, that where g_irqtmp would be invalid in the case of nested interrupts. I see only two solutions and neither are simple: 1. Implement IRQ/FIQ stacks. I am not clear on the design that would use these stacks, but stacking the data should be able to support nesting. 2. Implement ICCMPR interrupt controls and prohibit nesting interrupts altogether. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #207: SMP for Cortex-A MPcore is unstable
patacongo edited a comment on issue #207: SMP for Cortex-A MPcore is unstable URL: https://github.com/apache/incubator-nuttx/issues/207#issuecomment-585253784 I don't see any simple way to implement the first issue you mention, that where g_irqtmp would be invalid in the case of nested interrupts. Nested interrupts would occur only in the SMP case where the SGI inter-processor interrupts are non-maskable. I see only two solutions and neither are simple: 1. Implement IRQ/FIQ stacks. I am not clear on the design that would use these stacks, but stacking the data should be able to support nesting. 2. Implement ICCMPR interrupt controls and prohibit nesting interrupts altogether. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #254: arch/arm/src/armv7-a/arm_vectors.S: Fix clobbered register in SMP mode.
Ouss4 merged pull request #254: arch/arm/src/armv7-a/arm_vectors.S: Fix clobbered register in SMP mode. URL: https://github.com/apache/incubator-nuttx/pull/254 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #210: Reimplement sim uart on top of serial driver framework
yamt commented on issue #210: Reimplement sim uart on top of serial driver framework URL: https://github.com/apache/incubator-nuttx/pull/210#issuecomment-585270761 @xiaoxiang781216 after this change, nuttx sim console stopped working for me. it's on macos. some messages like finfo() show up, but no nsh prompt. do you have any ideas? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #249: Simplify sim net
patacongo merged pull request #249: Simplify sim net URL: https://github.com/apache/incubator-nuttx/pull/249 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #254: arch/arm/src/armv7-a/arm_vectors.S: Fix clobbered register in SMP mode.
patacongo opened a new pull request #254: arch/arm/src/armv7-a/arm_vectors.S: Fix clobbered register in SMP mode. URL: https://github.com/apache/incubator-nuttx/pull/254 This should resolve one of two problems noted by @masayuki2009 in #207 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #249: Simplify sim net
xiaoxiang781216 commented on a change in pull request #249: Simplify sim net URL: https://github.com/apache/incubator-nuttx/pull/249#discussion_r378243489 ## File path: boards/sim/sim/sim/README.txt ## @@ -199,6 +199,16 @@ REVISIT: This may not long be an issue even with NSH because of the recent redesign of how the stdio devices are handled in the simulation (they should no longer freeze the simulation). +Update: Please issue these commands to setup the reliable network on Ubuntu: + + sudo apt-get -y install net-tools + sudo nuttx/tools/simbridge.sh eth0 on + +Here is some tips you may need: + 1.Must launch the exectuable with the root permission + 2.Have to use virtual machine if host is in corporation network Review comment: In my case, the coperation network enable some adavanced link layer authentication which NuttX doesn't implement yet and then fail to login the network. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #210: Reimplement sim uart on top of serial driver framework
yamt commented on issue #210: Reimplement sim uart on top of serial driver framework URL: https://github.com/apache/incubator-nuttx/pull/210#issuecomment-585286554 i found i had CONFIG_STDIO_DISABLE_BUFFERING=y in my config. removing it somehow mitigated the issue. but it's still occasionally happening. having a large CONFIG_STDIO_BUFFER_SIZE seems like a workaround. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] jerpelea merged pull request #253: Fix typos in comments
jerpelea merged pull request #253: Fix typos in comments URL: https://github.com/apache/incubator-nuttx/pull/253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #210: Reimplement sim uart on top of serial driver framework
yamt commented on issue #210: Reimplement sim uart on top of serial driver framework URL: https://github.com/apache/incubator-nuttx/pull/210#issuecomment-585297853 here's my config. https://gist.github.com/yamt/b299c2a096bf89d4191db25a90b8fccb i will try linux if i have a chance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] NicholasChin opened a new pull request #255: IMXRT qencoder and chip Kconfig fixes
NicholasChin opened a new pull request #255: IMXRT qencoder and chip Kconfig fixes URL: https://github.com/apache/incubator-nuttx/pull/255 Both commits pass NX style and have been built with the 1020, 1050, and 1060-evk nsh configs. The Qencoder changes address compiler warnings and improves Kconfig symbol checking, with no major changes to functionality. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #210: Reimplement sim uart on top of serial driver framework
xiaoxiang781216 commented on issue #210: Reimplement sim uart on top of serial driver framework URL: https://github.com/apache/incubator-nuttx/pull/210#issuecomment-585312812 I can run to nsh as normal with your config on Ubuntu, macOS specific issue? ramdisk_register: buffer: 0x556e73d89be0 nsectors: 16 sectsize: 64 nsh_romfsetc: Mounting ROMFS filesystem at target=/etc with source=/dev/ram1 romfs_bind: Entry rd_open: rd_crefs: 1 rd_geometry: Entry rd_geometry: available: true mediachanged: false writeenabled: false rd_geometry: nsectors: 16 sectorsize: 64 rd_ioctl: Entry rd_ioctl: ppv: 0x556e73d89be0 binfs_bind: Entry romfs_open: Open 'init.d/rcS' rd_geometry: Entry rd_geometry: available: true mediachanged: false writeenabled: false rd_geometry: nsectors: 16 sectorsize: 64 romfs_seek: Seek to offset: 0 whence: 1 rd_geometry: Entry rd_geometry: available: true mediachanged: false writeenabled: false rd_geometry: nsectors: 16 sectorsize: 64 romfs_seek: New file position: 0 romfs_read: Read 1 bytes from offset 0 rd_geometry: Entry rd_geometry: available: true mediachanged: false writeenabled: false rd_geometry: nsectors: 16 sectorsize: 64 romfs_read: Read sector 3 romfs_filecacheread: sector: 3 cached: 0 sectorsize: 64 XIP base: 0x556e73d89be0 buffer: 0x556e73d89be0 romfs_filecacheread: XIP buffer: 0x556e73d89ca0 romfs_read: Return 1 bytes from sector offset 0 romfs_read: Read 1 bytes from offset 1 rd_geometry: Entry rd_geometry: available: true mediachanged: false writeenabled: false rd_geometry: nsectors: 16 sectorsize: 64 romfs_read: Read sector 3 romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 0x556e73d89be0 buffer: 0x556e73d89ca0 romfs_read: Return 1 bytes from sector offset 1 romfs_read: Read 1 bytes from offset 2 rd_geometry: Entry rd_geometry: available: true mediachanged: false writeenabled: false rd_geometry: nsectors: 16 sectorsize: 64 romfs_read: Read sector 3 romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 0x556e73d89be0 buffer: 0x556e73d89ca0 romfs_read: Return 1 bytes from sector offset 2 romfs_read: Read 1 bytes from offset 3 rd_geometry: Entry rd_geometry: available: true mediachanged: false writeenabled: false rd_geometry: nsectors: 16 sectorsize: 64 romfs_read: Read sector 3 romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 0x556e73d89be0 buffer: 0x556e73d89ca0 romfs_read: Return 1 bytes from sector offset 3 romfs_read: Read 1 bytes from offset 4 rd_geometry: Entry rd_geometry: available: true mediachanged: false writeenabled: false rd_geometry: nsectors: 16 sectorsize: 64 romfs_read: Read sector 3 romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 0x556e73d89be0 buffer: 0x556e73d89ca0 romfs_read: Return 1 bytes from sector offset 4 romfs_read: Read 1 bytes from offset 5 rd_geometry: Entry rd_geometry: available: true mediachanged: false writeenabled: false rd_geometry: nsectors: 16 sectorsize: 64 romfs_read: Read sector 3 romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 0x556e73d89be0 buffer: 0x556e73d89ca0 romfs_read: Return 1 bytes from sector offset 5 romfs_read: Read 1 bytes from offset 6 rd_geometry: Entry rd_geometry: available: true mediachanged: false writeenabled: false rd_geometry: nsectors: 16 sectorsize: 64 romfs_read: Read sector 3 romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 0x556e73d89be0 buffer: 0x556e73d89ca0 romfs_read: Return 1 bytes from sector offset 6 romfs_read: Read 1 bytes from offset 7 rd_geometry: Entry rd_geometry: available: true mediachanged: false writeenabled: false rd_geometry: nsectors: 16 sectorsize: 64 romfs_read: Read sector 3 romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 0x556e73d89be0 buffer: 0x556e73d89ca0 romfs_read: Return 1 bytes from sector offset 7 romfs_read: Read 1 bytes from offset 8 rd_geometry: Entry rd_geometry: available: true mediachanged: false writeenabled: false rd_geometry: nsectors: 16 sectorsize: 64 romfs_read: Read sector 3 romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 0x556e73d89be0 buffer: 0x556e73d89ca0 romfs_read: Return 1 bytes from sector offset 8 romfs_read: Read 1 bytes from offset 9 rd_geometry: Entry rd_geometry: available: true mediachanged: false writeenabled: false rd_geometry: nsectors: 16 sectorsize: 64 romfs_read: Read sector 3 romfs_filecacheread: sector: 3 cached: 3 sectorsize: 64 XIP base: 0x556e73d89be0 buffer: 0x556e73d89ca0 romfs_read: Return 1 bytes from sector offset 9 romfs_read: Read 1 bytes from offset 10 rd_geometry: Entry rd_geometry: available: true mediachanged: false writeenabled: false rd_geometry: nsectors: 16 sectorsize: 64 romfs_read: Read sector 3
[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #256: boards/arm/stm32h7/nucleo-h743zi: add pwm example configuration
raiden00pl opened a new pull request #256: boards/arm/stm32h7/nucleo-h743zi: add pwm example configuration URL: https://github.com/apache/incubator-nuttx/pull/256 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #210: Reimplement sim uart on top of serial driver framework
xiaoxiang781216 commented on issue #210: Reimplement sim uart on top of serial driver framework URL: https://github.com/apache/incubator-nuttx/pull/210#issuecomment-585293963 I don't meet this issue before, @yamt could you share your config? or try on Ubuntu, so we can identify where is a common issue or MacOS specific. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 merged pull request #255: IMXRT qencoder and chip Kconfig fixes
davids5 merged pull request #255: IMXRT qencoder and chip Kconfig fixes URL: https://github.com/apache/incubator-nuttx/pull/255 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #256: boards/arm/stm32h7/nucleo-h743zi: add pwm example configuration
patacongo merged pull request #256: boards/arm/stm32h7/nucleo-h743zi: add pwm example configuration URL: https://github.com/apache/incubator-nuttx/pull/256 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #274: Improve sim timer
xiaoxiang781216 opened a new pull request #274: Improve sim timer URL: https://github.com/apache/incubator-nuttx/pull/274 The change include: 1.Implment tickless mode with common code in drivers/timer 2.Sleep with the absolute time to avoid the time drift 3.Add RTC driver to make the complete date/time simulation This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #272: Sim: loadable module definitions
yamt commented on a change in pull request #272: Sim: loadable module definitions URL: https://github.com/apache/incubator-nuttx/pull/272#discussion_r379058589 ## File path: boards/sim/sim/sim/configs/cxxtest/Make.defs ## @@ -128,6 +142,7 @@ ifeq ($(CONFIG_SIM_M32),y) LDLINKFLAGS += -melf_i386 CCLINKFLAGS += -m32 LDFLAGS += -m32 + LDMODULEFLAGS += -melf_i386 Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #272: Sim: loadable module definitions
yamt commented on a change in pull request #272: Sim: loadable module
definitions
URL: https://github.com/apache/incubator-nuttx/pull/272#discussion_r379058535
##
File path: boards/sim/sim/sim/configs/cxxtest/Make.defs
##
@@ -88,10 +88,24 @@ CXXFLAGS = $(ARCHWARNINGSXX) $(ARCHOPTIMIZATION) \
CPPFLAGS = $(ARCHINCLUDES) $(ARCHDEFINES) $(EXTRADEFINES)
AFLAGS = $(CFLAGS) -D__ASSEMBLY__
+# Loadable module definitions
+
+CMODULEFLAGS = $(CFLAGS)
+# -fno-pic to avoid GOT relocations
+CMODULEFLAGS += -fno-pic
+
+LDMODULEFLAGS = -r -e module_initialize
+ifeq ($(WINTOOL),y)
+ LDMODULEFLAGS += -T "${shell cygpath -w
$(TOPDIR)/libs/libc/modlib/gnu-elf.ld}"
+else
+ LDMODULEFLAGS += -T $(TOPDIR)/libs/libc/modlib/gnu-elf.ld
+endif
# ELF module definitions
CELFFLAGS = $(CFLAGS)
+# -fno-pic to avoid GOT relocations
+CELFFLAGS += -fno-pic
CXXELFFLAGS = $(CXXFLAGS)
Review comment:
oops, fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #272: Sim: loadable module definitions
yamt commented on a change in pull request #272: Sim: loadable module
definitions
URL: https://github.com/apache/incubator-nuttx/pull/272#discussion_r379058763
##
File path: boards/sim/sim/sim/configs/nsh2/Make.defs
##
@@ -84,10 +84,24 @@ CXXFLAGS = $(ARCHWARNINGSXX) $(ARCHOPTIMIZATION)
\
CPPFLAGS = $(ARCHINCLUDES) $(ARCHDEFINES) $(EXTRADEFINES)
AFLAGS = $(CFLAGS) -D__ASSEMBLY__
+# Loadable module definitions
+
+CMODULEFLAGS = $(CFLAGS)
+# -fno-pic to avoid GOT relocations
+CMODULEFLAGS += -fno-pic
+
+LDMODULEFLAGS = -r -e module_initialize
+ifeq ($(WINTOOL),y)
+ LDMODULEFLAGS += -T "${shell cygpath -w
$(TOPDIR)/libs/libc/modlib/gnu-elf.ld}"
+else
+ LDMODULEFLAGS += -T $(TOPDIR)/libs/libc/modlib/gnu-elf.ld
+endif
# ELF module definitions
CELFFLAGS = $(CFLAGS)
+# -fno-pic to avoid GOT relocations
+CELFFLAGS += -fno-pic
CXXELFFLAGS = $(CXXFLAGS)
Review comment:
done for all three files
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #272: Sim: loadable module definitions
yamt commented on a change in pull request #272: Sim: loadable module definitions URL: https://github.com/apache/incubator-nuttx/pull/272#discussion_r379058649 ## File path: boards/sim/sim/sim/configs/nsh2/Make.defs ## @@ -120,6 +134,7 @@ ifeq ($(CONFIG_SIM_M32),y) LDLINKFLAGS += -melf_i386 CCLINKFLAGS += -m32 LDFLAGS += -m32 + LDMODULEFLAGS += -melf_i386 Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #274: Improve sim timer
yamt commented on a change in pull request #274: Improve sim timer
URL: https://github.com/apache/incubator-nuttx/pull/274#discussion_r379064231
##
File path: arch/sim/src/sim/up_rtc.c
##
@@ -0,0 +1,127 @@
+/
+ * arch/sim/src/sim/up_rtc.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+
+#include
+#include
+#include
+
+#include "up_internal.h"
+
+/
+ * Private Function Prototypes
+ /
+
+static int sim_rtc_rdtime(FAR struct rtc_lowerhalf_s *lower,
+ FAR struct rtc_time *rtctime);
+static int sim_rtc_settime(FAR struct rtc_lowerhalf_s *lower,
+ FAR const struct rtc_time *rtctime);
+static bool sim_rtc_havesettime(FAR struct rtc_lowerhalf_s *lower);
+
+/
+ * Private Data
+ /
+
+static const struct rtc_ops_s g_sim_rtc_ops =
+{
+ .rdtime = sim_rtc_rdtime,
+ .settime = sim_rtc_settime,
+ .havesettime = sim_rtc_havesettime,
+};
+
+static struct rtc_lowerhalf_s g_sim_rtc =
+{
+ .ops = _sim_rtc_ops,
+};
+
+/
+ * Private Functions
+ /
+
+static int sim_rtc_rdtime(FAR struct rtc_lowerhalf_s *lower,
+ FAR struct rtc_time *rtctime)
+{
+ uint64_t nsec;
+ time_t sec;
+
+
+ nsec = host_gettime(true);
+ sec = nsec / NSEC_PER_SEC;
+ nsec -= sec * NSEC_PER_SEC;
+
+ gmtime_r(, (FAR struct tm *)rtctime);
+ rtctime->tm_nsec = nsec;
+
+ return OK;
+}
+
+static int sim_rtc_settime(FAR struct rtc_lowerhalf_s *lower,
+ FAR const struct rtc_time *rtctime)
+{
+ uint64_t nsec;
+
+ nsec = mktime((FAR struct tm *)rtctime);
+ nsec *= NSEC_PER_SEC;
+ nsec += rtctime->tm_nsec;
+ host_settime(true, nsec);
Review comment:
does this mean the sim can modify the clock of the host os?
it's a surprising behavior for me.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] NicholasChin opened a new pull request #275: AT24 EEPROM Increase Polling Retries
NicholasChin opened a new pull request #275: AT24 EEPROM Increase Polling Retries URL: https://github.com/apache/incubator-nuttx/pull/275 I was seeing an issue with my IMXRT platform that uses an AT24 EEPROM. Driver currently polls the AT24 after a write, and knows the write is completely when the AT24 ACKS the transfer. Right now the IMXRT seems to poll the AT24 so fast that it burns through the 100 retries before the AT24 is ready to accept commands. 500 retries is the absolute max that you should need as 500 NACK'd transaction at 1MHz takes the same time as the AT24's max write time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] acassis merged pull request #273: net/netlink/netlink_route.c: Fix a typo.
acassis merged pull request #273: net/netlink/netlink_route.c: Fix a typo. URL: https://github.com/apache/incubator-nuttx/pull/273 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #360: Refine serial driver and console syslog
liuguo09 opened a new pull request #360: Refine serial driver and console syslog URL: https://github.com/apache/incubator-nuttx/pull/360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] klmchp commented on issue #353: multiple definition of `up_mdelay'
klmchp commented on issue #353: multiple definition of `up_mdelay'
URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-590076414
@patacongo @xiaoxiang781216 , also find multi definition of
up_rtc_getdatetime, up_rtc_settime and so on. I list the code from
nuttx/drivers/timers/arch_rtc.c for reference.
`int up_rtc_getdatetime(FAR struct tm *tp)
{
if (g_rtc_lower != NULL)
{
struct rtc_time rtctime;
ret = g_rtc_lower->ops->rdtime(g_rtc_lower, );
There are many the implementations of rdtime in different platform.
In arch/arm/src/stm32/stm32_rtc_lowerhalf.c
static int stm32_rdtime(FAR struct rtc_lowerhalf_s *lower,
FAR struct rtc_time *rtctime)
{
#if defined(CONFIG_RTC_DATETIME)
return **up_rtc_getdatetime**((FAR struct tm *)rtctime);
`
BR
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #353: multiple definition of `up_mdelay'
xiaoxiang781216 edited a comment on issue #353: multiple definition of `up_mdelay' URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-590082027 > > Not a whole architecture, different chipset in the same architecture can select the different approach because each chipset has own Make.defs and can include/exclude up_delay.c as needed, but the same chipset must share the same decision. > > Isn't that just an abritrary limitation? Why should implementation on any architecture have this option? Why limit it to just certain, pre-determined architectures? So you want to add an option to let user select? 1.Use up_rtc_*, up_timer_* and up_alarm_* in arch/ or 2.Use up_rtc_*, up_timer_* and up_alarm_* in drivers/timers/ There isn't difference outside the implementatin, the user get the same functionality with either selection. Actually, up_timer_/up_rtc_/up_alarm_ API is duplicated with oneshot_operations_s/rtc_ops_s/timer_ops_s and make the chipset developer write many duplication without any benefit. The best solution is: 1.Remove up_timer_, up_alarm_, up_rtc from nuttx/arch.h 2.Modify the code under sched/ to call oneshot_operations_s/rtc_ops_s/timer_ops_s instead of up_timer_, up_alarm_, up_rtc. 3.Chipset developer just need implement oneshot_operations_s/rtc_ops_s/timer_ops_s for their hardware. Basically, this approach move the code from drivers/timers/arch_* to sched/. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay'
xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay' URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-590082027 > > Not a whole architecture, different chipset in the same architecture can select the different approach because each chipset has own Make.defs and can include/exclude up_delay.c as needed, but the same chipset must share the same decision. > > Isn't that just an abritrary limitation? Why should implementation on any architecture have this option? Why limit it to just certain, pre-determined architectures? So you want to add an option to let user select? 1.Use up_rtc_*, up_timer_* and up_alarm_* in arch/ or 2.Use up_rtc_*, up_timer_* and up_alarm_* in drivers/timers/ There isn't difference outside the implementatin, the user get the same functionality with either selection. Actually, up_timer_/up_rtc_/up_alarm_ API is duplicated with oneshot_operations_s/rtc_ops_s/timer_ops_s and make the chpset developer write many duplication without any benefit. The best solution is: 1.Remove up_timer_, up_alarm_, up_rtc from nuttx/arch.h 2.Modify the code under sched/ to call oneshot_operations_s/rtc_ops_s/timer_ops_s instead of up_timer_, up_alarm_, up_rtc. 3.Developer just need implement oneshot_operations_s/rtc_ops_s/timer_ops_s for their hardware This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #353: multiple definition of `up_mdelay'
patacongo commented on issue #353: multiple definition of `up_mdelay' URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-590079793 > Not a whole architecture, different chipset in the same architecture can select the different approach because each chipset has own Make.defs and can include/exclude up_delay.c as needed, but the same chipset must share the same decision. Isn't that just an abritrary limitation? Why should implementation on any architecture have this option? Why limit it to just certain, pre-determined architectures? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #90: Run codespell -w with the latest dictonary again
xiaoxiang781216 opened a new pull request #90: Run codespell -w with the latest dictonary again URL: https://github.com/apache/incubator-nuttx-apps/pull/90 Signed-off-by: Xiang Xiao This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay'
xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay' URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-590074752 Not a whole architecture, different chipset in the same architecture can select the different approach because each chipset has own Make.defs and can include/exclude up_delay.c as needed, but the same chipset must share the same decision. The code under drivers/timers/arch_*.c just want to simplify the chipset developer work, supporting both approach just make their work hard than before without any benefit. So I don't think the last issue is a real limitation, the developer just need decide which method he want to use and forget another one totally before writing the code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-apps] patacongo opened a new pull request #91: apps/platform/.gitignore: Add ZDS-II temp files.
patacongo opened a new pull request #91: apps/platform/.gitignore: Add ZDS-II temp files. URL: https://github.com/apache/incubator-nuttx-apps/pull/91 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #360: Refine serial driver and console syslog
patacongo merged pull request #360: Refine serial driver and console syslog URL: https://github.com/apache/incubator-nuttx/pull/360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay'
xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay' URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-590087053 Ok, maybe it is better to change CONFIG_ARCH_[TIMER|RTC|ALARM] to CONFIG_ARCH_HAVE_[TIMER|RTC|ALARM] without prompt string, than each chipset could select these option from Kconfig base on their implementation decision. So it is impossible to make the wrong selection from defconfig. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #91: apps/platform/.gitignore: Add ZDS-II temp files.
xiaoxiang781216 merged pull request #91: apps/platform/.gitignore: Add ZDS-II temp files. URL: https://github.com/apache/incubator-nuttx-apps/pull/91 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #359: tools/zds/zdsar.c: Correct memory corruption bug
Ouss4 merged pull request #359: tools/zds/zdsar.c: Correct memory corruption bug URL: https://github.com/apache/incubator-nuttx/pull/359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-apps] patacongo merged pull request #90: Run codespell -w with the latest dictonary again
patacongo merged pull request #90: Run codespell -w with the latest dictonary again URL: https://github.com/apache/incubator-nuttx-apps/pull/90 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay'
xiaoxiang781216 commented on issue #353: multiple definition of `up_mdelay'
URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-590080225
> @patacongo @xiaoxiang781216 , also find multi definition of
up_rtc_getdatetime, up_rtc_settime and so on. I list the code from
nuttx/drivers/timers/arch_rtc.c for reference.
> `int up_rtc_getdatetime(FAR struct tm *tp)
> {
> if (g_rtc_lower != NULL)
> {
> struct rtc_time rtctime;
>
> ```
> ret = g_rtc_lower->ops->rdtime(g_rtc_lower, );
> ```
>
> There are many the implementations of rdtime in different platform.
> In arch/arm/src/stm32/stm32_rtc_lowerhalf.c
>
> static int stm32_rdtime(FAR struct rtc_lowerhalf_s *lower,
> FAR struct rtc_time *rtctime)
> {
> #if defined(CONFIG_RTC_DATETIME)
> return **up_rtc_getdatetime**((FAR struct tm *)rtctime);
> `
> BR
Yes, all code inside drivers/timer/arch_*.c is to implement up_timer_
up_rtc_ on top of timer/oneshot/rtc driver interface. As I said before, if you
want to use these files:
1.Remove up_rtc and up_timer_ up_alarm_ from your chipset
2.Implement the standard timer/oneshot/rtc driver interface
3.Let these file implement these function for you
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #353: multiple definition of `up_mdelay'
patacongo commented on issue #353: multiple definition of `up_mdelay' URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-590084312 > So you want to add an option to let user select? If they option is available to use, it should be safe and correct for them to select it and it should work correctly. If they are not supposed to select the option, then it should be disabled. So either every architecture that does not support the drivers/timer/arch_* drivers should disable those options, or the architectures should permit the user to select them without anything bad happening. That is simply a matter of making sure that the configuration options all work as advertised. It is make the configuration usable. It is not usable if you don't know if an option is available or not. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #353: multiple definition of `up_mdelay'
patacongo commented on issue #353: multiple definition of `up_mdelay' URL: https://github.com/apache/incubator-nuttx/issues/353#issuecomment-590072641 > 1.Remove up_delay.c from your chipset Make.defs directly > 2.Enable CONFIG_ALARM_ARCH in your defconfig That is not a good solution. The means that the configuration is not an option. Either an architecture must always have CONFIG_ALARM_ARCH and never build up_*delay.c; or it must never have CONFIG_ALARM_ARCH and always build up_*dealy.c. That is not very flexible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-apps] liuguo09 opened a new pull request #93: Remove the additional UNLINKDIR to fix parallel build break
liuguo09 opened a new pull request #93: Remove the additional UNLINKDIR to fix parallel build break URL: https://github.com/apache/incubator-nuttx-apps/pull/93 Remove the additional unlink to fix errors in parallel build as below. cc1: fatal error: ./board/dummy.c: No such file or directory Signed-off-by: liuhaitao This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #368: ZDS-II Object file relocations
patacongo opened a new pull request #368: ZDS-II Object file relocations URL: https://github.com/apache/incubator-nuttx/pull/368 tools/zds/zdsgen.c: Remove this program. It should have been a simpler way to manage ZDS-II compiler and assember differences. However, the compiler arguments needed to pass through too many layers of bash command line modifications and, as a result, it was not possible to retain quotes on critical strings. This approch was abandoned for an alternative approach. boards/z80/ez80/scripts/eZ80_Config.mk: Add definitions to move the object files as necessary. This seems to work well and is implemented for both native and Cygwin Windows build -- but only for the Z20x. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] acassis merged pull request #368: ZDS-II Object file relocations
acassis merged pull request #368: ZDS-II Object file relocations URL: https://github.com/apache/incubator-nuttx/pull/368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends
xiaoxiang781216 commented on issue #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends URL: https://github.com/apache/incubator-nuttx/pull/372#issuecomment-590931183 > @patacongo @Ouss4 I will run nxstyle and fix the problems and redo the code. Is there a guide to compiling and running nxstyle? Would you be willing to point me at it? run tools/checkpatch.sh, which will compile the tools for you. You can pass -h to get the usage. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on issue #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends
adamfeuer commented on issue #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends URL: https://github.com/apache/incubator-nuttx/pull/372#issuecomment-590946294 @xiaoxiang781216 Thanks, I will do that! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #379: armv7-m: Fix syscall stack alignment
patacongo merged pull request #379: armv7-m: Fix syscall stack alignment URL: https://github.com/apache/incubator-nuttx/pull/379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #100: Revert "examples: usrsocktest: Fix errors in NoBlockRecv and BlockRec…
xiaoxiang781216 opened a new pull request #100: Revert "examples: usrsocktest: Fix errors in NoBlockRecv and BlockRec… URL: https://github.com/apache/incubator-nuttx-apps/pull/100 …v tests" This reverts commit 10c715d9215a7fbc6bc5000f10169c128af11854. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #100: Revert "examples: usrsocktest: Fix errors in NoBlockRecv and BlockRec…
xiaoxiang781216 commented on issue #100: Revert "examples: usrsocktest: Fix errors in NoBlockRecv and BlockRec… URL: https://github.com/apache/incubator-nuttx-apps/pull/100#issuecomment-590936787 After these patch in nuttx: https://github.com/apache/incubator-nuttx/pull/378 https://github.com/apache/incubator-nuttx/pull/377 We don't need the workaround anymore. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #370: net: socket: Introduce net_clear_sinzero()
patacongo commented on issue #370: net: socket: Introduce net_clear_sinzero() URL: https://github.com/apache/incubator-nuttx/pull/370#issuecomment-590961398 > But as long as I checked Linux kernel, it clears in the network stack. Ignorinig the read-only 'const' would be a violation of C principles. We should not do that. I think it would be legal to test if sin_zero is all zero and, if not, return an error. That is correct, but would probably annoy a lot of people. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
