[GitHub] [pulsar-site] BewareMyPower opened a new pull request, #578: Add release notes for C++ client 3.2.0
BewareMyPower opened a new pull request, #578: URL: https://github.com/apache/pulsar-site/pull/578 - [x] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete`   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-site] 01/01: Add release notes for C++ client 3.2.0
This is an automated email from the ASF dual-hosted git repository.
xyz pushed a commit to branch bewaremypower/cpp-3.2.0-release-note
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
commit c6aff3fd1fcc96022b53384f8d52fef2e4ee3502
Author: Yunze Xu
AuthorDate: Tue May 16 12:01:43 2023 +0800
Add release notes for C++ client 3.2.0
---
data/release-cpp.js | 1 +
release-notes/versioned/client-cpp-3.2.0.md | 106
2 files changed, 107 insertions(+)
diff --git a/data/release-cpp.js b/data/release-cpp.js
index 557e497d802..f4c33055f1b 100644
--- a/data/release-cpp.js
+++ b/data/release-cpp.js
@@ -1,4 +1,5 @@
module.exports = [
+{tagName:
"v3.2.0",vtag:"3.2.x",releaseNotes:"/release-notes/versioned/client-cpp-3.2.0/",doc:"/docs/client-libraries-cpp",version:"v3.2.x"},
{tagName:
"v3.1.2",vtag:"3.1.x",releaseNotes:"/release-notes/versioned/client-cpp-3.1.2/",doc:"/docs/client-libraries-cpp",version:"v3.1.x"},
{tagName:
"v3.1.1",vtag:"3.1.x",releaseNotes:"/release-notes/versioned/client-cpp-3.1.1/",doc:"/docs/client-libraries-cpp",version:""},
{tagName:
"v3.1.0",vtag:"3.1.x",releaseNotes:"/release-notes/versioned/client-cpp-3.1.0/",doc:"/docs/client-libraries-cpp",version:""},
diff --git a/release-notes/versioned/client-cpp-3.2.0.md
b/release-notes/versioned/client-cpp-3.2.0.md
new file mode 100644
index 000..a2ccd98cf31
--- /dev/null
+++ b/release-notes/versioned/client-cpp-3.2.0.md
@@ -0,0 +1,106 @@
+---
+id: client-cpp-3.2.0
+title: Client CPP 3.2.0
+sidebar_label: Client CPP 3.2.0
+---
+
+## What's Changed
+* Fix segmentation fault during the destruction of ConsumerImpl by
@BewareMyPower in https://github.com/apache/pulsar-client-cpp/pull/121
+* [improve] Exclude debug artifact in the release and tar the windows
artifacts by @RobertIndie in
https://github.com/apache/pulsar-client-cpp/pull/124
+* [fix] Fix NamedEntity::checkName regression by @erobot in
https://github.com/apache/pulsar-client-cpp/pull/127
+* [fix] Fix PartitionedProducerImpl::closeAsync to close sub-producers
properly by @erobot in https://github.com/apache/pulsar-client-cpp/pull/125
+* [fix] Fix acknowledge MessageId list does not work when ackGroupingTimeMs is
0 by @BewareMyPower in https://github.com/apache/pulsar-client-cpp/pull/128
+* Fix the broken master by the upgrade of GTest by @BewareMyPower in
https://github.com/apache/pulsar-client-cpp/pull/133
+* [fix] Close broker producer created after producer close by @erobot in
https://github.com/apache/pulsar-client-cpp/pull/131
+* [fix] Fix a crash when closing a connection while connecting by @erobot in
https://github.com/apache/pulsar-client-cpp/pull/136
+* Boost optional by @fregate in
https://github.com/apache/pulsar-client-cpp/pull/138
+* Add BatchedMessageIdImpl to acknowledge batched messages by @BewareMyPower
in https://github.com/apache/pulsar-client-cpp/pull/132
+* Bumped version to 3.2.0-pre by @RobertIndie in
https://github.com/apache/pulsar-client-cpp/pull/141
+* [fix] Use sudo when executing `apt-get install` by @RobertIndie in
https://github.com/apache/pulsar-client-cpp/pull/143
+* [fix][doc] CMake is added to the Homebrew Mac Installation list by @erichare
in https://github.com/apache/pulsar-client-cpp/pull/145
+* [fix] Use authoritative argument correctly in
BinaryProtoLookupService::findBroker by @erobot in
https://github.com/apache/pulsar-client-cpp/pull/146
+* [feat] PIP 107: Introduce chunk message ID by @RobertIndie in
https://github.com/apache/pulsar-client-cpp/pull/148
+* [fix] Fix `auxv` detection by @AtkinsChang in
https://github.com/apache/pulsar-client-cpp/pull/152
+* [fix][build] Hide non-exported symbols from the dependencies by
@BewareMyPower in https://github.com/apache/pulsar-client-cpp/pull/155
+* Format .c suffix file. by @shibd in
https://github.com/apache/pulsar-client-cpp/pull/159
+* [fix] Fix MessageId serialization when it's a batched message by
@BewareMyPower in https://github.com/apache/pulsar-client-cpp/pull/153
+* [fix] Fix log for connection disconnected expectedly by @RobertIndie in
https://github.com/apache/pulsar-client-cpp/pull/156
+* The C API supports setting the log level. by @shibd in
https://github.com/apache/pulsar-client-cpp/pull/158
+* [feat] Add pulsar_logger_t as the configurable C logger by @BewareMyPower in
https://github.com/apache/pulsar-client-cpp/pull/162
+* [feat] Support messages with generic types by @BewareMyPower in
https://github.com/apache/pulsar-client-cpp/pull/149
+* Fix segfault caused by socket I/O on a closed io_service by @BewareMyPower
in https://github.com/apache/pulsar-client-cpp/pull/168
+* [fix] Fix missing schema related function definitions by @romainbrancourt in
https://github.com/apache/pulsar-client-cpp/pull/171
+* [feat] Support batch index acknowledgment by @BewareMyPower in
https://github.com/apache/pulsar-client-cpp/pull/151
+* [fix] Fix hostname verification by @izumo27 in
[pulsar-site] branch bewaremypower/cpp-3.2.0-release-note created (now c6aff3fd1fc)
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch bewaremypower/cpp-3.2.0-release-note in repository https://gitbox.apache.org/repos/asf/pulsar-site.git at c6aff3fd1fc Add release notes for C++ client 3.2.0 This branch includes the following new commits: new c6aff3fd1fc Add release notes for C++ client 3.2.0 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [pulsar] JooHyukKim commented on a diff in pull request #20284: [improve][client] Document Java Client's Seek logic thread-safety improved in #20242
JooHyukKim commented on code in PR #20284:
URL: https://github.com/apache/pulsar/pull/20284#discussion_r1194579051
##
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java:
##
@@ -523,11 +523,17 @@ CompletableFuture
reconsumeLaterCumulativeAsync(Message message,
/**
* The asynchronous version of {@link Consumer#seek(MessageId)}.
+ *
+ * If there is already a seek operation in progress, the method will log a
warning and
+ * return a future completed exceptionally.
Review Comment:
> It's probably worth documenting on the `seek` methods too.
Right, it makes sense to do so. Thank you for pointing out! Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on a diff in pull request #20284: [improve][client] Document Java Client's Seek logic thread-safety improved in #20242
JooHyukKim commented on code in PR #20284:
URL: https://github.com/apache/pulsar/pull/20284#discussion_r1194579051
##
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java:
##
@@ -523,11 +523,17 @@ CompletableFuture
reconsumeLaterCumulativeAsync(Message message,
/**
* The asynchronous version of {@link Consumer#seek(MessageId)}.
+ *
+ * If there is already a seek operation in progress, the method will log a
warning and
+ * return a future completed exceptionally.
Review Comment:
> It's probably worth documenting on the `seek` methods too.
Right, it makes sense to do so. Thank you for pointing out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] liangyepianzhou opened a new pull request, #20330: [optimize][admin]Enhancing Transaction Buffer Stats and Introducing TransactionBufferInternalStats API
liangyepianzhou opened a new pull request, #20330: URL: https://github.com/apache/pulsar/pull/20330 master https://github.com/apache/pulsar/issues/20291 ### Motivation Our primary goal is to improve the visibility and troubleshooting capabilities of the Pulsar Transaction Buffer by providing more detailed information about the snapshot stats and system topic internal status. ### Modifications 1. Enhance the existing TransactionBufferStats by adding information about snapshot stats, including the capital of the current segment, unseal aborted transaction ID size, and other related data. This will provide better visibility and troubleshooting capabilities for the Pulsar Transaction Buffer. 2. Introduce a new API for obtaining TransactionBufferInternalStats, allowing users to access the state of the system topic used for storing snapshots. This will facilitate problem investigation and resolution when issues arise with the transaction buffer. ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [x] The REST endpoints - [x] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [x] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] daziz commented on pull request #20329: correcting spelling mistakes
daziz commented on PR #20329: URL: https://github.com/apache/pulsar/pull/20329#issuecomment-1548934885 - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] daziz commented on pull request #20329: correcting spelling mistakes
daziz commented on PR #20329: URL: https://github.com/apache/pulsar/pull/20329#issuecomment-1548934179 - [ ] `doc` - [ ] `doc-required` - [√ ] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower opened a new issue, #270: [Bug] c_ConsumerTest.testBatchReceive failed
BewareMyPower opened a new issue, #270: URL: https://github.com/apache/pulsar-client-cpp/issues/270 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar-client-cpp/issues) and found nothing similar. ### Version - Pulsar: 2.11.0 - Client: v3.2.0 ### Minimal reproduce step Build the tests and run: ```bash ./tests/pulsar-tests --gtest_filter='c_ConsumerTest.testBatchReceive' ``` ### What did you expect to see? The test should succeed ### What did you see instead? ``` /home/xyz/github.com/apache/pulsar-client-cpp/tests/c/c_ConsumerTest.cc:114: Failure Expected equality of these values: pulsar_result_Ok Which is: 0 receive_future.get() Which is: 15 ``` ### Anything else? _No response_ ### Are you willing to submit a PR? - [X] I'm willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on a diff in pull request #18620: [fix][broker] If ledger lost, cursor mark delete position can not forward
poorbarcode commented on code in PR #18620:
URL: https://github.com/apache/pulsar/pull/18620#discussion_r1194569568
##
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##
@@ -480,7 +482,24 @@ public void operationComplete(ManagedCursorInfo info, Stat
stat) {
// Need to proceed and read the last entry in the
specified ledger to find out the last position
log.info("[{}] Consumer {} meta-data recover from ledger
{}", ledger.getName(), name,
info.getCursorsLedgerId());
-recoverFromLedger(info, callback);
+recoverFromLedger(info, new VoidCallback() {
+@Override
+public void operationComplete() {
+LinkedHashSet ledgersDeletedButNotAcked =
checkLedgersDeletedButNotAcked();
Review Comment:
these codes have been removed(This PR no longer call the checks when cursor
is initializing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #20325: [improve][misc] Enable rebase and merge to handle one PR of multiple semantic commits
michaeljmarshall commented on code in PR #20325: URL: https://github.com/apache/pulsar/pull/20325#discussion_r1194569541 ## .asf.yaml: ## @@ -35,12 +35,9 @@ github: # Enable projects for project management boards projects: true enabled_merge_buttons: -# enable squash button: squash: true -# disable merge button: merge: false -# disable rebase button: -rebase: false +rebase: true Review Comment: Thanks @tisonkun. I agree with putting it in that section. A committer guide would be valuable--I don't think we have one though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #20284: [improve][client] Document Java Client's Seek logic thread-safety improved in #20242
michaeljmarshall commented on code in PR #20284:
URL: https://github.com/apache/pulsar/pull/20284#discussion_r1194569092
##
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java:
##
@@ -523,11 +523,17 @@ CompletableFuture
reconsumeLaterCumulativeAsync(Message message,
/**
* The asynchronous version of {@link Consumer#seek(MessageId)}.
+ *
+ * If there is already a seek operation in progress, the method will log a
warning and
+ * return a future completed exceptionally.
Review Comment:
It's probably worth documenting on the `seek` methods too. If a user were to
share a consumer's reference in two threads, it could lead to the same error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #20329: correcting spelling mistakes
github-actions[bot] commented on PR #20329: URL: https://github.com/apache/pulsar/pull/20329#issuecomment-1548926559 @daziz Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] daziz opened a new pull request, #20329: correcting spelling mistakes
daziz opened a new pull request, #20329: URL: https://github.com/apache/pulsar/pull/20329 [Improves] correcting spelling mistakes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] KMoonSC opened a new issue, #20328: [Bug] Fail to get custom properties in org.apache.pulsar.broker.intercept.BrokerInterceptor#beforeSendMessage
KMoonSC opened a new issue, #20328:
URL: https://github.com/apache/pulsar/issues/20328
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### Version
2.10.4
### Minimal reproduce step
1、 create a **BrokerInterceptor**, implement method **beforeSendMessage**,
intend to get properties witch have been set to the message when produced
```
@Override
public void beforeSendMessage(Subscription subscription, Entry entry,
long[] ackSet, MessageMetadata msgMetadata) {
List keyValues = msgMetadata.getPropertiesList();
for (KeyValue keyValue : keyValues) {
logger.info("LogBrokerInterceptor beforeSendMessage. properties.
key:{} value:{}", keyValue.getKey(), keyValue.getValue());
}
logger.info("LogBrokerInterceptor beforeSendMessage.
propertiesCount:{}", msgMetadata.getPropertiesCount());
}
```
2、mvn package, move the .nar file to./interceptors
3、start pulsar
4、create a consumer to receive message on topic "public/default/my-topic"
```
PulsarClient client = PulsarClient.builder()
.serviceUrl("pulsar://localhost:6650")
.build();
Consumer consumer =
client.newConsumer().topic("public/default/my-topic").subscriptionName("local-sub").subscribe();
do {
tr
```y {
Message message = consumer.receive();
System.out.println("---");
System.out.println("Message received. messageId:" +
message.getMessageId().toString() + ",data:" + new String(message.getData()) +
",publishTime="
+ message.getPublishTime() + ",receive time=" +
System.currentTimeMillis() + ",properties=" +
JSON.toJSONString(message.getProperties()));
Thread.sleep(2000);
consumer.acknowledge(message);
System.out.println("Message acknowledged. messageId::" +
message.getMessageId().toString() + ",data:" + new String(message.getData()) +
",publishTime="
+ message.getPublishTime() + ",acknowledged time=" +
System.currentTimeMillis());
} catch (Throwable t) {
logger.error("error:", t);
}
} while (true);
5、produce a message with a property to topic "public/default/my-topic"
```
PulsarClient client = PulsarClient.builder()
.serviceUrl("pulsar://localhost:6650")
.build();
Producer producer = client.newProducer()
.topic("public/default/my-topic")
.create();
Map properties = new HashMap<>();
properties.put("clientId", "clientId123");
producer.newMessage()
.properties(properties)
.value("data1234".getBytes())
.send();
```
### What did you expect to see?
log:
LogBrokerInterceptor beforeSendMessage. properties. key:clientId
value:clientId123
LogBrokerInterceptor beforeSendMessage. propertiesCount:1
### What did you see instead?
log:
LogBrokerInterceptor beforeSendMessage. propertiesCount:0
### Anything else?
I am not sure if I use the right way, if not, please tell me how to get the
custom properties by BrokerInterceptor
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #20292: [feat][broker] introduce precise broker publish rate limiting
lordcheng10 commented on code in PR #20292:
URL: https://github.com/apache/pulsar/pull/20292#discussion_r1194562212
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java:
##
@@ -1116,6 +1116,12 @@ public boolean isBrokerPublishRateExceeded() {
return getBrokerPublishRateLimiter().isPublishRateExceeded();
}
+public boolean isBrokerPublishRateExceeded(int numberMessages, int bytes) {
+// whether broker publish rate exceed
+return preciseTopicPublishRateLimitingEnable
Review Comment:
fixed.
add config preciseBrokerPublishRateLimiterEnable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on a diff in pull request #18620: [fix][broker] If ledger lost, cursor mark delete position can not forward
poorbarcode commented on code in PR #18620:
URL: https://github.com/apache/pulsar/pull/18620#discussion_r1194560920
##
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##
@@ -2661,6 +2708,34 @@ void setReadPosition(Position newReadPositionInt) {
}
}
+void clearIncompleteAckedRecordsByLedgerId(final long ledgerId){
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on a diff in pull request #18620: [fix][broker] If ledger lost, cursor mark delete position can not forward
poorbarcode commented on code in PR #18620:
URL: https://github.com/apache/pulsar/pull/18620#discussion_r1194560654
##
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java:
##
@@ -117,6 +119,9 @@ public void readEntriesFailed(ManagedLedgerException
exception, Object ctx) {
return;
}
updateReadPosition(nexReadPosition);
+if (lostLedger != null) {
+clearIncompleteAckedRecordsFromLedger(lostLedger);
Review Comment:
fixed
##
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##
@@ -1729,6 +1729,18 @@ synchronized void ledgerClosed(final LedgerHandle lh) {
}
}
+@Override
+public void removeNonRecoverableLedger(long ledgerId){
+ledgers.remove(ledgerId);
+Iterator managedCursorIterator = cursors.iterator();
+while (managedCursorIterator.hasNext()){
+ManagedCursor managedCursor = managedCursorIterator.next();
+if (managedCursor instanceof ManagedCursorImpl managedCursorImpl){
+
managedCursorImpl.clearIncompleteAckedRecordsByLedgerId(ledgerId);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-site] BewareMyPower opened a new pull request, #577: Generate C++ client 3.2.0 doc
BewareMyPower opened a new pull request, #577: URL: https://github.com/apache/pulsar-site/pull/577  - [x] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-site] branch gen-cpp-apidoc created (now 488931d8331)
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch gen-cpp-apidoc in repository https://gitbox.apache.org/repos/asf/pulsar-site.git at 488931d8331 Generate C++ client 3.2.0 doc This branch includes the following new commits: new 488931d8331 Generate C++ client 3.2.0 doc The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[pulsar-client-cpp] branch main updated: Support specifying the C++ standard for some higher dependencies (#269)
This is an automated email from the ASF dual-hosted git repository.
xyz pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git
The following commit(s) were added to refs/heads/main by this push:
new 191a6b4 Support specifying the C++ standard for some higher
dependencies (#269)
191a6b4 is described below
commit 191a6b4a9484aadce0b00b4fb75b104e0d371d7a
Author: Yunze Xu
AuthorDate: Tue May 16 10:59:03 2023 +0800
Support specifying the C++ standard for some higher dependencies (#269)
Fixes https://github.com/apache/pulsar-client-cpp/issues/268
### Motivation
When users build from source with a dependency that requires a higher
C++ version than 11, it will fail because currently the C++ standard is
pinned to 11. For example, the latest GTest requires C++14 now. So
currently there is no way to build the tests except modifying the
CMakeLists.txt file.
### Modifications
Make `CMAKE_CXX_STANDARD` configurable and test it for the macOS
workflow because the `gtest` dependency installed from `brew` requires
C++14. Add the description into the README for it.
---
.github/workflows/ci-pr-validation.yaml | 5 +++--
CMakeLists.txt | 4 +++-
README.md | 6 ++
3 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/ci-pr-validation.yaml
b/.github/workflows/ci-pr-validation.yaml
index a736bb6..259a277 100644
--- a/.github/workflows/ci-pr-validation.yaml
+++ b/.github/workflows/ci-pr-validation.yaml
@@ -267,14 +267,15 @@ jobs:
uses: actions/checkout@v3
- name: Install dependencies
-run: brew install openssl protobuf boost zstd snappy
+run: brew install openssl protobuf boost zstd snappy googletest
- name: Configure (default)
shell: bash
run: |
+ # The latest GTest requires C++14
cmake \
-B ./build-macos \
- -DBUILD_TESTS=OFF \
+ -DCMAKE_CXX_STANDARD=14 \
-S .
- name: Compile
diff --git a/CMakeLists.txt b/CMakeLists.txt
index a8f56aa..dedea25 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -88,7 +88,9 @@ find_package(Threads REQUIRED)
MESSAGE(STATUS "Threads library: " ${CMAKE_THREAD_LIBS_INIT})
set(Boost_NO_BOOST_CMAKE ON)
-set(CMAKE_CXX_STANDARD 11)
+if (NOT CMAKE_CXX_STANDARD)
+set(CMAKE_CXX_STANDARD 11)
+endif ()
set(CMAKE_C_STANDARD 11)
# Compiler specific configuration:
diff --git a/README.md b/README.md
index 6c0547b..208c4e9 100644
--- a/README.md
+++ b/README.md
@@ -55,6 +55,12 @@ If you want to build and run the tests, you need to install
[GTest](https://gith
If you want to use `ClientConfiguration::setLogConfFilePath`, you need to
install the [Log4CXX](https://logging.apache.org/log4cxx) and add CMake option
`-DUSE_LOG4CXX=ON`.
+The [dependencies.yaml](./dependencies.yaml) file provides the recommended
dependency versions, while you can still build from source with other
dependency versions. If a dependency requires a higher C++ standard, e.g.
C++14, you can specify the standard like:
+
+```bash
+cmake . -DCMAKE_CXX_STANDARD=14
+```
+
## Platforms
Pulsar C++ Client Library has been tested on:
[GitHub] [pulsar-client-cpp] BewareMyPower closed issue #268: [Bug] C++ versions less than C++14 are not supported.
BewareMyPower closed issue #268: [Bug] C++ versions less than C++14 are not supported. URL: https://github.com/apache/pulsar-client-cpp/issues/268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #269: Support specifying the C++ standard for some higher dependencies
BewareMyPower merged PR #269: URL: https://github.com/apache/pulsar-client-cpp/pull/269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #269: Support specifying the C++ standard for some higher dependencies
BewareMyPower commented on PR #269: URL: https://github.com/apache/pulsar-client-cpp/pull/269#issuecomment-1548897805 > another way is pinning the version of gtest Yes. But for most C++ developers, it's still much easier to install the binary dependencies via the default package manager on Linux and macOS The `FetchContent` feature of CMake just downloads the source code. It still needs to build and install the dependencies. And as you can see we still need to pay some extra efforts to it: https://github.com/apache/incubator-kvrocks/blob/75db3e42df8a715339abaf02d640f3c62d43304a/cmake/utils.cmake Actually, we can achieve this goal via Vcpkg as well. Vcpkg can specify dependency versions. See example here: https://github.com/apache/pulsar-client-python/pull/23/files#diff-e62a7794d36dac6a2bbd197522dfe4d80d8d77f2e54e4772271e14e0103829e1 But still, for development, installing binaries directly will be much easier unless the dependencies are depended by source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20303: [fix] [meta]Switch to the metadata store thread after zk operation
poorbarcode commented on code in PR #20303:
URL: https://github.com/apache/pulsar/pull/20303#discussion_r1194546785
##
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataStoreTest.java:
##
@@ -425,6 +428,75 @@ public void testDeleteUnusedDirectories(String provider,
Supplier urlSup
assertFalse(store.exists(prefix).join());
}
+@DataProvider(name = "conditionOfSwitchThread")
+public Object[][] conditionOfSwitchThread(){
+return new Object[][]{
+{false, false},
+{false, true},
+{true, false},
+{true, true}
+};
+}
+
+@Test(dataProvider = "conditionOfSwitchThread")
+public void testThreadSwitchOfZkMetadataStore(boolean hasSynchronizer,
boolean enabledBatch) throws Exception {
+final String prefix = newKey();
+final String metadataStoreName =
UUID.randomUUID().toString().replaceAll("-", "");
+MetadataStoreConfig.MetadataStoreConfigBuilder builder =
+
MetadataStoreConfig.builder().metadataStoreName(metadataStoreName);
+builder.fsyncEnable(false);
+builder.batchingEnabled(enabledBatch);
+if (!hasSynchronizer) {
+builder.synchronizer(null);
+}
+MetadataStoreConfig config = builder.build();
+@Cleanup
+ZKMetadataStore store = (ZKMetadataStore)
MetadataStoreFactory.create(zks.getConnectionString(), config);
+
+final Runnable verify = () -> {
+String currentThreadName = Thread.currentThread().getName();
+String errorMessage = String.format("Expect to switch to thread
%s, but currently it is thread %s",
+metadataStoreName, currentThreadName);
+if
(!Thread.currentThread().getName().startsWith(metadataStoreName)){
Review Comment:
> Did you forget to push for this change?
Yes, you are right. Fixed, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-client-cpp] tisonkun commented on pull request #269: Support specifying the C++ standard for some higher dependencies
tisonkun commented on PR #269: URL: https://github.com/apache/pulsar-client-cpp/pull/269#issuecomment-1548886456 For reference - another way is pinning the version of gtest, like [gtest.cmake in Kvrocks](https://github.com/apache/incubator-kvrocks/blob/75db3e42df8a715339abaf02d640f3c62d43304a/cmake/gtest.cmake). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-cpp] tisonkun commented on a diff in pull request #269: Support specifying the C++ standard for some higher dependencies
tisonkun commented on code in PR #269:
URL: https://github.com/apache/pulsar-client-cpp/pull/269#discussion_r1194540048
##
CMakeLists.txt:
##
@@ -88,7 +88,9 @@ find_package(Threads REQUIRED)
MESSAGE(STATUS "Threads library: " ${CMAKE_THREAD_LIBS_INIT})
set(Boost_NO_BOOST_CMAKE ON)
-set(CMAKE_CXX_STANDARD 11)
+if (NOT CMAKE_CXX_STANDARD)
+set(CMAKE_CXX_STANDARD 11)
+endif ()
set(CMAKE_C_STANDARD 11)
Review Comment:
Thanks for your explanation! That sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #269: Support specifying the C++ standard for some higher dependencies
BewareMyPower commented on code in PR #269:
URL: https://github.com/apache/pulsar-client-cpp/pull/269#discussion_r1194539664
##
CMakeLists.txt:
##
@@ -88,7 +88,9 @@ find_package(Threads REQUIRED)
MESSAGE(STATUS "Threads library: " ${CMAKE_THREAD_LIBS_INIT})
set(Boost_NO_BOOST_CMAKE ON)
-set(CMAKE_CXX_STANDARD 11)
+if (NOT CMAKE_CXX_STANDARD)
+set(CMAKE_CXX_STANDARD 11)
+endif ()
set(CMAKE_C_STANDARD 11)
Review Comment:
No. The C standard is only applied to
- The C headers (`*.h` files) under
https://github.com/apache/pulsar-client-cpp/tree/main/include/pulsar/c
- The C examples, i.e. the `*.c` files under
https://github.com/apache/pulsar-client-cpp/tree/main/examples
They are never affected by any external dependency.
We should still stick to the C++11 and C11 standard for this project, but we
cannot avoid the minimum standard version requirements from external C++
dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #560: PIP-249 site redesign
tisonkun commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1548884427 > I assume, the next builds should take much less time? This is another tech debt that we maintain too much versions and to build them at once exhaust GitHub Actions Runner memory so we use [`split-version-build.sh`](https://github.com/apache/pulsar-site/blob/22081daf8095676f897a0224351e6116d7d0d183/scripts/split-version-build.sh) to build changed versions one by one. If only a few versions touched, it can be much faster. Ideally, legacy versions should be archived as a snapshot, which can be another improvement proposal to work on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] shibd commented on a diff in pull request #565: Add CPP client table view doc.
shibd commented on code in PR #565:
URL: https://github.com/apache/pulsar-site/pull/565#discussion_r1194535306
##
docs/client-libraries-tableviews.md:
##
@@ -4,36 +4,106 @@ title: Work with TableView
sidebar_label: "Work with TableView"
---
+mdx-code-block
+import Tabs from '@theme/Tabs';
+import TabItem from '@theme/TabItem';
+
+
After setting up your clients, you can explore more to start working with
[TableView](concepts-clients.md#tableview).
## Configure TableView
-The following is an example of how to configure a TableView.
-```java
-TableView tv = client.newTableViewBuilder(Schema.STRING)
- .topic("my-tableview")
- .create()
-```
+mdx-code-block
+
+
+
+ The following is an example of how to configure a TableView.
+
+ ```java
+TableView tv = client.newTableViewBuilder(Schema.STRING)
+.topic("my-tableview")
+.create()
+ ```
+
+You can use the available parameters in the `loadConf` configuration or the
API
[`TableViewBuilder`](/api/client/@pulsar:version_number@/org/apache/pulsar/client/api/TableViewBuilder.html)
to customize your TableView.
Review Comment:
Thanks, I test it, and it can work.
##
docs/client-libraries-tableviews.md:
##
@@ -4,36 +4,106 @@ title: Work with TableView
sidebar_label: "Work with TableView"
---
+mdx-code-block
+import Tabs from '@theme/Tabs';
+import TabItem from '@theme/TabItem';
+
+
After setting up your clients, you can explore more to start working with
[TableView](concepts-clients.md#tableview).
## Configure TableView
-The following is an example of how to configure a TableView.
-```java
-TableView tv = client.newTableViewBuilder(Schema.STRING)
- .topic("my-tableview")
- .create()
-```
+mdx-code-block
+
+
+
+ The following is an example of how to configure a TableView.
+
+ ```java
+TableView tv = client.newTableViewBuilder(Schema.STRING)
+.topic("my-tableview")
+.create()
+ ```
+
+You can use the available parameters in the `loadConf` configuration or the
API
[`TableViewBuilder`](/api/client/@pulsar:version_number@/org/apache/pulsar/client/api/TableViewBuilder.html)
to customize your TableView.
Review Comment:
Thanks, I tested it, and it can work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-client-cpp] tisonkun commented on a diff in pull request #269: Support specifying the C++ standard for some higher dependencies
tisonkun commented on code in PR #269:
URL: https://github.com/apache/pulsar-client-cpp/pull/269#discussion_r1194533381
##
CMakeLists.txt:
##
@@ -88,7 +88,9 @@ find_package(Threads REQUIRED)
MESSAGE(STATUS "Threads library: " ${CMAKE_THREAD_LIBS_INIT})
set(Boost_NO_BOOST_CMAKE ON)
-set(CMAKE_CXX_STANDARD 11)
+if (NOT CMAKE_CXX_STANDARD)
+set(CMAKE_CXX_STANDARD 11)
+endif ()
set(CMAKE_C_STANDARD 11)
Review Comment:
For options alignment, perhaps perform the same change for
`CMAKE_C_STANDARD`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #20325: [improve][misc] Enable rebase and merge to handle one PR of multiple semantic commits
tisonkun commented on code in PR #20325: URL: https://github.com/apache/pulsar/pull/20325#discussion_r1194531648 ## .asf.yaml: ## @@ -35,12 +35,9 @@ github: # Enable projects for project management boards projects: true enabled_merge_buttons: -# enable squash button: squash: true -# disable merge button: merge: false -# disable rebase button: -rebase: false +rebase: true Review Comment: OK. Let me start a mail thread first. For documentation, I don't think committers read comments in `.asf.yaml` so probably a page under https://pulsar.apache.org/contribute/develop-coding-conventions/ said "Reviewing Pull Request" or "Merging Pull Request". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
svn commit: r61870 - /dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.2.0-candidate-3/ /release/pulsar/pulsar-client-cpp-3.2.0/
Author: xyz Date: Tue May 16 02:26:27 2023 New Revision: 61870 Log: Release Apache Pulsar Client C++ 3.2.0 Added: release/pulsar/pulsar-client-cpp-3.2.0/ - copied from r61869, dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.2.0-candidate-3/ Removed: dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.2.0-candidate-3/
[pulsar-client-cpp] annotated tag v3.2.0 updated (1dad87b -> 26b6fa1)
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to annotated tag v3.2.0 in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git *** WARNING: tag v3.2.0 was modified! *** from 1dad87b (commit) to 26b6fa1 (tag) tagging 1dad87bb3b804d2aa8542ac48e4c35228ac2f1bf (commit) replaces v3.2.0-candidate-2 by Yunze Xu on Tue May 16 10:24:34 2023 +0800 - Log - Release v3.2.0 -BEGIN PGP SIGNATURE- iQJDBAABCgAtFiEEn+m0+KLf1EiRy6J0Qrtq+2zSb6YFAmRi6WIPHHh5ekBhcGFj aGUub3JnAAoJEEK7avts0m+mwO8QALE2ibApUZ0GzDI47zR9ywIvEGqlWrFw8iBG /XKhX5B8cq82zfJnCLwrvn2wivEA/yP+l2R6hClFlkOj30Zhfsk/pd8oycG9imiF 5IGKiPIPVgMiDWS1Rl856JM+QgPV5c98FqeqXezcA4wp7gdoWXZInaQjXz7aHaGW G55goJRGm6wcLxw/KMjxZa4VCzHwbg8xrDWmwOdEuoIVly3lBcOXNeb1TyHs0ev4 Gy1NesQuGTcHuI6fnKPnlLLZR8yX+Pv9pMGwPNwGsKyov79HyawJv54NXLWoesru kaRgabTad5rpknjk9zk45pKsv/pM5OuK5JryXcQp4hZEpnGVQtraBIDaC9ZX7knM J3exAFediHWeF04U/0tLDs9slyRnBW82SMV/b8NGtoc9Fidqg0Wn6k3o3AuIxthB amSe9Qc9HOojRvjheCllbK3RN93N+QZMDWNE7I1TM8pUq3LTBEF+R4rW10kU2qWi 6hRyNUsJ1k3134NuGaMBcLvDu+Q35WZWxxN1NJfELbNyhHVKN7wjJv0qSweJJ0Pf 7qHQmMsCMaXlwTDZQG1hL1/SP807F8dsReght8vO/HLYzeC2nzaGXp7iSBwCYrcY BJCCcSYTWUqk7otHD6BkSKTgi5xzsOk8fDZkGVGZ9pH6DAzlVl/BPqll5dYUedmm eNu8Ynp9 =eIim -END PGP SIGNATURE- --- No new revisions were added by this update. Summary of changes:
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #565: Add CPP client table view doc.
tisonkun commented on code in PR #565:
URL: https://github.com/apache/pulsar-site/pull/565#discussion_r1194529921
##
docs/client-libraries-tableviews.md:
##
@@ -4,36 +4,106 @@ title: Work with TableView
sidebar_label: "Work with TableView"
---
+mdx-code-block
+import Tabs from '@theme/Tabs';
+import TabItem from '@theme/TabItem';
+
+
After setting up your clients, you can explore more to start working with
[TableView](concepts-clients.md#tableview).
## Configure TableView
-The following is an example of how to configure a TableView.
-```java
-TableView tv = client.newTableViewBuilder(Schema.STRING)
- .topic("my-tableview")
- .create()
-```
+mdx-code-block
+
+
+
+ The following is an example of how to configure a TableView.
+
+ ```java
+TableView tv = client.newTableViewBuilder(Schema.STRING)
+.topic("my-tableview")
+.create()
+ ```
+
+You can use the available parameters in the `loadConf` configuration or the
API
[`TableViewBuilder`](/api/client/@pulsar:version_number@/org/apache/pulsar/client/api/TableViewBuilder.html)
to customize your TableView.
Review Comment:
```suggestion
You can use the available parameters in the `loadConf` configuration or the
API
[`TableViewBuilder`](/api/client/org/apache/pulsar/client/api/TableViewBuilder.html)
to customize your TableView.
```
The replace logic can be found at:
https://github.com/apache/pulsar-site/blob/22081daf8095676f897a0224351e6116d7d0d183/scripts/replace.js#L199
You can run `node scripts/replace.js` to test locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #19429: Make Java Client Authentication Asynchronous
github-actions[bot] commented on issue #19429: URL: https://github.com/apache/pulsar/issues/19429#issuecomment-1548853460 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated: [fix][txn] Implement compatibility for transaction buffer segmented snapshot feature upgrade (#20235)
This is an automated email from the ASF dual-hosted git repository.
bogong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 8b929e6bf1b [fix][txn] Implement compatibility for transaction buffer
segmented snapshot feature upgrade (#20235)
8b929e6bf1b is described below
commit 8b929e6bf1b1718431abebf04420d7817ad8cdb7
Author: Xiangying Meng <55571188+liangyepianz...@users.noreply.github.com>
AuthorDate: Tue May 16 09:41:35 2023 +0800
[fix][txn] Implement compatibility for transaction buffer segmented
snapshot feature upgrade (#20235)
master https://github.com/apache/pulsar/issues/16913
## Motivation:
The transaction buffer segmented snapshot feature aims to improve the
transaction buffer's performance by segmenting the snapshot and managing it
more efficiently. However, for existing topics that were created before this
feature was introduced, we need to ensure a seamless transition and
compatibility when enabling the segmented snapshot feature.
## Modifications:
1. Updated the `recoverFromSnapshot()` method to read from another topic if
the `persistentSnapshotIndexes` is null. This ensures that the appropriate
snapshot data is fetched during the recovery process when upgrading to the
segmented snapshot feature.
2. Created a new test `testSnapshotProcessorUpdate()` that verifies the
compatibility of the transaction
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe
tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(10MB)*
- *Extended integration test for recovery after broker failure*
---
.../SnapshotSegmentAbortedTxnProcessorImpl.java| 66 +-
.../SegmentAbortedTxnProcessorTest.java| 133 -
2 files changed, 196 insertions(+), 3 deletions(-)
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/SnapshotSegmentAbortedTxnProcessorImpl.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/SnapshotSegmentAbortedTxnProcessorImpl.java
index 751c03aff95..4f4e58ac3f5 100644
---
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/SnapshotSegmentAbortedTxnProcessorImpl.java
+++
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/SnapshotSegmentAbortedTxnProcessorImpl.java
@@ -47,6 +47,7 @@ import
org.apache.pulsar.broker.service.SystemTopicTxnBufferSnapshotService.Refe
import org.apache.pulsar.broker.service.persistent.PersistentTopic;
import org.apache.pulsar.broker.systopic.SystemTopicClient;
import org.apache.pulsar.broker.transaction.buffer.AbortedTxnProcessor;
+import
org.apache.pulsar.broker.transaction.buffer.metadata.TransactionBufferSnapshot;
import
org.apache.pulsar.broker.transaction.buffer.metadata.v2.TransactionBufferSnapshotIndex;
import
org.apache.pulsar.broker.transaction.buffer.metadata.v2.TransactionBufferSnapshotIndexes;
import
org.apache.pulsar.broker.transaction.buffer.metadata.v2.TransactionBufferSnapshotIndexesMetadata;
@@ -265,7 +266,7 @@ public class SnapshotSegmentAbortedTxnProcessorImpl
implements AbortedTxnProcess
PositionImpl finalStartReadCursorPosition =
startReadCursorPosition;
TransactionBufferSnapshotIndexes
finalPersistentSnapshotIndexes = persistentSnapshotIndexes;
if (persistentSnapshotIndexes == null) {
-return CompletableFuture.completedFuture(null);
+return recoverOldSnapshot();
} else {
this.unsealedTxnIds =
convertTypeToTxnID(persistentSnapshotIndexes
.getSnapshot().getAborts());
@@ -378,6 +379,69 @@ public class SnapshotSegmentAbortedTxnProcessorImpl
implements AbortedTxnProcess
.getExecutor(this));
}
+// This method will be deprecated and removed in version 4.x.0
+private CompletableFuture recoverOldSnapshot() {
+return
topic.getBrokerService().getTopic(TopicName.get(topic.getName()).getNamespace()
+ "/"
++ SystemTopicNames.TRANSACTION_BUFFER_SNAPSHOT, false)
+.thenCompose(topicOption -> {
+if (!topicOption.isPresent()) {
+return CompletableFuture.completedFuture(null);
+} else {
+return
[GitHub] [pulsar] congbobo184 merged pull request #20235: [fix][txn] Implement compatibility for transaction buffer segmented snapshot feature upgrade
congbobo184 merged PR #20235: URL: https://github.com/apache/pulsar/pull/20235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-site] branch main updated: Docs sync done from apache/pulsar (#0acf8f8)
This is an automated email from the ASF dual-hosted git repository.
urfree pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new 22081daf809 Docs sync done from apache/pulsar (#0acf8f8)
22081daf809 is described below
commit 22081daf8095676f897a0224351e6116d7d0d183
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Tue May 16 01:36:51 2023 +
Docs sync done from apache/pulsar (#0acf8f8)
---
static/swagger/master/swagger.json| 13 +++--
static/swagger/master/v2/swagger.json | 13 +++--
2 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/static/swagger/master/swagger.json
b/static/swagger/master/swagger.json
index c547d06c538..1139682e11a 100644
--- a/static/swagger/master/swagger.json
+++ b/static/swagger/master/swagger.json
@@ -1345,22 +1345,23 @@
"format": "int64",
"type": "integer"
},
+"isOffloaded": {
+"type": "boolean"
+},
"ledgerId": {
"format": "int64",
"type": "integer"
},
-"metadata": {
+"offloadedContextUuid": {
"type": "string"
},
-"offloaded": {
-"type": "boolean"
-},
"size": {
"format": "int64",
"type": "integer"
},
-"underReplicated": {
-"type": "boolean"
+"timestamp": {
+"format": "int64",
+"type": "integer"
}
},
"type": "object"
diff --git a/static/swagger/master/v2/swagger.json
b/static/swagger/master/v2/swagger.json
index c547d06c538..1139682e11a 100644
--- a/static/swagger/master/v2/swagger.json
+++ b/static/swagger/master/v2/swagger.json
@@ -1345,22 +1345,23 @@
"format": "int64",
"type": "integer"
},
+"isOffloaded": {
+"type": "boolean"
+},
"ledgerId": {
"format": "int64",
"type": "integer"
},
-"metadata": {
+"offloadedContextUuid": {
"type": "string"
},
-"offloaded": {
-"type": "boolean"
-},
"size": {
"format": "int64",
"type": "integer"
},
-"underReplicated": {
-"type": "boolean"
+"timestamp": {
+"format": "int64",
+"type": "integer"
}
},
"type": "object"
[GitHub] [pulsar-client-cpp] BewareMyPower opened a new pull request, #269: Support specifying the C++ standard for some higher dependencies
BewareMyPower opened a new pull request, #269: URL: https://github.com/apache/pulsar-client-cpp/pull/269 Fixes https://github.com/apache/pulsar-client-cpp/issues/268 ### Motivation When users build from source with a dependency that requires a higher C++ version than 11, it will fail because currently the C++ standard is pinned to 11. For example, the latest GTest requires C++14 now. So currently there is no way to build the tests except modifying the CMakeLists.txt file. ### Modifications Make `CMAKE_CXX_STANDARD` configurable and test it for the macOS workflow because the `gtest` dependency installed from `brew` requires C++14. Add the description into the README for it. ### Documentation - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [ ] `doc-not-needed` (Please explain why) - [x] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #20284: [improve][client] Document Java Client's Seek logic thread-safety improved in #20242
JooHyukKim commented on PR #20284: URL: https://github.com/apache/pulsar/pull/20284#issuecomment-154815 > ### Motivation > Improves JavaDoc describing changes made by PR #20242 as suggested by in [review](https://github.com/apache/pulsar/pull/20242#pullrequestreview-1417853594) > > **EDIT:** modified JavaDoc to also cover #20321 accordingly @tisonkun thank you for the reminder, I updated the PR description also. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on a diff in pull request #20284: [improve][client] Document Java Client's Seek logic thread-safety improved in #20242
JooHyukKim commented on code in PR #20284:
URL: https://github.com/apache/pulsar/pull/20284#discussion_r1194340918
##
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java:
##
@@ -523,11 +523,15 @@ CompletableFuture
reconsumeLaterCumulativeAsync(Message message,
/**
* The asynchronous version of {@link Consumer#seek(MessageId)}.
+ *
+ * If there is already a seek operation in progress, the method will log a
warning and return a canceled future.
Review Comment:
Oh okay, will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on pull request #560: PIP-249 site redesign
visortelle commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1548207937 2h+. Wow. https://github.com/apache/pulsar-site/assets/9302460/5d43e363-8d91-4b36-893f-02fe06ba3181;> @tisonkun I assume, the next builds should take much less time? There are a few minor tweaks by the designer. I assume it would be preferable to make new changes in new PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #153: docs: support API docs
entvex commented on code in PR #153:
URL: https://github.com/apache/pulsar-dotpulsar/pull/153#discussion_r1193481291
##
docfx.json:
##
@@ -0,0 +1,56 @@
+{
+ "metadata": [
+{
+ "src": [
+{
+ "files": [
+"src/DotPulsar/bin/**/*.dll"
+ ]
+}
+ ],
+ "dest": "api",
+ "includePrivateMembers": false,
+ "disableGitFeatures": false,
+ "disableDefaultFilter": false,
+ "noRestore": false,
+ "namespaceLayout": "flattened",
+ "memberLayout": "samePage",
+ "allowCompilationErrors": false
+}
+ ],
+ "build": {
+"content": [
+ {
+"files": [
+ "api/**.yml",
+ "api/index.md"
+]
+ },
+ {
+"files": [
+ "articles/**.md",
+ "articles/**/toc.yml",
+ "toc.yml",
+ "*.md"
+]
+ }
+],
+"resource": [
+ {
+"files": [
+ "images/**"
+]
+ }
+],
+"dest": "_site",
+"globalMetadataFiles": [],
Review Comment:
If you want to, it would be really awesome to have the Pulsar logo.
I think you can the logo and other stuff like this.
"globalMetadata": {
"_appTitle": "Offical DotPulsar Documentation",
"_appFooter": " Company LtdThe Apache Software
Foundation. All Rights Reserved. Apache, Pulsar, Apache Pulsar, and the Apache
feather logo are trademarks or registered trademarks of The Apache Software
Foundation.",
"_appLogoPath": "CompanyIcon.png",<--- Find a
Pulsar logo that looks nice in dark mode
"_appFaviconPath": "CompanyIcon.png", <--- Find the
Pulsar favicon
},
You can find all the things we can set here
https://dotnet.github.io/docfx/reference/docfx-json-reference.html#122-reserved-metadata
Also, remember to remove the "<--- Find a Pulsar logo that looks nice in
dark mode" and "<--- Find the Pulsar favicon"
Let me know if it makes sense, I'm happy to help
Other than that, excellent work @tisonkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-client-cpp] mattisonchao opened a new issue, #268: [Bug] C++ versions less than C++14 are not supported.
mattisonchao opened a new issue, #268: URL: https://github.com/apache/pulsar-client-cpp/issues/268 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar-client-cpp/issues) and found nothing similar. ### Version 3.2.0-candidate-3 ### Minimal reproduce step ``` cmake . make ``` ### What did you expect to see? run `make` success. ### What did you see instead? ``` [ 64%] Building CXX object tests/CMakeFiles/pulsar-tests.dir/AcknowledgeTest.cc.o In file included from /Users/mattisonchao/Projects/apache/pulsar-client-cpp/tests/AcknowledgeTest.cc:19: In file included from /usr/local/include/gtest/gtest.h:64: In file included from /usr/local/include/gtest/gtest-assertion-result.h:46: In file included from /usr/local/include/gtest/gtest-message.h:57: /usr/local/include/gtest/internal/gtest-port.h:270:2: error: C++ versions less than C++14 are not supported. #error C++ versions less than C++14 are not supported. ^ In file included from /Users/mattisonchao/Projects/apache/pulsar-client-cpp/tests/AcknowledgeTest.cc:19: In file included from /usr/local/include/gtest/gtest.h:65: In file included from /usr/local/include/gtest/gtest-death-test.h:43: In file included from /usr/local/include/gtest/internal/gtest-death-test-internal.h:47: In file included from /usr/local/include/gtest/gtest-matchers.h:48: In file included from /usr/local/include/gtest/gtest-printers.h:115: /usr/local/include/gtest/internal/gtest-internal.h:636:54: error: too few template arguments for class template 'less' typedef ::std::map> RegisteredTestsMap; ^ /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/__functional/operations.h:473:29: note: template is declared here struct _LIBCPP_TEMPLATE_VIS less ^ In file included from /Users/mattisonchao/Projects/apache/pulsar-client-cpp/tests/AcknowledgeTest.cc:19: In file included from /usr/local/include/gtest/gtest.h:65: In file included from /usr/local/include/gtest/gtest-death-test.h:43: In file included from /usr/local/include/gtest/internal/gtest-death-test-internal.h:47: In file included from /usr/local/include/gtest/gtest-matchers.h:48: In file included from /usr/local/include/gtest/gtest-printers.h:115: /usr/local/include/gtest/internal/gtest-internal.h:613:22: error: member reference base type 'testing::internal::TypedTestSuitePState::RegisteredTestsMap' (aka 'int') is not a structure or union registered_tests_.insert( ~^~~ /usr/local/include/gtest/internal/gtest-internal.h:619:29: error: member reference base type 'const testing::internal::TypedTestSuitePState::RegisteredTestsMap' (aka 'const int') is not a structure or union return registered_tests_.count(test_name) > 0; ``` ### Anything else? _No response_ ### Are you willing to submit a PR? - [ ] I'm willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on issue #20314: Python tests are broken in branch-2.10
BewareMyPower commented on issue #20314: URL: https://github.com/apache/pulsar/issues/20314#issuecomment-1547980222 @mattisonchao See my previous discussion [here](https://lists.apache.org/thread/5s2l9vgt5f973psb6xlttpmy4rpym7zh). @zymap @lhotari I think we can change the way to install the Python client. Currently, it's installed by: ```bash pip install pulsar-client[functions] ``` However, it's equivalent to: ```bash pip install pulsar-client pip install ... ``` Because the dependencies by the extra `[functions]` package are never related to the Python client itself. Once we have available dependencies, we can install them manually: ```bash pip install pulsar-client # I assumes BK client 4.16.0 is still compatible with Python 2.17 pip install apache-bookkeeper-client==4.16.0 # TODO: pip install other dependencies ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] syk-coder opened a new pull request, #20327: [fix][broker] When creating a namespace anti-affinity group with the default local policies, use the bundle size supplied by the user.
syk-coder opened a new pull request, #20327: URL: https://github.com/apache/pulsar/pull/20327 Fixes https://github.com/apache/pulsar/issues/20278 Motivation Motivation & Modifications: 1. When creating a namespace anti-affinity group with the default local policies, use the bundle size supplied by the user. 2. use OrElseGet instead of OrElse ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in the forked repository -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on a diff in pull request #560: PIP-249 site redesign
visortelle commented on code in PR #560: URL: https://github.com/apache/pulsar-site/pull/560#discussion_r1193808832 ## .github/workflows/ci-precommit.yml: ## @@ -17,8 +17,8 @@ name: CI - Precommit on: - pull_request: -branches: [main] + push: Review Comment: Reverted :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #560: PIP-249 site redesign
tisonkun commented on code in PR #560: URL: https://github.com/apache/pulsar-site/pull/560#discussion_r1193805168 ## .github/workflows/ci-precommit.yml: ## @@ -17,8 +17,8 @@ name: CI - Precommit on: - pull_request: -branches: [main] + push: Review Comment: Otherwise we cannot run CI upstream. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #560: PIP-249 site redesign
tisonkun commented on code in PR #560: URL: https://github.com/apache/pulsar-site/pull/560#discussion_r1193804769 ## .github/workflows/ci-precommit.yml: ## @@ -17,8 +17,8 @@ name: CI - Precommit on: - pull_request: -branches: [main] + push: Review Comment: I suggest you revert these commits. You can open a pull request against `main` in your fork to trigger CI also. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-site] branch main updated: build: add containerized building (#576)
This is an automated email from the ASF dual-hosted git repository.
tison pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new 4680b04ad5e build: add containerized building (#576)
4680b04ad5e is described below
commit 4680b04ad5ef4de533a75437949706da95a6e7e3
Author: tison
AuthorDate: Mon May 15 21:00:31 2023 +0800
build: add containerized building (#576)
Signed-off-by: tison
---
.dockerignore | 28
docker-compose.yaml => Dockerfile | 24 ++--
docker-compose.yaml | 11 +--
package.json | 2 +-
4 files changed, 48 insertions(+), 17 deletions(-)
diff --git a/.dockerignore b/.dockerignore
new file mode 100644
index 000..241625cfd81
--- /dev/null
+++ b/.dockerignore
@@ -0,0 +1,28 @@
+# JetBrains IDEs
+.idea/
+*.iml
+*.iws
+
+# Dependencies
+**/node_modules/**
+
+# Production
+build
+build-*
+
+# Generated files
+.docusaurus
+.cache-loader
+
+# Misc
+.DS_Store
+.env.local
+.env.development.local
+.env.test.local
+.env.production.local
+
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
+
+.yarn
diff --git a/docker-compose.yaml b/Dockerfile
similarity index 74%
copy from docker-compose.yaml
copy to Dockerfile
index 96efbb104a6..88b2d6dafb8 100644
--- a/docker-compose.yaml
+++ b/Dockerfile
@@ -15,13 +15,17 @@
# specific language governing permissions and limitations
# under the License.
-version: "3.1"
-services:
- web:
-image: httpd:2.4.54-alpine
-ports:
- - "80:80"
-volumes:
- - ./build:/usr/local/apache2/htdocs
- - ./tools/conf/httpd.conf:/usr/local/apache2/conf/httpd.conf
-container_name: pulsar_site
+FROM node:20-bullseye as build
+
+WORKDIR /bulid-site
+
+COPY . .
+
+RUN corepack enable && yarn install && yarn build
+
+FROM httpd:2.4.54-alpine
+
+COPY --from=build /bulid-site/build /usr/local/apache2/htdocs
+COPY tools/conf/httpd.conf /usr/local/apache2/conf/httpd.conf
+
+EXPOSE 80
diff --git a/docker-compose.yaml b/docker-compose.yaml
index 96efbb104a6..17524f0c988 100644
--- a/docker-compose.yaml
+++ b/docker-compose.yaml
@@ -17,11 +17,10 @@
version: "3.1"
services:
- web:
-image: httpd:2.4.54-alpine
+ site:
+build:
+ context: .
+ dockerfile: ./Dockerfile
ports:
- - "80:80"
-volumes:
- - ./build:/usr/local/apache2/htdocs
- - ./tools/conf/httpd.conf:/usr/local/apache2/conf/httpd.conf
+ - "3000:80"
container_name: pulsar_site
diff --git a/package.json b/package.json
index 2856467f838..5e1482ff929 100644
--- a/package.json
+++ b/package.json
@@ -91,6 +91,6 @@
},
"packageManager": "yarn@3.5.0",
"engines": {
-"node": "18"
+"node": ">=18"
}
}
[GitHub] [pulsar] tisonkun closed issue #20272: Pulsar site preview should be done in a container
tisonkun closed issue #20272: Pulsar site preview should be done in a container URL: https://github.com/apache/pulsar/issues/20272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun merged pull request #576: build: add containerized building
tisonkun merged PR #576: URL: https://github.com/apache/pulsar-site/pull/576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #576: build: add containerized building
tisonkun commented on PR #576: URL: https://github.com/apache/pulsar-site/pull/576#issuecomment-1547816645 I'll merge this patch first. Further improvement can be done later. I'll try to directly push some fix on the PIP-249 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #576: build: add containerized building
tisonkun commented on PR #576: URL: https://github.com/apache/pulsar-site/pull/576#issuecomment-1547814851 Let's discuss in your fork. It's unrelated to this PR or the upstream code. Basically, you need to run `yarn install` before any other command. It looks like your run `node scripts/replace.js` before `yarn install` - the script is another tech debt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on pull request #576: build: add containerized building
visortelle commented on PR #576:
URL: https://github.com/apache/pulsar-site/pull/576#issuecomment-1547808800
@tisonkun by the way, I used another command to run child process, and now I
at least see the concrete error message `cannot find module 'replace-in-files'`.
```python
import subprocess
...
def run_command(command):
process = subprocess.Popen(command, stdout=subprocess.PIPE,
stderr=subprocess.PIPE, shell=True)
stdout, stderr = process.communicate()
if stdout:
print("STDOUT:")
print(stdout.decode('utf-8'))
if stderr:
print("STDERR:")
print(stderr.decode('utf-8'))
...
run_command('yarn install')
```
https://github.com/apache/pulsar-site/assets/9302460/622a8e92-3089-48e6-8ce2-076c1129a4c4;>
https://github.com/tealtools/pulsar-site-pip-249/actions/runs/4980539690/jobs/8913580517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #20284: [improve][client] Document Java Client's Seek logic thread-safety improved in #20242
tisonkun commented on code in PR #20284:
URL: https://github.com/apache/pulsar/pull/20284#discussion_r1193774604
##
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java:
##
@@ -523,11 +523,15 @@ CompletableFuture
reconsumeLaterCumulativeAsync(Message message,
/**
* The asynchronous version of {@link Consumer#seek(MessageId)}.
+ *
+ * If there is already a seek operation in progress, the method will log a
warning and return a canceled future.
*/
CompletableFuture seekAsync(MessageId messageId);
/**
* Reset the subscription associated with this consumer to a specific
message publish time.
+ *
+ * If there is already a seek operation in progress, the method will log a
warning and return a canceled future.
Review Comment:
```suggestion
* If there is already a seek operation in progress, the method will log
a warning and return a future completed exceptionally.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #20284: [improve][client] Document Java Client's Seek logic thread-safety improved in #20242
tisonkun commented on code in PR #20284:
URL: https://github.com/apache/pulsar/pull/20284#discussion_r1193774304
##
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java:
##
@@ -523,11 +523,15 @@ CompletableFuture
reconsumeLaterCumulativeAsync(Message message,
/**
* The asynchronous version of {@link Consumer#seek(MessageId)}.
+ *
+ * If there is already a seek operation in progress, the method will log a
warning and return a canceled future.
Review Comment:
```suggestion
* If there is already a seek operation in progress, the method will log
a warning and return a future completed exceptionally.
```
See https://github.com/apache/pulsar/pull/20321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[pulsar] branch tisonkun-patch-1 deleted (was 1c34443f7ac)
This is an automated email from the ASF dual-hosted git repository. tison pushed a change to branch tisonkun-patch-1 in repository https://gitbox.apache.org/repos/asf/pulsar.git was 1c34443f7ac [improve][misc] Enable rebase and merge to handle one PR of multiple semantic commits The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[pulsar] 01/02: Revert "[fix][client] Seek should be thread-safe (#20242)"
This is an automated email from the ASF dual-hosted git repository.
tison pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 7b54664c364a7360f30cd37f0aa989ab13a14af4
Author: tison
AuthorDate: Mon May 15 10:47:00 2023 +0800
Revert "[fix][client] Seek should be thread-safe (#20242)"
This reverts commit bc1764f9ef71dd31e8cd61c7571e493442bc6395.
---
.../apache/pulsar/client/impl/ConsumerImpl.java| 109 +
.../pulsar/client/impl/ConsumerImplTest.java | 27 +
2 files changed, 50 insertions(+), 86 deletions(-)
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
index 2693f12d3ea..8a06ec122b5 100644
---
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
+++
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
@@ -208,7 +208,6 @@ public class ConsumerImpl extends ConsumerBase
implements ConnectionHandle
private final AtomicReference
clientCnxUsedForConsumerRegistration = new AtomicReference<>();
private final List previousExceptions = new
CopyOnWriteArrayList();
-
static ConsumerImpl newConsumerImpl(PulsarClientImpl client,
String topic,
ConsumerConfigurationData
conf,
@@ -252,12 +251,10 @@ public class ConsumerImpl extends ConsumerBase
implements ConnectionHandle
}
protected ConsumerImpl(PulsarClientImpl client, String topic,
ConsumerConfigurationData conf,
- ExecutorProvider executorProvider, int
partitionIndex, boolean hasParentConsumer,
- boolean parentConsumerHasListener,
CompletableFuture> subscribeFuture,
- MessageId startMessageId,
- long startMessageRollbackDurationInSec, Schema
schema,
- ConsumerInterceptors interceptors,
- boolean createTopicIfDoesNotExist) {
+ ExecutorProvider executorProvider, int partitionIndex, boolean
hasParentConsumer,
+ boolean parentConsumerHasListener, CompletableFuture>
subscribeFuture, MessageId startMessageId,
+ long startMessageRollbackDurationInSec, Schema schema,
ConsumerInterceptors interceptors,
+ boolean createTopicIfDoesNotExist) {
super(client, topic, conf, conf.getReceiverQueueSize(),
executorProvider, subscribeFuture, schema,
interceptors);
this.consumerId = client.newConsumerId();
@@ -329,21 +326,21 @@ public class ConsumerImpl extends ConsumerBase
implements ConnectionHandle
}
this.connectionHandler = new ConnectionHandler(this,
-new BackoffBuilder()
-
.setInitialTime(client.getConfiguration().getInitialBackoffIntervalNanos(),
-TimeUnit.NANOSECONDS)
-
.setMax(client.getConfiguration().getMaxBackoffIntervalNanos(),
TimeUnit.NANOSECONDS)
-.setMandatoryStop(0, TimeUnit.MILLISECONDS)
-.create(),
+new BackoffBuilder()
+
.setInitialTime(client.getConfiguration().getInitialBackoffIntervalNanos(),
+TimeUnit.NANOSECONDS)
+
.setMax(client.getConfiguration().getMaxBackoffIntervalNanos(),
TimeUnit.NANOSECONDS)
+.setMandatoryStop(0, TimeUnit.MILLISECONDS)
+.create(),
this);
this.topicName = TopicName.get(topic);
if (this.topicName.isPersistent()) {
this.acknowledgmentsGroupingTracker =
-new PersistentAcknowledgmentsGroupingTracker(this, conf,
client.eventLoopGroup());
+new PersistentAcknowledgmentsGroupingTracker(this, conf,
client.eventLoopGroup());
} else {
this.acknowledgmentsGroupingTracker =
-NonPersistentAcknowledgmentGroupingTracker.of();
+NonPersistentAcknowledgmentGroupingTracker.of();
}
if (conf.getDeadLetterPolicy() != null) {
@@ -420,16 +417,16 @@ public class ConsumerImpl extends ConsumerBase
implements ConnectionHandle
log.error("[{}][{}] Failed to unsubscribe: {}", topic,
subscription, e.getCause().getMessage());
setState(State.Ready);
unsubscribeFuture.completeExceptionally(
-PulsarClientException.wrap(e.getCause(),
-String.format("Failed to unsubscribe the
subscription %s of topic %s",
-topicName.toString(), subscription)));
+
[pulsar] 02/02: [fix][client] thread-safe seek
This is an automated email from the ASF dual-hosted git repository.
tison pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 0acf8f89d6057170e990b128936175fc5dd33be3
Author: tison
AuthorDate: Mon May 15 15:10:11 2023 +0800
[fix][client] thread-safe seek
Signed-off-by: tison
---
.../apache/pulsar/client/impl/ConsumerImpl.java| 11 -
.../pulsar/client/impl/ConsumerImplTest.java | 27 +-
2 files changed, 36 insertions(+), 2 deletions(-)
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
index 8a06ec122b5..4a84e765065 100644
---
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
+++
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
@@ -2158,9 +2158,18 @@ public class ConsumerImpl extends ConsumerBase
implements ConnectionHandle
final CompletableFuture seekFuture = new CompletableFuture<>();
ClientCnx cnx = cnx();
+if (!duringSeek.compareAndSet(false, true)) {
+final String message = String.format(
+"[%s][%s] attempting to seek operation that is already in
progress (seek by %s)",
+topic, subscription, seekBy);
+log.warn("[{}][{}] Attempting to seek operation that is already in
progress, cancelling {}",
+topic, subscription, seekBy);
+seekFuture.completeExceptionally(new
IllegalStateException(message));
+return seekFuture;
+}
+
MessageIdAdv originSeekMessageId = seekMessageId;
seekMessageId = (MessageIdAdv) seekId;
-duringSeek.set(true);
log.info("[{}][{}] Seeking subscription to {}", topic, subscription,
seekBy);
cnx.sendRequestWithId(seek, requestId).thenRun(() -> {
diff --git
a/pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java
b/pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java
index 29d180f5f9a..5a223d5da15 100644
---
a/pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java
+++
b/pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java
@@ -19,6 +19,7 @@
package org.apache.pulsar.client.impl;
import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.Mockito.any;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doReturn;
@@ -26,7 +27,9 @@ import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
-
+import static org.mockito.Mockito.when;
+import static org.testng.Assert.assertTrue;
+import io.netty.buffer.ByteBuf;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.CompletionException;
import java.util.concurrent.ExecutorService;
@@ -259,4 +262,26 @@ public class ConsumerImplTest {
assertThat(consumer.getPriorityLevel()).isEqualTo(1);
}
+
+@Test(invocationTimeOut = 1000)
+public void testSeekAsyncInternal() {
+// given
+ClientCnx cnx = mock(ClientCnx.class);
+CompletableFuture clientReq = new
CompletableFuture<>();
+when(cnx.sendRequestWithId(any(ByteBuf.class),
anyLong())).thenReturn(clientReq);
+
+consumer.setClientCnx(cnx);
+consumer.setState(HandlerState.State.Ready);
+
+// when
+CompletableFuture firstResult = consumer.seekAsync(1L);
+CompletableFuture secondResult = consumer.seekAsync(1L);
+
+clientReq.complete(null);
+
+// then
+assertTrue(firstResult.isDone());
+assertTrue(secondResult.isCompletedExceptionally());
+verify(cnx, times(1)).sendRequestWithId(any(ByteBuf.class), anyLong());
+}
}
[pulsar] branch master updated (21afdfd6df5 -> 0acf8f89d60)
This is an automated email from the ASF dual-hosted git repository. tison pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 21afdfd6df5 [improve][misc] Enable rebase and merge to handle one PR of multiple semantic commits (#20325) new 7b54664c364 Revert "[fix][client] Seek should be thread-safe (#20242)" new 0acf8f89d60 [fix][client] thread-safe seek The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../apache/pulsar/client/impl/ConsumerImpl.java| 106 ++--- .../pulsar/client/impl/ConsumerImplTest.java | 2 +- 2 files changed, 53 insertions(+), 55 deletions(-)
[GitHub] [pulsar] tisonkun commented on pull request #20321: [fix][client] thread-safe seek
tisonkun commented on PR #20321: URL: https://github.com/apache/pulsar/pull/20321#issuecomment-1547781948 Rebase and merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #20321: [fix][client] thread-safe seek
tisonkun merged PR #20321: URL: https://github.com/apache/pulsar/pull/20321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated: [improve][misc] Enable rebase and merge to handle one PR of multiple semantic commits (#20325)
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 21afdfd6df5 [improve][misc] Enable rebase and merge to handle one PR of multiple semantic commits (#20325) 21afdfd6df5 is described below commit 21afdfd6df57ed56438a3434cd081d9b6dd4132d Author: tison AuthorDate: Mon May 15 20:34:51 2023 +0800 [improve][misc] Enable rebase and merge to handle one PR of multiple semantic commits (#20325) --- .asf.yaml | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.asf.yaml b/.asf.yaml index 459dcb6e2fe..5c3b8cb98d9 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -35,12 +35,9 @@ github: # Enable projects for project management boards projects: true enabled_merge_buttons: -# enable squash button: squash: true -# disable merge button: merge: false -# disable rebase button: -rebase: false +rebase: true protected_branches: master: required_status_checks:
[GitHub] [pulsar-site] visortelle commented on pull request #576: build: add containerized building
visortelle commented on PR #576: URL: https://github.com/apache/pulsar-site/pull/576#issuecomment-1547774711 @tisonkun I tried locally. No changes in `yarn.lock`. Will set up GitHub actions for this branch in my fork. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #576: build: add containerized building
tisonkun commented on PR #576: URL: https://github.com/apache/pulsar-site/pull/576#issuecomment-1547769522 @visortelle I think of it just now. Let me try it out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on pull request #576: build: add containerized building
visortelle commented on PR #576: URL: https://github.com/apache/pulsar-site/pull/576#issuecomment-1547767911 Maybe it has sense to **full build process** to Docker? Let's say, I have such a problem in Python script that runs `yarn install`: https://github.com/apache/pulsar-site/assets/9302460/d013a5a0-234b-4d44-90ca-7308ab3b5a7a;> https://github.com/apache/pulsar-site/actions/runs/4979344185/jobs/8911494860 I'm not sure how I can debug it locally. The current Docker setup doesn't have any mention of Python, poetry package manager, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #560: PIP-249 site redesign
tisonkun commented on code in PR #560: URL: https://github.com/apache/pulsar-site/pull/560#discussion_r1193698203 ## versioned_docs/version-2.9.x/about.md: ## Review Comment: ``` Compiled with problems: × ERROR in ./versioned_docs/version-3.0.x/about.md 1:1096-1152 Module not found: Error: Can't resolve '@site/src/components/BlockLinks' in '/Users/chenzili/Brittani/pulsar-site/versioned_docs/version-3.0.x' ERROR in ./versioned_docs/version-3.0.x/about.md 1:1152-1206 Module not found: Error: Can't resolve '@site/src/components/BlockLink' in '/Users/chenzili/Brittani/pulsar-site/versioned_docs/version-3.0.x' ``` Need for 3.0 also I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on pull request #560: PIP-249 site redesign
visortelle commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1547673373 Will chech > Build failed in CI. Perhaps you need to run yarn install and update the lockfile? Will check in an hour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #560: PIP-249 site redesign
tisonkun commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1547670797 Build failed in CI. Perhaps you need to run yarn install and update the lockfile? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] crossoverJie opened a new pull request, #20326: [fix][broker] Fix skip message API when hole messages exists
crossoverJie opened a new pull request, #20326: URL: https://github.com/apache/pulsar/pull/20326 Fixes #20262 ### Motivation When there are hole messages, there is a bug in the API of skipping the message, please refer to the [issue](https://github.com/apache/pulsar/issues/20262) for the specific reason ### Modifications Remove `recyclePositionRangeConverter`, revert to normal loop. ### Verifying this change - [ ] Make sure that the change passes the CI checks. ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: (https://github.com/crossoverJie/pulsar/pull/8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on pull request #560: PIP-249 site redesign
visortelle commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1547525005 > This section is still work in progress? @asafm Fixed. https://pulsar-site-pip-249.vercel.app/contribute/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on a diff in pull request #560: PIP-249 site redesign
visortelle commented on code in PR #560:
URL: https://github.com/apache/pulsar-site/pull/560#discussion_r1193589673
##
docusaurus.config.js:
##
@@ -124,298 +125,321 @@ const injectLinkParseForEndpoint = ([, info]) => {
/** @type {import('@docusaurus/types').Config} */
module.exports = {
-title: "Apache Pulsar",
-tagline: "Apache Pulsar is a distributed, open source pub-sub messaging
and streaming platform for real-time workloads, managing hundreds of billions
of events per day.",
-url: "https://pulsar.apache.org;,
-baseUrl: baseUrl,
-onBrokenLinks: "warn",
-onBrokenMarkdownLinks: "warn",
-favicon: "img/favicon.ico",
-organizationName: "apache",
-projectName: "pulsar",
-customFields: {
-githubUrl,
-oldUrl,
+ title: "Apache Pulsar",
+ tagline:
+"Apache Pulsar is a distributed, open source pub-sub messaging and
streaming platform for real-time workloads, managing hundreds of billions of
events per day.",
+ url: "https://pulsar.apache.org;,
+ baseUrl: baseUrl,
+ onBrokenLinks: "warn",
+ onBrokenMarkdownLinks: "warn",
+ favicon: "img/favicon.ico",
+ organizationName: "apache",
+ projectName: "pulsar",
+ customFields: {
+githubUrl,
+oldUrl,
+ },
+ trailingSlash: true,
+ themeConfig: {
+/** @type {import('@docusaurus/preset-classic').ThemeConfig} */
+announcementBar: {
+ id: "summit",
+ content: renderAnnouncementBar(
+"Pulsar Virtual Summit Europe 2023",
+"https://pulsar-summit.org/event/europe-2023;
+ ),
+ backgroundColor: "#282826",
+ textColor: "#fff",
+ isCloseable: false,
},
-trailingSlash: true,
-themeConfig: {
-/** @type {import('@docusaurus/preset-classic').ThemeConfig} */
-announcementBar: {
-id: "summit",
-content: ` Pulsar Virtual Summit Europe 2023 will take place on
Tuesday, May 23rd, 2023! https://events.zoom.us/ev/Ap6rsDg9LeVfmdajJ_eB13HH026J1d_o8OoTKkQnl_jzVl-srhwB~AggLXsr32QYFjq8BlYLZ5I06Dg;>Register
now for free!`,
-backgroundColor: "#198fff",
-textColor: "#fff",
-isCloseable: true,
+colorMode: {
+ disableSwitch: true,
+},
+navbar: {
+ title: "",
+ logo: {
+alt: "pulsar logo",
+src: "img/logo-black.svg",
+ },
+ items: [
+{
+ type: "dropdown",
+ label: "Get Started",
+ position: "left",
+ items: [
+{
+ to: "/docs/next/concepts-overview/",
+ activeBaseRegex: "docs/next/concepts-overview/$",
+ label: "Pulsar Concepts",
+},
+{
+ to: "/docs/next/",
+ activeBaseRegex: "docs/next/$",
+ label: "Quickstart",
+},
+{
+ to: "/ecosystem/",
+ label: "Ecosystem",
+},
+ ],
},
-colorMode: {
-disableSwitch: false,
+{
+ type: "doc",
+ docId: "about",
+ position: "left",
+ label: "Docs",
},
-navbar: {
-title: "",
-logo: {
-alt: "pulsar logo",
-src: "img/logo.svg",
-},
-items: [
-{
-type: "dropdown",
-label: "Get Started",
-position: "right",
-items: [
-{
-type: 'doc',
-docId: 'concepts-overview',
-label: "Pulsar Concepts",
-},
-{
-type: 'doc',
-docId: 'about',
-label: "Quickstart",
-},
-{
-to: "/ecosystem/",
-label: "Ecosystem",
-},
-],
-},
-{
-type: 'doc',
-docId: 'about',
-position: "right",
-label: "Docs",
-},
-{
-to: "/contribute/",
-position: "right",
-label: "Contribute",
-},
-{
-type: "dropdown",
-label: "Community",
-position: "right",
-className: "community-dropdown",
-items: [
-{
-to: "/community#section-welcome",
-label: "Welcome",
-className: "scroll-link scroll-welcome",
-id: "scroll-welcome",
-},
-{
-
[GitHub] [pulsar] tisonkun opened a new pull request, #20325: [improve][misc] Enable rebase and merge to handle one PR of multiple semantic commits
tisonkun opened a new pull request, #20325: URL: https://github.com/apache/pulsar/pull/20325 For example https://github.com/apache/pulsar/pull/20321. Most of the time we use squash and merge, but rebase and merge help sometimes to keep commits separate while reviewing them at once. ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on pull request #576: build: add containerized building
visortelle commented on PR #576: URL: https://github.com/apache/pulsar-site/pull/576#issuecomment-1547519990 Confirm, it works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] 01/01: [improve][misc] Enable rebase and merge to handle one PR of multiple semantic commits
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch tisonkun-patch-1 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 1c34443f7ac7844153baadebeb5f131b0e98006d Author: tison AuthorDate: Mon May 15 17:37:45 2023 +0800 [improve][misc] Enable rebase and merge to handle one PR of multiple semantic commits --- .asf.yaml | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.asf.yaml b/.asf.yaml index 459dcb6e2fe..5c3b8cb98d9 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -35,12 +35,9 @@ github: # Enable projects for project management boards projects: true enabled_merge_buttons: -# enable squash button: squash: true -# disable merge button: merge: false -# disable rebase button: -rebase: false +rebase: true protected_branches: master: required_status_checks:
[pulsar] branch tisonkun-patch-1 created (now 1c34443f7ac)
This is an automated email from the ASF dual-hosted git repository. tison pushed a change to branch tisonkun-patch-1 in repository https://gitbox.apache.org/repos/asf/pulsar.git at 1c34443f7ac [improve][misc] Enable rebase and merge to handle one PR of multiple semantic commits This branch includes the following new commits: new 1c34443f7ac [improve][misc] Enable rebase and merge to handle one PR of multiple semantic commits The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #560: PIP-249 site redesign
tisonkun commented on code in PR #560:
URL: https://github.com/apache/pulsar-site/pull/560#discussion_r1193572269
##
docusaurus.config.js:
##
@@ -124,298 +125,321 @@ const injectLinkParseForEndpoint = ([, info]) => {
/** @type {import('@docusaurus/types').Config} */
module.exports = {
-title: "Apache Pulsar",
-tagline: "Apache Pulsar is a distributed, open source pub-sub messaging
and streaming platform for real-time workloads, managing hundreds of billions
of events per day.",
-url: "https://pulsar.apache.org;,
-baseUrl: baseUrl,
-onBrokenLinks: "warn",
-onBrokenMarkdownLinks: "warn",
-favicon: "img/favicon.ico",
-organizationName: "apache",
-projectName: "pulsar",
-customFields: {
-githubUrl,
-oldUrl,
+ title: "Apache Pulsar",
+ tagline:
+"Apache Pulsar is a distributed, open source pub-sub messaging and
streaming platform for real-time workloads, managing hundreds of billions of
events per day.",
+ url: "https://pulsar.apache.org;,
+ baseUrl: baseUrl,
+ onBrokenLinks: "warn",
+ onBrokenMarkdownLinks: "warn",
+ favicon: "img/favicon.ico",
+ organizationName: "apache",
+ projectName: "pulsar",
+ customFields: {
+githubUrl,
+oldUrl,
+ },
+ trailingSlash: true,
+ themeConfig: {
+/** @type {import('@docusaurus/preset-classic').ThemeConfig} */
+announcementBar: {
+ id: "summit",
+ content: renderAnnouncementBar(
+"Pulsar Virtual Summit Europe 2023",
+"https://pulsar-summit.org/event/europe-2023;
+ ),
+ backgroundColor: "#282826",
+ textColor: "#fff",
+ isCloseable: false,
},
-trailingSlash: true,
-themeConfig: {
-/** @type {import('@docusaurus/preset-classic').ThemeConfig} */
-announcementBar: {
-id: "summit",
-content: ` Pulsar Virtual Summit Europe 2023 will take place on
Tuesday, May 23rd, 2023! https://events.zoom.us/ev/Ap6rsDg9LeVfmdajJ_eB13HH026J1d_o8OoTKkQnl_jzVl-srhwB~AggLXsr32QYFjq8BlYLZ5I06Dg;>Register
now for free!`,
-backgroundColor: "#198fff",
-textColor: "#fff",
-isCloseable: true,
+colorMode: {
+ disableSwitch: true,
+},
+navbar: {
+ title: "",
+ logo: {
+alt: "pulsar logo",
+src: "img/logo-black.svg",
+ },
+ items: [
+{
+ type: "dropdown",
+ label: "Get Started",
+ position: "left",
+ items: [
+{
+ to: "/docs/next/concepts-overview/",
+ activeBaseRegex: "docs/next/concepts-overview/$",
+ label: "Pulsar Concepts",
+},
+{
+ to: "/docs/next/",
+ activeBaseRegex: "docs/next/$",
+ label: "Quickstart",
+},
+{
+ to: "/ecosystem/",
+ label: "Ecosystem",
+},
+ ],
},
-colorMode: {
-disableSwitch: false,
+{
+ type: "doc",
+ docId: "about",
+ position: "left",
+ label: "Docs",
},
-navbar: {
-title: "",
-logo: {
-alt: "pulsar logo",
-src: "img/logo.svg",
-},
-items: [
-{
-type: "dropdown",
-label: "Get Started",
-position: "right",
-items: [
-{
-type: 'doc',
-docId: 'concepts-overview',
-label: "Pulsar Concepts",
-},
-{
-type: 'doc',
-docId: 'about',
-label: "Quickstart",
-},
-{
-to: "/ecosystem/",
-label: "Ecosystem",
-},
-],
-},
-{
-type: 'doc',
-docId: 'about',
-position: "right",
-label: "Docs",
-},
-{
-to: "/contribute/",
-position: "right",
-label: "Contribute",
-},
-{
-type: "dropdown",
-label: "Community",
-position: "right",
-className: "community-dropdown",
-items: [
-{
-to: "/community#section-welcome",
-label: "Welcome",
-className: "scroll-link scroll-welcome",
-id: "scroll-welcome",
-},
-{
-
[GitHub] [pulsar] tisonkun commented on pull request #20316: [improve][cli] Allow pulser-client consume create a replicated subscription
tisonkun commented on PR #20316: URL: https://github.com/apache/pulsar/pull/20316#issuecomment-1547491520 > The doc could be generated automatically Yes, specifically, in [this script](https://github.com/apache/pulsar-site/blob/cc349c2a440cd5da3ccbd7ecb771e93f57ec745d/tools/pytools/lib/execute/pulsar_client_clidoc_generator.py). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #20316: [improve][cli] Allow pulser-client consume create a replicated subscription
JooHyukKim commented on PR #20316: URL: https://github.com/apache/pulsar/pull/20316#issuecomment-1547491447 > Thanks for your contribution! I renamed the pull request with "cli" since this only affects the CLI component Right, thank you for the revision @nicoloboschi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #574: [feat][doc] Add reference docs for 3.0.x
tisonkun commented on PR #574: URL: https://github.com/apache/pulsar-site/pull/574#issuecomment-1547470500 We do release the docs, but didn't add it to the sidebar. See https://github.com/apache/pulsar-site/pull/575. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #576: build: add containerized building
tisonkun commented on PR #576: URL: https://github.com/apache/pulsar-site/pull/576#issuecomment-1547456121 Still, we need `.build-versions.json ` to specify build versions. I'm preparing a patch to use environment variable so that we can easily integrate it in the containerized building process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun opened a new pull request, #576: build: add containerized building
tisonkun opened a new pull request, #576: URL: https://github.com/apache/pulsar-site/pull/576 This PR fixes https://github.com/apache/pulsar/issues/20272 - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` cc @visortelle @asafm welcome to test in your env: ``` docker-compose up ``` ... should simply work and you can browse at -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on a diff in pull request #20316: [improve][client] Allow pulser-client consume create a replicated subscription
JooHyukKim commented on code in PR #20316:
URL: https://github.com/apache/pulsar/pull/20316#discussion_r1193516263
##
pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdConsume.java:
##
@@ -156,7 +159,8 @@ private int consume(String topic) {
.subscriptionType(subscriptionType)
.subscriptionMode(subscriptionMode)
.subscriptionInitialPosition(subscriptionInitialPosition)
-.poolMessages(poolMessages);
+.poolMessages(poolMessages)
+.replicateSubscriptionState(replicatedSubscription);
Review Comment:
> It's better to keep the same name
Right, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #20257: [fix][broker] Fix ledger cachemiss size metric
Technoboy- commented on PR #20257: URL: https://github.com/apache/pulsar/pull/20257#issuecomment-1547413388 We don't need `valueRate`, so it seems no need to fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated (7e54e9b0463 -> c5ceec72d6d)
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 7e54e9b0463 [fix][broker] Fix class name typo `PrecisPublishLimiter` to "Precise" (#20310) add c5ceec72d6d [fix][test] Flaky-test: SimpleProducerConsumerTestStreamingDispatcherTest. rest (#20286) No new revisions were added by this update. Summary of changes: .../test/java/org/apache/pulsar/broker/service/BrokerServiceTest.java | 2 -- 1 file changed, 2 deletions(-)
[GitHub] [pulsar] Technoboy- merged pull request #20286: [fix][test] Flaky-test: SimpleProducerConsumerTestStreamingDispatcherTest. rest
Technoboy- merged PR #20286: URL: https://github.com/apache/pulsar/pull/20286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Technoboy- closed issue #20285: Flaky-test: SimpleProducerConsumerTestStreamingDispatcherTest. rest
Technoboy- closed issue #20285: Flaky-test: SimpleProducerConsumerTestStreamingDispatcherTest. rest URL: https://github.com/apache/pulsar/issues/20285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #20316: [improve][client] Allow pulser-client consume create a replicated subscription
Technoboy- commented on PR #20316: URL: https://github.com/apache/pulsar/pull/20316#issuecomment-1547380257 @tisonkun The doc could be generated automatically, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-manager] MrMigel opened a new issue, #516: Only one user can be logged in / created
MrMigel opened a new issue, #516: URL: https://github.com/apache/pulsar-manager/issues/516 Hi, Pulsar manager is quite helpful in administering the cluster, but it has one disadvantage. It is not possible to add more than one user - there can only be one administrator. This might not be a big problem except that this user can only be used by one person at a time. When we work in a team, we interrupt each other all the time. When I am working with pulsar manager and another person opens it, I get logged out immediately. I tried using two PM instances, however the effect is the same :( Is there any solution? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #560: PIP-249 site redesign
tisonkun commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1547373759 The file you link is quite old and I don't think it helps here. https://github.com/apache/pulsar/issues/20272 tracks your need IIUC and let me prepare a patch today against this repo and ping you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #20316: [improve][client] Allow pulser-client consume create a replicated subscription
Technoboy- commented on code in PR #20316:
URL: https://github.com/apache/pulsar/pull/20316#discussion_r1193469989
##
pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdConsume.java:
##
@@ -156,7 +159,8 @@ private int consume(String topic) {
.subscriptionType(subscriptionType)
.subscriptionMode(subscriptionMode)
.subscriptionInitialPosition(subscriptionInitialPosition)
-.poolMessages(poolMessages);
+.poolMessages(poolMessages)
+.replicateSubscriptionState(replicatedSubscription);
Review Comment:
It's better to keep the same name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun merged pull request #575: [fix][doc] Add 3.0.x reference docs in sidebar
tisonkun merged PR #575: URL: https://github.com/apache/pulsar-site/pull/575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-site] branch main updated: [fix][doc] Add 3.0.x reference docs in sidebar (#575)
This is an automated email from the ASF dual-hosted git repository.
tison pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new cc349c2a440 [fix][doc] Add 3.0.x reference docs in sidebar (#575)
cc349c2a440 is described below
commit cc349c2a440cd5da3ccbd7ecb771e93f57ec745d
Author: tison
AuthorDate: Mon May 15 15:53:42 2023 +0800
[fix][doc] Add 3.0.x reference docs in sidebar (#575)
Signed-off-by: tison
---
static/reference/index.html | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/static/reference/index.html b/static/reference/index.html
index 96fee80143d..fc26b119b6f 100644
--- a/static/reference/index.html
+++ b/static/reference/index.html
@@ -201,6 +201,7 @@
'2.9.x' +
'2.10.x' +
'2.11.x' +
+ '3.0.x' +
'next' +
"",
repo: "apache/pulsar",
@@ -213,7 +214,7 @@
namespaces: [
{
id: "version",
-values: ["2.6.x", "2.7.x", "2.8.x", "2.9.x", "2.10.x", "2.11.x",
"next"],
+values: ["2.6.x", "2.7.x", "2.8.x", "2.9.x", "2.10.x", "2.11.x",
"3.0.x", "next"],
optional: true,
selector: "#ver-selector",
default: "next",
[GitHub] [pulsar-site] tisonkun opened a new pull request, #575: [fix][doc] Add 3.0.x reference docs in sidebar
tisonkun opened a new pull request, #575: URL: https://github.com/apache/pulsar-site/pull/575 - [x] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun closed pull request #574: [feat][doc] Add reference docs for 3.0.x
tisonkun closed pull request #574: [feat][doc] Add reference docs for 3.0.x URL: https://github.com/apache/pulsar-site/pull/574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun opened a new pull request, #574: [feat][doc] Add reference docs for 3.0.x
tisonkun opened a new pull request, #574: URL: https://github.com/apache/pulsar-site/pull/574 - [x] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on pull request #560: PIP-249 site redesign
visortelle commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1547354948 @tisonkun maybe there is any way to build a full site in Docker? I want to be able to build a site in a single command and don't think about tools, or their versions. Or maybe you have such plans? If yes, I'd be happy to help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch master updated: [fix][broker] Fix class name typo `PrecisPublishLimiter` to "Precise" (#20310)
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 7e54e9b0463 [fix][broker] Fix class name typo `PrecisPublishLimiter`
to "Precise" (#20310)
7e54e9b0463 is described below
commit 7e54e9b0463f5c69846dc44892d88281d5508466
Author: Kim, Joo Hyuk
AuthorDate: Mon May 15 16:29:50 2023 +0900
[fix][broker] Fix class name typo `PrecisPublishLimiter` to "Precise"
(#20310)
---
.../pulsar/broker/service/AbstractTopic.java | 2 +-
...lishLimiter.java => PrecisePublishLimiter.java} | 10 +++
.../PrecisTopicPublishRateThrottleTest.java| 2 +-
...terTest.java => PrecisePublishLimiterTest.java} | 30 +--
.../broker/service/PublishRateLimiterTest.java | 34 --
5 files changed, 40 insertions(+), 38 deletions(-)
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
index 8269dc0c3d1..4614b846c8e 100644
---
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
+++
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
@@ -1274,7 +1274,7 @@ public abstract class AbstractTopic implements Topic,
TopicPolicyListener this.enableCnxAutoRead(),
brokerService.pulsar().getExecutor());
} else {
this.topicPublishRateLimiter = new
PublishRateLimiterImpl(publishRate);
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisPublishLimiter.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisePublishLimiter.java
similarity index 93%
rename from
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisPublishLimiter.java
rename to
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisePublishLimiter.java
index 6e215b3b495..ce14f6d7dd7 100644
---
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisPublishLimiter.java
+++
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisePublishLimiter.java
@@ -24,7 +24,7 @@ import org.apache.pulsar.common.policies.data.PublishRate;
import org.apache.pulsar.common.util.RateLimitFunction;
import org.apache.pulsar.common.util.RateLimiter;
-public class PrecisPublishLimiter implements PublishRateLimiter {
+public class PrecisePublishLimiter implements PublishRateLimiter {
protected volatile int publishMaxMessageRate = 0;
protected volatile long publishMaxByteRate = 0;
// precise mode for publish rate limiter
@@ -33,18 +33,18 @@ public class PrecisPublishLimiter implements
PublishRateLimiter {
private final RateLimitFunction rateLimitFunction;
private final ScheduledExecutorService scheduledExecutorService;
-public PrecisPublishLimiter(Policies policies, String clusterName,
RateLimitFunction rateLimitFunction) {
+public PrecisePublishLimiter(Policies policies, String clusterName,
RateLimitFunction rateLimitFunction) {
this.rateLimitFunction = rateLimitFunction;
update(policies, clusterName);
this.scheduledExecutorService = null;
}
-public PrecisPublishLimiter(PublishRate publishRate, RateLimitFunction
rateLimitFunction) {
+public PrecisePublishLimiter(PublishRate publishRate, RateLimitFunction
rateLimitFunction) {
this(publishRate, rateLimitFunction, null);
}
-public PrecisPublishLimiter(PublishRate publishRate, RateLimitFunction
rateLimitFunction,
-ScheduledExecutorService
scheduledExecutorService) {
+public PrecisePublishLimiter(PublishRate publishRate, RateLimitFunction
rateLimitFunction,
+ ScheduledExecutorService
scheduledExecutorService) {
this.rateLimitFunction = rateLimitFunction;
update(publishRate);
this.scheduledExecutorService = scheduledExecutorService;
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PrecisTopicPublishRateThrottleTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PrecisTopicPublishRateThrottleTest.java
index 07632814378..c22ed41fc15 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PrecisTopicPublishRateThrottleTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PrecisTopicPublishRateThrottleTest.java
@@ -164,7 +164,7 @@ public class PrecisTopicPublishRateThrottleTest extends
BrokerTestBase{
"" + rateInMsg));
Topic topicRef =
pulsar.getBrokerService().getTopicReference(topic).get();
Assert.assertNotNull(topicRef);
-PrecisPublishLimiter limiter = ((PrecisPublishLimiter)
((AbstractTopic) topicRef).topicPublishRateLimiter);
+
