Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]
vkagamlyk commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1972581141 > @vkagamlyk or are you suggesting I should create like a simple html page that simply run all the stuffs under `examples`? I thought about something more simple, like html page which runs single query like `g.V().group().by(label).by(count())` and show results. This will be useful for those who want to use Gremlin from the browser, and it will allow developers to relatively easily check the functionality of the driver after changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]
tien commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1972575974 @vkagamlyk or are you suggesting I should create like a simple html page that simply run all the stuffs under `examples`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]
tien commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1972476030 @vkagamlyk also, because the API signature is the exact same, those existing examples can be run just fine in a browser environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]
tien commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1972293541 @vkagamlyk the proper way would be to actually run the unit tests in the browser, like @kmcginnes mentioned. But that could potentially be a huge change to the current test suite. Another way would be to inject a browser `WebSocket` polyfill into the current test suite using `jsdom`. It's not perfect but would require a lot less changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]
tien commented on code in PR #2506:
URL: https://github.com/apache/tinkerpop/pull/2506#discussion_r1508384058
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/client-behavior-tests.js:
##
@@ -21,58 +21,56 @@
const assert = require('assert');
const helper = require('../helper');
-const {getUserAgent} = require("../../lib/utils");
+const { getUserAgent } = require('../../lib/utils');
let client;
let settings;
describe('Client', function () {
-before(function () {
-client = helper.getGremlinSocketServerClient('gmodern');
-settings = helper.getGremlinSocketServerSettings();
-return client.open();
-});
-after(function () {
-return client.close();
-});
-describe('#submit()', function () {
-it('should reconnect after server closes connection', async function
() {
-let connectionClosed = false;
-await client.submit('1', null, {requestId:
settings.CLOSE_CONNECTION_REQUEST_ID})
-.catch(function(error){
-assert.equal(error.toString(), 'Error: Connection has been
closed.');
-connectionClosed = true;
-});
+ before(function () {
Review Comment:
But in saying that, I've reverted all the style changes here for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]
vkagamlyk commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1972279090 Is there way to simply test these changes in different browsers? @tien maybe you have a simple application that can be put into [examples](https://github.com/apache/tinkerpop/tree/master/gremlin-javascript/examples) and run to check the basic functionality of the driver? This can also be used as an example for users -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]
tien commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1972252523 @kenhuuu Node 18 is compatible with all ES2022 features, so the changes to ESLint should be good. Regarding the Node version, I'm okay with keeping it 18 now. Since it would be beneficial for me if this is available before 4.0. I'm integrating gremlin with some of the things at my work & it's easier to justify installing a dependency from an official source, rather than my fork :)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]
tien commented on code in PR #2506:
URL: https://github.com/apache/tinkerpop/pull/2506#discussion_r1508361689
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/client-behavior-tests.js:
##
@@ -21,58 +21,56 @@
const assert = require('assert');
const helper = require('../helper');
-const {getUserAgent} = require("../../lib/utils");
+const { getUserAgent } = require('../../lib/utils');
let client;
let settings;
describe('Client', function () {
-before(function () {
-client = helper.getGremlinSocketServerClient('gmodern');
-settings = helper.getGremlinSocketServerSettings();
-return client.open();
-});
-after(function () {
-return client.close();
-});
-describe('#submit()', function () {
-it('should reconnect after server closes connection', async function
() {
-let connectionClosed = false;
-await client.submit('1', null, {requestId:
settings.CLOSE_CONNECTION_REQUEST_ID})
-.catch(function(error){
-assert.equal(error.toString(), 'Error: Connection has been
closed.');
-connectionClosed = true;
-});
+ before(function () {
Review Comment:
Yes, this is from prettier formatting. I've got my editor setup to
automatically format on save if the project have prettier setted up, which is
project have. I think it's a good idea to enforce formatting rule, even on CI.
But if an exception should be made for the test files, should I add all test
files to `.prettierignore` then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]
kenhuuu commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1972243401 You are targetting this PR against the master branch which is currently for the next major release (4.0). The way our branching system works is that you target the lowest version that you want the change to go into. Then when your PR gets merged, the committer will merge your changes all the way up to the latest master branch. It's a bit difficult to explain so I'll use an example. If you want your changes to go into the next 3.6.x, 3.7.x and 4.x release, then you would target the 3.6-dev branch and it will get merged up for you. If you target master then it will only go into the next 4.x release. I say this because I believe that currently there is no timeline for releasing 4.0 as we are doing releases for 3.6.x and 3.7.x. So if you were to target master then you may need to wait for a while for this change to get released. However, because its currently targetting an unreleased branch, you are technically allowed to upgrade the Node version and ES version. So, do you prefer to wait for this change to arrive in 4.x? In which case, you can make Node and ES version changes. Or, if you want it released sooner then you will probably have to undo your changes to ESLint and target the 3.7-dev branch as some of those changes could be considered breaking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]
kenhuuu commented on code in PR #2506:
URL: https://github.com/apache/tinkerpop/pull/2506#discussion_r1508348225
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/client-behavior-tests.js:
##
@@ -21,58 +21,56 @@
const assert = require('assert');
const helper = require('../helper');
-const {getUserAgent} = require("../../lib/utils");
+const { getUserAgent } = require('../../lib/utils');
let client;
let settings;
describe('Client', function () {
-before(function () {
-client = helper.getGremlinSocketServerClient('gmodern');
-settings = helper.getGremlinSocketServerSettings();
-return client.open();
-});
-after(function () {
-return client.close();
-});
-describe('#submit()', function () {
-it('should reconnect after server closes connection', async function
() {
-let connectionClosed = false;
-await client.submit('1', null, {requestId:
settings.CLOSE_CONNECTION_REQUEST_ID})
-.catch(function(error){
-assert.equal(error.toString(), 'Error: Connection has been
closed.');
-connectionClosed = true;
-});
+ before(function () {
Review Comment:
I noticed that for the test files a lot of the indentation was changed. I'm
assuming this was done by a linter but do you mind reverting it back to what it
was before. It's a bit difficult to read the Gremlin queries when they are
split over multiple lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(tinkerpop) branch master updated (77e4f71647 -> 03e9f24f06)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 77e4f71647 Merge branch '3.7-dev' add 1efe40b288 TINKERPOP-3054 Fix requestId Deserialization in `gremlin-python` (#2494) add cc9b3cf02c Merge branch '3.6-dev' into 3.7-dev new 03e9f24f06 Merge branch '3.7-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 5 +++-- gremlin-python/src/main/python/gremlin_python/driver/connection.py | 7 --- gremlin-python/src/main/python/gremlin_python/driver/serializer.py | 2 +- gremlin-python/src/main/python/tests/driver/test_client.py | 6 +- 4 files changed, 13 insertions(+), 7 deletions(-)
(tinkerpop) 01/01: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 03e9f24f062c507ed665c5700a90235249e652a9 Merge: 77e4f71647 cc9b3cf02c Author: Cole-Greer AuthorDate: Thu Feb 29 09:02:27 2024 -0800 Merge branch '3.7-dev' CHANGELOG.asciidoc | 5 +++-- gremlin-python/src/main/python/gremlin_python/driver/connection.py | 7 --- gremlin-python/src/main/python/gremlin_python/driver/serializer.py | 2 +- gremlin-python/src/main/python/tests/driver/test_client.py | 6 +- 4 files changed, 13 insertions(+), 7 deletions(-)
(tinkerpop) 01/01: Merge branch '3.6-dev' into 3.7-dev
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit cc9b3cf02c1e5d68a0583e2571e1a2a22d9fa249 Merge: 88acbad25a 1efe40b288 Author: Cole-Greer AuthorDate: Thu Feb 29 08:56:53 2024 -0800 Merge branch '3.6-dev' into 3.7-dev CHANGELOG.asciidoc | 5 +++-- gremlin-python/src/main/python/gremlin_python/driver/connection.py | 7 --- gremlin-python/src/main/python/gremlin_python/driver/serializer.py | 2 +- gremlin-python/src/main/python/tests/driver/test_client.py | 6 +- 4 files changed, 13 insertions(+), 7 deletions(-)
(tinkerpop) branch 3.7-dev updated (88acbad25a -> cc9b3cf02c)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 88acbad25a Change edge weights to double in feature tests (#2503) add 1efe40b288 TINKERPOP-3054 Fix requestId Deserialization in `gremlin-python` (#2494) new cc9b3cf02c Merge branch '3.6-dev' into 3.7-dev The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 5 +++-- gremlin-python/src/main/python/gremlin_python/driver/connection.py | 7 --- gremlin-python/src/main/python/gremlin_python/driver/serializer.py | 2 +- gremlin-python/src/main/python/tests/driver/test_client.py | 6 +- 4 files changed, 13 insertions(+), 7 deletions(-)
(tinkerpop) branch 3.6-dev updated (3166f1b347 -> 1efe40b288)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 3166f1b347 Bump github.com/nicksnyder/go-i18n/v2 from 2.3.0 to 2.4.0 in /gremlin-go (#2469) add 1efe40b288 TINKERPOP-3054 Fix requestId Deserialization in `gremlin-python` (#2494) No new revisions were added by this update. Summary of changes: CHANGELOG.asciidoc | 5 +++-- gremlin-python/src/main/python/gremlin_python/driver/connection.py | 7 --- gremlin-python/src/main/python/gremlin_python/driver/serializer.py | 2 +- gremlin-python/src/main/python/tests/driver/test_client.py | 6 +- 4 files changed, 13 insertions(+), 7 deletions(-)
Re: [PR] TINKERPOP-3054 Fix requestId Deserialization in `gremlin-python` [tinkerpop]
Cole-Greer merged PR #2494: URL: https://github.com/apache/tinkerpop/pull/2494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-3054 Fix requestId Deserialization in `gremlin-python` [tinkerpop]
Cole-Greer commented on PR #2494: URL: https://github.com/apache/tinkerpop/pull/2494#issuecomment-1971562226 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch master updated (83e66fdc5a -> 77e4f71647)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 83e66fdc5a Merge branch '3.7-dev' add 3976dbf884 Add true case tests for checkAdjacentVertices configuration (#2502) add 88acbad25a Change edge weights to double in feature tests (#2503) new 77e4f71647 Merge branch '3.7-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 28 ++- gremlin-go/driver/cucumber/gremlin.go | 28 ++- .../gremlin-javascript/test/cucumber/gremlin.js| 28 ++- gremlin-python/src/main/python/radish/gremlin.py | 28 ++- .../features/integrated/PartitionStrategy.feature | 56 +++--- .../features/integrated/SubgraphStrategy.feature | 32 - .../gremlin/test/features/map/MergeEdge.feature| 2 +- 7 files changed, 120 insertions(+), 82 deletions(-)
(tinkerpop) 01/01: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 77e4f716474b802b06f1de37427b18baf63dfc9c Merge: 83e66fdc5a 88acbad25a Author: Cole-Greer AuthorDate: Thu Feb 29 08:40:31 2024 -0800 Merge branch '3.7-dev' .../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 28 ++- gremlin-go/driver/cucumber/gremlin.go | 28 ++- .../gremlin-javascript/test/cucumber/gremlin.js| 28 ++- gremlin-python/src/main/python/radish/gremlin.py | 28 ++- .../features/integrated/PartitionStrategy.feature | 56 +++--- .../features/integrated/SubgraphStrategy.feature | 32 - .../gremlin/test/features/map/MergeEdge.feature| 2 +- 7 files changed, 120 insertions(+), 82 deletions(-)
(tinkerpop) branch 3.7-dev updated: Change edge weights to double in feature tests (#2503)
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch 3.7-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/3.7-dev by this push:
new 88acbad25a Change edge weights to double in feature tests (#2503)
88acbad25a is described below
commit 88acbad25a4f07fbc28bf761a09def3d5805c562
Author: Ryan Tan <65996005+r...@users.noreply.github.com>
AuthorDate: Thu Feb 29 08:31:42 2024 -0800
Change edge weights to double in feature tests (#2503)
https://issues.apache.org/jira/browse/TINKERPOP-3020 Updated all edge
weights to use type double in PartitionStrategy and SideEffect feature tests.
---
.../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 26 +-
gremlin-go/driver/cucumber/gremlin.go | 26 +-
.../gremlin-javascript/test/cucumber/gremlin.js| 26 +-
gremlin-python/src/main/python/radish/gremlin.py | 26 +-
.../features/integrated/PartitionStrategy.feature | 56 +++---
.../gremlin/test/features/map/MergeEdge.feature| 2 +-
6 files changed, 81 insertions(+), 81 deletions(-)
diff --git a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
index fd96bdc6ea..d99f0d1672 100644
--- a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
+++ b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
@@ -399,18 +399,18 @@ namespace Gremlin.Net.IntegrationTest.Gherkin
{"g_withStrategiesXPartitionStrategyXwrite_a_read_aXX_V_name",
new List, ITraversal>>
{(g,p)
=>g.AddV("person").Property("_partition","a").Property("name","alice").AddV("person").Property("_partition","b").Property("name","bob"),
(g,p) =>g.WithStrategies(new PartitionStrategy(includeMetaProperties: false,
partitionKey: "_partition", readPartitions: new HashSet {"a"},
writePartition: "a")).V().Values("na [...]
{"g_withStrategiesXPartitionStrategyXwrite_a_read_a_bXX_V_name", new
List, ITraversal>>
{(g,p)
=>g.AddV("person").Property("_partition","a").Property("name","alice").AddV("person").Property("_partition","b").Property("name","bob"),
(g,p) =>g.WithStrategies(new PartitionStrategy(includeMetaProperties: false,
partitionKey: "_partition", readPartitions: new HashSet {"a", "b"},
writePartition: "a")).V().Values, ITraversal>>
{(g,p)
=>g.AddV("person").Property("_partition","a").Property("name","alice").AddV("person").Property("_partition","b").Property("name","bob"),
(g,p) =>g.WithStrategies(new PartitionStrategy(includeMetaProperties: false,
partitionKey: "_partition", readPartitions: new HashSet {"c"},
writePartition: "a")).V().Values("na [...]
-
{"g_withStrategiesXPartitionStrategyXwrite_a_read_aXX_V_bothE_weight", new
List, ITraversal>>
{(g,p)
=>g.AddV("person").Property("_partition","a").Property("name","alice").As("a").AddV("person").Property("_partition","b").Property("name","bob").As("b").AddE("knows").From("a").To("b").Property("_partition","a").Property("weight",1).AddE("knows").From("b").To("a").Property("_partition","b").Property("weight",2),
(g,p) => [...]
-
{"g_withStrategiesXPartitionStrategyXwrite_a_read_bXX_V_bothE_weight", new
List, ITraversal>>
{(g,p)
=>g.AddV("person").Property("_partition","a").Property("name","alice").As("a").AddV("person").Property("_partition","b").Property("name","bob").As("b").AddE("knows").From("a").To("b").Property("_partition","a").Property("weight",1).AddE("knows").From("b").To("a").Property("_partition","b").Property("weight",2),
(g,p) => [...]
-
{"g_withStrategiesXPartitionStrategyXwrite_a_read_a_bXX_V_bothE_dedup_weight",
new List, ITraversal>>
{(g,p)
=>g.AddV("person").Property("_partition","a").Property("name","alice").As("a").AddV("person").Property("_partition","b").Property("name","bob").As("b").AddE("knows").From("a").To("b").Property("_partition","a").Property("weight",1).AddE("knows").From("b").To("a").Property("_partition","b").Property("weight",2),
[...]
-
{"g_withStrategiesXPartitionStrategyXwrite_a_read_cXX_V_bothE_weight", new
List, ITraversal>>
{(g,p)
=>g.AddV("person").Property("_partition","a").Property("name","alice").As("a").AddV("person").Property("_partition","b").Property("name","bob").As("b").AddE("knows").From("a").To("b").Property("_partition","a").Property("weight",1).AddE("knows").From("b").To("a").Property("_partition","b").Property("weight",2),
(g,p) => [...]
-
{"g_withStrategiesXPartitionStrategyXwrite_a_read_aXX_V_both_name", new
List, ITraversal>>
{(g,p)
=>g.AddV("person").Property("_partition","a").Property("name","alice").As("a").AddV("person").Property("_partition","b").Property("name","bob").As("b").AddE("knows").From("a").To("b").Property("_partition","a").Property("weight",1).AddE("knows").From("b").To("a").Property("_
Re: [PR] Update edge weights to use double in PartitionStrategy tests [tinkerpop]
Cole-Greer merged PR #2503: URL: https://github.com/apache/tinkerpop/pull/2503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch 3.7-dev updated: Add true case tests for checkAdjacentVertices configuration (#2502)
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch 3.7-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/3.7-dev by this push:
new 3976dbf884 Add true case tests for checkAdjacentVertices configuration
(#2502)
3976dbf884 is described below
commit 3976dbf88446969be4f40d213a02b72d1324888a
Author: Ryan Tan <65996005+r...@users.noreply.github.com>
AuthorDate: Thu Feb 29 08:31:14 2024 -0800
Add true case tests for checkAdjacentVertices configuration (#2502)
https://issues.apache.org/jira/browse/TINKERPOP-3026 Added tests to cover
checkAdjacentVertices = true in SubgraphStrategy configuration.
---
.../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 2 ++
gremlin-go/driver/cucumber/gremlin.go | 2 ++
.../gremlin-javascript/test/cucumber/gremlin.js| 2 ++
gremlin-python/src/main/python/radish/gremlin.py | 2 ++
.../features/integrated/SubgraphStrategy.feature | 32 +-
5 files changed, 39 insertions(+), 1 deletion(-)
diff --git a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
index ccfa82b240..fd96bdc6ea 100644
--- a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
+++ b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
@@ -478,6 +478,7 @@ namespace Gremlin.Net.IntegrationTest.Gherkin
{"g_withStrategiesXSubgraphStrategyXedges_hasLabelXusesX_hasXskill_5XXX_V_outE_valueMap_selectXvaluesX_unfold",
new List, ITraversal>>
{(g,p) =>g.WithStrategies(new SubgraphStrategy(checkAdjacentVertices: true,
edges:
__.HasLabel("uses").Has("skill",5))).V().OutE().ValueMap().Select(Column.Values).Unfold()}},
{"g_withStrategiesXSubgraphStrategyXsubgraphDXX_V", new
List, ITraversal>>
{(g,p) =>g.WithStrategies(new SubgraphStrategy(checkAdjacentVertices: false,
vertices: __.Has("name",P.Within(new List {"josh", "lop", "ripple"})),
edges:
__.Or(__.Has("weight",0.4).HasLabel("created"),__.Has("weight",1.0).HasLabel("created".V()}},
{"g_withStrategiesXSubgraphStrategyXsubgraphDXX_E", new
List, ITraversal>>
{(g,p) =>g.WithStrategies(new SubgraphStrategy(checkAdjacentVertices: false,
vertices: __.Has("name",P.Within(new List {"josh", "lop", "ripple"})),
edges:
__.Or(__.Has("weight",0.4).HasLabel("created"),__.Has("weight",1.0).HasLabel("created".E()}},
+
{"g_withStrategiesXSubgraphStrategyXcheckAdjacentVertices_subgraphDXX_E", new
List, ITraversal>>
{(g,p) =>g.WithStrategies(new SubgraphStrategy(checkAdjacentVertices: true,
vertices: __.Has("name",P.Within(new List {"josh", "lop", "ripple"})),
edges:
__.Or(__.Has("weight",0.4).HasLabel("created"),__.Has("weight",1.0).HasLabel("created".E()}},
{"g_withStrategiesXSubgraphStrategyXsubgraphDXX_VX4X_outE", new
List, ITraversal>>
{(g,p) =>g.WithStrategies(new SubgraphStrategy(checkAdjacentVertices: false,
vertices: __.Has("name",P.Within(new List {"josh", "lop", "ripple"})),
edges:
__.Or(__.Has("weight",0.4).HasLabel("created"),__.Has("weight",1.0).HasLabel("created".V(p["vid4"]).OutE()}},
{"g_withStrategiesXSubgraphStrategyXsubgraphDXX_VX4X_inE", new
List, ITraversal>>
{(g,p) =>g.WithStrategies(new SubgraphStrategy(checkAdjacentVertices: false,
vertices: __.Has("name",P.Within(new List {"josh", "lop", "ripple"})),
edges:
__.Or(__.Has("weight",0.4).HasLabel("created"),__.Has("weight",1.0).HasLabel("created".V(p["vid4"]).InE()}},
{"g_withStrategiesXSubgraphStrategyXsubgraphDXX_VX4X_out", new
List, ITraversal>>
{(g,p) =>g.WithStrategies(new SubgraphStrategy(checkAdjacentVertices: false,
vertices: __.Has("name",P.Within(new List {"josh", "lop", "ripple"})),
edges:
__.Or(__.Has("weight",0.4).HasLabel("created"),__.Has("weight",1.0).HasLabel("created".V(p["vid4"]).Out()}},
@@ -488,6 +489,7 @@ namespace Gremlin.Net.IntegrationTest.Gherkin
{"g_withStrategiesXSubgraphStrategyXsubgraphDXX_EX11X_bothV",
new List, ITraversal>>
{(g,p) =>g.WithStrategies(new SubgraphStrategy(checkAdjacentVertices: false,
vertices: __.Has("name",P.Within(new List {"josh", "lop", "ripple"})),
edges:
__.Or(__.Has("weight",0.4).HasLabel("created"),__.Has("weight",1.0).HasLabel("created".E(p["eid11"]).BothV()}},
{"g_withStrategiesXSubgraphStrategyXsubgraphDXX_EX12X_bothV",
new List, ITraversal>>
{(g,p) =>g.WithStrategies(new SubgraphStrategy(checkAdjacentVertices: false,
vertices: __.Has("name",P.Within(new List {"josh", "lop", "ripple"})),
edges:
__.Or(__.Has("weight",0.4).HasLabel("created"),__.Has("weight",1.0).HasLabel("created".E(p["eid12"]).BothV()}},
{"g_withStrategiesXSubgraphStrategyXsubgraphDXX_EX9X_bothV",
new List, ITraversal>>
{(g,p) =>g.WithStrategies(new
Re: [PR] Add true case tests for checkAdjacentVertices configuration [tinkerpop]
Cole-Greer merged PR #2502: URL: https://github.com/apache/tinkerpop/pull/2502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) 01/01: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 83e66fdc5a88446f4bc763f7e15d9ad911cf7516 Merge: 98236ba70a 7f73599f74 Author: Cole-Greer AuthorDate: Thu Feb 29 08:27:29 2024 -0800 Merge branch '3.7-dev' gremlin-go/go.mod | 4 +- gremlin-go/go.sum | 8 +- .../gremlin-javascript/package-lock.json | 151 +++-- 3 files changed, 57 insertions(+), 106 deletions(-)
(tinkerpop) branch master updated (98236ba70a -> 83e66fdc5a)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 98236ba70a Squash of 3 docs/gremlint dependabots add b7115b57d3 Bump eslint (#2507) add af5c9148b6 Bump mocha in /gremlin-javascript/src/main/javascript/gremlin-javascript (#2484) add ddb646e51e Bump github.com/cucumber/godog from 0.13.0 to 0.14.0 in /gremlin-go (#2471) add 3166f1b347 Bump github.com/nicksnyder/go-i18n/v2 from 2.3.0 to 2.4.0 in /gremlin-go (#2469) add 7f73599f74 Merge branch '3.6-dev' into 3.7-dev new 83e66fdc5a Merge branch '3.7-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: gremlin-go/go.mod | 4 +- gremlin-go/go.sum | 8 +- .../gremlin-javascript/package-lock.json | 151 +++-- 3 files changed, 57 insertions(+), 106 deletions(-)
(tinkerpop) branch 3.7-dev updated (a919b90ebe -> 7f73599f74)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from a919b90ebe Merge branch '3.6-dev' into 3.7-dev add b7115b57d3 Bump eslint (#2507) add af5c9148b6 Bump mocha in /gremlin-javascript/src/main/javascript/gremlin-javascript (#2484) add ddb646e51e Bump github.com/cucumber/godog from 0.13.0 to 0.14.0 in /gremlin-go (#2471) add 3166f1b347 Bump github.com/nicksnyder/go-i18n/v2 from 2.3.0 to 2.4.0 in /gremlin-go (#2469) new 7f73599f74 Merge branch '3.6-dev' into 3.7-dev The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: gremlin-go/go.mod | 4 +- gremlin-go/go.sum | 8 +- .../gremlin-javascript/package-lock.json | 151 +++-- 3 files changed, 57 insertions(+), 106 deletions(-)
(tinkerpop) 01/01: Merge branch '3.6-dev' into 3.7-dev
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 7f73599f74db02a188f37d5168efa84f39c2d068 Merge: a919b90ebe 3166f1b347 Author: Cole-Greer AuthorDate: Thu Feb 29 08:16:20 2024 -0800 Merge branch '3.6-dev' into 3.7-dev gremlin-go/go.mod | 4 +- gremlin-go/go.sum | 8 +- .../gremlin-javascript/package-lock.json | 151 +++-- 3 files changed, 57 insertions(+), 106 deletions(-) diff --cc gremlin-go/go.mod index 49824ef350,111ad2210b..a44e094cc7 --- a/gremlin-go/go.mod +++ b/gremlin-go/go.mod @@@ -20,13 -20,12 +20,13 @@@ module github.com/apache/tinkerpop/grem go 1.20 require ( - github.com/cucumber/godog v0.13.0 + github.com/cucumber/godog v0.14.0 github.com/google/uuid v1.6.0 github.com/gorilla/websocket v1.5.1 - github.com/nicksnyder/go-i18n/v2 v2.3.0 + github.com/nicksnyder/go-i18n/v2 v2.4.0 github.com/stretchr/testify v1.8.4 golang.org/x/text v0.14.0 + gopkg.in/yaml.v3 v3.0.1 ) require (
Re: [PR] Update edge weights to use double in PartitionStrategy tests [tinkerpop]
vkagamlyk commented on PR #2503: URL: https://github.com/apache/tinkerpop/pull/2503#issuecomment-1971502583 VOTE+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add true case tests for checkAdjacentVertices configuration [tinkerpop]
Cole-Greer commented on PR #2502: URL: https://github.com/apache/tinkerpop/pull/2502#issuecomment-1971493519 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update edge weights to use double in PartitionStrategy tests [tinkerpop]
Cole-Greer commented on PR #2503: URL: https://github.com/apache/tinkerpop/pull/2503#issuecomment-1971492756 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch 3.6-dev updated (af5c9148b6 -> ddb646e51e)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from af5c9148b6 Bump mocha in /gremlin-javascript/src/main/javascript/gremlin-javascript (#2484) add ddb646e51e Bump github.com/cucumber/godog from 0.13.0 to 0.14.0 in /gremlin-go (#2471) No new revisions were added by this update. Summary of changes: gremlin-go/go.mod | 2 +- gremlin-go/go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
Re: [PR] Bump eslint from 8.56.0 to 8.57.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript [tinkerpop]
Cole-Greer merged PR #2507: URL: https://github.com/apache/tinkerpop/pull/2507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch 3.6-dev updated (b7115b57d3 -> af5c9148b6)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from b7115b57d3 Bump eslint (#2507) add af5c9148b6 Bump mocha in /gremlin-javascript/src/main/javascript/gremlin-javascript (#2484) No new revisions were added by this update. Summary of changes: .../gremlin-javascript/package-lock.json | 87 +- 1 file changed, 19 insertions(+), 68 deletions(-)
Re: [PR] Bump mocha from 10.2.0 to 10.3.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript [tinkerpop]
Cole-Greer merged PR #2484: URL: https://github.com/apache/tinkerpop/pull/2484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/prettier-3.2.5 deleted (was 707d4a11c7)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/prettier-3.2.5 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 707d4a11c7 Bump prettier from 3.1.0 to 3.2.5 in /docs/gremlint The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) branch 3.6-dev updated: Bump eslint (#2507)
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch 3.6-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/3.6-dev by this push:
new b7115b57d3 Bump eslint (#2507)
b7115b57d3 is described below
commit b7115b57d314c0c616585a84495bd0d14ea8dd29
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AuthorDate: Thu Feb 29 08:07:52 2024 -0800
Bump eslint (#2507)
Bumps [eslint](https://github.com/eslint/eslint) from 8.56.0 to 8.57.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v8.56.0...v8.57.0)
---
updated-dependencies:
- dependency-name: eslint
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot]
Co-authored-by: dependabot[bot]
<49699333+dependabot[bot]@users.noreply.github.com>
---
.../gremlin-javascript/package-lock.json | 64 +++---
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git
a/gremlin-javascript/src/main/javascript/gremlin-javascript/package-lock.json
b/gremlin-javascript/src/main/javascript/gremlin-javascript/package-lock.json
index 0b86446496..4dcb4a385e 100644
---
a/gremlin-javascript/src/main/javascript/gremlin-javascript/package-lock.json
+++
b/gremlin-javascript/src/main/javascript/gremlin-javascript/package-lock.json
@@ -130,22 +130,22 @@
}
},
"node_modules/@eslint/js": {
- "version": "8.56.0",
- "resolved": "https://registry.npmjs.org/@eslint/js/-/js-8.56.0.tgz";,
- "integrity":
"sha512-gMsVel9D7f2HLkBma9VbtzZRehRogVRfbr++f06nL2vnCGCNlzOD+/MUov/F4p8myyAHspEhVobgjpX64q5m6A==",
+ "version": "8.57.0",
+ "resolved": "https://registry.npmjs.org/@eslint/js/-/js-8.57.0.tgz";,
+ "integrity":
"sha512-Ys+3g2TaW7gADOJzPt83SJtCDhMjndcDMFVQ/Tj9iA1BfJzFKD9mAUXT3OenpuPHbI6P/myECxRJrofUsDx/5g==",
"dev": true,
"engines": {
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
}
},
"node_modules/@humanwhocodes/config-array": {
- "version": "0.11.13",
- "resolved":
"https://registry.npmjs.org/@humanwhocodes/config-array/-/config-array-0.11.13.tgz";,
- "integrity":
"sha512-JSBDMiDKSzQVngfRjOdFXgFfklaXI4K9nLF49Auh21lmBWRLIK3+xTErTWD4KU54pb6coM6ESE7Awz/FNU3zgQ==",
+ "version": "0.11.14",
+ "resolved":
"https://registry.npmjs.org/@humanwhocodes/config-array/-/config-array-0.11.14.tgz";,
+ "integrity":
"sha512-3T8LkOmg45BV5FICb15QQMsyUSWrQ8AygVfC7ZG32zOalnqrilm018ZVCw0eapXux8FtA33q8PSRSstjee3jSg==",
"dev": true,
"dependencies": {
-"@humanwhocodes/object-schema": "^2.0.1",
-"debug": "^4.1.1",
+"@humanwhocodes/object-schema": "^2.0.2",
+"debug": "^4.3.1",
"minimatch": "^3.0.5"
},
"engines": {
@@ -166,9 +166,9 @@
}
},
"node_modules/@humanwhocodes/object-schema": {
- "version": "2.0.1",
- "resolved":
"https://registry.npmjs.org/@humanwhocodes/object-schema/-/object-schema-2.0.1.tgz";,
- "integrity":
"sha512-dvuCeX5fC9dXgJn9t+X5atfmgQAzUOWqS1254Gh0m6i8wKd10ebXkfNKiRK+1GWi/yTvvLDHpoxLr0xxxeslWw==",
+ "version": "2.0.2",
+ "resolved":
"https://registry.npmjs.org/@humanwhocodes/object-schema/-/object-schema-2.0.2.tgz";,
+ "integrity":
"sha512-6EwiSjwWYP7pTckG6I5eyFANjPhmPjUX9JRLUSfNPC7FX7zK9gyZAfUEaECL6ALTpGX5AjnBq3C9XmVWPitNpw==",
"dev": true
},
"node_modules/@nodelib/fs.scandir": {
@@ -1044,16 +1044,16 @@
}
},
"node_modules/eslint": {
- "version": "8.56.0",
- "resolved": "https://registry.npmjs.org/eslint/-/eslint-8.56.0.tgz";,
- "integrity":
"sha512-Go19xM6T9puCOWntie1/P997aXxFsOi37JIHRWI514Hc6ZnaHGKY9xFhrU65RT6CcBEzZoGG1e6Nq+DT04ZtZQ==",
+ "version": "8.57.0",
+ "resolved": "https://registry.npmjs.org/eslint/-/eslint-8.57.0.tgz";,
+ "integrity":
"sha512-dZ6+mexnaTIbSBZWgou51U6OmzIhYM2VcNdtiTtI7qPNZm35Akpr0f6vtw3w1Kmn5PYo+tZVfh13WrhpS6oLqQ==",
"dev": true,
"dependencies": {
"@eslint-community/eslint-utils": "^4.2.0",
"@eslint-community/regexpp": "^4.6.1",
"@eslint/eslintrc": "^2.1.4",
-"@eslint/js": "8.56.0",
-"@humanwhocodes/config-array": "^0.11.13",
+"@eslint/js": "8.57.0",
+"@humanwhocodes/config-array": "^0.11.14",
"@humanwhocodes/module-importer": "^1.0.1",
"@nodelib/fs.walk": "^1.2.8",
"@ungap/structured-clone": "^1.2.0",
@@ -4007,19 +4007,19 @@
}
},
"@eslint/js": {
- "version": "8.56.0",
- "resolved": "https://registry.npmjs.org/@eslint/js/-/js-8.56.0.tgz";,
- "integrity":
"sha512-gMsVel9D7f2HLkBma9VbtzZRehRogVRfbr++f06nL2vnCGCNlzOD+/
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/testing-library/jest-dom-6.4.2 deleted (was 063cd19054)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/testing-library/jest-dom-6.4.2 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 063cd19054 Bump @testing-library/jest-dom from 6.2.0 to 6.4.2 in /docs/gremlint The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump prettier from 3.1.0 to 3.2.5 in /docs/gremlint [tinkerpop]
dependabot[bot] closed pull request #2479: Bump prettier from 3.1.0 to 3.2.5 in /docs/gremlint URL: https://github.com/apache/tinkerpop/pull/2479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/go_modules/gremlin-go/3.6-dev/github.com/nicksnyder/go-i18n/v2-2.4.0 deleted (was d1c5140815)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch dependabot/go_modules/gremlin-go/3.6-dev/github.com/nicksnyder/go-i18n/v2-2.4.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was d1c5140815 Bump github.com/nicksnyder/go-i18n/v2 from 2.3.0 to 2.4.0 in /gremlin-go The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) branch 3.6-dev updated (ddb646e51e -> 3166f1b347)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from ddb646e51e Bump github.com/cucumber/godog from 0.13.0 to 0.14.0 in /gremlin-go (#2471) add 3166f1b347 Bump github.com/nicksnyder/go-i18n/v2 from 2.3.0 to 2.4.0 in /gremlin-go (#2469) No new revisions were added by this update. Summary of changes: gremlin-go/go.mod | 2 +- gremlin-go/go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
Re: [PR] Bump github.com/nicksnyder/go-i18n/v2 from 2.3.0 to 2.4.0 in /gremlin-go [tinkerpop]
Cole-Greer merged PR #2469: URL: https://github.com/apache/tinkerpop/pull/2469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/go_modules/gremlin-go/3.6-dev/github.com/cucumber/godog-0.14.0 deleted (was 0bcf319771)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch dependabot/go_modules/gremlin-go/3.6-dev/github.com/cucumber/godog-0.14.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 0bcf319771 Bump github.com/cucumber/godog from 0.13.0 to 0.14.0 in /gremlin-go The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump github.com/cucumber/godog from 0.13.0 to 0.14.0 in /gremlin-go [tinkerpop]
Cole-Greer merged PR #2471: URL: https://github.com/apache/tinkerpop/pull/2471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/npm_and_yarn/gremlin-javascript/src/main/javascript/gremlin-javascript/3.6-dev/mocha-10.3.0 deleted (was f0aab3941b)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch dependabot/npm_and_yarn/gremlin-javascript/src/main/javascript/gremlin-javascript/3.6-dev/mocha-10.3.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was f0aab3941b Bump mocha in /gremlin-javascript/src/main/javascript/gremlin-javascript The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) branch dependabot/npm_and_yarn/gremlin-javascript/src/main/javascript/gremlin-javascript/3.6-dev/eslint-8.57.0 deleted (was 72d63b47aa)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch dependabot/npm_and_yarn/gremlin-javascript/src/main/javascript/gremlin-javascript/3.6-dev/eslint-8.57.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 72d63b47aa Bump eslint The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump @testing-library/jest-dom from 6.2.0 to 6.4.2 in /docs/gremlint [tinkerpop]
dependabot[bot] closed pull request #2480: Bump @testing-library/jest-dom from 6.2.0 to 6.4.2 in /docs/gremlint URL: https://github.com/apache/tinkerpop/pull/2480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump @testing-library/jest-dom from 6.2.0 to 6.4.2 in /docs/gremlint [tinkerpop]
dependabot[bot] commented on PR #2480: URL: https://github.com/apache/tinkerpop/pull/2480#issuecomment-1971464902 Looks like @testing-library/jest-dom is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump prettier from 3.1.0 to 3.2.5 in /docs/gremlint [tinkerpop]
dependabot[bot] commented on PR #2479: URL: https://github.com/apache/tinkerpop/pull/2479#issuecomment-1971464878 Looks like prettier is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch master updated: Squash of 3 docs/gremlint dependabots
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/master by this push:
new 98236ba70a Squash of 3 docs/gremlint dependabots
98236ba70a is described below
commit 98236ba70a4f43cbda880ff8f78234f49dd6cc45
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AuthorDate: Thu Feb 29 14:14:16 2024 +
Squash of 3 docs/gremlint dependabots
Bump @types/node from 20.10.3 to 20.11.23 in /docs/gremlint
Bumps
[@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)
from 20.10.3 to 20.11.23.
- [Release
notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
-
[Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)
---
updated-dependencies:
- dependency-name: "@types/node"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot]
Bump @testing-library/jest-dom from 6.2.0 to 6.4.2 in /docs/gremlint
Bumps
[@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from
6.2.0 to 6.4.2.
- [Release notes](https://github.com/testing-library/jest-dom/releases)
-
[Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md)
-
[Commits](https://github.com/testing-library/jest-dom/compare/v6.2.0...v6.4.2)
---
updated-dependencies:
- dependency-name: "@testing-library/jest-dom"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot]
Bump prettier from 3.1.0 to 3.2.5 in /docs/gremlint
Bumps [prettier](https://github.com/prettier/prettier) from 3.1.0 to 3.2.5.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/3.1.0...3.2.5)
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot]
---
docs/gremlint/package-lock.json | 46 ++---
docs/gremlint/package.json | 6 +++---
2 files changed, 28 insertions(+), 24 deletions(-)
diff --git a/docs/gremlint/package-lock.json b/docs/gremlint/package-lock.json
index 42424b04a8..6eaad07ad1 100644
--- a/docs/gremlint/package-lock.json
+++ b/docs/gremlint/package-lock.json
@@ -21,16 +21,16 @@
"web-vitals": "^3.5.1"
},
"devDependencies": {
-"@testing-library/jest-dom": "^6.2.0",
+"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^12.1.5",
"@testing-library/user-event": "^14.5.2",
"@types/jest": "^29.5.4",
-"@types/node": "^20.10.3",
+"@types/node": "^20.11.23",
"@types/react": "^17.0.38",
"@types/react-dom": "^17.0.11",
"@types/styled-components": "^5.1.26",
"gh-pages": "^6.1.1",
-"prettier": "^3.1.0",
+"prettier": "^3.2.5",
"tslint": "^6.1.3",
"tslint-config-prettier": "^1.18.0"
},
@@ -4189,9 +4189,9 @@
}
},
"node_modules/@testing-library/jest-dom": {
- "version": "6.2.0",
- "resolved":
"https://registry.npmjs.org/@testing-library/jest-dom/-/jest-dom-6.2.0.tgz";,
- "integrity":
"sha512-+BVQlJ9cmEn5RDMUS8c2+TU6giLvzaHZ8sU/x0Jj7fk+6/46wPdwlgOPcpxS17CjcanBi/3VmGMqVr2rmbUmNw==",
+ "version": "6.4.2",
+ "resolved":
"https://registry.npmjs.org/@testing-library/jest-dom/-/jest-dom-6.4.2.tgz";,
+ "integrity":
"sha512-CzqH0AFymEMG48CpzXFriYYkOjk6ZGPCLMhW9e9jg3KMCn5OfJecF8GtGW7yGfR/IgCe3SX8BSwjdzI6BBbZLw==",
"dev": true,
"dependencies": {
"@adobe/css-tools": "^4.3.2",
@@ -4210,6 +4210,7 @@
},
"peerDependencies": {
"@jest/globals": ">= 28",
+"@types/bun": "latest",
"@types/jest": ">= 28",
"jest": ">= 28",
"vitest": ">= 0.32"
@@ -4218,6 +4219,9 @@
"@jest/globals": {
"optional": true
},
+"@types/bun": {
+ "optional": true
+},
"@types/jest": {
"optional": true
},
@@ -4540,9 +4544,9 @@
"integrity":
"sha512-YATxVxgRqNH6nHEIsvg6k2Boc1JHI9ZbH5iWFFv/MTkchz3b1ieGDa5T0a9RznNdI0KhVbdbWSN+KWWrQZRxTw=="
},
"node_modules/@types/node": {
- "version": "20.10.3",
- "resolved": "https://registry.npmjs.org/@types/node/-/node-20.10.3.tgz";,
- "integrity":
"sha512-XJavIpZqiXID5Yxnxv3RUDKTN5b81ddNC3ecsA0SoFXz/QU8OGBwZGMomiq0zw+uuqbL/krztv/DINAQ/EV4gg==",
+ "version": "20.11.23",
+
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.11.21 deleted (was e8dc218a60)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.11.21 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was e8dc218a60 Bump @types/node from 20.10.3 to 20.11.21 in /docs/gremlint The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump @types/node from 20.10.3 to 20.11.21 in /docs/gremlint [tinkerpop]
dependabot[bot] commented on PR #2509: URL: https://github.com/apache/tinkerpop/pull/2509#issuecomment-1971233892 Superseded by #2510. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.11.23 created (now bf31a97cdb)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.11.23 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at bf31a97cdb Bump @types/node from 20.10.3 to 20.11.23 in /docs/gremlint No new revisions were added by this update.
[PR] Bump @types/node from 20.10.3 to 20.11.23 in /docs/gremlint [tinkerpop]
dependabot[bot] opened a new pull request, #2510: URL: https://github.com/apache/tinkerpop/pull/2510 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.10.3 to 20.11.23. Commits See full diff in https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump @types/node from 20.10.3 to 20.11.21 in /docs/gremlint [tinkerpop]
dependabot[bot] closed pull request #2509: Bump @types/node from 20.10.3 to 20.11.21 in /docs/gremlint URL: https://github.com/apache/tinkerpop/pull/2509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
