[jira] [Commented] (HADOOP-13594) findbugs warnings to block a build
[ https://issues.apache.org/jira/browse/HADOOP-13594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488861#comment-15488861 ] Tsuyoshi Ozawa commented on HADOOP-13594: - [~busbey] thanks for your feedback. Sounds reasonable. I would like to close this :-) Please feel free to reopen this if someone is interested in. > findbugs warnings to block a build > -- > > Key: HADOOP-13594 > URL: https://issues.apache.org/jira/browse/HADOOP-13594 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Reporter: Tsuyoshi Ozawa > Attachments: HADOOP-13594.001.patch > > > findbugs is good tool, but we need to run separate command(mvn > findbugs:check). > Instead, it's better to run findbugs at compile time and block builds if it > find errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13594) findbugs warnings to block a build
[
https://issues.apache.org/jira/browse/HADOOP-13594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487620#comment-15487620
]
Sean Busbey commented on HADOOP-13594:
--
{quote}
bq. what does this buy us over the current flagging from precommit checks for
findbugs errors?
Unfortunately, findbugs warnings gets overlooked sometimes(e.g. HADOOP-11602
calling String.toUpper/toLower without configuring locale). If the compile
fails when findbugs generate warnings, reviewers can notify them easily.
However, there is also cons: compile time will increase.
{quote}
I am extremely skeptical of fixing people-problems (like committers not
following the agreed criteria for commits and ignoring precommit feedback) with
heavy-handed tech choices. This effectively removes our ability to ignore a
false-positive and I suspect makes the on-boarding process for new contributors
unnecessarily hostile.
{quote}
Sean Busbey I'm assuming merging this after addressing all findbugs warnings.
{quote}
This won't help if the new contribution is what introduces a findbugs warning.
I would prefer we not hit new folks directly with the build failing without
there being sufficient guidance for them to fix things on their own. Could you
paste a sample output from a failed run? Maybe I'm overly concerned about the
impact this will have on the new contributor experience.
> findbugs warnings to block a build
> --
>
> Key: HADOOP-13594
> URL: https://issues.apache.org/jira/browse/HADOOP-13594
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Reporter: Tsuyoshi Ozawa
> Attachments: HADOOP-13594.001.patch
>
>
> findbugs is good tool, but we need to run separate command(mvn
> findbugs:check).
> Instead, it's better to run findbugs at compile time and block builds if it
> find errors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13594) findbugs warnings to block a build
[
https://issues.apache.org/jira/browse/HADOOP-13594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487582#comment-15487582
]
Tsuyoshi Ozawa commented on HADOOP-13594:
-
[~arpiagariu] filed HADOOP-13602 for addressing the warnings.
[~busbey] I'm assuming merging this after addressing all findbugs warnings.
{quote}
what does this buy us over the current flagging from precommit checks for
findbugs errors?
{quote}
Unfortunately, findbugs warnings gets overlooked sometimes(e.g. HADOOP-11602
calling String.toUpper/toLower without configuring locale). If the compile
fails when findbugs generate warnings, reviewers can notify them easily.
However, there is also cons: compile time will increase.
> findbugs warnings to block a build
> --
>
> Key: HADOOP-13594
> URL: https://issues.apache.org/jira/browse/HADOOP-13594
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Reporter: Tsuyoshi Ozawa
> Attachments: HADOOP-13594.001.patch
>
>
> findbugs is good tool, but we need to run separate command(mvn
> findbugs:check).
> Instead, it's better to run findbugs at compile time and block builds if it
> find errors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13594) findbugs warnings to block a build
[ https://issues.apache.org/jira/browse/HADOOP-13594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487524#comment-15487524 ] Sean Busbey commented on HADOOP-13594: -- the effect would be maven failing the build. what does this buy use over the current flagging from precommit checks for findbugs errors? are the error messages sufficient to guide a new contributor in fixing things themselves, or is this likely to result in new folks complaining about the build breaking in confusing ways when their "simple" fix includes a findbugs error? > findbugs warnings to block a build > -- > > Key: HADOOP-13594 > URL: https://issues.apache.org/jira/browse/HADOOP-13594 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Tsuyoshi Ozawa > Attachments: HADOOP-13594.001.patch > > > findbugs is good tool, but we need to run separate command(mvn > findbugs:check). > Instead, it's better to run findbugs at compile time and block builds if it > find errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13594) findbugs warnings to block a build
[ https://issues.apache.org/jira/browse/HADOOP-13594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485271#comment-15485271 ] Arpit Agarwal commented on HADOOP-13594: What will be the effect on the compile time, assuming the 6 Maven plugin issues are addressed? > findbugs warnings to block a build > -- > > Key: HADOOP-13594 > URL: https://issues.apache.org/jira/browse/HADOOP-13594 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Tsuyoshi Ozawa > Attachments: HADOOP-13594.001.patch > > > findbugs is good tool, but we need to run separate command(mvn > findbugs:check). > Instead, it's better to run findbugs at compile time and block builds if it > find errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13594) findbugs warnings to block a build
[
https://issues.apache.org/jira/browse/HADOOP-13594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483673#comment-15483673
]
Hadoop QA commented on HADOOP-13594:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
9s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
11s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
9s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
7s{color} | {color:green} hadoop-project in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 10m 23s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | HADOOP-13594 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12828005/HADOOP-13594.001.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit xml |
| uname | Linux cab50b0e3a60 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / cc01ed70 |
| Default Java | 1.8.0_101 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10482/testReport/ |
| modules | C: hadoop-project U: hadoop-project |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10482/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> findbugs warnings to block a build
> --
>
> Key: HADOOP-13594
> URL: https://issues.apache.org/jira/browse/HADOOP-13594
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Tsuyoshi Ozawa
> Attachments: HADOOP-13594.001.patch
>
>
> findbugs is good tool, but we need to run separate command(mvn
> findbugs:check).
> Instead, it's better to run findbugs at compile time and block builds if it
> find errors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
