DO NOT REPLY [Bug 38853] - [collections] ReferenceMap clears bindings too early

2006-03-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38853.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38853





--- Additional Comments From [EMAIL PROTECTED]  2006-03-27 11:17 ---
Ok, thanks for the hint. That could of course be an issue. I will try to verify 
this. Sorry about the AspectJ code - but there's not much to do about it. I 
will report back in a bit.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[EMAIL PROTECTED]: Project commons-chain (in module jakarta-commons) failed

2006-03-27 Thread Stefan Bodewig
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-chain has an issue affecting its community integration.
This issue affects 16 projects,
 and has been outstanding for 37 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-chain :  GoF Chain of Responsibility pattern
- commons-jelly-tags-quartz :  Commons Jelly
- fulcrum-quartz :  Services Framework
- jakarta-tomcat-5 :  Servlet 2.4 and JSP 2.0 Reference Implementation
- jakarta-velocity-tools :  Velocity-Tools project
- myfaces :  JavaServer(tm) Faces implementation
- portals-bridges-frameworks :  Support for JSR168 compliant Portlet 
development
- portals-bridges-jsf :  Support for JSR168 compliant Portlet development
- portals-bridges-struts :  Support for JSR168 compliant Portlet development
- portals-bridges-velocity :  Support for JSR168 compliant Portlet 
development
- quartz :  Job Scheduler
- struts-action :  Model 2 Model-View-Controller framework for Servlets and 
JSP
- struts-el :  Model 2 Model-View-Controller framework for Servlets and JSP
- struts-sslext :  The Struts SSL Extension for HTTP/HTTPS switching
- struts-taglib :  Model 2 Model-View-Controller framework for Servlets and 
JSP
- struts-tiles :  Model 2 Model-View-Controller framework for Servlets and 
JSP


Full details are available at:

http://vmgump.apache.org/gump/public/jakarta-commons/commons-chain/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [commons-chain-27032006.jar] identifier set to project name
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/jakarta-commons/commons-chain/gump_work/build_jakarta-commons_commons-chain.html
Work Name: build_jakarta-commons_commons-chain (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 secs
Command Line: java -Djava.awt.headless=true 
-Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar
 org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only -Dfinal.name=commons-chain-27032006 -f build.xml jar 
[Working Directory: /usr/local/gump/public/workspace/jakarta-commons/chain]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/chain/target/classes:/usr/local/gump/public/workspace/jakarta-commons/chain/target/test-classes:/usr/local/gump/packages/jsf-1_1_01/lib/jsf-api.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27032006.jar:/usr/local/gump/public/workspace/portals-pluto-1.0/api/target/portlet-api-1.0.jar:/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar
-
[junit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 0.301 sec
[junit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 0.301 sec

[junit] Testcase: testPristine took 0.038 sec
[junit] Testcase: testReadOnly took 0.004 sec
[junit] Testcase: testReadWrite took 0.002 sec
[junit] Testcase: testWriteOnly took 0.001 sec
[junit] Testcase: testAttributes took 0.001 sec
[junit] Testcase: testContains took 0.001 sec
[junit] Testcase: testEquals took 0.012 sec
[junit] Testcase: testKeySet took 0.001 sec
[junit] Testcase: testPutAll took 0.001 sec
[junit] Testcase: testSeriaization took 0.057 sec
[junit] Running org.apache.commons.chain.web.ChainResourcesTestCase
[junit] Testsuite: 

[EMAIL PROTECTED]: Project commons-chain (in module jakarta-commons) failed

2006-03-27 Thread Stefan Bodewig
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-chain has an issue affecting its community integration.
This issue affects 16 projects,
 and has been outstanding for 37 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-chain :  GoF Chain of Responsibility pattern
- commons-jelly-tags-quartz :  Commons Jelly
- fulcrum-quartz :  Services Framework
- jakarta-tomcat-5 :  Servlet 2.4 and JSP 2.0 Reference Implementation
- jakarta-velocity-tools :  Velocity-Tools project
- myfaces :  JavaServer(tm) Faces implementation
- portals-bridges-frameworks :  Support for JSR168 compliant Portlet 
development
- portals-bridges-jsf :  Support for JSR168 compliant Portlet development
- portals-bridges-struts :  Support for JSR168 compliant Portlet development
- portals-bridges-velocity :  Support for JSR168 compliant Portlet 
development
- quartz :  Job Scheduler
- struts-action :  Model 2 Model-View-Controller framework for Servlets and 
JSP
- struts-el :  Model 2 Model-View-Controller framework for Servlets and JSP
- struts-sslext :  The Struts SSL Extension for HTTP/HTTPS switching
- struts-taglib :  Model 2 Model-View-Controller framework for Servlets and 
JSP
- struts-tiles :  Model 2 Model-View-Controller framework for Servlets and 
JSP


Full details are available at:

http://vmgump.apache.org/gump/public/jakarta-commons/commons-chain/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [commons-chain-27032006.jar] identifier set to project name
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/jakarta-commons/commons-chain/gump_work/build_jakarta-commons_commons-chain.html
Work Name: build_jakarta-commons_commons-chain (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 secs
Command Line: java -Djava.awt.headless=true 
-Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar
 org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only -Dfinal.name=commons-chain-27032006 -f build.xml jar 
[Working Directory: /usr/local/gump/public/workspace/jakarta-commons/chain]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/chain/target/classes:/usr/local/gump/public/workspace/jakarta-commons/chain/target/test-classes:/usr/local/gump/packages/jsf-1_1_01/lib/jsf-api.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27032006.jar:/usr/local/gump/public/workspace/portals-pluto-1.0/api/target/portlet-api-1.0.jar:/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar
-
[junit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 0.301 sec
[junit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 0.301 sec

[junit] Testcase: testPristine took 0.038 sec
[junit] Testcase: testReadOnly took 0.004 sec
[junit] Testcase: testReadWrite took 0.002 sec
[junit] Testcase: testWriteOnly took 0.001 sec
[junit] Testcase: testAttributes took 0.001 sec
[junit] Testcase: testContains took 0.001 sec
[junit] Testcase: testEquals took 0.012 sec
[junit] Testcase: testKeySet took 0.001 sec
[junit] Testcase: testPutAll took 0.001 sec
[junit] Testcase: testSeriaization took 0.057 sec
[junit] Running org.apache.commons.chain.web.ChainResourcesTestCase
[junit] Testsuite: 

[EMAIL PROTECTED]: Project commons-jelly-tags-xml-test (in module commons-jelly) failed

2006-03-27 Thread commons-jelly-tags-xml development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-xml-test has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 43 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-xml-test :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -WARNING- Overriding Maven properties: 
[/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties]
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.properties
 -INFO- Project Reports in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-reports



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/gump_work/build_commons-jelly_commons-jelly-tags-xml-test.html
Work Name: build_commons-jelly_commons-jelly-tags-xml-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 30 secs
Command Line: maven --offline jar 
[Working Directory: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar
-
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] 
[junit] 
[junit] Testcase: 
testSetSingleNodeAndAsString(org.apache.commons.jelly.tags.junit.CaseTag$1):
  Caused an ERROR
[junit] 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:294:81:
 x:set You must define an attribute called 'select' for this tag.
[junit] org.apache.commons.jelly.MissingAttributeException: 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:294:81:
 x:set You must define an attribute called 'select' for this tag.
[junit] at 
org.apache.commons.jelly.tags.xml.SetTag.doTag(SetTag.java:86)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] 
[junit] 
[junit] Testcase: 
testSetStringLists(org.apache.commons.jelly.tags.junit.CaseTag$1):
Caused an ERROR
[junit] 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:339:82:
 x:set You must define an attribute called 'select' for this tag.
[junit] org.apache.commons.jelly.MissingAttributeException: 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:339:82:
 x:set You must define an attribute called 'select' for this tag.
[junit] at 
org.apache.commons.jelly.tags.xml.SetTag.doTag(SetTag.java:86)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] 
[junit] 
[junit] Testcase: 
testEntities(org.apache.commons.jelly.tags.junit.CaseTag$1):  Caused an 
ERROR
[junit] 

[EMAIL PROTECTED]: Project commons-jelly-tags-xml-test (in module commons-jelly) failed

2006-03-27 Thread commons-jelly-tags-xml development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-xml-test has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 43 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-xml-test :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -WARNING- Overriding Maven properties: 
[/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties]
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.properties
 -INFO- Project Reports in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-reports



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/gump_work/build_commons-jelly_commons-jelly-tags-xml-test.html
Work Name: build_commons-jelly_commons-jelly-tags-xml-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 30 secs
Command Line: maven --offline jar 
[Working Directory: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar
-
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] 
[junit] 
[junit] Testcase: 
testSetSingleNodeAndAsString(org.apache.commons.jelly.tags.junit.CaseTag$1):
  Caused an ERROR
[junit] 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:294:81:
 x:set You must define an attribute called 'select' for this tag.
[junit] org.apache.commons.jelly.MissingAttributeException: 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:294:81:
 x:set You must define an attribute called 'select' for this tag.
[junit] at 
org.apache.commons.jelly.tags.xml.SetTag.doTag(SetTag.java:86)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] 
[junit] 
[junit] Testcase: 
testSetStringLists(org.apache.commons.jelly.tags.junit.CaseTag$1):
Caused an ERROR
[junit] 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:339:82:
 x:set You must define an attribute called 'select' for this tag.
[junit] org.apache.commons.jelly.MissingAttributeException: 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:339:82:
 x:set You must define an attribute called 'select' for this tag.
[junit] at 
org.apache.commons.jelly.tags.xml.SetTag.doTag(SetTag.java:86)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] 
[junit] 
[junit] Testcase: 
testEntities(org.apache.commons.jelly.tags.junit.CaseTag$1):  Caused an 
ERROR
[junit] 

[EMAIL PROTECTED]: Project commons-latka (in module jakarta-commons) failed

2006-03-27 Thread Ted Husted
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-latka has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 43 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-latka :  Functional Testing Suite


Full details are available at:

http://vmgump.apache.org/gump/public/jakarta-commons/commons-latka/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [commons-latka.jar] identifier set to project name
 -DEBUG- Dependency on jaxen exists, no need to add for property jaxen.jar.
 -INFO- Made directory 
[/usr/local/gump/public/workspace/jakarta-commons/latka/target/classes]
 -INFO- Made directory 
[/usr/local/gump/public/workspace/jakarta-commons/latka/target/test-classes]
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/jakarta-commons/commons-latka/gump_work/build_jakarta-commons_commons-latka.html
Work Name: build_jakarta-commons_commons-latka (Type: Build)
Work ended in a state of : Failed
Elapsed: 8 secs
Command Line: java -Djava.awt.headless=true 
-Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/usr/local/gump/public/workspace/xml-xalan/build/serializer.jar:/usr/local/gump/public/workspace/xml-xalan/build/xalan-unbundled.jar
 org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only 
-Djaxen.jar=/usr/local/gump/public/workspace/jaxen/target/jaxen-27032006.jar 
dist 
[Working Directory: /usr/local/gump/public/workspace/jakarta-commons/latka]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/latka/target/classes:/usr/local/gump/public/workspace/jakarta-commons/latka/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/jakarta-commons/httpclient/dist/commons-httpclient.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/codec/dist/commons-codec-27032006.jar:/usr/local/gump/public/workspace/logging-log4j/dist/lib/log4j-27032006.jar:/usr/local/gump/public/workspace/jakarta-regexp/build/jakarta-regexp-27032006.jar:/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/usr/local/gump/public/workspace/jdom/build/jdom.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/lang/dist/commons-lang-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-27032006.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-27032006.jar
-
[javac]  ^
[javac] 
/x1/gump/public/workspace/jakarta-commons/latka/src/java/org/apache/commons/latka/servlet/ViewResponseServlet.java:44:
 warning: [deprecation] getInstance(java.lang.Class) in 
org.apache.log4j.Category has been deprecated
[javac] public static final Category _log = Category.getInstance(
[javac] ^
[javac] 
/x1/gump/public/workspace/jakarta-commons/latka/src/java/org/apache/commons/latka/validators/BaseValidator.java:35:
 warning: [deprecation] getInstance(java.lang.Class) in 
org.apache.log4j.Category has been deprecated
[javac] protected final Category _log = 
Category.getInstance(BaseValidator.class);

[EMAIL PROTECTED]: Project commons-latka (in module jakarta-commons) failed

2006-03-27 Thread Ted Husted
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-latka has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 43 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-latka :  Functional Testing Suite


Full details are available at:

http://vmgump.apache.org/gump/public/jakarta-commons/commons-latka/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [commons-latka.jar] identifier set to project name
 -DEBUG- Dependency on jaxen exists, no need to add for property jaxen.jar.
 -INFO- Made directory 
[/usr/local/gump/public/workspace/jakarta-commons/latka/target/classes]
 -INFO- Made directory 
[/usr/local/gump/public/workspace/jakarta-commons/latka/target/test-classes]
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/jakarta-commons/commons-latka/gump_work/build_jakarta-commons_commons-latka.html
Work Name: build_jakarta-commons_commons-latka (Type: Build)
Work ended in a state of : Failed
Elapsed: 8 secs
Command Line: java -Djava.awt.headless=true 
-Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/usr/local/gump/public/workspace/xml-xalan/build/serializer.jar:/usr/local/gump/public/workspace/xml-xalan/build/xalan-unbundled.jar
 org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only 
-Djaxen.jar=/usr/local/gump/public/workspace/jaxen/target/jaxen-27032006.jar 
dist 
[Working Directory: /usr/local/gump/public/workspace/jakarta-commons/latka]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/latka/target/classes:/usr/local/gump/public/workspace/jakarta-commons/latka/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/jakarta-commons/httpclient/dist/commons-httpclient.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/codec/dist/commons-codec-27032006.jar:/usr/local/gump/public/workspace/logging-log4j/dist/lib/log4j-27032006.jar:/usr/local/gump/public/workspace/jakarta-regexp/build/jakarta-regexp-27032006.jar:/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/usr/local/gump/public/workspace/jdom/build/jdom.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/lang/dist/commons-lang-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-27032006.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-27032006.jar
-
[javac]  ^
[javac] 
/x1/gump/public/workspace/jakarta-commons/latka/src/java/org/apache/commons/latka/servlet/ViewResponseServlet.java:44:
 warning: [deprecation] getInstance(java.lang.Class) in 
org.apache.log4j.Category has been deprecated
[javac] public static final Category _log = Category.getInstance(
[javac] ^
[javac] 
/x1/gump/public/workspace/jakarta-commons/latka/src/java/org/apache/commons/latka/validators/BaseValidator.java:35:
 warning: [deprecation] getInstance(java.lang.Class) in 
org.apache.log4j.Category has been deprecated
[javac] protected final Category _log = 
Category.getInstance(BaseValidator.class);

Patch for DiskFileItem.java

2006-03-27 Thread Sven Schliesing

Hi,

I've been reviewing the code of the commons FileUpload package and 
would like to contribute a patch. This is no big thing, but some cleanup.


First of all, is this the right list for contributing patches?

Thanks in advance,

Sven

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed

2006-03-27 Thread commons-jelly-tags-html development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-html has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 43 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-html :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [commons-jelly-tags-html-27032006.jar] identifier set to 
project name
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties
 -INFO- Project Reports in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html
Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build)
Work ended in a state of : Failed
Elapsed: 12 secs
Command Line: maven --offline jar 
[Working Directory: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar
-
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] 
[junit] 
[junit] Testcase: 
testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an 
ERROR
[junit] 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] org.apache.commons.jelly.MissingAttributeException: 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] at 
org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] 
[junit] 
[junit] Testcase: 
testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an 
ERROR
[junit] 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] org.apache.commons.jelly.MissingAttributeException: 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] at 

[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed

2006-03-27 Thread commons-jelly-tags-html development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-html has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 43 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-html :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [commons-jelly-tags-html-27032006.jar] identifier set to 
project name
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties
 -INFO- Project Reports in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html
Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build)
Work ended in a state of : Failed
Elapsed: 12 secs
Command Line: maven --offline jar 
[Working Directory: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar
-
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] 
[junit] 
[junit] Testcase: 
testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an 
ERROR
[junit] 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] org.apache.commons.jelly.MissingAttributeException: 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] at 
org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] 
[junit] 
[junit] Testcase: 
testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an 
ERROR
[junit] 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] org.apache.commons.jelly.MissingAttributeException: 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] at 

[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed

2006-03-27 Thread commons-jelly-tags-jsl development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-jsl-test has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 43 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-jsl-test :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on ant exists, no need to add for property 
maven.jar.ant-optional.
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -WARNING- Overriding Maven properties: 
[/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties]
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties
 -INFO- Project Reports in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html
Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 15 secs
Command Line: maven --offline jar 
[Working Directory: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar
-
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186)
[junit] at 
org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234)
[junit] at 
org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186)
[junit] at 
org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:160)
[junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59)
[junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:80)
[junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171)
[junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59)
[junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:102)
[junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91)
[junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:78)
[junit] at 

[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed

2006-03-27 Thread commons-jelly-tags-jsl development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-jsl-test has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 43 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-jsl-test :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on ant exists, no need to add for property 
maven.jar.ant-optional.
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -WARNING- Overriding Maven properties: 
[/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties]
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties
 -INFO- Project Reports in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html
Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 15 secs
Command Line: maven --offline jar 
[Working Directory: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar
-
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186)
[junit] at 
org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234)
[junit] at 
org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186)
[junit] at 
org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:160)
[junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59)
[junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:80)
[junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171)
[junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59)
[junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:102)
[junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91)
[junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:78)
[junit] at 

[validator] Contribute

2006-03-27 Thread Markus
Hi,
in the TODO list are these two points

#  Examine the need for all dependencies. Validator has many dependencies
that are very lightly used and could be removed. Two likely candidates for
removal are commons-collections and ORO. The first because Validator only
uses one class in a very large jar and backward incompatible changes in
recent versions. The second because it can easily be replaced with the
faster and standard Java 1.4 regex engine.
# Scenario one: Replace the Jakarta ORO regex engine with the standard Java
1.4 engine. Preliminary tests show a 50% speed improvement using the
standard engine. This will remove the ORO dependency and bring Validator in
line with standard Java regular expressions. However, this requires a move
to Java 1.4 as the base required Java version. A good time for this move may
be Validator 2.0 when we also change the configuration file semantics. 

This are two tasks which I like to do.
Are they still open?

Kind regards,

Markus

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed

2006-03-27 Thread commons-jelly-tags-define development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-define-test has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 43 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-define-test :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -WARNING- Overriding Maven properties: 
[/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties]
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties
 -INFO- Project Reports in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html
Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 13 secs
Command Line: maven --offline jar 
[Working Directory: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar
-
[junit] at junit.framework.TestResult.runProtected(TestResult.java:124)
[junit] at junit.framework.TestResult.run(TestResult.java:109)
[junit] at junit.framework.TestCase.run(TestCase.java:118)
[junit] at junit.framework.TestSuite.runTest(TestSuite.java:208)
[junit] at junit.framework.TestSuite.run(TestSuite.java:203)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:536)
[junit] Mar 27, 2006 4:16:54 AM 
org.apache.commons.jelly.expression.xpath.XPathExpression evaluate
[junit] SEVERE: Error constructing xpath
[junit] org.jaxen.XPathSyntaxException: Node-set expected
[junit] at org.jaxen.BaseXPath.init(BaseXPath.java:131)
[junit] at org.jaxen.BaseXPath.init(BaseXPath.java:156)
[junit] at org.jaxen.dom4j.Dom4jXPath.init(Dom4jXPath.java:101)
[junit] at 
org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78)
[junit] at 
org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] at junit.framework.TestCase.runBare(TestCase.java:127)
[junit] at junit.framework.TestResult$1.protect(TestResult.java:106)
[junit] at junit.framework.TestResult.runProtected(TestResult.java:124)
[junit] at 

[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed

2006-03-27 Thread commons-jelly-tags-define development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-define-test has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 43 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-define-test :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -WARNING- Overriding Maven properties: 
[/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties]
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties
 -INFO- Project Reports in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html
Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 13 secs
Command Line: maven --offline jar 
[Working Directory: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-27032006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27032006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27032006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar
-
[junit] at junit.framework.TestResult.runProtected(TestResult.java:124)
[junit] at junit.framework.TestResult.run(TestResult.java:109)
[junit] at junit.framework.TestCase.run(TestCase.java:118)
[junit] at junit.framework.TestSuite.runTest(TestSuite.java:208)
[junit] at junit.framework.TestSuite.run(TestSuite.java:203)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:536)
[junit] Mar 27, 2006 4:16:54 AM 
org.apache.commons.jelly.expression.xpath.XPathExpression evaluate
[junit] SEVERE: Error constructing xpath
[junit] org.jaxen.XPathSyntaxException: Node-set expected
[junit] at org.jaxen.BaseXPath.init(BaseXPath.java:131)
[junit] at org.jaxen.BaseXPath.init(BaseXPath.java:156)
[junit] at org.jaxen.dom4j.Dom4jXPath.init(Dom4jXPath.java:101)
[junit] at 
org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78)
[junit] at 
org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] at junit.framework.TestCase.runBare(TestCase.java:127)
[junit] at junit.framework.TestResult$1.protect(TestResult.java:106)
[junit] at junit.framework.TestResult.runProtected(TestResult.java:124)
[junit] at 

Re: [pool] why the composite pool implementation isn't plugable [was: picking descriptive class names]

2006-03-27 Thread Rahul Akolkar
On 3/27/06, Sandy McArthur [EMAIL PROTECTED] wrote:
 On 3/27/06, Rahul Akolkar [EMAIL PROTECTED] wrote:
snip/
 
  Isn't the PoolableObjectFactory orthogonal to the four enum types you
  mention? Those tune the FactoryConfig?

 Yes, hence the smiley.

snap/

Aha ;-)


 The implication for a programmer wanting a feature that isn't
 expressible with the enums is one of:
 * the programmer customizes one of the other existing ObjectPool
 implementations available to him already.
 * the programmer uses his ASL given right to customize and enhance the
 source to meet his needs. (If we're lucky he'll submit a patch back to
 us.)

 Neither of those are terrible, end of the world implications.
 Personally I think the second one is pretty good.

snip/

Thats always the case, and not everyone has the privilege of being
able to use unreleased home-brew versions.


 
  2.1 because we'd rather get 2.0 out first, instead of waiting to try
  out the ideas? If you guys think its appropriate, you might even move
  that conversation here? Maybe others are interested as well; I am :-)
  Plus it will give us better background while reading the commit
  messages.

 Peter Steijn initiated the private email to me. It's up to him if he
 wants to discuss it on list. I will let him talk about his ideas for
 his thesis to whomever he chooses.

snap/

Ofcourse, wanted to let him know I was interested as well.

[Snipped good summary of some of the existing pool issues and
expectation out of first composite pool release].


  P.S.- [pool] code is quite hard to read with all that horizontal
  scrolling. Irrespective of the code already in place, maybe we should
  stick to a reasonable (80?) character line width for new code?

 The code I contribute to apache is code I wrote for pleasure. The code
 I contribute is in the form that was most pleasurable for me to write
 in. I impose no restrictions on how others choose to write their code.
 If you wish to compensate me to write code differently or reject my
 contributions because of such trivial issues, that is fine. The ASL
 grants anyone the right reformat ASL licensed code however they see
 fit. I only request that I am not stripped of attribution for my
 contributions.
snip/

exclamation-mark/

It was merely a suggestion. Will address this in further detail in a
separate email, later.

-Rahul


 --
 Sandy McArthur

 He who dares not offend cannot be honest.
 - Thomas Paine


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release Pool 1.3 based on 1.3-rc4

2006-03-27 Thread robert burrell donkin
On Mon, 2006-03-27 at 02:29 -0500, Sandy McArthur wrote:
 On 3/26/06, Phil Steitz [EMAIL PROTECTED] wrote:
  -0
  Could be a problem with setup or test itself, but with the 1.3-rc4
  jar, I am getting failures in [dbcp] test
  org.apache.commons.dbcp.TestJOCLed.  These tests pass with 1.2.  The
  good news is the other [dbcp] test failures that pool 1.3 is supposed
  to fix succeed for me.  Failures below happen on both Sun Linux JDK
  1.5.0_06 and 1.4.2_10.
 
 These failures are really a problem with the unit test in Dbcp and not pool.
 See: 
 http://www.mail-archive.com/commons-dev%40jakarta.apache.org/msg77500.html
 
  Another small nit is that the RELEASE-NOTES have an old paste reference to 
  [io].
 
 Oops, committed a fix. Assuming nothing else shows up can I just slip
 the fixes in instead of tagging and building another release
 candidate?

you're the release manager so it's your call :)

personally speaking, since it's a minor time, i'd wait a while to see
whether any other problems turn up. if so, i'd create another release
candidate. even if the dhcp issues is not a pool issue, probably best to
wait to make sure (it's a bad feeling having to rush out a fix release).

- robert


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r389310 - in /jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl: GenericKeyedObjectPool.java GenericObjectPool.java

2006-03-27 Thread ggregory
Author: ggregory
Date: Mon Mar 27 14:18:24 2006
New Revision: 389310

URL: http://svn.apache.org/viewcvs?rev=389310view=rev
Log:
Fixed 18 instances of the misspelled word eligible (was eligable) in 
Javadocs.

Modified:

jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java

jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java

Modified: 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java?rev=389310r1=389309r2=389310view=diff
==
--- 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java
 (original)
+++ 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java
 Mon Mar 27 14:18:24 2006
@@ -108,7 +108,7 @@
  *  li
  *   [EMAIL PROTECTED] #setMinEvictableIdleTimeMillis 
minEvictableIdleTimeMillis}
  *   specifies the minimum amount of time that an object may sit idle in the 
pool
- *   before it is eligable for eviction due to idle time.  When non-positive, 
no object
+ *   before it is eligible for eviction due to idle time.  When non-positive, 
no object
  *   will be dropped from the pool due to idle time alone.
  *  /li
  *  li
@@ -365,7 +365,7 @@
  * @param testOnReturn whether or not to validate objects after they are 
returned to the [EMAIL PROTECTED] #returnObject} method (see [EMAIL PROTECTED] 
#setTestOnReturn})
  * @param timeBetweenEvictionRunsMillis the amount of time (in 
milliseconds) to sleep between examining idle objects for eviction (see [EMAIL 
PROTECTED] #setTimeBetweenEvictionRunsMillis})
  * @param numTestsPerEvictionRun the number of idle objects to examine per 
run within the idle object eviction thread (if any) (see [EMAIL PROTECTED] 
#setNumTestsPerEvictionRun})
- * @param minEvictableIdleTimeMillis the minimum number of milliseconds an 
object can sit idle in the pool before it is eligable for evcition (see [EMAIL 
PROTECTED] #setMinEvictableIdleTimeMillis})
+ * @param minEvictableIdleTimeMillis the minimum number of milliseconds an 
object can sit idle in the pool before it is eligible for evcition (see [EMAIL 
PROTECTED] #setMinEvictableIdleTimeMillis})
  * @param testWhileIdle whether or not to validate objects in the idle 
object eviction thread, if any (see [EMAIL PROTECTED] #setTestWhileIdle})
  */
 public GenericKeyedObjectPool(KeyedPoolableObjectFactory factory, int 
maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, boolean 
testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, int 
numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean testWhileIdle) 
{
@@ -384,7 +384,7 @@
  * @param testOnReturn whether or not to validate objects after they are 
returned to the [EMAIL PROTECTED] #returnObject} method (see [EMAIL PROTECTED] 
#setTestOnReturn})
  * @param timeBetweenEvictionRunsMillis the amount of time (in 
milliseconds) to sleep between examining idle objects for eviction (see [EMAIL 
PROTECTED] #setTimeBetweenEvictionRunsMillis})
  * @param numTestsPerEvictionRun the number of idle objects to examine per 
run within the idle object eviction thread (if any) (see [EMAIL PROTECTED] 
#setNumTestsPerEvictionRun})
- * @param minEvictableIdleTimeMillis the minimum number of milliseconds an 
object can sit idle in the pool before it is eligable for evcition (see [EMAIL 
PROTECTED] #setMinEvictableIdleTimeMillis})
+ * @param minEvictableIdleTimeMillis the minimum number of milliseconds an 
object can sit idle in the pool before it is eligible for evcition (see [EMAIL 
PROTECTED] #setMinEvictableIdleTimeMillis})
  * @param testWhileIdle whether or not to validate objects in the idle 
object eviction thread, if any (see [EMAIL PROTECTED] #setTestWhileIdle})
  */
 public GenericKeyedObjectPool(KeyedPoolableObjectFactory factory, int 
maxActive, byte whenExhaustedAction, long maxWait, int maxIdle, int maxTotal, 
boolean testOnBorrow, boolean testOnReturn, long timeBetweenEvictionRunsMillis, 
int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, boolean 
testWhileIdle) {
@@ -404,7 +404,7 @@
  * @param testOnReturn whether or not to validate objects after they are 
returned to the [EMAIL PROTECTED] #returnObject} method (see [EMAIL PROTECTED] 
#setTestOnReturn})
  * @param timeBetweenEvictionRunsMillis the amount of time (in 
milliseconds) to sleep between examining idle objects for eviction (see [EMAIL 
PROTECTED] #setTimeBetweenEvictionRunsMillis})
  * @param numTestsPerEvictionRun the number of idle objects to examine per 
run within the idle object eviction thread (if any) (see [EMAIL PROTECTED] 

RE: [VOTE] Release Pool 1.3 based on 1.3-rc4

2006-03-27 Thread Gary Gregory
Hello:

I've fixed 18 instances of the misspelled word eligible (was
eligable) in Javadocs in the trunk files:

src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java
src/java/org/apache/commons/pool/impl/GenericObjectPool.java

Not sure this is worth another RC. It all depends on how much we care
about the public face of the component.

Gary

 -Original Message-
 From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of
Sandy
 McArthur
 Sent: Sunday, March 26, 2006 4:17 PM
 To: Jakarta Commons Developers List
 Subject: [VOTE] Release Pool 1.3 based on 1.3-rc4
 
 I've prepared Commons Pool release candidate 4 and uploaded it to:
 http://people.apache.org/~sandymac/pool/1.3-rc4/
 
 Changes since rc3 are limited to Stephen's suggestions of moving the
 published date from the bottom to the left and renaming API
 Documentation to Javadocs.
 
 Assuming the vote passes I would fill in the release date on the
download
 page.
 
 The vote will close on April 2nd 2006.
 
 1.3 RC4:
 http://people.apache.org/~sandymac/pool/1.3-rc4/
 
 1.3 RC4 Site:
 http://people.apache.org/~sandymac/pool/1.3-rc4/site/
 
 Keys:
 http://www.apache.org/dist/jakarta/commons/pool/KEYS
 
 
 [ ] +1  I support this release
 [ ] +0
 [ ] -0
 [ ] -1  I do not support this release because...
 
 
 --
 Sandy McArthur
 
 He who dares not offend cannot be honest.
 - Thomas Paine
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39109] - [net] MVSFTPEntryParser.java only halfway implemented

2006-03-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39109.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39109





--- Additional Comments From [EMAIL PROTECTED]  2006-03-28 02:22 ---
You are quite correct.  I remember thinking the same thing when this code was
submitted.  However, it filled the needs of the original author and was better
than nothing.  

None of the committers has access to an MVS system or any knowledge of it, as
you apparently do.  And so, the bottom line is, we humbly request you, in the
spirit of Open Source, to contribute a fully implemented parser, since you have
the expertise.  We'll be happy to commit such a contribution if you submit it,
and help you get it done if you aren't familiar with the process.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[all] Files to create for an RC release

2006-03-27 Thread Henri Yandell
Couple of thoughts on files we should be making sure we're putting in
a rc-x release candidate:

The KEYS file that contains the key against which the pgp stuff needs
to be checked.
The .jar file that is going to go into the Maven repository
.md5 and .asc for said .jar file

Any thoughts?

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[doc] Inspecting an RC

2006-03-27 Thread Henri Yandell
Anyone mind if I split the Things To Look For When Inspecting A
Release Candidate section of
http://jakarta.apache.org/commons/releases/prepare.html into its own
page?

And add in some bits about Phil's tools (I've been making
modifications to them, hope you've been noticing Phil :) ).

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] [RESULT] Demote Latka and Resources to Dormant

2006-03-27 Thread Henri Yandell
*ping*

In case this one has dropped off of the TODO lists.

Hen

On 3/14/06, Stephen Colebourne [EMAIL PROTECTED] wrote:
 Stephen Colebourne wrote:
  Demote [latka] to dormant status

 +1
 Simon Kitching
 Henri Yandell
 Robert Burrell Donkin
 Dion Gillard
 Niall Pemberton
 Torsten Curdt
 Stephen Colebourne
 Brian Wallace (non binding)

 +0
 Sandy McArthur

 Vote passes - move to dormant


  Demote [reosurces] to dormant status
 +1
 Simon Kitching
 Henri Yandell
 Robert Burrell Donkin
 Stephen Colebourne
 Brian Wallace (non binding)

 +0
 Dion Gillard
 Sandy McArthur
 Torsten Curdt

 -0
 Niall Pemberton

 Vote passes - move to dormant
 None of this should prevent it being brought back later.

 I suggest that a discussion about renaming Dormat to Unmaintained starts
 in a new thread.


 I'm not going to be able to action this for a few days now. Rahul, you
 volunteered to help move the components, so if you're still willing, the
 opportunity is now there :-)

 Stephen

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [pool] why the composite pool implementation isn't plugable [was: picking descriptive class names]

2006-03-27 Thread Peter Steijn

   2.1 because we'd rather get 2.0 out first, instead of waiting to try
   out the ideas? If you guys think its appropriate, you might even move
   that conversation here? Maybe others are interested as well; I am :-)
   Plus it will give us better background while reading the commit
   messages.
 
  Peter Steijn initiated the private email to me. It's up to him if he
  wants to discuss it on list. I will let him talk about his ideas for
  his thesis to whomever he chooses.
 
 snap/

 Ofcourse, wanted to let him know I was interested as well.


Hi!

This is Peter Steijn.  I just wanted to let everyone who is interested know
that I am in the process of writing two different implementations of my
proposed optimization for the object pool module.

Look forward to some alpha code and also a formal explanation sometime
within the next day or two.

-Pete


Re: [fileupload] Patch for DiskFileItem.java

2006-03-27 Thread Henri Yandell
Thanks Sven,

This is the right list. As you might have noticed, there's a lot of
different things going on - so we use a convention of [fileupload] in
the subject name to help things stand out.

The best way to submit a patch is to create a new item in Bugzilla
(http://issues.apache.org/bugzilla) for the Commons project,
FileUpload component. That way even if the activity is not on
FileUpload at the moment, it won't get forgotten.

If you want to then generate conversation about the issue, a post to
the -dev mailing list is a good idea, referencing the issue and any
questions you might have.

ie) If it were my first time creating a patch; I would create the
patch, apply it to bugzilla, and send an email asking if the patch
looks okay.

Hen

On 3/27/06, Sven Schliesing [EMAIL PROTECTED] wrote:
 Hi,

 I've been reviewing the code of the commons FileUpload package and
 would like to contribute a patch. This is no big thing, but some cleanup.

 First of all, is this the right list for contributing patches?

 Thanks in advance,

 Sven

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[discovery] 0.3 release?

2006-03-27 Thread Henri Yandell
Noticed today that Discovery 0.3 has an SVN tag, but we didn't do a
release. This was 6 months ago or so.

Did it get held up, or just lack of time/energy?

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [doc] Inspecting an RC

2006-03-27 Thread sebb
Some suggestions for the checklist:

* 3rd party jars and licences
* do the MD5 and PGPs work OK?
* do the archives contain everything that is needed? For example, if
there are source and binary jars, then the union of the two should
produce a set of files that includes everything in the repository.
* do the archives contain anything they shouldn't? E.g. unversioned
source files, test logs etc.
* if there are multiple archives, does each contain what is necessary
and sufficient, or is there some duplication that could be eliminated?

HTH
S.
On 28/03/06, Henri Yandell [EMAIL PROTECTED] wrote:
 Anyone mind if I split the Things To Look For When Inspecting A
 Release Candidate section of
 http://jakarta.apache.org/commons/releases/prepare.html into its own
 page?

 And add in some bits about Phil's tools (I've been making
 modifications to them, hope you've been noticing Phil :) ).

 Hen

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




Re: Dbcp unit test failures with Pool 1.3 [was: [VOTE] Release Pool 1.3 based on 1.3-rc4]

2006-03-27 Thread Phil Steitz
snip/
 Who did it? How did it happen? Lets look at the clues.

 First while we are running TestJOCLed, it subclasses
 TestConnectionPool and that is where the failures are really
 happening.

Yep.

 * testPooling: This test method passes when you run it by itself. It
 fails because while it looks like it's written to handle either a FIFO
 or a LIFO pool implementation it doesn't if the GenericObjectPool
 backing Dbcp has more than 2 idle connections. When the test is run
 after other tests the GOP contains 4 idle connections. With a LIFO the
 most recently returned is the first one borrowed so it doesn't matter
 how many idle connections already exist at the start of the test.
 Since GOP is now a FIFO the test fails because is incorrectly assumes
 that a recently returned connection will be the next one borrowed. IMO
 testPooling should be removed as it really testing Pool's behavior and
 not Dbcp's behavior.

Yes.  This is bad and I agree this test case should be removed, as it
depends on the implementation of the underlying pool, which is not
part of [dbcp].  If there are no objections, I will remove this test
case.


 * testConnectionsAreDistinct: This test method passes when you run it
 by itself. Took me a while to figure out why this fails. It fails
 because the GenericObjectPool backing Dbcp is configured with a
 maxActive of 10 but for me the test fails after borrowing 9 successful
 connections. I'm pretty sure somewhere two of the test methods are
 borrowing connections and not following the proper contracts and
 closing their connections.

As you point out below, this is definitely true of testPooling when it
fails (as it does) with the new pool impl.


 * testOpening, testClosing, testMaxActive, testThreaded,
 testPrepareStatemetnOptions, testNoRsetClose, testHashCode: all pass
 when run individually. They all fail because when
 testConnectionsAreDistinct fails it doesn't close any connection's it
 opened in a finally block so the shared GenericObjectPool which has a
 maxActive set to 10 thinks it's maxed out with 10 borrowed connections
 (9 were from testConnectionsAreDistinct).

 This whole unit test class has a problem in that each test method is
 not independent of the others. Each test method works when run alone
 because they have a fresh state that way. It's when one test leaves
 garbage state around after it runs that is affects other tests and
 triggers a cascade of failures.

Yes.  Better cleanup needs to be included in these tests.


 So where is the garbage state coming from? Like I said at the top,
 testPooling did it with the assertTrue, specifically lines 270 and 271
 of TestConnectionPool:

 270: assertTrue( underconn3 == underconn || underconn3 == underconn2 );
 271: conn3.close();

 When the assertTrue throws an exception the conn3.close is never
 called resulting in a connection leak.

 The easiest fix is to just transpose those two lines and everything
 else but testPooling passes just fine. That still leaves testPooling
 as failing and I think that should be solved by removing the test
 method completely. I think it's fair to say that unit tests for Pool
 belong in the Pool component code base.

 Still, someone should look at the testConnectionsAreDistinct test
 method as it doesn't clean up after itself when it fails.

 Also someone should rework the unit test as a whole so when each test
 method is run there is no residual state left over from other test
 methods. Until this is fixed TestConnectionPool isn't really testing
 what you think it is and probably technically broken.

Ack.  Patches welcome!

Based on above, I am +1 for pool release.

Phil

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [doc] Inspecting an RC

2006-03-27 Thread Niall Pemberton
On 3/28/06, Henri Yandell [EMAIL PROTECTED] wrote:
 Anyone mind if I split the Things To Look For When Inspecting A
 Release Candidate section of
 http://jakarta.apache.org/commons/releases/prepare.html into its own
 page?

 And add in some bits about Phil's tools (I've been making
 modifications to them, hope you've been noticing Phil :) ).

Theres are also these pages on the wiki that seem related:

http://wiki.apache.org/jakarta-commons/ReleaseChecking
http://wiki.apache.org/jakarta-commons/ReleaseShoppingList
http://wiki.apache.org/jakarta-commons/CandidateQualityElection
http://wiki.apache.org/jakarta-commons/SigningReleases

Niall

 Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [doc] Inspecting an RC

2006-03-27 Thread Craig McClanahan
On 3/27/06, sebb [EMAIL PROTECTED] wrote:

 Some suggestions for the checklist:

 * 3rd party jars and licences
 * do the MD5 and PGPs work OK?
 * do the archives contain everything that is needed? For example, if
 there are source and binary jars, then the union of the two should
 produce a set of files that includes everything in the repository.
 * do the archives contain anything they shouldn't? E.g. unversioned
 source files, test logs etc.
 * if there are multiple archives, does each contain what is necessary
 and sufficient, or is there some duplication that could be eliminated?


One more that bit us on Shale 1.0.1 ... can you successfully build the
source distribution?

HTH
 S.


Craig

On 28/03/06, Henri Yandell [EMAIL PROTECTED] wrote:
  Anyone mind if I split the Things To Look For When Inspecting A
  Release Candidate section of
  http://jakarta.apache.org/commons/releases/prepare.html into its own
  page?
 
  And add in some bits about Phil's tools (I've been making
  modifications to them, hope you've been noticing Phil :) ).
 
  Hen
 
  -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]




svn commit: r389381 - in /jakarta/commons/proper/pool/trunk/src: java/org/apache/commons/pool/composite/ test/org/apache/commons/pool/ test/org/apache/commons/pool/composite/

2006-03-27 Thread sandymac
Author: sandymac
Date: Mon Mar 27 19:46:23 2006
New Revision: 389381

URL: http://svn.apache.org/viewcvs?rev=389381view=rev
Log:
Unit tests for the composite Lender implementations.
Bug fix in EvictorLender where two EvictorLender instances
chained would delay getNumIdle from detecting idle objects
that have been evicted.

Added:

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestAll.java
   (with props)

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestFifoLender.java
   (with props)

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestIdleEvictorLender.java
   (with props)

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestInvalidEvictorLender.java
   (with props)

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestLender.java
   (with props)

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestLifoLender.java
   (with props)

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestNullLender.java
   (with props)

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestSoftLender.java
   (with props)
Modified:

jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/EvictorLender.java

jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/NullLender.java

jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/SoftLender.java

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/TestAll.java

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestCompositeObjectPool.java

Modified: 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/EvictorLender.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/EvictorLender.java?rev=389381r1=389380r2=389381view=diff
==
--- 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/EvictorLender.java
 (original)
+++ 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/EvictorLender.java
 Mon Mar 27 19:46:23 2006
@@ -83,7 +83,7 @@
 }
 
 /**
- * Return the size of the idle object pool. Also removes any broken [EMAIL 
PROTECTED] EvictorLender.EvictorReference}s so the
+ * Return the size of the idle object pool. Also removes any broken [EMAIL 
PROTECTED] Lender.LenderReference}s so the
  * size is more accurate.
  *
  * @return the size of the idle object pool the lender is accessing.
@@ -93,8 +93,12 @@
 synchronized (getObjectPool().getPool()) {
 final Iterator iter = super.listIterator();
 while (iter.hasNext()) {
-final EvictorReference ref = (EvictorReference)iter.next();
-if (ref != null  ref.get() == null) {
+Object o = iter.next();
+// unwrap
+while (o instanceof LenderReference) {
+o = ((LenderReference)o).get();
+}
+if (o == null) {
 iter.remove();
 }
 }

Modified: 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/NullLender.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/NullLender.java?rev=389381r1=389380r2=389381view=diff
==
--- 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/NullLender.java
 (original)
+++ 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/NullLender.java
 Mon Mar 27 19:46:23 2006
@@ -28,20 +28,9 @@
  * @since #.#
  * @version $Revision$ $Date$
  */
-final class NullLender implements Lender, Serializable {
+final class NullLender extends AbstractLender implements Serializable {
 
 private static final long serialVersionUID = -135471856936204860L;
-
-/**
- * Called once to associate this manager with an object pool by the [EMAIL 
PROTECTED] CompositeObjectPool} constructor.
- *
- * @param objectPool the pool to associate with.
- * @throws IllegalArgumentException if codeobjectPool/code is 
codenull/code.
- * @throws IllegalStateException if this method is called more than once.
- */
-public void setCompositeObjectPool(final CompositeObjectPool objectPool) 
throws IllegalArgumentException, IllegalStateException {
-// nothing
-}
 
 /**
  * Return codenull/code.

Modified: 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/SoftLender.java
URL: 

svn commit: r389394 - in /jakarta/commons/proper/pool/trunk/src: java/org/apache/commons/pool/composite/ test/org/apache/commons/pool/composite/

2006-03-27 Thread sandymac
Author: sandymac
Date: Mon Mar 27 21:04:36 2006
New Revision: 389394

URL: http://svn.apache.org/viewcvs?rev=389394view=rev
Log:
Unit tests for the composite Tracker implementations.

Added:

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestDebugTracker.java
   (with props)

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestNullTracker.java
   (with props)

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestReferenceTracker.java
   (with props)

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestSimpleTracker.java
   (with props)

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestTracker.java
   (with props)
Modified:

jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/ReferenceTracker.java

jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/Tracker.java

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestAll.java

jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestLender.java

Modified: 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/ReferenceTracker.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/ReferenceTracker.java?rev=389394r1=389393r2=389394view=diff
==
--- 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/ReferenceTracker.java
 (original)
+++ 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/ReferenceTracker.java
 Mon Mar 27 21:04:36 2006
@@ -53,6 +53,9 @@
 private transient int lost = 0;
 
 public void borrowed(final Object obj) {
+if (obj == null) {
+throw new IllegalArgumentException(Cannot track null borrowed 
from pool.);
+}
 workQueue();
 final IdentityReference ref;
 synchronized (rq) {
@@ -79,6 +82,9 @@
  * @throws IllegalStateException when an object that wasn't brorrowed from 
this pool is returned.
  */
 public void returned(final Object obj) throws IllegalStateException {
+if (obj == null) {
+throw new IllegalArgumentException(Cannot track null returned to 
the pool.);
+}
 workQueue();
 final IdentityKey key = new IdentityKey(obj);
 final IdentityReference ref = (IdentityReference)map.remove(key);

Modified: 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/Tracker.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/Tracker.java?rev=389394r1=389393r2=389394view=diff
==
--- 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/Tracker.java
 (original)
+++ 
jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/Tracker.java
 Mon Mar 27 21:04:36 2006
@@ -40,20 +40,20 @@
  * [EMAIL PROTECTED] PoolableObjectFactory#activateObject(Object) 
activated} and
  * [EMAIL PROTECTED] PoolableObjectFactory#validateObject(Object) 
validated} and is about to be returned to the client.
  *
- * pObjects created via [EMAIL PROTECTED] ObjectPool#addObject()} are 
also borrowed so that when
- * [EMAIL PROTECTED] ObjectPool#returnObject(Object)} [EMAIL PROTECTED] 
#returned(Object) returns} that object it isn't unexpected.
- *
  * @param obj was borrowed from the pool.
+ * @throws IllegalArgumentException may be thrown if codenull/code is 
not allowed.
  */
-public void borrowed(Object obj);
+public void borrowed(Object obj) throws IllegalArgumentException;
 
 /**
  * An object is being [EMAIL PROTECTED] ObjectPool#returnObject(Object) 
returned} to the pool.
  * [EMAIL PROTECTED] ObjectPool#invalidateObject(Object) Invalid} objects 
are also returned via this method.
  *
  * @param obj being returned to the pool.
+ * @throws IllegalArgumentException may be thrown if codenull/code is 
not allowed.
+ * @throws IllegalStateException may be thrown if an object is returned 
that wasn't borrowed.
  */
-public void returned(Object obj);
+public void returned(Object obj) throws IllegalArgumentException, 
IllegalStateException;
 
 /**
  * The number of borrowed or active objects from the pool.

Modified: 
jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestAll.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/composite/TestAll.java?rev=389394r1=389393r2=389394view=diff
==
--- 

svn commit: r389401 - /jakarta/commons/proper/pool/trunk/doap_pool.rdf

2006-03-27 Thread sandymac
Author: sandymac
Date: Mon Mar 27 21:33:46 2006
New Revision: 389401

URL: http://svn.apache.org/viewcvs?rev=389401view=rev
Log:
Added releases.

Modified:
jakarta/commons/proper/pool/trunk/doap_pool.rdf

Modified: jakarta/commons/proper/pool/trunk/doap_pool.rdf
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/doap_pool.rdf?rev=389401r1=389400r2=389401view=diff
==
--- jakarta/commons/proper/pool/trunk/doap_pool.rdf (original)
+++ jakarta/commons/proper/pool/trunk/doap_pool.rdf Mon Mar 27 21:33:46 2006
@@ -18,11 +18,32 @@
   /SVNRepository
 /repository
 release
-  revision
+  Version
 namecommons-pool/name
 created2004-06-07/created
-version1.1/version
-  /revision
+revision1.2/revision
+  /Version
+/release
+release
+  Version
+namecommons-pool/name
+created2004-10-20/created
+revision1.1/revision
+  /Version
+/release
+release
+  Version
+namecommons-pool/name
+created2002-08-12/created
+revision1.0.1/revision
+  /Version
+/release
+release
+  Version
+namecommons-pool/name
+created2002-05-04/created
+revision1.0/revision
+  /Version
 /release
 mailing-list 
rdf:resource=http://jakarta.apache.org/site/mail2.html#Commons/
   /Project



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[all] Line width and such minutiae

2006-03-27 Thread Rahul Akolkar
On 3/27/06, Rahul Akolkar [EMAIL PROTECTED] wrote:
 On 3/27/06, Sandy McArthur [EMAIL PROTECTED] wrote:
snip/
   P.S.- [pool] code is quite hard to read with all that horizontal
   scrolling. Irrespective of the code already in place, maybe we should
   stick to a reasonable (80?) character line width for new code?
 
  The code I contribute to apache is code I wrote for pleasure. The code
  I contribute is in the form that was most pleasurable for me to write
  in. I impose no restrictions on how others choose to write their code.
  If you wish to compensate me to write code differently or reject my
  contributions because of such trivial issues, that is fine. The ASL
  grants anyone the right reformat ASL licensed code however they see
  fit. I only request that I am not stripped of attribution for my
  contributions.
snap/

The comment wasn't about imposing restrictions, that would never work
anyway. Even while writing for pleasure, a lot of components still
check for style (I think its valuable). The line width style criteria
has some valid reasons, not the least of which is its accessibility
implication that those more fortunate tend to not realize. So, I am
implicitly -0 for any *new* commits that are needlessly and
consistently too wide which indicates my personal preference (a -1
ofcourse would be an attempt to impose a restriction). And I will
always respect your opinion, even if it doesn't match mine.
Compensation never comes to my mind in face of any discussions on
these mailing lists, that bit was a no-brainer.

As a sidebar, since attribution got mentioned -- its an old, widely
discussed topic at the ASF. Some of us believe that author tags in
source code are a distraction (doesn't mean we want everyone to change
their opinion). It has to do with issues arising out of how you define
the least unit of work that warrants an author tag, the tedium of
having to remember to add an author tag while applying a patch, and
issues of fairness (should the author tags be ordered by size of
contribution to the source file, name, chronology). A lot of older
projects traditionally had author tags, so its more effort to
discontinue, but for newer projects, I personally have begun to prefer
the no author tags policy. Accordingly, I will likely -1 a patch to
the [scxml] code if the author insists on having an author tag. And
maybe that means [scxml] will miss out on some valuable contributions
from talented folks purely for that reason, but that is perhaps the
lesser of the two evils. Attribution then, gets handled via commit
messages and the team page. All commit messages contain attribution as
the case may be, and anyone who contributes any code -- be it a line
or a million -- gets listed on the team page.

I find listening to the variety of opinions on almost all things here
at the ASF makes me richer.

-Rahul

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] [RESULT] Demote Latka and Resources to Dormant

2006-03-27 Thread Rahul Akolkar
On 3/27/06, Henri Yandell [EMAIL PROTECTED] wrote:
 *ping*

 In case this one has dropped off of the TODO lists.

snip/

Still on the list, and within the next 24 hours.

-Rahul


 Hen


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]