[jira] [Commented] (CONNECTORS-346) Testing hierarchy needs work
[ https://issues.apache.org/jira/browse/CONNECTORS-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177527#comment-13177527 ] Karl Wright commented on CONNECTORS-346: r1225740 to create a common infrastructure for firing up a ManifoldCF instance. > Testing hierarchy needs work > > > Key: CONNECTORS-346 > URL: https://issues.apache.org/jira/browse/CONNECTORS-346 > Project: ManifoldCF > Issue Type: Task > Components: Tests >Reporter: Karl Wright >Assignee: Karl Wright > Fix For: ManifoldCF 0.5 > > > The testing hierarchy is in need of some work. Specifically: > - Load tests should be pulled back into the "tests" directory, if possible, > and given a suffix (LT?) which allows Maven to skip them by default. This > will simplify the ant build.xml too. > - Final ant targets (test-dr, load-dr, UI, etc.) need to be regularized. > They all should begin with "test", for one thing. I don't yet have a > proposal though. > - There's a lot of code duplication in the hierarchy and across the different > database base classes. For example, methods that talk with the API appear in > the base class for each database, and could be shared if there was such a > thing as multiple inheritance. Since there isn't we could instead pull these > into their own support class, like HTMLTester does for the UI stuff. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-345) Jetty Configuration Support
[ https://issues.apache.org/jira/browse/CONNECTORS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177467#comment-13177467 ] Michael J. Kelleher commented on CONNECTORS-345: I can mess around with this tomorrow and see what happens and report back with my findings, if that is ok with you. I primarily need jmx and jetty.xml and webdefault.xml support for enabling application container BASIC authentication and server monitoring. The instance would be used in a production system and needs to be monitored and also prevent "the curious" from breaking stuff. I know tomcat could be used, but this is more self contained and portable. Also, I suspect, requires little or no administration, other than the initial jmx and auth support, which would become part of an "image" created for "deployment". Sent from my iPhone On Dec 29, 2011, at 7:11 PM, "Karl Wright (Commented) (JIRA)" > Jetty Configuration Support > --- > > Key: CONNECTORS-345 > URL: https://issues.apache.org/jira/browse/CONNECTORS-345 > Project: ManifoldCF > Issue Type: Improvement > Components: Framework core >Affects Versions: ManifoldCF 0.4 > Environment: Jetty Configuration >Reporter: Michael J. Kelleher > > Can the single process example be extended to support Jetty configuration? > 1) jetty.xml > 2) webdefault.xml > 3) OPTIONS= along with their corresponding XML config files, most > importantly the JMX option, Server,ajp,setuid would be nice to have -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-345) Jetty Configuration Support
[ https://issues.apache.org/jira/browse/CONNECTORS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177465#comment-13177465 ] Karl Wright commented on CONNECTORS-345: bq. It looks like some things have changed going from Jetty 6.1.26 and the newest version 7.x. So, the dependencies for this will change a bit. This is kind of what I was afraid of. If it's relatively easy to port to using Jetty 7 I'd certainly be willing to do it in the release 0.5 timeframe. If there are broad architectural changes, and/or your requirements are going to require ManifoldCF to continuously upgrade Jetty versions, then it's more of a tradeoff. It should be pretty easy to see if Jetty 7 works right now with MCF, and that would be the proper first step. Just delete the old jetty*.jar files from the lib directory, drop down the new jetty jar files, and try running "ant test". If that fails we'd need to figure out why. (The single-process example will almost certainly fail because start.jar won't have the right manifest, but that is easy to address.) > Jetty Configuration Support > --- > > Key: CONNECTORS-345 > URL: https://issues.apache.org/jira/browse/CONNECTORS-345 > Project: ManifoldCF > Issue Type: Improvement > Components: Framework core >Affects Versions: ManifoldCF 0.4 > Environment: Jetty Configuration >Reporter: Michael J. Kelleher > > Can the single process example be extended to support Jetty configuration? > 1) jetty.xml > 2) webdefault.xml > 3) OPTIONS= along with their corresponding XML config files, most > importantly the JMX option, Server,ajp,setuid would be nice to have -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-346) Testing hierarchy needs work
[ https://issues.apache.org/jira/browse/CONNECTORS-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177393#comment-13177393 ] Karl Wright commented on CONNECTORS-346: r1225655 for pulling loadtests out of their own hierarchy into the integration test hierarchy. > Testing hierarchy needs work > > > Key: CONNECTORS-346 > URL: https://issues.apache.org/jira/browse/CONNECTORS-346 > Project: ManifoldCF > Issue Type: Task > Components: Tests >Reporter: Karl Wright >Assignee: Karl Wright > Fix For: ManifoldCF 0.5 > > > The testing hierarchy is in need of some work. Specifically: > - Load tests should be pulled back into the "tests" directory, if possible, > and given a suffix (LT?) which allows Maven to skip them by default. This > will simplify the ant build.xml too. > - Final ant targets (test-dr, load-dr, UI, etc.) need to be regularized. > They all should begin with "test", for one thing. I don't yet have a > proposal though. > - There's a lot of code duplication in the hierarchy and across the different > database base classes. For example, methods that talk with the API appear in > the base class for each database, and could be shared if there was such a > thing as multiple inheritance. Since there isn't we could instead pull these > into their own support class, like HTMLTester does for the UI stuff. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-345) Jetty Configuration Support
[ https://issues.apache.org/jira/browse/CONNECTORS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177390#comment-13177390 ] Michael J. Kelleher commented on CONNECTORS-345: Hi Karl, It looks like some things have changed going from Jetty 6.1.26 and the newest version 7.x. So, the dependencies for this will change a bit. While I would love to have these features available, I wanted to ask your opinion of the likelihood of these features being included into MCF, given that as soon as you make it work with Jetty 6.1.26, it will have to be changed when you upgrade to a newer version of Jetty. That sounds like alot of work to me, and none of it core to what MCF does. If you still think these features may make it into MCF, I will do more research for the dependencies. I just did not want to dump a butt-load of work into the research for it to never have a chance to make it into MCF. Let me know what you think. Thanks! > Jetty Configuration Support > --- > > Key: CONNECTORS-345 > URL: https://issues.apache.org/jira/browse/CONNECTORS-345 > Project: ManifoldCF > Issue Type: Improvement > Components: Framework core >Affects Versions: ManifoldCF 0.4 > Environment: Jetty Configuration >Reporter: Michael J. Kelleher > > Can the single process example be extended to support Jetty configuration? > 1) jetty.xml > 2) webdefault.xml > 3) OPTIONS= along with their corresponding XML config files, most > importantly the JMX option, Server,ajp,setuid would be nice to have -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CONNECTORS-337) Maven build -DskipIT does not seem to skip integration tests anymore
[ https://issues.apache.org/jira/browse/CONNECTORS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Wright resolved CONNECTORS-337. Resolution: Fixed Assignee: Karl Wright > Maven build -DskipIT does not seem to skip integration tests anymore > > > Key: CONNECTORS-337 > URL: https://issues.apache.org/jira/browse/CONNECTORS-337 > Project: ManifoldCF > Issue Type: Bug > Components: Build >Affects Versions: ManifoldCF 0.5 >Reporter: Karl Wright >Assignee: Karl Wright >Priority: Minor > Fix For: ManifoldCF 0.5 > > > "mvn clean -DskipIT install" still seems to run all the integration tests. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-337) Maven build -DskipIT does not seem to skip integration tests anymore
[ https://issues.apache.org/jira/browse/CONNECTORS-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177356#comment-13177356 ] Karl Wright commented on CONNECTORS-337: r1225633 > Maven build -DskipIT does not seem to skip integration tests anymore > > > Key: CONNECTORS-337 > URL: https://issues.apache.org/jira/browse/CONNECTORS-337 > Project: ManifoldCF > Issue Type: Bug > Components: Build >Affects Versions: ManifoldCF 0.5 >Reporter: Karl Wright >Priority: Minor > Fix For: ManifoldCF 0.5 > > > "mvn clean -DskipIT install" still seems to run all the integration tests. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[VOTE] Release apache-manifoldcf-0.4-incubating, RC1
I've uploaded the RC1 apache-manifoldcf-0.4-incubating package which you can download from http://people.apache.org/~kwright. If you agree this should be released please vote +1. The fixes over RC0 are all UI related; you can see what they are in the CHANGES.txt file. Karl
[jira] [Commented] (CONNECTORS-345) Jetty Configuration Support
[ https://issues.apache.org/jira/browse/CONNECTORS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177261#comment-13177261 ] Michael J. Kelleher commented on CONNECTORS-345: I will research this and update the ticket. > Jetty Configuration Support > --- > > Key: CONNECTORS-345 > URL: https://issues.apache.org/jira/browse/CONNECTORS-345 > Project: ManifoldCF > Issue Type: Improvement > Components: Framework core >Affects Versions: ManifoldCF 0.4 > Environment: Jetty Configuration >Reporter: Michael J. Kelleher > > Can the single process example be extended to support Jetty configuration? > 1) jetty.xml > 2) webdefault.xml > 3) OPTIONS= along with their corresponding XML config files, most > importantly the JMX option, Server,ajp,setuid would be nice to have -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-345) Jetty Configuration Support
[ https://issues.apache.org/jira/browse/CONNECTORS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177242#comment-13177242 ] Karl Wright commented on CONNECTORS-345: Are there any addition jars required for any of these options? > Jetty Configuration Support > --- > > Key: CONNECTORS-345 > URL: https://issues.apache.org/jira/browse/CONNECTORS-345 > Project: ManifoldCF > Issue Type: Improvement > Components: Framework core >Affects Versions: ManifoldCF 0.4 > Environment: Jetty Configuration >Reporter: Michael J. Kelleher > > Can the single process example be extended to support Jetty configuration? > 1) jetty.xml > 2) webdefault.xml > 3) OPTIONS= along with their corresponding XML config files, most > importantly the JMX option, Server,ajp,setuid would be nice to have -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-346) Testing hierarchy needs work
[ https://issues.apache.org/jira/browse/CONNECTORS-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Wright updated CONNECTORS-346: --- Fix Version/s: ManifoldCF 0.5 Assignee: Karl Wright > Testing hierarchy needs work > > > Key: CONNECTORS-346 > URL: https://issues.apache.org/jira/browse/CONNECTORS-346 > Project: ManifoldCF > Issue Type: Task > Components: Tests >Reporter: Karl Wright >Assignee: Karl Wright > Fix For: ManifoldCF 0.5 > > > The testing hierarchy is in need of some work. Specifically: > - Load tests should be pulled back into the "tests" directory, if possible, > and given a suffix (LT?) which allows Maven to skip them by default. This > will simplify the ant build.xml too. > - Final ant targets (test-dr, load-dr, UI, etc.) need to be regularized. > They all should begin with "test", for one thing. I don't yet have a > proposal though. > - There's a lot of code duplication in the hierarchy and across the different > database base classes. For example, methods that talk with the API appear in > the base class for each database, and could be shared if there was such a > thing as multiple inheritance. Since there isn't we could instead pull these > into their own support class, like HTMLTester does for the UI stuff. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CONNECTORS-346) Testing hierarchy needs work
Testing hierarchy needs work Key: CONNECTORS-346 URL: https://issues.apache.org/jira/browse/CONNECTORS-346 Project: ManifoldCF Issue Type: Task Components: Tests Reporter: Karl Wright The testing hierarchy is in need of some work. Specifically: - Load tests should be pulled back into the "tests" directory, if possible, and given a suffix (LT?) which allows Maven to skip them by default. This will simplify the ant build.xml too. - Final ant targets (test-dr, load-dr, UI, etc.) need to be regularized. They all should begin with "test", for one thing. I don't yet have a proposal though. - There's a lot of code duplication in the hierarchy and across the different database base classes. For example, methods that talk with the API appear in the base class for each database, and could be shared if there was such a thing as multiple inheritance. Since there isn't we could instead pull these into their own support class, like HTMLTester does for the UI stuff. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-344) OpenSearchServer connector needs hiddens to work in multi-tab environment
[ https://issues.apache.org/jira/browse/CONNECTORS-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177239#comment-13177239 ] Emmanuel Keller commented on CONNECTORS-344: Sure, I start working on > OpenSearchServer connector needs hiddens to work in multi-tab environment > - > > Key: CONNECTORS-344 > URL: https://issues.apache.org/jira/browse/CONNECTORS-344 > Project: ManifoldCF > Issue Type: Bug > Components: OpenSearchServer connector >Affects Versions: ManifoldCF 0.4, ManifoldCF 0.5 >Reporter: Karl Wright >Assignee: Karl Wright > Fix For: ManifoldCF 0.5 > > > The OpenSearchServer connector UI loses your data when you click on different > tabs in either the output connector configuration page or job page. It needs > support for hidden data in order to not do this. See other connector > implementations, notably the CMIS connector (which is similar > architecturally) in order to do this right. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CONNECTORS-345) Jetty Configuration Support
Jetty Configuration Support --- Key: CONNECTORS-345 URL: https://issues.apache.org/jira/browse/CONNECTORS-345 Project: ManifoldCF Issue Type: Improvement Components: Framework core Affects Versions: ManifoldCF 0.4 Environment: Jetty Configuration Reporter: Michael J. Kelleher Can the single process example be extended to support Jetty configuration? 1) jetty.xml 2) webdefault.xml 3) OPTIONS= along with their corresponding XML config files, most importantly the JMX option, Server,ajp,setuid would be nice to have -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-344) OpenSearchServer connector needs hiddens to work in multi-tab environment
[ https://issues.apache.org/jira/browse/CONNECTORS-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177236#comment-13177236 ] Karl Wright commented on CONNECTORS-344: Nobody has started. If you want to submit a patch, that would be great! Thanks! > OpenSearchServer connector needs hiddens to work in multi-tab environment > - > > Key: CONNECTORS-344 > URL: https://issues.apache.org/jira/browse/CONNECTORS-344 > Project: ManifoldCF > Issue Type: Bug > Components: OpenSearchServer connector >Affects Versions: ManifoldCF 0.4, ManifoldCF 0.5 >Reporter: Karl Wright >Assignee: Karl Wright > Fix For: ManifoldCF 0.5 > > > The OpenSearchServer connector UI loses your data when you click on different > tabs in either the output connector configuration page or job page. It needs > support for hidden data in order to not do this. See other connector > implementations, notably the CMIS connector (which is similar > architecturally) in order to do this right. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-344) OpenSearchServer connector needs hiddens to work in multi-tab environment
[ https://issues.apache.org/jira/browse/CONNECTORS-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177230#comment-13177230 ] Emmanuel Keller commented on CONNECTORS-344: Hi! Is someone already working on this ? If not, I am available to achieve this task. > OpenSearchServer connector needs hiddens to work in multi-tab environment > - > > Key: CONNECTORS-344 > URL: https://issues.apache.org/jira/browse/CONNECTORS-344 > Project: ManifoldCF > Issue Type: Bug > Components: OpenSearchServer connector >Affects Versions: ManifoldCF 0.4, ManifoldCF 0.5 >Reporter: Karl Wright >Assignee: Karl Wright > Fix For: ManifoldCF 0.5 > > > The OpenSearchServer connector UI loses your data when you click on different > tabs in either the output connector configuration page or job page. It needs > support for hidden data in order to not do this. See other connector > implementations, notably the CMIS connector (which is similar > architecturally) in order to do this right. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CONNECTORS-344) OpenSearchServer connector needs hiddens to work in multi-tab environment
OpenSearchServer connector needs hiddens to work in multi-tab environment - Key: CONNECTORS-344 URL: https://issues.apache.org/jira/browse/CONNECTORS-344 Project: ManifoldCF Issue Type: Bug Components: OpenSearchServer connector Affects Versions: ManifoldCF 0.4, ManifoldCF 0.5 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.5 The OpenSearchServer connector UI loses your data when you click on different tabs in either the output connector configuration page or job page. It needs support for hidden data in order to not do this. See other connector implementations, notably the CMIS connector (which is similar architecturally) in order to do this right. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CONNECTORS-343) Severe connector UI bugs
[
https://issues.apache.org/jira/browse/CONNECTORS-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Wright resolved CONNECTORS-343.
Resolution: Fixed
> Severe connector UI bugs
>
>
> Key: CONNECTORS-343
> URL: https://issues.apache.org/jira/browse/CONNECTORS-343
> Project: ManifoldCF
> Issue Type: Bug
> Components: Alfresco connector, CMIS connector, OpenSearchServer
> connector
>Affects Versions: ManifoldCF 0.4
>Reporter: Karl Wright
>Assignee: Karl Wright
>Priority: Critical
> Fix For: ManifoldCF 0.4
>
>
> There are various severe UI bugs with the Alfresco connector, CMIS connector,
> and OpenSearchServer connector. These include:
> - injection of ${XXX} data into fields on the first (re)post of each edit
> form (Alfresco and CMIS only)
> - no escaping of string values appropriate for the context of each
> substitution value, which means the forms will blow up when unusual values
> like "<" or ">" are included in (say) a password
> I've fixed these problems on trunk as part of CONNECTORS-335. This ticket is
> meant to capture the problem for the 0.4 release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-343) Severe connector UI bugs
[
https://issues.apache.org/jira/browse/CONNECTORS-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177227#comment-13177227
]
Karl Wright commented on CONNECTORS-343:
r1225559 for the rest of it.
> Severe connector UI bugs
>
>
> Key: CONNECTORS-343
> URL: https://issues.apache.org/jira/browse/CONNECTORS-343
> Project: ManifoldCF
> Issue Type: Bug
> Components: Alfresco connector, CMIS connector, OpenSearchServer
> connector
>Affects Versions: ManifoldCF 0.4
>Reporter: Karl Wright
>Assignee: Karl Wright
>Priority: Critical
> Fix For: ManifoldCF 0.4
>
>
> There are various severe UI bugs with the Alfresco connector, CMIS connector,
> and OpenSearchServer connector. These include:
> - injection of ${XXX} data into fields on the first (re)post of each edit
> form (Alfresco and CMIS only)
> - no escaping of string values appropriate for the context of each
> substitution value, which means the forms will blow up when unusual values
> like "<" or ">" are included in (say) a password
> I've fixed these problems on trunk as part of CONNECTORS-335. This ticket is
> meant to capture the problem for the 0.4 release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [VOTE] Release Apache ManifoldCF 0.4-incubating, RC0
2011/12/29 Karl Wright :
> I found a potential blocker for 0.4-incubator, CONNECTORS-342. I
> think it is severe enough to require respin of the candidate. The bad
> HTML causes the "Save" button to vanish and makes the File Connector
> only barely usable.
>
> I've also found UI problems with the CMIS and Alfresco connectors; the
> way hiddens are managed is incorrect so that you can get ${xxx} values
> stuffed in the fields on the initial post/repost. In addition they
> both suffer from lack of proper escaping of values in the UI. The
> OpenSearchServer connector also suffers from the latter. These bugs
> are pretty severe in my opinion and I've captured them in
> CONNECTORS-343.
>
> I've checked in a fix to the branch for CONNECTORS-342. The fix for
> CONNECTORS-343 is a bit more extensive but is certainly doable within
> the 0.4-incubating release. Piergiorgio, do you agree that we should
> try to fix this for this release?
I agree that we have to fix these issues as soon as possible.
I have to reproduce the issue on the CMIS and Alfresco connector, I
hope to work on this this afternoon.
Piergiorgio
>
> Karl
>
> On Tue, Dec 20, 2011 at 8:40 AM, Karl Wright wrote:
>> As long as your changes are committed to trunk, I can push them to the
>> site immediately. They just won't be in the documentation that ships
>> with ManifoldCF 0.4-incubating, is all.
>>
>> So it sounds like we have a vote to release, as soon as we wait the
>> full 72 hours. ;-)
>> Karl
>>
>> On Tue, Dec 20, 2011 at 8:33 AM, Piergiorgio Lucidi
>> wrote:
>>> 2011/12/20 Karl Wright :
Piergiorgio wants to include a section in the "how to build and
deploy" documentation for the Alfresco connector. To me this is not
really an important enough change to spin another RC, but since we're
still waiting for Tommaso to review our releases there may be time to
do it.
But, right now, I vote +1 for RC0. We'll see if Piergiorgio withdraws his
vote.
>>>
>>> It's not a problem for me to release this RC0, but I would like to
>>> update at least the website documentation about how to build the
>>> Alfresco Connector. I hope this night to work on this new section and
>>> then we can push an update of the website.
>>>
>>> Piergiorgio
>>>
Karl
On Mon, Dec 19, 2011 at 7:04 PM, Shinichiro Abe
wrote:
> Thank you. I understand.
>
> +1 for me.
>
> Shinichiro Abe
>
> On 2011/12/19, at 16:25, Karl Wright wrote:
>
>> The hsqldb configuration used by multiprocess-example is an external
>> hsqldb database. It does not require the
>> org.apache.manifoldcf.hsqldbdatabasepath property. If you want to try
>> out the multiprocess example, take the following steps:
>>
>> (1) In one shell prompt, start the database: "start-database.bat/.sh"
>> (2) In another shell prompt, initialize the database:
>> "initialize.bat/.sh"
>> (3) When that is done, start the agents proces: "start-agents.bat/.sh"
>>
>> Thanks,
>> Karl
>>
>>
>> On Mon, Dec 19, 2011 at 2:05 AM, Shinichiro Abe
>> wrote:
>>> Hi.
>>>
>>> I checked 0.4 by running ant test, okay but one problem.
>>>
>>> In multiprocess-example, at default properties.xml, HSQLDB database
>>> requires
>>> 'org.apache.manifoldcf.hsqldbdatabasepath' property, containing a
>>> relative path:
>>>
>>>
>>>
>>> Now exception is thrown, so we need to add this property.
>>> Should I send a patch? Next?
>>>
>>> Regards,
>>> Shinichiro Abe
>>>
>>> On 2011/12/18, at 2:27, Karl Wright wrote:
>>>
I've again uploaded an apache-manifoldcf-0.4-incubating package which
you
can download from http://people.apache.org/~kwright. If you agree
this should be released please vote +1.
[Note that the release of this artifact is dependent on the release of
the three plugin packages upon which it depends. If we need to change
those packages we'll need to spin a new RC of this one. Also please
note that I've include SHA1 signatures for the first time, as per
Jukka's suggestion.]
I apologize again for the earlier hiccup. This one is the real thing,
though, and passes all tests.
Thanks!
Karl
>>>
>
>>>
>>>
>>>
>>> --
>>> Piergiorgio Lucidi
>>> http://www.open4dev.com
--
Piergiorgio Lucidi
http://www.open4dev.com
[jira] [Commented] (CONNECTORS-341) override config for test cases
[ https://issues.apache.org/jira/browse/CONNECTORS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177157#comment-13177157 ] Karl Wright commented on CONNECTORS-341: bq. I suggest... Two comments. First, maybe I didn't understand your use case - I was thinking that you meant that one might want to write a derived test which set different parameters than the ones included in the base class. But now you are talking about setting parameters based on files described by a -D switch? I'm not convinced this is appropriate. Second, you can't create two configuration files with one String return value. :-) Your createConfigFiles() method seems to attempt to do just that. Another question I have is whether it is ever appropriate to NOT clean up configuration files when the test is done. Other subsequent tests will lay down their own configuration files, and in the same folder/directory. Not cleaning up invites confusion, seems to me. > override config for test cases > -- > > Key: CONNECTORS-341 > URL: https://issues.apache.org/jira/browse/CONNECTORS-341 > Project: ManifoldCF > Issue Type: Improvement > Components: Tests >Reporter: Martin Goldhahn > Attachments: CONNECTORS-341.patch > > > It is hard to write a test case for a repository connector using the existing > *.Base classes that uses a different config file. > The config files are actually written in > org.apache.manifoldcf.core.tests.Base.localSetup(). > The localSetup method is called by all sub-classes in their overridden > localSetup function. each sub-class adds something specific for the test > case. If I wanted to put something different in the config files I had to > override localSetup() and copy all content of the superclasses' localSetup to > it. This can be avoided by moving the code that writes the config file in the > initialize() method. It makes also more sense in that the creation of the > config files and the provision of their content are now in the same function. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-343) Severe connector UI bugs
[
https://issues.apache.org/jira/browse/CONNECTORS-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177154#comment-13177154
]
Karl Wright commented on CONNECTORS-343:
r1225520 for the tab management issues.
> Severe connector UI bugs
>
>
> Key: CONNECTORS-343
> URL: https://issues.apache.org/jira/browse/CONNECTORS-343
> Project: ManifoldCF
> Issue Type: Bug
> Components: Alfresco connector, CMIS connector, OpenSearchServer
> connector
>Affects Versions: ManifoldCF 0.4
>Reporter: Karl Wright
>Assignee: Karl Wright
>Priority: Critical
> Fix For: ManifoldCF 0.4
>
>
> There are various severe UI bugs with the Alfresco connector, CMIS connector,
> and OpenSearchServer connector. These include:
> - injection of ${XXX} data into fields on the first (re)post of each edit
> form (Alfresco and CMIS only)
> - no escaping of string values appropriate for the context of each
> substitution value, which means the forms will blow up when unusual values
> like "<" or ">" are included in (say) a password
> I've fixed these problems on trunk as part of CONNECTORS-335. This ticket is
> meant to capture the problem for the 0.4 release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CONNECTORS-341) override config for test cases
[
https://issues.apache.org/jira/browse/CONNECTORS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177135#comment-13177135
]
Martin Goldhahn edited comment on CONNECTORS-341 at 12/29/11 12:33 PM:
---
Sounds good to me. I just found another issue.
org.apache.manifoldcf.core.tests.Base deletes the config files. So there should
be a pair of functions concerned with creation/deletion of the config files.
I suggest
{code}
/**
* This function can be used to provide configuration file and set the system
property {@code org.apache.manifoldcf.configfile}.
* If this function doesn't provide any config file (returns null), the system
property has to point to a valid config file.
*/
protected String createConfigFiles() {
}
/**
* This function can be used to cleaup the resources created with {@link
#createConfigFiles}
*/
protected void deleteConfigFiles() {
}
{code}
With this you can choose to write your config files in code or get them from
the class path or whatever.
was (Author: mgoldhahn):
Sounds good to me. I just found another issue.
org.apache.manifoldcf.core.tests.Base deletes the config files. So there should
be a pair of functions concerned with creation/deletion of the config files.
I suggest
{code}
/**
* This function can be used to provide configuration file and set the system
property {@code org.apache.manifoldcf.configfile}.
* If this function doesn't provide any config file (returns null), the system
property has to point to a valid config file.
*/
protected String createConfigFiles() {
}
/**
* This function can be used to cleaup the resources created with {@link
#createConfigFiles}
*/
protected void deleteConfigFiles() {
}
{code}
With this you can choose to write your config files
> override config for test cases
> --
>
> Key: CONNECTORS-341
> URL: https://issues.apache.org/jira/browse/CONNECTORS-341
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Tests
>Reporter: Martin Goldhahn
> Attachments: CONNECTORS-341.patch
>
>
> It is hard to write a test case for a repository connector using the existing
> *.Base classes that uses a different config file.
> The config files are actually written in
> org.apache.manifoldcf.core.tests.Base.localSetup().
> The localSetup method is called by all sub-classes in their overridden
> localSetup function. each sub-class adds something specific for the test
> case. If I wanted to put something different in the config files I had to
> override localSetup() and copy all content of the superclasses' localSetup to
> it. This can be avoided by moving the code that writes the config file in the
> initialize() method. It makes also more sense in that the creation of the
> config files and the provision of their content are now in the same function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-341) override config for test cases
[
https://issues.apache.org/jira/browse/CONNECTORS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177135#comment-13177135
]
Martin Goldhahn commented on CONNECTORS-341:
Sounds good to me. I just found another issue.
org.apache.manifoldcf.core.tests.Base deletes the config files. So there should
be a pair of functions concerned with creation/deletion of the config files.
I suggest
{code}
/**
* This function can be used to provide configuration file and set the system
property {@code org.apache.manifoldcf.configfile}.
* If this function doesn't provide any config file (returns null), the system
property has to point to a valid config file.
*/
protected String createConfigFiles() {
}
/**
* This function can be used to cleaup the resources created with {@link
#createConfigFiles}
*/
protected void deleteConfigFiles() {
}
{code}
With this you can choose to write your config files
> override config for test cases
> --
>
> Key: CONNECTORS-341
> URL: https://issues.apache.org/jira/browse/CONNECTORS-341
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Tests
>Reporter: Martin Goldhahn
> Attachments: CONNECTORS-341.patch
>
>
> It is hard to write a test case for a repository connector using the existing
> *.Base classes that uses a different config file.
> The config files are actually written in
> org.apache.manifoldcf.core.tests.Base.localSetup().
> The localSetup method is called by all sub-classes in their overridden
> localSetup function. each sub-class adds something specific for the test
> case. If I wanted to put something different in the config files I had to
> override localSetup() and copy all content of the superclasses' localSetup to
> it. This can be avoided by moving the code that writes the config file in the
> initialize() method. It makes also more sense in that the creation of the
> config files and the provision of their content are now in the same function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-342) File connector "Paths" tab has broken html
[ https://issues.apache.org/jira/browse/CONNECTORS-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177131#comment-13177131 ] Karl Wright commented on CONNECTORS-342: r1225505 for the release branch. > File connector "Paths" tab has broken html > -- > > Key: CONNECTORS-342 > URL: https://issues.apache.org/jira/browse/CONNECTORS-342 > Project: ManifoldCF > Issue Type: Bug > Components: File system connector >Affects Versions: ManifoldCF 0.4 >Reporter: Karl Wright >Assignee: Karl Wright >Priority: Blocker > Fix For: ManifoldCF 0.4 > > > The file system connector has broken HTML for the Paths tab, which blocks > people from using the connector. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [VOTE] Release Apache ManifoldCF 0.4-incubating, RC0
I found a potential blocker for 0.4-incubator, CONNECTORS-342. I
think it is severe enough to require respin of the candidate. The bad
HTML causes the "Save" button to vanish and makes the File Connector
only barely usable.
I've also found UI problems with the CMIS and Alfresco connectors; the
way hiddens are managed is incorrect so that you can get ${xxx} values
stuffed in the fields on the initial post/repost. In addition they
both suffer from lack of proper escaping of values in the UI. The
OpenSearchServer connector also suffers from the latter. These bugs
are pretty severe in my opinion and I've captured them in
CONNECTORS-343.
I've checked in a fix to the branch for CONNECTORS-342. The fix for
CONNECTORS-343 is a bit more extensive but is certainly doable within
the 0.4-incubating release. Piergiorgio, do you agree that we should
try to fix this for this release?
Karl
On Tue, Dec 20, 2011 at 8:40 AM, Karl Wright wrote:
> As long as your changes are committed to trunk, I can push them to the
> site immediately. They just won't be in the documentation that ships
> with ManifoldCF 0.4-incubating, is all.
>
> So it sounds like we have a vote to release, as soon as we wait the
> full 72 hours. ;-)
> Karl
>
> On Tue, Dec 20, 2011 at 8:33 AM, Piergiorgio Lucidi
> wrote:
>> 2011/12/20 Karl Wright :
>>> Piergiorgio wants to include a section in the "how to build and
>>> deploy" documentation for the Alfresco connector. To me this is not
>>> really an important enough change to spin another RC, but since we're
>>> still waiting for Tommaso to review our releases there may be time to
>>> do it.
>>>
>>> But, right now, I vote +1 for RC0. We'll see if Piergiorgio withdraws his
>>> vote.
>>
>> It's not a problem for me to release this RC0, but I would like to
>> update at least the website documentation about how to build the
>> Alfresco Connector. I hope this night to work on this new section and
>> then we can push an update of the website.
>>
>> Piergiorgio
>>
>>>
>>> Karl
>>>
>>> On Mon, Dec 19, 2011 at 7:04 PM, Shinichiro Abe
>>> wrote:
Thank you. I understand.
+1 for me.
Shinichiro Abe
On 2011/12/19, at 16:25, Karl Wright wrote:
> The hsqldb configuration used by multiprocess-example is an external
> hsqldb database. It does not require the
> org.apache.manifoldcf.hsqldbdatabasepath property. If you want to try
> out the multiprocess example, take the following steps:
>
> (1) In one shell prompt, start the database: "start-database.bat/.sh"
> (2) In another shell prompt, initialize the database: "initialize.bat/.sh"
> (3) When that is done, start the agents proces: "start-agents.bat/.sh"
>
> Thanks,
> Karl
>
>
> On Mon, Dec 19, 2011 at 2:05 AM, Shinichiro Abe
> wrote:
>> Hi.
>>
>> I checked 0.4 by running ant test, okay but one problem.
>>
>> In multiprocess-example, at default properties.xml, HSQLDB database
>> requires
>> 'org.apache.manifoldcf.hsqldbdatabasepath' property, containing a
>> relative path:
>>
>>
>>
>> Now exception is thrown, so we need to add this property.
>> Should I send a patch? Next?
>>
>> Regards,
>> Shinichiro Abe
>>
>> On 2011/12/18, at 2:27, Karl Wright wrote:
>>
>>> I've again uploaded an apache-manifoldcf-0.4-incubating package which
>>> you
>>> can download from http://people.apache.org/~kwright. If you agree
>>> this should be released please vote +1.
>>>
>>> [Note that the release of this artifact is dependent on the release of
>>> the three plugin packages upon which it depends. If we need to change
>>> those packages we'll need to spin a new RC of this one. Also please
>>> note that I've include SHA1 signatures for the first time, as per
>>> Jukka's suggestion.]
>>>
>>> I apologize again for the earlier hiccup. This one is the real thing,
>>> though, and passes all tests.
>>>
>>> Thanks!
>>> Karl
>>
>>
>>
>>
>> --
>> Piergiorgio Lucidi
>> http://www.open4dev.com
[jira] [Created] (CONNECTORS-343) Severe connector UI bugs
Severe connector UI bugs
Key: CONNECTORS-343
URL: https://issues.apache.org/jira/browse/CONNECTORS-343
Project: ManifoldCF
Issue Type: Bug
Components: Alfresco connector, CMIS connector, OpenSearchServer
connector
Affects Versions: ManifoldCF 0.4
Reporter: Karl Wright
Assignee: Karl Wright
Priority: Critical
Fix For: ManifoldCF 0.4
There are various severe UI bugs with the Alfresco connector, CMIS connector,
and OpenSearchServer connector. These include:
- injection of ${XXX} data into fields on the first (re)post of each edit form
(Alfresco and CMIS only)
- no escaping of string values appropriate for the context of each substitution
value, which means the forms will blow up when unusual values like "<" or ">"
are included in (say) a password
I've fixed these problems on trunk as part of CONNECTORS-335. This ticket is
meant to capture the problem for the 0.4 release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CONNECTORS-341) override config for test cases
[
https://issues.apache.org/jira/browse/CONNECTORS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177124#comment-13177124
]
Karl Wright edited comment on CONNECTORS-341 at 12/29/11 11:53 AM:
---
I had been toying with moving these embedded configuration files to
src/test/resource instead. It sounds like that would mess up your use case
entirely though.
I like the fact that "initialize()" can be separately overridden, but I'd like
perhaps to take it a step further and provide a base class method that is
specifically meant to be overridden such that the values written can be
extended rather than completely replaced, e.g.:
{code}
protected void populateConfigurationXML(StringBuilder sb)
{
...
}
{code}
... which is called from the base class implementation of initialize(). Also a
similar method for logging.ini. Do you understand what I mean, and if so do
you want to modify your patch accordingly?
was (Author: kwri...@metacarta.com):
I had been toying with moving these embedded configuration files to
src/test/resource instead. It sounds like that would mess up your use case
entirely though.
I like the fact that "initialize()" can be separately overridden, but I'd like
perhaps to take it a step further and provide a base class method that is
specifically meant to be overridden such that the values written can be
extended rather than completely replaced, e.g.:
protected void populateConfigurationXML(StringBuilder sb)
{
...
}
... which is called from the base class implementation of initialize(). Also a
similar method for logging.ini. Do you understand what I mean, and if so do
you want to modify your patch accordingly?
> override config for test cases
> --
>
> Key: CONNECTORS-341
> URL: https://issues.apache.org/jira/browse/CONNECTORS-341
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Tests
>Reporter: Martin Goldhahn
> Attachments: CONNECTORS-341.patch
>
>
> It is hard to write a test case for a repository connector using the existing
> *.Base classes that uses a different config file.
> The config files are actually written in
> org.apache.manifoldcf.core.tests.Base.localSetup().
> The localSetup method is called by all sub-classes in their overridden
> localSetup function. each sub-class adds something specific for the test
> case. If I wanted to put something different in the config files I had to
> override localSetup() and copy all content of the superclasses' localSetup to
> it. This can be avoided by moving the code that writes the config file in the
> initialize() method. It makes also more sense in that the creation of the
> config files and the provision of their content are now in the same function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-341) override config for test cases
[
https://issues.apache.org/jira/browse/CONNECTORS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177124#comment-13177124
]
Karl Wright commented on CONNECTORS-341:
I had been toying with moving these embedded configuration files to
src/test/resource instead. It sounds like that would mess up your use case
entirely though.
I like the fact that "initialize()" can be separately overridden, but I'd like
perhaps to take it a step further and provide a base class method that is
specifically meant to be overridden such that the values written can be
extended rather than completely replaced, e.g.:
protected void populateConfigurationXML(StringBuilder sb)
{
...
}
... which is called from the base class implementation of initialize(). Also a
similar method for logging.ini. Do you understand what I mean, and if so do
you want to modify your patch accordingly?
> override config for test cases
> --
>
> Key: CONNECTORS-341
> URL: https://issues.apache.org/jira/browse/CONNECTORS-341
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Tests
>Reporter: Martin Goldhahn
> Attachments: CONNECTORS-341.patch
>
>
> It is hard to write a test case for a repository connector using the existing
> *.Base classes that uses a different config file.
> The config files are actually written in
> org.apache.manifoldcf.core.tests.Base.localSetup().
> The localSetup method is called by all sub-classes in their overridden
> localSetup function. each sub-class adds something specific for the test
> case. If I wanted to put something different in the config files I had to
> override localSetup() and copy all content of the superclasses' localSetup to
> it. This can be avoided by moving the code that writes the config file in the
> initialize() method. It makes also more sense in that the creation of the
> config files and the provision of their content are now in the same function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-341) override config for test cases
[ https://issues.apache.org/jira/browse/CONNECTORS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Goldhahn updated CONNECTORS-341: --- Attachment: CONNECTORS-341.patch > override config for test cases > -- > > Key: CONNECTORS-341 > URL: https://issues.apache.org/jira/browse/CONNECTORS-341 > Project: ManifoldCF > Issue Type: Improvement > Components: Tests >Reporter: Martin Goldhahn > Attachments: CONNECTORS-341.patch > > > It is hard to write a test case for a repository connector using the existing > *.Base classes that uses a different config file. > The config files are actually written in > org.apache.manifoldcf.core.tests.Base.localSetup(). > The localSetup method is called by all sub-classes in their overridden > localSetup function. each sub-class adds something specific for the test > case. If I wanted to put something different in the config files I had to > override localSetup() and copy all content of the superclasses' localSetup to > it. This can be avoided by moving the code that writes the config file in the > initialize() method. It makes also more sense in that the creation of the > config files and the provision of their content are now in the same function. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-341) override config for test cases
[ https://issues.apache.org/jira/browse/CONNECTORS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Goldhahn updated CONNECTORS-341: --- Attachment: (was: CONNECTORS-341.patch) > override config for test cases > -- > > Key: CONNECTORS-341 > URL: https://issues.apache.org/jira/browse/CONNECTORS-341 > Project: ManifoldCF > Issue Type: Improvement > Components: Tests >Reporter: Martin Goldhahn > Attachments: CONNECTORS-341.patch > > > It is hard to write a test case for a repository connector using the existing > *.Base classes that uses a different config file. > The config files are actually written in > org.apache.manifoldcf.core.tests.Base.localSetup(). > The localSetup method is called by all sub-classes in their overridden > localSetup function. each sub-class adds something specific for the test > case. If I wanted to put something different in the config files I had to > override localSetup() and copy all content of the superclasses' localSetup to > it. This can be avoided by moving the code that writes the config file in the > initialize() method. It makes also more sense in that the creation of the > config files and the provision of their content are now in the same function. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-341) override config for test cases
[ https://issues.apache.org/jira/browse/CONNECTORS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Goldhahn updated CONNECTORS-341: --- Attachment: (was: CONNECTORS-341.patch) > override config for test cases > -- > > Key: CONNECTORS-341 > URL: https://issues.apache.org/jira/browse/CONNECTORS-341 > Project: ManifoldCF > Issue Type: Improvement > Components: Tests >Reporter: Martin Goldhahn > Attachments: CONNECTORS-341.patch > > > It is hard to write a test case for a repository connector using the existing > *.Base classes that uses a different config file. > The config files are actually written in > org.apache.manifoldcf.core.tests.Base.localSetup(). > The localSetup method is called by all sub-classes in their overridden > localSetup function. each sub-class adds something specific for the test > case. If I wanted to put something different in the config files I had to > override localSetup() and copy all content of the superclasses' localSetup to > it. This can be avoided by moving the code that writes the config file in the > initialize() method. It makes also more sense in that the creation of the > config files and the provision of their content are now in the same function. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-341) override config for test cases
[ https://issues.apache.org/jira/browse/CONNECTORS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Goldhahn updated CONNECTORS-341: --- Attachment: CONNECTORS-341.patch > override config for test cases > -- > > Key: CONNECTORS-341 > URL: https://issues.apache.org/jira/browse/CONNECTORS-341 > Project: ManifoldCF > Issue Type: Improvement > Components: Tests >Reporter: Martin Goldhahn > Attachments: CONNECTORS-341.patch > > > It is hard to write a test case for a repository connector using the existing > *.Base classes that uses a different config file. > The config files are actually written in > org.apache.manifoldcf.core.tests.Base.localSetup(). > The localSetup method is called by all sub-classes in their overridden > localSetup function. each sub-class adds something specific for the test > case. If I wanted to put something different in the config files I had to > override localSetup() and copy all content of the superclasses' localSetup to > it. This can be avoided by moving the code that writes the config file in the > initialize() method. It makes also more sense in that the creation of the > config files and the provision of their content are now in the same function. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-342) File connector "Paths" tab has broken html
[ https://issues.apache.org/jira/browse/CONNECTORS-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177119#comment-13177119 ] Karl Wright commented on CONNECTORS-342: A fix for this issue has already been checked into trunk as part of CONNECTORS-339. This ticket thus only covers the 0.4-incubating release. > File connector "Paths" tab has broken html > -- > > Key: CONNECTORS-342 > URL: https://issues.apache.org/jira/browse/CONNECTORS-342 > Project: ManifoldCF > Issue Type: Bug > Components: File system connector >Affects Versions: ManifoldCF 0.4 >Reporter: Karl Wright >Assignee: Karl Wright >Priority: Blocker > Fix For: ManifoldCF 0.4 > > > The file system connector has broken HTML for the Paths tab, which blocks > people from using the connector. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-341) override config for test cases
[ https://issues.apache.org/jira/browse/CONNECTORS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Goldhahn updated CONNECTORS-341: --- Attachment: CONNECTORS-341.patch Patch that solves the problem > override config for test cases > -- > > Key: CONNECTORS-341 > URL: https://issues.apache.org/jira/browse/CONNECTORS-341 > Project: ManifoldCF > Issue Type: Improvement > Components: Tests >Reporter: Martin Goldhahn > Attachments: CONNECTORS-341.patch > > > It is hard to write a test case for a repository connector using the existing > *.Base classes that uses a different config file. > The config files are actually written in > org.apache.manifoldcf.core.tests.Base.localSetup(). > The localSetup method is called by all sub-classes in their overridden > localSetup function. each sub-class adds something specific for the test > case. If I wanted to put something different in the config files I had to > override localSetup() and copy all content of the superclasses' localSetup to > it. This can be avoided by moving the code that writes the config file in the > initialize() method. It makes also more sense in that the creation of the > config files and the provision of their content are now in the same function. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CONNECTORS-341) override config for test cases
override config for test cases -- Key: CONNECTORS-341 URL: https://issues.apache.org/jira/browse/CONNECTORS-341 Project: ManifoldCF Issue Type: Improvement Components: Tests Reporter: Martin Goldhahn It is hard to write a test case for a repository connector using the existing *.Base classes that uses a different config file. The config files are actually written in org.apache.manifoldcf.core.tests.Base.localSetup(). The localSetup method is called by all sub-classes in their overridden localSetup function. each sub-class adds something specific for the test case. If I wanted to put something different in the config files I had to override localSetup() and copy all content of the superclasses' localSetup to it. This can be avoided by moving the code that writes the config file in the initialize() method. It makes also more sense in that the creation of the config files and the provision of their content are now in the same function. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CONNECTORS-342) File connector "Paths" tab has broken html
File connector "Paths" tab has broken html -- Key: CONNECTORS-342 URL: https://issues.apache.org/jira/browse/CONNECTORS-342 Project: ManifoldCF Issue Type: Bug Components: File system connector Affects Versions: ManifoldCF 0.4 Reporter: Karl Wright Assignee: Karl Wright Priority: Blocker Fix For: ManifoldCF 0.4 The file system connector has broken HTML for the Paths tab, which blocks people from using the connector. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
