Re: RFR: JDK-8248904: Add support to jpackage for the Mac App Store
On Wed, 10 Mar 2021 12:37:32 GMT, Kevin Rushforth wrote: >> Implementation of Mac App Support including three new mac specific CLI >> options. > > src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties > line 247: > >> 245: \ --mac-app-store\n\ >> 246: \ Indicates that the jpackage output is intended for the\n\ >> 247: \ Mac App Store.\n\ > > Maybe `macOS App Store`? Although I do see it referenced both ways (even by Apple) I see 10 times as many entries in Google for "Mac App Store" (1.7 billion) vs MacOS App Store (155 million) - PR: https://git.openjdk.java.net/jdk/pull/2716
Re: RFR: JDK-8248904: Add support to jpackage for the Mac App Store
On Wed, 10 Mar 2021 12:37:03 GMT, Kevin Rushforth wrote: >> Implementation of Mac App Support including three new mac specific CLI >> options. > > src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties > line 188: > >> 186: \ over-ridden by adding replacement resources to this >> directory.\n\ >> 187: \ (absolute path or relative to the current directory)\n\ >> 188: \ --runtime-image \n\ > > This seems unrelated to this change. yes - it is unrelated, other than I was adding a new help text with the same syntax (--mac-entitlements ) and was looking for consistent way to say "" and found that in all cases except this one we said not so I fixed this one too to make them all consistent. - PR: https://git.openjdk.java.net/jdk/pull/2716
Re: RFR: JDK-8248904: Add support to jpackage for the Mac App Store
On Wed, 24 Feb 2021 21:59:22 GMT, Andy Herrick wrote: > Implementation of Mac App Support including three new mac specific CLI > options. Looks good with a couple questions. Is `JavaApp.icns` intended to be an empty file (I see that the file it was renamed from was empty, so probably OK)? The rest are inline below. src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties line 188: > 186: \ over-ridden by adding replacement resources to this > directory.\n\ > 187: \ (absolute path or relative to the current directory)\n\ > 188: \ --runtime-image \n\ This seems unrelated to this change. src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties line 247: > 245: \ --mac-app-store\n\ > 246: \ Indicates that the jpackage output is intended for the\n\ > 247: \ Mac App Store.\n\ Maybe `macOS App Store`? - Marked as reviewed by kcr (Author). PR: https://git.openjdk.java.net/jdk/pull/2716
Re: RFR: JDK-8248904: Add support to jpackage for the Mac App Store
On Wed, 24 Feb 2021 21:59:22 GMT, Andy Herrick wrote: > Implementation of Mac App Support including three new mac specific CLI > options. Marked as reviewed by kizune (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2716
Re: RFR: JDK-8248904: Add support to jpackage for the Mac App Store
On Wed, 24 Feb 2021 21:59:22 GMT, Andy Herrick wrote: > Implementation of Mac App Support including three new mac specific CLI > options. Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/2716
Re: RFR: JDK-8248904: Add support to jpackage for the Mac App Store
On Wed, 24 Feb 2021 21:59:22 GMT, Andy Herrick wrote: > Implementation of Mac App Support including three new mac specific CLI > options. Marked as reviewed by asemenyuk (Committer). - PR: https://git.openjdk.java.net/jdk/pull/2716
