Re: [Curtin-dev] [Merge] ~lamoura/curtin:disable-networking-config into curtin:master

2020-05-20 Thread Server Team CI bot
Review: Approve continuous-integration

PASSED: Continuous integration, rev:acc75e2e528df66ea4ae8d9134a7adb6d14b2d63
https://jenkins.ubuntu.com/server/job/curtin-ci/120/
Executed test runs:
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/120/
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/120/
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/120/
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/120/


Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/120//rebuild
-- 
https://code.launchpad.net/~lamoura/curtin/+git/curtin/+merge/383785
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~lamoura/curtin:disable-networking-config into curtin:master

2020-05-20 Thread Lucas Albuquerque Medeiros de Moura
raharper, I have updated the code with the test refactoring. All network 
disable tests are now in the same file.
-- 
https://code.launchpad.net/~lamoura/curtin/+git/curtin/+merge/383785
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~lamoura/curtin:disable-networking-config into curtin:master

2020-05-20 Thread Ryan Harper
On Wed, May 20, 2020 at 1:43 PM Lucas Albuquerque Medeiros de Moura <
lucas.mo...@canonical.com> wrote:

> Wait, I think I missed something for these scenarios:
>
>  network: {config: disabled}
>  network: {config: disabled, version=1}
>
> We should not create the /etc/cloud/cloud.cfg.d/50-curtin-networking.cfg
> file for them ?
>

> I thought that they were valid cloudinit configs and we should propagate
> them. Right now, we are creating those files for these scenarios.
>

Yes, you're right;  Looking back at my first comment we definitely want to
allow someone to write a config to disable cloud-init's networking.

Revising, I'd still like to keep all of the disabled scenarios in a single
test class file, and to help me separate them:

CurtinDisableNetworkRendering (net-meta --mode=disabled)
CurtinDisableCloudInitNetworking (network: {config: disabled})
CurtinDisableCloudInitNetworkingVersion1 (network: {config: disabled,
version=1}


-- 
> https://code.launchpad.net/~lamoura/curtin/+git/curtin/+merge/383785
> You are reviewing the proposed merge of
> ~lamoura/curtin:disable-networking-config into curtin:master.
>

https://code.launchpad.net/~lamoura/curtin/+git/curtin/+merge/383785
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~lamoura/curtin:disable-networking-config into curtin:master

2020-05-20 Thread Lucas Albuquerque Medeiros de Moura
Wait, I think I missed something for these scenarios:

 network: {config: disabled}
 network: {config: disabled, version=1}

We should not create the /etc/cloud/cloud.cfg.d/50-curtin-networking.cfg file 
for them ?

I thought that they were valid cloudinit configs and we should propagate them. 
Right now, we are creating those files for these scenarios.
-- 
https://code.launchpad.net/~lamoura/curtin/+git/curtin/+merge/383785
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~lamoura/curtin:disable-networking-config into curtin:master

2020-05-20 Thread Ryan Harper
For the three scenarios:

net-meta mode=disabled
network: {config: disabled}
network: {config: disabled, version=1}

We need to check that in the target system, we do not find
/etc/cloud/cloud.cfg.d/50-curtin-networking.cfg

So, let's put that unittest in its own base class and then
build each scenario on top of the base class.  We'll also
include all of the networking skiptests in the base class
as without networking, we must skip all of those changes.

This all can be done in just the test_network_disabled.py module.

Like so:

https://paste.ubuntu.com/p/cq366Z2BXB/

I bind the conf_file to another base class, so that we don't repeat the
conf when we add additional ubuntu classes, for example when we add
GroovyTestNetworkDisabled, we just declare an additional class specifying
the release and the scenario class we need.

-- 
https://code.launchpad.net/~lamoura/curtin/+git/curtin/+merge/383785
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~raharper/curtin:fix/partition-verify-flags-msdos-primary-types into curtin:master

2020-05-20 Thread Server Team CI bot
Review: Approve continuous-integration

PASSED: Continuous integration, rev:669b5cf73d4cf15e1bccfb9913f15125fbb4b9c1
https://jenkins.ubuntu.com/server/job/curtin-ci/119/
Executed test runs:
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/119/
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/119/
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/119/
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/119/


Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/119//rebuild
-- 
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/384133
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~lamoura/curtin:disable-networking-config into curtin:master

2020-05-20 Thread Lucas Albuquerque Medeiros de Moura
The TestNetMetaDisabledModeBaseTestsAbs overrides some of tests that the 
network disable config should use. For example, this class overrides the test:

test_cloudinit_network_passthrough

Which is a test that should be performed for the disable cloud config tests. 
But I can move this override to the concrete class without an issue. But we 
would need to override them on each Ubuntu version that we need to test this 
configuration on.

Also, TestNetMetaDisabledModeBaseTestsAbs, has the implementation of the 
test_cloudinit_network_not_created test, which checks if the cloudinit network 
file was not created. However, this is not the case for the network config 
disable tests.

This means that we would need to remove this implementation from the abstract 
class or skip it in the network disabled config classes. Since the abstract 
class is specific for the net_meta disabled mode, I think it would be better to 
keep that test in the abstract file.

With that said, the network disable config tests would need to:

* skip the test_cloudinit_network_not_created test
* override the conf_file

Which are the two main characteristics that define the 
TestNetMetaDisabledModeBaseTestsAbs class. They would benefit from other 
network tests that are already skipped, but I don't think that this a huge 
benefit.

But I can be missing something, so if you disagree, just let me know.
-- 
https://code.launchpad.net/~lamoura/curtin/+git/curtin/+merge/383785
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~raharper/curtin:fix/partition-verify-flags-msdos-primary-types into curtin:master

2020-05-20 Thread Server Team CI bot
Review: Needs Fixing continuous-integration

FAILED: Continuous integration, rev:7e0fb61b9b9ab35b02ff485ebfe963b1ee77ff01
https://jenkins.ubuntu.com/server/job/curtin-ci/118/
Executed test runs:
FAILURE: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/118/
FAILURE: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/118/
FAILURE: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/118/
FAILURE: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/118/


Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/118//rebuild
-- 
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/384133
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~lamoura/curtin:disable-networking-config into curtin:master

2020-05-20 Thread Ryan Harper
Review: Needs Information

Thanks, one more question on the vmtests; it's not clear to me why we've got 
network-disabled tests in test_network.py rather than both of those classes in 
test_network_disabled.py and have the two different config versions subclass 
from your main TestNetMetaDisabled abstract class?

Diff comments:

> diff --git a/tests/vmtests/test_network.py b/tests/vmtests/test_network.py
> index 7d2e779..c49262a 100644
> --- a/tests/vmtests/test_network.py
> +++ b/tests/vmtests/test_network.py
> @@ -491,4 +491,34 @@ class 
> Centos70TestNetworkBasic(centos_relbase.centos70_xenial,
> CentosTestNetworkBasicAbs):
>  __test__ = True
>  
> +
> +class FocalTestNetworkDisabledConfigWithVersion(relbase.focal,
> +TestNetworkBasicAbs):
> +""" Basic network test but with network config marked as disabled
> +with a version key
> +"""
> +conf_file = "examples/tests/network_config_disabled_with_version.yaml"
> +__test__ = True
> +
> +def test_etc_resolvconf(self):
> +raise SkipTest('not available on %s' % self.__class__)
> +
> +def test_ip_output(self):
> +raise SkipTest('not available on %s' % self.__class__)
> +
> +

Shouldn't both of these be in test_network_disabled?  And derived from 
TestNetMetaDisabledModeBasicTestsAbs?

> +class FocalTestNetworkDisabledConfig(relbase.focal, TestNetworkBasicAbs):
> +""" Basic network test but with network config marked as disabled
> +without a version key
> +"""
> +conf_file = "examples/tests/network_config_disabled.yaml"
> +__test__ = True
> +
> +def test_etc_resolvconf(self):
> +raise SkipTest('not available on %s' % self.__class__)
> +
> +def test_ip_output(self):
> +raise SkipTest('not available on %s' % self.__class__)
> +
> +
>  # vi: ts=4 expandtab syntax=python


-- 
https://code.launchpad.net/~lamoura/curtin/+git/curtin/+merge/383785
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~falcojr/curtin:fix-mdraid-name into curtin:master

2020-05-20 Thread Ryan Harper
This looks good!  I think we can update one or more of our raid vmtests config 
to use the extended name;  and we'll likely want to add a vmtest *unittest* to 
verify we find the device in /dev/md/

See examples/tests/raid5boot.yaml  and 
tests/vmtests/test_mdadm_bcache.py:TestRaid5bootAbs
-- 
https://code.launchpad.net/~falcojr/curtin/+git/curtin/+merge/384209
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


[Curtin-dev] [Merge] ~raharper/curtin:fix/replace-grub-shell-helper into curtin:master

2020-05-20 Thread Server Team CI bot
The proposal to merge ~raharper/curtin:fix/replace-grub-shell-helper into 
curtin:master has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
-- 
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~raharper/curtin:fix/replace-grub-shell-helper into curtin:master

2020-05-20 Thread Server Team CI bot
Review: Approve continuous-integration


-- 
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~raharper/curtin:fix/replace-grub-shell-helper into curtin:master

2020-05-20 Thread Server Team CI bot
Review: Needs Fixing continuous-integration

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/201/
Executed test runs:
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/201/
FAILURE: 
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/201/
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/201/
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/201/

-- 
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~lamoura/curtin:disable-networking-config into curtin:master

2020-05-20 Thread Server Team CI bot
Review: Approve continuous-integration

PASSED: Continuous integration, rev:1bf73abf551d8bdcfa026f943f0d2403544d3af0
https://jenkins.ubuntu.com/server/job/curtin-ci/117/
Executed test runs:
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/117/
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/117/
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/117/
SUCCESS: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/117/


Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/117//rebuild
-- 
https://code.launchpad.net/~lamoura/curtin/+git/curtin/+merge/383785
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~raharper/curtin:fix/replace-grub-shell-helper into curtin:master

2020-05-20 Thread Ryan Harper
Merged a fix for the streams url, marking approved to re-run the autolander
-- 
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


[Curtin-dev] [Merge] ~raharper/curtin:fix/replace-grub-shell-helper into curtin:master

2020-05-20 Thread Ryan Harper
The proposal to merge ~raharper/curtin:fix/replace-grub-shell-helper into 
curtin:master has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
-- 
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


[Curtin-dev] [Merge] ~legovini/curtin:update-maas-streams-url into curtin:master

2020-05-20 Thread noreply
The proposal to merge ~legovini/curtin:update-maas-streams-url into 
curtin:master has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
-- 
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~legovini/curtin:update-maas-streams-url into curtin:master

2020-05-20 Thread Ryan Harper
I notified in #maas about the URL breaking.  I'm pushing this branch to master 
so we can autoland again.
-- 
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~legovini/curtin:update-maas-streams-url into curtin:master

2020-05-20 Thread Server Team CI bot
Review: Needs Fixing continuous-integration

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/200/
Executed test runs:
FAILURE: 
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/200/
FAILURE: 
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/200/
FAILURE: 
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/200/
FAILURE: 
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/200/

-- 
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~legovini/curtin:update-maas-streams-url into curtin:master

2020-05-20 Thread Ryan Harper
We may need to pull and push this directly to master if the autolander is going 
to fail as well.
-- 
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


[Curtin-dev] [Merge] ~legovini/curtin:update-maas-streams-url into curtin:master

2020-05-20 Thread Ryan Harper
The proposal to merge ~legovini/curtin:update-maas-streams-url into 
curtin:master has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
-- 
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~legovini/curtin:update-maas-streams-url into curtin:master

2020-05-20 Thread Ryan Harper
Review: Approve

I'm +1 on this; did we file an RT or some thing to let them know the old URL 
does not get to the right place?
-- 
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~legovini/curtin:update-maas-streams-url into curtin:master

2020-05-20 Thread Paride Legovini
Which is normal as the sync-images stage is *not* part of the CI run, it 
happens before it, and it's done by Jenkins with whatever is already on master.
-- 
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is requested to review the proposed merge of 
~legovini/curtin:update-maas-streams-url into curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~raharper/curtin:vmtest/enable-kernel-crashdump into curtin:master

2020-05-20 Thread Paride Legovini
Thanks for the explanations, post-standup and here. From my testing this all 
works as intended, and will greatly help speeding up the vmtest runs.
-- 
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/383805
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~legovini/curtin:update-maas-streams-url into curtin:master

2020-05-20 Thread Paride Legovini
CI is failing for the exact problem this MP fixes.
-- 
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is requested to review the proposed merge of 
~legovini/curtin:update-maas-streams-url into curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~lamoura/curtin:disable-networking-config into curtin:master

2020-05-20 Thread Paride Legovini
This MP should get the CI going again:

https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245

Background info: the vmtests run on the MAAS images, which are automatically 
synced as part of vmtest Jenkins jobs when needed. (The logic is slightly more 
complex, but doesn't matter here.) What seems to be broken is the URL the 
vmtest-sync-images script uses to retrieve the streams (json data) listing the 
available images and their location. The MP above fixes the URL.
-- 
https://code.launchpad.net/~lamoura/curtin/+git/curtin/+merge/383785
Your team curtin developers is subscribed to branch curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Curtin-dev] [Merge] ~legovini/curtin:update-maas-streams-url into curtin:master

2020-05-20 Thread Server Team CI bot
Review: Needs Fixing continuous-integration

FAILED: Continuous integration, rev:69a1404ff4f986db1fcbaa357050fb32b23de623
https://jenkins.ubuntu.com/server/job/curtin-ci/116/
Executed test runs:
FAILURE: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/116/
FAILURE: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/116/
FAILURE: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/116/
FAILURE: 
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/116/


Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/116//rebuild
-- 
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is requested to review the proposed merge of 
~legovini/curtin:update-maas-streams-url into curtin:master.

-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp


[Curtin-dev] [Merge] ~legovini/curtin:update-maas-streams-url into curtin:master

2020-05-20 Thread Paride Legovini
Paride Legovini has proposed merging ~legovini/curtin:update-maas-streams-url 
into curtin:master.

Commit message:
vmtest-sync-images: update the URL of the maas streams

The old URL goes through a couple of redirects but does not land at the
correct location.

Requested reviews:
  curtin developers (curtin-dev)

For more details, see:
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
-- 
Your team curtin developers is requested to review the proposed merge of 
~legovini/curtin:update-maas-streams-url into curtin:master.
diff --git a/tests/vmtests/image_sync.py b/tests/vmtests/image_sync.py
index 2559984..e460e02 100644
--- a/tests/vmtests/image_sync.py
+++ b/tests/vmtests/image_sync.py
@@ -34,7 +34,7 @@ def environ_get(key, default):
 
 IMAGE_SRC_URL = environ_get(
 'IMAGE_SRC_URL',
-"http://maas.ubuntu.com/images/ephemeral-v3/daily/streams/v1/index.sjson";)
+"http://images.maas.io/ephemeral-v3/daily/streams/v1/index.sjson";)
 IMAGE_DIR = environ_get("IMAGE_DIR", "/srv/images")
 
 KEYRING = environ_get(
-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp