Bug#986108: RFS: f3d/1.1.0-1 [ITP] -- fast and minimalist 3D viewer
Hi Bastian, I've updated the salsa repo with the repacking and I've also pushed the updated package to mentors. https://mentors.debian.net/package/f3d/ Salsa CI is still failing with an error that I do not understand. Maybe from git lfs storage in the documentation folder? https://salsa.debian.org/debian/f3d/-/jobs/2156215 I may also exclude this folder in the repacking as we do not generate the documentation. Not sure this is a good solution as we may want to also deliver documentation in the future. Could you please review again? Best Regards, François signature.asc Description: This is a digitally signed message part
Bug#986108: RFS: f3d/1.1.0-1 [ITP] -- fast and minimalist 3D viewer
Hello Bastian, Thanks for the salsa Debian repository creation and copyright update! In the meantime, I've updated the upstream issue with the binary package information you've provided. The only remaining item is the "data" folder. The copyright is apparently the global BSD-3 licence, but I agree that the origin is unclear. Fortunately, it looks like it's used for testing purpose only so it would be OK to remove it from the Debian archive. I propose to repack the source with the +dfsg prefix to remove this folder. Do you agree? Best, François signature.asc Description: This is a digitally signed message part
Bug#986108: RFS: f3d/1.1.0-1 [ITP] -- fast and minimalist 3D viewer
On 06.11.21 21:00, François Mazen wrote: The only remaining item is the "data" folder. The copyright is apparently the global BSD-3 licence, but I agree that the origin is unclear. Fortunately, it looks like it's used for testing purpose only so it would be OK to remove it from the Debian archive. I propose to repack the source with the +dfsg prefix to remove this folder. Do you agree? Yes, please do that.
Bug#986108: RFS: f3d/1.1.0-1 [ITP] -- fast and minimalist 3D viewer
Control: tags -1 moreinfo On 04.11.21 22:21, François Mazen wrote: Hello Bastian, Please consider relicensing debian/* or at least debian/patches/* I've relicensed to BSD-3, in order to match upstream license. Ken Martin, Will Schroeder, Bill Lorensen's copyright is missing. I guess you are referencing classic VTK's copyright. F3D's copyright is "Kitware, SAS" according to source code and official website, without any link to VTK's copyright. It is fine for them not to include it because these people obviously have the say over Kitware. Still, there are three source files that have their copyright and are BSD licensed. The license mandates including the copyright in any distribution, which is why Debian mandates it to be in the d/copyright file for the binary package to be compliant. I have added them to the git. src/cxxopts.hpp: Expat license is missing. Added to the copyright file, and I've opened an upstream bug: https://gitlab.kitware.com/f3d/f3d/-/issues/253 That is very kind of you. For the binaries that Kitware provides they are actually in breach of that license (given the file is actually compiled). Have you checked the files in the data directory? At least data/BoxAnimated0.bin is not a source file and some others might not be. Non-source files (defined as preferred format for modification) have to be excluded. Also, does the files' metadata say anythinng about copyright or license? d/f3d.1 === Please describe the options in the man page. Man page updated. You should prefer using the not-installed file for this use case. The not-installed file seems to avoid trigger dh_missing error, which is not what I need here. I haven't figured out how exclude files during the CMake install target (--exclude has no effect), so I've added an "rm" command in the rules file. If there is a better way, please suggest. I see you have already found another way... I suggest to have the package in Salsa's debian namespace so that others can contribute easily. If you agree I can create that and grant you maintainer rights for it. Yes! Please create the debian repository and grant me right to maintain it. Done. The CI test suite won't run because of the .lfsconfig file which is why I have disabled it.
Bug#986108: RFS: f3d/1.1.0-1 [ITP] -- fast and minimalist 3D viewer
Hello Bastian, > Please consider relicensing debian/* or at least debian/patches/* I've relicensed to BSD-3, in order to match upstream license. > Ken Martin, Will Schroeder, Bill Lorensen's copyright is missing. I guess you are referencing classic VTK's copyright. F3D's copyright is "Kitware, SAS" according to source code and official website, without any link to VTK's copyright. > src/cxxopts.hpp: Expat license is missing. Added to the copyright file, and I've opened an upstream bug: https://gitlab.kitware.com/f3d/f3d/-/issues/253 > d/f3d.1 > === > Please describe the options in the man page. Man page updated. > You should prefer using the not-installed file for this use case. The not-installed file seems to avoid trigger dh_missing error, which is not what I need here. I haven't figured out how exclude files during the CMake install target (--exclude has no effect), so I've added an "rm" command in the rules file. If there is a better way, please suggest. > I suggest to have the package in Salsa's debian namespace so that > others > can contribute easily. If you agree I can create that and grant you > maintainer rights for it. Yes! Please create the debian repository and grant me right to maintain it. Thanks a lot for this review, the new package is available on mentors. Best, François signature.asc Description: This is a digitally signed message part
Bug#986108: RFS: f3d/1.1.0-1 [ITP] -- fast and minimalist 3D viewer
Control: tags -1 moreinfo On Mon, 29 Mar 2021 18:53:15 +0200 franc...@mzf.fr wrote: I am looking for a sponsor for my package "f3d": * Package name: f3d Version : 1.1.0-1 Upstream Author : Kitware SAS * URL : https://kitware.github.io/F3D/ * License : BSD-3-clause * Vcs : https://salsa.debian.org/mzf/f3d Section : graphics d/copyright === Please consider relicensing debian/* or at least debian/patches/* to a license that is not more restrictive than upstream's. Currently, a copyrightable patch (the existing ones are probably too trivial) would make the package a GPL-2+ package. Ken Martin, Will Schroeder, Bill Lorensen's copyright is missing. src/cxxopts.hpp: Expat license is missing. d/f3d.1 === Please describe the options in the man page. d/patches/do_not_install_license_file.patch === You should prefer using the not-installed file for this use case. General rule: Don't patch when you can get the same effect via different means. Vcs === I suggest to have the package in Salsa's debian namespace so that others can contribute easily. If you agree I can create that and grant you maintainer rights for it. When you have uploaded the next revision to review (Please keep the version and changelog!) please remove the moreinfo tag.
Bug#986108: RFS: f3d/1.1.0-1 [ITP] -- fast and minimalist 3D viewer
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "f3d": * Package name: f3d Version : 1.1.0-1 Upstream Author : Kitware SAS * URL : https://kitware.github.io/F3D/ * License : BSD-3-clause * Vcs : https://salsa.debian.org/mzf/f3d Section : graphics It builds those binary packages: f3d - fast and minimalist 3D viewer To access further information about this package, please visit the following URL: https://mentors.debian.net/package/f3d/ Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/f/f3d/f3d_1.1.0-1.dsc Changes for the initial release: f3d (1.1.0-1) unstable; urgency=medium . * Initial release (Closes: #985993) Regards,
