Bug#852708: linux: null ptr dereference in sunrpc from 3.16

2017-01-26 Thread Raphael Geissert
735804]  [] ? path_lookupat+0x5b/0x780
[  196.735807]  [] ? complete_walk+0x47/0xd0
[  196.735809]  [] ? filename_lookup+0x26/0xc0
[  196.735811]  [] ? user_path_at_empty+0x54/0x90
[  196.735814]  [] ? from_kgid_munged+0xe/0x20
[  196.735816]  [] ? cp_new_stat+0x13a/0x160
[  196.735818]  [] ? vfs_fstatat+0x46/0x90
[  196.735821]  [] ? SYSC_newlstat+0x1d/0x40
[  196.735824]  [] ? system_call_fast_compare_end+0x10/0x15
[  196.735825] Code: 00 00 48 ff c8 75 fb 48 ff c8 c3 0f 1f 80 00 00
00 00 0f 1f 44 00 00 48 8b 05 6c 0a 5e 00 ff e0 66 90 65 48 8b 14 25
e0 26 01 00 <48> 8d 0c 12 48 c1 e2 06 48 8d 04 bd 00 00 00 00 48 29 ca
f7 e2

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net



Bug#844600: initramfs-tools-core: inconditional copy of /etc/modprobe.d/*

2016-11-17 Thread Raphael Geissert
Control: forcemerge 829280 -1
thanks

Hi Michael!

On 17 November 2016 at 16:16, Michael Prokop <m...@debian.org> wrote:
> * Raphael Geissert [Thu Nov 17, 2016 at 03:51:33PM +0100]:
>
>> mkinitramfs attempts to copy /etc/modprobe.d/* (module-init-tools
>> section), without checking if there are actually files in that
>> directory. This results in a warning in the middle of update-initramfs
>> as /etc/modprobe.d/* does not exist.
>
> This is #829280 and just waiting for a new release to be done.

Ah, thanks. I didn't look at the source package reports...

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net



Bug#844600: initramfs-tools-core: inconditional copy of /etc/modprobe.d/*

2016-11-17 Thread Raphael Geissert
Package: initramfs-tools-core
Version: 0.125
Severity: minor

Hi,

mkinitramfs attempts to copy /etc/modprobe.d/* (module-init-tools
section), without checking if there are actually files in that
directory. This results in a warning in the middle of update-initramfs
as /etc/modprobe.d/* does not exist.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net



Bug#796386: [PATCH] linux: correct spelling mistake in au8622_dig driver

2015-08-21 Thread Raphael Geissert
Source: linux
Source-Version: 4.1.3-1
Tags: patch
Severity: minor

---
Index: sources-linux/4.1.3-1/drivers/media/dvb-frontends/au8522_dig.c
===
--- sources-linux/4.1.3-1/drivers/media/dvb-frontends/au8522_dig.c
+++ sources-linux/4.1.3-1/drivers/media/dvb-frontends/au8522_dig.c
@@ -921,9 +921,9 @@
 module_param(debug, int, 0644);
 MODULE_PARM_DESC(debug, Enable verbose debug messages);

 module_param(zv_mode, int, 0644);
-MODULE_PARM_DESC(zv_mode, Turn on/off ZeeVee modulator compatability
mode (default:on).\n
+MODULE_PARM_DESC(zv_mode, Turn on/off ZeeVee modulator compatibility
mode (default:on).\n
  \t\ton - modified AU8522 QAM256 initialization.\n
  \t\tProvides faster lock when using ZeeVee modulator based sources);

 MODULE_DESCRIPTION(Auvitek AU8522 QAM-B/ATSC Demodulator driver);



Bug#772297: linux-kbuild-3.16: bashism in /bin/sh script

2014-12-06 Thread Raphael Geissert
Package: linux-kbuild-3.16
Severity: normal
Version: 3.16-2
User: debian-rele...@lists.debian.org
Usertags: goal-dash

Hi,

I've ran checkbashisms (from the 'devscripts' package) over the whole
archive and I found that your package has a /bin/sh script that uses a
bashism.

checkbashisms' output:
 possible bashism in ./usr/lib/linux-kbuild-3.16/scripts/setlocalversion
 line 87 (should be 'b = a'):
 if [ `hg log -r . --template '{latesttagdistance}'` ==
 1 ]; then


Not using bash (or a Debian Policy compliant shell interpreter that doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours. Please be aware that dash is the default /bin/sh.

Please closely examine the above output and the script, and determine
what the proper severity of the bug is, and adjust it accordingly. If
it's important or greater please hurry to get this fixed for jessie.

Hints about how to fix bashisms can be found at:
https://wiki.ubuntu.com/DashAsBinSh

Thanks in advance,
Raphael Geissert


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/1506320.D00f8LNljj@eee



Bug#772335: initramfs-tools: bashism in /bin/sh script

2014-12-06 Thread Raphael Geissert
Package: initramfs-tools
Severity: important
Version: 0.118
User: debian-rele...@lists.debian.org
Usertags: goal-dash

Hi,

I've ran checkbashisms (from the 'devscripts' package) over the whole
archive and I found that your package has a /bin/sh script that uses a
bashism.

checkbashisms' output:
 possible bashism in ./usr/sbin/mkinitramfs line 357 ($UID should be $(id
 -ru)):
 [ $UID != 0 ]  cpio_owner_root=-R 0:0
  blkid -p -n swap $RESUME /dev/null 21; then


Not using bash (or a Debian Policy compliant shell interpreter that doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours. Please be aware that dash is the default /bin/sh.

Please closely examine the above output and the script, and determine
what the proper severity of the bug is, and adjust it accordingly. If
it's important or greater please hurry to get this fixed for jessie.

Hints about how to fix bashisms can be found at:
https://wiki.ubuntu.com/DashAsBinSh

Thanks in advance,
Raphael Geissert


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/4043855.4VoL8qu7yY@eee



Bug#751408: linux-3.2: xhci_hcd: ERR: no room for command on command ring

2014-10-08 Thread Raphael Geissert
Hi Ben,

As discussed during Debconf, I can easily reproduce this bug when, on
laptop with an xhci-controlled device I plug a USB 2 device and
suspend the machine. As soon as it is brought back from S3 and that
the devices are probed the bug occurs and from that point on the
xhci-controlled devices become non-functional. Also, as discussed,
rmmod'ing the xhci module isn't enough to make the devices functional
again, one also needs to remove the ehci module - so it would appear
that the bug affects one of the structures that are passed back to
ehci by xhci during suspend and other operations.

HTH.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/CAA7hUgGcxAnu1qi9T+8_wtb6RaCfP=zwgfjzrna_dqmd68a...@mail.gmail.com



Bug#751408: linux-3.2: xhci_hcd: ERR: no room for command on command ring

2014-06-16 Thread Raphael Geissert
On 12 June 2014 16:59, Raphael Geissert geiss...@debian.org wrote:
[...]
 So, searching a bit on the git log leads to the following commits:

 xhci: Reset reserved command ring TRBs on cleanup.  - likely to fix
 the no room for command bug
 https://github.com/torvalds/linux/commit/33b2831ac870d50cc8e01c317b07fb1e69c13fe1

 xHCI: add aborting command ring function - unlikely to be it, but
 maybe a fix for other bugs
 https://github.com/torvalds/linux/commit/b92cc66c047ff7cf587b318fe377061a353c120f

Ok, noticed these two have already been merged in 3.2, so those aren't
the interesting ones...

 xHCI: dynamic ring expansion - likely to fix other bugs, and maybe
 help on this one
 https://github.com/torvalds/linux/commit/8dfec6140fc617b932cf9a09ba46d0ee3f3a7d87

This one needs a bit of backporting, so I haven't tested with it yet.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/CAA7hUgF2UQFXjx86mkB7QysjPdA8X7xqySWe7uOGpHp=nr_...@mail.gmail.com



Bug#751408: linux-3.2: xhci_hcd: ERR: no room for command on command ring

2014-06-12 Thread Raphael Geissert
Source: linux
Version: 3.2.57-3
Severity: important

Hi,

On some laptops such as HP's ZBook 15 that only have USB 3 ports, I
can reproducibly make the kernel ignore usb devices, in which case
syslog reads as follows:

ERROR no room on ep ring
ERR: No room for command on command ring
device not accepting address 5, error -12
couldn't allocate port 6 usb_device

So far I have reproduced it by plugging a USB 2.0 device on any of the
ports, by doing it several times (plugging  unplugging) the kernel
reaches the state where plugging again any device leads to the above
error.

Searching for the error message on $subject it shows several reports
of the same problem.

This problem can no longer be reproduced with a  kernel backported
from jessie/sid.

So, searching a bit on the git log leads to the following commits:

xhci: Reset reserved command ring TRBs on cleanup.  - likely to fix
the no room for command bug
https://github.com/torvalds/linux/commit/33b2831ac870d50cc8e01c317b07fb1e69c13fe1

xHCI: add aborting command ring function - unlikely to be it, but
maybe a fix for other bugs
https://github.com/torvalds/linux/commit/b92cc66c047ff7cf587b318fe377061a353c120f

xHCI: dynamic ring expansion - likely to fix other bugs, and maybe
help on this one
https://github.com/torvalds/linux/commit/8dfec6140fc617b932cf9a09ba46d0ee3f3a7d87

I intend to test those, but sending the report in advance.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/CAA7hUgGfXC3tjE9Pf5dDN+sR34cRywbGZC60uiHM=vlchfq...@mail.gmail.com



Bug#697963: linux-image-3.2.0-4-amd64: xhci_hcd breaks suspend

2014-06-12 Thread Raphael Geissert
Hi,

I can reproduce this problem. Unloading the module before suspending
works around the problem.

Perhaps this is related:
https://github.com/torvalds/linux/commit/8b3d45705e54075cfb9d4212dbca9ea82c85c4b8

Will check with newer kernels and if already fixed before attempting
to backport that commit.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/CAA7hUgGuJGG1TzYD=phf5sa4ezod4jkssdj4jcrqpjklyi4...@mail.gmail.com



Bug#741952: linux: Possible bug in 3.2's cifs/file.c, use of uninitialized variable

2014-04-07 Thread Raphael Geissert
On 7 April 2014 04:34, Ben Hutchings b...@decadent.org.uk wrote:
 Agreed; what do you think of this patch?
[...]
 From: Ben Hutchings b...@decadent.org.uk
 Date: Mon, 07 Apr 2014 03:29:24 +0100
 Subject: cifs: cifs_iovec_write(): fix use of uninitialised var
 Bug-Debian: https://bugs.debian.org/741952
 Forwarded: not-needed

 If the first call to cifs_reopen_file() from cifs_iovec_write() fails,
 written is not initialised.  We must check rc before written.

 ---
 --- a/fs/cifs/file.c
 +++ b/fs/cifs/file.c
 @@ -2194,15 +2194,17 @@ cifs_iovec_write(struct file *file, cons
 for (i = 0; i  npages; i++)
 kunmap(pages[i]);

 +   if (rc  0) {
 +   if (!total_written)
 +   total_written = rc;
 +   break;
 +   }
 +
 if (written) {
 len -= written;
 total_written += written;
 cifs_update_eof(CIFS_I(inode), *poffset, written);
 *poffset += written;
 -   } else if (rc  0) {
 -   if (!total_written)
 -   total_written = rc;
 -   break;
 }

 /* get length and number of kvecs of the next write */


Looks good to me.

Thanks,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/CAA7hUgFcbsYc_EcBo3cFiQMAsk=ySwwi=xfkvfuvewnodzy...@mail.gmail.com



Bug#741958: [PATCH 3.2 17/18] cifs: ensure that uncached writes handle unmapped areas correctly

2014-04-07 Thread Raphael Geissert
Hi,

On 7 April 2014 03:41, Ben Hutchings b...@decadent.org.uk wrote:
 On Mon, 2014-04-07 at 00:35 +0100, Ben Hutchings wrote:
 3.2.57-rc1 review patch.  If anyone has any objections, please let me know.
 [...]
 --- a/fs/cifs/file.c
 +++ b/fs/cifs/file.c
[...]
 +   /*
 +* i + 1 now represents the number of pages we actually used 
 in
 +* the copy phase above.
 +*/
 +   npages = min(npages, i + 1);

I'm having trouble understanding why min() is needed here. It
shouldn't harm either, but I find it confusing.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/caa7hugeiatb_r3_odpxvgvsvoqvrechjpcl6gyyvtf8vxiy...@mail.gmail.com



Bug#741952: linux: Possible bug in 3.2's cifs/file.c, use of uninitialized variable

2014-03-17 Thread Raphael Geissert
Source: linux
Version: 3.2.54-2

Hi,

In fs/cifs/file.c's cifs_iovec_write I believe that 'written'[1] can
be used while not initialized: it is initialized in the call to
CIFSSMBWrite2[2] but that code may not be run whenever
cifs_reopen_file fails with any error other than EAGAIN. In that case,
it would be used, uninitialized, to check it against 0[4] and then
used to modify a series of size_t, ssize_t, loff_t, etc.

I have not tried to follow what could actually happen in that case.

From a quick look to cifs_reopen_file it appears that at least EACCES
and ENOMEM can be returned.

It would appear that this was fixed in 3.4 with the move to async
writes in da82f7e755d2808ba726c9b23267d5bb23980e94

[1]http://sources.debian.net/src/linux/3.2.54-2/fs/cifs/file.c#L2108
[2]http://sources.debian.net/src/linux/3.2.54-2/fs/cifs/file.c#L2190
[3]http://sources.debian.net/src/linux/3.2.54-2/fs/cifs/file.c#L2183
[4]http://sources.debian.net/src/linux/3.2.54-2/fs/cifs/file.c#L2197

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/CAA7hUgFxUokzF_aXYFouY5CcpiN=cr48qs8vx__tu-mhtce...@mail.gmail.com



Bug#741955: linux: ssize_t casted to unsigned int in fs/cifs/file.c when CONFIG_CIFS_STATS is set

2014-03-17 Thread Raphael Geissert
Source: linux
Version: 3.2.54-2
Severity: minor

Hi,

Similar to my previous bug report, I noticed that cifs_iovec_write
sets the sszie_t 'total_written' to 'rc'[1] but at a later point it
calls cifs_stats_bytes_written[2] with that 0 value.
When CONFIG_CIFS_STATS is set, it casts what is passed from
'total_written' as an unsigned int and then increases a counter
(tcon-bytes_written) with it.

Have not checked what could happen later on.

This seems to have been fixed in 3.4 with the move to async writes
with da82f7e755d2808ba726c9b23267d5bb23980e94.

[1}http://sources.debian.net/src/linux/3.2.54-2/fs/cifs/file.c#L2204
[2]http://sources.debian.net/src/linux/3.2.54-2/fs/cifs/file.c#L2219

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/caa7hugf1seh1u6sbyouz+lngdaf2d+qhzpg+8vzxdawlxyf...@mail.gmail.com



Bug#741958: linux: CVE-2014-0069: cifs: incorrect handling of bogus user pointers during uncached writes

2014-03-17 Thread Raphael Geissert
Source: linux
Version: 3.2.51-1
Tags: patch security
X-debbugs-cc: j...@debian.org

Hi,

Attached patch is what I believe would be the correct backport for 3.2
of the specific fix for CVE-2014-0069, which is
5d81de8e8667da7135d3a32a964087c0faf5483f.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net
From: Jeff Layton jlay...@redhat.com
Date: Fri, 14 Feb 2014 07:20:35 -0500
Subject: [PATCH 2/3] cifs: ensure that uncached writes handle unmapped areas
 correctly

It's possible for userland to pass down an iovec via writev() that has a
bogus user pointer in it. If that happens and we're doing an uncached
write, then we can end up getting less bytes than we expect from the
call to iov_iter_copy_from_user. This is CVE-2014-0069

cifs_iovec_write isn't set up to handle that situation however. It'll
blindly keep chugging through the page array and not filling those pages
with anything useful. Worse yet, we'll later end up with a negative
number in wdata-tailsz, which will confuse the sending routines and
cause an oops at the very least.

Fix this by having the copy phase of cifs_iovec_write stop copying data
in this situation and send the last write as a short one. At the same
time, we want to avoid sending a zero-length write to the server, so
break out of the loop and set rc to -EFAULT if that happens. This also
allows us to handle the case where no address in the iovec is valid.

[Note: Marking this for stable on v3.4+ kernels, but kernels as old as
   v2.6.38 may have a similar problem and may need similar fix]

Cc: sta...@vger.kernel.org # v3.4+
Reviewed-by: Pavel Shilovsky pias...@etersoft.ru
Reported-by: Al Viro v...@zeniv.linux.org.uk
Signed-off-by: Jeff Layton jlay...@redhat.com
Signed-off-by: Steve French smfre...@gmail.com

[geissert: backport to 3.2.51]

---
 fs/cifs/file.c | 34 +++---
 1 file changed, 31 insertions(+), 3 deletions(-)

diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index c55808e..fd07d24 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -2107,7 +2107,7 @@ cifs_iovec_write(struct file *file, const struct iovec *iov,
 {
 	unsigned int written;
 	unsigned long num_pages, npages, i;
-	size_t copied, len, cur_len;
+	size_t bytes, copied, len, cur_len;
 	ssize_t total_written = 0;
 	struct kvec *to_send;
 	struct page **pages;
@@ -2165,17 +2165,45 @@ cifs_iovec_write(struct file *file, const struct iovec *iov,
 	do {
 		size_t save_len = cur_len;
 		for (i = 0; i  npages; i++) {
-			copied = min_t(const size_t, cur_len, PAGE_CACHE_SIZE);
+			bytes = min_t(const size_t, cur_len, PAGE_CACHE_SIZE);
 			copied = iov_iter_copy_from_user(pages[i], it, 0,
-			 copied);
+			 bytes);
 			cur_len -= copied;
 			iov_iter_advance(it, copied);
 			to_send[i+1].iov_base = kmap(pages[i]);
 			to_send[i+1].iov_len = copied;
+			/*
+			 * If we didn't copy as much as we expected, then that
+			 * may mean we trod into an unmapped area. Stop copying
+			 * at that point. On the next pass through the big
+			 * loop, we'll likely end up getting a zero-length
+			 * write and bailing out of it.
+			 */
+			if (copied  bytes)
+break;
 		}
 
+		/*
+		 * i + 1 now represents the number of pages we actually used in
+		 * the copy phase above. Bring npages down to that.
+		 */
+		for ( ; npages  i + 1; npages--) ;
+
 		cur_len = save_len - cur_len;
 
+		/*
+		 * If we have no data to send, then that probably means that
+		 * the copy above failed altogether. That's most likely because
+		 * the address in the iovec was bogus. Set the rc to -EFAULT,
+		 * and bail out.
+		 */
+		if (!cur_len) {
+			for (i = 0; i  npages; i++)
+kunmap(pages[i]);
+			total_written = -EFAULT;
+			break;
+		}
+
 		do {
 			if (open_file-invalidHandle) {
 rc = cifs_reopen_file(open_file, false);


Bug#593183: broken rt2860 support after upgrade to 2.6.32-18 from -16

2013-07-18 Thread Raphael Geissert
On Thursday 18 July 2013 20:28:20 Jonathan Nieder wrote:
 Wheezy uses a different driver (rt2800pci instead of rt2860sta).
 Raphael wrote Indeed, the rt2800 driver works like a charm compared
 to the rt2860sta (2012-01-19).  I consider that good enough. ;-)

Ack., and apologies for not testing after all this time.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/201307182336.39318.geiss...@debian.org



Bug#690721: linux-kbuild-3.2: bashism in /bin/sh script

2012-10-16 Thread Raphael Geissert
Package: linux-kbuild-3.2
Version: 3.2.17-1
Severity: important
User: debian-rele...@lists.debian.org
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' 
package) check I've found your package containing a /bin/sh script making 
use of a bashism.

checkbashisms' output:
possible bashism in ./usr/lib/linux-kbuild-3.2/scripts/setlocalversion line 
90 (should be 'b = a'):
if [ `hg log -r . --template '{latesttagdistance}'` ==
1 ]; then

Not using bash (or a Debian Policy conformant shell interpreter which 
doesn't provide such an extra feature) as /bin/sh is likely to lead to 
errors or unexpected behaviours.

You can find hints about how to fix bashisms at:
https://wiki.ubuntu.com/DashAsBinSh

Thank you,
Raphael Geissert


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/201210161311.15861.atom...@gmail.com



Bug#593183: broken rt2860 support after upgrade to 2.6.32-18 from -16

2012-01-18 Thread Raphael Geissert
Hi Jonathan,

On 27 November 2011 01:09, Jonathan Nieder jrnie...@gmail.com wrote:
 Raphael Geissert wrote:
 I just tried with a visible AP (using the same crypto settings) and it works.
 So, the changes to the module appear to only break support for hidden APs.

 Thanks for finding this.  As Ben mentioned, Realtek's original
 rt2860sta driver was abandoned in favor of rt2800pci from the rt2x00
 project[*] (the usual risk of using a staging driver).

Indeed, the rt2800 driver works like a charm compared to the rt2860sta :)

 However, many people still use squeeze.  So I would be happy to see
 the regression you discovered fixed.  Some questions in that vein:

  1. Just to check, can you still reproduce the trouble with the
    latest squeeze kernel?

  2. Can you bisect?  The squeeze kernel is on the squeeze branch
    of git://git.debian.org/kernel/linux-2.6.git; the usual
    make silentoldconfig; make; fakeroot -u make deb-pkg should work
    to build each revision one wants to test.

I currently don't have enough disk space to accommodate such a setup,
but will at least try with a live image or something similar.
Back when I was affected I remember checking the different changes
made to the driver, but they were all made in one big patchset that
was added in a single commit, IIRC.

HTH. I will anyway try to free up some space.

Cheers, and thanks for picking up such an old bug :)
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net



--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/caa7hugectftqpwcmr9amxh2wphznsbsd4vwuuq+tdjggtjz...@mail.gmail.com



Bug#593183: broken rt2860 support after upgrade to 2.6.32-18 from -16

2010-09-27 Thread Raphael Geissert
On Sunday 05 September 2010 10:09:30 Raphael Geissert wrote:
 On Sunday 05 September 2010 05:53:03 Ben Hutchings wrote:
  AFAIK rt2860sta has never worked with hidden APs.
 
 It has and it does with wpasupplicant, until I upgrade to src:2.6.32-18 or
 greater. I can try to test with one that isn't, and see if it makes any
 difference with the newer kernels.

I just tried with a visible AP (using the same crypto settings) and it works.
So, the changes to the module appear to only break support for hidden APs.

Has this been forwarded to upstream?

-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/201009271418.06283.geiss...@debian.org



Bug#593183: broken rt2860 support after upgrade to 2.6.32-18 from -16

2010-09-05 Thread Raphael Geissert
On Sunday 05 September 2010 05:53:03 Ben Hutchings wrote:
 On Sat, 2010-09-04 at 22:49 -0500, Raphael Geissert wrote:
  Hi,
  
  I've no longer had any problem with 2.6.32-5-686 and WEP-protected and
  similar APs. The only AP I'm still unable to connect to with -5 is a
  hidden WPA2-PSK-CCMP AP.
  I tried to take a look at the changes made in src:2.6.32-18 but the
  patch is too intrusive.
 
 AFAIK rt2860sta has never worked with hidden APs.

It has and it does with wpasupplicant, until I upgrade to src:2.6.32-18 or 
greater. I can try to test with one that isn't, and see if it makes any 
difference with the newer kernels.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/201009051009.31132.geiss...@debian.org



Bug#593183: broken rt2860 support after upgrade to 2.6.32-18 from -16

2010-09-04 Thread Raphael Geissert
Hi,

I've no longer had any problem with 2.6.32-5-686 and WEP-protected and
similar APs. The only AP I'm still unable to connect to with -5 is a
hidden WPA2-PSK-CCMP AP.
I tried to take a look at the changes made in src:2.6.32-18 but the
patch is too intrusive.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/aanlktinpacrez1bp_wof7lwr8jkuqeetba=v1njvd...@mail.gmail.com



Bug#593183: broken rt2860 support after upgrade to 2.6.32-18 from -16

2010-08-15 Thread Raphael Geissert
Package: linux-2.6
Version: 2.6.32-18
Severity: important

Hi,

Upgrading to 2.6.32-18 more or less breaks support for the RaLink
RT2860: wpasupplicant no longer works very well, I've seen it 
not even try to associate to encryption-less APs, not displaying the
list of really available APs (especially name-less,) etc.

Downgrading to linux-image-2.6.32-4-686 (2.6.32-11) makes it work just
fine.

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'stable'), (200, 'unstable'), (1, 
'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-4-686 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20100816031705.4546.50042.report...@eee.home



Bug#563356: linux-2.6: FTBFS in ia64: source_ia64_vserver/mm/memory.c:2995: error: implicit declaration of function 'vx_page_fault'

2010-01-02 Thread Raphael Geissert
Source: linux-2.6
Version: 2.6.32-3
Severity: grave

Hi,

Your package failed to build in ia64 with the following error:
 /build/buildd/linux-2.6-2.6.32/debian/build/source_ia64_vserver/mm/memory.c
: In function 'copy_pte_range':
 /build/buildd/linux-2.6-2.6.32/debian/build/source_ia64_vserver/mm/memory.c
:651: error: implicit declaration of function 'vx_rss_avail'
 /build/buildd/linux-2.6-2.6.32/debian/build/source_ia64_vserver/mm/memory.c
: In function 'insert_page':
 /build/buildd/linux-2.6-2.6.32/debian/build/source_ia64_vserver/mm/memory.c
:1519: error: implicit declaration of function 'vx_file_rsspages_inc'
 /build/buildd/linux-2.6-2.6.32/debian/build/source_ia64_vserver/mm/memory.c
: In function 'do_wp_page':
 /build/buildd/linux-2.6-2.6.32/debian/build/source_ia64_vserver/mm/memory.c
:2155: error: implicit declaration of function 'vx_file_rsspages_dec'
 /build/buildd/linux-2.6-2.6.32/debian/build/source_ia64_vserver/mm/memory.c
:2156: error: implicit declaration of function 'vx_anon_rsspages_inc'
 /build/buildd/linux-2.6-2.6.32/debian/build/source_ia64_vserver/mm/memory.c
: In function 'handle_pte_fault':
 /build/buildd/linux-2.6-2.6.32/debian/build/source_ia64_vserver/mm/memory.c
:2945: error: 'VXPT_UNKNOWN' undeclared (first use in this function)
 /build/buildd/linux-2.6-2.6.32/debian/build/source_ia64_vserver/mm/memory.c
:2945: error: (Each undeclared identifier is reported only once
 /build/buildd/linux-2.6-2.6.32/debian/build/source_ia64_vserver/mm/memory.c
:2945: error: for each function it appears in.)
 /build/buildd/linux-2.6-2.6.32/debian/build/source_ia64_vserver/mm/memory.c
:2973: error: 'VXPT_WRITE' undeclared (first use in this function)
 /build/buildd/linux-2.6-2.6.32/debian/build/source_ia64_vserver/mm/memory.c
:2995: error: implicit declaration of function 'vx_page_fault' make[6]: ***
 [mm/memory.o] Error 1


-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#563355: linux-2.6: FTBFS in s390: source_s390_vserver/kernel/vserver/proc.c:70: error: '__NR_vserver' undeclared

2010-01-02 Thread Raphael Geissert
Source: linux-2.6
Version: 2.6.32-3
Severity: grave

Hi,

Your package failed to build in s390 with the following error:
   CC  kernel/vserver/proc.o
 /build/buildd-linux-2.6_2.6.32-3-s390-7O5pHW/linux-2.6-2.6.32/debian/build/
source_s390_vserver/kernel/vserver/proc.c: In function 'proc_vci':
 /build/buildd-linux-2.6_2.6.32-3-s390-7O5pHW/linux-2.6-2.6.32/debian/build/
source_s390_vserver/kernel/vserver/proc.c:70: error: '__NR_vserver'
 undeclared (first use in this function)
 /build/buildd-linux-2.6_2.6.32-3-s390-7O5pHW/linux-2.6-2.6.32/debian/build/
source_s390_vserver/kernel/vserver/proc.c:70: error: (Each undeclared
 identifier is reported only once
 /build/buildd-linux-2.6_2.6.32-3-s390-7O5pHW/linux-2.6-2.6.32/debian/build/
source_s390_vserver/kernel/vserver/proc.c:70: error: for each function it
 appears in.)
 make[7]: *** [kernel/vserver/proc.o] Error 1 

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#530125: linux-kbuild-2.6.29: bashism in /bin/sh script

2009-05-23 Thread Raphael Geissert
Package: linux-kbuild-2.6.29
Severity: important
Version: 2.6.29-1
User: debian-rele...@lists.debian.org
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package)
check I've found your package containing a /bin/sh script making use
of a bashism.

checkbashisms' output:
 possible bashism in ./usr/src/linux-kbuild-2.6.29/scripts/gcc-version.sh
 line 21 (echo -e):
 echo -e Usage:\n\t$0 gcc-command
 possible bashism in ./usr/src/linux-kbuild-2.6.29/scripts/ver_linux line 68
 (brace expansion):
 ls -l /usr/lib/lib{g,stdc}++.so  2/dev/null | awk -F. \


Not using bash (or a Debian Policy conformant shell interpreter which doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours.
Please be aware that although bash is currently the default /bin/sh there was
a release goal for Lenny to make dash the default /bin/sh[1], and has been
proposed for squeeze as well[2].

If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html

For more information supporting this goal please refer to Debian Policy,
section 10.4, at:
http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

Hints about how to fix bashisms:
Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
If not already fixed you can read:
https://wiki.ubuntu.com/DashAsBinSh

If you still don't know how to fix the bashisms don't hesitate to reply to
this email, or tag the bug as 'help'.

[1]http://release.debian.org/lenny/goals.txt
[2]http://lists.debian.org/debian-release/2009/04/msg00133.html

Thank you,
Raphael Geissert



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#486033: gfs-tools: bashism in /bin/sh script

2008-06-12 Thread Raphael Geissert
Package: gfs-tools
Severity: important
Version: 2.20080603-1
User: [EMAIL PROTECTED]
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package) 
check I've found your package containing one or more /bin/sh scripts making 
use of bashisms.

checkbashisms' output:
 possible bashism in ./etc/init.d/gfs-tools line 89 ($foo should be eval
 gettext foo): 
 echo $Usage: $0 {start|stop|restart|reload|force-reload|status}

Not using bash (or a Debian Policy conformant shell interpreter which does 
provide such an extra feature) as /bin/sh is likely to lead to errors or 
unexpected behaviours.
Please be aware that although bash is currently the default /bin/sh there's a 
release goal for Lenny to make dash the default /bin/sh[1].

If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html

For more information please refer to the Debian Policy section 10.4 supporting 
this argument at:
http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

Hints about how to fix bashisms:
Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
If not already fixed you can read:
https://wiki.ubuntu.com/DashAsBinSh

[1]http://release.debian.org/lenny/goals.txt

Thank you,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#486032: gfs2-tools: bashism in /bin/sh script

2008-06-12 Thread Raphael Geissert
Package: gfs2-tools
Severity: important
Version: 2.20080603-1
User: [EMAIL PROTECTED]
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package) 
check I've found your package containing one or more /bin/sh scripts making 
use of bashisms.

checkbashisms' output:
 possible bashism in ./etc/init.d/gfs2-tools line 89 ($foo should be eval
 gettext foo): 
 echo $Usage: $0 {start|stop|restart|reload|force-reload|status}

Not using bash (or a Debian Policy conformant shell interpreter which does 
provide such an extra feature) as /bin/sh is likely to lead to errors or 
unexpected behaviours.
Please be aware that although bash is currently the default /bin/sh there's a 
release goal for Lenny to make dash the default /bin/sh[1].

If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html

For more information please refer to the Debian Policy section 10.4 supporting 
this argument at:
http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

Hints about how to fix bashisms:
Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
If not already fixed you can read:
https://wiki.ubuntu.com/DashAsBinSh

[1]http://release.debian.org/lenny/goals.txt

Thank you,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#464634: cman: bashism in /bin/sh script

2008-02-07 Thread Raphael Geissert
Package: cman
Severity: important
Version: 2.20080205-1
User: [EMAIL PROTECTED]
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package) 
check I've found your package containing a /bin/sh script making 
use of a bashism.

checkbashisms' output:
 possible bashism in ./etc/init.d/cman line 128 (should be word 21):
 if pidof fence_tool  /dev/null; then


Not using bash as /bin/sh would lead to errors. Please be aware that although 
bash is currently the default /bin/sh there's a release goal for Lenny to 
make dash the default /bin/sh[1].

If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html
https://wiki.ubuntu.com/DashAsBinSh

[1]http://release.debian.org/lenny/goals.txt

Thank you,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]