Bug#924449: lintian: Periodic "out of disk space" errors from lindsay.d.o

[Adam D. Barratt]

On 2019-03-13 06:40, Niels Thykier wrote:

Package: lintian
Version: 2.10.0
Severity: important

We seem to be getting regular "out of disk space" errors on
lindsay.d.o after resuming the archive-wide processing.

[...]

AFAICT, lintian correctly cleans up old packages during the run.
I.e. we are not accumulating disk usage from previous packages in the
run.

For reference, we currently have 32GB disk available for lintian ("all
inclusive").  About 23GB of that is available for checking with our
current usage for reports and stats.


For the record, lintian.d.o filled all the available space on lindsay's 
/srv again in the past day or so.


I killed a running check for insighttoolkit4, but there was still 23GB 
in scratch/tmp-lintian-lab*, in several folders dating back to the 28th 
of this month. I've removed a few of the older ones and checks were 
progressing again, but it seems like there are still some issues here.


Regards,

Adam

Bug#945544: lintian: Field too long doesn't report anything on the website

[Adam D. Barratt]

On 2019-11-26 18:26, Sylvestre Ledru wrote:

I don't have access to the server to debug?!


For the record, all DDs can log in to lindsay.d.o, which is where 
Lintian processing runs happen.


Regards,

Adam

Bug#944258: lintian 2.32.0~bpo9+1 in stretch-backports depends on coreutils (>= 8.30), but stretch has only 8.26-3

[Adam D. Barratt]

On Thu, 2019-11-07 at 10:49 -0800, Felix Lechner wrote:
> Also, as a side note, would someone please explain why someone still
> on stretch would need lintian? I am personally on stable, but most
> package maintainers out there seem to track testing or the bleeding
> edge, unstable.

Well, at least some debian.org infrastructure, including the ftp-master 
host, are still running stretch, for a starting point.

Regards,

Adam

Bug#570998: lintian: Please check that commands in /{usr/,}sbin do not use section 1 manpages

[Adam D. Barratt]

On 2019-07-18 05:07, Vincent Bernat wrote:

❦ 17 juillet 2019 23:04 -03, "Chris Lamb" :


 - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=348864
 - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=253011

There is no consensus.


Dmitry (added to CC), as you were the one championing this change, can
you please comment on the above? Perhaps particulary respect to
whether the severity should be reduced.


Hi Chris!

Are you sure? This is not about the alternative init but about manual
page section. It doesn't seem Dmitry is involved at all.


Apparently people can be interested in more than one thing. :-p

See the MR submitter on 
https://salsa.debian.org/lintian/lintian/commit/9f5271bfde40c23f1f7359913d8ec395998c8e48


Regards,

Adam

lintian.d.o issues

[Adam D. Barratt]

Hi,

As I mentioned on #debian-qa, I made a few changes on lindsay (the
machine on which the archive-wide Lintian runs happen), after it was
pointed out that it hadn't updated for a while - since late April, in
fact.

The specific issue there turned out to be a missing import when
Lintian::Reporting::Utils was split out. I've fixed that by adding the
missing statement, but wasn't sure how such local patches are usually
handled for lintian.d.o, so the change has currently just been made
directly to the file in the working copy.

The website seems to be updating happily now, but each run is
generating a mail indicating:

"
Warning: unable to close filehandle properly: No space left on device
during global destruction.
"

While at it, I fixed up the crontab to stop referring to liliburn (the
one-time lintian.d.o host), and to make the arguments to mail(1)
suitable for the installed package - presumably these changed at some
point. There didn't seem to be a controlled copy of the crontab other
than the file in /srv/lintian.d.o, but apologies if I missed something.

As a more general issue, while an error early in the reporting/harness
process does generate a log issue, there's no visible output and thus
no mail generated to inform us of the issue.

Regards,

Adam

Bug#913099: Possible triage

[Adam D. Barratt]

On Tue, 2018-11-06 at 14:49 -0800, Felix Lechner wrote:
> Thank you for identifying the offending commit. The error you are
> seeing could be caused by the second assignment in:

By default, nnn...@bugs.debian.org does not get sent to the submitter -
you'll need to CC them explicitly.

Regards,

Adam

Bug#909319: Show unnecessary overrides

[Adam D. Barratt]

On Fri, 2018-09-21 at 11:58 -0700, Josh Triplett wrote:
> On Fri, Sep 21, 2018 at 07:44:05PM +0100, Adam D. Barratt wrote:
> > On Fri, 2018-09-21 at 11:40 -0700, Josh Triplett wrote:
> > > It no longer triggers that tag as of lintian 2.5.104, which
> > > allows
> > > metapackages to depend on toolchain packages.
> > 
> > Right, sorry, I missed that the stretch-backports package is
> > lagging a
> > little.
> > 
> > However, running from a current lintian git checkout gives:
> > 
> > adam@jacala:~/code/debian/lintian$ ./frontend/lintian -I -E --
> > pedantic --show-overrides ../../josh-meta/target/josh-
> > dev_77_all.deb 
> > P: josh-dev: copyright-refers-to-symlink-license usr/share/common-
> > licenses/GPL
> > I: josh-dev: unused-override binary-package-depends-on-toolchain-
> > package
> > 
> > which looks like exactly what was expected?
> 
> ...argh. unused-override is *info*-level?
> 
> That explains why I didn't see it by default, but is there any
> particular reason for that?

It's been that way since at least lintian 1.23 (April 2004) according
to git, so I imagine no-one remembers specifically why.

Regards,

Adam

Bug#909319: Show unnecessary overrides

[Adam D. Barratt]

On Fri, 2018-09-21 at 11:40 -0700, Josh Triplett wrote:
> It no longer triggers that tag as of lintian 2.5.104, which allows
> metapackages to depend on toolchain packages.

Right, sorry, I missed that the stretch-backports package is lagging a
little.

However, running from a current lintian git checkout gives:

adam@jacala:~/code/debian/lintian$ ./frontend/lintian -I -E --pedantic 
--show-overrides ../../josh-meta/target/josh-dev_77_all.deb 
P: josh-dev: copyright-refers-to-symlink-license usr/share/common-licenses/GPL
I: josh-dev: unused-override binary-package-depends-on-toolchain-package

which looks like exactly what was expected?

Regards,

Adam

Bug#906597: lintian: false positive unknown-runtime-tests-restriction allow-stderr

[Adam D. Barratt]

Control: forcemerge 905843 -1

On Sat, 2018-08-18 at 17:30 +0200, Xavier Guimard wrote:
> Package: lintian
> Version: 2.5.96
> Severity: normal
> 
> Hi all,
> 
> in debian/tests/control, "allow-stderr" can be used in "Restrictions"
> (see /usr/share/doc/autopkgtest/README.package-tests.html), but
> Lintian
> reports:
> 
>    source: unknown-runtime-tests-restriction allow-stderr
> paragraph starting at line 1

This was fixed in 2.5.97, uploaded this morning.

Regards,

Adam

Bug#902797: lintian: check latest changelog entry for duplicate contributor information

[Adam D. Barratt]

On Sun, 2018-07-01 at 11:37 +0200, Mattia Rizzolo wrote:
> On Sun, Jul 01, 2018 at 12:39:47PM +0800, Paul Wise wrote:
> > I recently saw a changelog entry (quoted below) for a Perl team
> > package
> > where several contributors to that version had their names
> > mentioned
> > multiple times with one or more changes below each instance of
> > their
> > name. This made the changelog harder to read. I think it would be
> > useful for lintian to emit a pedantic or info-level warning for
> > duplicate contributor information in the latest changelog entry.
> 
> I personally agree with you here, but apparently not everybody does.
> ISTR to remember in the past suggesting to change the default of dch
> --multimaint-merge but somebody complained that that way it would
> lose the chronological order of the changes or something like that (I
> don't really buy it).
> 

When I initially added the merging functionality, I made it the
default. Joey Hess objected, and said that he'd intentionally
implemented the "strictly chronological" ordering, so it was made a
non-default option.

Regards,

Adam

Bug#897157: lintian: Allow /usr/share/doc/$pkg/examples to be a symlink

[Adam D. Barratt]

On 2018-05-01 10:49, Rafael Laboissière wrote:

* Chris Lamb  [2018-04-29 19:07]:


tags 897157 + moreinfo thanks

Hi Rafael,

There are legitimate cases where /usr/share/doc/$pkg/examples is a 
symlink instead of a directory.


That should be fine already. Indeed, I just added such a test for 
symlinks and it passes without any code changes:


 
https://salsa.debian.org/lintian/lintian/commit/1b148029d55c3091bd3751cc5f9a674ae901


(It also does not trigger on, for example src:zsh.)


Thanks for the fix.

Why is this bug report tagged "moreinfo"?


Because the above commit isn't a "fix" for anything - it's a testcase to 
prove that the existing code already does what you requested, with no 
changes.


The "moreinfo" tag will therefore be requesting more details about your 
failing case - most likely access to copies of the affected .deb files - 
in order to see why it appears not to be working for you.


Regards,

Adam

[lintian] 01/01: Refresh fonts data

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a commit to branch master
in repository lintian.

commit ac61a49802d572ae10ebcb2aea9dc196bd037c7d
Author: Adam D. Barratt <a...@adam-barratt.org.uk>
Date:   Sat Jan 13 22:20:10 2018 +

Refresh fonts data

Signed-off-by: Adam D. Barratt <a...@adam-barratt.org.uk>
---
 data/files/fonts | 695 ---
 debian/changelog |   2 +
 2 files changed, 506 insertions(+), 191 deletions(-)

diff --git a/data/files/fonts b/data/files/fonts
index fbd28d6..e8a8ae6 100644
--- a/data/files/fonts
+++ b/data/files/fonts
@@ -2,7 +2,7 @@
 # package that contains the font.  Only packages starting with ttf-,
 # otf-, t1-, xfonts- and fonts- are searched for fonts.
 #
-# Last updated: 2016-07-31
+# Last updated: 2018-01-13
 
 1015sn.ttf ttf-aenigma
 1015snr.ttf ttf-aenigma
@@ -40,19 +40,21 @@ aboriginalserifbold943.ttf fonts-lg-aboriginal
 aboriginalserifbolditalic943.ttf fonts-lg-aboriginal
 aboriginalserifitalic943.ttf fonts-lg-aboriginal
 aboriginalserifregular943.ttf fonts-lg-aboriginal
+abydosb_hint.ttf fonts-ancient-scripts
+abydosr_hint.ttf fonts-ancient-scripts
 abyssinicasil-r.ttf fonts-sil-abyssinica
-accanthisadfstd-bold.otf ttf-adf-accanthis
-accanthisadfstd-bolditalic.otf ttf-adf-accanthis
-accanthisadfstd-italic.otf ttf-adf-accanthis
-accanthisadfstd-regular.otf ttf-adf-accanthis
-accanthisadfstdno2-bold.otf ttf-adf-accanthis
-accanthisadfstdno2-bolditalic.otf ttf-adf-accanthis
-accanthisadfstdno2-italic.otf ttf-adf-accanthis
-accanthisadfstdno2-regular.otf ttf-adf-accanthis
-accanthisadfstdno3-bold.otf ttf-adf-accanthis
-accanthisadfstdno3-bolditalic.otf ttf-adf-accanthis
-accanthisadfstdno3-italic.otf ttf-adf-accanthis
-accanthisadfstdno3-regular.otf ttf-adf-accanthis
+accanthisadfstd-bold.otf fonts-adf-accanthis
+accanthisadfstd-bolditalic.otf fonts-adf-accanthis
+accanthisadfstd-italic.otf fonts-adf-accanthis
+accanthisadfstd-regular.otf fonts-adf-accanthis
+accanthisadfstdno2-bold.otf fonts-adf-accanthis
+accanthisadfstdno2-bolditalic.otf fonts-adf-accanthis
+accanthisadfstdno2-italic.otf fonts-adf-accanthis
+accanthisadfstdno2-regular.otf fonts-adf-accanthis
+accanthisadfstdno3-bold.otf fonts-adf-accanthis
+accanthisadfstdno3-bolditalic.otf fonts-adf-accanthis
+accanthisadfstdno3-italic.otf fonts-adf-accanthis
+accanthisadfstdno3-regular.otf fonts-adf-accanthis
 acidrefl.ttf ttf-aenigma
 acknowtt.ttf ttf-aenigma
 ae_alarabiya.ttf fonts-arabeyes
@@ -118,9 +120,12 @@ amalgama.ttf ttf-aenigma
 amalgamo.ttf ttf-aenigma
 amiri-bold.ttf fonts-hosny-amiri
 amiri-boldslanted.ttf fonts-hosny-amiri
+amiri-quran-colored.ttf fonts-hosny-amiri
 amiri-quran.ttf fonts-hosny-amiri
 amiri-regular.ttf fonts-hosny-amiri
 amiri-slanted.ttf fonts-hosny-amiri
+amit.otf fonts-ldco
+amit.ttf fonts-ldco
 amplitud.ttf ttf-aenigma
 anaktoria_hint.ttf fonts-ancient-scripts
 analecta_hint.ttf fonts-ancient-scripts
@@ -132,11 +137,11 @@ andikanewbasic-bi.ttf fonts-sil-andikanewbasic
 andikanewbasic-i.ttf fonts-sil-andikanewbasic
 andikanewbasic-r.ttf fonts-sil-andikanewbasic
 ani.ttf fonts-beng-extra
-anjalioldlipi.ttf fonts-smc
-annapurnasil-b.ttf fonts-sil-annapurna
-annapurnasil-r.ttf fonts-sil-annapurna
+anjalioldlipi.ttf fonts-smc-anjalioldlipi
+annapurnasil-bold.ttf fonts-sil-annapurna
+annapurnasil-regular.ttf fonts-sil-annapurna
 aoyagi-soseki.ttf fonts-aoyagi-soseki
-aoyagikouzanfontt.ttf fonts-aoyagi-kouzan-t
+aoyagikouzant.ttf fonts-aoyagi-kouzan-t
 apibold.ttf fonts-linex
 apibolit.ttf fonts-linex
 apiitali.ttf fonts-linex
@@ -164,19 +169,12 @@ aseaj_hint.ttf fonts-ancient-scripts
 asear_hint.ttf fonts-ancient-scripts
 aspartam.ttf ttf-aenigma
 assyrian_hint.ttf fonts-ancient-scripts
-atarismall.ttf ttf-atarismall
-atarismallbold.ttf ttf-atarismall
-atarismallcondensed.ttf ttf-atarismall
-atarismallitalic.ttf ttf-atarismall
-atarismalllight.ttf ttf-atarismall
+atarismall.ttf fonts-atarismall
 atavyros.otf fonts-ancient-scripts
 ataxia.ttf ttf-aenigma
 ataxiao.ttf ttf-aenigma
 automati.ttf ttf-aenigma
-avdira_b.otf fonts-ancient-scripts
-avdira_i.otf fonts-ancient-scripts
-avdira_j.otf fonts-ancient-scripts
-avdira_r.otf fonts-ancient-scripts
+avdira_hint.ttf fonts-ancient-scripts
 averiagwf-bold.ttf fonts-averia-gwf
 averiagwf-bolditalic.ttf fonts-averia-gwf
 averiagwf-gruesa.ttf fonts-averia-gwf
@@ -216,13 +214,21 @@ bandless.ttf ttf-aenigma
 bandmess.ttf ttf-aenigma
 bandwdth.ttf ttf-aenigma
 bangwool.ttf fonts-alee
-baskervaldadfstd-bold.otf ttf-adf-baskervald
-baskervaldadfstd-bolditalic.otf ttf-adf-baskervald
-baskervaldadfstd-italic.otf ttf-adf-baskervald
+baskervaldadfstd-bold.otf fonts-adf-baskervald
+baskervaldadfstd-bolditalic.otf fonts-adf-baskervald
+baskervaldadfstd-heavy.otf fonts-adf-baskervald
+baskervaldadfstd-heavyitalic.otf fonts-adf-baskervald
+baskervaldadfstd-italic.otf fonts-adf-baskervald
 baskervaldadfstd-regular.otf ttf-adf-baskervald
+baskervaldadfs

[lintian] branch master updated (10efc0e -> ac61a49)

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a change to branch master
in repository lintian.

  from  10efc0e   Refresh data/debhelper/*
   new  ac61a49   Refresh fonts data

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 data/files/fonts | 695 ---
 debian/changelog |   2 +
 2 files changed, 506 insertions(+), 191 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#885106: lintian: Please update dh_commands for scour 0.36

[Adam D. Barratt]

Control: tags -1 + pending

On Sat, 2018-01-13 at 21:47 +0100, Jörg Frings-Fürst wrote:
> reopen 885106
> found 885106 2.5.68
> thanks
> 
> Hello,
> 
> with lintian 2.5.68 I get the same error:
> 
> "simple-scan source: missing-build-dependency-for-dh-addon scour =>
> python-scour"
> 
> So I reopen this bug

The previous change dealt with explicit calls to dh_scour, but not its
use as an addon.

I've run lintian's script to update the debhelper data, which has
updated the addon mapping for scour amongst a bunch of other changes.

Regards,

Adam

[lintian] 01/01: Refresh data/debhelper/*

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a commit to branch master
in repository lintian.

commit 10efc0e5ca5cf40086c5e67fe0f752c2de3ab69e
Author: Adam D. Barratt <a...@adam-barratt.org.uk>
Date:   Sat Jan 13 22:01:59 2018 +

Refresh data/debhelper/*

Signed-off-by: Adam D. Barratt <a...@adam-barratt.org.uk>
---
 data/debhelper/dh_addons| 14 +++---
 data/debhelper/dh_commands  | 24 +---
 data/debhelper/dh_packages  | 13 +
 data/debhelper/maint_commands   |  4 +++-
 data/debhelper/miscDepends_commands |  5 +++--
 debian/changelog|  2 ++
 6 files changed, 45 insertions(+), 17 deletions(-)

diff --git a/data/debhelper/dh_addons b/data/debhelper/dh_addons
index c360418..f72774f 100644
--- a/data/debhelper/dh_addons
+++ b/data/debhelper/dh_addons
@@ -1,5 +1,5 @@
 # This file is generated from private/refresh-debhelper-data.
-# It was generated on 2016-07-31 15:44
+# It was generated on 2018-01-13 21:51
 #
 # If the script generates an insufficient/incorrect value for a
 # single item, please have a look at dh_addons-manual.
@@ -13,6 +13,7 @@ aspell_simple=dictionaries-common-dev
 autoreconf=dh-autoreconf
 autotools_dev=autotools-dev
 bash_completion=bash-completion
+build_stamp=debhelper
 buildinfo=dh-buildinfo
 cli=cli-common-dev
 cli_nant=cli-common-dev
@@ -23,6 +24,7 @@ d_i=dh-di
 dist_zilla=dh-dist-zilla
 dkms=dkms
 dpatch=dpatch
+dwz=debhelper
 eclipse_helper=javahelper
 elpa=dh-elpa
 germinate=germinate
@@ -34,6 +36,7 @@ javahelper=javahelper
 jh_maven_repo_helper=maven-repo-helper
 kde=pkg-kde-tools
 kf5=pkg-kde-tools
+kodiaddon=kodi-addons-dev
 libva=libva-dev
 linktree=dh-linktree
 lisp=dh-lisp
@@ -41,9 +44,9 @@ lua=dh-lua
 maven_repo_helper=maven-repo-helper
 nodejs=nodejs-dev
 ocaml=dh-ocaml
-parrot=parrot-devel
 perl_dbi=libdbi-perl
 perl_imager=libimager-perl
+perl_openssl=perl-openssl-defaults
 php=dh-php
 phpcomposer=pkg-php-tools
 phppear=pkg-php-tools
@@ -56,18 +59,23 @@ python2=python
 python3=dh-python
 python_support=debhelper
 python_virtualenv=dh-virtualenv
+qmlcdeps=pkg-kde-tools
 quilt=quilt
 rebar=dh-rebar
 ruby=gem2deb
 runit=dh-runit
-scour=python-scour
+scour=python3-scour
 sodeps=pkg-kde-tools
 sphinxdoc=sphinx-common
 swi_prolog=swi-prolog-nox
 systemd=debhelper
+sysuser=dh-sysuser
 tex=tex-common
+uwsgi=uwsgi-dev
 vdrplugin=vdr-dev
+vignette=dh-r
 xine=libxine2-dev
+xml_core=xml-core
 xsf=xserver-xorg-dev
 xsp=dh-xsp
 xul_ext=mozilla-devscripts
diff --git a/data/debhelper/dh_commands b/data/debhelper/dh_commands
index 933eab1..344a583 100644
--- a/data/debhelper/dh_commands
+++ b/data/debhelper/dh_commands
@@ -1,5 +1,5 @@
 # This file is generated from private/refresh-debhelper-data.
-# It was generated on 2016-07-31 15:44
+# It was generated on 2018-01-13 21:51
 #
 # If the script generates an insufficient/incorrect value for a
 # single item, please have a look at dh_commands-manual.
@@ -44,6 +44,7 @@ dh_dkms=dkms
 dh_doxygen=doxygen
 dh_dpatch_patch=dpatch
 dh_dpatch_unpatch=dpatch
+dh_dwz=debhelper
 dh_dzil_build=dh-dist-zilla
 dh_dzil_clean=dh-dist-zilla
 dh_elpa=dh-elpa
@@ -58,13 +59,14 @@ dh_gnome=gnome-pkg-tools
 dh_gnome_clean=gnome-pkg-tools
 dh_gnustep=gnustep-make
 dh_golang=dh-golang
+dh_golang_autopkgtest=dh-golang
 dh_gstscancodecs=libgstreamer1.0-dev
 dh_gtkmodules=libgtk2.0-dev
-dh_haskell_blurbs=haskell-devscripts
-dh_haskell_depends=haskell-devscripts
-dh_haskell_extra_depends=haskell-devscripts
-dh_haskell_provides=haskell-devscripts
-dh_haskell_shlibdeps=haskell-devscripts
+dh_haskell_blurbs=haskell-devscripts-minimal
+dh_haskell_depends=haskell-devscripts-minimal
+dh_haskell_extra_depends=haskell-devscripts-minimal
+dh_haskell_provides=haskell-devscripts-minimal
+dh_haskell_shlibdeps=haskell-devscripts-minimal
 dh_icons=debhelper
 dh_install=debhelper
 dh_installcatalogs=debhelper
@@ -93,6 +95,7 @@ dh_installmime=debhelper
 dh_installmodules=debhelper
 dh_installpam=debhelper
 dh_installppp=debhelper
+dh_installsystemd=debhelper
 dh_installtex=tex-common
 dh_installudev=debhelper
 dh_installwm=debhelper
@@ -103,6 +106,7 @@ dh_installyorick=yorick-dev
 dh_installzope=zope-debhelper
 dh_installzopeinstance=zope-debhelper
 dh_javadoc=gcj-jdk
+dh_kodiaddon_depends=kodi-addons-dev
 dh_libva=libva-dev
 dh_link=debhelper
 dh_linktree=dh-linktree
@@ -111,11 +115,13 @@ dh_lisp=dh-lisp
 dh_listpackages=debhelper
 dh_lua=dh-lua
 dh_make=dh-make
+dh_make_pgxs=postgresql-server-dev-all
 dh_makeclilibs=cli-common-dev
 dh_makefont=dh-make
 dh_makeshlibs=debhelper
 dh_md5sums=debhelper
 dh_metainit=dh-metainit
+dh_missing=debhelper
 dh_movefiles=debhelper
 dh_movelibkdeinit=pkg-kde-tools
 dh_nativejava=libgcj-common
@@ -126,11 +132,11 @@ dh_ocaml=dh-ocaml
 dh_ocamlclean=dh-ocaml
 dh_ocamldoc=dh-ocaml
 dh_ocamlinit=dh-ocaml
-dh_parrot=parrot-devel
 dh_pdl=pdl
 dh_perl=debhelper
 dh_perl_dbi=libdbi-perl
 dh_perl_imag

[lintian] 02/02: triggers.desc: English review

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a commit to branch master
in repository lintian.

commit 630309bd16f0a9ea6ce1d1b1aa6b16fab0feaa70
Author: Adam D. Barratt <a...@adam-barratt.org.uk>
Date:   Mon Dec 25 18:24:06 2017 +0300

triggers.desc: English review
---
 checks/triggers.desc | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/checks/triggers.desc b/checks/triggers.desc
index fba8d56..c6c881a 100644
--- a/checks/triggers.desc
+++ b/checks/triggers.desc
@@ -10,10 +10,10 @@ Certainty: possible
 Info: The package has a trigger that Lintian does not recognise in its
  control file.
  .
- The package may be uninstallable  if dpkg does not support the trigger.
+ The package may be uninstallable, if dpkg does not support the trigger.
  .
  If this is a new type of trigger, then Lintian may simply be out of date.
- Please verify if the latest version of Lintian know of the trigger or file
+ Please verify if the latest version of Lintian knows of the trigger, or file
  a bug against Lintian.
 Ref: deb-triggers(5)
 
@@ -21,16 +21,16 @@ Tag: uses-implicit-await-trigger
 Severity: normal
 Certainty: possible
 Info: The listed trigger is present in the control file of the package.
- The trigger is an await trigger, which may be not obvious from its name.
+ The trigger is an await trigger, which may not be obvious from its name.
  .
- Await triggers puts rather strong requirements on dpkg that often lead
+ Await triggers place rather strong requirements on dpkg that often lead
  to trigger cycles due to changes in other packages.
  .
- If the package does not need the guarantees that dpkg provide to await
+ If the package does not need the guarantees that dpkg provides to await
  triggers, please use the "-noawait" variant of the trigger.  This is often
  the case for packages that use the trigger to compile a form of cache.
  .
- If the package do need the guarantees provided by dpkg, then please
+ If the package does need the guarantees provided by dpkg, then please
  document the rationale in a comment above the trigger and use the
  "-await" variant of the trigger to avoid this warning.
 Ref: deb-triggers(5), #774559
@@ -45,11 +45,11 @@ Info: The package repeats the same trigger.  There should 
be no reason to
  the last declaration will be the effective one.
  .
  This tag is also triggered if the package has an activate trigger
- for something it also declares an interest.  The only (but rather
- unlikely) reason to do this is if another package also has an
- also declares an interest and this package need to activate that
+ for something on which it also declares an interest.  The only (but
+ rather unlikely) reason to do this is if another package also
+ declares an interest and this package needs to activate that
  other package.  If the package is using it for this exact purpose, then
- please use a lintian override to state this.
+ please use a Lintian override to state this.
  .
  Please remove any duplicate definitions.
 Ref: deb-triggers(5), #698723

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (9d03be2 -> 630309b)

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a change to branch master
in repository lintian.

  from  9d03be2   collection/src-orig-index: Set blocking on the STDIN pipe 
to avoid trying to close it too early.
   new  2ae1d32   shared-libs.desc: fix subject number agreement
   new  630309b   triggers.desc: English review

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/shared-libs.desc |  2 +-
 checks/triggers.desc| 20 ++--
 2 files changed, 11 insertions(+), 11 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/02: shared-libs.desc: fix subject number agreement

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a commit to branch master
in repository lintian.

commit 2ae1d3205589799a69675864223f9ab75331933e
Author: Adam D. Barratt <a...@adam-barratt.org.uk>
Date:   Mon Dec 25 18:23:41 2017 +0300

shared-libs.desc: fix subject number agreement
---
 checks/shared-libs.desc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/checks/shared-libs.desc b/checks/shared-libs.desc
index 4d2c97f..64648bc 100644
--- a/checks/shared-libs.desc
+++ b/checks/shared-libs.desc
@@ -205,7 +205,7 @@ Info: The package activates the ldconfig trigger even 
though no shared
  library loader.
  .
  Note this may be triggered by a bug in debhelper, that causes it to
- auto-generate an ldconfig trigger for packages that does not need it.
+ auto-generate an ldconfig trigger for packages that do not need it.
 Ref: policy 8.1.1, #204975
 
 Tag: udeb-postinst-must-not-call-ldconfig

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Re: [lintian] 01/01: Apply patch from Ville Skyttä <ville.sky...@iki.fi> to fix a number of spelling mistakes. (Closes: #878446)

[Adam D. Barratt]

On Fri, 2017-10-13 at 20:47 +, Chris Lamb wrote:
> - An _Choices field must be translated as a single string.
> + A _Choices field must be translated as a single string.

I guess that depends on how one pronounces / spells out "_Choices". I'd
be tempted to say "underscore choices", personally, in which case the
original "an" would be appropriate.

Regards,

Adam

Re: [lintian] Membership audit and clean up - please follow up if you are still active

[Adam D. Barratt]

On Sun, 2017-08-06 at 10:13 +, Niels Thykier wrote:
> I have gone through the member list on and removed members that were
> inactive according to Debian's MIA database.
> 
> Kindly review and act on the following:
> 
>  * If you consider yourself retired from lintian, please let me know
> and
>    I will clean up your access.
>  * If you have admin access or lintian-gid, please assert you are
> still
>    around and know how to use it if needed be.
> 
> => If you have "admin" or "lintian-gid" and I do not hear from
> you
> => before 2017-09-01, I will assume you are not around to use it.
> 
> Re: admin/lintian-gid: I am interested in having redundancy here so
> we
> are at least a few members that can do the tasks related to these
> privileges.
>   However, this only works if the people with said access are 1)
> still
> around to use it and 2) still knows how/when to use it.  Accordingly,
> this mail doubles as a check to see if we have a hidden bus-factor of
> 1
> on these things.
> 

I just realised that I failed to reply to this so far; apologies.

I'm around and try to keep an eye on what's happening with lintian,
although I don't have much time to contribute very often.

I'm happy poking at the admin interface if need be. I'm certainly happy
 using the gid to do things like killing a run, adjusting cron and
attempting to troubleshoot issues. I've not looked at the live setup
recently enough to know how it's actually set up, but at worst could
disable things while we worked it out.

Cheers,

Adam

[lintian] 01/01: Fix formatting of desktop-entry-lacks-icon-entry description

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a commit to branch master
in repository lintian.

commit 34f293735b553f6f2d19bb22640aa016d2c4ddc8
Author: Adam D. Barratt <a...@adam-barratt.org.uk>
Date:   Thu Jun 22 20:19:54 2017 +0100

Fix formatting of desktop-entry-lacks-icon-entry description
---
 checks/menu-format.desc | 6 +++---
 debian/changelog| 2 ++
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/checks/menu-format.desc b/checks/menu-format.desc
index 8fde714..d5556d6 100644
--- a/checks/menu-format.desc
+++ b/checks/menu-format.desc
@@ -323,9 +323,9 @@ Certainty: certain
 Info: This .desktop file does not contain an "Icon" entry.
  .
  "Icon" is the name of the file (without the extension) of the icon displayed
-  by this .desktop file. The icon is searched in the different icon themes.
-  If the name is an absolute path, the given file will be used.
-  The icon should be unique enough to help the user to recogninse the 
application.
+ by this .desktop file. The icon is searched in the different icon themes.
+ If the name is an absolute path, the given file will be used.
+ The icon should be unique enough to help the user to recogninse the 
application.
  .
  The desktop-file-validate tool in the desktop-file-utils package is
  useful for checking the syntax of desktop entries.
diff --git a/debian/changelog b/debian/changelog
index 960a1f7..4311c89 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -12,6 +12,8 @@ lintian (2.5.52) UNRELEASED; urgency=medium
   are now in oldstable.
 + [NT] Drop check for depending on multiple versions of tkx as
   tkx does not seem to be in Debian any longer.
+  * checks/menu-format.desc:
++ [ADB] Fix formatting of desktop-entry-lacks-icon-entry
   * checks/scripts.desc:
 + [CL] Upgrade new-package-should-not-package-python2-module from
   I: to W:. See #829744 for more info.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (f16f4c7 -> 34f2937)

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a change to branch master
in repository lintian.

  from  f16f4c7   data/spelling/corrections: Remove valid word "iff"
   new  34f2937   Fix formatting of desktop-entry-lacks-icon-entry 
description

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/menu-format.desc | 6 +++---
 debian/changelog| 2 ++
 2 files changed, 5 insertions(+), 3 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#859412: lintian: Please add obsolete site check for codeplex.com

[Adam D. Barratt]

Control: forcemerge -1 859248

On 2017-04-03 11:53, Hideki Yamane wrote:
 I heard about Microsoft's code hosting site codeplex.com will be 
shutdown,
 so it's better to add a check to lintian for obsolete site. Patch, 
attached.


Someone else also heard, and already filed #859248 :)

Regards,

Adam

Bug#843117: lintian does not warn on Essential dependencies

[Adam D. Barratt]

Control: tags -1 + moreinfo

On 2016-11-04 0:17, Nicolas Braud-Santoni wrote:
According to the Debian Policy, packages should not declare 
dependencies

on packages tagged Essential:

  
https://www.debian.org/doc/debian-policy/ch-binary.html#s-dependencies


However, I noticed that lintian does not warn if, for instance,
one declares a dependency upon dash.


lintian *does* warn about dependencies on Essential:yes packages, as can 
be seen from 
https://lintian.debian.org/tags/depends-on-essential-package-without-using-version.html


Checking 
https://anonscm.debian.org/git/lintian/lintian.git/tree/data/fields/essential 
also shows that the list of packages checked for includes dash.


Is the package that you believe is being incorrectly flagged available 
somewhere for testing?


Regards,

Adam

[lintian] 01/01: releases.md: fix typo

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a commit to branch master
in repository lintian.

commit 382731b02dd76a371cd39c4c090eef2b30aeb5d4
Author: Adam D. Barratt <a...@adam-barratt.org.uk>
Date:   Sat Sep 17 11:41:13 2016 +0100

releases.md: fix typo
---
 doc/releases.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/releases.md b/doc/releases.md
index b092e38..512fa03 100644
--- a/doc/releases.md
+++ b/doc/releases.md
@@ -31,7 +31,7 @@ tag.  This is generally done in the following way:
  * Add a tag message to the top of the file
  * Tag with `git tag  -u  --file `
 
-This is method is used to provide a "trust" path between the tag and
+This method is used to provide a "trust" path between the tag and
 the uploaded files.  This is also why we use the signed `.changes`
 (as signing the source package changes the checksums in the `.changes`).
 

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (e6b7620 -> 382731b)

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a change to branch master
in repository lintian.

  from  e6b7620   Document that changes to private/ are usually not 
mentioned
   new  382731b   releases.md: fix typo

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 doc/releases.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Re: [lintian] 01/01: c/shared-libs: Improve missing ldconfig-trigger tag description

[Adam D. Barratt]

On Sun, 2016-04-24 at 19:28 +0100, Adam D. Barratt wrote:
> On Sun, 2016-04-24 at 20:25 +0200, Jakub Wilk wrote:
> > >+ If the package is using debhelper, the dh_makeshlibs should
> > >+ automatically discover this need and add the trigger itself.
> > 
> > Is "itself" needed here? It sounds awkward to me. (But this might be due 
> > to my non-nativeness.)
> 
> I'd keep it, personally, although it would still make enough sense
> without.
> 
> I would, otoh, drop the first "the" and "need".

The *second* "the". Thanks, Jakub...

Re: [lintian] 01/01: c/shared-libs: Improve missing ldconfig-trigger tag description

[Adam D. Barratt]

On Sun, 2016-04-24 at 20:25 +0200, Jakub Wilk wrote:
> >+ If the package is using debhelper, the dh_makeshlibs should
> >+ automatically discover this need and add the trigger itself.
> 
> Is "itself" needed here? It sounds awkward to me. (But this might be due 
> to my non-nativeness.)

I'd keep it, personally, although it would still make enough sense
without.

I would, otoh, drop the first "the" and "need".

Regards,

Adam

Re: [lintian] 01/01: c/scripts: Track debhelper auto-snippets in maintscripts

[Adam D. Barratt]

On Sun, 2016-04-24 at 13:13 +, Niels Thykier wrote:
> +Tag: debhelper-autoscript-in-maintainer-scripts
> +Severity: classification
> +Certainty: possible
> +Info: The maintainer scripts of the package one or more auto-generated
> + shell snippets inserted by the listed debhelper tool.

This sentence missing word.

Regards,

Adam

Bug#818003: lintian: spurious povray: spelling-error-in-binary usr/bin/povray ressize resize

[Adam D. Barratt]

On Sat, 2016-03-12 at 19:39 +0100, Jakub Wilk wrote:
> * Niels Thykier , 2016-03-12, 18:28:
> >>The string that makes Lintian unhappy is:
> >>
> >>res.size() == static_cast(w)
> >>
> >>This is of course false positive. I don't know why Lintian glued "res" 
> >>and "size" together despite the dot between them...
> >
> >I doubt that is the case.  The "spelling-error-in-binary" tag uses 
> >"strings -a" to get all strings and then checks those against its 
> >dictionary.
> 
> $ strings -a /usr/bin/povray | grep -wF res.size
> res.size() == static_cast(w)
> 
> $ strings -a /usr/bin/povray | grep -wF res.size | spellintian
> ressize -> resize

check_spelling() has:

for my $word (split(' ', $text)) {
$word =~ tr/.,;:?!//d;

which looks relevant.

Regards,

Adam

Bug#812723: lintian: package-contains-broken-symlink should look at dependencies

[Adam D. Barratt]

On Tue, 2016-01-26 at 12:43 -0700, Sean Whitton wrote:
> Dear Adam,
> 
> On Tue, Jan 26, 2016 at 05:39:52AM +0000, Adam D. Barratt wrote:
> > The tag description explicitly indicates that this is expected in the
> > situation you describe.
> 
> I know.  I was under the impression, though, that all false positives
> are considered Lintian bugs.

It's a situation that Lintian can't reasonably address, as it doesn't
know what files are in the package that you depend on.

The tag's intentionally marked as Experimental; I'm not sure whether the
current recommendation for such tags is to override or simply ignore
them.

Regards,

Adam

Bug#812723: lintian: package-contains-broken-symlink should look at dependencies

[Adam D. Barratt]

On Mon, 2016-01-25 at 21:19 -0700, Sean Whitton wrote:
> package-contains-broken-symlink gives a false positive when a package
> contains a symlink to a file provided by another package, even when the
> package with the warning depends on the package providing the target of
> the symlink.
> 
> For an example, see the source package ublock-origin version
> 1.5.6+dfsg-1 in the Debian archive.

The tag description explicitly indicates that this is expected in the
situation you describe:

"The package contains a symlink but the destination for the link does
not exist in the package nor in its direct dependencies built from the
same source package."

xul-ext-ublock-origin and fonts-fonts-awesome are /not/ built from the
same source package.

Regards,

Adam

Bug#806387: menu tests paradoxical

[Adam D. Barratt]

Control: severity -1 normal

On Thu, 2015-11-26 at 22:47 +0100, Jörg Frings-Fürst wrote:
> Package: lintian
> Version: 2.5.38.1
> Severity: serious

Definitely not.

> Hi,
> 
> Since the tech-ctte decision at bug #741573 is the command listed both in a
> menu file and a desktop file prohibited.
> 
> Therefor I get the warning "xsane: command-in-menu-file-and-desktop-file xsane
> usr/share/menu/xsane:6"
> 
> After remove the command from the menu file I get this error: "E: xsane: menu-
> item-missing-required-tag command usr/share/menu/xsane:6"

Well, yes. You're supposed to remove the whole stanza (and in many cases
the whole file), not just one little bit of it.

The referenced TC decision says:

   2. In addition to those changes, the Technical Committee resolves
  that packages providing a .desktop file shall not also provide a
  menu file for the same application.

I'm not clear how one gets from "shall not also provide a menu file for
the same application" to "can also provide a menu file for the same
application as long as there's no command= in it".

At worst the wording of the tag needs improving; the above description
doesn't indicate any kind of functionality bug in the checks, just a
misunderstanding of the intended action.

Regards,

Adam

Bug#806262: lintian: fails to find _all.changes for arch:all-only builds (-A)

[Adam D. Barratt]

Control: reassign -1 devscripts

On Thu, 2015-11-26 at 00:45 +0100, Cyril Brulebois wrote:
> Running a build with the -A flag leads to a confused lintian as it tried
> to find a _amd64.changes file where an _all.changes file was produced.
> Full transcript follows:
> | (sid-amd64-devel)kibi@wodi:~/debian-installer/packages/base-installer$ 
> debuild -A
[...]
> |  dpkg-genchanges -A >../base-installer_1.158_all.changes
> | dpkg-genchanges: binary-only arch-indep upload (source code and 
> arch-specific packages not included)
> |  dpkg-source --after-build base-installer
> | dpkg-buildpackage: source-only upload: Debian-native package
> | Now running lintian...
> | warning: "base-installer_1.158_amd64.changes" cannot be processed.
> | warning: It is not a valid lab query and it is not an existing file.
> | Finished running lintian.

That's a debuild bug. The majority of your output is from
dpkg-buildpackage directly, but debuild is then running lintian against
the wrong file.

I'm assuming that the above also generated
base-installer_1.158_amd64.build?

Regards,

Adam

Bug#804256: lintian: false positive postrm-should-call-ldconfig

[Adam D. Barratt]

Control: tags -1 + moreinfo

On Fri, 2015-11-06 at 17:53 +0100, Jörg Frings-Fürst wrote:
> Package: lintian
> Version: 2.5.38
> Severity: important
> 
> Hi,
> 
> I get this error because tiggers contains:
> 
> # Triggers added by dh_makeshlibs
> activate-noawait ldconfig

Is the package in question available somewhere? 2.5.37 already contained
this change:

+ [NT] Accept an "activate-noawait ldconfig" trigger instead of
  explicit calls to "ldconfig".

Regards,

Adam

Bug#801482: The name of a programme, from which an error message comes, is missing in the lintian's message

[Adam D. Barratt]

On 2015-10-14 12:22, Jakub Wilk wrote:
[...]

* Bjarni Ingi Gislason , 2015-10-11, 00:41:

[...]
How will (the cause of) this programming error be documented, so 
people (can) learn from it and do not repeat it themselves?


As usually, in the bug log and in the changelog. (But this
condescending tone is not helpful...)


Very much agreed. Likewise the paragraphs of unrelated quotes following 
it.


Regards,

Adam

[lintian] branch master updated (8f8c04a -> 8f3a784)

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a change to branch master
in repository lintian.

  from  8f8c04a   c/debhelper: Unconditionally tag dh_clean -k usage
   new  8f3a784   c/debhelper.desc: fix typo ("instread")

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/debhelper.desc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: c/debhelper.desc: fix typo ("instread")

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a commit to branch master
in repository lintian.

commit 8f3a784b5284786c2d0b5828719ae94d3cc3bbd3
Author: Adam D. Barratt <a...@adam-barratt.org.uk>
Date:   Sat Sep 5 08:29:48 2015 +0100

c/debhelper.desc: fix typo ("instread")

    Signed-off-by: Adam D. Barratt <a...@adam-barratt.org.uk>
---
 checks/debhelper.desc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/checks/debhelper.desc b/checks/debhelper.desc
index 07f5efd..11783a4 100644
--- a/checks/debhelper.desc
+++ b/checks/debhelper.desc
@@ -118,7 +118,7 @@ Severity: normal
 Certainty: certain
 Ref: dh_clean(1)
 Info: This package calls dh_clean -k in its debian/rules file
- instread of dh_prep.
+ instead of dh_prep.
 
 Tag: debhelper-compat-file-is-empty
 Severity: important

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (082bdc6 - d03b83a)

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a change to branch master
in repository lintian.

  from  082bdc6   pod-spelling/WritingTests.pod: Fix some spelling issues
   new  d03b83a   doc/tutorial/*: proof-read

The 1 revisions listed above as new are entirely new to this
repository and will be described in separate emails.  The revisions
listed as adds were already present in the repository and have only
been added to this reference.


Summary of changes:
 doc/tutorial/Lintian/Tutorial/TestSuite.pod | 18 +++
 doc/tutorial/Lintian/Tutorial/WritingChecks.pod | 68 -
 doc/tutorial/Lintian/Tutorial/WritingTests.pod  | 42 +++
 3 files changed, 64 insertions(+), 64 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/20150811183030.9582.36...@moszumanska.debian.org

[lintian] 01/01: doc/tutorial/*: proof-read

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a commit to branch master
in repository lintian.

commit d03b83a2756aa964c939c512dc0934b8f420698c
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Tue Aug 11 19:29:41 2015 +0100

doc/tutorial/*: proof-read

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk
---
 doc/tutorial/Lintian/Tutorial/TestSuite.pod | 18 +++
 doc/tutorial/Lintian/Tutorial/WritingChecks.pod | 68 -
 doc/tutorial/Lintian/Tutorial/WritingTests.pod  | 42 +++
 3 files changed, 64 insertions(+), 64 deletions(-)

diff --git a/doc/tutorial/Lintian/Tutorial/TestSuite.pod 
b/doc/tutorial/Lintian/Tutorial/TestSuite.pod
index 650fd26..1a87ed8 100644
--- a/doc/tutorial/Lintian/Tutorial/TestSuite.pod
+++ b/doc/tutorial/Lintian/Tutorial/TestSuite.pod
@@ -18,9 +18,9 @@ LLintian::Tutorial::WritingTests.
 
 The Lintian test suite is an extensive collection of various test
 cases.  The test suite is divided into 4 sub-suites.  The majority
-of all tests are currently located in the tests sub-suite.
+of tests are currently located in the tests sub-suite.
 
-To run the full suite in all of its glory, simply invoke:
+To run the full suite in all its glory, simply invoke:
 
  $ debian/rules runtests
 
@@ -29,11 +29,11 @@ To run the full suite in all of its glory, simply invoke:
  $ mkdir -p debian/test-out
  $ t/runtests -k --dump-logs t debian/test-out
 
-But while writing a new tag (or check) you probably only want to run a
+While writing a new tag (or check) you probably only want to run a
 particular (subset of the) test(s).  See L/Running a subset of the
 tests for the available options.
 
-When run via Idebian/rules, the test suite respects the
+When run via Idebian/rules, the test suite respects
 DEB_BUILD_OPTIONS=parallel=N. When using It/runtests directly, use
 I-jN to choose the number of threads.  Note that N denotes the
 amount of worker threads.  The test runner will generally have 2
@@ -41,9 +41,9 @@ threads more than that.  Also each worker will run lintian, 
which
 runs multiple unpacking jobs in parallel as well.
 
 In case you are wondering about the 2 extra threads in the test
-runner, the first of them is the coordinator-thread (which will
+runner, the first of them is the coordinator thread (which will
 generally be waiting when the workers are active) and the second one
-is the output-thread (which handles the fancy output).
+is the output thread (which handles the fancy output).
 
 =head2 Running a subset of the tests
 
@@ -72,7 +72,7 @@ To run all tests for a given check, use:
  $ t/runtests --dump-logs -k t debian/test-out $check
 
 $check must be the name of a check (it will test for
-checks/$check.desc) or legacy.  This will run all tests that starts
+checks/$check.desc) or legacy.  This will run all tests that start
 with $check-.
 
 Note: The changes sub-suite in the new test suite does not support
@@ -90,12 +90,12 @@ To run all tests in a given sub-suite, use:
 
 $suites is a comma-separated list of names of sub-suites to run.
 
-Note: this cannot be used to influence the order, in which the sub-suites
+Note: this cannot be used to influence the order in which the sub-suites
 are run.
 
 =item Running all tests designed for a specific tag
 
-To run all tests that has a Test-For or a Test-Against for a given
+To run all tests that have a Test-For or a Test-Against for a given
 tag, use:
 
  $ debian/rules runtests onlyrun=tag:$tag
diff --git a/doc/tutorial/Lintian/Tutorial/WritingChecks.pod 
b/doc/tutorial/Lintian/Tutorial/WritingChecks.pod
index f9433ab..6f4860b 100644
--- a/doc/tutorial/Lintian/Tutorial/WritingChecks.pod
+++ b/doc/tutorial/Lintian/Tutorial/WritingChecks.pod
@@ -17,17 +17,17 @@ one.
 
 =head1 DESCRIPTION
 
-The basics of writing a check is outlined in the Lintian User Manual
-(§3.3).  This tutorial will focus on the part of writing the actual
+The basics of writing a check are outlined in the Lintian User Manual
+(§3.3).  This tutorial will focus on the act of writing the actual
 check.  In this tutorial, we will assume the name of the check to be
-written is called deb/pkg-check.
+written is deb/pkg-check.
 
 The tutorial will work with a binary and udeb check.  Checking
 source packages works in a similar fashion.
 
 =head2 Create a check I.desc file
 
-As mentioned, this tutorial will focus on the part of writing a check.
+As mentioned, this tutorial will focus on the writing of a check.
 Please see the Lintian User Manual (§3.3) for how to do this part.
 
 =head2 Create the Perl check module
@@ -48,7 +48,7 @@ Start with the template:
  return;
  }
 
-This snippet above is a simple valid check that does nothing at all.
+The snippet above is a simple valid check that does nothing at all.
 We will extend it in just a moment, but first let us have a look at
 the arguments at the setup.
 
@@ -70,7 +70,7 @@ At the moment, $type is one of binary (.deb), udeb

Re: [lintian] 01/02: Raise pre-depends-directly-on-multiarch-support to important

[Adam D. Barratt]

On Mon, 2015-08-03 at 17:50 +0200, Jakub Wilk wrote:
 * Bastien ROUCARIES broucaries-gu...@moszumanska.debian.org, 2015-08-03, 
 15:37:
 +  Thanks to Helmut Grohne remainder.
 
 s/remainder/for reminder/

for the reminder :P

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/1438623923.24735.3.ca...@adam-barratt.org.uk

Bug#792365: lintian gives false positive for minified js file

[Adam D. Barratt]

Control: severity -1 normal

On 2015-07-14 9:26, Pirate Praveen wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

package: lintian
version: 2.5.33
severity: grave
reason: gives wrong lintian error


A single false positive for a tag that's not on the auto-reject list is 
in no way Release Critical.


Regards,

Adam


--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/47c7a8fc6764aa936a3a31c6ff845...@mail.adam-barratt.org.uk

Re: [lintian] 01/01: Clarify a requirement of the deb822 ctrl statement .

[Adam D. Barratt]

On 2015-07-02 7:42, Niels Thykier wrote:

+ The empty-line control statement does not permit any characters
+ following it on the same line.  Therefore, the entirely line must
+ consist entirely of a space followed by a dot.


That's one too many entirelys. I'd suggest just dropping the first one 
and saying the line must consist entirely of. (Not near the right SSH 
key to fix it myself right now.)


Regards,

Adam


--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/320c44e5da86b926b2a16261ae630...@mail.adam-barratt.org.uk

[lintian] branch master updated (5602975 - 0fe2ac5)

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a change to branch master
in repository lintian.

  from  5602975   c/binaries: Make a separat unneeded sections tag for 
static libs
   new  0fe2ac5   c/binaries: fix typo in 
static-library-has-unneeded-section description

The 1 revisions listed above as new are entirely new to this
repository and will be described in separate emails.  The revisions
listed as adds were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/binaries.desc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/20150620134903.16209.2...@moszumanska.debian.org

[lintian] 01/01: c/binaries: fix typo in static-library-has-unneeded-section description

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a commit to branch master
in repository lintian.

commit 0fe2ac5f8be3a4f63e7a20b4231192b7507bc3c4
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sat Jun 20 14:48:39 2015 +0100

c/binaries: fix typo in static-library-has-unneeded-section description

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk
---
 checks/binaries.desc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/checks/binaries.desc b/checks/binaries.desc
index a44a561..b54fbb1 100644
--- a/checks/binaries.desc
+++ b/checks/binaries.desc
@@ -103,7 +103,7 @@ Certainty: certain
 Experimental: yes
 Info: Tag for tallying static libraries .comment sections.
  .
- Be advised that some languages (e.g. OCaml) stores bytecode in the
+ Be advised that some languages (e.g. OCaml) store bytecode in the
  .comment section and you should therefore inot/i blindly
  strip this section.
 

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/e1z6j8p-0004ex...@moszumanska.debian.org

Bug#769073: [duplicate-files] is mark with X for xxperimenta, but in the info the Severity are pedantic,

[Adam D. Barratt]

Control: tags -1 + moreinfo

On 2014-11-11 8:05, Jörg Frings-Fürst wrote:

X: bitz-server-doc: duplicate-files usr/share/doc/bitz-server-
doc/docs/search/all_0.js usr/share/doc/bitz-server-
doc/docs/search/functions_0.js

[...]

N:Severity: pedantic, Certainty: possible
N:
N:Check: duplicate-files, Type: binary
N:
N:This tag is marked experimental, which means that the code that
N:generates it is not as well-tested as the rest of Lintian and 
might
N:still give surprising results. Feel free to ignore experimental 
tags


I'm afraid I'm confused. What exactly is the problem that you're 
requesting be fixed?


Regards,

Adam


--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/92eb338e6cf5dea826e7a85f1653a...@mail.adsl.funky-badger.org

[lintian] 01/01: data/changes-file/known-dists: add stretch

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a commit to branch master
in repository lintian.

commit f9d1248acb1a99ed5ec17b8473db3f0f32aa47a0
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sun Nov 9 12:53:49 2014 +

data/changes-file/known-dists: add stretch

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk
---
 data/changes-file/known-dists | 1 +
 debian/changelog  | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/data/changes-file/known-dists b/data/changes-file/known-dists
index 5c3c216..c0f2a47 100644
--- a/data/changes-file/known-dists
+++ b/data/changes-file/known-dists
@@ -10,6 +10,7 @@
 squeeze
 wheezy
 jessie
+stretch
 sid
 
 # Aliases
diff --git a/debian/changelog b/debian/changelog
index 15260e4..b706a93 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,9 @@ lintian (2.5.31) UNRELEASED; urgency=medium
 + [BR] Add reference to build-depends-on-metapackage
   (Closes: #767107).
 
+  * data/changes-file/known-dists:
++ [ADB] Add stretch.
+
   * debian/control:
 + [NT] Recommend dpkg (= 1.17.14) for the --ctrl-tarfile
   option in dpkg-deb.  Lintian relies on it to support

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/e1xns6w-0003z1...@moszumanska.debian.org

[lintian] branch master updated (964562c - f9d1248)

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a change to branch master
in repository lintian.

  from  964562c   Add reference to build-depends-on-metapackage
   new  f9d1248   data/changes-file/known-dists: add stretch

The 1 revisions listed above as new are entirely new to this
repository and will be described in separate emails.  The revisions
listed as adds were already present in the repository and have only
been added to this reference.


Summary of changes:
 data/changes-file/known-dists | 1 +
 debian/changelog  | 3 +++
 2 files changed, 4 insertions(+)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/20141109130054.13612.25...@moszumanska.debian.org

[lintian] branch jessie created (now d5ea252)

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a change to branch jessie
in repository lintian.

at  d5ea252   data/changes-file/known-dists: add stretch

This branch includes the following new commits:

   new  447d944   Start Jessie branch
   new  d5ea252   data/changes-file/known-dists: add stretch

The 2 revisions listed above as new are entirely new to this
repository and will be described in separate emails.  The revisions
listed as adds were already present in the repository and have only
been added to this reference.


-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/20141109135541.21769.92...@moszumanska.debian.org

[lintian] 01/02: Start Jessie branch

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a commit to branch jessie
in repository lintian.

commit 447d944147fc3753934df5bb3d7e0d2714657e64
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sun Nov 9 13:10:32 2014 +

Start Jessie branch

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk
---
 debian/changelog | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index e9b3a81..7cdc32b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+lintian (2.5.30+deb8u1) jessie; urgency=medium
+
+  * 
+
+ -- Adam D. Barratt a...@adam-barratt.org.uk  Sun, 09 Nov 2014 13:07:54 +
+
 lintian (2.5.30) unstable; urgency=medium
 
   The welcome Axel Beckert! release.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/e1xnsxx-0005gi...@moszumanska.debian.org

[lintian] 02/02: data/changes-file/known-dists: add stretch

[Adam D. Barratt]

This is an automated email from the git hooks/post-receive script.

adsb pushed a commit to branch jessie
in repository lintian.

commit d5ea252072cbb66f87ea3e53f7e5b1161511f195
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sun Nov 9 13:52:10 2014 +

data/changes-file/known-dists: add stretch

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk
---
 data/changes-file/known-dists | 1 +
 debian/changelog  | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/data/changes-file/known-dists b/data/changes-file/known-dists
index 5c3c216..c0f2a47 100644
--- a/data/changes-file/known-dists
+++ b/data/changes-file/known-dists
@@ -10,6 +10,7 @@
 squeeze
 wheezy
 jessie
+stretch
 sid
 
 # Aliases
diff --git a/debian/changelog b/debian/changelog
index 7cdc32b..11e1927 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,7 @@
 lintian (2.5.30+deb8u1) jessie; urgency=medium
 
-  * 
+  * data/changes-file/known-dists:
++ [ADB] Add stretch.
 
  -- Adam D. Barratt a...@adam-barratt.org.uk  Sun, 09 Nov 2014 13:07:54 +
 

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/e1xnsxx-0005gr...@moszumanska.debian.org

Bug#766591: [lintian] false positives on license-problem-cc-by-nc-sa

[Adam D. Barratt]

Control: tags -1 + moreinfo

On Fri, 2014-10-24 at 10:36 +0200, Jörg Frings-Fürst wrote:
 On an fresh  empty svg file lintian reports a error with license-problem-cc-
 by-nc-sa.
 
 The svg file was created with inkscape (New, Resize, Save as).

That file doesn't appear to contain the strings necessary to trigger the
tag. Do you have an example package which demonstrates the issue?

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/1414171383.11758.6.ca...@adam-barratt.org.uk

Bug#761048: test-command is sufficient for autopkgtest

[Adam D. Barratt]

Control: forcemerge 760714 -1

On 2014-09-10 11:09, Pirate Praveen wrote:

package: lintian
version: 2.5.26

from
http://anonscm.debian.org/cgit/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst

Test-Command: shell command

[...]

but lintian give the following warnings, please fix them

W: ruby-kaminari source: missing-runtime-tests-field tests


That would be #760714, which has already been reported.

Regards,

Adam


--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/28693505d032995249ae1c5efe8cc...@mail.adsl.funky-badger.org

Bug#753165: lintian needs Provides: funny-manpages ( 1.3-5.1)

[Adam D. Barratt]

On Sun, 2014-06-29 at 20:20 +0300, Adrian Bunk wrote:
 Unpacking lintian (2.5.24) over (2.5.21) ...
 dpkg: error processing archive /var/cache/apt/archives/lintian_2.5.24_all.deb 
 (--unpack):
  trying to overwrite '/usr/share/lintian/overrides/lintian', which is also in 
 package funny-manpages 1.3-5
 dpkg-deb: error: subprocess paste was killed by signal (Broken pipe)
 
 --  snip  --
 
 
 This was a bug in funny-manpages, but lintian has to add a
 Provides: funny-manpages ( 1.3-5.1) to avoid users running
 into it when upgrading lintian.

You mean Replaces.

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/1404063718.4539.11.ca...@jacala.jungle.funky-badger.org

Bug#745802: Please add libcpre.gcc.o to list of not distributable files

[Adam D. Barratt]

On Sat, 2014-04-26 at 12:49 +0200, Bastien ROUCARIES wrote:
 Added, notes that you should ask to remove previous version of fpc
 from datas.debian.org

ITYM snapshot.

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/1398518177.15557.23.ca...@jacala.jungle.funky-badger.org

Bug#745546: lintian: False positive: openttd source: source-is-missing os/dos/cwsdpmi/cwsdpmi.txt

[Adam D. Barratt]

On Tue, 2014-04-22 at 19:17 +0200, Matthijs Kooijman wrote:
 The file referenced is somehow detected as a binary, even though it is
 just a text file containing licensing info and documentation. The file
 itself is available here:
 
 http://vcs.openttd.org/svn/browser/tags/1.4.0/os/dos/cwsdpmi/cwsdpmi.txt

I suspect due to (on wheezy at least):

$ file /tmp/cwsdpmi.txt 
/tmp/cwsdpmi.txt: Macromedia Flash data (compressed), version 68

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/1398192452.4516.29.ca...@jacala.jungle.funky-badger.org

Re: false-positive? for permission check

[Adam D. Barratt]

On 2014-02-06 4:11, Hideki Yamane wrote:

Hi lintian maintainers,


fontforge (20120731.b-5) [Uploader] Info PTS Bugs (last processed

by

Lintian/2.5.21-19-g426f50c)


 libfontforge-dev


W non-standard-dir-perm
usr/include/fontforge/ 0775 != 0755
usr/lib/pkgconfig/ 0775 != 0755

(snip)

 Well, I've checked binary package and its permission is 0755, not
0775 as lintian says.


Which precise package did you look at?

The i386 package does indeed have the directory as 0755:

adsb@franck:~$ dpkg-deb -c 
ftp/pool/main/f/fontforge/libfontforge-dev_20120731.b-5_i386.deb | egrep 
^d.*pkgconfig/$

drwxr-xr-x root/root 0 2014-01-01 08:34 ./usr/lib/pkgconfig/

All other architectures are 0775, however:

adsb@franck:~$ dpkg-deb -c 
ftp/pool/main/f/fontforge/libfontforge-dev_20120731.b-5_mips.deb | egrep 
^d.*pkgconfig/$

drwxrwxr-x root/root 0 2014-01-02 03:18 ./usr/lib/pkgconfig/


I'm not sure it's bug or not.


It may well be a bug, but not in lintian.

Regards,

Adam


--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/035b9b1341248e61c92497a91bd84...@mail.adsl.funky-badger.org

Bug#733595: false positive for maintainer-script-should-not-use-adduser-system-without-home

[Adam D. Barratt]

On 2013-12-30 7:59, Daniel Pocock wrote:

In my package reconserver, I have the following:

adduser --system \
   --home ${RECONSERVER_HOME} \
   --shell /bin/false \
   --no-create-home \
   --ingroup $RECONSERVER_GROUP \
   --disabled-password \
   --disabled-login \
   --gecos reConServer daemon \
   $RECONSERVER_USER || exit 1



Therefore, I believe the lintian report is a false positive, maybe
because the adduser command is split over multiple lines


Based on a bit of testing yesterday after another similar report, I 
believe the issue is actually due to the use of a variable for the home 
directory.


Regards,

Adam


--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/bfa61ff40dae1d0bd4a068e08b60a...@mail.adsl.funky-badger.org

[SCM] Debian package checker branch, master, updated. 2.5.14-31-gb41ef66

[Adam D. Barratt]

The following commit has been merged in the master branch:
commit b41ef660ab098bca85432235fa62f591a31ec4f3
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sun Jun 30 22:19:40 2013 +0100

Fix grammar in manpage-named-after-build-path description

diff --git a/checks/manpages.desc b/checks/manpages.desc
index 2a6e77d..eb69db2 100644
--- a/checks/manpages.desc
+++ b/checks/manpages.desc
@@ -275,7 +275,7 @@ Info: Lintian found a spelling error in the manpage. 
Lintian has a list
 Tag: manpage-named-after-build-path
 Severity: important
 Certainty: certain
-Info: The manual page appear to be named after its build path and
+Info: The manual page appears to be named after its build path and
  not after its content.
  .
  Please check your debian/rules or upstream Makefile.

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1utp2t-vn...@vasks.debian.org

Re: How does lintian detect the presence of static libs?

[Adam D. Barratt]

Hi,

On Mon, 2013-06-03 at 12:26 +0100, Richard Williams wrote:
 E: indiecity-client: embedded-library
 usr/bin/indiecity-client: tinyxml
 This is understandable. However, we've renamed the statically-linked
 custom tinyxml to 'icxml', to make it clear that this is not the same
 library, but the error persists verbatim.
[...]
 I was wondering if you could please advise me on how lintian detects a
 static library being used and how we can convince this mechanism that
 our lib is significantly different, or if an override is appropriate
 in this case.

Lintian matches strings in the binary against known text from common
static libraries;
see 
/usr/share/lintian/vendors/debian/ftp-master-auto-reject/data/binaries/embedded-libs

In the specific case of tinyxml:

tinyxml   ||Error when TiXmlDocument added to document

where the text after the || is what's being matched. For a local
package, an override should be fine, imho.

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1370274653.5209.11.ca...@jacala.jungle.funky-badger.org

Re: [SCM] Debian package checker branch, master, updated. 2.5.11-222-g70ed124

[Adam D. Barratt]

On Wed, 2013-04-03 at 22:26 +, Niels Thykier wrote:
 --- a/lib/Lintian/Collect/Package.pm
 +++ b/lib/Lintian/Collect/Package.pm
 @@ -219,10 +219,13 @@ sub _fetch_extracted_dir {
[...]
  # strip leading ./ - if that leaves something, return the path there
 -$file =~ s,^\.?/*+,,go;
 -return $dir/$file if $file;
 +if ($file =~ s,^(?:\.?/)++,,go) {

The new version there looks like it has too many +s?

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1365028736.25543.6.ca...@jacala.jungle.funky-badger.org

Re: [SCM] Debian package checker branch, master, updated. 2.5.11-222-g70ed124

[Adam D. Barratt]

On Thu, 2013-04-04 at 00:49 +0200, Niels Thykier wrote:
   The second plus is just a no-backtrack hint.

/me checks perlre(1) and adds that to the TIL list.

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1365029573.25543.8.ca...@jacala.jungle.funky-badger.org

Bug#701702: lintian: warn if debian/shlibs.local references foreign packages

[Adam D. Barratt]

On 26.02.2013 12:46, Sven Joachim wrote:

It would be great if lintian could detect when debian/shlibs.local
references packages not built from the same source and issue a 
warning

for that.


This sounds like something we could probably extend 
shlibs-declares-dependency-on-other-package to cover, unless I'm missing 
a detail somewhere.


Regards,

Adam


--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/c64d9493df6feea9e75a2701a5fbf...@mail.adsl.funky-badger.org

[SCM] Debian package checker branch, master, updated. 2.5.11-84-g705577d

[Adam D. Barratt]

The following commit has been merged in the master branch:
commit 705577dfbdba8584b19cdc872eeba0a071701b8a
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sat Jan 19 20:26:02 2013 +

Lintian::Util: correct spelling of ENCRYPTED

Fix a typo in the matching of expected delimiters for some
signed messages; thanks Samuel Bronson.

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk

diff --git a/debian/changelog b/debian/changelog
index e840219..940a5bc 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -141,6 +141,8 @@ lintian (2.5.12) UNRELEASED; urgency=low
 + [NT] Reject partially signed Deb822 files.  Most Deb822 files
   are not signed at all; but those that are should be completely
   covered by a signature.  (Closes: #696230)
++ [ADB] Fix a typo in the matching of expected delimiters for some
+  signed messages; thanks Samuel Bronson.
 
   * private/refresh-locale-codes:
 + [JW,NT] Ignore the zxx locale code, which means No
diff --git a/lib/Lintian/Util.pm b/lib/Lintian/Util.pm
index de61c56..49b4f28 100644
--- a/lib/Lintian/Util.pm
+++ b/lib/Lintian/Util.pm
@@ -428,7 +428,7 @@ sub visit_dpkg_paragraph {
 
 my $key = qr/(?:BEGIN|END) PGP (?:PUBLIC|PRIVATE) KEY BLOCK/;
 my $msgpart = qr{BEGIN PGP MESSAGE, PART \d+(?:/\d+)?};
-my $msg = qr/(?:BEGIN|END) PGP (?:(?:COMPRESSED|ENCRYTPED) 
)?MESSAGE/;
+my $msg = qr/(?:BEGIN|END) PGP (?:(?:COMPRESSED|ENCRYPTED) 
)?MESSAGE/;
 
 if (m/^-($key|$msgpart|$msg)-\s*$/o) {
 die syntax error at line $.: Unexpected $1 header\n;

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1twf0m-0003mx...@vasks.debian.org

Bug#694328: Patch

[Adam D. Barratt]

On Sun, 2012-12-09 at 13:01 +0100, Niels Thykier wrote:
 On 2012-12-09 12:43, Bastien ROUCARIES wrote:
  +Tag: font-adobe-copyrighted-fragment
  +Severity: serious
  +Certainty: possible
  +Info: This type 1 font file, include some postscript fragment with a 
   ^
 
 Spurious comma?  (Not an native English speaker, so I could be wrong here)

Nope, the comma definitely looks odd. Also s/include/s/.

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1355056132.19225.37.ca...@jacala.jungle.funky-badger.org

Re: [SCM] Debian package checker branch, master, updated. 2.5.10-236-g2bd94da

[Adam D. Barratt]

On Sat, 2012-11-03 at 01:46 +, Raphael Geissert wrote:
 The following commit has been merged in the master branch:
 commit 2bd94daabf7da01ee6e6c3ee632b525ab5904dca
 Author: Raphael Geissert atom...@gmail.com
 Date:   Fri Nov 2 19:45:01 2012 -0600
 
 Re-sort the spelling corrections
 
 Some corrections were out of order.
[...]
 +acient||ancient
 +acknowldegement||acknowldegement
[...]
  analysator||analyzer
 -acient||ancient

There was at least one oddity, but most of these just look like the list
was sorted by correction, rather than by the misspelling?

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1351962015.4348.17.ca...@jacala.jungle.funky-badger.org

[SCM] Debian package checker branch, master, updated. 2.5.10-218-gfa4e574

[Adam D. Barratt]

The following commit has been merged in the master branch:
commit fa4e5741ed77018ef5f084cdb8e85401df7b5f14
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sun Oct 21 13:55:23 2012 +0100

doc/lintian.xml: English / typo fixes

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk

diff --git a/doc/lintian.xml b/doc/lintian.xml
index fbe490d..25ae68f 100644
--- a/doc/lintian.xml
+++ b/doc/lintian.xml
@@ -810,7 +810,7 @@ foo [!any-i386] binary: some-tag-not-for-i386 optional-extra
 para
   This field is most likely only useful if the profile
   needs to enable a list of tags from a check in
-  additional to any tags already enabled from that
+  addition to any tags already enabled from that
   check (if any).
 /para
   /listitem
@@ -1215,7 +1215,7 @@ foo [!any-i386] binary: some-tag-not-for-i386 
optional-extra
 also holds for the checks provided by Lintian itself.
   /para
   para
-Checks in Lintian consists of a description file (.desc) and a
+Checks in Lintian consist of a description file (.desc) and a
 Perl module implementing the actual check (no extension).  The
 names of these checks must consist entirely of the lower case
 characters ([a-z]), digits ([0-9]), underscore (_), dash (-),
@@ -1308,7 +1308,7 @@ foo [!any-i386] binary: some-tag-not-for-i386 
optional-extra
 para
   Alternative or abbreviated name of the check.  These
   can be used with certain command line options as an
-  alternative name of the real check.
+  alternative name for the check.
 /para
   /listitem
 /varlistentry
@@ -1339,7 +1339,7 @@ foo [!any-i386] binary: some-tag-not-for-i386 
optional-extra
   tag is.  The value must be one of serious,
   important, normal, minor, wishlist and
   pedantic.  The effective severity and the value of
-  the Certainty field of a tag determines the
+  the Certainty field of a tag determine the
   one-letter code (of non-experimental tags).
 /para
   /listitem
@@ -1351,7 +1351,7 @@ foo [!any-i386] binary: some-tag-not-for-i386 
optional-extra
   How accurate the tag is (believed to be).  The value
   must be one of certain, possible, wild-guess.
   The effective severity and the value of the
-  Certainty field of a tag determines the one-letter
+  Certainty field of a tag determine the one-letter
   code (of non-experimental tags).
 /para
   /listitem
@@ -1370,7 +1370,7 @@ foo [!any-i386] binary: some-tag-not-for-i386 
optional-extra
   amp;amp;, amp;lt; and amp;gt; (respectively).
 /para
 para
-  Intended lines are considered pre-formatted and
+  Indented lines are considered pre-formatted and
   will not be line wrapped.  These lines are still
   subject to the allowed HTML tags and above mentioned
   escape sequences.
@@ -1473,13 +1473,13 @@ foo [!any-i386] binary: some-tag-not-for-i386 
optional-extra
 /listitem
 listitem
   para
-An instance of Lintian::Processable that represent the
+An instance of Lintian::Processable that represents the
 package being processed.
   /para
 /listitem
 listitem
   para
-An instance of Lintian::ProcessableGroup that represent
+An instance of Lintian::ProcessableGroup that represents
 the other processables in the given group.  An instance
 of the Lintian::Collect::Group is available via its
 info method.
@@ -1489,7 +1489,7 @@ foo [!any-i386] binary: some-tag-not-for-i386 
optional-extra
   para
 Further arguments may be added in the future after the above
 mentioned ones.  Implementations should therefore ignore
-extra arguments beyond the ones it know of.
+extra arguments beyond the ones they know of.
   /para
   para
 If the run sub returns normally, the check was run
@@ -1503,7 +1503,7 @@ foo [!any-i386] binary: some-tag-not-for-i386 
optional-extra
 still be run on other packages.
   /para
   para
-The run sub may emit tags by invoking that sub tag from
+The run sub may emit tags by invoking the sub tag from
 Lintian::Tags (it can be imported).  The first argument is
 the name of the tag to emit.  Any

[SCM] Debian package checker branch, master, updated. 2.5.10-218-gfa4e574

[Adam D. Barratt]

The following commit has been merged in the master branch:
commit 7b0a4448818b2ef33bbca072311e7a04882a7300
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sun Oct 21 13:54:53 2012 +0100

Test::Lintian: English tweaks

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk

diff --git a/lib/Test/Lintian.pm b/lib/Test/Lintian.pm
index e168dd8..bd9b019 100644
--- a/lib/Test/Lintian.pm
+++ b/lib/Test/Lintian.pm
@@ -74,9 +74,9 @@ Test check desc files (and the tags in them) for common 
errors.
 OPTS is an optional HASHREF that determines if some of the tests
 are optional or not.  Currently it is unused.
 
-DESCFILES is a list of paths to check desc files.
+DESCFILES is a list of paths in which to check desc files.
 
-As the number tests depend on the number of tags in desc, it is
+As the number of tests depends on the number of tags in desc, it is
 difficult to plan ahead when using this test.  It is therefore
 recommended to not specify a plan and use done_testing().
 

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1tpv5y-0008mq...@vasks.debian.org

[SCM] Debian package checker branch, master, updated. 2.5.6-126-gea8b765

[Adam D. Barratt]

The following commit has been merged in the master branch:
commit ea8b76583ca452a602d86d7e766d1550a17b74e9
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Thu May 3 22:08:15 2012 +0100

Add quantal as a known Ubuntu distribution

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk

diff --git a/debian/changelog b/debian/changelog
index 01b579c..d3e0f2f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -209,6 +209,7 @@ lintian (2.5.7) UNRELEASED; urgency=low
 
   * vendors/ubuntu/main/data/changes-file/known-dists:
 + [NT] New file based on data/changes-file/ubuntu-dists.
++ [ADB] Add quantal (Quetzal)
   * vendors/ubuntu/main/data/common/source-fields:
 + [NT] New file.
   * vendors/ubuntu/main/data/fields/{binary,udeb}-fields:
diff --git a/vendors/ubuntu/main/data/changes-file/known-dists 
b/vendors/ubuntu/main/data/changes-file/known-dists
index dd6c89c..0220b75 100644
--- a/vendors/ubuntu/main/data/changes-file/known-dists
+++ b/vendors/ubuntu/main/data/changes-file/known-dists
@@ -8,3 +8,4 @@ maverick
 natty
 oneiric
 precise
+quantal

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1sq3hp-0005ge...@vasks.debian.org

Bug#669709: lintian: check deban/watch::version

[Adam D. Barratt]

On Sat, 2012-04-21 at 13:09 +0300, Jari Aalto wrote:
 Please add a a check to verify that debian/watch::version is latest,
 similarly to checking debian/controll::Standards-Version to warn about
 policy being not the latest.

I'm fairly sure the discussion about version 2 watch files has been had
before and the consensus was that while they shouldn't be used for new
files, they're still supported by uscan so valid in packages.  I suppose
a pedantic tag is arguable, but if you're the sort of maintainer who's
likely to be looking at and paying attention to pedantic tags then
you're also the sort of maintainer who's going to have upgraded your
watch file years ago.

 An idea:
 
 E:  anything else
 P:  if LATEST - 2
 W:  if LATEST - 1

As above, I'm not convinced that version 2 use necessarily deserves any
form of tag.  The other two cases in your suggestion above - in fact
anything other than 2 or 3 - are already handled by a combination of
debian-watch-file-unknown-version (for versions consisting of digits)
and debian-watch-file-missing-version (which will also trigger for
version=foobar), which have existed since 2008.

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1335003945.26539.19.ca...@jacala.jungle.funky-badger.org

Bug#664211: add check for wrong dependency on debconf

[Adam D. Barratt]

On Fri, 2012-03-16 at 12:14 -0700, Russ Allbery wrote:
 But, on this topic, when I looked at removing debconf from my system, the
 thing that seemed to be missing was debconf-set-selections.  Does cdebconf
 provide that utility in some way that I'm not noticing?

A quick poke at the Contents files suggests that it does, but it's
in /usr/lib/cdebconf, rather than /usr/bin.

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1331927539.28016.4.ca...@jacala.jungle.funky-badger.org

Re: Standards-Version 3.9.3

[Adam D. Barratt]

Hi,

On Sun, 2012-02-26 at 09:55 +, Bas van den Dikkenberg wrote:
 According to my pts page i must upgrade to Standards-Version 3.9.3 but
 lintian gives a warning about it can you please fixed this in
 lintian ?

Lintian 2.5.5, released last Thursday, supports policy 3.9.3.

Regards,

Adam



-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1330252554.27081.97.ca...@jacala.jungle.funky-badger.org

Bug#661363: lintian: [false-positive] missing-dep-for-interpreter, though correctly: fontforge | fontforge-nox

[Adam D. Barratt]

On Sun, 2012-02-26 at 18:30 +0100, Martin Erik Werner wrote:
 It seems that lintian does not see the
  Depends: (...) fontforge-nox | fontforge, (...)
 of the package
  googlefontdirectory-tools
 correctly, and reports: missing-dep-for-interpreter

As far as I can tell, this is precisely because you've OR-ed the
dependency.  lintian wants fontforge to be installed to satisfy the
dependency, and fontforge-nox | fontforge does not fulfil that
requirement, since the -nox branch could be taken.

Does fontforge-nox provide equivalent functionality to fontforge, at
least for scripts?  i.e. if a script has a #!/usr/bin/fontforge
shebang, will it work correctly whichever of fontforge or fontforge-nox
is installed?

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1330280428.27081.103.ca...@jacala.jungle.funky-badger.org

experimental tags (was: Re: Bug#658971: lintian: exits 1 without any policy violations/errors/warnings checking epoptes)

[Adam D. Barratt]

On Tue, 2012-02-07 at 01:53 +0100, Jakub Wilk wrote:
 Apparently this is because of this tag, which would be an error if it 
 weren't experimental:
[...]
 So it's probably a bug in lintian, which was latent until very recently, 
 because we hadn't tags with such property.

If you mean experimental tags, we've had at least for a few years now.

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1328595033.29555.19.ca...@jacala.jungle.funky-badger.org

[SCM] Debian package checker branch, master, updated. 2.5.4-145-gba65e5d

[Adam D. Barratt]

The following commit has been merged in the master branch:
commit ba65e5d455a7d8959c2bbce7620d4d6d8b94ac7c
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sat Feb 4 15:49:38 2012 +

lib/Lintian/Processable.pm: add missing word

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk

diff --git a/lib/Lintian/Processable.pm b/lib/Lintian/Processable.pm
index b5f4ebe..907b0f2 100644
--- a/lib/Lintian/Processable.pm
+++ b/lib/Lintian/Processable.pm
@@ -138,7 +138,7 @@ Lintian::Processable-mk_accessors (qw(group));
 
 Returns LLintian::Collect|$info element for this processable.
 
-Note: This method must implemented by sub-classes unless they
+Note: This method must be implemented by sub-classes unless they
 provide an info field.
 
 =cut

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1rtht9-0001vz...@vasks.debian.org

Re: Cron errors from lintian.d.o

[Adam D. Barratt]

On Thu, 2012-02-02 at 15:35 +0100, Niels Thykier wrote:
 Short story: Is it possible to receive the cron mails from lintian.d.o?
  If so, how?
[...]
 I decided to check up on our cron errors and currently there are a tons
 of cron mails in /var/mail/lintian (~4.8 MB worth).

The approach that at least some other services (release, buildd, qa)
take is to have a cron-errors@ alias, to which the crontab sets MAILTO.
lintian.d.o is explicitly declared not to have a mail service though, so
that won't work.

Probably the easiest solution would be to add a /home/lintian/.forward
and send the mails somewhere sensible.

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1328217354.26956.9.ca...@jacala.jungle.funky-badger.org

[SCM] Debian package checker branch, master, updated. 2.5.4-95-g11d32ed

[Adam D. Barratt]

The following commit has been merged in the master branch:
commit 11d32ed69ebe8af7e0ceaa2ae232e9babbe5c517
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Thu Jan 19 21:29:51 2012 +

Typo fix

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk

diff --git a/doc/lintian.xml b/doc/lintian.xml
index cf71bee..4f18efb 100644
--- a/doc/lintian.xml
+++ b/doc/lintian.xml
@@ -738,7 +738,7 @@ foo [!any-i386] binary: some-tag-not-for-i386 optional-extra
   to recognise them.
 /para
 para
-  The directories are checking in the listed order and the
+  The directories are checked in the listed order and the
   first file matching the profile will be used.  This allows
   users to override a system profile by putting one with the
   same filename

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1rnzyt-0002v4...@vasks.debian.org

Bug#654560: superfluous gzip-file-is-not-multi-arch-same-safe warnings

[Adam D. Barratt]

forcemerge 650665 654560
thanks

On 04.01.2012 09:31, Matthias Klose wrote:

Package: lintian

openjdk-6-jre-headless
E gzip-file-is-not-multi-arch-same-safe
usr/lib/jvm/java-6-openjdk-i386/jre/man/ja_JP.eucJP/man1/java.1.gz
usr/lib/jvm/java-6-openjdk-i386/jre/man/ja_JP.eucJP/man1/keytool.1.gz

lintian should not complain, if either the architecture or the
multiarch name is encoded in the path.


Already reported as #650665 and fixed in git.

Regards,

Adam



--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/8b645cb9eb8a12415cbb8785aca17...@mail.adsl.funky-badger.org

[SCM] Debian package checker branch, master, updated. 2.5.3-235-g2e3da6e

[Adam D. Barratt]

The following commit has been merged in the master branch:
commit 2e3da6eea6b4c23c3792b94b469989197aa041b6
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sun Nov 20 17:50:48 2011 +

Fix a couple of packages / package typoes

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk

diff --git a/checks/fields.desc b/checks/fields.desc
index bcaae8b..4f68c57 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -10,7 +10,7 @@ Tag: unsupported-source-format
 Severity: serious
 Certainty: certain
 Info: This package uses a different source package format than 1.0,
- 3.0 (quilt) or 3.0 (native). Other packages formats are supported by
+ 3.0 (quilt) or 3.0 (native). Other package formats are supported by
  dpkg-source, but they are not allowed in the Debian archive.
 
 Tag: no-package-name
@@ -1085,5 +1085,5 @@ Ref: #645438
 Info: The package appears to be a transitional package, but it is not
  priority extra and in the oldlibs section.
  .
- Using oldlibs/extra assists packages managers in handling the
+ Using oldlibs/extra assists package managers in handling the
  transition package correctly.

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1rsbzp-0002fx...@vasks.debian.org

Bug#649224: lintian: perl warnings

[Adam D. Barratt]

On Sat, 2011-11-19 at 00:36 +, Tony Houghton wrote:
 Use of qw(...) as parentheses is deprecated at
 /usr/share/lintian/collection/index line 192.
[...]
 Subroutine IO::Socket::INET6::sockaddr_in6 redefined at
 /usr/share/perl/5.14/Exporter.pm line 67.
  at /usr/share/perl5/IO/Socket/INET6.pm line 21
[...]
 They're a bit annoying because one needs to look out for warnings in lintian's
 output. The warning about sockaddr_in6 has already been reported in #648938 
 but
 I can't see any other reports about the qw warning yet.

This report already got merged with it, but fwiw you were looking for
649133, filed on Thursday.

(The issue was also fixed in git even before that first bug was filed).

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1321700311.23841.6.ca...@hathi.jungle.funky-badger.org

[SCM] Debian package checker branch, master, updated. 2.5.3-202-g8566b45

[Adam D. Barratt]

The following commit has been merged in the master branch:
commit 8566b452ab886193c5ec7e8d5fdb87d8613b93d1
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sat Nov 5 10:06:16 2011 +

Add squeeze to the list of acceptable Debian distributions

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk

diff --git a/data/changelog-file/debian-dists b/data/changelog-file/debian-dists
index af8030c..589df1c 100644
--- a/data/changelog-file/debian-dists
+++ b/data/changelog-file/debian-dists
@@ -3,6 +3,7 @@
 
 # Codenames
 lenny
+squeeze
 wheezy
 sid
 

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1rmd9p-0002ci...@vasks.debian.org

[SCM] Debian package checker branch, master, updated. 2.5.3-203-g7605161

[Adam D. Barratt]

The following commit has been merged in the master branch:
commit 76051619b8be8e02b8f8b05b3c566e3ec815f036
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sat Nov 5 10:08:23 2011 +

Typo fixes

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk

diff --git a/checks/cruft.desc b/checks/cruft.desc
index 7f41e2e..2093f72 100644
--- a/checks/cruft.desc
+++ b/checks/cruft.desc
@@ -26,9 +26,9 @@ Severity: normal
 Certainty: certain
 Info: This package has a native version number (a version number
  without a dash and a Debian portion) but is built as a non-native
- package.  Usually this is an error caused by forgetting the debian
- reivision for a non-native package.  In this case the solution is to
- add a debian revision.
+ package.  Usually this is an error caused by forgetting the Debian
+ revision for a non-native package.  In this case the solution is to
+ add a Debian revision.
  .
  This error can also happen if the package is a 1.0 source format and
  there is a stray tt*.orig.tar.gz/tt file in the parent directory.

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1rmdbi-0002xd...@vasks.debian.org

Bug#647551: lintian: lintian-info outputs extra EOL whitespaces in tag descriptions

[Adam D. Barratt]

On Thu, 2011-11-03 at 21:32 +0200, Jari Aalto wrote:
 There seems to be extra EOL whitespaces in output after each paragraph
 break.
[...]
 E: wv: binary-or-shlib-defines-rpath usr/bin/wvConvert 
 /usr/lib/x86_64-linux-gnu$
 N:$
 N:   The binary or shared library sets RPATH. This overrides the normal$
 N:   library search path, possibly interfering with local policy and$
 N:   causing problems for multilib, among other issues.$
 N:   $
 N:   The only time a binary or shared library in a Debian package should$

Indeed there does.  I have to ask though, why is this a problem in any
way?  What is processing lintian output in a way that's so sensitive to
the possible presence of such whitespace?

In fact, I'd argue that removing it would actually be wrong.  The entire
description is indented by three spaces and the paragraph breaks are
part of that description.

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1320351335.6262.16.ca...@hathi.jungle.funky-badger.org

Bug#647551: lintian: lintian-info outputs extra EOL whitespaces in tag descriptions

[Adam D. Barratt]

On Thu, 2011-11-03 at 22:27 +0200, jari wrote:
 On 2011-11-03 20:15, Adam D. Barratt wrote:
 | On Thu, 2011-11-03 at 21:32 +0200, Jari Aalto wrote:
 |  There seems to be extra EOL whitespaces in output after each paragraph
 |  break.
[...]
 | Indeed there does.  I have to ask though, why is this a problem in any
 | way?  What is processing lintian output in a way that's so sensitive to
 | the possible presence of such whitespace?
 | 
 | In fact, I'd argue that removing it would actually be wrong.  The entire
 | description is indented by three spaces and the paragraph breaks are
 | part of that description.
 
 In general, I believe the outputs should be clean and have no extra EOL
 whitespaces.
 
 E.g. Git version control by default refuses to inject code that
 contains EOL whitespace.

And people are actually feeding lintian-info output in to git verbatim?

 For that reason I have configured Emacs to use whitespace-mode
 globally; as it happens it also shows problematic outputs in M-x shell
 buffer as well with red colors (quite distracting actually).

That you have configured your editor in a way that makes lintian's
output annoying to you does not make that output incorrect, at least in
the opinion of this maintainer.  I haven't closed the bug yet, but I'm
very tempted to.

 I't a simple operation in Perl to fix:
 
 perl -e '$_ = this  \n  line\n   \n  \n; s/[ \t]+$//gsm; print'

Thank you for assuming that we couldn't have worked that trivial
operation out for ourselves. :-/  However, if you actually examine the
code, you'll find it's really not that simple.  You want to start at
Lintian::Tag::Info::description() and its call from lintian-info.

If you were to provide a patch that resolved the issue you perceive,
without affecting any other part of lintian, then I might be inclined to
apply it.  As it is, I don't believe this is an issue, nor that it's
fixable without effort that could be far better spent in other areas,
such as fixing some of the real bugs open against lintian.

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1320352655.6262.23.ca...@hathi.jungle.funky-badger.org

Bug#647551: lintian: lintian-info outputs extra EOL whitespaces in tag descriptions

[Adam D. Barratt]

On Thu, 2011-11-03 at 22:27 +0200, jari wrote:
 E.g. Git version control by default refuses to inject code that
 contains EOL whitespace.

Did that default change at some point?  From a commit I made less than a
week ago using squeeze's git:

foo$ PAGER=cat -A git show d330f501eada71ac3f2561c7e4d97a2313beccb6
commit d330f501eada71ac3f2561c7e4d97a2313beccb6$
Author: Adam D. Barratt a...@adam-barratt.org.uk$
Date:   Sat Oct 29 17:33:26 2011 +$
$
scripts/TEMPLATE.wml: add an end-of-line whitespace to aid wrapping$
$
Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk$
$
diff --git a/scripts/TEMPLATE.wml b/scripts/TEMPLATE.wml$
index ee9e8d4..626a8ae 100644$
--- a/scripts/TEMPLATE.wml$
+++ b/scripts/TEMPLATE.wml$
@@ -30,7 +30,7 @@$
[...]
-$SUITE$ distribution Debian $VERSION$ (codename qcodename/q).$
+$SUITE$ distribution Debian $VERSION$ (codename qcodename/q). $

My .gitconfig on the machine in question just contains identity
information.

(and fwiw I note that the generated git log output contains a line
containing what could be classed as extra EOL whitespaces...)

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1320354618.1512.5.ca...@hathi.jungle.funky-badger.org

Re: ITM: Please review lab-refactor branch

[Adam D. Barratt]

On Thu, 2011-10-27 at 21:52 +0200, Niels Thykier wrote:
 The major part of the development in the lab-refactor branch should be
 done now, so I intend to merge it into master.  The branch has touched
 major parts of Lintian and breaks a lot of stuff.  Obviously, I would
 like a thorough review of it before I hit merge - particuarly of
 reporting/* as we have no test-suite coverage here.
 
 I would like to see the merge done some time next week followed by an
 upload.  However if you would like more time to review the branch,
 please let me know how long you need.

I started having a look over the branch at the weekend; unfortunately a
combination of being busy with other (mostly work-related) stuff and not
feeling great means it hasn't been as useful as I'd hoped so far.
Nevertheless I thought it was worth recording my thoughts so far.

* As discussed on IRC, it may be worth considering whether we want to
s/lab_// in a number of method names.

* How much of reporting/ has been tested with the new lab code?  I
realise we don't have formal test coverage for it but from memory
getting a minimal setup working is fairly simple.

* I noticed there's code intended for v10 lab format backward
compatibility.  Given that the patch also updates the lab format, how
much has that compatibility code been tested?

* Finally whilst having an initial run through the code I made a number
of tweaks and reminder comments, mostly related to documentation.  I'm
afraid it's not nicely split up but I've attached a copy of the changes
in the hope that they're useful.

Regards,

Adam
diff --git a/lib/Lintian/Lab.pm b/lib/Lintian/Lab.pm
index 62d8b85..db34abd 100644
--- a/lib/Lintian/Lab.pm
+++ b/lib/Lintian/Lab.pm
@@ -160,7 +160,8 @@ non-empty value from this method.
 
 Returns a truth value if this lab is open.
 
-Note: This does not imply that the underlying does not exists.
+XXX: What is this trying to say?
+Note: This does not imply that the underlying lab does not exist.
 
 =cut
 
@@ -191,11 +192,11 @@ sub lab_exists {
 
 Fetches an existing package from the lab.
 
-First argument can be a LLintian::Processable|proccessable.  In that
+The first argument can be a LLintian::Processable|proccessable.  In that
 case all other arguments are ignored.
 
 If the first calling convention is used then this method will by
-default search for an existing package.  The @extra argument cna be
+default search for an existing package.  The @extra argument can be
 used to narrow the search or even to add a new entry.
 
 @extra consists of (in order):
@@ -218,7 +219,7 @@ consider a wildcard for any.  Example:
 
 
 If all 3 @extra arguments are given, then the entry will be created if
-it does not exists.
+it does not exist.
 
 In list context, this returns a list of matches.  In scalar context
 this returns the first match (if any).
@@ -296,8 +297,8 @@ sub get_package {
 
 =item $lab-visit_packages ($visitor[, $pkg_type])
 
-Passes each lab entry to visitor.  If $pkg_type is passed, then only
-entries of that time is passed.
+Passes each lab entry to $visitor.  If $pkg_type is passed, then only
+entries of that type are passed.
 
 =cut
 
@@ -341,13 +342,13 @@ sub _get_lab_manifest_data {
 $index-visit_all ($searcher, $pkg_name, @keys);
 return $result[0] if @result;
 }
-# Nothing so far, then it does not exists
+# Nothing so far, then it does not exist
 return;
 }
 
 # Returns the index of packages in the lab of a given type (of packages).
 #
-# Unlike $lab-_load_lab_index, this uses the cache'd version if it is
+# Unlike $lab-_load_lab_index, this uses the cached version if it is
 # available.
 #
 # Note this is also used by reporting/html_reports
@@ -358,7 +359,7 @@ sub _get_lab_index {
 return $self-{'state'}-{$pkg_type} // $self-_load_lab_index ($pkg_type);
 }
 
-# Unconditionally (Re-)loads the index of packages in the lab of a
+# Unconditionally (re-)loads the index of packages in the lab of a
 # given type (of packages).
 #
 # $lab-_get_lab_index is generally faster since it uses the cache if
@@ -374,7 +375,7 @@ sub _load_lab_index {
 }
 
 # Given the package meta data (name, type, version, arch) return the
-# path to it in the Lab.  Path returned will be absolute.
+# path to it in the Lab.  The path returned will be absolute.
 sub _pool_path {
 my ($self, $pkg_name, $pkg_type, $pkg_version, $pkg_arch) = @_;
 my $dir = $self-dir;
@@ -426,8 +427,8 @@ sub generate_diffs {
 
 =item $lab-create_lab ([$opts])
 
-Creates a new lab.  It will create $lab-dir if it does not exists.
-It will also create a basic lab empty lab.  If this is a temporary
+Creates a new lab.  It will create $lab-dir if it does not exist.
+It will also create a basic empty lab.  If this is a temporary
 lab, this method will also setup the temporary dir for the lab.
 
 B$opts (if present) is a hashref containing options.  The following
@@ -449,10 +450,10 @@ Will default to 0777 if not specified.
 =back
 
 Note: This will not 

[SCM] Debian package checker branch, lab-refactor, updated. 2.5.3-180-ge312ee6

[Adam D. Barratt]

The following commit has been merged in the lab-refactor branch:
commit e312ee68ebf4b8330e2d2ca4925d2ac5acbbfa85
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Tue Nov 1 07:18:50 2011 +

Typo fix

Signed-off-by: Adam D. Barratt a...@adam-barratt.org.uk

diff --git a/lib/Lintian/Lab.pm b/lib/Lintian/Lab.pm
index 9fd0f1b..f401a92 100644
--- a/lib/Lintian/Lab.pm
+++ b/lib/Lintian/Lab.pm
@@ -161,7 +161,7 @@ non-empty value from this method.
 Returns a truth value if this lab is open.
 
 Note: If the lab is open, it also exists.  However, if the lab is
-closed then the lab may or may not exists (see L/lab_exists).
+closed then the lab may or may not exist (see L/lab_exists).
 
 =cut
 

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1rl8dg-0007qs...@vasks.debian.org

Bug#642833: [checks/source-copyright] use Config::Model

[Adam D. Barratt]

On Mon, 2011-09-26 at 09:18 +0300, jari wrote:
 On 2011-09-25 20:17, Jakub Wilk wrote:
 | * jari jari.aa...@cante.net, 2011-09-25, 15:19:
 | |   run config-edit -application dpkg-copyright -ui none
 |
[...]
 | I don't see anything[0] wrong with the copyright file you attached,
 
 It is just that config-edit displayd the error, which didn't show up
 in lintian.

Which might mean that config-edit is wrong.  Tool X displays a
warning/error that tool Y does not in no way implies that tool X is
correct, or that if it is then the correct manner of fixing tool Y is to
simply have it call tool X.

[...]
 | Care to explain us why Config::Model complains?
 
 Not Config::Model, but config-edit, Lintian does not display messages
 for the sample file.

Pedantry doesn't help.  In any case, you didn't answer the question -
*why* is the message being output?

 | [0] Except that you shouldn't use X-prefixed fields. But that's not
 | a syntax error.
 
 Not quite. Apart from being useful to record additional information
 about the upstream Vcs, bug contact URL etc, the extra fields are part
 of the DEP 5 spec as it was modeled after RFC 822/2822. From DEP 5:
 
 http://dep.debian.net/deps/dep5
 
 FILE SYNTAX
 
 (...) Extra fields can be added to any paragraph. No prefixing is
 necessary or desired, but please avoid names similar to standard
 ones so that mistakes are easier to catch.

No prefixing is necessary or desired means you can use extra fields
but just call them 'foo', not 'X-foo' or 'dep5-foo'.  That's not really
an argument in favour of your case; if anything, it's the reverse.

 See also how DEP 5 work was carried forwad:
 
 http://anonscm.debian.org/viewvc/dep/web/deps/dep5.mdwn?revision=100
 
 Extra fields can be added to any section. Their name starts by **`X-`

That revision is two years old, as can be seen from the text.  The
version you initially quoted is far more current and, as per your own
quote above, indicates that X- should *not* be used - things change
and specifications evolve.

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1317032414.2091.202.ca...@hathi.jungle.funky-badger.org

Bug#642902: lintian: source filenames don't have unpack path stripped when checking overrides

[Adam D. Barratt]

On Sun, 2011-09-25 at 14:51 +0200, Stefano Rivera wrote:
 P: re2 source: source-contains-svn-conflict-file 
 /tmp/s7W6UeV63q/source/re2/0+hg68+dfsg-1/source/unpacked/benchlog/benchlog.r70
 I: re2 source: unused-override source-contains-svn-conflict-file 
 benchlog/benchlog.r70
 
 It can be worked-around with a wildcard, though:
 re2 source: source-contains-svn-conflict-file */benchlog/benchlog.r70

Does this occur with other tags?  It looks like a symptom of a problem
with the checks from the cruft script, which was fixed recently (but
not yet released), in 890284d.

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1316968556.2091.193.ca...@hathi.jungle.funky-badger.org

Bug#642255: lintian does not handle AGPL license

[Adam D. Barratt]

On Wed, 2011-09-21 at 01:17 +0530, Ritesh Raj Sarraf wrote:
 I am working on packaging configshell which is licensed under the AGPL-3
 license.
 
 This license does not seem to be covered by lintian.

How should lintian cover it?  As it's not in common-licenses, and
isn't considered deprecated or problematic in any of the other ways
which lintian reports issues in licenses there doesn't seem to be
anything to cover.

 I get the following error when running lintian.

 E: python-configshell: copyright-should-refer-to-common-license-file-for-gpl

This, otoh, is indeed a false positive.  My suspicion is that it's
caused by the full text of AGPL3 including the text

The GNU General Public License permits

which matches the regular expression used by lintian to detect the GPL
and needs tightening.

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1316551879.8194.33.ca...@hathi.jungle.funky-badger.org

Re: [SCM] Debian package checker branch, squeeze, updated. 2.4.3-3-g8a6f168

[Adam D. Barratt]

On Sat, 2011-09-10 at 12:45 +, Niels Thykier wrote:
 The following commit has been merged in the squeeze branch:
 commit 9bcbd856565b71a926187e1357661ffe0a552967
 Author: Niels Thykier ni...@thykier.net
 Date:   Wed Aug 17 15:30:33 2011 +0200
[...]
 Conflicts:
 
   checks/conffiles
   debian/changelog

Anything to worry about?

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1315767254.3482.15.ca...@hathi.jungle.funky-badger.org

Bug#639292: lintian: --color=html does not close 'p' - breaks xhtml (lintian.d.o)

[Adam D. Barratt]

On Thu, 2011-08-25 at 19:15 +0200, Niels Thykier wrote:
 Notice how none of the p tags are closed; given xhtml is
 xml-based, all tags must be closed or the document will be malformed.
[...]
   push(@o,p$_\n);
 [...]
 
 becomes
 
 [...]
   push(@o,p$_/p\n);
 [...]
 but I do not fully understand the code there.

It's a fairly uncomplicated function, other than keeping track of
whether we're trying to display literal text - e.g the two examples on
http://lintian.debian.org/tags/binary-or-shlib-defines-rpath.html - and
your change looks sane enough to me, fwiw.

While we're on the subject of that page, it would be nice to do
something about the pre - p spacing, as at least in Iceweasel here
there's a large gap after each of the gcc lines.

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1314299724.9041.10.ca...@hathi.jungle.funky-badger.org

Re: Is lintian.postrm still useful?

[Adam D. Barratt]

On Sat, 2011-08-06 at 14:32 +0200, Niels Thykier wrote:
 I had a look at our maintainer scripts and looking at postrm, I am
 thinking this might be some legacy code.  Does anyone know when Lintian
 last deployed a default lab in /var/spool/lintian ?

I'm not sure that it's a case of deploying a default lab, rather
clearing up any static labs that were created whilst the package was
installed; I think the comment in the postrm means default lab
location, particularly given the content of the remainder of the
comment.

fwiw, it only became the postrm in 2008.  Previously the code was in
prerm but wasn't working (see #489860).

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1312638595.31497.14.ca...@hathi.jungle.funky-badger.org

Re: Updating lintian.debian.org

[Adam D. Barratt]

On Thu, 2011-07-14 at 11:11 -0700, Russ Allbery wrote:
 I just updated the version of Lintian on lintian.debian.org to 2.5.1 and
 am doing a new full run, since there were a bunch of false positives with
 the older version that we should clear out.  This will take a couple of
 days.

Thanks!

 We should get more people in the lintian group, particularly while my day
 job is sucking up so much of my time, so that other people can do this
 update as well.  Volunteers?

*raises hand*

I know I've not been the most active on the team recently, but I've also
grumbled in the past about not being able to fix stuck groff processes
and similar issues, and having to wait until someone with the magic gid
(which recently has mostly meant you) can poke things, so I can't really
turn down the possibility. :-)

 And what sort of documentation do folks need
 on how to go about it?  The README file in /org/lintian.debian.org should
 be relatively complete.

It looks reasonably comprehensive, certainly.

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1310669758.21827.7.ca...@hathi.jungle.funky-badger.org

Bug#633887: lintian: Perl warnings from reporting/harness -f

[Adam D. Barratt]

On Thu, 2011-07-14 at 11:22 -0700, Russ Allbery wrote:
 This may already be fixed with the work that was done on master; if so,
 feel free to close.
 
 Running reporting/harness -f on lintian.debian.org with 2.5.1 produced the
 following Perl warnings:
 
 Use of uninitialized value $ENV{LINTIAN_ROOT} in concatenation (.) or 
 string at /org/lintian.debian.org/root/lib/Read_pkglists.pm line 25.

Hmmm.  That's

use lib $ENV{'LINTIAN_ROOT'}/lib;

That statement is no longer in Read_pkglists.pm, but reporting/harness
should be setting $LINTIAN_ROOT in any case, so I'm intrigued as to
what's going on here.

 Use of uninitialized value in numeric eq (==) at 
 /org/lintian.debian.org/root/unpack/list-srcpkg line 140, IN line 746.
 Use of uninitialized value in numeric eq (==) at 
 /org/lintian.debian.org/root/unpack/list-srcpkg line 140, IN line 7558.

These are both:

  if ($timestamp == $data-{'timestamp'}) {

$timestamp is determined by stat()ing the .dsc, so I assume it's the %
data reference which is failing.  That implies that the previous version
of the package list included a record for the source package but with no
timestamp, which also doesn't sound right.

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1310670399.21827.15.ca...@hathi.jungle.funky-badger.org

[SCM] Debian package checker branch, master, updated. 2.5.1-19-g6653521

[Adam D. Barratt]

The following commit has been merged in the master branch:
commit 665352168fde63420e2fc88733db414d223ba736
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sun Jun 26 12:00:28 2011 +0100

Fix a typo in the changelog. (reporty)

diff --git a/debian/changelog b/debian/changelog
index fc34d18..d478b80 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -14,7 +14,7 @@ lintian (2.5.2) UNRELEASED; urgency=low
 + [NT] Stricten one of the regexes for catching left over
   helper templates.  This should prevent false-positives for
   some license texts.  Thanks to Charles Plessy for the
-  reporty.  (Closes: #631674)
+  report.  (Closes: #631674)
   * checks/debhelper:
 + [NT] Do not trigger deprecation warning for dh_python if it
   is followed by a $.  This prevents false-positives when

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1qan5q-0008iz...@vasks.debian.org

[SCM] Debian package checker branch, master, updated. 2.5.0-45-gf463de1

[Adam D. Barratt]

The following commit has been merged in the master branch:
commit 4fdcc8fe6cb7437e263f6fa796be1382a35a436b
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sat Jun 11 08:08:23 2011 +0100

checks/md5sums.desc: Drop references to debstd

* checks/md5sums.desc:
  + [ADB] Drop references to obsolete debstd.  Thanks to Steve Langasek
for the pointer.

diff --git a/checks/md5sums.desc b/checks/md5sums.desc
index b4409ab..6510444 100644
--- a/checks/md5sums.desc
+++ b/checks/md5sums.desc
@@ -34,8 +34,8 @@ Info: The md5sum listed for the file does not match the 
actual file
  contents.
  .
  Usually, this error occurs during the package build process, if the
- ttdebian/tmp//tt directory is touched after ttdh_md5sums/tt or
- ttdebstd/tt is run.
+ ttdebian/tmp//tt directory is touched after ttdh_md5sums/tt
+ is run.
 
 Tag: md5sums-lists-nonexisting-file
 Severity: important
@@ -44,13 +44,8 @@ Info: The md5sums control file lists a file which is not 
included in the
  package.
  .
  Usually, this error occurs during the package build process, if the
- ttdebian/tmp//tt directory is touched after ttdh_md5sums/tt or
- ttdebstd/tt is run.
- .
- If all the files in the ttDEBIAN//tt subdirectory are listed
- above, the problem was probably caused by building the package using a
- buggy debstd/debmake. In this case, rebuilding the package with an
- updated debstd should fix the problem.
+ ttdebian/tmp//tt directory is touched after ttdh_md5sums/tt
+ is run.
 
 Tag: file-missing-in-md5sums
 Severity: normal
@@ -59,5 +54,5 @@ Info: The package contains a file which isn't listed in the 
md5sums control
  file.
  .
  Usually, this error occurs during the package build process, if the
- ttdebian/tmp//tt directory is touched after ttdh_md5sums/tt or
- ttdebstd/tt is run.
+ ttdebian/tmp//tt directory is touched after ttdh_md5sums/tt
+ is run.
diff --git a/debian/changelog b/debian/changelog
index a79fd91..12f96ec 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -46,6 +46,9 @@ lintian (2.5.1) UNRELEASED; urgency=low
   a file or a symlink in the package itself, then it is also okay.
 + [NT] Allow maven plugins to be without classpaths.
   (Closes: #629056)
+  * checks/md5sums.desc:
++ [ADB] Drop references to obsolete debstd.  Thanks to Steve Langasek
+  for the pointer.
   * checks/rules:
 + [NT] Removed code for handling packages with dh_python.
 + [NT] Fixed the code for determining Build-Depends for python

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1qvikn-0003yg...@vasks.debian.org

[SCM] Debian package checker branch, master, updated. 2.5.0-45-gf463de1

[Adam D. Barratt]

The following commit has been merged in the master branch:
commit f463de1443b015c0187a4f6d1167f1b142a40380
Author: Adam D. Barratt a...@adam-barratt.org.uk
Date:   Sat Jun 11 08:09:55 2011 +0100

checks/manpages.desc: stop suggesting referring to debmake's output

* checks/manpages.desc:
  + [ADB] Don't suggest using debmake's output as a reference.  The
package is not even in oldstable any more.

diff --git a/checks/manpages.desc b/checks/manpages.desc
index 4b7719c..e9106c3 100644
--- a/checks/manpages.desc
+++ b/checks/manpages.desc
@@ -25,7 +25,7 @@ Info: Symbolic links to the undocumented(7) manual page may 
be provided
  .
  For help with writing manual pages, refer to the Man-Page-HOWTO at
  http://www.schweikhardt.net/man_page_howto.html, the examples created
- by ttdebmake/tt or ttdh_make/tt, or the
+ by ttdh_make/tt, or the
  tt/usr/share/doc/man-db/examples/tt directory.
  If the package provides tt--help/tt output, you might want to use
  the tthelp2man/tt utility to generate a simple manual page.
diff --git a/debian/changelog b/debian/changelog
index 12f96ec..49fea2f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -46,6 +46,9 @@ lintian (2.5.1) UNRELEASED; urgency=low
   a file or a symlink in the package itself, then it is also okay.
 + [NT] Allow maven plugins to be without classpaths.
   (Closes: #629056)
+  * checks/manpages.desc:
++ [ADB] Don't suggest using debmake's output as a reference.  The
+  package is not even in oldstable any more.
   * checks/md5sums.desc:
 + [ADB] Drop references to obsolete debstd.  Thanks to Steve Langasek
   for the pointer.

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1qviko-0003za...@vasks.debian.org

Bug#629648: lintian: missing-pre-dependency-on-multiarch-support FP for -dev packages

[Adam D. Barratt]

On Wed, 2011-06-08 at 10:39 -0700, Steve Langasek wrote:
 On Wed, Jun 08, 2011 at 06:11:08PM +0100, Simon McVittie wrote:
  Possibly... either way, lintian and debhelper should be consistent about
  what they consider to be a good enough reason to pre-depend (this could
  become a debhelper bug if you prefer?).
 
 right, so debhelper's check is:
 
   find $tmp -type f \( -name '*.so' -or -name '*.so.*' \)
 
 thus matching any *.so* real files at all in the multiarch dir.
 
 That would indeed be a better check to have in lintian also.  I probably
 didn't think of it when writing the lintian check because I didn't see an
 obvious way to check if a file was a symlink.

In the context of the surrounding code in checks/files,
$index_info-{type} == 'l' should do the trick.  (I note that most of
the other checks seem to do partial matching via regexes, but I think
that's a hangover from when it used to parse the index file directly;
Lintian::Collect::Binary::index() extracts a single character for
type).

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1307562345.14057.32.ca...@hathi.jungle.funky-badger.org

Bug#629453: lintian: --checksums does not do anything

[Adam D. Barratt]

On Mon, 2011-06-06 at 22:13 +0200, Niels Thykier wrote:
 ... and by the looks of it; it did not do anything in the 2.4.3
 release either.  I checked the $check_checksums variable in frontend/lintian
 in 2.4.3 and a modified local branch based on 2.5.0; none of them ever
 reads the variable (although they both pass it to GetOptions).

The front-end doesn't use it indeed, but:

./checks/changes-file:our $CHECK_CHECKSUMS = $main::check_checksums;
[...]
./checks/changes-file:  if ($CHECK_CHECKSUMS or $file =~ m/\.dsc$/o) {

It's possible that I broke this when splitting out the .changes parsing
stuff; we certainly don't appear to have a test for it. :-/  It's
trivial to fix, though - $check_checksums in the frontend needs to be
declared our, so that the check script can access it.

 Question is; should we re-instate it or deprecate it?  A little manual test
 suggests that currently is on by default making the option redundant.

Really?  My testing suggests precisely the opposite.  With the current code:

adam@hathi:~/code/debian/packages/lintian$ LINTIAN_ROOT=. frontend/lintian 
changes-foo-bar-moo.changes 
adam@hathi:~/code/debian/packages/lintian$ LINTIAN_ROOT=. frontend/lintian 
--checksums changes-foo-bar-moo.changes 

After applying the above fix:

adam@hathi:~/code/debian/packages/lintian$ LINTIAN_ROOT=. frontend/lintian 
changes-foo-bar-moo.changes 
adam@hathi:~/code/debian/packages/lintian$ LINTIAN_ROOT=. frontend/lintian 
--checksums changes-foo-bar-moo.changes 
E: changes-foo-bar-moo changes: checksum-mismatch-in-changes-file md5 
foo-bar-moo

Note that the option *only* controls whether the checksums of .changes
files are verified; the checks always occur for .dscs.

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1307394749.14074.11.ca...@hathi.jungle.funky-badger.org