[GitHub] activemq-artemis issue #1999: ARTEMIS-1790 Improve Topology Member Finding

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1999
  
@clebertsuconic @stanlyDoge done.


---

[GitHub] activemq-artemis issue #1999: ARTEMIS-1790 Improve Topology Member Finding

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1999
  
ok I'll take care of them.


---

[GitHub] activemq-artemis pull request #1999: ARTEMIS-1790 Improve Topology Member Fi...

[gaohoward]

Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1999#discussion_r180614044
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
 ---
@@ -511,6 +511,45 @@ public final boolean isUsingProtocolHandling() {
   return true;
}
 
+   @Override
+   public boolean isSameTarget(TransportConfiguration... configs) {
+  boolean yes = false;
--- End diff --

alright. :)



---

[GitHub] activemq-artemis pull request #2009: ARTEMIS-1800 - Fix metrics decrement on...

[cshannon]

GitHub user cshannon opened a pull request:

https://github.com/apache/activemq-artemis/pull/2009

ARTEMIS-1800 - Fix metrics decrement on scheduled message cancel

The queue metrics were being decremented improperly because on iteration
over the cancelled scheduled messages because the flag for 
fromMessageReferences was not
set to false. Setting the flag to false skips over the metrics update
which is what we want as the scheduled messages were never added to the
message references in the first place so the metrics don't need updating

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1800

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2009.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2009


commit 70f0908b4ee64e68059a21009db9dd3236c26732
Author: Christopher L. Shannon (cshannon) 
Date:   2018-04-10T19:54:29Z

ARTEMIS-1800 - Fix metrics decrement on scheduled message cancel

The queue metrics were being decremented improperly because on iteration
over the cancelled scheduled messages because the flag for 
fromMessageReferences was not
set to false. Setting the flag to false skips over the metrics update
which is what we want as the scheduled messages were never added to the
message references in the first place so the metrics don't need updating




---

[GitHub] activemq pull request #281: AMQ-6930 Expose an environment variable to allow...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq/pull/281


---

Re: Board report for April 2018

[Bruce Snyder]

Thank you, Justin!

Bruce

On Tue, Apr 10, 2018 at 10:06 AM, Justin Bertram 
wrote:

> I added the Artemis 2.5.0 release including some highlighted features from
> that release. I hope the level-of-detail was appropriate. Please adjust if
> necessary. Thanks!
>
>
> Justin
>
> On Tue, Apr 10, 2018 at 10:22 AM, Bruce Snyder 
> wrote:
>
> > I am getting rather desperate to have someone describe the project
> activity
> > for ActiveMQ, Artemis as well as NMS, CMS, etc.
> >
> > if you work on the project, can you please contribute to the April board
> > report via the wiki?
> >
> > https://cwiki.apache.org/confluence/pages/viewpage.
> action?pageId=75977784
> >
> > Your time is much appreciated. If I could buy you a virtual beer I would
> do
> > so ;-).
> >
> > Bruce
> >
> > On Tue, Apr 10, 2018 at 9:21 AM, Bruce Snyder 
> > wrote:
> >
> > > Hi Michael,
> > >
> > > I have granted you r/w permissions to the wiki, so you should be able
> to
> > > edit the page now.
> > >
> > > Bruce
> > >
> > > On Mon, Apr 9, 2018 at 1:45 PM, Michael André Pearce <
> > > michael.andre.pea...@me.com> wrote:
> > >
> > >> Hi Bruce,
> > >>
> > >> It seems same issue as last time, i don’t have rights to edit
> directly.
> > >>
> > >> Can you check the space permissions for my user: michael.andre.pearce
> > >>
> > >>
> > >> Bits i would add / comment on are:
> > >>
> > >> Artemis released 2.5.0
> > >> Effort to create updated website continues but slowly, a webex was had
> > >> last month to try get more traction on this.
> > >> A number of new contributors in Artemis who are not just one offs, but
> > >> continue to actively contribute, a sign of adoption increasing.
> > >>
> > >>
> > >> Cheers
> > >> Mike
> > >>
> > >>
> > >> > On 9 Apr 2018, at 16:37, Bruce Snyder 
> wrote:
> > >> >
> > >> > Happy Monday morning!
> > >> >
> > >> > The board report for April has not received any contributions yet
> and
> > I
> > >> > must submit it by Wednesday, April 11th.
> > >> >
> > >> > The report needs information on project activity for the following
> > three
> > >> > categories:
> > >> >
> > >> > * ActiveMQ
> > >> > * Artemis
> > >> > * Other
> > >> >
> > >> > If you can contribute any information about the project development
> > for
> > >> > these three areas, can you please add it to the board report right
> > away?
> > >> >
> > >> > Bruce
> > >> >
> > >> > On Wed, Apr 4, 2018 at 5:10 PM, Bruce Snyder <
> bruce.sny...@gmail.com>
> > >> wrote:
> > >> >
> > >> >> I am following up again to request your contribution to the ASF
> board
> > >> >> report for April. The deadline to contribute is April 11th.
> > >> >>
> > >> >> If you are contributing code to any modules within the ActiveMQ
> > >> project,
> > >> >> please take a few moments to edit the following wiki page to report
> > on
> > >> the
> > >> >> activity that has taken place over the last two months:
> > >> >>
> > >> >> https://cwiki.apache.org/confluence/pages/viewpage.action?
> > >> pageId=75977784
> > >> >>
> > >> >> Thank you!
> > >> >>
> > >> >> Bruce
> > >> >>
> > >> >> On Thu, Mar 29, 2018 at 9:30 PM, Bruce Snyder <
> > bruce.sny...@gmail.com>
> > >> >> wrote:
> > >> >>
> > >> >>> It is time once again to submit a report to the ASF board for
> April.
> > >> >>> Please take 5 minutes to contribute some of the project activity
> to
> > >> the
> > >> >>> report at the wiki page below:
> > >> >>>
> > >> >>> https://cwiki.apache.org/confluence/pages/viewpage.action?
> > >> pageId=75977784
> > >> >>>
> > >> >>> This report must be submitted by April 11th.
> > >> >>>
> > >> >>> I really appreciate your contributions!
> > >> >>>
> > >> >>> Bruce
> > >> >>>
> > >> >>> --
> > >> >>> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> > >> >>> 5R\"F)R=6-E+G-N>61E > >> >>>
> > >> >>> ActiveMQ in Action: http://bit.ly/2je6cQ
> > >> >>> Blog: http://bsnyder.org/ 
> > >> >>> Twitter: http://twitter.com/brucesnyder
> > >> >>>
> > >> >>
> > >> >>
> > >> >>
> > >> >> --
> > >> >> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> > >> >> 5R\"F)R=6-E+G-N>61E > >> >>
> > >> >> ActiveMQ in Action: http://bit.ly/2je6cQ
> > >> >> Blog: http://bsnyder.org/ 
> > >> >> Twitter: http://twitter.com/brucesnyder
> > >> >>
> > >> >
> > >> >
> > >> >
> > >> > --
> > >> > perl -e 'print
> > >> > unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E "YC;VT*"
> > >> );'
> > >> >
> > >> > ActiveMQ in Action: http://bit.ly/2je6cQ
> > >> > Blog: http://bsnyder.org/ 
> > >> > Twitter: http://twitter.com/brucesnyder
> > >>
> > >>
> > >
> > >
> > > --
> > > perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> > > 5R\"F)R=6-E+G-N>61E > >
> > > ActiveMQ in Action: http://bit.ly/2je6cQ
> > > Blog: http://bsnyder.org/ 
> > > Twitter: http://twitter.com/brucesnyder
> 

[GitHub] activemq-artemis pull request #2008: ARTEMIS-1800 - fix duplicate metrics up...

[cshannon]

Github user cshannon closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2008


---

[GitHub] activemq-artemis pull request #2008: ARTEMIS-1800 - fix duplicate metrics up...

[cshannon]

GitHub user cshannon opened a pull request:

https://github.com/apache/activemq-artemis/pull/2008

ARTEMIS-1800 - fix duplicate metrics update on scheduled message cancel

When removing scheduled messages from a queue the scheduled message
metrics were being decremented twice

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1800

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2008.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2008


commit 122782ae460a789c883beb21bfccb80089d9bb59
Author: Christopher L. Shannon (cshannon) 
Date:   2018-04-10T19:06:28Z

ARTEMIS-1800 - fix duplicate metrics update on scheduled message cancel

When removing scheduled messages from a queue the scheduled message
metrics were being decremented twice




---

[GitHub] activemq pull request #281: AMQ-6930 Expose an environment variable to allow...

[alvinlin123]

GitHub user alvinlin123 opened a pull request:

https://github.com/apache/activemq/pull/281

AMQ-6930 Expose an environment variable to allow redirect stdout/stderr to 
a file

This change does not modify the default behavior, the default behavior is 
still to pipe stdout/stderr to /dev/null. User can specify a file using an 
environment variable called `ACTIVEMQ_OUT` to  redirect stdout/stderr to the 
file. 

This change also added and fixed some tests in 
`assembly/src/test/scripts/init-script-testsuite`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alvinlin123/activemq amq-6930

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq/pull/281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #281


commit f3a8e882068803a3cdab338d3544b27a7808e0cc
Author: Alvin Lin 
Date:   2018-04-09T23:53:44Z

AMQ-6930 provide options to allow stdout/stderr of activemq process to be 
redirect to a file using append mode

commit 6bb56decf881328f5595692ca17c1899f7f86a7b
Author: Alvin Lin 
Date:   2018-04-10T02:04:55Z

AMQ-6930 add test case




---

[GitHub] activemq-artemis pull request #2005: ARTEMIS-1797 Auto-create-address flag s...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2005


---

[GitHub] activemq-artemis issue #2005: ARTEMIS-1797 Auto-create-address flag shouldn'...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2005
  
I will merge it .. but I will rename the commit message.


---

[GitHub] activemq-artemis issue #1999: ARTEMIS-1790 Improve Topology Member Finding

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1999
  
only issue I see is.. if this is broken.. then 
Topology::getMember(TransportConfiguration) is probably broken as well? That's 
used on freezeConnections and ScaleDownHandler

any chance you can fix it?


---

[GitHub] activemq-artemis pull request #1999: ARTEMIS-1790 Improve Topology Member Fi...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1999#discussion_r180507233
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
 ---
@@ -511,6 +511,45 @@ public final boolean isUsingProtocolHandling() {
   return true;
}
 
+   @Override
+   public boolean isSameTarget(TransportConfiguration... configs) {
+  boolean yes = false;
--- End diff --

@gaohoward  can you rename it from yes? :)

call it result if you like :)


---

[GitHub] activemq-artemis pull request #2006: ARTEMIS-1798 DEBUG message bad write me...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2006


---

[GitHub] activemq-artemis issue #2005: ARTEMIS-1797 Auto-create-address flag shouldn'...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2005
  
@gaohoward by block did you mean avoid? When you say block I was expecting 
a client blocking or not completing.


---

[GitHub] activemq-artemis pull request #2006: ARTEMIS-1798 DEBUG message bad write me...

[jdanekrh]

Github user jdanekrh commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2006#discussion_r180483597
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java
 ---
@@ -84,6 +85,10 @@
 import org.apache.activemq.util.LongSequenceGenerator;
 
 public class OpenWireProtocolManager implements 
ProtocolManager, ClusterTopologyListener {
+   static {
+  // this is not really a property, needs to be ignored
+  
FluentPropertyBeanIntrospectorWithIgnores.addIgnore(OpenWireProtocolManager.class.getName(),
 "setUpInactivityParams");
--- End diff --

@stanlyDoge told you so ))


---

[GitHub] activemq-artemis issue #2007: ARTEMIS-1799 - Add a NotificationActiveMQServe...

[cshannon]

Github user cshannon commented on the issue:

https://github.com/apache/activemq-artemis/pull/2007
  
@clebertsuconic - thanks for merging 


---

Re: Board report for April 2018

[Justin Bertram]

I added the Artemis 2.5.0 release including some highlighted features from
that release. I hope the level-of-detail was appropriate. Please adjust if
necessary. Thanks!


Justin

On Tue, Apr 10, 2018 at 10:22 AM, Bruce Snyder 
wrote:

> I am getting rather desperate to have someone describe the project activity
> for ActiveMQ, Artemis as well as NMS, CMS, etc.
>
> if you work on the project, can you please contribute to the April board
> report via the wiki?
>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75977784
>
> Your time is much appreciated. If I could buy you a virtual beer I would do
> so ;-).
>
> Bruce
>
> On Tue, Apr 10, 2018 at 9:21 AM, Bruce Snyder 
> wrote:
>
> > Hi Michael,
> >
> > I have granted you r/w permissions to the wiki, so you should be able to
> > edit the page now.
> >
> > Bruce
> >
> > On Mon, Apr 9, 2018 at 1:45 PM, Michael André Pearce <
> > michael.andre.pea...@me.com> wrote:
> >
> >> Hi Bruce,
> >>
> >> It seems same issue as last time, i don’t have rights to edit directly.
> >>
> >> Can you check the space permissions for my user: michael.andre.pearce
> >>
> >>
> >> Bits i would add / comment on are:
> >>
> >> Artemis released 2.5.0
> >> Effort to create updated website continues but slowly, a webex was had
> >> last month to try get more traction on this.
> >> A number of new contributors in Artemis who are not just one offs, but
> >> continue to actively contribute, a sign of adoption increasing.
> >>
> >>
> >> Cheers
> >> Mike
> >>
> >>
> >> > On 9 Apr 2018, at 16:37, Bruce Snyder  wrote:
> >> >
> >> > Happy Monday morning!
> >> >
> >> > The board report for April has not received any contributions yet and
> I
> >> > must submit it by Wednesday, April 11th.
> >> >
> >> > The report needs information on project activity for the following
> three
> >> > categories:
> >> >
> >> > * ActiveMQ
> >> > * Artemis
> >> > * Other
> >> >
> >> > If you can contribute any information about the project development
> for
> >> > these three areas, can you please add it to the board report right
> away?
> >> >
> >> > Bruce
> >> >
> >> > On Wed, Apr 4, 2018 at 5:10 PM, Bruce Snyder 
> >> wrote:
> >> >
> >> >> I am following up again to request your contribution to the ASF board
> >> >> report for April. The deadline to contribute is April 11th.
> >> >>
> >> >> If you are contributing code to any modules within the ActiveMQ
> >> project,
> >> >> please take a few moments to edit the following wiki page to report
> on
> >> the
> >> >> activity that has taken place over the last two months:
> >> >>
> >> >> https://cwiki.apache.org/confluence/pages/viewpage.action?
> >> pageId=75977784
> >> >>
> >> >> Thank you!
> >> >>
> >> >> Bruce
> >> >>
> >> >> On Thu, Mar 29, 2018 at 9:30 PM, Bruce Snyder <
> bruce.sny...@gmail.com>
> >> >> wrote:
> >> >>
> >> >>> It is time once again to submit a report to the ASF board for April.
> >> >>> Please take 5 minutes to contribute some of the project activity to
> >> the
> >> >>> report at the wiki page below:
> >> >>>
> >> >>> https://cwiki.apache.org/confluence/pages/viewpage.action?
> >> pageId=75977784
> >> >>>
> >> >>> This report must be submitted by April 11th.
> >> >>>
> >> >>> I really appreciate your contributions!
> >> >>>
> >> >>> Bruce
> >> >>>
> >> >>> --
> >> >>> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> >> >>> 5R\"F)R=6-E+G-N>61E >> >>>
> >> >>> ActiveMQ in Action: http://bit.ly/2je6cQ
> >> >>> Blog: http://bsnyder.org/ 
> >> >>> Twitter: http://twitter.com/brucesnyder
> >> >>>
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> >> >> 5R\"F)R=6-E+G-N>61E >> >>
> >> >> ActiveMQ in Action: http://bit.ly/2je6cQ
> >> >> Blog: http://bsnyder.org/ 
> >> >> Twitter: http://twitter.com/brucesnyder
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > perl -e 'print
> >> > unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E >> );'
> >> >
> >> > ActiveMQ in Action: http://bit.ly/2je6cQ
> >> > Blog: http://bsnyder.org/ 
> >> > Twitter: http://twitter.com/brucesnyder
> >>
> >>
> >
> >
> > --
> > perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> > 5R\"F)R=6-E+G-N>61E >
> > ActiveMQ in Action: http://bit.ly/2je6cQ
> > Blog: http://bsnyder.org/ 
> > Twitter: http://twitter.com/brucesnyder
> >
>
>
>
> --
> perl -e 'print
> unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E
> ActiveMQ in Action: http://bit.ly/2je6cQ
> Blog: http://bsnyder.org/ 
> Twitter: http://twitter.com/brucesnyder
>

[GitHub] activemq-artemis issue #2006: ARTEMIS-1798 DEBUG message bad write method ar...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2006
  
nice one.. thanks.. will wait the check and merge it


---

[GitHub] activemq-artemis pull request #2007: ARTEMIS-1799 - Add a NotificationActive...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2007


---

[GitHub] activemq-artemis issue #2007: ARTEMIS-1799 - Add a NotificationActiveMQServe...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2007
  
@cshannon I see. .thanks for the clarification. merging it.


---

[GitHub] activemq-artemis issue #2006: ARTEMIS-1798 DEBUG message bad write method ar...

[stanlyDoge]

Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/2006
  
@clebertsuconic Renamed.


---

Re: Board report for April 2018

[Bruce Snyder]

I am getting rather desperate to have someone describe the project activity
for ActiveMQ, Artemis as well as NMS, CMS, etc.

if you work on the project, can you please contribute to the April board
report via the wiki?

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75977784

Your time is much appreciated. If I could buy you a virtual beer I would do
so ;-).

Bruce

On Tue, Apr 10, 2018 at 9:21 AM, Bruce Snyder 
wrote:

> Hi Michael,
>
> I have granted you r/w permissions to the wiki, so you should be able to
> edit the page now.
>
> Bruce
>
> On Mon, Apr 9, 2018 at 1:45 PM, Michael André Pearce <
> michael.andre.pea...@me.com> wrote:
>
>> Hi Bruce,
>>
>> It seems same issue as last time, i don’t have rights to edit directly.
>>
>> Can you check the space permissions for my user: michael.andre.pearce
>>
>>
>> Bits i would add / comment on are:
>>
>> Artemis released 2.5.0
>> Effort to create updated website continues but slowly, a webex was had
>> last month to try get more traction on this.
>> A number of new contributors in Artemis who are not just one offs, but
>> continue to actively contribute, a sign of adoption increasing.
>>
>>
>> Cheers
>> Mike
>>
>>
>> > On 9 Apr 2018, at 16:37, Bruce Snyder  wrote:
>> >
>> > Happy Monday morning!
>> >
>> > The board report for April has not received any contributions yet and I
>> > must submit it by Wednesday, April 11th.
>> >
>> > The report needs information on project activity for the following three
>> > categories:
>> >
>> > * ActiveMQ
>> > * Artemis
>> > * Other
>> >
>> > If you can contribute any information about the project development for
>> > these three areas, can you please add it to the board report right away?
>> >
>> > Bruce
>> >
>> > On Wed, Apr 4, 2018 at 5:10 PM, Bruce Snyder 
>> wrote:
>> >
>> >> I am following up again to request your contribution to the ASF board
>> >> report for April. The deadline to contribute is April 11th.
>> >>
>> >> If you are contributing code to any modules within the ActiveMQ
>> project,
>> >> please take a few moments to edit the following wiki page to report on
>> the
>> >> activity that has taken place over the last two months:
>> >>
>> >> https://cwiki.apache.org/confluence/pages/viewpage.action?
>> pageId=75977784
>> >>
>> >> Thank you!
>> >>
>> >> Bruce
>> >>
>> >> On Thu, Mar 29, 2018 at 9:30 PM, Bruce Snyder 
>> >> wrote:
>> >>
>> >>> It is time once again to submit a report to the ASF board for April.
>> >>> Please take 5 minutes to contribute some of the project activity to
>> the
>> >>> report at the wiki page below:
>> >>>
>> >>> https://cwiki.apache.org/confluence/pages/viewpage.action?
>> pageId=75977784
>> >>>
>> >>> This report must be submitted by April 11th.
>> >>>
>> >>> I really appreciate your contributions!
>> >>>
>> >>> Bruce
>> >>>
>> >>> --
>> >>> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
>> >>> 5R\"F)R=6-E+G-N>61E> >>>
>> >>> ActiveMQ in Action: http://bit.ly/2je6cQ
>> >>> Blog: http://bsnyder.org/ 
>> >>> Twitter: http://twitter.com/brucesnyder
>> >>>
>> >>
>> >>
>> >>
>> >> --
>> >> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
>> >> 5R\"F)R=6-E+G-N>61E> >>
>> >> ActiveMQ in Action: http://bit.ly/2je6cQ
>> >> Blog: http://bsnyder.org/ 
>> >> Twitter: http://twitter.com/brucesnyder
>> >>
>> >
>> >
>> >
>> > --
>> > perl -e 'print
>> > unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E> );'
>> >
>> > ActiveMQ in Action: http://bit.ly/2je6cQ
>> > Blog: http://bsnyder.org/ 
>> > Twitter: http://twitter.com/brucesnyder
>>
>>
>
>
> --
> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> 5R\"F)R=6-E+G-N>61E
> ActiveMQ in Action: http://bit.ly/2je6cQ
> Blog: http://bsnyder.org/ 
> Twitter: http://twitter.com/brucesnyder
>



-- 
perl -e 'print
unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E
Twitter: http://twitter.com/brucesnyder

Re: Board report for April 2018

[Bruce Snyder]

Hi Michael,

I have granted you r/w permissions to the wiki, so you should be able to
edit the page now.

Bruce

On Mon, Apr 9, 2018 at 1:45 PM, Michael André Pearce <
michael.andre.pea...@me.com> wrote:

> Hi Bruce,
>
> It seems same issue as last time, i don’t have rights to edit directly.
>
> Can you check the space permissions for my user: michael.andre.pearce
>
>
> Bits i would add / comment on are:
>
> Artemis released 2.5.0
> Effort to create updated website continues but slowly, a webex was had
> last month to try get more traction on this.
> A number of new contributors in Artemis who are not just one offs, but
> continue to actively contribute, a sign of adoption increasing.
>
>
> Cheers
> Mike
>
>
> > On 9 Apr 2018, at 16:37, Bruce Snyder  wrote:
> >
> > Happy Monday morning!
> >
> > The board report for April has not received any contributions yet and I
> > must submit it by Wednesday, April 11th.
> >
> > The report needs information on project activity for the following three
> > categories:
> >
> > * ActiveMQ
> > * Artemis
> > * Other
> >
> > If you can contribute any information about the project development for
> > these three areas, can you please add it to the board report right away?
> >
> > Bruce
> >
> > On Wed, Apr 4, 2018 at 5:10 PM, Bruce Snyder 
> wrote:
> >
> >> I am following up again to request your contribution to the ASF board
> >> report for April. The deadline to contribute is April 11th.
> >>
> >> If you are contributing code to any modules within the ActiveMQ project,
> >> please take a few moments to edit the following wiki page to report on
> the
> >> activity that has taken place over the last two months:
> >>
> >> https://cwiki.apache.org/confluence/pages/viewpage.
> action?pageId=75977784
> >>
> >> Thank you!
> >>
> >> Bruce
> >>
> >> On Thu, Mar 29, 2018 at 9:30 PM, Bruce Snyder 
> >> wrote:
> >>
> >>> It is time once again to submit a report to the ASF board for April.
> >>> Please take 5 minutes to contribute some of the project activity to the
> >>> report at the wiki page below:
> >>>
> >>> https://cwiki.apache.org/confluence/pages/viewpage.
> action?pageId=75977784
> >>>
> >>> This report must be submitted by April 11th.
> >>>
> >>> I really appreciate your contributions!
> >>>
> >>> Bruce
> >>>
> >>> --
> >>> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> >>> 5R\"F)R=6-E+G-N>61E >>>
> >>> ActiveMQ in Action: http://bit.ly/2je6cQ
> >>> Blog: http://bsnyder.org/ 
> >>> Twitter: http://twitter.com/brucesnyder
> >>>
> >>
> >>
> >>
> >> --
> >> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> >> 5R\"F)R=6-E+G-N>61E >>
> >> ActiveMQ in Action: http://bit.ly/2je6cQ
> >> Blog: http://bsnyder.org/ 
> >> Twitter: http://twitter.com/brucesnyder
> >>
> >
> >
> >
> > --
> > perl -e 'print
> > unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E >
> > ActiveMQ in Action: http://bit.ly/2je6cQ
> > Blog: http://bsnyder.org/ 
> > Twitter: http://twitter.com/brucesnyder
>
>


-- 
perl -e 'print
unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E
Twitter: http://twitter.com/brucesnyder

[GitHub] activemq-artemis issue #2007: ARTEMIS-1799 - Add a NotificationActiveMQServe...

[cshannon]

Github user cshannon commented on the issue:

https://github.com/apache/activemq-artemis/pull/2007
  
I don't understand the confusion.  That call just calls off to any 
registered plugins if they exist.  This commit is a brand new plugin that 
implements the afterDeliver call and fires off a notification. But it only 
fires off that notification if the flag in the plugin is set to true.


---

[GitHub] activemq-artemis pull request #2006: ARTEMIS-1798 DEBUG message bad write me...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2006#discussion_r180460101
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java
 ---
@@ -84,6 +85,10 @@
 import org.apache.activemq.util.LongSequenceGenerator;
 
 public class OpenWireProtocolManager implements 
ProtocolManager, ClusterTopologyListener {
+   static {
+  // this is not really a property, needs to be ignored
+  
FluentPropertyBeanIntrospectorWithIgnores.addIgnore(OpenWireProtocolManager.class.getName(),
 "setUpInactivityParams");
--- End diff --

Instead of that.. what about renaming the method to 
configureInactivityParams.

You wouldn't need to do anything with Beans.


---

[GitHub] activemq-artemis pull request #2007: ARTEMIS-1799 - Add a NotificationActive...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2007#discussion_r180458900
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
 ---
@@ -39,7 +39,15 @@
PROPOSAL(18),
PROPOSAL_RESPONSE(19),
UNPROPOSAL(20),
-   CONSUMER_SLOW(21);
+   CONSUMER_SLOW(21),
+   ADDRESS_ADDED(22),
+   ADDRESS_REMOVED(23),
+   CONNECTION_CREATED(24),
+   CONNECTION_DESTROYED(25),
+   SESSION_CREATED(26),
+   SESSION_CLOSED(27),
+   MESSAGE_DELIVERED(28),
--- End diff --

@cshannon this one: 
https://github.com/apache/activemq-artemis/blob/39fc8cf1413c0f3cbb88913531753e8a7dba3d07/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java#L437


---

[GitHub] activemq-artemis pull request #2007: ARTEMIS-1799 - Add a NotificationActive...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2007#discussion_r180457921
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
 ---
@@ -39,7 +39,15 @@
PROPOSAL(18),
PROPOSAL_RESPONSE(19),
UNPROPOSAL(20),
-   CONSUMER_SLOW(21);
+   CONSUMER_SLOW(21),
+   ADDRESS_ADDED(22),
+   ADDRESS_REMOVED(23),
+   CONNECTION_CREATED(24),
+   CONNECTION_DESTROYED(25),
+   SESSION_CREATED(26),
+   SESSION_CLOSED(27),
+   MESSAGE_DELIVERED(28),
--- End diff --

@cshannon when  you go to ServerConsumerImpl, there's already a previous 
call you added to afterDeliver, that's apparently gets called every time.


Shouldn't that be changed to call this new component you wrote?


I guess that's where I'm getting confused. I read the code as part of your 
change now and I see that's an older change you added back in Jan this year.


Can you take a look for the relationship between that change and this one 
now?


---

[GitHub] activemq-artemis pull request #2007: ARTEMIS-1799 - Add a NotificationActive...

[cshannon]

Github user cshannon commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2007#discussion_r180449915
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
 ---
@@ -39,7 +39,15 @@
PROPOSAL(18),
PROPOSAL_RESPONSE(19),
UNPROPOSAL(20),
-   CONSUMER_SLOW(21);
+   CONSUMER_SLOW(21),
+   ADDRESS_ADDED(22),
+   ADDRESS_REMOVED(23),
+   CONNECTION_CREATED(24),
+   CONNECTION_DESTROYED(25),
+   SESSION_CREATED(26),
+   SESSION_CLOSED(27),
+   MESSAGE_DELIVERED(28),
--- End diff --

No because every notification is off by default.  The user can configure 
what they want.  By default if you configure the plugin it doesn't do anything 
unless the user sets a type to true to send.  So if someone doesn't care about 
message delivered notifications then just leave that flag as false.


---

[GitHub] activemq-artemis pull request #2007: ARTEMIS-1799 - Add a NotificationActive...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2007#discussion_r180448672
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
 ---
@@ -39,7 +39,15 @@
PROPOSAL(18),
PROPOSAL_RESPONSE(19),
UNPROPOSAL(20),
-   CONSUMER_SLOW(21);
+   CONSUMER_SLOW(21),
+   ADDRESS_ADDED(22),
+   ADDRESS_REMOVED(23),
+   CONNECTION_CREATED(24),
+   CONNECTION_DESTROYED(25),
+   SESSION_CREATED(26),
+   SESSION_CLOSED(27),
+   MESSAGE_DELIVERED(28),
--- End diff --

isn't that too costly to the broker?

that's a lot of notifications here. I don't think we should do on 
MESSAGE_DELIVERED.


---

[GitHub] activemq-artemis pull request #2007: ARTEMIS-1799 - Add a NotificationActive...

[cshannon]

GitHub user cshannon opened a pull request:

https://github.com/apache/activemq-artemis/pull/2007

ARTEMIS-1799 - Add a NotificationActiveMQServerPlugin

Adds a new plugin that will support sending new types of notifications
for broker events which will allow enhanced broker monitoring

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1799

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2007.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2007


commit 4795f7c6d0e9242c2fc1f364b1cc025a1ce037b6
Author: Christopher L. Shannon (cshannon) 
Date:   2018-04-10T13:19:11Z

ARTEMIS-1799 - Add a NotificationActiveMQServerPlugin

Adds a new plugin that will support sending new types of notifications
for broker events which will allow enhanced broker monitoring




---

[GitHub] activemq-artemis pull request #1999: ARTEMIS-1790 Improve Topology Member Fi...

[stanlyDoge]

Github user stanlyDoge commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1999#discussion_r180413588
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
 ---
@@ -511,6 +511,45 @@ public final boolean isUsingProtocolHandling() {
   return true;
}
 
+   @Override
+   public boolean isSameTarget(TransportConfiguration... configs) {
+  boolean yes = false;
--- End diff --

hehehe


---

[GitHub] activemq-artemis pull request #2006: ARTEMIS-1798 DEBUG message bad write me...

[stanlyDoge]

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/2006

ARTEMIS-1798 DEBUG message bad write method arg count - fix

When the logging level was set up to DEBUG, 
FluentPropertyBeanIntrospectorWithIgnores threw an exception at 
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager#setUpInactivityParams
 because it was not really setting up any property. I have added this method to 
FluentPropertyBeanIntrospectorWithIgnores's ignored method, which means this 
method is not checked anymore. That causes there is not error message in DEBUG 
output any longer.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis E638

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2006.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2006


commit 7f3962c0776fcfdda9c1dab2cc5260228a2edfc1
Author: Stanislav Knot 
Date:   2018-04-10T13:01:55Z

ARTEMIS-1798 DEBUG message bad write method arg count - fix




---

[GitHub] activemq-artemis pull request #2005: ARTEMIS-1797 Auto-create-address flag s...

[gaohoward]

GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/2005

ARTEMIS-1797 Auto-create-address flag shouldn't block temp destination 
creation



When creating a temp destination and auto-create-address set to false, the
broker throws an error and refuse to create it. This doesn't conform to
normal use-case (like amqp dynamic flag) where the temp destination should
be allowed even if the auto-create-address is false.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis g_1158

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2005.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2005


commit 39a4e04aa11f22e672f4fe6f8ce87c436f9ddc8f
Author: Howard Gao 
Date:   2018-04-10T07:26:27Z

ARTEMIS-1797 Auto-create-address flag shouldn't block temp destination 
creation

When creating a temp destination and auto-create-address set to false, the
broker throws an error and refuse to create it. This doesn't conform to
normal use-case (like amqp dynamic flag) where the temp destination should
be allowed even if the auto-create-address is false.




---