[GitHub] activemq-artemis issue #2193: ARTEMIS-1985: Switch from XA_RDONLY to XA_OK a...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/2193 Yes, I commented in Jira that either via core protocol (Artemis) and ActiveMQ are returning XA_OK. Actually all events only get prepared and therefor data loss. My test case (simple program) only needs a few lines for the tm. I'm using geronimo tm which is easy to init. ---
[GitHub] activemq-artemis issue #2193: ARTEMIS-1985: Switch from XA_RDONLY to XA_OK a...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/2193 @clebertsuconic : Friendly reminder :-) ---
[GitHub] activemq-artemis pull request #2193: ARTEMIS-1985: Switch from XA_RDONLY to ...
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/2193 ARTEMIS-1985: Switch from XA_RDONLY to XA_OK as return value for prepare transaction via OpenWire @clebertsuconic : Feedback for possible test cases needed (https://issues.apache.org/jira/browse/ARTEMIS-1985) You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis ARTEMIS-1985 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2193 commit 75b20b6553b374950dac333a1350783f0d29f937 Author: Benjamin Graf Date: 2018-07-21T14:57:12Z ARTEMIS-1985: Switch from XA_RDONLY to XA_OK as return value for prepare transaction via OpenWire ---
[GitHub] activemq-artemis issue #2141: ARTEMIS-1935: Close of connection closes all o...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/2141 @clebertsuconic : Will this patch be cherry picked to 2.6.x branch? ---
[GitHub] activemq-artemis pull request #2141: ARTEMIS-1935: Close of connection close...
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/2141 ARTEMIS-1935: Close of connection closes all open sessions You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2141.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2141 commit 1cdf64da0449195c47ab252311da5998bceec2aa Author: Benjamin Graf Date: 2018-06-14T18:34:04Z ARTEMIS-1935: Close of connection closes all open sessions ---
[GitHub] activemq-artemis issue #2073: ARTEMIS-1768: Update to fix handling of intern...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/2073 This one looks better. I also added a comment to the internal set for clarification what happens. ---
[GitHub] activemq-artemis issue #2073: ARTEMIS-1768: Update to fix handling of intern...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/2073 Still feels a bit odd to have so many internal sessions created and "saved" at connection start. Maybe its better to only save the internal id of the openwire session and later get it from property sessions for closing. ---
[GitHub] activemq-artemis pull request #2073: ARTEMIS-1768: Update to fix handling of...
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/2073 ARTEMIS-1768: Update to fix handling of internalSession for OpenWireConnection @clebertsuconic , @jbertram New hopefully to fix #2060 . Plz have a deep look before merge. You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis ARTEMIS-1768 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2073.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2073 commit 8ff1bcc9c6a1b3a2b07a593d98084df5157f Author: Benjamin Graf <benjamin.graf@...> Date: 2018-05-04T20:41:39Z ARTEMIS-1768: Update to fix handling of internalSession for OpenWireConnection ---
[GitHub] activemq-artemis issue #2060: ARTEMIS-1768: Fix handling of internalSession ...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/2060 @clebertsuconic , @jbertram I committed a new version on the original branch. Actually both security test files and also my new testcase does work. Plz have a look on it! ---
[GitHub] activemq-artemis issue #2060: ARTEMIS-1768: Fix handling of internalSession ...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/2060 Maybe it needs a better solution for the second part of the fix considering adding internal amqsessions. let me have a look. ---
[GitHub] activemq-artemis issue #2060: ARTEMIS-1768: Fix handling of internalSession ...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/2060 @clebertsuconic can you also close ARTEMIS-1768? I unfortunately have no rights on this project to do it myself. ---
[GitHub] activemq-artemis issue #2060: ARTEMIS-1768: Fix handling of internalSession ...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/2060 I mean the openwire-protocol module is actually untested. I know the integration testsuite. Where do you prefer test case? ---
[GitHub] activemq-artemis issue #2060: ARTEMIS-1768: Fix handling of internalSession ...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/2060 Well, the whole module is untested at the moment. Let me look if I can find a proper test case. ---
[GitHub] activemq-artemis pull request #2060: ARTEMIS-1768: Fix handling of internalS...
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/2060 ARTEMIS-1768: Fix handling of internalSession for OpenWireConnection You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis ARTEMIS-1768 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2060.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2060 commit 4794ca708cb32ec76287c8720ac595b7f10d09f8 Author: Benjamin Graf <benjamin.graf@...> Date: 2018-05-02T16:13:21Z ARTEMIS-1768: Fix handling of internalSession for OpenWireConnection ---
[GitHub] activemq-artemis pull request #1978: ARTEMIS-1775: Replace wrong env variabl...
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/1978 ARTEMIS-1775: Replace wrong env variable ARTEMIS_ETC_INSTANCE with ARTEMIS_INSTANCE_ETC You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis ARTEMIS-1775 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1978.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1978 commit c5ef696dad7f7ee5d20fd45b5e2f80130aa4292b Author: Benjamin Graf <benjamin.graf@...> Date: 2018-03-28T15:40:58Z ARTEMIS-1775: Replace wrong env variable ARTEMIS_ETC_INSTANCE with ARTEMIS_INSTANCE_ETC ---
[GitHub] activemq-artemis issue #1866: ARTEMIS-1660: Remove oracle12 autoincrement fr...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/1866 @mtaylor: Any feedback on this? ---
[GitHub] activemq-artemis issue #1863: NO-JIRA: Sync OSGi broker config with latest c...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/1863 Any further objection to not merge this? ---
[GitHub] activemq-artemis issue #1866: ARTEMIS-1660: Remove oracle12 autoincrement fr...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/1866 Well, I'm actually not able to test against oracle 12 only have a oracle 11 express instance. But a it is obvious that the autoincrement of id is wrong, since it is 1st managed by the broker and 2nd different to all other database types. ---
[GitHub] activemq-artemis issue #1866: ARTEMIS-1660: Remove oracle12 autoincrement fr...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/1866 @franz1981 : sorry I don't understand what you would like to tell? Do you think the title is wrong? Do you think my patch is wrong? ---
[GitHub] activemq-artemis pull request #1866: ARTEMIS-1660: Remove oracle12 autoincre...
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/1866 ARTEMIS-1660: Remove oracle12 autoincrement from column id for journa⦠â¦l tables You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis ARTEMIS-1660 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1866.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1866 commit 60e209b17a62f8b4d066f068fe057da43c740ecb Author: Benjamin Graf <benjamin.graf@...> Date: 2018-02-12T19:56:20Z ARTEMIS-1660: Remove oracle12 autoincrement from column id for journal tables ---
[GitHub] activemq-artemis issue #1863: NO-JIRA: Sync OSGi broker config with latest c...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/1863 Well, actually the broker.xml is build from several templates and snippets. OSGi needs a complete file to trigger broker deployment. Therefore a a file need to be constructed during build process. Meight be tricky. ---
[GitHub] activemq-artemis pull request #1863: NO-JIRA: Sync OSGi broker config with l...
Github user graben commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1863#discussion_r167488780 --- Diff: artemis-features/src/main/resources/artemis.xml --- @@ -196,5 +194,20 @@ under the License. + +
[GitHub] activemq-artemis pull request #1863: NO-JIRA: Sync OSGi broker config with l...
Github user graben commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1863#discussion_r167488599 --- Diff: artemis-features/src/main/resources/artemis.xml --- @@ -32,21 +32,23 @@ under the License. MAPPED: mmap files NIO: Plain Java Files --> - ASYNCIO + NIO - ./data/artemis/paging + ./paging --- End diff -- root directory is data/artemis/. This avoid data/artemis to be used unnecessary twice. ---
[GitHub] activemq-artemis pull request #1863: NO-JIRA: Sync OSGi broker config with l...
Github user graben commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1863#discussion_r167488412 --- Diff: artemis-features/src/main/resources/artemis.xml --- @@ -32,21 +32,23 @@ under the License. MAPPED: mmap files NIO: Plain Java Files --> - ASYNCIO + NIO --- End diff -- Well, I synced with a created default broker.xml its default is actually NIO and avoid "urgly" comments on every broker start if asyncio is not supported ---
[GitHub] activemq-artemis pull request #1863: NO-JIRA: Sync OSGi broker config with l...
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/1863 NO-JIRA: Sync OSGi broker config with latest changes from ARTEMIS-1628 You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1863.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1863 commit 5bd4ccc4e58bbc6f7d912ca2f0eead4d94968da2 Author: Benjamin Graf <benjamin.graf@...> Date: 2018-02-11T17:13:47Z NO-JIRA: Sync OSGi broker config with latest changes from ARTEMIS-1628 ---
[GitHub] activemq-artemis pull request #1820: [ARTEMIS-550] fix up test to validate C...
Github user graben commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1820#discussion_r164266537
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java
---
@@ -698,8 +699,17 @@ private ActiveMQMessageConsumer createConsumer(final
ActiveMQDestination dest,
*/
if (!response.isExists() ||
!response.getQueueNames().contains(dest.getSimpleAddress())) {
if (response.isAutoCreateQueues()) {
+ SimpleString queueNameToUse = dest.getSimpleAddress();
+ SimpleString addressToUse = queueNameToUse;
+ RoutingType routingTypeToUse = RoutingType.ANYCAST;
+ if
(CompositeAddress.isFullyQualified(queueNameToUse.toString())) {
+ CompositeAddress compositeAddress =
CompositeAddress.getQueueName(queueNameToUse.toString());
+ addressToUse = new
SimpleString(compositeAddress.getAddress());
+ queueNameToUse = new
SimpleString(compositeAddress.getQueueName());
+ routingTypeToUse = RoutingType.MULTICAST;
--- End diff --
Look at my test case in JIRA ARTEMIS-550 and you'll see that there is still
a problem concerning usage of FQQN via core protocol.
---
[GitHub] activemq-artemis pull request #1820: [ARTEMIS-550] fix up test to validate C...
Github user graben commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1820#discussion_r164181992
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java
---
@@ -698,8 +699,17 @@ private ActiveMQMessageConsumer createConsumer(final
ActiveMQDestination dest,
*/
if (!response.isExists() ||
!response.getQueueNames().contains(dest.getSimpleAddress())) {
if (response.isAutoCreateQueues()) {
+ SimpleString queueNameToUse = dest.getSimpleAddress();
+ SimpleString addressToUse = queueNameToUse;
+ RoutingType routingTypeToUse = RoutingType.ANYCAST;
+ if
(CompositeAddress.isFullyQualified(queueNameToUse.toString())) {
+ CompositeAddress compositeAddress =
CompositeAddress.getQueueName(queueNameToUse.toString());
+ addressToUse = new
SimpleString(compositeAddress.getAddress());
+ queueNameToUse = new
SimpleString(compositeAddress.getQueueName());
+ routingTypeToUse = RoutingType.MULTICAST;
--- End diff --
Well it depends. FQQN is a documented feature so usage this way might be
possible. Make it work or document as not working.
---
[GitHub] activemq-artemis pull request #1820: [ARTEMIS-550] fix up test to validate C...
Github user graben commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1820#discussion_r164173035
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java
---
@@ -698,8 +699,17 @@ private ActiveMQMessageConsumer createConsumer(final
ActiveMQDestination dest,
*/
if (!response.isExists() ||
!response.getQueueNames().contains(dest.getSimpleAddress())) {
if (response.isAutoCreateQueues()) {
+ SimpleString queueNameToUse = dest.getSimpleAddress();
+ SimpleString addressToUse = queueNameToUse;
+ RoutingType routingTypeToUse = RoutingType.ANYCAST;
+ if
(CompositeAddress.isFullyQualified(queueNameToUse.toString())) {
+ CompositeAddress compositeAddress =
CompositeAddress.getQueueName(queueNameToUse.toString());
+ addressToUse = new
SimpleString(compositeAddress.getAddress());
+ queueNameToUse = new
SimpleString(compositeAddress.getQueueName());
+ routingTypeToUse = RoutingType.MULTICAST;
--- End diff --
Got it. I misinterpreted spec. I did a test and it works. Fine for me. Thx
;-)
---
[GitHub] activemq-artemis pull request #1820: [ARTEMIS-550] fix up test to validate C...
Github user graben commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1820#discussion_r164166706
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java
---
@@ -698,8 +699,17 @@ private ActiveMQMessageConsumer createConsumer(final
ActiveMQDestination dest,
*/
if (!response.isExists() ||
!response.getQueueNames().contains(dest.getSimpleAddress())) {
if (response.isAutoCreateQueues()) {
+ SimpleString queueNameToUse = dest.getSimpleAddress();
+ SimpleString addressToUse = queueNameToUse;
+ RoutingType routingTypeToUse = RoutingType.ANYCAST;
+ if
(CompositeAddress.isFullyQualified(queueNameToUse.toString())) {
+ CompositeAddress compositeAddress =
CompositeAddress.getQueueName(queueNameToUse.toString());
+ addressToUse = new
SimpleString(compositeAddress.getAddress());
+ queueNameToUse = new
SimpleString(compositeAddress.getQueueName());
+ routingTypeToUse = RoutingType.MULTICAST;
--- End diff --
Sorry, that's not correct vt and shared subscriptions are only similar but
not equal. Shared subscriptions still need connection to have a clientid.
Therefor those connections are bounded to a special use case. VTs has queue
semantic. No "special" connections are needed. Such pooling of connections for
almost everything sending/consuming/... is possible. Artemis still leaks such a
feature on its core protocol.
---
[GitHub] activemq pull request #258: AMQ-6805: Add new implementation based on OSGi D...
GitHub user graben opened a pull request: https://github.com/apache/activemq/pull/258 AMQ-6805: Add new implementation based on OSGi Declarative Services t⦠â¦o make OSGi services available for broker configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq AMQ-6805 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/258.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #258 commit 91c2ae0dfda50ffe917593829faeeb55e6491d89 Author: Benjamin Graf <benjamin.g...@gmx.net> Date: 2017-09-06T18:57:08Z AMQ-6805: Add new implementation based on OSGi Declarative Services to make OSGi services available for broker configuration ---
[GitHub] activemq-artemis issue #1216: ARTEMIS-1124 JDBC Network Timeout configuratio...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/1216 Well, 20s in impl is different to 30s in doc. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1121: NO JIRA Small lexical typo
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/1121 NO JIRA Small lexical typo You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1121 commit 8800642669c85a62c2afe489e9c70b0ce770194b Author: Benjamin Graf <benjamin.g...@gmx.net> Date: 2017-03-22T20:23:40Z NO JIRA Small lexical typo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1101: ARTEMIS-1038: Upgrade qpid-jms-client t...
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/1101 ARTEMIS-1038: Upgrade qpid-jms-client to 0.21.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1101.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1101 commit 05329c49765436e167c72ba9f1ab2575711f4616 Author: Benjamin Graf <benjamin.g...@gmx.net> Date: 2017-03-17T18:48:01Z ARTEMIS-1038: Upgrade qpid-jms-client to 0.21.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq pull request #216: AMQ-5344: Replace bundles with feature
Github user graben closed the pull request at: https://github.com/apache/activemq/pull/216 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq pull request #216: AMQ-5344: Replace bundles with feature
GitHub user graben opened a pull request: https://github.com/apache/activemq/pull/216 AMQ-5344: Replace bundles with feature You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq AMQ-5344 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/216.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #216 commit b3e12dda8a874662423f4f10a8344d7979aacba2 Author: Benjamin Graf <benjamin.g...@gmx.net> Date: 2016-11-23T13:19:23Z AMQ-5344: Replace bundles with feature --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq pull request #211: AMQ-6057: Add performance patch to JDBC statemen...
Github user graben closed the pull request at: https://github.com/apache/activemq/pull/211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq pull request #212: AMQ-6506: Increase OSGi version range for packag...
Github user graben closed the pull request at: https://github.com/apache/activemq/pull/212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq pull request #210: AMQ-6452: Upgrade dependency of geronimo-transac...
Github user graben closed the pull request at: https://github.com/apache/activemq/pull/210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq pull request #213: AMQ-5247: Make jmxUseLocal global settable
Github user graben closed the pull request at: https://github.com/apache/activemq/pull/213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq pull request #213: AMQ-5247: Make jmxUseLocal global settable
GitHub user graben opened a pull request: https://github.com/apache/activemq/pull/213 AMQ-5247: Make jmxUseLocal global settable You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq AMQ-5247 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/213.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #213 commit fed0e9a9f3ba9a7ab9834cc43b3d7e2060c27a6b Author: Benjamin Graf <benjamin.g...@gmx.net> Date: 2016-11-20T16:27:31Z AMQ-5247: Make jmxUseLocal global settable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #891: NO-JIRA: ignore of IDE configurations
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/891 NO-JIRA: ignore of IDE configurations You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/891.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #891 commit 779b2c90217077b520d060ec8ad7866fd661d94b Author: Benjamin Graf <benjamin.g...@gmx.net> Date: 2016-11-17T16:49:41Z NO-JIRA: ignore of IDE configurations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #889: ARTEMIS-852: Add PK and index to create journal...
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/889 to be honest, array idea is taken from ActiveMQ :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq pull request #212: AMQ-6506: Increase OSGi version range for packag...
GitHub user graben opened a pull request: https://github.com/apache/activemq/pull/212 AMQ-6506: Increase OSGi version range for package import javax.jms You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq AMQ-6506 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/212.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #212 commit 2b2d0983dbc969e38d4228f7ad7cbfeca81b44e3 Author: Benjamin Graf <benjamin.g...@gmx.net> Date: 2016-11-16T12:57:42Z AMQ-6506: Increase OSGi version range for package import javax.jms --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #889: ARTEMIS-852: Add PK and index to create ...
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/889 ARTEMIS-852: Add PK and index to create journal table DDL script You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis ARTEMIS-852 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/889.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #889 commit 95e88dd22f68c27c57664cc5aec129f7f9175472 Author: Benjamin Graf <benjamin.g...@gmx.net> Date: 2016-11-16T09:08:10Z ARTEMIS-852: Add PK and index to create journal table DDL script --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #875: ARTEMIS-550 Add virtual topic support
Github user graben closed the pull request at: https://github.com/apache/activemq-artemis/pull/875 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq pull request #211: AMQ-6057: Add performance patch to JDBC statemen...
GitHub user graben opened a pull request: https://github.com/apache/activemq/pull/211 AMQ-6057: Add performance patch to JDBC statements definition You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq AMQ-6057 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/211.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #211 commit 6c8a677ede564facea3b72ed358189fc1104efab Author: Benjamin Graf <benjamin.g...@gmx.net> Date: 2016-11-15T16:01:34Z AMQ-6057: Add performance patch to JDBC statements definition --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #875: ARTEMIS-550 Add virtual topic support
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/875 @andytaylor: Have a look into http://activemq.apache.org/how-do-i-use-jms-efficiently.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #875: ARTEMIS-550 Add virtual topic support
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/875 @andytaylor: I mean the usage of one single pool which is used to send/receive concurrently to multiple topics and virtual topic consumers. Such are often used in integration infrastructures like e.g. Apache ServiceMix. You only have to configure one pool which addresses every purpose since you do not have to register clientId to the jms connections when consuming from queues only. I think that's different to pooled subscribed users in JMS 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #875: ARTEMIS-550 Add virtual topic support
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/875 @andytaylor: One big advantage of queue semantics vs topic subscriptions is the usage of shared pooling. No need for clientId@JMSComnection. Every single pool connection can be used for every topic (sending) or every queue (receiving or sending). Maximum flexibility. As far as I know this is still not addressed in JMS 2.0 API. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #875: ARTEMIS-550 Add virtual topic support
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/875 Well, I'm not sure at all but IMHO the actual implementation of PostOffice is transacted by default no way to deactivate. Concurrency seems a bit difficult to me to implement in this PR. Might implemented in general? The selector or filter (Artemis way) feature is on my todo list after the basis is approved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #875: ARTEMIS-550 Add virtual topic support
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/875 @mattrpav: I'm not sure these options can be implemented the way the virtual topic solution is integrated. Artemis works a bit different than ActiveMQ. But maybe someone with a deeper view into core code can answer this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #875: ARTEMIS-550 Add virtual topic support
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/875 Add some initial tests for better review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #875: ARTEMIS-550 Add virtual topic support
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/875 ARTEMIS-550 Add virtual topic support First preview for discussion, still lacking junit tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/875.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #875 commit 79de70d275f8dd8a5d83c8be77e4815e3201b337 Author: Benjamin Graf <benjamin.g...@gmx.net> Date: 2016-10-29T15:34:49Z ARTEMIS-550 Add virtual topic support --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #874: NO-JIRA: Fix checkstyle false friend
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/874 NO-JIRA: Fix checkstyle false friend You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/874.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #874 commit 20183f94a4171f8d35cd956e490e2457711e330d Author: Benjamin Graf <benjamin.g...@gmx.net> Date: 2016-10-28T17:09:41Z NO-JIRA: Fix checkstyle false friend --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/839 Looks good. I give it a try this evening when back home. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/839 @clebertsuconic That's fine with me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/839 I love checkstyle. :) I thought about the actual implementation and did some small refactorings. Now I think it fits best. But we may think about synchronizing in callback as they are called in separate threads. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/839 Have to fix a bug introduced by refactoring. I think inner classes are looking better than an anonymous one. It might be better to add components to ProtocolTrackerCallBackImpl too make it a static class!? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/839 A bit more this way? IMO I did not see why to change the method to addDataSource. It could be only one and this one is a dependency which is mandatory for broker startup. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/839 Rebase is done :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/839 Well, I think it must be the same callback to avoid the protocol tracker to start the broker if the datasource is not bounded yet. It's just another "mandatory" dependency. I might rename the class to more general name, but separating would end up in a mass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #839: ARTEMIS-793 Improvement to OSGi integrat...
GitHub user graben opened a pull request: https://github.com/apache/activemq-artemis/pull/839 ARTEMIS-793 Improvement to OSGi integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/graben/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/839.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #839 commit 021fa843cd2ccabb2be509df18ebb57c8ab260ed Author: Benjamin Graf <benjamin.g...@gmx.net> Date: 2016-10-11T19:27:52Z ARTEMIS-793 Improvement to OSGi integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #:
Github user graben commented on the pull request: https://github.com/apache/activemq-artemis/commit/d61c13ed77ecad432576442da31398ce77c87eb0#commitcomment-19304638 tcp://0.0.0.0:61616?tcpSendBufferSize=1048576;tcpReceiveBufferSize=1048576;protocols= Should artemis really wait for protocol being initialized? :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
