anybody who are familiar with ambari-web

2016-04-29 Thread jun aoki
I have made a patch on
https://issues.apache.org/jira/browse/AMBARI-16174

Could you review if you are familiar with ambair-web, especially
ConfigInitializer?

-- 
-jun


please review for HAWQ blocker for branch-2.2.2

2016-04-15 Thread jun aoki
Hi Ambari,

Could you please review this?
This is a HAWQ broker for branch-2.2.2

https://issues.apache.org/jira/browse/AMBARI-15926

-- 
-jun


FYI: One more HAWQ related blocker for 2.2.2

2016-04-15 Thread jun aoki
https://issues.apache.org/jira/browse/AMBARI-15926

-- 
-jun


could you +1 for a 2.2.2 HAWQ blocker?

2016-04-14 Thread jun aoki
Just want to make sure everyone is aware of what is going to be in.
Could you please +1?

https://issues.apache.org/jira/browse/AMBARI-15852

-- 
-jun


Re: [ANNOUNCE] Alexander Denissov as a new committer for Ambari

2016-04-12 Thread jun aoki
Congrats Alex. Well deserved!

On Tue, Apr 12, 2016 at 2:11 PM, Oleksandr Diachenko 
wrote:

> Hi all,
>
> It is my pleasure to announce that Alexander Denissov has become a
> committer for Ambari.
> He did significant contribution in HAWQ and PXF support and will continue
> doing his best.
>
> Congratulations, Alexander!
>
> Regards, Alex.
>



-- 
-jun


Re: Review Request 44375: Add theme and meta-data for HAWQ configurations

2016-03-04 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44375/#review122166
---


Ship it!




Ship It!

- jun aoki


On March 4, 2016, 2:05 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44375/
> ---
> 
> (Updated March 4, 2016, 2:05 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Lav Jain, and Newton Alex.
> 
> 
> Bugs: AMBARI-15107
> https://issues.apache.org/jira/browse/AMBARI-15107
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add theme for HAWQ
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml
>  58bfa27 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-limits-env.xml
>  d8917e6 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  457c1d2 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  32ae5a5 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml
>  053f108 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/yarn-client.xml
>  a2296a1 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 
> a772839 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44375/diff/
> 
> 
> Testing
> ---
> 
> Manully Tested on live cluster.
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 44375: Add theme and meta-data for HAWQ configurations

2016-03-04 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44375/#review122164
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 (line 153)
<https://reviews.apache.org/r/44375/#comment184062>

Could we have  ?



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
 (line 249)
<https://reviews.apache.org/r/44375/#comment184065>

Trivial, but HAWQ users are so used to talk about "vm.overcommit_memory", 
and they may Ctrl-F or search that exact keyword, instead of "VM Overcommit". 
Did you want to add "aka vm.overcommit_memory" in somewhere? It could be in 




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml
 (line 153)
<https://reviews.apache.org/r/44375/#comment184064>

trivial but indentation seems off.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml
 (line 203)
<https://reviews.apache.org/r/44375/#comment184061>

Could we have  ?


- jun aoki


On March 4, 2016, 2:05 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44375/
> ---
> 
> (Updated March 4, 2016, 2:05 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Lav Jain, and Newton Alex.
> 
> 
> Bugs: AMBARI-15107
> https://issues.apache.org/jira/browse/AMBARI-15107
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add theme for HAWQ
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml
>  58bfa27 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-limits-env.xml
>  d8917e6 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  457c1d2 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  32ae5a5 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml
>  053f108 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/yarn-client.xml
>  a2296a1 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 
> a772839 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44375/diff/
> 
> 
> Testing
> ---
> 
> Manully Tested on live cluster.
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 44375: Add theme and meta-data for HAWQ configurations

2016-03-04 Thread jun aoki


> On March 5, 2016, 1:41 a.m., jun aoki wrote:
> > Ship It!

LGTM except comments above.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44375/#review122166
---


On March 4, 2016, 2:05 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44375/
> ---
> 
> (Updated March 4, 2016, 2:05 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Lav Jain, and Newton Alex.
> 
> 
> Bugs: AMBARI-15107
> https://issues.apache.org/jira/browse/AMBARI-15107
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add theme for HAWQ
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml
>  58bfa27 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-limits-env.xml
>  d8917e6 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  457c1d2 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  32ae5a5 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml
>  053f108 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/yarn-client.xml
>  a2296a1 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 
> a772839 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44375/diff/
> 
> 
> Testing
> ---
> 
> Manully Tested on live cluster.
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 44211: Currently PXF's service check failure does not tell too much and it is hard to debug.

2016-03-04 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44211/#review122162
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
 (line 62)
<https://reviews.apache.org/r/44211/#comment184058>

Do you want to start with 0, and increment it before each test is executed?



ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
 (line 98)
<https://reviews.apache.org/r/44211/#comment184059>

Those detailed messages count for troubleshooting. Good work!


- jun aoki


On March 4, 2016, 4:41 a.m., Goutam Tadi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44211/
> ---
> 
> (Updated March 4, 2016, 4:41 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
> Lav Jain, Matt, and Newton Alex.
> 
> 
> Bugs: AMBARI-15249
> https://issues.apache.org/jira/browse/AMBARI-15249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> pxf service check failure does not tell why it fails. Include debug messages 
> for ease.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
>  6f60661 
> 
> Diff: https://reviews.apache.org/r/44211/diff/
> 
> 
> Testing
> ---
> 
> Yes, tested.
> 
> 
> Thanks,
> 
> Goutam Tadi
> 
>



[jira] [Commented] (AMBARI-15211) Alerts for PXF component status

2016-03-03 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178656#comment-15178656
 ] 

jun aoki commented on AMBARI-15211:
---

trunk hash was 
ec94842e2d7095767cbfa0634c2813b2a8c7079a

> Alerts for PXF component status
> ---
>
> Key: AMBARI-15211
> URL: https://issues.apache.org/jira/browse/AMBARI-15211
> Project: Ambari
>  Issue Type: Bug
>  Components: alerts
>    Reporter: jun aoki
>Assignee: jun aoki
>Priority: Minor
> Attachments: AMBARI-15211-branch-2.2.patch, 
> AMBARI-15211-branch-2.2.v2.patch, AMBARI-15211-branch-2.2.v3.patch, 
> AMBARI-15211-branch-2.2.v4.patch, AMBARI-15211-branch-2.2.v5.patch
>
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15211) Alerts for PXF component status

2016-03-03 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178654#comment-15178654
 ] 

jun aoki commented on AMBARI-15211:
---

Committed to branch-2.2
b4f067fd81f84354758ffe7cd2354f9ac25db23f
Committed to trunk
b4f067fd81f84354758ffe7cd2354f9ac25db23f

> Alerts for PXF component status
> ---
>
> Key: AMBARI-15211
> URL: https://issues.apache.org/jira/browse/AMBARI-15211
> Project: Ambari
>  Issue Type: Bug
>  Components: alerts
>    Reporter: jun aoki
>Assignee: jun aoki
>Priority: Minor
> Attachments: AMBARI-15211-branch-2.2.patch, 
> AMBARI-15211-branch-2.2.v2.patch, AMBARI-15211-branch-2.2.v3.patch, 
> AMBARI-15211-branch-2.2.v4.patch, AMBARI-15211-branch-2.2.v5.patch
>
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-03-03 Thread jun aoki


> On March 2, 2016, 9:37 p.m., jun aoki wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/service_advisor_HDP206HBASE.py,
> >  line 1
> > <https://reviews.apache.org/r/44210/diff/1/?file=1275516#file1275516line1>
> >
> > Hi Tim, nice effort to decouple stack_advisor!
> > 
> > Is this file naming service_advisor_HDP206HBASE.py a bit redundant? 
> > this is under 
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE, any files 
> > under this folder is meant for HDP, version 2.0.6 and HBASE.
> 
> Tim Thorpe wrote:
> I tried having the name as you stated but had a problem with python.  For 
> example in 2.3/services/HDFS, I have the following:
> 
> SCRIPT_DIR = os.path.dirname(os.path.abspath(file))
> PARENT_DIR = os.path.join(SCRIPT_DIR, '../../../2.2/services/HDFS/')
> sys.path.append(PARENT_DIR)
> from service_advisor_HDP22HDFS import *
> 
> If the file name is the same in 2.3 and 2.2, then "from service_advisor 
> import *" could reference the 2.2 or the 2.3 file.  I tried it with import 
> HDP22HDFSServiceAdvisor as well and both of them failed to find the correct 
> parent class.
> 
> The other way I could have solved this is to load all the service advisor 
> files from the default_stack_advisor.py walking my way up the stack.  This 
> would have allowed you to avoid the inheritance code in the 
> service_advisor.py files but it would restrict you from inheriting from 
> outside of your stack (unless at that point you started including the 
> inheritance code and the change of file names).

I believe it has to treated as python packages so that file path matters.
```
sys.path.append("/stacks")
from HDP.2_2.services.HDFS import service_advisor # you'd probably have to deal 
with "." in versions.
```


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review121720
---


On March 1, 2016, 4:53 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated March 1, 2016, 4:53 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml c2c993f 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/scripts/stack_advisor.py cdd9acb 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/GANGLIA/service_advisor_BIGTOP08GANGLIA.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HBASE/service_advisor_BIGTOP08HBASE.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/service_advisor_BIGTOP08HDFS.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/service_advisor_BIGTOP08HIVE.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/OOZIE/service_advisor_BIGTOP08OOZIE.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/YARN/service_advisor_BIGTOP08YARN.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/ZOOKEEPER/service_advisor_BIGTOP08ZOOKEEPER.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 
> 53591cd 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service_advisor_HDP206AMBARI_METRICS.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/

[jira] [Commented] (AMBARI-15211) Alerts for PXF component status

2016-03-02 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176934#comment-15176934
 ] 

jun aoki commented on AMBARI-15211:
---

The same patch applies to trunk

> Alerts for PXF component status
> ---
>
> Key: AMBARI-15211
> URL: https://issues.apache.org/jira/browse/AMBARI-15211
> Project: Ambari
>  Issue Type: Bug
>  Components: alerts
>    Reporter: jun aoki
>Assignee: jun aoki
>Priority: Minor
> Attachments: AMBARI-15211-branch-2.2.patch, 
> AMBARI-15211-branch-2.2.v2.patch, AMBARI-15211-branch-2.2.v3.patch, 
> AMBARI-15211-branch-2.2.v4.patch, AMBARI-15211-branch-2.2.v5.patch
>
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (AMBARI-15211) Alerts for PXF component status

2016-03-02 Thread jun aoki (JIRA)

 [ 
https://issues.apache.org/jira/browse/AMBARI-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jun aoki updated AMBARI-15211:
--
Attachment: AMBARI-15211-branch-2.2.v5.patch

> Alerts for PXF component status
> ---
>
> Key: AMBARI-15211
> URL: https://issues.apache.org/jira/browse/AMBARI-15211
> Project: Ambari
>  Issue Type: Bug
>  Components: alerts
>    Reporter: jun aoki
>Assignee: jun aoki
>Priority: Minor
> Attachments: AMBARI-15211-branch-2.2.patch, 
> AMBARI-15211-branch-2.2.v2.patch, AMBARI-15211-branch-2.2.v3.patch, 
> AMBARI-15211-branch-2.2.v4.patch, AMBARI-15211-branch-2.2.v5.patch
>
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 44119: Alerts for PXF component status

2016-03-02 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/
---

(Updated March 3, 2016, 12:16 a.m.)


Review request for Ambari.


Changes
---

slight text label change


Bugs: AMBARI-15211
https://issues.apache.org/jira/browse/AMBARI-15211


Repository: ambari


Description
---

Add alerts for PXF availability.
The availability could be same as its service check. (by hitting the version 
api)


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 
4078990 
  ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/PXF/3.0.0/metainfo.xml 
1797b29 
  
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/44119/diff/


Testing
---

Manually tested. 


--
Ran 275 tests in 6.876s

OK
--
Total run:924
Total errors:0
Total failures:0
OK


Thanks,

jun aoki



Re: [ANNOUNCE] Mithun Mathew as a new committer for Ambari

2016-03-02 Thread jun aoki
He goes by Matt, just in case you don't recognize him. Congrats! You well
deserved!

On Wed, Mar 2, 2016 at 2:11 PM, Newton Alex  wrote:

> Congratulations Mithun!
>
> -
> Newton
>
> On Wed, Mar 2, 2016 at 2:09 PM, Oleksandr Diachenko  > wrote:
>
>> Hi all,
>>
>> It is my pleasure to announce that Mithun Mathew has become a committer
>> for Ambari.
>> He did significant contribution in HAWQ and PXF support and will continue
>> doing his best.
>>
>> Congratulations, Mithun!
>>
>> Regards, Alex.
>>
>
>


-- 
-jun


Re: [ANNOUNCE] Bhuvnesh Chaudhary as a new committer for Ambari

2016-03-02 Thread jun aoki
Bhuvnesh, congrats! you well deserved!!

On Wed, Mar 2, 2016 at 2:09 PM, Oleksandr Diachenko 
wrote:

> Hi all,
>
> It is my pleasure to announce that Bhuvnesh Chaudhary has become a
> committer for Ambari.
> He did significant contribution in HAWQ and PXF support and will continue
> doing his best.
>
> Congratulations, Bhuvnesh!
>
> Regards, Alex.
>



-- 
-jun


Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-03-02 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review121720
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/service_advisor_HDP206HBASE.py
 (line 1)
<https://reviews.apache.org/r/44210/#comment183508>

Hi Tim, nice effort to decouple stack_advisor!

Is this file naming service_advisor_HDP206HBASE.py a bit redundant? this is 
under ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE, any 
files under this folder is meant for HDP, version 2.0.6 and HBASE.



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/service_advisor_HDP206HBASE.py
 (line 32)
<https://reviews.apache.org/r/44210/#comment183517>

Could this inheritate a brand new DefaultServiceAdvisor instead of the 
stack advisor? service and stack are different hierarchy and I feel somehow 
wrong if a service inheritate a stack.


- jun aoki


On March 1, 2016, 4:53 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated March 1, 2016, 4:53 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml c2c993f 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/scripts/stack_advisor.py cdd9acb 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/GANGLIA/service_advisor_BIGTOP08GANGLIA.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HBASE/service_advisor_BIGTOP08HBASE.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/service_advisor_BIGTOP08HDFS.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/service_advisor_BIGTOP08HIVE.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/OOZIE/service_advisor_BIGTOP08OOZIE.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/YARN/service_advisor_BIGTOP08YARN.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/ZOOKEEPER/service_advisor_BIGTOP08ZOOKEEPER.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 
> 53591cd 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service_advisor_HDP206AMBARI_METRICS.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/service_advisor_HDP206GANGLIA.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/service_advisor_HDP206HBASE.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/service_advisor_HDP206HDFS.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/service_advisor_HDP206HIVE.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/service_advisor_HDP206OOZIE.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/service_advisor_HDP206YARN.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/service_advisor_HDP206ZOOKEEPER.py
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> f6f8cde 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/service_advisor_HDP21FALCON.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/service_advisor_HDP21HIVE.py
>  PRE-CREAT

[jira] [Commented] (AMBARI-15227) Move HAWQMASTER above HAWQSTANDBY in Assign Masters page

2016-03-01 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174712#comment-15174712
 ] 

jun aoki commented on AMBARI-15227:
---

Committed to trunk
fa38d29a13fe26625f7225d249f72d05e997fa3b
Committed to branch-2.2
93aba403cbbfbdb9830cb13cbc7bc80decc10704

> Move HAWQMASTER above HAWQSTANDBY in Assign Masters page
> 
>
> Key: AMBARI-15227
> URL: https://issues.apache.org/jira/browse/AMBARI-15227
> Project: Ambari
>  Issue Type: Sub-task
>  Components: ambari-web
>Reporter: Matt
>Assignee: Matt
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-15227-branch-2.2-orig.patch, 
> AMBARI-15227-trunk-orig.patch, Fix.png
>
>
> On Assign Masters page, HAWQMASTER is shown below HAWQSTANDBY. Switch the 
> order in which these components are displayed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 44145: Update warning messages for HAWQ and PXF in stack advisor

2016-03-01 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44145/#review121523
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
99)
<https://reviews.apache.org/r/44145/#comment183245>

union this instead of "+" just in case there is duplicate?



ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
102)
<https://reviews.apache.org/r/44145/#comment183247>

    Good stuff.


- jun aoki


On Feb. 28, 2016, 12:53 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44145/
> ---
> 
> (Updated Feb. 28, 2016, 12:53 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Lav Jain, and Newton Alex.
> 
> 
> Bugs: AMBARI-15215
> https://issues.apache.org/jira/browse/AMBARI-15215
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *On Assign Masters:*
> HAWQ Master and HAWQ Standby Master cannot be deployed on the same host.
> 
> *On Assign Clients:*
> PXF must be installed on the NameNode, Standby NameNode and all the 
> DataNodes. The following  host(s) do not satisfy the colocation 
> recommendation: 
> 
> HAWQ Segment must be installed on all the DataNodes. The following  
> host(s) do not satisfy the colocation recommendation: 
> 
> *On Configuration Validation:*
> The default Postgres port (5432) on the Ambari Server conflicts with the 
> default HAWQ Master port. If you are using port 5432 for Postgres, you must 
> either deploy the HAWQ Master on a different host or configure a different 
> port for the HAWQ Master in the HAWQ Configuration page.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 0b4e543 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 1968c4b 
> 
> Diff: https://reviews.apache.org/r/44145/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Added additional unit test and updated existing tests:
> 
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is not recommended on a single node cluster ... ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
> test_createComponentLayoutRecommendations_hawqsegment_co_locate_datanode 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSegment gets recommended on same host group which has DATANODE 
> ... ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_createComponentLayoutRecommendations_pxf_co_locate_with_namenode_or_datanode
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended on same host group which has NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test layout validations for HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test validation warning for HAWQ segment not colocated with DATANODE ... ok
> test_getComponentLayoutValidations_nohawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test NO warning is generated when PXF is co-located with NAMENODE and 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_sparkts_no_hive 
&g

[jira] [Commented] (AMBARI-15189) Set dfs.allow.truncate = True on HDFS during HAWQ install or add service

2016-03-01 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174479#comment-15174479
 ] 

jun aoki commented on AMBARI-15189:
---

[~dmitriusan], thank you for reporting. We did execute the unit tests on trunk 
but somehow missed on the branch. We will make sure that we cover both cases. 

> Set dfs.allow.truncate = True on HDFS during HAWQ install or add service
> 
>
> Key: AMBARI-15189
> URL: https://issues.apache.org/jira/browse/AMBARI-15189
> Project: Ambari
>  Issue Type: Improvement
>  Components: ambari-server
>Affects Versions: trunk, 2.2.0
>Reporter: Lav Jain
>Assignee: Lav Jain
> Fix For: 2.3.0, 2.2.2
>
> Attachments: AMBARI-15189.branch22-2.patch, 
> AMBARI-15189.branch22.patch, AMBARI-15189.patch
>
>
> Setting this param to True is Mandatory, otherwise, failed transactions in 
> HAWQ might generate too many small files and will impact performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 44176: Move HAWQMASTER above HAWQSTANDBY in Assign Masters page

2016-03-01 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44176/#review121507
---


Ship it!




Ship It!

- jun aoki


On Feb. 29, 2016, 6:57 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44176/
> ---
> 
> (Updated Feb. 29, 2016, 6:57 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Lav Jain, and Newton Alex.
> 
> 
> Bugs: AMBARI-15227
> https://issues.apache.org/jira/browse/AMBARI-15227
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On Assign Masters page, HAWQMASTER is shown below HAWQSTANDBY. Switch the 
> order in which these components are displayed.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/mixins/wizard/assign_master_components.js efcb02e 
>   ambari-web/app/models/stack_service.js d9edf6e 
>   ambari-web/test/controllers/wizard/step5_test.js b5e0ddb 
>   ambari-web/test/mixins/wizard/assign_master_components_test.js d8ccd66 
> 
> Diff: https://reviews.apache.org/r/44176/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Updated unit test.
> Unit tests passed:
>   10429 tests complete (10 seconds)
>   121 tests pending
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 42.263 s
> [INFO] Finished at: 2016-02-29T10:42:25-08:00
> [INFO] Final Memory: 12M/311M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 44119: Alerts for PXF component status

2016-03-01 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/
---

(Updated March 1, 2016, 9:13 p.m.)


Review request for Ambari.


Bugs: AMBARI-15211
https://issues.apache.org/jira/browse/AMBARI-15211


Repository: ambari


Description
---

Add alerts for PXF availability.
The availability could be same as its service check. (by hitting the version 
api)


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/44119/diff/


Testing
---

Manually tested. 


--
Ran 275 tests in 6.876s

OK
--
Total run:924
Total errors:0
Total failures:0
OK


Thanks,

jun aoki



[jira] [Updated] (AMBARI-15211) Alerts for PXF component status

2016-03-01 Thread jun aoki (JIRA)

 [ 
https://issues.apache.org/jira/browse/AMBARI-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jun aoki updated AMBARI-15211:
--
Attachment: AMBARI-15211-branch-2.2.v4.patch

> Alerts for PXF component status
> ---
>
> Key: AMBARI-15211
> URL: https://issues.apache.org/jira/browse/AMBARI-15211
> Project: Ambari
>  Issue Type: Bug
>  Components: alerts
>    Reporter: jun aoki
>Assignee: jun aoki
>Priority: Minor
> Attachments: AMBARI-15211-branch-2.2.patch, 
> AMBARI-15211-branch-2.2.v2.patch, AMBARI-15211-branch-2.2.v3.patch, 
> AMBARI-15211-branch-2.2.v4.patch
>
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 44119: Alerts for PXF component status

2016-03-01 Thread jun aoki


> On Feb. 27, 2016, 1:11 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
> >  line 72
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line72>
> >
> > The log is common to all alerts which are run. It would be better to 
> > say which alert it is, for making debugging easier in the future.
> > 
> > logger.info("[Alert PXF API]: getting delegation token from 
> > {0}".format(url))
> > 
> > Consider other logger messages as well.
> 
> jun aoki wrote:
> @Matt, I wonder if all callers of logger have to write where it is, it 
> would defeat the purpose of logger? The callers should only write level 
> (info, debug, warn) and what it wants to log. 
> On the other hand, timestamp, py file name and possibly lines should be 
> logged by logger only when it is configured so? (also see log4j's "F" format)
> Let me know if I'm totally mistaken here with python's logger.
> 
> Matt wrote:
> Among a bunch of log messages, it would be easier to identify the message 
> if it contained 'PXF' in the message: "Getting delegation token from  
> for PXF". 
> At-least it makes it possible to grep for PXF in the ambari_alerts log 
> and this would show up, without possibly thinking about enabling other log4j 
> options (similar to the one you mentioned).
> 
> "Getting delegation token from " can be for any alert defined in 
> Ambari. grepping for PXF wouldn't return this line.

Good point. will append "for PXF" in the message


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121027
---


On March 1, 2016, 2:10 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> ---
> 
> (Updated March 1, 2016, 2:10 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> ---
> 
> Manually tested. 
> 
> 
> --
> Ran 275 tests in 6.876s
> 
> OK
> --
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>



[jira] [Updated] (AMBARI-15211) Alerts for PXF component status

2016-02-29 Thread jun aoki (JIRA)

 [ 
https://issues.apache.org/jira/browse/AMBARI-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jun aoki updated AMBARI-15211:
--
Attachment: AMBARI-15211-branch-2.2.v3.patch

> Alerts for PXF component status
> ---
>
> Key: AMBARI-15211
> URL: https://issues.apache.org/jira/browse/AMBARI-15211
> Project: Ambari
>  Issue Type: Bug
>  Components: alerts
>    Reporter: jun aoki
>Assignee: jun aoki
>Priority: Minor
> Attachments: AMBARI-15211-branch-2.2.patch, 
> AMBARI-15211-branch-2.2.v2.patch, AMBARI-15211-branch-2.2.v3.patch
>
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 44119: Alerts for PXF component status

2016-02-29 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/
---

(Updated March 1, 2016, 2:10 a.m.)


Review request for Ambari.


Changes
---

feedback applied


Bugs: AMBARI-15211
https://issues.apache.org/jira/browse/AMBARI-15211


Repository: ambari


Description
---

Add alerts for PXF availability.
The availability could be same as its service check. (by hitting the version 
api)


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/44119/diff/


Testing
---

Manually tested. 


--
Ran 275 tests in 6.876s

OK
--
Total run:924
Total errors:0
Total failures:0
OK


Thanks,

jun aoki



Re: Review Request 44119: Alerts for PXF component status

2016-02-29 Thread jun aoki


> On March 1, 2016, 1:38 a.m., Oleksandr Diachenko wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
> >  line 88
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line88>
> >
> > +1 for using Fail instead of Exception. Some of try-except blocks might 
> > be expection type Fail, not Exception and exception wouldn't be handled 
> > propertly.

Actually this script itself is the one who handles it, and it handles 
Exception, instead of Fail.


> On March 1, 2016, 1:38 a.m., Oleksandr Diachenko wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
> >  line 121
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line121>
> >
> > Better to raise Fail.

Same as above


> On March 1, 2016, 1:38 a.m., Oleksandr Diachenko wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
> >  line 127
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line127>
> >
> > There is JIRA in current trunk, which changed version response to this 
> > format:
> > { "version": "v14"}
> > https://issues.apache.org/jira/browse/HAWQ-340
> > 
> > So patch for trunk might be expect new response format.

Yes, the new version is what we certify here. (See also the unit test)


> On March 1, 2016, 1:38 a.m., Oleksandr Diachenko wrote:
> > ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py, 
> > line 26
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272831#file1272831line26>
> >
> > Are we using all files which we are importing? If no, I would 
> > explicitly import whatever you need only.

Good point. WIll fix it.


- jun


-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121376
---


On Feb. 29, 2016, 11:50 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> ---
> 
> (Updated Feb. 29, 2016, 11:50 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> ---
> 
> Manually tested. 
> 
> 
> --
> Ran 275 tests in 6.876s
> 
> OK
> --
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>



Re: Review Request 44119: Alerts for PXF component status

2016-02-29 Thread jun aoki


> On March 1, 2016, 1:38 a.m., Oleksandr Diachenko wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
> >  line 106
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line106>
> >
> > Extra space and colon needed?

Good point. will fix.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121376
-------


On Feb. 29, 2016, 11:50 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> ---
> 
> (Updated Feb. 29, 2016, 11:50 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> ---
> 
> Manually tested. 
> 
> 
> --
> Ran 275 tests in 6.876s
> 
> OK
> --
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>



[jira] [Commented] (AMBARI-15189) Set dfs.allow.truncate = True on HDFS during HAWQ install or add service

2016-02-29 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173069#comment-15173069
 ] 

jun aoki commented on AMBARI-15189:
---

Committed to branch-2.2
f3051f953f4cad56c9e8b8c162038f2f75a5a00e
Committed to trunk
a323c387f37b669e9cd7963f1535680abf20f8c2

> Set dfs.allow.truncate = True on HDFS during HAWQ install or add service
> 
>
> Key: AMBARI-15189
> URL: https://issues.apache.org/jira/browse/AMBARI-15189
> Project: Ambari
>  Issue Type: Improvement
>  Components: ambari-server
>Affects Versions: trunk, 2.2.0
>Reporter: Lav Jain
>Assignee: Lav Jain
> Fix For: 2.3.0, 2.2.2
>
> Attachments: AMBARI-15189.branch22.patch, AMBARI-15189.patch
>
>
> Setting this param to True is Mandatory, otherwise, failed transactions in 
> HAWQ might generate too many small files and will impact performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 44119: Alerts for PXF component status

2016-02-29 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/
---

(Updated Feb. 29, 2016, 11:50 p.m.)


Review request for Ambari.


Changes
---

Applied feedback


Bugs: AMBARI-15211
https://issues.apache.org/jira/browse/AMBARI-15211


Repository: ambari


Description
---

Add alerts for PXF availability.
The availability could be same as its service check. (by hitting the version 
api)


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/44119/diff/


Testing
---

Manually tested. 


--
Ran 275 tests in 6.876s

OK
--
Total run:924
Total errors:0
Total failures:0
OK


Thanks,

jun aoki



[jira] [Updated] (AMBARI-15211) Alerts for PXF component status

2016-02-29 Thread jun aoki (JIRA)

 [ 
https://issues.apache.org/jira/browse/AMBARI-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jun aoki updated AMBARI-15211:
--
Attachment: AMBARI-15211-branch-2.2.v2.patch

> Alerts for PXF component status
> ---
>
> Key: AMBARI-15211
> URL: https://issues.apache.org/jira/browse/AMBARI-15211
> Project: Ambari
>  Issue Type: Bug
>  Components: alerts
>    Reporter: jun aoki
>Assignee: jun aoki
>Priority: Minor
> Attachments: AMBARI-15211-branch-2.2.patch, 
> AMBARI-15211-branch-2.2.v2.patch
>
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 44119: Alerts for PXF component status

2016-02-29 Thread jun aoki


> On Feb. 27, 2016, 1:11 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
> >  line 157
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line157>
> >
> > Is there a case where the alert is CRITICAL?
> > 
> > If PXF component which is on the same host as NAMENODE, would that be 
> > CRITICAL? Or PXF service would still be operational as a whole relying on 
> > other PXF hostcomponents.

Good that you brought up. I will stick with WARNING since a PXF being down is 
not a critical situation, but I will follow up for other cases where it should 
be CRITICAL and will make jira tickets.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121027
-------


On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> ---
> 
> (Updated Feb. 27, 2016, 12:35 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> ---
> 
> Manually tested. 
> 
> 
> ------
> Ran 275 tests in 6.876s
> 
> OK
> --
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>



Re: Review Request 44119: Alerts for PXF component status

2016-02-29 Thread jun aoki


> On Feb. 27, 2016, 1:11 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
> >  line 72
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line72>
> >
> > The log is common to all alerts which are run. It would be better to 
> > say which alert it is, for making debugging easier in the future.
> > 
> > logger.info("[Alert PXF API]: getting delegation token from 
> > {0}".format(url))
> > 
> > Consider other logger messages as well.

@Matt, I wonder if all callers of logger have to write where it is, it would 
defeat the purpose of logger? The callers should only write level (info, debug, 
warn) and what it wants to log. 
On the other hand, timestamp, py file name and possibly lines should be logged 
by logger only when it is configured so? (also see log4j's "F" format)
Let me know if I'm totally mistaken here with python's logger.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121027
---


On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> ---
> 
> (Updated Feb. 27, 2016, 12:35 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> ---
> 
> Manually tested. 
> 
> 
> ------
> Ran 275 tests in 6.876s
> 
> OK
> --
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>



Re: Review Request 44119: Alerts for PXF component status

2016-02-29 Thread jun aoki


> On Feb. 27, 2016, 1:11 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
> >  line 150
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line150>
> >
> > The part of the message 'PXF is not functional' is already covered on 
> > Line 155. If you don't want to repeat the same information, you may delete 
> > it.

Good point. will delete it.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121027
-------


On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> ---
> 
> (Updated Feb. 27, 2016, 12:35 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> ---
> 
> Manually tested. 
> 
> 
> ------
> Ran 275 tests in 6.876s
> 
> OK
> --
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>



Re: Review Request 44119: Alerts for PXF component status

2016-02-29 Thread jun aoki


> On Feb. 27, 2016, 1:09 a.m., Goutam Tadi wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
> >  line 88
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line88>
> >
> > raise Exception(msg) or raise Fail(msg) ? I see throwing Fail(msg) in 
> > implementation.

Intresting. It is acutally the same thing 
https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/core/exceptions.py#L25


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121031
-------


On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> ---
> 
> (Updated Feb. 27, 2016, 12:35 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> ---
> 
> Manually tested. 
> 
> 
> ------
> Ran 275 tests in 6.876s
> 
> OK
> --
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>



Re: Review Request 44119: Alerts for PXF component status

2016-02-29 Thread jun aoki


> On Feb. 27, 2016, 12:45 a.m., Goutam Tadi wrote:
> > ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py, 
> > line 28
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272831#file1272831line28>
> >
> > Can we use like the one following 
> > ```
> > COMMON_SERVICES_PACKAGE_DIR = "PXF/3.0.0/package"
> > ```
> > 
> > in ambari-server/src/test/python/stacks/2.3/PXF/test_pxf.py

I am kind of mimicing this 
https://github.com/apache/ambari/blob/trunk/ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py#L33
 but use a bunch of ".." instead of a bunch of dirname methods.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121020
-------


On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> ---
> 
> (Updated Feb. 27, 2016, 12:35 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> ---
> 
> Manually tested. 
> 
> 
> ----------
> Ran 275 tests in 6.876s
> 
> OK
> --
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>



Re: Review Request 44119: Alerts for PXF component status

2016-02-29 Thread jun aoki


> On Feb. 27, 2016, 1 a.m., Goutam Tadi wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
> >  line 112
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line112>
> >
> > When I went through other methods in PXF we followed a convention 
> > "__get_pxf_protocol" (used double underscore at start). Though it does not 
> > affect the functionality, I would just like to give a hint.

I have a unit test that refers the method and if it 2 double underscores, the 
test won't be able to see it.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121028
-------


On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> ---
> 
> (Updated Feb. 27, 2016, 12:35 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> ---
> 
> Manually tested. 
> 
> 
> ----------
> Ran 275 tests in 6.876s
> 
> OK
> --
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>



Re: Review Request 44119: Alerts for PXF component status

2016-02-29 Thread jun aoki


> On Feb. 27, 2016, 1:02 a.m., Goutam Tadi wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
> >  line 65
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line65>
> >
> > Do you want  a ")" at the end for the comment?

thank you for letting me know. This line should be actually deleted. (some old 
code)


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121030
-------


On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> ---
> 
> (Updated Feb. 27, 2016, 12:35 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> ---
> 
> Manually tested. 
> 
> 
> ----------
> Ran 275 tests in 6.876s
> 
> OK
> --
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>



Re: Review Request 44119: Alerts for PXF component status

2016-02-29 Thread jun aoki


> On Feb. 27, 2016, 1 a.m., Goutam Tadi wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
> >  line 21
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line21>
> >
> > I see other implementations used 
> > ```
> > from resource_management.core.logger import Logger
> > ```
> > Can we consider this for logging?

I followed this convention
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py#L35
Let me know if you have a strong preference for the change.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121028
-------


On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> ---
> 
> (Updated Feb. 27, 2016, 12:35 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> ---
> 
> Manually tested. 
> 
> 
> ------
> Ran 275 tests in 6.876s
> 
> OK
> --
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>



[jira] [Commented] (AMBARI-15175) Hide Custom configuration category for files which does not support custom configuration in HAWQ and PXF

2016-02-29 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172678#comment-15172678
 ] 

jun aoki commented on AMBARI-15175:
---

Committed to trunk
8d38f163852e07318ef15a46cc1baf4f7cba055d
Committed to branch-2.2
5a04ef2c3633044a96d57ad03ba27eefd5243f53

> Hide Custom configuration category for files which does not support custom 
> configuration in HAWQ and PXF
> 
>
> Key: AMBARI-15175
> URL: https://issues.apache.org/jira/browse/AMBARI-15175
> Project: Ambari
>  Issue Type: Sub-task
>  Components: ambari-web, stacks
>Affects Versions: trunk, 2.2.0
>Reporter: bhuvnesh chaudhary
>Assignee: bhuvnesh chaudhary
>Priority: Minor
> Fix For: trunk, 2.2.0
>
> Attachments: AMBARI-15175-branch-2.2.patch, AMBARI-15175.patch
>
>
> Hide Custom configuration category for files which does not support custom 
> configuration in HAWQ and PXF



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 44055: Hide Custom configuration category for files which does not support custom configuration in HAWQ and PXF

2016-02-29 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44055/#review121323
---


Ship it!




Ship It!

- jun aoki


On Feb. 26, 2016, 6:11 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44055/
> ---
> 
> (Updated Feb. 26, 2016, 6:11 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, 
> Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15175
> https://issues.apache.org/jira/browse/AMBARI-15175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This minor patch hides custom configuration category for files which does not 
> support custom configuration in HAWQ and PXF
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/stack_service.js d9edf6e 
> 
> Diff: https://reviews.apache.org/r/44055/diff/
> 
> 
> Testing
> ---
> 
> yes. manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>



Re: Review Request 44055: Hide Custom configuration category for files which does not support custom configuration in HAWQ and PXF

2016-02-29 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44055/#review121322
---




ambari-web/app/models/stack_service.js (line 402)
<https://reviews.apache.org/r/44055/#comment183006>

Good stuff!


- jun aoki


On Feb. 26, 2016, 6:11 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44055/
> ---
> 
> (Updated Feb. 26, 2016, 6:11 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, 
> Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15175
> https://issues.apache.org/jira/browse/AMBARI-15175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This minor patch hides custom configuration category for files which does not 
> support custom configuration in HAWQ and PXF
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/stack_service.js d9edf6e 
> 
> Diff: https://reviews.apache.org/r/44055/diff/
> 
> 
> Testing
> ---
> 
> yes. manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>



Re: Review Request 44119: Alerts for PXF component status

2016-02-29 Thread jun aoki


> On Feb. 27, 2016, 12:49 a.m., Goutam Tadi wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py,
> >  line 90
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line90>
> >
> > There is one makeHTTPCall() in Pxfutils.py. Is this doing anything 
> > different. If yes, overloaded method can be used there.

@Matt told you can not import anything from main code, thus it is duplicated 
here.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121021
-------


On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> ---
> 
> (Updated Feb. 27, 2016, 12:35 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44119/diff/
> 
> 
> Testing
> ---
> 
> Manually tested. 
> 
> 
> ------
> Ran 275 tests in 6.876s
> 
> OK
> --
> Total run:924
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> jun aoki
> 
>



[jira] [Commented] (AMBARI-15172) HAWQ temp directories should not be /tmp

2016-02-29 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172551#comment-15172551
 ] 

jun aoki commented on AMBARI-15172:
---

Committed to branch-2.2
45a4a0e44eeb29d7a140b26b37e36156fbda0c30
Committed to trunk
ba59c242d65428e1ebcf7758a2dd7de3e90c7f5b

> HAWQ temp directories should not be /tmp
> 
>
> Key: AMBARI-15172
> URL: https://issues.apache.org/jira/browse/AMBARI-15172
> Project: Ambari
>  Issue Type: Improvement
>Reporter: Alexander Denissov
>Assignee: Alexander Denissov
>Priority: Minor
> Fix For: 2.2.2
>
> Attachments: AMBARI-15172.branch_2_2.patch, AMBARI-15172.trunk.patch, 
> AMBARI-15172.trunk.patch.1
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15172) HAWQ temp directories should not be /tmp

2016-02-29 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172382#comment-15172382
 ] 

jun aoki commented on AMBARI-15172:
---

[~adenisso], could you please add a reviewboard for especially the trunk patch. 
It is bigger because I believe it includes some unit tests as trunk has some 
unit tests for HAWQ.

> HAWQ temp directories should not be /tmp
> 
>
> Key: AMBARI-15172
> URL: https://issues.apache.org/jira/browse/AMBARI-15172
> Project: Ambari
>  Issue Type: Improvement
>Reporter: Alexander Denissov
>Assignee: Alexander Denissov
>Priority: Minor
> Fix For: 2.2.2
>
> Attachments: AMBARI-15172.branch_2_2.patch, AMBARI-15172.trunk.patch, 
> AMBARI-15172.trunk.patch.1
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15104) Update description for HAWQ Sync standby alert

2016-02-26 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170259#comment-15170259
 ] 

jun aoki commented on AMBARI-15104:
---

Committed to trunk
a281dfc097df502ed0b9941ea2e57c30b1d032ba
Committed to branch-2.2
0a76a076d002938862d8c3c142ebe35bfabb2054

> Update description for HAWQ Sync standby alert
> --
>
> Key: AMBARI-15104
> URL: https://issues.apache.org/jira/browse/AMBARI-15104
> Project: Ambari
>  Issue Type: Sub-task
>  Components: stacks
>Reporter: Matt
>Assignee: Matt
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-15104-branch-2.2-orig.patch, 
> AMBARI-15104-branch-2.2-v1.patch, AMBARI-15104-branch-2.2-v2.patch, 
> AMBARI-15104-trunk-orig.patch, AMBARI-15104-trunk-v1.patch, 
> AMBARI-15104-trunk-v2.patch
>
>
> Update the description for the alert so that the user knows what to do if the 
> alert is triggered from the description on the alert page



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15104) Update description for HAWQ Sync standby alert

2016-02-26 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170258#comment-15170258
 ] 

jun aoki commented on AMBARI-15104:
---

This is a minor comment change and very specific to HAWQ so I go ahead and 
commit

> Update description for HAWQ Sync standby alert
> --
>
> Key: AMBARI-15104
> URL: https://issues.apache.org/jira/browse/AMBARI-15104
> Project: Ambari
>  Issue Type: Sub-task
>  Components: stacks
>Reporter: Matt
>Assignee: Matt
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-15104-branch-2.2-orig.patch, 
> AMBARI-15104-branch-2.2-v1.patch, AMBARI-15104-branch-2.2-v2.patch, 
> AMBARI-15104-trunk-orig.patch, AMBARI-15104-trunk-v1.patch, 
> AMBARI-15104-trunk-v2.patch
>
>
> Update the description for the alert so that the user knows what to do if the 
> alert is triggered from the description on the alert page



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15104) Update description for HAWQ Sync standby alert

2016-02-26 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170257#comment-15170257
 ] 

jun aoki commented on AMBARI-15104:
---

+1

> Update description for HAWQ Sync standby alert
> --
>
> Key: AMBARI-15104
> URL: https://issues.apache.org/jira/browse/AMBARI-15104
> Project: Ambari
>  Issue Type: Sub-task
>  Components: stacks
>Reporter: Matt
>Assignee: Matt
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-15104-branch-2.2-orig.patch, 
> AMBARI-15104-branch-2.2-v1.patch, AMBARI-15104-branch-2.2-v2.patch, 
> AMBARI-15104-trunk-orig.patch, AMBARI-15104-trunk-v1.patch, 
> AMBARI-15104-trunk-v2.patch
>
>
> Update the description for the alert so that the user knows what to do if the 
> alert is triggered from the description on the alert page



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (AMBARI-15211) Alerts for PXF component status

2016-02-26 Thread jun aoki (JIRA)

 [ 
https://issues.apache.org/jira/browse/AMBARI-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jun aoki updated AMBARI-15211:
--
Attachment: AMBARI-15211-branch-2.2.patch

> Alerts for PXF component status
> ---
>
> Key: AMBARI-15211
> URL: https://issues.apache.org/jira/browse/AMBARI-15211
> Project: Ambari
>  Issue Type: Bug
>  Components: alerts
>    Reporter: jun aoki
>Assignee: jun aoki
>Priority: Minor
> Attachments: AMBARI-15211-branch-2.2.patch
>
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version 
> api)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Review Request 44119: Alerts for PXF component status

2016-02-26 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/
---

Review request for Ambari.


Bugs: AMBARI-15211
https://issues.apache.org/jira/browse/AMBARI-15211


Repository: ambari


Description
---

Add alerts for PXF availability.
The availability could be same as its service check. (by hitting the version 
api)


Diffs
-

  ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/44119/diff/


Testing
---

Manually tested. 


--
Ran 275 tests in 6.876s

OK
--
Total run:924
Total errors:0
Total failures:0
OK


Thanks,

jun aoki



[jira] [Created] (AMBARI-15211) Alerts for PXF component status

2016-02-26 Thread jun aoki (JIRA)
jun aoki created AMBARI-15211:
-

 Summary: Alerts for PXF component status
 Key: AMBARI-15211
 URL: https://issues.apache.org/jira/browse/AMBARI-15211
 Project: Ambari
  Issue Type: Bug
  Components: alerts
Reporter: jun aoki
Assignee: jun aoki
Priority: Minor


Add alerts for PXF availability.
The availability could be same as its service check. (by hitting the version 
api)




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-13439) Unit tests for the HAWQ service under common-services

2016-02-26 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-13439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169732#comment-15169732
 ] 

jun aoki commented on AMBARI-13439:
---

Committed to trunk
2f8636e5eafa4d9d26097a6e0d8f8dcde59d2e75

[~nalex], is this only for trunk?

> Unit tests for the HAWQ service under common-services
> -
>
> Key: AMBARI-13439
> URL: https://issues.apache.org/jira/browse/AMBARI-13439
> Project: Ambari
>  Issue Type: Task
>  Components: ambari-server
>Affects Versions: 2.1.2
>Reporter: Newton Alex
>Assignee: Newton Alex
>Priority: Minor
> Fix For: 2.3.0, trunk
>
> Attachments: AMBARI-13439.patch, AMBARI-13439_trunk-1.patch, 
> AMBARI-13439_trunk-2.patch
>
>
> This is a follow up task to AMBARI-12320. We have to add unit tests for HAWQ 
> service under common-services.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15105) Add alerts for HAWQ components status

2016-02-25 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168134#comment-15168134
 ] 

jun aoki commented on AMBARI-15105:
---

committed to branch-2.2
27e510b82aefd61b31d3da4f420b455689516603
committed to trunk
29115e81ee2ba6643c7725903300f070c4ba2ea5

> Add alerts for HAWQ components status
> -
>
> Key: AMBARI-15105
> URL: https://issues.apache.org/jira/browse/AMBARI-15105
> Project: Ambari
>  Issue Type: New Feature
>  Components: alerts
>Affects Versions: trunk, 2.2.0
>Reporter: bhuvnesh chaudhary
>Assignee: bhuvnesh chaudhary
> Fix For: trunk, 2.2.0
>
> Attachments: AMBARI-15105-1.patch, AMBARI-15105-2.patch, 
> AMBARI-15105-3.patch, AMBARI-15105.patch
>
>
> Add alerts for HAWQ components based on PORT. The below components are 
> covered.
> - Master
> - Standby
> - Segment



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43748: Add alerts for HAWQ components status

2016-02-25 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review120802
---


Ship it!




Ship It!

- jun aoki


On Feb. 25, 2016, 7:56 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> ---
> 
> (Updated Feb. 25, 2016, 7:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, 
> Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit 
> Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
> https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch introduces alerts for HAWQ components based on PORT. The below 
> components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 
> 3119a0c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_component_status.py
>  PRE-CREATION 
>   
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_component_status.py 
> PRE-CREATION 
>   ambari-web/app/views/main/dashboard/widgets.js 8a86af6 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> ---
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>



Re: Review Request 44040: Show swap memory for HAWQ Segment hosts

2016-02-25 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44040/#review120788
---


Ship it!




Ship It!

- jun aoki


On Feb. 25, 2016, 9:03 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44040/
> ---
> 
> (Updated Feb. 25, 2016, 9:03 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Lav Jain, and Newton Alex.
> 
> 
> Bugs: AMBARI-15191
> https://issues.apache.org/jira/browse/AMBARI-15191
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the HAWQ service page, show swap memory utilization for HAWQ Segment 
> hosts, on the existing memory widget.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/widgets.json 
> 48ae989 
> 
> Diff: https://reviews.apache.org/r/44040/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 44040: Show swap memory for HAWQ Segment hosts

2016-02-25 Thread jun aoki


> On Feb. 25, 2016, 9:05 p.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/widgets.json, 
> > line 138
> > <https://reviews.apache.org/r/44040/diff/1/?file=1271283#file1271283line138>
> >
> > Fixing an aggregation issue.
> > 
> > The mem_total across all segment hosts should be summed up and 
> > expressed as a percentage.

Was it average previously instead of summary?


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44040/#review120766
---


On Feb. 25, 2016, 9:03 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44040/
> ---
> 
> (Updated Feb. 25, 2016, 9:03 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Lav Jain, and Newton Alex.
> 
> 
> Bugs: AMBARI-15191
> https://issues.apache.org/jira/browse/AMBARI-15191
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the HAWQ service page, show swap memory utilization for HAWQ Segment 
> hosts, on the existing memory widget.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/widgets.json 
> 48ae989 
> 
> Diff: https://reviews.apache.org/r/44040/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> 
> Thanks,
> 
> Matt
> 
>



[jira] [Commented] (AMBARI-14987) assign_master_component.js does not show recommendations while adding master component for a service which is already installed

2016-02-25 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-14987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167975#comment-15167975
 ] 

jun aoki commented on AMBARI-14987:
---

Committed to branch-2.2
b0a7149373d48e2c7b4cce06b0b26a6d1c87b0ec
Committed to trunk
f495bbc02e462981720956b5e61ec102f746728f

> assign_master_component.js does not show recommendations while adding master 
> component for a service which is already installed
> ---
>
> Key: AMBARI-14987
> URL: https://issues.apache.org/jira/browse/AMBARI-14987
> Project: Ambari
>  Issue Type: Bug
>  Components: ambari-web
>Reporter: Matt
>Assignee: Matt
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-14987-branch-2.2-feedback-orig.patch, 
> AMBARI-14987-branch-2.2-v1.patch, AMBARI-14987-branch-2.2-v2.patch, 
> AMBARI-14987-branch-2.2.patch, AMBARI-14987-trunk-feedback-orig.patch, 
> AMBARI-14987-trunk-v1.patch, AMBARI-14987-trunk-v2.patch, 
> AMBARI-14987-trunk-v3.patch, AMBARI-14987-trunk.patch
>
>
> On the assign masters page for the wizard, recommendations are not shown for 
> a master component that is being added for an installed service.
> This happens while adding HAWQSTANDBY to the cluster using the 'Add 
> HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the 
> cluster). 
> The fix might also solve the issue where there is a installed service and the 
> upgrade of the service includes installing a new master component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-14987) assign_master_component.js does not show recommendations while adding master component for a service which is already installed

2016-02-25 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-14987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167966#comment-15167966
 ] 

jun aoki commented on AMBARI-14987:
---

Good work both [~mithmatt] and [~aantonenko]! will commit this.

> assign_master_component.js does not show recommendations while adding master 
> component for a service which is already installed
> ---
>
> Key: AMBARI-14987
> URL: https://issues.apache.org/jira/browse/AMBARI-14987
> Project: Ambari
>  Issue Type: Bug
>  Components: ambari-web
>Reporter: Matt
>Assignee: Matt
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-14987-branch-2.2-feedback-orig.patch, 
> AMBARI-14987-branch-2.2-v1.patch, AMBARI-14987-branch-2.2-v2.patch, 
> AMBARI-14987-branch-2.2.patch, AMBARI-14987-trunk-feedback-orig.patch, 
> AMBARI-14987-trunk-v1.patch, AMBARI-14987-trunk-v2.patch, 
> AMBARI-14987-trunk-v3.patch, AMBARI-14987-trunk.patch
>
>
> On the assign masters page for the wizard, recommendations are not shown for 
> a master component that is being added for an installed service.
> This happens while adding HAWQSTANDBY to the cluster using the 'Add 
> HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the 
> cluster). 
> The fix might also solve the issue where there is a installed service and the 
> upgrade of the service includes installing a new master component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43973: Hide Custom configuration category for files which does not support custom configuration in HAWQ and PXF

2016-02-25 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43973/#review120781
---


Ship it!




Ship It!

- jun aoki


On Feb. 25, 2016, 12:52 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43973/
> ---
> 
> (Updated Feb. 25, 2016, 12:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, 
> Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15175
> https://issues.apache.org/jira/browse/AMBARI-15175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This minor patch hides custom configuration category for files which does not 
> support custom configuration in HAWQ and PXF
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml
>  a948bae 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  32ae5a5 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml
>  8319741 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-public-classpath.xml
>  7538ee5 
> 
> Diff: https://reviews.apache.org/r/43973/diff/
> 
> 
> Testing
> ---
> 
> yes. manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>



Re: Review Request 43968: Updated HAWQ temporary directories from /tmp to /tmp/hawq/master and /tmp/hawq/segment respecitvely

2016-02-24 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43968/#review120613
---


Ship it!




Ship It!

- jun aoki


On Feb. 24, 2016, 11:13 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43968/
> ---
> 
> (Updated Feb. 24, 2016, 11:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Jayush Luniya, Lav Jain, Matt, Newton Alex, Oleksandr 
> Diachenko, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15172
> https://issues.apache.org/jira/browse/AMBARI-15172
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated HAWQ temporary directories from /tmp to /tmp/hawq/master and 
> /tmp/hawq/segment respecitvely
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  f195215 
> 
> Diff: https://reviews.apache.org/r/43968/diff/
> 
> 
> Testing
> ---
> 
> manual testing. unit tests will beupdated tomorrow once the unit tests patch 
> is committed.
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>



[jira] [Commented] (AMBARI-14821) Unit tests doesn't export scripts from common-services folder into PYTHONPATH

2016-02-23 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-14821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159910#comment-15159910
 ] 

jun aoki commented on AMBARI-14821:
---

Committed to trunk
d032056754246880a48939255784767bc31302e4

> Unit tests doesn't export scripts from common-services folder into PYTHONPATH
> -
>
> Key: AMBARI-14821
> URL: https://issues.apache.org/jira/browse/AMBARI-14821
> Project: Ambari
>  Issue Type: Bug
>Reporter: Newton Alex
>Assignee: Newton Alex
>Priority: Minor
> Fix For: trunk
>
> Attachments: AMBARI-14821_trunk.patch
>
>
> When running unit tests with mocks like
> ---
>   @patch ('hawqmaster.common.__set_osparams')
>   @patch ('hawqmaster.master_helper.__is_active_master')
>   @patch ('hawqmaster.master_helper.__is_local_initialized')
>   def test_start_default(self, is_local_initialized_mock, active_master_mock, 
> set_osparams_mock):
> ...
> 
> the unit tests fail with the following msg:
> 
> Failed tests:
> ERROR: test_configure_default (test_hawqmaster.TestHawqMaster)
> --
> Traceback (most recent call last):
>   File 
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 1191, in patched
> arg = patching.__enter__()
>   File 
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 1250, in __enter__
> self.target = self.getter()
>   File 
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 1412, in 
> getter = lambda: _importer(target)
>   File 
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 1096, in _importer
> thing = __import__(import_path)
> ImportError: No module named hawqmaster
> -
> the source scripts from common-services are not getting exported into 
> PYTHONPATH during unittest execution.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (AMBARI-14821) Unit tests doesn't export scripts from common-services folder into PYTHONPATH

2016-02-23 Thread jun aoki (JIRA)

 [ 
https://issues.apache.org/jira/browse/AMBARI-14821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jun aoki updated AMBARI-14821:
--
Fix Version/s: trunk

> Unit tests doesn't export scripts from common-services folder into PYTHONPATH
> -
>
> Key: AMBARI-14821
> URL: https://issues.apache.org/jira/browse/AMBARI-14821
> Project: Ambari
>  Issue Type: Bug
>Reporter: Newton Alex
>Assignee: Newton Alex
>Priority: Minor
> Fix For: trunk
>
> Attachments: AMBARI-14821_trunk.patch
>
>
> When running unit tests with mocks like
> ---
>   @patch ('hawqmaster.common.__set_osparams')
>   @patch ('hawqmaster.master_helper.__is_active_master')
>   @patch ('hawqmaster.master_helper.__is_local_initialized')
>   def test_start_default(self, is_local_initialized_mock, active_master_mock, 
> set_osparams_mock):
> ...
> 
> the unit tests fail with the following msg:
> 
> Failed tests:
> ERROR: test_configure_default (test_hawqmaster.TestHawqMaster)
> --
> Traceback (most recent call last):
>   File 
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 1191, in patched
> arg = patching.__enter__()
>   File 
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 1250, in __enter__
> self.target = self.getter()
>   File 
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 1412, in 
> getter = lambda: _importer(target)
>   File 
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 1096, in _importer
> thing = __import__(import_path)
> ImportError: No module named hawqmaster
> -
> the source scripts from common-services are not getting exported into 
> PYTHONPATH during unittest execution.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15124) Can't install ambari-server in Docker environment

2016-02-22 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157982#comment-15157982
 ] 

jun aoki commented on AMBARI-15124:
---

Committed to trunk
0682fb603f96bf9ded5333b19751011399c33099

> Can't install ambari-server in Docker environment
> -
>
> Key: AMBARI-15124
> URL: https://issues.apache.org/jira/browse/AMBARI-15124
> Project: Ambari
>  Issue Type: Bug
>Affects Versions: trunk
> Environment: Docker
>Reporter: Masahiro TANAKA
>Priority: Minor
>  Labels: easyfix, patch
> Attachments: AMBARI-15124.patch
>
>
> I tried to install and run ambari-server with Docker referring to 
> [this|https://cwiki.apache.org/confluence/display/AMBARI/Development+in+Docker#DevelopmentinDocker-CreateDockerImage]
>  then I got an error.
> {code:none}
> $ sudo docker rm ambari1
> $ sudo docker run --privileged -t -p 80:80 -p 5005:5005 -p 8080:8080 -h 
> node1.mydomain.com --name ambari1 -v $(pwd):/tmp/ambari ambari/build 
> /tmp/ambari-build-docker/bin/ambaribuild.py server -b
> ...(snip)...
> Traceback (most recent call last):
>   File "/tmp/ambari-build-docker/bin/ambaribuild.py", line 239, in 
> retcode = install_ambari_server()
>   File "/tmp/ambari-build-docker/bin/ambaribuild.py", line 52, in 
> install_ambari_server
> cwd="/tmp/ambari/ambari-server/target/rpm/ambari-server/RPMS/noarch")
>   File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__
> errread, errwrite)
>   File "/usr/lib64/python2.6/subprocess.py", line 1238, in _execute_child
> raise child_exception
> OSError: [Errno 2] No such file or directory: 
> '/tmp/ambari/ambari-server/target/rpm/ambari-server/RPMS/noarch'
> {code}
> I think ambari-server-*.rpm is x86_64, and is in 
> ambari-server/target/rpm/ambari-server/RPMS/x86_64



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15124) Can't install ambari-server in Docker environment

2016-02-22 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157970#comment-15157970
 ] 

jun aoki commented on AMBARI-15124:
---

[~masatana], thank you for your contribution. Good catch!

> Can't install ambari-server in Docker environment
> -
>
> Key: AMBARI-15124
> URL: https://issues.apache.org/jira/browse/AMBARI-15124
> Project: Ambari
>  Issue Type: Bug
>Affects Versions: trunk
> Environment: Docker
>Reporter: Masahiro TANAKA
>Priority: Minor
>  Labels: easyfix, patch
> Attachments: AMBARI-15124.patch
>
>
> I tried to install and run ambari-server with Docker referring to 
> [this|https://cwiki.apache.org/confluence/display/AMBARI/Development+in+Docker#DevelopmentinDocker-CreateDockerImage]
>  then I got an error.
> {code:none}
> $ sudo docker rm ambari1
> $ sudo docker run --privileged -t -p 80:80 -p 5005:5005 -p 8080:8080 -h 
> node1.mydomain.com --name ambari1 -v $(pwd):/tmp/ambari ambari/build 
> /tmp/ambari-build-docker/bin/ambaribuild.py server -b
> ...(snip)...
> Traceback (most recent call last):
>   File "/tmp/ambari-build-docker/bin/ambaribuild.py", line 239, in 
> retcode = install_ambari_server()
>   File "/tmp/ambari-build-docker/bin/ambaribuild.py", line 52, in 
> install_ambari_server
> cwd="/tmp/ambari/ambari-server/target/rpm/ambari-server/RPMS/noarch")
>   File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__
> errread, errwrite)
>   File "/usr/lib64/python2.6/subprocess.py", line 1238, in _execute_child
> raise child_exception
> OSError: [Errno 2] No such file or directory: 
> '/tmp/ambari/ambari-server/target/rpm/ambari-server/RPMS/noarch'
> {code}
> I think ambari-server-*.rpm is x86_64, and is in 
> ambari-server/target/rpm/ambari-server/RPMS/x86_64



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43805: AMBARI-15124: Can't install ambari-server in Docker environment

2016-02-22 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43805/#review120219
---


Ship it!





dev-support/docker/docker/bin/ambaribuild.py (line 50)
<https://reviews.apache.org/r/43805/#comment181646>

Indeed, it has been changed to x86_64. Good catch!


- jun aoki


On Feb. 21, 2016, 12:24 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43805/
> ---
> 
> (Updated Feb. 21, 2016, 12:24 a.m.)
> 
> 
> Review request for Ambari and jun aoki.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I tried to install and run ambari-server with Docker referring to 
> https://cwiki.apache.org/confluence/display/AMBARI/Development+in+Docker#DevelopmentinDocker-CreateDockerImage
>  then I got an error.
> 
> ```
> $ sudo docker rm ambari1
> $ sudo docker run --privileged -t -p 80:80 -p 5005:5005 -p 8080:8080 -h 
> node1.mydomain.com --name ambari1 -v $(pwd):/tmp/ambari ambari/build 
> /tmp/ambari-build-docker/bin/ambaribuild.py server -b
> 
> ...(snip)...
> 
> Traceback (most recent call last):
>   File "/tmp/ambari-build-docker/bin/ambaribuild.py", line 239, in 
> retcode = install_ambari_server()
>   File "/tmp/ambari-build-docker/bin/ambaribuild.py", line 52, in 
> install_ambari_server
> cwd="/tmp/ambari/ambari-server/target/rpm/ambari-server/RPMS/noarch")
>   File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__
> errread, errwrite)
>   File "/usr/lib64/python2.6/subprocess.py", line 1238, in _execute_child
> raise child_exception
> OSError: [Errno 2] No such file or directory: 
> '/tmp/ambari/ambari-server/target/rpm/ambari-server/RPMS/noarch'
> ```
> 
> I think ambari-server-*.rpm is x86_64, and is in 
> ambari-server/target/rpm/ambari-server/RPMS/x86_64
> 
> 
> Diffs
> -
> 
>   dev-support/docker/docker/bin/ambaribuild.py 50db0e2 
> 
> Diff: https://reviews.apache.org/r/43805/diff/
> 
> 
> Testing
> ---
> 
> Manually testing done
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>



[jira] [Commented] (AMBARI-15103) Move HAWQ system password to General Accordion tab

2016-02-22 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157874#comment-15157874
 ] 

jun aoki commented on AMBARI-15103:
---

Committed to branch-2.2
217d5fea57b0bd900b07116e95a7e488d688ea76
Committed to trunk
d741e438db58bcea2d59f902ccf9d7ad40097b7f


> Move HAWQ system password to General Accordion tab
> --
>
> Key: AMBARI-15103
> URL: https://issues.apache.org/jira/browse/AMBARI-15103
> Project: Ambari
>  Issue Type: Sub-task
>  Components: ambari-web
>Reporter: Matt
>Assignee: Matt
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-15103-branch-2.2-orig.patch, 
> AMBARI-15103-trunk-orig.patch
>
>
> The password is currently under Advanced hawq-env. Move it to General section.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15061) PXF Service checks fails with timeout

2016-02-22 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157864#comment-15157864
 ] 

jun aoki commented on AMBARI-15061:
---

Committed to trunk
49813c987a491d1527f6499927d22746a11f3631
Committed to branch-2.2
8430fbd3929383a6d40dc17b7a58e63a4f780e3c

> PXF Service checks fails with timeout
> -
>
> Key: AMBARI-15061
> URL: https://issues.apache.org/jira/browse/AMBARI-15061
> Project: Ambari
>  Issue Type: Bug
>  Components: stacks
>Affects Versions: trunk, 2.2.0
>Reporter: bhuvnesh chaudhary
>Assignee: bhuvnesh chaudhary
> Fix For: trunk, 2.2.0
>
> Attachments: AMBARI-15061-3.patch, AMBARI-15061-branch-2.2-2.patch
>
>
> During PXF service check, in order to execute hbase / hive command, we do 
> initialize the shell everytime (hbase shell / hive) and then run the command. 
> Initializing the shell takes time and we do that around 3-4 times which 
> consumes majority of the time.
> We should initialize the shell once, and execute the commands using a file 
> instead of doing individually.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-22 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43663/#review120191
---


Ship it!




Ship It!

- jun aoki


On Feb. 21, 2016, 2:19 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43663/
> ---
> 
> (Updated Feb. 21, 2016, 2:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, 
> Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15061
> https://issues.apache.org/jira/browse/AMBARI-15061
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During PXF service check, in order to execute hbase / hive command, we do 
> initialize the shell everytime (hbase shell / hive) and then run the command. 
> Initializing the shell takes time and we do that around 3-4 times which 
> consumes majority of the time.
> We should initialize the shell once, and execute the commands using a file 
> instead of doing individually.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py
>  b3e85e4 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py
>  9d93a38 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
>  21b7c5d 
> 
> Diff: https://reviews.apache.org/r/43663/diff/
> 
> 
> Testing
> ---
> 
> yes. manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>



Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-22 Thread jun aoki


> On Feb. 22, 2016, 8 p.m., jun aoki wrote:
> > Ship It!

With InlineTemplate, it is much clearer!


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43663/#review120191
---


On Feb. 21, 2016, 2:19 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43663/
> ---
> 
> (Updated Feb. 21, 2016, 2:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, 
> Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15061
> https://issues.apache.org/jira/browse/AMBARI-15061
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During PXF service check, in order to execute hbase / hive command, we do 
> initialize the shell everytime (hbase shell / hive) and then run the command. 
> Initializing the shell takes time and we do that around 3-4 times which 
> consumes majority of the time.
> We should initialize the shell once, and execute the commands using a file 
> instead of doing individually.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py
>  b3e85e4 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py
>  9d93a38 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
>  21b7c5d 
> 
> Diff: https://reviews.apache.org/r/43663/diff/
> 
> 
> Testing
> ---
> 
> yes. manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>



Re: Review Request 43845: Unit tests doesn't export scripts from common-services folder into PYTHONPATH

2016-02-22 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43845/#review120187
---


Ship it!




Ship It!

- jun aoki


On Feb. 22, 2016, 6:58 p.m., Newton Alex wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43845/
> ---
> 
> (Updated Feb. 22, 2016, 6:58 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-14821
> https://issues.apache.org/jira/browse/AMBARI-14821
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Unit tests doesn't export scripts from common-services folder into PYTHONPATH
> 
> 
> Diffs
> -
> 
>   ambari-server/src/test/python/unitTests.py 6368ca1 
> 
> Diff: https://reviews.apache.org/r/43845/diff/
> 
> 
> Testing
> ---
> 
> The unit tests passed
> ```
> test_validationMinMax (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> test_validationNamenodeAndSecondaryNamenode2Hosts_noMessagesForSameHost 
> (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> test_validationWarnMessagesIfLessThanDefault 
> (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> test_validatorEnoughDiskSpace (test_stack_advisor.TestHDP206StackAdvisor) ... 
> ok
> --
> Ran 37 tests in 0.077s
> ...
> OK
> Running tests for stack:2.0.6 service:before-INSTALL
> test_hook_default (test_before_install.TestHookBeforeInstall) ... ok
> --
> Ran 1 test in 0.023s
> OK
> Running tests for stack:2.0.6 service:before-START
> test_hook_default (test_before_start.TestHookBeforeStart) ... 2016-02-19 
> 23:10:10,842 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> test_hook_default_hdfs (test_before_start.TestHookBeforeStart) ... 2016-02-19 
> 23:10:10,907 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> test_hook_refresh_topology_custom_directories 
> (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:10,969 - Using 
> hadoop conf dir: /etc/hadoop/conf
> ok
> test_hook_secured (test_before_start.TestHookBeforeStart) ... 2016-02-19 
> 23:10:11,028 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> --
> Ran 4 tests in 0.254s
> OK...
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [7.680s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.244s]
> [INFO] Ambari Web  SUCCESS [1:41.096s]
> [INFO] Ambari Views .. SUCCESS [10.076s]
> [INFO] Ambari Admin View . SUCCESS [15.339s]
> [INFO] ambari-metrics  SUCCESS [0.737s]
> [INFO] Ambari Metrics Common . SUCCESS [3.933s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [6.933s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [4.318s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [5.493s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [3.808s]
> [INFO] Ambari Metrics Collector .. SUCCESS [6:51.190s]
> [INFO] Ambari Metrics Monitor  SUCCESS [3.405s]
> [INFO] Ambari Metrics Grafana  SUCCESS [47.021s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [7:08.869s]
> [INFO] Ambari Server . SUCCESS 
> [1:15:01.678s]
> [INFO] Ambari Functional Tests ... SUCCESS [3.113s]
> [INFO] Ambari Agent .. SUCCESS [1:16.953s]
> [INFO] Ambari Client . SUCCESS [0.212s]
> [INFO] Ambari Python Client .. SUCCESS [3.408s]
> [INFO] Ambari Groovy Client .. SUCCESS [13.774s]
> [INFO] Ambari Shell .. SUCCESS [0.223s]
> [INFO] Ambari Python Shell ... SUCCESS [1.037s]
> [INFO] Ambari Groovy Shell ... SUCCESS [10.407s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:34:21.847s
> [INFO] Finished at: Fri Feb 19 23:16:29 UTC 2016
> [INFO] Final Memory: 301M/1243M
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Newton Alex
> 
>



Re: Review Request 43753: Update description for HAWQ Sync standby alert

2016-02-19 Thread jun aoki


> On Feb. 19, 2016, 10:18 p.m., jun aoki wrote:
> > Ship It!

Except the ongoing discussion


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43753/#review119985
---


On Feb. 19, 2016, 3:33 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43753/
> ---
> 
> (Updated Feb. 19, 2016, 3:33 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Lav Jain, and Newton Alex.
> 
> 
> Bugs: AMBARI-15104
> https://issues.apache.org/jira/browse/AMBARI-15104
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update the description for the alert so that the user knows what to do if the 
> alert is triggered from the description on the alert page
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 
> 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43753/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested. Descriptions appears on the alerts page.
> 
> No additional unit tests required.
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 43753: Update description for HAWQ Sync standby alert

2016-02-19 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43753/#review119985
---


Ship it!




Ship It!

- jun aoki


On Feb. 19, 2016, 3:33 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43753/
> ---
> 
> (Updated Feb. 19, 2016, 3:33 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Lav Jain, and Newton Alex.
> 
> 
> Bugs: AMBARI-15104
> https://issues.apache.org/jira/browse/AMBARI-15104
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update the description for the alert so that the user knows what to do if the 
> alert is triggered from the description on the alert page
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 
> 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43753/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested. Descriptions appears on the alerts page.
> 
> No additional unit tests required.
> 
> 
> Thanks,
> 
> Matt
> 
>



[jira] [Resolved] (AMBARI-15076) HAWQ standby host name not getting populated in warning msg

2016-02-19 Thread jun aoki (JIRA)

 [ 
https://issues.apache.org/jira/browse/AMBARI-15076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jun aoki resolved AMBARI-15076.
---
Resolution: Fixed

> HAWQ standby host name not getting populated in warning msg
> ---
>
> Key: AMBARI-15076
> URL: https://issues.apache.org/jira/browse/AMBARI-15076
> Project: Ambari
>  Issue Type: Bug
>  Components: stacks
>Reporter: Newton Alex
>Assignee: Newton Alex
>Priority: Minor
> Attachments: AMBARI-15076-branch2-2.patch, AMBARI-15076-trunk.patch, 
> Screen Shot 2016-02-18 at 2.35.48 PM.png
>
>
> In the Add HAWQ Standby Wizard, the confirmation msg doesn't replace the 
> hostname correctly. It appears as below:
> "Please confirm if the data dir... on Standby Master {1}..."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15076) HAWQ standby host name not getting populated in warning msg

2016-02-19 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154986#comment-15154986
 ] 

jun aoki commented on AMBARI-15076:
---

Committed to trunk
1ba6722d14f54910d73f4b4d8decbb9a3cb1c5d6
Committed to branch-2.2
49b6ae660b80bab5a296361409b0cb869bc77cfb

> HAWQ standby host name not getting populated in warning msg
> ---
>
> Key: AMBARI-15076
> URL: https://issues.apache.org/jira/browse/AMBARI-15076
> Project: Ambari
>  Issue Type: Bug
>  Components: stacks
>Reporter: Newton Alex
>Assignee: Newton Alex
>Priority: Minor
> Attachments: AMBARI-15076-branch2-2.patch, AMBARI-15076-trunk.patch, 
> Screen Shot 2016-02-18 at 2.35.48 PM.png
>
>
> In the Add HAWQ Standby Wizard, the confirmation msg doesn't replace the 
> hostname correctly. It appears as below:
> "Please confirm if the data dir... on Standby Master {1}..."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15083) Add Stack Advisor validations for hawq_global_rm_type property in HAWQ

2016-02-19 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154904#comment-15154904
 ] 

jun aoki commented on AMBARI-15083:
---

committed to trunk
32173ff17642b8cdca6f0fdd5318683b633bb681
committed to branch-2.2
f848cb3c680eba8134d707f4c43eb5cd1a6c6a6a

> Add Stack Advisor validations for hawq_global_rm_type property in HAWQ
> --
>
> Key: AMBARI-15083
> URL: https://issues.apache.org/jira/browse/AMBARI-15083
> Project: Ambari
>  Issue Type: Improvement
>  Components: stacks
>Affects Versions: trunk, 2.2.0
>Reporter: bhuvnesh chaudhary
>Assignee: bhuvnesh chaudhary
>Priority: Minor
> Fix For: trunk, 2.2.0
>
> Attachments: AMBARI-15083-branch-2.2.patch, AMBARI-15083.patch
>
>
> Add Stack Advisor validations for hawq_global_rm_type property in HAWQ. The 
> below 2 cases must be covered:
> #1:
> If YARN service is not installed, and hawq_global_rm_type is set as yarn, a 
> validation error should be thrown
> #2:
> If YARN service is installed, and hawq_gloabl_rm_type is set as yarn, no 
> validation error should be thrown



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43752: Move HAWQ system password to General Accordion tab

2016-02-19 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43752/#review119966
---


Ship it!




Ship It!

- jun aoki


On Feb. 19, 2016, 3:34 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43752/
> ---
> 
> (Updated Feb. 19, 2016, 3:34 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Lav Jain, and Newton Alex.
> 
> 
> Bugs: AMBARI-15103
> https://issues.apache.org/jira/browse/AMBARI-15103
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The password is currently under Advanced hawq-env. Move it to General section.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml
>  e3a97fd 
>   ambari-web/app/data/HDP2.3/site_properties.js c5fb525 
> 
> Diff: https://reviews.apache.org/r/43752/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> No additional unit tests required.
> 
> Unit tests passed on Ambari-web:
>   10412 tests complete (10 seconds)
>   121 tests pending
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 39.598 s
> [INFO] Finished at: 2016-02-18T19:17:30-08:00
> [INFO] Final Memory: 12M/311M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>



[jira] [Commented] (AMBARI-15060) Ambari should show no. of HAWQ segments live on main dashboard

2016-02-19 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154792#comment-15154792
 ] 

jun aoki commented on AMBARI-15060:
---

Committed to branch-2.2
9e57671b4f52aad620dba5ecbc3188dffdece4e1
Committed to trunk
82d944017eb90c380e374e6f7aeddab6004c6a84


> Ambari should show no. of HAWQ segments live on main dashboard
> --
>
> Key: AMBARI-15060
> URL: https://issues.apache.org/jira/browse/AMBARI-15060
> Project: Ambari
>  Issue Type: Story
>  Components: ambari-web
>Reporter: Matt
>Assignee: Matt
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-15060-branch-2.2-orig.patch, 
> AMBARI-15060-branch-2.2-v1.patch, AMBARI-15060-branch-2.2-v2.patch, 
> AMBARI-15060-trunk-orig.patch, AMBARI-15060-trunk-v1.patch, 
> AMBARI-15060-trunk-v2.patch, green.png, orange.png, red.png
>
>
> The no. of HAWQ segments alive should be displayed as a widget on Ambari's 
> main dashboard.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43748: Add alerts for HAWQ components status

2016-02-18 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119778
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json (line 
24)
<https://reviews.apache.org/r/43748/#comment181131>

Is type OK for checking a process is down?
I don't know if a type called "PROCESS", but otherwise maybe "SCRIPT" to 
issue same ps with process names?


- jun aoki


On Feb. 19, 2016, 12:59 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> ---
> 
> (Updated Feb. 19, 2016, 12:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, 
> Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit 
> Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
> https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch introduces alerts for HAWQ components based on PORT. The below 
> components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 
> 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> ---
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>



Re: Review Request 43731: Add Stack Advisor validations for hawq_global_rm_type property in HAWQ

2016-02-18 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43731/#review119771
---


Ship it!




Ship It!

- jun aoki


On Feb. 18, 2016, 7:23 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43731/
> ---
> 
> (Updated Feb. 18, 2016, 7:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, 
> Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-15083
> https://issues.apache.org/jira/browse/AMBARI-15083
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Stack Advisor validations for hawq_global_rm_type property in HAWQ. The 
> below 2 cases must be covered:
> # 1: If YARN service is not installed, and hawq_global_rm_type is set as 
> yarn, a validation error should be thrown
> # 2: If YARN service is installed, and hawq_gloabl_rm_type is set as yarn, no 
> validation error should be thrown
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> b354378 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 545a2b5 
> 
> Diff: https://reviews.apache.org/r/43731/diff/
> 
> 
> Testing
> ---
> 
> yes, manual and stack advisor test run.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>



[jira] [Commented] (AMBARI-15067) Add custom commands for HAWQ to run check and clear cache

2016-02-18 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153516#comment-15153516
 ] 

jun aoki commented on AMBARI-15067:
---

Committed to branch-2.2
1e93caf4f7ba92f0190433303b7920eaf54c57eb
Committed to trunk
0941997b0f68f1044242354c9f3f0f4b3a476c7d


> Add custom commands for HAWQ to run check and clear cache
> -
>
> Key: AMBARI-15067
> URL: https://issues.apache.org/jira/browse/AMBARI-15067
> Project: Ambari
>  Issue Type: Story
>  Components: ambari-web, stacks
>Reporter: Matt
>Assignee: Matt
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-15067-branch-2.2-orig.patch, 
> AMBARI-15067-trunk-orig.patch
>
>
> A HAWQ user should be able to run hawq check and clear HDFS Metadata cache 
> from the Ambari UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43703: Add custom commands for HAWQ to run check and clear cache

2016-02-18 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43703/#review119766
---


Ship it!




Ship It!

- jun aoki


On Feb. 18, 2016, 10:17 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43703/
> ---
> 
> (Updated Feb. 18, 2016, 10:17 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh 
> chaudhary, Goutam Tadi, jun aoki, Lav Jain, and Newton Alex.
> 
> 
> Bugs: AMBARI-15067
> https://issues.apache.org/jira/browse/AMBARI-15067
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A HAWQ user should be able to run hawq check and clear HDFS Metadata cache 
> from the Ambari UI.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 
> 942b250 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
>  9fdbde5 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  d2f9ad0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  c5f891b 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
>  74c9813 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/templates/hawq-hosts.j2
>  e093375 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/templates/slaves.j2
>  0435b3e 
>   ambari-web/app/messages.js a7e4ff3 
>   ambari-web/app/models/host_component.js 5d919b9 
>   ambari-web/app/utils/helper.js 8ac754a 
>   ambari-web/app/views/main/service/item.js 145b64b 
> 
> Diff: https://reviews.apache.org/r/43703/diff/
> 
> 
> Testing
> ---
> 
> Tested functionality manually.
> 
> No additional unit tests were added.
> 
> Ambari Web unit tests passed:
> 10409 tests complete (9 seconds)
>   121 tests pending
> 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 46.008 s
> [INFO] Finished at: 2016-02-18T02:14:25-08:00
> [INFO] Final Memory: 12M/311M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 43740: Hostname substitution in HAWQ add standby popup

2016-02-18 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43740/#review119765
---


Ship it!




Ship It!

- jun aoki


On Feb. 18, 2016, 10:45 p.m., Newton Alex wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43740/
> ---
> 
> (Updated Feb. 18, 2016, 10:45 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15076
> https://issues.apache.org/jira/browse/AMBARI-15076
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hostname substitution in HAWQ add standby popup
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/admin/highAvailability/hawq/addStandby/step3_controller.js
>  513a519 
> 
> Diff: https://reviews.apache.org/r/43740/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Newton Alex
> 
>



Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-18 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43663/#review119764
---




ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-cleanup-data.sh
 (line 22)
<https://reviews.apache.org/r/43663/#comment181121>

Could this be InlineTemplate?



ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-populate-data.sh
 (line 22)
<https://reviews.apache.org/r/43663/#comment181122>

Could this be InlineTemplate?



ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py
 (line 27)
<https://reviews.apache.org/r/43663/#comment181118>

will be nice if we have more consistent naming ?
e.g.
```
hbase_populate_data_script = "hbase-populate-data.sh"
hbase_cleanup_data_script = "hbase-cleanup-data.sh"
```



ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
 (line 105)
<https://reviews.apache.org/r/43663/#comment181119>

this is nice!



ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
 (line 238)
<https://reviews.apache.org/r/43663/#comment181120>

how about 
```

def __create_hbase_script(self, script_name)
  File("{0}/{1}".format(params.exec_tmp_dir, script_name),
 content=StaticFile("{0}".format(script_name)),
 mode=0755)

...

# caller
__create_hbase_script(pxf_constants.hbase_load_script)
__create_hbase_script(pxf_constants.hbase_cleanup_script)
```



ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
 (line 298)
<https://reviews.apache.org/r/43663/#comment181123>

At this point, it is guaranteed the table does not exist?


- jun aoki


On Feb. 17, 2016, 10:46 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43663/
> ---
> 
> (Updated Feb. 17, 2016, 10:46 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, 
> Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15061
> https://issues.apache.org/jira/browse/AMBARI-15061
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During PXF service check, in order to execute hbase / hive command, we do 
> initialize the shell everytime (hbase shell / hive) and then run the command. 
> Initializing the shell takes time and we do that around 3-4 times which 
> consumes majority of the time.
> We should initialize the shell once, and execute the commands using a file 
> instead of doing individually.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-cleanup-data.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-populate-data.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py
>  b3e85e4 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py
>  9d93a38 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
>  21b7c5d 
> 
> Diff: https://reviews.apache.org/r/43663/diff/
> 
> 
> Testing
> ---
> 
> yes. manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>



Re: Review Request 43644: Ambari should show no. of HAWQ segments live on main dashboard

2016-02-18 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43644/#review119750
---




ambari-web/app/models/service/hawq.js (line 1)
<https://reviews.apache.org/r/43644/#comment181091>

Is this required?



ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js (line 51)
<https://reviews.apache.org/r/43644/#comment181105>

This may not be used as it is about started vs total?


- jun aoki


On Feb. 17, 2016, 7:57 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43644/
> ---
> 
> (Updated Feb. 17, 2016, 7:57 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh 
> chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, and 
> Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-15060
> https://issues.apache.org/jira/browse/AMBARI-15060
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The no. of HAWQ segments alive should be displayed as a widget on Ambari's 
> main dashboard.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/assets/test/tests.js 25c3f43 
>   ambari-web/app/mappers/components_state_mapper.js 0f2b627 
>   ambari-web/app/messages.js a7e4ff3 
>   ambari-web/app/models.js b607bee 
>   ambari-web/app/models/service/hawq.js PRE-CREATION 
>   ambari-web/app/views.js 7e461f9 
>   ambari-web/app/views/main/dashboard/widgets.js b99d881 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js 
> PRE-CREATION 
>   ambari-web/test/views/main/dashboard/widgets/hawqsegment_live_test.js 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43644/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested. Images attached to JIRA.
> 
> Added additional unit test.
>   10416 tests complete (10 seconds)
>   121 tests pending
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 53.572 s
> [INFO] Finished at: 2016-02-17T11:55:29-08:00
> [INFO] Final Memory: 12M/311M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>



[jira] [Commented] (AMBARI-15082) HAWQ fails to install

2016-02-18 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15152851#comment-15152851
 ] 

jun aoki commented on AMBARI-15082:
---

[~mithmatt], thank you for finding the root cause and your quick fix!

Committed to trunk
7da4706a33a03ce38739b5d5f0c11c4b2fc4bb94
Committed to branch-2.2
620daba7cad89af4d2531ca74baddcf334502379

> HAWQ fails to install
> -
>
> Key: AMBARI-15082
> URL: https://issues.apache.org/jira/browse/AMBARI-15082
> Project: Ambari
>  Issue Type: Bug
>  Components: stacks
>Reporter: Matt
>Assignee: Matt
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-15082-branch-2.2-orig.patch, 
> AMBARI-15082-trunk-orig.patch
>
>
> HAWQ fails to install while deploying HAWQ service.
> {code}stderr: 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py",
>  line 77, in 
> HawqMaster().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 219, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py",
>  line 40, in install
> self.configure(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py",
>  line 46, in configure
> master_helper.configure_master()
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/master_helper.py",
>  line 60, in configure_master
> common.setup_common_configurations()
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/common.py",
>  line 72, in setup_common_configurations
> configuration_attributes=params.config_attrs['hdfs-client'])
> TypeError: __new__() takes at least 2 non-keyword arguments (1 given)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43705: HAWQ fails to install

2016-02-18 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43705/#review119672
---


Ship it!




Ship It!

- jun aoki


On Feb. 18, 2016, 3:26 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43705/
> ---
> 
> (Updated Feb. 18, 2016, 3:26 a.m.)
> 
> 
> Review request for Ambari, jun aoki and Lav Jain.
> 
> 
> Bugs: AMBARI-15082
> https://issues.apache.org/jira/browse/AMBARI-15082
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ fails to install while deploying HAWQ service.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  b5353e8 
> 
> Diff: https://reviews.apache.org/r/43705/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Matt
> 
>



[jira] [Commented] (AMBARI-14881) Enable/Disable Custom Commands on Host Component page

2016-02-17 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151639#comment-15151639
 ] 

jun aoki commented on AMBARI-14881:
---

Committed to trunk
dcebcca60d47743176519b7758b86505263e39a7

> Enable/Disable Custom Commands on Host Component page
> -
>
> Key: AMBARI-14881
> URL: https://issues.apache.org/jira/browse/AMBARI-14881
> Project: Ambari
>  Issue Type: Improvement
>  Components: ambari-web
>Affects Versions: 2.2.2
>Reporter: Goutam Tadi
>Assignee: Goutam Tadi
>Priority: Trivial
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-14881-branch-2.2-v2.patch, 
> AMBARI-14881-branch-2.2-v3.patch, AMBARI-14881-branch-2.2.patch, 
> AMBARI-14881-trunk.patch
>
>
> Ambari should disable custom commands on Host Component page when they are 
> set to disabled on Services page or on some condition.
> Example: Ambari should disable (grey out) the HAWQ Immediate Stop Cluster 
> option if HAWQ Master is in stopped state as there is no use of triggering 
> this command when master is already stopped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15019) Refactor HAWQ common.py after moving config substitution to UI

2016-02-17 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151336#comment-15151336
 ] 

jun aoki commented on AMBARI-15019:
---

Committed to branch-2.2
bb314bd35549d1fa79534041146e2033d795514a
Committed to trunk
b15c0f3d7432dbd6b6ce6c678b6cc2884a73c68b

> Refactor HAWQ common.py after moving config substitution to UI
> --
>
> Key: AMBARI-15019
> URL: https://issues.apache.org/jira/browse/AMBARI-15019
> Project: Ambari
>  Issue Type: Improvement
>Affects Versions: trunk, 2.2.0
>Reporter: Lav Jain
>Assignee: Lav Jain
>Priority: Minor
> Fix For: 2.3.0, 2.2.2
>
> Attachments: AMBARI-15019.branch22.patch, AMBARI-15019.patch
>
>
> Use partial function for XmlConfig. Functions __update_yarn_client, 
> __update_hawq_site, __update_hdfs_client may no longer be required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-14997) Update gpcheck.cnf to hawq_check.cnf file as recommended in HAWQ documentation

2016-02-17 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151260#comment-15151260
 ] 

jun aoki commented on AMBARI-14997:
---

Committed to branch-2.2
52b72ac5988cfa51eb4bf4fa7094f942b0cf7fb4

> Update gpcheck.cnf to hawq_check.cnf file as recommended in HAWQ documentation
> --
>
> Key: AMBARI-14997
> URL: https://issues.apache.org/jira/browse/AMBARI-14997
> Project: Ambari
>  Issue Type: Improvement
>Affects Versions: trunk
>Reporter: bhuvnesh chaudhary
>Assignee: bhuvnesh chaudhary
>Priority: Minor
> Fix For: trunk, 2.2.0
>
> Attachments: AMBARI-14997-1.patch, AMBARI-14997-2.patch, 
> AMBARI-14997-branch-2.2.patch, AMBARI-14997.patch
>
>
> Populate hawq_check.cnf instead of gpcheck.cnf. Hawq documentation suggests 
> using hawq_check.cnf config file to run hawq check on clusters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15001) Hdfs keytab for hawq service check on secured cluster

2016-02-17 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151113#comment-15151113
 ] 

jun aoki commented on AMBARI-15001:
---

Committed to trunk
0ea255c59005eda4d5684230460d8b1c647c78f7
Committed to branch-2.2
7517c4dad6a71278921037db9af404311ca35347

> Hdfs keytab for hawq service check on secured cluster
> -
>
> Key: AMBARI-15001
> URL: https://issues.apache.org/jira/browse/AMBARI-15001
> Project: Ambari
>  Issue Type: Bug
>    Reporter: jun aoki
>    Assignee: jun aoki
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-15001-branch-2.2-v2.patch, 
> AMBARI-15001-branch-2.2.patch
>
>
> This is to add hdfs keytab for hawq nodes.
> Currently HAWQ's service check fails due to data clean up after service check 
> is completed and causes a false negative.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15001) Hdfs keytab for hawq service check on secured cluster

2016-02-17 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151104#comment-15151104
 ] 

jun aoki commented on AMBARI-15001:
---

Got a Ship It on reviewboard. (Thx [~rlevas] for your educational feedback!)
Committing. 

> Hdfs keytab for hawq service check on secured cluster
> -
>
> Key: AMBARI-15001
> URL: https://issues.apache.org/jira/browse/AMBARI-15001
> Project: Ambari
>  Issue Type: Bug
>    Reporter: jun aoki
>    Assignee: jun aoki
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-15001-branch-2.2-v2.patch, 
> AMBARI-15001-branch-2.2.patch
>
>
> This is to add hdfs keytab for hawq nodes.
> Currently HAWQ's service check fails due to data clean up after service check 
> is completed and causes a false negative.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-15020) HAWQ service check fails when PXF is present due to cmd syntax error

2016-02-17 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151003#comment-15151003
 ] 

jun aoki commented on AMBARI-15020:
---

Committed to branch-2.2
750e4e45d6ea5bf4e73129475c1f3d67f10cf662
Committed to trunk
c282a0eec34809290be93a4c08f6686948ff896f

> HAWQ service check fails when PXF is present due to cmd syntax error
> 
>
> Key: AMBARI-15020
> URL: https://issues.apache.org/jira/browse/AMBARI-15020
> Project: Ambari
>  Issue Type: Bug
>Affects Versions: trunk, 2.2.0
>Reporter: bhuvnesh chaudhary
>Assignee: bhuvnesh chaudhary
> Fix For: trunk, 2.2.0
>
> Attachments: AMBARI-15020.patch
>
>
> HAWQ service check fails due to syntax error caused due to different number 
> of backslashes required while executing psql command on master host or doing 
> ssh from segment to master and then executing psql command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43549: HAWQ service check fails when PXF is present due to cmd syntax error

2016-02-17 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43549/#review119511
---


Ship it!




Ship It!

- jun aoki


On Feb. 14, 2016, 12:18 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43549/
> ---
> 
> (Updated Feb. 14, 2016, 12:18 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, 
> Jayush Luniya, Oleksandr Diachenko, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15020
> https://issues.apache.org/jira/browse/AMBARI-15020
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ service check fails with syntax error caused due to different number of 
> backslashes required while executing psql command on master host or doing ssh 
> from segment to master and then executing psql command.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  51a38d1 
> 
> Diff: https://reviews.apache.org/r/43549/diff/
> 
> 
> Testing
> ---
> 
> yes, manual
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>



[jira] [Commented] (AMBARI-15001) Hdfs keytab for hawq service check on secured cluster

2016-02-16 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-15001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149731#comment-15149731
 ] 

jun aoki commented on AMBARI-15001:
---

[~rlevas] I uploaded another patch to the reviewboard. Let me know if I missed 
anything, or could you give Ship It?

> Hdfs keytab for hawq service check on secured cluster
> -
>
> Key: AMBARI-15001
> URL: https://issues.apache.org/jira/browse/AMBARI-15001
> Project: Ambari
>  Issue Type: Bug
>    Reporter: jun aoki
>    Assignee: jun aoki
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-15001-branch-2.2-v2.patch, 
> AMBARI-15001-branch-2.2.patch
>
>
> This is to add hdfs keytab for hawq nodes.
> Currently HAWQ's service check fails due to data clean up after service check 
> is completed and causes a false negative.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43465: Hdfs keytab for hawq service check on secured cluster

2016-02-16 Thread jun aoki

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43465/
---

(Updated Feb. 17, 2016, 2:34 a.m.)


Review request for Ambari.


Bugs: AMBARI-15001
https://issues.apache.org/jira/browse/AMBARI-15001


Repository: ambari


Description
---

This is to add hdfs keytab for hawq nodes.
Currently HAWQ's service check fails due to data clean up after service check 
is completed and causes a false negative.


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/kerberos.json 
cc11c15 

Diff: https://reviews.apache.org/r/43465/diff/


Testing
---

Locally teted.


Thanks,

jun aoki



[jira] [Updated] (AMBARI-15001) Hdfs keytab for hawq service check on secured cluster

2016-02-16 Thread jun aoki (JIRA)

 [ 
https://issues.apache.org/jira/browse/AMBARI-15001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jun aoki updated AMBARI-15001:
--
Attachment: AMBARI-15001-branch-2.2-v2.patch

> Hdfs keytab for hawq service check on secured cluster
> -
>
> Key: AMBARI-15001
> URL: https://issues.apache.org/jira/browse/AMBARI-15001
> Project: Ambari
>  Issue Type: Bug
>    Reporter: jun aoki
>    Assignee: jun aoki
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-15001-branch-2.2-v2.patch, 
> AMBARI-15001-branch-2.2.patch
>
>
> This is to add hdfs keytab for hawq nodes.
> Currently HAWQ's service check fails due to data clean up after service check 
> is completed and causes a false negative.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-14987) assign_master_component.js does not show recommendations while adding master component for a service which is already installed

2016-02-16 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-14987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149597#comment-15149597
 ] 

jun aoki commented on AMBARI-14987:
---

Committed to branch-2.2
94129bbc8289647c3e1b9e0d21d84f5d156d13ca
Committed to trunk
e4800e1c97709e8218989080fceb0df406e744ea

> assign_master_component.js does not show recommendations while adding master 
> component for a service which is already installed
> ---
>
> Key: AMBARI-14987
> URL: https://issues.apache.org/jira/browse/AMBARI-14987
> Project: Ambari
>  Issue Type: Bug
>  Components: ambari-web
>Reporter: Matt
>Assignee: Matt
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-14987-branch-2.2-v1.patch, 
> AMBARI-14987-branch-2.2-v2.patch, AMBARI-14987-branch-2.2.patch, 
> AMBARI-14987-trunk-v1.patch, AMBARI-14987-trunk-v2.patch, 
> AMBARI-14987-trunk-v3.patch, AMBARI-14987-trunk.patch
>
>
> On the assign masters page for the wizard, recommendations are not shown for 
> a master component that is being added for an installed service.
> This happens while adding HAWQSTANDBY to the cluster using the 'Add 
> HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the 
> cluster). 
> The fix might also solve the issue where there is a installed service and the 
> upgrade of the service includes installing a new master component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-14987) assign_master_component.js does not show recommendations while adding master component for a service which is already installed

2016-02-16 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-14987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149596#comment-15149596
 ] 

jun aoki commented on AMBARI-14987:
---

+1

> assign_master_component.js does not show recommendations while adding master 
> component for a service which is already installed
> ---
>
> Key: AMBARI-14987
> URL: https://issues.apache.org/jira/browse/AMBARI-14987
> Project: Ambari
>  Issue Type: Bug
>  Components: ambari-web
>Reporter: Matt
>Assignee: Matt
>Priority: Minor
> Fix For: trunk, 2.2.2
>
> Attachments: AMBARI-14987-branch-2.2-v1.patch, 
> AMBARI-14987-branch-2.2-v2.patch, AMBARI-14987-branch-2.2.patch, 
> AMBARI-14987-trunk-v1.patch, AMBARI-14987-trunk-v2.patch, 
> AMBARI-14987-trunk-v3.patch, AMBARI-14987-trunk.patch
>
>
> On the assign masters page for the wizard, recommendations are not shown for 
> a master component that is being added for an installed service.
> This happens while adding HAWQSTANDBY to the cluster using the 'Add 
> HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the 
> cluster). 
> The fix might also solve the issue where there is a installed service and the 
> upgrade of the service includes installing a new master component



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMBARI-14997) Update gpcheck.cnf to hawq_check.cnf file as recommended in HAWQ documentation

2016-02-16 Thread jun aoki (JIRA)

[ 
https://issues.apache.org/jira/browse/AMBARI-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149574#comment-15149574
 ] 

jun aoki commented on AMBARI-14997:
---

Committed to trunk
529c588add78ce4d0a82542144ba94f89c80299e

> Update gpcheck.cnf to hawq_check.cnf file as recommended in HAWQ documentation
> --
>
> Key: AMBARI-14997
> URL: https://issues.apache.org/jira/browse/AMBARI-14997
> Project: Ambari
>  Issue Type: Improvement
>Affects Versions: trunk
>Reporter: bhuvnesh chaudhary
>Assignee: bhuvnesh chaudhary
>Priority: Minor
> Fix For: trunk, 2.2.0
>
> Attachments: AMBARI-14997-1.patch, AMBARI-14997-2.patch, 
> AMBARI-14997.patch
>
>
> Populate hawq_check.cnf instead of gpcheck.cnf. Hawq documentation suggests 
> using hawq_check.cnf config file to run hawq check on clusters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


  1   2   3   4   5   6   7   8   >